type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/comments/143814015","pull_request_review_id":68381813,"id":143814015,"diff_hunk":"@@ -16,14 +18,17 @@ def __init__(self, alignment, dataType='CODON', home=os.getcwd()):\n \n self.aln_File = str(self.home / Path(alignment))\n outDir = self.home / Path('IQTREE')\n- Path.mkdir(outDir, exist_ok=True)\n+ makedirectory(outDir)\n copy(self.aln_File, str(outDir))\n os.chdir(str(outDir))\n self.iqtree_best_tree(alignment, dataType)\n copy(self.tree_file, str(self.home / Path(self.gene + '_iqtree.nwk')))\n \n def iqtree_best_tree(self, alignment, dataType):\n-\n- IQTCmd = IQTreeCommandline(alignment=alignment, dataType=dataType)\n- print(IQTCmd)\n- subprocess.check_call([str(IQTCmd)], stderr=subprocess.STDOUT, shell=True)\n+ \"\"\"Generate and save the best tree from IQTree by importing the filtered\n+ alignment.\n+ \"\"\"\n+ iqtree_cline = IQTreeCommandline(alignment=alignment,\n+ dataType=dataType)\n+ print(iqtree_cline)\n+ check_call([str(iqtree_cline)], stderr=STDOUT, shell=True)","path":"Datasnakes/Orthologs/Phylogenetics/IQTree/best_tree.py","position":41,"original_position":41,"commit_id":"222708cb3039937836b0bb367d0a57959d51f50b","original_commit_id":"222708cb3039937836b0bb367d0a57959d51f50b","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [subprocess call with shell=True identified, security issue.](https://www.codacy.com/app/datasnakes/Datasnakes-Scripts/pullRequest?prid=979871)","created_at":"2017-10-10T18:28:33Z","updated_at":"2017-10-10T18:28:33Z","html_url":"https://github.com/datasnakes/Datasnakes-Scripts/pull/99#discussion_r143814015","pull_request_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/99","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/comments/143814015"},"html":{"href":"https://github.com/datasnakes/Datasnakes-Scripts/pull/99#discussion_r143814015"},"pull_request":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/99","id":145766147,"html_url":"https://github.com/datasnakes/Datasnakes-Scripts/pull/99","diff_url":"https://github.com/datasnakes/Datasnakes-Scripts/pull/99.diff","patch_url":"https://github.com/datasnakes/Datasnakes-Scripts/pull/99.patch","issue_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues/99","number":99,"state":"open","locked":false,"title":"Improvement of Phylogenetics Module","user":{"login":"sdhutchins","id":20976111,"avatar_url":"https://avatars2.githubusercontent.com/u/20976111?v=4","gravatar_id":"","url":"https://api.github.com/users/sdhutchins","html_url":"https://github.com/sdhutchins","followers_url":"https://api.github.com/users/sdhutchins/followers","following_url":"https://api.github.com/users/sdhutchins/following{/other_user}","gists_url":"https://api.github.com/users/sdhutchins/gists{/gist_id}","starred_url":"https://api.github.com/users/sdhutchins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdhutchins/subscriptions","organizations_url":"https://api.github.com/users/sdhutchins/orgs","repos_url":"https://api.github.com/users/sdhutchins/repos","events_url":"https://api.github.com/users/sdhutchins/events{/privacy}","received_events_url":"https://api.github.com/users/sdhutchins/received_events","type":"User","site_admin":false},"body":"### Features Added:\r\n- Improvement of ETE3PAML class\r\n- Added `csvtolist` function which turns a column of a csv file to a list using pandas\r\n- Added README skeletons for PAML, IQTREE, and PhyML\r\n- Completely reworked Phylip class\r\n- Improved readability of FilteredTree class\r\n\r\nAddresses #35 ","created_at":"2017-10-10T18:24:08Z","updated_at":"2017-10-10T18:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e82ccefedfdaec075660e262ab708fd6423bd5b6","assignee":{"login":"grabear","id":20953530,"avatar_url":"https://avatars0.githubusercontent.com/u/20953530?v=4","gravatar_id":"","url":"https://api.github.com/users/grabear","html_url":"https://github.com/grabear","followers_url":"https://api.github.com/users/grabear/followers","following_url":"https://api.github.com/users/grabear/following{/other_user}","gists_url":"https://api.github.com/users/grabear/gists{/gist_id}","starred_url":"https://api.github.com/users/grabear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabear/subscriptions","organizations_url":"https://api.github.com/users/grabear/orgs","repos_url":"https://api.github.com/users/grabear/repos","events_url":"https://api.github.com/users/grabear/events{/privacy}","received_events_url":"https://api.github.com/users/grabear/received_events","type":"User","site_admin":false},"assignees":[{"login":"grabear","id":20953530,"avatar_url":"https://avatars0.githubusercontent.com/u/20953530?v=4","gravatar_id":"","url":"https://api.github.com/users/grabear","html_url":"https://github.com/grabear","followers_url":"https://api.github.com/users/grabear/followers","following_url":"https://api.github.com/users/grabear/following{/other_user}","gists_url":"https://api.github.com/users/grabear/gists{/gist_id}","starred_url":"https://api.github.com/users/grabear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabear/subscriptions","organizations_url":"https://api.github.com/users/grabear/orgs","repos_url":"https://api.github.com/users/grabear/repos","events_url":"https://api.github.com/users/grabear/events{/privacy}","received_events_url":"https://api.github.com/users/grabear/received_events","type":"User","site_admin":false},{"login":"sdhutchins","id":20976111,"avatar_url":"https://avatars2.githubusercontent.com/u/20976111?v=4","gravatar_id":"","url":"https://api.github.com/users/sdhutchins","html_url":"https://github.com/sdhutchins","followers_url":"https://api.github.com/users/sdhutchins/followers","following_url":"https://api.github.com/users/sdhutchins/following{/other_user}","gists_url":"https://api.github.com/users/sdhutchins/gists{/gist_id}","starred_url":"https://api.github.com/users/sdhutchins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdhutchins/subscriptions","organizations_url":"https://api.github.com/users/sdhutchins/orgs","repos_url":"https://api.github.com/users/sdhutchins/repos","events_url":"https://api.github.com/users/sdhutchins/events{/privacy}","received_events_url":"https://api.github.com/users/sdhutchins/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"grabear","id":20953530,"avatar_url":"https://avatars0.githubusercontent.com/u/20953530?v=4","gravatar_id":"","url":"https://api.github.com/users/grabear","html_url":"https://github.com/grabear","followers_url":"https://api.github.com/users/grabear/followers","following_url":"https://api.github.com/users/grabear/following{/other_user}","gists_url":"https://api.github.com/users/grabear/gists{/gist_id}","starred_url":"https://api.github.com/users/grabear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabear/subscriptions","organizations_url":"https://api.github.com/users/grabear/orgs","repos_url":"https://api.github.com/users/grabear/repos","events_url":"https://api.github.com/users/grabear/events{/privacy}","received_events_url":"https://api.github.com/users/grabear/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/milestones/4","html_url":"https://github.com/datasnakes/Datasnakes-Scripts/milestone/4","labels_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/milestones/4/labels","id":2770482,"number":4,"title":"Official project release","description":"Officially release the python package in all places.","creator":{"login":"sdhutchins","id":20976111,"avatar_url":"https://avatars2.githubusercontent.com/u/20976111?v=4","gravatar_id":"","url":"https://api.github.com/users/sdhutchins","html_url":"https://github.com/sdhutchins","followers_url":"https://api.github.com/users/sdhutchins/followers","following_url":"https://api.github.com/users/sdhutchins/following{/other_user}","gists_url":"https://api.github.com/users/sdhutchins/gists{/gist_id}","starred_url":"https://api.github.com/users/sdhutchins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdhutchins/subscriptions","organizations_url":"https://api.github.com/users/sdhutchins/orgs","repos_url":"https://api.github.com/users/sdhutchins/repos","events_url":"https://api.github.com/users/sdhutchins/events{/privacy}","received_events_url":"https://api.github.com/users/sdhutchins/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":12,"state":"open","created_at":"2017-09-15T23:17:07Z","updated_at":"2017-10-10T18:24:20Z","due_on":"2017-10-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/99/commits","review_comments_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/99/comments","review_comment_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues/99/comments","statuses_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/statuses/222708cb3039937836b0bb367d0a57959d51f50b","head":{"label":"datasnakes:phylogenetics-patch","ref":"phylogenetics-patch","sha":"222708cb3039937836b0bb367d0a57959d51f50b","user":{"login":"datasnakes","id":27606353,"avatar_url":"https://avatars2.githubusercontent.com/u/27606353?v=4","gravatar_id":"","url":"https://api.github.com/users/datasnakes","html_url":"https://github.com/datasnakes","followers_url":"https://api.github.com/users/datasnakes/followers","following_url":"https://api.github.com/users/datasnakes/following{/other_user}","gists_url":"https://api.github.com/users/datasnakes/gists{/gist_id}","starred_url":"https://api.github.com/users/datasnakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datasnakes/subscriptions","organizations_url":"https://api.github.com/users/datasnakes/orgs","repos_url":"https://api.github.com/users/datasnakes/repos","events_url":"https://api.github.com/users/datasnakes/events{/privacy}","received_events_url":"https://api.github.com/users/datasnakes/received_events","type":"Organization","site_admin":false},"repo":{"id":88282824,"name":"Datasnakes-Scripts","full_name":"datasnakes/Datasnakes-Scripts","owner":{"login":"datasnakes","id":27606353,"avatar_url":"https://avatars2.githubusercontent.com/u/27606353?v=4","gravatar_id":"","url":"https://api.github.com/users/datasnakes","html_url":"https://github.com/datasnakes","followers_url":"https://api.github.com/users/datasnakes/followers","following_url":"https://api.github.com/users/datasnakes/following{/other_user}","gists_url":"https://api.github.com/users/datasnakes/gists{/gist_id}","starred_url":"https://api.github.com/users/datasnakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datasnakes/subscriptions","organizations_url":"https://api.github.com/users/datasnakes/orgs","repos_url":"https://api.github.com/users/datasnakes/repos","events_url":"https://api.github.com/users/datasnakes/events{/privacy}","received_events_url":"https://api.github.com/users/datasnakes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datasnakes/Datasnakes-Scripts","description":"This package is a collection of the modules which aids in the analysis and visualization of orthologs-related bioinformatics projects.","fork":false,"url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts","forks_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/forks","keys_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/teams","hooks_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/hooks","issue_events_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues/events{/number}","events_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/events","assignees_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/assignees{/user}","branches_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/branches{/branch}","tags_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/tags","blobs_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/languages","stargazers_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/stargazers","contributors_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/contributors","subscribers_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/subscribers","subscription_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/subscription","commits_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/contents/{+path}","compare_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/merges","archive_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/downloads","issues_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues{/number}","pulls_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/labels{/name}","releases_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/releases{/id}","deployments_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/deployments","created_at":"2017-04-14T16:11:14Z","updated_at":"2017-09-18T23:59:47Z","pushed_at":"2017-10-10T18:27:41Z","git_url":"git://github.com/datasnakes/Datasnakes-Scripts.git","ssh_url":"[email protected]:datasnakes/Datasnakes-Scripts.git","clone_url":"https://github.com/datasnakes/Datasnakes-Scripts.git","svn_url":"https://github.com/datasnakes/Datasnakes-Scripts","homepage":"","size":38375,"stargazers_count":8,"watchers_count":8,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":27,"forks":1,"open_issues":27,"watchers":8,"default_branch":"master"}},"base":{"label":"datasnakes:dev-master","ref":"dev-master","sha":"fa37532d1ea1a35cf6f2ba81209dc357f88f3326","user":{"login":"datasnakes","id":27606353,"avatar_url":"https://avatars2.githubusercontent.com/u/27606353?v=4","gravatar_id":"","url":"https://api.github.com/users/datasnakes","html_url":"https://github.com/datasnakes","followers_url":"https://api.github.com/users/datasnakes/followers","following_url":"https://api.github.com/users/datasnakes/following{/other_user}","gists_url":"https://api.github.com/users/datasnakes/gists{/gist_id}","starred_url":"https://api.github.com/users/datasnakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datasnakes/subscriptions","organizations_url":"https://api.github.com/users/datasnakes/orgs","repos_url":"https://api.github.com/users/datasnakes/repos","events_url":"https://api.github.com/users/datasnakes/events{/privacy}","received_events_url":"https://api.github.com/users/datasnakes/received_events","type":"Organization","site_admin":false},"repo":{"id":88282824,"name":"Datasnakes-Scripts","full_name":"datasnakes/Datasnakes-Scripts","owner":{"login":"datasnakes","id":27606353,"avatar_url":"https://avatars2.githubusercontent.com/u/27606353?v=4","gravatar_id":"","url":"https://api.github.com/users/datasnakes","html_url":"https://github.com/datasnakes","followers_url":"https://api.github.com/users/datasnakes/followers","following_url":"https://api.github.com/users/datasnakes/following{/other_user}","gists_url":"https://api.github.com/users/datasnakes/gists{/gist_id}","starred_url":"https://api.github.com/users/datasnakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datasnakes/subscriptions","organizations_url":"https://api.github.com/users/datasnakes/orgs","repos_url":"https://api.github.com/users/datasnakes/repos","events_url":"https://api.github.com/users/datasnakes/events{/privacy}","received_events_url":"https://api.github.com/users/datasnakes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datasnakes/Datasnakes-Scripts","description":"This package is a collection of the modules which aids in the analysis and visualization of orthologs-related bioinformatics projects.","fork":false,"url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts","forks_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/forks","keys_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/teams","hooks_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/hooks","issue_events_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues/events{/number}","events_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/events","assignees_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/assignees{/user}","branches_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/branches{/branch}","tags_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/tags","blobs_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/languages","stargazers_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/stargazers","contributors_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/contributors","subscribers_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/subscribers","subscription_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/subscription","commits_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/contents/{+path}","compare_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/merges","archive_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/downloads","issues_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues{/number}","pulls_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/labels{/name}","releases_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/releases{/id}","deployments_url":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/deployments","created_at":"2017-04-14T16:11:14Z","updated_at":"2017-09-18T23:59:47Z","pushed_at":"2017-10-10T18:27:41Z","git_url":"git://github.com/datasnakes/Datasnakes-Scripts.git","ssh_url":"[email protected]:datasnakes/Datasnakes-Scripts.git","clone_url":"https://github.com/datasnakes/Datasnakes-Scripts.git","svn_url":"https://github.com/datasnakes/Datasnakes-Scripts","homepage":"","size":38375,"stargazers_count":8,"watchers_count":8,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":27,"forks":1,"open_issues":27,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/99"},"html":{"href":"https://github.com/datasnakes/Datasnakes-Scripts/pull/99"},"issue":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues/99"},"comments":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/datasnakes/Datasnakes-Scripts/statuses/222708cb3039937836b0bb367d0a57959d51f50b"}},"author_association":"COLLABORATOR"}} | {
"id": 88282824,
"name": "datasnakes/Datasnakes-Scripts",
"url": "https://api.github.com/repos/datasnakes/Datasnakes-Scripts"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 27606353,
"login": "datasnakes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27606353?",
"url": "https://api.github.com/orgs/datasnakes"
} | 2017-10-10T18:28:33 | 6698453682 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/155345830","pull_request_review_id":81650643,"id":155345830,"diff_hunk":"@@ -15,103 +16,109 @@\n namespace Envoy {\n namespace Tracing {\n \n-LightStepSpan::LightStepSpan(lightstep::Span& span, lightstep::Tracer& tracer)\n- : span_(span), tracer_(tracer) {}\n+namespace {\n+class LightStepLogger : Logger::Loggable<Logger::Id::tracing> {\n+public:\n+ void operator()(lightstep::LogLevel level, opentracing::string_view message) const {\n+ const fmt::StringRef fmt_message{message.data(), message.size()};\n+ switch (level) {\n+ case lightstep::LogLevel::debug:\n+ ENVOY_LOG(debug, \"{}\", fmt_message);\n+ break;\n+ case lightstep::LogLevel::info:\n+ ENVOY_LOG(info, \"{}\", fmt_message);\n+ break;\n+ default:\n+ ENVOY_LOG(warn, \"{}\", fmt_message);\n+ break;\n+ }\n+ }\n+};\n+} // namespace\n+\n+LightStepDriver::LightStepTransporter::LightStepTransporter(LightStepDriver& driver)\n+ : driver_(driver) {}\n+\n+void LightStepDriver::LightStepTransporter::Send(const Protobuf::Message& request,\n+ Protobuf::Message& response,\n+ lightstep::AsyncTransporter::Callback& callback) {\n+ // TODO(rnburn): Update to use Grpc::AsyncClient when it supports abstract message classes.\n+ active_callback_ = &callback;\n+ active_response_ = &response;\n+\n+ Http::MessagePtr message =\n+ Grpc::Common::prepareHeaders(driver_.cluster()->name(), lightstep::CollectorServiceFullName(),\n+ lightstep::CollectorMethodName());\n+ message->body() = Grpc::Common::serializeBody(request);\n+\n+ const uint64_t timeout =\n+ driver_.runtime().snapshot().getInteger(\"tracing.lightstep.request_timeout\", 5000U);\n+ driver_.clusterManager()\n+ .httpAsyncClientForCluster(driver_.cluster()->name())\n+ .send(std::move(message), *this, std::chrono::milliseconds(timeout));\n+}\n \n-void LightStepSpan::finishSpan() { span_.Finish(); }\n+void LightStepDriver::LightStepTransporter::onSuccess(Http::MessagePtr&& response) {\n+ try {\n+ Grpc::Common::validateResponse(*response);\n \n-void LightStepSpan::setOperation(const std::string& operation) {\n- span_.SetOperationName(operation);\n+ Grpc::Common::chargeStat(*driver_.cluster(), lightstep::CollectorServiceFullName(),\n+ lightstep::CollectorMethodName(), true);\n+ // http://www.grpc.io/docs/guides/wire.html\n+ // First 5 bytes contain the message header.\n+ response->body()->drain(5);\n+ Buffer::ZeroCopyInputStreamImpl stream{std::move(response->body())};\n+ if (!active_response_->ParseFromZeroCopyStream(&stream)) {\n+ throw EnvoyException(\"Failed to parse LightStep collector response\");\n+ }\n+ active_callback_->OnSuccess();\n+ } catch (const Grpc::Exception& ex) {\n+ Grpc::Common::chargeStat(*driver_.cluster(), lightstep::CollectorServiceFullName(),\n+ lightstep::CollectorMethodName(), false);\n+ active_callback_->OnFailure(std::make_error_code(std::errc::network_down));\n+ }\n }\n \n-void LightStepSpan::setTag(const std::string& name, const std::string& value) {\n- span_.SetTag(name, value);\n+void LightStepDriver::LightStepTransporter::onFailure(Http::AsyncClient::FailureReason) {\n+ Grpc::Common::chargeStat(*driver_.cluster(), lightstep::CollectorServiceFullName(),\n+ lightstep::CollectorMethodName(), false);\n+ active_callback_->OnFailure(std::make_error_code(std::errc::network_down));\n }\n \n-void LightStepSpan::injectContext(Http::HeaderMap& request_headers) {\n- lightstep::BinaryCarrier ctx;\n- tracer_.Inject(context(), lightstep::CarrierFormat::LightStepBinaryCarrier,\n- lightstep::ProtoWriter(&ctx));\n- const std::string current_span_context = ctx.SerializeAsString();\n- request_headers.insertOtSpanContext().value(\n- Base64::encode(current_span_context.c_str(), current_span_context.length()));\n-}\n+LightStepDriver::LightStepMetricsObserver::LightStepMetricsObserver(LightStepDriver& driver)\n+ : driver_(driver) {}\n \n-SpanPtr LightStepSpan::spawnChild(const Config&, const std::string& name, SystemTime start_time) {\n- lightstep::Span ls_span = tracer_.StartSpan(\n- name, {lightstep::ChildOf(span_.context()), lightstep::StartTimestamp(start_time)});\n- return SpanPtr{new LightStepSpan(ls_span, tracer_)};\n+void LightStepDriver::LightStepMetricsObserver::OnSpansSent(int num_spans) {\n+ driver_.tracerStats().spans_sent_.add(num_spans);\n }\n \n-LightStepRecorder::LightStepRecorder(const lightstep::TracerImpl& tracer, LightStepDriver& driver,\n- Event::Dispatcher& dispatcher)\n- : builder_(tracer), driver_(driver) {\n+LightStepDriver::TlsLightStepTracer::TlsLightStepTracer(\n+ std::shared_ptr<lightstep::LightStepTracer>&& tracer, LightStepDriver& driver,","path":"source/common/tracing/lightstep_tracer_impl.cc","position":null,"original_position":111,"commit_id":"861e87c90b0f28785ed36f255026c40cfd500840","original_commit_id":"5d62c5185c6cb988ac9c6611aea054eaa5aeee78","user":{"login":"rnburn","id":1923871,"avatar_url":"https://avatars3.githubusercontent.com/u/1923871?v=4","gravatar_id":"","url":"https://api.github.com/users/rnburn","html_url":"https://github.com/rnburn","followers_url":"https://api.github.com/users/rnburn/followers","following_url":"https://api.github.com/users/rnburn/following{/other_user}","gists_url":"https://api.github.com/users/rnburn/gists{/gist_id}","starred_url":"https://api.github.com/users/rnburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnburn/subscriptions","organizations_url":"https://api.github.com/users/rnburn/orgs","repos_url":"https://api.github.com/users/rnburn/repos","events_url":"https://api.github.com/users/rnburn/events{/privacy}","received_events_url":"https://api.github.com/users/rnburn/received_events","type":"User","site_admin":false},"body":"Changed.","created_at":"2017-12-06T20:03:40Z","updated_at":"2017-12-06T20:03:40Z","html_url":"https://github.com/envoyproxy/envoy/pull/2017#discussion_r155345830","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2017","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/155345830"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2017#discussion_r155345830"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2017"}},"in_reply_to_id":155093874},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2017","id":151273036,"html_url":"https://github.com/envoyproxy/envoy/pull/2017","diff_url":"https://github.com/envoyproxy/envoy/pull/2017.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/2017.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2017","number":2017,"state":"open","locked":false,"title":"tracing: Support OpenTracing API","user":{"login":"rnburn","id":1923871,"avatar_url":"https://avatars3.githubusercontent.com/u/1923871?v=4","gravatar_id":"","url":"https://api.github.com/users/rnburn","html_url":"https://github.com/rnburn","followers_url":"https://api.github.com/users/rnburn/followers","following_url":"https://api.github.com/users/rnburn/following{/other_user}","gists_url":"https://api.github.com/users/rnburn/gists{/gist_id}","starred_url":"https://api.github.com/users/rnburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnburn/subscriptions","organizations_url":"https://api.github.com/users/rnburn/orgs","repos_url":"https://api.github.com/users/rnburn/repos","events_url":"https://api.github.com/users/rnburn/events{/privacy}","received_events_url":"https://api.github.com/users/rnburn/received_events","type":"User","site_admin":false},"body":"*Description*:\r\n* Adds an `OpenTracingDriver` that implements `Tracing::Driver` using the OpenTracing API. With it, an OpenTracing-compliant tracer can be added into envoy by deriving from `OpenTracingDrive`r and implementing the abstract `tracer` method, reducing the amount of code that must be maintained for each tracer implementation.\r\n* Updates the LightStep tracer to use `OpenTracingDriver`. The latest version of LightStep provides a customizable transport, so the code that implements an Envoy-specific Reporter and interacts directly with LightStep's protobuf classes was removed in order to bind less tightly to the LightStep code.\r\n* Adds a new tracing log category and logs warning when injection/extraction fails, or the LightStep tracer generates an error message.\r\n\r\nA few notes:\r\n* As a step towards standardizing on a single OpenTracing header for propagation, we added optional support for single-header propagation to the LightStep tracer and switched Envoy to use that instead of its custom propagation code. Currently, LightStep's single-header propagation uses the same header as Envoy; though the expectation is that it will change to match whatever standard format emerges in the future.\r\n* Envoy still supports custom single-header propagation (though in a more OpenTracing-friendly manner). Individual tracers can be configured to use either Envoy's single-header propagation format, the tracer's native propagation format, or both via the tracer's driver class.\r\n* To support more efficient span context propagation when a tracer's headers belong to Envoy's special O(1) list, I added the function `Http::HeaderMap::lookup` that takes a header key and uses the `StaticLookupTable` to find the header's entry. If the tracer's headers don't belong to the O(1) list, propagation will still work; but the tracer will have to iterate through all of the entries.\r\n* The bazel build sets CC to point to a C++ compiler. This causes cmake to fail since it expects CC to be a C compiler. Even though C compilers aren't used, I added `CC=\"\"` to `opentracing.genrule_cmd` and `lightstep.genrule_cmd` in order to work around the problem. (Not sure if there's a better solution.)\r\n\r\nFixes #1196 \r\n\r\n*Risk Level*: High\r\n\r\n*Testing*:\r\n* Built and ran automated tests both locally on OSX and through the docker ci targets.\r\n* Set up a small tracing [example](https://github.com/rnburn/envoy-lightstep-example) and confirmed that traces are reported to LightStep.\r\n* Added additional unit tests for the new `Http::HeaderMap::lookup` function.\r\n\r\n","created_at":"2017-11-08T01:37:03Z","updated_at":"2017-12-06T20:03:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46bf4e75d7eda6b0dca3324b280768cffcaef7d0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/envoyproxy/envoy/milestones/5","html_url":"https://github.com/envoyproxy/envoy/milestone/5","labels_url":"https://api.github.com/repos/envoyproxy/envoy/milestones/5/labels","id":2884977,"number":5,"title":"1.6.0","description":"","creator":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":1,"state":"open","created_at":"2017-11-03T00:16:48Z","updated_at":"2017-12-04T21:03:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2017/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2017/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2017/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/861e87c90b0f28785ed36f255026c40cfd500840","head":{"label":"rnburn:master","ref":"master","sha":"861e87c90b0f28785ed36f255026c40cfd500840","user":{"login":"rnburn","id":1923871,"avatar_url":"https://avatars3.githubusercontent.com/u/1923871?v=4","gravatar_id":"","url":"https://api.github.com/users/rnburn","html_url":"https://github.com/rnburn","followers_url":"https://api.github.com/users/rnburn/followers","following_url":"https://api.github.com/users/rnburn/following{/other_user}","gists_url":"https://api.github.com/users/rnburn/gists{/gist_id}","starred_url":"https://api.github.com/users/rnburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnburn/subscriptions","organizations_url":"https://api.github.com/users/rnburn/orgs","repos_url":"https://api.github.com/users/rnburn/repos","events_url":"https://api.github.com/users/rnburn/events{/privacy}","received_events_url":"https://api.github.com/users/rnburn/received_events","type":"User","site_admin":false},"repo":{"id":101424264,"name":"envoy","full_name":"rnburn/envoy","owner":{"login":"rnburn","id":1923871,"avatar_url":"https://avatars3.githubusercontent.com/u/1923871?v=4","gravatar_id":"","url":"https://api.github.com/users/rnburn","html_url":"https://github.com/rnburn","followers_url":"https://api.github.com/users/rnburn/followers","following_url":"https://api.github.com/users/rnburn/following{/other_user}","gists_url":"https://api.github.com/users/rnburn/gists{/gist_id}","starred_url":"https://api.github.com/users/rnburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnburn/subscriptions","organizations_url":"https://api.github.com/users/rnburn/orgs","repos_url":"https://api.github.com/users/rnburn/repos","events_url":"https://api.github.com/users/rnburn/events{/privacy}","received_events_url":"https://api.github.com/users/rnburn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rnburn/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/rnburn/envoy","forks_url":"https://api.github.com/repos/rnburn/envoy/forks","keys_url":"https://api.github.com/repos/rnburn/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rnburn/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rnburn/envoy/teams","hooks_url":"https://api.github.com/repos/rnburn/envoy/hooks","issue_events_url":"https://api.github.com/repos/rnburn/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/rnburn/envoy/events","assignees_url":"https://api.github.com/repos/rnburn/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/rnburn/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/rnburn/envoy/tags","blobs_url":"https://api.github.com/repos/rnburn/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rnburn/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rnburn/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rnburn/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rnburn/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/rnburn/envoy/languages","stargazers_url":"https://api.github.com/repos/rnburn/envoy/stargazers","contributors_url":"https://api.github.com/repos/rnburn/envoy/contributors","subscribers_url":"https://api.github.com/repos/rnburn/envoy/subscribers","subscription_url":"https://api.github.com/repos/rnburn/envoy/subscription","commits_url":"https://api.github.com/repos/rnburn/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rnburn/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rnburn/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rnburn/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rnburn/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/rnburn/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rnburn/envoy/merges","archive_url":"https://api.github.com/repos/rnburn/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rnburn/envoy/downloads","issues_url":"https://api.github.com/repos/rnburn/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/rnburn/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/rnburn/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/rnburn/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rnburn/envoy/labels{/name}","releases_url":"https://api.github.com/repos/rnburn/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/rnburn/envoy/deployments","created_at":"2017-08-25T16:54:25Z","updated_at":"2017-09-07T02:33:20Z","pushed_at":"2017-12-06T20:01:40Z","git_url":"git://github.com/rnburn/envoy.git","ssh_url":"[email protected]:rnburn/envoy.git","clone_url":"https://github.com/rnburn/envoy.git","svn_url":"https://github.com/rnburn/envoy","homepage":"https://lyft.github.io/envoy","size":40893,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"5d27c1d738fa6f6e3da77a0c3ce7faefb7104c01","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2017-12-06T16:43:36Z","pushed_at":"2017-12-06T20:01:41Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"[email protected]:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://envoyproxy.github.io/","size":51124,"stargazers_count":3185,"watchers_count":3185,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":371,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":371,"open_issues":182,"watchers":3185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2017"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2017"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2017"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2017/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2017/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2017/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/861e87c90b0f28785ed36f255026c40cfd500840"}},"author_association":"NONE"}} | {
"id": 65214191,
"name": "envoyproxy/envoy",
"url": "https://api.github.com/repos/envoyproxy/envoy"
} | {
"id": 1923871,
"login": "rnburn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1923871?",
"url": "https://api.github.com/users/rnburn"
} | {
"id": 30125649,
"login": "envoyproxy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30125649?",
"url": "https://api.github.com/orgs/envoyproxy"
} | 2017-12-06T20:03:40 | 6953178301 | {"actor":{"display_login":"rnburn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/comments/146095926","pull_request_review_id":70998153,"id":146095926,"diff_hunk":"@@ -1,47 +1,74 @@\n # Britecharts React\n-Britecharts-react is a React wrapper for the [Britecharts charting library.][britecharts]\n+Britecharts-react is a [React][react] wrapper for the [Britecharts][britecharts] charting library.\n \n-## Why\n-Britecharts is a D3 based, high level charting library that allows users to create stunning data visualizations with little work. [React][react] is one of the most popular User Interface libraries that allows to create apps by composing small components in an intuitive way. Both libraries take control of the DOM, so how can we make them work together in a fluid way?\n \n-Britecharts-react proposes a way of integrating Britecharts and React that promotes a *clear separation of concerns* between the libraries and aims for an *easy and effortless maintenance* of the charts.\n-\n-## Approach\n-The React and D3 integration can be done at different levels, leaning more one side or another. We don’t want to get too specific on the details, as for that there is [slides][d3-react] and [a recording][d3-react-video] that explain the different approaches.\n+## Usage\n+Britecharts-React components are used just like any other stateless React component. You will pass in some props and it would render a chart:\n \n-For this project, we have chosen the approach called ‘Mapping Lifecycle methods’ based on [Nicholas Hery's article][integration-article]. You can see some [code example here][integration-article-code]. \n+```\n+<TooltipComponent>\n+ <StackedAreaComponent\n+ data={stackedAreaData.with2Sources()}\n+ width={600}\n+ height={400}\n+ />\n+</TooltipComponent>","path":"README.md","position":23,"original_position":23,"commit_id":"6ffa7ca6be0865238631c35c0396d1e9e17b1687","original_commit_id":"6ffa7ca6be0865238631c35c0396d1e9e17b1687","user":{"login":"Golodhros","id":190833,"avatar_url":"https://avatars3.githubusercontent.com/u/190833?v=4","gravatar_id":"","url":"https://api.github.com/users/Golodhros","html_url":"https://github.com/Golodhros","followers_url":"https://api.github.com/users/Golodhros/followers","following_url":"https://api.github.com/users/Golodhros/following{/other_user}","gists_url":"https://api.github.com/users/Golodhros/gists{/gist_id}","starred_url":"https://api.github.com/users/Golodhros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golodhros/subscriptions","organizations_url":"https://api.github.com/users/Golodhros/orgs","repos_url":"https://api.github.com/users/Golodhros/repos","events_url":"https://api.github.com/users/Golodhros/events{/privacy}","received_events_url":"https://api.github.com/users/Golodhros/received_events","type":"User","site_admin":false},"body":"True!","created_at":"2017-10-21T03:57:11Z","updated_at":"2017-10-21T03:57:11Z","html_url":"https://github.com/eventbrite/britecharts-react/pull/22#discussion_r146095926","pull_request_url":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/comments/146095926"},"html":{"href":"https://github.com/eventbrite/britecharts-react/pull/22#discussion_r146095926"},"pull_request":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/22"}},"in_reply_to_id":146089747},"pull_request":{"url":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/22","id":147910097,"html_url":"https://github.com/eventbrite/britecharts-react/pull/22","diff_url":"https://github.com/eventbrite/britecharts-react/pull/22.diff","patch_url":"https://github.com/eventbrite/britecharts-react/pull/22.patch","issue_url":"https://api.github.com/repos/eventbrite/britecharts-react/issues/22","number":22,"state":"open","locked":false,"title":"Updating Readme","user":{"login":"Golodhros","id":190833,"avatar_url":"https://avatars3.githubusercontent.com/u/190833?v=4","gravatar_id":"","url":"https://api.github.com/users/Golodhros","html_url":"https://github.com/Golodhros","followers_url":"https://api.github.com/users/Golodhros/followers","following_url":"https://api.github.com/users/Golodhros/following{/other_user}","gists_url":"https://api.github.com/users/Golodhros/gists{/gist_id}","starred_url":"https://api.github.com/users/Golodhros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golodhros/subscriptions","organizations_url":"https://api.github.com/users/Golodhros/orgs","repos_url":"https://api.github.com/users/Golodhros/repos","events_url":"https://api.github.com/users/Golodhros/events{/privacy}","received_events_url":"https://api.github.com/users/Golodhros/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nUpdated readme, moving write-up about the approach to the topics document.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nWe want to get ready to promote Britecharts-React, and that means we need good documentation.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n","created_at":"2017-10-20T22:48:25Z","updated_at":"2017-10-21T03:57:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49ed800e2557e0afaeebb58191528d72590801d4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/22/commits","review_comments_url":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/22/comments","review_comment_url":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eventbrite/britecharts-react/issues/22/comments","statuses_url":"https://api.github.com/repos/eventbrite/britecharts-react/statuses/6ffa7ca6be0865238631c35c0396d1e9e17b1687","head":{"label":"Golodhros:mi-readme","ref":"mi-readme","sha":"6ffa7ca6be0865238631c35c0396d1e9e17b1687","user":{"login":"Golodhros","id":190833,"avatar_url":"https://avatars3.githubusercontent.com/u/190833?v=4","gravatar_id":"","url":"https://api.github.com/users/Golodhros","html_url":"https://github.com/Golodhros","followers_url":"https://api.github.com/users/Golodhros/followers","following_url":"https://api.github.com/users/Golodhros/following{/other_user}","gists_url":"https://api.github.com/users/Golodhros/gists{/gist_id}","starred_url":"https://api.github.com/users/Golodhros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golodhros/subscriptions","organizations_url":"https://api.github.com/users/Golodhros/orgs","repos_url":"https://api.github.com/users/Golodhros/repos","events_url":"https://api.github.com/users/Golodhros/events{/privacy}","received_events_url":"https://api.github.com/users/Golodhros/received_events","type":"User","site_admin":false},"repo":{"id":100320053,"name":"britecharts-react","full_name":"Golodhros/britecharts-react","owner":{"login":"Golodhros","id":190833,"avatar_url":"https://avatars3.githubusercontent.com/u/190833?v=4","gravatar_id":"","url":"https://api.github.com/users/Golodhros","html_url":"https://github.com/Golodhros","followers_url":"https://api.github.com/users/Golodhros/followers","following_url":"https://api.github.com/users/Golodhros/following{/other_user}","gists_url":"https://api.github.com/users/Golodhros/gists{/gist_id}","starred_url":"https://api.github.com/users/Golodhros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golodhros/subscriptions","organizations_url":"https://api.github.com/users/Golodhros/orgs","repos_url":"https://api.github.com/users/Golodhros/repos","events_url":"https://api.github.com/users/Golodhros/events{/privacy}","received_events_url":"https://api.github.com/users/Golodhros/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Golodhros/britecharts-react","description":"React wrapper for britecharts","fork":true,"url":"https://api.github.com/repos/Golodhros/britecharts-react","forks_url":"https://api.github.com/repos/Golodhros/britecharts-react/forks","keys_url":"https://api.github.com/repos/Golodhros/britecharts-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Golodhros/britecharts-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Golodhros/britecharts-react/teams","hooks_url":"https://api.github.com/repos/Golodhros/britecharts-react/hooks","issue_events_url":"https://api.github.com/repos/Golodhros/britecharts-react/issues/events{/number}","events_url":"https://api.github.com/repos/Golodhros/britecharts-react/events","assignees_url":"https://api.github.com/repos/Golodhros/britecharts-react/assignees{/user}","branches_url":"https://api.github.com/repos/Golodhros/britecharts-react/branches{/branch}","tags_url":"https://api.github.com/repos/Golodhros/britecharts-react/tags","blobs_url":"https://api.github.com/repos/Golodhros/britecharts-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Golodhros/britecharts-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Golodhros/britecharts-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Golodhros/britecharts-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Golodhros/britecharts-react/statuses/{sha}","languages_url":"https://api.github.com/repos/Golodhros/britecharts-react/languages","stargazers_url":"https://api.github.com/repos/Golodhros/britecharts-react/stargazers","contributors_url":"https://api.github.com/repos/Golodhros/britecharts-react/contributors","subscribers_url":"https://api.github.com/repos/Golodhros/britecharts-react/subscribers","subscription_url":"https://api.github.com/repos/Golodhros/britecharts-react/subscription","commits_url":"https://api.github.com/repos/Golodhros/britecharts-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Golodhros/britecharts-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Golodhros/britecharts-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Golodhros/britecharts-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Golodhros/britecharts-react/contents/{+path}","compare_url":"https://api.github.com/repos/Golodhros/britecharts-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Golodhros/britecharts-react/merges","archive_url":"https://api.github.com/repos/Golodhros/britecharts-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Golodhros/britecharts-react/downloads","issues_url":"https://api.github.com/repos/Golodhros/britecharts-react/issues{/number}","pulls_url":"https://api.github.com/repos/Golodhros/britecharts-react/pulls{/number}","milestones_url":"https://api.github.com/repos/Golodhros/britecharts-react/milestones{/number}","notifications_url":"https://api.github.com/repos/Golodhros/britecharts-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Golodhros/britecharts-react/labels{/name}","releases_url":"https://api.github.com/repos/Golodhros/britecharts-react/releases{/id}","deployments_url":"https://api.github.com/repos/Golodhros/britecharts-react/deployments","created_at":"2017-08-15T00:10:25Z","updated_at":"2017-09-18T22:21:07Z","pushed_at":"2017-10-20T22:47:15Z","git_url":"git://github.com/Golodhros/britecharts-react.git","ssh_url":"[email protected]:Golodhros/britecharts-react.git","clone_url":"https://github.com/Golodhros/britecharts-react.git","svn_url":"https://github.com/Golodhros/britecharts-react","homepage":null,"size":1881,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eventbrite:master","ref":"master","sha":"94d2d598b53f27781decbf5c707281c5dfa554dc","user":{"login":"eventbrite","id":369874,"avatar_url":"https://avatars2.githubusercontent.com/u/369874?v=4","gravatar_id":"","url":"https://api.github.com/users/eventbrite","html_url":"https://github.com/eventbrite","followers_url":"https://api.github.com/users/eventbrite/followers","following_url":"https://api.github.com/users/eventbrite/following{/other_user}","gists_url":"https://api.github.com/users/eventbrite/gists{/gist_id}","starred_url":"https://api.github.com/users/eventbrite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventbrite/subscriptions","organizations_url":"https://api.github.com/users/eventbrite/orgs","repos_url":"https://api.github.com/users/eventbrite/repos","events_url":"https://api.github.com/users/eventbrite/events{/privacy}","received_events_url":"https://api.github.com/users/eventbrite/received_events","type":"Organization","site_admin":false},"repo":{"id":100057683,"name":"britecharts-react","full_name":"eventbrite/britecharts-react","owner":{"login":"eventbrite","id":369874,"avatar_url":"https://avatars2.githubusercontent.com/u/369874?v=4","gravatar_id":"","url":"https://api.github.com/users/eventbrite","html_url":"https://github.com/eventbrite","followers_url":"https://api.github.com/users/eventbrite/followers","following_url":"https://api.github.com/users/eventbrite/following{/other_user}","gists_url":"https://api.github.com/users/eventbrite/gists{/gist_id}","starred_url":"https://api.github.com/users/eventbrite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventbrite/subscriptions","organizations_url":"https://api.github.com/users/eventbrite/orgs","repos_url":"https://api.github.com/users/eventbrite/repos","events_url":"https://api.github.com/users/eventbrite/events{/privacy}","received_events_url":"https://api.github.com/users/eventbrite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventbrite/britecharts-react","description":"React wrapper for britecharts","fork":false,"url":"https://api.github.com/repos/eventbrite/britecharts-react","forks_url":"https://api.github.com/repos/eventbrite/britecharts-react/forks","keys_url":"https://api.github.com/repos/eventbrite/britecharts-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventbrite/britecharts-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventbrite/britecharts-react/teams","hooks_url":"https://api.github.com/repos/eventbrite/britecharts-react/hooks","issue_events_url":"https://api.github.com/repos/eventbrite/britecharts-react/issues/events{/number}","events_url":"https://api.github.com/repos/eventbrite/britecharts-react/events","assignees_url":"https://api.github.com/repos/eventbrite/britecharts-react/assignees{/user}","branches_url":"https://api.github.com/repos/eventbrite/britecharts-react/branches{/branch}","tags_url":"https://api.github.com/repos/eventbrite/britecharts-react/tags","blobs_url":"https://api.github.com/repos/eventbrite/britecharts-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventbrite/britecharts-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventbrite/britecharts-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventbrite/britecharts-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventbrite/britecharts-react/statuses/{sha}","languages_url":"https://api.github.com/repos/eventbrite/britecharts-react/languages","stargazers_url":"https://api.github.com/repos/eventbrite/britecharts-react/stargazers","contributors_url":"https://api.github.com/repos/eventbrite/britecharts-react/contributors","subscribers_url":"https://api.github.com/repos/eventbrite/britecharts-react/subscribers","subscription_url":"https://api.github.com/repos/eventbrite/britecharts-react/subscription","commits_url":"https://api.github.com/repos/eventbrite/britecharts-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventbrite/britecharts-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventbrite/britecharts-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventbrite/britecharts-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventbrite/britecharts-react/contents/{+path}","compare_url":"https://api.github.com/repos/eventbrite/britecharts-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventbrite/britecharts-react/merges","archive_url":"https://api.github.com/repos/eventbrite/britecharts-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventbrite/britecharts-react/downloads","issues_url":"https://api.github.com/repos/eventbrite/britecharts-react/issues{/number}","pulls_url":"https://api.github.com/repos/eventbrite/britecharts-react/pulls{/number}","milestones_url":"https://api.github.com/repos/eventbrite/britecharts-react/milestones{/number}","notifications_url":"https://api.github.com/repos/eventbrite/britecharts-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventbrite/britecharts-react/labels{/name}","releases_url":"https://api.github.com/repos/eventbrite/britecharts-react/releases{/id}","deployments_url":"https://api.github.com/repos/eventbrite/britecharts-react/deployments","created_at":"2017-08-11T17:53:12Z","updated_at":"2017-10-16T22:20:17Z","pushed_at":"2017-10-21T00:37:23Z","git_url":"git://github.com/eventbrite/britecharts-react.git","ssh_url":"[email protected]:eventbrite/britecharts-react.git","clone_url":"https://github.com/eventbrite/britecharts-react.git","svn_url":"https://github.com/eventbrite/britecharts-react","homepage":null,"size":1864,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/22"},"html":{"href":"https://github.com/eventbrite/britecharts-react/pull/22"},"issue":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/issues/22"},"comments":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/eventbrite/britecharts-react/statuses/6ffa7ca6be0865238631c35c0396d1e9e17b1687"}},"author_association":"CONTRIBUTOR"}} | {
"id": 100057683,
"name": "eventbrite/britecharts-react",
"url": "https://api.github.com/repos/eventbrite/britecharts-react"
} | {
"id": 190833,
"login": "Golodhros",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/190833?",
"url": "https://api.github.com/users/Golodhros"
} | {
"id": 369874,
"login": "eventbrite",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/369874?",
"url": "https://api.github.com/orgs/eventbrite"
} | 2017-10-21T03:57:11 | 6746555308 | {"actor":{"display_login":"Golodhros"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/comments/156546285","pull_request_review_id":83041324,"id":156546285,"diff_hunk":"@@ -0,0 +1,210 @@\n+//1a.\n+//a parameter is a preset variable designed to a function, an argument is the value passed through the function when it is called for\n+\n+//1b.\n+//return stops the execution of a function and returns whatever expression is designated. console.log logs the result of an expression in the console\n+\n+//1c.\n+//scope determines where in a script certain variables can be called for. variables declared globally are accessible anywhere. however, variables declared a function are local variables that are only available within that function \n+\n+\n+//2\n+\n+function checkPalindrome(str) {\n+\tlet cleanStr = str.split(' ').join('').toLowerCase();\n+\tlet arr = cleanStr.split('');\n+\tlet arrEnd = arr.length - 1;\n+\tfor (let i = 0; i <= Math.floor(arr.length / 2); i++) {\n+\t\tif (arr[i] !== arr[arrEnd - i]) {\n+\t\t\treturn false;\n+\t\t}\n+\t\telse {\n+\t\t\treturn true;\n+\t\t}\n+\t}\n+}\n+\n+// console.log(checkPalindrome('race car')); // true\n+// console.log(checkPalindrome('rAcE cAR')); // true\n+// console.log(checkPalindrome('james bardoLPh')); // false\n+// console.log(checkPalindrome('ab b c bb a')); // true\n+\n+\n+//3\n+\n+function sumDigits(num) {\n+\tlet numStr = num.toString();\n+\tlet arr = numStr.split('');\n+\tlet solution = 0;\n+\tfor (let i = 0; i <= arr.length - 1; i++) {\n+\t\tsolution += parseInt(arr[i], 10);\n+\t}\n+\treturn console.log(solution);\n+}\n+\n+// sumDigits(123); // 6\n+// sumDigits(55555); // 25\n+// sumDigits(2317497); // 33\n+\n+\n+//4\n+\n+function calculateSide(sideA, sideB) {\n+\tlet num = Math.pow(sideA, 2) + Math.pow(sideB, 2);\n+\tlet solution = Math.sqrt(num);\n+\treturn console.log(solution);\n+}\n+\n+// calculateSide(8,6); //10\n+// calculateSide(10,14); //17.204\n+// calculateSide(15, 20); //25\n+\n+\n+//5\n+\n+function sumArray(arr) {\n+\tlet sum = 0;\n+\tfor (let i = 0; i <= arr.length - 1; i++) {\n+\t\tsum += arr[i];\n+\t}\n+\treturn console.log(sum);\n+}\n+\n+// sumArray([1,3,7,10]); //21\n+// sumArray([0.2,6,-1,10]); //15.2\n+// sumArray([2,8,10,0,1,1,1]); //23\n+\n+\n+//6\n+\n+function checkPrime(num) {\n+\tlet isPrime = true;\n+\tlet numRoot = Math.sqrt(num);\n+\tfor (let i = 2; i <= numRoot; i++) {\n+\t\tif (Number.isInteger(num / i)) {\n+\t\t\tisPrime = false;\n+\t\t}\n+\t}\n+\treturn isPrime;\n+}\n+\n+// console.log(checkPrime(11)); //true\n+// console.log(checkPrime(9)); //false\n+// console.log(checkPrime(181)); //true\n+\n+function printPrimes(max) {\n+\tfor (let i = 2; i <= max; i++) {\n+\t\tif (checkPrime(i)) {\n+\t\t\tconsole.log(i+\" is a prime number.\");\n+\t\t}\n+\t\telse {\n+\t\t\tconsole.log(i+\" is not a prime number.\");\n+\t\t}\n+\t}\n+}\n+\n+\n+//7\n+\n+function insertDash(num) {\n+\tlet arr = num.toString().split('');\n+\tlet oddNum = false;\n+\tlet withDash = [];\n+\twithDash.push(arr[0]);\n+\tarr[0] % 2 === 1 ? oddNum = true : oddNum;\n+\tfor (let i = 1; i <= arr.length - 1; i++) {\n+\t\tif (oddNum === true && Number(arr[i]) % 2 !== 0) {\n+\t\t\twithDash.push(\"-\"+arr[i]);\n+\t\t\toddNum = true;\n+\t\t}\n+\t\telse if (oddNum === false && Number(arr[i]) % 2 !== 0) {\n+\t\t\twithDash.push(arr[i]);\n+\t\t\toddNum = true;\n+\t\t}\n+\t\telse {\n+\t\t\twithDash.push(arr[i]);\n+\t\t\toddNum = false;\n+\t\t}\n+\t}\n+\tlet solution = \"\";\n+\tfor (let i = 0; i < withDash.length - 1; i++) {\n+\t\tsolution += withDash[i];\n+\t}\n+\treturn console.log(solution);\n+}\n+\n+\n+// insertDash(213652781395); //21-3652781-3-9\n+\n+\n+\n+//HUNGRY\n+\n+//1\n+\n+function sumArrayTwo(arr) {\n+\tlet sum = arr.reduce(function(curr, next) {\n+\t\treturn curr + next;\n+\t}, 0)\n+\tconsole.log(sum);\n+}\n+\n+// sumArrayTwo([0,1,2,3,4,10]); //20\n+// sumArrayTwo([80,38,-9,0.4, 2]); //111.4\n+\n+\n+//2 \n+\n+function fancyPalindrome(str) {\n+\tlet cleanStr = str.split(' ').join('').toLowerCase().replace(/\\W/g, '');\n+\tlet arr = cleanStr.split('');\n+\tlet arrEnd = arr.length - 1;\n+\tfor (let i = 0; i <= Math.floor(arr.length / 2); i++) {\n+\t\tif (arr[i] !== arr[arrEnd - i]) {\n+\t\t\treturn false;\n+\t\t}\n+\t\telse {\n+\t\t\treturn true;\n+\t\t}\n+\t}\n+}\n+\n+// console.log(fancyPalindrome('@#^)#@%r@#(*&ace>:ca@##:r')); //true 'racecar'\n+","path":"js/main.js","position":173,"original_position":173,"commit_id":"b9e395f6da0e29c2c46ae491df992023ba095567","original_commit_id":"b9e395f6da0e29c2c46ae491df992023ba095567","user":{"login":"reubenayres","id":15374784,"avatar_url":"https://avatars2.githubusercontent.com/u/15374784?v=4","gravatar_id":"","url":"https://api.github.com/users/reubenayres","html_url":"https://github.com/reubenayres","followers_url":"https://api.github.com/users/reubenayres/followers","following_url":"https://api.github.com/users/reubenayres/following{/other_user}","gists_url":"https://api.github.com/users/reubenayres/gists{/gist_id}","starred_url":"https://api.github.com/users/reubenayres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reubenayres/subscriptions","organizations_url":"https://api.github.com/users/reubenayres/orgs","repos_url":"https://api.github.com/users/reubenayres/repos","events_url":"https://api.github.com/users/reubenayres/events{/privacy}","received_events_url":"https://api.github.com/users/reubenayres/received_events","type":"User","site_admin":false},"body":"This function does not work correctly as written.\r\n```javascript\r\nfancyPalindrome(\"helloh\")\r\n> true\r\n```","created_at":"2017-12-13T01:49:32Z","updated_at":"2017-12-13T01:49:32Z","html_url":"https://github.com/ga-chicago/wdi-10-hw3-functions/pull/1#discussion_r156546285","pull_request_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/comments/156546285"},"html":{"href":"https://github.com/ga-chicago/wdi-10-hw3-functions/pull/1#discussion_r156546285"},"pull_request":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/1","id":157455783,"html_url":"https://github.com/ga-chicago/wdi-10-hw3-functions/pull/1","diff_url":"https://github.com/ga-chicago/wdi-10-hw3-functions/pull/1.diff","patch_url":"https://github.com/ga-chicago/wdi-10-hw3-functions/pull/1.patch","issue_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/issues/1","number":1,"state":"open","locked":false,"title":"finished hw3 functions michael weber","user":{"login":"webermn15","id":32818398,"avatar_url":"https://avatars3.githubusercontent.com/u/32818398?v=4","gravatar_id":"","url":"https://api.github.com/users/webermn15","html_url":"https://github.com/webermn15","followers_url":"https://api.github.com/users/webermn15/followers","following_url":"https://api.github.com/users/webermn15/following{/other_user}","gists_url":"https://api.github.com/users/webermn15/gists{/gist_id}","starred_url":"https://api.github.com/users/webermn15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webermn15/subscriptions","organizations_url":"https://api.github.com/users/webermn15/orgs","repos_url":"https://api.github.com/users/webermn15/repos","events_url":"https://api.github.com/users/webermn15/events{/privacy}","received_events_url":"https://api.github.com/users/webermn15/received_events","type":"User","site_admin":false},"body":"& bonus Qs","created_at":"2017-12-10T23:18:34Z","updated_at":"2017-12-13T01:49:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da0e74f01595c53bf78c449e7246773519d30215","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/issues/1/comments","statuses_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/statuses/b9e395f6da0e29c2c46ae491df992023ba095567","head":{"label":"webermn15:master","ref":"master","sha":"b9e395f6da0e29c2c46ae491df992023ba095567","user":{"login":"webermn15","id":32818398,"avatar_url":"https://avatars3.githubusercontent.com/u/32818398?v=4","gravatar_id":"","url":"https://api.github.com/users/webermn15","html_url":"https://github.com/webermn15","followers_url":"https://api.github.com/users/webermn15/followers","following_url":"https://api.github.com/users/webermn15/following{/other_user}","gists_url":"https://api.github.com/users/webermn15/gists{/gist_id}","starred_url":"https://api.github.com/users/webermn15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webermn15/subscriptions","organizations_url":"https://api.github.com/users/webermn15/orgs","repos_url":"https://api.github.com/users/webermn15/repos","events_url":"https://api.github.com/users/webermn15/events{/privacy}","received_events_url":"https://api.github.com/users/webermn15/received_events","type":"User","site_admin":false},"repo":{"id":113729028,"name":"wdi-10-hw3-functions","full_name":"webermn15/wdi-10-hw3-functions","owner":{"login":"webermn15","id":32818398,"avatar_url":"https://avatars3.githubusercontent.com/u/32818398?v=4","gravatar_id":"","url":"https://api.github.com/users/webermn15","html_url":"https://github.com/webermn15","followers_url":"https://api.github.com/users/webermn15/followers","following_url":"https://api.github.com/users/webermn15/following{/other_user}","gists_url":"https://api.github.com/users/webermn15/gists{/gist_id}","starred_url":"https://api.github.com/users/webermn15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webermn15/subscriptions","organizations_url":"https://api.github.com/users/webermn15/orgs","repos_url":"https://api.github.com/users/webermn15/repos","events_url":"https://api.github.com/users/webermn15/events{/privacy}","received_events_url":"https://api.github.com/users/webermn15/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/webermn15/wdi-10-hw3-functions","description":null,"fork":true,"url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions","forks_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/forks","keys_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/teams","hooks_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/hooks","issue_events_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/issues/events{/number}","events_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/events","assignees_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/assignees{/user}","branches_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/branches{/branch}","tags_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/tags","blobs_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/git/refs{/sha}","trees_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/statuses/{sha}","languages_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/languages","stargazers_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/stargazers","contributors_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/contributors","subscribers_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/subscribers","subscription_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/subscription","commits_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/commits{/sha}","git_commits_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/git/commits{/sha}","comments_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/comments{/number}","issue_comment_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/issues/comments{/number}","contents_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/contents/{+path}","compare_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/merges","archive_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/downloads","issues_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/issues{/number}","pulls_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/pulls{/number}","milestones_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/milestones{/number}","notifications_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/labels{/name}","releases_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/releases{/id}","deployments_url":"https://api.github.com/repos/webermn15/wdi-10-hw3-functions/deployments","created_at":"2017-12-10T06:35:11Z","updated_at":"2017-12-10T16:25:40Z","pushed_at":"2017-12-10T22:13:12Z","git_url":"git://github.com/webermn15/wdi-10-hw3-functions.git","ssh_url":"[email protected]:webermn15/wdi-10-hw3-functions.git","clone_url":"https://github.com/webermn15/wdi-10-hw3-functions.git","svn_url":"https://github.com/webermn15/wdi-10-hw3-functions","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ga-chicago:master","ref":"master","sha":"8548f0acb72ac7992e05aa929f386a8db0eba7ec","user":{"login":"ga-chicago","id":12513784,"avatar_url":"https://avatars1.githubusercontent.com/u/12513784?v=4","gravatar_id":"","url":"https://api.github.com/users/ga-chicago","html_url":"https://github.com/ga-chicago","followers_url":"https://api.github.com/users/ga-chicago/followers","following_url":"https://api.github.com/users/ga-chicago/following{/other_user}","gists_url":"https://api.github.com/users/ga-chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/ga-chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga-chicago/subscriptions","organizations_url":"https://api.github.com/users/ga-chicago/orgs","repos_url":"https://api.github.com/users/ga-chicago/repos","events_url":"https://api.github.com/users/ga-chicago/events{/privacy}","received_events_url":"https://api.github.com/users/ga-chicago/received_events","type":"Organization","site_admin":false},"repo":{"id":113705379,"name":"wdi-10-hw3-functions","full_name":"ga-chicago/wdi-10-hw3-functions","owner":{"login":"ga-chicago","id":12513784,"avatar_url":"https://avatars1.githubusercontent.com/u/12513784?v=4","gravatar_id":"","url":"https://api.github.com/users/ga-chicago","html_url":"https://github.com/ga-chicago","followers_url":"https://api.github.com/users/ga-chicago/followers","following_url":"https://api.github.com/users/ga-chicago/following{/other_user}","gists_url":"https://api.github.com/users/ga-chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/ga-chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga-chicago/subscriptions","organizations_url":"https://api.github.com/users/ga-chicago/orgs","repos_url":"https://api.github.com/users/ga-chicago/repos","events_url":"https://api.github.com/users/ga-chicago/events{/privacy}","received_events_url":"https://api.github.com/users/ga-chicago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ga-chicago/wdi-10-hw3-functions","description":null,"fork":false,"url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions","forks_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/forks","keys_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/teams","hooks_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/hooks","issue_events_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/issues/events{/number}","events_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/events","assignees_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/assignees{/user}","branches_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/branches{/branch}","tags_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/tags","blobs_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/git/refs{/sha}","trees_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/statuses/{sha}","languages_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/languages","stargazers_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/stargazers","contributors_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/contributors","subscribers_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/subscribers","subscription_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/subscription","commits_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/commits{/sha}","git_commits_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/git/commits{/sha}","comments_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/comments{/number}","issue_comment_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/issues/comments{/number}","contents_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/contents/{+path}","compare_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/merges","archive_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/downloads","issues_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/issues{/number}","pulls_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls{/number}","milestones_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/milestones{/number}","notifications_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/labels{/name}","releases_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/releases{/id}","deployments_url":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/deployments","created_at":"2017-12-09T22:21:43Z","updated_at":"2017-12-09T22:21:43Z","pushed_at":"2017-12-12T15:05:35Z","git_url":"git://github.com/ga-chicago/wdi-10-hw3-functions.git","ssh_url":"[email protected]:ga-chicago/wdi-10-hw3-functions.git","clone_url":"https://github.com/ga-chicago/wdi-10-hw3-functions.git","svn_url":"https://github.com/ga-chicago/wdi-10-hw3-functions","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":11,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/1"},"html":{"href":"https://github.com/ga-chicago/wdi-10-hw3-functions/pull/1"},"issue":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/issues/1"},"comments":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions/statuses/b9e395f6da0e29c2c46ae491df992023ba095567"}},"author_association":"NONE"}} | {
"id": 113705379,
"name": "ga-chicago/wdi-10-hw3-functions",
"url": "https://api.github.com/repos/ga-chicago/wdi-10-hw3-functions"
} | {
"id": 15374784,
"login": "reubenayres",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15374784?",
"url": "https://api.github.com/users/reubenayres"
} | {
"id": 12513784,
"login": "ga-chicago",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12513784?",
"url": "https://api.github.com/orgs/ga-chicago"
} | 2017-12-13T01:49:32 | 6980456822 | {"actor":{"display_login":"reubenayres"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments/118663927","pull_request_review_id":40477798,"id":118663927,"diff_hunk":"@@ -26,17 +26,15 @@ type Config struct {\n \n \t// Settings.\n \n-\t// Name of the kind of ThirdPartyObjects. It should be in lower case\n-\t// and hyphen delimited. Kind names will be converted to CamelCase\n-\t// when creating ThirdPartyObjects. Hyphens in the kind are assumed to\n-\t// be word breaks. For instance the kind camel-case would be converted\n-\t// to CamelCase but camelcase would be converted to Camelcase.\n+\t// Name takes the form <kind>.<domain>. The domain is also known as","path":"tpr/tpr.go","position":9,"original_position":9,"commit_id":"464d5ae7954cd6743249cec0c4038eebbfee422e","original_commit_id":"60ae4597f7660690c2722b077e931b6cae2c3a90","user":{"login":"asymmetric","id":101816,"avatar_url":"https://avatars2.githubusercontent.com/u/101816?v=3","gravatar_id":"","url":"https://api.github.com/users/asymmetric","html_url":"https://github.com/asymmetric","followers_url":"https://api.github.com/users/asymmetric/followers","following_url":"https://api.github.com/users/asymmetric/following{/other_user}","gists_url":"https://api.github.com/users/asymmetric/gists{/gist_id}","starred_url":"https://api.github.com/users/asymmetric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asymmetric/subscriptions","organizations_url":"https://api.github.com/users/asymmetric/orgs","repos_url":"https://api.github.com/users/asymmetric/repos","events_url":"https://api.github.com/users/asymmetric/events{/privacy}","received_events_url":"https://api.github.com/users/asymmetric/received_events","type":"User","site_admin":false},"body":"Can we settle on one of domain and group? What's the benefit of mentioning both?","created_at":"2017-05-26T09:16:50Z","updated_at":"2017-05-26T09:21:55Z","html_url":"https://github.com/giantswarm/operatorkit/pull/15#discussion_r118663927","pull_request_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments/118663927"},"html":{"href":"https://github.com/giantswarm/operatorkit/pull/15#discussion_r118663927"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/15","id":122478675,"html_url":"https://github.com/giantswarm/operatorkit/pull/15","diff_url":"https://github.com/giantswarm/operatorkit/pull/15.diff","patch_url":"https://github.com/giantswarm/operatorkit/pull/15.patch","issue_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/15","number":15,"state":"open","locked":false,"title":"Infer TPR kind and group","user":{"login":"kopiczko","id":4608994,"avatar_url":"https://avatars3.githubusercontent.com/u/4608994?v=3","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"body":"Towards https://github.com/giantswarm/giantswarm/issues/1483","created_at":"2017-05-25T16:45:38Z","updated_at":"2017-05-26T09:21:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"074e51354caed94a6ba6013325f7f5c1bf4eafda","assignee":{"login":"kopiczko","id":4608994,"avatar_url":"https://avatars3.githubusercontent.com/u/4608994?v=3","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"assignees":[{"login":"kopiczko","id":4608994,"avatar_url":"https://avatars3.githubusercontent.com/u/4608994?v=3","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"JosephSalisbury","id":297653,"avatar_url":"https://avatars2.githubusercontent.com/u/297653?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephSalisbury","html_url":"https://github.com/JosephSalisbury","followers_url":"https://api.github.com/users/JosephSalisbury/followers","following_url":"https://api.github.com/users/JosephSalisbury/following{/other_user}","gists_url":"https://api.github.com/users/JosephSalisbury/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSalisbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSalisbury/subscriptions","organizations_url":"https://api.github.com/users/JosephSalisbury/orgs","repos_url":"https://api.github.com/users/JosephSalisbury/repos","events_url":"https://api.github.com/users/JosephSalisbury/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSalisbury/received_events","type":"User","site_admin":false},{"login":"rossf7","id":311527,"avatar_url":"https://avatars2.githubusercontent.com/u/311527?v=3","gravatar_id":"","url":"https://api.github.com/users/rossf7","html_url":"https://github.com/rossf7","followers_url":"https://api.github.com/users/rossf7/followers","following_url":"https://api.github.com/users/rossf7/following{/other_user}","gists_url":"https://api.github.com/users/rossf7/gists{/gist_id}","starred_url":"https://api.github.com/users/rossf7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossf7/subscriptions","organizations_url":"https://api.github.com/users/rossf7/orgs","repos_url":"https://api.github.com/users/rossf7/repos","events_url":"https://api.github.com/users/rossf7/events{/privacy}","received_events_url":"https://api.github.com/users/rossf7/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/15/commits","review_comments_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/15/comments","review_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/15/comments","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/464d5ae7954cd6743249cec0c4038eebbfee422e","head":{"label":"giantswarm:kind","ref":"kind","sha":"464d5ae7954cd6743249cec0c4038eebbfee422e","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":87818870,"name":"operatorkit","full_name":"giantswarm/operatorkit","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/operatorkit","description":"The operatorkit package implements an opinionated framework for developing Kubernetes operators.","fork":false,"url":"https://api.github.com/repos/giantswarm/operatorkit","forks_url":"https://api.github.com/repos/giantswarm/operatorkit/forks","keys_url":"https://api.github.com/repos/giantswarm/operatorkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/operatorkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/operatorkit/teams","hooks_url":"https://api.github.com/repos/giantswarm/operatorkit/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/operatorkit/events","assignees_url":"https://api.github.com/repos/giantswarm/operatorkit/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/operatorkit/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/operatorkit/tags","blobs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/operatorkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/operatorkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/operatorkit/languages","stargazers_url":"https://api.github.com/repos/giantswarm/operatorkit/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/operatorkit/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/operatorkit/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/operatorkit/subscription","commits_url":"https://api.github.com/repos/giantswarm/operatorkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/operatorkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/operatorkit/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/operatorkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/operatorkit/merges","archive_url":"https://api.github.com/repos/giantswarm/operatorkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/operatorkit/downloads","issues_url":"https://api.github.com/repos/giantswarm/operatorkit/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/operatorkit/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/operatorkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/operatorkit/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/operatorkit/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/operatorkit/deployments","created_at":"2017-04-10T14:12:58Z","updated_at":"2017-05-24T13:39:17Z","pushed_at":"2017-05-26T09:21:13Z","git_url":"git://github.com/giantswarm/operatorkit.git","ssh_url":"[email protected]:giantswarm/operatorkit.git","clone_url":"https://github.com/giantswarm/operatorkit.git","svn_url":"https://github.com/giantswarm/operatorkit","homepage":"","size":10494,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"a571e5d6b72f6e46caeeb716133fd02c16a8231d","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":87818870,"name":"operatorkit","full_name":"giantswarm/operatorkit","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/operatorkit","description":"The operatorkit package implements an opinionated framework for developing Kubernetes operators.","fork":false,"url":"https://api.github.com/repos/giantswarm/operatorkit","forks_url":"https://api.github.com/repos/giantswarm/operatorkit/forks","keys_url":"https://api.github.com/repos/giantswarm/operatorkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/operatorkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/operatorkit/teams","hooks_url":"https://api.github.com/repos/giantswarm/operatorkit/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/operatorkit/events","assignees_url":"https://api.github.com/repos/giantswarm/operatorkit/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/operatorkit/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/operatorkit/tags","blobs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/operatorkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/operatorkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/operatorkit/languages","stargazers_url":"https://api.github.com/repos/giantswarm/operatorkit/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/operatorkit/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/operatorkit/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/operatorkit/subscription","commits_url":"https://api.github.com/repos/giantswarm/operatorkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/operatorkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/operatorkit/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/operatorkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/operatorkit/merges","archive_url":"https://api.github.com/repos/giantswarm/operatorkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/operatorkit/downloads","issues_url":"https://api.github.com/repos/giantswarm/operatorkit/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/operatorkit/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/operatorkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/operatorkit/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/operatorkit/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/operatorkit/deployments","created_at":"2017-04-10T14:12:58Z","updated_at":"2017-05-24T13:39:17Z","pushed_at":"2017-05-26T09:21:13Z","git_url":"git://github.com/giantswarm/operatorkit.git","ssh_url":"[email protected]:giantswarm/operatorkit.git","clone_url":"https://github.com/giantswarm/operatorkit.git","svn_url":"https://github.com/giantswarm/operatorkit","homepage":"","size":10494,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/15"},"html":{"href":"https://github.com/giantswarm/operatorkit/pull/15"},"issue":{"href":"https://api.github.com/repos/giantswarm/operatorkit/issues/15"},"comments":{"href":"https://api.github.com/repos/giantswarm/operatorkit/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/operatorkit/statuses/464d5ae7954cd6743249cec0c4038eebbfee422e"}}}} | {
"id": 87818870,
"name": "giantswarm/operatorkit",
"url": "https://api.github.com/repos/giantswarm/operatorkit"
} | {
"id": 101816,
"login": "asymmetric",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/101816?",
"url": "https://api.github.com/users/asymmetric"
} | {
"id": 7556340,
"login": "giantswarm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7556340?",
"url": "https://api.github.com/orgs/giantswarm"
} | 2017-05-26T09:16:50 | 5947786483 | {"actor":{"display_login":"asymmetric"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/haikuports/haikuports/pulls/comments/154542391","pull_request_review_id":80719399,"id":154542391,"diff_hunk":"@@ -0,0 +1,118 @@\n+SUMMARY=\"An open source, portable, easy to use, readable and flexible SSL library\"\n+DESCRIPTION=\"mbed TLS (formerly known as PolarSSL) makes it trivially easy for \\\n+developers to include cryptographic and SSL/TLS capabilities in their (embedded) \\\n+products, facilitating this functionality with a minimal coding footprint.\"\n+HOMEPAGE=\"https://tls.mbed.org\"\n+COPYRIGHT=\"2006-2016, ARM Limited\"\n+LICENSE=\"Apache v2\"\n+REVISION=\"1\"\n+SOURCE_URI=\"https://tls.mbed.org/download/mbedtls-$portVersion-apache.tgz\"\n+CHECKSUM_SHA256=\"99bc9d4212d3d885eeb96273bcde8ecc649a481404b8d7ea7bb26397c9909687\"\n+\n+ARCHITECTURES=\"?x86_gcc2 ?x86 x86_64\"\n+\n+PROVIDES=\"\n+\tmbedtls = $portVersion\n+\tcmd:mbedtls_aescrypt2 = $portVersion\n+\tcmd:mbedtls_benchmark = $portVersion\n+\tcmd:mbedtls_cert_app = $portVersion\n+\tcmd:mbedtls_cert_req = $portVersion\n+\tcmd:mbedtls_cert_write = $portVersion\n+\tcmd:mbedtls_crl_app = $portVersion\n+\tcmd:mbedtls_crypt_and_hash = $portVersion\n+\tcmd:mbedtls_dh_client = $portVersion\n+\tcmd:mbedtls_dh_genprime = $portVersion\n+\tcmd:mbedtls_dh_server = $portVersion\n+\tcmd:mbedtls_dtls_client = $portVersion\n+\tcmd:mbedtls_dtls_server = $portVersion\n+\tcmd:mbedtls_ecdh_curve25519 = $portVersion\n+\tcmd:mbedtls_ecdsa = $portVersion\n+\tcmd:mbedtls_gen_entropy = $portVersion\n+\tcmd:mbedtls_gen_key = $portVersion\n+\tcmd:mbedtls_gen_random_ctr_drbg = $portVersion\n+\tcmd:mbedtls_gen_random_havege = $portVersion\n+\tcmd:mbedtls_generic_sum = $portVersion\n+\tcmd:mbedtls_hello = $portVersion\n+\tcmd:mbedtls_key_app = $portVersion\n+\tcmd:mbedtls_key_app_writer = $portVersion\n+\tcmd:mbedtls_mini_client = $portVersion\n+\tcmd:mbedtls_mpi_demo = $portVersion\n+\tcmd:mbedtls_pem2der = $portVersion\n+\tcmd:mbedtls_pk_decrypt = $portVersion\n+\tcmd:mbedtls_pk_encrypt = $portVersion\n+\tcmd:mbedtls_pk_sign = $portVersion\n+\tcmd:mbedtls_pk_verify = $portVersion\n+\tcmd:mbedtls_req_app = $portVersion\n+\tcmd:mbedtls_rsa_decrypt = $portVersion\n+\tcmd:mbedtls_rsa_encrypt = $portVersion\n+\tcmd:mbedtls_rsa_genkey = $portVersion\n+\tcmd:mbedtls_rsa_sign = $portVersion\n+\tcmd:mbedtls_rsa_sign_pss = $portVersion\n+\tcmd:mbedtls_rsa_verify = $portVersion\n+\tcmd:mbedtls_rsa_verify_pss = $portVersion\n+\tcmd:mbedtls_selftest = $portVersion\n+\tcmd:mbedtls_ssl_cert_test = $portVersion\n+\tcmd:mbedtls_ssl_client1 = $portVersion\n+\tcmd:mbedtls_ssl_client2 = $portVersion\n+\tcmd:mbedtls_ssl_fork_server = $portVersion\n+\tcmd:mbedtls_ssl_mail_client = $portVersion\n+\tcmd:mbedtls_ssl_server = $portVersion\n+\tcmd:mbedtls_ssl_server2 = $portVersion\n+\tcmd:mbedtls_strerror = $portVersion\n+\tcmd:mbedtls_udp_proxy = $portVersion\n+\tlib:libmbedcrypto\n+\tlib:libmbedtls\n+\tlib:libmbedx509\n+\t\"\n+REQUIRES=\"\n+\thaiku\n+\t\"\n+\n+PROVIDES_devel=\"\n+\tmbedtls_devel = $portVersion\n+\tdevel:libmbedcrypto\n+\tdevel:libmbedtls\n+\tdevel:libmbedx509\n+\t\"\n+REQUIRES_devel=\"\n+\tmbedtls == $portVersion base\n+\t\"\n+\n+BUILD_PREREQUIRES=\"\n+\tcmd:gcc\n+\tcmd:make\n+\tcmd:perl\n+\tcmd:sed\n+\t\"\n+BUILD_REQUIRES=\"\n+\thaiku_devel\n+\t\"\n+\n+PATCH()\n+{\n+\tsed -i \\\n+\t-e \"s|/include/mbedtls|/$relativeOldIncludeDir|;\"\\\n+\t-e \"s|/include|/$relativeOldIncludeDir|;\"\\\n+\t-e \"s|/bin/|/$relativeBinDir/|;\"\\\n+\t-e \"s|/bin\\$|/$relativeBinDir/|;\"\\\n+\t-e \"s|/lib\\$|$relativeLibDir/|;\"\\\n+\tMakefile\n+}\n+\n+BUILD()\n+{\n+\t# Haiku is unix-like and network functions are in libnetwork\n+\tmake CFLAGS=\"-Dunix\" LDFLAGS=\"-lnetwork\" SHARED=yes WARNING_CFLAGS=\n+}\n+\n+INSTALL()\n+{\n+\tmake install SHARED=yes DESTDIR=$prefix/","path":"net-libs/mbedtls/mbedtls-2.6.0.recipe","position":110,"original_position":110,"commit_id":"142b96bafd357fabdce978e51bf3d7bf78bad34f","original_commit_id":"142b96bafd357fabdce978e51bf3d7bf78bad34f","user":{"login":"ohnx","id":6683648,"avatar_url":"https://avatars1.githubusercontent.com/u/6683648?v=4","gravatar_id":"","url":"https://api.github.com/users/ohnx","html_url":"https://github.com/ohnx","followers_url":"https://api.github.com/users/ohnx/followers","following_url":"https://api.github.com/users/ohnx/following{/other_user}","gists_url":"https://api.github.com/users/ohnx/gists{/gist_id}","starred_url":"https://api.github.com/users/ohnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohnx/subscriptions","organizations_url":"https://api.github.com/users/ohnx/orgs","repos_url":"https://api.github.com/users/ohnx/repos","events_url":"https://api.github.com/users/ohnx/events{/privacy}","received_events_url":"https://api.github.com/users/ohnx/received_events","type":"User","site_admin":false},"body":"I tried, it tried writing to `/packages/mbedtls-2.6.0-1/.selflib` instead of `/packages/mbedtls-2.6.0-1/.self/lib`","created_at":"2017-12-04T00:11:11Z","updated_at":"2017-12-04T00:11:11Z","html_url":"https://github.com/haikuports/haikuports/pull/1834#discussion_r154542391","pull_request_url":"https://api.github.com/repos/haikuports/haikuports/pulls/1834","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/comments/154542391"},"html":{"href":"https://github.com/haikuports/haikuports/pull/1834#discussion_r154542391"},"pull_request":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/1834"}},"in_reply_to_id":154540315},"pull_request":{"url":"https://api.github.com/repos/haikuports/haikuports/pulls/1834","id":156067886,"html_url":"https://github.com/haikuports/haikuports/pull/1834","diff_url":"https://github.com/haikuports/haikuports/pull/1834.diff","patch_url":"https://github.com/haikuports/haikuports/pull/1834.patch","issue_url":"https://api.github.com/repos/haikuports/haikuports/issues/1834","number":1834,"state":"open","locked":false,"title":"mbedtls: add initial recipe for 2.6.0","user":{"login":"ohnx","id":6683648,"avatar_url":"https://avatars1.githubusercontent.com/u/6683648?v=4","gravatar_id":"","url":"https://api.github.com/users/ohnx","html_url":"https://github.com/ohnx","followers_url":"https://api.github.com/users/ohnx/followers","following_url":"https://api.github.com/users/ohnx/following{/other_user}","gists_url":"https://api.github.com/users/ohnx/gists{/gist_id}","starred_url":"https://api.github.com/users/ohnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohnx/subscriptions","organizations_url":"https://api.github.com/users/ohnx/orgs","repos_url":"https://api.github.com/users/ohnx/repos","events_url":"https://api.github.com/users/ohnx/events{/privacy}","received_events_url":"https://api.github.com/users/ohnx/received_events","type":"User","site_admin":false},"body":"mbed TLS (formerly known as PolarSSL) makes it trivially easy for developers to include cryptographic and SSL/TLS capabilities in their (embedded) products, facilitating this functionality with a minimal coding footprint.\r\n","created_at":"2017-12-03T16:24:32Z","updated_at":"2017-12-04T00:11:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bca21c219217bd4124f276d680e440f26e4401c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/haikuports/haikuports/pulls/1834/commits","review_comments_url":"https://api.github.com/repos/haikuports/haikuports/pulls/1834/comments","review_comment_url":"https://api.github.com/repos/haikuports/haikuports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haikuports/haikuports/issues/1834/comments","statuses_url":"https://api.github.com/repos/haikuports/haikuports/statuses/142b96bafd357fabdce978e51bf3d7bf78bad34f","head":{"label":"gci2017:mbedtls","ref":"mbedtls","sha":"142b96bafd357fabdce978e51bf3d7bf78bad34f","user":{"login":"gci2017","id":34080982,"avatar_url":"https://avatars0.githubusercontent.com/u/34080982?v=4","gravatar_id":"","url":"https://api.github.com/users/gci2017","html_url":"https://github.com/gci2017","followers_url":"https://api.github.com/users/gci2017/followers","following_url":"https://api.github.com/users/gci2017/following{/other_user}","gists_url":"https://api.github.com/users/gci2017/gists{/gist_id}","starred_url":"https://api.github.com/users/gci2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gci2017/subscriptions","organizations_url":"https://api.github.com/users/gci2017/orgs","repos_url":"https://api.github.com/users/gci2017/repos","events_url":"https://api.github.com/users/gci2017/events{/privacy}","received_events_url":"https://api.github.com/users/gci2017/received_events","type":"Organization","site_admin":false},"repo":{"id":112751859,"name":"haikuports","full_name":"gci2017/haikuports","owner":{"login":"gci2017","id":34080982,"avatar_url":"https://avatars0.githubusercontent.com/u/34080982?v=4","gravatar_id":"","url":"https://api.github.com/users/gci2017","html_url":"https://github.com/gci2017","followers_url":"https://api.github.com/users/gci2017/followers","following_url":"https://api.github.com/users/gci2017/following{/other_user}","gists_url":"https://api.github.com/users/gci2017/gists{/gist_id}","starred_url":"https://api.github.com/users/gci2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gci2017/subscriptions","organizations_url":"https://api.github.com/users/gci2017/orgs","repos_url":"https://api.github.com/users/gci2017/repos","events_url":"https://api.github.com/users/gci2017/events{/privacy}","received_events_url":"https://api.github.com/users/gci2017/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gci2017/haikuports","description":"Software ports for the Haiku operating system.","fork":true,"url":"https://api.github.com/repos/gci2017/haikuports","forks_url":"https://api.github.com/repos/gci2017/haikuports/forks","keys_url":"https://api.github.com/repos/gci2017/haikuports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gci2017/haikuports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gci2017/haikuports/teams","hooks_url":"https://api.github.com/repos/gci2017/haikuports/hooks","issue_events_url":"https://api.github.com/repos/gci2017/haikuports/issues/events{/number}","events_url":"https://api.github.com/repos/gci2017/haikuports/events","assignees_url":"https://api.github.com/repos/gci2017/haikuports/assignees{/user}","branches_url":"https://api.github.com/repos/gci2017/haikuports/branches{/branch}","tags_url":"https://api.github.com/repos/gci2017/haikuports/tags","blobs_url":"https://api.github.com/repos/gci2017/haikuports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gci2017/haikuports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gci2017/haikuports/git/refs{/sha}","trees_url":"https://api.github.com/repos/gci2017/haikuports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gci2017/haikuports/statuses/{sha}","languages_url":"https://api.github.com/repos/gci2017/haikuports/languages","stargazers_url":"https://api.github.com/repos/gci2017/haikuports/stargazers","contributors_url":"https://api.github.com/repos/gci2017/haikuports/contributors","subscribers_url":"https://api.github.com/repos/gci2017/haikuports/subscribers","subscription_url":"https://api.github.com/repos/gci2017/haikuports/subscription","commits_url":"https://api.github.com/repos/gci2017/haikuports/commits{/sha}","git_commits_url":"https://api.github.com/repos/gci2017/haikuports/git/commits{/sha}","comments_url":"https://api.github.com/repos/gci2017/haikuports/comments{/number}","issue_comment_url":"https://api.github.com/repos/gci2017/haikuports/issues/comments{/number}","contents_url":"https://api.github.com/repos/gci2017/haikuports/contents/{+path}","compare_url":"https://api.github.com/repos/gci2017/haikuports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gci2017/haikuports/merges","archive_url":"https://api.github.com/repos/gci2017/haikuports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gci2017/haikuports/downloads","issues_url":"https://api.github.com/repos/gci2017/haikuports/issues{/number}","pulls_url":"https://api.github.com/repos/gci2017/haikuports/pulls{/number}","milestones_url":"https://api.github.com/repos/gci2017/haikuports/milestones{/number}","notifications_url":"https://api.github.com/repos/gci2017/haikuports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gci2017/haikuports/labels{/name}","releases_url":"https://api.github.com/repos/gci2017/haikuports/releases{/id}","deployments_url":"https://api.github.com/repos/gci2017/haikuports/deployments","created_at":"2017-12-01T14:55:43Z","updated_at":"2017-12-01T14:55:49Z","pushed_at":"2017-12-03T22:28:36Z","git_url":"git://github.com/gci2017/haikuports.git","ssh_url":"[email protected]:gci2017/haikuports.git","clone_url":"https://github.com/gci2017/haikuports.git","svn_url":"https://github.com/gci2017/haikuports","homepage":"","size":30414,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haikuports:master","ref":"master","sha":"ae951ae78336ed66e1bc483688c80b6480adb2aa","user":{"login":"haikuports","id":12898682,"avatar_url":"https://avatars3.githubusercontent.com/u/12898682?v=4","gravatar_id":"","url":"https://api.github.com/users/haikuports","html_url":"https://github.com/haikuports","followers_url":"https://api.github.com/users/haikuports/followers","following_url":"https://api.github.com/users/haikuports/following{/other_user}","gists_url":"https://api.github.com/users/haikuports/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuports/subscriptions","organizations_url":"https://api.github.com/users/haikuports/orgs","repos_url":"https://api.github.com/users/haikuports/repos","events_url":"https://api.github.com/users/haikuports/events{/privacy}","received_events_url":"https://api.github.com/users/haikuports/received_events","type":"Organization","site_admin":false},"repo":{"id":38278075,"name":"haikuports","full_name":"haikuports/haikuports","owner":{"login":"haikuports","id":12898682,"avatar_url":"https://avatars3.githubusercontent.com/u/12898682?v=4","gravatar_id":"","url":"https://api.github.com/users/haikuports","html_url":"https://github.com/haikuports","followers_url":"https://api.github.com/users/haikuports/followers","following_url":"https://api.github.com/users/haikuports/following{/other_user}","gists_url":"https://api.github.com/users/haikuports/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuports/subscriptions","organizations_url":"https://api.github.com/users/haikuports/orgs","repos_url":"https://api.github.com/users/haikuports/repos","events_url":"https://api.github.com/users/haikuports/events{/privacy}","received_events_url":"https://api.github.com/users/haikuports/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haikuports/haikuports","description":"Software ports for the Haiku operating system.","fork":false,"url":"https://api.github.com/repos/haikuports/haikuports","forks_url":"https://api.github.com/repos/haikuports/haikuports/forks","keys_url":"https://api.github.com/repos/haikuports/haikuports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haikuports/haikuports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haikuports/haikuports/teams","hooks_url":"https://api.github.com/repos/haikuports/haikuports/hooks","issue_events_url":"https://api.github.com/repos/haikuports/haikuports/issues/events{/number}","events_url":"https://api.github.com/repos/haikuports/haikuports/events","assignees_url":"https://api.github.com/repos/haikuports/haikuports/assignees{/user}","branches_url":"https://api.github.com/repos/haikuports/haikuports/branches{/branch}","tags_url":"https://api.github.com/repos/haikuports/haikuports/tags","blobs_url":"https://api.github.com/repos/haikuports/haikuports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haikuports/haikuports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haikuports/haikuports/git/refs{/sha}","trees_url":"https://api.github.com/repos/haikuports/haikuports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haikuports/haikuports/statuses/{sha}","languages_url":"https://api.github.com/repos/haikuports/haikuports/languages","stargazers_url":"https://api.github.com/repos/haikuports/haikuports/stargazers","contributors_url":"https://api.github.com/repos/haikuports/haikuports/contributors","subscribers_url":"https://api.github.com/repos/haikuports/haikuports/subscribers","subscription_url":"https://api.github.com/repos/haikuports/haikuports/subscription","commits_url":"https://api.github.com/repos/haikuports/haikuports/commits{/sha}","git_commits_url":"https://api.github.com/repos/haikuports/haikuports/git/commits{/sha}","comments_url":"https://api.github.com/repos/haikuports/haikuports/comments{/number}","issue_comment_url":"https://api.github.com/repos/haikuports/haikuports/issues/comments{/number}","contents_url":"https://api.github.com/repos/haikuports/haikuports/contents/{+path}","compare_url":"https://api.github.com/repos/haikuports/haikuports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haikuports/haikuports/merges","archive_url":"https://api.github.com/repos/haikuports/haikuports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haikuports/haikuports/downloads","issues_url":"https://api.github.com/repos/haikuports/haikuports/issues{/number}","pulls_url":"https://api.github.com/repos/haikuports/haikuports/pulls{/number}","milestones_url":"https://api.github.com/repos/haikuports/haikuports/milestones{/number}","notifications_url":"https://api.github.com/repos/haikuports/haikuports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haikuports/haikuports/labels{/name}","releases_url":"https://api.github.com/repos/haikuports/haikuports/releases{/id}","deployments_url":"https://api.github.com/repos/haikuports/haikuports/deployments","created_at":"2015-06-30T00:15:33Z","updated_at":"2017-11-25T00:58:04Z","pushed_at":"2017-12-03T22:31:45Z","git_url":"git://github.com/haikuports/haikuports.git","ssh_url":"[email protected]:haikuports/haikuports.git","clone_url":"https://github.com/haikuports/haikuports.git","svn_url":"https://github.com/haikuports/haikuports","homepage":"","size":30437,"stargazers_count":60,"watchers_count":60,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":97,"open_issues":210,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/1834"},"html":{"href":"https://github.com/haikuports/haikuports/pull/1834"},"issue":{"href":"https://api.github.com/repos/haikuports/haikuports/issues/1834"},"comments":{"href":"https://api.github.com/repos/haikuports/haikuports/issues/1834/comments"},"review_comments":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/1834/comments"},"review_comment":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haikuports/haikuports/pulls/1834/commits"},"statuses":{"href":"https://api.github.com/repos/haikuports/haikuports/statuses/142b96bafd357fabdce978e51bf3d7bf78bad34f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 38278075,
"name": "haikuports/haikuports",
"url": "https://api.github.com/repos/haikuports/haikuports"
} | {
"id": 6683648,
"login": "ohnx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6683648?",
"url": "https://api.github.com/users/ohnx"
} | {
"id": 12898682,
"login": "haikuports",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12898682?",
"url": "https://api.github.com/orgs/haikuports"
} | 2017-12-04T00:11:11 | 6936847860 | {"actor":{"display_login":"ohnx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/increments/mastodon/pulls/comments/117661702","pull_request_review_id":39385194,"id":117661702,"diff_hunk":"@@ -14,6 +14,7 @@ const ja = {\n \"account.unblock\": \"ブロック解除\",\n \"account.unfollow\": \"フォロー解除\",\n \"account.unmute\": \"ミュート解除\",\n+ \"alert_bar.email_confirm_alert\": \"メールアドレスの確認が完了していません。登録したアドレス宛に送信されたメールを確認してください。\",","path":"app/assets/javascripts/components/locales/ja.jsx","position":null,"original_position":4,"commit_id":"28462ed5a2835076c4454a54ed62accd533083ed","original_commit_id":"229e63c439dc3a4822828ac563602af6f5b9697e","user":{"login":"tomoasleep","id":1477130,"avatar_url":"https://avatars0.githubusercontent.com/u/1477130?v=3","gravatar_id":"","url":"https://api.github.com/users/tomoasleep","html_url":"https://github.com/tomoasleep","followers_url":"https://api.github.com/users/tomoasleep/followers","following_url":"https://api.github.com/users/tomoasleep/following{/other_user}","gists_url":"https://api.github.com/users/tomoasleep/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoasleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoasleep/subscriptions","organizations_url":"https://api.github.com/users/tomoasleep/orgs","repos_url":"https://api.github.com/users/tomoasleep/repos","events_url":"https://api.github.com/users/tomoasleep/events{/privacy}","received_events_url":"https://api.github.com/users/tomoasleep/received_events","type":"User","site_admin":false},"body":"<img width=\"1341\" alt=\"2017-05-22 13 54 42\" src=\"https://cloud.githubusercontent.com/assets/1477130/26293128/41625778-3ef6-11e7-91ad-4b5edf631107.png\">\r\n直した ✌️ ","created_at":"2017-05-22T04:55:11Z","updated_at":"2017-05-22T04:55:12Z","html_url":"https://github.com/increments/mastodon/pull/8#discussion_r117661702","pull_request_url":"https://api.github.com/repos/increments/mastodon/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/increments/mastodon/pulls/comments/117661702"},"html":{"href":"https://github.com/increments/mastodon/pull/8#discussion_r117661702"},"pull_request":{"href":"https://api.github.com/repos/increments/mastodon/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/increments/mastodon/pulls/8","id":119340982,"html_url":"https://github.com/increments/mastodon/pull/8","diff_url":"https://github.com/increments/mastodon/pull/8.diff","patch_url":"https://github.com/increments/mastodon/pull/8.patch","issue_url":"https://api.github.com/repos/increments/mastodon/issues/8","number":8,"state":"open","locked":false,"title":"Qiita login","user":{"login":"tomoasleep","id":1477130,"avatar_url":"https://avatars0.githubusercontent.com/u/1477130?v=3","gravatar_id":"","url":"https://api.github.com/users/tomoasleep","html_url":"https://github.com/tomoasleep","followers_url":"https://api.github.com/users/tomoasleep/followers","following_url":"https://api.github.com/users/tomoasleep/following{/other_user}","gists_url":"https://api.github.com/users/tomoasleep/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoasleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoasleep/subscriptions","organizations_url":"https://api.github.com/users/tomoasleep/orgs","repos_url":"https://api.github.com/users/tomoasleep/repos","events_url":"https://api.github.com/users/tomoasleep/events{/privacy}","received_events_url":"https://api.github.com/users/tomoasleep/received_events","type":"User","site_admin":false},"body":"QiitaのOAuthを利用してアカウント作成とログインが行えるようにする。\r\n\r\n\r\n<img width=\"830\" alt=\"2017-05-18 19 52 06\" src=\"https://cloud.githubusercontent.com/assets/1477130/26199051/944aa3f0-3c03-11e7-8e8d-68eb56554c89.png\">\r\n\r\n\r\n# 仕様\r\n\r\n- ホーム画面 ( `/about` )とログイン画面 ( `/session/new` ) に「Qiitaアカウントで参加ボタン」が追加される\r\n- ボタンを押すと、紐付いている場合はログインが行える。\r\n - 紐付いていない場合は紐付け作業を行う\r\n - ログインしていない場合は専用の登録フォーム ( `` ) でアカウントの登録作業を行う\r\n - 専用フォームではメールアドレスとアカウント名を入力してMastodonアカウントの新規作成を行う\r\n - パスワードはランダムな文字列がダミーのパスワードとして入る\r\n - ユーザーには知らされないので再設定するまでパスワードログインできない\r\n - 設定画面からパスワードを設定することが出来る。最初の1回だけ現在のパスワードを入れずにパスワードを変更することが出来る\r\n - ログインしている場合では、MastodonアカウントとQiitaアカウントを紐付ける\r\n- 設定画面から紐付けが行える \r\n - 現在は紐付け解除はできない\r\n\r\n# 動作を見たい場合の注意\r\n\r\nQIitaで自分のアカウントでアプリケーションを作成し、`.env` に適宜以下の内容を追加しておいてください。\r\n\r\n```\r\n# XXXXを自分のアプリケーションのtokenの値に変える。\r\nQIITA_CLIENT_ID=XXXX\r\nQIITA_CLIENT_SECRET=XXXX\r\n```\r\n","created_at":"2017-05-07T14:39:07Z","updated_at":"2017-05-22T04:55:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6074f30b9fb1cabe40b753454592c2a987ac1a69","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/increments/mastodon/pulls/8/commits","review_comments_url":"https://api.github.com/repos/increments/mastodon/pulls/8/comments","review_comment_url":"https://api.github.com/repos/increments/mastodon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/increments/mastodon/issues/8/comments","statuses_url":"https://api.github.com/repos/increments/mastodon/statuses/28462ed5a2835076c4454a54ed62accd533083ed","head":{"label":"tomoasleep:qiita-login","ref":"qiita-login","sha":"28462ed5a2835076c4454a54ed62accd533083ed","user":{"login":"tomoasleep","id":1477130,"avatar_url":"https://avatars0.githubusercontent.com/u/1477130?v=3","gravatar_id":"","url":"https://api.github.com/users/tomoasleep","html_url":"https://github.com/tomoasleep","followers_url":"https://api.github.com/users/tomoasleep/followers","following_url":"https://api.github.com/users/tomoasleep/following{/other_user}","gists_url":"https://api.github.com/users/tomoasleep/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoasleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoasleep/subscriptions","organizations_url":"https://api.github.com/users/tomoasleep/orgs","repos_url":"https://api.github.com/users/tomoasleep/repos","events_url":"https://api.github.com/users/tomoasleep/events{/privacy}","received_events_url":"https://api.github.com/users/tomoasleep/received_events","type":"User","site_admin":false},"repo":{"id":89195641,"name":"mastodon","full_name":"tomoasleep/mastodon","owner":{"login":"tomoasleep","id":1477130,"avatar_url":"https://avatars0.githubusercontent.com/u/1477130?v=3","gravatar_id":"","url":"https://api.github.com/users/tomoasleep","html_url":"https://github.com/tomoasleep","followers_url":"https://api.github.com/users/tomoasleep/followers","following_url":"https://api.github.com/users/tomoasleep/following{/other_user}","gists_url":"https://api.github.com/users/tomoasleep/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoasleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoasleep/subscriptions","organizations_url":"https://api.github.com/users/tomoasleep/orgs","repos_url":"https://api.github.com/users/tomoasleep/repos","events_url":"https://api.github.com/users/tomoasleep/events{/privacy}","received_events_url":"https://api.github.com/users/tomoasleep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomoasleep/mastodon","description":"A GNU Social-compatible microblogging server","fork":true,"url":"https://api.github.com/repos/tomoasleep/mastodon","forks_url":"https://api.github.com/repos/tomoasleep/mastodon/forks","keys_url":"https://api.github.com/repos/tomoasleep/mastodon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomoasleep/mastodon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomoasleep/mastodon/teams","hooks_url":"https://api.github.com/repos/tomoasleep/mastodon/hooks","issue_events_url":"https://api.github.com/repos/tomoasleep/mastodon/issues/events{/number}","events_url":"https://api.github.com/repos/tomoasleep/mastodon/events","assignees_url":"https://api.github.com/repos/tomoasleep/mastodon/assignees{/user}","branches_url":"https://api.github.com/repos/tomoasleep/mastodon/branches{/branch}","tags_url":"https://api.github.com/repos/tomoasleep/mastodon/tags","blobs_url":"https://api.github.com/repos/tomoasleep/mastodon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomoasleep/mastodon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomoasleep/mastodon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomoasleep/mastodon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomoasleep/mastodon/statuses/{sha}","languages_url":"https://api.github.com/repos/tomoasleep/mastodon/languages","stargazers_url":"https://api.github.com/repos/tomoasleep/mastodon/stargazers","contributors_url":"https://api.github.com/repos/tomoasleep/mastodon/contributors","subscribers_url":"https://api.github.com/repos/tomoasleep/mastodon/subscribers","subscription_url":"https://api.github.com/repos/tomoasleep/mastodon/subscription","commits_url":"https://api.github.com/repos/tomoasleep/mastodon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomoasleep/mastodon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomoasleep/mastodon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomoasleep/mastodon/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomoasleep/mastodon/contents/{+path}","compare_url":"https://api.github.com/repos/tomoasleep/mastodon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomoasleep/mastodon/merges","archive_url":"https://api.github.com/repos/tomoasleep/mastodon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomoasleep/mastodon/downloads","issues_url":"https://api.github.com/repos/tomoasleep/mastodon/issues{/number}","pulls_url":"https://api.github.com/repos/tomoasleep/mastodon/pulls{/number}","milestones_url":"https://api.github.com/repos/tomoasleep/mastodon/milestones{/number}","notifications_url":"https://api.github.com/repos/tomoasleep/mastodon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomoasleep/mastodon/labels{/name}","releases_url":"https://api.github.com/repos/tomoasleep/mastodon/releases{/id}","deployments_url":"https://api.github.com/repos/tomoasleep/mastodon/deployments","created_at":"2017-04-24T03:51:16Z","updated_at":"2017-04-24T03:51:21Z","pushed_at":"2017-05-22T04:53:19Z","git_url":"git://github.com/tomoasleep/mastodon.git","ssh_url":"[email protected]:tomoasleep/mastodon.git","clone_url":"https://github.com/tomoasleep/mastodon.git","svn_url":"https://github.com/tomoasleep/mastodon","homepage":"https://mastodon.social","size":36612,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"increments:increments","ref":"increments","sha":"d3599001cb481b0ec0849341366114b5e364aaee","user":{"login":"increments","id":1674978,"avatar_url":"https://avatars2.githubusercontent.com/u/1674978?v=3","gravatar_id":"","url":"https://api.github.com/users/increments","html_url":"https://github.com/increments","followers_url":"https://api.github.com/users/increments/followers","following_url":"https://api.github.com/users/increments/following{/other_user}","gists_url":"https://api.github.com/users/increments/gists{/gist_id}","starred_url":"https://api.github.com/users/increments/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/increments/subscriptions","organizations_url":"https://api.github.com/users/increments/orgs","repos_url":"https://api.github.com/users/increments/repos","events_url":"https://api.github.com/users/increments/events{/privacy}","received_events_url":"https://api.github.com/users/increments/received_events","type":"Organization","site_admin":false},"repo":{"id":89566230,"name":"mastodon","full_name":"increments/mastodon","owner":{"login":"increments","id":1674978,"avatar_url":"https://avatars2.githubusercontent.com/u/1674978?v=3","gravatar_id":"","url":"https://api.github.com/users/increments","html_url":"https://github.com/increments","followers_url":"https://api.github.com/users/increments/followers","following_url":"https://api.github.com/users/increments/following{/other_user}","gists_url":"https://api.github.com/users/increments/gists{/gist_id}","starred_url":"https://api.github.com/users/increments/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/increments/subscriptions","organizations_url":"https://api.github.com/users/increments/orgs","repos_url":"https://api.github.com/users/increments/repos","events_url":"https://api.github.com/users/increments/events{/privacy}","received_events_url":"https://api.github.com/users/increments/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/increments/mastodon","description":"A GNU Social-compatible microblogging server","fork":true,"url":"https://api.github.com/repos/increments/mastodon","forks_url":"https://api.github.com/repos/increments/mastodon/forks","keys_url":"https://api.github.com/repos/increments/mastodon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/increments/mastodon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/increments/mastodon/teams","hooks_url":"https://api.github.com/repos/increments/mastodon/hooks","issue_events_url":"https://api.github.com/repos/increments/mastodon/issues/events{/number}","events_url":"https://api.github.com/repos/increments/mastodon/events","assignees_url":"https://api.github.com/repos/increments/mastodon/assignees{/user}","branches_url":"https://api.github.com/repos/increments/mastodon/branches{/branch}","tags_url":"https://api.github.com/repos/increments/mastodon/tags","blobs_url":"https://api.github.com/repos/increments/mastodon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/increments/mastodon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/increments/mastodon/git/refs{/sha}","trees_url":"https://api.github.com/repos/increments/mastodon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/increments/mastodon/statuses/{sha}","languages_url":"https://api.github.com/repos/increments/mastodon/languages","stargazers_url":"https://api.github.com/repos/increments/mastodon/stargazers","contributors_url":"https://api.github.com/repos/increments/mastodon/contributors","subscribers_url":"https://api.github.com/repos/increments/mastodon/subscribers","subscription_url":"https://api.github.com/repos/increments/mastodon/subscription","commits_url":"https://api.github.com/repos/increments/mastodon/commits{/sha}","git_commits_url":"https://api.github.com/repos/increments/mastodon/git/commits{/sha}","comments_url":"https://api.github.com/repos/increments/mastodon/comments{/number}","issue_comment_url":"https://api.github.com/repos/increments/mastodon/issues/comments{/number}","contents_url":"https://api.github.com/repos/increments/mastodon/contents/{+path}","compare_url":"https://api.github.com/repos/increments/mastodon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/increments/mastodon/merges","archive_url":"https://api.github.com/repos/increments/mastodon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/increments/mastodon/downloads","issues_url":"https://api.github.com/repos/increments/mastodon/issues{/number}","pulls_url":"https://api.github.com/repos/increments/mastodon/pulls{/number}","milestones_url":"https://api.github.com/repos/increments/mastodon/milestones{/number}","notifications_url":"https://api.github.com/repos/increments/mastodon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/increments/mastodon/labels{/name}","releases_url":"https://api.github.com/repos/increments/mastodon/releases{/id}","deployments_url":"https://api.github.com/repos/increments/mastodon/deployments","created_at":"2017-04-27T07:02:04Z","updated_at":"2017-05-08T10:54:32Z","pushed_at":"2017-05-22T04:53:21Z","git_url":"git://github.com/increments/mastodon.git","ssh_url":"[email protected]:increments/mastodon.git","clone_url":"https://github.com/increments/mastodon.git","svn_url":"https://github.com/increments/mastodon","homepage":"https://mastodon.social","size":36660,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"increments"}},"_links":{"self":{"href":"https://api.github.com/repos/increments/mastodon/pulls/8"},"html":{"href":"https://github.com/increments/mastodon/pull/8"},"issue":{"href":"https://api.github.com/repos/increments/mastodon/issues/8"},"comments":{"href":"https://api.github.com/repos/increments/mastodon/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/increments/mastodon/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/increments/mastodon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/increments/mastodon/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/increments/mastodon/statuses/28462ed5a2835076c4454a54ed62accd533083ed"}}}} | {
"id": 89566230,
"name": "increments/mastodon",
"url": "https://api.github.com/repos/increments/mastodon"
} | {
"id": 1477130,
"login": "tomoasleep",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1477130?",
"url": "https://api.github.com/users/tomoasleep"
} | {
"id": 1674978,
"login": "increments",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1674978?",
"url": "https://api.github.com/orgs/increments"
} | 2017-05-22T04:55:11 | 5914770988 | {"actor":{"display_login":"tomoasleep"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/122232919","pull_request_review_id":44332206,"id":122232919,"diff_hunk":"@@ -0,0 +1,27 @@\n+package org.infinispan.commons.dataconversion;\n+\n+import org.infinispan.commons.marshall.WrappedByteArray;\n+\n+/**\n+ * Wraps byte[] on a {@link WrappedByteArray} to provide equality and hashCode support, leaving other objects\n+ * unchanged.\n+ *\n+ * @since 9.1\n+ */\n+public class ByteArrayWrapper implements Wrapper {\n+","path":"commons/src/main/java/org/infinispan/commons/dataconversion/ByteArrayWrapper.java","position":12,"original_position":12,"commit_id":"c9427891841eb6299f7087b41f209a14d91d62ea","original_commit_id":"c9427891841eb6299f7087b41f209a14d91d62ea","user":{"login":"wburns","id":648175,"avatar_url":"https://avatars2.githubusercontent.com/u/648175?v=3","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"body":"👍 sounds good to me. I just glanced at the code very quickly after his recent updates.","created_at":"2017-06-15T15:27:04Z","updated_at":"2017-06-15T15:27:04Z","html_url":"https://github.com/infinispan/infinispan/pull/5181#discussion_r122232919","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5181","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/122232919"},"html":{"href":"https://github.com/infinispan/infinispan/pull/5181#discussion_r122232919"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5181"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/5181","id":123979124,"html_url":"https://github.com/infinispan/infinispan/pull/5181","diff_url":"https://github.com/infinispan/infinispan/pull/5181.diff","patch_url":"https://github.com/infinispan/infinispan/pull/5181.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/5181","number":5181,"state":"closed","locked":false,"title":"ISPN-7896 Support for on-demand data conversion in caches","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars1.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-7896\r\n\r\nThere are some polishings to be made and some rough edges, but the main approach should not change.\r\n\r\n**API Changes**\r\n\r\n* Introduced ```Encoder``` and ```Wrapper``` to handle data conversions and wrapping\r\n\r\n* Advanced cache has ```.withEncoder(encoder)``` to support different encodings on-demand.\r\nOnce ```.withEncoder(encoder)``` is called, all operations in the cache will use that encoder, including streams, map operations and listeners\r\n\r\n**Internal changes**\r\n\r\nTypeConverters, RemoteValueWrapperInterceptor, CompatibilityAdvancedCache, TypeConverterDelegatingAdvancedCache, DataTypedCache are gone, replaced by Encoders\r\n\r\n**Compatibility Mode**\r\n\r\nCompatibility mode is translated to an encoder called ```CompatModeEncoder```\r\n\r\n\r\n\r\n\r\n","created_at":"2017-06-05T13:40:33Z","updated_at":"2017-06-15T15:27:04Z","closed_at":"2017-06-15T14:46:20Z","merged_at":null,"merge_commit_sha":"2deffb46819b1e65a2f1d9522af111bf81744f43","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/infinispan/infinispan/milestones/78","html_url":"https://github.com/infinispan/infinispan/milestone/78","labels_url":"https://api.github.com/repos/infinispan/infinispan/milestones/78/labels","id":2571123,"number":78,"title":"9.1.0.Beta1","description":"","creator":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars3.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":10,"state":"open","created_at":"2017-06-08T08:54:52Z","updated_at":"2017-06-15T15:01:37Z","due_on":"2017-06-16T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5181/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5181/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/5181/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/c9427891841eb6299f7087b41f209a14d91d62ea","head":{"label":"gustavonalle:ISPN-7896","ref":"ISPN-7896","sha":"c9427891841eb6299f7087b41f209a14d91d62ea","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars1.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"repo":{"id":20231400,"name":"infinispan","full_name":"gustavonalle/infinispan","owner":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars1.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gustavonalle/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/gustavonalle/infinispan","forks_url":"https://api.github.com/repos/gustavonalle/infinispan/forks","keys_url":"https://api.github.com/repos/gustavonalle/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gustavonalle/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gustavonalle/infinispan/teams","hooks_url":"https://api.github.com/repos/gustavonalle/infinispan/hooks","issue_events_url":"https://api.github.com/repos/gustavonalle/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/gustavonalle/infinispan/events","assignees_url":"https://api.github.com/repos/gustavonalle/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/gustavonalle/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/gustavonalle/infinispan/tags","blobs_url":"https://api.github.com/repos/gustavonalle/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gustavonalle/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gustavonalle/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/gustavonalle/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gustavonalle/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/gustavonalle/infinispan/languages","stargazers_url":"https://api.github.com/repos/gustavonalle/infinispan/stargazers","contributors_url":"https://api.github.com/repos/gustavonalle/infinispan/contributors","subscribers_url":"https://api.github.com/repos/gustavonalle/infinispan/subscribers","subscription_url":"https://api.github.com/repos/gustavonalle/infinispan/subscription","commits_url":"https://api.github.com/repos/gustavonalle/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/gustavonalle/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/gustavonalle/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/gustavonalle/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/gustavonalle/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/gustavonalle/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gustavonalle/infinispan/merges","archive_url":"https://api.github.com/repos/gustavonalle/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gustavonalle/infinispan/downloads","issues_url":"https://api.github.com/repos/gustavonalle/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/gustavonalle/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/gustavonalle/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/gustavonalle/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gustavonalle/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/gustavonalle/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/gustavonalle/infinispan/deployments","created_at":"2014-05-27T18:52:33Z","updated_at":"2016-02-03T16:52:34Z","pushed_at":"2017-06-15T12:36:52Z","git_url":"git://github.com/gustavonalle/infinispan.git","ssh_url":"[email protected]:gustavonalle/infinispan.git","clone_url":"https://github.com/gustavonalle/infinispan.git","svn_url":"https://github.com/gustavonalle/infinispan","homepage":"http://www.infinispan.org","size":92953,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"2693175efc85cd928beb284725a467e583436750","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars0.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars0.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2017-06-15T07:48:03Z","pushed_at":"2017-06-15T14:44:21Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"[email protected]:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":97166,"stargazers_count":566,"watchers_count":566,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":398,"mirror_url":null,"open_issues_count":27,"forks":398,"open_issues":27,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5181"},"html":{"href":"https://github.com/infinispan/infinispan/pull/5181"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/5181"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/5181/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5181/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5181/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/c9427891841eb6299f7087b41f209a14d91d62ea"}}}} | {
"id": 1050944,
"name": "infinispan/infinispan",
"url": "https://api.github.com/repos/infinispan/infinispan"
} | {
"id": 648175,
"login": "wburns",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/648175?",
"url": "https://api.github.com/users/wburns"
} | {
"id": 458093,
"login": "infinispan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/458093?",
"url": "https://api.github.com/orgs/infinispan"
} | 2017-06-15T15:27:04 | 6073294724 | {"actor":{"display_login":"wburns"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/138912517","pull_request_review_id":62771980,"id":138912517,"diff_hunk":"@@ -210,6 +210,17 @@ def is_submission(obj, eng):\n \n \n @with_debug_logging\n+def add_holdingpen_entry_id(obj, eng):\n+ \"\"\"Add holdingpen entry id for this record in 'submission_number' \"\"\"\n+ source = obj.data.get('acquisition_source')\n+ if source:\n+ if source.get('method') == \"hepcrawl\":\n+ source['submission_number'] = obj.id","path":"inspirehep/modules/workflows/tasks/actions.py","position":9,"original_position":9,"commit_id":"6e47d5888bd42228d4954b6d3fa0b844c5f90353","original_commit_id":"6e47d5888bd42228d4954b6d3fa0b844c5f90353","user":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars2.githubusercontent.com/u/381280?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"body":"More succinct:\r\n```python\r\nmethod = get_value(obj.data, 'acquisition_source.method', default='')\r\nif method == 'hepcrawl':\r\n obj.data['acquisition_source']['submission_number'] = obj.id\r\n```","created_at":"2017-09-14T14:36:39Z","updated_at":"2017-09-14T14:36:39Z","html_url":"https://github.com/inspirehep/inspire-next/pull/2753#discussion_r138912517","pull_request_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2753","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/138912517"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/2753#discussion_r138912517"},"pull_request":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2753"}}},"pull_request":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2753","id":141078269,"html_url":"https://github.com/inspirehep/inspire-next/pull/2753","diff_url":"https://github.com/inspirehep/inspire-next/pull/2753.diff","patch_url":"https://github.com/inspirehep/inspire-next/pull/2753.patch","issue_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/2753","number":2753,"state":"open","locked":false,"title":"'submission_number' field poplulated differently","user":{"login":"iulianav","id":20461142,"avatar_url":"https://avatars3.githubusercontent.com/u/20461142?v=4","gravatar_id":"","url":"https://api.github.com/users/iulianav","html_url":"https://github.com/iulianav","followers_url":"https://api.github.com/users/iulianav/followers","following_url":"https://api.github.com/users/iulianav/following{/other_user}","gists_url":"https://api.github.com/users/iulianav/gists{/gist_id}","starred_url":"https://api.github.com/users/iulianav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iulianav/subscriptions","organizations_url":"https://api.github.com/users/iulianav/orgs","repos_url":"https://api.github.com/users/iulianav/repos","events_url":"https://api.github.com/users/iulianav/events{/privacy}","received_events_url":"https://api.github.com/users/iulianav/received_events","type":"User","site_admin":false},"body":"The submission_number field ( 541__e ) in 'acquisition_source' is populated\r\ndifferently between hepcrawl and submissions. The aim is to populate it in\r\nhepcrawl the same way as it is in submissions, i.e. contain the holdingpen\r\nentry id of the record.\r\n\r\nSigned-off-by: Iuliana Voinea <[email protected]>\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n## Related Issue\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I have all the information that I need (if not, move to `RFC` and look for it).\r\n- [ ] I linked the related issue(s) in the corresponding commit logs.\r\n- [x] I wrote [good commit log messages](https://github.com/torvalds/subsurface-for-dirk/blob/5f15ad5a86ada3c5e574041a5f9d85235322dabb/README#L92-L119).\r\n- [ ] My code follows the code style of this project.\r\n- [ ] I've added any new docs if API/utils methods were added.\r\n- [ ] I have updated the existing documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n<!--- After this you can move the PR to `Needs Review` -->\r\n","created_at":"2017-09-14T13:44:53Z","updated_at":"2017-09-14T14:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d26e950e957051698d9d36bb1d44af2d3bfbbe1e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kaplun","id":119349,"avatar_url":"https://avatars3.githubusercontent.com/u/119349?v=4","gravatar_id":"","url":"https://api.github.com/users/kaplun","html_url":"https://github.com/kaplun","followers_url":"https://api.github.com/users/kaplun/followers","following_url":"https://api.github.com/users/kaplun/following{/other_user}","gists_url":"https://api.github.com/users/kaplun/gists{/gist_id}","starred_url":"https://api.github.com/users/kaplun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaplun/subscriptions","organizations_url":"https://api.github.com/users/kaplun/orgs","repos_url":"https://api.github.com/users/kaplun/repos","events_url":"https://api.github.com/users/kaplun/events{/privacy}","received_events_url":"https://api.github.com/users/kaplun/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2753/commits","review_comments_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2753/comments","review_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/2753/comments","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/6e47d5888bd42228d4954b6d3fa0b844c5f90353","head":{"label":"iulianav:fix-hepcrawl-holdingpen-entry-id-bug","ref":"fix-hepcrawl-holdingpen-entry-id-bug","sha":"6e47d5888bd42228d4954b6d3fa0b844c5f90353","user":{"login":"iulianav","id":20461142,"avatar_url":"https://avatars3.githubusercontent.com/u/20461142?v=4","gravatar_id":"","url":"https://api.github.com/users/iulianav","html_url":"https://github.com/iulianav","followers_url":"https://api.github.com/users/iulianav/followers","following_url":"https://api.github.com/users/iulianav/following{/other_user}","gists_url":"https://api.github.com/users/iulianav/gists{/gist_id}","starred_url":"https://api.github.com/users/iulianav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iulianav/subscriptions","organizations_url":"https://api.github.com/users/iulianav/orgs","repos_url":"https://api.github.com/users/iulianav/repos","events_url":"https://api.github.com/users/iulianav/events{/privacy}","received_events_url":"https://api.github.com/users/iulianav/received_events","type":"User","site_admin":false},"repo":{"id":99801591,"name":"inspire-next","full_name":"iulianav/inspire-next","owner":{"login":"iulianav","id":20461142,"avatar_url":"https://avatars3.githubusercontent.com/u/20461142?v=4","gravatar_id":"","url":"https://api.github.com/users/iulianav","html_url":"https://github.com/iulianav","followers_url":"https://api.github.com/users/iulianav/followers","following_url":"https://api.github.com/users/iulianav/following{/other_user}","gists_url":"https://api.github.com/users/iulianav/gists{/gist_id}","starred_url":"https://api.github.com/users/iulianav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iulianav/subscriptions","organizations_url":"https://api.github.com/users/iulianav/orgs","repos_url":"https://api.github.com/users/iulianav/repos","events_url":"https://api.github.com/users/iulianav/events{/privacy}","received_events_url":"https://api.github.com/users/iulianav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iulianav/inspire-next","description":"The next version of INSPIRE","fork":true,"url":"https://api.github.com/repos/iulianav/inspire-next","forks_url":"https://api.github.com/repos/iulianav/inspire-next/forks","keys_url":"https://api.github.com/repos/iulianav/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iulianav/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iulianav/inspire-next/teams","hooks_url":"https://api.github.com/repos/iulianav/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/iulianav/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/iulianav/inspire-next/events","assignees_url":"https://api.github.com/repos/iulianav/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/iulianav/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/iulianav/inspire-next/tags","blobs_url":"https://api.github.com/repos/iulianav/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iulianav/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iulianav/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/iulianav/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iulianav/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/iulianav/inspire-next/languages","stargazers_url":"https://api.github.com/repos/iulianav/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/iulianav/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/iulianav/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/iulianav/inspire-next/subscription","commits_url":"https://api.github.com/repos/iulianav/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/iulianav/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/iulianav/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/iulianav/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/iulianav/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/iulianav/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iulianav/inspire-next/merges","archive_url":"https://api.github.com/repos/iulianav/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iulianav/inspire-next/downloads","issues_url":"https://api.github.com/repos/iulianav/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/iulianav/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/iulianav/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/iulianav/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iulianav/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/iulianav/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/iulianav/inspire-next/deployments","created_at":"2017-08-09T11:37:52Z","updated_at":"2017-08-09T11:37:55Z","pushed_at":"2017-09-14T13:44:21Z","git_url":"git://github.com/iulianav/inspire-next.git","ssh_url":"[email protected]:iulianav/inspire-next.git","clone_url":"https://github.com/iulianav/inspire-next.git","svn_url":"https://github.com/iulianav/inspire-next","homepage":"https://labs.inspirehep.net","size":65737,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inspirehep:master","ref":"master","sha":"fcb1263266d851ba4651a0123455ad2ff3974916","user":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"repo":{"id":15221515,"name":"inspire-next","full_name":"inspirehep/inspire-next","owner":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspirehep/inspire-next","description":"The next version of INSPIRE","fork":false,"url":"https://api.github.com/repos/inspirehep/inspire-next","forks_url":"https://api.github.com/repos/inspirehep/inspire-next/forks","keys_url":"https://api.github.com/repos/inspirehep/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspirehep/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspirehep/inspire-next/teams","hooks_url":"https://api.github.com/repos/inspirehep/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/inspirehep/inspire-next/events","assignees_url":"https://api.github.com/repos/inspirehep/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/inspirehep/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/inspirehep/inspire-next/tags","blobs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspirehep/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspirehep/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/inspirehep/inspire-next/languages","stargazers_url":"https://api.github.com/repos/inspirehep/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/inspirehep/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/inspirehep/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/inspirehep/inspire-next/subscription","commits_url":"https://api.github.com/repos/inspirehep/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspirehep/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspirehep/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/inspirehep/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspirehep/inspire-next/merges","archive_url":"https://api.github.com/repos/inspirehep/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspirehep/inspire-next/downloads","issues_url":"https://api.github.com/repos/inspirehep/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/inspirehep/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/inspirehep/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspirehep/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/inspirehep/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/inspirehep/inspire-next/deployments","created_at":"2013-12-16T09:11:58Z","updated_at":"2017-08-25T21:31:35Z","pushed_at":"2017-09-14T14:30:45Z","git_url":"git://github.com/inspirehep/inspire-next.git","ssh_url":"[email protected]:inspirehep/inspire-next.git","clone_url":"https://github.com/inspirehep/inspire-next.git","svn_url":"https://github.com/inspirehep/inspire-next","homepage":"https://labs.inspirehep.net","size":65764,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":285,"forks":45,"open_issues":285,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2753"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/2753"},"issue":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/2753"},"comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/2753/comments"},"review_comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2753/comments"},"review_comment":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2753/commits"},"statuses":{"href":"https://api.github.com/repos/inspirehep/inspire-next/statuses/6e47d5888bd42228d4954b6d3fa0b844c5f90353"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15221515,
"name": "inspirehep/inspire-next",
"url": "https://api.github.com/repos/inspirehep/inspire-next"
} | {
"id": 381280,
"login": "jacquerie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/381280?",
"url": "https://api.github.com/users/jacquerie"
} | {
"id": 356664,
"login": "inspirehep",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/356664?",
"url": "https://api.github.com/orgs/inspirehep"
} | 2017-09-14T14:36:39 | 6590972760 | {"actor":{"display_login":"jacquerie"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/comments/154625647","pull_request_review_id":80813515,"id":154625647,"diff_hunk":"@@ -0,0 +1,355 @@\n+/**\n+ * @file aero_offboard_velocity_node.cpp\n+ * @brief MAVROS Offboard Control example node, written with mavros version 0.14.2, px4 flight\n+ * stack and tested in Gazebo SITL & jMAVSIM.\n+ */\n+\n+#include <ros/ros.h>\n+#include <geometry_msgs/PoseStamped.h>\n+#include <mavros_msgs/CommandBool.h>\n+#include <mavros_msgs/SetMode.h>\n+#include <mavros_msgs/State.h>\n+#include <mavros_msgs/PositionTarget.h>\n+#include <unistd.h>\n+#include <mavros_msgs/CommandTOL.h>\n+#include <time.h>\n+#include <boost/thread/thread.hpp>\n+#include <ros/duration.h>\n+\n+void state_cb(const mavros_msgs::StateConstPtr& msg, mavros_msgs::State* current_state)\n+{\n+ *current_state = *msg;\n+ bool connected = current_state->connected;\n+}\n+\n+void wait_For_FCU_Connection()\n+{\n+ mavros_msgs::State current_state;\n+ ros::NodeHandlePtr node = boost::make_shared<ros::NodeHandle>();\n+ ros::Subscriber flight_mode_sub =\n+ node->subscribe<mavros_msgs::State>(\"mavros/state\", 3, boost::bind(state_cb, _1, ¤t_state));\n+ while (ros::ok() && !current_state.connected)\n+ {\n+ ros::spinOnce();\n+ }\n+}\n+\n+class Offboard\n+{\n+public:\n+ Offboard();\n+ Offboard(ros::NodeHandle* nodehandle);\n+ ros::NodeHandle nh_;","path":"ros-examples/src/aero_offboard_velocity/src/aero_offboard_velocity_node.cpp","position":42,"original_position":42,"commit_id":"5a8329cae5da4a928828ba5c58426dd278fe918a","original_commit_id":"5a8329cae5da4a928828ba5c58426dd278fe918a","user":{"login":"shakthi-prashanth-m","id":26615772,"avatar_url":"https://avatars2.githubusercontent.com/u/26615772?v=4","gravatar_id":"","url":"https://api.github.com/users/shakthi-prashanth-m","html_url":"https://github.com/shakthi-prashanth-m","followers_url":"https://api.github.com/users/shakthi-prashanth-m/followers","following_url":"https://api.github.com/users/shakthi-prashanth-m/following{/other_user}","gists_url":"https://api.github.com/users/shakthi-prashanth-m/gists{/gist_id}","starred_url":"https://api.github.com/users/shakthi-prashanth-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakthi-prashanth-m/subscriptions","organizations_url":"https://api.github.com/users/shakthi-prashanth-m/orgs","repos_url":"https://api.github.com/users/shakthi-prashanth-m/repos","events_url":"https://api.github.com/users/shakthi-prashanth-m/events{/privacy}","received_events_url":"https://api.github.com/users/shakthi-prashanth-m/received_events","type":"User","site_admin":false},"body":"Make data members as private.","created_at":"2017-12-04T11:42:56Z","updated_at":"2017-12-04T11:42:56Z","html_url":"https://github.com/intel-aero/intel-aero-samples/pull/2#discussion_r154625647","pull_request_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/comments/154625647"},"html":{"href":"https://github.com/intel-aero/intel-aero-samples/pull/2#discussion_r154625647"},"pull_request":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/2","id":156159094,"html_url":"https://github.com/intel-aero/intel-aero-samples/pull/2","diff_url":"https://github.com/intel-aero/intel-aero-samples/pull/2.diff","patch_url":"https://github.com/intel-aero/intel-aero-samples/pull/2.patch","issue_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues/2","number":2,"state":"open","locked":false,"title":"Add aero_offboard_velocity example","user":{"login":"padmashree9110","id":25497245,"avatar_url":"https://avatars2.githubusercontent.com/u/25497245?v=4","gravatar_id":"","url":"https://api.github.com/users/padmashree9110","html_url":"https://github.com/padmashree9110","followers_url":"https://api.github.com/users/padmashree9110/followers","following_url":"https://api.github.com/users/padmashree9110/following{/other_user}","gists_url":"https://api.github.com/users/padmashree9110/gists{/gist_id}","starred_url":"https://api.github.com/users/padmashree9110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padmashree9110/subscriptions","organizations_url":"https://api.github.com/users/padmashree9110/orgs","repos_url":"https://api.github.com/users/padmashree9110/repos","events_url":"https://api.github.com/users/padmashree9110/events{/privacy}","received_events_url":"https://api.github.com/users/padmashree9110/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-04T10:27:11Z","updated_at":"2017-12-04T11:42:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fa1cb9737d2c8b8ea1859d0c03810fcf9c99740","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/2/commits","review_comments_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/2/comments","review_comment_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues/2/comments","statuses_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/statuses/5a8329cae5da4a928828ba5c58426dd278fe918a","head":{"label":"intel-aero:ros-examples-offboard","ref":"ros-examples-offboard","sha":"5a8329cae5da4a928828ba5c58426dd278fe918a","user":{"login":"intel-aero","id":20196197,"avatar_url":"https://avatars1.githubusercontent.com/u/20196197?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-aero","html_url":"https://github.com/intel-aero","followers_url":"https://api.github.com/users/intel-aero/followers","following_url":"https://api.github.com/users/intel-aero/following{/other_user}","gists_url":"https://api.github.com/users/intel-aero/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-aero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-aero/subscriptions","organizations_url":"https://api.github.com/users/intel-aero/orgs","repos_url":"https://api.github.com/users/intel-aero/repos","events_url":"https://api.github.com/users/intel-aero/events{/privacy}","received_events_url":"https://api.github.com/users/intel-aero/received_events","type":"Organization","site_admin":false},"repo":{"id":71950040,"name":"intel-aero-samples","full_name":"intel-aero/intel-aero-samples","owner":{"login":"intel-aero","id":20196197,"avatar_url":"https://avatars1.githubusercontent.com/u/20196197?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-aero","html_url":"https://github.com/intel-aero","followers_url":"https://api.github.com/users/intel-aero/followers","following_url":"https://api.github.com/users/intel-aero/following{/other_user}","gists_url":"https://api.github.com/users/intel-aero/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-aero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-aero/subscriptions","organizations_url":"https://api.github.com/users/intel-aero/orgs","repos_url":"https://api.github.com/users/intel-aero/repos","events_url":"https://api.github.com/users/intel-aero/events{/privacy}","received_events_url":"https://api.github.com/users/intel-aero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel-aero/intel-aero-samples","description":"Layer for intel-aero sample applications recipes ","fork":false,"url":"https://api.github.com/repos/intel-aero/intel-aero-samples","forks_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/forks","keys_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/teams","hooks_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/hooks","issue_events_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues/events{/number}","events_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/events","assignees_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/assignees{/user}","branches_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/branches{/branch}","tags_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/tags","blobs_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/languages","stargazers_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/stargazers","contributors_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/contributors","subscribers_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/subscribers","subscription_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/subscription","commits_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/contents/{+path}","compare_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/merges","archive_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/downloads","issues_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues{/number}","pulls_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/labels{/name}","releases_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/releases{/id}","deployments_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/deployments","created_at":"2016-10-26T00:19:39Z","updated_at":"2017-07-29T03:22:54Z","pushed_at":"2017-12-04T10:35:25Z","git_url":"git://github.com/intel-aero/intel-aero-samples.git","ssh_url":"[email protected]:intel-aero/intel-aero-samples.git","clone_url":"https://github.com/intel-aero/intel-aero-samples.git","svn_url":"https://github.com/intel-aero/intel-aero-samples","homepage":"","size":33,"stargazers_count":1,"watchers_count":1,"language":"BitBake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"intel-aero:develop","ref":"develop","sha":"3a296da57ab9a70a005de3163e996ae093bc770f","user":{"login":"intel-aero","id":20196197,"avatar_url":"https://avatars1.githubusercontent.com/u/20196197?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-aero","html_url":"https://github.com/intel-aero","followers_url":"https://api.github.com/users/intel-aero/followers","following_url":"https://api.github.com/users/intel-aero/following{/other_user}","gists_url":"https://api.github.com/users/intel-aero/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-aero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-aero/subscriptions","organizations_url":"https://api.github.com/users/intel-aero/orgs","repos_url":"https://api.github.com/users/intel-aero/repos","events_url":"https://api.github.com/users/intel-aero/events{/privacy}","received_events_url":"https://api.github.com/users/intel-aero/received_events","type":"Organization","site_admin":false},"repo":{"id":71950040,"name":"intel-aero-samples","full_name":"intel-aero/intel-aero-samples","owner":{"login":"intel-aero","id":20196197,"avatar_url":"https://avatars1.githubusercontent.com/u/20196197?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-aero","html_url":"https://github.com/intel-aero","followers_url":"https://api.github.com/users/intel-aero/followers","following_url":"https://api.github.com/users/intel-aero/following{/other_user}","gists_url":"https://api.github.com/users/intel-aero/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-aero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-aero/subscriptions","organizations_url":"https://api.github.com/users/intel-aero/orgs","repos_url":"https://api.github.com/users/intel-aero/repos","events_url":"https://api.github.com/users/intel-aero/events{/privacy}","received_events_url":"https://api.github.com/users/intel-aero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel-aero/intel-aero-samples","description":"Layer for intel-aero sample applications recipes ","fork":false,"url":"https://api.github.com/repos/intel-aero/intel-aero-samples","forks_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/forks","keys_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/teams","hooks_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/hooks","issue_events_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues/events{/number}","events_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/events","assignees_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/assignees{/user}","branches_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/branches{/branch}","tags_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/tags","blobs_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/languages","stargazers_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/stargazers","contributors_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/contributors","subscribers_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/subscribers","subscription_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/subscription","commits_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/contents/{+path}","compare_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/merges","archive_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/downloads","issues_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues{/number}","pulls_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/labels{/name}","releases_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/releases{/id}","deployments_url":"https://api.github.com/repos/intel-aero/intel-aero-samples/deployments","created_at":"2016-10-26T00:19:39Z","updated_at":"2017-07-29T03:22:54Z","pushed_at":"2017-12-04T10:35:25Z","git_url":"git://github.com/intel-aero/intel-aero-samples.git","ssh_url":"[email protected]:intel-aero/intel-aero-samples.git","clone_url":"https://github.com/intel-aero/intel-aero-samples.git","svn_url":"https://github.com/intel-aero/intel-aero-samples","homepage":"","size":33,"stargazers_count":1,"watchers_count":1,"language":"BitBake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/2"},"html":{"href":"https://github.com/intel-aero/intel-aero-samples/pull/2"},"issue":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues/2"},"comments":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/intel-aero/intel-aero-samples/statuses/5a8329cae5da4a928828ba5c58426dd278fe918a"}},"author_association":"NONE"}} | {
"id": 71950040,
"name": "intel-aero/intel-aero-samples",
"url": "https://api.github.com/repos/intel-aero/intel-aero-samples"
} | {
"id": 26615772,
"login": "shakthi-prashanth-m",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26615772?",
"url": "https://api.github.com/users/shakthi-prashanth-m"
} | {
"id": 20196197,
"login": "intel-aero",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20196197?",
"url": "https://api.github.com/orgs/intel-aero"
} | 2017-12-04T11:42:56 | 6938901419 | {"actor":{"display_login":"shakthi-prashanth-m"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/comments/119999487","pull_request_review_id":41931986,"id":119999487,"diff_hunk":"@@ -0,0 +1,66 @@\n+require 'spec_helper'","path":"spec/resource/caching_spec.rb","position":1,"original_position":1,"commit_id":"7e47a9b07c62d5670a69f1e3c5d25ef5aad0abd2","original_commit_id":"7e47a9b07c62d5670a69f1e3c5d25ef5aad0abd2","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Missing magic comment # frozen_string_literal: true.","created_at":"2017-06-04T03:01:07Z","updated_at":"2017-06-04T03:01:08Z","html_url":"https://github.com/jsonapi-rb/jsonapi-serializable/pull/72#discussion_r119999487","pull_request_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/comments/119999487"},"html":{"href":"https://github.com/jsonapi-rb/jsonapi-serializable/pull/72#discussion_r119999487"},"pull_request":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/72","id":123863603,"html_url":"https://github.com/jsonapi-rb/jsonapi-serializable/pull/72","diff_url":"https://github.com/jsonapi-rb/jsonapi-serializable/pull/72.diff","patch_url":"https://github.com/jsonapi-rb/jsonapi-serializable/pull/72.patch","issue_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues/72","number":72,"state":"open","locked":false,"title":"Add extension for attributes caching.","user":{"login":"beauby","id":2215778,"avatar_url":"https://avatars0.githubusercontent.com/u/2215778?v=3","gravatar_id":"","url":"https://api.github.com/users/beauby","html_url":"https://github.com/beauby","followers_url":"https://api.github.com/users/beauby/followers","following_url":"https://api.github.com/users/beauby/following{/other_user}","gists_url":"https://api.github.com/users/beauby/gists{/gist_id}","starred_url":"https://api.github.com/users/beauby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beauby/subscriptions","organizations_url":"https://api.github.com/users/beauby/orgs","repos_url":"https://api.github.com/users/beauby/repos","events_url":"https://api.github.com/users/beauby/events{/privacy}","received_events_url":"https://api.github.com/users/beauby/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-04T03:00:58Z","updated_at":"2017-06-04T03:01:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5da478bbf1b9064797ac085ca8c43363b6e79e23","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/72/commits","review_comments_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/72/comments","review_comment_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues/72/comments","statuses_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/statuses/7e47a9b07c62d5670a69f1e3c5d25ef5aad0abd2","head":{"label":"jsonapi-rb:caching","ref":"caching","sha":"7e47a9b07c62d5670a69f1e3c5d25ef5aad0abd2","user":{"login":"jsonapi-rb","id":23066863,"avatar_url":"https://avatars2.githubusercontent.com/u/23066863?v=3","gravatar_id":"","url":"https://api.github.com/users/jsonapi-rb","html_url":"https://github.com/jsonapi-rb","followers_url":"https://api.github.com/users/jsonapi-rb/followers","following_url":"https://api.github.com/users/jsonapi-rb/following{/other_user}","gists_url":"https://api.github.com/users/jsonapi-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonapi-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonapi-rb/subscriptions","organizations_url":"https://api.github.com/users/jsonapi-rb/orgs","repos_url":"https://api.github.com/users/jsonapi-rb/repos","events_url":"https://api.github.com/users/jsonapi-rb/events{/privacy}","received_events_url":"https://api.github.com/users/jsonapi-rb/received_events","type":"Organization","site_admin":false},"repo":{"id":71955427,"name":"jsonapi-serializable","full_name":"jsonapi-rb/jsonapi-serializable","owner":{"login":"jsonapi-rb","id":23066863,"avatar_url":"https://avatars2.githubusercontent.com/u/23066863?v=3","gravatar_id":"","url":"https://api.github.com/users/jsonapi-rb","html_url":"https://github.com/jsonapi-rb","followers_url":"https://api.github.com/users/jsonapi-rb/followers","following_url":"https://api.github.com/users/jsonapi-rb/following{/other_user}","gists_url":"https://api.github.com/users/jsonapi-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonapi-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonapi-rb/subscriptions","organizations_url":"https://api.github.com/users/jsonapi-rb/orgs","repos_url":"https://api.github.com/users/jsonapi-rb/repos","events_url":"https://api.github.com/users/jsonapi-rb/events{/privacy}","received_events_url":"https://api.github.com/users/jsonapi-rb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsonapi-rb/jsonapi-serializable","description":"Conveniently build and efficiently render JSON API resources.","fork":false,"url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable","forks_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/forks","keys_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/teams","hooks_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/hooks","issue_events_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues/events{/number}","events_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/events","assignees_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/assignees{/user}","branches_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/branches{/branch}","tags_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/tags","blobs_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/statuses/{sha}","languages_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/languages","stargazers_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/stargazers","contributors_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/contributors","subscribers_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/subscribers","subscription_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/subscription","commits_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/contents/{+path}","compare_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/merges","archive_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/downloads","issues_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues{/number}","pulls_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls{/number}","milestones_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/milestones{/number}","notifications_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/labels{/name}","releases_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/releases{/id}","deployments_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/deployments","created_at":"2016-10-26T01:50:49Z","updated_at":"2017-05-26T08:11:50Z","pushed_at":"2017-06-04T03:00:58Z","git_url":"git://github.com/jsonapi-rb/jsonapi-serializable.git","ssh_url":"[email protected]:jsonapi-rb/jsonapi-serializable.git","clone_url":"https://github.com/jsonapi-rb/jsonapi-serializable.git","svn_url":"https://github.com/jsonapi-rb/jsonapi-serializable","homepage":"http://jsonapi-rb.org","size":93,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":11,"forks":8,"open_issues":11,"watchers":5,"default_branch":"master"}},"base":{"label":"jsonapi-rb:master","ref":"master","sha":"a38dcd67e1ca8cdd665632c93deb6b8bb1de0ad7","user":{"login":"jsonapi-rb","id":23066863,"avatar_url":"https://avatars2.githubusercontent.com/u/23066863?v=3","gravatar_id":"","url":"https://api.github.com/users/jsonapi-rb","html_url":"https://github.com/jsonapi-rb","followers_url":"https://api.github.com/users/jsonapi-rb/followers","following_url":"https://api.github.com/users/jsonapi-rb/following{/other_user}","gists_url":"https://api.github.com/users/jsonapi-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonapi-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonapi-rb/subscriptions","organizations_url":"https://api.github.com/users/jsonapi-rb/orgs","repos_url":"https://api.github.com/users/jsonapi-rb/repos","events_url":"https://api.github.com/users/jsonapi-rb/events{/privacy}","received_events_url":"https://api.github.com/users/jsonapi-rb/received_events","type":"Organization","site_admin":false},"repo":{"id":71955427,"name":"jsonapi-serializable","full_name":"jsonapi-rb/jsonapi-serializable","owner":{"login":"jsonapi-rb","id":23066863,"avatar_url":"https://avatars2.githubusercontent.com/u/23066863?v=3","gravatar_id":"","url":"https://api.github.com/users/jsonapi-rb","html_url":"https://github.com/jsonapi-rb","followers_url":"https://api.github.com/users/jsonapi-rb/followers","following_url":"https://api.github.com/users/jsonapi-rb/following{/other_user}","gists_url":"https://api.github.com/users/jsonapi-rb/gists{/gist_id}","starred_url":"https://api.github.com/users/jsonapi-rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsonapi-rb/subscriptions","organizations_url":"https://api.github.com/users/jsonapi-rb/orgs","repos_url":"https://api.github.com/users/jsonapi-rb/repos","events_url":"https://api.github.com/users/jsonapi-rb/events{/privacy}","received_events_url":"https://api.github.com/users/jsonapi-rb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsonapi-rb/jsonapi-serializable","description":"Conveniently build and efficiently render JSON API resources.","fork":false,"url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable","forks_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/forks","keys_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/teams","hooks_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/hooks","issue_events_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues/events{/number}","events_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/events","assignees_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/assignees{/user}","branches_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/branches{/branch}","tags_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/tags","blobs_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/statuses/{sha}","languages_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/languages","stargazers_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/stargazers","contributors_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/contributors","subscribers_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/subscribers","subscription_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/subscription","commits_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/contents/{+path}","compare_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/merges","archive_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/downloads","issues_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues{/number}","pulls_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls{/number}","milestones_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/milestones{/number}","notifications_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/labels{/name}","releases_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/releases{/id}","deployments_url":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/deployments","created_at":"2016-10-26T01:50:49Z","updated_at":"2017-05-26T08:11:50Z","pushed_at":"2017-06-04T03:00:58Z","git_url":"git://github.com/jsonapi-rb/jsonapi-serializable.git","ssh_url":"[email protected]:jsonapi-rb/jsonapi-serializable.git","clone_url":"https://github.com/jsonapi-rb/jsonapi-serializable.git","svn_url":"https://github.com/jsonapi-rb/jsonapi-serializable","homepage":"http://jsonapi-rb.org","size":93,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":11,"forks":8,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/72"},"html":{"href":"https://github.com/jsonapi-rb/jsonapi-serializable/pull/72"},"issue":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues/72"},"comments":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/jsonapi-rb/jsonapi-serializable/statuses/7e47a9b07c62d5670a69f1e3c5d25ef5aad0abd2"}}}} | {
"id": 71955427,
"name": "jsonapi-rb/jsonapi-serializable",
"url": "https://api.github.com/repos/jsonapi-rb/jsonapi-serializable"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 23066863,
"login": "jsonapi-rb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23066863?",
"url": "https://api.github.com/orgs/jsonapi-rb"
} | 2017-06-04T03:01:07 | 5997638791 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/102853523","pull_request_review_id":23623877,"id":102853523,"diff_hunk":"@@ -44,49 +45,169 @@ def check(*cmd):\n subprocess.check_call(cmd)\n \n \n-def sig_handler(_signo, _frame):\n- \"\"\"Stops container upon receive signal.SIGTERM and signal.SIGINT.\"\"\"\n- print >>sys.stderr, 'signo = %s, frame = %s' % (_signo, _frame)\n- check('docker', 'stop', CONTAINER)\n+def check_env(env, *cmd):\n+ \"\"\"Log and run the command with a specific env, raising on errors.\"\"\"\n+ print >>sys.stderr, 'Environment:'\n+ for key, value in env.items():\n+ print >>sys.stderr, '%s=%s' % (key, value)\n+ print >>sys.stderr, 'Run:', cmd\n+ subprocess.check_call(cmd, env=env)\n \n \n def kubekins(tag):\n \"\"\"Return full path to kubekins-e2e:tag.\"\"\"\n return 'gcr.io/k8s-testimages/kubekins-e2e:%s' % tag\n \n \n-def main(args):\n- \"\"\"Set up env, start kubekins-e2e, handle termination. \"\"\"\n- # pylint: disable=too-many-locals\n-\n- # dockerized-e2e-runner goodies setup\n- workspace = os.environ.get('WORKSPACE', os.getcwd())\n- artifacts = '%s/_artifacts' % workspace\n- if not os.path.isdir(artifacts):\n- os.makedirs(artifacts)\n+class LocalMode(object):\n+ \"\"\"Runs e2e tests by calling e2e-runner.sh.\"\"\"\n+ def __init__(self, workspace):\n+ self.workspace = workspace\n+ self.env = []\n+ self.env_files = []\n+ self.add_environment(\n+ 'HOME=%s' % workspace,\n+ 'WORKSPACE=%s' % workspace,\n+ 'PATH=%s' % os.getenv('PATH'),\n+ )\n+\n+ @staticmethod\n+ def parse_env(env):\n+ \"\"\"Returns (FOO, BAR=MORE) for FOO=BAR=MORE.\"\"\"\n+ return env.split('=', 1)\n+\n+ def add_environment(self, *envs):\n+ \"\"\"Adds FOO=BAR to the list of environment overrides.\"\"\"\n+ self.env.extend(self.parse_env(e) for e in envs)\n+\n+ def add_files(self, env_files):\n+ \"\"\"Reads all FOO=BAR lines from each path in env_files seq.\"\"\"\n+ for env_file in env_files:\n+ with open(test_infra(env_file)) as fp:\n+ for line in fp:\n+ line = line.rstrip()\n+ if not line or line.startswith('#'):\n+ continue\n+ self.env_files.append(self.parse_env(line))\n+\n+ def add_gce_ssh(self, priv, pub):\n+ \"\"\"Copies priv, pub keys to $WORKSPACE/.ssh.\"\"\"\n+ gce_ssh = '%s/.ssh/google_compute_engine' % self.workspace\n+ gce_pub = '%s/.ssh/google_compute_engine.pub' % self.workspace\n+ shutil.copy(priv, gce_ssh)\n+ shutil.copy(pub, gce_pub)\n+ self.add_environment(\n+ 'JENKINS_GCE_SSH_PRIVATE_KEY_FILE=%s' % gce_ssh,\n+ 'JENKINS_GCE_SSH_PUBLIC_KEY_FILE=%s' % gce_pub,\n+ )\n+\n+ def add_service_account(self, path):\n+ \"\"\"Sets GOOGLE_APPLICATION_CREDENTIALS to path.\"\"\"\n+ self.add_environment('GOOGLE_APPLICATION_CREDENTIALS=%s' % path)\n+\n+ @property\n+ def runner(self):\n+ \"\"\"Finds the best version of e2e-runner.sh.\"\"\"\n+ options = ['e2e-runner.sh', test_infra('jenkins/e2e-image/e2e-runner.sh')]\n+ for path in options:\n+ if os.path.isfile(path):\n+ return path\n+ raise ValueError('Cannot find e2e-runner at any of %s' % ', '.join(options))\n+\n+\n+ def install_prerequisites(self):\n+ \"\"\"Copies upload-to-gcs and kubetest if needed.\"\"\"\n+ parent = os.path.dirname(self.runner)\n+ if not os.path.isfile(os.path.join(parent, 'upload-to-gcs.sh')):\n+ shutil.copy(\n+ test_infra('../kubernetes/hack/jenkins/upload-to-gcs.sh'),\n+ os.path.join(parent, 'upload-to-gcs.sh'))\n+ if not os.path.isfile(os.path.join(parent, 'kubetest')):\n+ check('go', 'install', 'k8s.io/test-infra/kubetest')\n+ shutil.copy(\n+ os.path.expandvars('${GOPATH}/bin/kubetest'),\n+ os.path.join(parent, 'kubetest'))\n+\n+ def start(self):\n+ \"\"\"Runs e2e-runner.sh after setting env and installing prereqs.\"\"\"\n+ env = {}\n+ env.update(self.env_files)","path":"scenarios/kubernetes_e2e.py","position":111,"original_position":111,"commit_id":"eafe60171d5e061f6173f9008dce3d8a5a63d2f3","original_commit_id":"eafe60171d5e061f6173f9008dce3d8a5a63d2f3","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"heh, `help(dict.update)`","created_at":"2017-02-24T00:22:15Z","updated_at":"2017-02-24T00:22:15Z","html_url":"https://github.com/kubernetes/test-infra/pull/2001#discussion_r102853523","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2001","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/102853523"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/2001#discussion_r102853523"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2001"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2001","id":107740738,"html_url":"https://github.com/kubernetes/test-infra/pull/2001","diff_url":"https://github.com/kubernetes/test-infra/pull/2001.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/2001.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/2001","number":2001,"state":"open","locked":false,"title":"Add a --mode=local flag to kubernetes_e2e scenario","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"`kubernetes_e2e.py --mode=docker # the default` runs the scenario via `docker run kubekins`\r\n`kubernetes_e2e.py --mode=local` runs the scenario by starting a e2e-runner.sh subprocess.\r\n\r\nAlso:\r\n* fix the binary name in bootstrap.py -h\r\n* Delete unused cp /var/lib/jenkins gce keys (we always run on docker now in jenkins)\r\n* Delete non bootstrap migration mode (everything uses bootstrap now)\r\n","created_at":"2017-02-24T00:01:31Z","updated_at":"2017-02-24T00:22:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e10c1cd9a1336180a1ce3437274b8610b5fe221a","assignee":{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars.githubusercontent.com/u/1108148?v=3","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false},"assignees":[{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars.githubusercontent.com/u/1108148?v=3","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2001/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2001/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/2001/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/eafe60171d5e061f6173f9008dce3d8a5a63d2f3","head":{"label":"fejta:prow","ref":"prow","sha":"eafe60171d5e061f6173f9008dce3d8a5a63d2f3","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"repo":{"id":59241934,"name":"test-infra","full_name":"fejta/test-infra","owner":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fejta/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/fejta/test-infra","forks_url":"https://api.github.com/repos/fejta/test-infra/forks","keys_url":"https://api.github.com/repos/fejta/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fejta/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fejta/test-infra/teams","hooks_url":"https://api.github.com/repos/fejta/test-infra/hooks","issue_events_url":"https://api.github.com/repos/fejta/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/fejta/test-infra/events","assignees_url":"https://api.github.com/repos/fejta/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/fejta/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/fejta/test-infra/tags","blobs_url":"https://api.github.com/repos/fejta/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fejta/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fejta/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/fejta/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fejta/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/fejta/test-infra/languages","stargazers_url":"https://api.github.com/repos/fejta/test-infra/stargazers","contributors_url":"https://api.github.com/repos/fejta/test-infra/contributors","subscribers_url":"https://api.github.com/repos/fejta/test-infra/subscribers","subscription_url":"https://api.github.com/repos/fejta/test-infra/subscription","commits_url":"https://api.github.com/repos/fejta/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/fejta/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/fejta/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/fejta/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/fejta/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/fejta/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fejta/test-infra/merges","archive_url":"https://api.github.com/repos/fejta/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fejta/test-infra/downloads","issues_url":"https://api.github.com/repos/fejta/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/fejta/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/fejta/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/fejta/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fejta/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/fejta/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/fejta/test-infra/deployments","created_at":"2016-05-19T20:53:03Z","updated_at":"2017-01-21T20:00:13Z","pushed_at":"2017-02-24T00:12:49Z","git_url":"git://github.com/fejta/test-infra.git","ssh_url":"[email protected]:fejta/test-infra.git","clone_url":"https://github.com/fejta/test-infra.git","svn_url":"https://github.com/fejta/test-infra","homepage":null,"size":14834,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"57825fcd7ab08b1b20f107649d6ba1cdcf7907fa","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2017-02-23T09:51:20Z","pushed_at":"2017-02-24T00:13:40Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"[email protected]:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":15629,"stargazers_count":52,"watchers_count":52,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":171,"forks":100,"open_issues":171,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2001"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/2001"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/2001"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/2001/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2001/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2001/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/eafe60171d5e061f6173f9008dce3d8a5a63d2f3"}}}} | {
"id": 57333709,
"name": "kubernetes/test-infra",
"url": "https://api.github.com/repos/kubernetes/test-infra"
} | {
"id": 940341,
"login": "fejta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/940341?",
"url": "https://api.github.com/users/fejta"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-02-24T00:22:15 | 5382147911 | {"actor":{"display_login":"fejta"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/103731889","pull_request_review_id":24528283,"id":103731889,"diff_hunk":"@@ -172,13 +172,26 @@ var _ = framework.KubeDescribe(\"Projected\", func() {\n \n \tIt(\"optional updates should be reflected in volume [Conformance] [Volume]\", func() {\n \n-\t\t// We may have to wait or a full sync period to elapse before the\n-\t\t// Kubelet projects the update into the volume and the container picks\n-\t\t// it up. This timeout is based on the default Kubelet sync period (1\n-\t\t// minute) plus additional time for fudge factor.\n-\t\tconst podLogTimeout = 300 * time.Second\n-\t\ttrueVal := true\n+\t\t// We SecretManager, we may have to wait up to full sync period + TTL of\n+\t\t// a secret to elapse before the Kubelet projects the update into the volume\n+\t\t// and the container picks it ip.\n+\t\t// This timeout is based on default Kubelet sync period (1 minute) plus\n+\t\t// maximum secret TTL (based on cluster size) plus additional time for fudge","path":"test/e2e/common/projected.go","position":null,"original_position":14,"commit_id":"1c295635a9c485394a559214ebc4258d60ed80a9","original_commit_id":"a2003a64ca89bc9515ef2ae4e4923f94f9eb3712","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"Good point. Fixed.","created_at":"2017-03-01T16:49:36Z","updated_at":"2017-03-01T16:49:53Z","html_url":"https://github.com/kubernetes/kubernetes/pull/42266#discussion_r103731889","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42266","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/103731889"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/42266#discussion_r103731889"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42266"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42266","id":108384136,"html_url":"https://github.com/kubernetes/kubernetes/pull/42266","diff_url":"https://github.com/kubernetes/kubernetes/pull/42266.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/42266.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42266","number":42266,"state":"open","locked":false,"title":"Bump test timeouts to make secret tests work in large clusters","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-28T17:52:49Z","updated_at":"2017-03-01T16:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28e828cff46eab8d8413ef7101dea36fec48630c","assignee":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars2.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"assignees":[{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars2.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31","html_url":"https://github.com/kubernetes/kubernetes/milestone/31","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31/labels","id":2130587,"number":31,"title":"v1.6","description":"","creator":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars2.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"open_issues":306,"closed_issues":523,"state":"open","created_at":"2016-11-12T00:35:38Z","updated_at":"2017-03-01T16:30:00Z","due_on":"2017-03-22T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42266/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42266/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42266/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1c295635a9c485394a559214ebc4258d60ed80a9","head":{"label":"wojtek-t:fix_secret_tests_in_large_clusters","ref":"fix_secret_tests_in_large_clusters","sha":"1c295635a9c485394a559214ebc4258d60ed80a9","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"repo":{"id":30216785,"name":"kubernetes","full_name":"wojtek-t/kubernetes","owner":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wojtek-t/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/wojtek-t/kubernetes","forks_url":"https://api.github.com/repos/wojtek-t/kubernetes/forks","keys_url":"https://api.github.com/repos/wojtek-t/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wojtek-t/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wojtek-t/kubernetes/teams","hooks_url":"https://api.github.com/repos/wojtek-t/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wojtek-t/kubernetes/events","assignees_url":"https://api.github.com/repos/wojtek-t/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wojtek-t/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wojtek-t/kubernetes/tags","blobs_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wojtek-t/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wojtek-t/kubernetes/languages","stargazers_url":"https://api.github.com/repos/wojtek-t/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wojtek-t/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wojtek-t/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wojtek-t/kubernetes/subscription","commits_url":"https://api.github.com/repos/wojtek-t/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wojtek-t/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wojtek-t/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wojtek-t/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wojtek-t/kubernetes/merges","archive_url":"https://api.github.com/repos/wojtek-t/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wojtek-t/kubernetes/downloads","issues_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wojtek-t/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wojtek-t/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wojtek-t/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wojtek-t/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wojtek-t/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/wojtek-t/kubernetes/deployments","created_at":"2015-02-03T00:37:55Z","updated_at":"2015-04-30T12:14:58Z","pushed_at":"2017-03-01T16:49:44Z","git_url":"git://github.com/wojtek-t/kubernetes.git","ssh_url":"[email protected]:wojtek-t/kubernetes.git","clone_url":"https://github.com/wojtek-t/kubernetes.git","svn_url":"https://github.com/wojtek-t/kubernetes","homepage":"http://kubernetes.io","size":390061,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c7b53794d0c6290a90345a16a79ca2f797933f4d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-03-01T16:44:16Z","pushed_at":"2017-03-01T16:49:48Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"[email protected]:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":561032,"stargazers_count":21043,"watchers_count":21043,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7185,"mirror_url":null,"open_issues_count":5694,"forks":7185,"open_issues":5694,"watchers":21043,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42266"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/42266"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/42266"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/42266/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42266/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42266/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1c295635a9c485394a559214ebc4258d60ed80a9"}}}} | {
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
} | {
"id": 10743879,
"login": "wojtek-t",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10743879?",
"url": "https://api.github.com/users/wojtek-t"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-03-01T16:49:36 | 5413489470 | {"actor":{"display_login":"wojtek-t"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/134931024","pull_request_review_id":58279865,"id":134931024,"diff_hunk":"@@ -0,0 +1,151 @@\n+/*\n+Copyright 2017 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package gce\n+\n+import (\n+\t\"strings\"\n+\t\"time\"\n+\n+\tcomputealpha \"google.golang.org/api/compute/v0.alpha\"\n+)\n+\n+const (\n+\tExperimentalKey = \"X-Goog-Experiments\"\n+\tNEGExperimentalValue = \"EnableNetworkEndpointGroup\"\n+\tNEGLoadBalancerType = \"LOAD_BALANCING\"\n+\tNEGIPPortNetworkEndpointType = \"GCE_VM_IP_PORT\"\n+)\n+\n+func newNetworkEndpointGroupMetricContext(request string, zone string) *metricContext {\n+\tzoneLabel := zone\n+\tif len(strings.TrimSpace(zone)) == 0 {\n+\t\tzoneLabel = unusedMetricLabel\n+\t}\n+\treturn &metricContext{\n+\t\tstart: time.Now(),\n+\t\tattributes: []string{\"networkendpointgroup_\" + request, unusedMetricLabel, zoneLabel},\n+\t}\n+}\n+\n+func (gce *GCECloud) GetNetworkEndpointGroup(name string, zone string) (*computealpha.NetworkEndpointGroup, error) {\n+\tif err := gce.alphaFeatureEnabled(AlphaFeatureNetworkEndpointGroup); err != nil {\n+\t\treturn nil, err\n+\t}\n+\tmc := newNetworkEndpointGroupMetricContext(\"get\", zone)\n+\tv, err := gce.serviceAlpha.NetworkEndpointGroups.Get(gce.GetProjectID(), zone, name).Do()\n+\treturn v, mc.Observe(err)\n+}\n+\n+func (gce *GCECloud) ListNetworkEndpointGroup(zone string) (*computealpha.NetworkEndpointGroupList, error) {\n+\tif err := gce.alphaFeatureEnabled(AlphaFeatureNetworkEndpointGroup); err != nil {\n+\t\treturn nil, err\n+\t}\n+\tmc := newNetworkEndpointGroupMetricContext(\"list\", zone)\n+\tv, err := gce.serviceAlpha.NetworkEndpointGroups.List(gce.GetProjectID(), zone).Do()\n+\treturn v, mc.Observe(err)\n+}\n+\n+func (gce *GCECloud) AggregatedListNetworkEndpointGroup() (*computealpha.NetworkEndpointGroupAggregatedList, error) {\n+\tif err := gce.alphaFeatureEnabled(AlphaFeatureNetworkEndpointGroup); err != nil {\n+\t\treturn nil, err\n+\t}\n+\tmc := newNetworkEndpointGroupMetricContext(\"aggregated\", \"\")\n+\tv, err := gce.serviceAlpha.NetworkEndpointGroups.AggregatedList(gce.GetProjectID()).Do()\n+\treturn v, mc.Observe(err)\n+}\n+\n+func (gce *GCECloud) CreateNetworkEndpointGroup(neg *computealpha.NetworkEndpointGroup, zone string) error {\n+\tif err := gce.alphaFeatureEnabled(AlphaFeatureNetworkEndpointGroup); err != nil {\n+\t\treturn err\n+\t}\n+\tmc := newNetworkEndpointGroupMetricContext(\"create\", zone)\n+\tcall := gce.serviceAlpha.NetworkEndpointGroups.Insert(gce.GetProjectID(), zone, neg)\n+\t// TODO: remove this after NEG is enabled\n+\tcall.Header().Add(ExperimentalKey, NEGExperimentalValue)\n+\top, err := call.Do()\n+\tif err != nil {\n+\t\treturn mc.Observe(err)\n+\t}\n+\treturn gce.waitForZoneOp(op, zone, mc)\n+}\n+\n+func (gce *GCECloud) DeleteNetworkEndpointGroup(name string, zone string) error {\n+\tif err := gce.alphaFeatureEnabled(AlphaFeatureNetworkEndpointGroup); err != nil {\n+\t\treturn err\n+\t}\n+\tmc := newNetworkEndpointGroupMetricContext(\"delete\", zone)\n+\tcall := gce.serviceAlpha.NetworkEndpointGroups.Delete(gce.GetProjectID(), zone, name)\n+\t// TODO: remove this after NEG is enabled\n+\tcall.Header().Add(\"X-Goog-Experiments\", \"EnableNetworkEndpointGroup\")\n+\top, err := call.Do()\n+\tif err != nil {\n+\t\treturn mc.Observe(err)\n+\t}\n+\treturn gce.waitForZoneOp(op, zone, mc)\n+}\n+\n+func (gce *GCECloud) AttachNetworkEndpoints(name, zone string, endpoints []*computealpha.NetworkEndpoint) error {\n+\tif err := gce.alphaFeatureEnabled(AlphaFeatureNetworkEndpointGroup); err != nil {\n+\t\treturn err\n+\t}\n+\tmc := newNetworkEndpointGroupMetricContext(\"attach\", zone)\n+\tcall := gce.serviceAlpha.NetworkEndpointGroups.AttachNetworkEndpoints(gce.GetProjectID(), zone, name, &computealpha.NetworkEndpointGroupsAttachEndpointsRequest{\n+\t\tNetworkEndpoints: endpoints,\n+\t})\n+\t// TODO: remove this after NEG is enabled\n+\tcall.Header().Add(\"X-Goog-Experiments\", \"EnableNetworkEndpointGroup\")","path":"pkg/cloudprovider/providers/gce/gce_networkendpointgroup.go","position":110,"original_position":110,"commit_id":"567615dc1937700a2a845bd03d2cff5b8e912d3b","original_commit_id":"567615dc1937700a2a845bd03d2cff5b8e912d3b","user":{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"body":"use the constants you created","created_at":"2017-08-24T05:44:53Z","updated_at":"2017-08-24T05:45:36Z","html_url":"https://github.com/kubernetes/kubernetes/pull/51067#discussion_r134931024","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51067","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/134931024"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/51067#discussion_r134931024"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51067"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51067","id":136872774,"html_url":"https://github.com/kubernetes/kubernetes/pull/51067","diff_url":"https://github.com/kubernetes/kubernetes/pull/51067.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/51067.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51067","number":51067,"state":"open","locked":false,"title":"neg cloud provider","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars3.githubusercontent.com/u/1332699?v=4","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2017-08-22T01:13:42Z","updated_at":"2017-08-24T05:45:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a7935e7c1b408b5b0cd03b6aa99916659f98d33","assignee":{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false},"assignees":[{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false},{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36","html_url":"https://github.com/kubernetes/kubernetes/milestone/36","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36/labels","id":2545392,"number":36,"title":"v1.8","description":"Kubernetes 1.8 release milestone, date is TBD.","creator":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"open_issues":233,"closed_issues":218,"state":"open","created_at":"2017-05-26T17:18:43Z","updated_at":"2017-08-24T00:41:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51067/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51067/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51067/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/567615dc1937700a2a845bd03d2cff5b8e912d3b","head":{"label":"freehan:cloud-provider-neg","ref":"cloud-provider-neg","sha":"567615dc1937700a2a845bd03d2cff5b8e912d3b","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars3.githubusercontent.com/u/1332699?v=4","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"repo":{"id":45570688,"name":"kubernetes","full_name":"freehan/kubernetes","owner":{"login":"freehan","id":1332699,"avatar_url":"https://avatars3.githubusercontent.com/u/1332699?v=4","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freehan/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/freehan/kubernetes","forks_url":"https://api.github.com/repos/freehan/kubernetes/forks","keys_url":"https://api.github.com/repos/freehan/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freehan/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freehan/kubernetes/teams","hooks_url":"https://api.github.com/repos/freehan/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/freehan/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/freehan/kubernetes/events","assignees_url":"https://api.github.com/repos/freehan/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/freehan/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/freehan/kubernetes/tags","blobs_url":"https://api.github.com/repos/freehan/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freehan/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freehan/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/freehan/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freehan/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/freehan/kubernetes/languages","stargazers_url":"https://api.github.com/repos/freehan/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/freehan/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/freehan/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/freehan/kubernetes/subscription","commits_url":"https://api.github.com/repos/freehan/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/freehan/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/freehan/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/freehan/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/freehan/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/freehan/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freehan/kubernetes/merges","archive_url":"https://api.github.com/repos/freehan/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freehan/kubernetes/downloads","issues_url":"https://api.github.com/repos/freehan/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/freehan/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/freehan/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/freehan/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freehan/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/freehan/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/freehan/kubernetes/deployments","created_at":"2015-11-04T22:09:37Z","updated_at":"2016-01-13T01:28:27Z","pushed_at":"2017-08-23T22:36:29Z","git_url":"git://github.com/freehan/kubernetes.git","ssh_url":"[email protected]:freehan/kubernetes.git","clone_url":"https://github.com/freehan/kubernetes.git","svn_url":"https://github.com/freehan/kubernetes","homepage":"http://kubernetes.io","size":460353,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b973d65ccca68119c857ff53d2f2fdf13545137b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-08-24T04:47:19Z","pushed_at":"2017-08-24T05:38:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"[email protected]:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":679466,"stargazers_count":26230,"watchers_count":26230,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9343,"mirror_url":null,"open_issues_count":5381,"forks":9343,"open_issues":5381,"watchers":26230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51067"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/51067"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/51067"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/51067/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51067/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51067/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/567615dc1937700a2a845bd03d2cff5b8e912d3b"}}}} | {
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
} | {
"id": 837034,
"login": "bowei",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/837034?",
"url": "https://api.github.com/users/bowei"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-08-24T05:44:53 | 6505784603 | {"actor":{"display_login":"bowei"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments/143595353","pull_request_review_id":68123758,"id":143595353,"diff_hunk":"@@ -0,0 +1,11 @@\n+id: application-architect\n+name: Application Architect\n+related:\n+ - application-developer\n+tags:\n+ - user-type\n+short-description: |\n+ A person concerned with the high-level design of an application.\n+long-description: |\n+ The architect typically ensures that the app's implementation allows it to interact with its surrounding components in a scalable, maintainable way.\n+ These other components are often databases, logging infrastructure, and other microservices.","path":"_data/glossary/application-architect.yaml","position":11,"original_position":11,"commit_id":"ce9a27195c23bd28d18cfd61d71bccf7393e0734","original_commit_id":"ce9a27195c23bd28d18cfd61d71bccf7393e0734","user":{"login":"zacharysarah","id":3210446,"avatar_url":"https://avatars1.githubusercontent.com/u/3210446?v=4","gravatar_id":"","url":"https://api.github.com/users/zacharysarah","html_url":"https://github.com/zacharysarah","followers_url":"https://api.github.com/users/zacharysarah/followers","following_url":"https://api.github.com/users/zacharysarah/following{/other_user}","gists_url":"https://api.github.com/users/zacharysarah/gists{/gist_id}","starred_url":"https://api.github.com/users/zacharysarah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zacharysarah/subscriptions","organizations_url":"https://api.github.com/users/zacharysarah/orgs","repos_url":"https://api.github.com/users/zacharysarah/repos","events_url":"https://api.github.com/users/zacharysarah/events{/privacy}","received_events_url":"https://api.github.com/users/zacharysarah/received_events","type":"User","site_admin":false},"body":"Surrounding components include databases, ...","created_at":"2017-10-09T22:50:40Z","updated_at":"2017-10-09T23:00:54Z","html_url":"https://github.com/kubernetes/kubernetes.github.io/pull/5657#discussion_r143595353","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/5657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments/143595353"},"html":{"href":"https://github.com/kubernetes/kubernetes.github.io/pull/5657#discussion_r143595353"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/5657"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/5657","id":143425606,"html_url":"https://github.com/kubernetes/kubernetes.github.io/pull/5657","diff_url":"https://github.com/kubernetes/kubernetes.github.io/pull/5657.diff","patch_url":"https://github.com/kubernetes/kubernetes.github.io/pull/5657.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/5657","number":5657,"state":"open","locked":false,"title":"[docs][glossary] Add page that lists all standardized k8s terms","user":{"login":"abiogenesis-now","id":25401650,"avatar_url":"https://avatars0.githubusercontent.com/u/25401650?v=4","gravatar_id":"","url":"https://api.github.com/users/abiogenesis-now","html_url":"https://github.com/abiogenesis-now","followers_url":"https://api.github.com/users/abiogenesis-now/followers","following_url":"https://api.github.com/users/abiogenesis-now/following{/other_user}","gists_url":"https://api.github.com/users/abiogenesis-now/gists{/gist_id}","starred_url":"https://api.github.com/users/abiogenesis-now/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abiogenesis-now/subscriptions","organizations_url":"https://api.github.com/users/abiogenesis-now/orgs","repos_url":"https://api.github.com/users/abiogenesis-now/repos","events_url":"https://api.github.com/users/abiogenesis-now/events{/privacy}","received_events_url":"https://api.github.com/users/abiogenesis-now/received_events","type":"User","site_admin":false},"body":"@chenopis This PR is a quick prototype of what we discussed last week. You mentioned that Sarah (or was it Paris?) thought it would be worth formally defining \"user persona terms\" like \"cluster operator\" and \"application developer.\"\r\n\r\nI put the link to this glossary page under *Reference*. You may have mentioned putting it on the home page--I think that categorically it makes sense under \"Reference\", but was that suggestion due to visibility concerns? If you feel strongly I can move it.\r\n\r\n**GIF of final product, illustrating all the random features:**\r\n\r\n\r\n\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes.github.io/5657)\r\n<!-- Reviewable:end -->\r\n","created_at":"2017-09-27T15:29:35Z","updated_at":"2017-10-09T23:00:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b929236e45bfb3fef3568b1d71c230aef768953e","assignee":{"login":"Bradamant3","id":6934230,"avatar_url":"https://avatars2.githubusercontent.com/u/6934230?v=4","gravatar_id":"","url":"https://api.github.com/users/Bradamant3","html_url":"https://github.com/Bradamant3","followers_url":"https://api.github.com/users/Bradamant3/followers","following_url":"https://api.github.com/users/Bradamant3/following{/other_user}","gists_url":"https://api.github.com/users/Bradamant3/gists{/gist_id}","starred_url":"https://api.github.com/users/Bradamant3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bradamant3/subscriptions","organizations_url":"https://api.github.com/users/Bradamant3/orgs","repos_url":"https://api.github.com/users/Bradamant3/repos","events_url":"https://api.github.com/users/Bradamant3/events{/privacy}","received_events_url":"https://api.github.com/users/Bradamant3/received_events","type":"User","site_admin":false},"assignees":[{"login":"Bradamant3","id":6934230,"avatar_url":"https://avatars2.githubusercontent.com/u/6934230?v=4","gravatar_id":"","url":"https://api.github.com/users/Bradamant3","html_url":"https://github.com/Bradamant3","followers_url":"https://api.github.com/users/Bradamant3/followers","following_url":"https://api.github.com/users/Bradamant3/following{/other_user}","gists_url":"https://api.github.com/users/Bradamant3/gists{/gist_id}","starred_url":"https://api.github.com/users/Bradamant3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bradamant3/subscriptions","organizations_url":"https://api.github.com/users/Bradamant3/orgs","repos_url":"https://api.github.com/users/Bradamant3/repos","events_url":"https://api.github.com/users/Bradamant3/events{/privacy}","received_events_url":"https://api.github.com/users/Bradamant3/received_events","type":"User","site_admin":false},{"login":"steveperry-53","id":13792782,"avatar_url":"https://avatars2.githubusercontent.com/u/13792782?v=4","gravatar_id":"","url":"https://api.github.com/users/steveperry-53","html_url":"https://github.com/steveperry-53","followers_url":"https://api.github.com/users/steveperry-53/followers","following_url":"https://api.github.com/users/steveperry-53/following{/other_user}","gists_url":"https://api.github.com/users/steveperry-53/gists{/gist_id}","starred_url":"https://api.github.com/users/steveperry-53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveperry-53/subscriptions","organizations_url":"https://api.github.com/users/steveperry-53/orgs","repos_url":"https://api.github.com/users/steveperry-53/repos","events_url":"https://api.github.com/users/steveperry-53/events{/privacy}","received_events_url":"https://api.github.com/users/steveperry-53/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"parispittman","id":5912992,"avatar_url":"https://avatars2.githubusercontent.com/u/5912992?v=4","gravatar_id":"","url":"https://api.github.com/users/parispittman","html_url":"https://github.com/parispittman","followers_url":"https://api.github.com/users/parispittman/followers","following_url":"https://api.github.com/users/parispittman/following{/other_user}","gists_url":"https://api.github.com/users/parispittman/gists{/gist_id}","starred_url":"https://api.github.com/users/parispittman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parispittman/subscriptions","organizations_url":"https://api.github.com/users/parispittman/orgs","repos_url":"https://api.github.com/users/parispittman/repos","events_url":"https://api.github.com/users/parispittman/events{/privacy}","received_events_url":"https://api.github.com/users/parispittman/received_events","type":"User","site_admin":false},{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars1.githubusercontent.com/u/7725777?v=4","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},{"login":"matchstick","id":19715963,"avatar_url":"https://avatars2.githubusercontent.com/u/19715963?v=4","gravatar_id":"","url":"https://api.github.com/users/matchstick","html_url":"https://github.com/matchstick","followers_url":"https://api.github.com/users/matchstick/followers","following_url":"https://api.github.com/users/matchstick/following{/other_user}","gists_url":"https://api.github.com/users/matchstick/gists{/gist_id}","starred_url":"https://api.github.com/users/matchstick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matchstick/subscriptions","organizations_url":"https://api.github.com/users/matchstick/orgs","repos_url":"https://api.github.com/users/matchstick/repos","events_url":"https://api.github.com/users/matchstick/events{/privacy}","received_events_url":"https://api.github.com/users/matchstick/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/milestones/14","html_url":"https://github.com/kubernetes/kubernetes.github.io/milestone/14","labels_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/milestones/14/labels","id":2708567,"number":14,"title":"Glossary","description":null,"creator":{"login":"chenopis","id":24798125,"avatar_url":"https://avatars1.githubusercontent.com/u/24798125?v=4","gravatar_id":"","url":"https://api.github.com/users/chenopis","html_url":"https://github.com/chenopis","followers_url":"https://api.github.com/users/chenopis/followers","following_url":"https://api.github.com/users/chenopis/following{/other_user}","gists_url":"https://api.github.com/users/chenopis/gists{/gist_id}","starred_url":"https://api.github.com/users/chenopis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenopis/subscriptions","organizations_url":"https://api.github.com/users/chenopis/orgs","repos_url":"https://api.github.com/users/chenopis/repos","events_url":"https://api.github.com/users/chenopis/events{/privacy}","received_events_url":"https://api.github.com/users/chenopis/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":6,"state":"open","created_at":"2017-08-17T23:59:21Z","updated_at":"2017-09-27T17:00:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/5657/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/5657/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/5657/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/ce9a27195c23bd28d18cfd61d71bccf7393e0734","head":{"label":"abiogenesis-now:jyao/glossary-page","ref":"jyao/glossary-page","sha":"ce9a27195c23bd28d18cfd61d71bccf7393e0734","user":{"login":"abiogenesis-now","id":25401650,"avatar_url":"https://avatars0.githubusercontent.com/u/25401650?v=4","gravatar_id":"","url":"https://api.github.com/users/abiogenesis-now","html_url":"https://github.com/abiogenesis-now","followers_url":"https://api.github.com/users/abiogenesis-now/followers","following_url":"https://api.github.com/users/abiogenesis-now/following{/other_user}","gists_url":"https://api.github.com/users/abiogenesis-now/gists{/gist_id}","starred_url":"https://api.github.com/users/abiogenesis-now/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abiogenesis-now/subscriptions","organizations_url":"https://api.github.com/users/abiogenesis-now/orgs","repos_url":"https://api.github.com/users/abiogenesis-now/repos","events_url":"https://api.github.com/users/abiogenesis-now/events{/privacy}","received_events_url":"https://api.github.com/users/abiogenesis-now/received_events","type":"User","site_admin":false},"repo":{"id":95401157,"name":"kubernetes.github.io","full_name":"abiogenesis-now/kubernetes.github.io","owner":{"login":"abiogenesis-now","id":25401650,"avatar_url":"https://avatars0.githubusercontent.com/u/25401650?v=4","gravatar_id":"","url":"https://api.github.com/users/abiogenesis-now","html_url":"https://github.com/abiogenesis-now","followers_url":"https://api.github.com/users/abiogenesis-now/followers","following_url":"https://api.github.com/users/abiogenesis-now/following{/other_user}","gists_url":"https://api.github.com/users/abiogenesis-now/gists{/gist_id}","starred_url":"https://api.github.com/users/abiogenesis-now/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abiogenesis-now/subscriptions","organizations_url":"https://api.github.com/users/abiogenesis-now/orgs","repos_url":"https://api.github.com/users/abiogenesis-now/repos","events_url":"https://api.github.com/users/abiogenesis-now/events{/privacy}","received_events_url":"https://api.github.com/users/abiogenesis-now/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abiogenesis-now/kubernetes.github.io","description":"Kubernetes website and documentation repo: ","fork":true,"url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io","forks_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/forks","keys_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/teams","hooks_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/hooks","issue_events_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/events","assignees_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/tags","blobs_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/languages","stargazers_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/stargazers","contributors_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/contributors","subscribers_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/subscribers","subscription_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/subscription","commits_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/merges","archive_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/downloads","issues_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/labels{/name}","releases_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/abiogenesis-now/kubernetes.github.io/deployments","created_at":"2017-06-26T02:37:23Z","updated_at":"2017-06-26T02:37:27Z","pushed_at":"2017-10-09T16:07:45Z","git_url":"git://github.com/abiogenesis-now/kubernetes.github.io.git","ssh_url":"[email protected]:abiogenesis-now/kubernetes.github.io.git","clone_url":"https://github.com/abiogenesis-now/kubernetes.github.io.git","svn_url":"https://github.com/abiogenesis-now/kubernetes.github.io","homepage":"https://kubernetes.github.io","size":58554,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"fc2a3f62a9a13bc1bba2fefb9afa86ab6fb11e84","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"name":"kubernetes.github.io","full_name":"kubernetes/kubernetes.github.io","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes.github.io","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io","forks_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2017-10-06T12:29:17Z","pushed_at":"2017-10-09T21:54:24Z","git_url":"git://github.com/kubernetes/kubernetes.github.io.git","ssh_url":"[email protected]:kubernetes/kubernetes.github.io.git","clone_url":"https://github.com/kubernetes/kubernetes.github.io.git","svn_url":"https://github.com/kubernetes/kubernetes.github.io","homepage":"https://kubernetes.github.io","size":79824,"stargazers_count":251,"watchers_count":251,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1728,"mirror_url":null,"open_issues_count":478,"forks":1728,"open_issues":478,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/5657"},"html":{"href":"https://github.com/kubernetes/kubernetes.github.io/pull/5657"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/5657"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/5657/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/5657/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/5657/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/ce9a27195c23bd28d18cfd61d71bccf7393e0734"}},"author_association":"CONTRIBUTOR"}} | {
"id": 51478266,
"name": "kubernetes/kubernetes.github.io",
"url": "https://api.github.com/repos/kubernetes/kubernetes.github.io"
} | {
"id": 3210446,
"login": "zacharysarah",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3210446?",
"url": "https://api.github.com/users/zacharysarah"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-10-09T22:50:40 | 6694008108 | {"actor":{"display_login":"zacharysarah"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments/146899217","pull_request_review_id":71910745,"id":146899217,"diff_hunk":"@@ -224,6 +224,9 @@ func ScaleUp(context *AutoscalingContext, unschedulablePods []*apiv1.Pod, nodes\n \t\t\t\t\tnodeInfos[newId] = nodeInfos[oldId]\n \t\t\t\t\tdelete(nodeInfos, oldId)\n \t\t\t\t}\n+\t\t\t\tcontext.LogRecorder.Eventf(apiv1.EventTypeNormal, \"CreatedNodeGroup\",\n+\t\t\t\t\t\"NodeAutoprovisioning: create new node group %v\", newId)","path":"cluster-autoscaler/core/scale_up.go","position":null,"original_position":5,"commit_id":"9c2ebccbfef4d6640a489cbc2fdfd8ca0007032d","original_commit_id":"f3940101d88eb8132409398c840079bfc36cb1f9","user":{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"body":"fixed tense in message to be consistent","created_at":"2017-10-25T15:41:02Z","updated_at":"2017-10-25T15:41:02Z","html_url":"https://github.com/kubernetes/autoscaler/pull/420#discussion_r146899217","pull_request_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/420","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments/146899217"},"html":{"href":"https://github.com/kubernetes/autoscaler/pull/420#discussion_r146899217"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/420"}},"in_reply_to_id":146844051},"pull_request":{"url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/420","id":148654199,"html_url":"https://github.com/kubernetes/autoscaler/pull/420","diff_url":"https://github.com/kubernetes/autoscaler/pull/420.diff","patch_url":"https://github.com/kubernetes/autoscaler/pull/420.patch","issue_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/420","number":420,"state":"open","locked":false,"title":"Write events when autoprovisioned nodegroup is created / deleted","user":{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-25T12:33:32Z","updated_at":"2017-10-25T15:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4f84a8d54bb030fcf085c16dabdb16dc0e18ef4","assignee":{"login":"aleksandra-malinowska","id":4884414,"avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false},"assignees":[{"login":"aleksandra-malinowska","id":4884414,"avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/420/commits","review_comments_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/420/comments","review_comment_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/420/comments","statuses_url":"https://api.github.com/repos/kubernetes/autoscaler/statuses/9c2ebccbfef4d6640a489cbc2fdfd8ca0007032d","head":{"label":"MaciekPytel:nap_events","ref":"nap_events","sha":"9c2ebccbfef4d6640a489cbc2fdfd8ca0007032d","user":{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"repo":{"id":88637049,"name":"autoscaler","full_name":"MaciekPytel/autoscaler","owner":{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaciekPytel/autoscaler","description":null,"fork":true,"url":"https://api.github.com/repos/MaciekPytel/autoscaler","forks_url":"https://api.github.com/repos/MaciekPytel/autoscaler/forks","keys_url":"https://api.github.com/repos/MaciekPytel/autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaciekPytel/autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaciekPytel/autoscaler/teams","hooks_url":"https://api.github.com/repos/MaciekPytel/autoscaler/hooks","issue_events_url":"https://api.github.com/repos/MaciekPytel/autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/MaciekPytel/autoscaler/events","assignees_url":"https://api.github.com/repos/MaciekPytel/autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/MaciekPytel/autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/MaciekPytel/autoscaler/tags","blobs_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaciekPytel/autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/MaciekPytel/autoscaler/languages","stargazers_url":"https://api.github.com/repos/MaciekPytel/autoscaler/stargazers","contributors_url":"https://api.github.com/repos/MaciekPytel/autoscaler/contributors","subscribers_url":"https://api.github.com/repos/MaciekPytel/autoscaler/subscribers","subscription_url":"https://api.github.com/repos/MaciekPytel/autoscaler/subscription","commits_url":"https://api.github.com/repos/MaciekPytel/autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaciekPytel/autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaciekPytel/autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaciekPytel/autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/MaciekPytel/autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaciekPytel/autoscaler/merges","archive_url":"https://api.github.com/repos/MaciekPytel/autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaciekPytel/autoscaler/downloads","issues_url":"https://api.github.com/repos/MaciekPytel/autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/MaciekPytel/autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/MaciekPytel/autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/MaciekPytel/autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaciekPytel/autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/MaciekPytel/autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/MaciekPytel/autoscaler/deployments","created_at":"2017-04-18T14:51:45Z","updated_at":"2017-04-18T14:51:47Z","pushed_at":"2017-10-25T15:39:49Z","git_url":"git://github.com/MaciekPytel/autoscaler.git","ssh_url":"[email protected]:MaciekPytel/autoscaler.git","clone_url":"https://github.com/MaciekPytel/autoscaler.git","svn_url":"https://github.com/MaciekPytel/autoscaler","homepage":null,"size":20167,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c7aa56a82a4c92ddc65938c7e9bd05243b87d95d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":87990209,"name":"autoscaler","full_name":"kubernetes/autoscaler","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/autoscaler","description":"Autoscaling components for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/autoscaler","forks_url":"https://api.github.com/repos/kubernetes/autoscaler/forks","keys_url":"https://api.github.com/repos/kubernetes/autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/autoscaler/teams","hooks_url":"https://api.github.com/repos/kubernetes/autoscaler/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/autoscaler/events","assignees_url":"https://api.github.com/repos/kubernetes/autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/autoscaler/tags","blobs_url":"https://api.github.com/repos/kubernetes/autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/autoscaler/languages","stargazers_url":"https://api.github.com/repos/kubernetes/autoscaler/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/autoscaler/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/autoscaler/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/autoscaler/subscription","commits_url":"https://api.github.com/repos/kubernetes/autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/autoscaler/merges","archive_url":"https://api.github.com/repos/kubernetes/autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/autoscaler/downloads","issues_url":"https://api.github.com/repos/kubernetes/autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/autoscaler/deployments","created_at":"2017-04-12T00:03:40Z","updated_at":"2017-10-25T13:36:12Z","pushed_at":"2017-10-25T15:39:50Z","git_url":"git://github.com/kubernetes/autoscaler.git","ssh_url":"[email protected]:kubernetes/autoscaler.git","clone_url":"https://github.com/kubernetes/autoscaler.git","svn_url":"https://github.com/kubernetes/autoscaler","homepage":"","size":20614,"stargazers_count":254,"watchers_count":254,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"open_issues_count":44,"forks":126,"open_issues":44,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/420"},"html":{"href":"https://github.com/kubernetes/autoscaler/pull/420"},"issue":{"href":"https://api.github.com/repos/kubernetes/autoscaler/issues/420"},"comments":{"href":"https://api.github.com/repos/kubernetes/autoscaler/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/autoscaler/statuses/9c2ebccbfef4d6640a489cbc2fdfd8ca0007032d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 87990209,
"name": "kubernetes/autoscaler",
"url": "https://api.github.com/repos/kubernetes/autoscaler"
} | {
"id": 7901030,
"login": "MaciekPytel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7901030?",
"url": "https://api.github.com/users/MaciekPytel"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-10-25T15:41:02 | 6764756442 | {"actor":{"display_login":"MaciekPytel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/website/pulls/comments/150717665","pull_request_review_id":76308930,"id":150717665,"diff_hunk":"@@ -188,17 +193,21 @@ used to verify the serving certificate of the apiserver.\n Finally, the default namespace to be used for namespaced API operations is placed in a file\n at `/var/run/secrets/kubernetes.io/serviceaccount/namespace` in each container.\n \n-From within a pod the recommended ways to connect to API are:\n+From within a Pod, the recommended ways to connect to the Kubernetes API are:\n+\n+ - use one of the official [client libraries](/docs/reference/client-libraries/)\n+ as they handle API host discovery and authentication out of the box.\n+ For Go client, the `rest.InClusterConfig()` function assists with this.\n+ See [an example here](https://git.k8s.io/client-go/examples/in-cluster-client-configuration/main.go).\n \n- - run a kubectl proxy as one of the containers in the pod, or as a background\n- process within a container. This proxies the\n- Kubernetes API to the localhost interface of the pod, so that other processes\n- in any container of the pod can access it. See this [example of using kubectl proxy\n- in a pod](https://github.com/kubernetes/examples/tree/{{page.githubbranch}}/staging/kubectl-container/).\n- - use the Go client library, and create a client using the `rest.InClusterConfig()` and `kubernetes.NewForConfig()` functions.\n- They handle locating and authenticating to the apiserver. [example](https://git.k8s.io/client-go/examples/in-cluster-client-configuration/main.go)\n+ - if you would like to query the API without an official client library, you can run `kubectl proxy`\n+ as the [command](/docs/tasks/inject-data-application/define-command-argument-container/)\n+ of a new sidecar container in the Pod. This way, `kubectl proxy` will authenticate\n+ to the API and expose it on the `localhost` interface of the Pod, so that other containers\n+ in the Pod can use it directly.","path":"docs/tasks/administer-cluster/access-cluster-api.md","position":53,"original_position":53,"commit_id":"e03ab3d0b9f03021867fcaa225b457bae9884fc2","original_commit_id":"e03ab3d0b9f03021867fcaa225b457bae9884fc2","user":{"login":"steveperry-53","id":13792782,"avatar_url":"https://avatars2.githubusercontent.com/u/13792782?v=4","gravatar_id":"","url":"https://api.github.com/users/steveperry-53","html_url":"https://github.com/steveperry-53","followers_url":"https://api.github.com/users/steveperry-53/followers","following_url":"https://api.github.com/users/steveperry-53/following{/other_user}","gists_url":"https://api.github.com/users/steveperry-53/gists{/gist_id}","starred_url":"https://api.github.com/users/steveperry-53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveperry-53/subscriptions","organizations_url":"https://api.github.com/users/steveperry-53/orgs","repos_url":"https://api.github.com/users/steveperry-53/repos","events_url":"https://api.github.com/users/steveperry-53/events{/privacy}","received_events_url":"https://api.github.com/users/steveperry-53/received_events","type":"User","site_admin":false},"body":"Start bullet items with caps.\r\n\r\n- Use one ...\r\n- If you would like ...","created_at":"2017-11-14T01:47:33Z","updated_at":"2017-11-14T01:47:33Z","html_url":"https://github.com/kubernetes/website/pull/6259#discussion_r150717665","pull_request_url":"https://api.github.com/repos/kubernetes/website/pulls/6259","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments/150717665"},"html":{"href":"https://github.com/kubernetes/website/pull/6259#discussion_r150717665"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/website/pulls/6259"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/website/pulls/6259","id":151760047,"html_url":"https://github.com/kubernetes/website/pull/6259","diff_url":"https://github.com/kubernetes/website/pull/6259.diff","patch_url":"https://github.com/kubernetes/website/pull/6259.patch","issue_url":"https://api.github.com/repos/kubernetes/website/issues/6259","number":6259,"state":"open","locked":false,"title":"Improve \"authenticating to k8s api from a pod\" docs","user":{"login":"ahmetb","id":159209,"avatar_url":"https://avatars1.githubusercontent.com/u/159209?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmetb","html_url":"https://github.com/ahmetb","followers_url":"https://api.github.com/users/ahmetb/followers","following_url":"https://api.github.com/users/ahmetb/following{/other_user}","gists_url":"https://api.github.com/users/ahmetb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetb/subscriptions","organizations_url":"https://api.github.com/users/ahmetb/orgs","repos_url":"https://api.github.com/users/ahmetb/repos","events_url":"https://api.github.com/users/ahmetb/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetb/received_events","type":"User","site_admin":false},"body":"Helps with https://github.com/kubernetes/kubernetes/issues/22121.\r\nAlso removing the link to kubectl-container example which is staged for removal.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/website/6259)\n<!-- Reviewable:end -->\n","created_at":"2017-11-09T20:55:02Z","updated_at":"2017-11-14T01:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"612705e70bd8d2fbeaed9a7c5e6dfb94fbeccc5d","assignee":{"login":"Bradamant3","id":6934230,"avatar_url":"https://avatars2.githubusercontent.com/u/6934230?v=4","gravatar_id":"","url":"https://api.github.com/users/Bradamant3","html_url":"https://github.com/Bradamant3","followers_url":"https://api.github.com/users/Bradamant3/followers","following_url":"https://api.github.com/users/Bradamant3/following{/other_user}","gists_url":"https://api.github.com/users/Bradamant3/gists{/gist_id}","starred_url":"https://api.github.com/users/Bradamant3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bradamant3/subscriptions","organizations_url":"https://api.github.com/users/Bradamant3/orgs","repos_url":"https://api.github.com/users/Bradamant3/repos","events_url":"https://api.github.com/users/Bradamant3/events{/privacy}","received_events_url":"https://api.github.com/users/Bradamant3/received_events","type":"User","site_admin":false},"assignees":[{"login":"Bradamant3","id":6934230,"avatar_url":"https://avatars2.githubusercontent.com/u/6934230?v=4","gravatar_id":"","url":"https://api.github.com/users/Bradamant3","html_url":"https://github.com/Bradamant3","followers_url":"https://api.github.com/users/Bradamant3/followers","following_url":"https://api.github.com/users/Bradamant3/following{/other_user}","gists_url":"https://api.github.com/users/Bradamant3/gists{/gist_id}","starred_url":"https://api.github.com/users/Bradamant3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bradamant3/subscriptions","organizations_url":"https://api.github.com/users/Bradamant3/orgs","repos_url":"https://api.github.com/users/Bradamant3/repos","events_url":"https://api.github.com/users/Bradamant3/events{/privacy}","received_events_url":"https://api.github.com/users/Bradamant3/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/website/pulls/6259/commits","review_comments_url":"https://api.github.com/repos/kubernetes/website/pulls/6259/comments","review_comment_url":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/website/issues/6259/comments","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/e03ab3d0b9f03021867fcaa225b457bae9884fc2","head":{"label":"ahmetb:accessing-api","ref":"accessing-api","sha":"e03ab3d0b9f03021867fcaa225b457bae9884fc2","user":{"login":"ahmetb","id":159209,"avatar_url":"https://avatars1.githubusercontent.com/u/159209?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmetb","html_url":"https://github.com/ahmetb","followers_url":"https://api.github.com/users/ahmetb/followers","following_url":"https://api.github.com/users/ahmetb/following{/other_user}","gists_url":"https://api.github.com/users/ahmetb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetb/subscriptions","organizations_url":"https://api.github.com/users/ahmetb/orgs","repos_url":"https://api.github.com/users/ahmetb/repos","events_url":"https://api.github.com/users/ahmetb/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetb/received_events","type":"User","site_admin":false},"repo":{"id":74075197,"name":"kubernetes.github.io","full_name":"ahmetb/kubernetes.github.io","owner":{"login":"ahmetb","id":159209,"avatar_url":"https://avatars1.githubusercontent.com/u/159209?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmetb","html_url":"https://github.com/ahmetb","followers_url":"https://api.github.com/users/ahmetb/followers","following_url":"https://api.github.com/users/ahmetb/following{/other_user}","gists_url":"https://api.github.com/users/ahmetb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetb/subscriptions","organizations_url":"https://api.github.com/users/ahmetb/orgs","repos_url":"https://api.github.com/users/ahmetb/repos","events_url":"https://api.github.com/users/ahmetb/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetb/kubernetes.github.io","description":"Website/documentation repo","fork":true,"url":"https://api.github.com/repos/ahmetb/kubernetes.github.io","forks_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/forks","keys_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/teams","hooks_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/hooks","issue_events_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/events","assignees_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/tags","blobs_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/languages","stargazers_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/stargazers","contributors_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/contributors","subscribers_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/subscribers","subscription_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/subscription","commits_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/merges","archive_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/downloads","issues_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/labels{/name}","releases_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/ahmetb/kubernetes.github.io/deployments","created_at":"2016-11-17T23:03:41Z","updated_at":"2016-11-17T23:03:44Z","pushed_at":"2017-11-10T19:02:39Z","git_url":"git://github.com/ahmetb/kubernetes.github.io.git","ssh_url":"[email protected]:ahmetb/kubernetes.github.io.git","clone_url":"https://github.com/ahmetb/kubernetes.github.io.git","svn_url":"https://github.com/ahmetb/kubernetes.github.io","homepage":null,"size":65547,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"30116c4b629e715b28a484d752c93c34fa13c776","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"name":"website","full_name":"kubernetes/website","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/website","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/website","forks_url":"https://api.github.com/repos/kubernetes/website/forks","keys_url":"https://api.github.com/repos/kubernetes/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/website/teams","hooks_url":"https://api.github.com/repos/kubernetes/website/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/website/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/website/events","assignees_url":"https://api.github.com/repos/kubernetes/website/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/website/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/website/tags","blobs_url":"https://api.github.com/repos/kubernetes/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/website/languages","stargazers_url":"https://api.github.com/repos/kubernetes/website/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/website/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/website/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/website/subscription","commits_url":"https://api.github.com/repos/kubernetes/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/website/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/website/merges","archive_url":"https://api.github.com/repos/kubernetes/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/website/downloads","issues_url":"https://api.github.com/repos/kubernetes/website/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/website/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/website/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/website/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/website/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/website/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2017-11-14T00:22:53Z","pushed_at":"2017-11-14T01:22:58Z","git_url":"git://github.com/kubernetes/website.git","ssh_url":"[email protected]:kubernetes/website.git","clone_url":"https://github.com/kubernetes/website.git","svn_url":"https://github.com/kubernetes/website","homepage":"https://kubernetes.io","size":87825,"stargazers_count":280,"watchers_count":280,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1834,"mirror_url":null,"archived":false,"open_issues_count":526,"forks":1834,"open_issues":526,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/6259"},"html":{"href":"https://github.com/kubernetes/website/pull/6259"},"issue":{"href":"https://api.github.com/repos/kubernetes/website/issues/6259"},"comments":{"href":"https://api.github.com/repos/kubernetes/website/issues/6259/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/website/pulls/6259/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/website/pulls/6259/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/website/statuses/e03ab3d0b9f03021867fcaa225b457bae9884fc2"}},"author_association":"MEMBER"}} | {
"id": 51478266,
"name": "kubernetes/website",
"url": "https://api.github.com/repos/kubernetes/website"
} | {
"id": 13792782,
"login": "steveperry-53",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13792782?",
"url": "https://api.github.com/users/steveperry-53"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-11-14T01:47:33 | 6850190418 | {"actor":{"display_login":"steveperry-53"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/149175770","pull_request_review_id":74529430,"id":149175770,"diff_hunk":"@@ -793,7 +814,44 @@ var _ = SIGDescribe(\"Cluster size autoscaling [Slow]\", func() {\n \t\tframework.ExpectNoError(waitTillAllNAPNodePoolsAreRemoved())\n \t\tBy(\"Check if NAP group was removeed\")\n \t\tExpect(getNAPNodePoolsNumber()).Should(Equal(0))\n-\t\tframework.ExpectNoError(disableAutoprovisioning())\n+\t})\n+\n+\tIt(\"shouldn't add new node group if not needed [Feature:ClusterSizeAutoscalingScaleWithNAP]\", func() {\n+\t\tframework.SkipUnlessProviderIs(\"gke\")\n+\t\tconst extraPoolName = \"extra-pool\"\n+\t\taddNodePool(extraPoolName, \"n1-standard-4\", 0)","path":"test/e2e/autoscaling/cluster_size_autoscaling.go","position":null,"original_position":87,"commit_id":"89c96cf4ec605f16da30bba987772612205c19c6","original_commit_id":"7c35e18639b6507d34cc49c23493f2d1c7d9e96e","user":{"login":"krzysztof-jastrzebski","id":29974120,"avatar_url":"https://avatars0.githubusercontent.com/u/29974120?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysztof-jastrzebski","html_url":"https://github.com/krzysztof-jastrzebski","followers_url":"https://api.github.com/users/krzysztof-jastrzebski/followers","following_url":"https://api.github.com/users/krzysztof-jastrzebski/following{/other_user}","gists_url":"https://api.github.com/users/krzysztof-jastrzebski/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysztof-jastrzebski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysztof-jastrzebski/subscriptions","organizations_url":"https://api.github.com/users/krzysztof-jastrzebski/orgs","repos_url":"https://api.github.com/users/krzysztof-jastrzebski/repos","events_url":"https://api.github.com/users/krzysztof-jastrzebski/events{/privacy}","received_events_url":"https://api.github.com/users/krzysztof-jastrzebski/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-11-06T19:19:42Z","updated_at":"2017-11-06T19:19:42Z","html_url":"https://github.com/kubernetes/kubernetes/pull/55061#discussion_r149175770","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55061","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/149175770"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/55061#discussion_r149175770"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55061"}},"in_reply_to_id":149107735},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55061","id":150538457,"html_url":"https://github.com/kubernetes/kubernetes/pull/55061","diff_url":"https://github.com/kubernetes/kubernetes/pull/55061.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/55061.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55061","number":55061,"state":"open","locked":false,"title":"Adds e2e tests for Node Autoprovisioning:","user":{"login":"krzysztof-jastrzebski","id":29974120,"avatar_url":"https://avatars0.githubusercontent.com/u/29974120?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysztof-jastrzebski","html_url":"https://github.com/krzysztof-jastrzebski","followers_url":"https://api.github.com/users/krzysztof-jastrzebski/followers","following_url":"https://api.github.com/users/krzysztof-jastrzebski/following{/other_user}","gists_url":"https://api.github.com/users/krzysztof-jastrzebski/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysztof-jastrzebski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysztof-jastrzebski/subscriptions","organizations_url":"https://api.github.com/users/krzysztof-jastrzebski/orgs","repos_url":"https://api.github.com/users/krzysztof-jastrzebski/repos","events_url":"https://api.github.com/users/krzysztof-jastrzebski/events{/privacy}","received_events_url":"https://api.github.com/users/krzysztof-jastrzebski/received_events","type":"User","site_admin":false},"body":" Adds e2e tests for Node Autoprovisioning:\r\n - shouldn't add new node group if not needed\r\n - shouldn't scale up if cores limit too low, should scale up after limit is changed\r\n","created_at":"2017-11-03T14:16:03Z","updated_at":"2017-11-06T19:19:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c568b8e2e4e0329cd660dcb2f4290ea599f7f64e","assignee":{"login":"bskiba","id":3731277,"avatar_url":"https://avatars1.githubusercontent.com/u/3731277?v=4","gravatar_id":"","url":"https://api.github.com/users/bskiba","html_url":"https://github.com/bskiba","followers_url":"https://api.github.com/users/bskiba/followers","following_url":"https://api.github.com/users/bskiba/following{/other_user}","gists_url":"https://api.github.com/users/bskiba/gists{/gist_id}","starred_url":"https://api.github.com/users/bskiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bskiba/subscriptions","organizations_url":"https://api.github.com/users/bskiba/orgs","repos_url":"https://api.github.com/users/bskiba/repos","events_url":"https://api.github.com/users/bskiba/events{/privacy}","received_events_url":"https://api.github.com/users/bskiba/received_events","type":"User","site_admin":false},"assignees":[{"login":"bskiba","id":3731277,"avatar_url":"https://avatars1.githubusercontent.com/u/3731277?v=4","gravatar_id":"","url":"https://api.github.com/users/bskiba","html_url":"https://github.com/bskiba","followers_url":"https://api.github.com/users/bskiba/followers","following_url":"https://api.github.com/users/bskiba/following{/other_user}","gists_url":"https://api.github.com/users/bskiba/gists{/gist_id}","starred_url":"https://api.github.com/users/bskiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bskiba/subscriptions","organizations_url":"https://api.github.com/users/bskiba/orgs","repos_url":"https://api.github.com/users/bskiba/repos","events_url":"https://api.github.com/users/bskiba/events{/privacy}","received_events_url":"https://api.github.com/users/bskiba/received_events","type":"User","site_admin":false},{"login":"aleksandra-malinowska","id":4884414,"avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55061/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55061/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55061/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/89c96cf4ec605f16da30bba987772612205c19c6","head":{"label":"krzysztof-jastrzebski:e2e","ref":"e2e","sha":"89c96cf4ec605f16da30bba987772612205c19c6","user":{"login":"krzysztof-jastrzebski","id":29974120,"avatar_url":"https://avatars0.githubusercontent.com/u/29974120?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysztof-jastrzebski","html_url":"https://github.com/krzysztof-jastrzebski","followers_url":"https://api.github.com/users/krzysztof-jastrzebski/followers","following_url":"https://api.github.com/users/krzysztof-jastrzebski/following{/other_user}","gists_url":"https://api.github.com/users/krzysztof-jastrzebski/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysztof-jastrzebski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysztof-jastrzebski/subscriptions","organizations_url":"https://api.github.com/users/krzysztof-jastrzebski/orgs","repos_url":"https://api.github.com/users/krzysztof-jastrzebski/repos","events_url":"https://api.github.com/users/krzysztof-jastrzebski/events{/privacy}","received_events_url":"https://api.github.com/users/krzysztof-jastrzebski/received_events","type":"User","site_admin":false},"repo":{"id":102341461,"name":"kubernetes","full_name":"krzysztof-jastrzebski/kubernetes","owner":{"login":"krzysztof-jastrzebski","id":29974120,"avatar_url":"https://avatars0.githubusercontent.com/u/29974120?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysztof-jastrzebski","html_url":"https://github.com/krzysztof-jastrzebski","followers_url":"https://api.github.com/users/krzysztof-jastrzebski/followers","following_url":"https://api.github.com/users/krzysztof-jastrzebski/following{/other_user}","gists_url":"https://api.github.com/users/krzysztof-jastrzebski/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysztof-jastrzebski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysztof-jastrzebski/subscriptions","organizations_url":"https://api.github.com/users/krzysztof-jastrzebski/orgs","repos_url":"https://api.github.com/users/krzysztof-jastrzebski/repos","events_url":"https://api.github.com/users/krzysztof-jastrzebski/events{/privacy}","received_events_url":"https://api.github.com/users/krzysztof-jastrzebski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krzysztof-jastrzebski/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes","forks_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/forks","keys_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/teams","hooks_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/events","assignees_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/tags","blobs_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/languages","stargazers_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/subscription","commits_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/merges","archive_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/downloads","issues_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/krzysztof-jastrzebski/kubernetes/deployments","created_at":"2017-09-04T09:06:35Z","updated_at":"2017-09-04T09:07:19Z","pushed_at":"2017-11-06T19:18:16Z","git_url":"git://github.com/krzysztof-jastrzebski/kubernetes.git","ssh_url":"[email protected]:krzysztof-jastrzebski/kubernetes.git","clone_url":"https://github.com/krzysztof-jastrzebski/kubernetes.git","svn_url":"https://github.com/krzysztof-jastrzebski/kubernetes","homepage":"http://kubernetes.io","size":512963,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"298c42bbcd95c1536e0dc5f7a0aed48cec91eaf1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-11-06T19:15:57Z","pushed_at":"2017-11-06T19:16:50Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"[email protected]:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":733571,"stargazers_count":28556,"watchers_count":28556,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10203,"mirror_url":null,"archived":false,"open_issues_count":5486,"forks":10203,"open_issues":5486,"watchers":28556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55061"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/55061"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/55061"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/55061/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55061/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55061/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/89c96cf4ec605f16da30bba987772612205c19c6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
} | {
"id": 29974120,
"login": "krzysztof-jastrzebski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29974120?",
"url": "https://api.github.com/users/krzysztof-jastrzebski"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-11-06T19:19:42 | 6816347885 | {"actor":{"display_login":"krzysztof-jastrzebski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/community/pulls/comments/100527140","pull_request_review_id":21238022,"id":100527140,"diff_hunk":"@@ -0,0 +1,381 @@\n+# Local Storage Management\n+Authors: vishh@, msau42@\n+\n+This document presents a strawman for managing local storage in Kubernetes. We expect to provide a UX and high level design overview for managing most user workflows. More detailed design and implementation will be added once the community agrees with the high level design presented here.\n+\n+# Goals\n+* Enable ephemeral & durable access to local storage\n+* Support storage requirements for all workloads supported by Kubernetes\n+* Provide flexibility for users/vendors to utilize various types of storage devices\n+* Define a standard partitioning scheme for storage drives for all Kubernetes nodes\n+* Provide storage usage isolation for shared partitions\n+* Support random access storage devices only (e.g., hard disks and SSDs)\n+\n+# Non Goals\n+* Provide storage usage isolation for non-shared partitions.\n+* Support all storage devices natively in upstream Kubernetes. Non standard storage devices are expected to be managed using extension mechanisms.\n+\n+# Use Cases\n+\n+## Ephemeral Local Storage\n+Today, ephemeral local storage is exposed to pods via the container’s writable layer, logs directory, and EmptyDir volumes. Pods use ephemeral local storage for scratch space, caching and logs. There are many issues related to the lack of local storage accounting and isolation, including:\n+\n+* Pods do not know how much local storage is available to them.\n+* Pods cannot request “guaranteed” local storage.\n+* Local storage is a “best-effort” resource.\n+* Pods can get evicted due to other pods filling up the local storage, after which no new pods will be admitted until sufficient storage has been reclaimed.\n+\n+## Persistent Local Storage\n+Distributed filesystems and databases are the primary use cases for persistent local storage due to the following factors:\n+\n+* Performance: On cloud providers, local SSDs give better performance than remote disks.\n+* Cost: On baremetal, in addition to performance, local storage is typically cheaper and using it is a necessity to provision distributed filesystems.\n+\n+Distributed systems often use replication to provide fault tolerance, and can therefore tolerate node failures. However, data gravity is preferred for reducing replication traffic and cold startup latencies.\n+\n+# Design Overview\n+\n+A node’s local storage can be broken into primary and secondary partitions.\n+\n+## Primary Partitions\n+Primary partitions are shared partitions that can provide ephemeral local storage. The two supported primary partitions are:\n+\n+### Root\n+ This partition holds the kubelet’s root directory (`/var/lib/kubelet` by default) and `/var/log` directory. This partition may be shared between user pods, OS and Kubernetes system daemons. This partition can be consumed by pods via EmptyDir volumes, container logs, image layers and container writable layers. Kubelet will manage shared access and isolation of this partition. This partition is “ephemeral” and applications cannot expect any performance SLAs (Disk IOPs for example) from this partition.\n+\n+### Runtime\n+This is an optional partition which runtimes can use for overlay filesystems. Kubelet will attempt to identify and provide shared access along with isolation to this partition.\n+\n+## Secondary Partitions\n+All other partitions are exposed as persistent volumes. The PV interface allows for varying storage configurations to be supported, while hiding specific configuration details to the pod. Applications can continue to use their existing PVC specifications with minimal changes to request local storage. Each PV uses an entire partition. The PVs can be precreated by an addon DaemonSet that discovers all the secondary partitions, and can create new PVs as disks are added to the node.\n+\n+# User Workflows\n+\n+### Alice manages a deployment and requires “Guaranteed” ephemeral storage\n+\n+1. Kubelet running across all nodes will identify primary partition and expose capacity and allocatable for the primary “root” partition. The runtime partition is an implementation detail and is not exposed outside the node.\n+\n+ ```yaml\n+ apiVersion: v1\n+ kind: Node\n+ metadata:\n+ name: foo\n+ status:\n+ capacity: \n+ storage: 100Gi\n+ allocatable:\n+ storage: 90Gi\n+ ```\n+\n+2. Alice adds a “Storage” requirement to her pod as follows\n+\n+ ```yaml\n+ apiVersion: v1\n+ kind: pod\n+ metadata:\n+ name: foo\n+ spec:\n+ containers:\n+ - name: fooc\n+ resources:\n+ limits:\n+ storageLogs: 500Mi\n+ storageOverlay: 1Gi\n+ volumes:\n+ - name: myEmptyDir\n+ emptyDir:\n+ capacity: 20Gi\n+ ```\n+\n+3. Alice’s pod “foo” is Guaranteed a total of “21.5Gi” of local storage. The container “fooc” in her pod cannot consume more than 1Gi for writable layer and 500Mi for logs, and “myEmptyDir” volume cannot consume more than 20Gi.\n+4. Alice’s pod is not provided any IO guarantees\n+5. Kubelet will rotate logs to keep logs usage of “fooc” under 500Mi\n+6. Kubelet will attempt to hard limit local storage consumed by pod “foo” if Linux project quota feature is available and runtime supports storage isolation.\n+7. With hard limits, containers will receive a ENOSPACE error if they consume all reserved storage. Without hard limits, the pod will be evicted by kubelet.\n+8. Health is monitored by an external entity like the “Node Problem Detector” which is expected to place appropriate taints.\n+9. If a primary partition becomes unhealthy, the node is tainted and all pods running in it will be evicted by default, unless they tolerate that taint. Kubelet’s behavior on a node with unhealthy primary partition is undefined. Cluster administrators are expected to fix unhealthy primary partitions on nodes. \n+\n+### Bob runs batch workloads and is unsure of “storage” requirements\n+\n+1. Bob can create pods without any “storage” resource requirements. \n+\n+ ```yaml\n+ apiVersion: v1\n+ kind: pod\n+ metadata:\n+ name: foo\n+ namespace: myns\n+ spec:\n+ containers:\n+ - name: fooc\n+ volumes:\n+ - name: myEmptyDir\n+ emptyDir:\n+ ```\n+\n+2. His cluster administrator being aware of the issues with disk reclamation latencies has intelligently decided not to allow overcommitting primary partitions. The cluster administrator has installed a [LimitRange](https://kubernetes.io/docs/user-guide/compute-resources/) to “myns” namespace that will set a default storage size. Note: A cluster administrator can also specify burst ranges and a host of other features supported by LimitRange for local storage.\n+\n+ ```yaml\n+ apiVersion: v1\n+ kind: LimitRange\n+ metadata:\n+ name: mylimits\n+ spec:\n+ - default:\n+ storageLogs: 200Mi\n+ storageOverlay: 200Mi\n+ type: Container\n+ - default:\n+ storage: 1Gi\n+ type: EmptyDir\n+ ```\n+\n+3. The limit range will update the pod specification as follows:\n+\n+ ```yaml\n+ apiVersion: v1\n+ kind: pod\n+ metadata:\n+ name: foo\n+ spec:\n+ containers:\n+ name: fooc\n+ resources:\n+ limits:\n+ storageLogs: 200Mi\n+ storageOverlay: 200Mi\n+ volumes:\n+ name: myEmptyDir\n+ emptyDir:\n+ capacity: 1Gi\n+ ```\n+\n+4. Bob’s “foo” pod can use upto “200Mi” for its containers logs and writable layer each, and “1Gi” for its “myEmptyDir” volume. \n+5. If Bob’s pod “foo” exceeds the “default” storage limits and gets evicted, then Bob can set a minimum storage requirement for his containers and a higher “capacity” for his EmptyDir volumes.\n+\n+ ```yaml\n+ apiVersion: v1\n+ kind: pod\n+ metadata:\n+ name: foo\n+ spec:\n+ containers:\n+ name: fooc\n+ resources:\n+ requests:\n+ storageLogs: 500Mi\n+ storageOverlay: 500Mi\n+ volumes:\n+ name: myEmptyDir\n+ emptyDir:\n+ capacity: 2Gi\n+ ```\n+\n+6. Note that it is not possible to specify a minimum storage requirement for EmptyDir volumes because we intend to limit overcommitment of local storage due to high latency in reclaiming it from terminated pods.\n+\n+### Alice manages a Database which needs access to “durable” and fast scratch space\n+\n+1. Cluster administrator provisions machines with local SSDs and brings up the cluster\n+2. When a new node instance starts up, an addon DaemonSet discovers local “secondary” partitions which are mounted at a well known location and creates HostPath PVs for them if one doesn’t exist already. The PVs will include a path to the secondary device mount points and include additional labels and annotations that help tie to a specific node and identify the storage medium.\n+\n+ ```yaml\n+ kind: PersistentVolume\n+ apiVersion: v1\n+ metadata:\n+ name: local-pv-1\n+ annotations:\n+ storage.kubernetes.io/node: node-1\n+ labels:\n+ storage.kubernetes.io/medium: ssd\n+ spec:\n+ volumeType: local\n+ storageType: filesystem\n+ capacity:\n+ storage: 100Gi\n+ hostpath:\n+ path: /var/lib/kubelet/storage-partitions/local-pv-1\n+ accessModes:\n+ - ReadWriteOnce\n+ persistentVolumeReclaimPolicy: Delete\n+ ```\n+ ```\n+ $ kubectl get pv\n+ NAME CAPACITY ACCESSMODES RECLAIMPOLICY STATUS CLAIM … NODE\n+ local-pv-1 100Gi RWO Delete Available node-1\n+ local-pv-2 10Gi RWO Delete Available node-1\n+ local-pv-1 100Gi RWO Delete Available node-2\n+ local-pv-2 10Gi RWO Delete Available node-2\n+ local-pv-1 100Gi RWO Delete Available node-3\n+ local-pv-2 10Gi RWO Delete Available node-3\n+ ```\n+3. The addon will monitor the health of secondary partitions and mark PVs as unhealthy whenever the backing local storage devices have failed.\n+4. Alice creates a StatefulSet that uses local PVCs\n+\n+ ```yaml\n+ apiVersion: apps/v1beta1\n+ kind: StatefulSet\n+ metadata:\n+ name: web\n+ spec:\n+ serviceName: \"nginx\"\n+ replicas: 3\n+ template:\n+ metadata:\n+ labels:\n+ app: nginx\n+ spec:\n+ terminationGracePeriodSeconds: 10\n+ containers:\n+ - name: nginx\n+ image: gcr.io/google_containers/nginx-slim:0.8\n+ ports:\n+ - containerPort: 80\n+ name: web\n+ volumeMounts:\n+ - name: www\n+ mountPath: /usr/share/nginx/html\n+ - name: log\n+ mountPath: /var/log/nginx\n+ volumeClaimTemplates:\n+ - metadata:\n+ name: www\n+ labels:\n+ storage.kubernetes.io/medium: ssd\n+ spec:\n+ volumeType: local\n+ accessModes: [ \"ReadWriteOnce\" ]\n+ resources:\n+ requests:\n+ storage: 100Gi\n+ - metadata:\n+ name: log\n+ labels:\n+ storage.kubernetes.io/medium: hdd\n+ spec:\n+ volumeType: local\n+ accessModes: [ \"ReadWriteOnce\" ]\n+ resources:\n+ requests:\n+ storage: 1Gi\n+ ```\n+\n+5. The scheduler identifies nodes for each pod that can satisfy cpu, memory, storage requirements and also contains available local PVs to satisfy the pod's PVC claims. It then binds the pod’s PVCs to specific PVs on the node and then binds the pod to the node.\n+ ```\n+ $ kubectl get pvc\n+ NAME STATUS VOLUME CAPACITY ACCESSMODES … NODE\n+ www-local-pvc-1 Bound local-pv-1 100Gi RWO node-1\n+ www-local-pvc-2 Bound local-pv-1 100Gi RWO node-2\n+ www-local-pvc-3 Bound local-pv-1 100Gi RWO node-3\n+ log-local-pvc-1 Bound local-pv-2 10Gi RWO node-1\n+ log-local-pvc-2 Bound local-pv-2 10Gi RWO node-2\n+ log-local-pvc-3 Bound local-pv-2 10Gi RWO node-3\n+ ```\n+ ```\n+ $ kubectl get pv\n+ NAME CAPACITY … STATUS CLAIM NODE\n+ local-pv-1 100Gi Bound www-local-pvc-1 node-1\n+ local-pv-2 10Gi Bound log-local-pvc-1 node-1\n+ local-pv-1 100Gi Bound www-local-pvc-2 node-2\n+ local-pv-2 10Gi Bound log-local-pvc-2 node-2\n+ local-pv-1 100Gi Bound www-local-pvc-3 node-3\n+ local-pv-2 10Gi Bound log-local-pvc-3 node-3\n+ ```\n+\n+6. If a pod dies and is replaced by a new one that reuses existing PVCs, the pod will be placed on the same node where the corresponding PVs exist. Stateful Pods are expected to have a high enough priority which will result in such pods preempting other low priority pods if necessary to run on a specific node.\n+7. If a pod fails to get scheduled while attempting to reuse an old PVC, a controller will unbind the PVC from the PV, clean up the PV according to the reclaim policy, and reschedule the pod. The PVC will get rebound to a new PV.\n+8. If the node gets tainted as NotReady or Unknown, the pod is evicted according to the taint's forgiveness setting. The pod will then fail scheduling due to the taint, and follow step 7.\n+9. If a PV becomes unhealthy, the pod is evicted by a controller, and follows step 7. Unhealthy PVs once released will not be added back to the cluster until the corresponding local storage device is healthy.\n+10. Once Alice decides to delete the database, the StatefulSet is destroyed, followed by the PVCs. The PVs will then get recycled and deleted according to the reclaim policy, and the addon adds it back to the cluster.","path":"contributors/design-proposals/local-storage-overview.md","position":288,"original_position":288,"commit_id":"2f01ad576f0f40fd77c851b02c4fb7e28cbf4b67","original_commit_id":"2f01ad576f0f40fd77c851b02c4fb7e28cbf4b67","user":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"body":"\"the addon adds it back to the cluster.\" What addon? The daemonset?\r\n","created_at":"2017-02-10T12:42:02Z","updated_at":"2017-02-10T12:42:02Z","html_url":"https://github.com/kubernetes/community/pull/306#discussion_r100527140","pull_request_url":"https://api.github.com/repos/kubernetes/community/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/community/pulls/comments/100527140"},"html":{"href":"https://github.com/kubernetes/community/pull/306#discussion_r100527140"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/community/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/community/pulls/306","id":103805548,"html_url":"https://github.com/kubernetes/community/pull/306","diff_url":"https://github.com/kubernetes/community/pull/306.diff","patch_url":"https://github.com/kubernetes/community/pull/306.patch","issue_url":"https://api.github.com/repos/kubernetes/community/issues/306","number":306,"state":"open","locked":false,"title":"[Proposal] Improve Local Storage Management","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"body":"A note to reviewers: A detailed design proposal will be posted once the overall design in this proposal has been accepted by the community. So kindly hold on to specific design questions or suggestions that are not relevant to the overall high level design for local storage. \r\n\r\ncc @kubernetes/sig-storage-proposals @kubernetes/sig-node-proposals @kubernetes/sig-apps-proposals @kubernetes/sig-scheduling-proposals \r\n\r\ncc @msau42 \r\n\r\nFor https://github.com/kubernetes/features/issues/121","created_at":"2017-01-30T19:43:22Z","updated_at":"2017-02-10T12:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f2a60919269fa69cf2d1d95ec322313611c0eab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/community/pulls/306/commits","review_comments_url":"https://api.github.com/repos/kubernetes/community/pulls/306/comments","review_comment_url":"https://api.github.com/repos/kubernetes/community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/community/issues/306/comments","statuses_url":"https://api.github.com/repos/kubernetes/community/statuses/2f01ad576f0f40fd77c851b02c4fb7e28cbf4b67","head":{"label":"vishh:storage-proposal","ref":"storage-proposal","sha":"2f01ad576f0f40fd77c851b02c4fb7e28cbf4b67","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"repo":{"id":80394404,"name":"community","full_name":"vishh/community","owner":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vishh/community","description":"Kubernetes community content","fork":true,"url":"https://api.github.com/repos/vishh/community","forks_url":"https://api.github.com/repos/vishh/community/forks","keys_url":"https://api.github.com/repos/vishh/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vishh/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vishh/community/teams","hooks_url":"https://api.github.com/repos/vishh/community/hooks","issue_events_url":"https://api.github.com/repos/vishh/community/issues/events{/number}","events_url":"https://api.github.com/repos/vishh/community/events","assignees_url":"https://api.github.com/repos/vishh/community/assignees{/user}","branches_url":"https://api.github.com/repos/vishh/community/branches{/branch}","tags_url":"https://api.github.com/repos/vishh/community/tags","blobs_url":"https://api.github.com/repos/vishh/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vishh/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vishh/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/vishh/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vishh/community/statuses/{sha}","languages_url":"https://api.github.com/repos/vishh/community/languages","stargazers_url":"https://api.github.com/repos/vishh/community/stargazers","contributors_url":"https://api.github.com/repos/vishh/community/contributors","subscribers_url":"https://api.github.com/repos/vishh/community/subscribers","subscription_url":"https://api.github.com/repos/vishh/community/subscription","commits_url":"https://api.github.com/repos/vishh/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/vishh/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/vishh/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/vishh/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/vishh/community/contents/{+path}","compare_url":"https://api.github.com/repos/vishh/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vishh/community/merges","archive_url":"https://api.github.com/repos/vishh/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vishh/community/downloads","issues_url":"https://api.github.com/repos/vishh/community/issues{/number}","pulls_url":"https://api.github.com/repos/vishh/community/pulls{/number}","milestones_url":"https://api.github.com/repos/vishh/community/milestones{/number}","notifications_url":"https://api.github.com/repos/vishh/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vishh/community/labels{/name}","releases_url":"https://api.github.com/repos/vishh/community/releases{/id}","deployments_url":"https://api.github.com/repos/vishh/community/deployments","created_at":"2017-01-30T04:48:28Z","updated_at":"2017-01-30T04:48:31Z","pushed_at":"2017-02-09T19:10:58Z","git_url":"git://github.com/vishh/community.git","ssh_url":"[email protected]:vishh/community.git","clone_url":"https://github.com/vishh/community.git","svn_url":"https://github.com/vishh/community","homepage":"","size":7207,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a78e7d11ef10b95d6391ef5096c9355e028d882e","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57939112,"name":"community","full_name":"kubernetes/community","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/community","description":"Kubernetes community content","fork":false,"url":"https://api.github.com/repos/kubernetes/community","forks_url":"https://api.github.com/repos/kubernetes/community/forks","keys_url":"https://api.github.com/repos/kubernetes/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/community/teams","hooks_url":"https://api.github.com/repos/kubernetes/community/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/community/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/community/events","assignees_url":"https://api.github.com/repos/kubernetes/community/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/community/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/community/tags","blobs_url":"https://api.github.com/repos/kubernetes/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/community/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/community/languages","stargazers_url":"https://api.github.com/repos/kubernetes/community/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/community/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/community/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/community/subscription","commits_url":"https://api.github.com/repos/kubernetes/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/community/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/community/merges","archive_url":"https://api.github.com/repos/kubernetes/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/community/downloads","issues_url":"https://api.github.com/repos/kubernetes/community/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/community/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/community/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/community/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/community/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/community/deployments","created_at":"2016-05-03T03:36:05Z","updated_at":"2017-02-09T22:47:33Z","pushed_at":"2017-02-10T10:43:34Z","git_url":"git://github.com/kubernetes/community.git","ssh_url":"[email protected]:kubernetes/community.git","clone_url":"https://github.com/kubernetes/community.git","svn_url":"https://github.com/kubernetes/community","homepage":"","size":7225,"stargazers_count":172,"watchers_count":172,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":79,"forks":182,"open_issues":79,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/community/pulls/306"},"html":{"href":"https://github.com/kubernetes/community/pull/306"},"issue":{"href":"https://api.github.com/repos/kubernetes/community/issues/306"},"comments":{"href":"https://api.github.com/repos/kubernetes/community/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/community/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/community/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/community/statuses/2f01ad576f0f40fd77c851b02c4fb7e28cbf4b67"}}}} | {
"id": 57939112,
"name": "kubernetes/community",
"url": "https://api.github.com/repos/kubernetes/community"
} | {
"id": 1745006,
"login": "jsafrane",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1745006?",
"url": "https://api.github.com/users/jsafrane"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-02-10T12:42:02 | 5302353844 | {"actor":{"display_login":"jsafrane"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/154883527","pull_request_review_id":81110647,"id":154883527,"diff_hunk":"@@ -240,16 +240,19 @@ func (m *ManagerImpl) Devices() map[string][]pluginapi.Device {\n // from the registered device plugins.\n func (m *ManagerImpl) Allocate(node *schedulercache.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {\n \tpod := attrs.Pod\n+\tdevicesToReuse := make(map[string]sets.String)","path":"pkg/kubelet/cm/deviceplugin/manager.go","position":4,"original_position":4,"commit_id":"d4244f3dede646c5292c8200755d428ae4fbad83","original_commit_id":"d4244f3dede646c5292c8200755d428ae4fbad83","user":{"login":"ScorpioCPH","id":5319646,"avatar_url":"https://avatars2.githubusercontent.com/u/5319646?v=4","gravatar_id":"","url":"https://api.github.com/users/ScorpioCPH","html_url":"https://github.com/ScorpioCPH","followers_url":"https://api.github.com/users/ScorpioCPH/followers","following_url":"https://api.github.com/users/ScorpioCPH/following{/other_user}","gists_url":"https://api.github.com/users/ScorpioCPH/gists{/gist_id}","starred_url":"https://api.github.com/users/ScorpioCPH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScorpioCPH/subscriptions","organizations_url":"https://api.github.com/users/ScorpioCPH/orgs","repos_url":"https://api.github.com/users/ScorpioCPH/repos","events_url":"https://api.github.com/users/ScorpioCPH/events{/privacy}","received_events_url":"https://api.github.com/users/ScorpioCPH/received_events","type":"User","site_admin":false},"body":"nit: can we add new field `devicesToReuse` in `m.podDevices` or `ManagerImpl` , so we can stop passing `devicesToReuse` everywhere :)","created_at":"2017-12-05T09:08:23Z","updated_at":"2017-12-05T09:09:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/56818#discussion_r154883527","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56818","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/154883527"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/56818#discussion_r154883527"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56818"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56818","id":156319561,"html_url":"https://github.com/kubernetes/kubernetes/pull/56818","diff_url":"https://github.com/kubernetes/kubernetes/pull/56818.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/56818.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56818","number":56818,"state":"open","locked":false,"title":"Re-uses device plugin resources allocated to init containers.","user":{"login":"jiayingz","id":29497748,"avatar_url":"https://avatars3.githubusercontent.com/u/29497748?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayingz","html_url":"https://github.com/jiayingz","followers_url":"https://api.github.com/users/jiayingz/followers","following_url":"https://api.github.com/users/jiayingz/following{/other_user}","gists_url":"https://api.github.com/users/jiayingz/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayingz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayingz/subscriptions","organizations_url":"https://api.github.com/users/jiayingz/orgs","repos_url":"https://api.github.com/users/jiayingz/repos","events_url":"https://api.github.com/users/jiayingz/events{/privacy}","received_events_url":"https://api.github.com/users/jiayingz/received_events","type":"User","site_admin":false},"body":"Implements option 2 mentioned in\r\nhttps://github.com/kubernetes/kubernetes/issues/56022#issuecomment-348286184\r\n\r\n<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis PR implements the option 2 solution discussed in https://github.com/kubernetes/kubernetes/issues/56022#issuecomment-348286184.\r\nThis is one of short-term fix we are considering for a 1.9 patch release. The alternative is to disallow requesting device plugin resources in init containers,\r\nas PR https://github.com/kubernetes/kubernetes/pull/56659 is taking.\r\nThe long-term fix we want to implement for 1.10 is still open to discussion.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes https://github.com/kubernetes/kubernetes/issues/56022\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!-- Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n","created_at":"2017-12-04T22:09:12Z","updated_at":"2017-12-05T09:09:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a255e883cad20b2a0d3a4e0514e6ce42f095a86","assignee":{"login":"mindprince","id":695290,"avatar_url":"https://avatars2.githubusercontent.com/u/695290?v=4","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},"assignees":[{"login":"mindprince","id":695290,"avatar_url":"https://avatars2.githubusercontent.com/u/695290?v=4","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"avatar_url":"https://avatars2.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56818/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56818/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56818/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d4244f3dede646c5292c8200755d428ae4fbad83","head":{"label":"jiayingz:init-container-fix","ref":"init-container-fix","sha":"d4244f3dede646c5292c8200755d428ae4fbad83","user":{"login":"jiayingz","id":29497748,"avatar_url":"https://avatars3.githubusercontent.com/u/29497748?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayingz","html_url":"https://github.com/jiayingz","followers_url":"https://api.github.com/users/jiayingz/followers","following_url":"https://api.github.com/users/jiayingz/following{/other_user}","gists_url":"https://api.github.com/users/jiayingz/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayingz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayingz/subscriptions","organizations_url":"https://api.github.com/users/jiayingz/orgs","repos_url":"https://api.github.com/users/jiayingz/repos","events_url":"https://api.github.com/users/jiayingz/events{/privacy}","received_events_url":"https://api.github.com/users/jiayingz/received_events","type":"User","site_admin":false},"repo":{"id":94807444,"name":"kubernetes","full_name":"jiayingz/kubernetes","owner":{"login":"jiayingz","id":29497748,"avatar_url":"https://avatars3.githubusercontent.com/u/29497748?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayingz","html_url":"https://github.com/jiayingz","followers_url":"https://api.github.com/users/jiayingz/followers","following_url":"https://api.github.com/users/jiayingz/following{/other_user}","gists_url":"https://api.github.com/users/jiayingz/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayingz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayingz/subscriptions","organizations_url":"https://api.github.com/users/jiayingz/orgs","repos_url":"https://api.github.com/users/jiayingz/repos","events_url":"https://api.github.com/users/jiayingz/events{/privacy}","received_events_url":"https://api.github.com/users/jiayingz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiayingz/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/jiayingz/kubernetes","forks_url":"https://api.github.com/repos/jiayingz/kubernetes/forks","keys_url":"https://api.github.com/repos/jiayingz/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiayingz/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiayingz/kubernetes/teams","hooks_url":"https://api.github.com/repos/jiayingz/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jiayingz/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jiayingz/kubernetes/events","assignees_url":"https://api.github.com/repos/jiayingz/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jiayingz/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jiayingz/kubernetes/tags","blobs_url":"https://api.github.com/repos/jiayingz/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiayingz/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiayingz/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiayingz/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiayingz/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jiayingz/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jiayingz/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jiayingz/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jiayingz/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jiayingz/kubernetes/subscription","commits_url":"https://api.github.com/repos/jiayingz/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiayingz/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiayingz/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiayingz/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiayingz/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jiayingz/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiayingz/kubernetes/merges","archive_url":"https://api.github.com/repos/jiayingz/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiayingz/kubernetes/downloads","issues_url":"https://api.github.com/repos/jiayingz/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jiayingz/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jiayingz/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jiayingz/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiayingz/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jiayingz/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jiayingz/kubernetes/deployments","created_at":"2017-06-19T18:19:32Z","updated_at":"2017-06-19T18:20:12Z","pushed_at":"2017-12-05T06:01:44Z","git_url":"git://github.com/jiayingz/kubernetes.git","ssh_url":"[email protected]:jiayingz/kubernetes.git","clone_url":"https://github.com/jiayingz/kubernetes.git","svn_url":"https://github.com/jiayingz/kubernetes","homepage":"http://kubernetes.io","size":554734,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2175199646e3f530fb329210b8a643be319f09f0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-12-05T08:45:00Z","pushed_at":"2017-12-05T09:08:20Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"[email protected]:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":743168,"stargazers_count":29631,"watchers_count":29631,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10607,"mirror_url":null,"archived":false,"open_issues_count":5715,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10607,"open_issues":5715,"watchers":29631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56818"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/56818"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/56818"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/56818/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56818/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56818/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d4244f3dede646c5292c8200755d428ae4fbad83"}},"author_association":"MEMBER"}} | {
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
} | {
"id": 5319646,
"login": "ScorpioCPH",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5319646?",
"url": "https://api.github.com/users/ScorpioCPH"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-12-05T09:08:23 | 6944089628 | {"actor":{"display_login":"ScorpioCPH"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress/pulls/comments/137455858","pull_request_review_id":61123904,"id":137455858,"diff_hunk":"@@ -170,6 +182,25 @@ func (c *ClusterManager) Checkpoint(lbs []*loadbalancers.L7RuntimeInfo, nodeName\n \treturn nil\n }\n \n+func (c *ClusterManager) CreateInstanceGroups(servicePorts []backends.ServicePort) ([]*compute.InstanceGroup, error) {\n+\tvar igs []*compute.InstanceGroup\n+\tvar err error\n+\tfor _, p := range servicePorts {\n+\t\tigs, _, err = instances.CreateInstanceGroups(c.instancePool, c.ClusterNamer, p.Port)","path":"controllers/gce/controller/cluster_manager.go","position":78,"original_position":78,"commit_id":"2e74c814957949b16ea7d83079609b7ac0ff35c6","original_commit_id":"2e74c814957949b16ea7d83079609b7ac0ff35c6","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"CreateInstanceGroups creates instance groups in all zones and then adds the given named port to it.\r\nEach time CreateInstanceGroups is called for a port, it always returns the same set of all igs. So we dont need append, just return the output of any call.\r\n\r\nIdeally, we should call CreateInstanceGroups only the first time and then call AddNamedPort subsequent times, but that interface is not exposed yet. Will add a TODO and a comment explaining this.","created_at":"2017-09-07T06:33:11Z","updated_at":"2017-09-07T06:33:11Z","html_url":"https://github.com/kubernetes/ingress/pull/1033#discussion_r137455858","pull_request_url":"https://api.github.com/repos/kubernetes/ingress/pulls/1033","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress/pulls/comments/137455858"},"html":{"href":"https://github.com/kubernetes/ingress/pull/1033#discussion_r137455858"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress/pulls/1033"}},"in_reply_to_id":137442470},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress/pulls/1033","id":132832547,"html_url":"https://github.com/kubernetes/ingress/pull/1033","diff_url":"https://github.com/kubernetes/ingress/pull/1033.diff","patch_url":"https://github.com/kubernetes/ingress/pull/1033.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress/issues/1033","number":1033,"state":"open","locked":false,"title":"Adding logic to GCE ingress controller to handle multi cluster ingresses","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"Ingress controller should manage instance groups and ports for multi cluster ingresses.\r\n\r\nThings to do:\r\n- [x] Add tests\r\n- [x] Verify manually that this works\r\n- [x] Ensure that resources are GC'd as expected.\r\n\r\nSending it out now to get early feedback.\r\n\r\nUpdate:\r\nVerified that the code works as expected with the following scenarios:\r\n\r\nCreating an ingress with gce-multi class, creates expected instance group and deleting the ingress, deletes the ig.\r\nIf there is an existing ingress, then creating gce-multi ingress, reuses the existing instance group rather than creating a new one.\r\nThere is an existing issue that deleting the ingress does not delete the corresponding named ports which is being tracked in #695.\r\n\r\nWill add e2e tests in main repo to automate these tests.\r\n\r\ncc @nicksardo ","created_at":"2017-07-27T19:58:16Z","updated_at":"2017-09-07T06:33:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61cd457aa31b0e862b09b12d7ebb3c3e9463c4ed","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress/pulls/1033/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress/pulls/1033/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress/issues/1033/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress/statuses/2e74c814957949b16ea7d83079609b7ac0ff35c6","head":{"label":"nikhiljindal:reportIGName","ref":"reportIGName","sha":"2e74c814957949b16ea7d83079609b7ac0ff35c6","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"repo":{"id":97534211,"name":"ingress","full_name":"nikhiljindal/ingress","owner":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikhiljindal/ingress","description":"Ingress controllers","fork":true,"url":"https://api.github.com/repos/nikhiljindal/ingress","forks_url":"https://api.github.com/repos/nikhiljindal/ingress/forks","keys_url":"https://api.github.com/repos/nikhiljindal/ingress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikhiljindal/ingress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikhiljindal/ingress/teams","hooks_url":"https://api.github.com/repos/nikhiljindal/ingress/hooks","issue_events_url":"https://api.github.com/repos/nikhiljindal/ingress/issues/events{/number}","events_url":"https://api.github.com/repos/nikhiljindal/ingress/events","assignees_url":"https://api.github.com/repos/nikhiljindal/ingress/assignees{/user}","branches_url":"https://api.github.com/repos/nikhiljindal/ingress/branches{/branch}","tags_url":"https://api.github.com/repos/nikhiljindal/ingress/tags","blobs_url":"https://api.github.com/repos/nikhiljindal/ingress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikhiljindal/ingress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikhiljindal/ingress/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikhiljindal/ingress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikhiljindal/ingress/statuses/{sha}","languages_url":"https://api.github.com/repos/nikhiljindal/ingress/languages","stargazers_url":"https://api.github.com/repos/nikhiljindal/ingress/stargazers","contributors_url":"https://api.github.com/repos/nikhiljindal/ingress/contributors","subscribers_url":"https://api.github.com/repos/nikhiljindal/ingress/subscribers","subscription_url":"https://api.github.com/repos/nikhiljindal/ingress/subscription","commits_url":"https://api.github.com/repos/nikhiljindal/ingress/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikhiljindal/ingress/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikhiljindal/ingress/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikhiljindal/ingress/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikhiljindal/ingress/contents/{+path}","compare_url":"https://api.github.com/repos/nikhiljindal/ingress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikhiljindal/ingress/merges","archive_url":"https://api.github.com/repos/nikhiljindal/ingress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikhiljindal/ingress/downloads","issues_url":"https://api.github.com/repos/nikhiljindal/ingress/issues{/number}","pulls_url":"https://api.github.com/repos/nikhiljindal/ingress/pulls{/number}","milestones_url":"https://api.github.com/repos/nikhiljindal/ingress/milestones{/number}","notifications_url":"https://api.github.com/repos/nikhiljindal/ingress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikhiljindal/ingress/labels{/name}","releases_url":"https://api.github.com/repos/nikhiljindal/ingress/releases{/id}","deployments_url":"https://api.github.com/repos/nikhiljindal/ingress/deployments","created_at":"2017-07-18T00:26:01Z","updated_at":"2017-07-18T00:26:03Z","pushed_at":"2017-09-07T01:17:50Z","git_url":"git://github.com/nikhiljindal/ingress.git","ssh_url":"[email protected]:nikhiljindal/ingress.git","clone_url":"https://github.com/nikhiljindal/ingress.git","svn_url":"https://github.com/nikhiljindal/ingress","homepage":null,"size":24598,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a8bfdc24277071474263f8f73d30c7066e058e4f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":72891330,"name":"ingress","full_name":"kubernetes/ingress","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/ingress","description":"Ingress controllers","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress","forks_url":"https://api.github.com/repos/kubernetes/ingress/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress/deployments","created_at":"2016-11-04T22:54:14Z","updated_at":"2017-09-06T21:12:19Z","pushed_at":"2017-09-07T01:17:58Z","git_url":"git://github.com/kubernetes/ingress.git","ssh_url":"[email protected]:kubernetes/ingress.git","clone_url":"https://github.com/kubernetes/ingress.git","svn_url":"https://github.com/kubernetes/ingress","homepage":null,"size":25854,"stargazers_count":650,"watchers_count":650,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":477,"mirror_url":null,"open_issues_count":136,"forks":477,"open_issues":136,"watchers":650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress/pulls/1033"},"html":{"href":"https://github.com/kubernetes/ingress/pull/1033"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress/issues/1033"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress/issues/1033/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress/pulls/1033/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress/pulls/1033/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress/statuses/2e74c814957949b16ea7d83079609b7ac0ff35c6"}},"author_association":"MEMBER"}} | {
"id": 72891330,
"name": "kubernetes/ingress",
"url": "https://api.github.com/repos/kubernetes/ingress"
} | {
"id": 10199099,
"login": "nikhiljindal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10199099?",
"url": "https://api.github.com/users/nikhiljindal"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-09-07T06:33:11 | 6559798439 | {"actor":{"display_login":"nikhiljindal"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments/123395328","pull_request_review_id":45590589,"id":123395328,"diff_hunk":"@@ -0,0 +1,84 @@\n+---\n+assignees:\n+- crassirostris\n+- piosz\n+title: Events Using Stackdriver\n+---\n+\n+Kubernetes events are objects that provide an insight into what is happening\n+inside a cluster, for example, what decisions were made by scheduler or why\n+some pods were evicted from the node. You can read more about using events\n+for debugging your application in the [Application Introspection and Debugging\n+](docs/tasks/debug-application-cluster/debug-application-introspection)\n+section.\n+\n+Since events are API objects, they are stored in the apiserver on master. To\n+avoid filling up master's disk, a retention policy is enforced: events are\n+removed after one hour after the last occurence. To provide longer history\n+and aggregation capabilities, a third party solution should be installed,\n+to where events would be exported for future use.\n+\n+This article describes a solution that exports Kubernetes events to\n+Stackdriver Logging, where they can be made useful.\n+\n+*Note:* evets are considered best-effort, so it's possible that some events\n+will be lost on their way to Stackdriver. For example, because of the\n+technical constraints, events that happen while event exporter is not\n+running are not exported. You should not depend on every event happening in\n+the cluster making its way to Stackdriver. In particular, this implies that\n+alerting based on events might be not a good idea.\n+\n+* TOC\n+{:toc}\n+\n+## Deployment\n+\n+### Google Container Engine\n+\n+In Google Container Engine event exporter is deployed by default to the\n+clusters with master in version 1.7 and higher, if cloud logging is enabled.\n+Note, that in order to prevent disturbing your workloads, event exporter\n+doesn't have resources set and is in the best effort QOS class, which\n+effectively means that it will be the first to kill in case of resource\n+starvation. If you want your events to be exported, make sure you have\n+enough resources to facilitate the event exporter pod (depends on the\n+workload, but on average approximately 100Mb RAM and 100m CPU).\n+\n+### Deploying to the Existing Cluster\n+\n+Deploy event exporter to your cluster using the following command:\n+\n+```shell\n+kubectl create -f https://k8s.io/docs/tasks/debug-application-cluster/event-exporter-deploy.yaml\n+```\n+\n+Since event exporter accesses Kubernetes API, it requres permissions to\n+do so. The following deployment is configured to work with RBAC\n+authorization. It sets up a service account and a cluster role binding\n+to allow event exporter to read events. To make sure that event exporter\n+pod will not be evicted from the node, you can additionally set up resource\n+requests. As mentioned earlier, 100Mb RAM and 100m CPU should be enough.\n+\n+{% include code.html language=\"yaml\" file=\"event-exporter-deploy.yaml\" ghlink=\"/docs/tasks/debug-application-cluster/event-exporter-deploy.yaml\" %}\n+\n+## User Guide\n+\n+Events are exported to the `GKE Cluster` resource in Stackdriver Logging,","path":"docs/tasks/debug-application-cluster/events-stackdriver.md","position":66,"original_position":66,"commit_id":"a9c91d9446066dd4d4d2f0b19967e52701ac42a9","original_commit_id":"a9c91d9446066dd4d4d2f0b19967e52701ac42a9","user":{"login":"chenopis","id":24798125,"avatar_url":"https://avatars2.githubusercontent.com/u/24798125?v=3","gravatar_id":"","url":"https://api.github.com/users/chenopis","html_url":"https://github.com/chenopis","followers_url":"https://api.github.com/users/chenopis/followers","following_url":"https://api.github.com/users/chenopis/following{/other_user}","gists_url":"https://api.github.com/users/chenopis/gists{/gist_id}","starred_url":"https://api.github.com/users/chenopis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenopis/subscriptions","organizations_url":"https://api.github.com/users/chenopis/orgs","repos_url":"https://api.github.com/users/chenopis/repos","events_url":"https://api.github.com/users/chenopis/events{/privacy}","received_events_url":"https://api.github.com/users/chenopis/received_events","type":"User","site_admin":false},"body":"Break into two sentences: \"Events are exported to the `GKE Cluster` resource in Stackdriver Logging. You can find them by selecting an appropriate option from a drop-down menu of available resources:\"","created_at":"2017-06-22T00:09:23Z","updated_at":"2017-06-22T00:12:23Z","html_url":"https://github.com/kubernetes/kubernetes.github.io/pull/4155#discussion_r123395328","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/4155","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments/123395328"},"html":{"href":"https://github.com/kubernetes/kubernetes.github.io/pull/4155#discussion_r123395328"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/4155"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/4155","id":126834998,"html_url":"https://github.com/kubernetes/kubernetes.github.io/pull/4155","diff_url":"https://github.com/kubernetes/kubernetes.github.io/pull/4155.diff","patch_url":"https://github.com/kubernetes/kubernetes.github.io/pull/4155.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/4155","number":4155,"state":"open","locked":false,"title":"Add documentation for Stackdriver event exporter","user":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars2.githubusercontent.com/u/1756505?v=3","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"body":"/cc @piosz @fgrzadkowski\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes.github.io/4155)\r\n<!-- Reviewable:end -->\r\n","created_at":"2017-06-21T18:51:51Z","updated_at":"2017-06-22T00:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"beca701d0a70586b4821b8176caa60539921348e","assignee":{"login":"piosz","id":10819974,"avatar_url":"https://avatars3.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"assignees":[{"login":"piosz","id":10819974,"avatar_url":"https://avatars3.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars3.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false},{"login":"chenopis","id":24798125,"avatar_url":"https://avatars2.githubusercontent.com/u/24798125?v=3","gravatar_id":"","url":"https://api.github.com/users/chenopis","html_url":"https://github.com/chenopis","followers_url":"https://api.github.com/users/chenopis/followers","following_url":"https://api.github.com/users/chenopis/following{/other_user}","gists_url":"https://api.github.com/users/chenopis/gists{/gist_id}","starred_url":"https://api.github.com/users/chenopis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenopis/subscriptions","organizations_url":"https://api.github.com/users/chenopis/orgs","repos_url":"https://api.github.com/users/chenopis/repos","events_url":"https://api.github.com/users/chenopis/events{/privacy}","received_events_url":"https://api.github.com/users/chenopis/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"piosz","id":10819974,"avatar_url":"https://avatars3.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars3.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/milestones/7","html_url":"https://github.com/kubernetes/kubernetes.github.io/milestone/7","labels_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/milestones/7/labels","id":2508569,"number":7,"title":"1.7","description":null,"creator":{"login":"chenopis","id":24798125,"avatar_url":"https://avatars2.githubusercontent.com/u/24798125?v=3","gravatar_id":"","url":"https://api.github.com/users/chenopis","html_url":"https://github.com/chenopis","followers_url":"https://api.github.com/users/chenopis/followers","following_url":"https://api.github.com/users/chenopis/following{/other_user}","gists_url":"https://api.github.com/users/chenopis/gists{/gist_id}","starred_url":"https://api.github.com/users/chenopis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenopis/subscriptions","organizations_url":"https://api.github.com/users/chenopis/orgs","repos_url":"https://api.github.com/users/chenopis/repos","events_url":"https://api.github.com/users/chenopis/events{/privacy}","received_events_url":"https://api.github.com/users/chenopis/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":19,"state":"open","created_at":"2017-05-08T22:12:23Z","updated_at":"2017-06-21T23:55:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/4155/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/4155/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/4155/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/a9c91d9446066dd4d4d2f0b19967e52701ac42a9","head":{"label":"crassirostris:add-event-exporter-doc-page","ref":"add-event-exporter-doc-page","sha":"a9c91d9446066dd4d4d2f0b19967e52701ac42a9","user":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars2.githubusercontent.com/u/1756505?v=3","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"repo":{"id":75004629,"name":"kubernetes.github.io","full_name":"crassirostris/kubernetes.github.io","owner":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars2.githubusercontent.com/u/1756505?v=3","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crassirostris/kubernetes.github.io","description":"Website/documentation repo","fork":true,"url":"https://api.github.com/repos/crassirostris/kubernetes.github.io","forks_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/forks","keys_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/teams","hooks_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/hooks","issue_events_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/events","assignees_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/tags","blobs_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/languages","stargazers_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/stargazers","contributors_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/contributors","subscribers_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/subscribers","subscription_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/subscription","commits_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/merges","archive_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/downloads","issues_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/labels{/name}","releases_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/crassirostris/kubernetes.github.io/deployments","created_at":"2016-11-28T18:58:05Z","updated_at":"2016-11-28T18:58:08Z","pushed_at":"2017-06-21T20:12:11Z","git_url":"git://github.com/crassirostris/kubernetes.github.io.git","ssh_url":"[email protected]:crassirostris/kubernetes.github.io.git","clone_url":"https://github.com/crassirostris/kubernetes.github.io.git","svn_url":"https://github.com/crassirostris/kubernetes.github.io","homepage":null,"size":52403,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:release-1.7","ref":"release-1.7","sha":"09bf855b76e6d683103f64c295aae4af5c0372cc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"name":"kubernetes.github.io","full_name":"kubernetes/kubernetes.github.io","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes.github.io","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes.github.io","forks_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes.github.io/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2017-06-20T00:36:11Z","pushed_at":"2017-06-21T23:56:39Z","git_url":"git://github.com/kubernetes/kubernetes.github.io.git","ssh_url":"[email protected]:kubernetes/kubernetes.github.io.git","clone_url":"https://github.com/kubernetes/kubernetes.github.io.git","svn_url":"https://github.com/kubernetes/kubernetes.github.io","homepage":"https://kubernetes.github.io","size":56710,"stargazers_count":191,"watchers_count":191,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1352,"mirror_url":null,"open_issues_count":488,"forks":1352,"open_issues":488,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/4155"},"html":{"href":"https://github.com/kubernetes/kubernetes.github.io/pull/4155"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/4155"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/issues/4155/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/4155/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/pulls/4155/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes.github.io/statuses/a9c91d9446066dd4d4d2f0b19967e52701ac42a9"}}}} | {
"id": 51478266,
"name": "kubernetes/kubernetes.github.io",
"url": "https://api.github.com/repos/kubernetes/kubernetes.github.io"
} | {
"id": 24798125,
"login": "chenopis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24798125?",
"url": "https://api.github.com/users/chenopis"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-06-22T00:09:23 | 6114207704 | {"actor":{"display_login":"chenopis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/code-generator/pulls/comments/148581426","pull_request_review_id":73846888,"id":148581426,"diff_hunk":"@@ -0,0 +1,214 @@\n+# Kubernetes Code Generators\n+\n+Kubernetes provides a collection of code generators to assist with developing APIs. These code generators generate\n+useful libraries such as clients, openapi definitions, copying go structs, etc.\n+\n+The `kubegen` uses directory structure conventions to detect Kubernetes APIs definitions and run the standard\n+set of Kubernetes code generators.\n+\n+There are 2 methods for running kubegen\n+\n+- Directly through the kubegen command line by downloading the binary and running at a the project root\n+- Through Bazel by adding rules to `WORKSPACE` and `BUILD.gazel`\n+\n+## Kubernetes API conventions\n+\n+kubegen will run the full set of Kubernetes code generators for all APIs it finds in the project.\n+kubegen looks for API groups defined under `pkg/apis/<group>/<version>` where *group* and *version* match the following\n+patterns.\n+\n+- **group pattern**: ^[a-z]+$\n+- **version pattern**: ^v\\\\d+(alpha\\\\d+|beta\\\\d+)*$\n+\n+By default, kubegen will run code generators for both external types defined under `pkg/apis/<group>/<version>` and\n+internal types defined under `pkg/apis/<group>`. The location kubegen searches can be overridden.\n+\n+kubegen will prepend all generated files with copyright and license comments.\n+\n+By default, the kubegen binary runs all* of the Kubernetes code\n+generators against all API group/versions defined in the project.\n+\n+**List of generators:*\n+\n+- client-gen\n+- conversion-gen\n+- deepcopy-gen\n+- defaulter-gen\n+- go-to-protobuf\n+- informer-gen\n+- lister-gen\n+- openapi-gen\n+- set-gen\n+\n+## Running via Command line\n+\n+### Installing the command line\n+\n+- Download the latest kubegen release from the code-generators release page.\n+- Extract the tar and add the `kubegen` binary to the PATH\n+- Run `kubegen version` to list the version\n+ - Will correspond to a Kubernetes release\n+\n+### Running the command line\n+\n+#### Use defaults\n+\n+```sh\n+kubegen\n+```\n+\n+- run all code generators against discovered APIs\n+ - run for both internal and external types\n+- prepend license to generated files\n+ - wrap the contents of the LICENSE in comments\n+ - exit non-zero if the LICENSE file is missing\n+\n+#### Specifying copyright owners\n+\n+The copyright owners for the license can be defined with the `--copyright` flag\n+\n+```sh\n+kubegen --copyright \"The Kubernetes Authors.\"\n+```\n+\n+- run all code generators against discovered APIs\n+ - run for both internal and external types\n+- prepend license to generated files\n+ - wrap the contents of the LICENSE in comments\n+ - start license with \"Copyright <current year> <copyright>\" e.g. *Copyright 2018 The Kubernetes Authors.*\n+ - exit non-zero if the LICENSE file is missing\n+\n+\n+#### Specifying the license file\n+\n+The license file can be overridden from the LICENSE file using the `--license-file` flag\n+\n+```sh\n+kubegen --license-file \"boilerplate.go.txt\"","path":"docs/proposals/kubegen.md","position":86,"original_position":87,"commit_id":"b7b20ee02123331c9f5707e51684163e027ac0e6","original_commit_id":"7d4bd09a3f11faa2ad82dd99e8842caace69ee5b","user":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"body":"How about we start with just `--license-file` with the description saying it specifies boilerplate.go.txt. Having 2 flags for the same thing is a bit confusing.","created_at":"2017-11-02T16:10:07Z","updated_at":"2017-11-02T16:10:07Z","html_url":"https://github.com/kubernetes/code-generator/pull/17#discussion_r148581426","pull_request_url":"https://api.github.com/repos/kubernetes/code-generator/pulls/17","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/code-generator/pulls/comments/148581426"},"html":{"href":"https://github.com/kubernetes/code-generator/pull/17#discussion_r148581426"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/code-generator/pulls/17"}},"in_reply_to_id":148227445},"pull_request":{"url":"https://api.github.com/repos/kubernetes/code-generator/pulls/17","id":149637147,"html_url":"https://github.com/kubernetes/code-generator/pull/17","diff_url":"https://github.com/kubernetes/code-generator/pull/17.diff","patch_url":"https://github.com/kubernetes/code-generator/pull/17.patch","issue_url":"https://api.github.com/repos/kubernetes/code-generator/issues/17","number":17,"state":"closed","locked":false,"title":"Proposal for meta-generator","user":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"body":"This is a proposal in the form of what would be the user facing documentation for a meta code generation tool.\r\n\r\nkubernetes/kubernetes#53524","created_at":"2017-10-30T21:04:00Z","updated_at":"2017-11-02T16:10:07Z","closed_at":"2017-11-01T22:42:37Z","merged_at":null,"merge_commit_sha":"a39b007227e452f07b5d3ec84357574b06131411","assignee":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/code-generator/pulls/17/commits","review_comments_url":"https://api.github.com/repos/kubernetes/code-generator/pulls/17/comments","review_comment_url":"https://api.github.com/repos/kubernetes/code-generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/code-generator/issues/17/comments","statuses_url":"https://api.github.com/repos/kubernetes/code-generator/statuses/b7b20ee02123331c9f5707e51684163e027ac0e6","head":{"label":"pwittrock:master","ref":"master","sha":"b7b20ee02123331c9f5707e51684163e027ac0e6","user":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"repo":{"id":108905552,"name":"code-generator","full_name":"pwittrock/code-generator","owner":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pwittrock/code-generator","description":"Generators for kube-like API types","fork":true,"url":"https://api.github.com/repos/pwittrock/code-generator","forks_url":"https://api.github.com/repos/pwittrock/code-generator/forks","keys_url":"https://api.github.com/repos/pwittrock/code-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwittrock/code-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwittrock/code-generator/teams","hooks_url":"https://api.github.com/repos/pwittrock/code-generator/hooks","issue_events_url":"https://api.github.com/repos/pwittrock/code-generator/issues/events{/number}","events_url":"https://api.github.com/repos/pwittrock/code-generator/events","assignees_url":"https://api.github.com/repos/pwittrock/code-generator/assignees{/user}","branches_url":"https://api.github.com/repos/pwittrock/code-generator/branches{/branch}","tags_url":"https://api.github.com/repos/pwittrock/code-generator/tags","blobs_url":"https://api.github.com/repos/pwittrock/code-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwittrock/code-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwittrock/code-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwittrock/code-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwittrock/code-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/pwittrock/code-generator/languages","stargazers_url":"https://api.github.com/repos/pwittrock/code-generator/stargazers","contributors_url":"https://api.github.com/repos/pwittrock/code-generator/contributors","subscribers_url":"https://api.github.com/repos/pwittrock/code-generator/subscribers","subscription_url":"https://api.github.com/repos/pwittrock/code-generator/subscription","commits_url":"https://api.github.com/repos/pwittrock/code-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwittrock/code-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwittrock/code-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwittrock/code-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pwittrock/code-generator/contents/{+path}","compare_url":"https://api.github.com/repos/pwittrock/code-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwittrock/code-generator/merges","archive_url":"https://api.github.com/repos/pwittrock/code-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwittrock/code-generator/downloads","issues_url":"https://api.github.com/repos/pwittrock/code-generator/issues{/number}","pulls_url":"https://api.github.com/repos/pwittrock/code-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/pwittrock/code-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/pwittrock/code-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwittrock/code-generator/labels{/name}","releases_url":"https://api.github.com/repos/pwittrock/code-generator/releases{/id}","deployments_url":"https://api.github.com/repos/pwittrock/code-generator/deployments","created_at":"2017-10-30T20:36:26Z","updated_at":"2017-10-30T20:36:27Z","pushed_at":"2017-11-01T22:39:25Z","git_url":"git://github.com/pwittrock/code-generator.git","ssh_url":"[email protected]:pwittrock/code-generator.git","clone_url":"https://github.com/pwittrock/code-generator.git","svn_url":"https://github.com/pwittrock/code-generator","homepage":null,"size":2997,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"961bc077103364eb5bda2c40e2b560d068c9a8c6","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":100410169,"name":"code-generator","full_name":"kubernetes/code-generator","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/code-generator","description":"Generators for kube-like API types","fork":false,"url":"https://api.github.com/repos/kubernetes/code-generator","forks_url":"https://api.github.com/repos/kubernetes/code-generator/forks","keys_url":"https://api.github.com/repos/kubernetes/code-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/code-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/code-generator/teams","hooks_url":"https://api.github.com/repos/kubernetes/code-generator/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/code-generator/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/code-generator/events","assignees_url":"https://api.github.com/repos/kubernetes/code-generator/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/code-generator/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/code-generator/tags","blobs_url":"https://api.github.com/repos/kubernetes/code-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/code-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/code-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/code-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/code-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/code-generator/languages","stargazers_url":"https://api.github.com/repos/kubernetes/code-generator/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/code-generator/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/code-generator/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/code-generator/subscription","commits_url":"https://api.github.com/repos/kubernetes/code-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/code-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/code-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/code-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/code-generator/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/code-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/code-generator/merges","archive_url":"https://api.github.com/repos/kubernetes/code-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/code-generator/downloads","issues_url":"https://api.github.com/repos/kubernetes/code-generator/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/code-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/code-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/code-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/code-generator/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/code-generator/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/code-generator/deployments","created_at":"2017-08-15T19:12:23Z","updated_at":"2017-10-29T21:42:32Z","pushed_at":"2017-11-01T22:39:27Z","git_url":"git://github.com/kubernetes/code-generator.git","ssh_url":"[email protected]:kubernetes/code-generator.git","clone_url":"https://github.com/kubernetes/code-generator.git","svn_url":"https://github.com/kubernetes/code-generator","homepage":null,"size":2993,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":12,"forks":14,"open_issues":12,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/code-generator/pulls/17"},"html":{"href":"https://github.com/kubernetes/code-generator/pull/17"},"issue":{"href":"https://api.github.com/repos/kubernetes/code-generator/issues/17"},"comments":{"href":"https://api.github.com/repos/kubernetes/code-generator/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/code-generator/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/code-generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/code-generator/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/code-generator/statuses/b7b20ee02123331c9f5707e51684163e027ac0e6"}},"author_association":"MEMBER"}} | {
"id": 100410169,
"name": "kubernetes/code-generator",
"url": "https://api.github.com/repos/kubernetes/code-generator"
} | {
"id": 7882754,
"login": "pwittrock",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7882754?",
"url": "https://api.github.com/users/pwittrock"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-11-02T16:10:07 | 6801219863 | {"actor":{"display_login":"pwittrock"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/147437389","pull_request_review_id":72536989,"id":147437389,"diff_hunk":"@@ -63,8 +63,8 @@ type Interface interface {\n \n // ValidationInterface is an abstract, pluggable interface for Admission Control decisions.\n type ValidationInterface interface {\n-\t// Validate makes an admission decision based on the request attributes. It is NOT allowed to mutate\n-\tValidate(a Attributes) (err error)\n+\t// ValidatingAdmit makes an admission decision based on the request attributes. It is NOT allowed to mutate\n+\tValidatingAdmit(a Attributes) (err error)","path":"staging/src/k8s.io/apiserver/pkg/admission/interfaces.go","position":null,"original_position":7,"commit_id":"52de21464d83c75bab1e3908e392a58e761b1580","original_commit_id":"790b4cf265e88c555488b719a9e1bcc12867c708","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"have renamed Validate to ValidateInitialization and ValidatingAdmit to Validate.","created_at":"2017-10-27T15:11:09Z","updated_at":"2017-10-27T15:11:09Z","html_url":"https://github.com/kubernetes/kubernetes/pull/54484#discussion_r147437389","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54484","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/147437389"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/54484#discussion_r147437389"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54484"}},"in_reply_to_id":147195598},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54484","id":148399800,"html_url":"https://github.com/kubernetes/kubernetes/pull/54484","diff_url":"https://github.com/kubernetes/kubernetes/pull/54484.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/54484.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54484","number":54484,"state":"open","locked":false,"title":"admission: wire through validating-only admission","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"Based on https://github.com/kubernetes/kubernetes/pull/54232.\r\n\r\nThis is important and required for beta because it affects the shape of the webhook admission plugins that are going to be produced and is needed to make sure that our existing chain continues to properly verify and protect the API objects based on their final state after webhook admission mutators run.\r\n\r\nWe discussed this in the October 11 API machinery call with @erictune and @caesarxuchao and we agreed to do this as a requirement for beta. See this part of the recording: https://www.youtube.com/watch?v=mrgDPHyr4VY#t=325 .","created_at":"2017-10-24T13:38:42Z","updated_at":"2017-10-27T15:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80012089b740fa6a7ec979fec8408c4161f779fc","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54484/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54484/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54484/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/52de21464d83c75bab1e3908e392a58e761b1580","head":{"label":"sttts:sttts-split-psp","ref":"sttts-split-psp","sha":"52de21464d83c75bab1e3908e392a58e761b1580","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"repo":{"id":36099048,"name":"kubernetes","full_name":"sttts/kubernetes","owner":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sttts/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/sttts/kubernetes","forks_url":"https://api.github.com/repos/sttts/kubernetes/forks","keys_url":"https://api.github.com/repos/sttts/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttts/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttts/kubernetes/teams","hooks_url":"https://api.github.com/repos/sttts/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sttts/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sttts/kubernetes/events","assignees_url":"https://api.github.com/repos/sttts/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sttts/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sttts/kubernetes/tags","blobs_url":"https://api.github.com/repos/sttts/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttts/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttts/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttts/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttts/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sttts/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sttts/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sttts/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sttts/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sttts/kubernetes/subscription","commits_url":"https://api.github.com/repos/sttts/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttts/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttts/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttts/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttts/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sttts/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttts/kubernetes/merges","archive_url":"https://api.github.com/repos/sttts/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttts/kubernetes/downloads","issues_url":"https://api.github.com/repos/sttts/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sttts/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sttts/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sttts/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttts/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sttts/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/sttts/kubernetes/deployments","created_at":"2015-05-22T23:09:55Z","updated_at":"2017-08-24T05:29:53Z","pushed_at":"2017-10-27T09:10:22Z","git_url":"git://github.com/sttts/kubernetes.git","ssh_url":"[email protected]:sttts/kubernetes.git","clone_url":"https://github.com/sttts/kubernetes.git","svn_url":"https://github.com/sttts/kubernetes","homepage":null,"size":502892,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5f030f4568822e791054d5c4c3aff7f9f5c85151","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-10-27T14:24:41Z","pushed_at":"2017-10-27T15:08:53Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"[email protected]:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":726085,"stargazers_count":28200,"watchers_count":28200,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10098,"mirror_url":null,"archived":false,"open_issues_count":5592,"forks":10098,"open_issues":5592,"watchers":28200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54484"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/54484"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/54484"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/54484/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54484/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54484/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/52de21464d83c75bab1e3908e392a58e761b1580"}},"author_association":"CONTRIBUTOR"}} | {
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
} | {
"id": 730123,
"login": "sttts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/730123?",
"url": "https://api.github.com/users/sttts"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2017-10-27T15:11:09 | 6775715622 | {"actor":{"display_login":"sttts"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/125454193","pull_request_review_id":47836691,"id":125454193,"diff_hunk":"@@ -769,6 +770,13 @@ object AppDefinition extends GeneralPurposeCombinators {\n }\n }\n \n+ private val complyWithMesosHealthChecks: Validator[AppDefinition] =\n+ conditional[AppDefinition](appDef =>\n+ (appDef.healthChecks.count(_.isInstanceOf[MesosHealthCheck]) -\n+ appDef.healthChecks.count(_.isInstanceOf[MesosCommandHealthCheck])) > 0) {\n+ featureEnabled(Features.MESOS_HEALTHCHECKS)","path":"src/main/scala/mesosphere/marathon/state/AppDefinition.scala","position":120,"original_position":16,"commit_id":"ed340f969186ae99d43ad10cc42aadeae2997980","original_commit_id":"ed340f969186ae99d43ad10cc42aadeae2997980","user":{"login":"unterstein","id":904420,"avatar_url":"https://avatars0.githubusercontent.com/u/904420?v=3","gravatar_id":"","url":"https://api.github.com/users/unterstein","html_url":"https://github.com/unterstein","followers_url":"https://api.github.com/users/unterstein/followers","following_url":"https://api.github.com/users/unterstein/following{/other_user}","gists_url":"https://api.github.com/users/unterstein/gists{/gist_id}","starred_url":"https://api.github.com/users/unterstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unterstein/subscriptions","organizations_url":"https://api.github.com/users/unterstein/orgs","repos_url":"https://api.github.com/users/unterstein/repos","events_url":"https://api.github.com/users/unterstein/events{/privacy}","received_events_url":"https://api.github.com/users/unterstein/received_events","type":"User","site_admin":false},"body":"I would add something like this additionally:\r\n\r\n```\r\nval mesosHealthCheckMinVersion = SemanticVersion(1, 2, 0)\r\n...\r\nfeatureEnabled(Features.MESOS_HEALTHCHECKS) && LibMesos.version >= mesosHealthCheckMinVersion\r\n```\r\n\r\nWhat do you think?","created_at":"2017-07-04T11:49:29Z","updated_at":"2017-07-04T12:02:34Z","html_url":"https://github.com/mesosphere/marathon/pull/5406#discussion_r125454193","pull_request_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5406","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/125454193"},"html":{"href":"https://github.com/mesosphere/marathon/pull/5406#discussion_r125454193"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5406"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/5406","id":122264100,"html_url":"https://github.com/mesosphere/marathon/pull/5406","diff_url":"https://github.com/mesosphere/marathon/pull/5406.diff","patch_url":"https://github.com/mesosphere/marathon/pull/5406.patch","issue_url":"https://api.github.com/repos/mesosphere/marathon/issues/5406","number":5406,"state":"open","locked":false,"title":"Fixes #4168 - Add support for Mesos HTTP/TCP health checks (#4210)","user":{"login":"janisz","id":1616386,"avatar_url":"https://avatars3.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"body":"This is a cherrypick of a @gkleiman's PR #4210. \r\nMarathon 1.4 introduced Mesos HTTP/TCP healthchecks. This could result in better performance of a Marathon. Unfortunately Marathon 1.4 introduced a performance degradation making it unusable in bigger installations ([MARATHON-7358](https://jira.mesosphere.com/browse/MARATHON-7358)). This PR add Mesos Healthcecks support to Marathon 1.3. This change is future proof and upgrading to 1.4 is safe.\r\n\r\nMoving all Marathon applications from Marathon healthcecks to Mesos Healthcecks can't be done at once. Every application need to be redeployed with new configuration. This PR allow users to slowly move to Mesos Healthchecks and then upgrade to Marathon 1.4\r\n\r\n<details>\r\nManually fixed Conflicts:\r\n\r\n-\t[`project/build.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/project/build.scala)\r\n-\t[`src/main/java/mesosphere/marathon/Protos.java`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/main/java/mesosphere/marathon/Protos.java)\r\n-\t[`src/main/scala/mesosphere/marathon/core/health/HealthCheck.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/main/scala/mesosphere/marathon/core/health/HealthCheck.scala)\r\n-\t[`src/main/scala/mesosphere/marathon/core/health/impl/HealthCheckActor.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/main/scala/mesosphere/marathon/core/health/impl/HealthCheckActor.scala)\r\n-\t[`src/main/scala/mesosphere/marathon/core/health/impl/MarathonHealthCheckManager.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/main/scala/mesosphere/marathon/core/health/impl/MarathonHealthCheckManager.scala)\r\n-\t[`src/main/scala/mesosphere/marathon/state/AppDefinition.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/main/scala/mesosphere/marathon/state/AppDefinition.scala)\r\n-\t[`src/test/scala/mesosphere/marathon/api/v2/json/AppDefinitionTest.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/test/scala/mesosphere/marathon/api/v2/json/AppDefinitionTest.scala)\r\n-\t[`src/test/scala/mesosphere/marathon/core/health/impl/HealthCheckActorTest.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/test/scala/mesosphere/marathon/core/health/impl/HealthCheckActorTest.scala)\r\n-\t[`src/test/scala/mesosphere/marathon/core/health/impl/MarathonHealthCheckManagerTest.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/test/scala/mesosphere/marathon/core/health/impl/MarathonHealthCheckManagerTest.scala)\r\n-\t[`src/test/scala/mesosphere/marathon/integration/AppDeployIntegrationTest.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/test/scala/mesosphere/marathon/integration/AppDeployIntegrationTest.scala)\r\n-\t[`src/test/scala/mesosphere/marathon/state/MarathonStoreTest.scala`](https://github.com/janisz/marathon/blob/431de4e8932b048433405131a8875904895f4d73/src/test/scala/mesosphere/marathon/state/MarathonStoreTest.scala)\r\n</details>","created_at":"2017-05-24T15:57:54Z","updated_at":"2017-07-04T12:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"904d950817fb9018eb1d19056b1938448d687ae0","assignee":{"login":"timcharper","id":183,"avatar_url":"https://avatars2.githubusercontent.com/u/183?v=3","gravatar_id":"","url":"https://api.github.com/users/timcharper","html_url":"https://github.com/timcharper","followers_url":"https://api.github.com/users/timcharper/followers","following_url":"https://api.github.com/users/timcharper/following{/other_user}","gists_url":"https://api.github.com/users/timcharper/gists{/gist_id}","starred_url":"https://api.github.com/users/timcharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcharper/subscriptions","organizations_url":"https://api.github.com/users/timcharper/orgs","repos_url":"https://api.github.com/users/timcharper/repos","events_url":"https://api.github.com/users/timcharper/events{/privacy}","received_events_url":"https://api.github.com/users/timcharper/received_events","type":"User","site_admin":false},"assignees":[{"login":"timcharper","id":183,"avatar_url":"https://avatars2.githubusercontent.com/u/183?v=3","gravatar_id":"","url":"https://api.github.com/users/timcharper","html_url":"https://github.com/timcharper","followers_url":"https://api.github.com/users/timcharper/followers","following_url":"https://api.github.com/users/timcharper/following{/other_user}","gists_url":"https://api.github.com/users/timcharper/gists{/gist_id}","starred_url":"https://api.github.com/users/timcharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcharper/subscriptions","organizations_url":"https://api.github.com/users/timcharper/orgs","repos_url":"https://api.github.com/users/timcharper/repos","events_url":"https://api.github.com/users/timcharper/events{/privacy}","received_events_url":"https://api.github.com/users/timcharper/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jdef","id":2348332,"avatar_url":"https://avatars0.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5406/commits","review_comments_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5406/comments","review_comment_url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/5406/comments","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/ed340f969186ae99d43ad10cc42aadeae2997980","head":{"label":"janisz:cherrypick/#4168/add_support_for_mesos_http/tcp_health_checks","ref":"cherrypick/#4168/add_support_for_mesos_http/tcp_health_checks","sha":"ed340f969186ae99d43ad10cc42aadeae2997980","user":{"login":"janisz","id":1616386,"avatar_url":"https://avatars3.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"repo":{"id":38816996,"name":"marathon","full_name":"janisz/marathon","owner":{"login":"janisz","id":1616386,"avatar_url":"https://avatars3.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janisz/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":true,"url":"https://api.github.com/repos/janisz/marathon","forks_url":"https://api.github.com/repos/janisz/marathon/forks","keys_url":"https://api.github.com/repos/janisz/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janisz/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janisz/marathon/teams","hooks_url":"https://api.github.com/repos/janisz/marathon/hooks","issue_events_url":"https://api.github.com/repos/janisz/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/janisz/marathon/events","assignees_url":"https://api.github.com/repos/janisz/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/janisz/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/janisz/marathon/tags","blobs_url":"https://api.github.com/repos/janisz/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janisz/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janisz/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/janisz/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janisz/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/janisz/marathon/languages","stargazers_url":"https://api.github.com/repos/janisz/marathon/stargazers","contributors_url":"https://api.github.com/repos/janisz/marathon/contributors","subscribers_url":"https://api.github.com/repos/janisz/marathon/subscribers","subscription_url":"https://api.github.com/repos/janisz/marathon/subscription","commits_url":"https://api.github.com/repos/janisz/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/janisz/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/janisz/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/janisz/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/janisz/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/janisz/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janisz/marathon/merges","archive_url":"https://api.github.com/repos/janisz/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janisz/marathon/downloads","issues_url":"https://api.github.com/repos/janisz/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/janisz/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/janisz/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/janisz/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janisz/marathon/labels{/name}","releases_url":"https://api.github.com/repos/janisz/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/janisz/marathon/deployments","created_at":"2015-07-09T11:44:23Z","updated_at":"2016-01-11T14:57:01Z","pushed_at":"2017-07-04T10:37:29Z","git_url":"git://github.com/janisz/marathon.git","ssh_url":"[email protected]:janisz/marathon.git","clone_url":"https://github.com/janisz/marathon.git","svn_url":"https://github.com/janisz/marathon","homepage":"https://mesosphere.github.io/marathon/","size":28082,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesosphere:releases/1.3","ref":"releases/1.3","sha":"acc261835097aa7dbfe2b33565fb0eb35439a3d2","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars3.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars3.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2017-07-04T11:28:12Z","pushed_at":"2017-07-04T10:37:30Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"[email protected]:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":30605,"stargazers_count":3333,"watchers_count":3333,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":758,"mirror_url":null,"open_issues_count":16,"forks":758,"open_issues":16,"watchers":3333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5406"},"html":{"href":"https://github.com/mesosphere/marathon/pull/5406"},"issue":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/5406"},"comments":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/5406/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5406/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5406/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/marathon/statuses/ed340f969186ae99d43ad10cc42aadeae2997980"}}}} | {
"id": 10941409,
"name": "mesosphere/marathon",
"url": "https://api.github.com/repos/mesosphere/marathon"
} | {
"id": 904420,
"login": "unterstein",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/904420?",
"url": "https://api.github.com/users/unterstein"
} | {
"id": 3458585,
"login": "mesosphere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3458585?",
"url": "https://api.github.com/orgs/mesosphere"
} | 2017-07-04T11:49:29 | 6189092725 | {"actor":{"display_login":"unterstein"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/122286764","pull_request_review_id":44390306,"id":122286764,"diff_hunk":"@@ -10,51 +10,58 @@ import (\n \t\"github.com/mesosphere/dcos-commons/cli/config\"\n )\n \n-func HTTPCosmosPostJSON(urlPath, jsonPayload string) *http.Response {\n-\treturn checkCosmosHTTPResponse(httpQuery(createCosmosHTTPJSONRequest(\"POST\", urlPath, jsonPayload)))\n+// HTTPCosmosPostJSON triggers a HTTP POST request containing jsonPayload to\n+// https://dcos.cluster/cosmos/service/<urlPath>\n+func HTTPCosmosPostJSON(urlPath, jsonPayload string) ([]byte, error) {\n+\tSetCustomResponseCheck(checkCosmosHTTPResponse)\n+\treturn checkHTTPResponse(httpQuery(createCosmosHTTPJSONRequest(\"POST\", urlPath, jsonPayload)))\n }\n \n-func printBadVersionErrorAndExit(response *http.Response, data map[string]interface{}) {\n-\trequestedVersion := data[\"updateVersion\"]\n-\t//TODO: this is probably an array?\n-\tvalidVersions := data[\"validVersions\"]\n-\tprintResponseError(response)\n-\tLogMessage(\"- Unable to update %s to requested version: %s\", config.ServiceName, requestedVersion)\n-\tLogMessageAndExit(\"- Valid versions are: %s\", validVersions)\n+func createBadVersionError(response *http.Response, data map[string]interface{}) error {\n+\trequestedVersion, _ := GetValueFromJSON(data, \"updateVersion\")\n+\tvalidVersions, _ := GetValueFromJSON(data, \"validVersions\")\n+\tif config.Verbose {\n+\t\tprintResponseError(response)\n+\t}\n+\n+\terrorString := `Unable to update %s to requested version: %s\n+Valid versions are: %s`\n+\n+\treturn fmt.Errorf(errorString, config.ServiceName, requestedVersion, validVersions)\n }\n \n-func parseCosmosHTTPErrorResponse(response *http.Response) {\n-\tresponseJSON, err := UnmarshalJSON(GetResponseBytes(response))\n+func parseCosmosHTTPErrorResponse(response *http.Response, body []byte) error {\n+\tresponseJSON, err := UnmarshalJSON(body)\n \tif err != nil {\n-\t\tprintResponseErrorAndExit(response)\n+\t\treturn createResponseError(response)\n \t}\n \tif errorType, present := responseJSON[\"type\"]; present {\n \t\tmessage := responseJSON[\"message\"]\n \t\tswitch errorType {\n \t\tcase \"MarathonAppNotFound\":","path":"cli/client/cosmos.go","position":44,"original_position":44,"commit_id":"6a6d32ce673ba9a662c6616f3a57762ff95620a0","original_commit_id":"6a6d32ce673ba9a662c6616f3a57762ff95620a0","user":{"login":"ssk2","id":355705,"avatar_url":"https://avatars2.githubusercontent.com/u/355705?v=3","gravatar_id":"","url":"https://api.github.com/users/ssk2","html_url":"https://github.com/ssk2","followers_url":"https://api.github.com/users/ssk2/followers","following_url":"https://api.github.com/users/ssk2/following{/other_user}","gists_url":"https://api.github.com/users/ssk2/gists{/gist_id}","starred_url":"https://api.github.com/users/ssk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssk2/subscriptions","organizations_url":"https://api.github.com/users/ssk2/orgs","repos_url":"https://api.github.com/users/ssk2/repos","events_url":"https://api.github.com/users/ssk2/events{/privacy}","received_events_url":"https://api.github.com/users/ssk2/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-06-15T19:08:20Z","updated_at":"2017-06-15T19:08:20Z","html_url":"https://github.com/mesosphere/dcos-commons/pull/1084#discussion_r122286764","pull_request_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/1084","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/122286764"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/1084#discussion_r122286764"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/1084"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/1084","id":124080398,"html_url":"https://github.com/mesosphere/dcos-commons/pull/1084","diff_url":"https://github.com/mesosphere/dcos-commons/pull/1084.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/1084.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/1084","number":1084,"state":"open","locked":false,"title":"[INFINITY-1609] [INFINITY-1640] Additional commands for update","user":{"login":"ssk2","id":355705,"avatar_url":"https://avatars2.githubusercontent.com/u/355705?v=3","gravatar_id":"","url":"https://api.github.com/users/ssk2","html_url":"https://github.com/ssk2","followers_url":"https://api.github.com/users/ssk2/followers","following_url":"https://api.github.com/users/ssk2/following{/other_user}","gists_url":"https://api.github.com/users/ssk2/gists{/gist_id}","starred_url":"https://api.github.com/users/ssk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssk2/subscriptions","organizations_url":"https://api.github.com/users/ssk2/orgs","repos_url":"https://api.github.com/users/ssk2/repos","events_url":"https://api.github.com/users/ssk2/events{/privacy}","received_events_url":"https://api.github.com/users/ssk2/received_events","type":"User","site_admin":false},"body":"I've essentially just created some new commands for `dcos <service> update` that re-use the handlers for the equivalent commands in `dcos <service> plan`.\r\n\r\nSeveral of these were renamed (but have aliases for the previous commands):\r\n+ continue -> resume\r\n+ interrupt -> pause\r\n+ restart -> force-restart\r\n\r\nThis PR also includes the `dcos <service> update package-versions` command. \r\n\r\nOther changes made:\r\n* I reordered commands and methods in `plan.go` to be in alphabetical order.\r\n* Moved two tests from `update_test.go` to `plan_test.go`.\r\n* Moved printing logic out of `response.go` into `print.go`.\r\n* Changed `plan_test.go` into a TestSuite that will allow us to mock out responses for new tests.\r\n* Fixed all the warnings generated by `golint` and unexported a number of commands that didn't need to be exported.\r\n* Changed the methods in http.go to return `[]byte` instead of Response (this keeps all the code that operates on Response structs in the same library at least).\r\n* Changed some of the methods to return errors instead of printing directly to stdout. I'm hoping this is a first step to eventually getting to a place where we can use Kingpin's error handling logic.\r\n* Fixed a bug in the Plans API where it would only 404 for the first request that came in (and would stacktrace thereafter).\r\n* Added some extra logic to the Plans API to return a 208 if the user has already submitted that request, or it was unable to be fulfilled because the plan had already completed.\r\n\r\nWhat remains to be done:\r\n- [x] Check that output is what it should be\r\n- [x] Validate that this layout is acceptable to @keithchambers (I worry that having redundant options in the help output might be confusing).\r\n- [x] Rebase on top of cli-plan-status when that is ready for merge\r\n- [x] Integration tests for these commands\r\n- [ ] Test package-versions on a live cluster (blocked on https://github.com/dcos/dcos-cli/pull/1001).\r\n- [ ] Better error catching for Cosmos errors.\r\n- [ ] Rollback\r\n\r\nDocs updates will be done as part of #1053.\r\n\r\n```sh\r\n➜ helloworld git:(ssk2/additional-commands) ✗ dcos hello-world\r\nusage: dcos hello-world [<flags>] <command> [<args> ...]\r\n\r\nFlags:\r\n -h, --help Show context-sensitive help (also try --help-long\r\n and --help-man).\r\n -v, --verbose Enable extra logging of requests/responses\r\n --force-insecure Allow unverified TLS certificates when querying\r\n service\r\n --custom-auth-token=DCOS_AUTH_TOKEN\r\n Custom auth token to use when querying service\r\n --custom-dcos-url=DCOS_URI/DCOS_URL\r\n Custom cluster URL to use when querying service\r\n --custom-cert-path=DCOS_CA_PATH/DCOS_CERT_PATH\r\n Custom TLS CA certificate file to use when querying\r\n service\r\n --name=\"hello-world\" Name of the service instance to query\r\n\r\nCommands:\r\n help [<command>...]\r\n Show help.\r\n\r\n config list\r\n List IDs of all available configurations\r\n\r\n config show <config_id>\r\n Display a specified configuration\r\n\r\n config target\r\n Display the target configuration\r\n\r\n config target_id\r\n List ID of the target configuration\r\n\r\n describe\r\n View the package configuration for this DC/OS service\r\n\r\n endpoints [<name>]\r\n View client endpoints\r\n\r\n plan force-complete <plan> <phase> <step>\r\n Force complete a specific step in the provided phase\r\n\r\n plan force-restart <plan> [<phase>] [<step>]\r\n Restart a deploy plan, or specific step in the provided phase\r\n\r\n plan list\r\n Show all plans for this service\r\n\r\n plan pause [<plan>] [<phase>]\r\n Pause the deploy plan, or the plan with the provided name, or a specific\r\n phase in that plan with the provided name or UUID\r\n\r\n plan resume [<plan>] [<phase>]\r\n Resume the deploy plan, or the plan with the provided name, or a specific\r\n phase in that plan with the provided name or UUID\r\n\r\n plan start [<flags>] <plan>\r\n Start the plan with the provided name, with optional envvars to supply to\r\n task\r\n\r\n plan status [<flags>] [<plan>]\r\n Display the deploy plan or the plan with the provided name\r\n\r\n plan stop <plan>\r\n Stop the plan with the provided name\r\n\r\n pods list\r\n Display the list of known pod instances\r\n\r\n pods status [<pod>]\r\n Display the status for tasks in one pod or all pods\r\n\r\n pods info <pod>\r\n Display the full state information for tasks in a pod\r\n\r\n pods restart <pod>\r\n Restarts a given pod without moving it to a new agent\r\n\r\n pods replace <pod>\r\n Destroys a given pod and moves it to a new agent\r\n\r\n state framework_id\r\n Display the Mesos framework ID\r\n\r\n state properties\r\n List names of all custom properties\r\n\r\n state property <name>\r\n Display the content of a specified property\r\n\r\n state refresh_cache\r\n Refresh the state cache, used for debugging\r\n\r\n update force-complete <plan> <phase> <step>\r\n Force complete a specific step in the provided phase\r\n\r\n update force-restart [<plan>] [<phase>] [<step>]\r\n Restart a deploy plan, or specific step in the provided phase\r\n\r\n update pause [<plan>]\r\n Pause the deploy plan, or the plan with the provided name, or a specific\r\n phase in that plan with the provided name or UUID\r\n\r\n update resume [<plan>]\r\n Resume the deploy plan, or the plan with the provided name, or a specific\r\n phase in that plan with the provided name or UUID\r\n\r\n update status [<flags>] [<plan>]\r\n View status of the current update\r\n```","created_at":"2017-06-05T23:17:32Z","updated_at":"2017-06-15T19:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"714b198a00a9937307ca27cf505cbb63e7f139fb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nickbp","id":35933,"avatar_url":"https://avatars1.githubusercontent.com/u/35933?v=3","gravatar_id":"","url":"https://api.github.com/users/nickbp","html_url":"https://github.com/nickbp","followers_url":"https://api.github.com/users/nickbp/followers","following_url":"https://api.github.com/users/nickbp/following{/other_user}","gists_url":"https://api.github.com/users/nickbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbp/subscriptions","organizations_url":"https://api.github.com/users/nickbp/orgs","repos_url":"https://api.github.com/users/nickbp/repos","events_url":"https://api.github.com/users/nickbp/events{/privacy}","received_events_url":"https://api.github.com/users/nickbp/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/1084/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/1084/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/1084/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/6a6d32ce673ba9a662c6616f3a57762ff95620a0","head":{"label":"mesosphere:ssk2/additional-commands","ref":"ssk2/additional-commands","sha":"6a6d32ce673ba9a662c6616f3a57762ff95620a0","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars3.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars3.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2017-06-07T21:13:40Z","pushed_at":"2017-06-15T19:07:37Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"[email protected]:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":56929,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":48,"forks":70,"open_issues":48,"watchers":76,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"6a3cc44ebbc1b0885be7d49aa662bd68688863c1","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars3.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars3.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2017-06-07T21:13:40Z","pushed_at":"2017-06-15T19:07:37Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"[email protected]:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":56929,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":48,"forks":70,"open_issues":48,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/1084"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/1084"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/1084"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/1084/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/1084/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/1084/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/6a6d32ce673ba9a662c6616f3a57762ff95620a0"}}}} | {
"id": 60286497,
"name": "mesosphere/dcos-commons",
"url": "https://api.github.com/repos/mesosphere/dcos-commons"
} | {
"id": 355705,
"login": "ssk2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/355705?",
"url": "https://api.github.com/users/ssk2"
} | {
"id": 3458585,
"login": "mesosphere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3458585?",
"url": "https://api.github.com/orgs/mesosphere"
} | 2017-06-15T19:08:20 | 6074889979 | {"actor":{"display_login":"ssk2"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/comments/127998625","pull_request_review_id":50614480,"id":127998625,"diff_hunk":"@@ -15,6 +15,11 @@\n */\n \n /* @flow */\n+export const blackAndWhite = {","path":"packages/component-utils/src/styleVariables.js","position":4,"original_position":4,"commit_id":"0ab6ddd9e613092bff57fc5766fb451651134910","original_commit_id":"0ab6ddd9e613092bff57fc5766fb451651134910","user":{"login":"brentertz","id":202773,"avatar_url":"https://avatars1.githubusercontent.com/u/202773?v=4","gravatar_id":"","url":"https://api.github.com/users/brentertz","html_url":"https://github.com/brentertz","followers_url":"https://api.github.com/users/brentertz/followers","following_url":"https://api.github.com/users/brentertz/following{/other_user}","gists_url":"https://api.github.com/users/brentertz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentertz/subscriptions","organizations_url":"https://api.github.com/users/brentertz/orgs","repos_url":"https://api.github.com/users/brentertz/repos","events_url":"https://api.github.com/users/brentertz/events{/privacy}","received_events_url":"https://api.github.com/users/brentertz/received_events","type":"User","site_admin":false},"body":"Following how we handled the rest of the palette. It seems like `black` and `white` should just be keys inside the `color` object in `styleVariables`. Then, in `mineralTheme`, we should define `color_black` and `color_white` using those keys.","created_at":"2017-07-18T14:51:23Z","updated_at":"2017-07-18T14:55:26Z","html_url":"https://github.com/mineral-ui/mineral-ui/pull/171#discussion_r127998625","pull_request_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/comments/127998625"},"html":{"href":"https://github.com/mineral-ui/mineral-ui/pull/171#discussion_r127998625"},"pull_request":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/171","id":130689073,"html_url":"https://github.com/mineral-ui/mineral-ui/pull/171","diff_url":"https://github.com/mineral-ui/mineral-ui/pull/171.diff","patch_url":"https://github.com/mineral-ui/mineral-ui/pull/171.patch","issue_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/171","number":171,"state":"open","locked":false,"title":"[Card] Initial component","user":{"login":"kylegach","id":486540,"avatar_url":"https://avatars3.githubusercontent.com/u/486540?v=4","gravatar_id":"","url":"https://api.github.com/users/kylegach","html_url":"https://github.com/kylegach","followers_url":"https://api.github.com/users/kylegach/followers","following_url":"https://api.github.com/users/kylegach/following{/other_user}","gists_url":"https://api.github.com/users/kylegach/gists{/gist_id}","starred_url":"https://api.github.com/users/kylegach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylegach/subscriptions","organizations_url":"https://api.github.com/users/kylegach/orgs","repos_url":"https://api.github.com/users/kylegach/repos","events_url":"https://api.github.com/users/kylegach/events{/privacy}","received_events_url":"https://api.github.com/users/kylegach/received_events","type":"User","site_admin":false},"body":"<!--\r\nNOTE: We’re just getting started. While we appreciate any feedback, we’re not yet ready to accept public contributions.\r\n\r\nThank you for your contribution! Here’s a template to help you format your PR.\r\n\r\nYour title should look like: [ComponentName] Clear, brief title using imperative tense\r\nFor example: [Button] Add support for type=submit\r\n\r\nFor a PR to be considered, each item in the checklist must be checked.\r\n-->\r\n\r\n### Description\r\n<!-- Describe your changes in detail -->\r\n- Add Card, CardActions, CardBlock, CardImage, and CardTitle components (and also a non-exported CardRow)\r\n- Add demos for each of the above\r\n- Add `color_black`, `color_white`, and `spacing_triple` to mineralTheme\r\n\r\nConnects #142\r\n\r\n### Motivation and context\r\n<!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here and auto-close them via commit messages: https://help.github.com/articles/closing-issues-via-commit-messages. -->\r\nAll the cool kids have a Card component.\r\n\r\n### Screenshots or videos, if appropriate\r\n<!-- To record and share a video: http://recordit.co/ -->\r\n<img width=\"328\" alt=\"screen shot 2017-07-14 at 4 54 33 pm\" src=\"https://user-images.githubusercontent.com/486540/28233609-2b993658-68b5-11e7-842a-fff20384dc79.png\">\r\n\r\n### How has this been tested?\r\n<!-- Please describe in detail how you tested your changes beyond automated tests. -->\r\nChecked demo in all supported browsers.\r\n\r\n### Types of changes\r\n<!-- What types of changes does your code introduce? Remove the lines below that are NOT applicable. Note: Whatever you choose here should match your commit messages. -->\r\n- New feature (non-breaking change which adds functionality)\r\n\r\n### Checklist\r\n<!-- Put an `x` in all the boxes that apply and are complete. If an item does not apply, put an `x` in it anyway and add “[n/a]” to the end of the line. If you’re unsure about any of these, don’t hesitate to ask. We’re here to help! -->\r\n* [x] Renders and functions properly in [all supported browsers](https://github.com/mineral-ui/mineral-ui#browser-support)\r\n* [x] Automated tests written and passing\r\n* [x] [Accessibility](http://webaim.org/intro) and [inclusivity](https://24ways.org/2016/what-the-heck-is-inclusive-design/) considered\r\n* [x] Rendering performance (initial load time & 60fps) and [perceived performance](http://blog.teamtreehouse.com/perceived-performance) considered\r\n* [x] Documentation created or updated\r\n\r\n<!-- If any of the above need further details, you should include those here. -->\r\n\r\n### How does this PR make you feel?\r\n<!--\r\n1. Find a gif: http://giphy.com/categories/\r\n2. Click 'Copy link'\r\n3. Copy the 'GIF Link', paste it in place of the URL below, and update the alt text\r\n-->\r\n","created_at":"2017-07-14T22:57:52Z","updated_at":"2017-07-18T14:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"riley","id":282503,"avatar_url":"https://avatars0.githubusercontent.com/u/282503?v=4","gravatar_id":"","url":"https://api.github.com/users/riley","html_url":"https://github.com/riley","followers_url":"https://api.github.com/users/riley/followers","following_url":"https://api.github.com/users/riley/following{/other_user}","gists_url":"https://api.github.com/users/riley/gists{/gist_id}","starred_url":"https://api.github.com/users/riley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riley/subscriptions","organizations_url":"https://api.github.com/users/riley/orgs","repos_url":"https://api.github.com/users/riley/repos","events_url":"https://api.github.com/users/riley/events{/privacy}","received_events_url":"https://api.github.com/users/riley/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/171/commits","review_comments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/171/comments","review_comment_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/171/comments","statuses_url":"https://api.github.com/repos/mineral-ui/mineral-ui/statuses/0ab6ddd9e613092bff57fc5766fb451651134910","head":{"label":"mineral-ui:142-card","ref":"142-card","sha":"0ab6ddd9e613092bff57fc5766fb451651134910","user":{"login":"mineral-ui","id":27220460,"avatar_url":"https://avatars1.githubusercontent.com/u/27220460?v=4","gravatar_id":"","url":"https://api.github.com/users/mineral-ui","html_url":"https://github.com/mineral-ui","followers_url":"https://api.github.com/users/mineral-ui/followers","following_url":"https://api.github.com/users/mineral-ui/following{/other_user}","gists_url":"https://api.github.com/users/mineral-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/mineral-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mineral-ui/subscriptions","organizations_url":"https://api.github.com/users/mineral-ui/orgs","repos_url":"https://api.github.com/users/mineral-ui/repos","events_url":"https://api.github.com/users/mineral-ui/events{/privacy}","received_events_url":"https://api.github.com/users/mineral-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":87827232,"name":"mineral-ui","full_name":"mineral-ui/mineral-ui","owner":{"login":"mineral-ui","id":27220460,"avatar_url":"https://avatars1.githubusercontent.com/u/27220460?v=4","gravatar_id":"","url":"https://api.github.com/users/mineral-ui","html_url":"https://github.com/mineral-ui","followers_url":"https://api.github.com/users/mineral-ui/followers","following_url":"https://api.github.com/users/mineral-ui/following{/other_user}","gists_url":"https://api.github.com/users/mineral-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/mineral-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mineral-ui/subscriptions","organizations_url":"https://api.github.com/users/mineral-ui/orgs","repos_url":"https://api.github.com/users/mineral-ui/repos","events_url":"https://api.github.com/users/mineral-ui/events{/privacy}","received_events_url":"https://api.github.com/users/mineral-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mineral-ui/mineral-ui","description":"A design system and React component library for the web brought to you by CA Technologies.","fork":false,"url":"https://api.github.com/repos/mineral-ui/mineral-ui","forks_url":"https://api.github.com/repos/mineral-ui/mineral-ui/forks","keys_url":"https://api.github.com/repos/mineral-ui/mineral-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mineral-ui/mineral-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mineral-ui/mineral-ui/teams","hooks_url":"https://api.github.com/repos/mineral-ui/mineral-ui/hooks","issue_events_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mineral-ui/mineral-ui/events","assignees_url":"https://api.github.com/repos/mineral-ui/mineral-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mineral-ui/mineral-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mineral-ui/mineral-ui/tags","blobs_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mineral-ui/mineral-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mineral-ui/mineral-ui/languages","stargazers_url":"https://api.github.com/repos/mineral-ui/mineral-ui/stargazers","contributors_url":"https://api.github.com/repos/mineral-ui/mineral-ui/contributors","subscribers_url":"https://api.github.com/repos/mineral-ui/mineral-ui/subscribers","subscription_url":"https://api.github.com/repos/mineral-ui/mineral-ui/subscription","commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mineral-ui/mineral-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mineral-ui/mineral-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mineral-ui/mineral-ui/merges","archive_url":"https://api.github.com/repos/mineral-ui/mineral-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mineral-ui/mineral-ui/downloads","issues_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mineral-ui/mineral-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mineral-ui/mineral-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mineral-ui/mineral-ui/labels{/name}","releases_url":"https://api.github.com/repos/mineral-ui/mineral-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/deployments","created_at":"2017-04-10T15:29:20Z","updated_at":"2017-07-12T00:13:23Z","pushed_at":"2017-07-17T22:34:15Z","git_url":"git://github.com/mineral-ui/mineral-ui.git","ssh_url":"[email protected]:mineral-ui/mineral-ui.git","clone_url":"https://github.com/mineral-ui/mineral-ui.git","svn_url":"https://github.com/mineral-ui/mineral-ui","homepage":"http://mineral-ui.com","size":705,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":62,"forks":1,"open_issues":62,"watchers":50,"default_branch":"master"}},"base":{"label":"mineral-ui:master","ref":"master","sha":"bbe592f0e35316476b08969d169f66a4451a8e69","user":{"login":"mineral-ui","id":27220460,"avatar_url":"https://avatars1.githubusercontent.com/u/27220460?v=4","gravatar_id":"","url":"https://api.github.com/users/mineral-ui","html_url":"https://github.com/mineral-ui","followers_url":"https://api.github.com/users/mineral-ui/followers","following_url":"https://api.github.com/users/mineral-ui/following{/other_user}","gists_url":"https://api.github.com/users/mineral-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/mineral-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mineral-ui/subscriptions","organizations_url":"https://api.github.com/users/mineral-ui/orgs","repos_url":"https://api.github.com/users/mineral-ui/repos","events_url":"https://api.github.com/users/mineral-ui/events{/privacy}","received_events_url":"https://api.github.com/users/mineral-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":87827232,"name":"mineral-ui","full_name":"mineral-ui/mineral-ui","owner":{"login":"mineral-ui","id":27220460,"avatar_url":"https://avatars1.githubusercontent.com/u/27220460?v=4","gravatar_id":"","url":"https://api.github.com/users/mineral-ui","html_url":"https://github.com/mineral-ui","followers_url":"https://api.github.com/users/mineral-ui/followers","following_url":"https://api.github.com/users/mineral-ui/following{/other_user}","gists_url":"https://api.github.com/users/mineral-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/mineral-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mineral-ui/subscriptions","organizations_url":"https://api.github.com/users/mineral-ui/orgs","repos_url":"https://api.github.com/users/mineral-ui/repos","events_url":"https://api.github.com/users/mineral-ui/events{/privacy}","received_events_url":"https://api.github.com/users/mineral-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mineral-ui/mineral-ui","description":"A design system and React component library for the web brought to you by CA Technologies.","fork":false,"url":"https://api.github.com/repos/mineral-ui/mineral-ui","forks_url":"https://api.github.com/repos/mineral-ui/mineral-ui/forks","keys_url":"https://api.github.com/repos/mineral-ui/mineral-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mineral-ui/mineral-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mineral-ui/mineral-ui/teams","hooks_url":"https://api.github.com/repos/mineral-ui/mineral-ui/hooks","issue_events_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mineral-ui/mineral-ui/events","assignees_url":"https://api.github.com/repos/mineral-ui/mineral-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mineral-ui/mineral-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mineral-ui/mineral-ui/tags","blobs_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mineral-ui/mineral-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mineral-ui/mineral-ui/languages","stargazers_url":"https://api.github.com/repos/mineral-ui/mineral-ui/stargazers","contributors_url":"https://api.github.com/repos/mineral-ui/mineral-ui/contributors","subscribers_url":"https://api.github.com/repos/mineral-ui/mineral-ui/subscribers","subscription_url":"https://api.github.com/repos/mineral-ui/mineral-ui/subscription","commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mineral-ui/mineral-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mineral-ui/mineral-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mineral-ui/mineral-ui/merges","archive_url":"https://api.github.com/repos/mineral-ui/mineral-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mineral-ui/mineral-ui/downloads","issues_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mineral-ui/mineral-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mineral-ui/mineral-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mineral-ui/mineral-ui/labels{/name}","releases_url":"https://api.github.com/repos/mineral-ui/mineral-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/deployments","created_at":"2017-04-10T15:29:20Z","updated_at":"2017-07-12T00:13:23Z","pushed_at":"2017-07-17T22:34:15Z","git_url":"git://github.com/mineral-ui/mineral-ui.git","ssh_url":"[email protected]:mineral-ui/mineral-ui.git","clone_url":"https://github.com/mineral-ui/mineral-ui.git","svn_url":"https://github.com/mineral-ui/mineral-ui","homepage":"http://mineral-ui.com","size":705,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":62,"forks":1,"open_issues":62,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/171"},"html":{"href":"https://github.com/mineral-ui/mineral-ui/pull/171"},"issue":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/171"},"comments":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/statuses/0ab6ddd9e613092bff57fc5766fb451651134910"}}}} | {
"id": 87827232,
"name": "mineral-ui/mineral-ui",
"url": "https://api.github.com/repos/mineral-ui/mineral-ui"
} | {
"id": 202773,
"login": "brentertz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/202773?",
"url": "https://api.github.com/users/brentertz"
} | {
"id": 27220460,
"login": "mineral-ui",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27220460?",
"url": "https://api.github.com/orgs/mineral-ui"
} | 2017-07-18T14:51:23 | 6278737127 | {"actor":{"display_login":"brentertz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/moldedbits/argus-android/pulls/comments/126612546","pull_request_review_id":49111128,"id":126612546,"diff_hunk":"@@ -26,13 +23,14 @@\n /**\n * Allow user to login with email and password\n */\n-public abstract class EmailLoginProvider extends BaseProvider {\n+public abstract class EmailLoginProvider extends BaseProviderHandler {","path":"argus/src/main/java/com/moldedbits/argus/provider/login/EmailLoginProvider.java","position":30,"original_position":30,"commit_id":"1bb447efa733fbe7bc238b02645fb61fbb8f986c","original_commit_id":"1bb447efa733fbe7bc238b02645fb61fbb8f986c","user":{"login":"anujmiddha","id":1011854,"avatar_url":"https://avatars1.githubusercontent.com/u/1011854?v=3","gravatar_id":"","url":"https://api.github.com/users/anujmiddha","html_url":"https://github.com/anujmiddha","followers_url":"https://api.github.com/users/anujmiddha/followers","following_url":"https://api.github.com/users/anujmiddha/following{/other_user}","gists_url":"https://api.github.com/users/anujmiddha/gists{/gist_id}","starred_url":"https://api.github.com/users/anujmiddha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anujmiddha/subscriptions","organizations_url":"https://api.github.com/users/anujmiddha/orgs","repos_url":"https://api.github.com/users/anujmiddha/repos","events_url":"https://api.github.com/users/anujmiddha/events{/privacy}","received_events_url":"https://api.github.com/users/anujmiddha/received_events","type":"User","site_admin":false},"body":"Why not add `applyTheme` in `BaseProvider` itself?","created_at":"2017-07-11T07:20:53Z","updated_at":"2017-07-11T07:21:29Z","html_url":"https://github.com/moldedbits/argus-android/pull/31#discussion_r126612546","pull_request_url":"https://api.github.com/repos/moldedbits/argus-android/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/moldedbits/argus-android/pulls/comments/126612546"},"html":{"href":"https://github.com/moldedbits/argus-android/pull/31#discussion_r126612546"},"pull_request":{"href":"https://api.github.com/repos/moldedbits/argus-android/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/moldedbits/argus-android/pulls/31","id":129835604,"html_url":"https://github.com/moldedbits/argus-android/pull/31","diff_url":"https://github.com/moldedbits/argus-android/pull/31.diff","patch_url":"https://github.com/moldedbits/argus-android/pull/31.patch","issue_url":"https://api.github.com/repos/moldedbits/argus-android/issues/31","number":31,"state":"open","locked":false,"title":"Sh argus shopdroid","user":{"login":"therealshabi","id":15019528,"avatar_url":"https://avatars3.githubusercontent.com/u/15019528?v=3","gravatar_id":"","url":"https://api.github.com/users/therealshabi","html_url":"https://github.com/therealshabi","followers_url":"https://api.github.com/users/therealshabi/followers","following_url":"https://api.github.com/users/therealshabi/following{/other_user}","gists_url":"https://api.github.com/users/therealshabi/gists{/gist_id}","starred_url":"https://api.github.com/users/therealshabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealshabi/subscriptions","organizations_url":"https://api.github.com/users/therealshabi/orgs","repos_url":"https://api.github.com/users/therealshabi/repos","events_url":"https://api.github.com/users/therealshabi/events{/privacy}","received_events_url":"https://api.github.com/users/therealshabi/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-11T06:55:46Z","updated_at":"2017-07-11T07:21:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1f8e420465d622642c8ba88f35e7cb6b3aed404","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shishanksingh2015","id":13149641,"avatar_url":"https://avatars0.githubusercontent.com/u/13149641?v=3","gravatar_id":"","url":"https://api.github.com/users/shishanksingh2015","html_url":"https://github.com/shishanksingh2015","followers_url":"https://api.github.com/users/shishanksingh2015/followers","following_url":"https://api.github.com/users/shishanksingh2015/following{/other_user}","gists_url":"https://api.github.com/users/shishanksingh2015/gists{/gist_id}","starred_url":"https://api.github.com/users/shishanksingh2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shishanksingh2015/subscriptions","organizations_url":"https://api.github.com/users/shishanksingh2015/orgs","repos_url":"https://api.github.com/users/shishanksingh2015/repos","events_url":"https://api.github.com/users/shishanksingh2015/events{/privacy}","received_events_url":"https://api.github.com/users/shishanksingh2015/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moldedbits/argus-android/pulls/31/commits","review_comments_url":"https://api.github.com/repos/moldedbits/argus-android/pulls/31/comments","review_comment_url":"https://api.github.com/repos/moldedbits/argus-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moldedbits/argus-android/issues/31/comments","statuses_url":"https://api.github.com/repos/moldedbits/argus-android/statuses/1bb447efa733fbe7bc238b02645fb61fbb8f986c","head":{"label":"therealshabi:sh_argus_shopdroid","ref":"sh_argus_shopdroid","sha":"1bb447efa733fbe7bc238b02645fb61fbb8f986c","user":{"login":"therealshabi","id":15019528,"avatar_url":"https://avatars3.githubusercontent.com/u/15019528?v=3","gravatar_id":"","url":"https://api.github.com/users/therealshabi","html_url":"https://github.com/therealshabi","followers_url":"https://api.github.com/users/therealshabi/followers","following_url":"https://api.github.com/users/therealshabi/following{/other_user}","gists_url":"https://api.github.com/users/therealshabi/gists{/gist_id}","starred_url":"https://api.github.com/users/therealshabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealshabi/subscriptions","organizations_url":"https://api.github.com/users/therealshabi/orgs","repos_url":"https://api.github.com/users/therealshabi/repos","events_url":"https://api.github.com/users/therealshabi/events{/privacy}","received_events_url":"https://api.github.com/users/therealshabi/received_events","type":"User","site_admin":false},"repo":{"id":96860380,"name":"argus-android","full_name":"therealshabi/argus-android","owner":{"login":"therealshabi","id":15019528,"avatar_url":"https://avatars3.githubusercontent.com/u/15019528?v=3","gravatar_id":"","url":"https://api.github.com/users/therealshabi","html_url":"https://github.com/therealshabi","followers_url":"https://api.github.com/users/therealshabi/followers","following_url":"https://api.github.com/users/therealshabi/following{/other_user}","gists_url":"https://api.github.com/users/therealshabi/gists{/gist_id}","starred_url":"https://api.github.com/users/therealshabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealshabi/subscriptions","organizations_url":"https://api.github.com/users/therealshabi/orgs","repos_url":"https://api.github.com/users/therealshabi/repos","events_url":"https://api.github.com/users/therealshabi/events{/privacy}","received_events_url":"https://api.github.com/users/therealshabi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/therealshabi/argus-android","description":"Login/Registration Module for Android","fork":true,"url":"https://api.github.com/repos/therealshabi/argus-android","forks_url":"https://api.github.com/repos/therealshabi/argus-android/forks","keys_url":"https://api.github.com/repos/therealshabi/argus-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/therealshabi/argus-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/therealshabi/argus-android/teams","hooks_url":"https://api.github.com/repos/therealshabi/argus-android/hooks","issue_events_url":"https://api.github.com/repos/therealshabi/argus-android/issues/events{/number}","events_url":"https://api.github.com/repos/therealshabi/argus-android/events","assignees_url":"https://api.github.com/repos/therealshabi/argus-android/assignees{/user}","branches_url":"https://api.github.com/repos/therealshabi/argus-android/branches{/branch}","tags_url":"https://api.github.com/repos/therealshabi/argus-android/tags","blobs_url":"https://api.github.com/repos/therealshabi/argus-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/therealshabi/argus-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/therealshabi/argus-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/therealshabi/argus-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/therealshabi/argus-android/statuses/{sha}","languages_url":"https://api.github.com/repos/therealshabi/argus-android/languages","stargazers_url":"https://api.github.com/repos/therealshabi/argus-android/stargazers","contributors_url":"https://api.github.com/repos/therealshabi/argus-android/contributors","subscribers_url":"https://api.github.com/repos/therealshabi/argus-android/subscribers","subscription_url":"https://api.github.com/repos/therealshabi/argus-android/subscription","commits_url":"https://api.github.com/repos/therealshabi/argus-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/therealshabi/argus-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/therealshabi/argus-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/therealshabi/argus-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/therealshabi/argus-android/contents/{+path}","compare_url":"https://api.github.com/repos/therealshabi/argus-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/therealshabi/argus-android/merges","archive_url":"https://api.github.com/repos/therealshabi/argus-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/therealshabi/argus-android/downloads","issues_url":"https://api.github.com/repos/therealshabi/argus-android/issues{/number}","pulls_url":"https://api.github.com/repos/therealshabi/argus-android/pulls{/number}","milestones_url":"https://api.github.com/repos/therealshabi/argus-android/milestones{/number}","notifications_url":"https://api.github.com/repos/therealshabi/argus-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/therealshabi/argus-android/labels{/name}","releases_url":"https://api.github.com/repos/therealshabi/argus-android/releases{/id}","deployments_url":"https://api.github.com/repos/therealshabi/argus-android/deployments","created_at":"2017-07-11T06:46:52Z","updated_at":"2017-07-11T06:46:54Z","pushed_at":"2017-07-11T06:54:34Z","git_url":"git://github.com/therealshabi/argus-android.git","ssh_url":"[email protected]:therealshabi/argus-android.git","clone_url":"https://github.com/therealshabi/argus-android.git","svn_url":"https://github.com/therealshabi/argus-android","homepage":"","size":4130,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moldedbits:master","ref":"master","sha":"c9ab8df5d2c923ce91fef93da90253167d6aa7fd","user":{"login":"moldedbits","id":1472463,"avatar_url":"https://avatars0.githubusercontent.com/u/1472463?v=3","gravatar_id":"","url":"https://api.github.com/users/moldedbits","html_url":"https://github.com/moldedbits","followers_url":"https://api.github.com/users/moldedbits/followers","following_url":"https://api.github.com/users/moldedbits/following{/other_user}","gists_url":"https://api.github.com/users/moldedbits/gists{/gist_id}","starred_url":"https://api.github.com/users/moldedbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moldedbits/subscriptions","organizations_url":"https://api.github.com/users/moldedbits/orgs","repos_url":"https://api.github.com/users/moldedbits/repos","events_url":"https://api.github.com/users/moldedbits/events{/privacy}","received_events_url":"https://api.github.com/users/moldedbits/received_events","type":"Organization","site_admin":false},"repo":{"id":89474356,"name":"argus-android","full_name":"moldedbits/argus-android","owner":{"login":"moldedbits","id":1472463,"avatar_url":"https://avatars0.githubusercontent.com/u/1472463?v=3","gravatar_id":"","url":"https://api.github.com/users/moldedbits","html_url":"https://github.com/moldedbits","followers_url":"https://api.github.com/users/moldedbits/followers","following_url":"https://api.github.com/users/moldedbits/following{/other_user}","gists_url":"https://api.github.com/users/moldedbits/gists{/gist_id}","starred_url":"https://api.github.com/users/moldedbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moldedbits/subscriptions","organizations_url":"https://api.github.com/users/moldedbits/orgs","repos_url":"https://api.github.com/users/moldedbits/repos","events_url":"https://api.github.com/users/moldedbits/events{/privacy}","received_events_url":"https://api.github.com/users/moldedbits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moldedbits/argus-android","description":"Login/Registration Module for Android","fork":false,"url":"https://api.github.com/repos/moldedbits/argus-android","forks_url":"https://api.github.com/repos/moldedbits/argus-android/forks","keys_url":"https://api.github.com/repos/moldedbits/argus-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moldedbits/argus-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moldedbits/argus-android/teams","hooks_url":"https://api.github.com/repos/moldedbits/argus-android/hooks","issue_events_url":"https://api.github.com/repos/moldedbits/argus-android/issues/events{/number}","events_url":"https://api.github.com/repos/moldedbits/argus-android/events","assignees_url":"https://api.github.com/repos/moldedbits/argus-android/assignees{/user}","branches_url":"https://api.github.com/repos/moldedbits/argus-android/branches{/branch}","tags_url":"https://api.github.com/repos/moldedbits/argus-android/tags","blobs_url":"https://api.github.com/repos/moldedbits/argus-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moldedbits/argus-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moldedbits/argus-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/moldedbits/argus-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moldedbits/argus-android/statuses/{sha}","languages_url":"https://api.github.com/repos/moldedbits/argus-android/languages","stargazers_url":"https://api.github.com/repos/moldedbits/argus-android/stargazers","contributors_url":"https://api.github.com/repos/moldedbits/argus-android/contributors","subscribers_url":"https://api.github.com/repos/moldedbits/argus-android/subscribers","subscription_url":"https://api.github.com/repos/moldedbits/argus-android/subscription","commits_url":"https://api.github.com/repos/moldedbits/argus-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/moldedbits/argus-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/moldedbits/argus-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/moldedbits/argus-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/moldedbits/argus-android/contents/{+path}","compare_url":"https://api.github.com/repos/moldedbits/argus-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moldedbits/argus-android/merges","archive_url":"https://api.github.com/repos/moldedbits/argus-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moldedbits/argus-android/downloads","issues_url":"https://api.github.com/repos/moldedbits/argus-android/issues{/number}","pulls_url":"https://api.github.com/repos/moldedbits/argus-android/pulls{/number}","milestones_url":"https://api.github.com/repos/moldedbits/argus-android/milestones{/number}","notifications_url":"https://api.github.com/repos/moldedbits/argus-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moldedbits/argus-android/labels{/name}","releases_url":"https://api.github.com/repos/moldedbits/argus-android/releases{/id}","deployments_url":"https://api.github.com/repos/moldedbits/argus-android/deployments","created_at":"2017-04-26T11:41:48Z","updated_at":"2017-06-26T12:12:04Z","pushed_at":"2017-07-11T06:55:47Z","git_url":"git://github.com/moldedbits/argus-android.git","ssh_url":"[email protected]:moldedbits/argus-android.git","clone_url":"https://github.com/moldedbits/argus-android.git","svn_url":"https://github.com/moldedbits/argus-android","homepage":"","size":4130,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moldedbits/argus-android/pulls/31"},"html":{"href":"https://github.com/moldedbits/argus-android/pull/31"},"issue":{"href":"https://api.github.com/repos/moldedbits/argus-android/issues/31"},"comments":{"href":"https://api.github.com/repos/moldedbits/argus-android/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/moldedbits/argus-android/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/moldedbits/argus-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moldedbits/argus-android/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/moldedbits/argus-android/statuses/1bb447efa733fbe7bc238b02645fb61fbb8f986c"}}}} | {
"id": 89474356,
"name": "moldedbits/argus-android",
"url": "https://api.github.com/repos/moldedbits/argus-android"
} | {
"id": 1011854,
"login": "anujmiddha",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1011854?",
"url": "https://api.github.com/users/anujmiddha"
} | {
"id": 1472463,
"login": "moldedbits",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1472463?",
"url": "https://api.github.com/orgs/moldedbits"
} | 2017-07-11T07:20:53 | 6230219362 | {"actor":{"display_login":"anujmiddha"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/comments/114621530","pull_request_review_id":36103686,"id":114621530,"diff_hunk":"@@ -0,0 +1,143 @@\n+/**\n+ * Copyright 2016-2017 The OpenZipkin Authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package zipkin.collector.kinesis;\n+\n+import com.amazonaws.auth.AWSCredentialsProvider;\n+import com.amazonaws.auth.DefaultAWSCredentialsProviderChain;\n+import com.amazonaws.services.kinesis.clientlibrary.interfaces.v2.IRecordProcessorFactory;\n+import com.amazonaws.services.kinesis.clientlibrary.lib.worker.KinesisClientLibConfiguration;\n+import com.amazonaws.services.kinesis.clientlibrary.lib.worker.Worker;\n+import zipkin.collector.Collector;\n+import zipkin.collector.CollectorComponent;\n+import zipkin.collector.CollectorMetrics;\n+import zipkin.collector.CollectorSampler;\n+import zipkin.internal.Util;\n+import zipkin.storage.StorageComponent;\n+\n+import java.io.Closeable;\n+import java.io.IOException;\n+import java.net.InetAddress;\n+import java.net.UnknownHostException;\n+import java.util.UUID;\n+import java.util.concurrent.Executor;\n+import java.util.concurrent.Executors;\n+\n+public final class KinesisCollector implements CollectorComponent, Closeable {\n+\n+ public static Builder builder() {\n+ return new Builder();\n+ }\n+\n+ public static final class Builder implements CollectorComponent.Builder {\n+\n+ Collector.Builder delegate = Collector.builder(KinesisCollector.class);\n+\n+ AWSCredentialsProvider credentialsProvider;\n+ String appName;\n+ String streamName;\n+ Executor executor = Executors.newSingleThreadExecutor();","path":"collector-kinesis/src/main/java/zipkin/collector/kinesis/KinesisCollector.java","position":49,"original_position":49,"commit_id":"7281fc0e85eeff0917ad250b2a54eec7b726cfe0","original_commit_id":"7281fc0e85eeff0917ad250b2a54eec7b726cfe0","user":{"login":"devinsba","id":139938,"avatar_url":"https://avatars0.githubusercontent.com/u/139938?v=3","gravatar_id":"","url":"https://api.github.com/users/devinsba","html_url":"https://github.com/devinsba","followers_url":"https://api.github.com/users/devinsba/followers","following_url":"https://api.github.com/users/devinsba/following{/other_user}","gists_url":"https://api.github.com/users/devinsba/gists{/gist_id}","starred_url":"https://api.github.com/users/devinsba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinsba/subscriptions","organizations_url":"https://api.github.com/users/devinsba/orgs","repos_url":"https://api.github.com/users/devinsba/repos","events_url":"https://api.github.com/users/devinsba/events{/privacy}","received_events_url":"https://api.github.com/users/devinsba/received_events","type":"User","site_admin":false},"body":"The sqs-collector allows a `parallelism` configuration instead of being able to configure the executor directly. I'm not sure which is better. I guess the other approach more cleanly matches to a property, but that can be handled in the autoconfigure module instead of here","created_at":"2017-05-03T18:38:40Z","updated_at":"2017-05-03T18:38:41Z","html_url":"https://github.com/openzipkin/zipkin-aws/pull/33#discussion_r114621530","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/comments/114621530"},"html":{"href":"https://github.com/openzipkin/zipkin-aws/pull/33#discussion_r114621530"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/33","id":106907401,"html_url":"https://github.com/openzipkin/zipkin-aws/pull/33","diff_url":"https://github.com/openzipkin/zipkin-aws/pull/33.diff","patch_url":"https://github.com/openzipkin/zipkin-aws/pull/33.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-aws/issues/33","number":33,"state":"open","locked":false,"title":"WIP: Kinesis Collector","user":{"login":"devinsba","id":139938,"avatar_url":"https://avatars0.githubusercontent.com/u/139938?v=3","gravatar_id":"","url":"https://api.github.com/users/devinsba","html_url":"https://github.com/devinsba","followers_url":"https://api.github.com/users/devinsba/followers","following_url":"https://api.github.com/users/devinsba/following{/other_user}","gists_url":"https://api.github.com/users/devinsba/gists{/gist_id}","starred_url":"https://api.github.com/users/devinsba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinsba/subscriptions","organizations_url":"https://api.github.com/users/devinsba/orgs","repos_url":"https://api.github.com/users/devinsba/repos","events_url":"https://api.github.com/users/devinsba/events{/privacy}","received_events_url":"https://api.github.com/users/devinsba/received_events","type":"User","site_admin":false},"body":"This is a WIP kinesis collector.\r\n\r\nSo far it uses the KCL client instead of the plain API client. Not sure if that should be configurable. This one is supposedly more performant so thats why I wanted try using this one.","created_at":"2017-02-19T16:45:22Z","updated_at":"2017-05-03T18:38:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a265095a0168ed77d82213488ead1020fedf4bde","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/33/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/33/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-aws/issues/33/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-aws/statuses/7281fc0e85eeff0917ad250b2a54eec7b726cfe0","head":{"label":"DealerDotCom:kinesis-collector","ref":"kinesis-collector","sha":"7281fc0e85eeff0917ad250b2a54eec7b726cfe0","user":{"login":"DealerDotCom","id":1919423,"avatar_url":"https://avatars2.githubusercontent.com/u/1919423?v=3","gravatar_id":"","url":"https://api.github.com/users/DealerDotCom","html_url":"https://github.com/DealerDotCom","followers_url":"https://api.github.com/users/DealerDotCom/followers","following_url":"https://api.github.com/users/DealerDotCom/following{/other_user}","gists_url":"https://api.github.com/users/DealerDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/DealerDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DealerDotCom/subscriptions","organizations_url":"https://api.github.com/users/DealerDotCom/orgs","repos_url":"https://api.github.com/users/DealerDotCom/repos","events_url":"https://api.github.com/users/DealerDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/DealerDotCom/received_events","type":"Organization","site_admin":false},"repo":{"id":69571818,"name":"zipkin-aws","full_name":"DealerDotCom/zipkin-aws","owner":{"login":"DealerDotCom","id":1919423,"avatar_url":"https://avatars2.githubusercontent.com/u/1919423?v=3","gravatar_id":"","url":"https://api.github.com/users/DealerDotCom","html_url":"https://github.com/DealerDotCom","followers_url":"https://api.github.com/users/DealerDotCom/followers","following_url":"https://api.github.com/users/DealerDotCom/following{/other_user}","gists_url":"https://api.github.com/users/DealerDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/DealerDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DealerDotCom/subscriptions","organizations_url":"https://api.github.com/users/DealerDotCom/orgs","repos_url":"https://api.github.com/users/DealerDotCom/repos","events_url":"https://api.github.com/users/DealerDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/DealerDotCom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DealerDotCom/zipkin-aws","description":"Reporters and collectors for use in Amazon's cloud","fork":true,"url":"https://api.github.com/repos/DealerDotCom/zipkin-aws","forks_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/forks","keys_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/teams","hooks_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/hooks","issue_events_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/issues/events{/number}","events_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/events","assignees_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/assignees{/user}","branches_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/branches{/branch}","tags_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/tags","blobs_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/languages","stargazers_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/stargazers","contributors_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/contributors","subscribers_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/subscribers","subscription_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/subscription","commits_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/contents/{+path}","compare_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/merges","archive_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/downloads","issues_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/issues{/number}","pulls_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/labels{/name}","releases_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/releases{/id}","deployments_url":"https://api.github.com/repos/DealerDotCom/zipkin-aws/deployments","created_at":"2016-09-29T13:47:43Z","updated_at":"2017-03-09T11:17:01Z","pushed_at":"2017-05-03T18:35:46Z","git_url":"git://github.com/DealerDotCom/zipkin-aws.git","ssh_url":"[email protected]:DealerDotCom/zipkin-aws.git","clone_url":"https://github.com/DealerDotCom/zipkin-aws.git","svn_url":"https://github.com/DealerDotCom/zipkin-aws","homepage":null,"size":183,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"71a670046c4b626922c28d6cb196255f19293799","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars0.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":69571507,"name":"zipkin-aws","full_name":"openzipkin/zipkin-aws","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars0.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-aws","description":"Reporters and collectors for use in Amazon's cloud","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-aws","forks_url":"https://api.github.com/repos/openzipkin/zipkin-aws/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-aws/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-aws/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-aws/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-aws/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-aws/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-aws/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-aws/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-aws/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-aws/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-aws/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-aws/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-aws/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-aws/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-aws/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-aws/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-aws/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-aws/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-aws/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-aws/deployments","created_at":"2016-09-29T13:44:26Z","updated_at":"2017-03-18T15:08:03Z","pushed_at":"2017-05-03T18:35:47Z","git_url":"git://github.com/openzipkin/zipkin-aws.git","ssh_url":"[email protected]:openzipkin/zipkin-aws.git","clone_url":"https://github.com/openzipkin/zipkin-aws.git","svn_url":"https://github.com/openzipkin/zipkin-aws","homepage":null,"size":186,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/33"},"html":{"href":"https://github.com/openzipkin/zipkin-aws/pull/33"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/issues/33"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-aws/statuses/7281fc0e85eeff0917ad250b2a54eec7b726cfe0"}}}} | {
"id": 69571507,
"name": "openzipkin/zipkin-aws",
"url": "https://api.github.com/repos/openzipkin/zipkin-aws"
} | {
"id": 139938,
"login": "devinsba",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139938?",
"url": "https://api.github.com/users/devinsba"
} | {
"id": 11860887,
"login": "openzipkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11860887?",
"url": "https://api.github.com/orgs/openzipkin"
} | 2017-05-03T18:38:40 | 5803961637 | {"actor":{"display_login":"devinsba"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/97560954","pull_request_review_id":18172856,"id":97560954,"diff_hunk":"@@ -771,6 +770,26 @@ def test_resample_empty_dataframe(self):\n \n # test size for GH13212 (currently stays as df)\n \n+ def test_resample_size_empty_dataframe(self):\n+ # GH14962\n+ index = self.create_series().index[:0]\n+ f = DataFrame(index=index)\n+\n+ for freq in ['M', 'D', 'H']:\n+ result = f.resample(freq).size()\n+\n+ if isinstance(result.index, PeriodIndex) and freq == 'H':","path":"pandas/tseries/tests/test_resample.py","position":20,"original_position":20,"commit_id":"427234faf8371a1238bee6c6db6f5e7acc415234","original_commit_id":"427234faf8371a1238bee6c6db6f5e7acc415234","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"why is this any different?","created_at":"2017-01-24T14:45:06Z","updated_at":"2017-01-24T14:45:15Z","html_url":"https://github.com/pandas-dev/pandas/pull/15093#discussion_r97560954","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/97560954"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/15093#discussion_r97560954"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093","id":100768917,"html_url":"https://github.com/pandas-dev/pandas/pull/15093","diff_url":"https://github.com/pandas-dev/pandas/pull/15093.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/15093.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/15093","number":15093,"state":"open","locked":false,"title":"BUG: Inconsistent return type for downsampling on resample of empty DataFrame","user":{"login":"discort","id":4944021,"avatar_url":"https://avatars.githubusercontent.com/u/4944021?v=3","gravatar_id":"","url":"https://api.github.com/users/discort","html_url":"https://github.com/discort","followers_url":"https://api.github.com/users/discort/followers","following_url":"https://api.github.com/users/discort/following{/other_user}","gists_url":"https://api.github.com/users/discort/gists{/gist_id}","starred_url":"https://api.github.com/users/discort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discort/subscriptions","organizations_url":"https://api.github.com/users/discort/orgs","repos_url":"https://api.github.com/users/discort/repos","events_url":"https://api.github.com/users/discort/events{/privacy}","received_events_url":"https://api.github.com/users/discort/received_events","type":"User","site_admin":false},"body":" - [x] closes #14962\r\n - [x] tests added / passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n - [x] whatsnew entry\r\n","created_at":"2017-01-09T21:58:41Z","updated_at":"2017-01-24T14:45:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c26f442d02bc98560804c58b7ecc2f9bf963048","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/15093/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/427234faf8371a1238bee6c6db6f5e7acc415234","head":{"label":"discort:fix_14962_bug","ref":"fix_14962_bug","sha":"427234faf8371a1238bee6c6db6f5e7acc415234","user":{"login":"discort","id":4944021,"avatar_url":"https://avatars.githubusercontent.com/u/4944021?v=3","gravatar_id":"","url":"https://api.github.com/users/discort","html_url":"https://github.com/discort","followers_url":"https://api.github.com/users/discort/followers","following_url":"https://api.github.com/users/discort/following{/other_user}","gists_url":"https://api.github.com/users/discort/gists{/gist_id}","starred_url":"https://api.github.com/users/discort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discort/subscriptions","organizations_url":"https://api.github.com/users/discort/orgs","repos_url":"https://api.github.com/users/discort/repos","events_url":"https://api.github.com/users/discort/events{/privacy}","received_events_url":"https://api.github.com/users/discort/received_events","type":"User","site_admin":false},"repo":{"id":74369521,"name":"pandas","full_name":"discort/pandas","owner":{"login":"discort","id":4944021,"avatar_url":"https://avatars.githubusercontent.com/u/4944021?v=3","gravatar_id":"","url":"https://api.github.com/users/discort","html_url":"https://github.com/discort","followers_url":"https://api.github.com/users/discort/followers","following_url":"https://api.github.com/users/discort/following{/other_user}","gists_url":"https://api.github.com/users/discort/gists{/gist_id}","starred_url":"https://api.github.com/users/discort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discort/subscriptions","organizations_url":"https://api.github.com/users/discort/orgs","repos_url":"https://api.github.com/users/discort/repos","events_url":"https://api.github.com/users/discort/events{/privacy}","received_events_url":"https://api.github.com/users/discort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/discort/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/discort/pandas","forks_url":"https://api.github.com/repos/discort/pandas/forks","keys_url":"https://api.github.com/repos/discort/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discort/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discort/pandas/teams","hooks_url":"https://api.github.com/repos/discort/pandas/hooks","issue_events_url":"https://api.github.com/repos/discort/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/discort/pandas/events","assignees_url":"https://api.github.com/repos/discort/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/discort/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/discort/pandas/tags","blobs_url":"https://api.github.com/repos/discort/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discort/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discort/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/discort/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discort/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/discort/pandas/languages","stargazers_url":"https://api.github.com/repos/discort/pandas/stargazers","contributors_url":"https://api.github.com/repos/discort/pandas/contributors","subscribers_url":"https://api.github.com/repos/discort/pandas/subscribers","subscription_url":"https://api.github.com/repos/discort/pandas/subscription","commits_url":"https://api.github.com/repos/discort/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/discort/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/discort/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/discort/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/discort/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/discort/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discort/pandas/merges","archive_url":"https://api.github.com/repos/discort/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discort/pandas/downloads","issues_url":"https://api.github.com/repos/discort/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/discort/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/discort/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/discort/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discort/pandas/labels{/name}","releases_url":"https://api.github.com/repos/discort/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/discort/pandas/deployments","created_at":"2016-11-21T14:05:11Z","updated_at":"2016-11-21T14:05:18Z","pushed_at":"2017-01-23T19:54:56Z","git_url":"git://github.com/discort/pandas.git","ssh_url":"[email protected]:discort/pandas.git","clone_url":"https://github.com/discort/pandas.git","svn_url":"https://github.com/discort/pandas","homepage":"http://pandas.pydata.org","size":87265,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"be3f2aea4a8ad3f6bf4eb84e6ca3269abff5fcfb","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars.githubusercontent.com/u/21206976?v=3","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars.githubusercontent.com/u/21206976?v=3","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-01-24T13:58:00Z","pushed_at":"2017-01-24T14:41:38Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"[email protected]:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":87569,"stargazers_count":8291,"watchers_count":8291,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3332,"mirror_url":null,"open_issues_count":1850,"forks":3332,"open_issues":1850,"watchers":8291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/15093"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/15093"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/15093/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/427234faf8371a1238bee6c6db6f5e7acc415234"}}}} | {
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
} | {
"id": 953992,
"login": "jreback",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/953992?",
"url": "https://api.github.com/users/jreback"
} | {
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
} | 2017-01-24T14:45:06 | 5204097288 | {"actor":{"display_login":"jreback"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/142007930","pull_request_review_id":66315101,"id":142007930,"diff_hunk":"@@ -1982,33 +1982,41 @@ def _partial_tup_index(self, tup, side='left'):\n \n def get_loc(self, key, method=None):\n \"\"\"\n- Get integer location, slice or boolean mask for requested label or\n- tuple. If the key is past the lexsort depth, the return may be a\n- boolean mask array, otherwise it is always a slice or int.\n+ Get location for a label or a tuple of labels as an integer, slice or\n+ boolean mask.\n \n Parameters\n ----------\n- key : label or tuple\n+ key : label or tuple of labels (one for each level)\n method : None\n \n Returns\n -------\n loc : int, slice object or boolean mask\n+ If the key is past the lexsort depth, the return may be a\n+ boolean mask array, otherwise it is always a slice or int.\n \n Examples\n ---------\n >>> mi = pd.MultiIndex.from_arrays([list('abb'), list('def')])\n+\n >>> mi.get_loc('b')\n slice(1, 3, None)\n+\n >>> mi.get_loc(('b', 'e'))\n 1\n \n+ Notes\n+ ------\n+ The key cannot be a slice, list of same-level labels, a boolean mask,\n+ or a sequence of such. If you want to use those, use :meth:`get_locs`","path":"pandas/core/indexes/multi.py","position":null,"original_position":46,"commit_id":"070e8f34b483fb92f6d2e64d6755a5c86860a62e","original_commit_id":"1b0ab8828d5d0bd4faeb6aab42e0c867737caec8","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"you pass the arg —\u0000single api ","created_at":"2017-09-30T15:03:19Z","updated_at":"2017-09-30T15:03:19Z","html_url":"https://github.com/pandas-dev/pandas/pull/17675#discussion_r142007930","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17675","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/142007930"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/17675#discussion_r142007930"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17675"}},"in_reply_to_id":142003870},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17675","id":142999940,"html_url":"https://github.com/pandas-dev/pandas/pull/17675","diff_url":"https://github.com/pandas-dev/pandas/pull/17675.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/17675.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17675","number":17675,"state":"open","locked":false,"title":"DOC: Add examples for MultiIndex.get_locs + cleanups","user":{"login":"topper-123","id":26364415,"avatar_url":"https://avatars1.githubusercontent.com/u/26364415?v=4","gravatar_id":"","url":"https://api.github.com/users/topper-123","html_url":"https://github.com/topper-123","followers_url":"https://api.github.com/users/topper-123/followers","following_url":"https://api.github.com/users/topper-123/following{/other_user}","gists_url":"https://api.github.com/users/topper-123/gists{/gist_id}","starred_url":"https://api.github.com/users/topper-123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topper-123/subscriptions","organizations_url":"https://api.github.com/users/topper-123/orgs","repos_url":"https://api.github.com/users/topper-123/repos","events_url":"https://api.github.com/users/topper-123/events{/privacy}","received_events_url":"https://api.github.com/users/topper-123/received_events","type":"User","site_admin":false},"body":"- [x ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n\r\nAdds examples to ``MultiIndex.get_locs`` and also some changes to ``.get_loc`` and ``.get_loc_values``.","created_at":"2017-09-25T22:33:48Z","updated_at":"2017-09-30T15:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69f9e8a22997e589c3e05fa3836d91464964dc05","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17675/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17675/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17675/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/070e8f34b483fb92f6d2e64d6755a5c86860a62e","head":{"label":"topper-123:multiindex.get_locs","ref":"multiindex.get_locs","sha":"070e8f34b483fb92f6d2e64d6755a5c86860a62e","user":{"login":"topper-123","id":26364415,"avatar_url":"https://avatars1.githubusercontent.com/u/26364415?v=4","gravatar_id":"","url":"https://api.github.com/users/topper-123","html_url":"https://github.com/topper-123","followers_url":"https://api.github.com/users/topper-123/followers","following_url":"https://api.github.com/users/topper-123/following{/other_user}","gists_url":"https://api.github.com/users/topper-123/gists{/gist_id}","starred_url":"https://api.github.com/users/topper-123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topper-123/subscriptions","organizations_url":"https://api.github.com/users/topper-123/orgs","repos_url":"https://api.github.com/users/topper-123/repos","events_url":"https://api.github.com/users/topper-123/events{/privacy}","received_events_url":"https://api.github.com/users/topper-123/received_events","type":"User","site_admin":false},"repo":{"id":96933596,"name":"pandas","full_name":"topper-123/pandas","owner":{"login":"topper-123","id":26364415,"avatar_url":"https://avatars1.githubusercontent.com/u/26364415?v=4","gravatar_id":"","url":"https://api.github.com/users/topper-123","html_url":"https://github.com/topper-123","followers_url":"https://api.github.com/users/topper-123/followers","following_url":"https://api.github.com/users/topper-123/following{/other_user}","gists_url":"https://api.github.com/users/topper-123/gists{/gist_id}","starred_url":"https://api.github.com/users/topper-123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topper-123/subscriptions","organizations_url":"https://api.github.com/users/topper-123/orgs","repos_url":"https://api.github.com/users/topper-123/repos","events_url":"https://api.github.com/users/topper-123/events{/privacy}","received_events_url":"https://api.github.com/users/topper-123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/topper-123/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/topper-123/pandas","forks_url":"https://api.github.com/repos/topper-123/pandas/forks","keys_url":"https://api.github.com/repos/topper-123/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topper-123/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topper-123/pandas/teams","hooks_url":"https://api.github.com/repos/topper-123/pandas/hooks","issue_events_url":"https://api.github.com/repos/topper-123/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/topper-123/pandas/events","assignees_url":"https://api.github.com/repos/topper-123/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/topper-123/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/topper-123/pandas/tags","blobs_url":"https://api.github.com/repos/topper-123/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topper-123/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topper-123/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/topper-123/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topper-123/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/topper-123/pandas/languages","stargazers_url":"https://api.github.com/repos/topper-123/pandas/stargazers","contributors_url":"https://api.github.com/repos/topper-123/pandas/contributors","subscribers_url":"https://api.github.com/repos/topper-123/pandas/subscribers","subscription_url":"https://api.github.com/repos/topper-123/pandas/subscription","commits_url":"https://api.github.com/repos/topper-123/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/topper-123/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/topper-123/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/topper-123/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/topper-123/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/topper-123/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topper-123/pandas/merges","archive_url":"https://api.github.com/repos/topper-123/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topper-123/pandas/downloads","issues_url":"https://api.github.com/repos/topper-123/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/topper-123/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/topper-123/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/topper-123/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topper-123/pandas/labels{/name}","releases_url":"https://api.github.com/repos/topper-123/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/topper-123/pandas/deployments","created_at":"2017-07-11T20:17:08Z","updated_at":"2017-07-11T20:17:15Z","pushed_at":"2017-09-30T14:56:57Z","git_url":"git://github.com/topper-123/pandas.git","ssh_url":"[email protected]:topper-123/pandas.git","clone_url":"https://github.com/topper-123/pandas.git","svn_url":"https://github.com/topper-123/pandas","homepage":"http://pandas.pydata.org","size":105191,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"e2a0251d32a1467e9ab86281a31f57aca582a88f","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-09-30T13:24:03Z","pushed_at":"2017-09-30T14:57:05Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"[email protected]:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":105342,"stargazers_count":11009,"watchers_count":11009,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4364,"mirror_url":null,"open_issues_count":2137,"forks":4364,"open_issues":2137,"watchers":11009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17675"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/17675"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/17675"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/17675/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17675/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17675/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/070e8f34b483fb92f6d2e64d6755a5c86860a62e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
} | {
"id": 953992,
"login": "jreback",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/953992?",
"url": "https://api.github.com/users/jreback"
} | {
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
} | 2017-09-30T15:03:19 | 6658095932 | {"actor":{"display_login":"jreback"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/110336072","pull_request_review_id":31499668,"id":110336072,"diff_hunk":"@@ -929,6 +934,47 @@ method:\n minor_axis=['a', 'b', 'c', 'd'])\n panel.to_frame()","path":"doc/source/dsintro.rst","position":14,"original_position":14,"commit_id":"b6fe33b1126de189ef8f00fc3ee2c531c6aa7825","original_commit_id":"b6fe33b1126de189ef8f00fc3ee2c531c6aa7825","user":{"login":"jorisvandenbossche","id":1020496,"avatar_url":"https://avatars1.githubusercontent.com/u/1020496?v=3","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"All those example above will need a `:okwarning:`","created_at":"2017-04-07T08:00:14Z","updated_at":"2017-04-07T08:43:11Z","html_url":"https://github.com/pandas-dev/pandas/pull/15601#discussion_r110336072","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15601","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/110336072"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/15601#discussion_r110336072"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15601"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15601","id":109517138,"html_url":"https://github.com/pandas-dev/pandas/pull/15601","diff_url":"https://github.com/pandas-dev/pandas/pull/15601.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/15601.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/15601","number":15601,"state":"open","locked":false,"title":"DEPR: Panel deprecated","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars1.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"closes #13563\r\n\r\ngoing to be on top of #15677\r\n \r\nNote this is currently a ``FutureWarning`` mainly to fail the tests if I missed anything. Intention is to change to a ``DeprecationWarning``.","created_at":"2017-03-07T16:27:43Z","updated_at":"2017-04-07T08:43:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e6fe30d97b4335b5e2ff6eb739f0597a1121a02","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/39","html_url":"https://github.com/pandas-dev/pandas/milestone/39","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/39/labels","id":1570595,"number":39,"title":"0.20.0","description":"after 0.19.x series","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars1.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":777,"state":"open","created_at":"2016-02-08T15:30:21Z","updated_at":"2017-04-07T02:55:59Z","due_on":"2017-04-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15601/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15601/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/15601/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/b6fe33b1126de189ef8f00fc3ee2c531c6aa7825","head":{"label":"jreback:panel","ref":"panel","sha":"b6fe33b1126de189ef8f00fc3ee2c531c6aa7825","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars1.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"repo":{"id":2142250,"name":"pandas","full_name":"jreback/pandas","owner":{"login":"jreback","id":953992,"avatar_url":"https://avatars1.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jreback/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jreback/pandas","forks_url":"https://api.github.com/repos/jreback/pandas/forks","keys_url":"https://api.github.com/repos/jreback/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jreback/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jreback/pandas/teams","hooks_url":"https://api.github.com/repos/jreback/pandas/hooks","issue_events_url":"https://api.github.com/repos/jreback/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jreback/pandas/events","assignees_url":"https://api.github.com/repos/jreback/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jreback/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jreback/pandas/tags","blobs_url":"https://api.github.com/repos/jreback/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jreback/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jreback/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jreback/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jreback/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jreback/pandas/languages","stargazers_url":"https://api.github.com/repos/jreback/pandas/stargazers","contributors_url":"https://api.github.com/repos/jreback/pandas/contributors","subscribers_url":"https://api.github.com/repos/jreback/pandas/subscribers","subscription_url":"https://api.github.com/repos/jreback/pandas/subscription","commits_url":"https://api.github.com/repos/jreback/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jreback/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jreback/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jreback/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jreback/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jreback/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jreback/pandas/merges","archive_url":"https://api.github.com/repos/jreback/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jreback/pandas/downloads","issues_url":"https://api.github.com/repos/jreback/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jreback/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jreback/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jreback/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jreback/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jreback/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jreback/pandas/deployments","created_at":"2011-08-02T12:17:07Z","updated_at":"2017-02-13T06:30:07Z","pushed_at":"2017-04-07T02:55:34Z","git_url":"git://github.com/jreback/pandas.git","ssh_url":"[email protected]:jreback/pandas.git","clone_url":"https://github.com/jreback/pandas.git","svn_url":"https://github.com/jreback/pandas","homepage":"http://pandas.sourceforge.net","size":93426,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":9,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"0cfc08cf4584e8442c84c30d53f1dceafeac5abf","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars1.githubusercontent.com/u/21206976?v=3","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars1.githubusercontent.com/u/21206976?v=3","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-04-07T04:34:42Z","pushed_at":"2017-04-07T08:41:24Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"[email protected]:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":91929,"stargazers_count":9161,"watchers_count":9161,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3650,"mirror_url":null,"open_issues_count":1918,"forks":3650,"open_issues":1918,"watchers":9161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15601"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/15601"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/15601"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/15601/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15601/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15601/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/b6fe33b1126de189ef8f00fc3ee2c531c6aa7825"}}}} | {
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
} | {
"id": 1020496,
"login": "jorisvandenbossche",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1020496?",
"url": "https://api.github.com/users/jorisvandenbossche"
} | {
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
} | 2017-04-07T08:00:14 | 5645296743 | {"actor":{"display_login":"jorisvandenbossche"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/142633890","pull_request_review_id":67020007,"id":142633890,"diff_hunk":"@@ -226,7 +231,7 @@ def read_excel(io, sheet_name=0, header=0, skiprows=None, skip_footer=0,\n \n return io._parse_excel(\n sheetname=sheet_name, header=header, skiprows=skiprows, names=names,\n- index_col=index_col, parse_cols=parse_cols, parse_dates=parse_dates,","path":"pandas/io/excel.py","position":35,"original_position":35,"commit_id":"517b72611099577eaf9aa99310864b6e65017008","original_commit_id":"517b72611099577eaf9aa99310864b6e65017008","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars0.githubusercontent.com/u/9273653?v=4","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"body":"Ah, good point. Will do.","created_at":"2017-10-04T10:24:12Z","updated_at":"2017-10-04T10:24:12Z","html_url":"https://github.com/pandas-dev/pandas/pull/17774#discussion_r142633890","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17774","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/142633890"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/17774#discussion_r142633890"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17774"}},"in_reply_to_id":142632680},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17774","id":144591182,"html_url":"https://github.com/pandas-dev/pandas/pull/17774","diff_url":"https://github.com/pandas-dev/pandas/pull/17774.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/17774.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17774","number":17774,"state":"open","locked":false,"title":"DEPR: Deprecate parse_cols in read_excel","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars0.githubusercontent.com/u/9273653?v=4","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"body":"Will now use \"usecols\" just like in read_csv.\r\n\r\nxref #4988.","created_at":"2017-10-04T06:31:07Z","updated_at":"2017-10-04T10:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"393ea68a762d67dc0c815d21551d8289ac8b746b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/46","html_url":"https://github.com/pandas-dev/pandas/milestone/46","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/46/labels","id":2406656,"number":46,"title":"0.21.0","description":"","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":636,"state":"open","created_at":"2017-03-23T13:26:25Z","updated_at":"2017-10-04T10:17:09Z","due_on":"2017-10-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17774/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17774/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17774/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/517b72611099577eaf9aa99310864b6e65017008","head":{"label":"gfyoung:parse-cols-depr-excel","ref":"parse-cols-depr-excel","sha":"517b72611099577eaf9aa99310864b6e65017008","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars0.githubusercontent.com/u/9273653?v=4","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"repo":{"id":51449909,"name":"pandas","full_name":"gfyoung/pandas","owner":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars0.githubusercontent.com/u/9273653?v=4","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfyoung/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/gfyoung/pandas","forks_url":"https://api.github.com/repos/gfyoung/pandas/forks","keys_url":"https://api.github.com/repos/gfyoung/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfyoung/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfyoung/pandas/teams","hooks_url":"https://api.github.com/repos/gfyoung/pandas/hooks","issue_events_url":"https://api.github.com/repos/gfyoung/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/gfyoung/pandas/events","assignees_url":"https://api.github.com/repos/gfyoung/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/gfyoung/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/gfyoung/pandas/tags","blobs_url":"https://api.github.com/repos/gfyoung/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfyoung/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfyoung/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfyoung/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfyoung/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/gfyoung/pandas/languages","stargazers_url":"https://api.github.com/repos/gfyoung/pandas/stargazers","contributors_url":"https://api.github.com/repos/gfyoung/pandas/contributors","subscribers_url":"https://api.github.com/repos/gfyoung/pandas/subscribers","subscription_url":"https://api.github.com/repos/gfyoung/pandas/subscription","commits_url":"https://api.github.com/repos/gfyoung/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfyoung/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfyoung/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfyoung/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfyoung/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/gfyoung/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfyoung/pandas/merges","archive_url":"https://api.github.com/repos/gfyoung/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfyoung/pandas/downloads","issues_url":"https://api.github.com/repos/gfyoung/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/gfyoung/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/gfyoung/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/gfyoung/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfyoung/pandas/labels{/name}","releases_url":"https://api.github.com/repos/gfyoung/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/gfyoung/pandas/deployments","created_at":"2016-02-10T15:31:30Z","updated_at":"2016-02-10T15:31:35Z","pushed_at":"2017-10-04T06:30:21Z","git_url":"git://github.com/gfyoung/pandas.git","ssh_url":"[email protected]:gfyoung/pandas.git","clone_url":"https://github.com/gfyoung/pandas.git","svn_url":"https://github.com/gfyoung/pandas","homepage":"http://pandas.pydata.org","size":104689,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"81694dce171ecd93a65e32ed455612ee967d3951","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-10-04T09:01:09Z","pushed_at":"2017-10-04T10:02:30Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"[email protected]:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":105609,"stargazers_count":11047,"watchers_count":11047,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4381,"mirror_url":null,"open_issues_count":2134,"forks":4381,"open_issues":2134,"watchers":11047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17774"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/17774"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/17774"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/17774/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17774/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17774/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/517b72611099577eaf9aa99310864b6e65017008"}},"author_association":"MEMBER"}} | {
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
} | {
"id": 9273653,
"login": "gfyoung",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9273653?",
"url": "https://api.github.com/users/gfyoung"
} | {
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
} | 2017-10-04T10:24:12 | 6672162471 | {"actor":{"display_login":"gfyoung"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/150366252","pull_request_review_id":75914486,"id":150366252,"diff_hunk":"@@ -437,6 +437,15 @@ def assertPrefixEqual(self, expected, actual_iter):\n \"\"\"\n self.assertEqual(expected, list(itertools.islice(actual_iter, len(expected))))\n \n+ def assertInFile(self, string, file):\n+ \"\"\"Verifies that a string appears in a file\n+\n+ :API: public\n+ \"\"\"\n+\n+ with open(file) as f:\n+ self.assertIn(string, f.read())","path":"tests/python/pants_test/base_test.py","position":11,"original_position":11,"commit_id":"773852840107493af6597bc25465d3f9ca772fa3","original_commit_id":"773852840107493af6597bc25465d3f9ca772fa3","user":{"login":"wisechengyi","id":596358,"avatar_url":"https://avatars0.githubusercontent.com/u/596358?v=4","gravatar_id":"","url":"https://api.github.com/users/wisechengyi","html_url":"https://github.com/wisechengyi","followers_url":"https://api.github.com/users/wisechengyi/followers","following_url":"https://api.github.com/users/wisechengyi/following{/other_user}","gists_url":"https://api.github.com/users/wisechengyi/gists{/gist_id}","starred_url":"https://api.github.com/users/wisechengyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wisechengyi/subscriptions","organizations_url":"https://api.github.com/users/wisechengyi/orgs","repos_url":"https://api.github.com/users/wisechengyi/repos","events_url":"https://api.github.com/users/wisechengyi/events{/privacy}","received_events_url":"https://api.github.com/users/wisechengyi/received_events","type":"User","site_admin":false},"body":"1. `file` is a built-in function in python, so it's good to rename it to something like `file_path` to avoid confusion.\r\n2. Improve error msg \r\n```\r\ncontent = f.read()\r\nself.assertIn(string, content, '\"{}\" is not in the file {}:\\n{}'.format(string, f.name, content)`\r\n","created_at":"2017-11-11T00:39:19Z","updated_at":"2017-11-11T00:55:44Z","html_url":"https://github.com/pantsbuild/pants/pull/5023#discussion_r150366252","pull_request_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5023","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/150366252"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5023#discussion_r150366252"},"pull_request":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5023"}}},"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/5023","id":149008360,"html_url":"https://github.com/pantsbuild/pants/pull/5023","diff_url":"https://github.com/pantsbuild/pants/pull/5023.diff","patch_url":"https://github.com/pantsbuild/pants/pull/5023.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/5023","number":5023,"state":"open","locked":false,"title":"Target Rename with Buildozer ","user":{"login":"15Dkatz","id":11095053,"avatar_url":"https://avatars3.githubusercontent.com/u/11095053?v=4","gravatar_id":"","url":"https://api.github.com/users/15Dkatz","html_url":"https://github.com/15Dkatz","followers_url":"https://api.github.com/users/15Dkatz/followers","following_url":"https://api.github.com/users/15Dkatz/following{/other_user}","gists_url":"https://api.github.com/users/15Dkatz/gists{/gist_id}","starred_url":"https://api.github.com/users/15Dkatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/15Dkatz/subscriptions","organizations_url":"https://api.github.com/users/15Dkatz/orgs","repos_url":"https://api.github.com/users/15Dkatz/repos","events_url":"https://api.github.com/users/15Dkatz/events{/privacy}","received_events_url":"https://api.github.com/users/15Dkatz/received_events","type":"User","site_admin":false},"body":"@wisechengyi \r\n\r\n### Problem\r\nWhat if an owner of a popular library wants to change the Pants target name for that library? Then they would have to update multiple BUILD files to ensure that all of the library's dependees use the new name.\r\n\r\n### Solution\r\nThe solution adds a pants goal called 'meta-rename' to the `buildrefactor` module. This allows us to update the name of a target with --from and --to options. The solution itself builds a dependency graph of the repository. Then by using buildozer, we can rename the original build file, and rename wherever it's referenced as a dependency.\r\n\r\n## Follow-ups:\r\n- Support all the targets beyond Scala, like Python, Java, and more.\r\n- Rename attributes/keys in BUILD files under the same `target_name` as the specified target.\r\n- Smartly recognize the format of references in BUILD files, whether that's <spec_path>:<target_name>, <target_name>, or :<target_name>. Right now, the goal will try to execute on <spec_path>:<target_name>, and if an error occurs, it will execute on :<target_name>.\r\n\r\n## This refactors:\r\nhttps://github.com/pantsbuild/pants/pull/4882\r\n\r\n## This addresses issue:\r\nhttps://github.com/pantsbuild/pants/issues/4845\r\n\r\n### To Verify:\r\nExample:\r\n`./pants meta-rename\r\n--from=examples/src/java/org/pantsbuild/example/javac/plugin:simple_javac_plugin\r\n--to=examples/src/java/org/pantsbuild/example/javac/plugin:new_name`\r\n\r\nTest:\r\n` ./pants test\r\ncontrib/buildrefactor/tests/python/pants_test/contrib/buildrefactor:meta-rename`\r\n` ./pants test\r\ncontrib/buildrefactor/tests/python/pants_test/contrib/buildrefactor:buildozer`\r\n","created_at":"2017-10-26T18:17:39Z","updated_at":"2017-11-11T00:55:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86829883e105c97a38ed84c5eec5222416b7c2d0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5023/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5023/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/5023/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/773852840107493af6597bc25465d3f9ca772fa3","head":{"label":"15Dkatz:rename-with-buildozer","ref":"rename-with-buildozer","sha":"773852840107493af6597bc25465d3f9ca772fa3","user":{"login":"15Dkatz","id":11095053,"avatar_url":"https://avatars3.githubusercontent.com/u/11095053?v=4","gravatar_id":"","url":"https://api.github.com/users/15Dkatz","html_url":"https://github.com/15Dkatz","followers_url":"https://api.github.com/users/15Dkatz/followers","following_url":"https://api.github.com/users/15Dkatz/following{/other_user}","gists_url":"https://api.github.com/users/15Dkatz/gists{/gist_id}","starred_url":"https://api.github.com/users/15Dkatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/15Dkatz/subscriptions","organizations_url":"https://api.github.com/users/15Dkatz/orgs","repos_url":"https://api.github.com/users/15Dkatz/repos","events_url":"https://api.github.com/users/15Dkatz/events{/privacy}","received_events_url":"https://api.github.com/users/15Dkatz/received_events","type":"User","site_admin":false},"repo":{"id":103761657,"name":"pants","full_name":"15Dkatz/pants","owner":{"login":"15Dkatz","id":11095053,"avatar_url":"https://avatars3.githubusercontent.com/u/11095053?v=4","gravatar_id":"","url":"https://api.github.com/users/15Dkatz","html_url":"https://github.com/15Dkatz","followers_url":"https://api.github.com/users/15Dkatz/followers","following_url":"https://api.github.com/users/15Dkatz/following{/other_user}","gists_url":"https://api.github.com/users/15Dkatz/gists{/gist_id}","starred_url":"https://api.github.com/users/15Dkatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/15Dkatz/subscriptions","organizations_url":"https://api.github.com/users/15Dkatz/orgs","repos_url":"https://api.github.com/users/15Dkatz/repos","events_url":"https://api.github.com/users/15Dkatz/events{/privacy}","received_events_url":"https://api.github.com/users/15Dkatz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/15Dkatz/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/15Dkatz/pants","forks_url":"https://api.github.com/repos/15Dkatz/pants/forks","keys_url":"https://api.github.com/repos/15Dkatz/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/15Dkatz/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/15Dkatz/pants/teams","hooks_url":"https://api.github.com/repos/15Dkatz/pants/hooks","issue_events_url":"https://api.github.com/repos/15Dkatz/pants/issues/events{/number}","events_url":"https://api.github.com/repos/15Dkatz/pants/events","assignees_url":"https://api.github.com/repos/15Dkatz/pants/assignees{/user}","branches_url":"https://api.github.com/repos/15Dkatz/pants/branches{/branch}","tags_url":"https://api.github.com/repos/15Dkatz/pants/tags","blobs_url":"https://api.github.com/repos/15Dkatz/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/15Dkatz/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/15Dkatz/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/15Dkatz/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/15Dkatz/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/15Dkatz/pants/languages","stargazers_url":"https://api.github.com/repos/15Dkatz/pants/stargazers","contributors_url":"https://api.github.com/repos/15Dkatz/pants/contributors","subscribers_url":"https://api.github.com/repos/15Dkatz/pants/subscribers","subscription_url":"https://api.github.com/repos/15Dkatz/pants/subscription","commits_url":"https://api.github.com/repos/15Dkatz/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/15Dkatz/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/15Dkatz/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/15Dkatz/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/15Dkatz/pants/contents/{+path}","compare_url":"https://api.github.com/repos/15Dkatz/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/15Dkatz/pants/merges","archive_url":"https://api.github.com/repos/15Dkatz/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/15Dkatz/pants/downloads","issues_url":"https://api.github.com/repos/15Dkatz/pants/issues{/number}","pulls_url":"https://api.github.com/repos/15Dkatz/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/15Dkatz/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/15Dkatz/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/15Dkatz/pants/labels{/name}","releases_url":"https://api.github.com/repos/15Dkatz/pants/releases{/id}","deployments_url":"https://api.github.com/repos/15Dkatz/pants/deployments","created_at":"2017-09-16T15:14:51Z","updated_at":"2017-09-16T15:14:58Z","pushed_at":"2017-11-10T21:53:26Z","git_url":"git://github.com/15Dkatz/pants.git","ssh_url":"[email protected]:15Dkatz/pants.git","clone_url":"https://github.com/15Dkatz/pants.git","svn_url":"https://github.com/15Dkatz/pants","homepage":"http://pantsbuild.org/","size":83230,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"4808297dedc739dab5f90ca44915348e888ca5c7","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2017-11-10T19:30:53Z","pushed_at":"2017-11-11T00:53:38Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"[email protected]:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.org/","size":80857,"stargazers_count":865,"watchers_count":865,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"open_issues_count":530,"forks":252,"open_issues":530,"watchers":865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5023"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5023"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5023"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5023/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5023/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5023/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/773852840107493af6597bc25465d3f9ca772fa3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 7209075,
"name": "pantsbuild/pants",
"url": "https://api.github.com/repos/pantsbuild/pants"
} | {
"id": 596358,
"login": "wisechengyi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/596358?",
"url": "https://api.github.com/users/wisechengyi"
} | {
"id": 3065172,
"login": "pantsbuild",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3065172?",
"url": "https://api.github.com/orgs/pantsbuild"
} | 2017-11-11T00:39:19 | 6840508542 | {"actor":{"display_login":"wisechengyi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/comments/124937242","pull_request_review_id":47278724,"id":124937242,"diff_hunk":"@@ -1,7 +1,7 @@\n # Dependencies for PDF rendering\n class classroom::master::pdf_stack {\n \n- $enabled = $classroom::offline ? {\n+ $enabled = defined('$classroom::offline') and $classroom::offline ? {","path":"manifests/master/pdf_stack.pp","position":5,"original_position":5,"commit_id":"638fdf1e3b89e2302efabbc63cc5a7e9de4a8454","original_commit_id":"638fdf1e3b89e2302efabbc63cc5a7e9de4a8454","user":{"login":"greglarkin","id":4807374,"avatar_url":"https://avatars2.githubusercontent.com/u/4807374?v=3","gravatar_id":"","url":"https://api.github.com/users/greglarkin","html_url":"https://github.com/greglarkin","followers_url":"https://api.github.com/users/greglarkin/followers","following_url":"https://api.github.com/users/greglarkin/following{/other_user}","gists_url":"https://api.github.com/users/greglarkin/gists{/gist_id}","starred_url":"https://api.github.com/users/greglarkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglarkin/subscriptions","organizations_url":"https://api.github.com/users/greglarkin/orgs","repos_url":"https://api.github.com/users/greglarkin/repos","events_url":"https://api.github.com/users/greglarkin/events{/privacy}","received_events_url":"https://api.github.com/users/greglarkin/received_events","type":"User","site_admin":false},"body":"@samuelson Thought about that. I would need to add it to this class and the calling class `classroom::master::showoff`. I had to do something similar with the new `jvm_tuning_profile` parameter.","created_at":"2017-06-29T23:41:47Z","updated_at":"2017-06-29T23:41:47Z","html_url":"https://github.com/puppetlabs/pltraining-classroom/pull/334#discussion_r124937242","pull_request_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/334","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/comments/124937242"},"html":{"href":"https://github.com/puppetlabs/pltraining-classroom/pull/334#discussion_r124937242"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/334"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/334","id":125711747,"html_url":"https://github.com/puppetlabs/pltraining-classroom/pull/334","diff_url":"https://github.com/puppetlabs/pltraining-classroom/pull/334.diff","patch_url":"https://github.com/puppetlabs/pltraining-classroom/pull/334.patch","issue_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/334","number":334,"state":"open","locked":false,"title":"Implement Gabe's \"tuned-down\" PE configuration and clean up tuning class","user":{"login":"greglarkin","id":4807374,"avatar_url":"https://avatars2.githubusercontent.com/u/4807374?v=3","gravatar_id":"","url":"https://api.github.com/users/greglarkin","html_url":"https://github.com/greglarkin","followers_url":"https://api.github.com/users/greglarkin/followers","following_url":"https://api.github.com/users/greglarkin/following{/other_user}","gists_url":"https://api.github.com/users/greglarkin/gists{/gist_id}","starred_url":"https://api.github.com/users/greglarkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglarkin/subscriptions","organizations_url":"https://api.github.com/users/greglarkin/orgs","repos_url":"https://api.github.com/users/greglarkin/repos","events_url":"https://api.github.com/users/greglarkin/events{/privacy}","received_events_url":"https://api.github.com/users/greglarkin/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-06-14T23:10:17Z","updated_at":"2017-06-29T23:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dbf28901192336c5e5ae0ad9bdecb13513af328","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/334/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/334/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/334/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/statuses/638fdf1e3b89e2302efabbc63cc5a7e9de4a8454","head":{"label":"greglarkin:traintech-1051-fix","ref":"traintech-1051-fix","sha":"638fdf1e3b89e2302efabbc63cc5a7e9de4a8454","user":{"login":"greglarkin","id":4807374,"avatar_url":"https://avatars2.githubusercontent.com/u/4807374?v=3","gravatar_id":"","url":"https://api.github.com/users/greglarkin","html_url":"https://github.com/greglarkin","followers_url":"https://api.github.com/users/greglarkin/followers","following_url":"https://api.github.com/users/greglarkin/following{/other_user}","gists_url":"https://api.github.com/users/greglarkin/gists{/gist_id}","starred_url":"https://api.github.com/users/greglarkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglarkin/subscriptions","organizations_url":"https://api.github.com/users/greglarkin/orgs","repos_url":"https://api.github.com/users/greglarkin/repos","events_url":"https://api.github.com/users/greglarkin/events{/privacy}","received_events_url":"https://api.github.com/users/greglarkin/received_events","type":"User","site_admin":false},"repo":{"id":63986863,"name":"pltraining-classroom","full_name":"greglarkin/pltraining-classroom","owner":{"login":"greglarkin","id":4807374,"avatar_url":"https://avatars2.githubusercontent.com/u/4807374?v=3","gravatar_id":"","url":"https://api.github.com/users/greglarkin","html_url":"https://github.com/greglarkin","followers_url":"https://api.github.com/users/greglarkin/followers","following_url":"https://api.github.com/users/greglarkin/following{/other_user}","gists_url":"https://api.github.com/users/greglarkin/gists{/gist_id}","starred_url":"https://api.github.com/users/greglarkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglarkin/subscriptions","organizations_url":"https://api.github.com/users/greglarkin/orgs","repos_url":"https://api.github.com/users/greglarkin/repos","events_url":"https://api.github.com/users/greglarkin/events{/privacy}","received_events_url":"https://api.github.com/users/greglarkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greglarkin/pltraining-classroom","description":"Classroom module for Puppetlabs Training courses. Not intended for general use.","fork":true,"url":"https://api.github.com/repos/greglarkin/pltraining-classroom","forks_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/forks","keys_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/teams","hooks_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/hooks","issue_events_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/issues/events{/number}","events_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/events","assignees_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/assignees{/user}","branches_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/branches{/branch}","tags_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/tags","blobs_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/statuses/{sha}","languages_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/languages","stargazers_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/stargazers","contributors_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/contributors","subscribers_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/subscribers","subscription_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/subscription","commits_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/contents/{+path}","compare_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/merges","archive_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/downloads","issues_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/issues{/number}","pulls_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/pulls{/number}","milestones_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/milestones{/number}","notifications_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/labels{/name}","releases_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/releases{/id}","deployments_url":"https://api.github.com/repos/greglarkin/pltraining-classroom/deployments","created_at":"2016-07-22T22:22:26Z","updated_at":"2016-07-22T22:22:27Z","pushed_at":"2017-06-29T23:31:49Z","git_url":"git://github.com/greglarkin/pltraining-classroom.git","ssh_url":"[email protected]:greglarkin/pltraining-classroom.git","clone_url":"https://github.com/greglarkin/pltraining-classroom.git","svn_url":"https://github.com/greglarkin/pltraining-classroom","homepage":null,"size":18058,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f5c91d5e71be8f402aee0297cf53c5ac30b8092b","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars3.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":32344158,"name":"pltraining-classroom","full_name":"puppetlabs/pltraining-classroom","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars3.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pltraining-classroom","description":"Classroom module for Puppetlabs Training courses. Not intended for general use.","fork":false,"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom","forks_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/forks","keys_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/events","assignees_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/merges","archive_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/deployments","created_at":"2015-03-16T18:17:47Z","updated_at":"2017-04-27T05:20:37Z","pushed_at":"2017-06-29T23:31:51Z","git_url":"git://github.com/puppetlabs/pltraining-classroom.git","ssh_url":"[email protected]:puppetlabs/pltraining-classroom.git","clone_url":"https://github.com/puppetlabs/pltraining-classroom.git","svn_url":"https://github.com/puppetlabs/pltraining-classroom","homepage":null,"size":18053,"stargazers_count":13,"watchers_count":13,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":4,"forks":23,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/334"},"html":{"href":"https://github.com/puppetlabs/pltraining-classroom/pull/334"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/334"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/statuses/638fdf1e3b89e2302efabbc63cc5a7e9de4a8454"}}}} | {
"id": 32344158,
"name": "puppetlabs/pltraining-classroom",
"url": "https://api.github.com/repos/puppetlabs/pltraining-classroom"
} | {
"id": 4807374,
"login": "greglarkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4807374?",
"url": "https://api.github.com/users/greglarkin"
} | {
"id": 234268,
"login": "puppetlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234268?",
"url": "https://api.github.com/orgs/puppetlabs"
} | 2017-06-29T23:41:47 | 6167684112 | {"actor":{"display_login":"greglarkin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/purescript/pursuit/pulls/comments/94683027","pull_request_review_id":15216615,"id":94683027,"diff_hunk":"@@ -163,10 +163,12 @@ getBuiltinDocsR mnString = do\n setTitle (toHtml mnString)\n let mn = P.moduleNameFromString mnString\n let htmlDocs = primDocs\n- let widget = $(widgetFile \"packageVersionModuleDocs\")\n [whamlet|\n- <div .col.col-main>\n- ^{widget}\n+ <div .col.col--main>\n+ <div .page-title.clearfix>\n+ <div .page-title__label>Builtin","path":"src/Handler/Packages.hs","position":28,"original_position":28,"commit_id":"40ee7cdbb1337b9177b04322833982e8f1abbffd","original_commit_id":"40ee7cdbb1337b9177b04322833982e8f1abbffd","user":{"login":"hdgarrood","id":1270186,"avatar_url":"https://avatars.githubusercontent.com/u/1270186?v=3","gravatar_id":"","url":"https://api.github.com/users/hdgarrood","html_url":"https://github.com/hdgarrood","followers_url":"https://api.github.com/users/hdgarrood/followers","following_url":"https://api.github.com/users/hdgarrood/following{/other_user}","gists_url":"https://api.github.com/users/hdgarrood/gists{/gist_id}","starred_url":"https://api.github.com/users/hdgarrood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdgarrood/subscriptions","organizations_url":"https://api.github.com/users/hdgarrood/orgs","repos_url":"https://api.github.com/users/hdgarrood/repos","events_url":"https://api.github.com/users/hdgarrood/events{/privacy}","received_events_url":"https://api.github.com/users/hdgarrood/received_events","type":"User","site_admin":false},"body":"I think this should say \"Module\" rather than \"Builtin\" - `Prim` is still a module, it being built in to the compiler doesn't change that.","created_at":"2017-01-04T22:55:03Z","updated_at":"2017-01-04T22:55:03Z","html_url":"https://github.com/purescript/pursuit/pull/266#discussion_r94683027","pull_request_url":"https://api.github.com/repos/purescript/pursuit/pulls/266","_links":{"self":{"href":"https://api.github.com/repos/purescript/pursuit/pulls/comments/94683027"},"html":{"href":"https://github.com/purescript/pursuit/pull/266#discussion_r94683027"},"pull_request":{"href":"https://api.github.com/repos/purescript/pursuit/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/purescript/pursuit/pulls/266","id":99940074,"html_url":"https://github.com/purescript/pursuit/pull/266","diff_url":"https://github.com/purescript/pursuit/pull/266.diff","patch_url":"https://github.com/purescript/pursuit/pull/266.patch","issue_url":"https://api.github.com/repos/purescript/pursuit/issues/266","number":266,"state":"open","locked":false,"title":"UI Refinements","user":{"login":"naehrstoff","id":10811,"avatar_url":"https://avatars.githubusercontent.com/u/10811?v=3","gravatar_id":"","url":"https://api.github.com/users/naehrstoff","html_url":"https://github.com/naehrstoff","followers_url":"https://api.github.com/users/naehrstoff/followers","following_url":"https://api.github.com/users/naehrstoff/following{/other_user}","gists_url":"https://api.github.com/users/naehrstoff/gists{/gist_id}","starred_url":"https://api.github.com/users/naehrstoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naehrstoff/subscriptions","organizations_url":"https://api.github.com/users/naehrstoff/orgs","repos_url":"https://api.github.com/users/naehrstoff/repos","events_url":"https://api.github.com/users/naehrstoff/events{/privacy}","received_events_url":"https://api.github.com/users/naehrstoff/received_events","type":"User","site_admin":false},"body":"This PR focuses on making Pursuit more useable and beginner friendly by applying a few visual and interaction design recipes. It mainly improves on the following:\r\n\r\n* More welcoming homepage with more personality, search examples, and denser presentation of packages.\r\n* Distinctive typographic treatment of the content to provide better visual guidance for the reader.\r\n* Improved display of search results for easier scannability and understandability (e.g. by adding badges to modules and packages to better highlight what they are).\r\n* Clarified navigation between packages and modules and allow navigation from one module to a sibling module.\r\n* Friendlier display of code examples and inline code snippets.\r\n\r\nI'll have some more time to work on this this week, so if there are things that I should fix or that I overlooked, please let me know and I'll see that I can add them so this PR could be merged.\r\n\r\n_Note: this is a big PR that I should probably have announced before I started working on it. I chose to do this in stealth mode, however, because I was not sure whether I would find the time to properly work on it due to the unpredictability of kids 😬. It did work out and I'm happy to be able to submit this PR._\r\n\r\n# Commit summary\r\n\r\n## Typography\r\n* Fixed display of italic fonts (no italic font files had been loaded before, making the browser slant the regular font, leading to faux-italics). <img width=\"388\" alt=\"faux-real-italic\" src=\"https://cloud.githubusercontent.com/assets/10811/21605311/9198e614-d1a8-11e6-9d83-f06d94315fdf.png\">\r\n* Lists align with left edge for cleaner look.\r\n* Introduced definition lists for combination of titles and list elements.\r\n* Version numbers are displayed in a smaller font to make them more distinctive.\r\n\r\n## CSS\r\n\r\nI refactored the CSS quite a bit fully aware that large scale code rewriting is a very bad practice for PRs. However, after working on the previous CSS for a while the many global styles made it very difficult to work with, leading me to believe that it was grown over time and was ready for a refactoring.\r\n\r\nI introduced code sections and a naming system based on [BEM](https://en.bem.info/). I understand that this is a controversial naming system; it is very good at creating human-readable namespaces, however, which is needed for creating CSS components that don't influence one another and that can be changed confidently over time. Because it only has three rules (that I applied here) it is easy to apply also for people who don't know what it is.\r\n\r\nI tried to keep the CSS small and well structured to make sure other people can make changes to it easily.\r\n\r\n* Introduced code sections\r\n* Component naming system based on BEM\r\n* Generalised utility classes\r\n* Extracted existing styles into CSS components\r\n* Improved page layout at various breakpoints\r\n* Treat Github rendered Markdown content separately and clearly namespace it (because we don't control it)\r\n\r\n## Other\r\n\r\n* Fixed some small accessibility issues\r\n\r\n# Discussion\r\n\r\n1. [ ] I saw that there is an open issue for a favicon (#109), work on it has been started but stalled. If it's ok, I would make and add a favicon.\r\n2. [ ] Issue #93 mentions contrast of links and other elements. This is something that could be attacked in further design refinements. However, it opens the question on what decisions taken there would mean for the Purescript website. Would that maybe be an undertaking for the Purescript 1.0 release? I like to use living style guides to make sure a design language can grow and is properly applied, but I wouldn't know where to host that (A separate repo? The main Purescript repo?)\r\n3. [ ] A recent PR (https://github.com/purescript/pursuit/commit/27e0ac19026538b04929837c7f9bf5fb1ebe2cb7) introduced a new route to display builtin docs. I have for the time being solved it like so in the new layout: https://github.com/naehrstoff/pursuit/commit/cc9ee90efc8c8fd2c4b36f92cc466f5472f4a6ae Is more needed?\r\n4. [x] After merging in the latest changes I found that some packages did not render or stopped rendering after a while (e.g. purescript-ace). I'm not sure what the cause of this is but suspect that it has to do with the `purescript-backups` packages I use (updated just now) or some caches. If you can reproduce this, please let me know.\r\n\r\n# Screenshots\r\n\r\n## Homepage\r\n\r\n\r\n\r\n## Package\r\n\r\n\r\n\r\n## Module\r\n\r\n\r\n\r\n## Search results\r\n\r\n\r\n\r\n## Code\r\n\r\n","created_at":"2017-01-03T11:19:37Z","updated_at":"2017-01-04T22:55:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"445a7d2bf0ccac5376e8cc01432e6c48f905eb8b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/purescript/pursuit/pulls/266/commits","review_comments_url":"https://api.github.com/repos/purescript/pursuit/pulls/266/comments","review_comment_url":"https://api.github.com/repos/purescript/pursuit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purescript/pursuit/issues/266/comments","statuses_url":"https://api.github.com/repos/purescript/pursuit/statuses/40ee7cdbb1337b9177b04322833982e8f1abbffd","head":{"label":"naehrstoff:ui-refinements","ref":"ui-refinements","sha":"40ee7cdbb1337b9177b04322833982e8f1abbffd","user":{"login":"naehrstoff","id":10811,"avatar_url":"https://avatars.githubusercontent.com/u/10811?v=3","gravatar_id":"","url":"https://api.github.com/users/naehrstoff","html_url":"https://github.com/naehrstoff","followers_url":"https://api.github.com/users/naehrstoff/followers","following_url":"https://api.github.com/users/naehrstoff/following{/other_user}","gists_url":"https://api.github.com/users/naehrstoff/gists{/gist_id}","starred_url":"https://api.github.com/users/naehrstoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naehrstoff/subscriptions","organizations_url":"https://api.github.com/users/naehrstoff/orgs","repos_url":"https://api.github.com/users/naehrstoff/repos","events_url":"https://api.github.com/users/naehrstoff/events{/privacy}","received_events_url":"https://api.github.com/users/naehrstoff/received_events","type":"User","site_admin":false},"repo":{"id":77902576,"name":"pursuit","full_name":"naehrstoff/pursuit","owner":{"login":"naehrstoff","id":10811,"avatar_url":"https://avatars.githubusercontent.com/u/10811?v=3","gravatar_id":"","url":"https://api.github.com/users/naehrstoff","html_url":"https://github.com/naehrstoff","followers_url":"https://api.github.com/users/naehrstoff/followers","following_url":"https://api.github.com/users/naehrstoff/following{/other_user}","gists_url":"https://api.github.com/users/naehrstoff/gists{/gist_id}","starred_url":"https://api.github.com/users/naehrstoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naehrstoff/subscriptions","organizations_url":"https://api.github.com/users/naehrstoff/orgs","repos_url":"https://api.github.com/users/naehrstoff/repos","events_url":"https://api.github.com/users/naehrstoff/events{/privacy}","received_events_url":"https://api.github.com/users/naehrstoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/naehrstoff/pursuit","description":"Search engine for PureScript functions","fork":true,"url":"https://api.github.com/repos/naehrstoff/pursuit","forks_url":"https://api.github.com/repos/naehrstoff/pursuit/forks","keys_url":"https://api.github.com/repos/naehrstoff/pursuit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naehrstoff/pursuit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naehrstoff/pursuit/teams","hooks_url":"https://api.github.com/repos/naehrstoff/pursuit/hooks","issue_events_url":"https://api.github.com/repos/naehrstoff/pursuit/issues/events{/number}","events_url":"https://api.github.com/repos/naehrstoff/pursuit/events","assignees_url":"https://api.github.com/repos/naehrstoff/pursuit/assignees{/user}","branches_url":"https://api.github.com/repos/naehrstoff/pursuit/branches{/branch}","tags_url":"https://api.github.com/repos/naehrstoff/pursuit/tags","blobs_url":"https://api.github.com/repos/naehrstoff/pursuit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naehrstoff/pursuit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naehrstoff/pursuit/git/refs{/sha}","trees_url":"https://api.github.com/repos/naehrstoff/pursuit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naehrstoff/pursuit/statuses/{sha}","languages_url":"https://api.github.com/repos/naehrstoff/pursuit/languages","stargazers_url":"https://api.github.com/repos/naehrstoff/pursuit/stargazers","contributors_url":"https://api.github.com/repos/naehrstoff/pursuit/contributors","subscribers_url":"https://api.github.com/repos/naehrstoff/pursuit/subscribers","subscription_url":"https://api.github.com/repos/naehrstoff/pursuit/subscription","commits_url":"https://api.github.com/repos/naehrstoff/pursuit/commits{/sha}","git_commits_url":"https://api.github.com/repos/naehrstoff/pursuit/git/commits{/sha}","comments_url":"https://api.github.com/repos/naehrstoff/pursuit/comments{/number}","issue_comment_url":"https://api.github.com/repos/naehrstoff/pursuit/issues/comments{/number}","contents_url":"https://api.github.com/repos/naehrstoff/pursuit/contents/{+path}","compare_url":"https://api.github.com/repos/naehrstoff/pursuit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naehrstoff/pursuit/merges","archive_url":"https://api.github.com/repos/naehrstoff/pursuit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naehrstoff/pursuit/downloads","issues_url":"https://api.github.com/repos/naehrstoff/pursuit/issues{/number}","pulls_url":"https://api.github.com/repos/naehrstoff/pursuit/pulls{/number}","milestones_url":"https://api.github.com/repos/naehrstoff/pursuit/milestones{/number}","notifications_url":"https://api.github.com/repos/naehrstoff/pursuit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naehrstoff/pursuit/labels{/name}","releases_url":"https://api.github.com/repos/naehrstoff/pursuit/releases{/id}","deployments_url":"https://api.github.com/repos/naehrstoff/pursuit/deployments","created_at":"2017-01-03T09:28:57Z","updated_at":"2017-01-03T09:29:01Z","pushed_at":"2017-01-03T13:08:50Z","git_url":"git://github.com/naehrstoff/pursuit.git","ssh_url":"[email protected]:naehrstoff/pursuit.git","clone_url":"https://github.com/naehrstoff/pursuit.git","svn_url":"https://github.com/naehrstoff/pursuit","homepage":"http://pursuit.purescript.org/","size":1096,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purescript:master","ref":"master","sha":"c9dd6951acbde5944b1a264c61d7be2ab0f46d0c","user":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"repo":{"id":22592439,"name":"pursuit","full_name":"purescript/pursuit","owner":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purescript/pursuit","description":"Search engine for PureScript functions","fork":false,"url":"https://api.github.com/repos/purescript/pursuit","forks_url":"https://api.github.com/repos/purescript/pursuit/forks","keys_url":"https://api.github.com/repos/purescript/pursuit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purescript/pursuit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purescript/pursuit/teams","hooks_url":"https://api.github.com/repos/purescript/pursuit/hooks","issue_events_url":"https://api.github.com/repos/purescript/pursuit/issues/events{/number}","events_url":"https://api.github.com/repos/purescript/pursuit/events","assignees_url":"https://api.github.com/repos/purescript/pursuit/assignees{/user}","branches_url":"https://api.github.com/repos/purescript/pursuit/branches{/branch}","tags_url":"https://api.github.com/repos/purescript/pursuit/tags","blobs_url":"https://api.github.com/repos/purescript/pursuit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purescript/pursuit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purescript/pursuit/git/refs{/sha}","trees_url":"https://api.github.com/repos/purescript/pursuit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purescript/pursuit/statuses/{sha}","languages_url":"https://api.github.com/repos/purescript/pursuit/languages","stargazers_url":"https://api.github.com/repos/purescript/pursuit/stargazers","contributors_url":"https://api.github.com/repos/purescript/pursuit/contributors","subscribers_url":"https://api.github.com/repos/purescript/pursuit/subscribers","subscription_url":"https://api.github.com/repos/purescript/pursuit/subscription","commits_url":"https://api.github.com/repos/purescript/pursuit/commits{/sha}","git_commits_url":"https://api.github.com/repos/purescript/pursuit/git/commits{/sha}","comments_url":"https://api.github.com/repos/purescript/pursuit/comments{/number}","issue_comment_url":"https://api.github.com/repos/purescript/pursuit/issues/comments{/number}","contents_url":"https://api.github.com/repos/purescript/pursuit/contents/{+path}","compare_url":"https://api.github.com/repos/purescript/pursuit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purescript/pursuit/merges","archive_url":"https://api.github.com/repos/purescript/pursuit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purescript/pursuit/downloads","issues_url":"https://api.github.com/repos/purescript/pursuit/issues{/number}","pulls_url":"https://api.github.com/repos/purescript/pursuit/pulls{/number}","milestones_url":"https://api.github.com/repos/purescript/pursuit/milestones{/number}","notifications_url":"https://api.github.com/repos/purescript/pursuit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purescript/pursuit/labels{/name}","releases_url":"https://api.github.com/repos/purescript/pursuit/releases{/id}","deployments_url":"https://api.github.com/repos/purescript/pursuit/deployments","created_at":"2014-08-04T04:57:54Z","updated_at":"2017-01-03T15:52:45Z","pushed_at":"2017-01-04T22:41:00Z","git_url":"git://github.com/purescript/pursuit.git","ssh_url":"[email protected]:purescript/pursuit.git","clone_url":"https://github.com/purescript/pursuit.git","svn_url":"https://github.com/purescript/pursuit","homepage":"http://pursuit.purescript.org/","size":1061,"stargazers_count":53,"watchers_count":53,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":41,"forks":17,"open_issues":41,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purescript/pursuit/pulls/266"},"html":{"href":"https://github.com/purescript/pursuit/pull/266"},"issue":{"href":"https://api.github.com/repos/purescript/pursuit/issues/266"},"comments":{"href":"https://api.github.com/repos/purescript/pursuit/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/purescript/pursuit/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/purescript/pursuit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purescript/pursuit/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/purescript/pursuit/statuses/40ee7cdbb1337b9177b04322833982e8f1abbffd"}}}} | {
"id": 22592439,
"name": "purescript/pursuit",
"url": "https://api.github.com/repos/purescript/pursuit"
} | {
"id": 1270186,
"login": "hdgarrood",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1270186?",
"url": "https://api.github.com/users/hdgarrood"
} | {
"id": 6556677,
"login": "purescript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6556677?",
"url": "https://api.github.com/orgs/purescript"
} | 2017-01-04T22:55:03 | 5103900122 | {"actor":{"display_login":"hdgarrood"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/comments/133943635","pull_request_review_id":57183490,"id":133943635,"diff_hunk":"@@ -37,15 +37,15 @@ jobs:\n - stage: deploy\n python: '3.6'\n env:\n- install: skip\n+ install: pip install -U setuptools setuptools_scm","path":".travis.yml","position":5,"original_position":5,"commit_id":"d4d52dc933ff4bc532e169de9680a382b187e58b","original_commit_id":"d4d52dc933ff4bc532e169de9680a382b187e58b","user":{"login":"nicoddemus","id":1085180,"avatar_url":"https://avatars2.githubusercontent.com/u/1085180?v=4","gravatar_id":"","url":"https://api.github.com/users/nicoddemus","html_url":"https://github.com/nicoddemus","followers_url":"https://api.github.com/users/nicoddemus/followers","following_url":"https://api.github.com/users/nicoddemus/following{/other_user}","gists_url":"https://api.github.com/users/nicoddemus/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoddemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoddemus/subscriptions","organizations_url":"https://api.github.com/users/nicoddemus/orgs","repos_url":"https://api.github.com/users/nicoddemus/repos","events_url":"https://api.github.com/users/nicoddemus/events{/privacy}","received_events_url":"https://api.github.com/users/nicoddemus/received_events","type":"User","site_admin":false},"body":"I see, thanks.","created_at":"2017-08-18T12:09:59Z","updated_at":"2017-08-18T12:09:59Z","html_url":"https://github.com/pytest-dev/pytest-xdist/pull/225#discussion_r133943635","pull_request_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/comments/133943635"},"html":{"href":"https://github.com/pytest-dev/pytest-xdist/pull/225#discussion_r133943635"},"pull_request":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/225","id":136463456,"html_url":"https://github.com/pytest-dev/pytest-xdist/pull/225","diff_url":"https://github.com/pytest-dev/pytest-xdist/pull/225.diff","patch_url":"https://github.com/pytest-dev/pytest-xdist/pull/225.patch","issue_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/225","number":225,"state":"open","locked":false,"title":"fix up travis deploy config","user":{"login":"RonnyPfannschmidt","id":156838,"avatar_url":"https://avatars1.githubusercontent.com/u/156838?v=4","gravatar_id":"","url":"https://api.github.com/users/RonnyPfannschmidt","html_url":"https://github.com/RonnyPfannschmidt","followers_url":"https://api.github.com/users/RonnyPfannschmidt/followers","following_url":"https://api.github.com/users/RonnyPfannschmidt/following{/other_user}","gists_url":"https://api.github.com/users/RonnyPfannschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyPfannschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyPfannschmidt/subscriptions","organizations_url":"https://api.github.com/users/RonnyPfannschmidt/orgs","repos_url":"https://api.github.com/users/RonnyPfannschmidt/repos","events_url":"https://api.github.com/users/RonnyPfannschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyPfannschmidt/received_events","type":"User","site_admin":false},"body":"move distributions key to the right place\r\ninstall setuptools_scm for deploy\r\n\r\n","created_at":"2017-08-18T12:00:55Z","updated_at":"2017-08-18T12:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fd60d838711d1e842a047c58ba3572486a1cacd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/225/commits","review_comments_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/225/comments","review_comment_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/225/comments","statuses_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/statuses/d4d52dc933ff4bc532e169de9680a382b187e58b","head":{"label":"pytest-dev:Ronny-patch-1","ref":"Ronny-patch-1","sha":"d4d52dc933ff4bc532e169de9680a382b187e58b","user":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars2.githubusercontent.com/u/8897583?v=4","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":41756998,"name":"pytest-xdist","full_name":"pytest-dev/pytest-xdist","owner":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars2.githubusercontent.com/u/8897583?v=4","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytest-dev/pytest-xdist","description":"a py.test plugin for distributed testing and loop-on-failures testing modes. ","fork":false,"url":"https://api.github.com/repos/pytest-dev/pytest-xdist","forks_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/forks","keys_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/events","assignees_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/merges","archive_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/releases{/id}","deployments_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/deployments","created_at":"2015-09-01T18:51:45Z","updated_at":"2017-08-18T08:06:36Z","pushed_at":"2017-08-18T12:00:55Z","git_url":"git://github.com/pytest-dev/pytest-xdist.git","ssh_url":"[email protected]:pytest-dev/pytest-xdist.git","clone_url":"https://github.com/pytest-dev/pytest-xdist.git","svn_url":"https://github.com/pytest-dev/pytest-xdist","homepage":null,"size":1077,"stargazers_count":115,"watchers_count":115,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":68,"forks":50,"open_issues":68,"watchers":115,"default_branch":"master"}},"base":{"label":"pytest-dev:master","ref":"master","sha":"e5c234793440f80ef65812445ab619866427a479","user":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars2.githubusercontent.com/u/8897583?v=4","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":41756998,"name":"pytest-xdist","full_name":"pytest-dev/pytest-xdist","owner":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars2.githubusercontent.com/u/8897583?v=4","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytest-dev/pytest-xdist","description":"a py.test plugin for distributed testing and loop-on-failures testing modes. ","fork":false,"url":"https://api.github.com/repos/pytest-dev/pytest-xdist","forks_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/forks","keys_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/events","assignees_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/merges","archive_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/releases{/id}","deployments_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/deployments","created_at":"2015-09-01T18:51:45Z","updated_at":"2017-08-18T08:06:36Z","pushed_at":"2017-08-18T12:00:55Z","git_url":"git://github.com/pytest-dev/pytest-xdist.git","ssh_url":"[email protected]:pytest-dev/pytest-xdist.git","clone_url":"https://github.com/pytest-dev/pytest-xdist.git","svn_url":"https://github.com/pytest-dev/pytest-xdist","homepage":null,"size":1077,"stargazers_count":115,"watchers_count":115,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":68,"forks":50,"open_issues":68,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/225"},"html":{"href":"https://github.com/pytest-dev/pytest-xdist/pull/225"},"issue":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/225"},"comments":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/pytest-dev/pytest-xdist/statuses/d4d52dc933ff4bc532e169de9680a382b187e58b"}}}} | {
"id": 41756998,
"name": "pytest-dev/pytest-xdist",
"url": "https://api.github.com/repos/pytest-dev/pytest-xdist"
} | {
"id": 1085180,
"login": "nicoddemus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1085180?",
"url": "https://api.github.com/users/nicoddemus"
} | {
"id": 8897583,
"login": "pytest-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8897583?",
"url": "https://api.github.com/orgs/pytest-dev"
} | 2017-08-18T12:09:59 | 6479956292 | {"actor":{"display_login":"nicoddemus"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/robotology/yarp/pulls/comments/145393241","pull_request_review_id":70185301,"id":145393241,"diff_hunk":"@@ -7,6 +7,8 @@\n #ifndef YARP_OS_RANDOM_H\n #define YARP_OS_RANDOM_H\n \n+#ifndef YARP_NO_DEPRECATED","path":"src/libYARP_OS/include/yarp/os/Random.h","position":4,"original_position":4,"commit_id":"3ccf9459d4eadd801c1e48d5c697e9aa9304a100","original_commit_id":"3ccf9459d4eadd801c1e48d5c697e9aa9304a100","user":{"login":"drdanz","id":1100056,"avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},"body":"Please add\r\n```diff\r\n+#ifndef YARP_NO_DEPRECATED // Since YARP 2.3.72\r\n```\r\nSo that we will find it easily when we will remove the deprecated features in the next release","created_at":"2017-10-18T12:06:11Z","updated_at":"2017-10-18T12:10:45Z","html_url":"https://github.com/robotology/yarp/pull/1418#discussion_r145393241","pull_request_url":"https://api.github.com/repos/robotology/yarp/pulls/1418","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments/145393241"},"html":{"href":"https://github.com/robotology/yarp/pull/1418#discussion_r145393241"},"pull_request":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1418"}}},"pull_request":{"url":"https://api.github.com/repos/robotology/yarp/pulls/1418","id":147263178,"html_url":"https://github.com/robotology/yarp/pull/1418","diff_url":"https://github.com/robotology/yarp/pull/1418.diff","patch_url":"https://github.com/robotology/yarp/pull/1418.patch","issue_url":"https://api.github.com/repos/robotology/yarp/issues/1418","number":1418,"state":"open","locked":false,"title":"Deprecate yarp::os::Random","user":{"login":"damn1","id":19439151,"avatar_url":"https://avatars1.githubusercontent.com/u/19439151?v=4","gravatar_id":"","url":"https://api.github.com/users/damn1","html_url":"https://github.com/damn1","followers_url":"https://api.github.com/users/damn1/followers","following_url":"https://api.github.com/users/damn1/following{/other_user}","gists_url":"https://api.github.com/users/damn1/gists{/gist_id}","starred_url":"https://api.github.com/users/damn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damn1/subscriptions","organizations_url":"https://api.github.com/users/damn1/orgs","repos_url":"https://api.github.com/users/damn1/repos","events_url":"https://api.github.com/users/damn1/events{/privacy}","received_events_url":"https://api.github.com/users/damn1/received_events","type":"User","site_admin":false},"body":"Deprecated the Random api and substituted all usages with utilities from C++11's <random> library.\r\nChangelog updated.","created_at":"2017-10-18T10:28:59Z","updated_at":"2017-10-18T12:10:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1836be46532baffe4afaaafe36a4decc262db35e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"traversaro","id":1857049,"avatar_url":"https://avatars2.githubusercontent.com/u/1857049?v=4","gravatar_id":"","url":"https://api.github.com/users/traversaro","html_url":"https://github.com/traversaro","followers_url":"https://api.github.com/users/traversaro/followers","following_url":"https://api.github.com/users/traversaro/following{/other_user}","gists_url":"https://api.github.com/users/traversaro/gists{/gist_id}","starred_url":"https://api.github.com/users/traversaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traversaro/subscriptions","organizations_url":"https://api.github.com/users/traversaro/orgs","repos_url":"https://api.github.com/users/traversaro/repos","events_url":"https://api.github.com/users/traversaro/events{/privacy}","received_events_url":"https://api.github.com/users/traversaro/received_events","type":"User","site_admin":false},{"login":"randaz81","id":2869969,"avatar_url":"https://avatars0.githubusercontent.com/u/2869969?v=4","gravatar_id":"","url":"https://api.github.com/users/randaz81","html_url":"https://github.com/randaz81","followers_url":"https://api.github.com/users/randaz81/followers","following_url":"https://api.github.com/users/randaz81/following{/other_user}","gists_url":"https://api.github.com/users/randaz81/gists{/gist_id}","starred_url":"https://api.github.com/users/randaz81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randaz81/subscriptions","organizations_url":"https://api.github.com/users/randaz81/orgs","repos_url":"https://api.github.com/users/randaz81/repos","events_url":"https://api.github.com/users/randaz81/events{/privacy}","received_events_url":"https://api.github.com/users/randaz81/received_events","type":"User","site_admin":false},{"login":"barbalberto","id":4061020,"avatar_url":"https://avatars2.githubusercontent.com/u/4061020?v=4","gravatar_id":"","url":"https://api.github.com/users/barbalberto","html_url":"https://github.com/barbalberto","followers_url":"https://api.github.com/users/barbalberto/followers","following_url":"https://api.github.com/users/barbalberto/following{/other_user}","gists_url":"https://api.github.com/users/barbalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/barbalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barbalberto/subscriptions","organizations_url":"https://api.github.com/users/barbalberto/orgs","repos_url":"https://api.github.com/users/barbalberto/repos","events_url":"https://api.github.com/users/barbalberto/events{/privacy}","received_events_url":"https://api.github.com/users/barbalberto/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/robotology/yarp/pulls/1418/commits","review_comments_url":"https://api.github.com/repos/robotology/yarp/pulls/1418/comments","review_comment_url":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/yarp/issues/1418/comments","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/3ccf9459d4eadd801c1e48d5c697e9aa9304a100","head":{"label":"damn1:deprecate_osRandom","ref":"deprecate_osRandom","sha":"3ccf9459d4eadd801c1e48d5c697e9aa9304a100","user":{"login":"damn1","id":19439151,"avatar_url":"https://avatars1.githubusercontent.com/u/19439151?v=4","gravatar_id":"","url":"https://api.github.com/users/damn1","html_url":"https://github.com/damn1","followers_url":"https://api.github.com/users/damn1/followers","following_url":"https://api.github.com/users/damn1/following{/other_user}","gists_url":"https://api.github.com/users/damn1/gists{/gist_id}","starred_url":"https://api.github.com/users/damn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damn1/subscriptions","organizations_url":"https://api.github.com/users/damn1/orgs","repos_url":"https://api.github.com/users/damn1/repos","events_url":"https://api.github.com/users/damn1/events{/privacy}","received_events_url":"https://api.github.com/users/damn1/received_events","type":"User","site_admin":false},"repo":{"id":104322647,"name":"yarp","full_name":"damn1/yarp","owner":{"login":"damn1","id":19439151,"avatar_url":"https://avatars1.githubusercontent.com/u/19439151?v=4","gravatar_id":"","url":"https://api.github.com/users/damn1","html_url":"https://github.com/damn1","followers_url":"https://api.github.com/users/damn1/followers","following_url":"https://api.github.com/users/damn1/following{/other_user}","gists_url":"https://api.github.com/users/damn1/gists{/gist_id}","starred_url":"https://api.github.com/users/damn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damn1/subscriptions","organizations_url":"https://api.github.com/users/damn1/orgs","repos_url":"https://api.github.com/users/damn1/repos","events_url":"https://api.github.com/users/damn1/events{/privacy}","received_events_url":"https://api.github.com/users/damn1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damn1/yarp","description":"YARP - Yet Another Robot Platform","fork":true,"url":"https://api.github.com/repos/damn1/yarp","forks_url":"https://api.github.com/repos/damn1/yarp/forks","keys_url":"https://api.github.com/repos/damn1/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damn1/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damn1/yarp/teams","hooks_url":"https://api.github.com/repos/damn1/yarp/hooks","issue_events_url":"https://api.github.com/repos/damn1/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/damn1/yarp/events","assignees_url":"https://api.github.com/repos/damn1/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/damn1/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/damn1/yarp/tags","blobs_url":"https://api.github.com/repos/damn1/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damn1/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damn1/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/damn1/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damn1/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/damn1/yarp/languages","stargazers_url":"https://api.github.com/repos/damn1/yarp/stargazers","contributors_url":"https://api.github.com/repos/damn1/yarp/contributors","subscribers_url":"https://api.github.com/repos/damn1/yarp/subscribers","subscription_url":"https://api.github.com/repos/damn1/yarp/subscription","commits_url":"https://api.github.com/repos/damn1/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/damn1/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/damn1/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/damn1/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/damn1/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/damn1/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damn1/yarp/merges","archive_url":"https://api.github.com/repos/damn1/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damn1/yarp/downloads","issues_url":"https://api.github.com/repos/damn1/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/damn1/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/damn1/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/damn1/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damn1/yarp/labels{/name}","releases_url":"https://api.github.com/repos/damn1/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/damn1/yarp/deployments","created_at":"2017-09-21T08:35:59Z","updated_at":"2017-09-21T08:36:07Z","pushed_at":"2017-10-18T10:42:16Z","git_url":"git://github.com/damn1/yarp.git","ssh_url":"[email protected]:damn1/yarp.git","clone_url":"https://github.com/damn1/yarp.git","svn_url":"https://github.com/damn1/yarp","homepage":"http://www.yarp.it","size":62506,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robotology:devel","ref":"devel","sha":"4bc2c2160419e8bf915f76d12d89c8fc9beb6bb5","user":{"login":"robotology","id":1587191,"avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":9517720,"name":"yarp","full_name":"robotology/yarp","owner":{"login":"robotology","id":1587191,"avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/yarp","description":"YARP - Yet Another Robot Platform","fork":false,"url":"https://api.github.com/repos/robotology/yarp","forks_url":"https://api.github.com/repos/robotology/yarp/forks","keys_url":"https://api.github.com/repos/robotology/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/yarp/teams","hooks_url":"https://api.github.com/repos/robotology/yarp/hooks","issue_events_url":"https://api.github.com/repos/robotology/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/yarp/events","assignees_url":"https://api.github.com/repos/robotology/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/yarp/tags","blobs_url":"https://api.github.com/repos/robotology/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/yarp/languages","stargazers_url":"https://api.github.com/repos/robotology/yarp/stargazers","contributors_url":"https://api.github.com/repos/robotology/yarp/contributors","subscribers_url":"https://api.github.com/repos/robotology/yarp/subscribers","subscription_url":"https://api.github.com/repos/robotology/yarp/subscription","commits_url":"https://api.github.com/repos/robotology/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/yarp/merges","archive_url":"https://api.github.com/repos/robotology/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/yarp/downloads","issues_url":"https://api.github.com/repos/robotology/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/yarp/labels{/name}","releases_url":"https://api.github.com/repos/robotology/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/yarp/deployments","created_at":"2013-04-18T09:13:24Z","updated_at":"2017-10-16T20:45:28Z","pushed_at":"2017-10-18T10:42:18Z","git_url":"git://github.com/robotology/yarp.git","ssh_url":"[email protected]:robotology/yarp.git","clone_url":"https://github.com/robotology/yarp.git","svn_url":"https://github.com/robotology/yarp","homepage":"http://www.yarp.it","size":62516,"stargazers_count":158,"watchers_count":158,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":86,"mirror_url":null,"open_issues_count":180,"forks":86,"open_issues":180,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1418"},"html":{"href":"https://github.com/robotology/yarp/pull/1418"},"issue":{"href":"https://api.github.com/repos/robotology/yarp/issues/1418"},"comments":{"href":"https://api.github.com/repos/robotology/yarp/issues/1418/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1418/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1418/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/yarp/statuses/3ccf9459d4eadd801c1e48d5c697e9aa9304a100"}},"author_association":"CONTRIBUTOR"}} | {
"id": 9517720,
"name": "robotology/yarp",
"url": "https://api.github.com/repos/robotology/yarp"
} | {
"id": 1100056,
"login": "drdanz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1100056?",
"url": "https://api.github.com/users/drdanz"
} | {
"id": 1587191,
"login": "robotology",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1587191?",
"url": "https://api.github.com/orgs/robotology"
} | 2017-10-18T12:06:11 | 6732603065 | {"actor":{"display_login":"drdanz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/searchisko/configuration/pulls/comments/120730500","pull_request_review_id":42718701,"id":120730500,"diff_hunk":"@@ -0,0 +1,128 @@\n+{\n+ \"type\" : \"remote\",\n+ \"remote\" : {\n+ \"urlGetDocuments\" : \"http://{apiKey}\",\n+ \"listDocumentsMode\" : \"simple\",\n+ \"spacesIndexed\" : \"MAIN\",\n+ \"timeout\" : \"60s\",\n+ \"indexUpdatePeriod\" : \"10m\",","path":"rivers/jbossdeveloper_vimeo_drupal.json","position":8,"original_position":8,"commit_id":"2d74f497d71ccb7c082832b442ab407754f2c9db","original_commit_id":"2d74f497d71ccb7c082832b442ab407754f2c9db","user":{"login":"unibrew","id":1574669,"avatar_url":"https://avatars1.githubusercontent.com/u/1574669?v=3","gravatar_id":"","url":"https://api.github.com/users/unibrew","html_url":"https://github.com/unibrew","followers_url":"https://api.github.com/users/unibrew/followers","following_url":"https://api.github.com/users/unibrew/following{/other_user}","gists_url":"https://api.github.com/users/unibrew/gists{/gist_id}","starred_url":"https://api.github.com/users/unibrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unibrew/subscriptions","organizations_url":"https://api.github.com/users/unibrew/orgs","repos_url":"https://api.github.com/users/unibrew/repos","events_url":"https://api.github.com/users/unibrew/events{/privacy}","received_events_url":"https://api.github.com/users/unibrew/received_events","type":"User","site_admin":false},"body":"From yesterday it seems this setting doesn't work, please experiment with the full update one to see if it works as expected. Same for the second river config","created_at":"2017-06-07T20:06:10Z","updated_at":"2017-06-07T20:10:28Z","html_url":"https://github.com/searchisko/configuration/pull/97#discussion_r120730500","pull_request_url":"https://api.github.com/repos/searchisko/configuration/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/searchisko/configuration/pulls/comments/120730500"},"html":{"href":"https://github.com/searchisko/configuration/pull/97#discussion_r120730500"},"pull_request":{"href":"https://api.github.com/repos/searchisko/configuration/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/searchisko/configuration/pulls/97","id":124280816,"html_url":"https://github.com/searchisko/configuration/pull/97","diff_url":"https://github.com/searchisko/configuration/pull/97.diff","patch_url":"https://github.com/searchisko/configuration/pull/97.patch","issue_url":"https://api.github.com/repos/searchisko/configuration/issues/97","number":97,"state":"open","locked":false,"title":"DEVELOPER-3942 - Added video configurations for exported drupal videos","user":{"login":"Dantheman720","id":938664,"avatar_url":"https://avatars1.githubusercontent.com/u/938664?v=3","gravatar_id":"","url":"https://api.github.com/users/Dantheman720","html_url":"https://github.com/Dantheman720","followers_url":"https://api.github.com/users/Dantheman720/followers","following_url":"https://api.github.com/users/Dantheman720/following{/other_user}","gists_url":"https://api.github.com/users/Dantheman720/gists{/gist_id}","starred_url":"https://api.github.com/users/Dantheman720/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dantheman720/subscriptions","organizations_url":"https://api.github.com/users/Dantheman720/orgs","repos_url":"https://api.github.com/users/Dantheman720/repos","events_url":"https://api.github.com/users/Dantheman720/events{/privacy}","received_events_url":"https://api.github.com/users/Dantheman720/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/DEVELOPER-3942","created_at":"2017-06-06T20:27:55Z","updated_at":"2017-06-07T20:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01c9fc990fb7183e1d68bc2238203947fb9e0ff3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/searchisko/configuration/pulls/97/commits","review_comments_url":"https://api.github.com/repos/searchisko/configuration/pulls/97/comments","review_comment_url":"https://api.github.com/repos/searchisko/configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/searchisko/configuration/issues/97/comments","statuses_url":"https://api.github.com/repos/searchisko/configuration/statuses/2d74f497d71ccb7c082832b442ab407754f2c9db","head":{"label":"Dantheman720:VideoRiversConfiguration","ref":"VideoRiversConfiguration","sha":"2d74f497d71ccb7c082832b442ab407754f2c9db","user":{"login":"Dantheman720","id":938664,"avatar_url":"https://avatars1.githubusercontent.com/u/938664?v=3","gravatar_id":"","url":"https://api.github.com/users/Dantheman720","html_url":"https://github.com/Dantheman720","followers_url":"https://api.github.com/users/Dantheman720/followers","following_url":"https://api.github.com/users/Dantheman720/following{/other_user}","gists_url":"https://api.github.com/users/Dantheman720/gists{/gist_id}","starred_url":"https://api.github.com/users/Dantheman720/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dantheman720/subscriptions","organizations_url":"https://api.github.com/users/Dantheman720/orgs","repos_url":"https://api.github.com/users/Dantheman720/repos","events_url":"https://api.github.com/users/Dantheman720/events{/privacy}","received_events_url":"https://api.github.com/users/Dantheman720/received_events","type":"User","site_admin":false},"repo":{"id":47210759,"name":"configuration","full_name":"Dantheman720/configuration","owner":{"login":"Dantheman720","id":938664,"avatar_url":"https://avatars1.githubusercontent.com/u/938664?v=3","gravatar_id":"","url":"https://api.github.com/users/Dantheman720","html_url":"https://github.com/Dantheman720","followers_url":"https://api.github.com/users/Dantheman720/followers","following_url":"https://api.github.com/users/Dantheman720/following{/other_user}","gists_url":"https://api.github.com/users/Dantheman720/gists{/gist_id}","starred_url":"https://api.github.com/users/Dantheman720/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dantheman720/subscriptions","organizations_url":"https://api.github.com/users/Dantheman720/orgs","repos_url":"https://api.github.com/users/Dantheman720/repos","events_url":"https://api.github.com/users/Dantheman720/events{/privacy}","received_events_url":"https://api.github.com/users/Dantheman720/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dantheman720/configuration","description":"Searchisko configuration","fork":true,"url":"https://api.github.com/repos/Dantheman720/configuration","forks_url":"https://api.github.com/repos/Dantheman720/configuration/forks","keys_url":"https://api.github.com/repos/Dantheman720/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dantheman720/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dantheman720/configuration/teams","hooks_url":"https://api.github.com/repos/Dantheman720/configuration/hooks","issue_events_url":"https://api.github.com/repos/Dantheman720/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/Dantheman720/configuration/events","assignees_url":"https://api.github.com/repos/Dantheman720/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/Dantheman720/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/Dantheman720/configuration/tags","blobs_url":"https://api.github.com/repos/Dantheman720/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dantheman720/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dantheman720/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dantheman720/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dantheman720/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/Dantheman720/configuration/languages","stargazers_url":"https://api.github.com/repos/Dantheman720/configuration/stargazers","contributors_url":"https://api.github.com/repos/Dantheman720/configuration/contributors","subscribers_url":"https://api.github.com/repos/Dantheman720/configuration/subscribers","subscription_url":"https://api.github.com/repos/Dantheman720/configuration/subscription","commits_url":"https://api.github.com/repos/Dantheman720/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dantheman720/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dantheman720/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dantheman720/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dantheman720/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/Dantheman720/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dantheman720/configuration/merges","archive_url":"https://api.github.com/repos/Dantheman720/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dantheman720/configuration/downloads","issues_url":"https://api.github.com/repos/Dantheman720/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/Dantheman720/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/Dantheman720/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/Dantheman720/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dantheman720/configuration/labels{/name}","releases_url":"https://api.github.com/repos/Dantheman720/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/Dantheman720/configuration/deployments","created_at":"2015-12-01T18:59:41Z","updated_at":"2015-12-01T18:59:42Z","pushed_at":"2017-06-06T20:13:46Z","git_url":"git://github.com/Dantheman720/configuration.git","ssh_url":"[email protected]:Dantheman720/configuration.git","clone_url":"https://github.com/Dantheman720/configuration.git","svn_url":"https://github.com/Dantheman720/configuration","homepage":null,"size":346,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"searchisko:master","ref":"master","sha":"5c702a9f423ce4da84d65a27faa7c103bbf41ca3","user":{"login":"searchisko","id":5040477,"avatar_url":"https://avatars1.githubusercontent.com/u/5040477?v=3","gravatar_id":"","url":"https://api.github.com/users/searchisko","html_url":"https://github.com/searchisko","followers_url":"https://api.github.com/users/searchisko/followers","following_url":"https://api.github.com/users/searchisko/following{/other_user}","gists_url":"https://api.github.com/users/searchisko/gists{/gist_id}","starred_url":"https://api.github.com/users/searchisko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/searchisko/subscriptions","organizations_url":"https://api.github.com/users/searchisko/orgs","repos_url":"https://api.github.com/users/searchisko/repos","events_url":"https://api.github.com/users/searchisko/events{/privacy}","received_events_url":"https://api.github.com/users/searchisko/received_events","type":"Organization","site_admin":false},"repo":{"id":34790041,"name":"configuration","full_name":"searchisko/configuration","owner":{"login":"searchisko","id":5040477,"avatar_url":"https://avatars1.githubusercontent.com/u/5040477?v=3","gravatar_id":"","url":"https://api.github.com/users/searchisko","html_url":"https://github.com/searchisko","followers_url":"https://api.github.com/users/searchisko/followers","following_url":"https://api.github.com/users/searchisko/following{/other_user}","gists_url":"https://api.github.com/users/searchisko/gists{/gist_id}","starred_url":"https://api.github.com/users/searchisko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/searchisko/subscriptions","organizations_url":"https://api.github.com/users/searchisko/orgs","repos_url":"https://api.github.com/users/searchisko/repos","events_url":"https://api.github.com/users/searchisko/events{/privacy}","received_events_url":"https://api.github.com/users/searchisko/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/searchisko/configuration","description":"Searchisko configuration","fork":false,"url":"https://api.github.com/repos/searchisko/configuration","forks_url":"https://api.github.com/repos/searchisko/configuration/forks","keys_url":"https://api.github.com/repos/searchisko/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/searchisko/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/searchisko/configuration/teams","hooks_url":"https://api.github.com/repos/searchisko/configuration/hooks","issue_events_url":"https://api.github.com/repos/searchisko/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/searchisko/configuration/events","assignees_url":"https://api.github.com/repos/searchisko/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/searchisko/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/searchisko/configuration/tags","blobs_url":"https://api.github.com/repos/searchisko/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/searchisko/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/searchisko/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/searchisko/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/searchisko/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/searchisko/configuration/languages","stargazers_url":"https://api.github.com/repos/searchisko/configuration/stargazers","contributors_url":"https://api.github.com/repos/searchisko/configuration/contributors","subscribers_url":"https://api.github.com/repos/searchisko/configuration/subscribers","subscription_url":"https://api.github.com/repos/searchisko/configuration/subscription","commits_url":"https://api.github.com/repos/searchisko/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/searchisko/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/searchisko/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/searchisko/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/searchisko/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/searchisko/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/searchisko/configuration/merges","archive_url":"https://api.github.com/repos/searchisko/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/searchisko/configuration/downloads","issues_url":"https://api.github.com/repos/searchisko/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/searchisko/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/searchisko/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/searchisko/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/searchisko/configuration/labels{/name}","releases_url":"https://api.github.com/repos/searchisko/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/searchisko/configuration/deployments","created_at":"2015-04-29T11:29:13Z","updated_at":"2016-01-26T12:46:22Z","pushed_at":"2017-06-06T20:27:56Z","git_url":"git://github.com/searchisko/configuration.git","ssh_url":"[email protected]:searchisko/configuration.git","clone_url":"https://github.com/searchisko/configuration.git","svn_url":"https://github.com/searchisko/configuration","homepage":null,"size":342,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/searchisko/configuration/pulls/97"},"html":{"href":"https://github.com/searchisko/configuration/pull/97"},"issue":{"href":"https://api.github.com/repos/searchisko/configuration/issues/97"},"comments":{"href":"https://api.github.com/repos/searchisko/configuration/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/searchisko/configuration/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/searchisko/configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/searchisko/configuration/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/searchisko/configuration/statuses/2d74f497d71ccb7c082832b442ab407754f2c9db"}}}} | {
"id": 34790041,
"name": "searchisko/configuration",
"url": "https://api.github.com/repos/searchisko/configuration"
} | {
"id": 1574669,
"login": "unibrew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1574669?",
"url": "https://api.github.com/users/unibrew"
} | {
"id": 5040477,
"login": "searchisko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5040477?",
"url": "https://api.github.com/orgs/searchisko"
} | 2017-06-07T20:06:10 | 6022060131 | {"actor":{"display_login":"unibrew"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/serverless/serverless/pulls/comments/139558242","pull_request_review_id":63508084,"id":139558242,"diff_hunk":"@@ -1,9 +1,16 @@\n const path = require('path');\n-// eslint-disable-next-line import/no-unresolved\n const slsw = require('serverless-webpack');\n \n module.exports = {\n entry: slsw.lib.entries,\n+ resolve: {","path":"lib/plugins/create/templates/aws-nodejs-typescript/webpack.config.js","position":7,"original_position":7,"commit_id":"cd33957793a3bfa0d8c32e6338c3c477c0507bbe","original_commit_id":"3cbea4df9c84a12d80b216a0e1eaa3521ca42e13","user":{"login":"franciscocpg","id":3680556,"avatar_url":"https://avatars1.githubusercontent.com/u/3680556?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscocpg","html_url":"https://github.com/franciscocpg","followers_url":"https://api.github.com/users/franciscocpg/followers","following_url":"https://api.github.com/users/franciscocpg/following{/other_user}","gists_url":"https://api.github.com/users/franciscocpg/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscocpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscocpg/subscriptions","organizations_url":"https://api.github.com/users/franciscocpg/orgs","repos_url":"https://api.github.com/users/franciscocpg/repos","events_url":"https://api.github.com/users/franciscocpg/events{/privacy}","received_events_url":"https://api.github.com/users/franciscocpg/received_events","type":"User","site_admin":false},"body":"Since we're adding `.tsx` I think it makes sense.","created_at":"2017-09-18T22:37:53Z","updated_at":"2017-09-18T22:37:53Z","html_url":"https://github.com/serverless/serverless/pull/4281#discussion_r139558242","pull_request_url":"https://api.github.com/repos/serverless/serverless/pulls/4281","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments/139558242"},"html":{"href":"https://github.com/serverless/serverless/pull/4281#discussion_r139558242"},"pull_request":{"href":"https://api.github.com/repos/serverless/serverless/pulls/4281"}},"in_reply_to_id":139551202},"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/4281","id":141713321,"html_url":"https://github.com/serverless/serverless/pull/4281","diff_url":"https://github.com/serverless/serverless/pull/4281.diff","patch_url":"https://github.com/serverless/serverless/pull/4281.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/4281","number":4281,"state":"open","locked":false,"title":"Adding typescript files extension to webpack resolves","user":{"login":"franciscocpg","id":3680556,"avatar_url":"https://avatars1.githubusercontent.com/u/3680556?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscocpg","html_url":"https://github.com/franciscocpg","followers_url":"https://api.github.com/users/franciscocpg/followers","following_url":"https://api.github.com/users/franciscocpg/following{/other_user}","gists_url":"https://api.github.com/users/franciscocpg/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscocpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscocpg/subscriptions","organizations_url":"https://api.github.com/users/franciscocpg/orgs","repos_url":"https://api.github.com/users/franciscocpg/repos","events_url":"https://api.github.com/users/franciscocpg/events{/privacy}","received_events_url":"https://api.github.com/users/franciscocpg/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\n\r\nCloses #4280 \r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\n\r\nAdding typescript extensions to webpack resolve\r\n\r\n\r\n## How can we verify it:\r\n\r\nCreate a typescript project using `aws-nodejs-typescript` template from this PR, add a new typescript (`.ts`) module file and try to import it using something like `import typescript_module from './typescript_file'`.\r\nBefore this PR one needs to add the file extension for this to work, eg: `import typescript_module from './typescript_file.ts'`.\r\n\r\nI am also upgrading dependencies.\r\n\r\n## Todos:\r\n\r\n- [ ] Write tests\r\n- [ ] Write documentation\r\n- [x] Fix linting errors\r\n- [ ] Make sure code coverage hasn't dropped\r\n- [ ] Provide verification config / commands / resources\r\n- [x] Enable \"Allow edits from maintainers\" for this PR\r\n- [x] Update the messages below\r\n\r\n***Is this ready for review?:*** YES\r\n***Is it a breaking change?:*** NO\r\n","created_at":"2017-09-18T21:53:27Z","updated_at":"2017-09-18T22:37:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f71cc0702d62d18dbf922bdfce2d245b9cef10d6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/4281/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/4281/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/4281/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/cd33957793a3bfa0d8c32e6338c3c477c0507bbe","head":{"label":"franciscocpg:import-ts-files-without-extension","ref":"import-ts-files-without-extension","sha":"cd33957793a3bfa0d8c32e6338c3c477c0507bbe","user":{"login":"franciscocpg","id":3680556,"avatar_url":"https://avatars1.githubusercontent.com/u/3680556?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscocpg","html_url":"https://github.com/franciscocpg","followers_url":"https://api.github.com/users/franciscocpg/followers","following_url":"https://api.github.com/users/franciscocpg/following{/other_user}","gists_url":"https://api.github.com/users/franciscocpg/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscocpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscocpg/subscriptions","organizations_url":"https://api.github.com/users/franciscocpg/orgs","repos_url":"https://api.github.com/users/franciscocpg/repos","events_url":"https://api.github.com/users/franciscocpg/events{/privacy}","received_events_url":"https://api.github.com/users/franciscocpg/received_events","type":"User","site_admin":false},"repo":{"id":99673689,"name":"serverless","full_name":"franciscocpg/serverless","owner":{"login":"franciscocpg","id":3680556,"avatar_url":"https://avatars1.githubusercontent.com/u/3680556?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscocpg","html_url":"https://github.com/franciscocpg","followers_url":"https://api.github.com/users/franciscocpg/followers","following_url":"https://api.github.com/users/franciscocpg/following{/other_user}","gists_url":"https://api.github.com/users/franciscocpg/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscocpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscocpg/subscriptions","organizations_url":"https://api.github.com/users/franciscocpg/orgs","repos_url":"https://api.github.com/users/franciscocpg/repos","events_url":"https://api.github.com/users/franciscocpg/events{/privacy}","received_events_url":"https://api.github.com/users/franciscocpg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/franciscocpg/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":true,"url":"https://api.github.com/repos/franciscocpg/serverless","forks_url":"https://api.github.com/repos/franciscocpg/serverless/forks","keys_url":"https://api.github.com/repos/franciscocpg/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/franciscocpg/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/franciscocpg/serverless/teams","hooks_url":"https://api.github.com/repos/franciscocpg/serverless/hooks","issue_events_url":"https://api.github.com/repos/franciscocpg/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/franciscocpg/serverless/events","assignees_url":"https://api.github.com/repos/franciscocpg/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/franciscocpg/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/franciscocpg/serverless/tags","blobs_url":"https://api.github.com/repos/franciscocpg/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/franciscocpg/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/franciscocpg/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/franciscocpg/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/franciscocpg/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/franciscocpg/serverless/languages","stargazers_url":"https://api.github.com/repos/franciscocpg/serverless/stargazers","contributors_url":"https://api.github.com/repos/franciscocpg/serverless/contributors","subscribers_url":"https://api.github.com/repos/franciscocpg/serverless/subscribers","subscription_url":"https://api.github.com/repos/franciscocpg/serverless/subscription","commits_url":"https://api.github.com/repos/franciscocpg/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/franciscocpg/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/franciscocpg/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/franciscocpg/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/franciscocpg/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/franciscocpg/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/franciscocpg/serverless/merges","archive_url":"https://api.github.com/repos/franciscocpg/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/franciscocpg/serverless/downloads","issues_url":"https://api.github.com/repos/franciscocpg/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/franciscocpg/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/franciscocpg/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/franciscocpg/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/franciscocpg/serverless/labels{/name}","releases_url":"https://api.github.com/repos/franciscocpg/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/franciscocpg/serverless/deployments","created_at":"2017-08-08T09:11:44Z","updated_at":"2017-08-08T09:11:48Z","pushed_at":"2017-09-18T22:36:51Z","git_url":"git://github.com/franciscocpg/serverless.git","ssh_url":"[email protected]:franciscocpg/serverless.git","clone_url":"https://github.com/franciscocpg/serverless.git","svn_url":"https://github.com/franciscocpg/serverless","homepage":"http://www.serverless.com","size":75368,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"7893bc95e6fb3a6ba36fa6a4803c98c896c81196","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars0.githubusercontent.com/u/13742415?v=4","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2017-09-18T22:22:59Z","pushed_at":"2017-09-18T22:36:54Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"[email protected]:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":77069,"stargazers_count":19135,"watchers_count":19135,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1940,"mirror_url":null,"open_issues_count":347,"forks":1940,"open_issues":347,"watchers":19135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/4281"},"html":{"href":"https://github.com/serverless/serverless/pull/4281"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/4281"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/4281/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/4281/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/4281/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/cd33957793a3bfa0d8c32e6338c3c477c0507bbe"}},"author_association":"CONTRIBUTOR"}} | {
"id": 34302698,
"name": "serverless/serverless",
"url": "https://api.github.com/repos/serverless/serverless"
} | {
"id": 3680556,
"login": "franciscocpg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3680556?",
"url": "https://api.github.com/users/franciscocpg"
} | {
"id": 13742415,
"login": "serverless",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13742415?",
"url": "https://api.github.com/orgs/serverless"
} | 2017-09-18T22:37:53 | 6606191701 | {"actor":{"display_login":"franciscocpg"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/comments/135684203","pull_request_review_id":59121007,"id":135684203,"diff_hunk":"@@ -47,8 +47,9 @@ const applyListenerCallbacks = (retroChannel, store, actions) => {\n actions.deleteIdea(deletedIdea.id)\n })\n \n- retroChannel.on(\"vote_submitted\", votedOnIdea => {\n- actions.updateIdea(votedOnIdea.id, { vote_count: votedOnIdea.vote_count })\n+ retroChannel.on(\"vote_submitted\", data => {\n+ actions.updateIdea(data.idea.id, { vote_count: data.idea.vote_count })","path":"web/static/js/services/retro_channel.js","position":7,"original_position":7,"commit_id":"2cddfcf736281a269f2400c436ba3a37796a1034","original_commit_id":"2cddfcf736281a269f2400c436ba3a37796a1034","user":{"login":"vanderhoop","id":4386645,"avatar_url":"https://avatars1.githubusercontent.com/u/4386645?v=4","gravatar_id":"","url":"https://api.github.com/users/vanderhoop","html_url":"https://github.com/vanderhoop","followers_url":"https://api.github.com/users/vanderhoop/followers","following_url":"https://api.github.com/users/vanderhoop/following{/other_user}","gists_url":"https://api.github.com/users/vanderhoop/gists{/gist_id}","starred_url":"https://api.github.com/users/vanderhoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanderhoop/subscriptions","organizations_url":"https://api.github.com/users/vanderhoop/orgs","repos_url":"https://api.github.com/users/vanderhoop/repos","events_url":"https://api.github.com/users/vanderhoop/events{/privacy}","received_events_url":"https://api.github.com/users/vanderhoop/received_events","type":"User","site_admin":false},"body":"@qlaire @ams340 while you're on the bench, can you keep your noses primed for this dual state/action spell propagating throughout the app. @kpthomas pinging you as well, as i'm guessing you thought of this when you did the initial persistence work with Claire a couple weeks ago.","created_at":"2017-08-29T03:05:10Z","updated_at":"2017-08-29T03:05:10Z","html_url":"https://github.com/stride-nyc/remote_retro/pull/271#discussion_r135684203","pull_request_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/comments/135684203"},"html":{"href":"https://github.com/stride-nyc/remote_retro/pull/271#discussion_r135684203"},"pull_request":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/271"}},"in_reply_to_id":135683913},"pull_request":{"url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/271","id":138017732,"html_url":"https://github.com/stride-nyc/remote_retro/pull/271","diff_url":"https://github.com/stride-nyc/remote_retro/pull/271.diff","patch_url":"https://github.com/stride-nyc/remote_retro/pull/271.patch","issue_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/271","number":271,"state":"open","locked":false,"title":"Feature/limit user to five votes","user":{"login":"qlaire","id":12402436,"avatar_url":"https://avatars0.githubusercontent.com/u/12402436?v=4","gravatar_id":"","url":"https://api.github.com/users/qlaire","html_url":"https://github.com/qlaire","followers_url":"https://api.github.com/users/qlaire/followers","following_url":"https://api.github.com/users/qlaire/following{/other_user}","gists_url":"https://api.github.com/users/qlaire/gists{/gist_id}","starred_url":"https://api.github.com/users/qlaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlaire/subscriptions","organizations_url":"https://api.github.com/users/qlaire/orgs","repos_url":"https://api.github.com/users/qlaire/repos","events_url":"https://api.github.com/users/qlaire/events{/privacy}","received_events_url":"https://api.github.com/users/qlaire/received_events","type":"User","site_admin":false},"body":"__Description of Change(s) Introduced:__ \r\nA user can now vote only 5 times per retro. \r\n\r\n__Dependencies Introduced or Upgraded:__ (if applicable): \r\nUpgraded enzyme and added prop-types to replace deprecated React.PropTypes and react-test-renderer to fix linting error\r\n\r\n- (Dependency) - (current version number): \r\nprop-types 15.5.10, enzyme 2.9.1, and react-test-renderer 15.6.1\r\n\r\n__Description of Testing Applied:__ \r\nFrontend tests for reducer and ensuring button is disabled when user has voted 5 times.\r\nBackend validation tests to ensure vote count is between 0 and 5\r\n\r\n__Relevant github Issue:__ \r\n\r\n- #236 \r\n","created_at":"2017-08-28T19:21:34Z","updated_at":"2017-08-29T03:05:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dcbbfb928b9b9d9b294c40baa972a73188cb1e9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/271/commits","review_comments_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/271/comments","review_comment_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/271/comments","statuses_url":"https://api.github.com/repos/stride-nyc/remote_retro/statuses/2cddfcf736281a269f2400c436ba3a37796a1034","head":{"label":"stride-nyc:feature/limit-user-to-five-votes","ref":"feature/limit-user-to-five-votes","sha":"2cddfcf736281a269f2400c436ba3a37796a1034","user":{"login":"stride-nyc","id":8702428,"avatar_url":"https://avatars3.githubusercontent.com/u/8702428?v=4","gravatar_id":"","url":"https://api.github.com/users/stride-nyc","html_url":"https://github.com/stride-nyc","followers_url":"https://api.github.com/users/stride-nyc/followers","following_url":"https://api.github.com/users/stride-nyc/following{/other_user}","gists_url":"https://api.github.com/users/stride-nyc/gists{/gist_id}","starred_url":"https://api.github.com/users/stride-nyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride-nyc/subscriptions","organizations_url":"https://api.github.com/users/stride-nyc/orgs","repos_url":"https://api.github.com/users/stride-nyc/repos","events_url":"https://api.github.com/users/stride-nyc/events{/privacy}","received_events_url":"https://api.github.com/users/stride-nyc/received_events","type":"Organization","site_admin":false},"repo":{"id":76188623,"name":"remote_retro","full_name":"stride-nyc/remote_retro","owner":{"login":"stride-nyc","id":8702428,"avatar_url":"https://avatars3.githubusercontent.com/u/8702428?v=4","gravatar_id":"","url":"https://api.github.com/users/stride-nyc","html_url":"https://github.com/stride-nyc","followers_url":"https://api.github.com/users/stride-nyc/followers","following_url":"https://api.github.com/users/stride-nyc/following{/other_user}","gists_url":"https://api.github.com/users/stride-nyc/gists{/gist_id}","starred_url":"https://api.github.com/users/stride-nyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride-nyc/subscriptions","organizations_url":"https://api.github.com/users/stride-nyc/orgs","repos_url":"https://api.github.com/users/stride-nyc/repos","events_url":"https://api.github.com/users/stride-nyc/events{/privacy}","received_events_url":"https://api.github.com/users/stride-nyc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stride-nyc/remote_retro","description":"A real-time application for conducting Agile retrospectives ","fork":false,"url":"https://api.github.com/repos/stride-nyc/remote_retro","forks_url":"https://api.github.com/repos/stride-nyc/remote_retro/forks","keys_url":"https://api.github.com/repos/stride-nyc/remote_retro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stride-nyc/remote_retro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stride-nyc/remote_retro/teams","hooks_url":"https://api.github.com/repos/stride-nyc/remote_retro/hooks","issue_events_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/events{/number}","events_url":"https://api.github.com/repos/stride-nyc/remote_retro/events","assignees_url":"https://api.github.com/repos/stride-nyc/remote_retro/assignees{/user}","branches_url":"https://api.github.com/repos/stride-nyc/remote_retro/branches{/branch}","tags_url":"https://api.github.com/repos/stride-nyc/remote_retro/tags","blobs_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/refs{/sha}","trees_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stride-nyc/remote_retro/statuses/{sha}","languages_url":"https://api.github.com/repos/stride-nyc/remote_retro/languages","stargazers_url":"https://api.github.com/repos/stride-nyc/remote_retro/stargazers","contributors_url":"https://api.github.com/repos/stride-nyc/remote_retro/contributors","subscribers_url":"https://api.github.com/repos/stride-nyc/remote_retro/subscribers","subscription_url":"https://api.github.com/repos/stride-nyc/remote_retro/subscription","commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/commits{/sha}","git_commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/commits{/sha}","comments_url":"https://api.github.com/repos/stride-nyc/remote_retro/comments{/number}","issue_comment_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/comments{/number}","contents_url":"https://api.github.com/repos/stride-nyc/remote_retro/contents/{+path}","compare_url":"https://api.github.com/repos/stride-nyc/remote_retro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stride-nyc/remote_retro/merges","archive_url":"https://api.github.com/repos/stride-nyc/remote_retro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stride-nyc/remote_retro/downloads","issues_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues{/number}","pulls_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls{/number}","milestones_url":"https://api.github.com/repos/stride-nyc/remote_retro/milestones{/number}","notifications_url":"https://api.github.com/repos/stride-nyc/remote_retro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stride-nyc/remote_retro/labels{/name}","releases_url":"https://api.github.com/repos/stride-nyc/remote_retro/releases{/id}","deployments_url":"https://api.github.com/repos/stride-nyc/remote_retro/deployments","created_at":"2016-12-11T17:21:02Z","updated_at":"2017-08-13T13:49:29Z","pushed_at":"2017-08-28T19:27:39Z","git_url":"git://github.com/stride-nyc/remote_retro.git","ssh_url":"[email protected]:stride-nyc/remote_retro.git","clone_url":"https://github.com/stride-nyc/remote_retro.git","svn_url":"https://github.com/stride-nyc/remote_retro","homepage":"https://remoteretro.herokuapp.com/","size":2597,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":67,"forks":15,"open_issues":67,"watchers":75,"default_branch":"master"}},"base":{"label":"stride-nyc:master","ref":"master","sha":"0b24515e138000bc2a7d9be14e59484b2d538c78","user":{"login":"stride-nyc","id":8702428,"avatar_url":"https://avatars3.githubusercontent.com/u/8702428?v=4","gravatar_id":"","url":"https://api.github.com/users/stride-nyc","html_url":"https://github.com/stride-nyc","followers_url":"https://api.github.com/users/stride-nyc/followers","following_url":"https://api.github.com/users/stride-nyc/following{/other_user}","gists_url":"https://api.github.com/users/stride-nyc/gists{/gist_id}","starred_url":"https://api.github.com/users/stride-nyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride-nyc/subscriptions","organizations_url":"https://api.github.com/users/stride-nyc/orgs","repos_url":"https://api.github.com/users/stride-nyc/repos","events_url":"https://api.github.com/users/stride-nyc/events{/privacy}","received_events_url":"https://api.github.com/users/stride-nyc/received_events","type":"Organization","site_admin":false},"repo":{"id":76188623,"name":"remote_retro","full_name":"stride-nyc/remote_retro","owner":{"login":"stride-nyc","id":8702428,"avatar_url":"https://avatars3.githubusercontent.com/u/8702428?v=4","gravatar_id":"","url":"https://api.github.com/users/stride-nyc","html_url":"https://github.com/stride-nyc","followers_url":"https://api.github.com/users/stride-nyc/followers","following_url":"https://api.github.com/users/stride-nyc/following{/other_user}","gists_url":"https://api.github.com/users/stride-nyc/gists{/gist_id}","starred_url":"https://api.github.com/users/stride-nyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride-nyc/subscriptions","organizations_url":"https://api.github.com/users/stride-nyc/orgs","repos_url":"https://api.github.com/users/stride-nyc/repos","events_url":"https://api.github.com/users/stride-nyc/events{/privacy}","received_events_url":"https://api.github.com/users/stride-nyc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stride-nyc/remote_retro","description":"A real-time application for conducting Agile retrospectives ","fork":false,"url":"https://api.github.com/repos/stride-nyc/remote_retro","forks_url":"https://api.github.com/repos/stride-nyc/remote_retro/forks","keys_url":"https://api.github.com/repos/stride-nyc/remote_retro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stride-nyc/remote_retro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stride-nyc/remote_retro/teams","hooks_url":"https://api.github.com/repos/stride-nyc/remote_retro/hooks","issue_events_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/events{/number}","events_url":"https://api.github.com/repos/stride-nyc/remote_retro/events","assignees_url":"https://api.github.com/repos/stride-nyc/remote_retro/assignees{/user}","branches_url":"https://api.github.com/repos/stride-nyc/remote_retro/branches{/branch}","tags_url":"https://api.github.com/repos/stride-nyc/remote_retro/tags","blobs_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/refs{/sha}","trees_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stride-nyc/remote_retro/statuses/{sha}","languages_url":"https://api.github.com/repos/stride-nyc/remote_retro/languages","stargazers_url":"https://api.github.com/repos/stride-nyc/remote_retro/stargazers","contributors_url":"https://api.github.com/repos/stride-nyc/remote_retro/contributors","subscribers_url":"https://api.github.com/repos/stride-nyc/remote_retro/subscribers","subscription_url":"https://api.github.com/repos/stride-nyc/remote_retro/subscription","commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/commits{/sha}","git_commits_url":"https://api.github.com/repos/stride-nyc/remote_retro/git/commits{/sha}","comments_url":"https://api.github.com/repos/stride-nyc/remote_retro/comments{/number}","issue_comment_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues/comments{/number}","contents_url":"https://api.github.com/repos/stride-nyc/remote_retro/contents/{+path}","compare_url":"https://api.github.com/repos/stride-nyc/remote_retro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stride-nyc/remote_retro/merges","archive_url":"https://api.github.com/repos/stride-nyc/remote_retro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stride-nyc/remote_retro/downloads","issues_url":"https://api.github.com/repos/stride-nyc/remote_retro/issues{/number}","pulls_url":"https://api.github.com/repos/stride-nyc/remote_retro/pulls{/number}","milestones_url":"https://api.github.com/repos/stride-nyc/remote_retro/milestones{/number}","notifications_url":"https://api.github.com/repos/stride-nyc/remote_retro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stride-nyc/remote_retro/labels{/name}","releases_url":"https://api.github.com/repos/stride-nyc/remote_retro/releases{/id}","deployments_url":"https://api.github.com/repos/stride-nyc/remote_retro/deployments","created_at":"2016-12-11T17:21:02Z","updated_at":"2017-08-13T13:49:29Z","pushed_at":"2017-08-28T19:27:39Z","git_url":"git://github.com/stride-nyc/remote_retro.git","ssh_url":"[email protected]:stride-nyc/remote_retro.git","clone_url":"https://github.com/stride-nyc/remote_retro.git","svn_url":"https://github.com/stride-nyc/remote_retro","homepage":"https://remoteretro.herokuapp.com/","size":2597,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":67,"forks":15,"open_issues":67,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/271"},"html":{"href":"https://github.com/stride-nyc/remote_retro/pull/271"},"issue":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/issues/271"},"comments":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/stride-nyc/remote_retro/statuses/2cddfcf736281a269f2400c436ba3a37796a1034"}}}} | {
"id": 76188623,
"name": "stride-nyc/remote_retro",
"url": "https://api.github.com/repos/stride-nyc/remote_retro"
} | {
"id": 4386645,
"login": "vanderhoop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4386645?",
"url": "https://api.github.com/users/vanderhoop"
} | {
"id": 8702428,
"login": "stride-nyc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8702428?",
"url": "https://api.github.com/orgs/stride-nyc"
} | 2017-08-29T03:05:10 | 6522523432 | {"actor":{"display_login":"vanderhoop"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/comments/115806818","pull_request_review_id":37378525,"id":115806818,"diff_hunk":"@@ -112,6 +112,37 @@ describe('cloudant connector', function() {\n };\n });\n });\n+\n+ describe('updateOrCreate', function() {\n+ afterEach(function(done) {\n+ Product.destroyById(1, function(err) {\n+ if (err) return done(err);\n+ done();","path":"test/cloudant.test.js","position":9,"original_position":9,"commit_id":"6db9e7c2d4aecf3c0959f5b2b79c880264c90bba","original_commit_id":"6db9e7c2d4aecf3c0959f5b2b79c880264c90bba","user":{"login":"Amir-61","id":10672146,"avatar_url":"https://avatars1.githubusercontent.com/u/10672146?v=3","gravatar_id":"","url":"https://api.github.com/users/Amir-61","html_url":"https://github.com/Amir-61","followers_url":"https://api.github.com/users/Amir-61/followers","following_url":"https://api.github.com/users/Amir-61/following{/other_user}","gists_url":"https://api.github.com/users/Amir-61/gists{/gist_id}","starred_url":"https://api.github.com/users/Amir-61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amir-61/subscriptions","organizations_url":"https://api.github.com/users/Amir-61/orgs","repos_url":"https://api.github.com/users/Amir-61/repos","events_url":"https://api.github.com/users/Amir-61/events{/privacy}","received_events_url":"https://api.github.com/users/Amir-61/received_events","type":"User","site_admin":false},"body":"Instead of:\r\n```\r\nif (err) return done(err);\r\ndone();\r\n```\r\n\r\nJust the following line is enough:\r\n```\r\ndone(err)\r\n```","created_at":"2017-05-10T17:46:54Z","updated_at":"2017-05-10T17:53:37Z","html_url":"https://github.com/strongloop/loopback-connector-cloudant/pull/129#discussion_r115806818","pull_request_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/comments/115806818"},"html":{"href":"https://github.com/strongloop/loopback-connector-cloudant/pull/129#discussion_r115806818"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/129","id":119764325,"html_url":"https://github.com/strongloop/loopback-connector-cloudant/pull/129","diff_url":"https://github.com/strongloop/loopback-connector-cloudant/pull/129.diff","patch_url":"https://github.com/strongloop/loopback-connector-cloudant/pull/129.patch","issue_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/issues/129","number":129,"state":"open","locked":false,"title":"1.x fix/upsert","user":{"login":"jannyHou","id":12554153,"avatar_url":"https://avatars3.githubusercontent.com/u/12554153?v=3","gravatar_id":"","url":"https://api.github.com/users/jannyHou","html_url":"https://github.com/jannyHou","followers_url":"https://api.github.com/users/jannyHou/followers","following_url":"https://api.github.com/users/jannyHou/following{/other_user}","gists_url":"https://api.github.com/users/jannyHou/gists{/gist_id}","starred_url":"https://api.github.com/users/jannyHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannyHou/subscriptions","organizations_url":"https://api.github.com/users/jannyHou/orgs","repos_url":"https://api.github.com/users/jannyHou/repos","events_url":"https://api.github.com/users/jannyHou/events{/privacy}","received_events_url":"https://api.github.com/users/jannyHou/received_events","type":"User","site_admin":false},"body":"related to https://github.com/strongloop/loopback-connector-cloudant/pull/111","created_at":"2017-05-09T22:04:38Z","updated_at":"2017-05-10T17:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1c3ddb8940c7c6117a9c966f1c79433e2bb23bf","assignee":{"login":"jannyHou","id":12554153,"avatar_url":"https://avatars3.githubusercontent.com/u/12554153?v=3","gravatar_id":"","url":"https://api.github.com/users/jannyHou","html_url":"https://github.com/jannyHou","followers_url":"https://api.github.com/users/jannyHou/followers","following_url":"https://api.github.com/users/jannyHou/following{/other_user}","gists_url":"https://api.github.com/users/jannyHou/gists{/gist_id}","starred_url":"https://api.github.com/users/jannyHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannyHou/subscriptions","organizations_url":"https://api.github.com/users/jannyHou/orgs","repos_url":"https://api.github.com/users/jannyHou/repos","events_url":"https://api.github.com/users/jannyHou/events{/privacy}","received_events_url":"https://api.github.com/users/jannyHou/received_events","type":"User","site_admin":false},"assignees":[{"login":"jannyHou","id":12554153,"avatar_url":"https://avatars3.githubusercontent.com/u/12554153?v=3","gravatar_id":"","url":"https://api.github.com/users/jannyHou","html_url":"https://github.com/jannyHou","followers_url":"https://api.github.com/users/jannyHou/followers","following_url":"https://api.github.com/users/jannyHou/following{/other_user}","gists_url":"https://api.github.com/users/jannyHou/gists{/gist_id}","starred_url":"https://api.github.com/users/jannyHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannyHou/subscriptions","organizations_url":"https://api.github.com/users/jannyHou/orgs","repos_url":"https://api.github.com/users/jannyHou/repos","events_url":"https://api.github.com/users/jannyHou/events{/privacy}","received_events_url":"https://api.github.com/users/jannyHou/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/129/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/129/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/issues/129/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/statuses/6db9e7c2d4aecf3c0959f5b2b79c880264c90bba","head":{"label":"djorg83:1.x-fix/upsert","ref":"1.x-fix/upsert","sha":"6db9e7c2d4aecf3c0959f5b2b79c880264c90bba","user":{"login":"djorg83","id":3258109,"avatar_url":"https://avatars3.githubusercontent.com/u/3258109?v=3","gravatar_id":"","url":"https://api.github.com/users/djorg83","html_url":"https://github.com/djorg83","followers_url":"https://api.github.com/users/djorg83/followers","following_url":"https://api.github.com/users/djorg83/following{/other_user}","gists_url":"https://api.github.com/users/djorg83/gists{/gist_id}","starred_url":"https://api.github.com/users/djorg83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djorg83/subscriptions","organizations_url":"https://api.github.com/users/djorg83/orgs","repos_url":"https://api.github.com/users/djorg83/repos","events_url":"https://api.github.com/users/djorg83/events{/privacy}","received_events_url":"https://api.github.com/users/djorg83/received_events","type":"User","site_admin":false},"repo":{"id":89526414,"name":"loopback-connector-cloudant","full_name":"djorg83/loopback-connector-cloudant","owner":{"login":"djorg83","id":3258109,"avatar_url":"https://avatars3.githubusercontent.com/u/3258109?v=3","gravatar_id":"","url":"https://api.github.com/users/djorg83","html_url":"https://github.com/djorg83","followers_url":"https://api.github.com/users/djorg83/followers","following_url":"https://api.github.com/users/djorg83/following{/other_user}","gists_url":"https://api.github.com/users/djorg83/gists{/gist_id}","starred_url":"https://api.github.com/users/djorg83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djorg83/subscriptions","organizations_url":"https://api.github.com/users/djorg83/orgs","repos_url":"https://api.github.com/users/djorg83/repos","events_url":"https://api.github.com/users/djorg83/events{/privacy}","received_events_url":"https://api.github.com/users/djorg83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djorg83/loopback-connector-cloudant","description":"LoopBack Connector for IBM Cloudant","fork":true,"url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant","forks_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/forks","keys_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/teams","hooks_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/hooks","issue_events_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/issues/events{/number}","events_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/events","assignees_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/assignees{/user}","branches_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/branches{/branch}","tags_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/tags","blobs_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/git/refs{/sha}","trees_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/statuses/{sha}","languages_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/languages","stargazers_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/stargazers","contributors_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/contributors","subscribers_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/subscribers","subscription_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/subscription","commits_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/commits{/sha}","git_commits_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/git/commits{/sha}","comments_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/comments{/number}","issue_comment_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/issues/comments{/number}","contents_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/contents/{+path}","compare_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/merges","archive_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/downloads","issues_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/issues{/number}","pulls_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/pulls{/number}","milestones_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/milestones{/number}","notifications_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/labels{/name}","releases_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/releases{/id}","deployments_url":"https://api.github.com/repos/djorg83/loopback-connector-cloudant/deployments","created_at":"2017-04-26T21:03:49Z","updated_at":"2017-04-26T21:03:51Z","pushed_at":"2017-05-09T22:12:33Z","git_url":"git://github.com/djorg83/loopback-connector-cloudant.git","ssh_url":"[email protected]:djorg83/loopback-connector-cloudant.git","clone_url":"https://github.com/djorg83/loopback-connector-cloudant.git","svn_url":"https://github.com/djorg83/loopback-connector-cloudant","homepage":null,"size":178,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strongloop:1.x","ref":"1.x","sha":"3263602c9989839dede9c16a2e47bb27f70845c1","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars2.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":46471687,"name":"loopback-connector-cloudant","full_name":"strongloop/loopback-connector-cloudant","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars2.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-connector-cloudant","description":"LoopBack Connector for IBM Cloudant","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant","forks_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/deployments","created_at":"2015-11-19T06:12:17Z","updated_at":"2017-04-04T18:20:33Z","pushed_at":"2017-05-10T16:05:59Z","git_url":"git://github.com/strongloop/loopback-connector-cloudant.git","ssh_url":"[email protected]:strongloop/loopback-connector-cloudant.git","clone_url":"https://github.com/strongloop/loopback-connector-cloudant.git","svn_url":"https://github.com/strongloop/loopback-connector-cloudant","homepage":null,"size":175,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":30,"forks":12,"open_issues":30,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/129"},"html":{"href":"https://github.com/strongloop/loopback-connector-cloudant/pull/129"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/issues/129"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback-connector-cloudant/statuses/6db9e7c2d4aecf3c0959f5b2b79c880264c90bba"}}}} | {
"id": 46471687,
"name": "strongloop/loopback-connector-cloudant",
"url": "https://api.github.com/repos/strongloop/loopback-connector-cloudant"
} | {
"id": 10672146,
"login": "Amir-61",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10672146?",
"url": "https://api.github.com/users/Amir-61"
} | {
"id": 3020012,
"login": "strongloop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3020012?",
"url": "https://api.github.com/orgs/strongloop"
} | 2017-05-10T17:46:54 | 5847182268 | {"actor":{"display_login":"Amir-61"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/magenta/pulls/comments/99697169","pull_request_review_id":20381939,"id":99697169,"diff_hunk":"@@ -89,7 +89,9 @@\n tf.app.flags.DEFINE_integer(\n 'temperature_control_number',\n None,\n- 'The control change number to use for controlling softmax temperature.')\n+ 'The control change number to use for controlling softmax temperature.'\n+ 'This should be an integer between 0 and 127 corresponding to a softmax '\n+ 'temperature between 0.1 and 2.')","path":"magenta/interfaces/midi/magenta_midi.py","position":7,"original_position":7,"commit_id":"52d5d82dc571d82fbbdff8c9466419b9210db536","original_commit_id":"52d5d82dc571d82fbbdff8c9466419b9210db536","user":{"login":"korymath","id":178099,"avatar_url":"https://avatars.githubusercontent.com/u/178099?v=3","gravatar_id":"","url":"https://api.github.com/users/korymath","html_url":"https://github.com/korymath","followers_url":"https://api.github.com/users/korymath/followers","following_url":"https://api.github.com/users/korymath/following{/other_user}","gists_url":"https://api.github.com/users/korymath/gists{/gist_id}","starred_url":"https://api.github.com/users/korymath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korymath/subscriptions","organizations_url":"https://api.github.com/users/korymath/orgs","repos_url":"https://api.github.com/users/korymath/repos","events_url":"https://api.github.com/users/korymath/events{/privacy}","received_events_url":"https://api.github.com/users/korymath/received_events","type":"User","site_admin":false},"body":"Love it. That makes much more sense and should help temperature fiddlers, like myself, to work with this interface. I will propose that change ASAP.","created_at":"2017-02-06T22:07:26Z","updated_at":"2017-02-06T22:07:26Z","html_url":"https://github.com/tensorflow/magenta/pull/510#discussion_r99697169","pull_request_url":"https://api.github.com/repos/tensorflow/magenta/pulls/510","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/magenta/pulls/comments/99697169"},"html":{"href":"https://github.com/tensorflow/magenta/pull/510#discussion_r99697169"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/magenta/pulls/510"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/magenta/pulls/510","id":104231946,"html_url":"https://github.com/tensorflow/magenta/pull/510","diff_url":"https://github.com/tensorflow/magenta/pull/510.diff","patch_url":"https://github.com/tensorflow/magenta/pull/510.patch","issue_url":"https://api.github.com/repos/tensorflow/magenta/issues/510","number":510,"state":"open","locked":false,"title":"Adding ranges for the softmax temperature control.","user":{"login":"korymath","id":178099,"avatar_url":"https://avatars.githubusercontent.com/u/178099?v=3","gravatar_id":"","url":"https://api.github.com/users/korymath","html_url":"https://github.com/korymath","followers_url":"https://api.github.com/users/korymath/followers","following_url":"https://api.github.com/users/korymath/following{/other_user}","gists_url":"https://api.github.com/users/korymath/gists{/gist_id}","starred_url":"https://api.github.com/users/korymath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korymath/subscriptions","organizations_url":"https://api.github.com/users/korymath/orgs","repos_url":"https://api.github.com/users/korymath/repos","events_url":"https://api.github.com/users/korymath/events{/privacy}","received_events_url":"https://api.github.com/users/korymath/received_events","type":"User","site_admin":false},"body":"The temperature_control_number on magenta_midi represents a temperature, but the range is not immediately clear. By adding details in the flag definition users can more easily understand how to tune the temperature.","created_at":"2017-02-01T22:03:21Z","updated_at":"2017-02-06T22:07:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b5d4186eea5b7b44ec2dbb85b0bac9af12f0112","assignee":{"login":"adarob","id":1088232,"avatar_url":"https://avatars.githubusercontent.com/u/1088232?v=3","gravatar_id":"","url":"https://api.github.com/users/adarob","html_url":"https://github.com/adarob","followers_url":"https://api.github.com/users/adarob/followers","following_url":"https://api.github.com/users/adarob/following{/other_user}","gists_url":"https://api.github.com/users/adarob/gists{/gist_id}","starred_url":"https://api.github.com/users/adarob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adarob/subscriptions","organizations_url":"https://api.github.com/users/adarob/orgs","repos_url":"https://api.github.com/users/adarob/repos","events_url":"https://api.github.com/users/adarob/events{/privacy}","received_events_url":"https://api.github.com/users/adarob/received_events","type":"User","site_admin":false},"assignees":[{"login":"adarob","id":1088232,"avatar_url":"https://avatars.githubusercontent.com/u/1088232?v=3","gravatar_id":"","url":"https://api.github.com/users/adarob","html_url":"https://github.com/adarob","followers_url":"https://api.github.com/users/adarob/followers","following_url":"https://api.github.com/users/adarob/following{/other_user}","gists_url":"https://api.github.com/users/adarob/gists{/gist_id}","starred_url":"https://api.github.com/users/adarob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adarob/subscriptions","organizations_url":"https://api.github.com/users/adarob/orgs","repos_url":"https://api.github.com/users/adarob/repos","events_url":"https://api.github.com/users/adarob/events{/privacy}","received_events_url":"https://api.github.com/users/adarob/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/magenta/pulls/510/commits","review_comments_url":"https://api.github.com/repos/tensorflow/magenta/pulls/510/comments","review_comment_url":"https://api.github.com/repos/tensorflow/magenta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/magenta/issues/510/comments","statuses_url":"https://api.github.com/repos/tensorflow/magenta/statuses/52d5d82dc571d82fbbdff8c9466419b9210db536","head":{"label":"korymath:patch-1","ref":"patch-1","sha":"52d5d82dc571d82fbbdff8c9466419b9210db536","user":{"login":"korymath","id":178099,"avatar_url":"https://avatars.githubusercontent.com/u/178099?v=3","gravatar_id":"","url":"https://api.github.com/users/korymath","html_url":"https://github.com/korymath","followers_url":"https://api.github.com/users/korymath/followers","following_url":"https://api.github.com/users/korymath/following{/other_user}","gists_url":"https://api.github.com/users/korymath/gists{/gist_id}","starred_url":"https://api.github.com/users/korymath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korymath/subscriptions","organizations_url":"https://api.github.com/users/korymath/orgs","repos_url":"https://api.github.com/users/korymath/repos","events_url":"https://api.github.com/users/korymath/events{/privacy}","received_events_url":"https://api.github.com/users/korymath/received_events","type":"User","site_admin":false},"repo":{"id":80668833,"name":"magenta","full_name":"korymath/magenta","owner":{"login":"korymath","id":178099,"avatar_url":"https://avatars.githubusercontent.com/u/178099?v=3","gravatar_id":"","url":"https://api.github.com/users/korymath","html_url":"https://github.com/korymath","followers_url":"https://api.github.com/users/korymath/followers","following_url":"https://api.github.com/users/korymath/following{/other_user}","gists_url":"https://api.github.com/users/korymath/gists{/gist_id}","starred_url":"https://api.github.com/users/korymath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korymath/subscriptions","organizations_url":"https://api.github.com/users/korymath/orgs","repos_url":"https://api.github.com/users/korymath/repos","events_url":"https://api.github.com/users/korymath/events{/privacy}","received_events_url":"https://api.github.com/users/korymath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/korymath/magenta","description":"Magenta: Music and Art Generation with Machine Intelligence","fork":true,"url":"https://api.github.com/repos/korymath/magenta","forks_url":"https://api.github.com/repos/korymath/magenta/forks","keys_url":"https://api.github.com/repos/korymath/magenta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/korymath/magenta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/korymath/magenta/teams","hooks_url":"https://api.github.com/repos/korymath/magenta/hooks","issue_events_url":"https://api.github.com/repos/korymath/magenta/issues/events{/number}","events_url":"https://api.github.com/repos/korymath/magenta/events","assignees_url":"https://api.github.com/repos/korymath/magenta/assignees{/user}","branches_url":"https://api.github.com/repos/korymath/magenta/branches{/branch}","tags_url":"https://api.github.com/repos/korymath/magenta/tags","blobs_url":"https://api.github.com/repos/korymath/magenta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/korymath/magenta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/korymath/magenta/git/refs{/sha}","trees_url":"https://api.github.com/repos/korymath/magenta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/korymath/magenta/statuses/{sha}","languages_url":"https://api.github.com/repos/korymath/magenta/languages","stargazers_url":"https://api.github.com/repos/korymath/magenta/stargazers","contributors_url":"https://api.github.com/repos/korymath/magenta/contributors","subscribers_url":"https://api.github.com/repos/korymath/magenta/subscribers","subscription_url":"https://api.github.com/repos/korymath/magenta/subscription","commits_url":"https://api.github.com/repos/korymath/magenta/commits{/sha}","git_commits_url":"https://api.github.com/repos/korymath/magenta/git/commits{/sha}","comments_url":"https://api.github.com/repos/korymath/magenta/comments{/number}","issue_comment_url":"https://api.github.com/repos/korymath/magenta/issues/comments{/number}","contents_url":"https://api.github.com/repos/korymath/magenta/contents/{+path}","compare_url":"https://api.github.com/repos/korymath/magenta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/korymath/magenta/merges","archive_url":"https://api.github.com/repos/korymath/magenta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/korymath/magenta/downloads","issues_url":"https://api.github.com/repos/korymath/magenta/issues{/number}","pulls_url":"https://api.github.com/repos/korymath/magenta/pulls{/number}","milestones_url":"https://api.github.com/repos/korymath/magenta/milestones{/number}","notifications_url":"https://api.github.com/repos/korymath/magenta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/korymath/magenta/labels{/name}","releases_url":"https://api.github.com/repos/korymath/magenta/releases{/id}","deployments_url":"https://api.github.com/repos/korymath/magenta/deployments","created_at":"2017-02-01T22:00:39Z","updated_at":"2017-02-01T22:00:41Z","pushed_at":"2017-02-03T02:15:04Z","git_url":"git://github.com/korymath/magenta.git","ssh_url":"[email protected]:korymath/magenta.git","clone_url":"https://github.com/korymath/magenta.git","svn_url":"https://github.com/korymath/magenta","homepage":"","size":14783,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"868791ccbce5e673943795a5e7963b00cd60c613","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":58157629,"name":"magenta","full_name":"tensorflow/magenta","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/magenta","description":"Magenta: Music and Art Generation with Machine Intelligence","fork":false,"url":"https://api.github.com/repos/tensorflow/magenta","forks_url":"https://api.github.com/repos/tensorflow/magenta/forks","keys_url":"https://api.github.com/repos/tensorflow/magenta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/magenta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/magenta/teams","hooks_url":"https://api.github.com/repos/tensorflow/magenta/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/magenta/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/magenta/events","assignees_url":"https://api.github.com/repos/tensorflow/magenta/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/magenta/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/magenta/tags","blobs_url":"https://api.github.com/repos/tensorflow/magenta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/magenta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/magenta/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/magenta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/magenta/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/magenta/languages","stargazers_url":"https://api.github.com/repos/tensorflow/magenta/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/magenta/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/magenta/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/magenta/subscription","commits_url":"https://api.github.com/repos/tensorflow/magenta/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/magenta/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/magenta/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/magenta/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/magenta/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/magenta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/magenta/merges","archive_url":"https://api.github.com/repos/tensorflow/magenta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/magenta/downloads","issues_url":"https://api.github.com/repos/tensorflow/magenta/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/magenta/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/magenta/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/magenta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/magenta/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/magenta/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/magenta/deployments","created_at":"2016-05-05T20:10:40Z","updated_at":"2017-02-06T17:40:36Z","pushed_at":"2017-02-06T21:46:22Z","git_url":"git://github.com/tensorflow/magenta.git","ssh_url":"[email protected]:tensorflow/magenta.git","clone_url":"https://github.com/tensorflow/magenta.git","svn_url":"https://github.com/tensorflow/magenta","homepage":"","size":14783,"stargazers_count":4418,"watchers_count":4418,"language":"Jupyter Notebook","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":605,"mirror_url":null,"open_issues_count":40,"forks":605,"open_issues":40,"watchers":4418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/magenta/pulls/510"},"html":{"href":"https://github.com/tensorflow/magenta/pull/510"},"issue":{"href":"https://api.github.com/repos/tensorflow/magenta/issues/510"},"comments":{"href":"https://api.github.com/repos/tensorflow/magenta/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/magenta/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/magenta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/magenta/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/magenta/statuses/52d5d82dc571d82fbbdff8c9466419b9210db536"}}}} | {
"id": 58157629,
"name": "tensorflow/magenta",
"url": "https://api.github.com/repos/tensorflow/magenta"
} | {
"id": 178099,
"login": "korymath",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/178099?",
"url": "https://api.github.com/users/korymath"
} | {
"id": 15658638,
"login": "tensorflow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15658638?",
"url": "https://api.github.com/orgs/tensorflow"
} | 2017-02-06T22:07:26 | 5276024255 | {"actor":{"display_login":"korymath"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/130471427","pull_request_review_id":53350907,"id":130471427,"diff_hunk":"@@ -0,0 +1,64 @@\n+# Copyright 2017 The TensorFlow Authors. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+# ==============================================================================\n+\"\"\"Utilities to translate legacy protos to their modern equivalents.\"\"\"\n+\n+from __future__ import absolute_import\n+from __future__ import division\n+from __future__ import print_function\n+\n+import numpy as np\n+import tensorflow as tf\n+\n+from tensorboard.plugins.histogram import metadata as histogram_metadata\n+\n+\n+def translate_value(value):","path":"tensorboard/data_compat.py","position":27,"original_position":27,"commit_id":"bd066a216a354c99ae7df42e5206ff358b8b41f4","original_commit_id":"bd066a216a354c99ae7df42e5206ff358b8b41f4","user":{"login":"wchargin","id":4317806,"avatar_url":"https://avatars3.githubusercontent.com/u/4317806?v=4","gravatar_id":"","url":"https://api.github.com/users/wchargin","html_url":"https://github.com/wchargin","followers_url":"https://api.github.com/users/wchargin/followers","following_url":"https://api.github.com/users/wchargin/following{/other_user}","gists_url":"https://api.github.com/users/wchargin/gists{/gist_id}","starred_url":"https://api.github.com/users/wchargin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchargin/subscriptions","organizations_url":"https://api.github.com/users/wchargin/orgs","repos_url":"https://api.github.com/users/wchargin/repos","events_url":"https://api.github.com/users/wchargin/events{/privacy}","received_events_url":"https://api.github.com/users/wchargin/received_events","type":"User","site_admin":false},"body":"Okay.","created_at":"2017-07-31T21:47:59Z","updated_at":"2017-07-31T21:55:37Z","html_url":"https://github.com/tensorflow/tensorboard/pull/290#discussion_r130471427","pull_request_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/290","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/130471427"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/290#discussion_r130471427"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/290","id":132878998,"html_url":"https://github.com/tensorflow/tensorboard/pull/290","diff_url":"https://github.com/tensorflow/tensorboard/pull/290.diff","patch_url":"https://github.com/tensorflow/tensorboard/pull/290.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/290","number":290,"state":"open","locked":false,"title":"Introduce `data_compat`, legacy summary converter","user":{"login":"wchargin","id":4317806,"avatar_url":"https://avatars3.githubusercontent.com/u/4317806?v=4","gravatar_id":"","url":"https://api.github.com/users/wchargin","html_url":"https://github.com/wchargin","followers_url":"https://api.github.com/users/wchargin/followers","following_url":"https://api.github.com/users/wchargin/following{/other_user}","gists_url":"https://api.github.com/users/wchargin/gists{/gist_id}","starred_url":"https://api.github.com/users/wchargin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchargin/subscriptions","organizations_url":"https://api.github.com/users/wchargin/orgs","repos_url":"https://api.github.com/users/wchargin/repos","events_url":"https://api.github.com/users/wchargin/events{/privacy}","received_events_url":"https://api.github.com/users/wchargin/received_events","type":"User","site_admin":false},"body":"Summary:\r\nAs we move from using old-style summaries to using only tensor\r\nsummaries, we need to continue supporting the old formats. The only\r\nplugin that has been converted so far is the histogram plugin, and that\r\nplugin manages the compatibility itself. But it would be nicer to have a\r\nunified Event Translation Layer where we convert all the old-style\r\nevents to new-style events. Once we do this, plugin code will only have\r\nto deal with new-style events---which is especially attractive because\r\nit makes the plugins more copy-pastable.\r\n\r\nThis commit introduces `data_compat`, a module that will perform such\r\nconversions. This module will intercept events before the event\r\naccumulator processes them. This is forward-compatible with SQL mode:\r\nwe can simply call out to this module from the SQL loader instead of the\r\nevent accumulator. For now, `data_compat` converts histogram values and\r\nleaves everything else alone.\r\n\r\nI haven't connected this layer to the event accumulator because it has\r\nbreaking behavior for the distributions plugin, which depends on\r\nspecial-casing behavior in the accumulator. The plan to deal with that\r\nis to move the histogram compression logic out of the event accumulator\r\nand into the distributions plugin itself (so that compression is\r\nperformed on the fly instead of being precomputed).\r\n\r\nTest Plan:\r\nRun the included unit tests, which are comprehensive.\r\n\r\nAlso, apply the following patch:\r\n```diff\r\ndiff --git a/tensorboard/backend/event_processing/BUILD b/tensorboard/backend/event_processing/BUILD\r\nindex 3ae126f..4043ca2 100644\r\n--- a/tensorboard/backend/event_processing/BUILD\r\n+++ b/tensorboard/backend/event_processing/BUILD\r\n@@ -82,6 +82,7 @@ py_library(\r\n \":event_file_loader\",\r\n \":plugin_asset_util\",\r\n \":reservoir\",\r\n+ \"//tensorboard:data_compat\",\r\n \"//tensorboard:expect_tensorflow_installed\",\r\n \"//tensorboard/plugins/distribution:compressor\",\r\n ],\r\ndiff --git a/tensorboard/backend/event_processing/event_accumulator.py b/tensorboard/backend/event_processing/event_accumulator.py\r\nindex 65acc30..c588579 100644\r\n--- a/tensorboard/backend/event_processing/event_accumulator.py\r\n+++ b/tensorboard/backend/event_processing/event_accumulator.py\r\n@@ -23,6 +23,7 @@ import threading\r\n\r\n import tensorflow as tf\r\n\r\n+from tensorboard import data_compat\r\n from tensorboard.backend.event_processing import directory_watcher\r\n from tensorboard.backend.event_processing import event_file_loader\r\n from tensorboard.backend.event_processing import plugin_asset_util\r\n@@ -383,6 +384,8 @@ class EventAccumulator(object):\r\n self._tagged_metadata[tag] = event.tagged_run_metadata.run_metadata\r\n elif event.HasField('summary'):\r\n for value in event.summary.value:\r\n+ value = data_compat.translate_value(value)\r\n+\r\n if value.HasField('metadata'):\r\n tag = value.tag\r\n # We only store the first instance of the metadata. This check\r\n```\r\nVerify that the resulting TensorBoard instance has working histograms\r\nfrom both old- and new-style sources. (You can tell that the old-style\r\nhistograms have been converted because the reservoir sampling will be\r\nmore aggressive.) Note also that the distributions plugin is marked as\r\ninactive, and that the event accumulator tests fail.\r\n\r\nwchargin-branch: data-compat","created_at":"2017-07-28T01:40:59Z","updated_at":"2017-07-31T21:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ea682e6f344b782f4fc87109c342c8ae4de450f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/290/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/290/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/290/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/bd066a216a354c99ae7df42e5206ff358b8b41f4","head":{"label":"tensorflow:wchargin-data-compat","ref":"wchargin-data-compat","sha":"bd066a216a354c99ae7df42e5206ff358b8b41f4","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":91379993,"name":"tensorboard","full_name":"tensorflow/tensorboard","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorboard","forks_url":"https://api.github.com/repos/tensorflow/tensorboard/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorboard/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorboard/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorboard/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorboard/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorboard/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorboard/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorboard/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorboard/deployments","created_at":"2017-05-15T20:08:07Z","updated_at":"2017-07-31T12:13:53Z","pushed_at":"2017-07-31T20:43:35Z","git_url":"git://github.com/tensorflow/tensorboard.git","ssh_url":"[email protected]:tensorflow/tensorboard.git","clone_url":"https://github.com/tensorflow/tensorboard.git","svn_url":"https://github.com/tensorflow/tensorboard","homepage":null,"size":5994,"stargazers_count":195,"watchers_count":195,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":101,"forks":61,"open_issues":101,"watchers":195,"default_branch":"master"}},"base":{"label":"tensorflow:wchargin-show-display-name-and-description","ref":"wchargin-show-display-name-and-description","sha":"50452afd1b04f917721d7e787e9f99d5a5228937","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":91379993,"name":"tensorboard","full_name":"tensorflow/tensorboard","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorboard","forks_url":"https://api.github.com/repos/tensorflow/tensorboard/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorboard/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorboard/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorboard/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorboard/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorboard/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorboard/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorboard/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorboard/deployments","created_at":"2017-05-15T20:08:07Z","updated_at":"2017-07-31T12:13:53Z","pushed_at":"2017-07-31T20:43:35Z","git_url":"git://github.com/tensorflow/tensorboard.git","ssh_url":"[email protected]:tensorflow/tensorboard.git","clone_url":"https://github.com/tensorflow/tensorboard.git","svn_url":"https://github.com/tensorflow/tensorboard","homepage":null,"size":5994,"stargazers_count":195,"watchers_count":195,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":101,"forks":61,"open_issues":101,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/290"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/290"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/290"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorboard/statuses/bd066a216a354c99ae7df42e5206ff358b8b41f4"}}}} | {
"id": 91379993,
"name": "tensorflow/tensorboard",
"url": "https://api.github.com/repos/tensorflow/tensorboard"
} | {
"id": 4317806,
"login": "wchargin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4317806?",
"url": "https://api.github.com/users/wchargin"
} | {
"id": 15658638,
"login": "tensorflow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15658638?",
"url": "https://api.github.com/orgs/tensorflow"
} | 2017-07-31T21:47:59 | 6365406889 | {"actor":{"display_login":"wchargin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tornadoweb/tornado/pulls/comments/113365274","pull_request_review_id":34745660,"id":113365274,"diff_hunk":"@@ -14,13 +17,35 @@ static PyObject* websocket_mask(PyObject* self, PyObject* args) {\n return NULL;\n }\n \n+ uint32_mask = ((uint32_t*)mask)[0];\n+\n result = PyBytes_FromStringAndSize(NULL, data_len);\n if (!result) {\n return NULL;\n }\n buf = PyBytes_AsString(result);\n+\n+ if (sizeof(size_t) >= 8) {\n+ uint64_mask = uint32_mask;\n+ uint64_mask = (uint64_mask << 32) | uint32_mask;\n+\n+ while (data_len >= 8) {\n+ ((uint64_t*)buf)[0] = ((uint64_t*)data)[0] ^ uint64_mask;\n+ data += 8;\n+ buf += 8;\n+ data_len -= 8;\n+ }\n+ }\n+\n+ while (data_len >= 4) {","path":"tornado/speedups.c","position":37,"original_position":37,"commit_id":"2cfc0d44ded0c9c5b0f700402a2b06303afc73ec","original_commit_id":"2cfc0d44ded0c9c5b0f700402a2b06303afc73ec","user":{"login":"ploxiln","id":649835,"avatar_url":"https://avatars1.githubusercontent.com/u/649835?v=3","gravatar_id":"","url":"https://api.github.com/users/ploxiln","html_url":"https://github.com/ploxiln","followers_url":"https://api.github.com/users/ploxiln/followers","following_url":"https://api.github.com/users/ploxiln/following{/other_user}","gists_url":"https://api.github.com/users/ploxiln/gists{/gist_id}","starred_url":"https://api.github.com/users/ploxiln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploxiln/subscriptions","organizations_url":"https://api.github.com/users/ploxiln/orgs","repos_url":"https://api.github.com/users/ploxiln/repos","events_url":"https://api.github.com/users/ploxiln/events{/privacy}","received_events_url":"https://api.github.com/users/ploxiln/received_events","type":"User","site_admin":false},"body":"another silly little thing which probably has no measurable effect: this can just be `if (data_len >= 4)` because it can only be true once, saving an extra compare/branch after the first (only) iteration","created_at":"2017-04-26T04:53:22Z","updated_at":"2017-04-26T04:53:22Z","html_url":"https://github.com/tornadoweb/tornado/pull/2024#discussion_r113365274","pull_request_url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2024","_links":{"self":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/comments/113365274"},"html":{"href":"https://github.com/tornadoweb/tornado/pull/2024#discussion_r113365274"},"pull_request":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/2024"}}},"pull_request":{"url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2024","id":117527802,"html_url":"https://github.com/tornadoweb/tornado/pull/2024","diff_url":"https://github.com/tornadoweb/tornado/pull/2024.diff","patch_url":"https://github.com/tornadoweb/tornado/pull/2024.patch","issue_url":"https://api.github.com/repos/tornadoweb/tornado/issues/2024","number":2024,"state":"open","locked":false,"title":"websocket: optimize C websocket_mask function","user":{"login":"pjknkda","id":4986524,"avatar_url":"https://avatars3.githubusercontent.com/u/4986524?v=3","gravatar_id":"","url":"https://api.github.com/users/pjknkda","html_url":"https://github.com/pjknkda","followers_url":"https://api.github.com/users/pjknkda/followers","following_url":"https://api.github.com/users/pjknkda/following{/other_user}","gists_url":"https://api.github.com/users/pjknkda/gists{/gist_id}","starred_url":"https://api.github.com/users/pjknkda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjknkda/subscriptions","organizations_url":"https://api.github.com/users/pjknkda/orgs","repos_url":"https://api.github.com/users/pjknkda/repos","events_url":"https://api.github.com/users/pjknkda/events{/privacy}","received_events_url":"https://api.github.com/users/pjknkda/received_events","type":"User","site_admin":false},"body":"This change includes the optimization of `websocket_mask` function which is written in C extension.\r\n\r\nBasically the idea is from the cython implementation of another popular Python web framework - aiohttp. (https://github.com/aio-libs/aiohttp/blob/v1.2.0/aiohttp/_websocket.pyx)\r\n\r\nHere is a benchmark result (CPython 3.5.1):\r\n\r\n```sh\r\n# Original\r\n% python -m timeit \\\r\n -n 100000 \\\r\n -s 'import os; from tornado.speedups import websocket_mask; mask = b\"asdf\"; data = os.urandom(100 * 1024)' \\\r\n 'websocket_mask(mask, data)'\r\n100000 loops, best of 3: 113 usec per loop\r\n\r\n# Proposed\r\n% python -m timeit \\\r\n -n 100000 \\\r\n -s 'import os; from tornado.speedups import websocket_mask; mask = b\"asdf\"; data = os.urandom(100 * 1024)' \\\r\n 'websocket_mask(mask, data)'\r\n100000 loops, best of 3: 23.1 usec per loop\r\n```\r\n\r\nThe change takes more advantages if the length of data gets longer.\r\n\r\n\r\n| len(data) | Original | Proposed | Ratio |\r\n|-----------|---------:|---------:|:-----:|\r\n| 1 | 0.131 | 0.129 | 0.98 |\r\n| 10 | 0.157 | 0.133 | 0.85 |\r\n| 100 | 0.253 | 0.140 | 0.55 |\r\n| 1,000 | 1.24 | 0.387 | 0.31 |\r\n| 10,000 | 11.1 | 2.36 | 0.21 |\r\n| 100,000 | 113 | 22.4 | 0.20 |\r\n| 1,000,000 | 1110 | 218 | 0.20 |\r\n","created_at":"2017-04-25T16:31:22Z","updated_at":"2017-04-26T04:53:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65314a00b829687c7eadecd00e5f12dd8d9cbfaa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2024/commits","review_comments_url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2024/comments","review_comment_url":"https://api.github.com/repos/tornadoweb/tornado/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tornadoweb/tornado/issues/2024/comments","statuses_url":"https://api.github.com/repos/tornadoweb/tornado/statuses/2cfc0d44ded0c9c5b0f700402a2b06303afc73ec","head":{"label":"pjknkda:master","ref":"master","sha":"2cfc0d44ded0c9c5b0f700402a2b06303afc73ec","user":{"login":"pjknkda","id":4986524,"avatar_url":"https://avatars3.githubusercontent.com/u/4986524?v=3","gravatar_id":"","url":"https://api.github.com/users/pjknkda","html_url":"https://github.com/pjknkda","followers_url":"https://api.github.com/users/pjknkda/followers","following_url":"https://api.github.com/users/pjknkda/following{/other_user}","gists_url":"https://api.github.com/users/pjknkda/gists{/gist_id}","starred_url":"https://api.github.com/users/pjknkda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjknkda/subscriptions","organizations_url":"https://api.github.com/users/pjknkda/orgs","repos_url":"https://api.github.com/users/pjknkda/repos","events_url":"https://api.github.com/users/pjknkda/events{/privacy}","received_events_url":"https://api.github.com/users/pjknkda/received_events","type":"User","site_admin":false},"repo":{"id":89371349,"name":"tornado","full_name":"pjknkda/tornado","owner":{"login":"pjknkda","id":4986524,"avatar_url":"https://avatars3.githubusercontent.com/u/4986524?v=3","gravatar_id":"","url":"https://api.github.com/users/pjknkda","html_url":"https://github.com/pjknkda","followers_url":"https://api.github.com/users/pjknkda/followers","following_url":"https://api.github.com/users/pjknkda/following{/other_user}","gists_url":"https://api.github.com/users/pjknkda/gists{/gist_id}","starred_url":"https://api.github.com/users/pjknkda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjknkda/subscriptions","organizations_url":"https://api.github.com/users/pjknkda/orgs","repos_url":"https://api.github.com/users/pjknkda/repos","events_url":"https://api.github.com/users/pjknkda/events{/privacy}","received_events_url":"https://api.github.com/users/pjknkda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pjknkda/tornado","description":"Tornado is a Python web framework and asynchronous networking library, originally developed at FriendFeed.","fork":true,"url":"https://api.github.com/repos/pjknkda/tornado","forks_url":"https://api.github.com/repos/pjknkda/tornado/forks","keys_url":"https://api.github.com/repos/pjknkda/tornado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjknkda/tornado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjknkda/tornado/teams","hooks_url":"https://api.github.com/repos/pjknkda/tornado/hooks","issue_events_url":"https://api.github.com/repos/pjknkda/tornado/issues/events{/number}","events_url":"https://api.github.com/repos/pjknkda/tornado/events","assignees_url":"https://api.github.com/repos/pjknkda/tornado/assignees{/user}","branches_url":"https://api.github.com/repos/pjknkda/tornado/branches{/branch}","tags_url":"https://api.github.com/repos/pjknkda/tornado/tags","blobs_url":"https://api.github.com/repos/pjknkda/tornado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjknkda/tornado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjknkda/tornado/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjknkda/tornado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjknkda/tornado/statuses/{sha}","languages_url":"https://api.github.com/repos/pjknkda/tornado/languages","stargazers_url":"https://api.github.com/repos/pjknkda/tornado/stargazers","contributors_url":"https://api.github.com/repos/pjknkda/tornado/contributors","subscribers_url":"https://api.github.com/repos/pjknkda/tornado/subscribers","subscription_url":"https://api.github.com/repos/pjknkda/tornado/subscription","commits_url":"https://api.github.com/repos/pjknkda/tornado/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjknkda/tornado/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjknkda/tornado/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjknkda/tornado/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjknkda/tornado/contents/{+path}","compare_url":"https://api.github.com/repos/pjknkda/tornado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjknkda/tornado/merges","archive_url":"https://api.github.com/repos/pjknkda/tornado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjknkda/tornado/downloads","issues_url":"https://api.github.com/repos/pjknkda/tornado/issues{/number}","pulls_url":"https://api.github.com/repos/pjknkda/tornado/pulls{/number}","milestones_url":"https://api.github.com/repos/pjknkda/tornado/milestones{/number}","notifications_url":"https://api.github.com/repos/pjknkda/tornado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjknkda/tornado/labels{/name}","releases_url":"https://api.github.com/repos/pjknkda/tornado/releases{/id}","deployments_url":"https://api.github.com/repos/pjknkda/tornado/deployments","created_at":"2017-04-25T14:38:23Z","updated_at":"2017-04-25T14:38:26Z","pushed_at":"2017-04-26T04:12:40Z","git_url":"git://github.com/pjknkda/tornado.git","ssh_url":"[email protected]:pjknkda/tornado.git","clone_url":"https://github.com/pjknkda/tornado.git","svn_url":"https://github.com/pjknkda/tornado","homepage":"http://www.tornadoweb.org/","size":7111,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tornadoweb:master","ref":"master","sha":"79b2683437ad49e26fc33d5975b6a661ee0b863c","user":{"login":"tornadoweb","id":7468980,"avatar_url":"https://avatars0.githubusercontent.com/u/7468980?v=3","gravatar_id":"","url":"https://api.github.com/users/tornadoweb","html_url":"https://github.com/tornadoweb","followers_url":"https://api.github.com/users/tornadoweb/followers","following_url":"https://api.github.com/users/tornadoweb/following{/other_user}","gists_url":"https://api.github.com/users/tornadoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/tornadoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tornadoweb/subscriptions","organizations_url":"https://api.github.com/users/tornadoweb/orgs","repos_url":"https://api.github.com/users/tornadoweb/repos","events_url":"https://api.github.com/users/tornadoweb/events{/privacy}","received_events_url":"https://api.github.com/users/tornadoweb/received_events","type":"Organization","site_admin":false},"repo":{"id":301742,"name":"tornado","full_name":"tornadoweb/tornado","owner":{"login":"tornadoweb","id":7468980,"avatar_url":"https://avatars0.githubusercontent.com/u/7468980?v=3","gravatar_id":"","url":"https://api.github.com/users/tornadoweb","html_url":"https://github.com/tornadoweb","followers_url":"https://api.github.com/users/tornadoweb/followers","following_url":"https://api.github.com/users/tornadoweb/following{/other_user}","gists_url":"https://api.github.com/users/tornadoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/tornadoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tornadoweb/subscriptions","organizations_url":"https://api.github.com/users/tornadoweb/orgs","repos_url":"https://api.github.com/users/tornadoweb/repos","events_url":"https://api.github.com/users/tornadoweb/events{/privacy}","received_events_url":"https://api.github.com/users/tornadoweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tornadoweb/tornado","description":"Tornado is a Python web framework and asynchronous networking library, originally developed at FriendFeed.","fork":false,"url":"https://api.github.com/repos/tornadoweb/tornado","forks_url":"https://api.github.com/repos/tornadoweb/tornado/forks","keys_url":"https://api.github.com/repos/tornadoweb/tornado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tornadoweb/tornado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tornadoweb/tornado/teams","hooks_url":"https://api.github.com/repos/tornadoweb/tornado/hooks","issue_events_url":"https://api.github.com/repos/tornadoweb/tornado/issues/events{/number}","events_url":"https://api.github.com/repos/tornadoweb/tornado/events","assignees_url":"https://api.github.com/repos/tornadoweb/tornado/assignees{/user}","branches_url":"https://api.github.com/repos/tornadoweb/tornado/branches{/branch}","tags_url":"https://api.github.com/repos/tornadoweb/tornado/tags","blobs_url":"https://api.github.com/repos/tornadoweb/tornado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tornadoweb/tornado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tornadoweb/tornado/git/refs{/sha}","trees_url":"https://api.github.com/repos/tornadoweb/tornado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tornadoweb/tornado/statuses/{sha}","languages_url":"https://api.github.com/repos/tornadoweb/tornado/languages","stargazers_url":"https://api.github.com/repos/tornadoweb/tornado/stargazers","contributors_url":"https://api.github.com/repos/tornadoweb/tornado/contributors","subscribers_url":"https://api.github.com/repos/tornadoweb/tornado/subscribers","subscription_url":"https://api.github.com/repos/tornadoweb/tornado/subscription","commits_url":"https://api.github.com/repos/tornadoweb/tornado/commits{/sha}","git_commits_url":"https://api.github.com/repos/tornadoweb/tornado/git/commits{/sha}","comments_url":"https://api.github.com/repos/tornadoweb/tornado/comments{/number}","issue_comment_url":"https://api.github.com/repos/tornadoweb/tornado/issues/comments{/number}","contents_url":"https://api.github.com/repos/tornadoweb/tornado/contents/{+path}","compare_url":"https://api.github.com/repos/tornadoweb/tornado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tornadoweb/tornado/merges","archive_url":"https://api.github.com/repos/tornadoweb/tornado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tornadoweb/tornado/downloads","issues_url":"https://api.github.com/repos/tornadoweb/tornado/issues{/number}","pulls_url":"https://api.github.com/repos/tornadoweb/tornado/pulls{/number}","milestones_url":"https://api.github.com/repos/tornadoweb/tornado/milestones{/number}","notifications_url":"https://api.github.com/repos/tornadoweb/tornado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tornadoweb/tornado/labels{/name}","releases_url":"https://api.github.com/repos/tornadoweb/tornado/releases{/id}","deployments_url":"https://api.github.com/repos/tornadoweb/tornado/deployments","created_at":"2009-09-09T04:55:16Z","updated_at":"2017-04-26T04:07:19Z","pushed_at":"2017-04-26T04:12:45Z","git_url":"git://github.com/tornadoweb/tornado.git","ssh_url":"[email protected]:tornadoweb/tornado.git","clone_url":"https://github.com/tornadoweb/tornado.git","svn_url":"https://github.com/tornadoweb/tornado","homepage":"http://www.tornadoweb.org/","size":7109,"stargazers_count":13424,"watchers_count":13424,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4031,"mirror_url":null,"open_issues_count":183,"forks":4031,"open_issues":183,"watchers":13424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/2024"},"html":{"href":"https://github.com/tornadoweb/tornado/pull/2024"},"issue":{"href":"https://api.github.com/repos/tornadoweb/tornado/issues/2024"},"comments":{"href":"https://api.github.com/repos/tornadoweb/tornado/issues/2024/comments"},"review_comments":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/2024/comments"},"review_comment":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tornadoweb/tornado/pulls/2024/commits"},"statuses":{"href":"https://api.github.com/repos/tornadoweb/tornado/statuses/2cfc0d44ded0c9c5b0f700402a2b06303afc73ec"}}}} | {
"id": 301742,
"name": "tornadoweb/tornado",
"url": "https://api.github.com/repos/tornadoweb/tornado"
} | {
"id": 649835,
"login": "ploxiln",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/649835?",
"url": "https://api.github.com/users/ploxiln"
} | {
"id": 7468980,
"login": "tornadoweb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7468980?",
"url": "https://api.github.com/orgs/tornadoweb"
} | 2017-04-26T04:53:22 | 5757589103 | {"actor":{"display_login":"ploxiln"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/flux/pulls/comments/115778162","pull_request_review_id":37346637,"id":115778162,"diff_hunk":"@@ -70,11 +75,89 @@ func (d *Daemon) askForSync() {\n }\n \n func (d *Daemon) pullAndSync(logger log.Logger) {\n+\tstarted := time.Now().UTC()\n+\n+\t// Pull for new commits\n \tif err := d.Checkout.Pull(); err != nil {\n \t\tlogger.Log(\"err\", err)\n+\t\treturn\n+\t}\n+\n+\t// checkout a working clone so we can mess around with tags later\n+\tworking, err := d.Checkout.WorkingClone()\n+\tif err != nil {\n+\t\tlogger.Log(\"err\", err)\n+\t\treturn\n \t}\n+\tdefer working.Clean()\n+\n+\t// update notes and emit events for applied commits\n+\trevisions, err := working.RevisionsBetween(working.SyncTag+\"~1\", \"HEAD\")\n+\tif isUnknownRevision(err) {\n+\t\t// No sync tag, grab all revisions\n+\t\trevisions, err = working.RevisionsBefore(\"HEAD\")\n+\t}\n+\tif err != nil {\n+\t\tlogger.Log(\"err\", err)\n+\t}\n+\n+\t// TODO logging, metrics?\n+\t// Get a map of all resources defined in the repo\n+\tallResources, err := d.Cluster.LoadManifests(working.ManifestDir())\n+\tif err != nil {\n+\t\tlogger.Log(\"err\", errors.Wrap(err, \"loading resources from repo\"))\n+\t\treturn\n+\t}\n+\n \t// TODO supply deletes argument from somewhere (command-line?)\n-\tif err := sync.Sync(d.Checkout.ManifestDir(), d.Cluster, false); err != nil {\n+\tif err := sync.Sync(allResources, d.Cluster, false); err != nil {","path":"daemon/loop.go","position":56,"original_position":56,"commit_id":"c5c36e20ea48f715f08f79edb145fc8cf86ee10d","original_commit_id":"c5c36e20ea48f715f08f79edb145fc8cf86ee10d","user":{"login":"paulbellamy","id":250199,"avatar_url":"https://avatars3.githubusercontent.com/u/250199?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbellamy","html_url":"https://github.com/paulbellamy","followers_url":"https://api.github.com/users/paulbellamy/followers","following_url":"https://api.github.com/users/paulbellamy/following{/other_user}","gists_url":"https://api.github.com/users/paulbellamy/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbellamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbellamy/subscriptions","organizations_url":"https://api.github.com/users/paulbellamy/orgs","repos_url":"https://api.github.com/users/paulbellamy/repos","events_url":"https://api.github.com/users/paulbellamy/events{/privacy}","received_events_url":"https://api.github.com/users/paulbellamy/received_events","type":"User","site_admin":false},"body":"Yes, we could, but this way if you change the kubernetes cluster \"live\", and update the git repo it will \"fix everything\"","created_at":"2017-05-10T15:47:05Z","updated_at":"2017-05-10T15:47:05Z","html_url":"https://github.com/weaveworks/flux/pull/560#discussion_r115778162","pull_request_url":"https://api.github.com/repos/weaveworks/flux/pulls/560","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/flux/pulls/comments/115778162"},"html":{"href":"https://github.com/weaveworks/flux/pull/560#discussion_r115778162"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/flux/pulls/560"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/flux/pulls/560","id":119492155,"html_url":"https://github.com/weaveworks/flux/pull/560","diff_url":"https://github.com/weaveworks/flux/pull/560.diff","patch_url":"https://github.com/weaveworks/flux/pull/560.patch","issue_url":"https://api.github.com/repos/weaveworks/flux/issues/560","number":560,"state":"open","locked":false,"title":"Make fluxctl wait for release to finish again","user":{"login":"paulbellamy","id":250199,"avatar_url":"https://avatars3.githubusercontent.com/u/250199?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbellamy","html_url":"https://github.com/paulbellamy","followers_url":"https://api.github.com/users/paulbellamy/followers","following_url":"https://api.github.com/users/paulbellamy/following{/other_user}","gists_url":"https://api.github.com/users/paulbellamy/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbellamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbellamy/subscriptions","organizations_url":"https://api.github.com/users/paulbellamy/orgs","repos_url":"https://api.github.com/users/paulbellamy/repos","events_url":"https://api.github.com/users/paulbellamy/events{/privacy}","received_events_url":"https://api.github.com/users/paulbellamy/received_events","type":"User","site_admin":false},"body":"Based on #555 \r\n\r\nAlso:\r\n- emitting events when releasing, and syncing\r\n- moving the tag when syncing\r\n- add lock around the repo, to avoid a pull race condition\r\n- Fix bug in revlist splitting\r\n- sync all files, but only emit changed ones in the history even\r\n\r\n## TODO\r\n\r\n- [x] Make sure I've not made the tests worse.\r\n- [x] Get rid of \"Pending\" status on serviceResults, it doesn't make sense anymore.\r\n- [x] Check it works without an existing flux-sync tag\r\n- [x] Hide scary log messages when notes and flux-sync tag don't exist.\r\n- [x] Figure out how to make resource.ServiceIDs better.\r\n- [x] Expand sync loop test\r\n","created_at":"2017-05-08T17:08:44Z","updated_at":"2017-05-10T15:47:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e7209b18c4e1426c3c81b61801565f2d4102380","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/flux/pulls/560/commits","review_comments_url":"https://api.github.com/repos/weaveworks/flux/pulls/560/comments","review_comment_url":"https://api.github.com/repos/weaveworks/flux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/flux/issues/560/comments","statuses_url":"https://api.github.com/repos/weaveworks/flux/statuses/c5c36e20ea48f715f08f79edb145fc8cf86ee10d","head":{"label":"weaveworks:sync-in-daemon-await-job","ref":"sync-in-daemon-await-job","sha":"c5c36e20ea48f715f08f79edb145fc8cf86ee10d","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars2.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":62799996,"name":"flux","full_name":"weaveworks/flux","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars2.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/flux","description":"A tool for turning container images into running Kubernetes services","fork":false,"url":"https://api.github.com/repos/weaveworks/flux","forks_url":"https://api.github.com/repos/weaveworks/flux/forks","keys_url":"https://api.github.com/repos/weaveworks/flux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/flux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/flux/teams","hooks_url":"https://api.github.com/repos/weaveworks/flux/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/flux/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/flux/events","assignees_url":"https://api.github.com/repos/weaveworks/flux/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/flux/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/flux/tags","blobs_url":"https://api.github.com/repos/weaveworks/flux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/flux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/flux/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/flux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/flux/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/flux/languages","stargazers_url":"https://api.github.com/repos/weaveworks/flux/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/flux/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/flux/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/flux/subscription","commits_url":"https://api.github.com/repos/weaveworks/flux/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/flux/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/flux/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/flux/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/flux/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/flux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/flux/merges","archive_url":"https://api.github.com/repos/weaveworks/flux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/flux/downloads","issues_url":"https://api.github.com/repos/weaveworks/flux/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/flux/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/flux/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/flux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/flux/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/flux/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/flux/deployments","created_at":"2016-07-07T10:55:13Z","updated_at":"2017-05-08T23:59:42Z","pushed_at":"2017-05-10T15:42:52Z","git_url":"git://github.com/weaveworks/flux.git","ssh_url":"[email protected]:weaveworks/flux.git","clone_url":"https://github.com/weaveworks/flux.git","svn_url":"https://github.com/weaveworks/flux","homepage":"","size":4643,"stargazers_count":110,"watchers_count":110,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":102,"forks":12,"open_issues":102,"watchers":110,"default_branch":"master"}},"base":{"label":"weaveworks:move-sync-into-daemon","ref":"move-sync-into-daemon","sha":"3c0a79bdff40d6e27bad5cf394a17dbeb47b4a0d","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars2.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":62799996,"name":"flux","full_name":"weaveworks/flux","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars2.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/flux","description":"A tool for turning container images into running Kubernetes services","fork":false,"url":"https://api.github.com/repos/weaveworks/flux","forks_url":"https://api.github.com/repos/weaveworks/flux/forks","keys_url":"https://api.github.com/repos/weaveworks/flux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/flux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/flux/teams","hooks_url":"https://api.github.com/repos/weaveworks/flux/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/flux/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/flux/events","assignees_url":"https://api.github.com/repos/weaveworks/flux/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/flux/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/flux/tags","blobs_url":"https://api.github.com/repos/weaveworks/flux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/flux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/flux/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/flux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/flux/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/flux/languages","stargazers_url":"https://api.github.com/repos/weaveworks/flux/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/flux/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/flux/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/flux/subscription","commits_url":"https://api.github.com/repos/weaveworks/flux/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/flux/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/flux/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/flux/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/flux/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/flux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/flux/merges","archive_url":"https://api.github.com/repos/weaveworks/flux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/flux/downloads","issues_url":"https://api.github.com/repos/weaveworks/flux/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/flux/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/flux/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/flux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/flux/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/flux/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/flux/deployments","created_at":"2016-07-07T10:55:13Z","updated_at":"2017-05-08T23:59:42Z","pushed_at":"2017-05-10T15:42:52Z","git_url":"git://github.com/weaveworks/flux.git","ssh_url":"[email protected]:weaveworks/flux.git","clone_url":"https://github.com/weaveworks/flux.git","svn_url":"https://github.com/weaveworks/flux","homepage":"","size":4643,"stargazers_count":110,"watchers_count":110,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":102,"forks":12,"open_issues":102,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/flux/pulls/560"},"html":{"href":"https://github.com/weaveworks/flux/pull/560"},"issue":{"href":"https://api.github.com/repos/weaveworks/flux/issues/560"},"comments":{"href":"https://api.github.com/repos/weaveworks/flux/issues/560/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/flux/pulls/560/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/flux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/flux/pulls/560/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/flux/statuses/c5c36e20ea48f715f08f79edb145fc8cf86ee10d"}}}} | {
"id": 62799996,
"name": "weaveworks/flux",
"url": "https://api.github.com/repos/weaveworks/flux"
} | {
"id": 250199,
"login": "paulbellamy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/250199?",
"url": "https://api.github.com/users/paulbellamy"
} | {
"id": 9976052,
"login": "weaveworks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9976052?",
"url": "https://api.github.com/orgs/weaveworks"
} | 2017-05-10T15:47:05 | 5846245504 | {"actor":{"display_login":"paulbellamy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/comments/99431464","pull_request_review_id":20113214,"id":99431464,"diff_hunk":"@@ -0,0 +1,188 @@\n+<link rel=\"import\" href=\"../polymer/polymer.html\">\n+<link rel=\"import\" href=\"../iron-overlay-behavior/iron-overlay-behavior.html\">\n+<link rel=\"import\" href=\"../neon-animation/neon-animation-runner-behavior.html\">\n+<link rel=\"import\" href=\"../neon-animation/animations/slide-from-bottom-animation.html\">\n+<link rel=\"import\" href=\"../neon-animation/animations/slide-down-animation.html\">\n+<link rel=\"import\" href=\"../neon-animation/animations/transform-animation.html\">\n+<link rel=\"import\" href=\"../neon-animation/animations/fade-in-animation.html\">\n+<link rel=\"import\" href=\"../neon-animation/animations/fade-out-animation.html\">\n+<link rel=\"import\" href=\"../d2l-icons/d2l-icons.html\">\n+<link rel=\"import\" href=\"d2l-simple-overlay-styles.html\">\n+<link rel=\"import\" href=\"../d2l-polymer-behaviors/d2l-dom.html\">\n+\n+<!-- This overlay supports using different animations and transitions for desktop and mobile. -->\n+<dom-module id=\"d2l-simple-overlay\">\n+\t<style include=\"d2l-simple-overlay-styles\"></style>\n+\t<template>\n+\t\t<span role=\"dialog\" aria-label$=\"[[titleName]]\">\n+\t\t\t<div class=\"max-width container\">\n+\t\t\t\t<h1 class=\"d2l-heading-2\">{{titleName}}</h1>\n+\t\t\t\t<button\n+\t\t\t\t\tclass=\"close-button\"\n+\t\t\t\t\ton-tap=\"_handleClose\"\n+\t\t\t\t\taria-label$=\"[[closeSimpleOverlayAltText]]\"\n+\t\t\t\t\talt$=\"[[closeSimpleOverlayAltText]]\">\n+\t\t\t\t\t<d2l-icon icon=\"d2l-tier1:close-large-thick\"></d2l-icon>\n+\t\t\t\t</button>\n+\t\t\t</div>\n+\t\t\t<div class=\"scrollable\">\n+\t\t\t\t<div class=\"max-width\">\n+\t\t\t\t\t<content></content>\n+\t\t\t\t</div>\n+\t\t\t</div>\n+\t\t</span>\n+\t</template>\n+\t<script>\n+\t\t'use strict';\n+\n+\t\tPolymer({\n+\t\t\tis: 'd2l-simple-overlay',\n+\n+\t\t\tbehaviors: [\n+\t\t\t\tPolymer.IronOverlayBehavior,\n+\t\t\t\tPolymer.NeonAnimationRunnerBehavior\n+\t\t\t],\n+\t\t\tlisteners: {\n+\t\t\t\t'neon-animation-finish': '_onNeonAnimationFinish',\n+\t\t\t\t'image-selector-tile-image-selected': '_handleCloseSimpleOverlayEvent'\n+\t\t\t},\n+\t\t\tproperties: {\n+\t\t\t\t// Title for overlay\n+\t\t\t\ttitleName: {\n+\t\t\t\t\ttype: String\n+\t\t\t\t},\n+\t\t\t\t// Localized text for the close button label\n+\t\t\t\tcloseSimpleOverlayAltText: {","path":"d2l-simple-overlay.html","position":55,"original_position":55,"commit_id":"6eb44f9cdcdfefe177e08fe2e61ea79e8676657a","original_commit_id":"5e828562aa1b90404b557afa176123a689e0b18c","user":{"login":"jstefaniuk-d2l","id":14077760,"avatar_url":"https://avatars.githubusercontent.com/u/14077760?v=3","gravatar_id":"","url":"https://api.github.com/users/jstefaniuk-d2l","html_url":"https://github.com/jstefaniuk-d2l","followers_url":"https://api.github.com/users/jstefaniuk-d2l/followers","following_url":"https://api.github.com/users/jstefaniuk-d2l/following{/other_user}","gists_url":"https://api.github.com/users/jstefaniuk-d2l/gists{/gist_id}","starred_url":"https://api.github.com/users/jstefaniuk-d2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstefaniuk-d2l/subscriptions","organizations_url":"https://api.github.com/users/jstefaniuk-d2l/orgs","repos_url":"https://api.github.com/users/jstefaniuk-d2l/repos","events_url":"https://api.github.com/users/jstefaniuk-d2l/events{/privacy}","received_events_url":"https://api.github.com/users/jstefaniuk-d2l/received_events","type":"User","site_admin":false},"body":"You can do `closeSimpleOverlayAltText: String` here","created_at":"2017-02-03T22:00:12Z","updated_at":"2017-02-03T22:00:12Z","html_url":"https://github.com/Brightspace/simple-overlay/pull/1#discussion_r99431464","pull_request_url":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/comments/99431464"},"html":{"href":"https://github.com/Brightspace/simple-overlay/pull/1#discussion_r99431464"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/1","id":104609816,"html_url":"https://github.com/Brightspace/simple-overlay/pull/1","diff_url":"https://github.com/Brightspace/simple-overlay/pull/1.diff","patch_url":"https://github.com/Brightspace/simple-overlay/pull/1.patch","issue_url":"https://api.github.com/repos/Brightspace/simple-overlay/issues/1","number":1,"state":"open","locked":false,"title":"Factor out of my courses","user":{"login":"cgalvind2l","id":8916855,"avatar_url":"https://avatars.githubusercontent.com/u/8916855?v=3","gravatar_id":"","url":"https://api.github.com/users/cgalvind2l","html_url":"https://github.com/cgalvind2l","followers_url":"https://api.github.com/users/cgalvind2l/followers","following_url":"https://api.github.com/users/cgalvind2l/following{/other_user}","gists_url":"https://api.github.com/users/cgalvind2l/gists{/gist_id}","starred_url":"https://api.github.com/users/cgalvind2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgalvind2l/subscriptions","organizations_url":"https://api.github.com/users/cgalvind2l/orgs","repos_url":"https://api.github.com/users/cgalvind2l/repos","events_url":"https://api.github.com/users/cgalvind2l/events{/privacy}","received_events_url":"https://api.github.com/users/cgalvind2l/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-03T20:54:16Z","updated_at":"2017-02-03T22:00:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7974e16edd695152801954eea461cfcd32816b6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/simple-overlay/issues/1/comments","statuses_url":"https://api.github.com/repos/Brightspace/simple-overlay/statuses/6eb44f9cdcdfefe177e08fe2e61ea79e8676657a","head":{"label":"Brightspace:factorOutOfMyCourses","ref":"factorOutOfMyCourses","sha":"6eb44f9cdcdfefe177e08fe2e61ea79e8676657a","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":80163227,"name":"simple-overlay","full_name":"Brightspace/simple-overlay","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/simple-overlay","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/simple-overlay","forks_url":"https://api.github.com/repos/Brightspace/simple-overlay/forks","keys_url":"https://api.github.com/repos/Brightspace/simple-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/simple-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/simple-overlay/teams","hooks_url":"https://api.github.com/repos/Brightspace/simple-overlay/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/simple-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/simple-overlay/events","assignees_url":"https://api.github.com/repos/Brightspace/simple-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/simple-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/simple-overlay/tags","blobs_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/simple-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/simple-overlay/languages","stargazers_url":"https://api.github.com/repos/Brightspace/simple-overlay/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/simple-overlay/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/simple-overlay/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/simple-overlay/subscription","commits_url":"https://api.github.com/repos/Brightspace/simple-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/simple-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/simple-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/simple-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/simple-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/simple-overlay/merges","archive_url":"https://api.github.com/repos/Brightspace/simple-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/simple-overlay/downloads","issues_url":"https://api.github.com/repos/Brightspace/simple-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/simple-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/simple-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/simple-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/simple-overlay/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/simple-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/simple-overlay/deployments","created_at":"2017-01-26T22:48:03Z","updated_at":"2017-01-26T22:48:03Z","pushed_at":"2017-02-03T21:11:06Z","git_url":"git://github.com/Brightspace/simple-overlay.git","ssh_url":"[email protected]:Brightspace/simple-overlay.git","clone_url":"https://github.com/Brightspace/simple-overlay.git","svn_url":"https://github.com/Brightspace/simple-overlay","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"a27896b1624674db088d32d3793321a509da3166","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":80163227,"name":"simple-overlay","full_name":"Brightspace/simple-overlay","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/simple-overlay","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/simple-overlay","forks_url":"https://api.github.com/repos/Brightspace/simple-overlay/forks","keys_url":"https://api.github.com/repos/Brightspace/simple-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/simple-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/simple-overlay/teams","hooks_url":"https://api.github.com/repos/Brightspace/simple-overlay/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/simple-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/simple-overlay/events","assignees_url":"https://api.github.com/repos/Brightspace/simple-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/simple-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/simple-overlay/tags","blobs_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/simple-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/simple-overlay/languages","stargazers_url":"https://api.github.com/repos/Brightspace/simple-overlay/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/simple-overlay/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/simple-overlay/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/simple-overlay/subscription","commits_url":"https://api.github.com/repos/Brightspace/simple-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/simple-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/simple-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/simple-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/simple-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/simple-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/simple-overlay/merges","archive_url":"https://api.github.com/repos/Brightspace/simple-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/simple-overlay/downloads","issues_url":"https://api.github.com/repos/Brightspace/simple-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/simple-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/simple-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/simple-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/simple-overlay/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/simple-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/simple-overlay/deployments","created_at":"2017-01-26T22:48:03Z","updated_at":"2017-01-26T22:48:03Z","pushed_at":"2017-02-03T21:11:06Z","git_url":"git://github.com/Brightspace/simple-overlay.git","ssh_url":"[email protected]:Brightspace/simple-overlay.git","clone_url":"https://github.com/Brightspace/simple-overlay.git","svn_url":"https://github.com/Brightspace/simple-overlay","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/1"},"html":{"href":"https://github.com/Brightspace/simple-overlay/pull/1"},"issue":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/issues/1"},"comments":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/simple-overlay/statuses/6eb44f9cdcdfefe177e08fe2e61ea79e8676657a"}}}} | {
"id": 80163227,
"name": "Brightspace/simple-overlay",
"url": "https://api.github.com/repos/Brightspace/simple-overlay"
} | {
"id": 14077760,
"login": "jstefaniuk-d2l",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14077760?",
"url": "https://api.github.com/users/jstefaniuk-d2l"
} | {
"id": 5429170,
"login": "Brightspace",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5429170?",
"url": "https://api.github.com/orgs/Brightspace"
} | 2017-02-03T22:00:12 | 5264619218 | {"actor":{"display_login":"jstefaniuk-d2l"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/BuildEmpire/apartment/pulls/comments/117187654","pull_request_review_id":38871240,"id":117187654,"diff_hunk":"@@ -1,2 +1,315 @@\n-# apartment\n-Database multi-tenancy for lumen applications\n+BuildEmpire/Apartment\n+=========================\n+\n+Database multi-tenancy for lumen applications using PostgreSQL and Eloquent\n+\n+This package provides the ability to utilise PostgreSQL's schemas within your Lumen application. Apartment facilitates \n+the creation, update, and management of your multi tenants while using many of the artisan migration commands you \n+are already familiar with.\n+ \n+Installation\n+------------\n+\n+First, install the package using composer and dump composer's auto-load.\n+```\n+composer require buildempire/apartment\n+composer dump-autoload\n+```\n+\n+Then add the BuildEmpire/Apartment provider to your /bootstrap/app.php file.\n+```\n+$app->register(BuildEmpire\\Apartment\\Providers\\ApartmentServiceProvider::class);\n+```\n+\n+You must also enable Facades and Eloquent:\n+\n+```\n+$app->withFacades();\n+\n+$app->withEloquent();\n+```\n+\n+If you wish to use Apartment's middleware you can also add that to your /bootstrap/app.php file.\n+```\n+$app->routeMiddleware([\n+ 'apartment' => BuildEmpire\\Apartment\\Middleware\\ApartmentMiddleware::class\n+]);\n+```\n+\n+<p align=\"center\">\n+\n+Command Line Usage using Artisan\n+--------------------------------\n+\n+All commands for apartment are available within artisan. \n+\n+Apartment uses the same process to manage migrations as in Lumen, which is with the artisan migration commands:\n+\n+```\n+migrate\n+migrate:install Create the migration repository\n+migrate:refresh Reset and re-run all migrations\n+migrate:reset Rollback all database migrations\n+migrate:rollback Rollback the last database migration\n+migrate:status Show the status of each migration\n+```\n+\n+<b>Important:</b> Your migrations can consist of two types of migration files. A standard Lumen migration or an \n+Apartment migration. A standard Lumen migration file will ONLY be applied to the public schema whereas the Apartment\n+migration files will ONLY be applied to any available schemas. To learn how to create an Apartment migration see the \n+Creating a new Apartment Migration section. \n+\n+\n+</p>\n+\n+Creating a new Apartment\n+------------------------\n+\n+To create your first apartment/schema simple enter:\n+```\n+php artisan apartment:make [name of schema/apartment]\n+```\n+<b>Important:</b> Apartment names can only start with a letter and may only contain lowercase letters, numbers, or underscores.\n+\n+Listing Apartments\n+------------------\n+\n+Sometimes it's important to view what apartments have already been created and this can be achived by using the command:\n+```\n+php artisan apartment:list\n+\n+```\n+\n+which will return a list of schemas.\n+\n+Creating a new Apartment Migration\n+----------------------------------\n+Apartment tries to use the same process to manage migrations as in Lumen, which is with the artisan migration commands. \n+The only difference occurs when creating an apartment migration file using the command:\n+ \n+```\n+php artisan apartment:migration [name of migration]\n+```\n+\n+which will create a file within your migrations folder. In this example I created a migration called CreateProductsTable \n+which created the file: 2017_05_17_203315_CreateProductsTable.php\n+\n+```\n+<?php\n+\n+use Illuminate\\Support\\Facades\\Schema;\n+use Illuminate\\Database\\Schema\\Blueprint;\n+use BuildEmpire\\Apartment\\ApartmentMigration;\n+\n+/**\n+ * Apartment migration file.\n+ *\n+ * You must set the table name with the table property, and place it anywhere you reference the table in your schemas.\n+ */\n+class CreateProductsTable extends ApartmentMigration\n+{\n+ /**\n+ * You must use this table variable in your schema migrations as the table name.\n+ */\n+ protected $table = '';\n+\n+ /**\n+ * Run the migrations.\n+ *\n+ * @return void\n+ */\n+ public function apartmentUp()\n+ {\n+ Schema::create($this->table, function (Blueprint $table) {\n+ $table->increments('id');\n+ });\n+ }\n+\n+ /**\n+ * Reverse the migrations.\n+ *\n+ * @return void\n+ */\n+ public function apartmentDown()\n+ {\n+ Schema::drop($this->table);\n+ }\n+}\n+```\n+The important things to notice in the apartment migration file are these two areas:\n+\n+```\n+protected $table = '';\n+```\n+and the schema calls\n+```\n+Schema::create($this->table, functi....\n+Schema::drop($this->table);\n+```\n+\n+\n+You must specify the table name that you wish to update, create or any other operation you wish to do to the table and \n+make sure that any references that Schema makes to a table is using the $this->table property.\n+ \n+In many cases this is simply a case of updating the $table property. In this example we've updated it to:\n+\n+```\n+protected $table = 'products';\n+```\n+\n+The schemas in this example are already pointed to the $this->table property so we don't need to change anything related ","path":"README.md","position":162,"original_position":162,"commit_id":"b341c4027ff82715cbfdc2f2be53a31861cec86a","original_commit_id":"605cb636ac09ae7e8efeeb762f1861a3fc7bcc69","user":{"login":"uk-casmith","id":16223008,"avatar_url":"https://avatars2.githubusercontent.com/u/16223008?v=3","gravatar_id":"","url":"https://api.github.com/users/uk-casmith","html_url":"https://github.com/uk-casmith","followers_url":"https://api.github.com/users/uk-casmith/followers","following_url":"https://api.github.com/users/uk-casmith/following{/other_user}","gists_url":"https://api.github.com/users/uk-casmith/gists{/gist_id}","starred_url":"https://api.github.com/users/uk-casmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uk-casmith/subscriptions","organizations_url":"https://api.github.com/users/uk-casmith/orgs","repos_url":"https://api.github.com/users/uk-casmith/repos","events_url":"https://api.github.com/users/uk-casmith/events{/privacy}","received_events_url":"https://api.github.com/users/uk-casmith/received_events","type":"User","site_admin":false},"body":"Yeah, the code tags make it look pretty when viewed in Github :). ","created_at":"2017-05-18T08:29:32Z","updated_at":"2017-05-18T08:29:32Z","html_url":"https://github.com/BuildEmpire/apartment/pull/1#discussion_r117187654","pull_request_url":"https://api.github.com/repos/BuildEmpire/apartment/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/BuildEmpire/apartment/pulls/comments/117187654"},"html":{"href":"https://github.com/BuildEmpire/apartment/pull/1#discussion_r117187654"},"pull_request":{"href":"https://api.github.com/repos/BuildEmpire/apartment/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/BuildEmpire/apartment/pulls/1","id":121007993,"html_url":"https://github.com/BuildEmpire/apartment/pull/1","diff_url":"https://github.com/BuildEmpire/apartment/pull/1.diff","patch_url":"https://github.com/BuildEmpire/apartment/pull/1.patch","issue_url":"https://api.github.com/repos/BuildEmpire/apartment/issues/1","number":1,"state":"open","locked":false,"title":"Initial Implementation of Apartment","user":{"login":"uk-casmith","id":16223008,"avatar_url":"https://avatars2.githubusercontent.com/u/16223008?v=3","gravatar_id":"","url":"https://api.github.com/users/uk-casmith","html_url":"https://github.com/uk-casmith","followers_url":"https://api.github.com/users/uk-casmith/followers","following_url":"https://api.github.com/users/uk-casmith/following{/other_user}","gists_url":"https://api.github.com/users/uk-casmith/gists{/gist_id}","starred_url":"https://api.github.com/users/uk-casmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uk-casmith/subscriptions","organizations_url":"https://api.github.com/users/uk-casmith/orgs","repos_url":"https://api.github.com/users/uk-casmith/repos","events_url":"https://api.github.com/users/uk-casmith/events{/privacy}","received_events_url":"https://api.github.com/users/uk-casmith/received_events","type":"User","site_admin":false},"body":"WIP - Do not review :)","created_at":"2017-05-17T09:09:55Z","updated_at":"2017-05-18T08:29:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb4aad856b1b9088f7d399fdc32b55369e60666e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/BuildEmpire/apartment/pulls/1/commits","review_comments_url":"https://api.github.com/repos/BuildEmpire/apartment/pulls/1/comments","review_comment_url":"https://api.github.com/repos/BuildEmpire/apartment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BuildEmpire/apartment/issues/1/comments","statuses_url":"https://api.github.com/repos/BuildEmpire/apartment/statuses/b341c4027ff82715cbfdc2f2be53a31861cec86a","head":{"label":"uk-casmith:intial_project","ref":"intial_project","sha":"b341c4027ff82715cbfdc2f2be53a31861cec86a","user":{"login":"uk-casmith","id":16223008,"avatar_url":"https://avatars2.githubusercontent.com/u/16223008?v=3","gravatar_id":"","url":"https://api.github.com/users/uk-casmith","html_url":"https://github.com/uk-casmith","followers_url":"https://api.github.com/users/uk-casmith/followers","following_url":"https://api.github.com/users/uk-casmith/following{/other_user}","gists_url":"https://api.github.com/users/uk-casmith/gists{/gist_id}","starred_url":"https://api.github.com/users/uk-casmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uk-casmith/subscriptions","organizations_url":"https://api.github.com/users/uk-casmith/orgs","repos_url":"https://api.github.com/users/uk-casmith/repos","events_url":"https://api.github.com/users/uk-casmith/events{/privacy}","received_events_url":"https://api.github.com/users/uk-casmith/received_events","type":"User","site_admin":false},"repo":{"id":91466643,"name":"apartment","full_name":"uk-casmith/apartment","owner":{"login":"uk-casmith","id":16223008,"avatar_url":"https://avatars2.githubusercontent.com/u/16223008?v=3","gravatar_id":"","url":"https://api.github.com/users/uk-casmith","html_url":"https://github.com/uk-casmith","followers_url":"https://api.github.com/users/uk-casmith/followers","following_url":"https://api.github.com/users/uk-casmith/following{/other_user}","gists_url":"https://api.github.com/users/uk-casmith/gists{/gist_id}","starred_url":"https://api.github.com/users/uk-casmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uk-casmith/subscriptions","organizations_url":"https://api.github.com/users/uk-casmith/orgs","repos_url":"https://api.github.com/users/uk-casmith/repos","events_url":"https://api.github.com/users/uk-casmith/events{/privacy}","received_events_url":"https://api.github.com/users/uk-casmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uk-casmith/apartment","description":"Database multi-tenancy for lumen applications","fork":true,"url":"https://api.github.com/repos/uk-casmith/apartment","forks_url":"https://api.github.com/repos/uk-casmith/apartment/forks","keys_url":"https://api.github.com/repos/uk-casmith/apartment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uk-casmith/apartment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uk-casmith/apartment/teams","hooks_url":"https://api.github.com/repos/uk-casmith/apartment/hooks","issue_events_url":"https://api.github.com/repos/uk-casmith/apartment/issues/events{/number}","events_url":"https://api.github.com/repos/uk-casmith/apartment/events","assignees_url":"https://api.github.com/repos/uk-casmith/apartment/assignees{/user}","branches_url":"https://api.github.com/repos/uk-casmith/apartment/branches{/branch}","tags_url":"https://api.github.com/repos/uk-casmith/apartment/tags","blobs_url":"https://api.github.com/repos/uk-casmith/apartment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uk-casmith/apartment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uk-casmith/apartment/git/refs{/sha}","trees_url":"https://api.github.com/repos/uk-casmith/apartment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uk-casmith/apartment/statuses/{sha}","languages_url":"https://api.github.com/repos/uk-casmith/apartment/languages","stargazers_url":"https://api.github.com/repos/uk-casmith/apartment/stargazers","contributors_url":"https://api.github.com/repos/uk-casmith/apartment/contributors","subscribers_url":"https://api.github.com/repos/uk-casmith/apartment/subscribers","subscription_url":"https://api.github.com/repos/uk-casmith/apartment/subscription","commits_url":"https://api.github.com/repos/uk-casmith/apartment/commits{/sha}","git_commits_url":"https://api.github.com/repos/uk-casmith/apartment/git/commits{/sha}","comments_url":"https://api.github.com/repos/uk-casmith/apartment/comments{/number}","issue_comment_url":"https://api.github.com/repos/uk-casmith/apartment/issues/comments{/number}","contents_url":"https://api.github.com/repos/uk-casmith/apartment/contents/{+path}","compare_url":"https://api.github.com/repos/uk-casmith/apartment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uk-casmith/apartment/merges","archive_url":"https://api.github.com/repos/uk-casmith/apartment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uk-casmith/apartment/downloads","issues_url":"https://api.github.com/repos/uk-casmith/apartment/issues{/number}","pulls_url":"https://api.github.com/repos/uk-casmith/apartment/pulls{/number}","milestones_url":"https://api.github.com/repos/uk-casmith/apartment/milestones{/number}","notifications_url":"https://api.github.com/repos/uk-casmith/apartment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uk-casmith/apartment/labels{/name}","releases_url":"https://api.github.com/repos/uk-casmith/apartment/releases{/id}","deployments_url":"https://api.github.com/repos/uk-casmith/apartment/deployments","created_at":"2017-05-16T14:16:52Z","updated_at":"2017-05-16T14:18:40Z","pushed_at":"2017-05-18T08:27:57Z","git_url":"git://github.com/uk-casmith/apartment.git","ssh_url":"[email protected]:uk-casmith/apartment.git","clone_url":"https://github.com/uk-casmith/apartment.git","svn_url":"https://github.com/uk-casmith/apartment","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"BuildEmpire:develop","ref":"develop","sha":"bea0a6626e8990f3e484a3b2198c5625143b59fb","user":{"login":"BuildEmpire","id":6884652,"avatar_url":"https://avatars0.githubusercontent.com/u/6884652?v=3","gravatar_id":"","url":"https://api.github.com/users/BuildEmpire","html_url":"https://github.com/BuildEmpire","followers_url":"https://api.github.com/users/BuildEmpire/followers","following_url":"https://api.github.com/users/BuildEmpire/following{/other_user}","gists_url":"https://api.github.com/users/BuildEmpire/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildEmpire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildEmpire/subscriptions","organizations_url":"https://api.github.com/users/BuildEmpire/orgs","repos_url":"https://api.github.com/users/BuildEmpire/repos","events_url":"https://api.github.com/users/BuildEmpire/events{/privacy}","received_events_url":"https://api.github.com/users/BuildEmpire/received_events","type":"Organization","site_admin":false},"repo":{"id":91303048,"name":"apartment","full_name":"BuildEmpire/apartment","owner":{"login":"BuildEmpire","id":6884652,"avatar_url":"https://avatars0.githubusercontent.com/u/6884652?v=3","gravatar_id":"","url":"https://api.github.com/users/BuildEmpire","html_url":"https://github.com/BuildEmpire","followers_url":"https://api.github.com/users/BuildEmpire/followers","following_url":"https://api.github.com/users/BuildEmpire/following{/other_user}","gists_url":"https://api.github.com/users/BuildEmpire/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildEmpire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildEmpire/subscriptions","organizations_url":"https://api.github.com/users/BuildEmpire/orgs","repos_url":"https://api.github.com/users/BuildEmpire/repos","events_url":"https://api.github.com/users/BuildEmpire/events{/privacy}","received_events_url":"https://api.github.com/users/BuildEmpire/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuildEmpire/apartment","description":"Database multi-tenancy for Lumen applications","fork":false,"url":"https://api.github.com/repos/BuildEmpire/apartment","forks_url":"https://api.github.com/repos/BuildEmpire/apartment/forks","keys_url":"https://api.github.com/repos/BuildEmpire/apartment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuildEmpire/apartment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuildEmpire/apartment/teams","hooks_url":"https://api.github.com/repos/BuildEmpire/apartment/hooks","issue_events_url":"https://api.github.com/repos/BuildEmpire/apartment/issues/events{/number}","events_url":"https://api.github.com/repos/BuildEmpire/apartment/events","assignees_url":"https://api.github.com/repos/BuildEmpire/apartment/assignees{/user}","branches_url":"https://api.github.com/repos/BuildEmpire/apartment/branches{/branch}","tags_url":"https://api.github.com/repos/BuildEmpire/apartment/tags","blobs_url":"https://api.github.com/repos/BuildEmpire/apartment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuildEmpire/apartment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuildEmpire/apartment/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuildEmpire/apartment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuildEmpire/apartment/statuses/{sha}","languages_url":"https://api.github.com/repos/BuildEmpire/apartment/languages","stargazers_url":"https://api.github.com/repos/BuildEmpire/apartment/stargazers","contributors_url":"https://api.github.com/repos/BuildEmpire/apartment/contributors","subscribers_url":"https://api.github.com/repos/BuildEmpire/apartment/subscribers","subscription_url":"https://api.github.com/repos/BuildEmpire/apartment/subscription","commits_url":"https://api.github.com/repos/BuildEmpire/apartment/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuildEmpire/apartment/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuildEmpire/apartment/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuildEmpire/apartment/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuildEmpire/apartment/contents/{+path}","compare_url":"https://api.github.com/repos/BuildEmpire/apartment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuildEmpire/apartment/merges","archive_url":"https://api.github.com/repos/BuildEmpire/apartment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuildEmpire/apartment/downloads","issues_url":"https://api.github.com/repos/BuildEmpire/apartment/issues{/number}","pulls_url":"https://api.github.com/repos/BuildEmpire/apartment/pulls{/number}","milestones_url":"https://api.github.com/repos/BuildEmpire/apartment/milestones{/number}","notifications_url":"https://api.github.com/repos/BuildEmpire/apartment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuildEmpire/apartment/labels{/name}","releases_url":"https://api.github.com/repos/BuildEmpire/apartment/releases{/id}","deployments_url":"https://api.github.com/repos/BuildEmpire/apartment/deployments","created_at":"2017-05-15T06:34:35Z","updated_at":"2017-05-17T13:18:00Z","pushed_at":"2017-05-18T08:27:58Z","git_url":"git://github.com/BuildEmpire/apartment.git","ssh_url":"[email protected]:BuildEmpire/apartment.git","clone_url":"https://github.com/BuildEmpire/apartment.git","svn_url":"https://github.com/BuildEmpire/apartment","homepage":"","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/BuildEmpire/apartment/pulls/1"},"html":{"href":"https://github.com/BuildEmpire/apartment/pull/1"},"issue":{"href":"https://api.github.com/repos/BuildEmpire/apartment/issues/1"},"comments":{"href":"https://api.github.com/repos/BuildEmpire/apartment/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/BuildEmpire/apartment/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/BuildEmpire/apartment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BuildEmpire/apartment/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/BuildEmpire/apartment/statuses/b341c4027ff82715cbfdc2f2be53a31861cec86a"}}}} | {
"id": 91303048,
"name": "BuildEmpire/apartment",
"url": "https://api.github.com/repos/BuildEmpire/apartment"
} | {
"id": 16223008,
"login": "uk-casmith",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16223008?",
"url": "https://api.github.com/users/uk-casmith"
} | {
"id": 6884652,
"login": "BuildEmpire",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6884652?",
"url": "https://api.github.com/orgs/BuildEmpire"
} | 2017-05-18T08:29:32 | 5895944002 | {"actor":{"display_login":"uk-casmith"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/comments/105345892","pull_request_review_id":26222062,"id":105345892,"diff_hunk":"@@ -952,14 +952,14 @@ def is_int(s):\n \n \n def is_process(s):\n- cmd = \"ps -ef -o comm= | grep -v grep | grep -qsE '\\b%s\\b'\" % s\n- if options.regression_tests:\n- print \".EXT\", cmd\n- proc = subprocess.Popen(cmd,\n- shell=True,\n- stdout=subprocess.PIPE)\n- proc.wait()\n- return proc.returncode == 0\n+ commands = set()\n+ pids = [pid for pid in os.listdir('/proc') if pid.isdigit()]\n+ for pid in pids:\n+ try:\n+ commands.add(os.path.basename(open(os.path.join('/proc', pid, 'cmdline'), 'rb').read().replace('\\x00', ' ').split(' ')[0]))\n+ except os.error:\n+ pass\n+ return s in commands","path":"crmsh/utils.py","position":19,"original_position":19,"commit_id":"8b84583eeabb9906caf8c354e3ecb3ba4f8f28da","original_commit_id":"8b84583eeabb9906caf8c354e3ecb3ba4f8f28da","user":{"login":"krig","id":25527,"avatar_url":"https://avatars3.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"body":"Yes, I think I prefer reading `/proc` since it is less error-prone than parsing the command output, but maybe I can make the code clearer :)","created_at":"2017-03-10T07:52:59Z","updated_at":"2017-03-10T07:52:59Z","html_url":"https://github.com/ClusterLabs/crmsh/pull/185#discussion_r105345892","pull_request_url":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/comments/105345892"},"html":{"href":"https://github.com/ClusterLabs/crmsh/pull/185#discussion_r105345892"},"pull_request":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/185","id":109911509,"html_url":"https://github.com/ClusterLabs/crmsh/pull/185","diff_url":"https://github.com/ClusterLabs/crmsh/pull/185.diff","patch_url":"https://github.com/ClusterLabs/crmsh/pull/185.patch","issue_url":"https://api.github.com/repos/ClusterLabs/crmsh/issues/185","number":185,"state":"open","locked":false,"title":"low: utils: Use /proc for process discovery","user":{"login":"krig","id":25527,"avatar_url":"https://avatars3.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"body":"Parsing ps output turns out to be tricky, so\r\nuse the /proc filesystem for process discovery\r\ninstead.\r\n\r\nFixes: #182","created_at":"2017-03-09T13:20:55Z","updated_at":"2017-03-10T07:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60a9bcddbfd129d2c907debd71ef57ebbb01f829","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/185/commits","review_comments_url":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/185/comments","review_comment_url":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClusterLabs/crmsh/issues/185/comments","statuses_url":"https://api.github.com/repos/ClusterLabs/crmsh/statuses/8b84583eeabb9906caf8c354e3ecb3ba4f8f28da","head":{"label":"krig:is-process-2","ref":"is-process-2","sha":"8b84583eeabb9906caf8c354e3ecb3ba4f8f28da","user":{"login":"krig","id":25527,"avatar_url":"https://avatars3.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"repo":{"id":18411355,"name":"crmsh","full_name":"krig/crmsh","owner":{"login":"krig","id":25527,"avatar_url":"https://avatars3.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krig/crmsh","description":"Command-line interface for High-Availability cluster management on GNU/Linux systems.","fork":true,"url":"https://api.github.com/repos/krig/crmsh","forks_url":"https://api.github.com/repos/krig/crmsh/forks","keys_url":"https://api.github.com/repos/krig/crmsh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krig/crmsh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krig/crmsh/teams","hooks_url":"https://api.github.com/repos/krig/crmsh/hooks","issue_events_url":"https://api.github.com/repos/krig/crmsh/issues/events{/number}","events_url":"https://api.github.com/repos/krig/crmsh/events","assignees_url":"https://api.github.com/repos/krig/crmsh/assignees{/user}","branches_url":"https://api.github.com/repos/krig/crmsh/branches{/branch}","tags_url":"https://api.github.com/repos/krig/crmsh/tags","blobs_url":"https://api.github.com/repos/krig/crmsh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krig/crmsh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krig/crmsh/git/refs{/sha}","trees_url":"https://api.github.com/repos/krig/crmsh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krig/crmsh/statuses/{sha}","languages_url":"https://api.github.com/repos/krig/crmsh/languages","stargazers_url":"https://api.github.com/repos/krig/crmsh/stargazers","contributors_url":"https://api.github.com/repos/krig/crmsh/contributors","subscribers_url":"https://api.github.com/repos/krig/crmsh/subscribers","subscription_url":"https://api.github.com/repos/krig/crmsh/subscription","commits_url":"https://api.github.com/repos/krig/crmsh/commits{/sha}","git_commits_url":"https://api.github.com/repos/krig/crmsh/git/commits{/sha}","comments_url":"https://api.github.com/repos/krig/crmsh/comments{/number}","issue_comment_url":"https://api.github.com/repos/krig/crmsh/issues/comments{/number}","contents_url":"https://api.github.com/repos/krig/crmsh/contents/{+path}","compare_url":"https://api.github.com/repos/krig/crmsh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krig/crmsh/merges","archive_url":"https://api.github.com/repos/krig/crmsh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krig/crmsh/downloads","issues_url":"https://api.github.com/repos/krig/crmsh/issues{/number}","pulls_url":"https://api.github.com/repos/krig/crmsh/pulls{/number}","milestones_url":"https://api.github.com/repos/krig/crmsh/milestones{/number}","notifications_url":"https://api.github.com/repos/krig/crmsh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krig/crmsh/labels{/name}","releases_url":"https://api.github.com/repos/krig/crmsh/releases{/id}","deployments_url":"https://api.github.com/repos/krig/crmsh/deployments","created_at":"2014-04-03T17:11:03Z","updated_at":"2016-01-11T10:01:54Z","pushed_at":"2017-03-09T20:57:29Z","git_url":"git://github.com/krig/crmsh.git","ssh_url":"[email protected]:krig/crmsh.git","clone_url":"https://github.com/krig/crmsh.git","svn_url":"https://github.com/krig/crmsh","homepage":"","size":20964,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ClusterLabs:master","ref":"master","sha":"841c55211e6115860691271e55d2d1cc7d378040","user":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars1.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":17904765,"name":"crmsh","full_name":"ClusterLabs/crmsh","owner":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars1.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterLabs/crmsh","description":"Command-line interface for High-Availability cluster management on GNU/Linux systems.","fork":false,"url":"https://api.github.com/repos/ClusterLabs/crmsh","forks_url":"https://api.github.com/repos/ClusterLabs/crmsh/forks","keys_url":"https://api.github.com/repos/ClusterLabs/crmsh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterLabs/crmsh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterLabs/crmsh/teams","hooks_url":"https://api.github.com/repos/ClusterLabs/crmsh/hooks","issue_events_url":"https://api.github.com/repos/ClusterLabs/crmsh/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterLabs/crmsh/events","assignees_url":"https://api.github.com/repos/ClusterLabs/crmsh/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterLabs/crmsh/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterLabs/crmsh/tags","blobs_url":"https://api.github.com/repos/ClusterLabs/crmsh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterLabs/crmsh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterLabs/crmsh/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterLabs/crmsh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterLabs/crmsh/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterLabs/crmsh/languages","stargazers_url":"https://api.github.com/repos/ClusterLabs/crmsh/stargazers","contributors_url":"https://api.github.com/repos/ClusterLabs/crmsh/contributors","subscribers_url":"https://api.github.com/repos/ClusterLabs/crmsh/subscribers","subscription_url":"https://api.github.com/repos/ClusterLabs/crmsh/subscription","commits_url":"https://api.github.com/repos/ClusterLabs/crmsh/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterLabs/crmsh/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterLabs/crmsh/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterLabs/crmsh/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterLabs/crmsh/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterLabs/crmsh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterLabs/crmsh/merges","archive_url":"https://api.github.com/repos/ClusterLabs/crmsh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterLabs/crmsh/downloads","issues_url":"https://api.github.com/repos/ClusterLabs/crmsh/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterLabs/crmsh/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterLabs/crmsh/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterLabs/crmsh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterLabs/crmsh/labels{/name}","releases_url":"https://api.github.com/repos/ClusterLabs/crmsh/releases{/id}","deployments_url":"https://api.github.com/repos/ClusterLabs/crmsh/deployments","created_at":"2014-03-19T13:18:01Z","updated_at":"2017-02-27T07:58:47Z","pushed_at":"2017-03-09T20:57:43Z","git_url":"git://github.com/ClusterLabs/crmsh.git","ssh_url":"[email protected]:ClusterLabs/crmsh.git","clone_url":"https://github.com/ClusterLabs/crmsh.git","svn_url":"https://github.com/ClusterLabs/crmsh","homepage":"","size":20907,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":31,"forks":40,"open_issues":31,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/185"},"html":{"href":"https://github.com/ClusterLabs/crmsh/pull/185"},"issue":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/issues/185"},"comments":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterLabs/crmsh/statuses/8b84583eeabb9906caf8c354e3ecb3ba4f8f28da"}}}} | {
"id": 17904765,
"name": "ClusterLabs/crmsh",
"url": "https://api.github.com/repos/ClusterLabs/crmsh"
} | {
"id": 25527,
"login": "krig",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25527?",
"url": "https://api.github.com/users/krig"
} | {
"id": 574912,
"login": "ClusterLabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/574912?",
"url": "https://api.github.com/orgs/ClusterLabs"
} | 2017-03-10T07:52:59 | 5468823217 | {"actor":{"display_login":"krig"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/comments/156399452","pull_request_review_id":82842041,"id":156399452,"diff_hunk":"@@ -80,18 +73,63 @@ test('parseBroadcast should return an object', () => {\n result.updatedAt.should.equal(date);\n });\n \n-test('getBroadcastCount should return a number', () => {\n- const broadcastId = stubs.getBroadcastId();\n- const mockCount = 42;\n- const mockWhere = {\n- count: function count() {\n- return mockCount;\n- },\n- };\n+test('aggregateMessagesForBroadcastId should call Messages.aggregate and return array', async () => {\n+ const array = ['tyrion', 'tywin', 'jamie', 'cersei'];\n+ sandbox.stub(Message, 'aggregate')\n+ .returns(Promise.resolve(array));\n+ const result = await broadcastHelper.aggregateMessagesForBroadcastId(broadcastId);\n+ Message.aggregate.should.have.been.called;\n+ result.should.equal(array);\n+});\n+\n+test('parseMessageDirection should return string', (t) => {\n+ t.deepEqual(broadcastHelper.parseMessageDirection('inbound'), 'inbound');\n+ t.deepEqual(broadcastHelper.parseMessageDirection('outbound-api-import'), 'outbound');\n+ t.deepEqual(broadcastHelper.parseMessageDirection('outbound-api-send'), 'outbound');\n+ t.deepEqual(broadcastHelper.parseMessageDirection('default'), 'outbound');\n+});\n+\n+test('aggregateMessagesForBroadcastId should throw if Messages.aggregate fails', async (t) => {\n+ sandbox.stub(Message, 'aggregate')\n+ .returns(Promise.reject(new Error()));\n+ await t.throws(broadcastHelper.aggregateMessagesForBroadcastId(broadcastId));\n+});\n \n- sandbox.stub(Message, 'where').returns(mockWhere);\n+test('formatStats should return default object when no data is passed', () => {\n+ sandbox.spy(broadcastHelper, 'parseMessageDirection');\n+ const result = broadcastHelper.formatStats();\n+ result.should.deep.equal(defaultStats);\n+ broadcastHelper.parseMessageDirection.should.not.have.been.called;\n+});\n+\n+test('formatStats should return object when array is passed', () => {\n+ sandbox.spy(broadcastHelper, 'parseMessageDirection');\n+ const inboundNoMacroCount = 43;\n+ const inboundConfirmedCampaignMacroCount = 16;\n+ const outboundCount = 205;\n+ const aggregateResults = [\n+ { _id: { direction: 'inbound' }, count: inboundNoMacroCount },\n+ {\n+ _id: { direction: 'inbound', macro: 'confirmedCampaign' },\n+ count: inboundConfirmedCampaignMacroCount,\n+ },\n+ { _id: { direction: 'outbound-api-import' }, count: outboundCount },\n+ ];\n+ const result = broadcastHelper.formatStats(aggregateResults);\n+ result.inbound.total.should.equal(inboundNoMacroCount + inboundConfirmedCampaignMacroCount);\n+ result.inbound.macros.confirmedCampaign.should.equal(inboundConfirmedCampaignMacroCount);\n+ result.outbound.total.should.equal(outboundCount);\n+ // TODO: Why have you forsaken me? This should be called.\n+ // broadcastHelper.parseMessageDirection.should.have.been.called;","path":"test/lib/lib-helpers/broadcast.test.js","position":106,"original_position":106,"commit_id":"a51824c900e912e97e3e264473dc763eb31dcda7","original_commit_id":"a51824c900e912e97e3e264473dc763eb31dcda7","user":{"login":"rapala61","id":863301,"avatar_url":"https://avatars3.githubusercontent.com/u/863301?v=4","gravatar_id":"","url":"https://api.github.com/users/rapala61","html_url":"https://github.com/rapala61","followers_url":"https://api.github.com/users/rapala61/followers","following_url":"https://api.github.com/users/rapala61/following{/other_user}","gists_url":"https://api.github.com/users/rapala61/gists{/gist_id}","starred_url":"https://api.github.com/users/rapala61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapala61/subscriptions","organizations_url":"https://api.github.com/users/rapala61/orgs","repos_url":"https://api.github.com/users/rapala61/repos","events_url":"https://api.github.com/users/rapala61/events{/privacy}","received_events_url":"https://api.github.com/users/rapala61/received_events","type":"User","site_admin":false},"body":"This is happening because `parseMessageDirection` is being stored in the `formatStats` scope, it's not accessing the exposed `module.exports.parseMessageDirection`. You would have to call it as `module.exports.parseMessageDirection` in https://github.com/DoSomething/gambit-conversations/pull/252/files#diff-7ccd6448aff97587fa8bdb77007f3c81R80. There are other tests in here that are assuming `parseMessageDirection` is being spied on, but in reality is not: Like [here](https://github.com/DoSomething/gambit-conversations/pull/252/files#diff-b309c91fe72283ac5533d45fb6ad0b16R99).","created_at":"2017-12-12T15:29:08Z","updated_at":"2017-12-12T15:32:25Z","html_url":"https://github.com/DoSomething/gambit-conversations/pull/252#discussion_r156399452","pull_request_url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/252","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/comments/156399452"},"html":{"href":"https://github.com/DoSomething/gambit-conversations/pull/252#discussion_r156399452"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/252"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/252","id":157675156,"html_url":"https://github.com/DoSomething/gambit-conversations/pull/252","diff_url":"https://github.com/DoSomething/gambit-conversations/pull/252.diff","patch_url":"https://github.com/DoSomething/gambit-conversations/pull/252.patch","issue_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/252","number":252,"state":"open","locked":false,"title":"Broadcast aggregate totals + stats cache","user":{"login":"aaronschachter","id":1236811,"avatar_url":"https://avatars2.githubusercontent.com/u/1236811?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false},"body":"* Returns aggregate count of messages for a given `broadcastId`, grouped by the Message `direction` and `macro` properties. Closes #243 \r\n * Adds a compound index to `Messages`. For now, this index will be created upon deploy -- which is something Mongoose suggests [disabling](http://mongoosejs.com/docs/guide.html#indexes). I've been pondering using a config variable to control this vs. always manually creating... \r\n\r\n* Adds a `broadcastStats` instance of Cacheman to cache the formatted data to return in API response.\r\n * Splits the `lib/middleware/broadcasts-single/stats` middleware into `stats-cache-get` and `stats-cache-set`","created_at":"2017-12-11T21:23:42Z","updated_at":"2017-12-12T15:32:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3498e68bd1a9ffc54e3e923c606a58ab3c10d96","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/252/commits","review_comments_url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/252/comments","review_comment_url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/252/comments","statuses_url":"https://api.github.com/repos/DoSomething/gambit-conversations/statuses/a51824c900e912e97e3e264473dc763eb31dcda7","head":{"label":"DoSomething:feature/243-macro","ref":"feature/243-macro","sha":"a51824c900e912e97e3e264473dc763eb31dcda7","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":93206005,"name":"gambit-conversations","full_name":"DoSomething/gambit-conversations","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/gambit-conversations","description":":black_joker: The DoSomething.org chatbot service for multi-platform conversations.","fork":false,"url":"https://api.github.com/repos/DoSomething/gambit-conversations","forks_url":"https://api.github.com/repos/DoSomething/gambit-conversations/forks","keys_url":"https://api.github.com/repos/DoSomething/gambit-conversations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/gambit-conversations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/gambit-conversations/teams","hooks_url":"https://api.github.com/repos/DoSomething/gambit-conversations/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/gambit-conversations/events","assignees_url":"https://api.github.com/repos/DoSomething/gambit-conversations/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/gambit-conversations/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/gambit-conversations/tags","blobs_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/gambit-conversations/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/gambit-conversations/languages","stargazers_url":"https://api.github.com/repos/DoSomething/gambit-conversations/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/gambit-conversations/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/gambit-conversations/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/gambit-conversations/subscription","commits_url":"https://api.github.com/repos/DoSomething/gambit-conversations/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/gambit-conversations/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/gambit-conversations/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/gambit-conversations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/gambit-conversations/merges","archive_url":"https://api.github.com/repos/DoSomething/gambit-conversations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/gambit-conversations/downloads","issues_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/gambit-conversations/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/gambit-conversations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/gambit-conversations/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/gambit-conversations/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/gambit-conversations/deployments","created_at":"2017-06-02T21:42:25Z","updated_at":"2017-12-09T00:49:04Z","pushed_at":"2017-12-12T07:03:54Z","git_url":"git://github.com/DoSomething/gambit-conversations.git","ssh_url":"[email protected]:DoSomething/gambit-conversations.git","clone_url":"https://github.com/DoSomething/gambit-conversations.git","svn_url":"https://github.com/DoSomething/gambit-conversations","homepage":"","size":729,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"6f3b56f032780eb3d2c71c3c18be541b81bc4422","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":93206005,"name":"gambit-conversations","full_name":"DoSomething/gambit-conversations","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/gambit-conversations","description":":black_joker: The DoSomething.org chatbot service for multi-platform conversations.","fork":false,"url":"https://api.github.com/repos/DoSomething/gambit-conversations","forks_url":"https://api.github.com/repos/DoSomething/gambit-conversations/forks","keys_url":"https://api.github.com/repos/DoSomething/gambit-conversations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/gambit-conversations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/gambit-conversations/teams","hooks_url":"https://api.github.com/repos/DoSomething/gambit-conversations/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/gambit-conversations/events","assignees_url":"https://api.github.com/repos/DoSomething/gambit-conversations/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/gambit-conversations/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/gambit-conversations/tags","blobs_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/gambit-conversations/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/gambit-conversations/languages","stargazers_url":"https://api.github.com/repos/DoSomething/gambit-conversations/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/gambit-conversations/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/gambit-conversations/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/gambit-conversations/subscription","commits_url":"https://api.github.com/repos/DoSomething/gambit-conversations/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/gambit-conversations/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/gambit-conversations/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/gambit-conversations/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/gambit-conversations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/gambit-conversations/merges","archive_url":"https://api.github.com/repos/DoSomething/gambit-conversations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/gambit-conversations/downloads","issues_url":"https://api.github.com/repos/DoSomething/gambit-conversations/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/gambit-conversations/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/gambit-conversations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/gambit-conversations/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/gambit-conversations/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/gambit-conversations/deployments","created_at":"2017-06-02T21:42:25Z","updated_at":"2017-12-09T00:49:04Z","pushed_at":"2017-12-12T07:03:54Z","git_url":"git://github.com/DoSomething/gambit-conversations.git","ssh_url":"[email protected]:DoSomething/gambit-conversations.git","clone_url":"https://github.com/DoSomething/gambit-conversations.git","svn_url":"https://github.com/DoSomething/gambit-conversations","homepage":"","size":729,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/252"},"html":{"href":"https://github.com/DoSomething/gambit-conversations/pull/252"},"issue":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/252"},"comments":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/gambit-conversations/statuses/a51824c900e912e97e3e264473dc763eb31dcda7"}},"author_association":"OWNER"}} | {
"id": 93206005,
"name": "DoSomething/gambit-conversations",
"url": "https://api.github.com/repos/DoSomething/gambit-conversations"
} | {
"id": 863301,
"login": "rapala61",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/863301?",
"url": "https://api.github.com/users/rapala61"
} | {
"id": 731685,
"login": "DoSomething",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/731685?",
"url": "https://api.github.com/orgs/DoSomething"
} | 2017-12-12T15:29:08 | 6977751491 | {"actor":{"display_login":"rapala61"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/phoenix/pulls/comments/124400568","pull_request_review_id":46685834,"id":124400568,"diff_hunk":"@@ -189,7 +191,120 @@ function _signup_resource_index($user, $users, $campaigns, $count, $page, $compe\n 'runs' => $runs,\n ];\n \n- return (new SignupTransformer)->index($parameters);\n+ if (variable_get('rogue_collection', FALSE)) {\n+ if ($user) {\n+ $northstar_user_id = dosomething_user_get_northstar_id($user);\n+ $user_object = user_load($user);\n+ }\n+\n+ $rogue = dosomething_rogue_client();\n+\n+ $response = $rogue->getActivity([\n+ 'filter' => [\n+ 'northstar_id' => $northstar_user_id,\n+ 'campaign_id' => $campaigns,\n+ ],\n+ ]);\n+\n+ if ($response) {\n+ $transformed_response = collect($response['data'])->map(function($signup) {\n+ $campaign = node_load($signup['campaign_id']);\n+ $campaign = Campaign::get($signup['campaign_id']);\n+\n+ if ($signup['posts']['data']) {\n+ $posts = [];\n+ $flagged = FALSE;\n+\n+ foreach ($signup['posts']['data'] as $post) {\n+ $formatted_post = [];\n+ $formatted_post['id'] = $post['id'];\n+ $formatted_post['status'] = $post['status'];\n+ $formatted_post['caption'] = $post['media']['caption'];\n+ $formatted_post['uri'] = null;\n+ $formatted_post['media']['uri'] = $post['media']['url'];\n+ $formatted_post['media']['type'] = 'image';\n+ $formatted_post['created_at'] = (new Carbon($post['created_at']))->timestamp;\n+\n+ if ($post['reactions']) {\n+ $reactions = [];\n+ foreach ($post['reactions'] as $reaction) {\n+ $formatted_reaction = [];\n+ $formatted_reaction['id'] = $reaction['id'];\n+ $formatted_reaction['term'] = 'heart';\n+ $formatted_reaction['reportback_item'] = $reaction['post_id'];\n+ $formatted_reaction['user'] = $reaction['northstar_id'];\n+ $formatted_reaction['uri'] = null;\n+ array_push($reactions, $formatted_reaction);\n+ }\n+ }\n+\n+ $formatted_post['kudos'] = $reactions ? $reactions : null;\n+ array_push($posts, $formatted_post);\n+\n+ if ($post['status'] === 'rejected') {\n+ $flagged = TRUE;\n+ }\n+ }\n+ }\n+\n+ return [\n+ 'id' => $signup['signup_id'],\n+ 'created_at' => (new Carbon($signup['created_at']))->timestamp,\n+ 'campaign_run' => [\n+ 'id' => $signup['campaign_run_id'],\n+ 'current' => (dosomething_helpers_get_current_campaign_run_for_user($signup['campaign_id'], $user_object)->nid == $signup['campaign_run_id']) ? TRUE : FALSE,\n+ ],\n+ 'uri' => null,\n+ 'campaign' => [\n+ 'id' => $signup['campaign_id'],\n+ 'title' => $campaign->title,\n+ 'campaign_runs' => $campaign->campaign_runs,\n+ 'language' => [\n+ 'language_code' => $campaign->language['language_code'],\n+ 'prefix' => $campaign->language['prefix'],\n+ ],\n+ 'translations' => $campaign->translations,\n+ 'tagline' => $campaign->tagline,\n+ 'status' => $campaign->status,\n+ 'type' => $campaign->type,\n+ 'reportback_info' => $campaign->reportback_info,\n+ ],\n+ 'reportback' => [\n+ 'id' => $signup['signup_id'],\n+ 'created_at' => (new Carbon($signup['created_at']))->timestamp,\n+ 'updated_at' => (new Carbon($signup['updated_at']))->timestamp,\n+ 'quantity' => $signup['quantity'],\n+ 'uri' => null,\n+ 'why_participated' => $signup['why_participated'],\n+ 'flagged' => $flagged,\n+ 'reportback_items' => [\n+ 'total' => count($signup['posts']['data']),\n+ 'data' => $posts,\n+ ],\n+ ],\n+ ];\n+ });\n+ }\n+ }\n+\n+ if ($transformed_response) {\n+ $final_response = [];\n+\n+ // Mimic meta data response\n+ $final_response['meta'] = $response['meta'];\n+\n+ $final_response['meta']['pagination']['links']['next_uri'] = $response['meta']['pagination']['links']['next'];","path":"lib/modules/dosomething/dosomething_api/resources/signup_resource.inc","position":111,"original_position":115,"commit_id":"54be8ef2f8934de83286b6de3e5fd3ef3e784324","original_commit_id":"d3bafc639ccbaabd28bb0aa6b420a457ea133cf6","user":{"login":"chloealee","id":9019452,"avatar_url":"https://avatars1.githubusercontent.com/u/9019452?v=3","gravatar_id":"","url":"https://api.github.com/users/chloealee","html_url":"https://github.com/chloealee","followers_url":"https://api.github.com/users/chloealee/followers","following_url":"https://api.github.com/users/chloealee/following{/other_user}","gists_url":"https://api.github.com/users/chloealee/gists{/gist_id}","starred_url":"https://api.github.com/users/chloealee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chloealee/subscriptions","organizations_url":"https://api.github.com/users/chloealee/orgs","repos_url":"https://api.github.com/users/chloealee/repos","events_url":"https://api.github.com/users/chloealee/events{/privacy}","received_events_url":"https://api.github.com/users/chloealee/received_events","type":"User","site_admin":false},"body":"ah true! what would be the phoenix url we'd want to send them to in this case? ","created_at":"2017-06-27T21:27:03Z","updated_at":"2017-06-27T21:27:03Z","html_url":"https://github.com/DoSomething/phoenix/pull/7414#discussion_r124400568","pull_request_url":"https://api.github.com/repos/DoSomething/phoenix/pulls/7414","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/comments/124400568"},"html":{"href":"https://github.com/DoSomething/phoenix/pull/7414#discussion_r124400568"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/7414"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/phoenix/pulls/7414","id":125674931,"html_url":"https://github.com/DoSomething/phoenix/pull/7414","diff_url":"https://github.com/DoSomething/phoenix/pull/7414.diff","patch_url":"https://github.com/DoSomething/phoenix/pull/7414.patch","issue_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7414","number":7414,"state":"open","locked":false,"title":"When Rogue is on, user can now signup via SMS for a campaign ","user":{"login":"chloealee","id":9019452,"avatar_url":"https://avatars1.githubusercontent.com/u/9019452?v=3","gravatar_id":"","url":"https://api.github.com/users/chloealee","html_url":"https://github.com/chloealee","followers_url":"https://api.github.com/users/chloealee/followers","following_url":"https://api.github.com/users/chloealee/following{/other_user}","gists_url":"https://api.github.com/users/chloealee/gists{/gist_id}","starred_url":"https://api.github.com/users/chloealee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chloealee/subscriptions","organizations_url":"https://api.github.com/users/chloealee/orgs","repos_url":"https://api.github.com/users/chloealee/repos","events_url":"https://api.github.com/users/chloealee/events{/privacy}","received_events_url":"https://api.github.com/users/chloealee/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\n- Fixes bug so now when Rogue is on, user can go through SMS flow when texting in keyword to 38383. \r\n - When user texts keyword, first check if signup exists in Rogue and if not, create a new signup. \r\n - Returns Rogue signup object when Phoenix's `GET /signups` endpoint is hit. \r\n - Returns Rogue `signup_id` when Phoenix's `/campaigns/[nid]/signup` is hit.\r\n- Removes `dosomething_rogue_check_sid_and_store_ref` and anywhere that uses this since we no longer post info back to Phoenix from Rogue.\r\n\r\n#### How should this be reviewed?\r\n- Turn Rogue on. \r\n- Signup for a new campaign. \r\n- Make sure signup makes it to Rogue. \r\n- Hit `/campaigns/[nid]/signup` and make sure Rogue signup id is returned. \r\n- Make sure signing up via SMS works (both for a new and existing signup). \r\n\r\n#### Any background context you want to provide?\r\nJust want to flag for @aaronschachter in case you see any issues because of this PR! \r\n\r\n#### Relevant tickets\r\nFixes https://trello.com/c/S7cjnFL1/482-3-when-rogue-is-turned-on-user-cannot-sign-up-via-sms\r\n\r\n#### Checklist\r\n- [ ] Documentation added for new features/changed endpoints.\r\n- [ ] Tested on staging.\r\n- [ ] Pinged a PM if this is a larger PR that would benefit from some additional testing love\r\n- [ ] Post a message in #phoenix if this includes something that causes a rebuild! \r\n","created_at":"2017-06-14T19:31:15Z","updated_at":"2017-06-27T21:27:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91971f8ff7a51a67b35f4d08d6b522d21cf501ce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sbsmith86","id":1700409,"avatar_url":"https://avatars3.githubusercontent.com/u/1700409?v=3","gravatar_id":"","url":"https://api.github.com/users/sbsmith86","html_url":"https://github.com/sbsmith86","followers_url":"https://api.github.com/users/sbsmith86/followers","following_url":"https://api.github.com/users/sbsmith86/following{/other_user}","gists_url":"https://api.github.com/users/sbsmith86/gists{/gist_id}","starred_url":"https://api.github.com/users/sbsmith86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbsmith86/subscriptions","organizations_url":"https://api.github.com/users/sbsmith86/orgs","repos_url":"https://api.github.com/users/sbsmith86/repos","events_url":"https://api.github.com/users/sbsmith86/events{/privacy}","received_events_url":"https://api.github.com/users/sbsmith86/received_events","type":"User","site_admin":false},{"login":"katiecrane","id":4240292,"avatar_url":"https://avatars2.githubusercontent.com/u/4240292?v=3","gravatar_id":"","url":"https://api.github.com/users/katiecrane","html_url":"https://github.com/katiecrane","followers_url":"https://api.github.com/users/katiecrane/followers","following_url":"https://api.github.com/users/katiecrane/following{/other_user}","gists_url":"https://api.github.com/users/katiecrane/gists{/gist_id}","starred_url":"https://api.github.com/users/katiecrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katiecrane/subscriptions","organizations_url":"https://api.github.com/users/katiecrane/orgs","repos_url":"https://api.github.com/users/katiecrane/repos","events_url":"https://api.github.com/users/katiecrane/events{/privacy}","received_events_url":"https://api.github.com/users/katiecrane/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/phoenix/pulls/7414/commits","review_comments_url":"https://api.github.com/repos/DoSomething/phoenix/pulls/7414/comments","review_comment_url":"https://api.github.com/repos/DoSomething/phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7414/comments","statuses_url":"https://api.github.com/repos/DoSomething/phoenix/statuses/54be8ef2f8934de83286b6de3e5fd3ef3e784324","head":{"label":"DoSomething:sms-bug","ref":"sms-bug","sha":"54be8ef2f8934de83286b6de3e5fd3ef3e784324","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars1.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":13592927,"name":"phoenix","full_name":"DoSomething/phoenix","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars1.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/phoenix","description":":fire: The DoSomething.org website & content API.","fork":false,"url":"https://api.github.com/repos/DoSomething/phoenix","forks_url":"https://api.github.com/repos/DoSomething/phoenix/forks","keys_url":"https://api.github.com/repos/DoSomething/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/phoenix/teams","hooks_url":"https://api.github.com/repos/DoSomething/phoenix/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/phoenix/events","assignees_url":"https://api.github.com/repos/DoSomething/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/phoenix/tags","blobs_url":"https://api.github.com/repos/DoSomething/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/phoenix/languages","stargazers_url":"https://api.github.com/repos/DoSomething/phoenix/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/phoenix/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/phoenix/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/phoenix/subscription","commits_url":"https://api.github.com/repos/DoSomething/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/phoenix/merges","archive_url":"https://api.github.com/repos/DoSomething/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/phoenix/downloads","issues_url":"https://api.github.com/repos/DoSomething/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/phoenix/deployments","created_at":"2013-10-15T14:50:48Z","updated_at":"2017-06-13T19:33:48Z","pushed_at":"2017-06-27T21:09:53Z","git_url":"git://github.com/DoSomething/phoenix.git","ssh_url":"[email protected]:DoSomething/phoenix.git","clone_url":"https://github.com/DoSomething/phoenix.git","svn_url":"https://github.com/DoSomething/phoenix","homepage":"https://www.dosomething.org/","size":20906,"stargazers_count":29,"watchers_count":29,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":58,"forks":20,"open_issues":58,"watchers":29,"default_branch":"dev"}},"base":{"label":"DoSomething:dev","ref":"dev","sha":"c5968b7a4c39645d0510c6c252bc5e005b238720","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars1.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":13592927,"name":"phoenix","full_name":"DoSomething/phoenix","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars1.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/phoenix","description":":fire: The DoSomething.org website & content API.","fork":false,"url":"https://api.github.com/repos/DoSomething/phoenix","forks_url":"https://api.github.com/repos/DoSomething/phoenix/forks","keys_url":"https://api.github.com/repos/DoSomething/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/phoenix/teams","hooks_url":"https://api.github.com/repos/DoSomething/phoenix/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/phoenix/events","assignees_url":"https://api.github.com/repos/DoSomething/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/phoenix/tags","blobs_url":"https://api.github.com/repos/DoSomething/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/phoenix/languages","stargazers_url":"https://api.github.com/repos/DoSomething/phoenix/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/phoenix/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/phoenix/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/phoenix/subscription","commits_url":"https://api.github.com/repos/DoSomething/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/phoenix/merges","archive_url":"https://api.github.com/repos/DoSomething/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/phoenix/downloads","issues_url":"https://api.github.com/repos/DoSomething/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/phoenix/deployments","created_at":"2013-10-15T14:50:48Z","updated_at":"2017-06-13T19:33:48Z","pushed_at":"2017-06-27T21:09:53Z","git_url":"git://github.com/DoSomething/phoenix.git","ssh_url":"[email protected]:DoSomething/phoenix.git","clone_url":"https://github.com/DoSomething/phoenix.git","svn_url":"https://github.com/DoSomething/phoenix","homepage":"https://www.dosomething.org/","size":20906,"stargazers_count":29,"watchers_count":29,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":58,"forks":20,"open_issues":58,"watchers":29,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/7414"},"html":{"href":"https://github.com/DoSomething/phoenix/pull/7414"},"issue":{"href":"https://api.github.com/repos/DoSomething/phoenix/issues/7414"},"comments":{"href":"https://api.github.com/repos/DoSomething/phoenix/issues/7414/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/7414/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/7414/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/phoenix/statuses/54be8ef2f8934de83286b6de3e5fd3ef3e784324"}}}} | {
"id": 13592927,
"name": "DoSomething/phoenix",
"url": "https://api.github.com/repos/DoSomething/phoenix"
} | {
"id": 9019452,
"login": "chloealee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9019452?",
"url": "https://api.github.com/users/chloealee"
} | {
"id": 731685,
"login": "DoSomething",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/731685?",
"url": "https://api.github.com/orgs/DoSomething"
} | 2017-06-27T21:27:03 | 6150017845 | {"actor":{"display_login":"chloealee"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/tower/pulls/comments/106213384","pull_request_review_id":27124681,"id":106213384,"diff_hunk":"@@ -4,18 +4,18 @@\n - role: dosomething.web\n - role: dosomething.phoenix\n \n-# sudo mount -t nfs -o nolock 172.20.100.20:/drupal-static-files /mnt\n-#- name: Mount shared folder to Drupal WebApp\n-# hosts: tag_Role_Thor_WebApp\n-# tasks:\n-# - name: Install nfs-common\n-# become: yes\n-# apt: name=nfs-common state=latest\n-# - name: Mount NFS\n-# become: yes\n-# mount: >\n-# name=/var/www/www.dosomething.org/shared/files\n-# src='172.20.100.20:/drupal-static-files'\n-# fstype=nfs\n-# opts=nolock\n-# state=mounted\n+- name: Mount shared folder to Drupal WebApp\n+ hosts: tag_Role_Thor_WebApp\n+ tasks:\n+ - name: Install nfs-common\n+ become: yes\n+ apt: name=nfs-common state=latest\n+\n+ - name: Mount NFS\n+ become: yes\n+ mount: >\n+ name=/var/www/www.dosomething.org/shared/files\n+ src='fs-3a64a373.efs.us-east-1.amazonaws.com:/'\n+ fstype=nfs\n+ opts=nolock","path":"thor-webapp.yml","position":32,"original_position":32,"commit_id":"b8cbf56f8dc7baf5b719f803afee20c1a1220518","original_commit_id":"b8cbf56f8dc7baf5b719f803afee20c1a1220518","user":{"login":"pnasrat","id":13798,"avatar_url":"https://avatars2.githubusercontent.com/u/13798?v=3","gravatar_id":"","url":"https://api.github.com/users/pnasrat","html_url":"https://github.com/pnasrat","followers_url":"https://api.github.com/users/pnasrat/followers","following_url":"https://api.github.com/users/pnasrat/following{/other_user}","gists_url":"https://api.github.com/users/pnasrat/gists{/gist_id}","starred_url":"https://api.github.com/users/pnasrat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnasrat/subscriptions","organizations_url":"https://api.github.com/users/pnasrat/orgs","repos_url":"https://api.github.com/users/pnasrat/repos","events_url":"https://api.github.com/users/pnasrat/events{/privacy}","received_events_url":"https://api.github.com/users/pnasrat/received_events","type":"User","site_admin":false},"body":"The mount points seem to have more options than this - should validate.","created_at":"2017-03-15T16:24:48Z","updated_at":"2017-03-15T16:24:48Z","html_url":"https://github.com/DoSomething/tower/pull/218#discussion_r106213384","pull_request_url":"https://api.github.com/repos/DoSomething/tower/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/tower/pulls/comments/106213384"},"html":{"href":"https://github.com/DoSomething/tower/pull/218#discussion_r106213384"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/tower/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/tower/pulls/218","id":110879224,"html_url":"https://github.com/DoSomething/tower/pull/218","diff_url":"https://github.com/DoSomething/tower/pull/218.diff","patch_url":"https://github.com/DoSomething/tower/pull/218.patch","issue_url":"https://api.github.com/repos/DoSomething/tower/issues/218","number":218,"state":"open","locked":false,"title":"Updating Thor Phoenix NFS mount point to region EFS volume.","user":{"login":"sheyd","id":4562565,"avatar_url":"https://avatars3.githubusercontent.com/u/4562565?v=3","gravatar_id":"","url":"https://api.github.com/users/sheyd","html_url":"https://github.com/sheyd","followers_url":"https://api.github.com/users/sheyd/followers","following_url":"https://api.github.com/users/sheyd/following{/other_user}","gists_url":"https://api.github.com/users/sheyd/gists{/gist_id}","starred_url":"https://api.github.com/users/sheyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheyd/subscriptions","organizations_url":"https://api.github.com/users/sheyd/orgs","repos_url":"https://api.github.com/users/sheyd/repos","events_url":"https://api.github.com/users/sheyd/events{/privacy}","received_events_url":"https://api.github.com/users/sheyd/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nUpdates NFS mount value for Thor Phoenix Web servers.\r\n\r\n#### Where should the reviewer start?\r\nOne file change below.\r\n\r\n#### How should this be manually tested?\r\nRun locally against Thor Phoenix box and checking with Morgan and Pris beforehand.\r\n\r\n#### Any background context you want to provide?\r\nWe migrated to AWS EFS months ago, but never updated this value. Running Ansible playbooks against Thor webserver can break stuff.\r\n\r\n","created_at":"2017-03-15T16:00:34Z","updated_at":"2017-03-15T16:24:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3ad82ad5609e97cf03fb13b0106d83b00eedb15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/tower/pulls/218/commits","review_comments_url":"https://api.github.com/repos/DoSomething/tower/pulls/218/comments","review_comment_url":"https://api.github.com/repos/DoSomething/tower/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/tower/issues/218/comments","statuses_url":"https://api.github.com/repos/DoSomething/tower/statuses/b8cbf56f8dc7baf5b719f803afee20c1a1220518","head":{"label":"DoSomething:nfs-efs-mount-thor","ref":"nfs-efs-mount-thor","sha":"b8cbf56f8dc7baf5b719f803afee20c1a1220518","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars1.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":33142704,"name":"tower","full_name":"DoSomething/tower","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars1.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/tower","description":"Ansible Tower Playbooks","fork":false,"url":"https://api.github.com/repos/DoSomething/tower","forks_url":"https://api.github.com/repos/DoSomething/tower/forks","keys_url":"https://api.github.com/repos/DoSomething/tower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/tower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/tower/teams","hooks_url":"https://api.github.com/repos/DoSomething/tower/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/tower/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/tower/events","assignees_url":"https://api.github.com/repos/DoSomething/tower/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/tower/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/tower/tags","blobs_url":"https://api.github.com/repos/DoSomething/tower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/tower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/tower/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/tower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/tower/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/tower/languages","stargazers_url":"https://api.github.com/repos/DoSomething/tower/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/tower/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/tower/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/tower/subscription","commits_url":"https://api.github.com/repos/DoSomething/tower/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/tower/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/tower/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/tower/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/tower/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/tower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/tower/merges","archive_url":"https://api.github.com/repos/DoSomething/tower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/tower/downloads","issues_url":"https://api.github.com/repos/DoSomething/tower/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/tower/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/tower/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/tower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/tower/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/tower/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/tower/deployments","created_at":"2015-03-30T19:15:39Z","updated_at":"2016-02-10T22:00:49Z","pushed_at":"2017-03-15T16:00:35Z","git_url":"git://github.com/DoSomething/tower.git","ssh_url":"[email protected]:DoSomething/tower.git","clone_url":"https://github.com/DoSomething/tower.git","svn_url":"https://github.com/DoSomething/tower","homepage":null,"size":451,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":19,"forks":5,"open_issues":19,"watchers":0,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"3a13fb774ab0b4225644d0e63f3204d7e3c26d6c","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars1.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":33142704,"name":"tower","full_name":"DoSomething/tower","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars1.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/tower","description":"Ansible Tower Playbooks","fork":false,"url":"https://api.github.com/repos/DoSomething/tower","forks_url":"https://api.github.com/repos/DoSomething/tower/forks","keys_url":"https://api.github.com/repos/DoSomething/tower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/tower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/tower/teams","hooks_url":"https://api.github.com/repos/DoSomething/tower/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/tower/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/tower/events","assignees_url":"https://api.github.com/repos/DoSomething/tower/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/tower/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/tower/tags","blobs_url":"https://api.github.com/repos/DoSomething/tower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/tower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/tower/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/tower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/tower/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/tower/languages","stargazers_url":"https://api.github.com/repos/DoSomething/tower/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/tower/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/tower/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/tower/subscription","commits_url":"https://api.github.com/repos/DoSomething/tower/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/tower/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/tower/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/tower/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/tower/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/tower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/tower/merges","archive_url":"https://api.github.com/repos/DoSomething/tower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/tower/downloads","issues_url":"https://api.github.com/repos/DoSomething/tower/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/tower/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/tower/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/tower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/tower/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/tower/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/tower/deployments","created_at":"2015-03-30T19:15:39Z","updated_at":"2016-02-10T22:00:49Z","pushed_at":"2017-03-15T16:00:35Z","git_url":"git://github.com/DoSomething/tower.git","ssh_url":"[email protected]:DoSomething/tower.git","clone_url":"https://github.com/DoSomething/tower.git","svn_url":"https://github.com/DoSomething/tower","homepage":null,"size":451,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":19,"forks":5,"open_issues":19,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/tower/pulls/218"},"html":{"href":"https://github.com/DoSomething/tower/pull/218"},"issue":{"href":"https://api.github.com/repos/DoSomething/tower/issues/218"},"comments":{"href":"https://api.github.com/repos/DoSomething/tower/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/tower/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/tower/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/tower/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/tower/statuses/b8cbf56f8dc7baf5b719f803afee20c1a1220518"}}}} | {
"id": 33142704,
"name": "DoSomething/tower",
"url": "https://api.github.com/repos/DoSomething/tower"
} | {
"id": 13798,
"login": "pnasrat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13798?",
"url": "https://api.github.com/users/pnasrat"
} | {
"id": 731685,
"login": "DoSomething",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/731685?",
"url": "https://api.github.com/orgs/DoSomething"
} | 2017-03-15T16:24:48 | 5499495046 | {"actor":{"display_login":"pnasrat"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/comments/102340509","pull_request_review_id":23094226,"id":102340509,"diff_hunk":"@@ -229,77 +230,35 @@\n \t\t\t\t\t\t</select>\n \t\t\t\t\t</label>\n \t\t\t\t</div>\n-\t\t\t\t<div id=\"setUnitsControl\" style=\"\">\n+\t\t\t\t-->\n+\t\t\t\t<div id=\"unitsSelectorContainer\" style=\"\">\n \t\t\t\t\t<!-- Setting display:none in the widget itself doesn't work.\n \t\t\t\t\t setting display:none in the label doesn't work in FireFox. -->\n-\t\t\t\t\t<label for=\"setUnits\">Units\n-\t\t\t\t\t\t<input id=\"setUnits\" data-dojo-type=\"dijit/form/ComboBox\" style=\"width:6em\">\n+\t\t\t\t\t<label for=\"unitsSelector\">Units\n+\t\t\t\t\t\t<input id=\"unitsSelector\" data-dojo-type=\"dijit/form/ComboBox\" style=\"width:6em\">\n \t\t\t\t\t</label>\n \t\t\t\t</div>\n \t\t\t</div>\n \t\t\t\n-\t\t\t<div id=\"setRootNode\" class=\"fieldgroup\" style=\"\">\n-\t\t\t\t<label for =\"markRootNode\" title =\"Mark this node as a root node.\">Root:</label>\n-\t\t\t\t<input id =\"markRootNode\" name =\"markRootNode\" data-dojo-type=\"dijit/form/CheckBox\" value=\"agreed\" checked=\"false\"/>\n+\t\t\t<div id=\"rootNodeToggleContainer\" class=\"fieldgroup\" style=\"display: none;\">\n+\t\t\t\t<label for =\"rootNodeToggleCheckbox\" title =\"Mark this node as a root node.\">Root:</label>\n+\t\t\t\t<input id =\"rootNodeToggleCheckbox\" name =\"markRootNode\" data-dojo-type=\"dijit/form/CheckBox\" value=\"agreed\" checked=\"false\"/>\n \t\t\t\t<div id=\"questionMarkRoot\" class=\"questionMark\"></div>\n \t\t\t</div>\n \n-\t\t\t<div id=\"setDynamicNode\" class=\"fieldgroup\" style=\"\">\n-\t\t\t\t<label for =\"markDynamicNode\" title =\"Mark this node as a root node.\">Dynamic:</label>\n-\t\t\t\t<input id =\"markDynamicNode\" name =\"markDynamicNode\" data-dojo-type=\"dijit/form/CheckBox\" value=\"agreed\" checked=\"false\"/>\n+\t\t\t<div id=\"dynamicNodeToggleContainer\" class=\"fieldgroup\" style=\"display: none;\">\n+\t\t\t\t<label for =\"dynamicNodeToggleCheckbox\" title =\"Mark this node as a root node.\">Dynamic:</label>\n+\t\t\t\t<input id =\"dynamicNodeToggleCheckbox\" name =\"markDynamicNode\" data-dojo-type=\"dijit/form/CheckBox\" value=\"agreed\" checked=\"false\"/>\n \t\t\t\t<div id=\"questionMarkDynamic\" class=\"questionMark\"></div>\n \t\t\t</div>\n \n-\t\t\t<div class=\"fieldgroup\">\n-\t\t\t\t<label for=\"messageBox\">Messages</label>\n-\t\t\t\t<div id=\"messageBox\" class=\"textscroll\" data-dojo-type=\"dijit/layout/ContentPane\"></div>\n-\n-\t\t\t\t<div style=\"margin-bottom:10px; display:block\">\n-\t\t\t\t\t<span> </span>\n-\t\t\t\t\t<button id=\"closeButton\" type=\"button\" data-dojo-type=\"dijit/form/Button\" iconClass=\"dijitNoIcon\" style=\"float:right;\">Done</button>\n-\t\t\t\t\t<button id=\"deleteButton\" type=\"button\" data-dojo-type=\"dijit/form/Button\" iconClass=\"dijitNoIcon\" style=\"float:left;\">Delete Node</button>\n-\t\t\t\t</div>\n-\t\t\t</div>\n-\n-\t\t</div><!-- end of quantity node editor -->\n-\n-\t\t<!-- crisis Alert -->\n-\t\t<div class=\"claro crisisDialog\" id=\"crisisAlertMessage\" data-dojo-type=\"dijit.Dialog\" title=\"Message\">\n-\t\t\t<div id = \"crisisMessage\"> </div>\n-\t\t\t<button id=\"OkButton\" type=\"button\" data-dojo-type=\"dijit/form/Button\">OK</button>\n-\t\t</div> \n-\t\t<!-- Equation Node Editor-->\n-\t\t<div class=\"claro sameedit\" data-dojo-type=\"dijit/Dialog\" id=\"equationNodeEditor\">\n-\t\t\t\n-\t\t\t<div id=\"studentModelControl2\" class=\"fieldgroup\">\n-\t\t\t\t<label style=\"width:20ex;\" for=\"setStudentNode2\">Given to student</label>\n-\t\t\t\t<input id=\"setStudentNode2\" name=\"markStudentNode2\" data-dojo-type=\"dijit/form/CheckBox\" checked=\"false\"/>\n-\t\t\t</div>\n-\t\t\t<div id=\"selectModelControl2\" class=\"fieldgroup\" style=\"display:none\" >\n-\t\t\t\t<label for=\"selectModel2\">Select Model</label>\n-\t\t\t\t<select id=\"selectModel2\" data-dojo-type=\"dijit/form/Select\">\n-\t\t\t\t\t<option value='correct' selected>Author's Values</option>\n-\t\t\t\t\t<option value='given'>Initial Student Values</option>\n-\t\t\t\t</select>\n-\t\t\t</div>\n-\n-\t\t\t<div class=\"fieldgroup\">\n-\t\t\t\t<div id=\"descriptionControlAuthor2\" class=\"fieldgroup\" style=\"\">\n-\t\t\t\t\t<span class=\"fixedwidth\">\n-\t\t\t\t\t\t<div id=\"authorDescriptionQuestionMark2\" class=\"questionMark\"></div>\n-\t\t\t\t\t\t<label for=\"setDescription2\">Explanation</label>\n-\t\t\t\t\t</span>\n-\t\t\t\t\t<input id=\"setDescription2\" data-dojo-type=\"dijit/form/ComboBox\">\n-\t\t\t\t</div>\n-\t\t\t</div>\n-\n-\t\t\t<div class=\"ExpressionContainer\" id=\"expressionDiv\" style=\"\">\n+\t\t\t<div class=\"equationInputsContainer\" id=\"expressionDiv\" style=\"display: none;\">\n \t\t\t\t<div class=\"fieldgroup\">\n \t\t\t\t\t <div class=\"vertical\">\n \t\t\t\t\t\t<div id=\"equationLabel\"></div>\n-\t\t\t\t\t\t\t<div id=\"nameControl2\" class=\"fieldgroup\">\n-\t\t\t\t\t\t\t\t<label for=\"setName2\">Equation</label>\n-\t\t\t\t\t\t\t\t\t<textarea id=\"setName2\" rows=4 cols=50 data-dojo-type=\"dijit/form/SimpleTextarea\t\" style=\"min-height:60px;\"></textarea>\n+\t\t\t\t\t\t\t<div id=\"equationInputboxContainer\" class=\"fieldgroup\">\n+\t\t\t\t\t\t\t\t<label for=\"equationInputbox\">Equation</label>\n+\t\t\t\t\t\t\t\t\t<textarea id=\"equationInputbox\" rows=4 cols=50 data-dojo-type=\"dijit/form/SimpleTextarea\" style=\"min-height:60px;\"></textarea>","path":"www/index.php","position":160,"original_position":160,"commit_id":"7f917bfd54ce84a03ef5893938941f5a95db8341","original_commit_id":"7f917bfd54ce84a03ef5893938941f5a95db8341","user":{"login":"riteshsamala","id":7574479,"avatar_url":"https://avatars.githubusercontent.com/u/7574479?v=3","gravatar_id":"","url":"https://api.github.com/users/riteshsamala","html_url":"https://github.com/riteshsamala","followers_url":"https://api.github.com/users/riteshsamala/followers","following_url":"https://api.github.com/users/riteshsamala/following{/other_user}","gists_url":"https://api.github.com/users/riteshsamala/gists{/gist_id}","starred_url":"https://api.github.com/users/riteshsamala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riteshsamala/subscriptions","organizations_url":"https://api.github.com/users/riteshsamala/orgs","repos_url":"https://api.github.com/users/riteshsamala/repos","events_url":"https://api.github.com/users/riteshsamala/events{/privacy}","received_events_url":"https://api.github.com/users/riteshsamala/received_events","type":"User","site_admin":false},"body":"fixed the indentation, cols here is for the text area for entering the equation","created_at":"2017-02-21T22:53:49Z","updated_at":"2017-02-21T22:53:49Z","html_url":"https://github.com/Dragoon-Lab/topomath/pull/43#discussion_r102340509","pull_request_url":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/comments/102340509"},"html":{"href":"https://github.com/Dragoon-Lab/topomath/pull/43#discussion_r102340509"},"pull_request":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/43","id":103213788,"html_url":"https://github.com/Dragoon-Lab/topomath/pull/43","diff_url":"https://github.com/Dragoon-Lab/topomath/pull/43.diff","patch_url":"https://github.com/Dragoon-Lab/topomath/pull/43.patch","issue_url":"https://api.github.com/repos/Dragoon-Lab/topomath/issues/43","number":43,"state":"open","locked":false,"title":"Node editor2 \thandleInitial related apply directives and functions, handle setStudentEqNode, handle setStudentQtyNode","user":{"login":"riteshsamala","id":7574479,"avatar_url":"https://avatars.githubusercontent.com/u/7574479?v=3","gravatar_id":"","url":"https://api.github.com/users/riteshsamala","html_url":"https://github.com/riteshsamala","followers_url":"https://api.github.com/users/riteshsamala/followers","following_url":"https://api.github.com/users/riteshsamala/following{/other_user}","gists_url":"https://api.github.com/users/riteshsamala/gists{/gist_id}","starred_url":"https://api.github.com/users/riteshsamala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riteshsamala/subscriptions","organizations_url":"https://api.github.com/users/riteshsamala/orgs","repos_url":"https://api.github.com/users/riteshsamala/repos","events_url":"https://api.github.com/users/riteshsamala/events{/privacy}","received_events_url":"https://api.github.com/users/riteshsamala/received_events","type":"User","site_admin":false},"body":"please review\r\n\r\nresolves #31 handleInitial related apply directives and functions, \r\nresolves #39 handle setStudentEqNode, \r\nresolves #40 handle setStudentQtyNode \r\n\r\n","created_at":"2017-01-25T22:03:42Z","updated_at":"2017-02-21T22:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0a324579f6be73068e66052831547239b886d54","assignee":{"login":"riteshsamala","id":7574479,"avatar_url":"https://avatars.githubusercontent.com/u/7574479?v=3","gravatar_id":"","url":"https://api.github.com/users/riteshsamala","html_url":"https://github.com/riteshsamala","followers_url":"https://api.github.com/users/riteshsamala/followers","following_url":"https://api.github.com/users/riteshsamala/following{/other_user}","gists_url":"https://api.github.com/users/riteshsamala/gists{/gist_id}","starred_url":"https://api.github.com/users/riteshsamala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riteshsamala/subscriptions","organizations_url":"https://api.github.com/users/riteshsamala/orgs","repos_url":"https://api.github.com/users/riteshsamala/repos","events_url":"https://api.github.com/users/riteshsamala/events{/privacy}","received_events_url":"https://api.github.com/users/riteshsamala/received_events","type":"User","site_admin":false},"assignees":[{"login":"riteshsamala","id":7574479,"avatar_url":"https://avatars.githubusercontent.com/u/7574479?v=3","gravatar_id":"","url":"https://api.github.com/users/riteshsamala","html_url":"https://github.com/riteshsamala","followers_url":"https://api.github.com/users/riteshsamala/followers","following_url":"https://api.github.com/users/riteshsamala/following{/other_user}","gists_url":"https://api.github.com/users/riteshsamala/gists{/gist_id}","starred_url":"https://api.github.com/users/riteshsamala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riteshsamala/subscriptions","organizations_url":"https://api.github.com/users/riteshsamala/orgs","repos_url":"https://api.github.com/users/riteshsamala/repos","events_url":"https://api.github.com/users/riteshsamala/events{/privacy}","received_events_url":"https://api.github.com/users/riteshsamala/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/43/commits","review_comments_url":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/43/comments","review_comment_url":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dragoon-Lab/topomath/issues/43/comments","statuses_url":"https://api.github.com/repos/Dragoon-Lab/topomath/statuses/7f917bfd54ce84a03ef5893938941f5a95db8341","head":{"label":"Dragoon-Lab:node_editor2","ref":"node_editor2","sha":"7f917bfd54ce84a03ef5893938941f5a95db8341","user":{"login":"Dragoon-Lab","id":12074669,"avatar_url":"https://avatars.githubusercontent.com/u/12074669?v=3","gravatar_id":"","url":"https://api.github.com/users/Dragoon-Lab","html_url":"https://github.com/Dragoon-Lab","followers_url":"https://api.github.com/users/Dragoon-Lab/followers","following_url":"https://api.github.com/users/Dragoon-Lab/following{/other_user}","gists_url":"https://api.github.com/users/Dragoon-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/Dragoon-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dragoon-Lab/subscriptions","organizations_url":"https://api.github.com/users/Dragoon-Lab/orgs","repos_url":"https://api.github.com/users/Dragoon-Lab/repos","events_url":"https://api.github.com/users/Dragoon-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/Dragoon-Lab/received_events","type":"Organization","site_admin":false},"repo":{"id":72044530,"name":"topomath","full_name":"Dragoon-Lab/topomath","owner":{"login":"Dragoon-Lab","id":12074669,"avatar_url":"https://avatars.githubusercontent.com/u/12074669?v=3","gravatar_id":"","url":"https://api.github.com/users/Dragoon-Lab","html_url":"https://github.com/Dragoon-Lab","followers_url":"https://api.github.com/users/Dragoon-Lab/followers","following_url":"https://api.github.com/users/Dragoon-Lab/following{/other_user}","gists_url":"https://api.github.com/users/Dragoon-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/Dragoon-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dragoon-Lab/subscriptions","organizations_url":"https://api.github.com/users/Dragoon-Lab/orgs","repos_url":"https://api.github.com/users/Dragoon-Lab/repos","events_url":"https://api.github.com/users/Dragoon-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/Dragoon-Lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Dragoon-Lab/topomath","description":null,"fork":false,"url":"https://api.github.com/repos/Dragoon-Lab/topomath","forks_url":"https://api.github.com/repos/Dragoon-Lab/topomath/forks","keys_url":"https://api.github.com/repos/Dragoon-Lab/topomath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dragoon-Lab/topomath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dragoon-Lab/topomath/teams","hooks_url":"https://api.github.com/repos/Dragoon-Lab/topomath/hooks","issue_events_url":"https://api.github.com/repos/Dragoon-Lab/topomath/issues/events{/number}","events_url":"https://api.github.com/repos/Dragoon-Lab/topomath/events","assignees_url":"https://api.github.com/repos/Dragoon-Lab/topomath/assignees{/user}","branches_url":"https://api.github.com/repos/Dragoon-Lab/topomath/branches{/branch}","tags_url":"https://api.github.com/repos/Dragoon-Lab/topomath/tags","blobs_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dragoon-Lab/topomath/statuses/{sha}","languages_url":"https://api.github.com/repos/Dragoon-Lab/topomath/languages","stargazers_url":"https://api.github.com/repos/Dragoon-Lab/topomath/stargazers","contributors_url":"https://api.github.com/repos/Dragoon-Lab/topomath/contributors","subscribers_url":"https://api.github.com/repos/Dragoon-Lab/topomath/subscribers","subscription_url":"https://api.github.com/repos/Dragoon-Lab/topomath/subscription","commits_url":"https://api.github.com/repos/Dragoon-Lab/topomath/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dragoon-Lab/topomath/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dragoon-Lab/topomath/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dragoon-Lab/topomath/contents/{+path}","compare_url":"https://api.github.com/repos/Dragoon-Lab/topomath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dragoon-Lab/topomath/merges","archive_url":"https://api.github.com/repos/Dragoon-Lab/topomath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dragoon-Lab/topomath/downloads","issues_url":"https://api.github.com/repos/Dragoon-Lab/topomath/issues{/number}","pulls_url":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls{/number}","milestones_url":"https://api.github.com/repos/Dragoon-Lab/topomath/milestones{/number}","notifications_url":"https://api.github.com/repos/Dragoon-Lab/topomath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dragoon-Lab/topomath/labels{/name}","releases_url":"https://api.github.com/repos/Dragoon-Lab/topomath/releases{/id}","deployments_url":"https://api.github.com/repos/Dragoon-Lab/topomath/deployments","created_at":"2016-10-26T21:07:33Z","updated_at":"2017-01-12T21:18:39Z","pushed_at":"2017-02-21T22:47:23Z","git_url":"git://github.com/Dragoon-Lab/topomath.git","ssh_url":"[email protected]:Dragoon-Lab/topomath.git","clone_url":"https://github.com/Dragoon-Lab/topomath.git","svn_url":"https://github.com/Dragoon-Lab/topomath","homepage":null,"size":212,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":1,"default_branch":"master"}},"base":{"label":"Dragoon-Lab:master","ref":"master","sha":"791a48c83a06f31cbdd46cd420b983103a9bb05c","user":{"login":"Dragoon-Lab","id":12074669,"avatar_url":"https://avatars.githubusercontent.com/u/12074669?v=3","gravatar_id":"","url":"https://api.github.com/users/Dragoon-Lab","html_url":"https://github.com/Dragoon-Lab","followers_url":"https://api.github.com/users/Dragoon-Lab/followers","following_url":"https://api.github.com/users/Dragoon-Lab/following{/other_user}","gists_url":"https://api.github.com/users/Dragoon-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/Dragoon-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dragoon-Lab/subscriptions","organizations_url":"https://api.github.com/users/Dragoon-Lab/orgs","repos_url":"https://api.github.com/users/Dragoon-Lab/repos","events_url":"https://api.github.com/users/Dragoon-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/Dragoon-Lab/received_events","type":"Organization","site_admin":false},"repo":{"id":72044530,"name":"topomath","full_name":"Dragoon-Lab/topomath","owner":{"login":"Dragoon-Lab","id":12074669,"avatar_url":"https://avatars.githubusercontent.com/u/12074669?v=3","gravatar_id":"","url":"https://api.github.com/users/Dragoon-Lab","html_url":"https://github.com/Dragoon-Lab","followers_url":"https://api.github.com/users/Dragoon-Lab/followers","following_url":"https://api.github.com/users/Dragoon-Lab/following{/other_user}","gists_url":"https://api.github.com/users/Dragoon-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/Dragoon-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dragoon-Lab/subscriptions","organizations_url":"https://api.github.com/users/Dragoon-Lab/orgs","repos_url":"https://api.github.com/users/Dragoon-Lab/repos","events_url":"https://api.github.com/users/Dragoon-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/Dragoon-Lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Dragoon-Lab/topomath","description":null,"fork":false,"url":"https://api.github.com/repos/Dragoon-Lab/topomath","forks_url":"https://api.github.com/repos/Dragoon-Lab/topomath/forks","keys_url":"https://api.github.com/repos/Dragoon-Lab/topomath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dragoon-Lab/topomath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dragoon-Lab/topomath/teams","hooks_url":"https://api.github.com/repos/Dragoon-Lab/topomath/hooks","issue_events_url":"https://api.github.com/repos/Dragoon-Lab/topomath/issues/events{/number}","events_url":"https://api.github.com/repos/Dragoon-Lab/topomath/events","assignees_url":"https://api.github.com/repos/Dragoon-Lab/topomath/assignees{/user}","branches_url":"https://api.github.com/repos/Dragoon-Lab/topomath/branches{/branch}","tags_url":"https://api.github.com/repos/Dragoon-Lab/topomath/tags","blobs_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dragoon-Lab/topomath/statuses/{sha}","languages_url":"https://api.github.com/repos/Dragoon-Lab/topomath/languages","stargazers_url":"https://api.github.com/repos/Dragoon-Lab/topomath/stargazers","contributors_url":"https://api.github.com/repos/Dragoon-Lab/topomath/contributors","subscribers_url":"https://api.github.com/repos/Dragoon-Lab/topomath/subscribers","subscription_url":"https://api.github.com/repos/Dragoon-Lab/topomath/subscription","commits_url":"https://api.github.com/repos/Dragoon-Lab/topomath/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dragoon-Lab/topomath/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dragoon-Lab/topomath/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dragoon-Lab/topomath/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dragoon-Lab/topomath/contents/{+path}","compare_url":"https://api.github.com/repos/Dragoon-Lab/topomath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dragoon-Lab/topomath/merges","archive_url":"https://api.github.com/repos/Dragoon-Lab/topomath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dragoon-Lab/topomath/downloads","issues_url":"https://api.github.com/repos/Dragoon-Lab/topomath/issues{/number}","pulls_url":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls{/number}","milestones_url":"https://api.github.com/repos/Dragoon-Lab/topomath/milestones{/number}","notifications_url":"https://api.github.com/repos/Dragoon-Lab/topomath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dragoon-Lab/topomath/labels{/name}","releases_url":"https://api.github.com/repos/Dragoon-Lab/topomath/releases{/id}","deployments_url":"https://api.github.com/repos/Dragoon-Lab/topomath/deployments","created_at":"2016-10-26T21:07:33Z","updated_at":"2017-01-12T21:18:39Z","pushed_at":"2017-02-21T22:47:23Z","git_url":"git://github.com/Dragoon-Lab/topomath.git","ssh_url":"[email protected]:Dragoon-Lab/topomath.git","clone_url":"https://github.com/Dragoon-Lab/topomath.git","svn_url":"https://github.com/Dragoon-Lab/topomath","homepage":null,"size":212,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/43"},"html":{"href":"https://github.com/Dragoon-Lab/topomath/pull/43"},"issue":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/issues/43"},"comments":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/Dragoon-Lab/topomath/statuses/7f917bfd54ce84a03ef5893938941f5a95db8341"}}}} | {
"id": 72044530,
"name": "Dragoon-Lab/topomath",
"url": "https://api.github.com/repos/Dragoon-Lab/topomath"
} | {
"id": 7574479,
"login": "riteshsamala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7574479?",
"url": "https://api.github.com/users/riteshsamala"
} | {
"id": 12074669,
"login": "Dragoon-Lab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12074669?",
"url": "https://api.github.com/orgs/Dragoon-Lab"
} | 2017-02-21T22:53:49 | 5366086240 | {"actor":{"display_login":"riteshsamala"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/136609786","pull_request_review_id":60177257,"id":136609786,"diff_hunk":"@@ -1433,14 +1433,16 @@ if doConfigure :\n \t\t\te.Append( CPPFLAGS = '-DIECORE_WITH_ASIO' )\n \telse :\n \t\tsys.stderr.write( \"WARNING: boost/asio.hpp not found, some functionality will be disabled.\\n\" )\n-\t\tcoreSources.remove( \"src/IECore/ClientDisplayDriver.cpp\" )\n-\t\tcoreSources.remove( \"src/IECore/DisplayDriver.cpp\" )\n-\t\tcoreSources.remove( \"src/IECore/ImageDisplayDriver.cpp\" )\n-\t\tcoreSources.remove( \"src/IECore/DisplayDriverServer.cpp\" )\n-\t\tcorePythonSources.remove( \"src/IECorePython/ClientDisplayDriverBinding.cpp\" )\n-\t\tcorePythonSources.remove( \"src/IECorePython/DisplayDriverServerBinding.cpp\" )\n-\t\tcorePythonSources.remove( \"src/IECorePython/DisplayDriverBinding.cpp\" )\n-\t\tcorePythonSources.remove( \"src/IECorePython/ImageDisplayDriverBinding.cpp\" )\n+\t\tcoreSources.remove( \"src/IECoreImage/ClientDisplayDriver.cpp\" )","path":"SConstruct","position":140,"original_position":12,"commit_id":"cd93b9242fc849fa362adaecee11918b7550c112","original_commit_id":"4fdf10d58dc68a836fbf900b5ec49baf10d78b3a","user":{"login":"andrewkaufman","id":3979682,"avatar_url":"https://avatars1.githubusercontent.com/u/3979682?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},"body":"It seems asio is only required by IECoreImage and IECoreNuke. Should I make it a primary requirement incase we want it for IECore in the future, or leave it to those libs only?","created_at":"2017-09-01T16:03:37Z","updated_at":"2017-09-01T16:03:38Z","html_url":"https://github.com/ImageEngine/cortex/pull/605#discussion_r136609786","pull_request_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/605","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments/136609786"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/605#discussion_r136609786"},"pull_request":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/605"}},"in_reply_to_id":136529324},"pull_request":{"url":"https://api.github.com/repos/ImageEngine/cortex/pulls/605","id":136140274,"html_url":"https://github.com/ImageEngine/cortex/pull/605","diff_url":"https://github.com/ImageEngine/cortex/pull/605.diff","patch_url":"https://github.com/ImageEngine/cortex/pull/605.patch","issue_url":"https://api.github.com/repos/ImageEngine/cortex/issues/605","number":605,"state":"open","locked":false,"title":"IECoreImage : A new module for image processing ","user":{"login":"andrewkaufman","id":3979682,"avatar_url":"https://avatars1.githubusercontent.com/u/3979682?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},"body":"This sprawling PR begins our efforts towards more modular sub-libraries, which is aimed at both improving discover-ability of code (by reducing files per include directory) and insulating external dependencies specific to sub-domains (e.g. the OpenImageIO dependency I'm introducing here).\r\n\r\nThe result is a new libIECoreImage (and associated IECoreImage python module) which contains all image processing code in Cortex (from ImagePrimitive itself, to its associated parameters and ops for reading/writing and manipulating images). libIECoreGL, libIECoreMaya, and libIECoreNuke all depend on libIECoreImage (as does libIECoreRI if you have SX enabled).\r\n\r\nAll format specific image readers/writers have been replaced with a single ImageReader and ImageWriter, both of which are backed by OpenImageIO. Furthermore, all color conversion and color processing has been removed from Cortex, as has support for deep image reading/writing. Many image related ops have been removed as well, on the grounds that other projects are better suited to those tasks (e.g. OCIO, OIIO, or Gaffer).\r\n\r\nIn general, IECoreImage should only be used for quite rudimentary image processing, such as loading textures in IECoreGL. Gaffer has much more performant (and well rounded) image processing capabilities.\r\n\r\nIt might be quite difficult to review at first, since so many files have been touched. I'll try to point out some helpful hints / drawbacks to watch for :\r\n\r\n- 4c7a17e is the first commit that's not just removing (or adapting to recently removed) stuff\r\n- 71cba77 duplicates some freetype code from `IECore::Font` to `IECoreImage::Font`, and `IECoreGL::Font` now has a pointer to both. I wasn't sure it'd be worth refactoring the freetype stuff to allow for something better.\r\n- As discussed offline, `ImagePrimitive` is no longer a `Primitive`, and just a `BlindDataHolder`, though I'm still calling it `ImagePrimitive`. As a result, much of its API has changed in 35e2272.\r\n- IECoreImage does depend on `CurvesPrimitive` right now (because of the `CurveThinner` op, moved in 48969f9). This isn't ideal, but I didn't want to lose the op, and I've left it for the future creator if IECoreScene to sort out.\r\n- 7f3ea4f is the dodgiest commit in my books. It re-writes a bunch of test tifs (from testGL) using oiiotool. I don't know why those tiffs were crashing (the tiffs in testImage work just fine) and simply re-writing them fixes all the crashes, and the tests all pass unchanged (except one, addressed in 706ba02, but that wasn't passing before this PR either).\r\n- `scons testImage` is not currently running on Travis, so the Travis tests only show that `testCore` and `testCorePython` are still passing. I have run `testImage` myself, in regular and debug mode, as well as `testGL`, `testRI`, `testArnold`, `testAppleseed`, `testMantra`, `testAlembic`, `testMaya`, `testNuke`, and `testHoudini`. That was all with gcc 4.8.3 on CentOs 7 at IE.\r\n- The tests won't currently run at IE unless you have an env hack. That should be sorted out by IT shortly, but if anyone else did try to run them at IE right now, they'd crash.\r\n- `scons test` does not currently run `testImage`. I'd like to fix that, but was unsure how.","created_at":"2017-08-16T22:56:10Z","updated_at":"2017-09-01T16:03:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acdc7bf3908686c39ce87e530a2d7756e84b66a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/605/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/605/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/issues/605/comments","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/cd93b9242fc849fa362adaecee11918b7550c112","head":{"label":"andrewkaufman:imageColor","ref":"imageColor","sha":"cd93b9242fc849fa362adaecee11918b7550c112","user":{"login":"andrewkaufman","id":3979682,"avatar_url":"https://avatars1.githubusercontent.com/u/3979682?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},"repo":{"id":10675663,"name":"cortex","full_name":"andrewkaufman/cortex","owner":{"login":"andrewkaufman","id":3979682,"avatar_url":"https://avatars1.githubusercontent.com/u/3979682?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewkaufman/cortex","description":"My day-to-day development. See ImageEngine/cortex for official code","fork":true,"url":"https://api.github.com/repos/andrewkaufman/cortex","forks_url":"https://api.github.com/repos/andrewkaufman/cortex/forks","keys_url":"https://api.github.com/repos/andrewkaufman/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewkaufman/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewkaufman/cortex/teams","hooks_url":"https://api.github.com/repos/andrewkaufman/cortex/hooks","issue_events_url":"https://api.github.com/repos/andrewkaufman/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/andrewkaufman/cortex/events","assignees_url":"https://api.github.com/repos/andrewkaufman/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/andrewkaufman/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/andrewkaufman/cortex/tags","blobs_url":"https://api.github.com/repos/andrewkaufman/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewkaufman/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewkaufman/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewkaufman/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewkaufman/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewkaufman/cortex/languages","stargazers_url":"https://api.github.com/repos/andrewkaufman/cortex/stargazers","contributors_url":"https://api.github.com/repos/andrewkaufman/cortex/contributors","subscribers_url":"https://api.github.com/repos/andrewkaufman/cortex/subscribers","subscription_url":"https://api.github.com/repos/andrewkaufman/cortex/subscription","commits_url":"https://api.github.com/repos/andrewkaufman/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewkaufman/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewkaufman/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewkaufman/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewkaufman/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/andrewkaufman/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewkaufman/cortex/merges","archive_url":"https://api.github.com/repos/andrewkaufman/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewkaufman/cortex/downloads","issues_url":"https://api.github.com/repos/andrewkaufman/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/andrewkaufman/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewkaufman/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewkaufman/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewkaufman/cortex/labels{/name}","releases_url":"https://api.github.com/repos/andrewkaufman/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/andrewkaufman/cortex/deployments","created_at":"2013-06-13T20:51:14Z","updated_at":"2015-05-06T16:31:16Z","pushed_at":"2017-09-01T00:06:11Z","git_url":"git://github.com/andrewkaufman/cortex.git","ssh_url":"[email protected]:andrewkaufman/cortex.git","clone_url":"https://github.com/andrewkaufman/cortex.git","svn_url":"https://github.com/andrewkaufman/cortex","homepage":"","size":99511,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"aa5a6b0c2ec266c60ad673b5f0bf2d26cf0b9ce7","user":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars1.githubusercontent.com/u/3976662?v=4","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":10654465,"name":"cortex","full_name":"ImageEngine/cortex","owner":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars1.githubusercontent.com/u/3976662?v=4","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImageEngine/cortex","description":"Libraries for visual effects software development","fork":false,"url":"https://api.github.com/repos/ImageEngine/cortex","forks_url":"https://api.github.com/repos/ImageEngine/cortex/forks","keys_url":"https://api.github.com/repos/ImageEngine/cortex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/cortex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/cortex/teams","hooks_url":"https://api.github.com/repos/ImageEngine/cortex/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/cortex/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/cortex/events","assignees_url":"https://api.github.com/repos/ImageEngine/cortex/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/cortex/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/cortex/tags","blobs_url":"https://api.github.com/repos/ImageEngine/cortex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/cortex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/cortex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/cortex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/cortex/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/cortex/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/cortex/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/cortex/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/cortex/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/cortex/subscription","commits_url":"https://api.github.com/repos/ImageEngine/cortex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/cortex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/cortex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/cortex/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImageEngine/cortex/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/cortex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/cortex/merges","archive_url":"https://api.github.com/repos/ImageEngine/cortex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/cortex/downloads","issues_url":"https://api.github.com/repos/ImageEngine/cortex/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/cortex/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/cortex/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/cortex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/cortex/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/cortex/releases{/id}","deployments_url":"https://api.github.com/repos/ImageEngine/cortex/deployments","created_at":"2013-06-12T23:12:28Z","updated_at":"2017-08-31T05:51:42Z","pushed_at":"2017-09-01T00:06:13Z","git_url":"git://github.com/ImageEngine/cortex.git","ssh_url":"[email protected]:ImageEngine/cortex.git","clone_url":"https://github.com/ImageEngine/cortex.git","svn_url":"https://github.com/ImageEngine/cortex","homepage":null,"size":99237,"stargazers_count":204,"watchers_count":204,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":39,"forks":77,"open_issues":39,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/605"},"html":{"href":"https://github.com/ImageEngine/cortex/pull/605"},"issue":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/605"},"comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/issues/605/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/605/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/cortex/pulls/605/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/cortex/statuses/cd93b9242fc849fa362adaecee11918b7550c112"}},"author_association":"OWNER"}} | {
"id": 10654465,
"name": "ImageEngine/cortex",
"url": "https://api.github.com/repos/ImageEngine/cortex"
} | {
"id": 3979682,
"login": "andrewkaufman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3979682?",
"url": "https://api.github.com/users/andrewkaufman"
} | {
"id": 3976662,
"login": "ImageEngine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3976662?",
"url": "https://api.github.com/orgs/ImageEngine"
} | 2017-09-01T16:03:37 | 6540600486 | {"actor":{"display_login":"andrewkaufman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/comments/147549790","pull_request_review_id":72667065,"id":147549790,"diff_hunk":"@@ -0,0 +1,164 @@\n+--- ibus-1.5.13/setup/main.py.~1~\t2016-02-22 11:46:23.000000000 +0000\n++++ ibus-1.5.13/setup/main.py\t2017-10-27 08:44:34.828623420 +0000\n+@@ -24,7 +24,9 @@\n+ from __future__ import print_function\n+ \n+ import os\n++import shutil\n+ import signal\n++import subprocess\n+ import sys\n+ import time\n+ \n+@@ -506,35 +508,38 @@\n+ model.set(iter, COLUMN_PRELOAD, data[DATA_PRELOAD])\n+ \n+ def __is_auto_start(self):\n+- link_file = path.join(GLib.get_user_config_dir(),\n+- \"autostart/ibus.desktop\")\n+- ibus_desktop = path.join(os.getenv(\"IBUS_PREFIX\"),\n+- \"share/applications/ibus.desktop\")\n+-\n+- if not path.exists(link_file):\n+- return False\n+- if not path.islink(link_file):\n+- return False\n+- if path.realpath(link_file) != ibus_desktop:\n+- return False\n+- return True\n+-\n+- def __checkbutton_auto_start_toggled_cb(self, button):\n+- auto_start_dir = path.join(GLib.get_user_config_dir(), \"autostart\")\n+- if not path.isdir(auto_start_dir):\n+- os.makedirs(auto_start_dir)\n+-\n+- link_file = path.join(GLib.get_user_config_dir(),\n+- \"autostart/ibus.desktop\")\n+- ibus_desktop = path.join(os.getenv(\"IBUS_PREFIX\"),\n+- \"share/applications/ibus.desktop\")\n+- # unlink file\n++ home = os.getenv(\"HOME\")\n++ config_file = path.join(home, \".imf\")\n+ try:\n+- os.unlink(link_file)\n++ if os.path.isfile(config_file):\n++\t im = subprocess.check_output([\"/usr/bin/sh\", config_file, \"-name\"])\n++ if im.startswith(\"IBus \"):\n++ return True\n+ except:\n+ pass\n+- if self.__checkbutton_auto_start.get_active():\n+- os.symlink(ibus_desktop, link_file)\n++ return False\n++\n++ def __checkbutton_auto_start_toggled_cb(self, button):\n++ IBUS_SCRIPT=\"/etc/X11/xinit/imf.d/0010.ibus\"\n++\n++ try:\n++ home = os.getenv(\"HOME\")\n++ if home:\n++ config_file = path.join(home, \".imf\")\n++ if self.__checkbutton_auto_start.get_active():\n++ shutil.copyfile(IBUS_SCRIPT, config_file)\n++ elif os.path.exists(config_file):\n++ os.unlink(config_file)\n++ except Exception as e:\n++ dlg = Gtk.MessageDialog(message_type = Gtk.MessageType.ERROR,","path":"components/inputmethod/ibus/patches/01-enable-autostart-management.patch","position":66,"original_position":66,"commit_id":"6fe3838947a772b6fe0dab924d52f3a90e1020a4","original_commit_id":"6fe3838947a772b6fe0dab924d52f3a90e1020a4","user":{"login":"pyhalov","id":4092748,"avatar_url":"https://avatars2.githubusercontent.com/u/4092748?v=4","gravatar_id":"","url":"https://api.github.com/users/pyhalov","html_url":"https://github.com/pyhalov","followers_url":"https://api.github.com/users/pyhalov/followers","following_url":"https://api.github.com/users/pyhalov/following{/other_user}","gists_url":"https://api.github.com/users/pyhalov/gists{/gist_id}","starred_url":"https://api.github.com/users/pyhalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyhalov/subscriptions","organizations_url":"https://api.github.com/users/pyhalov/orgs","repos_url":"https://api.github.com/users/pyhalov/repos","events_url":"https://api.github.com/users/pyhalov/events{/privacy}","received_events_url":"https://api.github.com/users/pyhalov/received_events","type":"User","site_admin":false},"body":"It's a common style in that file","created_at":"2017-10-28T09:00:47Z","updated_at":"2017-10-28T09:00:47Z","html_url":"https://github.com/OpenIndiana/oi-userland/pull/3613#discussion_r147549790","pull_request_url":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/3613","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/comments/147549790"},"html":{"href":"https://github.com/OpenIndiana/oi-userland/pull/3613#discussion_r147549790"},"pull_request":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/3613"}},"in_reply_to_id":147549447},"pull_request":{"url":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/3613","id":149006777,"html_url":"https://github.com/OpenIndiana/oi-userland/pull/3613","diff_url":"https://github.com/OpenIndiana/oi-userland/pull/3613.diff","patch_url":"https://github.com/OpenIndiana/oi-userland/pull/3613.patch","issue_url":"https://api.github.com/repos/OpenIndiana/oi-userland/issues/3613","number":3613,"state":"open","locked":false,"title":"ibus: add auto-start management interface to ibus-setup","user":{"login":"pyhalov","id":4092748,"avatar_url":"https://avatars2.githubusercontent.com/u/4092748?v=4","gravatar_id":"","url":"https://api.github.com/users/pyhalov","html_url":"https://github.com/pyhalov","followers_url":"https://api.github.com/users/pyhalov/followers","following_url":"https://api.github.com/users/pyhalov/following{/other_user}","gists_url":"https://api.github.com/users/pyhalov/gists{/gist_id}","starred_url":"https://api.github.com/users/pyhalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyhalov/subscriptions","organizations_url":"https://api.github.com/users/pyhalov/orgs","repos_url":"https://api.github.com/users/pyhalov/repos","events_url":"https://api.github.com/users/pyhalov/events{/privacy}","received_events_url":"https://api.github.com/users/pyhalov/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-26T18:10:15Z","updated_at":"2017-10-28T09:00:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7e00612cd19729cdb56801a4871569872f2b6d9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/3613/commits","review_comments_url":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/3613/comments","review_comment_url":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenIndiana/oi-userland/issues/3613/comments","statuses_url":"https://api.github.com/repos/OpenIndiana/oi-userland/statuses/6fe3838947a772b6fe0dab924d52f3a90e1020a4","head":{"label":"pyhalov:input-methods-wip","ref":"input-methods-wip","sha":"6fe3838947a772b6fe0dab924d52f3a90e1020a4","user":{"login":"pyhalov","id":4092748,"avatar_url":"https://avatars2.githubusercontent.com/u/4092748?v=4","gravatar_id":"","url":"https://api.github.com/users/pyhalov","html_url":"https://github.com/pyhalov","followers_url":"https://api.github.com/users/pyhalov/followers","following_url":"https://api.github.com/users/pyhalov/following{/other_user}","gists_url":"https://api.github.com/users/pyhalov/gists{/gist_id}","starred_url":"https://api.github.com/users/pyhalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyhalov/subscriptions","organizations_url":"https://api.github.com/users/pyhalov/orgs","repos_url":"https://api.github.com/users/pyhalov/repos","events_url":"https://api.github.com/users/pyhalov/events{/privacy}","received_events_url":"https://api.github.com/users/pyhalov/received_events","type":"User","site_admin":false},"repo":{"id":10253327,"name":"oi-userland","full_name":"pyhalov/oi-userland","owner":{"login":"pyhalov","id":4092748,"avatar_url":"https://avatars2.githubusercontent.com/u/4092748?v=4","gravatar_id":"","url":"https://api.github.com/users/pyhalov","html_url":"https://github.com/pyhalov","followers_url":"https://api.github.com/users/pyhalov/followers","following_url":"https://api.github.com/users/pyhalov/following{/other_user}","gists_url":"https://api.github.com/users/pyhalov/gists{/gist_id}","starred_url":"https://api.github.com/users/pyhalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyhalov/subscriptions","organizations_url":"https://api.github.com/users/pyhalov/orgs","repos_url":"https://api.github.com/users/pyhalov/repos","events_url":"https://api.github.com/users/pyhalov/events{/privacy}","received_events_url":"https://api.github.com/users/pyhalov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pyhalov/oi-userland","description":"OI Userland","fork":true,"url":"https://api.github.com/repos/pyhalov/oi-userland","forks_url":"https://api.github.com/repos/pyhalov/oi-userland/forks","keys_url":"https://api.github.com/repos/pyhalov/oi-userland/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyhalov/oi-userland/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyhalov/oi-userland/teams","hooks_url":"https://api.github.com/repos/pyhalov/oi-userland/hooks","issue_events_url":"https://api.github.com/repos/pyhalov/oi-userland/issues/events{/number}","events_url":"https://api.github.com/repos/pyhalov/oi-userland/events","assignees_url":"https://api.github.com/repos/pyhalov/oi-userland/assignees{/user}","branches_url":"https://api.github.com/repos/pyhalov/oi-userland/branches{/branch}","tags_url":"https://api.github.com/repos/pyhalov/oi-userland/tags","blobs_url":"https://api.github.com/repos/pyhalov/oi-userland/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyhalov/oi-userland/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyhalov/oi-userland/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyhalov/oi-userland/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyhalov/oi-userland/statuses/{sha}","languages_url":"https://api.github.com/repos/pyhalov/oi-userland/languages","stargazers_url":"https://api.github.com/repos/pyhalov/oi-userland/stargazers","contributors_url":"https://api.github.com/repos/pyhalov/oi-userland/contributors","subscribers_url":"https://api.github.com/repos/pyhalov/oi-userland/subscribers","subscription_url":"https://api.github.com/repos/pyhalov/oi-userland/subscription","commits_url":"https://api.github.com/repos/pyhalov/oi-userland/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyhalov/oi-userland/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyhalov/oi-userland/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyhalov/oi-userland/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyhalov/oi-userland/contents/{+path}","compare_url":"https://api.github.com/repos/pyhalov/oi-userland/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyhalov/oi-userland/merges","archive_url":"https://api.github.com/repos/pyhalov/oi-userland/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyhalov/oi-userland/downloads","issues_url":"https://api.github.com/repos/pyhalov/oi-userland/issues{/number}","pulls_url":"https://api.github.com/repos/pyhalov/oi-userland/pulls{/number}","milestones_url":"https://api.github.com/repos/pyhalov/oi-userland/milestones{/number}","notifications_url":"https://api.github.com/repos/pyhalov/oi-userland/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyhalov/oi-userland/labels{/name}","releases_url":"https://api.github.com/repos/pyhalov/oi-userland/releases{/id}","deployments_url":"https://api.github.com/repos/pyhalov/oi-userland/deployments","created_at":"2013-05-23T20:59:05Z","updated_at":"2016-10-28T06:08:57Z","pushed_at":"2017-10-28T05:21:42Z","git_url":"git://github.com/pyhalov/oi-userland.git","ssh_url":"[email protected]:pyhalov/oi-userland.git","clone_url":"https://github.com/pyhalov/oi-userland.git","svn_url":"https://github.com/pyhalov/oi-userland","homepage":null,"size":55507,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":2,"default_branch":"oi/hipster"}},"base":{"label":"OpenIndiana:oi/hipster","ref":"oi/hipster","sha":"76f795a46760c203a91dece2ef7f4ab14fed6219","user":{"login":"OpenIndiana","id":1423700,"avatar_url":"https://avatars2.githubusercontent.com/u/1423700?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenIndiana","html_url":"https://github.com/OpenIndiana","followers_url":"https://api.github.com/users/OpenIndiana/followers","following_url":"https://api.github.com/users/OpenIndiana/following{/other_user}","gists_url":"https://api.github.com/users/OpenIndiana/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenIndiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenIndiana/subscriptions","organizations_url":"https://api.github.com/users/OpenIndiana/orgs","repos_url":"https://api.github.com/users/OpenIndiana/repos","events_url":"https://api.github.com/users/OpenIndiana/events{/privacy}","received_events_url":"https://api.github.com/users/OpenIndiana/received_events","type":"Organization","site_admin":false},"repo":{"id":10007731,"name":"oi-userland","full_name":"OpenIndiana/oi-userland","owner":{"login":"OpenIndiana","id":1423700,"avatar_url":"https://avatars2.githubusercontent.com/u/1423700?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenIndiana","html_url":"https://github.com/OpenIndiana","followers_url":"https://api.github.com/users/OpenIndiana/followers","following_url":"https://api.github.com/users/OpenIndiana/following{/other_user}","gists_url":"https://api.github.com/users/OpenIndiana/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenIndiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenIndiana/subscriptions","organizations_url":"https://api.github.com/users/OpenIndiana/orgs","repos_url":"https://api.github.com/users/OpenIndiana/repos","events_url":"https://api.github.com/users/OpenIndiana/events{/privacy}","received_events_url":"https://api.github.com/users/OpenIndiana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenIndiana/oi-userland","description":"Unified build system for OpenIndiana distribution components","fork":false,"url":"https://api.github.com/repos/OpenIndiana/oi-userland","forks_url":"https://api.github.com/repos/OpenIndiana/oi-userland/forks","keys_url":"https://api.github.com/repos/OpenIndiana/oi-userland/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenIndiana/oi-userland/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenIndiana/oi-userland/teams","hooks_url":"https://api.github.com/repos/OpenIndiana/oi-userland/hooks","issue_events_url":"https://api.github.com/repos/OpenIndiana/oi-userland/issues/events{/number}","events_url":"https://api.github.com/repos/OpenIndiana/oi-userland/events","assignees_url":"https://api.github.com/repos/OpenIndiana/oi-userland/assignees{/user}","branches_url":"https://api.github.com/repos/OpenIndiana/oi-userland/branches{/branch}","tags_url":"https://api.github.com/repos/OpenIndiana/oi-userland/tags","blobs_url":"https://api.github.com/repos/OpenIndiana/oi-userland/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenIndiana/oi-userland/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenIndiana/oi-userland/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenIndiana/oi-userland/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenIndiana/oi-userland/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenIndiana/oi-userland/languages","stargazers_url":"https://api.github.com/repos/OpenIndiana/oi-userland/stargazers","contributors_url":"https://api.github.com/repos/OpenIndiana/oi-userland/contributors","subscribers_url":"https://api.github.com/repos/OpenIndiana/oi-userland/subscribers","subscription_url":"https://api.github.com/repos/OpenIndiana/oi-userland/subscription","commits_url":"https://api.github.com/repos/OpenIndiana/oi-userland/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenIndiana/oi-userland/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenIndiana/oi-userland/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenIndiana/oi-userland/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenIndiana/oi-userland/contents/{+path}","compare_url":"https://api.github.com/repos/OpenIndiana/oi-userland/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenIndiana/oi-userland/merges","archive_url":"https://api.github.com/repos/OpenIndiana/oi-userland/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenIndiana/oi-userland/downloads","issues_url":"https://api.github.com/repos/OpenIndiana/oi-userland/issues{/number}","pulls_url":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenIndiana/oi-userland/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenIndiana/oi-userland/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenIndiana/oi-userland/labels{/name}","releases_url":"https://api.github.com/repos/OpenIndiana/oi-userland/releases{/id}","deployments_url":"https://api.github.com/repos/OpenIndiana/oi-userland/deployments","created_at":"2013-05-12T01:29:19Z","updated_at":"2017-10-08T00:26:04Z","pushed_at":"2017-10-28T05:22:16Z","git_url":"git://github.com/OpenIndiana/oi-userland.git","ssh_url":"[email protected]:OpenIndiana/oi-userland.git","clone_url":"https://github.com/OpenIndiana/oi-userland.git","svn_url":"https://github.com/OpenIndiana/oi-userland","homepage":"","size":130227,"stargazers_count":52,"watchers_count":52,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":92,"open_issues":25,"watchers":52,"default_branch":"oi/hipster"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/3613"},"html":{"href":"https://github.com/OpenIndiana/oi-userland/pull/3613"},"issue":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/issues/3613"},"comments":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/issues/3613/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/3613/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/pulls/3613/commits"},"statuses":{"href":"https://api.github.com/repos/OpenIndiana/oi-userland/statuses/6fe3838947a772b6fe0dab924d52f3a90e1020a4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 10007731,
"name": "OpenIndiana/oi-userland",
"url": "https://api.github.com/repos/OpenIndiana/oi-userland"
} | {
"id": 4092748,
"login": "pyhalov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4092748?",
"url": "https://api.github.com/users/pyhalov"
} | {
"id": 1423700,
"login": "OpenIndiana",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1423700?",
"url": "https://api.github.com/orgs/OpenIndiana"
} | 2017-10-28T09:00:47 | 6778311450 | {"actor":{"display_login":"pyhalov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/comments/148555561","pull_request_review_id":73815575,"id":148555561,"diff_hunk":"@@ -0,0 +1,95 @@\n+node('sat6-rhel7') {\n+\n+ snapperStage('Setup Git Repos') {\n+\n+ deleteDir()\n+\t\tgitlab_clone_and_merge('foreman')\n+\n+ }\n+\n+ snapperStage('Configure Environment') {\n+\n+ try {\n+ sh \"cp config/settings.yaml.example config/settings.yaml\"\n+ sh \"sed -i 's/:locations_enabled: false/:locations_enabled: true/' config/settings.yaml\"\n+ sh \"sed -i 's/:organizations_enabled: false/:organizations_enabled: true/' config/settings.yaml\"\n+\n+ sh \"cp $HOME/postgresql.db.yaml config/database.yml\"\n+\n+ sh \"sed -i \\\"s/database:.*/database: ${gemset()}-test/\\\" config/database.yml\"\n+ sh \"\"\"\n+cat <<EOT >> config/database.yml\n+development:\n+ adapter: postgresql\n+ database: ${gemset()}-development\n+ username: foreman\n+ password: foreman\n+ host: localhost\n+ template: template0\n+production:\n+ adapter: postgresql\n+ database: ${gemset()}-development\n+ username: foreman\n+ password: foreman\n+ host: localhost\n+ template: template0\n+EOT\n+ \"\"\"\n+ } catch (all) {\n+ cleanup()","path":"workflows/test/foreman.groovy","position":39,"original_position":39,"commit_id":"4c1d236bd1923070b3dcfad3795ca6e0830bfde8","original_commit_id":"4c1d236bd1923070b3dcfad3795ca6e0830bfde8","user":{"login":"evgeni","id":94284,"avatar_url":"https://avatars3.githubusercontent.com/u/94284?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeni","html_url":"https://github.com/evgeni","followers_url":"https://api.github.com/users/evgeni/followers","following_url":"https://api.github.com/users/evgeni/following{/other_user}","gists_url":"https://api.github.com/users/evgeni/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeni/subscriptions","organizations_url":"https://api.github.com/users/evgeni/orgs","repos_url":"https://api.github.com/users/evgeni/repos","events_url":"https://api.github.com/users/evgeni/events{/privacy}","received_events_url":"https://api.github.com/users/evgeni/received_events","type":"User","site_admin":false},"body":"Finally would also run with no exceptions, do you really want to clean up inbetween steps?","created_at":"2017-11-02T14:51:15Z","updated_at":"2017-11-02T14:51:15Z","html_url":"https://github.com/SatelliteQE/robottelo-ci/pull/858#discussion_r148555561","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/858","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/comments/148555561"},"html":{"href":"https://github.com/SatelliteQE/robottelo-ci/pull/858#discussion_r148555561"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/858"}},"in_reply_to_id":148531521},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/858","id":148492957,"html_url":"https://github.com/SatelliteQE/robottelo-ci/pull/858","diff_url":"https://github.com/SatelliteQE/robottelo-ci/pull/858.diff","patch_url":"https://github.com/SatelliteQE/robottelo-ci/pull/858.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/issues/858","number":858,"state":"open","locked":false,"title":"Don't install mysql for Foreman unit tests","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-24T19:36:52Z","updated_at":"2017-11-02T14:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"220766050a4036f754a37d3eded35a86ef3b77ac","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/858/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/858/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/issues/858/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/statuses/4c1d236bd1923070b3dcfad3795ca6e0830bfde8","head":{"label":"ehelms:without-mysql","ref":"without-mysql","sha":"4c1d236bd1923070b3dcfad3795ca6e0830bfde8","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"repo":{"id":44755853,"name":"robottelo-ci","full_name":"ehelms/robottelo-ci","owner":{"login":"ehelms","id":293363,"avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehelms/robottelo-ci","description":"Jenkins jobs configuration files to be used to run Robottelo against Satellite 6 and SAM.","fork":true,"url":"https://api.github.com/repos/ehelms/robottelo-ci","forks_url":"https://api.github.com/repos/ehelms/robottelo-ci/forks","keys_url":"https://api.github.com/repos/ehelms/robottelo-ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehelms/robottelo-ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehelms/robottelo-ci/teams","hooks_url":"https://api.github.com/repos/ehelms/robottelo-ci/hooks","issue_events_url":"https://api.github.com/repos/ehelms/robottelo-ci/issues/events{/number}","events_url":"https://api.github.com/repos/ehelms/robottelo-ci/events","assignees_url":"https://api.github.com/repos/ehelms/robottelo-ci/assignees{/user}","branches_url":"https://api.github.com/repos/ehelms/robottelo-ci/branches{/branch}","tags_url":"https://api.github.com/repos/ehelms/robottelo-ci/tags","blobs_url":"https://api.github.com/repos/ehelms/robottelo-ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehelms/robottelo-ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehelms/robottelo-ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehelms/robottelo-ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehelms/robottelo-ci/statuses/{sha}","languages_url":"https://api.github.com/repos/ehelms/robottelo-ci/languages","stargazers_url":"https://api.github.com/repos/ehelms/robottelo-ci/stargazers","contributors_url":"https://api.github.com/repos/ehelms/robottelo-ci/contributors","subscribers_url":"https://api.github.com/repos/ehelms/robottelo-ci/subscribers","subscription_url":"https://api.github.com/repos/ehelms/robottelo-ci/subscription","commits_url":"https://api.github.com/repos/ehelms/robottelo-ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehelms/robottelo-ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehelms/robottelo-ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehelms/robottelo-ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehelms/robottelo-ci/contents/{+path}","compare_url":"https://api.github.com/repos/ehelms/robottelo-ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehelms/robottelo-ci/merges","archive_url":"https://api.github.com/repos/ehelms/robottelo-ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehelms/robottelo-ci/downloads","issues_url":"https://api.github.com/repos/ehelms/robottelo-ci/issues{/number}","pulls_url":"https://api.github.com/repos/ehelms/robottelo-ci/pulls{/number}","milestones_url":"https://api.github.com/repos/ehelms/robottelo-ci/milestones{/number}","notifications_url":"https://api.github.com/repos/ehelms/robottelo-ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehelms/robottelo-ci/labels{/name}","releases_url":"https://api.github.com/repos/ehelms/robottelo-ci/releases{/id}","deployments_url":"https://api.github.com/repos/ehelms/robottelo-ci/deployments","created_at":"2015-10-22T15:47:33Z","updated_at":"2015-10-22T15:47:34Z","pushed_at":"2017-10-31T18:44:44Z","git_url":"git://github.com/ehelms/robottelo-ci.git","ssh_url":"[email protected]:ehelms/robottelo-ci.git","clone_url":"https://github.com/ehelms/robottelo-ci.git","svn_url":"https://github.com/ehelms/robottelo-ci","homepage":"","size":961,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:master","ref":"master","sha":"d0784c2098f4dc6d939cf8c4a4f4419d93ce1503","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars3.githubusercontent.com/u/8754276?v=4","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":27786159,"name":"robottelo-ci","full_name":"SatelliteQE/robottelo-ci","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars3.githubusercontent.com/u/8754276?v=4","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo-ci","description":"Jenkins jobs configuration files to be used to run Robottelo against Satellite 6 and SAM.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo-ci","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/releases{/id}","deployments_url":"https://api.github.com/repos/SatelliteQE/robottelo-ci/deployments","created_at":"2014-12-09T20:43:44Z","updated_at":"2017-10-22T06:59:29Z","pushed_at":"2017-11-01T07:24:02Z","git_url":"git://github.com/SatelliteQE/robottelo-ci.git","ssh_url":"[email protected]:SatelliteQE/robottelo-ci.git","clone_url":"https://github.com/SatelliteQE/robottelo-ci.git","svn_url":"https://github.com/SatelliteQE/robottelo-ci","homepage":"","size":959,"stargazers_count":8,"watchers_count":8,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":32,"forks":24,"open_issues":32,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/858"},"html":{"href":"https://github.com/SatelliteQE/robottelo-ci/pull/858"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/issues/858"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/issues/858/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/858/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/pulls/858/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo-ci/statuses/4c1d236bd1923070b3dcfad3795ca6e0830bfde8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 27786159,
"name": "SatelliteQE/robottelo-ci",
"url": "https://api.github.com/repos/SatelliteQE/robottelo-ci"
} | {
"id": 94284,
"login": "evgeni",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/94284?",
"url": "https://api.github.com/users/evgeni"
} | {
"id": 8754276,
"login": "SatelliteQE",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8754276?",
"url": "https://api.github.com/orgs/SatelliteQE"
} | 2017-11-02T14:51:15 | 6800736923 | {"actor":{"display_login":"evgeni"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Starcounter/Guidelines/pulls/comments/132946506","pull_request_review_id":56074058,"id":132946506,"diff_hunk":"@@ -16,4 +16,36 @@ Incorrect:\n \n ```csharp\n var page = (ProductPage)Self.GET($\"/products/partial/products/{obj.Key}\");\n-```\n\\ No newline at end of file\n+```\n+\n+## Use string interpolation and typeof in the SQL queries\n+\n+For the non-performance critical code, it is suggested to use `typeof` for table names:\n+\n+```c#\n+Db.SQL<SomebodyGroup>($\"SELECT s FROM {typeof(SomebodyGroup).FullName} s\n+WHERE s.{nameof(SomebodyGroup.Name)} LIKE ?\", obj)\n+```\n+\n+It is refactorable and in general it provides better information for coding tools as compared to the table names given as strings.\n+\n+Warning: if the table name includes keywords such as \"order\", the above code will not produce a correct query. You will have to escape the keyword in double quotes in one of the following ways:\n+\n+```c#\n+Db.SQL(\"SELECT * FROM Customer.\\\"Order\\\"\"); //fast but not refactorable\n+Db.SQL($\"SELECT * FROM \\\"{typeof(Customer).FullName.Replace(\".\", \"\\\".\\\"\")}\\\"\"); //slow but refactorable\n+```\n+\n+Keep in mind that `typeof` is resolved in the run time. For performance critical code, use `nameof`, which is resolved in the compile time:\n+\n+```c#\n+Db.SQL<SomebodyGroup>($\"SELECT s FROM {nameof(Simplified)}.{nameof(Ring2)}.{nameof(SomebodyGroup)} s\n+WHERE s.{nameof(SomebodyGroup.Name)} LIKE ?\", obj)\n+```\n+\n+If the table is in the same namespace as the current app, then you can use the short table name:","path":"starcounter-api-usage.md","position":33,"original_position":33,"commit_id":"963595bbaad6bd2f22d0a3e2a2027a5274ed8cf7","original_commit_id":"963595bbaad6bd2f22d0a3e2a2027a5274ed8cf7","user":{"login":"joozek78","id":6013217,"avatar_url":"https://avatars0.githubusercontent.com/u/6013217?v=4","gravatar_id":"","url":"https://api.github.com/users/joozek78","html_url":"https://github.com/joozek78","followers_url":"https://api.github.com/users/joozek78/followers","following_url":"https://api.github.com/users/joozek78/following{/other_user}","gists_url":"https://api.github.com/users/joozek78/gists{/gist_id}","starred_url":"https://api.github.com/users/joozek78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joozek78/subscriptions","organizations_url":"https://api.github.com/users/joozek78/orgs","repos_url":"https://api.github.com/users/joozek78/repos","events_url":"https://api.github.com/users/joozek78/events{/privacy}","received_events_url":"https://api.github.com/users/joozek78/received_events","type":"User","site_admin":false},"body":"BTW my question stands - what is the namespace of the current app? I thought the short form uses namespace of the calling class","created_at":"2017-08-14T13:13:40Z","updated_at":"2017-08-14T13:13:40Z","html_url":"https://github.com/Starcounter/Guidelines/pull/44#discussion_r132946506","pull_request_url":"https://api.github.com/repos/Starcounter/Guidelines/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/Starcounter/Guidelines/pulls/comments/132946506"},"html":{"href":"https://github.com/Starcounter/Guidelines/pull/44#discussion_r132946506"},"pull_request":{"href":"https://api.github.com/repos/Starcounter/Guidelines/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/Starcounter/Guidelines/pulls/44","id":135361998,"html_url":"https://github.com/Starcounter/Guidelines/pull/44","diff_url":"https://github.com/Starcounter/Guidelines/pull/44.diff","patch_url":"https://github.com/Starcounter/Guidelines/pull/44.patch","issue_url":"https://api.github.com/repos/Starcounter/Guidelines/issues/44","number":44,"state":"open","locked":false,"title":"C# 7 and string interpolation with typeof in SQL queries","user":{"login":"warpech","id":566463,"avatar_url":"https://avatars0.githubusercontent.com/u/566463?v=4","gravatar_id":"","url":"https://api.github.com/users/warpech","html_url":"https://github.com/warpech","followers_url":"https://api.github.com/users/warpech/followers","following_url":"https://api.github.com/users/warpech/following{/other_user}","gists_url":"https://api.github.com/users/warpech/gists{/gist_id}","starred_url":"https://api.github.com/users/warpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpech/subscriptions","organizations_url":"https://api.github.com/users/warpech/orgs","repos_url":"https://api.github.com/users/warpech/repos","events_url":"https://api.github.com/users/warpech/events{/privacy}","received_events_url":"https://api.github.com/users/warpech/received_events","type":"User","site_admin":false},"body":"Implements the advice from #29 and #25.\r\n\r\n@Starcounter/sc-apps please review.","created_at":"2017-08-11T15:33:26Z","updated_at":"2017-08-14T13:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"829aabc6c7b9b054e255157b281c29b6892a9aa7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Starcounter/Guidelines/pulls/44/commits","review_comments_url":"https://api.github.com/repos/Starcounter/Guidelines/pulls/44/comments","review_comment_url":"https://api.github.com/repos/Starcounter/Guidelines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Starcounter/Guidelines/issues/44/comments","statuses_url":"https://api.github.com/repos/Starcounter/Guidelines/statuses/963595bbaad6bd2f22d0a3e2a2027a5274ed8cf7","head":{"label":"Starcounter:c-sharp-improvements","ref":"c-sharp-improvements","sha":"963595bbaad6bd2f22d0a3e2a2027a5274ed8cf7","user":{"login":"Starcounter","id":1219066,"avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"repo":{"id":55141910,"name":"Guidelines","full_name":"Starcounter/Guidelines","owner":{"login":"Starcounter","id":1219066,"avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Starcounter/Guidelines","description":"Starcounter App Team developer guidelines","fork":false,"url":"https://api.github.com/repos/Starcounter/Guidelines","forks_url":"https://api.github.com/repos/Starcounter/Guidelines/forks","keys_url":"https://api.github.com/repos/Starcounter/Guidelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starcounter/Guidelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starcounter/Guidelines/teams","hooks_url":"https://api.github.com/repos/Starcounter/Guidelines/hooks","issue_events_url":"https://api.github.com/repos/Starcounter/Guidelines/issues/events{/number}","events_url":"https://api.github.com/repos/Starcounter/Guidelines/events","assignees_url":"https://api.github.com/repos/Starcounter/Guidelines/assignees{/user}","branches_url":"https://api.github.com/repos/Starcounter/Guidelines/branches{/branch}","tags_url":"https://api.github.com/repos/Starcounter/Guidelines/tags","blobs_url":"https://api.github.com/repos/Starcounter/Guidelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starcounter/Guidelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starcounter/Guidelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starcounter/Guidelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starcounter/Guidelines/statuses/{sha}","languages_url":"https://api.github.com/repos/Starcounter/Guidelines/languages","stargazers_url":"https://api.github.com/repos/Starcounter/Guidelines/stargazers","contributors_url":"https://api.github.com/repos/Starcounter/Guidelines/contributors","subscribers_url":"https://api.github.com/repos/Starcounter/Guidelines/subscribers","subscription_url":"https://api.github.com/repos/Starcounter/Guidelines/subscription","commits_url":"https://api.github.com/repos/Starcounter/Guidelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starcounter/Guidelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starcounter/Guidelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starcounter/Guidelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starcounter/Guidelines/contents/{+path}","compare_url":"https://api.github.com/repos/Starcounter/Guidelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starcounter/Guidelines/merges","archive_url":"https://api.github.com/repos/Starcounter/Guidelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starcounter/Guidelines/downloads","issues_url":"https://api.github.com/repos/Starcounter/Guidelines/issues{/number}","pulls_url":"https://api.github.com/repos/Starcounter/Guidelines/pulls{/number}","milestones_url":"https://api.github.com/repos/Starcounter/Guidelines/milestones{/number}","notifications_url":"https://api.github.com/repos/Starcounter/Guidelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starcounter/Guidelines/labels{/name}","releases_url":"https://api.github.com/repos/Starcounter/Guidelines/releases{/id}","deployments_url":"https://api.github.com/repos/Starcounter/Guidelines/deployments","created_at":"2016-03-31T10:27:17Z","updated_at":"2017-05-15T08:38:26Z","pushed_at":"2017-08-11T15:33:27Z","git_url":"git://github.com/Starcounter/Guidelines.git","ssh_url":"[email protected]:Starcounter/Guidelines.git","clone_url":"https://github.com/Starcounter/Guidelines.git","svn_url":"https://github.com/Starcounter/Guidelines","homepage":"https://starcounter.gitbooks.io/guidelines/content/","size":249,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":1,"default_branch":"master"}},"base":{"label":"Starcounter:master","ref":"master","sha":"d896ae1cf13dcdaa6ccf43abe5b8287f8caddf06","user":{"login":"Starcounter","id":1219066,"avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"repo":{"id":55141910,"name":"Guidelines","full_name":"Starcounter/Guidelines","owner":{"login":"Starcounter","id":1219066,"avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Starcounter/Guidelines","description":"Starcounter App Team developer guidelines","fork":false,"url":"https://api.github.com/repos/Starcounter/Guidelines","forks_url":"https://api.github.com/repos/Starcounter/Guidelines/forks","keys_url":"https://api.github.com/repos/Starcounter/Guidelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starcounter/Guidelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starcounter/Guidelines/teams","hooks_url":"https://api.github.com/repos/Starcounter/Guidelines/hooks","issue_events_url":"https://api.github.com/repos/Starcounter/Guidelines/issues/events{/number}","events_url":"https://api.github.com/repos/Starcounter/Guidelines/events","assignees_url":"https://api.github.com/repos/Starcounter/Guidelines/assignees{/user}","branches_url":"https://api.github.com/repos/Starcounter/Guidelines/branches{/branch}","tags_url":"https://api.github.com/repos/Starcounter/Guidelines/tags","blobs_url":"https://api.github.com/repos/Starcounter/Guidelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starcounter/Guidelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starcounter/Guidelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starcounter/Guidelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starcounter/Guidelines/statuses/{sha}","languages_url":"https://api.github.com/repos/Starcounter/Guidelines/languages","stargazers_url":"https://api.github.com/repos/Starcounter/Guidelines/stargazers","contributors_url":"https://api.github.com/repos/Starcounter/Guidelines/contributors","subscribers_url":"https://api.github.com/repos/Starcounter/Guidelines/subscribers","subscription_url":"https://api.github.com/repos/Starcounter/Guidelines/subscription","commits_url":"https://api.github.com/repos/Starcounter/Guidelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starcounter/Guidelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starcounter/Guidelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starcounter/Guidelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starcounter/Guidelines/contents/{+path}","compare_url":"https://api.github.com/repos/Starcounter/Guidelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starcounter/Guidelines/merges","archive_url":"https://api.github.com/repos/Starcounter/Guidelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starcounter/Guidelines/downloads","issues_url":"https://api.github.com/repos/Starcounter/Guidelines/issues{/number}","pulls_url":"https://api.github.com/repos/Starcounter/Guidelines/pulls{/number}","milestones_url":"https://api.github.com/repos/Starcounter/Guidelines/milestones{/number}","notifications_url":"https://api.github.com/repos/Starcounter/Guidelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starcounter/Guidelines/labels{/name}","releases_url":"https://api.github.com/repos/Starcounter/Guidelines/releases{/id}","deployments_url":"https://api.github.com/repos/Starcounter/Guidelines/deployments","created_at":"2016-03-31T10:27:17Z","updated_at":"2017-05-15T08:38:26Z","pushed_at":"2017-08-11T15:33:27Z","git_url":"git://github.com/Starcounter/Guidelines.git","ssh_url":"[email protected]:Starcounter/Guidelines.git","clone_url":"https://github.com/Starcounter/Guidelines.git","svn_url":"https://github.com/Starcounter/Guidelines","homepage":"https://starcounter.gitbooks.io/guidelines/content/","size":249,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Starcounter/Guidelines/pulls/44"},"html":{"href":"https://github.com/Starcounter/Guidelines/pull/44"},"issue":{"href":"https://api.github.com/repos/Starcounter/Guidelines/issues/44"},"comments":{"href":"https://api.github.com/repos/Starcounter/Guidelines/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/Starcounter/Guidelines/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/Starcounter/Guidelines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Starcounter/Guidelines/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/Starcounter/Guidelines/statuses/963595bbaad6bd2f22d0a3e2a2027a5274ed8cf7"}}}} | {
"id": 55141910,
"name": "Starcounter/Guidelines",
"url": "https://api.github.com/repos/Starcounter/Guidelines"
} | {
"id": 6013217,
"login": "joozek78",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6013217?",
"url": "https://api.github.com/users/joozek78"
} | {
"id": 1219066,
"login": "Starcounter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1219066?",
"url": "https://api.github.com/orgs/Starcounter"
} | 2017-08-14T13:13:40 | 6448643417 | {"actor":{"display_login":"joozek78"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/comments/147295108","pull_request_review_id":72372058,"id":147295108,"diff_hunk":"@@ -0,0 +1,36 @@\n+# Magellan IS\n+\n+## Purpose\n+\n+The Purpose of this project is to document the design of the original Magellan ISO board which is no longer in use.\n+\n+-----\n+\n+## Circuit Diagram\n+The designs for the board are in this repository. It consists of the main logic board, on which a Rabbitboard RCM2100 sits to control the entire system, and then it has three separate boards that it connects to using a 40 conduit bus. Using Buffers, it selects certain components to output onto the bus, and then records that information. Afterwards, it moves onto the next set of components.\n+\n+The circuit diagram formats are in \".json\" and \".schdoc\". In \".shcdoc\" is used by [Altium](), a professional development software. The \".json\" format is used by [EasyEDA](https://easyeda.com/), which is a free online platform. To use EasyEDA, simply download the \".json\" formatted files, and then select \"Open EasyEDA file\" from the \"File\" menu on EasyEDA.com.\n+\n+Note: The PCB schematics for these circuit diagrams are not included. Each ISO boardb may be slightly different than the rest because of space or design needs, and so each PCB requirements are different.","path":"Magellan-ISO/README.md","position":14,"original_position":14,"commit_id":"b5428466e4ba137d9872ce7e8402da3db6b2455d","original_commit_id":"b5428466e4ba137d9872ce7e8402da3db6b2455d","user":{"login":"alexanderson1993","id":6558157,"avatar_url":"https://avatars1.githubusercontent.com/u/6558157?v=4","gravatar_id":"","url":"https://api.github.com/users/alexanderson1993","html_url":"https://github.com/alexanderson1993","followers_url":"https://api.github.com/users/alexanderson1993/followers","following_url":"https://api.github.com/users/alexanderson1993/following{/other_user}","gists_url":"https://api.github.com/users/alexanderson1993/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderson1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderson1993/subscriptions","organizations_url":"https://api.github.com/users/alexanderson1993/orgs","repos_url":"https://api.github.com/users/alexanderson1993/repos","events_url":"https://api.github.com/users/alexanderson1993/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderson1993/received_events","type":"User","site_admin":false},"body":"boardb vs board","created_at":"2017-10-26T23:41:53Z","updated_at":"2017-10-26T23:42:15Z","html_url":"https://github.com/Thorium-Sim/thorium-hardware/pull/6#discussion_r147295108","pull_request_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/6","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/comments/147295108"},"html":{"href":"https://github.com/Thorium-Sim/thorium-hardware/pull/6#discussion_r147295108"},"pull_request":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/6"}},"in_reply_to_id":147295095},"pull_request":{"url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/6","id":149070666,"html_url":"https://github.com/Thorium-Sim/thorium-hardware/pull/6","diff_url":"https://github.com/Thorium-Sim/thorium-hardware/pull/6.diff","patch_url":"https://github.com/Thorium-Sim/thorium-hardware/pull/6.patch","issue_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues/6","number":6,"state":"open","locked":false,"title":"`Included README.md for info and instructions. Included also all Cir…","user":{"login":"Emrix","id":1387836,"avatar_url":"https://avatars0.githubusercontent.com/u/1387836?v=4","gravatar_id":"","url":"https://api.github.com/users/Emrix","html_url":"https://github.com/Emrix","followers_url":"https://api.github.com/users/Emrix/followers","following_url":"https://api.github.com/users/Emrix/following{/other_user}","gists_url":"https://api.github.com/users/Emrix/gists{/gist_id}","starred_url":"https://api.github.com/users/Emrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emrix/subscriptions","organizations_url":"https://api.github.com/users/Emrix/orgs","repos_url":"https://api.github.com/users/Emrix/repos","events_url":"https://api.github.com/users/Emrix/events{/privacy}","received_events_url":"https://api.github.com/users/Emrix/received_events","type":"User","site_admin":false},"body":"…cuit Diagrams in 2 formats for the Magellan ISO board.","created_at":"2017-10-26T23:39:23Z","updated_at":"2017-10-26T23:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5994771b12e696503e653b19bca62fee73162d95","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues/6/comments","statuses_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/statuses/b5428466e4ba137d9872ce7e8402da3db6b2455d","head":{"label":"Thorium-Sim:Magellan-ISO","ref":"Magellan-ISO","sha":"b5428466e4ba137d9872ce7e8402da3db6b2455d","user":{"login":"Thorium-Sim","id":23285942,"avatar_url":"https://avatars2.githubusercontent.com/u/23285942?v=4","gravatar_id":"","url":"https://api.github.com/users/Thorium-Sim","html_url":"https://github.com/Thorium-Sim","followers_url":"https://api.github.com/users/Thorium-Sim/followers","following_url":"https://api.github.com/users/Thorium-Sim/following{/other_user}","gists_url":"https://api.github.com/users/Thorium-Sim/gists{/gist_id}","starred_url":"https://api.github.com/users/Thorium-Sim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thorium-Sim/subscriptions","organizations_url":"https://api.github.com/users/Thorium-Sim/orgs","repos_url":"https://api.github.com/users/Thorium-Sim/repos","events_url":"https://api.github.com/users/Thorium-Sim/events{/privacy}","received_events_url":"https://api.github.com/users/Thorium-Sim/received_events","type":"Organization","site_admin":false},"repo":{"id":101947065,"name":"thorium-hardware","full_name":"Thorium-Sim/thorium-hardware","owner":{"login":"Thorium-Sim","id":23285942,"avatar_url":"https://avatars2.githubusercontent.com/u/23285942?v=4","gravatar_id":"","url":"https://api.github.com/users/Thorium-Sim","html_url":"https://github.com/Thorium-Sim","followers_url":"https://api.github.com/users/Thorium-Sim/followers","following_url":"https://api.github.com/users/Thorium-Sim/following{/other_user}","gists_url":"https://api.github.com/users/Thorium-Sim/gists{/gist_id}","starred_url":"https://api.github.com/users/Thorium-Sim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thorium-Sim/subscriptions","organizations_url":"https://api.github.com/users/Thorium-Sim/orgs","repos_url":"https://api.github.com/users/Thorium-Sim/repos","events_url":"https://api.github.com/users/Thorium-Sim/events{/privacy}","received_events_url":"https://api.github.com/users/Thorium-Sim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Thorium-Sim/thorium-hardware","description":"Hardware panel controllers for Thorium","fork":false,"url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware","forks_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/forks","keys_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/teams","hooks_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/hooks","issue_events_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues/events{/number}","events_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/events","assignees_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/assignees{/user}","branches_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/branches{/branch}","tags_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/tags","blobs_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/statuses/{sha}","languages_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/languages","stargazers_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/stargazers","contributors_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/contributors","subscribers_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/subscribers","subscription_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/subscription","commits_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/contents/{+path}","compare_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/merges","archive_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/downloads","issues_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues{/number}","pulls_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls{/number}","milestones_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/milestones{/number}","notifications_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/labels{/name}","releases_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/releases{/id}","deployments_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/deployments","created_at":"2017-08-31T01:50:36Z","updated_at":"2017-08-31T01:51:07Z","pushed_at":"2017-10-26T23:39:24Z","git_url":"git://github.com/Thorium-Sim/thorium-hardware.git","ssh_url":"[email protected]:Thorium-Sim/thorium-hardware.git","clone_url":"https://github.com/Thorium-Sim/thorium-hardware.git","svn_url":"https://github.com/Thorium-Sim/thorium-hardware","homepage":null,"size":15864,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"Thorium-Sim:master","ref":"master","sha":"d58252f28d7d59203e9c3244016e81947dbea8f3","user":{"login":"Thorium-Sim","id":23285942,"avatar_url":"https://avatars2.githubusercontent.com/u/23285942?v=4","gravatar_id":"","url":"https://api.github.com/users/Thorium-Sim","html_url":"https://github.com/Thorium-Sim","followers_url":"https://api.github.com/users/Thorium-Sim/followers","following_url":"https://api.github.com/users/Thorium-Sim/following{/other_user}","gists_url":"https://api.github.com/users/Thorium-Sim/gists{/gist_id}","starred_url":"https://api.github.com/users/Thorium-Sim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thorium-Sim/subscriptions","organizations_url":"https://api.github.com/users/Thorium-Sim/orgs","repos_url":"https://api.github.com/users/Thorium-Sim/repos","events_url":"https://api.github.com/users/Thorium-Sim/events{/privacy}","received_events_url":"https://api.github.com/users/Thorium-Sim/received_events","type":"Organization","site_admin":false},"repo":{"id":101947065,"name":"thorium-hardware","full_name":"Thorium-Sim/thorium-hardware","owner":{"login":"Thorium-Sim","id":23285942,"avatar_url":"https://avatars2.githubusercontent.com/u/23285942?v=4","gravatar_id":"","url":"https://api.github.com/users/Thorium-Sim","html_url":"https://github.com/Thorium-Sim","followers_url":"https://api.github.com/users/Thorium-Sim/followers","following_url":"https://api.github.com/users/Thorium-Sim/following{/other_user}","gists_url":"https://api.github.com/users/Thorium-Sim/gists{/gist_id}","starred_url":"https://api.github.com/users/Thorium-Sim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thorium-Sim/subscriptions","organizations_url":"https://api.github.com/users/Thorium-Sim/orgs","repos_url":"https://api.github.com/users/Thorium-Sim/repos","events_url":"https://api.github.com/users/Thorium-Sim/events{/privacy}","received_events_url":"https://api.github.com/users/Thorium-Sim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Thorium-Sim/thorium-hardware","description":"Hardware panel controllers for Thorium","fork":false,"url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware","forks_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/forks","keys_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/teams","hooks_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/hooks","issue_events_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues/events{/number}","events_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/events","assignees_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/assignees{/user}","branches_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/branches{/branch}","tags_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/tags","blobs_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/statuses/{sha}","languages_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/languages","stargazers_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/stargazers","contributors_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/contributors","subscribers_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/subscribers","subscription_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/subscription","commits_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/contents/{+path}","compare_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/merges","archive_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/downloads","issues_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues{/number}","pulls_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls{/number}","milestones_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/milestones{/number}","notifications_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/labels{/name}","releases_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/releases{/id}","deployments_url":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/deployments","created_at":"2017-08-31T01:50:36Z","updated_at":"2017-08-31T01:51:07Z","pushed_at":"2017-10-26T23:39:24Z","git_url":"git://github.com/Thorium-Sim/thorium-hardware.git","ssh_url":"[email protected]:Thorium-Sim/thorium-hardware.git","clone_url":"https://github.com/Thorium-Sim/thorium-hardware.git","svn_url":"https://github.com/Thorium-Sim/thorium-hardware","homepage":null,"size":15864,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/6"},"html":{"href":"https://github.com/Thorium-Sim/thorium-hardware/pull/6"},"issue":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues/6"},"comments":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Thorium-Sim/thorium-hardware/statuses/b5428466e4ba137d9872ce7e8402da3db6b2455d"}},"author_association":"COLLABORATOR"}} | {
"id": 101947065,
"name": "Thorium-Sim/thorium-hardware",
"url": "https://api.github.com/repos/Thorium-Sim/thorium-hardware"
} | {
"id": 6558157,
"login": "alexanderson1993",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6558157?",
"url": "https://api.github.com/users/alexanderson1993"
} | {
"id": 23285942,
"login": "Thorium-Sim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23285942?",
"url": "https://api.github.com/orgs/Thorium-Sim"
} | 2017-10-26T23:41:53 | 6772566402 | {"actor":{"display_login":"alexanderson1993"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/126017062","pull_request_review_id":48457253,"id":126017062,"diff_hunk":"@@ -502,6 +543,66 @@ void LightSampler::sample(\n else sample_emitting_triangles(time, s, light_sample);\n }\n \n+void LightSampler::sample(\n+ const ShadingRay::Time& time,\n+ const Vector3f& s,\n+ const ShadingPoint& shading_point,\n+ LightSample& light_sample) const\n+{\n+ // Mark different light groups.\n+ const size_t light_group_non_physical_cdf = 0;\n+ const size_t light_group_emitting_triangle_cdf = 1;\n+ const size_t light_group_light_tree = 2;\n+\n+ size_t candidate_groups[3];\n+ size_t candidate_groups_count = 0;\n+\n+ // Check for existence of each light group and record it.\n+ if (m_non_physical_lights_cdf.valid())\n+ candidate_groups[candidate_groups_count++] = light_group_non_physical_cdf;\n+ if (m_emitting_triangles_cdf.valid())\n+ candidate_groups[candidate_groups_count++] = light_group_emitting_triangle_cdf;\n+ if (m_light_tree.is_built())\n+ candidate_groups[candidate_groups_count++] = light_group_light_tree;\n+\n+ // At least one light group must be present.\n+ assert(!candidate_groups.empty());\n+\n+ // Randomly select one of the group which will be sampled.\n+ size_t const selected_index = s[0] * candidate_groups_count;\n+ size_t const selected_type = candidate_groups[selected_index];\n+ \n+ // Avoid bias propagation by expanding the chosen interval back to [0,1].\n+ float probability_interval_shift = (s[0] - selected_index / candidate_groups_count) * candidate_groups_count;\n+\n+ switch (selected_type)\n+ {\n+ case light_group_non_physical_cdf:\n+ sample_non_physical_lights(\n+ time,\n+ foundation::Vector3f(probability_interval_shift, s[1], s[2]),\n+ light_sample);\n+ light_sample.m_probability /= candidate_groups_count;\n+ break;\n+ case light_group_emitting_triangle_cdf:\n+ sample_emitting_triangles(\n+ time,\n+ foundation::Vector3f(probability_interval_shift, s[1], s[2]),\n+ light_sample);\n+ light_sample.m_probability /= candidate_groups_count;\n+ break;\n+ case light_group_light_tree:\n+ sample_light_tree_lights(\n+ time,\n+ foundation::Vector3f(probability_interval_shift, s[1], s[2]),\n+ shading_point,\n+ light_sample);\n+ break;","path":"src/appleseed/renderer/kernel/lighting/lightsampler.cpp","position":168,"original_position":168,"commit_id":"4669ef3108b7fc253a0d5f74bbdcace9a449a020","original_commit_id":"4669ef3108b7fc253a0d5f74bbdcace9a449a020","user":{"login":"dictoon","id":321290,"avatar_url":"https://avatars2.githubusercontent.com/u/321290?v=3","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"Not dividing `light_sample.m_probability` by `candidate_groups_count` here?","created_at":"2017-07-06T21:11:29Z","updated_at":"2017-07-06T21:31:02Z","html_url":"https://github.com/appleseedhq/appleseed/pull/1505#discussion_r126017062","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1505","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/126017062"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1505#discussion_r126017062"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1505"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1505","id":128970800,"html_url":"https://github.com/appleseedhq/appleseed/pull/1505","diff_url":"https://github.com/appleseedhq/appleseed/pull/1505.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/1505.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1505","number":1505,"state":"open","locked":false,"title":"Light tree","user":{"login":"gospodnetic","id":15703361,"avatar_url":"https://avatars0.githubusercontent.com/u/15703361?v=3","gravatar_id":"","url":"https://api.github.com/users/gospodnetic","html_url":"https://github.com/gospodnetic","followers_url":"https://api.github.com/users/gospodnetic/followers","following_url":"https://api.github.com/users/gospodnetic/following{/other_user}","gists_url":"https://api.github.com/users/gospodnetic/gists{/gist_id}","starred_url":"https://api.github.com/users/gospodnetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gospodnetic/subscriptions","organizations_url":"https://api.github.com/users/gospodnetic/orgs","repos_url":"https://api.github.com/users/gospodnetic/repos","events_url":"https://api.github.com/users/gospodnetic/events{/privacy}","received_events_url":"https://api.github.com/users/gospodnetic/received_events","type":"User","site_admin":false},"body":"Initial integration of the LightTree sampling. The tree can handle only point source lights. The point lights are flagged as `LightTreeCompatible` and, as such, extracted into a separate vector within the `LightSampler`\r\n\r\nSince we know the lights within the `LightTree` can only be non physical for now, contributions from the `LightTree` within the `DirectLightingIntegrator` are added using the `add_non_physical_light_sample_contribution()`. It is something that works now but should be changed/expanded once I add other types of lights to the tree. I wouldn't change it now because I am not sure yet what and how should I change. I can duplicate the `add_non_physical_light_sample_contribution()` function and rename it into `add_light_tree_sample_contribution()` just to mark the spot that will be expanded.","created_at":"2017-07-05T14:03:20Z","updated_at":"2017-07-06T21:31:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1505/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1505/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1505/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/4669ef3108b7fc253a0d5f74bbdcace9a449a020","head":{"label":"gospodnetic:LightTree","ref":"LightTree","sha":"4669ef3108b7fc253a0d5f74bbdcace9a449a020","user":{"login":"gospodnetic","id":15703361,"avatar_url":"https://avatars0.githubusercontent.com/u/15703361?v=3","gravatar_id":"","url":"https://api.github.com/users/gospodnetic","html_url":"https://github.com/gospodnetic","followers_url":"https://api.github.com/users/gospodnetic/followers","following_url":"https://api.github.com/users/gospodnetic/following{/other_user}","gists_url":"https://api.github.com/users/gospodnetic/gists{/gist_id}","starred_url":"https://api.github.com/users/gospodnetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gospodnetic/subscriptions","organizations_url":"https://api.github.com/users/gospodnetic/orgs","repos_url":"https://api.github.com/users/gospodnetic/repos","events_url":"https://api.github.com/users/gospodnetic/events{/privacy}","received_events_url":"https://api.github.com/users/gospodnetic/received_events","type":"User","site_admin":false},"repo":{"id":84643083,"name":"appleseed","full_name":"gospodnetic/appleseed","owner":{"login":"gospodnetic","id":15703361,"avatar_url":"https://avatars0.githubusercontent.com/u/15703361?v=3","gravatar_id":"","url":"https://api.github.com/users/gospodnetic","html_url":"https://github.com/gospodnetic","followers_url":"https://api.github.com/users/gospodnetic/followers","following_url":"https://api.github.com/users/gospodnetic/following{/other_user}","gists_url":"https://api.github.com/users/gospodnetic/gists{/gist_id}","starred_url":"https://api.github.com/users/gospodnetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gospodnetic/subscriptions","organizations_url":"https://api.github.com/users/gospodnetic/orgs","repos_url":"https://api.github.com/users/gospodnetic/repos","events_url":"https://api.github.com/users/gospodnetic/events{/privacy}","received_events_url":"https://api.github.com/users/gospodnetic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gospodnetic/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":true,"url":"https://api.github.com/repos/gospodnetic/appleseed","forks_url":"https://api.github.com/repos/gospodnetic/appleseed/forks","keys_url":"https://api.github.com/repos/gospodnetic/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gospodnetic/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gospodnetic/appleseed/teams","hooks_url":"https://api.github.com/repos/gospodnetic/appleseed/hooks","issue_events_url":"https://api.github.com/repos/gospodnetic/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/gospodnetic/appleseed/events","assignees_url":"https://api.github.com/repos/gospodnetic/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/gospodnetic/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/gospodnetic/appleseed/tags","blobs_url":"https://api.github.com/repos/gospodnetic/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gospodnetic/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gospodnetic/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/gospodnetic/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gospodnetic/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/gospodnetic/appleseed/languages","stargazers_url":"https://api.github.com/repos/gospodnetic/appleseed/stargazers","contributors_url":"https://api.github.com/repos/gospodnetic/appleseed/contributors","subscribers_url":"https://api.github.com/repos/gospodnetic/appleseed/subscribers","subscription_url":"https://api.github.com/repos/gospodnetic/appleseed/subscription","commits_url":"https://api.github.com/repos/gospodnetic/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/gospodnetic/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/gospodnetic/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/gospodnetic/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/gospodnetic/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/gospodnetic/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gospodnetic/appleseed/merges","archive_url":"https://api.github.com/repos/gospodnetic/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gospodnetic/appleseed/downloads","issues_url":"https://api.github.com/repos/gospodnetic/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/gospodnetic/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/gospodnetic/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/gospodnetic/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gospodnetic/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/gospodnetic/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/gospodnetic/appleseed/deployments","created_at":"2017-03-11T10:50:26Z","updated_at":"2017-03-11T10:50:37Z","pushed_at":"2017-07-06T15:31:14Z","git_url":"git://github.com/gospodnetic/appleseed.git","ssh_url":"[email protected]:gospodnetic/appleseed.git","clone_url":"https://github.com/gospodnetic/appleseed.git","svn_url":"https://github.com/gospodnetic/appleseed","homepage":"http://appleseedhq.net/","size":934296,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"fd9faad88fbd81b97a1da391b669c3eec548a729","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars0.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars0.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed/deployments","created_at":"2010-07-02T16:33:51Z","updated_at":"2017-07-06T10:42:02Z","pushed_at":"2017-07-06T15:31:16Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"[email protected]:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"http://appleseedhq.net/","size":940043,"stargazers_count":757,"watchers_count":757,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":268,"forks":140,"open_issues":268,"watchers":757,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1505"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1505"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1505"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1505/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1505/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1505/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/4669ef3108b7fc253a0d5f74bbdcace9a449a020"}}}} | {
"id": 753784,
"name": "appleseedhq/appleseed",
"url": "https://api.github.com/repos/appleseedhq/appleseed"
} | {
"id": 321290,
"login": "dictoon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/321290?",
"url": "https://api.github.com/users/dictoon"
} | {
"id": 6373510,
"login": "appleseedhq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6373510?",
"url": "https://api.github.com/orgs/appleseedhq"
} | 2017-07-06T21:11:29 | 6207732859 | {"actor":{"display_login":"dictoon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/94288390","pull_request_review_id":14817112,"id":94288390,"diff_hunk":"@@ -0,0 +1,246 @@\n+\n+//\n+// This source file is part of appleseed.\n+// Visit http://appleseedhq.net/ for additional information and resources.\n+//\n+// This software is released under the MIT license.\n+//\n+// Copyright (c) 2015 Esteban Tovagliari, The appleseedhq Organization","path":"src/appleseed/renderer/modeling/surfaceshader/oslsurfaceshader.cpp","position":8,"original_position":8,"commit_id":"ebe3ee145309ed87260527cd50412b8864373b7b","original_commit_id":"ebe3ee145309ed87260527cd50412b8864373b7b","user":{"login":"dictoon","id":321290,"avatar_url":"https://avatars.githubusercontent.com/u/321290?v=3","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"Fix year in copyright notice (it probably should say 2016, or 2015-2016, until I update all notices for the year 2017).","created_at":"2017-01-01T20:15:01Z","updated_at":"2017-01-01T20:17:08Z","html_url":"https://github.com/appleseedhq/appleseed/pull/1193#discussion_r94288390","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1193","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/94288390"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1193#discussion_r94288390"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1193"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1193","id":99802090,"html_url":"https://github.com/appleseedhq/appleseed/pull/1193","diff_url":"https://github.com/appleseedhq/appleseed/pull/1193.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/1193.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1193","number":1193,"state":"open","locked":false,"title":"OSL Misc work","user":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"body":"Added OSL's coordinate systems transforms from object, camera and world to NDC and raster spaces.\r\n\r\nOSL's SurfaceShaders:\r\nA surface shader that runs an OSL shader to post-process the shading results. Might be useful to do color corrections and other special effects.\r\nThe commit includes useful things, like marking OSL shader parameters as outputs and getting shader symbols to be able to fetch results from them.\r\n","created_at":"2016-12-31T10:10:31Z","updated_at":"2017-01-01T20:17:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0bf1a92df317d60ed2f3785a7c4bcefa3aca560","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1193/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1193/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1193/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/ebe3ee145309ed87260527cd50412b8864373b7b","head":{"label":"est77:est_misc_work","ref":"est_misc_work","sha":"ebe3ee145309ed87260527cd50412b8864373b7b","user":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"repo":{"id":10621343,"name":"appleseed","full_name":"est77/appleseed","owner":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/est77/appleseed","description":"appleseed is a modern, physically-based production renderer.","fork":true,"url":"https://api.github.com/repos/est77/appleseed","forks_url":"https://api.github.com/repos/est77/appleseed/forks","keys_url":"https://api.github.com/repos/est77/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/est77/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/est77/appleseed/teams","hooks_url":"https://api.github.com/repos/est77/appleseed/hooks","issue_events_url":"https://api.github.com/repos/est77/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/est77/appleseed/events","assignees_url":"https://api.github.com/repos/est77/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/est77/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/est77/appleseed/tags","blobs_url":"https://api.github.com/repos/est77/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/est77/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/est77/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/est77/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/est77/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/est77/appleseed/languages","stargazers_url":"https://api.github.com/repos/est77/appleseed/stargazers","contributors_url":"https://api.github.com/repos/est77/appleseed/contributors","subscribers_url":"https://api.github.com/repos/est77/appleseed/subscribers","subscription_url":"https://api.github.com/repos/est77/appleseed/subscription","commits_url":"https://api.github.com/repos/est77/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/est77/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/est77/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/est77/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/est77/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/est77/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/est77/appleseed/merges","archive_url":"https://api.github.com/repos/est77/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/est77/appleseed/downloads","issues_url":"https://api.github.com/repos/est77/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/est77/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/est77/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/est77/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/est77/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/est77/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/est77/appleseed/deployments","created_at":"2013-06-11T12:49:35Z","updated_at":"2015-04-30T17:28:14Z","pushed_at":"2016-12-31T09:51:54Z","git_url":"git://github.com/est77/appleseed.git","ssh_url":"[email protected]:est77/appleseed.git","clone_url":"https://github.com/est77/appleseed.git","svn_url":"https://github.com/est77/appleseed","homepage":"http://appleseedhq.net/","size":717872,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"a36572436d9ef327ca6adbb91a7ff13a3902d485","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"appleseed is a modern, physically-based production renderer","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed/deployments","created_at":"2010-07-02T16:33:51Z","updated_at":"2016-12-26T19:41:22Z","pushed_at":"2016-12-31T10:10:32Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"[email protected]:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"http://appleseedhq.net/","size":717778,"stargazers_count":338,"watchers_count":338,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":217,"forks":97,"open_issues":217,"watchers":338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1193"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1193"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1193"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1193/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1193/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1193/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/ebe3ee145309ed87260527cd50412b8864373b7b"}}}} | {
"id": 753784,
"name": "appleseedhq/appleseed",
"url": "https://api.github.com/repos/appleseedhq/appleseed"
} | {
"id": 321290,
"login": "dictoon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/321290?",
"url": "https://api.github.com/users/dictoon"
} | {
"id": 6373510,
"login": "appleseedhq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6373510?",
"url": "https://api.github.com/orgs/appleseedhq"
} | 2017-01-01T20:15:01 | 5089698046 | {"actor":{"display_login":"dictoon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments/158692366","pull_request_review_id":85528776,"id":158692366,"diff_hunk":"@@ -712,8 +716,14 @@ namespace\n m_spinner_renderingthreads->SetResetValue(RendererSettings::defaults().m_rendering_threads);\n m_spinner_renderingthreads->SetValue(m_settings.m_rendering_threads, FALSE);\n \n+ const wchar_t* log_combo_items[] = { L\"Always\", L\"Never\", L\"On Error\" };\n+ for (int i = 0; i < 3; i++)","path":"src/appleseed-max-impl/appleseedrenderer/appleseedrendererparamdlg.cpp","position":30,"original_position":30,"commit_id":"ba4523025fe8566367a4275f4b7c437f1ca4f659","original_commit_id":"ba4523025fe8566367a4275f4b7c437f1ca4f659","user":{"login":"dictoon","id":321290,"avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"Prefer `size_t` unless another type is required.","created_at":"2017-12-26T10:40:03Z","updated_at":"2017-12-26T11:02:54Z","html_url":"https://github.com/appleseedhq/appleseed-max/pull/113#discussion_r158692366","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/113","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments/158692366"},"html":{"href":"https://github.com/appleseedhq/appleseed-max/pull/113#discussion_r158692366"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/113","id":160084335,"html_url":"https://github.com/appleseedhq/appleseed-max/pull/113","diff_url":"https://github.com/appleseedhq/appleseed-max/pull/113.diff","patch_url":"https://github.com/appleseedhq/appleseed-max/pull/113.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/113","number":113,"state":"open","locked":false,"title":"Add dialog window for rendering log","user":{"login":"usakhelo","id":1850877,"avatar_url":"https://avatars3.githubusercontent.com/u/1850877?v=4","gravatar_id":"","url":"https://api.github.com/users/usakhelo","html_url":"https://github.com/usakhelo","followers_url":"https://api.github.com/users/usakhelo/followers","following_url":"https://api.github.com/users/usakhelo/following{/other_user}","gists_url":"https://api.github.com/users/usakhelo/gists{/gist_id}","starred_url":"https://api.github.com/users/usakhelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usakhelo/subscriptions","organizations_url":"https://api.github.com/users/usakhelo/orgs","repos_url":"https://api.github.com/users/usakhelo/repos","events_url":"https://api.github.com/users/usakhelo/events{/privacy}","received_events_url":"https://api.github.com/users/usakhelo/received_events","type":"User","site_admin":false},"body":"Hi,\r\nThis pr adds dialog window to print rendering log messages. Three ui elements added to the System rollout of appleseed settings tab:\r\n - ComboBox with three choices of messages types that will cause dialog to open automatically\r\n - Button to open dialog manually before render or open dialog with messages from previous rendering session\r\n - Checkbox to turn on/off logging of rendering of material samples\r\n\r\nCombobox and checkbox state is saved into ini file to standard max config folder and loaded on each max startup - %localappdata%\\Autodesk\\3dsMax\\2016 - 64bit\\ENU\\en-US\\plugcfg\\appleseed\\appleseed.ini (language code and max version varies).\r\n\r\nProbably worth noting: log window is another appleseed log target that gets attached and detached on rendering start and finish, so no plugin initialization warnings and errors will show up in the window.\r\n\r\nThanks for review,\r\nSergo.","created_at":"2017-12-26T05:08:18Z","updated_at":"2017-12-26T11:02:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80d0b54fdd02d777ce6522c819eb5457acf2c3cd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/113/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/113/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/113/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/ba4523025fe8566367a4275f4b7c437f1ca4f659","head":{"label":"usakhelo:log_window_pr","ref":"log_window_pr","sha":"ba4523025fe8566367a4275f4b7c437f1ca4f659","user":{"login":"usakhelo","id":1850877,"avatar_url":"https://avatars3.githubusercontent.com/u/1850877?v=4","gravatar_id":"","url":"https://api.github.com/users/usakhelo","html_url":"https://github.com/usakhelo","followers_url":"https://api.github.com/users/usakhelo/followers","following_url":"https://api.github.com/users/usakhelo/following{/other_user}","gists_url":"https://api.github.com/users/usakhelo/gists{/gist_id}","starred_url":"https://api.github.com/users/usakhelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usakhelo/subscriptions","organizations_url":"https://api.github.com/users/usakhelo/orgs","repos_url":"https://api.github.com/users/usakhelo/repos","events_url":"https://api.github.com/users/usakhelo/events{/privacy}","received_events_url":"https://api.github.com/users/usakhelo/received_events","type":"User","site_admin":false},"repo":{"id":88937196,"name":"appleseed-max","full_name":"usakhelo/appleseed-max","owner":{"login":"usakhelo","id":1850877,"avatar_url":"https://avatars3.githubusercontent.com/u/1850877?v=4","gravatar_id":"","url":"https://api.github.com/users/usakhelo","html_url":"https://github.com/usakhelo","followers_url":"https://api.github.com/users/usakhelo/followers","following_url":"https://api.github.com/users/usakhelo/following{/other_user}","gists_url":"https://api.github.com/users/usakhelo/gists{/gist_id}","starred_url":"https://api.github.com/users/usakhelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usakhelo/subscriptions","organizations_url":"https://api.github.com/users/usakhelo/orgs","repos_url":"https://api.github.com/users/usakhelo/repos","events_url":"https://api.github.com/users/usakhelo/events{/privacy}","received_events_url":"https://api.github.com/users/usakhelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/usakhelo/appleseed-max","description":"appleseed plugin for Autodesk® 3ds Max®","fork":true,"url":"https://api.github.com/repos/usakhelo/appleseed-max","forks_url":"https://api.github.com/repos/usakhelo/appleseed-max/forks","keys_url":"https://api.github.com/repos/usakhelo/appleseed-max/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usakhelo/appleseed-max/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usakhelo/appleseed-max/teams","hooks_url":"https://api.github.com/repos/usakhelo/appleseed-max/hooks","issue_events_url":"https://api.github.com/repos/usakhelo/appleseed-max/issues/events{/number}","events_url":"https://api.github.com/repos/usakhelo/appleseed-max/events","assignees_url":"https://api.github.com/repos/usakhelo/appleseed-max/assignees{/user}","branches_url":"https://api.github.com/repos/usakhelo/appleseed-max/branches{/branch}","tags_url":"https://api.github.com/repos/usakhelo/appleseed-max/tags","blobs_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/refs{/sha}","trees_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usakhelo/appleseed-max/statuses/{sha}","languages_url":"https://api.github.com/repos/usakhelo/appleseed-max/languages","stargazers_url":"https://api.github.com/repos/usakhelo/appleseed-max/stargazers","contributors_url":"https://api.github.com/repos/usakhelo/appleseed-max/contributors","subscribers_url":"https://api.github.com/repos/usakhelo/appleseed-max/subscribers","subscription_url":"https://api.github.com/repos/usakhelo/appleseed-max/subscription","commits_url":"https://api.github.com/repos/usakhelo/appleseed-max/commits{/sha}","git_commits_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/commits{/sha}","comments_url":"https://api.github.com/repos/usakhelo/appleseed-max/comments{/number}","issue_comment_url":"https://api.github.com/repos/usakhelo/appleseed-max/issues/comments{/number}","contents_url":"https://api.github.com/repos/usakhelo/appleseed-max/contents/{+path}","compare_url":"https://api.github.com/repos/usakhelo/appleseed-max/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usakhelo/appleseed-max/merges","archive_url":"https://api.github.com/repos/usakhelo/appleseed-max/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usakhelo/appleseed-max/downloads","issues_url":"https://api.github.com/repos/usakhelo/appleseed-max/issues{/number}","pulls_url":"https://api.github.com/repos/usakhelo/appleseed-max/pulls{/number}","milestones_url":"https://api.github.com/repos/usakhelo/appleseed-max/milestones{/number}","notifications_url":"https://api.github.com/repos/usakhelo/appleseed-max/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usakhelo/appleseed-max/labels{/name}","releases_url":"https://api.github.com/repos/usakhelo/appleseed-max/releases{/id}","deployments_url":"https://api.github.com/repos/usakhelo/appleseed-max/deployments","created_at":"2017-04-21T03:48:17Z","updated_at":"2017-04-21T03:48:19Z","pushed_at":"2017-12-26T04:59:19Z","git_url":"git://github.com/usakhelo/appleseed-max.git","ssh_url":"[email protected]:usakhelo/appleseed-max.git","clone_url":"https://github.com/usakhelo/appleseed-max.git","svn_url":"https://github.com/usakhelo/appleseed-max","homepage":"","size":1903,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"75fdf28826cb2dd29fd27a1887523856d2886787","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":45906123,"name":"appleseed-max","full_name":"appleseedhq/appleseed-max","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed-max","description":"appleseed plugin for Autodesk® 3ds Max®","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed-max","forks_url":"https://api.github.com/repos/appleseedhq/appleseed-max/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed-max/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed-max/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed-max/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed-max/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed-max/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed-max/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed-max/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed-max/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed-max/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed-max/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed-max/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed-max/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed-max/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed-max/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed-max/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed-max/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed-max/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed-max/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed-max/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed-max/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed-max/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed-max/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/deployments","created_at":"2015-11-10T10:57:32Z","updated_at":"2017-12-20T20:39:07Z","pushed_at":"2017-12-26T05:08:19Z","git_url":"git://github.com/appleseedhq/appleseed-max.git","ssh_url":"[email protected]:appleseedhq/appleseed-max.git","clone_url":"https://github.com/appleseedhq/appleseed-max.git","svn_url":"https://github.com/appleseedhq/appleseed-max","homepage":"http://appleseedhq.net/","size":1664,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":32,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/113"},"html":{"href":"https://github.com/appleseedhq/appleseed-max/pull/113"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/113"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/ba4523025fe8566367a4275f4b7c437f1ca4f659"}},"author_association":"CONTRIBUTOR"}} | {
"id": 45906123,
"name": "appleseedhq/appleseed-max",
"url": "https://api.github.com/repos/appleseedhq/appleseed-max"
} | {
"id": 321290,
"login": "dictoon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/321290?",
"url": "https://api.github.com/users/dictoon"
} | {
"id": 6373510,
"login": "appleseedhq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6373510?",
"url": "https://api.github.com/orgs/appleseedhq"
} | 2017-12-26T10:40:03 | 7030576028 | {"actor":{"display_login":"dictoon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/comments/146010283","pull_request_review_id":70898360,"id":146010283,"diff_hunk":"@@ -8,3 +8,66 @@\n \n @return $string;\n }\n+\n+// https://stackoverflow.com/questions/32376461/how-to-split-a-string-into-two-lists-of-numbers-in-sass\n+@function str-split($string, $separator) {\n+\n+ $index : str-index($string, $separator);\n+\n+ $str-1 : str-slice($string, 1, $index - 1);\n+ $str-2 : str-slice($string, $index + 1);\n+\n+ @return $str-1 $str-2;\n+}\n+\n+// https://www.sassmeister.com/gist/9fa19d254864f33d4a80\n+@function to-number($value) {\n+ @if type-of($value) == 'number' {\n+ @return $value;\n+ } @else if type-of($value) != 'string' {\n+ $_: log('Value for `to-number` should be a number or a string.');\n+ }\n+\n+ $result: 0;\n+ $digits: 0;\n+ $minus: str-slice($value, 1, 1) == '-';\n+ $numbers: ('0': 0, '1': 1, '2': 2, '3': 3, '4': 4, '5': 5, '6': 6, '7': 7, '8': 8, '9': 9);\n+\n+ @for $i from if($minus, 2, 1) through str-length($value) {\n+ $character: str-slice($value, $i, $i);\n+\n+ @if not (index(map-keys($numbers), $character) or $character == '.') {\n+ @return to-length(if($minus, -$result, $result), str-slice($value, $i))\n+ }\n+\n+ @if $character == '.' {\n+ $digits: 1;\n+ } @else if $digits == 0 {\n+ $result: $result * 10 + map-get($numbers, $character);\n+ } @else {\n+ $digits: $digits * 10;\n+ $result: $result + map-get($numbers, $character) / $digits;\n+ }\n+ }\n+\n+ @return if($minus, -$result, $result);;\n+}\n+\n+\n+///\n+/// Add `$unit` to `$value`\n+///\n+/// @param {Number} $value - Value to add unit to\n+/// @param {String} $unit - String representation of the unit\n+///\n+/// @return {Number} - `$value` expressed in `$unit`\n+///\n+@function to-length($value, $unit) {\n+ $units: ('px': 1px, 'cm': 1cm, 'mm': 1mm, '%': 1%, 'ch': 1ch, 'pc': 1pc, 'in': 1in, 'em': 1em, 'rem': 1rem, 'pt': 1pt, 'ex': 1ex, 'vw': 1vw, 'vh': 1vh, 'vmin': 1vmin, 'vmax': 1vmax);\n+ \n+ @if not index(map-keys($units), $unit) {\n+ $_: log('Invalid unit `#{$unit}`.');\n+ }\n+\n+ @return $value * map-get($units, $unit);\n+}","path":"assets/scss/tools/_string.scss","position":66,"original_position":66,"commit_id":"6fdb08f64ab839966481b86855214e6df1fda777","original_commit_id":"6fdb08f64ab839966481b86855214e6df1fda777","user":{"login":"junedkazi","id":319659,"avatar_url":"https://avatars0.githubusercontent.com/u/319659?v=4","gravatar_id":"","url":"https://api.github.com/users/junedkazi","html_url":"https://github.com/junedkazi","followers_url":"https://api.github.com/users/junedkazi/followers","following_url":"https://api.github.com/users/junedkazi/following{/other_user}","gists_url":"https://api.github.com/users/junedkazi/gists{/gist_id}","starred_url":"https://api.github.com/users/junedkazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junedkazi/subscriptions","organizations_url":"https://api.github.com/users/junedkazi/orgs","repos_url":"https://api.github.com/users/junedkazi/repos","events_url":"https://api.github.com/users/junedkazi/events{/privacy}","received_events_url":"https://api.github.com/users/junedkazi/received_events","type":"User","site_admin":false},"body":"EOL is missing","created_at":"2017-10-20T16:33:22Z","updated_at":"2017-10-20T16:33:23Z","html_url":"https://github.com/bigcommerce/cornerstone/pull/1104#discussion_r146010283","pull_request_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1104","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/comments/146010283"},"html":{"href":"https://github.com/bigcommerce/cornerstone/pull/1104#discussion_r146010283"},"pull_request":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1104"}}},"pull_request":{"url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1104","id":147099630,"html_url":"https://github.com/bigcommerce/cornerstone/pull/1104","diff_url":"https://github.com/bigcommerce/cornerstone/pull/1104.diff","patch_url":"https://github.com/bigcommerce/cornerstone/pull/1104.patch","issue_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues/1104","number":1104,"state":"open","locked":false,"title":"STENCIL-3891 Lazy load images, save space for images while loading","user":{"login":"BC-EChristensen","id":32500994,"avatar_url":"https://avatars2.githubusercontent.com/u/32500994?v=4","gravatar_id":"","url":"https://api.github.com/users/BC-EChristensen","html_url":"https://github.com/BC-EChristensen","followers_url":"https://api.github.com/users/BC-EChristensen/followers","following_url":"https://api.github.com/users/BC-EChristensen/following{/other_user}","gists_url":"https://api.github.com/users/BC-EChristensen/gists{/gist_id}","starred_url":"https://api.github.com/users/BC-EChristensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BC-EChristensen/subscriptions","organizations_url":"https://api.github.com/users/BC-EChristensen/orgs","repos_url":"https://api.github.com/users/BC-EChristensen/repos","events_url":"https://api.github.com/users/BC-EChristensen/events{/privacy}","received_events_url":"https://api.github.com/users/BC-EChristensen/received_events","type":"User","site_admin":false},"body":"#### What?\r\n\r\nLazy load all site images, and save space for images while they are loading.\r\n\r\n#### Tickets / Documentation\r\n\r\n- [STENCIL-3891](https://jira.bigcommerce.com/browse/STENCIL-3891)\r\n- [STENCIL-3109](https://jira.bigcommerce.com/browse/STENCIL-3109)\r\n","created_at":"2017-10-17T17:04:47Z","updated_at":"2017-10-20T16:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fe8af1af55d5731668948ff596014ee6ee36981","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1104/commits","review_comments_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1104/comments","review_comment_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues/1104/comments","statuses_url":"https://api.github.com/repos/bigcommerce/cornerstone/statuses/6fdb08f64ab839966481b86855214e6df1fda777","head":{"label":"BC-EChristensen:STENCIL-3891","ref":"STENCIL-3891","sha":"6fdb08f64ab839966481b86855214e6df1fda777","user":{"login":"BC-EChristensen","id":32500994,"avatar_url":"https://avatars2.githubusercontent.com/u/32500994?v=4","gravatar_id":"","url":"https://api.github.com/users/BC-EChristensen","html_url":"https://github.com/BC-EChristensen","followers_url":"https://api.github.com/users/BC-EChristensen/followers","following_url":"https://api.github.com/users/BC-EChristensen/following{/other_user}","gists_url":"https://api.github.com/users/BC-EChristensen/gists{/gist_id}","starred_url":"https://api.github.com/users/BC-EChristensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BC-EChristensen/subscriptions","organizations_url":"https://api.github.com/users/BC-EChristensen/orgs","repos_url":"https://api.github.com/users/BC-EChristensen/repos","events_url":"https://api.github.com/users/BC-EChristensen/events{/privacy}","received_events_url":"https://api.github.com/users/BC-EChristensen/received_events","type":"User","site_admin":false},"repo":{"id":106035565,"name":"cornerstone","full_name":"BC-EChristensen/cornerstone","owner":{"login":"BC-EChristensen","id":32500994,"avatar_url":"https://avatars2.githubusercontent.com/u/32500994?v=4","gravatar_id":"","url":"https://api.github.com/users/BC-EChristensen","html_url":"https://github.com/BC-EChristensen","followers_url":"https://api.github.com/users/BC-EChristensen/followers","following_url":"https://api.github.com/users/BC-EChristensen/following{/other_user}","gists_url":"https://api.github.com/users/BC-EChristensen/gists{/gist_id}","starred_url":"https://api.github.com/users/BC-EChristensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BC-EChristensen/subscriptions","organizations_url":"https://api.github.com/users/BC-EChristensen/orgs","repos_url":"https://api.github.com/users/BC-EChristensen/repos","events_url":"https://api.github.com/users/BC-EChristensen/events{/privacy}","received_events_url":"https://api.github.com/users/BC-EChristensen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BC-EChristensen/cornerstone","description":"The BigCommerce Cornerstone theme","fork":true,"url":"https://api.github.com/repos/BC-EChristensen/cornerstone","forks_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/forks","keys_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/teams","hooks_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/hooks","issue_events_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/issues/events{/number}","events_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/events","assignees_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/assignees{/user}","branches_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/branches{/branch}","tags_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/tags","blobs_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/statuses/{sha}","languages_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/languages","stargazers_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/stargazers","contributors_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/contributors","subscribers_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/subscribers","subscription_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/subscription","commits_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/contents/{+path}","compare_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/merges","archive_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/downloads","issues_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/issues{/number}","pulls_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/pulls{/number}","milestones_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/milestones{/number}","notifications_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/labels{/name}","releases_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/releases{/id}","deployments_url":"https://api.github.com/repos/BC-EChristensen/cornerstone/deployments","created_at":"2017-10-06T18:07:57Z","updated_at":"2017-10-06T18:07:59Z","pushed_at":"2017-10-19T18:46:57Z","git_url":"git://github.com/BC-EChristensen/cornerstone.git","ssh_url":"[email protected]:BC-EChristensen/cornerstone.git","clone_url":"https://github.com/BC-EChristensen/cornerstone.git","svn_url":"https://github.com/BC-EChristensen/cornerstone","homepage":"https://stencil.bigcommerce.com/docs","size":34785,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigcommerce:master","ref":"master","sha":"2a60583582a6c4a93737cba41627626bec17da7d","user":{"login":"bigcommerce","id":186342,"avatar_url":"https://avatars1.githubusercontent.com/u/186342?v=4","gravatar_id":"","url":"https://api.github.com/users/bigcommerce","html_url":"https://github.com/bigcommerce","followers_url":"https://api.github.com/users/bigcommerce/followers","following_url":"https://api.github.com/users/bigcommerce/following{/other_user}","gists_url":"https://api.github.com/users/bigcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/bigcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigcommerce/subscriptions","organizations_url":"https://api.github.com/users/bigcommerce/orgs","repos_url":"https://api.github.com/users/bigcommerce/repos","events_url":"https://api.github.com/users/bigcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/bigcommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":34682093,"name":"cornerstone","full_name":"bigcommerce/cornerstone","owner":{"login":"bigcommerce","id":186342,"avatar_url":"https://avatars1.githubusercontent.com/u/186342?v=4","gravatar_id":"","url":"https://api.github.com/users/bigcommerce","html_url":"https://github.com/bigcommerce","followers_url":"https://api.github.com/users/bigcommerce/followers","following_url":"https://api.github.com/users/bigcommerce/following{/other_user}","gists_url":"https://api.github.com/users/bigcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/bigcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigcommerce/subscriptions","organizations_url":"https://api.github.com/users/bigcommerce/orgs","repos_url":"https://api.github.com/users/bigcommerce/repos","events_url":"https://api.github.com/users/bigcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/bigcommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigcommerce/cornerstone","description":"The BigCommerce Cornerstone theme","fork":false,"url":"https://api.github.com/repos/bigcommerce/cornerstone","forks_url":"https://api.github.com/repos/bigcommerce/cornerstone/forks","keys_url":"https://api.github.com/repos/bigcommerce/cornerstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigcommerce/cornerstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigcommerce/cornerstone/teams","hooks_url":"https://api.github.com/repos/bigcommerce/cornerstone/hooks","issue_events_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues/events{/number}","events_url":"https://api.github.com/repos/bigcommerce/cornerstone/events","assignees_url":"https://api.github.com/repos/bigcommerce/cornerstone/assignees{/user}","branches_url":"https://api.github.com/repos/bigcommerce/cornerstone/branches{/branch}","tags_url":"https://api.github.com/repos/bigcommerce/cornerstone/tags","blobs_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigcommerce/cornerstone/statuses/{sha}","languages_url":"https://api.github.com/repos/bigcommerce/cornerstone/languages","stargazers_url":"https://api.github.com/repos/bigcommerce/cornerstone/stargazers","contributors_url":"https://api.github.com/repos/bigcommerce/cornerstone/contributors","subscribers_url":"https://api.github.com/repos/bigcommerce/cornerstone/subscribers","subscription_url":"https://api.github.com/repos/bigcommerce/cornerstone/subscription","commits_url":"https://api.github.com/repos/bigcommerce/cornerstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigcommerce/cornerstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigcommerce/cornerstone/contents/{+path}","compare_url":"https://api.github.com/repos/bigcommerce/cornerstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigcommerce/cornerstone/merges","archive_url":"https://api.github.com/repos/bigcommerce/cornerstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigcommerce/cornerstone/downloads","issues_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues{/number}","pulls_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls{/number}","milestones_url":"https://api.github.com/repos/bigcommerce/cornerstone/milestones{/number}","notifications_url":"https://api.github.com/repos/bigcommerce/cornerstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigcommerce/cornerstone/labels{/name}","releases_url":"https://api.github.com/repos/bigcommerce/cornerstone/releases{/id}","deployments_url":"https://api.github.com/repos/bigcommerce/cornerstone/deployments","created_at":"2015-04-27T17:58:18Z","updated_at":"2017-10-13T21:14:38Z","pushed_at":"2017-10-20T03:54:35Z","git_url":"git://github.com/bigcommerce/cornerstone.git","ssh_url":"[email protected]:bigcommerce/cornerstone.git","clone_url":"https://github.com/bigcommerce/cornerstone.git","svn_url":"https://github.com/bigcommerce/cornerstone","homepage":"https://stencil.bigcommerce.com/docs","size":34777,"stargazers_count":38,"watchers_count":38,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":95,"open_issues":25,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1104"},"html":{"href":"https://github.com/bigcommerce/cornerstone/pull/1104"},"issue":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/issues/1104"},"comments":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/issues/1104/comments"},"review_comments":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1104/comments"},"review_comment":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1104/commits"},"statuses":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/statuses/6fdb08f64ab839966481b86855214e6df1fda777"}},"author_association":"CONTRIBUTOR"}} | {
"id": 34682093,
"name": "bigcommerce/cornerstone",
"url": "https://api.github.com/repos/bigcommerce/cornerstone"
} | {
"id": 319659,
"login": "junedkazi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/319659?",
"url": "https://api.github.com/users/junedkazi"
} | {
"id": 186342,
"login": "bigcommerce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/186342?",
"url": "https://api.github.com/orgs/bigcommerce"
} | 2017-10-20T16:33:22 | 6744683645 | {"actor":{"display_login":"junedkazi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/comments/134904542","pull_request_review_id":58252846,"id":134904542,"diff_hunk":"@@ -1,3 +1,23 @@\n # blob-uploader.js\n \n-Coming soon...\n+This library wraps the blob uploader service [Blob uploader](https://github.com/blinkmobile/blob-uploader) and AWS S3 to allow uploading and retrieval of blobs from S3 without having to work with AWS credentials and the AWS SDK directly.\n+## Usage\n+1. Initialise the blobUploader with the URL of the blob uploader service, e.g. \n+```\n+new blobUploader('https://bm-blob-uploader-dev.api.blinkm.io/')\n+```\n+2. For simple upload via a single HTTP PUT, blobUploader.uploadBlob with the blob to be uploaded. This will return a Promise that will resolve with the id that can be used later to retrieve the blob.\n+```\n+blobUploader.uploadBlob(blob)\n+```\n+OR\n+\n+2. For a managed upload which supports a progress event, cancellation and will adjust to network conditions, call blobUploader.ManagedUpload. This function takes as parameters the blob to be uploaded and a function that will be called with a progress event(OPTIONAL). This will return a Promise that will resolve with an object that includes the id that can be used later to retrieve the blob, a function upload()which returns a promise that will resolve when the upload succeeds or rejects if the upload fails or is stopped, and a function cancel() that will abort the upload. The progress event call will include a progress parameter with properties loaded and total (see [AWS SDK](http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3/ManagedUpload.html#httpUploadProgress-event))\n+```\n+blobUploader.managedUpload(blob, progressFn)\n+```\n+\n+3. To retrieve a URL to the blob in S3, call blobUploader.retrieveBlobUrl. This will return a Promise that will resolve to a URL that can be used with HTTP GET to retrieve the blob.","path":"docs/developer.md","position":21,"original_position":21,"commit_id":"16c4305c44f98c3e7acbe15db42f8285bfa83f02","original_commit_id":"16c4305c44f98c3e7acbe15db42f8285bfa83f02","user":{"login":"mymattcarroll","id":16235788,"avatar_url":"https://avatars2.githubusercontent.com/u/16235788?v=4","gravatar_id":"","url":"https://api.github.com/users/mymattcarroll","html_url":"https://github.com/mymattcarroll","followers_url":"https://api.github.com/users/mymattcarroll/followers","following_url":"https://api.github.com/users/mymattcarroll/following{/other_user}","gists_url":"https://api.github.com/users/mymattcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/mymattcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mymattcarroll/subscriptions","organizations_url":"https://api.github.com/users/mymattcarroll/orgs","repos_url":"https://api.github.com/users/mymattcarroll/repos","events_url":"https://api.github.com/users/mymattcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/mymattcarroll/received_events","type":"User","site_admin":false},"body":"> This will return a Promise that will resolve to a URL that can be used with HTTP GET to retrieve the blob\r\n\r\nIs that correct?","created_at":"2017-08-24T00:44:37Z","updated_at":"2017-08-24T00:44:37Z","html_url":"https://github.com/blinkmobile/blob-uploader.js/pull/2#discussion_r134904542","pull_request_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/comments/134904542"},"html":{"href":"https://github.com/blinkmobile/blob-uploader.js/pull/2#discussion_r134904542"},"pull_request":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/2","id":136389960,"html_url":"https://github.com/blinkmobile/blob-uploader.js/pull/2","diff_url":"https://github.com/blinkmobile/blob-uploader.js/pull/2.diff","patch_url":"https://github.com/blinkmobile/blob-uploader.js/pull/2.patch","issue_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues/2","number":2,"state":"open","locked":false,"title":"Fss 11","user":{"login":"kizaonline","id":11908094,"avatar_url":"https://avatars0.githubusercontent.com/u/11908094?v=4","gravatar_id":"","url":"https://api.github.com/users/kizaonline","html_url":"https://github.com/kizaonline","followers_url":"https://api.github.com/users/kizaonline/followers","following_url":"https://api.github.com/users/kizaonline/following{/other_user}","gists_url":"https://api.github.com/users/kizaonline/gists{/gist_id}","starred_url":"https://api.github.com/users/kizaonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kizaonline/subscriptions","organizations_url":"https://api.github.com/users/kizaonline/orgs","repos_url":"https://api.github.com/users/kizaonline/repos","events_url":"https://api.github.com/users/kizaonline/events{/privacy}","received_events_url":"https://api.github.com/users/kizaonline/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-18T02:22:25Z","updated_at":"2017-08-24T00:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6f17dd0e190abd1490aea233cf68bffa6078c9f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/2/commits","review_comments_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/2/comments","review_comment_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues/2/comments","statuses_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/statuses/16c4305c44f98c3e7acbe15db42f8285bfa83f02","head":{"label":"blinkmobile:FSS-11","ref":"FSS-11","sha":"16c4305c44f98c3e7acbe15db42f8285bfa83f02","user":{"login":"blinkmobile","id":2390706,"avatar_url":"https://avatars0.githubusercontent.com/u/2390706?v=4","gravatar_id":"","url":"https://api.github.com/users/blinkmobile","html_url":"https://github.com/blinkmobile","followers_url":"https://api.github.com/users/blinkmobile/followers","following_url":"https://api.github.com/users/blinkmobile/following{/other_user}","gists_url":"https://api.github.com/users/blinkmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkmobile/subscriptions","organizations_url":"https://api.github.com/users/blinkmobile/orgs","repos_url":"https://api.github.com/users/blinkmobile/repos","events_url":"https://api.github.com/users/blinkmobile/events{/privacy}","received_events_url":"https://api.github.com/users/blinkmobile/received_events","type":"Organization","site_admin":false},"repo":{"id":94496189,"name":"blob-uploader.js","full_name":"blinkmobile/blob-uploader.js","owner":{"login":"blinkmobile","id":2390706,"avatar_url":"https://avatars0.githubusercontent.com/u/2390706?v=4","gravatar_id":"","url":"https://api.github.com/users/blinkmobile","html_url":"https://github.com/blinkmobile","followers_url":"https://api.github.com/users/blinkmobile/followers","following_url":"https://api.github.com/users/blinkmobile/following{/other_user}","gists_url":"https://api.github.com/users/blinkmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkmobile/subscriptions","organizations_url":"https://api.github.com/users/blinkmobile/orgs","repos_url":"https://api.github.com/users/blinkmobile/repos","events_url":"https://api.github.com/users/blinkmobile/events{/privacy}","received_events_url":"https://api.github.com/users/blinkmobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blinkmobile/blob-uploader.js","description":"Javascript wrapper for the blob uploader service","fork":false,"url":"https://api.github.com/repos/blinkmobile/blob-uploader.js","forks_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/forks","keys_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/teams","hooks_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/hooks","issue_events_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues/events{/number}","events_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/events","assignees_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/assignees{/user}","branches_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/branches{/branch}","tags_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/tags","blobs_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/statuses/{sha}","languages_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/languages","stargazers_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/stargazers","contributors_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/contributors","subscribers_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/subscribers","subscription_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/subscription","commits_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/contents/{+path}","compare_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/merges","archive_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/downloads","issues_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues{/number}","pulls_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls{/number}","milestones_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/milestones{/number}","notifications_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/labels{/name}","releases_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/releases{/id}","deployments_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/deployments","created_at":"2017-06-16T02:16:01Z","updated_at":"2017-08-15T04:16:32Z","pushed_at":"2017-08-24T00:22:34Z","git_url":"git://github.com/blinkmobile/blob-uploader.js.git","ssh_url":"[email protected]:blinkmobile/blob-uploader.js.git","clone_url":"https://github.com/blinkmobile/blob-uploader.js.git","svn_url":"https://github.com/blinkmobile/blob-uploader.js","homepage":null,"size":2040,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"blinkmobile:master","ref":"master","sha":"d043830e3a57c81f55c7a89992c46eb01c01a8ec","user":{"login":"blinkmobile","id":2390706,"avatar_url":"https://avatars0.githubusercontent.com/u/2390706?v=4","gravatar_id":"","url":"https://api.github.com/users/blinkmobile","html_url":"https://github.com/blinkmobile","followers_url":"https://api.github.com/users/blinkmobile/followers","following_url":"https://api.github.com/users/blinkmobile/following{/other_user}","gists_url":"https://api.github.com/users/blinkmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkmobile/subscriptions","organizations_url":"https://api.github.com/users/blinkmobile/orgs","repos_url":"https://api.github.com/users/blinkmobile/repos","events_url":"https://api.github.com/users/blinkmobile/events{/privacy}","received_events_url":"https://api.github.com/users/blinkmobile/received_events","type":"Organization","site_admin":false},"repo":{"id":94496189,"name":"blob-uploader.js","full_name":"blinkmobile/blob-uploader.js","owner":{"login":"blinkmobile","id":2390706,"avatar_url":"https://avatars0.githubusercontent.com/u/2390706?v=4","gravatar_id":"","url":"https://api.github.com/users/blinkmobile","html_url":"https://github.com/blinkmobile","followers_url":"https://api.github.com/users/blinkmobile/followers","following_url":"https://api.github.com/users/blinkmobile/following{/other_user}","gists_url":"https://api.github.com/users/blinkmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/blinkmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blinkmobile/subscriptions","organizations_url":"https://api.github.com/users/blinkmobile/orgs","repos_url":"https://api.github.com/users/blinkmobile/repos","events_url":"https://api.github.com/users/blinkmobile/events{/privacy}","received_events_url":"https://api.github.com/users/blinkmobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blinkmobile/blob-uploader.js","description":"Javascript wrapper for the blob uploader service","fork":false,"url":"https://api.github.com/repos/blinkmobile/blob-uploader.js","forks_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/forks","keys_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/teams","hooks_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/hooks","issue_events_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues/events{/number}","events_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/events","assignees_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/assignees{/user}","branches_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/branches{/branch}","tags_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/tags","blobs_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/statuses/{sha}","languages_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/languages","stargazers_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/stargazers","contributors_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/contributors","subscribers_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/subscribers","subscription_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/subscription","commits_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/contents/{+path}","compare_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/merges","archive_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/downloads","issues_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues{/number}","pulls_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls{/number}","milestones_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/milestones{/number}","notifications_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/labels{/name}","releases_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/releases{/id}","deployments_url":"https://api.github.com/repos/blinkmobile/blob-uploader.js/deployments","created_at":"2017-06-16T02:16:01Z","updated_at":"2017-08-15T04:16:32Z","pushed_at":"2017-08-24T00:22:34Z","git_url":"git://github.com/blinkmobile/blob-uploader.js.git","ssh_url":"[email protected]:blinkmobile/blob-uploader.js.git","clone_url":"https://github.com/blinkmobile/blob-uploader.js.git","svn_url":"https://github.com/blinkmobile/blob-uploader.js","homepage":null,"size":2040,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/2"},"html":{"href":"https://github.com/blinkmobile/blob-uploader.js/pull/2"},"issue":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues/2"},"comments":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/blinkmobile/blob-uploader.js/statuses/16c4305c44f98c3e7acbe15db42f8285bfa83f02"}}}} | {
"id": 94496189,
"name": "blinkmobile/blob-uploader.js",
"url": "https://api.github.com/repos/blinkmobile/blob-uploader.js"
} | {
"id": 16235788,
"login": "mymattcarroll",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16235788?",
"url": "https://api.github.com/users/mymattcarroll"
} | {
"id": 2390706,
"login": "blinkmobile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2390706?",
"url": "https://api.github.com/orgs/blinkmobile"
} | 2017-08-24T00:44:37 | 6505137180 | {"actor":{"display_login":"mymattcarroll"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/114767821","pull_request_review_id":36262039,"id":114767821,"diff_hunk":"@@ -3623,7 +3658,10 @@ private inline proc _write_binary_internal(_channel_internal:qio_channel_ptr_t,\n \n // Channel must be locked, must be running on this.home\n // x is ref (vs out) because it might contain a literal string.\n-private inline proc _read_one_internal(_channel_internal:qio_channel_ptr_t, param kind:iokind, ref x:?t):syserr where _isIoPrimitiveTypeOrNewline(t) {\n+private inline proc _read_one_internal(_channel_internal:qio_channel_ptr_t,\n+ param kind:iokind,\n+ ref x:?t,\n+ loc:locale):syserr where _isIoPrimitiveTypeOrNewline(t) {","path":"modules/standard/IO.chpl","position":57,"original_position":57,"commit_id":"e194bbda5b25d7c5d64d52ff482dbd9b346c0503","original_commit_id":"e194bbda5b25d7c5d64d52ff482dbd9b346c0503","user":{"login":"mppf","id":3653132,"avatar_url":"https://avatars0.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"body":"It is intentional. These functions are overloaded - have two implementations, one for built-in types and another for anything else. I needed the loc:locale argument on the \"anything else\" version so changed both overloads.","created_at":"2017-05-04T13:08:17Z","updated_at":"2017-05-04T13:08:17Z","html_url":"https://github.com/chapel-lang/chapel/pull/5989#discussion_r114767821","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/5989","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/114767821"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/5989#discussion_r114767821"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/5989"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/5989","id":115411366,"html_url":"https://github.com/chapel-lang/chapel/pull/5989","diff_url":"https://github.com/chapel-lang/chapel/pull/5989.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/5989.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/5989","number":5989,"state":"open","locked":false,"title":"Enable original locale of I/O operations to be queried","user":{"login":"mppf","id":3653132,"avatar_url":"https://avatars0.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"body":"Adds a new field to `record channel` to store the locale on which the I/O originated. That way, it can be queried for things like Replicated arrays to output in a reasonable manner. This original locale information is passed along to I/O calls within writeThis.\r\n\r\nTesting:\r\n- [x] passed full local testing\r\n- [x] passed full GASNet testing\r\n\r\nReview:\r\n- [ ] address Lydia's feedback\r\n\r\nMerging:\r\n- [ ] merge PR #6168 before this one.","created_at":"2017-04-11T20:48:17Z","updated_at":"2017-05-04T13:08:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"080f8f249fba320c2f715783e87e4913eb09fc7c","assignee":{"login":"lydia-duncan","id":2454710,"avatar_url":"https://avatars1.githubusercontent.com/u/2454710?v=3","gravatar_id":"","url":"https://api.github.com/users/lydia-duncan","html_url":"https://github.com/lydia-duncan","followers_url":"https://api.github.com/users/lydia-duncan/followers","following_url":"https://api.github.com/users/lydia-duncan/following{/other_user}","gists_url":"https://api.github.com/users/lydia-duncan/gists{/gist_id}","starred_url":"https://api.github.com/users/lydia-duncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lydia-duncan/subscriptions","organizations_url":"https://api.github.com/users/lydia-duncan/orgs","repos_url":"https://api.github.com/users/lydia-duncan/repos","events_url":"https://api.github.com/users/lydia-duncan/events{/privacy}","received_events_url":"https://api.github.com/users/lydia-duncan/received_events","type":"User","site_admin":false},"assignees":[{"login":"lydia-duncan","id":2454710,"avatar_url":"https://avatars1.githubusercontent.com/u/2454710?v=3","gravatar_id":"","url":"https://api.github.com/users/lydia-duncan","html_url":"https://github.com/lydia-duncan","followers_url":"https://api.github.com/users/lydia-duncan/followers","following_url":"https://api.github.com/users/lydia-duncan/following{/other_user}","gists_url":"https://api.github.com/users/lydia-duncan/gists{/gist_id}","starred_url":"https://api.github.com/users/lydia-duncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lydia-duncan/subscriptions","organizations_url":"https://api.github.com/users/lydia-duncan/orgs","repos_url":"https://api.github.com/users/lydia-duncan/repos","events_url":"https://api.github.com/users/lydia-duncan/events{/privacy}","received_events_url":"https://api.github.com/users/lydia-duncan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/5989/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/5989/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/5989/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/e194bbda5b25d7c5d64d52ff482dbd9b346c0503","head":{"label":"mppf:writethis-locale","ref":"writethis-locale","sha":"e194bbda5b25d7c5d64d52ff482dbd9b346c0503","user":{"login":"mppf","id":3653132,"avatar_url":"https://avatars0.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"repo":{"id":22106313,"name":"chapel","full_name":"mppf/chapel","owner":{"login":"mppf","id":3653132,"avatar_url":"https://avatars0.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mppf/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/mppf/chapel","forks_url":"https://api.github.com/repos/mppf/chapel/forks","keys_url":"https://api.github.com/repos/mppf/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mppf/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mppf/chapel/teams","hooks_url":"https://api.github.com/repos/mppf/chapel/hooks","issue_events_url":"https://api.github.com/repos/mppf/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/mppf/chapel/events","assignees_url":"https://api.github.com/repos/mppf/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/mppf/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/mppf/chapel/tags","blobs_url":"https://api.github.com/repos/mppf/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mppf/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mppf/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mppf/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mppf/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/mppf/chapel/languages","stargazers_url":"https://api.github.com/repos/mppf/chapel/stargazers","contributors_url":"https://api.github.com/repos/mppf/chapel/contributors","subscribers_url":"https://api.github.com/repos/mppf/chapel/subscribers","subscription_url":"https://api.github.com/repos/mppf/chapel/subscription","commits_url":"https://api.github.com/repos/mppf/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mppf/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mppf/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mppf/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/mppf/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/mppf/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mppf/chapel/merges","archive_url":"https://api.github.com/repos/mppf/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mppf/chapel/downloads","issues_url":"https://api.github.com/repos/mppf/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/mppf/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/mppf/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/mppf/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mppf/chapel/labels{/name}","releases_url":"https://api.github.com/repos/mppf/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/mppf/chapel/deployments","created_at":"2014-07-22T14:05:45Z","updated_at":"2016-01-11T15:01:10Z","pushed_at":"2017-05-04T03:10:07Z","git_url":"git://github.com/mppf/chapel.git","ssh_url":"[email protected]:mppf/chapel.git","clone_url":"https://github.com/mppf/chapel.git","svn_url":"https://github.com/mppf/chapel","homepage":"http://chapel.cray.com/","size":406674,"stargazers_count":1,"watchers_count":1,"language":"Chapel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"9adb20e4c36758abb93f63e1910335f571bf9ee0","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars1.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars1.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2017-05-04T06:56:51Z","pushed_at":"2017-05-04T03:10:08Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"[email protected]:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":412112,"stargazers_count":434,"watchers_count":434,"language":"Chapel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":278,"forks":141,"open_issues":278,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/5989"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/5989"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/5989"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/5989/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/5989/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/5989/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/e194bbda5b25d7c5d64d52ff482dbd9b346c0503"}}}} | {
"id": 21663285,
"name": "chapel-lang/chapel",
"url": "https://api.github.com/repos/chapel-lang/chapel"
} | {
"id": 3653132,
"login": "mppf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3653132?",
"url": "https://api.github.com/users/mppf"
} | {
"id": 7597261,
"login": "chapel-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7597261?",
"url": "https://api.github.com/orgs/chapel-lang"
} | 2017-05-04T13:08:17 | 5809312826 | {"actor":{"display_login":"mppf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/comments/117451554","pull_request_review_id":39161616,"id":117451554,"diff_hunk":"@@ -0,0 +1,33 @@\n+.frost-guage {\n+ position: relative;\n+\n+ &-text {","path":"addon/styles/_frost-guage.scss","position":null,"original_position":4,"commit_id":"d5b2007afc54da34e2d8819ca87265b3f485bb0e","original_commit_id":"153a043f294ad98d32f23a8e01bb04862593d145","user":{"login":"job13er","id":411788,"avatar_url":"https://avatars1.githubusercontent.com/u/411788?v=3","gravatar_id":"","url":"https://api.github.com/users/job13er","html_url":"https://github.com/job13er","followers_url":"https://api.github.com/users/job13er/followers","following_url":"https://api.github.com/users/job13er/following{/other_user}","gists_url":"https://api.github.com/users/job13er/gists{/gist_id}","starred_url":"https://api.github.com/users/job13er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job13er/subscriptions","organizations_url":"https://api.github.com/users/job13er/orgs","repos_url":"https://api.github.com/users/job13er/repos","events_url":"https://api.github.com/users/job13er/events{/privacy}","received_events_url":"https://api.github.com/users/job13er/received_events","type":"User","site_admin":false},"body":"I also thought that `.frost-gauge-selected` would be preferrable over `.frost-gauge.selected`, wouldn't it, since `selected` is pretty generic, and would be easy for someone to style it w/o scoping it first on accident. ","created_at":"2017-05-19T10:29:29Z","updated_at":"2017-05-19T10:29:29Z","html_url":"https://github.com/ciena-frost/ember-frost-chart/pull/14#discussion_r117451554","pull_request_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/comments/117451554"},"html":{"href":"https://github.com/ciena-frost/ember-frost-chart/pull/14#discussion_r117451554"},"pull_request":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/14","id":120687896,"html_url":"https://github.com/ciena-frost/ember-frost-chart/pull/14","diff_url":"https://github.com/ciena-frost/ember-frost-chart/pull/14.diff","patch_url":"https://github.com/ciena-frost/ember-frost-chart/pull/14.patch","issue_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/14","number":14,"state":"closed","locked":false,"title":"Added Guage","user":{"login":"helrac","id":26879720,"avatar_url":"https://avatars0.githubusercontent.com/u/26879720?v=3","gravatar_id":"","url":"https://api.github.com/users/helrac","html_url":"https://github.com/helrac","followers_url":"https://api.github.com/users/helrac/followers","following_url":"https://api.github.com/users/helrac/following{/other_user}","gists_url":"https://api.github.com/users/helrac/gists{/gist_id}","starred_url":"https://api.github.com/users/helrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helrac/subscriptions","organizations_url":"https://api.github.com/users/helrac/orgs","repos_url":"https://api.github.com/users/helrac/repos","events_url":"https://api.github.com/users/helrac/events{/privacy}","received_events_url":"https://api.github.com/users/helrac/received_events","type":"User","site_admin":false},"body":"### This project uses [semver](semver.org), please check the scope of this pr:\r\n\r\n- [ ] #none# - documentation fixes and/or test additions\r\n- [ ] #patch# - backwards-compatible bug fix\r\n- [x] #minor# - adding functionality in a backwards-compatible manner\r\n- [ ] #major# - incompatible API change\r\n\r\n# CHANGELOG\r\nAdded guage\r\n","created_at":"2017-05-15T20:31:38Z","updated_at":"2017-05-19T10:29:29Z","closed_at":"2017-05-18T14:50:41Z","merged_at":"2017-05-18T14:50:41Z","merge_commit_sha":"50a85d83abe7c8a4759ee29affbfe271a035d32f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/14/commits","review_comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/14/comments","review_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/14/comments","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/statuses/d5b2007afc54da34e2d8819ca87265b3f485bb0e","head":{"label":"helrac:master","ref":"master","sha":"d5b2007afc54da34e2d8819ca87265b3f485bb0e","user":{"login":"helrac","id":26879720,"avatar_url":"https://avatars0.githubusercontent.com/u/26879720?v=3","gravatar_id":"","url":"https://api.github.com/users/helrac","html_url":"https://github.com/helrac","followers_url":"https://api.github.com/users/helrac/followers","following_url":"https://api.github.com/users/helrac/following{/other_user}","gists_url":"https://api.github.com/users/helrac/gists{/gist_id}","starred_url":"https://api.github.com/users/helrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helrac/subscriptions","organizations_url":"https://api.github.com/users/helrac/orgs","repos_url":"https://api.github.com/users/helrac/repos","events_url":"https://api.github.com/users/helrac/events{/privacy}","received_events_url":"https://api.github.com/users/helrac/received_events","type":"User","site_admin":false},"repo":{"id":90384675,"name":"ember-frost-chart","full_name":"helrac/ember-frost-chart","owner":{"login":"helrac","id":26879720,"avatar_url":"https://avatars0.githubusercontent.com/u/26879720?v=3","gravatar_id":"","url":"https://api.github.com/users/helrac","html_url":"https://github.com/helrac","followers_url":"https://api.github.com/users/helrac/followers","following_url":"https://api.github.com/users/helrac/following{/other_user}","gists_url":"https://api.github.com/users/helrac/gists{/gist_id}","starred_url":"https://api.github.com/users/helrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helrac/subscriptions","organizations_url":"https://api.github.com/users/helrac/orgs","repos_url":"https://api.github.com/users/helrac/repos","events_url":"https://api.github.com/users/helrac/events{/privacy}","received_events_url":"https://api.github.com/users/helrac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helrac/ember-frost-chart","description":"Composable charts with decoupled axes / plots and some extra pizzazz","fork":true,"url":"https://api.github.com/repos/helrac/ember-frost-chart","forks_url":"https://api.github.com/repos/helrac/ember-frost-chart/forks","keys_url":"https://api.github.com/repos/helrac/ember-frost-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helrac/ember-frost-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helrac/ember-frost-chart/teams","hooks_url":"https://api.github.com/repos/helrac/ember-frost-chart/hooks","issue_events_url":"https://api.github.com/repos/helrac/ember-frost-chart/issues/events{/number}","events_url":"https://api.github.com/repos/helrac/ember-frost-chart/events","assignees_url":"https://api.github.com/repos/helrac/ember-frost-chart/assignees{/user}","branches_url":"https://api.github.com/repos/helrac/ember-frost-chart/branches{/branch}","tags_url":"https://api.github.com/repos/helrac/ember-frost-chart/tags","blobs_url":"https://api.github.com/repos/helrac/ember-frost-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helrac/ember-frost-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helrac/ember-frost-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/helrac/ember-frost-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helrac/ember-frost-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/helrac/ember-frost-chart/languages","stargazers_url":"https://api.github.com/repos/helrac/ember-frost-chart/stargazers","contributors_url":"https://api.github.com/repos/helrac/ember-frost-chart/contributors","subscribers_url":"https://api.github.com/repos/helrac/ember-frost-chart/subscribers","subscription_url":"https://api.github.com/repos/helrac/ember-frost-chart/subscription","commits_url":"https://api.github.com/repos/helrac/ember-frost-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/helrac/ember-frost-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/helrac/ember-frost-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/helrac/ember-frost-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/helrac/ember-frost-chart/contents/{+path}","compare_url":"https://api.github.com/repos/helrac/ember-frost-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helrac/ember-frost-chart/merges","archive_url":"https://api.github.com/repos/helrac/ember-frost-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helrac/ember-frost-chart/downloads","issues_url":"https://api.github.com/repos/helrac/ember-frost-chart/issues{/number}","pulls_url":"https://api.github.com/repos/helrac/ember-frost-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/helrac/ember-frost-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/helrac/ember-frost-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helrac/ember-frost-chart/labels{/name}","releases_url":"https://api.github.com/repos/helrac/ember-frost-chart/releases{/id}","deployments_url":"https://api.github.com/repos/helrac/ember-frost-chart/deployments","created_at":"2017-05-05T14:30:49Z","updated_at":"2017-05-05T14:30:50Z","pushed_at":"2017-05-18T20:34:12Z","git_url":"git://github.com/helrac/ember-frost-chart.git","ssh_url":"[email protected]:helrac/ember-frost-chart.git","clone_url":"https://github.com/helrac/ember-frost-chart.git","svn_url":"https://github.com/helrac/ember-frost-chart","homepage":null,"size":132,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciena-frost:master","ref":"master","sha":"78946b24bba16b08f034b58fb7d13c68658b0e16","user":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars1.githubusercontent.com/u/16601148?v=3","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"repo":{"id":86949493,"name":"ember-frost-chart","full_name":"ciena-frost/ember-frost-chart","owner":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars1.githubusercontent.com/u/16601148?v=3","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciena-frost/ember-frost-chart","description":"Composable charts with decoupled axes / plots and some extra pizzazz","fork":false,"url":"https://api.github.com/repos/ciena-frost/ember-frost-chart","forks_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/forks","keys_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/teams","hooks_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/hooks","issue_events_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/events{/number}","events_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/events","assignees_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/assignees{/user}","branches_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/branches{/branch}","tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/tags","blobs_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/languages","stargazers_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/stargazers","contributors_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/contributors","subscribers_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/subscribers","subscription_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/subscription","commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/contents/{+path}","compare_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/merges","archive_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/downloads","issues_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues{/number}","pulls_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/labels{/name}","releases_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/releases{/id}","deployments_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/deployments","created_at":"2017-04-01T23:35:40Z","updated_at":"2017-04-02T02:10:56Z","pushed_at":"2017-05-18T20:49:58Z","git_url":"git://github.com/ciena-frost/ember-frost-chart.git","ssh_url":"[email protected]:ciena-frost/ember-frost-chart.git","clone_url":"https://github.com/ciena-frost/ember-frost-chart.git","svn_url":"https://github.com/ciena-frost/ember-frost-chart","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/14"},"html":{"href":"https://github.com/ciena-frost/ember-frost-chart/pull/14"},"issue":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/14"},"comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/statuses/d5b2007afc54da34e2d8819ca87265b3f485bb0e"}}}} | {
"id": 86949493,
"name": "ciena-frost/ember-frost-chart",
"url": "https://api.github.com/repos/ciena-frost/ember-frost-chart"
} | {
"id": 411788,
"login": "job13er",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/411788?",
"url": "https://api.github.com/users/job13er"
} | {
"id": 16601148,
"login": "ciena-frost",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16601148?",
"url": "https://api.github.com/orgs/ciena-frost"
} | 2017-05-19T10:29:29 | 5904686691 | {"actor":{"display_login":"job13er"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/115075333","pull_request_review_id":36593436,"id":115075333,"diff_hunk":"@@ -0,0 +1,351 @@\n+// Copyright 2017 Dolphin Emulator Project\n+// Licensed under GPLv2+\n+// Refer to the license.txt file included.\n+\n+#include <QLabel>\n+#include <QMessageBox>\n+#include <QPixmap>\n+#include <iostream>\n+\n+#include \"Core/ConfigManager.h\"\n+#include \"Core/HW/WiimoteReal/WiimoteReal.h\"\n+#include \"Core/IOS/IOS.h\"\n+#include \"Core/IOS/USB/Bluetooth/BTReal.h\"\n+#include \"DolphinQt2/Settings.h\"\n+\n+#include \"ControllersWindow.h\"\n+\n+const std::unordered_map<SerialInterface::SIDevices, int> ControllersWindow::m_gc_types = {\n+ {SerialInterface::SIDEVICE_NONE, 0}, {SerialInterface::SIDEVICE_GC_CONTROLLER, 1},\n+ {SerialInterface::SIDEVICE_WIIU_ADAPTER, 2}, {SerialInterface::SIDEVICE_GC_STEERING, 3},\n+ {SerialInterface::SIDEVICE_DANCEMAT, 4}, {SerialInterface::SIDEVICE_GC_TARUKONGA, 5},\n+ {SerialInterface::SIDEVICE_GC_GBA, 6}, {SerialInterface::SIDEVICE_GC_KEYBOARD, 7}};\n+\n+const std::unordered_map<int, int> ControllersWindow::m_wiimote_types = {\n+ {WIIMOTE_SRC_NONE, 0}, {WIIMOTE_SRC_EMU, 1}, {WIIMOTE_SRC_REAL, 2}, {WIIMOTE_SRC_HYBRID, 3}};\n+\n+int ControllersWindow::ToGCMenuIndex(const SerialInterface::SIDevices& sidevice)\n+{\n+ return m_gc_types.at(sidevice);\n+}\n+\n+SerialInterface::SIDevices ControllersWindow::FromGCMenuIndex(const int& menudevice)\n+{\n+ for (const auto& kv : m_gc_types)\n+ {\n+ if (kv.second == menudevice)\n+ return kv.first;\n+ }\n+ return SerialInterface::SIDEVICE_NONE;\n+}\n+\n+int ControllersWindow::ToWiimoteMenuIndex(const int& device)\n+{\n+ return m_wiimote_types.at(device);\n+}\n+\n+int ControllersWindow::FromWiimoteMenuIndex(const int& menudevice)\n+{\n+ for (const auto& kv : m_wiimote_types)\n+ {\n+ if (kv.second == menudevice)\n+ return kv.first;\n+ }\n+ return WIIMOTE_SRC_NONE;\n+}\n+\n+ControllersWindow::ControllersWindow(QWidget* parent)\n+ : QDialog(parent),\n+ m_configure_icon(Settings().GetThemeDir().append(QStringLiteral(\"config.png\"))),\n+ m_gamecube_icon(Settings().GetResourcesDir().append(QStringLiteral(\"Platform_Gamecube.png\"))),\n+ m_wii_icon(Settings().GetResourcesDir().append(QStringLiteral(\"Platform_Wii.png\")))\n+{\n+ setWindowTitle(tr(\"Controller Settings\"));\n+\n+ CreateGamecubeLayout();\n+ CreateWiimoteLayout();\n+ CreateAdvancedLayout();\n+ CreateMainLayout();\n+ LoadSettings();\n+ ConnectWidgets();\n+}\n+\n+void ControllersWindow::CreateGamecubeLayout()\n+{\n+ std::cout << m_gamecube_icon.toStdString() << std::endl;\n+\n+ m_gc_box = new QGroupBox(m_gc_label);\n+ m_gc_layout = new QFormLayout();\n+\n+ m_gc_label = new QLabel();\n+ m_gc_label->setPixmap(QPixmap(m_gamecube_icon));\n+ m_gc_label->setAlignment(Qt::AlignCenter);\n+ m_gc_layout->addRow(m_gc_label);\n+\n+ m_gc_layout->setLabelAlignment(Qt::AlignCenter);\n+\n+ for (int i = 0; i < 4; i++)\n+ {\n+ auto* gc_box = m_gc_controller_boxes[i] = new QComboBox();\n+ auto* gc_button = m_gc_buttons[i] = new QPushButton(QIcon(m_configure_icon), QString());\n+ auto* gc_group = m_gc_groups[i] = new QHBoxLayout();\n+\n+ for (const auto& item :\n+ {tr(\"None\"), tr(\"Standard Controller\"), tr(\"GameCube Adapter for Wii U\"),\n+ tr(\"Steering Wheel\"), tr(\"Dance Mat\"), tr(\"DK Bongos\"), tr(\"GBA\"), tr(\"Keyboard\")})\n+ gc_box->addItem(item);\n+\n+ gc_group->addWidget(gc_box);\n+ gc_group->addWidget(gc_button);\n+\n+ m_gc_layout->addRow(tr(\"Controller %1\").arg(i + 1), gc_group);\n+ }\n+ m_gc_box->setLayout(m_gc_layout);\n+}\n+\n+void ControllersWindow::CreateWiimoteLayout()\n+{\n+ m_wiimote_box = new QGroupBox();\n+ m_wiimote_layout = new QFormLayout();\n+ m_wiimote_passthrough = new QRadioButton(tr(\"Use Bluetooth Passthrough\"));\n+ m_wiimote_sync = new QPushButton(tr(\"Sync\"));\n+ m_wiimote_reset = new QPushButton(tr(\"Reset\"));\n+ m_wiimote_emu = new QRadioButton(tr(\"Emulate the Wii Bluetooth Adapter\"));\n+\n+ m_wiimote_continous_scanning = new QCheckBox(tr(\"Continous Scanning\"));\n+ m_wiimote_real_balance_board = new QCheckBox(tr(\"Real Balance Board\"));\n+ m_wiimote_speaker_data = new QCheckBox(tr(\"Enable Speaker Data\"));\n+\n+ m_wiimote_layout->setLabelAlignment(Qt::AlignLeft);\n+ m_wiimote_layout->setFormAlignment(Qt::AlignRight);\n+\n+ m_wii_label = new QLabel();\n+ m_wii_label->setPixmap(QPixmap(m_wii_icon));\n+ m_wii_label->setAlignment(Qt::AlignCenter);\n+ m_wiimote_layout->addRow(m_wii_label);\n+\n+ // Passthrough BT\n+ m_wiimote_layout->addRow(m_wiimote_passthrough);\n+\n+ m_wiimote_layout->addRow(tr(\"Sync real Wii Remotes and pair them\"), m_wiimote_sync);\n+ m_wiimote_layout->addRow(tr(\"Reset all saved Wii Remote pairings\"), m_wiimote_reset);\n+\n+ // Emulated BT\n+ m_wiimote_layout->addRow(m_wiimote_emu);\n+\n+ for (int i = 0; i < 4; i++)\n+ {\n+ auto* wm_box = m_wiimote_boxes[i] = new QComboBox();\n+ auto* wm_button = m_wiimote_buttons[i] = new QPushButton(QIcon(m_configure_icon), QString());\n+ auto* wm_group = m_wiimote_groups[i] = new QHBoxLayout();\n+\n+ for (const auto& item :\n+ {tr(\"None\"), tr(\"Emulated Wii Remote\"), tr(\"Real Wii Remote\"), tr(\"Hybrid Wii Remote\")})\n+ wm_box->addItem(item);\n+\n+ wm_group->addWidget(wm_box);\n+ wm_group->addWidget(wm_button);\n+\n+ m_wiimote_layout->addRow(tr(\"Wii Remote %1\").arg(i + 1), wm_group);\n+ }\n+\n+ m_wiimote_layout->addRow(m_wiimote_continous_scanning);\n+ m_wiimote_layout->addRow(m_wiimote_real_balance_board);\n+ m_wiimote_layout->addRow(m_wiimote_speaker_data);\n+\n+ m_wiimote_box->setLayout(m_wiimote_layout);\n+}\n+\n+void ControllersWindow::CreateAdvancedLayout()\n+{\n+ m_advanced_box = new QGroupBox(tr(\"Advanced\"));\n+ m_advanced_layout = new QHBoxLayout();\n+ m_advanced_bg_input = new QCheckBox(tr(\"Background Input\"));\n+\n+ m_advanced_layout->addWidget(m_advanced_bg_input);\n+\n+ m_advanced_box->setLayout(m_advanced_layout);\n+}\n+\n+void ControllersWindow::CreateMainLayout()\n+{\n+ m_main_layout = new QVBoxLayout();\n+ m_main_hbox = new QHBoxLayout();\n+\n+ m_main_hbox->addWidget(m_gc_box);\n+ m_main_hbox->addWidget(m_wiimote_box);\n+\n+ m_main_layout->addItem(m_main_hbox);\n+ m_main_layout->addWidget(m_advanced_box);\n+\n+ setLayout(m_main_layout);\n+}\n+\n+void ControllersWindow::ConnectWidgets()\n+{\n+ connect(m_wiimote_passthrough, SIGNAL(toggled(bool)), this, SLOT(OnWiimoteModeChanged(bool)));\n+\n+ connect(m_advanced_bg_input, SIGNAL(toggled(bool)), this, SLOT(SaveSettings()));\n+ connect(m_wiimote_continous_scanning, SIGNAL(toggled(bool)), SLOT(SaveSettings()));\n+ connect(m_wiimote_real_balance_board, SIGNAL(toggled(bool)), SLOT(SaveSettings()));\n+ connect(m_wiimote_speaker_data, SIGNAL(toggled(bool)), SLOT(SaveSettings()));\n+ connect(m_wiimote_sync, SIGNAL(clicked()), SLOT(OnBluetoothPassthroughSyncPressed()));\n+ connect(m_wiimote_reset, SIGNAL(clicked()), SLOT(OnBluetoothPassthroughResetPressed()));\n+\n+ for (int i = 0; i < 4; i++)\n+ {\n+ connect(m_wiimote_boxes[i], SIGNAL(currentIndexChanged(int)), SLOT(SaveSettings()));\n+ connect(m_wiimote_boxes[i], SIGNAL(currentIndexChanged(int)), SLOT(OnWiimoteTypeChanged(int)));\n+ connect(m_wiimote_buttons[i], SIGNAL(clicked()), SLOT(UnimplementedButton()));\n+ connect(m_gc_controller_boxes[i], SIGNAL(currentIndexChanged(int)), SLOT(SaveSettings()));\n+ connect(m_gc_controller_boxes[i], SIGNAL(currentIndexChanged(int)), SLOT(OnGCTypeChanged(int)));\n+ connect(m_gc_buttons[i], SIGNAL(clicked()), SLOT(UnimplementedButton()));\n+ }\n+}\n+\n+void ControllersWindow::OnWiimoteModeChanged(bool passthrough)\n+{\n+ m_wiimote_sync->setEnabled(passthrough);\n+ m_wiimote_reset->setEnabled(passthrough);\n+\n+ for (int i = 0; i < 4; i++)\n+ {\n+ m_wiimote_boxes[i]->setEnabled(!passthrough);\n+ m_wiimote_buttons[i]->setEnabled(!passthrough);\n+ }\n+\n+ m_wiimote_real_balance_board->setEnabled(!passthrough);\n+ m_wiimote_speaker_data->setEnabled(!passthrough);\n+ m_wiimote_continous_scanning->setEnabled(!passthrough);\n+\n+ SaveSettings();\n+}\n+\n+void ControllersWindow::OnWiimoteTypeChanged(int type)\n+{\n+ auto* box = static_cast<QComboBox*>(QObject::sender());\n+\n+ for (int i = 0; i < 4; i++)\n+ {\n+ if (m_gc_controller_boxes[i] == box)\n+ {\n+ m_wiimote_buttons[i]->setEnabled(box->currentIndex() != 0);\n+ return;\n+ }\n+ }\n+}\n+\n+void ControllersWindow::OnGCTypeChanged(int type)\n+{\n+ auto* box = static_cast<QComboBox*>(QObject::sender());","path":"Source/Core/DolphinQt2/Config/ControllersWindow.cpp","position":240,"original_position":240,"commit_id":"3bd86f3d7b57c2cc48e8e38455a742573166e322","original_commit_id":"ba7393d67d3dcfaa1cf57f81ba8be5ab3395b886","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars2.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"This can be a pointer to const.","created_at":"2017-05-05T19:52:08Z","updated_at":"2017-05-05T19:58:24Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/5377#discussion_r115075333","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5377","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/115075333"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5377#discussion_r115075333"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5377"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5377","id":119236578,"html_url":"https://github.com/dolphin-emu/dolphin/pull/5377","diff_url":"https://github.com/dolphin-emu/dolphin/pull/5377.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/5377.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5377","number":5377,"state":"open","locked":false,"title":"[RFC] [WIP] Qt: Add controller (overview) window","user":{"login":"spycrab","id":1440715,"avatar_url":"https://avatars1.githubusercontent.com/u/1440715?v=3","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"body":"Currently not finished, but I want to get some Feedback before finishing this up.\r\n\r\nTODO List:\r\n- [x] Overview Interface\r\n- [x] Load Settings\r\n- [ ] Save Settings (partial, have to do some UICommon stuff beforehand...)\r\n- [x] Bluetooth Passthrough Sync / Reset Buttons functional\r\n- [x] Fix Windows build\r\n- [ ] Disable certain options while Emulation is running\r\n- [ ] Configuration Windows (For Mapping etc.) (Separate PR?)\r\n\r\n","created_at":"2017-05-05T18:49:55Z","updated_at":"2017-05-05T19:58:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f39c88b91973c8be5b6fd5c6c2571bf16a67c05","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5377/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5377/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5377/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3bd86f3d7b57c2cc48e8e38455a742573166e322","head":{"label":"spycrab:qt_controller","ref":"qt_controller","sha":"3bd86f3d7b57c2cc48e8e38455a742573166e322","user":{"login":"spycrab","id":1440715,"avatar_url":"https://avatars1.githubusercontent.com/u/1440715?v=3","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"repo":{"id":88349585,"name":"dolphin","full_name":"spycrab/dolphin","owner":{"login":"spycrab","id":1440715,"avatar_url":"https://avatars1.githubusercontent.com/u/1440715?v=3","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spycrab/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/spycrab/dolphin","forks_url":"https://api.github.com/repos/spycrab/dolphin/forks","keys_url":"https://api.github.com/repos/spycrab/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spycrab/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spycrab/dolphin/teams","hooks_url":"https://api.github.com/repos/spycrab/dolphin/hooks","issue_events_url":"https://api.github.com/repos/spycrab/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/spycrab/dolphin/events","assignees_url":"https://api.github.com/repos/spycrab/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/spycrab/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/spycrab/dolphin/tags","blobs_url":"https://api.github.com/repos/spycrab/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spycrab/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spycrab/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/spycrab/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spycrab/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/spycrab/dolphin/languages","stargazers_url":"https://api.github.com/repos/spycrab/dolphin/stargazers","contributors_url":"https://api.github.com/repos/spycrab/dolphin/contributors","subscribers_url":"https://api.github.com/repos/spycrab/dolphin/subscribers","subscription_url":"https://api.github.com/repos/spycrab/dolphin/subscription","commits_url":"https://api.github.com/repos/spycrab/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/spycrab/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/spycrab/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/spycrab/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/spycrab/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/spycrab/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spycrab/dolphin/merges","archive_url":"https://api.github.com/repos/spycrab/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spycrab/dolphin/downloads","issues_url":"https://api.github.com/repos/spycrab/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/spycrab/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/spycrab/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/spycrab/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spycrab/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/spycrab/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/spycrab/dolphin/deployments","created_at":"2017-04-15T13:46:17Z","updated_at":"2017-04-15T13:46:43Z","pushed_at":"2017-05-05T19:54:07Z","git_url":"git://github.com/spycrab/dolphin.git","ssh_url":"[email protected]:spycrab/dolphin.git","clone_url":"https://github.com/spycrab/dolphin.git","svn_url":"https://github.com/spycrab/dolphin","homepage":"https://dolphin-emu.org/","size":297547,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"b4aaf806ec24be32a209cd755612af8e4f6adea8","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-05-05T17:30:58Z","pushed_at":"2017-05-05T19:54:09Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"[email protected]:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":335197,"stargazers_count":3286,"watchers_count":3286,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":858,"mirror_url":null,"open_issues_count":151,"forks":858,"open_issues":151,"watchers":3286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5377"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5377"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5377"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5377/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5377/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5377/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3bd86f3d7b57c2cc48e8e38455a742573166e322"}}}} | {
"id": 11577304,
"name": "dolphin-emu/dolphin",
"url": "https://api.github.com/repos/dolphin-emu/dolphin"
} | {
"id": 712067,
"login": "lioncash",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/712067?",
"url": "https://api.github.com/users/lioncash"
} | {
"id": 5050316,
"login": "dolphin-emu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5050316?",
"url": "https://api.github.com/orgs/dolphin-emu"
} | 2017-05-05T19:52:08 | 5819692980 | {"actor":{"display_login":"lioncash"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/106102210","pull_request_review_id":27008180,"id":106102210,"diff_hunk":"@@ -35,9 +35,9 @@ The syntax Elixir provides for type specifications is similar to [the one in Erl\n ## Numbers","path":"lib/elixir/pages/Typespecs.md","position":10,"original_position":10,"commit_id":"edaa415637c4fb296b7645b79b19071518f8f449","original_commit_id":"edaa415637c4fb296b7645b79b19071518f8f449","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars3.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"I believe the examples are enough to clarify it. so let's get rid of all of them. :)","created_at":"2017-03-15T07:50:01Z","updated_at":"2017-03-15T07:50:01Z","html_url":"https://github.com/elixir-lang/elixir/pull/5875#discussion_r106102210","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5875","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/106102210"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/5875#discussion_r106102210"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5875"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5875","id":110540595,"html_url":"https://github.com/elixir-lang/elixir/pull/5875","diff_url":"https://github.com/elixir-lang/elixir/pull/5875.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/5875.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5875","number":5875,"state":"open","locked":false,"title":"Typespecs changes","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars1.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-14T03:18:13Z","updated_at":"2017-03-15T07:50:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0027b5f6f88a0a867f39c29c38fee427bb7cb120","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5875/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5875/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5875/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/edaa415637c4fb296b7645b79b19071518f8f449","head":{"label":"eksperimental:typespecs","ref":"typespecs","sha":"edaa415637c4fb296b7645b79b19071518f8f449","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars1.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"repo":{"id":25033185,"name":"elixir","full_name":"eksperimental/elixir","owner":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars1.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eksperimental/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/eksperimental/elixir","forks_url":"https://api.github.com/repos/eksperimental/elixir/forks","keys_url":"https://api.github.com/repos/eksperimental/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eksperimental/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eksperimental/elixir/teams","hooks_url":"https://api.github.com/repos/eksperimental/elixir/hooks","issue_events_url":"https://api.github.com/repos/eksperimental/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/eksperimental/elixir/events","assignees_url":"https://api.github.com/repos/eksperimental/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/eksperimental/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/eksperimental/elixir/tags","blobs_url":"https://api.github.com/repos/eksperimental/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eksperimental/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eksperimental/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/eksperimental/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eksperimental/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/eksperimental/elixir/languages","stargazers_url":"https://api.github.com/repos/eksperimental/elixir/stargazers","contributors_url":"https://api.github.com/repos/eksperimental/elixir/contributors","subscribers_url":"https://api.github.com/repos/eksperimental/elixir/subscribers","subscription_url":"https://api.github.com/repos/eksperimental/elixir/subscription","commits_url":"https://api.github.com/repos/eksperimental/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/eksperimental/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/eksperimental/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/eksperimental/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/eksperimental/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/eksperimental/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eksperimental/elixir/merges","archive_url":"https://api.github.com/repos/eksperimental/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eksperimental/elixir/downloads","issues_url":"https://api.github.com/repos/eksperimental/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/eksperimental/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/eksperimental/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/eksperimental/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eksperimental/elixir/labels{/name}","releases_url":"https://api.github.com/repos/eksperimental/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/eksperimental/elixir/deployments","created_at":"2014-10-10T11:48:55Z","updated_at":"2017-02-22T17:29:37Z","pushed_at":"2017-03-15T01:49:02Z","git_url":"git://github.com/eksperimental/elixir.git","ssh_url":"[email protected]:eksperimental/elixir.git","clone_url":"https://github.com/eksperimental/elixir.git","svn_url":"https://github.com/eksperimental/elixir","homepage":"http://elixir-lang.org/","size":30646,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"b191f6bf1f767f93c752370a851f45549a8d6b45","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars2.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars2.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/elixir/deployments","created_at":"2011-01-09T08:43:57Z","updated_at":"2017-03-15T07:23:52Z","pushed_at":"2017-03-15T01:49:42Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"[email protected]:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":30836,"stargazers_count":9610,"watchers_count":9610,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1324,"mirror_url":null,"open_issues_count":40,"forks":1324,"open_issues":40,"watchers":9610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5875"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/5875"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/5875"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/5875/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5875/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5875/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/edaa415637c4fb296b7645b79b19071518f8f449"}}}} | {
"id": 1234714,
"name": "elixir-lang/elixir",
"url": "https://api.github.com/repos/elixir-lang/elixir"
} | {
"id": 9582,
"login": "josevalim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9582?",
"url": "https://api.github.com/users/josevalim"
} | {
"id": 1481354,
"login": "elixir-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1481354?",
"url": "https://api.github.com/orgs/elixir-lang"
} | 2017-03-15T07:50:01 | 5496165853 | {"actor":{"display_login":"josevalim"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/comments/147495237","pull_request_review_id":72605069,"id":147495237,"diff_hunk":"@@ -21,198 +21,232 @@ A plugin for the Salesforce CLI to create mobile applications to interface with\n ## Help\n ```\n -> sfdx mobilesdk --help","path":"sfdx/README.md","position":3,"original_position":3,"commit_id":"c19918c58e99108a754fb9a9fcf2e09f7bcde09c","original_commit_id":"c19918c58e99108a754fb9a9fcf2e09f7bcde09c","user":{"login":"wmathurin","id":1012459,"avatar_url":"https://avatars0.githubusercontent.com/u/1012459?v=4","gravatar_id":"","url":"https://api.github.com/users/wmathurin","html_url":"https://github.com/wmathurin","followers_url":"https://api.github.com/users/wmathurin/followers","following_url":"https://api.github.com/users/wmathurin/following{/other_user}","gists_url":"https://api.github.com/users/wmathurin/gists{/gist_id}","starred_url":"https://api.github.com/users/wmathurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmathurin/subscriptions","organizations_url":"https://api.github.com/users/wmathurin/orgs","repos_url":"https://api.github.com/users/wmathurin/repos","events_url":"https://api.github.com/users/wmathurin/events{/privacy}","received_events_url":"https://api.github.com/users/wmathurin/received_events","type":"User","site_admin":false},"body":"This readme is generated using `sfdx/generate_readme.sh`.\r\nIt looks like the help output has changed in the latest version of `sfdx`.","created_at":"2017-10-27T19:16:40Z","updated_at":"2017-10-27T19:16:40Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Package/pull/69#discussion_r147495237","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/69","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/comments/147495237"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-Package/pull/69#discussion_r147495237"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/69","id":149265651,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Package/pull/69","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Package/pull/69.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Package/pull/69.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/issues/69","number":69,"state":"open","locked":false,"title":"Feedback from sfdx doc review","user":{"login":"wmathurin","id":1012459,"avatar_url":"https://avatars0.githubusercontent.com/u/1012459?v=4","gravatar_id":"","url":"https://api.github.com/users/wmathurin","html_url":"https://github.com/wmathurin","followers_url":"https://api.github.com/users/wmathurin/followers","following_url":"https://api.github.com/users/wmathurin/following{/other_user}","gists_url":"https://api.github.com/users/wmathurin/gists{/gist_id}","starred_url":"https://api.github.com/users/wmathurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmathurin/subscriptions","organizations_url":"https://api.github.com/users/wmathurin/orgs","repos_url":"https://api.github.com/users/wmathurin/repos","events_url":"https://api.github.com/users/wmathurin/events{/privacy}","received_events_url":"https://api.github.com/users/wmathurin/received_events","type":"User","site_admin":false},"body":"* createwithtemplate instead of createWithTemplate\r\n* -k for packagename (-p is already used for platform)\r\nNB: forceios/forcedroid will still accept createWithTemplate -- they don't care about the case of the command typed","created_at":"2017-10-27T19:15:38Z","updated_at":"2017-10-27T19:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cfb800a866f9de5479e96cd02d768f41c277d93","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/69/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/69/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/issues/69/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/statuses/c19918c58e99108a754fb9a9fcf2e09f7bcde09c","head":{"label":"wmathurin:dev","ref":"dev","sha":"c19918c58e99108a754fb9a9fcf2e09f7bcde09c","user":{"login":"wmathurin","id":1012459,"avatar_url":"https://avatars0.githubusercontent.com/u/1012459?v=4","gravatar_id":"","url":"https://api.github.com/users/wmathurin","html_url":"https://github.com/wmathurin","followers_url":"https://api.github.com/users/wmathurin/followers","following_url":"https://api.github.com/users/wmathurin/following{/other_user}","gists_url":"https://api.github.com/users/wmathurin/gists{/gist_id}","starred_url":"https://api.github.com/users/wmathurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmathurin/subscriptions","organizations_url":"https://api.github.com/users/wmathurin/orgs","repos_url":"https://api.github.com/users/wmathurin/repos","events_url":"https://api.github.com/users/wmathurin/events{/privacy}","received_events_url":"https://api.github.com/users/wmathurin/received_events","type":"User","site_admin":false},"repo":{"id":72589231,"name":"SalesforceMobileSDK-Package","full_name":"wmathurin/SalesforceMobileSDK-Package","owner":{"login":"wmathurin","id":1012459,"avatar_url":"https://avatars0.githubusercontent.com/u/1012459?v=4","gravatar_id":"","url":"https://api.github.com/users/wmathurin","html_url":"https://github.com/wmathurin","followers_url":"https://api.github.com/users/wmathurin/followers","following_url":"https://api.github.com/users/wmathurin/following{/other_user}","gists_url":"https://api.github.com/users/wmathurin/gists{/gist_id}","starred_url":"https://api.github.com/users/wmathurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmathurin/subscriptions","organizations_url":"https://api.github.com/users/wmathurin/orgs","repos_url":"https://api.github.com/users/wmathurin/repos","events_url":"https://api.github.com/users/wmathurin/events{/privacy}","received_events_url":"https://api.github.com/users/wmathurin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmathurin/SalesforceMobileSDK-Package","description":null,"fork":true,"url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package","forks_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/forks","keys_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/teams","hooks_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/hooks","issue_events_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/issues/events{/number}","events_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/events","assignees_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/assignees{/user}","branches_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/branches{/branch}","tags_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/tags","blobs_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/statuses/{sha}","languages_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/languages","stargazers_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/stargazers","contributors_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/contributors","subscribers_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/subscribers","subscription_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/subscription","commits_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/contents/{+path}","compare_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/merges","archive_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/downloads","issues_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/issues{/number}","pulls_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/pulls{/number}","milestones_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/milestones{/number}","notifications_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/labels{/name}","releases_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/releases{/id}","deployments_url":"https://api.github.com/repos/wmathurin/SalesforceMobileSDK-Package/deployments","created_at":"2016-11-02T00:39:39Z","updated_at":"2016-12-13T00:40:38Z","pushed_at":"2017-10-27T19:15:10Z","git_url":"git://github.com/wmathurin/SalesforceMobileSDK-Package.git","ssh_url":"[email protected]:wmathurin/SalesforceMobileSDK-Package.git","clone_url":"https://github.com/wmathurin/SalesforceMobileSDK-Package.git","svn_url":"https://github.com/wmathurin/SalesforceMobileSDK-Package","homepage":null,"size":182,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forcedotcom:dev","ref":"dev","sha":"4a28c700c8ba3f45e70b063d6f968fd941d736b3","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":72245629,"name":"SalesforceMobileSDK-Package","full_name":"forcedotcom/SalesforceMobileSDK-Package","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Package","description":null,"fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/deployments","created_at":"2016-10-28T21:57:13Z","updated_at":"2017-08-31T07:43:48Z","pushed_at":"2017-10-27T19:15:38Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-Package.git","ssh_url":"[email protected]:forcedotcom/SalesforceMobileSDK-Package.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Package.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Package","homepage":null,"size":195,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/69"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-Package/pull/69"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/issues/69"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package/statuses/c19918c58e99108a754fb9a9fcf2e09f7bcde09c"}},"author_association":"COLLABORATOR"}} | {
"id": 72245629,
"name": "forcedotcom/SalesforceMobileSDK-Package",
"url": "https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Package"
} | {
"id": 1012459,
"login": "wmathurin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1012459?",
"url": "https://api.github.com/users/wmathurin"
} | {
"id": 464563,
"login": "forcedotcom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/464563?",
"url": "https://api.github.com/orgs/forcedotcom"
} | 2017-10-27T19:16:40 | 6776788605 | {"actor":{"display_login":"wmathurin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/146150021","pull_request_review_id":71050599,"id":146150021,"diff_hunk":"@@ -207,8 +207,15 @@ namespace aspect\n double\n Box<dim>::depth(const Point<dim> &position) const\n {\n- // this depth does not take topography into consideration\n- const double d = maximal_depth()-(position(dim-1)-box_origin[dim-1]);\n+ // Get the surface x (,y) point\n+ Point<dim-1> surface_point;\n+ for (unsigned int d=0; d<dim-1; ++d)\n+ surface_point[d] = position[d];\n+\n+ // Get the surface topography at this point\n+ const double topo = topo_model->value(surface_point);\n+\n+ const double d = maximal_depth()-(position(dim-1)-box_origin[dim-1])+topo;","path":"source/geometry_model/box.cc","position":14,"original_position":14,"commit_id":"c96016388b71ca2c58034ae02a8fe181181b91fb","original_commit_id":"c96016388b71ca2c58034ae02a8fe181181b91fb","user":{"login":"anne-glerum","id":7631624,"avatar_url":"https://avatars1.githubusercontent.com/u/7631624?v=4","gravatar_id":"","url":"https://api.github.com/users/anne-glerum","html_url":"https://github.com/anne-glerum","followers_url":"https://api.github.com/users/anne-glerum/followers","following_url":"https://api.github.com/users/anne-glerum/following{/other_user}","gists_url":"https://api.github.com/users/anne-glerum/gists{/gist_id}","starred_url":"https://api.github.com/users/anne-glerum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anne-glerum/subscriptions","organizations_url":"https://api.github.com/users/anne-glerum/orgs","repos_url":"https://api.github.com/users/anne-glerum/repos","events_url":"https://api.github.com/users/anne-glerum/events{/privacy}","received_events_url":"https://api.github.com/users/anne-glerum/received_events","type":"User","site_admin":false},"body":"Are you sure this is correct?` maximal_depth` includes the maximum topography to which you add the local topography as well. Shouldn't it be: \r\n`d = extents[dim-1] + topo - (position(dim-1)-box_origin[dim-1]);`","created_at":"2017-10-23T00:18:26Z","updated_at":"2017-10-23T00:18:26Z","html_url":"https://github.com/geodynamics/aspect/pull/1952#discussion_r146150021","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/1952","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/146150021"},"html":{"href":"https://github.com/geodynamics/aspect/pull/1952#discussion_r146150021"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/1952"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/1952","id":145719821,"html_url":"https://github.com/geodynamics/aspect/pull/1952","diff_url":"https://github.com/geodynamics/aspect/pull/1952.diff","patch_url":"https://github.com/geodynamics/aspect/pull/1952.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/1952","number":1952,"state":"open","locked":false,"title":"Fix depth functions for initial topography","user":{"login":"MFraters","id":7631629,"avatar_url":"https://avatars0.githubusercontent.com/u/7631629?v=4","gravatar_id":"","url":"https://api.github.com/users/MFraters","html_url":"https://github.com/MFraters","followers_url":"https://api.github.com/users/MFraters/followers","following_url":"https://api.github.com/users/MFraters/following{/other_user}","gists_url":"https://api.github.com/users/MFraters/gists{/gist_id}","starred_url":"https://api.github.com/users/MFraters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFraters/subscriptions","organizations_url":"https://api.github.com/users/MFraters/orgs","repos_url":"https://api.github.com/users/MFraters/repos","events_url":"https://api.github.com/users/MFraters/events{/privacy}","received_events_url":"https://api.github.com/users/MFraters/received_events","type":"User","site_admin":false},"body":"This pull request intents to 'fix' the depth functions of the geometry models. Currently the depth functions functions differently, where only the ellipsoidal chunk geometry model has the initial topography model implemented and accounts for this initial topography in the depth function. \r\n\r\nThis pull request adds the adjustment of the depth (and max depth) for the box model. Before I work on others, I would first like to know if this is oke, or that there are reasons for not doing this? \r\n\r\nThe test box_initial_topography_ascii_data will now fail because it uses very large initial topography together with surface pressure normalisation. The surface pressure normalisation uses the depth function together with face information to look if it is near the surface (helper_functions.cc:776). I think the test fails because the cells become too deformed.","created_at":"2017-10-10T15:06:50Z","updated_at":"2017-10-23T00:18:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd26783788c172b5b0a44e97567bb347e1b5a15c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/1952/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/1952/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/1952/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/c96016388b71ca2c58034ae02a8fe181181b91fb","head":{"label":"MFraters:fix_depth_functions_for_initial_topography","ref":"fix_depth_functions_for_initial_topography","sha":"c96016388b71ca2c58034ae02a8fe181181b91fb","user":{"login":"MFraters","id":7631629,"avatar_url":"https://avatars0.githubusercontent.com/u/7631629?v=4","gravatar_id":"","url":"https://api.github.com/users/MFraters","html_url":"https://github.com/MFraters","followers_url":"https://api.github.com/users/MFraters/followers","following_url":"https://api.github.com/users/MFraters/following{/other_user}","gists_url":"https://api.github.com/users/MFraters/gists{/gist_id}","starred_url":"https://api.github.com/users/MFraters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFraters/subscriptions","organizations_url":"https://api.github.com/users/MFraters/orgs","repos_url":"https://api.github.com/users/MFraters/repos","events_url":"https://api.github.com/users/MFraters/events{/privacy}","received_events_url":"https://api.github.com/users/MFraters/received_events","type":"User","site_admin":false},"repo":{"id":19946391,"name":"aspect","full_name":"MFraters/aspect","owner":{"login":"MFraters","id":7631629,"avatar_url":"https://avatars0.githubusercontent.com/u/7631629?v=4","gravatar_id":"","url":"https://api.github.com/users/MFraters","html_url":"https://github.com/MFraters","followers_url":"https://api.github.com/users/MFraters/followers","following_url":"https://api.github.com/users/MFraters/following{/other_user}","gists_url":"https://api.github.com/users/MFraters/gists{/gist_id}","starred_url":"https://api.github.com/users/MFraters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFraters/subscriptions","organizations_url":"https://api.github.com/users/MFraters/orgs","repos_url":"https://api.github.com/users/MFraters/repos","events_url":"https://api.github.com/users/MFraters/events{/privacy}","received_events_url":"https://api.github.com/users/MFraters/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MFraters/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/MFraters/aspect","forks_url":"https://api.github.com/repos/MFraters/aspect/forks","keys_url":"https://api.github.com/repos/MFraters/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MFraters/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MFraters/aspect/teams","hooks_url":"https://api.github.com/repos/MFraters/aspect/hooks","issue_events_url":"https://api.github.com/repos/MFraters/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/MFraters/aspect/events","assignees_url":"https://api.github.com/repos/MFraters/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/MFraters/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/MFraters/aspect/tags","blobs_url":"https://api.github.com/repos/MFraters/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MFraters/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MFraters/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/MFraters/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MFraters/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/MFraters/aspect/languages","stargazers_url":"https://api.github.com/repos/MFraters/aspect/stargazers","contributors_url":"https://api.github.com/repos/MFraters/aspect/contributors","subscribers_url":"https://api.github.com/repos/MFraters/aspect/subscribers","subscription_url":"https://api.github.com/repos/MFraters/aspect/subscription","commits_url":"https://api.github.com/repos/MFraters/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/MFraters/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/MFraters/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/MFraters/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/MFraters/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/MFraters/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MFraters/aspect/merges","archive_url":"https://api.github.com/repos/MFraters/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MFraters/aspect/downloads","issues_url":"https://api.github.com/repos/MFraters/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/MFraters/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/MFraters/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/MFraters/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MFraters/aspect/labels{/name}","releases_url":"https://api.github.com/repos/MFraters/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/MFraters/aspect/deployments","created_at":"2014-05-19T15:08:19Z","updated_at":"2016-01-13T15:59:16Z","pushed_at":"2017-10-16T20:51:00Z","git_url":"git://github.com/MFraters/aspect.git","ssh_url":"[email protected]:MFraters/aspect.git","clone_url":"https://github.com/MFraters/aspect.git","svn_url":"https://github.com/MFraters/aspect","homepage":null,"size":160917,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"5ae9dcf613e9bb17c0c91fb1811afabb959ef8fc","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/geodynamics/aspect/deployments","created_at":"2014-05-06T16:47:18Z","updated_at":"2017-10-12T15:05:01Z","pushed_at":"2017-10-21T22:10:42Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"[email protected]:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"https://aspect.geodynamics.org/","size":165630,"stargazers_count":41,"watchers_count":41,"language":"Gnuplot","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":153,"forks":82,"open_issues":153,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/1952"},"html":{"href":"https://github.com/geodynamics/aspect/pull/1952"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/1952"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/1952/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/1952/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/1952/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/c96016388b71ca2c58034ae02a8fe181181b91fb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 19502452,
"name": "geodynamics/aspect",
"url": "https://api.github.com/repos/geodynamics/aspect"
} | {
"id": 7631624,
"login": "anne-glerum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7631624?",
"url": "https://api.github.com/users/anne-glerum"
} | {
"id": 4052461,
"login": "geodynamics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4052461?",
"url": "https://api.github.com/orgs/geodynamics"
} | 2017-10-23T00:18:26 | 6749926343 | {"actor":{"display_login":"anne-glerum"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/godot/pulls/comments/141479287","pull_request_review_id":65700275,"id":141479287,"diff_hunk":"@@ -110,18 +118,25 @@\n \t</methods>\n \t<members>\n \t\t<member name=\"attack_us\" type=\"float\" setter=\"set_attack_us\" getter=\"get_attack_us\">\n+\t\t\tCompressor's reaction time when the signal exceeds the threshold. Value can range from 20 to 2000. Default value: [code]20ms[/code].\n \t\t</member>\n \t\t<member name=\"gain\" type=\"float\" setter=\"set_gain\" getter=\"get_gain\">\n+\t\t\tGain applied to the output signal.\n \t\t</member>\n \t\t<member name=\"mix\" type=\"float\" setter=\"set_mix\" getter=\"get_mix\">\n+\t\t\tBalance between original signal and effect signal. Value can range from 0 (totally dry) to 1 (totally wet). Default value: [code]1[/code].\n \t\t</member>\n \t\t<member name=\"ratio\" type=\"float\" setter=\"set_ratio\" getter=\"get_ratio\">\n+\t\t\tAmount of compression applied to the audio once it passes the threshold level. The higher the ratio the more the loud parts of the audio will be compressed. Value can range from 1 to 48. Default value: [code]4[/code].\n \t\t</member>\n \t\t<member name=\"release_ms\" type=\"float\" setter=\"set_release_ms\" getter=\"get_release_ms\">\n+\t\t\tCompressor's delay time to stop reducing the signal after the signal level falls below the threshold. Value can range from 20 to 2000. Default value: [code]250ms[/code].\n \t\t</member>\n \t\t<member name=\"sidechain\" type=\"String\" setter=\"set_sidechain\" getter=\"get_sidechain\">\n+\t\t\tReduce the sound level use another audio bus. for threshold detection.","path":"doc/classes/AudioEffectCompressor.xml","position":36,"original_position":36,"commit_id":"49711a066aaf024d036de76c78eb4eb1540db735","original_commit_id":"49711a066aaf024d036de76c78eb4eb1540db735","user":{"login":"cbscribe","id":3812514,"avatar_url":"https://avatars2.githubusercontent.com/u/3812514?v=4","gravatar_id":"","url":"https://api.github.com/users/cbscribe","html_url":"https://github.com/cbscribe","followers_url":"https://api.github.com/users/cbscribe/followers","following_url":"https://api.github.com/users/cbscribe/following{/other_user}","gists_url":"https://api.github.com/users/cbscribe/gists{/gist_id}","starred_url":"https://api.github.com/users/cbscribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbscribe/subscriptions","organizations_url":"https://api.github.com/users/cbscribe/orgs","repos_url":"https://api.github.com/users/cbscribe/repos","events_url":"https://api.github.com/users/cbscribe/events{/privacy}","received_events_url":"https://api.github.com/users/cbscribe/received_events","type":"User","site_admin":false},"body":"I think something got lost on this one.","created_at":"2017-09-27T21:58:29Z","updated_at":"2017-09-27T21:58:30Z","html_url":"https://github.com/godotengine/godot/pull/11635#discussion_r141479287","pull_request_url":"https://api.github.com/repos/godotengine/godot/pulls/11635","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments/141479287"},"html":{"href":"https://github.com/godotengine/godot/pull/11635#discussion_r141479287"},"pull_request":{"href":"https://api.github.com/repos/godotengine/godot/pulls/11635"}}},"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/11635","id":143452020,"html_url":"https://github.com/godotengine/godot/pull/11635","diff_url":"https://github.com/godotengine/godot/pull/11635.diff","patch_url":"https://github.com/godotengine/godot/pull/11635.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/11635","number":11635,"state":"open","locked":false,"title":"[DOCS] AudioEffects doc","user":{"login":"Jerome67000","id":7358899,"avatar_url":"https://avatars3.githubusercontent.com/u/7358899?v=4","gravatar_id":"","url":"https://api.github.com/users/Jerome67000","html_url":"https://github.com/Jerome67000","followers_url":"https://api.github.com/users/Jerome67000/followers","following_url":"https://api.github.com/users/Jerome67000/following{/other_user}","gists_url":"https://api.github.com/users/Jerome67000/gists{/gist_id}","starred_url":"https://api.github.com/users/Jerome67000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jerome67000/subscriptions","organizations_url":"https://api.github.com/users/Jerome67000/orgs","repos_url":"https://api.github.com/users/Jerome67000/repos","events_url":"https://api.github.com/users/Jerome67000/events{/privacy}","received_events_url":"https://api.github.com/users/Jerome67000/received_events","type":"User","site_admin":false},"body":"Not without effort, here is the documentation for the audio effects of godot.\r\n\r\nI have not documented Filters because maybe they will be integrated differently. If not i will write that too.\r\n\r\nFirst time I help for the doc, so maybe some changes will be made before the merge...","created_at":"2017-09-27T17:18:03Z","updated_at":"2017-09-27T21:58:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dd3c0c133a2cdc0a8a879623bfe6ff0cbd49df2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/4","html_url":"https://github.com/godotengine/godot/milestone/4","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/4/labels","id":1449702,"number":4,"title":"3.0","description":"","creator":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":276,"closed_issues":2730,"state":"open","created_at":"2015-12-08T11:42:08Z","updated_at":"2017-09-27T20:15:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/11635/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/11635/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/11635/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/49711a066aaf024d036de76c78eb4eb1540db735","head":{"label":"Jerome67000:docs_AudioEffects","ref":"docs_AudioEffects","sha":"49711a066aaf024d036de76c78eb4eb1540db735","user":{"login":"Jerome67000","id":7358899,"avatar_url":"https://avatars3.githubusercontent.com/u/7358899?v=4","gravatar_id":"","url":"https://api.github.com/users/Jerome67000","html_url":"https://github.com/Jerome67000","followers_url":"https://api.github.com/users/Jerome67000/followers","following_url":"https://api.github.com/users/Jerome67000/following{/other_user}","gists_url":"https://api.github.com/users/Jerome67000/gists{/gist_id}","starred_url":"https://api.github.com/users/Jerome67000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jerome67000/subscriptions","organizations_url":"https://api.github.com/users/Jerome67000/orgs","repos_url":"https://api.github.com/users/Jerome67000/repos","events_url":"https://api.github.com/users/Jerome67000/events{/privacy}","received_events_url":"https://api.github.com/users/Jerome67000/received_events","type":"User","site_admin":false},"repo":{"id":76730820,"name":"godot","full_name":"Jerome67000/godot","owner":{"login":"Jerome67000","id":7358899,"avatar_url":"https://avatars3.githubusercontent.com/u/7358899?v=4","gravatar_id":"","url":"https://api.github.com/users/Jerome67000","html_url":"https://github.com/Jerome67000","followers_url":"https://api.github.com/users/Jerome67000/followers","following_url":"https://api.github.com/users/Jerome67000/following{/other_user}","gists_url":"https://api.github.com/users/Jerome67000/gists{/gist_id}","starred_url":"https://api.github.com/users/Jerome67000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jerome67000/subscriptions","organizations_url":"https://api.github.com/users/Jerome67000/orgs","repos_url":"https://api.github.com/users/Jerome67000/repos","events_url":"https://api.github.com/users/Jerome67000/events{/privacy}","received_events_url":"https://api.github.com/users/Jerome67000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jerome67000/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":true,"url":"https://api.github.com/repos/Jerome67000/godot","forks_url":"https://api.github.com/repos/Jerome67000/godot/forks","keys_url":"https://api.github.com/repos/Jerome67000/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jerome67000/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jerome67000/godot/teams","hooks_url":"https://api.github.com/repos/Jerome67000/godot/hooks","issue_events_url":"https://api.github.com/repos/Jerome67000/godot/issues/events{/number}","events_url":"https://api.github.com/repos/Jerome67000/godot/events","assignees_url":"https://api.github.com/repos/Jerome67000/godot/assignees{/user}","branches_url":"https://api.github.com/repos/Jerome67000/godot/branches{/branch}","tags_url":"https://api.github.com/repos/Jerome67000/godot/tags","blobs_url":"https://api.github.com/repos/Jerome67000/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jerome67000/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jerome67000/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jerome67000/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jerome67000/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/Jerome67000/godot/languages","stargazers_url":"https://api.github.com/repos/Jerome67000/godot/stargazers","contributors_url":"https://api.github.com/repos/Jerome67000/godot/contributors","subscribers_url":"https://api.github.com/repos/Jerome67000/godot/subscribers","subscription_url":"https://api.github.com/repos/Jerome67000/godot/subscription","commits_url":"https://api.github.com/repos/Jerome67000/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jerome67000/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jerome67000/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jerome67000/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jerome67000/godot/contents/{+path}","compare_url":"https://api.github.com/repos/Jerome67000/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jerome67000/godot/merges","archive_url":"https://api.github.com/repos/Jerome67000/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jerome67000/godot/downloads","issues_url":"https://api.github.com/repos/Jerome67000/godot/issues{/number}","pulls_url":"https://api.github.com/repos/Jerome67000/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/Jerome67000/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/Jerome67000/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jerome67000/godot/labels{/name}","releases_url":"https://api.github.com/repos/Jerome67000/godot/releases{/id}","deployments_url":"https://api.github.com/repos/Jerome67000/godot/deployments","created_at":"2016-12-17T15:15:16Z","updated_at":"2016-12-17T15:15:21Z","pushed_at":"2017-09-27T21:43:58Z","git_url":"git://github.com/Jerome67000/godot.git","ssh_url":"[email protected]:Jerome67000/godot.git","clone_url":"https://github.com/Jerome67000/godot.git","svn_url":"https://github.com/Jerome67000/godot","homepage":"https://godotengine.org","size":177522,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"da144fed4c49133a93b3b83cfc665352c0af351a","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"name":"godot","full_name":"godotengine/godot","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2017-09-27T21:41:38Z","pushed_at":"2017-09-27T21:44:01Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"[email protected]:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":191473,"stargazers_count":9761,"watchers_count":9761,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2331,"mirror_url":null,"open_issues_count":2197,"forks":2331,"open_issues":2197,"watchers":9761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/11635"},"html":{"href":"https://github.com/godotengine/godot/pull/11635"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/11635"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/11635/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/11635/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/11635/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/49711a066aaf024d036de76c78eb4eb1540db735"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15634981,
"name": "godotengine/godot",
"url": "https://api.github.com/repos/godotengine/godot"
} | {
"id": 3812514,
"login": "cbscribe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3812514?",
"url": "https://api.github.com/users/cbscribe"
} | {
"id": 6318500,
"login": "godotengine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6318500?",
"url": "https://api.github.com/orgs/godotengine"
} | 2017-09-27T21:58:29 | 6646468136 | {"actor":{"display_login":"cbscribe"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments/121189851","pull_request_review_id":43225148,"id":121189851,"diff_hunk":"@@ -298,9 +332,17 @@ def do_take(args, config):\n url = config.get('DEFAULT', 'url')\n key_file = config.get('DEFAULT', 'key_file')\n \n- client = XoClient(base_url=url,\n- keyfile=key_file)\n- response = client.take(name, space)\n+ auth_user = args.auth_user\n+ auth_password = args.auth_password\n+ if auth_user is not None and auth_password is None:\n+ auth_password = getpass.getpass(prompt=\"auth_password: \")","path":"sdk/examples/xo_python/sawtooth_xo/xo_cli.py","position":92,"original_position":92,"commit_id":"5cd41379b41bb2cbf1bd2571444758e098382eff","original_commit_id":"5cd41379b41bb2cbf1bd2571444758e098382eff","user":{"login":"delventhalz","id":8889580,"avatar_url":"https://avatars0.githubusercontent.com/u/8889580?v=3","gravatar_id":"","url":"https://api.github.com/users/delventhalz","html_url":"https://github.com/delventhalz","followers_url":"https://api.github.com/users/delventhalz/followers","following_url":"https://api.github.com/users/delventhalz/following{/other_user}","gists_url":"https://api.github.com/users/delventhalz/gists{/gist_id}","starred_url":"https://api.github.com/users/delventhalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delventhalz/subscriptions","organizations_url":"https://api.github.com/users/delventhalz/orgs","repos_url":"https://api.github.com/users/delventhalz/repos","events_url":"https://api.github.com/users/delventhalz/events{/privacy}","received_events_url":"https://api.github.com/users/delventhalz/received_events","type":"User","site_admin":false},"body":"You use these four lines four times in this file. Would probably be worth abstracting them into a function.","created_at":"2017-06-09T18:12:27Z","updated_at":"2017-06-09T18:19:49Z","html_url":"https://github.com/hyperledger/sawtooth-core/pull/581#discussion_r121189851","pull_request_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments/121189851"},"html":{"href":"https://github.com/hyperledger/sawtooth-core/pull/581#discussion_r121189851"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/581","id":124063754,"html_url":"https://github.com/hyperledger/sawtooth-core/pull/581","diff_url":"https://github.com/hyperledger/sawtooth-core/pull/581.diff","patch_url":"https://github.com/hyperledger/sawtooth-core/pull/581.patch","issue_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/581","number":581,"state":"open","locked":false,"title":"Add xo CLI auth","user":{"login":"dplumb94","id":27690938,"avatar_url":"https://avatars3.githubusercontent.com/u/27690938?v=3","gravatar_id":"","url":"https://api.github.com/users/dplumb94","html_url":"https://github.com/dplumb94","followers_url":"https://api.github.com/users/dplumb94/followers","following_url":"https://api.github.com/users/dplumb94/following{/other_user}","gists_url":"https://api.github.com/users/dplumb94/gists{/gist_id}","starred_url":"https://api.github.com/users/dplumb94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dplumb94/subscriptions","organizations_url":"https://api.github.com/users/dplumb94/orgs","repos_url":"https://api.github.com/users/dplumb94/repos","events_url":"https://api.github.com/users/dplumb94/events{/privacy}","received_events_url":"https://api.github.com/users/dplumb94/received_events","type":"User","site_admin":false},"body":"## To test this PR\r\n### Setup apache proxy: \r\n`% sudo apt-get update`\r\n`% sudo apt-get install -y apache2`\r\n`% sudo a2enmod headers`\r\n`% sudo a2enmod proxy_http`\r\n\r\n`% vi _/tmp/.password`\r\n```\r\n# .password should match this:\r\n\r\nsawtooth:$apr1$cyAIkitu$Cv6M2hHJlNgnVvKbUdlFr.\r\n\r\n#EOF\r\n```\r\n\r\n`% sudo vi /etc/apache2/sites-enabled/000-default.conf`\r\n```\r\n# 000-default.conf should match this:\r\n\r\n<VirtualHost *:80>\r\n ServerAdmin sawtooth@sawtooth\r\n DocumentRoot /var/www/html\r\n\r\n ErrorLog ${APACHE_LOG_DIR}/error.log\r\n CustomLog ${APACHE_LOG_DIR}/access.log combined\r\n\r\n <Location />\r\n Options Indexes FollowSymLinks\r\n AllowOverride None\r\n AuthType Basic\r\n AuthName \"Enter password\"\r\n AuthUserFile \"/tmp/.password\"\r\n Require user sawtooth\r\n Require all denied\r\n </Location>\r\n</VirtualHost>\r\n\r\nProxyPass /sawtooth http://localhost:8080\r\nProxyPassReverse /sawtooth http://localhost:8080\r\nRequestHeader set X-Forwarded-Path \"/sawtooth\"\r\n\r\n#EOF\r\n```\r\n`% sudo apachectl start`\r\n\r\n### Play xo\r\nTo connect to the Apache proxy auth server, initialize xo with this command:\r\n`% xo init --url http://localhost/sawtooth`\r\n\r\nYou can enter in auth info for each transaction with the `--auth_user` and `--auth_password` options.\r\n\r\n\r\n\r\n\r\n\r\n\r\nSigned-off-by: Darian Plumb <[email protected]>","created_at":"2017-06-05T21:23:03Z","updated_at":"2017-06-09T18:19:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52a516e64d3665a3c8d9a723a31b3bc538ff16ec","assignee":{"login":"dplumb94","id":27690938,"avatar_url":"https://avatars3.githubusercontent.com/u/27690938?v=3","gravatar_id":"","url":"https://api.github.com/users/dplumb94","html_url":"https://github.com/dplumb94","followers_url":"https://api.github.com/users/dplumb94/followers","following_url":"https://api.github.com/users/dplumb94/following{/other_user}","gists_url":"https://api.github.com/users/dplumb94/gists{/gist_id}","starred_url":"https://api.github.com/users/dplumb94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dplumb94/subscriptions","organizations_url":"https://api.github.com/users/dplumb94/orgs","repos_url":"https://api.github.com/users/dplumb94/repos","events_url":"https://api.github.com/users/dplumb94/events{/privacy}","received_events_url":"https://api.github.com/users/dplumb94/received_events","type":"User","site_admin":false},"assignees":[{"login":"dplumb94","id":27690938,"avatar_url":"https://avatars3.githubusercontent.com/u/27690938?v=3","gravatar_id":"","url":"https://api.github.com/users/dplumb94","html_url":"https://github.com/dplumb94","followers_url":"https://api.github.com/users/dplumb94/followers","following_url":"https://api.github.com/users/dplumb94/following{/other_user}","gists_url":"https://api.github.com/users/dplumb94/gists{/gist_id}","starred_url":"https://api.github.com/users/dplumb94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dplumb94/subscriptions","organizations_url":"https://api.github.com/users/dplumb94/orgs","repos_url":"https://api.github.com/users/dplumb94/repos","events_url":"https://api.github.com/users/dplumb94/events{/privacy}","received_events_url":"https://api.github.com/users/dplumb94/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"peterschwarz","id":282233,"avatar_url":"https://avatars3.githubusercontent.com/u/282233?v=3","gravatar_id":"","url":"https://api.github.com/users/peterschwarz","html_url":"https://github.com/peterschwarz","followers_url":"https://api.github.com/users/peterschwarz/followers","following_url":"https://api.github.com/users/peterschwarz/following{/other_user}","gists_url":"https://api.github.com/users/peterschwarz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschwarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschwarz/subscriptions","organizations_url":"https://api.github.com/users/peterschwarz/orgs","repos_url":"https://api.github.com/users/peterschwarz/repos","events_url":"https://api.github.com/users/peterschwarz/events{/privacy}","received_events_url":"https://api.github.com/users/peterschwarz/received_events","type":"User","site_admin":false},{"login":"vaporos","id":2374712,"avatar_url":"https://avatars2.githubusercontent.com/u/2374712?v=3","gravatar_id":"","url":"https://api.github.com/users/vaporos","html_url":"https://github.com/vaporos","followers_url":"https://api.github.com/users/vaporos/followers","following_url":"https://api.github.com/users/vaporos/following{/other_user}","gists_url":"https://api.github.com/users/vaporos/gists{/gist_id}","starred_url":"https://api.github.com/users/vaporos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaporos/subscriptions","organizations_url":"https://api.github.com/users/vaporos/orgs","repos_url":"https://api.github.com/users/vaporos/repos","events_url":"https://api.github.com/users/vaporos/events{/privacy}","received_events_url":"https://api.github.com/users/vaporos/received_events","type":"User","site_admin":false},{"login":"agunde406","id":18215486,"avatar_url":"https://avatars1.githubusercontent.com/u/18215486?v=3","gravatar_id":"","url":"https://api.github.com/users/agunde406","html_url":"https://github.com/agunde406","followers_url":"https://api.github.com/users/agunde406/followers","following_url":"https://api.github.com/users/agunde406/following{/other_user}","gists_url":"https://api.github.com/users/agunde406/gists{/gist_id}","starred_url":"https://api.github.com/users/agunde406/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agunde406/subscriptions","organizations_url":"https://api.github.com/users/agunde406/orgs","repos_url":"https://api.github.com/users/agunde406/repos","events_url":"https://api.github.com/users/agunde406/events{/privacy}","received_events_url":"https://api.github.com/users/agunde406/received_events","type":"User","site_admin":false},{"login":"aludvik","id":24274338,"avatar_url":"https://avatars2.githubusercontent.com/u/24274338?v=3","gravatar_id":"","url":"https://api.github.com/users/aludvik","html_url":"https://github.com/aludvik","followers_url":"https://api.github.com/users/aludvik/followers","following_url":"https://api.github.com/users/aludvik/following{/other_user}","gists_url":"https://api.github.com/users/aludvik/gists{/gist_id}","starred_url":"https://api.github.com/users/aludvik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aludvik/subscriptions","organizations_url":"https://api.github.com/users/aludvik/orgs","repos_url":"https://api.github.com/users/aludvik/repos","events_url":"https://api.github.com/users/aludvik/events{/privacy}","received_events_url":"https://api.github.com/users/aludvik/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/581/commits","review_comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/581/comments","review_comment_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/581/comments","statuses_url":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/5cd41379b41bb2cbf1bd2571444758e098382eff","head":{"label":"dplumb94:STL-304-xo-cli-auth","ref":"STL-304-xo-cli-auth","sha":"5cd41379b41bb2cbf1bd2571444758e098382eff","user":{"login":"dplumb94","id":27690938,"avatar_url":"https://avatars3.githubusercontent.com/u/27690938?v=3","gravatar_id":"","url":"https://api.github.com/users/dplumb94","html_url":"https://github.com/dplumb94","followers_url":"https://api.github.com/users/dplumb94/followers","following_url":"https://api.github.com/users/dplumb94/following{/other_user}","gists_url":"https://api.github.com/users/dplumb94/gists{/gist_id}","starred_url":"https://api.github.com/users/dplumb94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dplumb94/subscriptions","organizations_url":"https://api.github.com/users/dplumb94/orgs","repos_url":"https://api.github.com/users/dplumb94/repos","events_url":"https://api.github.com/users/dplumb94/events{/privacy}","received_events_url":"https://api.github.com/users/dplumb94/received_events","type":"User","site_admin":false},"repo":{"id":88771648,"name":"sawtooth-core","full_name":"dplumb94/sawtooth-core","owner":{"login":"dplumb94","id":27690938,"avatar_url":"https://avatars3.githubusercontent.com/u/27690938?v=3","gravatar_id":"","url":"https://api.github.com/users/dplumb94","html_url":"https://github.com/dplumb94","followers_url":"https://api.github.com/users/dplumb94/followers","following_url":"https://api.github.com/users/dplumb94/following{/other_user}","gists_url":"https://api.github.com/users/dplumb94/gists{/gist_id}","starred_url":"https://api.github.com/users/dplumb94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dplumb94/subscriptions","organizations_url":"https://api.github.com/users/dplumb94/orgs","repos_url":"https://api.github.com/users/dplumb94/repos","events_url":"https://api.github.com/users/dplumb94/events{/privacy}","received_events_url":"https://api.github.com/users/dplumb94/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dplumb94/sawtooth-core","description":"Core repository for Sawtooth Lake Distributed ledger","fork":true,"url":"https://api.github.com/repos/dplumb94/sawtooth-core","forks_url":"https://api.github.com/repos/dplumb94/sawtooth-core/forks","keys_url":"https://api.github.com/repos/dplumb94/sawtooth-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dplumb94/sawtooth-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dplumb94/sawtooth-core/teams","hooks_url":"https://api.github.com/repos/dplumb94/sawtooth-core/hooks","issue_events_url":"https://api.github.com/repos/dplumb94/sawtooth-core/issues/events{/number}","events_url":"https://api.github.com/repos/dplumb94/sawtooth-core/events","assignees_url":"https://api.github.com/repos/dplumb94/sawtooth-core/assignees{/user}","branches_url":"https://api.github.com/repos/dplumb94/sawtooth-core/branches{/branch}","tags_url":"https://api.github.com/repos/dplumb94/sawtooth-core/tags","blobs_url":"https://api.github.com/repos/dplumb94/sawtooth-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dplumb94/sawtooth-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dplumb94/sawtooth-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dplumb94/sawtooth-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dplumb94/sawtooth-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dplumb94/sawtooth-core/languages","stargazers_url":"https://api.github.com/repos/dplumb94/sawtooth-core/stargazers","contributors_url":"https://api.github.com/repos/dplumb94/sawtooth-core/contributors","subscribers_url":"https://api.github.com/repos/dplumb94/sawtooth-core/subscribers","subscription_url":"https://api.github.com/repos/dplumb94/sawtooth-core/subscription","commits_url":"https://api.github.com/repos/dplumb94/sawtooth-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dplumb94/sawtooth-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dplumb94/sawtooth-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dplumb94/sawtooth-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dplumb94/sawtooth-core/contents/{+path}","compare_url":"https://api.github.com/repos/dplumb94/sawtooth-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dplumb94/sawtooth-core/merges","archive_url":"https://api.github.com/repos/dplumb94/sawtooth-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dplumb94/sawtooth-core/downloads","issues_url":"https://api.github.com/repos/dplumb94/sawtooth-core/issues{/number}","pulls_url":"https://api.github.com/repos/dplumb94/sawtooth-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dplumb94/sawtooth-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dplumb94/sawtooth-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dplumb94/sawtooth-core/labels{/name}","releases_url":"https://api.github.com/repos/dplumb94/sawtooth-core/releases{/id}","deployments_url":"https://api.github.com/repos/dplumb94/sawtooth-core/deployments","created_at":"2017-04-19T17:23:18Z","updated_at":"2017-04-19T17:23:20Z","pushed_at":"2017-06-09T15:50:52Z","git_url":"git://github.com/dplumb94/sawtooth-core.git","ssh_url":"[email protected]:dplumb94/sawtooth-core.git","clone_url":"https://github.com/dplumb94/sawtooth-core.git","svn_url":"https://github.com/dplumb94/sawtooth-core","homepage":"http://intelledger.github.io/","size":19777,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"4177c6893af1bd1763e643101fbae75356b9a580","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars1.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":57901437,"name":"sawtooth-core","full_name":"hyperledger/sawtooth-core","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars1.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/sawtooth-core","description":"Core repository for Sawtooth Lake Distributed ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/sawtooth-core","forks_url":"https://api.github.com/repos/hyperledger/sawtooth-core/forks","keys_url":"https://api.github.com/repos/hyperledger/sawtooth-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/sawtooth-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/sawtooth-core/teams","hooks_url":"https://api.github.com/repos/hyperledger/sawtooth-core/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/sawtooth-core/events","assignees_url":"https://api.github.com/repos/hyperledger/sawtooth-core/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/sawtooth-core/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/sawtooth-core/tags","blobs_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/sawtooth-core/languages","stargazers_url":"https://api.github.com/repos/hyperledger/sawtooth-core/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/sawtooth-core/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/sawtooth-core/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/sawtooth-core/subscription","commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/sawtooth-core/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/sawtooth-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/sawtooth-core/merges","archive_url":"https://api.github.com/repos/hyperledger/sawtooth-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/sawtooth-core/downloads","issues_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/sawtooth-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/sawtooth-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/sawtooth-core/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/sawtooth-core/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/deployments","created_at":"2016-05-02T15:51:53Z","updated_at":"2017-06-09T08:37:41Z","pushed_at":"2017-06-09T18:03:39Z","git_url":"git://github.com/hyperledger/sawtooth-core.git","ssh_url":"[email protected]:hyperledger/sawtooth-core.git","clone_url":"https://github.com/hyperledger/sawtooth-core.git","svn_url":"https://github.com/hyperledger/sawtooth-core","homepage":"http://intelledger.github.io/","size":19882,"stargazers_count":272,"watchers_count":272,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":14,"forks":144,"open_issues":14,"watchers":272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/581"},"html":{"href":"https://github.com/hyperledger/sawtooth-core/pull/581"},"issue":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/581"},"comments":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/5cd41379b41bb2cbf1bd2571444758e098382eff"}}}} | {
"id": 57901437,
"name": "hyperledger/sawtooth-core",
"url": "https://api.github.com/repos/hyperledger/sawtooth-core"
} | {
"id": 8889580,
"login": "delventhalz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8889580?",
"url": "https://api.github.com/users/delventhalz"
} | {
"id": 7657900,
"login": "hyperledger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7657900?",
"url": "https://api.github.com/orgs/hyperledger"
} | 2017-06-09T18:12:27 | 6037302750 | {"actor":{"display_login":"delventhalz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments/101619031","pull_request_review_id":22351269,"id":101619031,"diff_hunk":"@@ -143,20 +181,30 @@ def __init__(self,\n endpoint,\n dispatcher,\n identity=None,\n- peer_connections=None):\n+ peer_connections=None,\n+ secured=False,\n+ server_public_key=None,\n+ server_private_key=None):","path":"validator/sawtooth_validator/networking/interconnect.py","position":89,"original_position":89,"commit_id":"e611998447d03b290e1789ea8b8ce04884674e7b","original_commit_id":"e611998447d03b290e1789ea8b8ce04884674e7b","user":{"login":"peterschwarz","id":282233,"avatar_url":"https://avatars.githubusercontent.com/u/282233?v=3","gravatar_id":"","url":"https://api.github.com/users/peterschwarz","html_url":"https://github.com/peterschwarz","followers_url":"https://api.github.com/users/peterschwarz/followers","following_url":"https://api.github.com/users/peterschwarz/following{/other_user}","gists_url":"https://api.github.com/users/peterschwarz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschwarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschwarz/subscriptions","organizations_url":"https://api.github.com/users/peterschwarz/orgs","repos_url":"https://api.github.com/users/peterschwarz/repos","events_url":"https://api.github.com/users/peterschwarz/events{/privacy}","received_events_url":"https://api.github.com/users/peterschwarz/received_events","type":"User","site_admin":false},"body":"Doc here on these fields","created_at":"2017-02-16T20:29:10Z","updated_at":"2017-02-16T20:31:20Z","html_url":"https://github.com/hyperledger/sawtooth-core/pull/94#discussion_r101619031","pull_request_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments/101619031"},"html":{"href":"https://github.com/hyperledger/sawtooth-core/pull/94#discussion_r101619031"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/94","id":106601266,"html_url":"https://github.com/hyperledger/sawtooth-core/pull/94","diff_url":"https://github.com/hyperledger/sawtooth-core/pull/94.diff","patch_url":"https://github.com/hyperledger/sawtooth-core/pull/94.patch","issue_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/94","number":94,"state":"open","locked":false,"title":"Implement CurveZMQ security for the network","user":{"login":"jsmitchell","id":5748777,"avatar_url":"https://avatars.githubusercontent.com/u/5748777?v=3","gravatar_id":"","url":"https://api.github.com/users/jsmitchell","html_url":"https://github.com/jsmitchell","followers_url":"https://api.github.com/users/jsmitchell/followers","following_url":"https://api.github.com/users/jsmitchell/following{/other_user}","gists_url":"https://api.github.com/users/jsmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmitchell/subscriptions","organizations_url":"https://api.github.com/users/jsmitchell/orgs","repos_url":"https://api.github.com/users/jsmitchell/repos","events_url":"https://api.github.com/users/jsmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/jsmitchell/received_events","type":"User","site_admin":false},"body":"This implements an authentication handshake and transport encryption using ZMQ's CurveZMQ support (ec based on edwards). The support is implemented in the shared Interconnect object, but is only enabled for the network (validator to validator) instance. In the future, we can also enable this for the intercomponent instance, but that will require changes to 'clients'.","created_at":"2017-02-16T19:53:39Z","updated_at":"2017-02-16T20:31:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1fc6036990c8ae254a5fff1c0ac8a56ebfbe484","assignee":{"login":"peterschwarz","id":282233,"avatar_url":"https://avatars.githubusercontent.com/u/282233?v=3","gravatar_id":"","url":"https://api.github.com/users/peterschwarz","html_url":"https://github.com/peterschwarz","followers_url":"https://api.github.com/users/peterschwarz/followers","following_url":"https://api.github.com/users/peterschwarz/following{/other_user}","gists_url":"https://api.github.com/users/peterschwarz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschwarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschwarz/subscriptions","organizations_url":"https://api.github.com/users/peterschwarz/orgs","repos_url":"https://api.github.com/users/peterschwarz/repos","events_url":"https://api.github.com/users/peterschwarz/events{/privacy}","received_events_url":"https://api.github.com/users/peterschwarz/received_events","type":"User","site_admin":false},"assignees":[{"login":"peterschwarz","id":282233,"avatar_url":"https://avatars.githubusercontent.com/u/282233?v=3","gravatar_id":"","url":"https://api.github.com/users/peterschwarz","html_url":"https://github.com/peterschwarz","followers_url":"https://api.github.com/users/peterschwarz/followers","following_url":"https://api.github.com/users/peterschwarz/following{/other_user}","gists_url":"https://api.github.com/users/peterschwarz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschwarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschwarz/subscriptions","organizations_url":"https://api.github.com/users/peterschwarz/orgs","repos_url":"https://api.github.com/users/peterschwarz/repos","events_url":"https://api.github.com/users/peterschwarz/events{/privacy}","received_events_url":"https://api.github.com/users/peterschwarz/received_events","type":"User","site_admin":false},{"login":"vaporos","id":2374712,"avatar_url":"https://avatars.githubusercontent.com/u/2374712?v=3","gravatar_id":"","url":"https://api.github.com/users/vaporos","html_url":"https://github.com/vaporos","followers_url":"https://api.github.com/users/vaporos/followers","following_url":"https://api.github.com/users/vaporos/following{/other_user}","gists_url":"https://api.github.com/users/vaporos/gists{/gist_id}","starred_url":"https://api.github.com/users/vaporos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaporos/subscriptions","organizations_url":"https://api.github.com/users/vaporos/orgs","repos_url":"https://api.github.com/users/vaporos/repos","events_url":"https://api.github.com/users/vaporos/events{/privacy}","received_events_url":"https://api.github.com/users/vaporos/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/94/commits","review_comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/94/comments","review_comment_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/94/comments","statuses_url":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/e611998447d03b290e1789ea8b8ce04884674e7b","head":{"label":"jsmitchell:zmqsecurity","ref":"zmqsecurity","sha":"e611998447d03b290e1789ea8b8ce04884674e7b","user":{"login":"jsmitchell","id":5748777,"avatar_url":"https://avatars.githubusercontent.com/u/5748777?v=3","gravatar_id":"","url":"https://api.github.com/users/jsmitchell","html_url":"https://github.com/jsmitchell","followers_url":"https://api.github.com/users/jsmitchell/followers","following_url":"https://api.github.com/users/jsmitchell/following{/other_user}","gists_url":"https://api.github.com/users/jsmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmitchell/subscriptions","organizations_url":"https://api.github.com/users/jsmitchell/orgs","repos_url":"https://api.github.com/users/jsmitchell/repos","events_url":"https://api.github.com/users/jsmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/jsmitchell/received_events","type":"User","site_admin":false},"repo":{"id":81605361,"name":"sawtooth-core","full_name":"jsmitchell/sawtooth-core","owner":{"login":"jsmitchell","id":5748777,"avatar_url":"https://avatars.githubusercontent.com/u/5748777?v=3","gravatar_id":"","url":"https://api.github.com/users/jsmitchell","html_url":"https://github.com/jsmitchell","followers_url":"https://api.github.com/users/jsmitchell/followers","following_url":"https://api.github.com/users/jsmitchell/following{/other_user}","gists_url":"https://api.github.com/users/jsmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmitchell/subscriptions","organizations_url":"https://api.github.com/users/jsmitchell/orgs","repos_url":"https://api.github.com/users/jsmitchell/repos","events_url":"https://api.github.com/users/jsmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/jsmitchell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsmitchell/sawtooth-core","description":"Core repository for Sawtooth Lake Distributed ledger","fork":true,"url":"https://api.github.com/repos/jsmitchell/sawtooth-core","forks_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/forks","keys_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/teams","hooks_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/hooks","issue_events_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/issues/events{/number}","events_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/events","assignees_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/assignees{/user}","branches_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/branches{/branch}","tags_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/tags","blobs_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/languages","stargazers_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/stargazers","contributors_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/contributors","subscribers_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/subscribers","subscription_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/subscription","commits_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/contents/{+path}","compare_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/merges","archive_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/downloads","issues_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/issues{/number}","pulls_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/labels{/name}","releases_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/releases{/id}","deployments_url":"https://api.github.com/repos/jsmitchell/sawtooth-core/deployments","created_at":"2017-02-10T20:46:59Z","updated_at":"2017-02-10T20:47:02Z","pushed_at":"2017-02-16T19:48:23Z","git_url":"git://github.com/jsmitchell/sawtooth-core.git","ssh_url":"[email protected]:jsmitchell/sawtooth-core.git","clone_url":"https://github.com/jsmitchell/sawtooth-core.git","svn_url":"https://github.com/jsmitchell/sawtooth-core","homepage":"http://intelledger.github.io/","size":10058,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"f54e602870bbe078f7780a7cf4d64433fd3741d6","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":57901437,"name":"sawtooth-core","full_name":"hyperledger/sawtooth-core","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/sawtooth-core","description":"Core repository for Sawtooth Lake Distributed ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/sawtooth-core","forks_url":"https://api.github.com/repos/hyperledger/sawtooth-core/forks","keys_url":"https://api.github.com/repos/hyperledger/sawtooth-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/sawtooth-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/sawtooth-core/teams","hooks_url":"https://api.github.com/repos/hyperledger/sawtooth-core/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/sawtooth-core/events","assignees_url":"https://api.github.com/repos/hyperledger/sawtooth-core/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/sawtooth-core/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/sawtooth-core/tags","blobs_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/sawtooth-core/languages","stargazers_url":"https://api.github.com/repos/hyperledger/sawtooth-core/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/sawtooth-core/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/sawtooth-core/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/sawtooth-core/subscription","commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/sawtooth-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/sawtooth-core/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/sawtooth-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/sawtooth-core/merges","archive_url":"https://api.github.com/repos/hyperledger/sawtooth-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/sawtooth-core/downloads","issues_url":"https://api.github.com/repos/hyperledger/sawtooth-core/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/sawtooth-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/sawtooth-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/sawtooth-core/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/sawtooth-core/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/sawtooth-core/deployments","created_at":"2016-05-02T15:51:53Z","updated_at":"2017-02-15T17:45:50Z","pushed_at":"2017-02-16T19:53:40Z","git_url":"git://github.com/hyperledger/sawtooth-core.git","ssh_url":"[email protected]:hyperledger/sawtooth-core.git","clone_url":"https://github.com/hyperledger/sawtooth-core.git","svn_url":"https://github.com/hyperledger/sawtooth-core","homepage":"http://intelledger.github.io/","size":10104,"stargazers_count":160,"watchers_count":160,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":10,"forks":83,"open_issues":10,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/94"},"html":{"href":"https://github.com/hyperledger/sawtooth-core/pull/94"},"issue":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/94"},"comments":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/sawtooth-core/statuses/e611998447d03b290e1789ea8b8ce04884674e7b"}}}} | {
"id": 57901437,
"name": "hyperledger/sawtooth-core",
"url": "https://api.github.com/repos/hyperledger/sawtooth-core"
} | {
"id": 282233,
"login": "peterschwarz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/282233?",
"url": "https://api.github.com/users/peterschwarz"
} | {
"id": 7657900,
"login": "hyperledger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7657900?",
"url": "https://api.github.com/orgs/hyperledger"
} | 2017-02-16T20:29:10 | 5339502528 | {"actor":{"display_login":"peterschwarz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/lv275python/eventually.api/pulls/comments/151101216","pull_request_review_id":76749271,"id":151101216,"diff_hunk":"@@ -3,19 +3,66 @@\n ============\n \"\"\"\n \n-from utils.utils import json_loads\n+\n from django.views.generic.base import View\n from django.contrib.auth import authenticate, login, logout\n from django.http import HttpResponse\n+from eventually.settings import FRONT_HOST\n+from utils.utils import json_loads\n+from utils.jwttoken import create_token, handle_token\n+from utils.send_mail import send_email\n+from utils.validators import registration_validate\n+from authentication.models import CustomUser\n \n \n class UserView(View):\n \"\"\"UserView view handles GET, POST, PUT, DELETE requests.\"\"\"\n \n \n-def registration_user():\n+def registration(request):\n \"\"\"Registration CustomUser\"\"\"\n \n+ if request.method == 'POST':\n+ data = json_loads(request.body)\n+ if not registration_validate(data):\n+ return HttpResponse('Data is not valid', status=400)\n+\n+ user = CustomUser.create(first_name=data['first_name'],\n+ last_name=data['last_name'],\n+ middle_name=data['middle_name'],\n+ email=data['email'].lower().strip(),\n+ password=data['password'])\n+ if not user:\n+ return HttpResponse('Email is already exist', status=400)\n+\n+ ctx = {\n+ 'first_name': user.first_name,\n+ 'domain': FRONT_HOST,\n+ 'token': create_token({'email': user.email}),\n+ }\n+ message = 'registration'\n+ mail_subject = 'Activate account'\n+ send_email(mail_subject, message, [user.email], 'registration.html', ctx)\n+ msg = 'Please confirm your email address to complete the registration'\n+ return HttpResponse(msg, status=201)\n+\n+\n+def activate(request, token):\n+ \"\"\"Activation CustomUser\"\"\"\n+ if request.method == 'GET':\n+ try:\n+ email = handle_token(token)\n+ user = CustomUser.objects.get(email=email['email'])\n+ except(TypeError, ValueError, OverflowError, CustomUser.DoesNotExist):\n+ user = None\n+ if user is not None:","path":"eventually/authentication/views.py","position":58,"original_position":58,"commit_id":"05d5a99c7bac268b8198eb4ea4fb0d2c0d3358b3","original_commit_id":"05d5a99c7bac268b8198eb4ea4fb0d2c0d3358b3","user":{"login":"dmytrorevak","id":23266969,"avatar_url":"https://avatars1.githubusercontent.com/u/23266969?v=4","gravatar_id":"","url":"https://api.github.com/users/dmytrorevak","html_url":"https://github.com/dmytrorevak","followers_url":"https://api.github.com/users/dmytrorevak/followers","following_url":"https://api.github.com/users/dmytrorevak/following{/other_user}","gists_url":"https://api.github.com/users/dmytrorevak/gists{/gist_id}","starred_url":"https://api.github.com/users/dmytrorevak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmytrorevak/subscriptions","organizations_url":"https://api.github.com/users/dmytrorevak/orgs","repos_url":"https://api.github.com/users/dmytrorevak/repos","events_url":"https://api.github.com/users/dmytrorevak/events{/privacy}","received_events_url":"https://api.github.com/users/dmytrorevak/received_events","type":"User","site_admin":false},"body":"why not only `if user`?","created_at":"2017-11-15T11:32:25Z","updated_at":"2017-11-15T11:46:12Z","html_url":"https://github.com/lv275python/eventually.api/pull/47#discussion_r151101216","pull_request_url":"https://api.github.com/repos/lv275python/eventually.api/pulls/47","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lv275python/eventually.api/pulls/comments/151101216"},"html":{"href":"https://github.com/lv275python/eventually.api/pull/47#discussion_r151101216"},"pull_request":{"href":"https://api.github.com/repos/lv275python/eventually.api/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/lv275python/eventually.api/pulls/47","id":152332254,"html_url":"https://github.com/lv275python/eventually.api/pull/47","diff_url":"https://github.com/lv275python/eventually.api/pull/47.diff","patch_url":"https://github.com/lv275python/eventually.api/pull/47.patch","issue_url":"https://api.github.com/repos/lv275python/eventually.api/issues/47","number":47,"state":"open","locked":false,"title":"Added registration views & validation & confirm email","user":{"login":"Silent777","id":33020662,"avatar_url":"https://avatars0.githubusercontent.com/u/33020662?v=4","gravatar_id":"","url":"https://api.github.com/users/Silent777","html_url":"https://github.com/Silent777","followers_url":"https://api.github.com/users/Silent777/followers","following_url":"https://api.github.com/users/Silent777/following{/other_user}","gists_url":"https://api.github.com/users/Silent777/gists{/gist_id}","starred_url":"https://api.github.com/users/Silent777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silent777/subscriptions","organizations_url":"https://api.github.com/users/Silent777/orgs","repos_url":"https://api.github.com/users/Silent777/repos","events_url":"https://api.github.com/users/Silent777/events{/privacy}","received_events_url":"https://api.github.com/users/Silent777/received_events","type":"User","site_admin":false},"body":"Added activation for user\r\nAdded url for token\r\nAdded registration template html\r\n\r\n## JIRA\r\n\r\n* [Main JIRA ticket](https://ssu-jira.softserveinc.com/secure/RapidBoard.jspa?rapidView=738&view=detail&selectedIssue=LVPYTP-10)\r\n\r\n\r\n## Code reviewers\r\n\r\n- [ ] @dmytrorevak\r\n- [ ] @IvanAndrukh\r\n- [ ] @JjuliaP\r\n- [ ] @makarman\r\n- [ ] @noobhunters\r\n- [ ] @Silent777\r\n- [ ] @Staryj812\r\n\r\n### Second Level Review\r\n\r\n- [ ] @ssOleg\r\n- [ ] @lhalam\r\n\r\n## CHECK LIST\r\n- [ ] СI passed\r\n- [ ] Сode coverage >=95%\r\n- [ ] PR is reviewed manually again (to make sure you have 100% ready code)\r\n- [ ] All reviewers agreed to merge the PR\r\n- [ ] I've checked new feature as logged in and logged out user if needed\r\n- [ ] PR meets all conventions\r\n","created_at":"2017-11-13T19:56:53Z","updated_at":"2017-11-15T11:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"789965b315b85ed657e0c34679d4bde8301bce14","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lv275python/eventually.api/pulls/47/commits","review_comments_url":"https://api.github.com/repos/lv275python/eventually.api/pulls/47/comments","review_comment_url":"https://api.github.com/repos/lv275python/eventually.api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lv275python/eventually.api/issues/47/comments","statuses_url":"https://api.github.com/repos/lv275python/eventually.api/statuses/05d5a99c7bac268b8198eb4ea4fb0d2c0d3358b3","head":{"label":"lv275python:feature/registration_user","ref":"feature/registration_user","sha":"05d5a99c7bac268b8198eb4ea4fb0d2c0d3358b3","user":{"login":"lv275python","id":33029203,"avatar_url":"https://avatars1.githubusercontent.com/u/33029203?v=4","gravatar_id":"","url":"https://api.github.com/users/lv275python","html_url":"https://github.com/lv275python","followers_url":"https://api.github.com/users/lv275python/followers","following_url":"https://api.github.com/users/lv275python/following{/other_user}","gists_url":"https://api.github.com/users/lv275python/gists{/gist_id}","starred_url":"https://api.github.com/users/lv275python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lv275python/subscriptions","organizations_url":"https://api.github.com/users/lv275python/orgs","repos_url":"https://api.github.com/users/lv275python/repos","events_url":"https://api.github.com/users/lv275python/events{/privacy}","received_events_url":"https://api.github.com/users/lv275python/received_events","type":"Organization","site_admin":false},"repo":{"id":107986376,"name":"eventually.api","full_name":"lv275python/eventually.api","owner":{"login":"lv275python","id":33029203,"avatar_url":"https://avatars1.githubusercontent.com/u/33029203?v=4","gravatar_id":"","url":"https://api.github.com/users/lv275python","html_url":"https://github.com/lv275python","followers_url":"https://api.github.com/users/lv275python/followers","following_url":"https://api.github.com/users/lv275python/following{/other_user}","gists_url":"https://api.github.com/users/lv275python/gists{/gist_id}","starred_url":"https://api.github.com/users/lv275python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lv275python/subscriptions","organizations_url":"https://api.github.com/users/lv275python/orgs","repos_url":"https://api.github.com/users/lv275python/repos","events_url":"https://api.github.com/users/lv275python/events{/privacy}","received_events_url":"https://api.github.com/users/lv275python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lv275python/eventually.api","description":null,"fork":false,"url":"https://api.github.com/repos/lv275python/eventually.api","forks_url":"https://api.github.com/repos/lv275python/eventually.api/forks","keys_url":"https://api.github.com/repos/lv275python/eventually.api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lv275python/eventually.api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lv275python/eventually.api/teams","hooks_url":"https://api.github.com/repos/lv275python/eventually.api/hooks","issue_events_url":"https://api.github.com/repos/lv275python/eventually.api/issues/events{/number}","events_url":"https://api.github.com/repos/lv275python/eventually.api/events","assignees_url":"https://api.github.com/repos/lv275python/eventually.api/assignees{/user}","branches_url":"https://api.github.com/repos/lv275python/eventually.api/branches{/branch}","tags_url":"https://api.github.com/repos/lv275python/eventually.api/tags","blobs_url":"https://api.github.com/repos/lv275python/eventually.api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lv275python/eventually.api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lv275python/eventually.api/git/refs{/sha}","trees_url":"https://api.github.com/repos/lv275python/eventually.api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lv275python/eventually.api/statuses/{sha}","languages_url":"https://api.github.com/repos/lv275python/eventually.api/languages","stargazers_url":"https://api.github.com/repos/lv275python/eventually.api/stargazers","contributors_url":"https://api.github.com/repos/lv275python/eventually.api/contributors","subscribers_url":"https://api.github.com/repos/lv275python/eventually.api/subscribers","subscription_url":"https://api.github.com/repos/lv275python/eventually.api/subscription","commits_url":"https://api.github.com/repos/lv275python/eventually.api/commits{/sha}","git_commits_url":"https://api.github.com/repos/lv275python/eventually.api/git/commits{/sha}","comments_url":"https://api.github.com/repos/lv275python/eventually.api/comments{/number}","issue_comment_url":"https://api.github.com/repos/lv275python/eventually.api/issues/comments{/number}","contents_url":"https://api.github.com/repos/lv275python/eventually.api/contents/{+path}","compare_url":"https://api.github.com/repos/lv275python/eventually.api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lv275python/eventually.api/merges","archive_url":"https://api.github.com/repos/lv275python/eventually.api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lv275python/eventually.api/downloads","issues_url":"https://api.github.com/repos/lv275python/eventually.api/issues{/number}","pulls_url":"https://api.github.com/repos/lv275python/eventually.api/pulls{/number}","milestones_url":"https://api.github.com/repos/lv275python/eventually.api/milestones{/number}","notifications_url":"https://api.github.com/repos/lv275python/eventually.api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lv275python/eventually.api/labels{/name}","releases_url":"https://api.github.com/repos/lv275python/eventually.api/releases{/id}","deployments_url":"https://api.github.com/repos/lv275python/eventually.api/deployments","created_at":"2017-10-23T13:31:00Z","updated_at":"2017-11-11T22:20:43Z","pushed_at":"2017-11-15T11:41:27Z","git_url":"git://github.com/lv275python/eventually.api.git","ssh_url":"[email protected]:lv275python/eventually.api.git","clone_url":"https://github.com/lv275python/eventually.api.git","svn_url":"https://github.com/lv275python/eventually.api","homepage":null,"size":124,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":2,"default_branch":"dev"}},"base":{"label":"lv275python:dev","ref":"dev","sha":"07313838dfb804d620868a6a5cf82fe8b1e99bb5","user":{"login":"lv275python","id":33029203,"avatar_url":"https://avatars1.githubusercontent.com/u/33029203?v=4","gravatar_id":"","url":"https://api.github.com/users/lv275python","html_url":"https://github.com/lv275python","followers_url":"https://api.github.com/users/lv275python/followers","following_url":"https://api.github.com/users/lv275python/following{/other_user}","gists_url":"https://api.github.com/users/lv275python/gists{/gist_id}","starred_url":"https://api.github.com/users/lv275python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lv275python/subscriptions","organizations_url":"https://api.github.com/users/lv275python/orgs","repos_url":"https://api.github.com/users/lv275python/repos","events_url":"https://api.github.com/users/lv275python/events{/privacy}","received_events_url":"https://api.github.com/users/lv275python/received_events","type":"Organization","site_admin":false},"repo":{"id":107986376,"name":"eventually.api","full_name":"lv275python/eventually.api","owner":{"login":"lv275python","id":33029203,"avatar_url":"https://avatars1.githubusercontent.com/u/33029203?v=4","gravatar_id":"","url":"https://api.github.com/users/lv275python","html_url":"https://github.com/lv275python","followers_url":"https://api.github.com/users/lv275python/followers","following_url":"https://api.github.com/users/lv275python/following{/other_user}","gists_url":"https://api.github.com/users/lv275python/gists{/gist_id}","starred_url":"https://api.github.com/users/lv275python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lv275python/subscriptions","organizations_url":"https://api.github.com/users/lv275python/orgs","repos_url":"https://api.github.com/users/lv275python/repos","events_url":"https://api.github.com/users/lv275python/events{/privacy}","received_events_url":"https://api.github.com/users/lv275python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lv275python/eventually.api","description":null,"fork":false,"url":"https://api.github.com/repos/lv275python/eventually.api","forks_url":"https://api.github.com/repos/lv275python/eventually.api/forks","keys_url":"https://api.github.com/repos/lv275python/eventually.api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lv275python/eventually.api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lv275python/eventually.api/teams","hooks_url":"https://api.github.com/repos/lv275python/eventually.api/hooks","issue_events_url":"https://api.github.com/repos/lv275python/eventually.api/issues/events{/number}","events_url":"https://api.github.com/repos/lv275python/eventually.api/events","assignees_url":"https://api.github.com/repos/lv275python/eventually.api/assignees{/user}","branches_url":"https://api.github.com/repos/lv275python/eventually.api/branches{/branch}","tags_url":"https://api.github.com/repos/lv275python/eventually.api/tags","blobs_url":"https://api.github.com/repos/lv275python/eventually.api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lv275python/eventually.api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lv275python/eventually.api/git/refs{/sha}","trees_url":"https://api.github.com/repos/lv275python/eventually.api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lv275python/eventually.api/statuses/{sha}","languages_url":"https://api.github.com/repos/lv275python/eventually.api/languages","stargazers_url":"https://api.github.com/repos/lv275python/eventually.api/stargazers","contributors_url":"https://api.github.com/repos/lv275python/eventually.api/contributors","subscribers_url":"https://api.github.com/repos/lv275python/eventually.api/subscribers","subscription_url":"https://api.github.com/repos/lv275python/eventually.api/subscription","commits_url":"https://api.github.com/repos/lv275python/eventually.api/commits{/sha}","git_commits_url":"https://api.github.com/repos/lv275python/eventually.api/git/commits{/sha}","comments_url":"https://api.github.com/repos/lv275python/eventually.api/comments{/number}","issue_comment_url":"https://api.github.com/repos/lv275python/eventually.api/issues/comments{/number}","contents_url":"https://api.github.com/repos/lv275python/eventually.api/contents/{+path}","compare_url":"https://api.github.com/repos/lv275python/eventually.api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lv275python/eventually.api/merges","archive_url":"https://api.github.com/repos/lv275python/eventually.api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lv275python/eventually.api/downloads","issues_url":"https://api.github.com/repos/lv275python/eventually.api/issues{/number}","pulls_url":"https://api.github.com/repos/lv275python/eventually.api/pulls{/number}","milestones_url":"https://api.github.com/repos/lv275python/eventually.api/milestones{/number}","notifications_url":"https://api.github.com/repos/lv275python/eventually.api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lv275python/eventually.api/labels{/name}","releases_url":"https://api.github.com/repos/lv275python/eventually.api/releases{/id}","deployments_url":"https://api.github.com/repos/lv275python/eventually.api/deployments","created_at":"2017-10-23T13:31:00Z","updated_at":"2017-11-11T22:20:43Z","pushed_at":"2017-11-15T11:41:27Z","git_url":"git://github.com/lv275python/eventually.api.git","ssh_url":"[email protected]:lv275python/eventually.api.git","clone_url":"https://github.com/lv275python/eventually.api.git","svn_url":"https://github.com/lv275python/eventually.api","homepage":null,"size":124,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/lv275python/eventually.api/pulls/47"},"html":{"href":"https://github.com/lv275python/eventually.api/pull/47"},"issue":{"href":"https://api.github.com/repos/lv275python/eventually.api/issues/47"},"comments":{"href":"https://api.github.com/repos/lv275python/eventually.api/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/lv275python/eventually.api/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/lv275python/eventually.api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lv275python/eventually.api/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/lv275python/eventually.api/statuses/05d5a99c7bac268b8198eb4ea4fb0d2c0d3358b3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 107986376,
"name": "lv275python/eventually.api",
"url": "https://api.github.com/repos/lv275python/eventually.api"
} | {
"id": 23266969,
"login": "dmytrorevak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23266969?",
"url": "https://api.github.com/users/dmytrorevak"
} | {
"id": 33029203,
"login": "lv275python",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33029203?",
"url": "https://api.github.com/orgs/lv275python"
} | 2017-11-15T11:32:25 | 6858089137 | {"actor":{"display_login":"dmytrorevak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/comments/139886436","pull_request_review_id":63876752,"id":139886436,"diff_hunk":"@@ -0,0 +1,10 @@\n+echo 'Backup Influx metadata'","path":"data/backup-script/backup.sh","position":1,"original_position":1,"commit_id":"7b102c22c46bdd85517f481fdba4da831517c8a0","original_commit_id":"7b102c22c46bdd85517f481fdba4da831517c8a0","user":{"login":"terrillmoore","id":19333103,"avatar_url":"https://avatars3.githubusercontent.com/u/19333103?v=4","gravatar_id":"","url":"https://api.github.com/users/terrillmoore","html_url":"https://github.com/terrillmoore","followers_url":"https://api.github.com/users/terrillmoore/followers","following_url":"https://api.github.com/users/terrillmoore/following{/other_user}","gists_url":"https://api.github.com/users/terrillmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/terrillmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrillmoore/subscriptions","organizations_url":"https://api.github.com/users/terrillmoore/orgs","repos_url":"https://api.github.com/users/terrillmoore/repos","events_url":"https://api.github.com/users/terrillmoore/events{/privacy}","received_events_url":"https://api.github.com/users/terrillmoore/received_events","type":"User","site_admin":false},"body":"I now see that, in fact, this is a mistaken commit, as it's a duplicate of the script below.","created_at":"2017-09-20T06:45:03Z","updated_at":"2017-09-20T06:47:35Z","html_url":"https://github.com/mcci-catena/docker-ttn-dashboard/pull/10#discussion_r139886436","pull_request_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/comments/139886436"},"html":{"href":"https://github.com/mcci-catena/docker-ttn-dashboard/pull/10#discussion_r139886436"},"pull_request":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/10"}},"in_reply_to_id":139884459},"pull_request":{"url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/10","id":141787376,"html_url":"https://github.com/mcci-catena/docker-ttn-dashboard/pull/10","diff_url":"https://github.com/mcci-catena/docker-ttn-dashboard/pull/10.diff","patch_url":"https://github.com/mcci-catena/docker-ttn-dashboard/pull/10.patch","issue_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/issues/10","number":10,"state":"open","locked":false,"title":"Extra instance for influxdb backup","user":{"login":"MuruganChandrasekar","id":18657477,"avatar_url":"https://avatars0.githubusercontent.com/u/18657477?v=4","gravatar_id":"","url":"https://api.github.com/users/MuruganChandrasekar","html_url":"https://github.com/MuruganChandrasekar","followers_url":"https://api.github.com/users/MuruganChandrasekar/followers","following_url":"https://api.github.com/users/MuruganChandrasekar/following{/other_user}","gists_url":"https://api.github.com/users/MuruganChandrasekar/gists{/gist_id}","starred_url":"https://api.github.com/users/MuruganChandrasekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MuruganChandrasekar/subscriptions","organizations_url":"https://api.github.com/users/MuruganChandrasekar/orgs","repos_url":"https://api.github.com/users/MuruganChandrasekar/repos","events_url":"https://api.github.com/users/MuruganChandrasekar/events{/privacy}","received_events_url":"https://api.github.com/users/MuruganChandrasekar/received_events","type":"User","site_admin":false},"body":"Extra instance for influxdb backup has been setup and created a short notes in README.md under \"influxdb-backup\" directory for reference. please go through it. ","created_at":"2017-09-19T08:32:58Z","updated_at":"2017-09-20T06:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9796fda165b573757ebe613dd912bf7a0f6acb3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/10/commits","review_comments_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/10/comments","review_comment_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/issues/10/comments","statuses_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/statuses/7b102c22c46bdd85517f481fdba4da831517c8a0","head":{"label":"MuruganChandrasekar:extra-instance-for-influxdb-backup","ref":"extra-instance-for-influxdb-backup","sha":"7b102c22c46bdd85517f481fdba4da831517c8a0","user":{"login":"MuruganChandrasekar","id":18657477,"avatar_url":"https://avatars0.githubusercontent.com/u/18657477?v=4","gravatar_id":"","url":"https://api.github.com/users/MuruganChandrasekar","html_url":"https://github.com/MuruganChandrasekar","followers_url":"https://api.github.com/users/MuruganChandrasekar/followers","following_url":"https://api.github.com/users/MuruganChandrasekar/following{/other_user}","gists_url":"https://api.github.com/users/MuruganChandrasekar/gists{/gist_id}","starred_url":"https://api.github.com/users/MuruganChandrasekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MuruganChandrasekar/subscriptions","organizations_url":"https://api.github.com/users/MuruganChandrasekar/orgs","repos_url":"https://api.github.com/users/MuruganChandrasekar/repos","events_url":"https://api.github.com/users/MuruganChandrasekar/events{/privacy}","received_events_url":"https://api.github.com/users/MuruganChandrasekar/received_events","type":"User","site_admin":false},"repo":{"id":104046241,"name":"docker-ttn-dashboard","full_name":"MuruganChandrasekar/docker-ttn-dashboard","owner":{"login":"MuruganChandrasekar","id":18657477,"avatar_url":"https://avatars0.githubusercontent.com/u/18657477?v=4","gravatar_id":"","url":"https://api.github.com/users/MuruganChandrasekar","html_url":"https://github.com/MuruganChandrasekar","followers_url":"https://api.github.com/users/MuruganChandrasekar/followers","following_url":"https://api.github.com/users/MuruganChandrasekar/following{/other_user}","gists_url":"https://api.github.com/users/MuruganChandrasekar/gists{/gist_id}","starred_url":"https://api.github.com/users/MuruganChandrasekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MuruganChandrasekar/subscriptions","organizations_url":"https://api.github.com/users/MuruganChandrasekar/orgs","repos_url":"https://api.github.com/users/MuruganChandrasekar/repos","events_url":"https://api.github.com/users/MuruganChandrasekar/events{/privacy}","received_events_url":"https://api.github.com/users/MuruganChandrasekar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MuruganChandrasekar/docker-ttn-dashboard","description":"A complete setup for node-red + influxdb + grafana + ssl + let's encrypt using docker-compose.","fork":true,"url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard","forks_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/forks","keys_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/teams","hooks_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/hooks","issue_events_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/events","assignees_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/tags","blobs_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/languages","stargazers_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/stargazers","contributors_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/contributors","subscribers_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/subscribers","subscription_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/subscription","commits_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/merges","archive_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/downloads","issues_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/MuruganChandrasekar/docker-ttn-dashboard/deployments","created_at":"2017-09-19T08:11:32Z","updated_at":"2017-09-19T08:11:34Z","pushed_at":"2017-09-19T08:22:35Z","git_url":"git://github.com/MuruganChandrasekar/docker-ttn-dashboard.git","ssh_url":"[email protected]:MuruganChandrasekar/docker-ttn-dashboard.git","clone_url":"https://github.com/MuruganChandrasekar/docker-ttn-dashboard.git","svn_url":"https://github.com/MuruganChandrasekar/docker-ttn-dashboard","homepage":"","size":860,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mcci-catena:master","ref":"master","sha":"c496789b3e316deb73b52c5c46e8b3ffa4000519","user":{"login":"mcci-catena","id":23129382,"avatar_url":"https://avatars1.githubusercontent.com/u/23129382?v=4","gravatar_id":"","url":"https://api.github.com/users/mcci-catena","html_url":"https://github.com/mcci-catena","followers_url":"https://api.github.com/users/mcci-catena/followers","following_url":"https://api.github.com/users/mcci-catena/following{/other_user}","gists_url":"https://api.github.com/users/mcci-catena/gists{/gist_id}","starred_url":"https://api.github.com/users/mcci-catena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcci-catena/subscriptions","organizations_url":"https://api.github.com/users/mcci-catena/orgs","repos_url":"https://api.github.com/users/mcci-catena/repos","events_url":"https://api.github.com/users/mcci-catena/events{/privacy}","received_events_url":"https://api.github.com/users/mcci-catena/received_events","type":"Organization","site_admin":false},"repo":{"id":78951563,"name":"docker-ttn-dashboard","full_name":"mcci-catena/docker-ttn-dashboard","owner":{"login":"mcci-catena","id":23129382,"avatar_url":"https://avatars1.githubusercontent.com/u/23129382?v=4","gravatar_id":"","url":"https://api.github.com/users/mcci-catena","html_url":"https://github.com/mcci-catena","followers_url":"https://api.github.com/users/mcci-catena/followers","following_url":"https://api.github.com/users/mcci-catena/following{/other_user}","gists_url":"https://api.github.com/users/mcci-catena/gists{/gist_id}","starred_url":"https://api.github.com/users/mcci-catena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcci-catena/subscriptions","organizations_url":"https://api.github.com/users/mcci-catena/orgs","repos_url":"https://api.github.com/users/mcci-catena/repos","events_url":"https://api.github.com/users/mcci-catena/events{/privacy}","received_events_url":"https://api.github.com/users/mcci-catena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mcci-catena/docker-ttn-dashboard","description":"A complete setup for node-red + influxdb + grafana + ssl + let's encrypt using docker-compose.","fork":false,"url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard","forks_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/forks","keys_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/teams","hooks_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/hooks","issue_events_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/events","assignees_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/tags","blobs_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/languages","stargazers_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/stargazers","contributors_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/contributors","subscribers_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/subscribers","subscription_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/subscription","commits_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/merges","archive_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/downloads","issues_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/deployments","created_at":"2017-01-14T16:26:27Z","updated_at":"2017-09-19T07:04:17Z","pushed_at":"2017-09-19T08:32:59Z","git_url":"git://github.com/mcci-catena/docker-ttn-dashboard.git","ssh_url":"[email protected]:mcci-catena/docker-ttn-dashboard.git","clone_url":"https://github.com/mcci-catena/docker-ttn-dashboard.git","svn_url":"https://github.com/mcci-catena/docker-ttn-dashboard","homepage":"","size":372,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/10"},"html":{"href":"https://github.com/mcci-catena/docker-ttn-dashboard/pull/10"},"issue":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/issues/10"},"comments":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/mcci-catena/docker-ttn-dashboard/statuses/7b102c22c46bdd85517f481fdba4da831517c8a0"}},"author_association":"NONE"}} | {
"id": 78951563,
"name": "mcci-catena/docker-ttn-dashboard",
"url": "https://api.github.com/repos/mcci-catena/docker-ttn-dashboard"
} | {
"id": 19333103,
"login": "terrillmoore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19333103?",
"url": "https://api.github.com/users/terrillmoore"
} | {
"id": 23129382,
"login": "mcci-catena",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23129382?",
"url": "https://api.github.com/orgs/mcci-catena"
} | 2017-09-20T06:45:03 | 6612854403 | {"actor":{"display_login":"terrillmoore"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/comments/134563346","pull_request_review_id":57869321,"id":134563346,"diff_hunk":"@@ -612,6 +611,11 @@ protected void onActivityResult(int requestCode, int resultCode,\n return;\n }\n \n+ if (intent == null) {\n+ Timber.i(\"The intent has a null value for requestCode: \" + requestCode);","path":"collect_app/src/main/java/org/odk/collect/android/activities/FormEntryActivity.java","position":15,"original_position":15,"commit_id":"84c618b079f34b04055d22e986a31a85bf803ec4","original_commit_id":"84c618b079f34b04055d22e986a31a85bf803ec4","user":{"login":"lognaturel","id":967540,"avatar_url":"https://avatars3.githubusercontent.com/u/967540?v=4","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"body":"I'm curious to know what app causes this crash but I'm not sure that there's anything we can actually do about it if we know! I'm fine with either leaving it at `i` or using `w`.\r\n\r\nAs for moving to Crashlytics, I'd prefer we do it when the integration is more complete, it seems like it hasn't officially been migrated to being the crash log provider yet.","created_at":"2017-08-22T18:23:53Z","updated_at":"2017-08-22T18:23:53Z","html_url":"https://github.com/opendatakit/collect/pull/1365#discussion_r134563346","pull_request_url":"https://api.github.com/repos/opendatakit/collect/pulls/1365","_links":{"self":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/comments/134563346"},"html":{"href":"https://github.com/opendatakit/collect/pull/1365#discussion_r134563346"},"pull_request":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/1365"}}},"pull_request":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/1365","id":136932562,"html_url":"https://github.com/opendatakit/collect/pull/1365","diff_url":"https://github.com/opendatakit/collect/pull/1365.diff","patch_url":"https://github.com/opendatakit/collect/pull/1365.patch","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/1365","number":1365,"state":"open","locked":false,"title":"Attempt to invoke virtual method 'android.net.Uri android.content.Intent.getData()' on a null object reference","user":{"login":"grzesiek2010","id":3276264,"avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"body":"Closes #1364 \r\n\r\n#### What has been done to verify that this works as intended?\r\nI'm not able to reproduce the issue but I believe it's possible since our users might use lots of different camera apps etc.\r\n\r\n#### Why is this the best possible solution? Were any other approaches considered?\r\nI can't see any better solution, if the intent has a null value we can't do anything we can just handle that case.\r\n\r\n#### Are there any risks to merging this code? If so, what are they?\r\nIt's completely safe.","created_at":"2017-08-22T09:29:26Z","updated_at":"2017-08-22T18:23:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e0c571233e8f51c639d091994d45f0ba81a00af","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opendatakit/collect/pulls/1365/commits","review_comments_url":"https://api.github.com/repos/opendatakit/collect/pulls/1365/comments","review_comment_url":"https://api.github.com/repos/opendatakit/collect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/1365/comments","statuses_url":"https://api.github.com/repos/opendatakit/collect/statuses/84c618b079f34b04055d22e986a31a85bf803ec4","head":{"label":"grzesiek2010:COLLECT-1364","ref":"COLLECT-1364","sha":"84c618b079f34b04055d22e986a31a85bf803ec4","user":{"login":"grzesiek2010","id":3276264,"avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"repo":{"id":75389799,"name":"collect","full_name":"grzesiek2010/collect","owner":{"login":"grzesiek2010","id":3276264,"avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grzesiek2010/collect","description":"ODK Collect is an Android app for filling out forms. It's been used to collect millions of data points in challenging environments around the world. Contribute and make the world a better place! ✨🌍✨","fork":true,"url":"https://api.github.com/repos/grzesiek2010/collect","forks_url":"https://api.github.com/repos/grzesiek2010/collect/forks","keys_url":"https://api.github.com/repos/grzesiek2010/collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grzesiek2010/collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grzesiek2010/collect/teams","hooks_url":"https://api.github.com/repos/grzesiek2010/collect/hooks","issue_events_url":"https://api.github.com/repos/grzesiek2010/collect/issues/events{/number}","events_url":"https://api.github.com/repos/grzesiek2010/collect/events","assignees_url":"https://api.github.com/repos/grzesiek2010/collect/assignees{/user}","branches_url":"https://api.github.com/repos/grzesiek2010/collect/branches{/branch}","tags_url":"https://api.github.com/repos/grzesiek2010/collect/tags","blobs_url":"https://api.github.com/repos/grzesiek2010/collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grzesiek2010/collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grzesiek2010/collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/grzesiek2010/collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grzesiek2010/collect/statuses/{sha}","languages_url":"https://api.github.com/repos/grzesiek2010/collect/languages","stargazers_url":"https://api.github.com/repos/grzesiek2010/collect/stargazers","contributors_url":"https://api.github.com/repos/grzesiek2010/collect/contributors","subscribers_url":"https://api.github.com/repos/grzesiek2010/collect/subscribers","subscription_url":"https://api.github.com/repos/grzesiek2010/collect/subscription","commits_url":"https://api.github.com/repos/grzesiek2010/collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/grzesiek2010/collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/grzesiek2010/collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/grzesiek2010/collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/grzesiek2010/collect/contents/{+path}","compare_url":"https://api.github.com/repos/grzesiek2010/collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grzesiek2010/collect/merges","archive_url":"https://api.github.com/repos/grzesiek2010/collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grzesiek2010/collect/downloads","issues_url":"https://api.github.com/repos/grzesiek2010/collect/issues{/number}","pulls_url":"https://api.github.com/repos/grzesiek2010/collect/pulls{/number}","milestones_url":"https://api.github.com/repos/grzesiek2010/collect/milestones{/number}","notifications_url":"https://api.github.com/repos/grzesiek2010/collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grzesiek2010/collect/labels{/name}","releases_url":"https://api.github.com/repos/grzesiek2010/collect/releases{/id}","deployments_url":"https://api.github.com/repos/grzesiek2010/collect/deployments","created_at":"2016-12-02T11:26:41Z","updated_at":"2016-12-02T11:26:43Z","pushed_at":"2017-08-22T10:43:49Z","git_url":"git://github.com/grzesiek2010/collect.git","ssh_url":"[email protected]:grzesiek2010/collect.git","clone_url":"https://github.com/grzesiek2010/collect.git","svn_url":"https://github.com/grzesiek2010/collect","homepage":"https://github.com/opendatakit/collect","size":36037,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opendatakit:master","ref":"master","sha":"55d9539c56114f254c207571471ecb08341b005b","user":{"login":"opendatakit","id":6222985,"avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"repo":{"id":40213809,"name":"collect","full_name":"opendatakit/collect","owner":{"login":"opendatakit","id":6222985,"avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opendatakit/collect","description":"ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨","fork":false,"url":"https://api.github.com/repos/opendatakit/collect","forks_url":"https://api.github.com/repos/opendatakit/collect/forks","keys_url":"https://api.github.com/repos/opendatakit/collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opendatakit/collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opendatakit/collect/teams","hooks_url":"https://api.github.com/repos/opendatakit/collect/hooks","issue_events_url":"https://api.github.com/repos/opendatakit/collect/issues/events{/number}","events_url":"https://api.github.com/repos/opendatakit/collect/events","assignees_url":"https://api.github.com/repos/opendatakit/collect/assignees{/user}","branches_url":"https://api.github.com/repos/opendatakit/collect/branches{/branch}","tags_url":"https://api.github.com/repos/opendatakit/collect/tags","blobs_url":"https://api.github.com/repos/opendatakit/collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opendatakit/collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opendatakit/collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/opendatakit/collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opendatakit/collect/statuses/{sha}","languages_url":"https://api.github.com/repos/opendatakit/collect/languages","stargazers_url":"https://api.github.com/repos/opendatakit/collect/stargazers","contributors_url":"https://api.github.com/repos/opendatakit/collect/contributors","subscribers_url":"https://api.github.com/repos/opendatakit/collect/subscribers","subscription_url":"https://api.github.com/repos/opendatakit/collect/subscription","commits_url":"https://api.github.com/repos/opendatakit/collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/opendatakit/collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/opendatakit/collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/opendatakit/collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/opendatakit/collect/contents/{+path}","compare_url":"https://api.github.com/repos/opendatakit/collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opendatakit/collect/merges","archive_url":"https://api.github.com/repos/opendatakit/collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opendatakit/collect/downloads","issues_url":"https://api.github.com/repos/opendatakit/collect/issues{/number}","pulls_url":"https://api.github.com/repos/opendatakit/collect/pulls{/number}","milestones_url":"https://api.github.com/repos/opendatakit/collect/milestones{/number}","notifications_url":"https://api.github.com/repos/opendatakit/collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opendatakit/collect/labels{/name}","releases_url":"https://api.github.com/repos/opendatakit/collect/releases{/id}","deployments_url":"https://api.github.com/repos/opendatakit/collect/deployments","created_at":"2015-08-04T23:21:33Z","updated_at":"2017-08-21T19:17:48Z","pushed_at":"2017-08-22T10:43:50Z","git_url":"git://github.com/opendatakit/collect.git","ssh_url":"[email protected]:opendatakit/collect.git","clone_url":"https://github.com/opendatakit/collect.git","svn_url":"https://github.com/opendatakit/collect","homepage":"https://github.com/opendatakit/collect","size":35299,"stargazers_count":102,"watchers_count":102,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":373,"mirror_url":null,"open_issues_count":225,"forks":373,"open_issues":225,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/1365"},"html":{"href":"https://github.com/opendatakit/collect/pull/1365"},"issue":{"href":"https://api.github.com/repos/opendatakit/collect/issues/1365"},"comments":{"href":"https://api.github.com/repos/opendatakit/collect/issues/1365/comments"},"review_comments":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/1365/comments"},"review_comment":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/1365/commits"},"statuses":{"href":"https://api.github.com/repos/opendatakit/collect/statuses/84c618b079f34b04055d22e986a31a85bf803ec4"}}}} | {
"id": 40213809,
"name": "opendatakit/collect",
"url": "https://api.github.com/repos/opendatakit/collect"
} | {
"id": 967540,
"login": "lognaturel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/967540?",
"url": "https://api.github.com/users/lognaturel"
} | {
"id": 6222985,
"login": "opendatakit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6222985?",
"url": "https://api.github.com/orgs/opendatakit"
} | 2017-08-22T18:23:53 | 6498683279 | {"actor":{"display_login":"lognaturel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/comments/95847706","pull_request_review_id":16416421,"id":95847706,"diff_hunk":"@@ -12,8 +12,9 @@ ENV DB_PORT 5432\n ENV DB_NAME pega\n \n # Provide variables for the JDBC connection string\n-ENV JDBC_URL \"jdbc:postgresql://${DB_HOST}:${DB_PORT}/${DB_NAME}\"\n ENV JDBC_CLASS org.postgresql.Driver\n+ENV JDBC_DB_TYPE postgresql","path":"Dockerfile","position":6,"original_position":6,"commit_id":"a84bcc54d40080b25b70e5cb72a965447806b594","original_commit_id":"a84bcc54d40080b25b70e5cb72a965447806b594","user":{"login":"cdancy","id":7871459,"avatar_url":"https://avatars.githubusercontent.com/u/7871459?v=3","gravatar_id":"","url":"https://api.github.com/users/cdancy","html_url":"https://github.com/cdancy","followers_url":"https://api.github.com/users/cdancy/followers","following_url":"https://api.github.com/users/cdancy/following{/other_user}","gists_url":"https://api.github.com/users/cdancy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdancy/subscriptions","organizations_url":"https://api.github.com/users/cdancy/orgs","repos_url":"https://api.github.com/users/cdancy/repos","events_url":"https://api.github.com/users/cdancy/events{/privacy}","received_events_url":"https://api.github.com/users/cdancy/received_events","type":"User","site_admin":false},"body":"Maybe remove `JDBC_DB_TYPE` as well and just parse it from the passed `JDBC_URL`? That's what we do here in our `gradle-prpc-plugin` and would remove one more variable to track.","created_at":"2017-01-12T17:57:17Z","updated_at":"2017-01-12T17:57:17Z","html_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready/pull/4#discussion_r95847706","pull_request_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/comments/95847706"},"html":{"href":"https://github.com/pegasystems/docker-pega7-tomcat-ready/pull/4#discussion_r95847706"},"pull_request":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/4","id":101306426,"html_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready/pull/4","diff_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready/pull/4.diff","patch_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready/pull/4.patch","issue_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues/4","number":4,"state":"open","locked":false,"title":"Fixed prsysmgmt issue with connection via JMX and updated docs","user":{"login":"petehayes","id":494275,"avatar_url":"https://avatars.githubusercontent.com/u/494275?v=3","gravatar_id":"","url":"https://api.github.com/users/petehayes","html_url":"https://github.com/petehayes","followers_url":"https://api.github.com/users/petehayes/followers","following_url":"https://api.github.com/users/petehayes/following{/other_user}","gists_url":"https://api.github.com/users/petehayes/gists{/gist_id}","starred_url":"https://api.github.com/users/petehayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petehayes/subscriptions","organizations_url":"https://api.github.com/users/petehayes/orgs","repos_url":"https://api.github.com/users/petehayes/repos","events_url":"https://api.github.com/users/petehayes/events{/privacy}","received_events_url":"https://api.github.com/users/petehayes/received_events","type":"User","site_admin":false},"body":"I fixed the issue related to JMX and updated the docs a bit.","created_at":"2017-01-12T17:39:26Z","updated_at":"2017-01-12T17:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1bcf66fac7223dc929c5f6ab03767a5e69d1860","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/4/commits","review_comments_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/4/comments","review_comment_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues/4/comments","statuses_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/statuses/a84bcc54d40080b25b70e5cb72a965447806b594","head":{"label":"pegasystems:fix-prsysmgmt","ref":"fix-prsysmgmt","sha":"a84bcc54d40080b25b70e5cb72a965447806b594","user":{"login":"pegasystems","id":20665642,"avatar_url":"https://avatars.githubusercontent.com/u/20665642?v=3","gravatar_id":"","url":"https://api.github.com/users/pegasystems","html_url":"https://github.com/pegasystems","followers_url":"https://api.github.com/users/pegasystems/followers","following_url":"https://api.github.com/users/pegasystems/following{/other_user}","gists_url":"https://api.github.com/users/pegasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/pegasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pegasystems/subscriptions","organizations_url":"https://api.github.com/users/pegasystems/orgs","repos_url":"https://api.github.com/users/pegasystems/repos","events_url":"https://api.github.com/users/pegasystems/events{/privacy}","received_events_url":"https://api.github.com/users/pegasystems/received_events","type":"Organization","site_admin":false},"repo":{"id":76687472,"name":"docker-pega7-tomcat-ready","full_name":"pegasystems/docker-pega7-tomcat-ready","owner":{"login":"pegasystems","id":20665642,"avatar_url":"https://avatars.githubusercontent.com/u/20665642?v=3","gravatar_id":"","url":"https://api.github.com/users/pegasystems","html_url":"https://github.com/pegasystems","followers_url":"https://api.github.com/users/pegasystems/followers","following_url":"https://api.github.com/users/pegasystems/following{/other_user}","gists_url":"https://api.github.com/users/pegasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/pegasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pegasystems/subscriptions","organizations_url":"https://api.github.com/users/pegasystems/orgs","repos_url":"https://api.github.com/users/pegasystems/repos","events_url":"https://api.github.com/users/pegasystems/events{/privacy}","received_events_url":"https://api.github.com/users/pegasystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready","description":"Docker project for generating a tomcat docker image for Pega7","fork":false,"url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready","forks_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/forks","keys_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/teams","hooks_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/hooks","issue_events_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues/events{/number}","events_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/events","assignees_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/assignees{/user}","branches_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/branches{/branch}","tags_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/tags","blobs_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/refs{/sha}","trees_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/statuses/{sha}","languages_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/languages","stargazers_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/stargazers","contributors_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/contributors","subscribers_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/subscribers","subscription_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/subscription","commits_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/commits{/sha}","git_commits_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/commits{/sha}","comments_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/comments{/number}","issue_comment_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues/comments{/number}","contents_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/contents/{+path}","compare_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/merges","archive_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/downloads","issues_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues{/number}","pulls_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls{/number}","milestones_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/milestones{/number}","notifications_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/labels{/name}","releases_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/releases{/id}","deployments_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/deployments","created_at":"2016-12-16T21:41:06Z","updated_at":"2016-12-20T21:25:03Z","pushed_at":"2017-01-12T17:46:33Z","git_url":"git://github.com/pegasystems/docker-pega7-tomcat-ready.git","ssh_url":"[email protected]:pegasystems/docker-pega7-tomcat-ready.git","clone_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready.git","svn_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready","homepage":null,"size":16,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"pegasystems:master","ref":"master","sha":"efd70a8b82d515057644d2c4ef4d7f92e3dc2e58","user":{"login":"pegasystems","id":20665642,"avatar_url":"https://avatars.githubusercontent.com/u/20665642?v=3","gravatar_id":"","url":"https://api.github.com/users/pegasystems","html_url":"https://github.com/pegasystems","followers_url":"https://api.github.com/users/pegasystems/followers","following_url":"https://api.github.com/users/pegasystems/following{/other_user}","gists_url":"https://api.github.com/users/pegasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/pegasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pegasystems/subscriptions","organizations_url":"https://api.github.com/users/pegasystems/orgs","repos_url":"https://api.github.com/users/pegasystems/repos","events_url":"https://api.github.com/users/pegasystems/events{/privacy}","received_events_url":"https://api.github.com/users/pegasystems/received_events","type":"Organization","site_admin":false},"repo":{"id":76687472,"name":"docker-pega7-tomcat-ready","full_name":"pegasystems/docker-pega7-tomcat-ready","owner":{"login":"pegasystems","id":20665642,"avatar_url":"https://avatars.githubusercontent.com/u/20665642?v=3","gravatar_id":"","url":"https://api.github.com/users/pegasystems","html_url":"https://github.com/pegasystems","followers_url":"https://api.github.com/users/pegasystems/followers","following_url":"https://api.github.com/users/pegasystems/following{/other_user}","gists_url":"https://api.github.com/users/pegasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/pegasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pegasystems/subscriptions","organizations_url":"https://api.github.com/users/pegasystems/orgs","repos_url":"https://api.github.com/users/pegasystems/repos","events_url":"https://api.github.com/users/pegasystems/events{/privacy}","received_events_url":"https://api.github.com/users/pegasystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready","description":"Docker project for generating a tomcat docker image for Pega7","fork":false,"url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready","forks_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/forks","keys_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/teams","hooks_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/hooks","issue_events_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues/events{/number}","events_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/events","assignees_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/assignees{/user}","branches_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/branches{/branch}","tags_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/tags","blobs_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/refs{/sha}","trees_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/statuses/{sha}","languages_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/languages","stargazers_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/stargazers","contributors_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/contributors","subscribers_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/subscribers","subscription_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/subscription","commits_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/commits{/sha}","git_commits_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/git/commits{/sha}","comments_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/comments{/number}","issue_comment_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues/comments{/number}","contents_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/contents/{+path}","compare_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/merges","archive_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/downloads","issues_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues{/number}","pulls_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls{/number}","milestones_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/milestones{/number}","notifications_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/labels{/name}","releases_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/releases{/id}","deployments_url":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/deployments","created_at":"2016-12-16T21:41:06Z","updated_at":"2016-12-20T21:25:03Z","pushed_at":"2017-01-12T17:46:33Z","git_url":"git://github.com/pegasystems/docker-pega7-tomcat-ready.git","ssh_url":"[email protected]:pegasystems/docker-pega7-tomcat-ready.git","clone_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready.git","svn_url":"https://github.com/pegasystems/docker-pega7-tomcat-ready","homepage":null,"size":16,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/4"},"html":{"href":"https://github.com/pegasystems/docker-pega7-tomcat-ready/pull/4"},"issue":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues/4"},"comments":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready/statuses/a84bcc54d40080b25b70e5cb72a965447806b594"}}}} | {
"id": 76687472,
"name": "pegasystems/docker-pega7-tomcat-ready",
"url": "https://api.github.com/repos/pegasystems/docker-pega7-tomcat-ready"
} | {
"id": 7871459,
"login": "cdancy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7871459?",
"url": "https://api.github.com/users/cdancy"
} | {
"id": 20665642,
"login": "pegasystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20665642?",
"url": "https://api.github.com/orgs/pegasystems"
} | 2017-01-12T17:57:17 | 5144197533 | {"actor":{"display_login":"cdancy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/comments/137241275","pull_request_review_id":60880764,"id":137241275,"diff_hunk":"@@ -144,10 +144,25 @@ function plugin_init_genericobject() {\n );\n \n // Display a menu entry ?\n- $PLUGIN_HOOKS['menu_toadd']['genericobject'] = array(\n- 'config' => 'PluginGenericobjectType',\n- 'assets' => 'PluginGenericobjectObject'\n- );\n+ if (Session::haveRight('plugin_genericobject_types', READ)) {\n+ $PLUGIN_HOOKS['menu_toadd']['genericobject']['config'] = 'PluginGenericobjectType';\n+ }\n+\n+ $object = false;\n+ foreach ($DB->request('glpi_profilerights',","path":"setup.php","position":13,"original_position":13,"commit_id":"963143a814c864d09309929938e50c5f77e0369f","original_commit_id":"963143a814c864d09309929938e50c5f77e0369f","user":{"login":"trasher","id":224733,"avatar_url":"https://avatars2.githubusercontent.com/u/224733?v=4","gravatar_id":"","url":"https://api.github.com/users/trasher","html_url":"https://github.com/trasher","followers_url":"https://api.github.com/users/trasher/followers","following_url":"https://api.github.com/users/trasher/following{/other_user}","gists_url":"https://api.github.com/users/trasher/gists{/gist_id}","starred_url":"https://api.github.com/users/trasher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trasher/subscriptions","organizations_url":"https://api.github.com/users/trasher/orgs","repos_url":"https://api.github.com/users/trasher/repos","events_url":"https://api.github.com/users/trasher/events{/privacy}","received_events_url":"https://api.github.com/users/trasher/received_events","type":"User","site_admin":false},"body":"What about adding `right > 0`, do a count on it in the query and rely on that count? That would prevent to loop if not necessary.","created_at":"2017-09-06T11:32:25Z","updated_at":"2017-09-06T11:32:40Z","html_url":"https://github.com/pluginsGLPI/genericobject/pull/142#discussion_r137241275","pull_request_url":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/142","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/comments/137241275"},"html":{"href":"https://github.com/pluginsGLPI/genericobject/pull/142#discussion_r137241275"},"pull_request":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/142","id":128528589,"html_url":"https://github.com/pluginsGLPI/genericobject/pull/142","diff_url":"https://github.com/pluginsGLPI/genericobject/pull/142.diff","patch_url":"https://github.com/pluginsGLPI/genericobject/pull/142.patch","issue_url":"https://api.github.com/repos/pluginsGLPI/genericobject/issues/142","number":142,"state":"open","locked":false,"title":"Display assets menu only if rights on an object #141","user":{"login":"yllen","id":12936722,"avatar_url":"https://avatars3.githubusercontent.com/u/12936722?v=4","gravatar_id":"","url":"https://api.github.com/users/yllen","html_url":"https://github.com/yllen","followers_url":"https://api.github.com/users/yllen/followers","following_url":"https://api.github.com/users/yllen/following{/other_user}","gists_url":"https://api.github.com/users/yllen/gists{/gist_id}","starred_url":"https://api.github.com/users/yllen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yllen/subscriptions","organizations_url":"https://api.github.com/users/yllen/orgs","repos_url":"https://api.github.com/users/yllen/repos","events_url":"https://api.github.com/users/yllen/events{/privacy}","received_events_url":"https://api.github.com/users/yllen/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-02T17:53:25Z","updated_at":"2017-09-06T11:32:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bf0ecc2891cd20a07a9046ed55f4fe6a2108775","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/142/commits","review_comments_url":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/142/comments","review_comment_url":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pluginsGLPI/genericobject/issues/142/comments","statuses_url":"https://api.github.com/repos/pluginsGLPI/genericobject/statuses/963143a814c864d09309929938e50c5f77e0369f","head":{"label":"yllen:patch-2","ref":"patch-2","sha":"963143a814c864d09309929938e50c5f77e0369f","user":{"login":"yllen","id":12936722,"avatar_url":"https://avatars3.githubusercontent.com/u/12936722?v=4","gravatar_id":"","url":"https://api.github.com/users/yllen","html_url":"https://github.com/yllen","followers_url":"https://api.github.com/users/yllen/followers","following_url":"https://api.github.com/users/yllen/following{/other_user}","gists_url":"https://api.github.com/users/yllen/gists{/gist_id}","starred_url":"https://api.github.com/users/yllen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yllen/subscriptions","organizations_url":"https://api.github.com/users/yllen/orgs","repos_url":"https://api.github.com/users/yllen/repos","events_url":"https://api.github.com/users/yllen/events{/privacy}","received_events_url":"https://api.github.com/users/yllen/received_events","type":"User","site_admin":false},"repo":{"id":96034456,"name":"genericobject","full_name":"yllen/genericobject","owner":{"login":"yllen","id":12936722,"avatar_url":"https://avatars3.githubusercontent.com/u/12936722?v=4","gravatar_id":"","url":"https://api.github.com/users/yllen","html_url":"https://github.com/yllen","followers_url":"https://api.github.com/users/yllen/followers","following_url":"https://api.github.com/users/yllen/following{/other_user}","gists_url":"https://api.github.com/users/yllen/gists{/gist_id}","starred_url":"https://api.github.com/users/yllen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yllen/subscriptions","organizations_url":"https://api.github.com/users/yllen/orgs","repos_url":"https://api.github.com/users/yllen/repos","events_url":"https://api.github.com/users/yllen/events{/privacy}","received_events_url":"https://api.github.com/users/yllen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yllen/genericobject","description":"Genericobject object plugin","fork":true,"url":"https://api.github.com/repos/yllen/genericobject","forks_url":"https://api.github.com/repos/yllen/genericobject/forks","keys_url":"https://api.github.com/repos/yllen/genericobject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yllen/genericobject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yllen/genericobject/teams","hooks_url":"https://api.github.com/repos/yllen/genericobject/hooks","issue_events_url":"https://api.github.com/repos/yllen/genericobject/issues/events{/number}","events_url":"https://api.github.com/repos/yllen/genericobject/events","assignees_url":"https://api.github.com/repos/yllen/genericobject/assignees{/user}","branches_url":"https://api.github.com/repos/yllen/genericobject/branches{/branch}","tags_url":"https://api.github.com/repos/yllen/genericobject/tags","blobs_url":"https://api.github.com/repos/yllen/genericobject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yllen/genericobject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yllen/genericobject/git/refs{/sha}","trees_url":"https://api.github.com/repos/yllen/genericobject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yllen/genericobject/statuses/{sha}","languages_url":"https://api.github.com/repos/yllen/genericobject/languages","stargazers_url":"https://api.github.com/repos/yllen/genericobject/stargazers","contributors_url":"https://api.github.com/repos/yllen/genericobject/contributors","subscribers_url":"https://api.github.com/repos/yllen/genericobject/subscribers","subscription_url":"https://api.github.com/repos/yllen/genericobject/subscription","commits_url":"https://api.github.com/repos/yllen/genericobject/commits{/sha}","git_commits_url":"https://api.github.com/repos/yllen/genericobject/git/commits{/sha}","comments_url":"https://api.github.com/repos/yllen/genericobject/comments{/number}","issue_comment_url":"https://api.github.com/repos/yllen/genericobject/issues/comments{/number}","contents_url":"https://api.github.com/repos/yllen/genericobject/contents/{+path}","compare_url":"https://api.github.com/repos/yllen/genericobject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yllen/genericobject/merges","archive_url":"https://api.github.com/repos/yllen/genericobject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yllen/genericobject/downloads","issues_url":"https://api.github.com/repos/yllen/genericobject/issues{/number}","pulls_url":"https://api.github.com/repos/yllen/genericobject/pulls{/number}","milestones_url":"https://api.github.com/repos/yllen/genericobject/milestones{/number}","notifications_url":"https://api.github.com/repos/yllen/genericobject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yllen/genericobject/labels{/name}","releases_url":"https://api.github.com/repos/yllen/genericobject/releases{/id}","deployments_url":"https://api.github.com/repos/yllen/genericobject/deployments","created_at":"2017-07-02T16:08:42Z","updated_at":"2017-07-02T16:08:44Z","pushed_at":"2017-07-02T18:11:57Z","git_url":"git://github.com/yllen/genericobject.git","ssh_url":"[email protected]:yllen/genericobject.git","clone_url":"https://github.com/yllen/genericobject.git","svn_url":"https://github.com/yllen/genericobject","homepage":"http://glpi-plugins.rtfd.io/en/latest/genericobject/index.html","size":854,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pluginsGLPI:develop","ref":"develop","sha":"ab33d74972c8b82d824e1e5df4c8cf074fde9b5f","user":{"login":"pluginsGLPI","id":10156352,"avatar_url":"https://avatars3.githubusercontent.com/u/10156352?v=4","gravatar_id":"","url":"https://api.github.com/users/pluginsGLPI","html_url":"https://github.com/pluginsGLPI","followers_url":"https://api.github.com/users/pluginsGLPI/followers","following_url":"https://api.github.com/users/pluginsGLPI/following{/other_user}","gists_url":"https://api.github.com/users/pluginsGLPI/gists{/gist_id}","starred_url":"https://api.github.com/users/pluginsGLPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluginsGLPI/subscriptions","organizations_url":"https://api.github.com/users/pluginsGLPI/orgs","repos_url":"https://api.github.com/users/pluginsGLPI/repos","events_url":"https://api.github.com/users/pluginsGLPI/events{/privacy}","received_events_url":"https://api.github.com/users/pluginsGLPI/received_events","type":"Organization","site_admin":false},"repo":{"id":19499100,"name":"genericobject","full_name":"pluginsGLPI/genericobject","owner":{"login":"pluginsGLPI","id":10156352,"avatar_url":"https://avatars3.githubusercontent.com/u/10156352?v=4","gravatar_id":"","url":"https://api.github.com/users/pluginsGLPI","html_url":"https://github.com/pluginsGLPI","followers_url":"https://api.github.com/users/pluginsGLPI/followers","following_url":"https://api.github.com/users/pluginsGLPI/following{/other_user}","gists_url":"https://api.github.com/users/pluginsGLPI/gists{/gist_id}","starred_url":"https://api.github.com/users/pluginsGLPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluginsGLPI/subscriptions","organizations_url":"https://api.github.com/users/pluginsGLPI/orgs","repos_url":"https://api.github.com/users/pluginsGLPI/repos","events_url":"https://api.github.com/users/pluginsGLPI/events{/privacy}","received_events_url":"https://api.github.com/users/pluginsGLPI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pluginsGLPI/genericobject","description":"Genericobject object plugin","fork":false,"url":"https://api.github.com/repos/pluginsGLPI/genericobject","forks_url":"https://api.github.com/repos/pluginsGLPI/genericobject/forks","keys_url":"https://api.github.com/repos/pluginsGLPI/genericobject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pluginsGLPI/genericobject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pluginsGLPI/genericobject/teams","hooks_url":"https://api.github.com/repos/pluginsGLPI/genericobject/hooks","issue_events_url":"https://api.github.com/repos/pluginsGLPI/genericobject/issues/events{/number}","events_url":"https://api.github.com/repos/pluginsGLPI/genericobject/events","assignees_url":"https://api.github.com/repos/pluginsGLPI/genericobject/assignees{/user}","branches_url":"https://api.github.com/repos/pluginsGLPI/genericobject/branches{/branch}","tags_url":"https://api.github.com/repos/pluginsGLPI/genericobject/tags","blobs_url":"https://api.github.com/repos/pluginsGLPI/genericobject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pluginsGLPI/genericobject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pluginsGLPI/genericobject/git/refs{/sha}","trees_url":"https://api.github.com/repos/pluginsGLPI/genericobject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pluginsGLPI/genericobject/statuses/{sha}","languages_url":"https://api.github.com/repos/pluginsGLPI/genericobject/languages","stargazers_url":"https://api.github.com/repos/pluginsGLPI/genericobject/stargazers","contributors_url":"https://api.github.com/repos/pluginsGLPI/genericobject/contributors","subscribers_url":"https://api.github.com/repos/pluginsGLPI/genericobject/subscribers","subscription_url":"https://api.github.com/repos/pluginsGLPI/genericobject/subscription","commits_url":"https://api.github.com/repos/pluginsGLPI/genericobject/commits{/sha}","git_commits_url":"https://api.github.com/repos/pluginsGLPI/genericobject/git/commits{/sha}","comments_url":"https://api.github.com/repos/pluginsGLPI/genericobject/comments{/number}","issue_comment_url":"https://api.github.com/repos/pluginsGLPI/genericobject/issues/comments{/number}","contents_url":"https://api.github.com/repos/pluginsGLPI/genericobject/contents/{+path}","compare_url":"https://api.github.com/repos/pluginsGLPI/genericobject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pluginsGLPI/genericobject/merges","archive_url":"https://api.github.com/repos/pluginsGLPI/genericobject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pluginsGLPI/genericobject/downloads","issues_url":"https://api.github.com/repos/pluginsGLPI/genericobject/issues{/number}","pulls_url":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls{/number}","milestones_url":"https://api.github.com/repos/pluginsGLPI/genericobject/milestones{/number}","notifications_url":"https://api.github.com/repos/pluginsGLPI/genericobject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pluginsGLPI/genericobject/labels{/name}","releases_url":"https://api.github.com/repos/pluginsGLPI/genericobject/releases{/id}","deployments_url":"https://api.github.com/repos/pluginsGLPI/genericobject/deployments","created_at":"2014-05-06T15:14:57Z","updated_at":"2017-07-30T00:36:14Z","pushed_at":"2017-09-06T10:55:54Z","git_url":"git://github.com/pluginsGLPI/genericobject.git","ssh_url":"[email protected]:pluginsGLPI/genericobject.git","clone_url":"https://github.com/pluginsGLPI/genericobject.git","svn_url":"https://github.com/pluginsGLPI/genericobject","homepage":"http://glpi-plugins.rtfd.io/en/latest/genericobject/index.html","size":843,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":48,"forks":25,"open_issues":48,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/142"},"html":{"href":"https://github.com/pluginsGLPI/genericobject/pull/142"},"issue":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/issues/142"},"comments":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/pluginsGLPI/genericobject/statuses/963143a814c864d09309929938e50c5f77e0369f"}},"author_association":"NONE"}} | {
"id": 19499100,
"name": "pluginsGLPI/genericobject",
"url": "https://api.github.com/repos/pluginsGLPI/genericobject"
} | {
"id": 224733,
"login": "trasher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/224733?",
"url": "https://api.github.com/users/trasher"
} | {
"id": 10156352,
"login": "pluginsGLPI",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10156352?",
"url": "https://api.github.com/orgs/pluginsGLPI"
} | 2017-09-06T11:32:25 | 6555733756 | {"actor":{"display_login":"trasher"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/102894607","pull_request_review_id":23664503,"id":102894607,"diff_hunk":"@@ -177,8 +176,6 @@ def test_integration_single_task(self):\n 2 * NUM_CLUSTER_NODES + 1)\n \n num_return_vals = [0, 1, 2, 3, 5, 10]\n- # There should not be anything else in Redis yet.\n- self.assertEqual(len(self.redis_client.keys(\"*\")), 2 * NUM_CLUSTER_NODES + 1)","path":"python/global_scheduler/test/test.py","position":48,"original_position":48,"commit_id":"ff4e61ec352bbe9b81c428bbdfa768773c9e176a","original_commit_id":"ff4e61ec352bbe9b81c428bbdfa768773c9e176a","user":{"login":"atumanov","id":1316372,"avatar_url":"https://avatars.githubusercontent.com/u/1316372?v=3","gravatar_id":"","url":"https://api.github.com/users/atumanov","html_url":"https://github.com/atumanov","followers_url":"https://api.github.com/users/atumanov/followers","following_url":"https://api.github.com/users/atumanov/following{/other_user}","gists_url":"https://api.github.com/users/atumanov/gists{/gist_id}","starred_url":"https://api.github.com/users/atumanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atumanov/subscriptions","organizations_url":"https://api.github.com/users/atumanov/orgs","repos_url":"https://api.github.com/users/atumanov/repos","events_url":"https://api.github.com/users/atumanov/events{/privacy}","received_events_url":"https://api.github.com/users/atumanov/received_events","type":"User","site_admin":false},"body":"why are you removing this assert?","created_at":"2017-02-24T08:04:03Z","updated_at":"2017-02-24T08:10:22Z","html_url":"https://github.com/ray-project/ray/pull/314#discussion_r102894607","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/314","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/102894607"},"html":{"href":"https://github.com/ray-project/ray/pull/314#discussion_r102894607"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/314","id":107778060,"html_url":"https://github.com/ray-project/ray/pull/314","diff_url":"https://github.com/ray-project/ray/pull/314.diff","patch_url":"https://github.com/ray-project/ray/pull/314.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/314","number":314,"state":"open","locked":false,"title":"Fix global scheduler test failure.","user":{"login":"robertnishihara","id":249517,"avatar_url":"https://avatars.githubusercontent.com/u/249517?v=3","gravatar_id":"","url":"https://api.github.com/users/robertnishihara","html_url":"https://github.com/robertnishihara","followers_url":"https://api.github.com/users/robertnishihara/followers","following_url":"https://api.github.com/users/robertnishihara/following{/other_user}","gists_url":"https://api.github.com/users/robertnishihara/gists{/gist_id}","starred_url":"https://api.github.com/users/robertnishihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertnishihara/subscriptions","organizations_url":"https://api.github.com/users/robertnishihara/orgs","repos_url":"https://api.github.com/users/robertnishihara/repos","events_url":"https://api.github.com/users/robertnishihara/events{/privacy}","received_events_url":"https://api.github.com/users/robertnishihara/received_events","type":"User","site_admin":false},"body":"Note that the change in the way we kill the processes in `tearDown` actually seems to make a difference. On my laptop the previous way does not actually kill the processes.","created_at":"2017-02-24T07:05:19Z","updated_at":"2017-02-24T08:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4700d9fba95f414663ecc92fb21081b6cf2acb63","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/314/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/314/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/314/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/ff4e61ec352bbe9b81c428bbdfa768773c9e176a","head":{"label":"robertnishihara:globalschedulertest","ref":"globalschedulertest","sha":"ff4e61ec352bbe9b81c428bbdfa768773c9e176a","user":{"login":"robertnishihara","id":249517,"avatar_url":"https://avatars.githubusercontent.com/u/249517?v=3","gravatar_id":"","url":"https://api.github.com/users/robertnishihara","html_url":"https://github.com/robertnishihara","followers_url":"https://api.github.com/users/robertnishihara/followers","following_url":"https://api.github.com/users/robertnishihara/following{/other_user}","gists_url":"https://api.github.com/users/robertnishihara/gists{/gist_id}","starred_url":"https://api.github.com/users/robertnishihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertnishihara/subscriptions","organizations_url":"https://api.github.com/users/robertnishihara/orgs","repos_url":"https://api.github.com/users/robertnishihara/repos","events_url":"https://api.github.com/users/robertnishihara/events{/privacy}","received_events_url":"https://api.github.com/users/robertnishihara/received_events","type":"User","site_admin":false},"repo":{"id":77168352,"name":"ray","full_name":"robertnishihara/ray","owner":{"login":"robertnishihara","id":249517,"avatar_url":"https://avatars.githubusercontent.com/u/249517?v=3","gravatar_id":"","url":"https://api.github.com/users/robertnishihara","html_url":"https://github.com/robertnishihara","followers_url":"https://api.github.com/users/robertnishihara/followers","following_url":"https://api.github.com/users/robertnishihara/following{/other_user}","gists_url":"https://api.github.com/users/robertnishihara/gists{/gist_id}","starred_url":"https://api.github.com/users/robertnishihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertnishihara/subscriptions","organizations_url":"https://api.github.com/users/robertnishihara/orgs","repos_url":"https://api.github.com/users/robertnishihara/repos","events_url":"https://api.github.com/users/robertnishihara/events{/privacy}","received_events_url":"https://api.github.com/users/robertnishihara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertnishihara/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/robertnishihara/ray","forks_url":"https://api.github.com/repos/robertnishihara/ray/forks","keys_url":"https://api.github.com/repos/robertnishihara/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertnishihara/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertnishihara/ray/teams","hooks_url":"https://api.github.com/repos/robertnishihara/ray/hooks","issue_events_url":"https://api.github.com/repos/robertnishihara/ray/issues/events{/number}","events_url":"https://api.github.com/repos/robertnishihara/ray/events","assignees_url":"https://api.github.com/repos/robertnishihara/ray/assignees{/user}","branches_url":"https://api.github.com/repos/robertnishihara/ray/branches{/branch}","tags_url":"https://api.github.com/repos/robertnishihara/ray/tags","blobs_url":"https://api.github.com/repos/robertnishihara/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertnishihara/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertnishihara/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertnishihara/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertnishihara/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/robertnishihara/ray/languages","stargazers_url":"https://api.github.com/repos/robertnishihara/ray/stargazers","contributors_url":"https://api.github.com/repos/robertnishihara/ray/contributors","subscribers_url":"https://api.github.com/repos/robertnishihara/ray/subscribers","subscription_url":"https://api.github.com/repos/robertnishihara/ray/subscription","commits_url":"https://api.github.com/repos/robertnishihara/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertnishihara/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertnishihara/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertnishihara/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertnishihara/ray/contents/{+path}","compare_url":"https://api.github.com/repos/robertnishihara/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertnishihara/ray/merges","archive_url":"https://api.github.com/repos/robertnishihara/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertnishihara/ray/downloads","issues_url":"https://api.github.com/repos/robertnishihara/ray/issues{/number}","pulls_url":"https://api.github.com/repos/robertnishihara/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/robertnishihara/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/robertnishihara/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertnishihara/ray/labels{/name}","releases_url":"https://api.github.com/repos/robertnishihara/ray/releases{/id}","deployments_url":"https://api.github.com/repos/robertnishihara/ray/deployments","created_at":"2016-12-22T18:50:20Z","updated_at":"2016-12-22T18:50:23Z","pushed_at":"2017-02-24T07:04:18Z","git_url":"git://github.com/robertnishihara/ray.git","ssh_url":"[email protected]:robertnishihara/ray.git","clone_url":"https://github.com/robertnishihara/ray.git","svn_url":"https://github.com/robertnishihara/ray","homepage":"","size":3363,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"7f5be9668359a671d5a6b9fa5ba070b1dbe578a1","user":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars.githubusercontent.com/u/22125274?v=3","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars.githubusercontent.com/u/22125274?v=3","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"An experimental distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2017-02-22T13:40:13Z","pushed_at":"2017-02-24T07:05:20Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"[email protected]:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":3259,"stargazers_count":41,"watchers_count":41,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":41,"forks":22,"open_issues":41,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/314"},"html":{"href":"https://github.com/ray-project/ray/pull/314"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/314"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/ff4e61ec352bbe9b81c428bbdfa768773c9e176a"}}}} | {
"id": 71932349,
"name": "ray-project/ray",
"url": "https://api.github.com/repos/ray-project/ray"
} | {
"id": 1316372,
"login": "atumanov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1316372?",
"url": "https://api.github.com/users/atumanov"
} | {
"id": 22125274,
"login": "ray-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22125274?",
"url": "https://api.github.com/orgs/ray-project"
} | 2017-02-24T08:04:03 | 5383742665 | {"actor":{"display_login":"atumanov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/151824217","pull_request_review_id":77602196,"id":151824217,"diff_hunk":"@@ -84,6 +84,30 @@ def run(self):\n raise e\n \n \n+def import_function(file_path, function_name):","path":"python/ray/tune/script_runner.py","position":4,"original_position":4,"commit_id":"db203a2876e9da0f42cc353b471b0daa0078454a","original_commit_id":"db203a2876e9da0f42cc353b471b0daa0078454a","user":{"login":"richardliaw","id":4529381,"avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"body":"This code comes from the script_runner init from before.\r\n\r\n@ericl correct me if this is wrong - We want to be able to run an arbitrary script as a `Trial`, so we have to load the external file somehow, (the if cases are for python compatibility...)","created_at":"2017-11-18T01:47:49Z","updated_at":"2017-11-18T02:01:29Z","html_url":"https://github.com/ray-project/ray/pull/1226#discussion_r151824217","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/1226","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/151824217"},"html":{"href":"https://github.com/ray-project/ray/pull/1226#discussion_r151824217"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1226"}},"in_reply_to_id":151817586},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/1226","id":152951787,"html_url":"https://github.com/ray-project/ray/pull/1226","diff_url":"https://github.com/ray-project/ray/pull/1226.diff","patch_url":"https://github.com/ray-project/ray/pull/1226.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/1226","number":1226,"state":"open","locked":false,"title":"[tune] Support user-defined trainable functions / classes / envs with a shared object registry","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your contribution!\r\n\r\nPlease review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request.\r\n-->\r\n\r\n## What do these changes do?\r\n\r\nCurrently the tune APIs aren't very amenable to providing user-defined objects. This is since it's hard to refer to arbitrary objects/classes in the config. The proposed solution is to pass an object registry around in tune internal classes. The user calls `register_trainable()` at the start of the program to make their custom classes available by name.\r\n\r\ncc @richardliaw \r\n\r\n## Related issue number\r\n\r\nhttps://github.com/ray-project/ray/issues/1223","created_at":"2017-11-16T05:00:07Z","updated_at":"2017-11-18T02:01:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1354614ea4366e56b5290aca93420fc002ec964","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/1226/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/1226/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/1226/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/db203a2876e9da0f42cc353b471b0daa0078454a","head":{"label":"ericl:registry","ref":"registry","sha":"db203a2876e9da0f42cc353b471b0daa0078454a","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"repo":{"id":91077004,"name":"ray","full_name":"ericl/ray","owner":{"login":"ericl","id":14922,"avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericl/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/ericl/ray","forks_url":"https://api.github.com/repos/ericl/ray/forks","keys_url":"https://api.github.com/repos/ericl/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericl/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericl/ray/teams","hooks_url":"https://api.github.com/repos/ericl/ray/hooks","issue_events_url":"https://api.github.com/repos/ericl/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ericl/ray/events","assignees_url":"https://api.github.com/repos/ericl/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ericl/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ericl/ray/tags","blobs_url":"https://api.github.com/repos/ericl/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericl/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericl/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericl/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericl/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ericl/ray/languages","stargazers_url":"https://api.github.com/repos/ericl/ray/stargazers","contributors_url":"https://api.github.com/repos/ericl/ray/contributors","subscribers_url":"https://api.github.com/repos/ericl/ray/subscribers","subscription_url":"https://api.github.com/repos/ericl/ray/subscription","commits_url":"https://api.github.com/repos/ericl/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericl/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericl/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericl/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericl/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ericl/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericl/ray/merges","archive_url":"https://api.github.com/repos/ericl/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericl/ray/downloads","issues_url":"https://api.github.com/repos/ericl/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ericl/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ericl/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ericl/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericl/ray/labels{/name}","releases_url":"https://api.github.com/repos/ericl/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ericl/ray/deployments","created_at":"2017-05-12T09:51:04Z","updated_at":"2017-05-12T09:51:06Z","pushed_at":"2017-11-18T01:55:11Z","git_url":"git://github.com/ericl/ray.git","ssh_url":"[email protected]:ericl/ray.git","clone_url":"https://github.com/ericl/ray.git","svn_url":"https://github.com/ericl/ray","homepage":"","size":7382,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"94423c0542866ce4a512dba902d0e42dece540dd","user":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2017-11-16T21:14:33Z","pushed_at":"2017-11-18T01:55:12Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"[email protected]:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":6772,"stargazers_count":774,"watchers_count":774,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":171,"forks":154,"open_issues":171,"watchers":774,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1226"},"html":{"href":"https://github.com/ray-project/ray/pull/1226"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/1226"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/1226/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1226/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1226/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/db203a2876e9da0f42cc353b471b0daa0078454a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 71932349,
"name": "ray-project/ray",
"url": "https://api.github.com/repos/ray-project/ray"
} | {
"id": 4529381,
"login": "richardliaw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4529381?",
"url": "https://api.github.com/users/richardliaw"
} | {
"id": 22125274,
"login": "ray-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22125274?",
"url": "https://api.github.com/orgs/ray-project"
} | 2017-11-18T01:47:49 | 6872846827 | {"actor":{"display_login":"richardliaw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sagemathinc/cocalc/pulls/comments/132641549","pull_request_review_id":55744285,"id":132641549,"diff_hunk":"@@ -1525,44 +1525,66 @@ ProjectFilesActionBox = rclass\n if not (single_file_data.is_public and single_file_data.public?.path isnt single_file)\n @share_click()\n \n- download_click: ->\n+ download_single_click: ->\n @props.actions.download_file\n path : @props.checked_files.first()\n log : true\n @props.actions.set_file_action()\n \n- render_download_link: (single_item) ->\n+ download_multiple_click: ->\n+ destination = ReactDOM.findDOMNode(@refs.download_archive).value\n+ @props.actions.zip_files\n+ src : @props.checked_files.toArray()\n+ dest : misc.path_to_file(@props.current_path, destination)\n+ @props.actions.download_file","path":"src/smc-webapp/project_files.cjsx","position":17,"original_position":17,"commit_id":"464af535a2490d8588462c938163be098b06125c","original_commit_id":"464af535a2490d8588462c938163be098b06125c","user":{"login":"haraldschilly","id":207405,"avatar_url":"https://avatars0.githubusercontent.com/u/207405?v=4","gravatar_id":"","url":"https://api.github.com/users/haraldschilly","html_url":"https://github.com/haraldschilly","followers_url":"https://api.github.com/users/haraldschilly/followers","following_url":"https://api.github.com/users/haraldschilly/following{/other_user}","gists_url":"https://api.github.com/users/haraldschilly/gists{/gist_id}","starred_url":"https://api.github.com/users/haraldschilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraldschilly/subscriptions","organizations_url":"https://api.github.com/users/haraldschilly/orgs","repos_url":"https://api.github.com/users/haraldschilly/repos","events_url":"https://api.github.com/users/haraldschilly/events{/privacy}","received_events_url":"https://api.github.com/users/haraldschilly/received_events","type":"User","site_admin":false},"body":"I'm a bit surprised that these two commands in a row work. Aren't they asynchronous? So, imagine the zip-operation takes a few seconds. The download will continue to start immediately but fails with a file not found error. The unfortunate situation is, in these props-actions (`smc-webapp/project_store.coffee`) the callback is already some default file-listing & cleanup operation.","created_at":"2017-08-11T08:56:05Z","updated_at":"2017-08-11T08:56:05Z","html_url":"https://github.com/sagemathinc/cocalc/pull/2278#discussion_r132641549","pull_request_url":"https://api.github.com/repos/sagemathinc/cocalc/pulls/2278","_links":{"self":{"href":"https://api.github.com/repos/sagemathinc/cocalc/pulls/comments/132641549"},"html":{"href":"https://github.com/sagemathinc/cocalc/pull/2278#discussion_r132641549"},"pull_request":{"href":"https://api.github.com/repos/sagemathinc/cocalc/pulls/2278"}}},"pull_request":{"url":"https://api.github.com/repos/sagemathinc/cocalc/pulls/2278","id":135252560,"html_url":"https://github.com/sagemathinc/cocalc/pull/2278","diff_url":"https://github.com/sagemathinc/cocalc/pull/2278.diff","patch_url":"https://github.com/sagemathinc/cocalc/pull/2278.patch","issue_url":"https://api.github.com/repos/sagemathinc/cocalc/issues/2278","number":2278,"state":"open","locked":false,"title":"Changed download behavior for multiple files","user":{"login":"bryantpq","id":10336847,"avatar_url":"https://avatars3.githubusercontent.com/u/10336847?v=4","gravatar_id":"","url":"https://api.github.com/users/bryantpq","html_url":"https://github.com/bryantpq","followers_url":"https://api.github.com/users/bryantpq/followers","following_url":"https://api.github.com/users/bryantpq/following{/other_user}","gists_url":"https://api.github.com/users/bryantpq/gists{/gist_id}","starred_url":"https://api.github.com/users/bryantpq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryantpq/subscriptions","organizations_url":"https://api.github.com/users/bryantpq/orgs","repos_url":"https://api.github.com/users/bryantpq/repos","events_url":"https://api.github.com/users/bryantpq/events{/privacy}","received_events_url":"https://api.github.com/users/bryantpq/received_events","type":"User","site_admin":false},"body":"Now compresses the files for the user and downloads the resulting zip file, rather than showing the notice","created_at":"2017-08-11T01:08:17Z","updated_at":"2017-08-11T08:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbe8cc736f149b5c6ce505cb13d402eff520d68b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sagemathinc/cocalc/pulls/2278/commits","review_comments_url":"https://api.github.com/repos/sagemathinc/cocalc/pulls/2278/comments","review_comment_url":"https://api.github.com/repos/sagemathinc/cocalc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sagemathinc/cocalc/issues/2278/comments","statuses_url":"https://api.github.com/repos/sagemathinc/cocalc/statuses/464af535a2490d8588462c938163be098b06125c","head":{"label":"sagemathinc:download_files","ref":"download_files","sha":"464af535a2490d8588462c938163be098b06125c","user":{"login":"sagemathinc","id":11307305,"avatar_url":"https://avatars0.githubusercontent.com/u/11307305?v=4","gravatar_id":"","url":"https://api.github.com/users/sagemathinc","html_url":"https://github.com/sagemathinc","followers_url":"https://api.github.com/users/sagemathinc/followers","following_url":"https://api.github.com/users/sagemathinc/following{/other_user}","gists_url":"https://api.github.com/users/sagemathinc/gists{/gist_id}","starred_url":"https://api.github.com/users/sagemathinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagemathinc/subscriptions","organizations_url":"https://api.github.com/users/sagemathinc/orgs","repos_url":"https://api.github.com/users/sagemathinc/repos","events_url":"https://api.github.com/users/sagemathinc/events{/privacy}","received_events_url":"https://api.github.com/users/sagemathinc/received_events","type":"Organization","site_admin":false},"repo":{"id":32500369,"name":"cocalc","full_name":"sagemathinc/cocalc","owner":{"login":"sagemathinc","id":11307305,"avatar_url":"https://avatars0.githubusercontent.com/u/11307305?v=4","gravatar_id":"","url":"https://api.github.com/users/sagemathinc","html_url":"https://github.com/sagemathinc","followers_url":"https://api.github.com/users/sagemathinc/followers","following_url":"https://api.github.com/users/sagemathinc/following{/other_user}","gists_url":"https://api.github.com/users/sagemathinc/gists{/gist_id}","starred_url":"https://api.github.com/users/sagemathinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagemathinc/subscriptions","organizations_url":"https://api.github.com/users/sagemathinc/orgs","repos_url":"https://api.github.com/users/sagemathinc/repos","events_url":"https://api.github.com/users/sagemathinc/events{/privacy}","received_events_url":"https://api.github.com/users/sagemathinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sagemathinc/cocalc","description":"CoCalc: Collaborative Calculation in the Cloud","fork":false,"url":"https://api.github.com/repos/sagemathinc/cocalc","forks_url":"https://api.github.com/repos/sagemathinc/cocalc/forks","keys_url":"https://api.github.com/repos/sagemathinc/cocalc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sagemathinc/cocalc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sagemathinc/cocalc/teams","hooks_url":"https://api.github.com/repos/sagemathinc/cocalc/hooks","issue_events_url":"https://api.github.com/repos/sagemathinc/cocalc/issues/events{/number}","events_url":"https://api.github.com/repos/sagemathinc/cocalc/events","assignees_url":"https://api.github.com/repos/sagemathinc/cocalc/assignees{/user}","branches_url":"https://api.github.com/repos/sagemathinc/cocalc/branches{/branch}","tags_url":"https://api.github.com/repos/sagemathinc/cocalc/tags","blobs_url":"https://api.github.com/repos/sagemathinc/cocalc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sagemathinc/cocalc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sagemathinc/cocalc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sagemathinc/cocalc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sagemathinc/cocalc/statuses/{sha}","languages_url":"https://api.github.com/repos/sagemathinc/cocalc/languages","stargazers_url":"https://api.github.com/repos/sagemathinc/cocalc/stargazers","contributors_url":"https://api.github.com/repos/sagemathinc/cocalc/contributors","subscribers_url":"https://api.github.com/repos/sagemathinc/cocalc/subscribers","subscription_url":"https://api.github.com/repos/sagemathinc/cocalc/subscription","commits_url":"https://api.github.com/repos/sagemathinc/cocalc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sagemathinc/cocalc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sagemathinc/cocalc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sagemathinc/cocalc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sagemathinc/cocalc/contents/{+path}","compare_url":"https://api.github.com/repos/sagemathinc/cocalc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sagemathinc/cocalc/merges","archive_url":"https://api.github.com/repos/sagemathinc/cocalc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sagemathinc/cocalc/downloads","issues_url":"https://api.github.com/repos/sagemathinc/cocalc/issues{/number}","pulls_url":"https://api.github.com/repos/sagemathinc/cocalc/pulls{/number}","milestones_url":"https://api.github.com/repos/sagemathinc/cocalc/milestones{/number}","notifications_url":"https://api.github.com/repos/sagemathinc/cocalc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sagemathinc/cocalc/labels{/name}","releases_url":"https://api.github.com/repos/sagemathinc/cocalc/releases{/id}","deployments_url":"https://api.github.com/repos/sagemathinc/cocalc/deployments","created_at":"2015-03-19T04:16:53Z","updated_at":"2017-08-10T02:21:26Z","pushed_at":"2017-08-11T02:15:16Z","git_url":"git://github.com/sagemathinc/cocalc.git","ssh_url":"[email protected]:sagemathinc/cocalc.git","clone_url":"https://github.com/sagemathinc/cocalc.git","svn_url":"https://github.com/sagemathinc/cocalc","homepage":"https://CoCalc.com","size":181393,"stargazers_count":403,"watchers_count":403,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":586,"forks":79,"open_issues":586,"watchers":403,"default_branch":"master"}},"base":{"label":"sagemathinc:master","ref":"master","sha":"e9ed2d00feff16c1d081628f92e8cc36db31833e","user":{"login":"sagemathinc","id":11307305,"avatar_url":"https://avatars0.githubusercontent.com/u/11307305?v=4","gravatar_id":"","url":"https://api.github.com/users/sagemathinc","html_url":"https://github.com/sagemathinc","followers_url":"https://api.github.com/users/sagemathinc/followers","following_url":"https://api.github.com/users/sagemathinc/following{/other_user}","gists_url":"https://api.github.com/users/sagemathinc/gists{/gist_id}","starred_url":"https://api.github.com/users/sagemathinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagemathinc/subscriptions","organizations_url":"https://api.github.com/users/sagemathinc/orgs","repos_url":"https://api.github.com/users/sagemathinc/repos","events_url":"https://api.github.com/users/sagemathinc/events{/privacy}","received_events_url":"https://api.github.com/users/sagemathinc/received_events","type":"Organization","site_admin":false},"repo":{"id":32500369,"name":"cocalc","full_name":"sagemathinc/cocalc","owner":{"login":"sagemathinc","id":11307305,"avatar_url":"https://avatars0.githubusercontent.com/u/11307305?v=4","gravatar_id":"","url":"https://api.github.com/users/sagemathinc","html_url":"https://github.com/sagemathinc","followers_url":"https://api.github.com/users/sagemathinc/followers","following_url":"https://api.github.com/users/sagemathinc/following{/other_user}","gists_url":"https://api.github.com/users/sagemathinc/gists{/gist_id}","starred_url":"https://api.github.com/users/sagemathinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagemathinc/subscriptions","organizations_url":"https://api.github.com/users/sagemathinc/orgs","repos_url":"https://api.github.com/users/sagemathinc/repos","events_url":"https://api.github.com/users/sagemathinc/events{/privacy}","received_events_url":"https://api.github.com/users/sagemathinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sagemathinc/cocalc","description":"CoCalc: Collaborative Calculation in the Cloud","fork":false,"url":"https://api.github.com/repos/sagemathinc/cocalc","forks_url":"https://api.github.com/repos/sagemathinc/cocalc/forks","keys_url":"https://api.github.com/repos/sagemathinc/cocalc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sagemathinc/cocalc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sagemathinc/cocalc/teams","hooks_url":"https://api.github.com/repos/sagemathinc/cocalc/hooks","issue_events_url":"https://api.github.com/repos/sagemathinc/cocalc/issues/events{/number}","events_url":"https://api.github.com/repos/sagemathinc/cocalc/events","assignees_url":"https://api.github.com/repos/sagemathinc/cocalc/assignees{/user}","branches_url":"https://api.github.com/repos/sagemathinc/cocalc/branches{/branch}","tags_url":"https://api.github.com/repos/sagemathinc/cocalc/tags","blobs_url":"https://api.github.com/repos/sagemathinc/cocalc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sagemathinc/cocalc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sagemathinc/cocalc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sagemathinc/cocalc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sagemathinc/cocalc/statuses/{sha}","languages_url":"https://api.github.com/repos/sagemathinc/cocalc/languages","stargazers_url":"https://api.github.com/repos/sagemathinc/cocalc/stargazers","contributors_url":"https://api.github.com/repos/sagemathinc/cocalc/contributors","subscribers_url":"https://api.github.com/repos/sagemathinc/cocalc/subscribers","subscription_url":"https://api.github.com/repos/sagemathinc/cocalc/subscription","commits_url":"https://api.github.com/repos/sagemathinc/cocalc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sagemathinc/cocalc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sagemathinc/cocalc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sagemathinc/cocalc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sagemathinc/cocalc/contents/{+path}","compare_url":"https://api.github.com/repos/sagemathinc/cocalc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sagemathinc/cocalc/merges","archive_url":"https://api.github.com/repos/sagemathinc/cocalc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sagemathinc/cocalc/downloads","issues_url":"https://api.github.com/repos/sagemathinc/cocalc/issues{/number}","pulls_url":"https://api.github.com/repos/sagemathinc/cocalc/pulls{/number}","milestones_url":"https://api.github.com/repos/sagemathinc/cocalc/milestones{/number}","notifications_url":"https://api.github.com/repos/sagemathinc/cocalc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sagemathinc/cocalc/labels{/name}","releases_url":"https://api.github.com/repos/sagemathinc/cocalc/releases{/id}","deployments_url":"https://api.github.com/repos/sagemathinc/cocalc/deployments","created_at":"2015-03-19T04:16:53Z","updated_at":"2017-08-10T02:21:26Z","pushed_at":"2017-08-11T02:15:16Z","git_url":"git://github.com/sagemathinc/cocalc.git","ssh_url":"[email protected]:sagemathinc/cocalc.git","clone_url":"https://github.com/sagemathinc/cocalc.git","svn_url":"https://github.com/sagemathinc/cocalc","homepage":"https://CoCalc.com","size":181393,"stargazers_count":403,"watchers_count":403,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":586,"forks":79,"open_issues":586,"watchers":403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sagemathinc/cocalc/pulls/2278"},"html":{"href":"https://github.com/sagemathinc/cocalc/pull/2278"},"issue":{"href":"https://api.github.com/repos/sagemathinc/cocalc/issues/2278"},"comments":{"href":"https://api.github.com/repos/sagemathinc/cocalc/issues/2278/comments"},"review_comments":{"href":"https://api.github.com/repos/sagemathinc/cocalc/pulls/2278/comments"},"review_comment":{"href":"https://api.github.com/repos/sagemathinc/cocalc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sagemathinc/cocalc/pulls/2278/commits"},"statuses":{"href":"https://api.github.com/repos/sagemathinc/cocalc/statuses/464af535a2490d8588462c938163be098b06125c"}}}} | {
"id": 32500369,
"name": "sagemathinc/cocalc",
"url": "https://api.github.com/repos/sagemathinc/cocalc"
} | {
"id": 207405,
"login": "haraldschilly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/207405?",
"url": "https://api.github.com/users/haraldschilly"
} | {
"id": 11307305,
"login": "sagemathinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11307305?",
"url": "https://api.github.com/orgs/sagemathinc"
} | 2017-08-11T08:56:05 | 6439496516 | {"actor":{"display_login":"haraldschilly"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scalacenter/scalafix/pulls/comments/157740075","pull_request_review_id":84431399,"id":157740075,"diff_hunk":"@@ -0,0 +1,24 @@\n+/*\n+rules = DottyAutoTuplingFunctionArgs\n+ */\n+package test\n+\n+object DottyAutoTuplingFunctionArgs {\n+ List((1, 2), (3, 4)).map { case (a, b) => a + b }","path":"scalafix-tests/input/src/main/scala/test/DottyAutoTuplingFunctionArgs.scala","position":7,"original_position":7,"commit_id":"f81287e30928591fa305bac1ff2477d87fb5e595","original_commit_id":"3e31ed1f7cea75b5d6015db076d54b557dc887d1","user":{"login":"marcelocenerine","id":1107367,"avatar_url":"https://avatars0.githubusercontent.com/u/1107367?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelocenerine","html_url":"https://github.com/marcelocenerine","followers_url":"https://api.github.com/users/marcelocenerine/followers","following_url":"https://api.github.com/users/marcelocenerine/following{/other_user}","gists_url":"https://api.github.com/users/marcelocenerine/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelocenerine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelocenerine/subscriptions","organizations_url":"https://api.github.com/users/marcelocenerine/orgs","repos_url":"https://api.github.com/users/marcelocenerine/repos","events_url":"https://api.github.com/users/marcelocenerine/events{/privacy}","received_events_url":"https://api.github.com/users/marcelocenerine/received_events","type":"User","site_admin":false},"body":"oh, you found a way to break it. Nice catch! Your suggestion https://github.com/scalacenter/scalafix/pull/513/files#r157722339 addresses this.","created_at":"2017-12-19T12:27:59Z","updated_at":"2017-12-19T12:27:59Z","html_url":"https://github.com/scalacenter/scalafix/pull/513#discussion_r157740075","pull_request_url":"https://api.github.com/repos/scalacenter/scalafix/pulls/513","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/comments/157740075"},"html":{"href":"https://github.com/scalacenter/scalafix/pull/513#discussion_r157740075"},"pull_request":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/513"}},"in_reply_to_id":157722205},"pull_request":{"url":"https://api.github.com/repos/scalacenter/scalafix/pulls/513","id":159068017,"html_url":"https://github.com/scalacenter/scalafix/pull/513","diff_url":"https://github.com/scalacenter/scalafix/pull/513.diff","patch_url":"https://github.com/scalacenter/scalafix/pull/513.patch","issue_url":"https://api.github.com/repos/scalacenter/scalafix/issues/513","number":513,"state":"open","locked":false,"title":"Add rule to leverage automatic tupling of function parameters in Dotty","user":{"login":"marcelocenerine","id":1107367,"avatar_url":"https://avatars0.githubusercontent.com/u/1107367?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelocenerine","html_url":"https://github.com/marcelocenerine","followers_url":"https://api.github.com/users/marcelocenerine/followers","following_url":"https://api.github.com/users/marcelocenerine/following{/other_user}","gists_url":"https://api.github.com/users/marcelocenerine/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelocenerine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelocenerine/subscriptions","organizations_url":"https://api.github.com/users/marcelocenerine/orgs","repos_url":"https://api.github.com/users/marcelocenerine/repos","events_url":"https://api.github.com/users/marcelocenerine/events{/privacy}","received_events_url":"https://api.github.com/users/marcelocenerine/received_events","type":"User","site_admin":false},"body":"http://dotty.epfl.ch/docs/reference/auto-parameter-tupling.html\r\n\r\n@olafurpg, is this something you would like to have in scalafix at this point?","created_at":"2017-12-19T02:58:39Z","updated_at":"2017-12-19T12:27:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc80de25c025abe29256f992d5e8b4dc3a57d4c0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalacenter/scalafix/pulls/513/commits","review_comments_url":"https://api.github.com/repos/scalacenter/scalafix/pulls/513/comments","review_comment_url":"https://api.github.com/repos/scalacenter/scalafix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalacenter/scalafix/issues/513/comments","statuses_url":"https://api.github.com/repos/scalacenter/scalafix/statuses/f81287e30928591fa305bac1ff2477d87fb5e595","head":{"label":"marcelocenerine:auto_tupling","ref":"auto_tupling","sha":"f81287e30928591fa305bac1ff2477d87fb5e595","user":{"login":"marcelocenerine","id":1107367,"avatar_url":"https://avatars0.githubusercontent.com/u/1107367?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelocenerine","html_url":"https://github.com/marcelocenerine","followers_url":"https://api.github.com/users/marcelocenerine/followers","following_url":"https://api.github.com/users/marcelocenerine/following{/other_user}","gists_url":"https://api.github.com/users/marcelocenerine/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelocenerine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelocenerine/subscriptions","organizations_url":"https://api.github.com/users/marcelocenerine/orgs","repos_url":"https://api.github.com/users/marcelocenerine/repos","events_url":"https://api.github.com/users/marcelocenerine/events{/privacy}","received_events_url":"https://api.github.com/users/marcelocenerine/received_events","type":"User","site_admin":false},"repo":{"id":113115063,"name":"scalafix","full_name":"marcelocenerine/scalafix","owner":{"login":"marcelocenerine","id":1107367,"avatar_url":"https://avatars0.githubusercontent.com/u/1107367?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelocenerine","html_url":"https://github.com/marcelocenerine","followers_url":"https://api.github.com/users/marcelocenerine/followers","following_url":"https://api.github.com/users/marcelocenerine/following{/other_user}","gists_url":"https://api.github.com/users/marcelocenerine/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelocenerine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelocenerine/subscriptions","organizations_url":"https://api.github.com/users/marcelocenerine/orgs","repos_url":"https://api.github.com/users/marcelocenerine/repos","events_url":"https://api.github.com/users/marcelocenerine/events{/privacy}","received_events_url":"https://api.github.com/users/marcelocenerine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcelocenerine/scalafix","description":"Refactoring and linting tool for Scala","fork":true,"url":"https://api.github.com/repos/marcelocenerine/scalafix","forks_url":"https://api.github.com/repos/marcelocenerine/scalafix/forks","keys_url":"https://api.github.com/repos/marcelocenerine/scalafix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcelocenerine/scalafix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcelocenerine/scalafix/teams","hooks_url":"https://api.github.com/repos/marcelocenerine/scalafix/hooks","issue_events_url":"https://api.github.com/repos/marcelocenerine/scalafix/issues/events{/number}","events_url":"https://api.github.com/repos/marcelocenerine/scalafix/events","assignees_url":"https://api.github.com/repos/marcelocenerine/scalafix/assignees{/user}","branches_url":"https://api.github.com/repos/marcelocenerine/scalafix/branches{/branch}","tags_url":"https://api.github.com/repos/marcelocenerine/scalafix/tags","blobs_url":"https://api.github.com/repos/marcelocenerine/scalafix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcelocenerine/scalafix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcelocenerine/scalafix/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcelocenerine/scalafix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcelocenerine/scalafix/statuses/{sha}","languages_url":"https://api.github.com/repos/marcelocenerine/scalafix/languages","stargazers_url":"https://api.github.com/repos/marcelocenerine/scalafix/stargazers","contributors_url":"https://api.github.com/repos/marcelocenerine/scalafix/contributors","subscribers_url":"https://api.github.com/repos/marcelocenerine/scalafix/subscribers","subscription_url":"https://api.github.com/repos/marcelocenerine/scalafix/subscription","commits_url":"https://api.github.com/repos/marcelocenerine/scalafix/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcelocenerine/scalafix/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcelocenerine/scalafix/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcelocenerine/scalafix/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcelocenerine/scalafix/contents/{+path}","compare_url":"https://api.github.com/repos/marcelocenerine/scalafix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcelocenerine/scalafix/merges","archive_url":"https://api.github.com/repos/marcelocenerine/scalafix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcelocenerine/scalafix/downloads","issues_url":"https://api.github.com/repos/marcelocenerine/scalafix/issues{/number}","pulls_url":"https://api.github.com/repos/marcelocenerine/scalafix/pulls{/number}","milestones_url":"https://api.github.com/repos/marcelocenerine/scalafix/milestones{/number}","notifications_url":"https://api.github.com/repos/marcelocenerine/scalafix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcelocenerine/scalafix/labels{/name}","releases_url":"https://api.github.com/repos/marcelocenerine/scalafix/releases{/id}","deployments_url":"https://api.github.com/repos/marcelocenerine/scalafix/deployments","created_at":"2017-12-05T01:21:58Z","updated_at":"2017-12-05T01:22:00Z","pushed_at":"2017-12-19T11:01:15Z","git_url":"git://github.com/marcelocenerine/scalafix.git","ssh_url":"[email protected]:marcelocenerine/scalafix.git","clone_url":"https://github.com/marcelocenerine/scalafix.git","svn_url":"https://github.com/marcelocenerine/scalafix","homepage":"https://scalacenter.github.io/scalafix/","size":5320,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalacenter:master","ref":"master","sha":"8bd026de8e6610934ab2cad70f811592f764fc98","user":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":65199839,"name":"scalafix","full_name":"scalacenter/scalafix","owner":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalacenter/scalafix","description":"Refactoring and linting tool for Scala","fork":false,"url":"https://api.github.com/repos/scalacenter/scalafix","forks_url":"https://api.github.com/repos/scalacenter/scalafix/forks","keys_url":"https://api.github.com/repos/scalacenter/scalafix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/scalafix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/scalafix/teams","hooks_url":"https://api.github.com/repos/scalacenter/scalafix/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/scalafix/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/scalafix/events","assignees_url":"https://api.github.com/repos/scalacenter/scalafix/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/scalafix/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/scalafix/tags","blobs_url":"https://api.github.com/repos/scalacenter/scalafix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/scalafix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/scalafix/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/scalafix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/scalafix/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/scalafix/languages","stargazers_url":"https://api.github.com/repos/scalacenter/scalafix/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/scalafix/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/scalafix/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/scalafix/subscription","commits_url":"https://api.github.com/repos/scalacenter/scalafix/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/scalafix/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/scalafix/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/scalafix/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/scalafix/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/scalafix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/scalafix/merges","archive_url":"https://api.github.com/repos/scalacenter/scalafix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/scalafix/downloads","issues_url":"https://api.github.com/repos/scalacenter/scalafix/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/scalafix/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/scalafix/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/scalafix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/scalafix/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/scalafix/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/scalafix/deployments","created_at":"2016-08-08T11:45:19Z","updated_at":"2017-12-17T22:15:52Z","pushed_at":"2017-12-19T11:39:53Z","git_url":"git://github.com/scalacenter/scalafix.git","ssh_url":"[email protected]:scalacenter/scalafix.git","clone_url":"https://github.com/scalacenter/scalafix.git","svn_url":"https://github.com/scalacenter/scalafix","homepage":"https://scalacenter.github.io/scalafix/","size":5361,"stargazers_count":211,"watchers_count":211,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":58,"open_issues":66,"watchers":211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/513"},"html":{"href":"https://github.com/scalacenter/scalafix/pull/513"},"issue":{"href":"https://api.github.com/repos/scalacenter/scalafix/issues/513"},"comments":{"href":"https://api.github.com/repos/scalacenter/scalafix/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/scalacenter/scalafix/statuses/f81287e30928591fa305bac1ff2477d87fb5e595"}},"author_association":"NONE"}} | {
"id": 65199839,
"name": "scalacenter/scalafix",
"url": "https://api.github.com/repos/scalacenter/scalafix"
} | {
"id": 1107367,
"login": "marcelocenerine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1107367?",
"url": "https://api.github.com/users/marcelocenerine"
} | {
"id": 16118980,
"login": "scalacenter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16118980?",
"url": "https://api.github.com/orgs/scalacenter"
} | 2017-12-19T12:27:59 | 7007473368 | {"actor":{"display_login":"marcelocenerine"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ualbertalib/avalon/pulls/comments/100864945","pull_request_review_id":21581284,"id":100864945,"diff_hunk":"@@ -0,0 +1,29 @@\n+# Copyright 2017, University of Alberta Libraries.\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+#\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software distributed\n+# under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\n+# CONDITIONS OF ANY KIND, either express or implied. See the License for the\n+# specific language governing permissions and limitations under the License.\n+# --- END LICENSE_HEADER BLOCK ---\n+\n+module EraAvHelper\n+ def ualib_logo_link\n+ link_to(\"\", \"https://library.ualberta.ca\", :class => 'logo')\n+ end\n+\n+ def era_av_logo_link\n+ image =\n+ image_tag(\"ERA-A+V-beta-logo.png\",\n+ alt: \"University of Alberta ERA Audio and Video\"\\","path":"app/helpers/era_av_helper.rb","position":23,"original_position":23,"commit_id":"91121ebfb45bc006a1b3043a26a5fabee3959d46","original_commit_id":"91121ebfb45bc006a1b3043a26a5fabee3959d46","user":{"login":"murny","id":1930474,"avatar_url":"https://avatars.githubusercontent.com/u/1930474?v=3","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false},"body":"Why have some of this stuff come from I18n but not other parts? Make this all from I18n?","created_at":"2017-02-13T18:40:14Z","updated_at":"2017-02-13T18:40:14Z","html_url":"https://github.com/ualbertalib/avalon/pull/75#discussion_r100864945","pull_request_url":"https://api.github.com/repos/ualbertalib/avalon/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/ualbertalib/avalon/pulls/comments/100864945"},"html":{"href":"https://github.com/ualbertalib/avalon/pull/75#discussion_r100864945"},"pull_request":{"href":"https://api.github.com/repos/ualbertalib/avalon/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/ualbertalib/avalon/pulls/75","id":105321501,"html_url":"https://github.com/ualbertalib/avalon/pull/75","diff_url":"https://github.com/ualbertalib/avalon/pull/75.diff","patch_url":"https://github.com/ualbertalib/avalon/pull/75.patch","issue_url":"https://api.github.com/repos/ualbertalib/avalon/issues/75","number":75,"state":"open","locked":false,"title":"Issue #36. Make logo clickable and have it point to the home page.","user":{"login":"cwant","id":672104,"avatar_url":"https://avatars.githubusercontent.com/u/672104?v=3","gravatar_id":"","url":"https://api.github.com/users/cwant","html_url":"https://github.com/cwant","followers_url":"https://api.github.com/users/cwant/followers","following_url":"https://api.github.com/users/cwant/following{/other_user}","gists_url":"https://api.github.com/users/cwant/gists{/gist_id}","starred_url":"https://api.github.com/users/cwant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwant/subscriptions","organizations_url":"https://api.github.com/users/cwant/orgs","repos_url":"https://api.github.com/users/cwant/repos","events_url":"https://api.github.com/users/cwant/events{/privacy}","received_events_url":"https://api.github.com/users/cwant/received_events","type":"User","site_admin":false},"body":"Also refactored this and some other U of A specific view code into an era_av helper.\r\n\r\nFixes #36 ;\r\n","created_at":"2017-02-08T22:38:43Z","updated_at":"2017-02-13T18:40:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da9f264cd744d3830e0da02da950b77eb34f74a3","assignee":{"login":"murny","id":1930474,"avatar_url":"https://avatars.githubusercontent.com/u/1930474?v=3","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false},"assignees":[{"login":"murny","id":1930474,"avatar_url":"https://avatars.githubusercontent.com/u/1930474?v=3","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ualbertalib/avalon/pulls/75/commits","review_comments_url":"https://api.github.com/repos/ualbertalib/avalon/pulls/75/comments","review_comment_url":"https://api.github.com/repos/ualbertalib/avalon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ualbertalib/avalon/issues/75/comments","statuses_url":"https://api.github.com/repos/ualbertalib/avalon/statuses/91121ebfb45bc006a1b3043a26a5fabee3959d46","head":{"label":"ualbertalib:cwant/make_era_av_clickable","ref":"cwant/make_era_av_clickable","sha":"91121ebfb45bc006a1b3043a26a5fabee3959d46","user":{"login":"ualbertalib","id":2856757,"avatar_url":"https://avatars.githubusercontent.com/u/2856757?v=3","gravatar_id":"","url":"https://api.github.com/users/ualbertalib","html_url":"https://github.com/ualbertalib","followers_url":"https://api.github.com/users/ualbertalib/followers","following_url":"https://api.github.com/users/ualbertalib/following{/other_user}","gists_url":"https://api.github.com/users/ualbertalib/gists{/gist_id}","starred_url":"https://api.github.com/users/ualbertalib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ualbertalib/subscriptions","organizations_url":"https://api.github.com/users/ualbertalib/orgs","repos_url":"https://api.github.com/users/ualbertalib/repos","events_url":"https://api.github.com/users/ualbertalib/events{/privacy}","received_events_url":"https://api.github.com/users/ualbertalib/received_events","type":"Organization","site_admin":false},"repo":{"id":44204376,"name":"avalon","full_name":"ualbertalib/avalon","owner":{"login":"ualbertalib","id":2856757,"avatar_url":"https://avatars.githubusercontent.com/u/2856757?v=3","gravatar_id":"","url":"https://api.github.com/users/ualbertalib","html_url":"https://github.com/ualbertalib","followers_url":"https://api.github.com/users/ualbertalib/followers","following_url":"https://api.github.com/users/ualbertalib/following{/other_user}","gists_url":"https://api.github.com/users/ualbertalib/gists{/gist_id}","starred_url":"https://api.github.com/users/ualbertalib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ualbertalib/subscriptions","organizations_url":"https://api.github.com/users/ualbertalib/orgs","repos_url":"https://api.github.com/users/ualbertalib/repos","events_url":"https://api.github.com/users/ualbertalib/events{/privacy}","received_events_url":"https://api.github.com/users/ualbertalib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ualbertalib/avalon","description":"University of Alberta's Media Repository based on Avalon","fork":true,"url":"https://api.github.com/repos/ualbertalib/avalon","forks_url":"https://api.github.com/repos/ualbertalib/avalon/forks","keys_url":"https://api.github.com/repos/ualbertalib/avalon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ualbertalib/avalon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ualbertalib/avalon/teams","hooks_url":"https://api.github.com/repos/ualbertalib/avalon/hooks","issue_events_url":"https://api.github.com/repos/ualbertalib/avalon/issues/events{/number}","events_url":"https://api.github.com/repos/ualbertalib/avalon/events","assignees_url":"https://api.github.com/repos/ualbertalib/avalon/assignees{/user}","branches_url":"https://api.github.com/repos/ualbertalib/avalon/branches{/branch}","tags_url":"https://api.github.com/repos/ualbertalib/avalon/tags","blobs_url":"https://api.github.com/repos/ualbertalib/avalon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ualbertalib/avalon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ualbertalib/avalon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ualbertalib/avalon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ualbertalib/avalon/statuses/{sha}","languages_url":"https://api.github.com/repos/ualbertalib/avalon/languages","stargazers_url":"https://api.github.com/repos/ualbertalib/avalon/stargazers","contributors_url":"https://api.github.com/repos/ualbertalib/avalon/contributors","subscribers_url":"https://api.github.com/repos/ualbertalib/avalon/subscribers","subscription_url":"https://api.github.com/repos/ualbertalib/avalon/subscription","commits_url":"https://api.github.com/repos/ualbertalib/avalon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ualbertalib/avalon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ualbertalib/avalon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ualbertalib/avalon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ualbertalib/avalon/contents/{+path}","compare_url":"https://api.github.com/repos/ualbertalib/avalon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ualbertalib/avalon/merges","archive_url":"https://api.github.com/repos/ualbertalib/avalon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ualbertalib/avalon/downloads","issues_url":"https://api.github.com/repos/ualbertalib/avalon/issues{/number}","pulls_url":"https://api.github.com/repos/ualbertalib/avalon/pulls{/number}","milestones_url":"https://api.github.com/repos/ualbertalib/avalon/milestones{/number}","notifications_url":"https://api.github.com/repos/ualbertalib/avalon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ualbertalib/avalon/labels{/name}","releases_url":"https://api.github.com/repos/ualbertalib/avalon/releases{/id}","deployments_url":"https://api.github.com/repos/ualbertalib/avalon/deployments","created_at":"2015-10-13T20:56:46Z","updated_at":"2017-01-11T21:45:48Z","pushed_at":"2017-02-08T22:38:43Z","git_url":"git://github.com/ualbertalib/avalon.git","ssh_url":"[email protected]:ualbertalib/avalon.git","clone_url":"https://github.com/ualbertalib/avalon.git","svn_url":"https://github.com/ualbertalib/avalon","homepage":"","size":40866,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":55,"forks":0,"open_issues":55,"watchers":0,"default_branch":"master"}},"base":{"label":"ualbertalib:master","ref":"master","sha":"6146e7230ee5601422d0654f2f2f433da0ef05cb","user":{"login":"ualbertalib","id":2856757,"avatar_url":"https://avatars.githubusercontent.com/u/2856757?v=3","gravatar_id":"","url":"https://api.github.com/users/ualbertalib","html_url":"https://github.com/ualbertalib","followers_url":"https://api.github.com/users/ualbertalib/followers","following_url":"https://api.github.com/users/ualbertalib/following{/other_user}","gists_url":"https://api.github.com/users/ualbertalib/gists{/gist_id}","starred_url":"https://api.github.com/users/ualbertalib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ualbertalib/subscriptions","organizations_url":"https://api.github.com/users/ualbertalib/orgs","repos_url":"https://api.github.com/users/ualbertalib/repos","events_url":"https://api.github.com/users/ualbertalib/events{/privacy}","received_events_url":"https://api.github.com/users/ualbertalib/received_events","type":"Organization","site_admin":false},"repo":{"id":44204376,"name":"avalon","full_name":"ualbertalib/avalon","owner":{"login":"ualbertalib","id":2856757,"avatar_url":"https://avatars.githubusercontent.com/u/2856757?v=3","gravatar_id":"","url":"https://api.github.com/users/ualbertalib","html_url":"https://github.com/ualbertalib","followers_url":"https://api.github.com/users/ualbertalib/followers","following_url":"https://api.github.com/users/ualbertalib/following{/other_user}","gists_url":"https://api.github.com/users/ualbertalib/gists{/gist_id}","starred_url":"https://api.github.com/users/ualbertalib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ualbertalib/subscriptions","organizations_url":"https://api.github.com/users/ualbertalib/orgs","repos_url":"https://api.github.com/users/ualbertalib/repos","events_url":"https://api.github.com/users/ualbertalib/events{/privacy}","received_events_url":"https://api.github.com/users/ualbertalib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ualbertalib/avalon","description":"University of Alberta's Media Repository based on Avalon","fork":true,"url":"https://api.github.com/repos/ualbertalib/avalon","forks_url":"https://api.github.com/repos/ualbertalib/avalon/forks","keys_url":"https://api.github.com/repos/ualbertalib/avalon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ualbertalib/avalon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ualbertalib/avalon/teams","hooks_url":"https://api.github.com/repos/ualbertalib/avalon/hooks","issue_events_url":"https://api.github.com/repos/ualbertalib/avalon/issues/events{/number}","events_url":"https://api.github.com/repos/ualbertalib/avalon/events","assignees_url":"https://api.github.com/repos/ualbertalib/avalon/assignees{/user}","branches_url":"https://api.github.com/repos/ualbertalib/avalon/branches{/branch}","tags_url":"https://api.github.com/repos/ualbertalib/avalon/tags","blobs_url":"https://api.github.com/repos/ualbertalib/avalon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ualbertalib/avalon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ualbertalib/avalon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ualbertalib/avalon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ualbertalib/avalon/statuses/{sha}","languages_url":"https://api.github.com/repos/ualbertalib/avalon/languages","stargazers_url":"https://api.github.com/repos/ualbertalib/avalon/stargazers","contributors_url":"https://api.github.com/repos/ualbertalib/avalon/contributors","subscribers_url":"https://api.github.com/repos/ualbertalib/avalon/subscribers","subscription_url":"https://api.github.com/repos/ualbertalib/avalon/subscription","commits_url":"https://api.github.com/repos/ualbertalib/avalon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ualbertalib/avalon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ualbertalib/avalon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ualbertalib/avalon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ualbertalib/avalon/contents/{+path}","compare_url":"https://api.github.com/repos/ualbertalib/avalon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ualbertalib/avalon/merges","archive_url":"https://api.github.com/repos/ualbertalib/avalon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ualbertalib/avalon/downloads","issues_url":"https://api.github.com/repos/ualbertalib/avalon/issues{/number}","pulls_url":"https://api.github.com/repos/ualbertalib/avalon/pulls{/number}","milestones_url":"https://api.github.com/repos/ualbertalib/avalon/milestones{/number}","notifications_url":"https://api.github.com/repos/ualbertalib/avalon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ualbertalib/avalon/labels{/name}","releases_url":"https://api.github.com/repos/ualbertalib/avalon/releases{/id}","deployments_url":"https://api.github.com/repos/ualbertalib/avalon/deployments","created_at":"2015-10-13T20:56:46Z","updated_at":"2017-01-11T21:45:48Z","pushed_at":"2017-02-08T22:38:43Z","git_url":"git://github.com/ualbertalib/avalon.git","ssh_url":"[email protected]:ualbertalib/avalon.git","clone_url":"https://github.com/ualbertalib/avalon.git","svn_url":"https://github.com/ualbertalib/avalon","homepage":"","size":40866,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":55,"forks":0,"open_issues":55,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ualbertalib/avalon/pulls/75"},"html":{"href":"https://github.com/ualbertalib/avalon/pull/75"},"issue":{"href":"https://api.github.com/repos/ualbertalib/avalon/issues/75"},"comments":{"href":"https://api.github.com/repos/ualbertalib/avalon/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/ualbertalib/avalon/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/ualbertalib/avalon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ualbertalib/avalon/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/ualbertalib/avalon/statuses/91121ebfb45bc006a1b3043a26a5fabee3959d46"}}}} | {
"id": 44204376,
"name": "ualbertalib/avalon",
"url": "https://api.github.com/repos/ualbertalib/avalon"
} | {
"id": 1930474,
"login": "murny",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1930474?",
"url": "https://api.github.com/users/murny"
} | {
"id": 2856757,
"login": "ualbertalib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2856757?",
"url": "https://api.github.com/orgs/ualbertalib"
} | 2017-02-13T18:40:14 | 5315963381 | {"actor":{"display_login":"murny"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/comments/128224784","pull_request_review_id":50882568,"id":128224784,"diff_hunk":"@@ -0,0 +1,283 @@\n+REST API: Settings\n+==================\n+\n+The settings REST API allows you to view and update WooCommerce Stripe settinngs.\n+The endpoints, requests, and responses have similar structure with [WooCommerce core setting options REST API](https://woocommerce.github.io/woocommerce-rest-api-docs/?shell#setting-options).\n+\n+## Setting option properties\n+\n+| Attribute | Type | Description | |","path":"docs/api/settings.md","position":9,"original_position":9,"commit_id":"656239771c9b7434d9a26a07884afa0fe94447b1","original_commit_id":"656239771c9b7434d9a26a07884afa0fe94447b1","user":{"login":"budzanowski","id":17271089,"avatar_url":"https://avatars2.githubusercontent.com/u/17271089?v=4","gravatar_id":"","url":"https://api.github.com/users/budzanowski","html_url":"https://github.com/budzanowski","followers_url":"https://api.github.com/users/budzanowski/followers","following_url":"https://api.github.com/users/budzanowski/following{/other_user}","gists_url":"https://api.github.com/users/budzanowski/gists{/gist_id}","starred_url":"https://api.github.com/users/budzanowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budzanowski/subscriptions","organizations_url":"https://api.github.com/users/budzanowski/orgs","repos_url":"https://api.github.com/users/budzanowski/repos","events_url":"https://api.github.com/users/budzanowski/events{/privacy}","received_events_url":"https://api.github.com/users/budzanowski/received_events","type":"User","site_admin":false},"body":"I would say that it is a Name and not Attribute, The last comment misses a label - maybe _Access Type_","created_at":"2017-07-19T11:54:43Z","updated_at":"2017-07-19T11:54:43Z","html_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/314#discussion_r128224784","pull_request_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/314","_links":{"self":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/comments/128224784"},"html":{"href":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/314#discussion_r128224784"},"pull_request":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/314","id":131095003,"html_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/314","diff_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/314.diff","patch_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/314.patch","issue_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/314","number":314,"state":"open","locked":false,"title":"Add REST API documentation for WooCommerce Stripe.","user":{"login":"gedex","id":78313,"avatar_url":"https://avatars2.githubusercontent.com/u/78313?v=4","gravatar_id":"","url":"https://api.github.com/users/gedex","html_url":"https://github.com/gedex","followers_url":"https://api.github.com/users/gedex/followers","following_url":"https://api.github.com/users/gedex/following{/other_user}","gists_url":"https://api.github.com/users/gedex/gists{/gist_id}","starred_url":"https://api.github.com/users/gedex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedex/subscriptions","organizations_url":"https://api.github.com/users/gedex/orgs","repos_url":"https://api.github.com/users/gedex/repos","events_url":"https://api.github.com/users/gedex/events{/privacy}","received_events_url":"https://api.github.com/users/gedex/received_events","type":"User","site_admin":false},"body":"This is a draft version that has a status request for feedback.\r\n\r\nAvailable endpoints:\r\n\r\n* `/stripe/settings` — View and update (single or batch). The endpoints, requests, and responses have a similar structure with [WooCommerce core setting options REST API](https://woocommerce.github.io/woocommerce-rest-api-docs/?shell#setting-options).\r\n* Orders? For example: given an order ID the REST API allows to retrieve Stripe-related information (e.g. customer ID, card ID, etc). Most of them are stored as order meta so that can be handled by WC REST API too by whitelisting some meta.\r\n\r\n/cc @allendav @budzanowski ","created_at":"2017-07-18T14:00:37Z","updated_at":"2017-07-19T11:54:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd0a0c55217e694459c64e0fdefb6f861073f57a","assignee":{"login":"gedex","id":78313,"avatar_url":"https://avatars2.githubusercontent.com/u/78313?v=4","gravatar_id":"","url":"https://api.github.com/users/gedex","html_url":"https://github.com/gedex","followers_url":"https://api.github.com/users/gedex/followers","following_url":"https://api.github.com/users/gedex/following{/other_user}","gists_url":"https://api.github.com/users/gedex/gists{/gist_id}","starred_url":"https://api.github.com/users/gedex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedex/subscriptions","organizations_url":"https://api.github.com/users/gedex/orgs","repos_url":"https://api.github.com/users/gedex/repos","events_url":"https://api.github.com/users/gedex/events{/privacy}","received_events_url":"https://api.github.com/users/gedex/received_events","type":"User","site_admin":false},"assignees":[{"login":"gedex","id":78313,"avatar_url":"https://avatars2.githubusercontent.com/u/78313?v=4","gravatar_id":"","url":"https://api.github.com/users/gedex","html_url":"https://github.com/gedex","followers_url":"https://api.github.com/users/gedex/followers","following_url":"https://api.github.com/users/gedex/following{/other_user}","gists_url":"https://api.github.com/users/gedex/gists{/gist_id}","starred_url":"https://api.github.com/users/gedex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedex/subscriptions","organizations_url":"https://api.github.com/users/gedex/orgs","repos_url":"https://api.github.com/users/gedex/repos","events_url":"https://api.github.com/users/gedex/events{/privacy}","received_events_url":"https://api.github.com/users/gedex/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"allendav","id":1595739,"avatar_url":"https://avatars1.githubusercontent.com/u/1595739?v=4","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/314/commits","review_comments_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/314/comments","review_comment_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/314/comments","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/statuses/656239771c9b7434d9a26a07884afa0fe94447b1","head":{"label":"woocommerce:add/313-rest-api-doc","ref":"add/313-rest-api-doc","sha":"656239771c9b7434d9a26a07884afa0fe94447b1","user":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":58202827,"name":"woocommerce-gateway-stripe","full_name":"woocommerce/woocommerce-gateway-stripe","owner":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/woocommerce/woocommerce-gateway-stripe","description":"The official Stripe Payment Gateway for WooCommerce","fork":false,"url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe","forks_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/forks","keys_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/teams","hooks_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/events","assignees_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/tags","blobs_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/languages","stargazers_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/subscription","commits_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/merges","archive_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/downloads","issues_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/deployments","created_at":"2016-05-06T11:30:42Z","updated_at":"2017-07-09T13:53:59Z","pushed_at":"2017-07-18T14:03:21Z","git_url":"git://github.com/woocommerce/woocommerce-gateway-stripe.git","ssh_url":"[email protected]:woocommerce/woocommerce-gateway-stripe.git","clone_url":"https://github.com/woocommerce/woocommerce-gateway-stripe.git","svn_url":"https://github.com/woocommerce/woocommerce-gateway-stripe","homepage":null,"size":2403,"stargazers_count":47,"watchers_count":47,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":37,"forks":40,"open_issues":37,"watchers":47,"default_branch":"master"}},"base":{"label":"woocommerce:master","ref":"master","sha":"5d3de45388ecbac62ac74d71f7ac2c96243bd1dc","user":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":58202827,"name":"woocommerce-gateway-stripe","full_name":"woocommerce/woocommerce-gateway-stripe","owner":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/woocommerce/woocommerce-gateway-stripe","description":"The official Stripe Payment Gateway for WooCommerce","fork":false,"url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe","forks_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/forks","keys_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/teams","hooks_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/events","assignees_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/tags","blobs_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/languages","stargazers_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/subscription","commits_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/merges","archive_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/downloads","issues_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/deployments","created_at":"2016-05-06T11:30:42Z","updated_at":"2017-07-09T13:53:59Z","pushed_at":"2017-07-18T14:03:21Z","git_url":"git://github.com/woocommerce/woocommerce-gateway-stripe.git","ssh_url":"[email protected]:woocommerce/woocommerce-gateway-stripe.git","clone_url":"https://github.com/woocommerce/woocommerce-gateway-stripe.git","svn_url":"https://github.com/woocommerce/woocommerce-gateway-stripe","homepage":null,"size":2403,"stargazers_count":47,"watchers_count":47,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":37,"forks":40,"open_issues":37,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/314"},"html":{"href":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/314"},"issue":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/314"},"comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/statuses/656239771c9b7434d9a26a07884afa0fe94447b1"}}}} | {
"id": 58202827,
"name": "woocommerce/woocommerce-gateway-stripe",
"url": "https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe"
} | {
"id": 17271089,
"login": "budzanowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17271089?",
"url": "https://api.github.com/users/budzanowski"
} | {
"id": 473596,
"login": "woocommerce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/473596?",
"url": "https://api.github.com/orgs/woocommerce"
} | 2017-07-19T11:54:43 | 6286012823 | {"actor":{"display_login":"budzanowski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments/134216464","pull_request_review_id":57481602,"id":134216464,"diff_hunk":"@@ -747,12 +747,12 @@ public static function add_to_cart_action( $url = false ) {\n \t\t}\n \n \t\t// If we added the product to the cart we can now optionally do a redirect.\n-\t\tif ( $was_added_to_cart && wc_notice_count( 'error' ) === 0 ) {\n+\t\tif ( $was_added_to_cart && 0 === wc_notice_count( 'error' ) ) {","path":"includes/class-wc-form-handler.php","position":32,"original_position":32,"commit_id":"2e515d5c065d16de64393161ec6d1406bba0f300","original_commit_id":"2e515d5c065d16de64393161ec6d1406bba0f300","user":{"login":"mikejolley","id":90977,"avatar_url":"https://avatars2.githubusercontent.com/u/90977?v=4","gravatar_id":"","url":"https://api.github.com/users/mikejolley","html_url":"https://github.com/mikejolley","followers_url":"https://api.github.com/users/mikejolley/followers","following_url":"https://api.github.com/users/mikejolley/following{/other_user}","gists_url":"https://api.github.com/users/mikejolley/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejolley/subscriptions","organizations_url":"https://api.github.com/users/mikejolley/orgs","repos_url":"https://api.github.com/users/mikejolley/repos","events_url":"https://api.github.com/users/mikejolley/events{/privacy}","received_events_url":"https://api.github.com/users/mikejolley/received_events","type":"User","site_admin":false},"body":"There is extra white space","created_at":"2017-08-21T12:12:28Z","updated_at":"2017-08-21T12:12:42Z","html_url":"https://github.com/woocommerce/woocommerce/pull/16532#discussion_r134216464","pull_request_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/16532","_links":{"self":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments/134216464"},"html":{"href":"https://github.com/woocommerce/woocommerce/pull/16532#discussion_r134216464"},"pull_request":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/16532"}}},"pull_request":{"url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/16532","id":136594229,"html_url":"https://github.com/woocommerce/woocommerce/pull/16532","diff_url":"https://github.com/woocommerce/woocommerce/pull/16532.diff","patch_url":"https://github.com/woocommerce/woocommerce/pull/16532.patch","issue_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/16532","number":16532,"state":"open","locked":false,"title":"fix-condition","user":{"login":"Umangvaghela","id":26810472,"avatar_url":"https://avatars0.githubusercontent.com/u/26810472?v=4","gravatar_id":"","url":"https://api.github.com/users/Umangvaghela","html_url":"https://github.com/Umangvaghela","followers_url":"https://api.github.com/users/Umangvaghela/followers","following_url":"https://api.github.com/users/Umangvaghela/following{/other_user}","gists_url":"https://api.github.com/users/Umangvaghela/gists{/gist_id}","starred_url":"https://api.github.com/users/Umangvaghela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umangvaghela/subscriptions","organizations_url":"https://api.github.com/users/Umangvaghela/orgs","repos_url":"https://api.github.com/users/Umangvaghela/repos","events_url":"https://api.github.com/users/Umangvaghela/events{/privacy}","received_events_url":"https://api.github.com/users/Umangvaghela/received_events","type":"User","site_admin":false},"body":"fix-condition","created_at":"2017-08-19T05:28:05Z","updated_at":"2017-08-21T12:12:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42fe053988a2977330b101bffa0d9e41e47eb49f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/16532/commits","review_comments_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/16532/comments","review_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/16532/comments","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/2e515d5c065d16de64393161ec6d1406bba0f300","head":{"label":"Umangvaghela:fix-condition","ref":"fix-condition","sha":"2e515d5c065d16de64393161ec6d1406bba0f300","user":{"login":"Umangvaghela","id":26810472,"avatar_url":"https://avatars0.githubusercontent.com/u/26810472?v=4","gravatar_id":"","url":"https://api.github.com/users/Umangvaghela","html_url":"https://github.com/Umangvaghela","followers_url":"https://api.github.com/users/Umangvaghela/followers","following_url":"https://api.github.com/users/Umangvaghela/following{/other_user}","gists_url":"https://api.github.com/users/Umangvaghela/gists{/gist_id}","starred_url":"https://api.github.com/users/Umangvaghela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umangvaghela/subscriptions","organizations_url":"https://api.github.com/users/Umangvaghela/orgs","repos_url":"https://api.github.com/users/Umangvaghela/repos","events_url":"https://api.github.com/users/Umangvaghela/events{/privacy}","received_events_url":"https://api.github.com/users/Umangvaghela/received_events","type":"User","site_admin":false},"repo":{"id":86786448,"name":"woocommerce","full_name":"Umangvaghela/woocommerce","owner":{"login":"Umangvaghela","id":26810472,"avatar_url":"https://avatars0.githubusercontent.com/u/26810472?v=4","gravatar_id":"","url":"https://api.github.com/users/Umangvaghela","html_url":"https://github.com/Umangvaghela","followers_url":"https://api.github.com/users/Umangvaghela/followers","following_url":"https://api.github.com/users/Umangvaghela/following{/other_user}","gists_url":"https://api.github.com/users/Umangvaghela/gists{/gist_id}","starred_url":"https://api.github.com/users/Umangvaghela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umangvaghela/subscriptions","organizations_url":"https://api.github.com/users/Umangvaghela/orgs","repos_url":"https://api.github.com/users/Umangvaghela/repos","events_url":"https://api.github.com/users/Umangvaghela/events{/privacy}","received_events_url":"https://api.github.com/users/Umangvaghela/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Umangvaghela/woocommerce","description":"An open source eCommerce plugin for WordPress.","fork":true,"url":"https://api.github.com/repos/Umangvaghela/woocommerce","forks_url":"https://api.github.com/repos/Umangvaghela/woocommerce/forks","keys_url":"https://api.github.com/repos/Umangvaghela/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Umangvaghela/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Umangvaghela/woocommerce/teams","hooks_url":"https://api.github.com/repos/Umangvaghela/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/Umangvaghela/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/Umangvaghela/woocommerce/events","assignees_url":"https://api.github.com/repos/Umangvaghela/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/Umangvaghela/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/Umangvaghela/woocommerce/tags","blobs_url":"https://api.github.com/repos/Umangvaghela/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Umangvaghela/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Umangvaghela/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/Umangvaghela/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Umangvaghela/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/Umangvaghela/woocommerce/languages","stargazers_url":"https://api.github.com/repos/Umangvaghela/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/Umangvaghela/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/Umangvaghela/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/Umangvaghela/woocommerce/subscription","commits_url":"https://api.github.com/repos/Umangvaghela/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/Umangvaghela/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/Umangvaghela/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/Umangvaghela/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/Umangvaghela/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/Umangvaghela/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Umangvaghela/woocommerce/merges","archive_url":"https://api.github.com/repos/Umangvaghela/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Umangvaghela/woocommerce/downloads","issues_url":"https://api.github.com/repos/Umangvaghela/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/Umangvaghela/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/Umangvaghela/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/Umangvaghela/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Umangvaghela/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/Umangvaghela/woocommerce/releases{/id}","deployments_url":"https://api.github.com/repos/Umangvaghela/woocommerce/deployments","created_at":"2017-03-31T06:37:12Z","updated_at":"2017-03-31T06:37:21Z","pushed_at":"2017-08-19T05:27:18Z","git_url":"git://github.com/Umangvaghela/woocommerce.git","ssh_url":"[email protected]:Umangvaghela/woocommerce.git","clone_url":"https://github.com/Umangvaghela/woocommerce.git","svn_url":"https://github.com/Umangvaghela/woocommerce","homepage":"http://www.woocommerce.com/","size":130388,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"woocommerce:master","ref":"master","sha":"56b8829f46e1d68ec7d64f339c94755525f264b8","user":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":2179920,"name":"woocommerce","full_name":"woocommerce/woocommerce","owner":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/woocommerce/woocommerce","description":"An open source eCommerce plugin for WordPress.","fork":false,"url":"https://api.github.com/repos/woocommerce/woocommerce","forks_url":"https://api.github.com/repos/woocommerce/woocommerce/forks","keys_url":"https://api.github.com/repos/woocommerce/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/woocommerce/teams","hooks_url":"https://api.github.com/repos/woocommerce/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/woocommerce/events","assignees_url":"https://api.github.com/repos/woocommerce/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/woocommerce/tags","blobs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/woocommerce/languages","stargazers_url":"https://api.github.com/repos/woocommerce/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/woocommerce/subscription","commits_url":"https://api.github.com/repos/woocommerce/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/woocommerce/merges","archive_url":"https://api.github.com/repos/woocommerce/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/woocommerce/downloads","issues_url":"https://api.github.com/repos/woocommerce/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/woocommerce/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/woocommerce/deployments","created_at":"2011-08-09T15:12:11Z","updated_at":"2017-08-21T11:21:08Z","pushed_at":"2017-08-21T12:01:31Z","git_url":"git://github.com/woocommerce/woocommerce.git","ssh_url":"[email protected]:woocommerce/woocommerce.git","clone_url":"https://github.com/woocommerce/woocommerce.git","svn_url":"https://github.com/woocommerce/woocommerce","homepage":"http://www.woocommerce.com/","size":131701,"stargazers_count":3658,"watchers_count":3658,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3177,"mirror_url":null,"open_issues_count":60,"forks":3177,"open_issues":60,"watchers":3658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/16532"},"html":{"href":"https://github.com/woocommerce/woocommerce/pull/16532"},"issue":{"href":"https://api.github.com/repos/woocommerce/woocommerce/issues/16532"},"comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce/issues/16532/comments"},"review_comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/16532/comments"},"review_comment":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/16532/commits"},"statuses":{"href":"https://api.github.com/repos/woocommerce/woocommerce/statuses/2e515d5c065d16de64393161ec6d1406bba0f300"}}}} | {
"id": 2179920,
"name": "woocommerce/woocommerce",
"url": "https://api.github.com/repos/woocommerce/woocommerce"
} | {
"id": 90977,
"login": "mikejolley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/90977?",
"url": "https://api.github.com/users/mikejolley"
} | {
"id": 473596,
"login": "woocommerce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/473596?",
"url": "https://api.github.com/orgs/woocommerce"
} | 2017-08-21T12:12:28 | 6492216886 | {"actor":{"display_login":"mikejolley"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/0-complexity/G8_testing/pulls/comments/153196068","pull_request_review_id":79165812,"id":153196068,"diff_hunk":"@@ -73,20 +74,52 @@ def test003_check_connectivity_through_external_network(self):\n #. Check if you can ping VM1 from outside, should succeed\n \"\"\"\n \n- @unittest.skip('Not Implemented')\n def test004_migrate_vm_in_middle_of_writing_file(self):\n- \"\"\" OVC-000\n+ \"\"\" OVC-039\n *Test case for checking data integrity after migrating vm in the middle of writing a file*\n \n **Test Scenario:**\n \n #. Create a cloudspace CS1, should succeed\n- #. Create VM1\n+ #. Create VM1, should succeed\n #. Write a big file FS1 on VM1\n #. Migrate VM1 in the middle of writing a file, should succeed\n #. Check if the file has been written correctly after vm live migration\n \"\"\"\n- # Note: this testcase may be hard to be implemented from here.\n+ self.lg('%s STARTED' % self._testID)\n+\n+ self.lg(\"Create VM1,should succeed.\")\n+ vm1_id = self.cloudapi_create_machine(cloudspace_id=self.cloudspace_id)\n+ self.assertTrue(vm1_id)","path":"functional_testing/Openvcloud/ovc_master_hosted/OVC/c_advanced/machine_tests.py","position":32,"original_position":32,"commit_id":"efe7cf36a825d918bfdd38eb2cbd46e0ef97b7b1","original_commit_id":"efe7cf36a825d918bfdd38eb2cbd46e0ef97b7b1","user":{"login":"ahmedelsayed-93","id":24386820,"avatar_url":"https://avatars1.githubusercontent.com/u/24386820?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmedelsayed-93","html_url":"https://github.com/ahmedelsayed-93","followers_url":"https://api.github.com/users/ahmedelsayed-93/followers","following_url":"https://api.github.com/users/ahmedelsayed-93/following{/other_user}","gists_url":"https://api.github.com/users/ahmedelsayed-93/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedelsayed-93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedelsayed-93/subscriptions","organizations_url":"https://api.github.com/users/ahmedelsayed-93/orgs","repos_url":"https://api.github.com/users/ahmedelsayed-93/repos","events_url":"https://api.github.com/users/ahmedelsayed-93/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedelsayed-93/received_events","type":"User","site_admin":false},"body":"no need for this line, `cloudapi_create_machine` method already assert for the machine id\r\nhttps://github.com/0-complexity/G8_testing/blob/dd1c6dc70c64eefdae6ce9916c5d0535efd3ae23/functional_testing/Openvcloud/utils/utils.py#L225","created_at":"2017-11-27T13:31:51Z","updated_at":"2017-11-27T13:31:51Z","html_url":"https://github.com/0-complexity/G8_testing/pull/251#discussion_r153196068","pull_request_url":"https://api.github.com/repos/0-complexity/G8_testing/pulls/251","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/0-complexity/G8_testing/pulls/comments/153196068"},"html":{"href":"https://github.com/0-complexity/G8_testing/pull/251#discussion_r153196068"},"pull_request":{"href":"https://api.github.com/repos/0-complexity/G8_testing/pulls/251"}}},"pull_request":{"url":"https://api.github.com/repos/0-complexity/G8_testing/pulls/251","id":154783287,"html_url":"https://github.com/0-complexity/G8_testing/pull/251","diff_url":"https://github.com/0-complexity/G8_testing/pull/251.diff","patch_url":"https://github.com/0-complexity/G8_testing/pull/251.patch","issue_url":"https://api.github.com/repos/0-complexity/G8_testing/issues/251","number":251,"state":"open","locked":false,"title":"Task 238","user":{"login":"john-kheir","id":15011431,"avatar_url":"https://avatars1.githubusercontent.com/u/15011431?v=4","gravatar_id":"","url":"https://api.github.com/users/john-kheir","html_url":"https://github.com/john-kheir","followers_url":"https://api.github.com/users/john-kheir/followers","following_url":"https://api.github.com/users/john-kheir/following{/other_user}","gists_url":"https://api.github.com/users/john-kheir/gists{/gist_id}","starred_url":"https://api.github.com/users/john-kheir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-kheir/subscriptions","organizations_url":"https://api.github.com/users/john-kheir/orgs","repos_url":"https://api.github.com/users/john-kheir/repos","events_url":"https://api.github.com/users/john-kheir/events{/privacy}","received_events_url":"https://api.github.com/users/john-kheir/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/0-complexity/G8_testing/issues/238","created_at":"2017-11-27T11:17:59Z","updated_at":"2017-11-27T13:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a223bd10ccdbdbf62a6f2671a669b2ff56f8cb58","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/0-complexity/G8_testing/pulls/251/commits","review_comments_url":"https://api.github.com/repos/0-complexity/G8_testing/pulls/251/comments","review_comment_url":"https://api.github.com/repos/0-complexity/G8_testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0-complexity/G8_testing/issues/251/comments","statuses_url":"https://api.github.com/repos/0-complexity/G8_testing/statuses/efe7cf36a825d918bfdd38eb2cbd46e0ef97b7b1","head":{"label":"0-complexity:task-238","ref":"task-238","sha":"efe7cf36a825d918bfdd38eb2cbd46e0ef97b7b1","user":{"login":"0-complexity","id":9442740,"avatar_url":"https://avatars1.githubusercontent.com/u/9442740?v=4","gravatar_id":"","url":"https://api.github.com/users/0-complexity","html_url":"https://github.com/0-complexity","followers_url":"https://api.github.com/users/0-complexity/followers","following_url":"https://api.github.com/users/0-complexity/following{/other_user}","gists_url":"https://api.github.com/users/0-complexity/gists{/gist_id}","starred_url":"https://api.github.com/users/0-complexity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0-complexity/subscriptions","organizations_url":"https://api.github.com/users/0-complexity/orgs","repos_url":"https://api.github.com/users/0-complexity/repos","events_url":"https://api.github.com/users/0-complexity/events{/privacy}","received_events_url":"https://api.github.com/users/0-complexity/received_events","type":"Organization","site_admin":false},"repo":{"id":66453761,"name":"G8_testing","full_name":"0-complexity/G8_testing","owner":{"login":"0-complexity","id":9442740,"avatar_url":"https://avatars1.githubusercontent.com/u/9442740?v=4","gravatar_id":"","url":"https://api.github.com/users/0-complexity","html_url":"https://github.com/0-complexity","followers_url":"https://api.github.com/users/0-complexity/followers","following_url":"https://api.github.com/users/0-complexity/following{/other_user}","gists_url":"https://api.github.com/users/0-complexity/gists{/gist_id}","starred_url":"https://api.github.com/users/0-complexity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0-complexity/subscriptions","organizations_url":"https://api.github.com/users/0-complexity/orgs","repos_url":"https://api.github.com/users/0-complexity/repos","events_url":"https://api.github.com/users/0-complexity/events{/privacy}","received_events_url":"https://api.github.com/users/0-complexity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0-complexity/G8_testing","description":null,"fork":false,"url":"https://api.github.com/repos/0-complexity/G8_testing","forks_url":"https://api.github.com/repos/0-complexity/G8_testing/forks","keys_url":"https://api.github.com/repos/0-complexity/G8_testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0-complexity/G8_testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0-complexity/G8_testing/teams","hooks_url":"https://api.github.com/repos/0-complexity/G8_testing/hooks","issue_events_url":"https://api.github.com/repos/0-complexity/G8_testing/issues/events{/number}","events_url":"https://api.github.com/repos/0-complexity/G8_testing/events","assignees_url":"https://api.github.com/repos/0-complexity/G8_testing/assignees{/user}","branches_url":"https://api.github.com/repos/0-complexity/G8_testing/branches{/branch}","tags_url":"https://api.github.com/repos/0-complexity/G8_testing/tags","blobs_url":"https://api.github.com/repos/0-complexity/G8_testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0-complexity/G8_testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0-complexity/G8_testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/0-complexity/G8_testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0-complexity/G8_testing/statuses/{sha}","languages_url":"https://api.github.com/repos/0-complexity/G8_testing/languages","stargazers_url":"https://api.github.com/repos/0-complexity/G8_testing/stargazers","contributors_url":"https://api.github.com/repos/0-complexity/G8_testing/contributors","subscribers_url":"https://api.github.com/repos/0-complexity/G8_testing/subscribers","subscription_url":"https://api.github.com/repos/0-complexity/G8_testing/subscription","commits_url":"https://api.github.com/repos/0-complexity/G8_testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/0-complexity/G8_testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/0-complexity/G8_testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/0-complexity/G8_testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/0-complexity/G8_testing/contents/{+path}","compare_url":"https://api.github.com/repos/0-complexity/G8_testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0-complexity/G8_testing/merges","archive_url":"https://api.github.com/repos/0-complexity/G8_testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0-complexity/G8_testing/downloads","issues_url":"https://api.github.com/repos/0-complexity/G8_testing/issues{/number}","pulls_url":"https://api.github.com/repos/0-complexity/G8_testing/pulls{/number}","milestones_url":"https://api.github.com/repos/0-complexity/G8_testing/milestones{/number}","notifications_url":"https://api.github.com/repos/0-complexity/G8_testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0-complexity/G8_testing/labels{/name}","releases_url":"https://api.github.com/repos/0-complexity/G8_testing/releases{/id}","deployments_url":"https://api.github.com/repos/0-complexity/G8_testing/deployments","created_at":"2016-08-24T10:10:17Z","updated_at":"2017-11-26T07:09:40Z","pushed_at":"2017-11-27T13:09:48Z","git_url":"git://github.com/0-complexity/G8_testing.git","ssh_url":"[email protected]:0-complexity/G8_testing.git","clone_url":"https://github.com/0-complexity/G8_testing.git","svn_url":"https://github.com/0-complexity/G8_testing","homepage":null,"size":8579,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":1,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"0-complexity:master","ref":"master","sha":"c38bb01d9933d5845ac523c31dd25d3eb0ce7453","user":{"login":"0-complexity","id":9442740,"avatar_url":"https://avatars1.githubusercontent.com/u/9442740?v=4","gravatar_id":"","url":"https://api.github.com/users/0-complexity","html_url":"https://github.com/0-complexity","followers_url":"https://api.github.com/users/0-complexity/followers","following_url":"https://api.github.com/users/0-complexity/following{/other_user}","gists_url":"https://api.github.com/users/0-complexity/gists{/gist_id}","starred_url":"https://api.github.com/users/0-complexity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0-complexity/subscriptions","organizations_url":"https://api.github.com/users/0-complexity/orgs","repos_url":"https://api.github.com/users/0-complexity/repos","events_url":"https://api.github.com/users/0-complexity/events{/privacy}","received_events_url":"https://api.github.com/users/0-complexity/received_events","type":"Organization","site_admin":false},"repo":{"id":66453761,"name":"G8_testing","full_name":"0-complexity/G8_testing","owner":{"login":"0-complexity","id":9442740,"avatar_url":"https://avatars1.githubusercontent.com/u/9442740?v=4","gravatar_id":"","url":"https://api.github.com/users/0-complexity","html_url":"https://github.com/0-complexity","followers_url":"https://api.github.com/users/0-complexity/followers","following_url":"https://api.github.com/users/0-complexity/following{/other_user}","gists_url":"https://api.github.com/users/0-complexity/gists{/gist_id}","starred_url":"https://api.github.com/users/0-complexity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0-complexity/subscriptions","organizations_url":"https://api.github.com/users/0-complexity/orgs","repos_url":"https://api.github.com/users/0-complexity/repos","events_url":"https://api.github.com/users/0-complexity/events{/privacy}","received_events_url":"https://api.github.com/users/0-complexity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0-complexity/G8_testing","description":null,"fork":false,"url":"https://api.github.com/repos/0-complexity/G8_testing","forks_url":"https://api.github.com/repos/0-complexity/G8_testing/forks","keys_url":"https://api.github.com/repos/0-complexity/G8_testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0-complexity/G8_testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0-complexity/G8_testing/teams","hooks_url":"https://api.github.com/repos/0-complexity/G8_testing/hooks","issue_events_url":"https://api.github.com/repos/0-complexity/G8_testing/issues/events{/number}","events_url":"https://api.github.com/repos/0-complexity/G8_testing/events","assignees_url":"https://api.github.com/repos/0-complexity/G8_testing/assignees{/user}","branches_url":"https://api.github.com/repos/0-complexity/G8_testing/branches{/branch}","tags_url":"https://api.github.com/repos/0-complexity/G8_testing/tags","blobs_url":"https://api.github.com/repos/0-complexity/G8_testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0-complexity/G8_testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0-complexity/G8_testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/0-complexity/G8_testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0-complexity/G8_testing/statuses/{sha}","languages_url":"https://api.github.com/repos/0-complexity/G8_testing/languages","stargazers_url":"https://api.github.com/repos/0-complexity/G8_testing/stargazers","contributors_url":"https://api.github.com/repos/0-complexity/G8_testing/contributors","subscribers_url":"https://api.github.com/repos/0-complexity/G8_testing/subscribers","subscription_url":"https://api.github.com/repos/0-complexity/G8_testing/subscription","commits_url":"https://api.github.com/repos/0-complexity/G8_testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/0-complexity/G8_testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/0-complexity/G8_testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/0-complexity/G8_testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/0-complexity/G8_testing/contents/{+path}","compare_url":"https://api.github.com/repos/0-complexity/G8_testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0-complexity/G8_testing/merges","archive_url":"https://api.github.com/repos/0-complexity/G8_testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0-complexity/G8_testing/downloads","issues_url":"https://api.github.com/repos/0-complexity/G8_testing/issues{/number}","pulls_url":"https://api.github.com/repos/0-complexity/G8_testing/pulls{/number}","milestones_url":"https://api.github.com/repos/0-complexity/G8_testing/milestones{/number}","notifications_url":"https://api.github.com/repos/0-complexity/G8_testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0-complexity/G8_testing/labels{/name}","releases_url":"https://api.github.com/repos/0-complexity/G8_testing/releases{/id}","deployments_url":"https://api.github.com/repos/0-complexity/G8_testing/deployments","created_at":"2016-08-24T10:10:17Z","updated_at":"2017-11-26T07:09:40Z","pushed_at":"2017-11-27T13:09:48Z","git_url":"git://github.com/0-complexity/G8_testing.git","ssh_url":"[email protected]:0-complexity/G8_testing.git","clone_url":"https://github.com/0-complexity/G8_testing.git","svn_url":"https://github.com/0-complexity/G8_testing","homepage":null,"size":8579,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":1,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/0-complexity/G8_testing/pulls/251"},"html":{"href":"https://github.com/0-complexity/G8_testing/pull/251"},"issue":{"href":"https://api.github.com/repos/0-complexity/G8_testing/issues/251"},"comments":{"href":"https://api.github.com/repos/0-complexity/G8_testing/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/0-complexity/G8_testing/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/0-complexity/G8_testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0-complexity/G8_testing/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/0-complexity/G8_testing/statuses/efe7cf36a825d918bfdd38eb2cbd46e0ef97b7b1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 66453761,
"name": "0-complexity/G8_testing",
"url": "https://api.github.com/repos/0-complexity/G8_testing"
} | {
"id": 24386820,
"login": "ahmedelsayed-93",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24386820?",
"url": "https://api.github.com/users/ahmedelsayed-93"
} | {
"id": 9442740,
"login": "0-complexity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9442740?",
"url": "https://api.github.com/orgs/0-complexity"
} | 2017-11-27T13:31:51 | 6907021427 | {"actor":{"display_login":"ahmedelsayed-93"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/comments/94674830","pull_request_review_id":15208103,"id":94674830,"diff_hunk":"@@ -0,0 +1,183 @@\n+# Copyright (C) 2015-2016 Regents of the University of California\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+from __future__ import absolute_import\n+import logging\n+import os\n+from abc import ABCMeta, abstractmethod\n+from threading import Thread\n+from Queue import Queue, Empty\n+import time\n+\n+logging.basicConfig(level=logging.DEBUG)\n+logger = logging.getLogger(__name__)\n+\n+class AbstractGridEngineWorker(Thread):","path":"src/toil/batchSystems/abstractGridEngineWorker.py","position":null,"original_position":26,"commit_id":"e278422c2008f40e94e2db68f5cfef170931f19a","original_commit_id":"a4f8ef37f2d4e6379bb06a89f1206f2167796a9a","user":{"login":"cjfields","id":49265,"avatar_url":"https://avatars.githubusercontent.com/u/49265?v=3","gravatar_id":"","url":"https://api.github.com/users/cjfields","html_url":"https://github.com/cjfields","followers_url":"https://api.github.com/users/cjfields/followers","following_url":"https://api.github.com/users/cjfields/following{/other_user}","gists_url":"https://api.github.com/users/cjfields/gists{/gist_id}","starred_url":"https://api.github.com/users/cjfields/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjfields/subscriptions","organizations_url":"https://api.github.com/users/cjfields/orgs","repos_url":"https://api.github.com/users/cjfields/repos","events_url":"https://api.github.com/users/cjfields/events{/privacy}","received_events_url":"https://api.github.com/users/cjfields/received_events","type":"User","site_admin":false},"body":"Moved into `AbstractGridEngineBatchSystem` in a6bd60f","created_at":"2017-01-04T22:03:55Z","updated_at":"2017-01-04T22:03:55Z","html_url":"https://github.com/BD2KGenomics/toil/pull/1195#discussion_r94674830","pull_request_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1195","_links":{"self":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/comments/94674830"},"html":{"href":"https://github.com/BD2KGenomics/toil/pull/1195#discussion_r94674830"},"pull_request":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1195"}}},"pull_request":{"url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1195","id":88329906,"html_url":"https://github.com/BD2KGenomics/toil/pull/1195","diff_url":"https://github.com/BD2KGenomics/toil/pull/1195.diff","patch_url":"https://github.com/BD2KGenomics/toil/pull/1195.patch","issue_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/1195","number":1195,"state":"open","locked":false,"title":"Initial PBS/Torque support","user":{"login":"cjfields","id":49265,"avatar_url":"https://avatars.githubusercontent.com/u/49265?v=3","gravatar_id":"","url":"https://api.github.com/users/cjfields","html_url":"https://github.com/cjfields","followers_url":"https://api.github.com/users/cjfields/followers","following_url":"https://api.github.com/users/cjfields/following{/other_user}","gists_url":"https://api.github.com/users/cjfields/gists{/gist_id}","starred_url":"https://api.github.com/users/cjfields/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjfields/subscriptions","organizations_url":"https://api.github.com/users/cjfields/orgs","repos_url":"https://api.github.com/users/cjfields/repos","events_url":"https://api.github.com/users/cjfields/events{/privacy}","received_events_url":"https://api.github.com/users/cjfields/received_events","type":"User","site_admin":false},"body":"This is a preliminary run at adding PBS/Torque support, designed off the SLURM and SGE classes. Tests have also been added.\r\n\r\nResolves #1163 \r\n","created_at":"2016-10-06T19:55:59Z","updated_at":"2017-01-04T22:03:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43e59bdd8c285213d2e06d1b9f833c8827451a21","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1195/commits","review_comments_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1195/comments","review_comment_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/1195/comments","statuses_url":"https://api.github.com/repos/BD2KGenomics/toil/statuses/e278422c2008f40e94e2db68f5cfef170931f19a","head":{"label":"HPCBio:issues/1163-pbs-support","ref":"issues/1163-pbs-support","sha":"e278422c2008f40e94e2db68f5cfef170931f19a","user":{"login":"HPCBio","id":1896272,"avatar_url":"https://avatars.githubusercontent.com/u/1896272?v=3","gravatar_id":"","url":"https://api.github.com/users/HPCBio","html_url":"https://github.com/HPCBio","followers_url":"https://api.github.com/users/HPCBio/followers","following_url":"https://api.github.com/users/HPCBio/following{/other_user}","gists_url":"https://api.github.com/users/HPCBio/gists{/gist_id}","starred_url":"https://api.github.com/users/HPCBio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HPCBio/subscriptions","organizations_url":"https://api.github.com/users/HPCBio/orgs","repos_url":"https://api.github.com/users/HPCBio/repos","events_url":"https://api.github.com/users/HPCBio/events{/privacy}","received_events_url":"https://api.github.com/users/HPCBio/received_events","type":"Organization","site_admin":false},"repo":{"id":69927177,"name":"toil","full_name":"HPCBio/toil","owner":{"login":"HPCBio","id":1896272,"avatar_url":"https://avatars.githubusercontent.com/u/1896272?v=3","gravatar_id":"","url":"https://api.github.com/users/HPCBio","html_url":"https://github.com/HPCBio","followers_url":"https://api.github.com/users/HPCBio/followers","following_url":"https://api.github.com/users/HPCBio/following{/other_user}","gists_url":"https://api.github.com/users/HPCBio/gists{/gist_id}","starred_url":"https://api.github.com/users/HPCBio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HPCBio/subscriptions","organizations_url":"https://api.github.com/users/HPCBio/orgs","repos_url":"https://api.github.com/users/HPCBio/repos","events_url":"https://api.github.com/users/HPCBio/events{/privacy}","received_events_url":"https://api.github.com/users/HPCBio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HPCBio/toil","description":"A scalable, efficient, cross-platform and easy-to-use workflow engine in pure Python","fork":true,"url":"https://api.github.com/repos/HPCBio/toil","forks_url":"https://api.github.com/repos/HPCBio/toil/forks","keys_url":"https://api.github.com/repos/HPCBio/toil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HPCBio/toil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HPCBio/toil/teams","hooks_url":"https://api.github.com/repos/HPCBio/toil/hooks","issue_events_url":"https://api.github.com/repos/HPCBio/toil/issues/events{/number}","events_url":"https://api.github.com/repos/HPCBio/toil/events","assignees_url":"https://api.github.com/repos/HPCBio/toil/assignees{/user}","branches_url":"https://api.github.com/repos/HPCBio/toil/branches{/branch}","tags_url":"https://api.github.com/repos/HPCBio/toil/tags","blobs_url":"https://api.github.com/repos/HPCBio/toil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HPCBio/toil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HPCBio/toil/git/refs{/sha}","trees_url":"https://api.github.com/repos/HPCBio/toil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HPCBio/toil/statuses/{sha}","languages_url":"https://api.github.com/repos/HPCBio/toil/languages","stargazers_url":"https://api.github.com/repos/HPCBio/toil/stargazers","contributors_url":"https://api.github.com/repos/HPCBio/toil/contributors","subscribers_url":"https://api.github.com/repos/HPCBio/toil/subscribers","subscription_url":"https://api.github.com/repos/HPCBio/toil/subscription","commits_url":"https://api.github.com/repos/HPCBio/toil/commits{/sha}","git_commits_url":"https://api.github.com/repos/HPCBio/toil/git/commits{/sha}","comments_url":"https://api.github.com/repos/HPCBio/toil/comments{/number}","issue_comment_url":"https://api.github.com/repos/HPCBio/toil/issues/comments{/number}","contents_url":"https://api.github.com/repos/HPCBio/toil/contents/{+path}","compare_url":"https://api.github.com/repos/HPCBio/toil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HPCBio/toil/merges","archive_url":"https://api.github.com/repos/HPCBio/toil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HPCBio/toil/downloads","issues_url":"https://api.github.com/repos/HPCBio/toil/issues{/number}","pulls_url":"https://api.github.com/repos/HPCBio/toil/pulls{/number}","milestones_url":"https://api.github.com/repos/HPCBio/toil/milestones{/number}","notifications_url":"https://api.github.com/repos/HPCBio/toil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HPCBio/toil/labels{/name}","releases_url":"https://api.github.com/repos/HPCBio/toil/releases{/id}","deployments_url":"https://api.github.com/repos/HPCBio/toil/deployments","created_at":"2016-10-04T02:06:12Z","updated_at":"2016-10-04T02:06:15Z","pushed_at":"2017-01-04T22:00:42Z","git_url":"git://github.com/HPCBio/toil.git","ssh_url":"[email protected]:HPCBio/toil.git","clone_url":"https://github.com/HPCBio/toil.git","svn_url":"https://github.com/HPCBio/toil","homepage":"","size":7059,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BD2KGenomics:master","ref":"master","sha":"88fa45e453088a109ff7f83660daa4e6d8283d25","user":{"login":"BD2KGenomics","id":8701293,"avatar_url":"https://avatars.githubusercontent.com/u/8701293?v=3","gravatar_id":"","url":"https://api.github.com/users/BD2KGenomics","html_url":"https://github.com/BD2KGenomics","followers_url":"https://api.github.com/users/BD2KGenomics/followers","following_url":"https://api.github.com/users/BD2KGenomics/following{/other_user}","gists_url":"https://api.github.com/users/BD2KGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/BD2KGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BD2KGenomics/subscriptions","organizations_url":"https://api.github.com/users/BD2KGenomics/orgs","repos_url":"https://api.github.com/users/BD2KGenomics/repos","events_url":"https://api.github.com/users/BD2KGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/BD2KGenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":33148320,"name":"toil","full_name":"BD2KGenomics/toil","owner":{"login":"BD2KGenomics","id":8701293,"avatar_url":"https://avatars.githubusercontent.com/u/8701293?v=3","gravatar_id":"","url":"https://api.github.com/users/BD2KGenomics","html_url":"https://github.com/BD2KGenomics","followers_url":"https://api.github.com/users/BD2KGenomics/followers","following_url":"https://api.github.com/users/BD2KGenomics/following{/other_user}","gists_url":"https://api.github.com/users/BD2KGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/BD2KGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BD2KGenomics/subscriptions","organizations_url":"https://api.github.com/users/BD2KGenomics/orgs","repos_url":"https://api.github.com/users/BD2KGenomics/repos","events_url":"https://api.github.com/users/BD2KGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/BD2KGenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BD2KGenomics/toil","description":"A scalable, efficient, cross-platform and easy-to-use workflow engine in pure Python","fork":false,"url":"https://api.github.com/repos/BD2KGenomics/toil","forks_url":"https://api.github.com/repos/BD2KGenomics/toil/forks","keys_url":"https://api.github.com/repos/BD2KGenomics/toil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BD2KGenomics/toil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BD2KGenomics/toil/teams","hooks_url":"https://api.github.com/repos/BD2KGenomics/toil/hooks","issue_events_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/events{/number}","events_url":"https://api.github.com/repos/BD2KGenomics/toil/events","assignees_url":"https://api.github.com/repos/BD2KGenomics/toil/assignees{/user}","branches_url":"https://api.github.com/repos/BD2KGenomics/toil/branches{/branch}","tags_url":"https://api.github.com/repos/BD2KGenomics/toil/tags","blobs_url":"https://api.github.com/repos/BD2KGenomics/toil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BD2KGenomics/toil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BD2KGenomics/toil/git/refs{/sha}","trees_url":"https://api.github.com/repos/BD2KGenomics/toil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BD2KGenomics/toil/statuses/{sha}","languages_url":"https://api.github.com/repos/BD2KGenomics/toil/languages","stargazers_url":"https://api.github.com/repos/BD2KGenomics/toil/stargazers","contributors_url":"https://api.github.com/repos/BD2KGenomics/toil/contributors","subscribers_url":"https://api.github.com/repos/BD2KGenomics/toil/subscribers","subscription_url":"https://api.github.com/repos/BD2KGenomics/toil/subscription","commits_url":"https://api.github.com/repos/BD2KGenomics/toil/commits{/sha}","git_commits_url":"https://api.github.com/repos/BD2KGenomics/toil/git/commits{/sha}","comments_url":"https://api.github.com/repos/BD2KGenomics/toil/comments{/number}","issue_comment_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/comments{/number}","contents_url":"https://api.github.com/repos/BD2KGenomics/toil/contents/{+path}","compare_url":"https://api.github.com/repos/BD2KGenomics/toil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BD2KGenomics/toil/merges","archive_url":"https://api.github.com/repos/BD2KGenomics/toil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BD2KGenomics/toil/downloads","issues_url":"https://api.github.com/repos/BD2KGenomics/toil/issues{/number}","pulls_url":"https://api.github.com/repos/BD2KGenomics/toil/pulls{/number}","milestones_url":"https://api.github.com/repos/BD2KGenomics/toil/milestones{/number}","notifications_url":"https://api.github.com/repos/BD2KGenomics/toil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BD2KGenomics/toil/labels{/name}","releases_url":"https://api.github.com/repos/BD2KGenomics/toil/releases{/id}","deployments_url":"https://api.github.com/repos/BD2KGenomics/toil/deployments","created_at":"2015-03-30T21:08:58Z","updated_at":"2017-01-03T09:23:49Z","pushed_at":"2017-01-04T22:00:44Z","git_url":"git://github.com/BD2KGenomics/toil.git","ssh_url":"[email protected]:BD2KGenomics/toil.git","clone_url":"https://github.com/BD2KGenomics/toil.git","svn_url":"https://github.com/BD2KGenomics/toil","homepage":"","size":7612,"stargazers_count":279,"watchers_count":279,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":183,"forks":60,"open_issues":183,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1195"},"html":{"href":"https://github.com/BD2KGenomics/toil/pull/1195"},"issue":{"href":"https://api.github.com/repos/BD2KGenomics/toil/issues/1195"},"comments":{"href":"https://api.github.com/repos/BD2KGenomics/toil/issues/1195/comments"},"review_comments":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1195/comments"},"review_comment":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1195/commits"},"statuses":{"href":"https://api.github.com/repos/BD2KGenomics/toil/statuses/e278422c2008f40e94e2db68f5cfef170931f19a"}}}} | {
"id": 33148320,
"name": "BD2KGenomics/toil",
"url": "https://api.github.com/repos/BD2KGenomics/toil"
} | {
"id": 49265,
"login": "cjfields",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49265?",
"url": "https://api.github.com/users/cjfields"
} | {
"id": 8701293,
"login": "BD2KGenomics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8701293?",
"url": "https://api.github.com/orgs/BD2KGenomics"
} | 2017-01-04T22:03:55 | 5103645769 | {"actor":{"display_login":"cjfields"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/156476396","pull_request_review_id":82959657,"id":156476396,"diff_hunk":"@@ -138,6 +139,66 @@\n \tlog_and_message_admins(\" - DirectNarrate to ([M.name]/[M.key]): [msg]\")\n \tfeedback_add_details(\"admin_verb\",\"DIRN\") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!\n \n+// Local narrate, narrates to everyone who can see where you are regardless of whether they are blind or deaf.\n+/client/proc/cmd_admin_local_narrate(var/atom/A)\n+\tset category = \"Special Verbs\"\n+\tset name = \"Local Narrate\"\n+\n+\tvar/list/listening_hosts = hosts_in_view_range(usr)\n+\n+\tvar/msg = sanitize(input(\"Message:\", text(\"Enter the text you wish to appear to your target:\")) as text)\n+\n+\tif( !msg )\n+\t\treturn\n+\n+\tfor(var/listener in listening_hosts)\n+\t\tto_chat(listener, msg)\n+\tlog_and_message_admins(\" - LocalNarrate: [msg]\")\n+\n+// Visible narrate, it's as if it's a visible message\n+/client/proc/cmd_admin_visible_narrate(var/atom/A)\n+\tset category = \"Special Verbs\"\n+\tset name = \"Visible Narrate\"\n+\tif(!holder)","path":"code/modules/admin/verbs/randomverbs.dm","position":34,"original_position":34,"commit_id":"ac2b30ea452974fe854683026b8451f6950ed9ee","original_commit_id":"ac2b30ea452974fe854683026b8451f6950ed9ee","user":{"login":"PsiOmegaDelta","id":496895,"avatar_url":"https://avatars2.githubusercontent.com/u/496895?v=4","gravatar_id":"","url":"https://api.github.com/users/PsiOmegaDelta","html_url":"https://github.com/PsiOmegaDelta","followers_url":"https://api.github.com/users/PsiOmegaDelta/followers","following_url":"https://api.github.com/users/PsiOmegaDelta/following{/other_user}","gists_url":"https://api.github.com/users/PsiOmegaDelta/gists{/gist_id}","starred_url":"https://api.github.com/users/PsiOmegaDelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PsiOmegaDelta/subscriptions","organizations_url":"https://api.github.com/users/PsiOmegaDelta/orgs","repos_url":"https://api.github.com/users/PsiOmegaDelta/repos","events_url":"https://api.github.com/users/PsiOmegaDelta/events{/privacy}","received_events_url":"https://api.github.com/users/PsiOmegaDelta/received_events","type":"User","site_admin":false},"body":"Use `check_rights()` with appropriate permission flags.","created_at":"2017-12-12T19:49:01Z","updated_at":"2017-12-12T19:50:18Z","html_url":"https://github.com/Baystation12/Baystation12/pull/19775#discussion_r156476396","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19775","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/156476396"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/19775#discussion_r156476396"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19775"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19775","id":157893717,"html_url":"https://github.com/Baystation12/Baystation12/pull/19775","diff_url":"https://github.com/Baystation12/Baystation12/pull/19775.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/19775.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/19775","number":19775,"state":"open","locked":false,"title":"Audible and visible narrate","user":{"login":"FTangSteve","id":21090264,"avatar_url":"https://avatars0.githubusercontent.com/u/21090264?v=4","gravatar_id":"","url":"https://api.github.com/users/FTangSteve","html_url":"https://github.com/FTangSteve","followers_url":"https://api.github.com/users/FTangSteve/followers","following_url":"https://api.github.com/users/FTangSteve/following{/other_user}","gists_url":"https://api.github.com/users/FTangSteve/gists{/gist_id}","starred_url":"https://api.github.com/users/FTangSteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTangSteve/subscriptions","organizations_url":"https://api.github.com/users/FTangSteve/orgs","repos_url":"https://api.github.com/users/FTangSteve/repos","events_url":"https://api.github.com/users/FTangSteve/events{/privacy}","received_events_url":"https://api.github.com/users/FTangSteve/received_events","type":"User","site_admin":false},"body":"<!-- \r\nDo not forget to add a changelog when you have made admin/player facing changes that can alter gameplay.\r\nExamples which require a changelog entry include:\r\n* Adding/removing objects that players may interact with, or the way they function.\r\n* Adding/removing/altering admin tools.\r\n* Changing the map.\r\n\r\nExamples were changelog entries are optional/not typically required:\r\n* Cosmetic changes such as descriptions, sound effects, etc.\r\n* Optimizations and other changes to underlying systems which do not affect gameplay.\r\n* Minor bug fixes.\r\n\r\nYou find a README and example file in .\\html\\changelogs\\ for further instructions.\r\n-->\r\n","created_at":"2017-12-12T17:39:48Z","updated_at":"2017-12-12T19:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e56a81f7195522e41c40523ea9ddab3efeda0808","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19775/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19775/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/19775/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/ac2b30ea452974fe854683026b8451f6950ed9ee","head":{"label":"FTangSteve:localNarrate","ref":"localNarrate","sha":"ac2b30ea452974fe854683026b8451f6950ed9ee","user":{"login":"FTangSteve","id":21090264,"avatar_url":"https://avatars0.githubusercontent.com/u/21090264?v=4","gravatar_id":"","url":"https://api.github.com/users/FTangSteve","html_url":"https://github.com/FTangSteve","followers_url":"https://api.github.com/users/FTangSteve/followers","following_url":"https://api.github.com/users/FTangSteve/following{/other_user}","gists_url":"https://api.github.com/users/FTangSteve/gists{/gist_id}","starred_url":"https://api.github.com/users/FTangSteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTangSteve/subscriptions","organizations_url":"https://api.github.com/users/FTangSteve/orgs","repos_url":"https://api.github.com/users/FTangSteve/repos","events_url":"https://api.github.com/users/FTangSteve/events{/privacy}","received_events_url":"https://api.github.com/users/FTangSteve/received_events","type":"User","site_admin":false},"repo":{"id":73750699,"name":"Baystation12","full_name":"FTangSteve/Baystation12","owner":{"login":"FTangSteve","id":21090264,"avatar_url":"https://avatars0.githubusercontent.com/u/21090264?v=4","gravatar_id":"","url":"https://api.github.com/users/FTangSteve","html_url":"https://github.com/FTangSteve","followers_url":"https://api.github.com/users/FTangSteve/followers","following_url":"https://api.github.com/users/FTangSteve/following{/other_user}","gists_url":"https://api.github.com/users/FTangSteve/gists{/gist_id}","starred_url":"https://api.github.com/users/FTangSteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTangSteve/subscriptions","organizations_url":"https://api.github.com/users/FTangSteve/orgs","repos_url":"https://api.github.com/users/FTangSteve/repos","events_url":"https://api.github.com/users/FTangSteve/events{/privacy}","received_events_url":"https://api.github.com/users/FTangSteve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FTangSteve/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/FTangSteve/Baystation12","forks_url":"https://api.github.com/repos/FTangSteve/Baystation12/forks","keys_url":"https://api.github.com/repos/FTangSteve/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTangSteve/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTangSteve/Baystation12/teams","hooks_url":"https://api.github.com/repos/FTangSteve/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/FTangSteve/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/FTangSteve/Baystation12/events","assignees_url":"https://api.github.com/repos/FTangSteve/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/FTangSteve/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/FTangSteve/Baystation12/tags","blobs_url":"https://api.github.com/repos/FTangSteve/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTangSteve/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTangSteve/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTangSteve/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTangSteve/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/FTangSteve/Baystation12/languages","stargazers_url":"https://api.github.com/repos/FTangSteve/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/FTangSteve/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/FTangSteve/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/FTangSteve/Baystation12/subscription","commits_url":"https://api.github.com/repos/FTangSteve/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTangSteve/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTangSteve/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTangSteve/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTangSteve/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/FTangSteve/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTangSteve/Baystation12/merges","archive_url":"https://api.github.com/repos/FTangSteve/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTangSteve/Baystation12/downloads","issues_url":"https://api.github.com/repos/FTangSteve/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/FTangSteve/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/FTangSteve/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/FTangSteve/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTangSteve/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/FTangSteve/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/FTangSteve/Baystation12/deployments","created_at":"2016-11-14T21:59:17Z","updated_at":"2016-11-14T21:59:30Z","pushed_at":"2017-12-12T17:05:16Z","git_url":"git://github.com/FTangSteve/Baystation12.git","ssh_url":"[email protected]:FTangSteve/Baystation12.git","clone_url":"https://github.com/FTangSteve/Baystation12.git","svn_url":"https://github.com/FTangSteve/Baystation12","homepage":"http://baystation12.net/","size":741830,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"f1d9ba90b3ee9d2c755f12e3ad6fc221db56de93","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars0.githubusercontent.com/u/1174322?v=4","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars0.githubusercontent.com/u/1174322?v=4","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2017-12-08T15:51:11Z","pushed_at":"2017-12-12T19:44:22Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"[email protected]:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":741044,"stargazers_count":271,"watchers_count":271,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":883,"mirror_url":null,"archived":false,"open_issues_count":1535,"license":null,"forks":883,"open_issues":1535,"watchers":271,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19775"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/19775"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/19775"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/19775/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19775/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19775/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/ac2b30ea452974fe854683026b8451f6950ed9ee"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2715933,
"name": "Baystation12/Baystation12",
"url": "https://api.github.com/repos/Baystation12/Baystation12"
} | {
"id": 496895,
"login": "PsiOmegaDelta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/496895?",
"url": "https://api.github.com/users/PsiOmegaDelta"
} | {
"id": 1174322,
"login": "Baystation12",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1174322?",
"url": "https://api.github.com/orgs/Baystation12"
} | 2017-12-12T19:49:01 | 6979110546 | {"actor":{"display_login":"PsiOmegaDelta"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/comments/131467076","pull_request_review_id":54455389,"id":131467076,"diff_hunk":"@@ -0,0 +1,88 @@\n+package com.microsoft.partnercatalyst.fortis.spark.dba\n+import java.util.concurrent.ConcurrentHashMap\n+\n+import com.microsoft.partnercatalyst.fortis.spark.dto.{BlacklistedTerm, Geofence, SiteSettings}\n+import com.microsoft.partnercatalyst.fortis.spark.sources.streamprovider.ConnectorConfig\n+import org.apache.spark.SparkContext\n+import com.datastax.spark.connector._\n+import com.microsoft.partnercatalyst.fortis.spark.logging.Loggable\n+import scala.compat.java8.FunctionConverters._\n+\n+@SerialVersionUID(100L)\n+class CassandraConfigurationManager extends ConfigurationManager with Serializable with Loggable {\n+ // Note: trusted sources are cached for the lifetime of the configuration manager since in order to update them,\n+ // streaming must be restarted (and hence the configuration manager would be replaced).\n+ private lazy val connectorToTrustedSources = new ConcurrentHashMap[String, Seq[String]]()\n+\n+ override def fetchConnectorConfigs(sparkContext: SparkContext, pipeline: String): List[ConnectorConfig] = {\n+ def fetchTrustedSources(connectorName: String): Seq[String] = {\n+ sparkContext.cassandraTable(CassandraSchema.KeyspaceName, CassandraSchema.Table.TrustedSourcesName)\n+ .select(\"externalsourceid\")\n+ .map(row => row.getString(\"externalsourceid\")).collect()\n+ }\n+\n+ val pipelineConfigRows = sparkContext.cassandraTable[CassandraSchema.Table.Stream](CassandraSchema.KeyspaceName,\n+ CassandraSchema.Table.StreamsName).collect()","path":"src/main/scala/com/microsoft/partnercatalyst/fortis/spark/dba/CassandraConfigurationManager.scala","position":25,"original_position":25,"commit_id":"5cd96d75d2b43ce07954e5de18b5b84a4621b91c","original_commit_id":"5cd96d75d2b43ce07954e5de18b5b84a4621b91c","user":{"login":"jcjimenez","id":1117904,"avatar_url":"https://avatars0.githubusercontent.com/u/1117904?v=4","gravatar_id":"","url":"https://api.github.com/users/jcjimenez","html_url":"https://github.com/jcjimenez","followers_url":"https://api.github.com/users/jcjimenez/followers","following_url":"https://api.github.com/users/jcjimenez/following{/other_user}","gists_url":"https://api.github.com/users/jcjimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/jcjimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcjimenez/subscriptions","organizations_url":"https://api.github.com/users/jcjimenez/orgs","repos_url":"https://api.github.com/users/jcjimenez/repos","events_url":"https://api.github.com/users/jcjimenez/events{/privacy}","received_events_url":"https://api.github.com/users/jcjimenez/received_events","type":"User","site_admin":false},"body":"No biggie, but I think we could get rid of (or defer) this `collect()` call since we call `toList` at the end - this way we only iterate through the list once.","created_at":"2017-08-04T19:19:02Z","updated_at":"2017-08-04T19:30:34Z","html_url":"https://github.com/CatalystCode/project-fortis-spark/pull/67#discussion_r131467076","pull_request_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/comments/131467076"},"html":{"href":"https://github.com/CatalystCode/project-fortis-spark/pull/67#discussion_r131467076"},"pull_request":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/67","id":134232384,"html_url":"https://github.com/CatalystCode/project-fortis-spark/pull/67","diff_url":"https://github.com/CatalystCode/project-fortis-spark/pull/67.diff","patch_url":"https://github.com/CatalystCode/project-fortis-spark/pull/67.patch","issue_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/issues/67","number":67,"state":"open","locked":false,"title":"Implement Cassandra configuration manager","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars0.githubusercontent.com/u/1374024?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"body":"Implementation of the `ConfigurationManager` interface for Cassandra.\r\n\r\n**Summary**\r\n- Cassandra config manager implementation. Uses Spark to perform required manipulations.\r\n- Adds Spark context to configuration manager parameter lists for DB access backed by Spark.\r\n- Changes `ConnectorConfig.parameters` from `Map[String, String]` to `Map[String, Any]`.\r\n- Adds `ParameterExtensions` helper class to simplify reading objects from connector config parameter maps.","created_at":"2017-08-04T19:09:30Z","updated_at":"2017-08-04T19:30:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad5ea7456357c1c3520d3572182b9c7a73d290a6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/67/commits","review_comments_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/67/comments","review_comment_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/issues/67/comments","statuses_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/statuses/5cd96d75d2b43ce07954e5de18b5b84a4621b91c","head":{"label":"kevinhartman:cassandra-config","ref":"cassandra-config","sha":"5cd96d75d2b43ce07954e5de18b5b84a4621b91c","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars0.githubusercontent.com/u/1374024?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"repo":{"id":90048981,"name":"project-fortis-spark","full_name":"kevinhartman/project-fortis-spark","owner":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars0.githubusercontent.com/u/1374024?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinhartman/project-fortis-spark","description":"A repository for all spark jobs running on fortis","fork":true,"url":"https://api.github.com/repos/kevinhartman/project-fortis-spark","forks_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/forks","keys_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/teams","hooks_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/hooks","issue_events_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/issues/events{/number}","events_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/events","assignees_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/assignees{/user}","branches_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/branches{/branch}","tags_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/tags","blobs_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/languages","stargazers_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/stargazers","contributors_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/contributors","subscribers_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/subscribers","subscription_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/subscription","commits_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/contents/{+path}","compare_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/merges","archive_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/downloads","issues_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/issues{/number}","pulls_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/labels{/name}","releases_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/releases{/id}","deployments_url":"https://api.github.com/repos/kevinhartman/project-fortis-spark/deployments","created_at":"2017-05-02T15:30:33Z","updated_at":"2017-05-03T19:44:57Z","pushed_at":"2017-08-04T18:46:37Z","git_url":"git://github.com/kevinhartman/project-fortis-spark.git","ssh_url":"[email protected]:kevinhartman/project-fortis-spark.git","clone_url":"https://github.com/kevinhartman/project-fortis-spark.git","svn_url":"https://github.com/kevinhartman/project-fortis-spark","homepage":null,"size":16654,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CatalystCode:master","ref":"master","sha":"eb9f9794fad442db4ba3aac5c5b99fb84469fb23","user":{"login":"CatalystCode","id":12663554,"avatar_url":"https://avatars0.githubusercontent.com/u/12663554?v=4","gravatar_id":"","url":"https://api.github.com/users/CatalystCode","html_url":"https://github.com/CatalystCode","followers_url":"https://api.github.com/users/CatalystCode/followers","following_url":"https://api.github.com/users/CatalystCode/following{/other_user}","gists_url":"https://api.github.com/users/CatalystCode/gists{/gist_id}","starred_url":"https://api.github.com/users/CatalystCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CatalystCode/subscriptions","organizations_url":"https://api.github.com/users/CatalystCode/orgs","repos_url":"https://api.github.com/users/CatalystCode/repos","events_url":"https://api.github.com/users/CatalystCode/events{/privacy}","received_events_url":"https://api.github.com/users/CatalystCode/received_events","type":"Organization","site_admin":false},"repo":{"id":89546314,"name":"project-fortis-spark","full_name":"CatalystCode/project-fortis-spark","owner":{"login":"CatalystCode","id":12663554,"avatar_url":"https://avatars0.githubusercontent.com/u/12663554?v=4","gravatar_id":"","url":"https://api.github.com/users/CatalystCode","html_url":"https://github.com/CatalystCode","followers_url":"https://api.github.com/users/CatalystCode/followers","following_url":"https://api.github.com/users/CatalystCode/following{/other_user}","gists_url":"https://api.github.com/users/CatalystCode/gists{/gist_id}","starred_url":"https://api.github.com/users/CatalystCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CatalystCode/subscriptions","organizations_url":"https://api.github.com/users/CatalystCode/orgs","repos_url":"https://api.github.com/users/CatalystCode/repos","events_url":"https://api.github.com/users/CatalystCode/events{/privacy}","received_events_url":"https://api.github.com/users/CatalystCode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CatalystCode/project-fortis-spark","description":"A repository for all spark jobs running on fortis","fork":false,"url":"https://api.github.com/repos/CatalystCode/project-fortis-spark","forks_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/forks","keys_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/teams","hooks_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/hooks","issue_events_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/issues/events{/number}","events_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/events","assignees_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/assignees{/user}","branches_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/branches{/branch}","tags_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/tags","blobs_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/statuses/{sha}","languages_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/languages","stargazers_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/stargazers","contributors_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/contributors","subscribers_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/subscribers","subscription_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/subscription","commits_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/contents/{+path}","compare_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/merges","archive_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/downloads","issues_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/issues{/number}","pulls_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls{/number}","milestones_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/milestones{/number}","notifications_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/labels{/name}","releases_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/releases{/id}","deployments_url":"https://api.github.com/repos/CatalystCode/project-fortis-spark/deployments","created_at":"2017-04-27T02:21:24Z","updated_at":"2017-07-06T12:55:47Z","pushed_at":"2017-08-04T19:09:31Z","git_url":"git://github.com/CatalystCode/project-fortis-spark.git","ssh_url":"[email protected]:CatalystCode/project-fortis-spark.git","clone_url":"https://github.com/CatalystCode/project-fortis-spark.git","svn_url":"https://github.com/CatalystCode/project-fortis-spark","homepage":null,"size":16650,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":13,"forks":4,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/67"},"html":{"href":"https://github.com/CatalystCode/project-fortis-spark/pull/67"},"issue":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/issues/67"},"comments":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/CatalystCode/project-fortis-spark/statuses/5cd96d75d2b43ce07954e5de18b5b84a4621b91c"}}}} | {
"id": 89546314,
"name": "CatalystCode/project-fortis-spark",
"url": "https://api.github.com/repos/CatalystCode/project-fortis-spark"
} | {
"id": 1117904,
"login": "jcjimenez",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1117904?",
"url": "https://api.github.com/users/jcjimenez"
} | {
"id": 12663554,
"login": "CatalystCode",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12663554?",
"url": "https://api.github.com/orgs/CatalystCode"
} | 2017-08-04T19:19:02 | 6398026485 | {"actor":{"display_login":"jcjimenez"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/comments/121308543","pull_request_review_id":43345668,"id":121308543,"diff_hunk":"@@ -18,7 +18,8 @@ public extension PlaceholderDesignable where Self: UITextField {\n var placeholderText: String? { get { return \"\" } set {} }\n \n public func configurePlaceholderColor() {\n- if let placeholderColor = placeholderColor, let placeholder = placeholder {\n+ let text = placeholderText ?? placeholder","path":"IBAnimatable/PlaceholderDesignable.swift","position":5,"original_position":5,"commit_id":"fe8abfe6f759711a6aeda0f9beac87841dabb87e","original_commit_id":"b171526f8a33746f5e075a3cf6d301b90a44c681","user":{"login":"SD10","id":7445580,"avatar_url":"https://avatars3.githubusercontent.com/u/7445580?v=3","gravatar_id":"","url":"https://api.github.com/users/SD10","html_url":"https://github.com/SD10","followers_url":"https://api.github.com/users/SD10/followers","following_url":"https://api.github.com/users/SD10/following{/other_user}","gists_url":"https://api.github.com/users/SD10/gists{/gist_id}","starred_url":"https://api.github.com/users/SD10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SD10/subscriptions","organizations_url":"https://api.github.com/users/SD10/orgs","repos_url":"https://api.github.com/users/SD10/repos","events_url":"https://api.github.com/users/SD10/events{/privacy}","received_events_url":"https://api.github.com/users/SD10/received_events","type":"User","site_admin":false},"body":"`placeholderText` will always return an empty String, so if a user sets `Placeholder` in Interface Builder, the latter will never be considered. See [#499](https://github.com/IBAnimatable/IBAnimatable/pull/499)","created_at":"2017-06-12T04:26:36Z","updated_at":"2017-06-12T04:26:36Z","html_url":"https://github.com/IBAnimatable/IBAnimatable/pull/459#discussion_r121308543","pull_request_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/459","_links":{"self":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/comments/121308543"},"html":{"href":"https://github.com/IBAnimatable/IBAnimatable/pull/459#discussion_r121308543"},"pull_request":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/459"}}},"pull_request":{"url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/459","id":116985080,"html_url":"https://github.com/IBAnimatable/IBAnimatable/pull/459","diff_url":"https://github.com/IBAnimatable/IBAnimatable/pull/459.diff","patch_url":"https://github.com/IBAnimatable/IBAnimatable/pull/459.patch","issue_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/459","number":459,"state":"closed","locked":false,"title":"Fix placeholderColor when using basic placeholder text","user":{"login":"tbaranes","id":1402212,"avatar_url":"https://avatars3.githubusercontent.com/u/1402212?v=3","gravatar_id":"","url":"https://api.github.com/users/tbaranes","html_url":"https://github.com/tbaranes","followers_url":"https://api.github.com/users/tbaranes/followers","following_url":"https://api.github.com/users/tbaranes/following{/other_user}","gists_url":"https://api.github.com/users/tbaranes/gists{/gist_id}","starred_url":"https://api.github.com/users/tbaranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbaranes/subscriptions","organizations_url":"https://api.github.com/users/tbaranes/orgs","repos_url":"https://api.github.com/users/tbaranes/repos","events_url":"https://api.github.com/users/tbaranes/events{/privacy}","received_events_url":"https://api.github.com/users/tbaranes/received_events","type":"User","site_admin":false},"body":"While trying to fix #451, I encountered a new issue: `placeholderColor` wasn't working 😨 \r\nIn the end, the issue was simply that I wasn't using `placeholderText` but `placeholder`. I don't know if that's the right fix, but I'm even wondering if `placeholderText` should exist in the first place. That PR will make `placeholderColor` available for `placeholderText` AND `placeholder`, but it will keep the current priority level: `placeholderText` > `placeholder`.\r\n\r\nThat also makes me wondering if it's really useful to have `placeholderText` since the property already exists natively and worked in interface builder. I have also the same question for `fillColor`. I have the impression that just bring confusion. If anyone is interested to discuss this, let's open a new issue about this.","created_at":"2017-04-21T13:27:39Z","updated_at":"2017-06-12T04:26:36Z","closed_at":"2017-04-26T07:37:11Z","merged_at":"2017-04-26T07:37:11Z","merge_commit_sha":"73782ab1b7ba00cef3bc0c07acade71e44145239","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/459/commits","review_comments_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/459/comments","review_comment_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/459/comments","statuses_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/statuses/fe8abfe6f759711a6aeda0f9beac87841dabb87e","head":{"label":"IBAnimatable:hotfix/placeholder_color","ref":"hotfix/placeholder_color","sha":"fe8abfe6f759711a6aeda0f9beac87841dabb87e","user":{"login":"IBAnimatable","id":20221209,"avatar_url":"https://avatars1.githubusercontent.com/u/20221209?v=3","gravatar_id":"","url":"https://api.github.com/users/IBAnimatable","html_url":"https://github.com/IBAnimatable","followers_url":"https://api.github.com/users/IBAnimatable/followers","following_url":"https://api.github.com/users/IBAnimatable/following{/other_user}","gists_url":"https://api.github.com/users/IBAnimatable/gists{/gist_id}","starred_url":"https://api.github.com/users/IBAnimatable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBAnimatable/subscriptions","organizations_url":"https://api.github.com/users/IBAnimatable/orgs","repos_url":"https://api.github.com/users/IBAnimatable/repos","events_url":"https://api.github.com/users/IBAnimatable/events{/privacy}","received_events_url":"https://api.github.com/users/IBAnimatable/received_events","type":"Organization","site_admin":false},"repo":{"id":46383222,"name":"IBAnimatable","full_name":"IBAnimatable/IBAnimatable","owner":{"login":"IBAnimatable","id":20221209,"avatar_url":"https://avatars1.githubusercontent.com/u/20221209?v=3","gravatar_id":"","url":"https://api.github.com/users/IBAnimatable","html_url":"https://github.com/IBAnimatable","followers_url":"https://api.github.com/users/IBAnimatable/followers","following_url":"https://api.github.com/users/IBAnimatable/following{/other_user}","gists_url":"https://api.github.com/users/IBAnimatable/gists{/gist_id}","starred_url":"https://api.github.com/users/IBAnimatable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBAnimatable/subscriptions","organizations_url":"https://api.github.com/users/IBAnimatable/orgs","repos_url":"https://api.github.com/users/IBAnimatable/repos","events_url":"https://api.github.com/users/IBAnimatable/events{/privacy}","received_events_url":"https://api.github.com/users/IBAnimatable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IBAnimatable/IBAnimatable","description":"Design and prototype customized UI, interaction, navigation, transition and animation for App Store ready Apps in Interface Builder with IBAnimatable.","fork":false,"url":"https://api.github.com/repos/IBAnimatable/IBAnimatable","forks_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/forks","keys_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/teams","hooks_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/hooks","issue_events_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/events{/number}","events_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/events","assignees_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/assignees{/user}","branches_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/branches{/branch}","tags_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/tags","blobs_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/statuses/{sha}","languages_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/languages","stargazers_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/stargazers","contributors_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/contributors","subscribers_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/subscribers","subscription_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/subscription","commits_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/contents/{+path}","compare_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/merges","archive_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/downloads","issues_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues{/number}","pulls_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls{/number}","milestones_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/milestones{/number}","notifications_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/labels{/name}","releases_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/releases{/id}","deployments_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/deployments","created_at":"2015-11-17T23:55:21Z","updated_at":"2017-06-12T03:08:48Z","pushed_at":"2017-06-12T04:12:50Z","git_url":"git://github.com/IBAnimatable/IBAnimatable.git","ssh_url":"[email protected]:IBAnimatable/IBAnimatable.git","clone_url":"https://github.com/IBAnimatable/IBAnimatable.git","svn_url":"https://github.com/IBAnimatable/IBAnimatable","homepage":"","size":26105,"stargazers_count":6364,"watchers_count":6364,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":563,"mirror_url":null,"open_issues_count":43,"forks":563,"open_issues":43,"watchers":6364,"default_branch":"master"}},"base":{"label":"IBAnimatable:master","ref":"master","sha":"2a9c84959938e42c5709e311315b56f10f799c36","user":{"login":"IBAnimatable","id":20221209,"avatar_url":"https://avatars1.githubusercontent.com/u/20221209?v=3","gravatar_id":"","url":"https://api.github.com/users/IBAnimatable","html_url":"https://github.com/IBAnimatable","followers_url":"https://api.github.com/users/IBAnimatable/followers","following_url":"https://api.github.com/users/IBAnimatable/following{/other_user}","gists_url":"https://api.github.com/users/IBAnimatable/gists{/gist_id}","starred_url":"https://api.github.com/users/IBAnimatable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBAnimatable/subscriptions","organizations_url":"https://api.github.com/users/IBAnimatable/orgs","repos_url":"https://api.github.com/users/IBAnimatable/repos","events_url":"https://api.github.com/users/IBAnimatable/events{/privacy}","received_events_url":"https://api.github.com/users/IBAnimatable/received_events","type":"Organization","site_admin":false},"repo":{"id":46383222,"name":"IBAnimatable","full_name":"IBAnimatable/IBAnimatable","owner":{"login":"IBAnimatable","id":20221209,"avatar_url":"https://avatars1.githubusercontent.com/u/20221209?v=3","gravatar_id":"","url":"https://api.github.com/users/IBAnimatable","html_url":"https://github.com/IBAnimatable","followers_url":"https://api.github.com/users/IBAnimatable/followers","following_url":"https://api.github.com/users/IBAnimatable/following{/other_user}","gists_url":"https://api.github.com/users/IBAnimatable/gists{/gist_id}","starred_url":"https://api.github.com/users/IBAnimatable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBAnimatable/subscriptions","organizations_url":"https://api.github.com/users/IBAnimatable/orgs","repos_url":"https://api.github.com/users/IBAnimatable/repos","events_url":"https://api.github.com/users/IBAnimatable/events{/privacy}","received_events_url":"https://api.github.com/users/IBAnimatable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IBAnimatable/IBAnimatable","description":"Design and prototype customized UI, interaction, navigation, transition and animation for App Store ready Apps in Interface Builder with IBAnimatable.","fork":false,"url":"https://api.github.com/repos/IBAnimatable/IBAnimatable","forks_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/forks","keys_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/teams","hooks_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/hooks","issue_events_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/events{/number}","events_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/events","assignees_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/assignees{/user}","branches_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/branches{/branch}","tags_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/tags","blobs_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/statuses/{sha}","languages_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/languages","stargazers_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/stargazers","contributors_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/contributors","subscribers_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/subscribers","subscription_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/subscription","commits_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/contents/{+path}","compare_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/merges","archive_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/downloads","issues_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues{/number}","pulls_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls{/number}","milestones_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/milestones{/number}","notifications_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/labels{/name}","releases_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/releases{/id}","deployments_url":"https://api.github.com/repos/IBAnimatable/IBAnimatable/deployments","created_at":"2015-11-17T23:55:21Z","updated_at":"2017-06-12T03:08:48Z","pushed_at":"2017-06-12T04:12:50Z","git_url":"git://github.com/IBAnimatable/IBAnimatable.git","ssh_url":"[email protected]:IBAnimatable/IBAnimatable.git","clone_url":"https://github.com/IBAnimatable/IBAnimatable.git","svn_url":"https://github.com/IBAnimatable/IBAnimatable","homepage":"","size":26105,"stargazers_count":6364,"watchers_count":6364,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":563,"mirror_url":null,"open_issues_count":43,"forks":563,"open_issues":43,"watchers":6364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/459"},"html":{"href":"https://github.com/IBAnimatable/IBAnimatable/pull/459"},"issue":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/459"},"comments":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/issues/459/comments"},"review_comments":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/459/comments"},"review_comment":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/pulls/459/commits"},"statuses":{"href":"https://api.github.com/repos/IBAnimatable/IBAnimatable/statuses/fe8abfe6f759711a6aeda0f9beac87841dabb87e"}}}} | {
"id": 46383222,
"name": "IBAnimatable/IBAnimatable",
"url": "https://api.github.com/repos/IBAnimatable/IBAnimatable"
} | {
"id": 7445580,
"login": "SD10",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7445580?",
"url": "https://api.github.com/users/SD10"
} | {
"id": 20221209,
"login": "IBAnimatable",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20221209?",
"url": "https://api.github.com/orgs/IBAnimatable"
} | 2017-06-12T04:26:36 | 6044252332 | {"actor":{"display_login":"SD10"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/comments/103071599","pull_request_review_id":23851333,"id":103071599,"diff_hunk":"@@ -0,0 +1,15 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Text;\n+using System.Threading.Tasks;\n+\n+namespace KishorAdmin\n+{\n+ public class UserEntity\n+ {\n+ public decimal UserId { get; set; }","path":"GithubBranchingStratergy/GithubBranchingStratergy/KishorAdmin/UserEntity.cs","position":11,"original_position":11,"commit_id":"aaf99887699f574af7ea89b3eb760d52a9ab8633","original_commit_id":"aaf99887699f574af7ea89b3eb760d52a9ab8633","user":{"login":"MohitKumarJhariya","id":25920567,"avatar_url":"https://avatars.githubusercontent.com/u/25920567?v=3","gravatar_id":"","url":"https://api.github.com/users/MohitKumarJhariya","html_url":"https://github.com/MohitKumarJhariya","followers_url":"https://api.github.com/users/MohitKumarJhariya/followers","following_url":"https://api.github.com/users/MohitKumarJhariya/following{/other_user}","gists_url":"https://api.github.com/users/MohitKumarJhariya/gists{/gist_id}","starred_url":"https://api.github.com/users/MohitKumarJhariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MohitKumarJhariya/subscriptions","organizations_url":"https://api.github.com/users/MohitKumarJhariya/orgs","repos_url":"https://api.github.com/users/MohitKumarJhariya/repos","events_url":"https://api.github.com/users/MohitKumarJhariya/events{/privacy}","received_events_url":"https://api.github.com/users/MohitKumarJhariya/received_events","type":"User","site_admin":false},"body":"@KishorNaik : Now this Correct..","created_at":"2017-02-25T05:17:33Z","updated_at":"2017-02-25T05:19:56Z","html_url":"https://github.com/IdeatorsTeam/SolGitBranching/pull/1#discussion_r103071599","pull_request_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/comments/103071599"},"html":{"href":"https://github.com/IdeatorsTeam/SolGitBranching/pull/1#discussion_r103071599"},"pull_request":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/1","id":107947125,"html_url":"https://github.com/IdeatorsTeam/SolGitBranching/pull/1","diff_url":"https://github.com/IdeatorsTeam/SolGitBranching/pull/1.diff","patch_url":"https://github.com/IdeatorsTeam/SolGitBranching/pull/1.patch","issue_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues/1","number":1,"state":"open","locked":false,"title":"#Kishor : User Entity Added..","user":{"login":"KishorNaik","id":8419478,"avatar_url":"https://avatars.githubusercontent.com/u/8419478?v=3","gravatar_id":"","url":"https://api.github.com/users/KishorNaik","html_url":"https://github.com/KishorNaik","followers_url":"https://api.github.com/users/KishorNaik/followers","following_url":"https://api.github.com/users/KishorNaik/following{/other_user}","gists_url":"https://api.github.com/users/KishorNaik/gists{/gist_id}","starred_url":"https://api.github.com/users/KishorNaik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KishorNaik/subscriptions","organizations_url":"https://api.github.com/users/KishorNaik/orgs","repos_url":"https://api.github.com/users/KishorNaik/repos","events_url":"https://api.github.com/users/KishorNaik/events{/privacy}","received_events_url":"https://api.github.com/users/KishorNaik/received_events","type":"User","site_admin":false},"body":"@MohitKumarJhariya : Kindly check code and merge in develop branch..","created_at":"2017-02-25T05:06:49Z","updated_at":"2017-02-25T05:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e2e422d5a0fdc77f7bce38895b62b53ebaa0188","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/1/commits","review_comments_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/1/comments","review_comment_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues/1/comments","statuses_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/statuses/aaf99887699f574af7ea89b3eb760d52a9ab8633","head":{"label":"IdeatorsTeam:KishorUser","ref":"KishorUser","sha":"aaf99887699f574af7ea89b3eb760d52a9ab8633","user":{"login":"IdeatorsTeam","id":26017704,"avatar_url":"https://avatars.githubusercontent.com/u/26017704?v=3","gravatar_id":"","url":"https://api.github.com/users/IdeatorsTeam","html_url":"https://github.com/IdeatorsTeam","followers_url":"https://api.github.com/users/IdeatorsTeam/followers","following_url":"https://api.github.com/users/IdeatorsTeam/following{/other_user}","gists_url":"https://api.github.com/users/IdeatorsTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/IdeatorsTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IdeatorsTeam/subscriptions","organizations_url":"https://api.github.com/users/IdeatorsTeam/orgs","repos_url":"https://api.github.com/users/IdeatorsTeam/repos","events_url":"https://api.github.com/users/IdeatorsTeam/events{/privacy}","received_events_url":"https://api.github.com/users/IdeatorsTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":83105724,"name":"SolGitBranching","full_name":"IdeatorsTeam/SolGitBranching","owner":{"login":"IdeatorsTeam","id":26017704,"avatar_url":"https://avatars.githubusercontent.com/u/26017704?v=3","gravatar_id":"","url":"https://api.github.com/users/IdeatorsTeam","html_url":"https://github.com/IdeatorsTeam","followers_url":"https://api.github.com/users/IdeatorsTeam/followers","following_url":"https://api.github.com/users/IdeatorsTeam/following{/other_user}","gists_url":"https://api.github.com/users/IdeatorsTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/IdeatorsTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IdeatorsTeam/subscriptions","organizations_url":"https://api.github.com/users/IdeatorsTeam/orgs","repos_url":"https://api.github.com/users/IdeatorsTeam/repos","events_url":"https://api.github.com/users/IdeatorsTeam/events{/privacy}","received_events_url":"https://api.github.com/users/IdeatorsTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IdeatorsTeam/SolGitBranching","description":null,"fork":false,"url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching","forks_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/forks","keys_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/teams","hooks_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/hooks","issue_events_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues/events{/number}","events_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/events","assignees_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/assignees{/user}","branches_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/branches{/branch}","tags_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/tags","blobs_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/refs{/sha}","trees_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/statuses/{sha}","languages_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/languages","stargazers_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/stargazers","contributors_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/contributors","subscribers_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/subscribers","subscription_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/subscription","commits_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/commits{/sha}","git_commits_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/commits{/sha}","comments_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/comments{/number}","issue_comment_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues/comments{/number}","contents_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/contents/{+path}","compare_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/merges","archive_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/downloads","issues_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues{/number}","pulls_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls{/number}","milestones_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/milestones{/number}","notifications_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/labels{/name}","releases_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/releases{/id}","deployments_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/deployments","created_at":"2017-02-25T04:21:28Z","updated_at":"2017-02-25T04:34:38Z","pushed_at":"2017-02-25T05:16:33Z","git_url":"git://github.com/IdeatorsTeam/SolGitBranching.git","ssh_url":"[email protected]:IdeatorsTeam/SolGitBranching.git","clone_url":"https://github.com/IdeatorsTeam/SolGitBranching.git","svn_url":"https://github.com/IdeatorsTeam/SolGitBranching","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"IdeatorsTeam:Develop","ref":"Develop","sha":"ddd10c07cba6b521ad5a2e90369a4cdfdddf2054","user":{"login":"IdeatorsTeam","id":26017704,"avatar_url":"https://avatars.githubusercontent.com/u/26017704?v=3","gravatar_id":"","url":"https://api.github.com/users/IdeatorsTeam","html_url":"https://github.com/IdeatorsTeam","followers_url":"https://api.github.com/users/IdeatorsTeam/followers","following_url":"https://api.github.com/users/IdeatorsTeam/following{/other_user}","gists_url":"https://api.github.com/users/IdeatorsTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/IdeatorsTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IdeatorsTeam/subscriptions","organizations_url":"https://api.github.com/users/IdeatorsTeam/orgs","repos_url":"https://api.github.com/users/IdeatorsTeam/repos","events_url":"https://api.github.com/users/IdeatorsTeam/events{/privacy}","received_events_url":"https://api.github.com/users/IdeatorsTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":83105724,"name":"SolGitBranching","full_name":"IdeatorsTeam/SolGitBranching","owner":{"login":"IdeatorsTeam","id":26017704,"avatar_url":"https://avatars.githubusercontent.com/u/26017704?v=3","gravatar_id":"","url":"https://api.github.com/users/IdeatorsTeam","html_url":"https://github.com/IdeatorsTeam","followers_url":"https://api.github.com/users/IdeatorsTeam/followers","following_url":"https://api.github.com/users/IdeatorsTeam/following{/other_user}","gists_url":"https://api.github.com/users/IdeatorsTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/IdeatorsTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IdeatorsTeam/subscriptions","organizations_url":"https://api.github.com/users/IdeatorsTeam/orgs","repos_url":"https://api.github.com/users/IdeatorsTeam/repos","events_url":"https://api.github.com/users/IdeatorsTeam/events{/privacy}","received_events_url":"https://api.github.com/users/IdeatorsTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IdeatorsTeam/SolGitBranching","description":null,"fork":false,"url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching","forks_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/forks","keys_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/teams","hooks_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/hooks","issue_events_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues/events{/number}","events_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/events","assignees_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/assignees{/user}","branches_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/branches{/branch}","tags_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/tags","blobs_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/refs{/sha}","trees_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/statuses/{sha}","languages_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/languages","stargazers_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/stargazers","contributors_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/contributors","subscribers_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/subscribers","subscription_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/subscription","commits_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/commits{/sha}","git_commits_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/git/commits{/sha}","comments_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/comments{/number}","issue_comment_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues/comments{/number}","contents_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/contents/{+path}","compare_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/merges","archive_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/downloads","issues_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues{/number}","pulls_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls{/number}","milestones_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/milestones{/number}","notifications_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/labels{/name}","releases_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/releases{/id}","deployments_url":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/deployments","created_at":"2017-02-25T04:21:28Z","updated_at":"2017-02-25T04:34:38Z","pushed_at":"2017-02-25T05:16:33Z","git_url":"git://github.com/IdeatorsTeam/SolGitBranching.git","ssh_url":"[email protected]:IdeatorsTeam/SolGitBranching.git","clone_url":"https://github.com/IdeatorsTeam/SolGitBranching.git","svn_url":"https://github.com/IdeatorsTeam/SolGitBranching","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/1"},"html":{"href":"https://github.com/IdeatorsTeam/SolGitBranching/pull/1"},"issue":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues/1"},"comments":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/IdeatorsTeam/SolGitBranching/statuses/aaf99887699f574af7ea89b3eb760d52a9ab8633"}}}} | {
"id": 83105724,
"name": "IdeatorsTeam/SolGitBranching",
"url": "https://api.github.com/repos/IdeatorsTeam/SolGitBranching"
} | {
"id": 25920567,
"login": "MohitKumarJhariya",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25920567?",
"url": "https://api.github.com/users/MohitKumarJhariya"
} | {
"id": 26017704,
"login": "IdeatorsTeam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26017704?",
"url": "https://api.github.com/orgs/IdeatorsTeam"
} | 2017-02-25T05:17:33 | 5389662935 | {"actor":{"display_login":"MohitKumarJhariya"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/109990550","pull_request_review_id":31129279,"id":109990550,"diff_hunk":"@@ -0,0 +1,183 @@\n+// Copyright (c) 2017 Valve Corporation\n+// Copyright (c) 2017 LunarG Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+#include <gmock/gmock.h>\n+\n+#include \"pass_fixture.h\"\n+#include \"pass_utils.h\"\n+\n+namespace {\n+\n+using namespace spvtools;\n+\n+// Returns the initial part of the assembly text for a valid\n+// SPIR-V module, including instructions prior to decorations.\n+std::string PreambleAssembly() {\n+ return\n+ R\"(OpCapability Shader\n+OpMemoryModel Logical GLSL450\n+OpEntryPoint Fragment %main \"main\" %hue %saturation %value\n+OpName %main \"main\"\n+OpName %void_fn \"void_fn\"\n+OpName %hue \"hue\"\n+OpName %saturation \"saturation\"\n+OpName %value \"value\"\n+OpName %entry \"entry\"\n+OpName %Point \"Point\"\n+)\";\n+}\n+\n+// Retuns types\n+std::string TypesAndFunctionsAssembly() {\n+ return\n+ R\"(%void = OpTypeVoid\n+%void_fn = OpTypeFunction %void\n+%float = OpTypeFloat 32\n+%Point = OpTypeStruct %float %float %float\n+%_ptr_Input_float = OpTypePointer Input %float\n+%hue = OpVariable %_ptr_Input_float Input\n+%saturation = OpVariable %_ptr_Input_float Input\n+%value = OpVariable %_ptr_Input_float Input\n+%main = OpFunction %void None %void_fn\n+%entry = OpLabel\n+OpReturn\n+OpFunctionEnd\n+)\";\n+}\n+\n+struct FlattenDecorationCase {\n+ // Names and decorations before the pass.\n+ std::string input;\n+ // Names and decorations after the pass.\n+ std::string expected;\n+};\n+\n+using FlattenDecorationTest =\n+ PassTest<::testing::TestWithParam<FlattenDecorationCase>>;\n+\n+TEST_P(FlattenDecorationTest, TransformsDecorations) {\n+ const auto before =\n+ PreambleAssembly() + GetParam().input + TypesAndFunctionsAssembly();\n+ const auto after =\n+ PreambleAssembly() + GetParam().expected + TypesAndFunctionsAssembly();\n+\n+ SinglePassRunAndCheck<opt::FlattenDecorationPass>(before, after, false, true);\n+}\n+\n+INSTANTIATE_TEST_CASE_P(NoUses, FlattenDecorationTest,\n+ ::testing::ValuesIn(std::vector<FlattenDecorationCase>{\n+ // No OpDecorationGroup\n+ {\"\", \"\"},\n+\n+ // OpDecorationGroup without any uses, and\n+ // no OpName.\n+ {\"%group = OpDecorationGroup\\n\", \"\"},\n+\n+ // OpDecorationGroup without any uses, and\n+ // with OpName targeting it. Proves you must\n+ // remove the names as well.\n+ {\"OpName %group \\\"group\\\"\\n\"\n+ \"%group = OpDecorationGroup\\n\",\n+ \"\"},","path":"test/opt/flatten_decoration_test.cpp","position":95,"original_position":93,"commit_id":"e55e5899264a373120cf7a8d7632e972207672f9","original_commit_id":"132e4be0a5953d0f7cee9f35a1d95ac670293317","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars3.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"This was a good test case. Helped expose an infinite loop bug.","created_at":"2017-04-05T18:18:57Z","updated_at":"2017-04-05T18:18:57Z","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/610#discussion_r109990550","pull_request_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/610","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/109990550"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/610#discussion_r109990550"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/610"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/610","id":113805914,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/610","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/610.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/610.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/610","number":610,"state":"open","locked":false,"title":"Flatten decoration groups","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars3.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"Replaces OpDecorationGroup and its uses in OpGroupDecorate and OpMemberDecorate with repeated instances of OpDecorate and OpMemberDecorate.\r\n\r\nFixes https://github.com/KhronosGroup/SPIRV-Tools/issues/602","created_at":"2017-04-02T05:22:36Z","updated_at":"2017-04-05T18:18:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8582a36eda004e6288fa229f3dec182d6ca87f8f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/610/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/610/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/610/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/e55e5899264a373120cf7a8d7632e972207672f9","head":{"label":"dneto0:flatten-decoration-groups","ref":"flatten-decoration-groups","sha":"e55e5899264a373120cf7a8d7632e972207672f9","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars3.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"repo":{"id":46365138,"name":"SPIRV-Tools","full_name":"dneto0/SPIRV-Tools","owner":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars3.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dneto0/SPIRV-Tools","description":null,"fork":true,"url":"https://api.github.com/repos/dneto0/SPIRV-Tools","forks_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/deployments","created_at":"2015-11-17T17:57:28Z","updated_at":"2016-03-24T18:57:43Z","pushed_at":"2017-04-05T18:18:07Z","git_url":"git://github.com/dneto0/SPIRV-Tools.git","ssh_url":"[email protected]:dneto0/SPIRV-Tools.git","clone_url":"https://github.com/dneto0/SPIRV-Tools.git","svn_url":"https://github.com/dneto0/SPIRV-Tools","homepage":null,"size":3096,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"dec3f5e23158eccc1ed710fbec9bd2934ed10447","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars0.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars0.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":null,"fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2017-04-03T13:41:37Z","pushed_at":"2017-04-05T18:18:09Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"[email protected]:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":3020,"stargazers_count":173,"watchers_count":173,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":58,"forks":60,"open_issues":58,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/610"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/610"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/610"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/e55e5899264a373120cf7a8d7632e972207672f9"}}}} | {
"id": 45981801,
"name": "KhronosGroup/SPIRV-Tools",
"url": "https://api.github.com/repos/KhronosGroup/SPIRV-Tools"
} | {
"id": 13054574,
"login": "dneto0",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13054574?",
"url": "https://api.github.com/users/dneto0"
} | {
"id": 1608701,
"login": "KhronosGroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1608701?",
"url": "https://api.github.com/orgs/KhronosGroup"
} | 2017-04-05T18:18:57 | 5633188135 | {"actor":{"display_login":"dneto0"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/151807166","pull_request_review_id":77582836,"id":151807166,"diff_hunk":"@@ -1,26 +1,28 @@\n package com.minecolonies.coremod.items;\n \n import net.minecraft.item.Item;\n+import net.minecraftforge.fml.common.registry.IForgeRegistry;\n \n /**\n * Class handling the registering of the mod items.\n */\n+@SuppressWarnings(\"squid:S1444\")\n public final class ModItems\n {\n- public static final Item supplyChest = new ItemSupplyChestDeployer();\n- public static final Item buildTool = new ItemBuildTool();\n- public static final Item scanTool = new ItemScanTool();\n- public static final Item permTool = new ItemScepterPermission();\n- public static final Item caliper = new ItemCaliper();\n- public static final Item scepterGuard = new ItemScepterGuard();\n- public static final Item supplyCamp = new ItemSupplyCampDeployer();\n- public static final Item ancientTome = new ItemAncientTome();\n- public static final Item chiefSword = new ItemChiefSword();\n+ public static Item supplyChest;\n+ public static Item buildTool;\n+ public static Item scanTool;","path":"src/main/java/com/minecolonies/coremod/items/ModItems.java","position":23,"original_position":23,"commit_id":"f296e20e70568a0f2bef1fb3b75b508280e5a490","original_commit_id":"f296e20e70568a0f2bef1fb3b75b508280e5a490","user":{"login":"MinecoloniesSonar","id":19393044,"avatar_url":"https://avatars3.githubusercontent.com/u/19393044?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecoloniesSonar","html_url":"https://github.com/MinecoloniesSonar","followers_url":"https://api.github.com/users/MinecoloniesSonar/followers","following_url":"https://api.github.com/users/MinecoloniesSonar/following{/other_user}","gists_url":"https://api.github.com/users/MinecoloniesSonar/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecoloniesSonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecoloniesSonar/subscriptions","organizations_url":"https://api.github.com/users/MinecoloniesSonar/orgs","repos_url":"https://api.github.com/users/MinecoloniesSonar/repos","events_url":"https://api.github.com/users/MinecoloniesSonar/events{/privacy}","received_events_url":"https://api.github.com/users/MinecoloniesSonar/received_events","type":"User","site_admin":false},"body":" Make scanTool a static final constant or non-public and provide accessors if needed. [](https://sonar.orionminecraft.com/coding_rules#rule_key=squid%3AClassVariableVisibilityCheck)\n","created_at":"2017-11-17T22:47:57Z","updated_at":"2017-11-17T22:47:57Z","html_url":"https://github.com/Minecolonies/minecolonies/pull/1654#discussion_r151807166","pull_request_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1654","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/151807166"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/1654#discussion_r151807166"},"pull_request":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1654"}}},"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1654","id":153410584,"html_url":"https://github.com/Minecolonies/minecolonies/pull/1654","diff_url":"https://github.com/Minecolonies/minecolonies/pull/1654.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/1654.patch","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1654","number":1654,"state":"open","locked":false,"title":"Paperwall type","user":{"login":"Raycoms","id":6438347,"avatar_url":"https://avatars1.githubusercontent.com/u/6438347?v=4","gravatar_id":"","url":"https://api.github.com/users/Raycoms","html_url":"https://github.com/Raycoms","followers_url":"https://api.github.com/users/Raycoms/followers","following_url":"https://api.github.com/users/Raycoms/following{/other_user}","gists_url":"https://api.github.com/users/Raycoms/gists{/gist_id}","starred_url":"https://api.github.com/users/Raycoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raycoms/subscriptions","organizations_url":"https://api.github.com/users/Raycoms/orgs","repos_url":"https://api.github.com/users/Raycoms/repos","events_url":"https://api.github.com/users/Raycoms/events{/privacy}","received_events_url":"https://api.github.com/users/Raycoms/received_events","type":"User","site_admin":false},"body":"Adds a custom PaperWall block in 4 different flavors.\r\n\r\nAlso rewrites all our model and item + block registering code since it was a huge mess.\r\n\r\nReview please\r\n","created_at":"2017-11-17T22:43:20Z","updated_at":"2017-11-17T22:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ea87f2ce9a4036283a67a305cf710f5e4e834c1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1654/commits","review_comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1654/comments","review_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1654/comments","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/f296e20e70568a0f2bef1fb3b75b508280e5a490","head":{"label":"Minecolonies:PaperwallType","ref":"PaperwallType","sha":"f296e20e70568a0f2bef1fb3b75b508280e5a490","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-11-11T04:54:42Z","pushed_at":"2017-11-17T22:43:20Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":35448,"stargazers_count":57,"watchers_count":57,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":125,"forks":50,"open_issues":125,"watchers":57,"default_branch":"version/1.11"}},"base":{"label":"Minecolonies:version/1.10","ref":"version/1.10","sha":"6ee966e90e305a40c49f86e39d3f9c7d28785b26","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-11-11T04:54:42Z","pushed_at":"2017-11-17T22:43:20Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":35448,"stargazers_count":57,"watchers_count":57,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":125,"forks":50,"open_issues":125,"watchers":57,"default_branch":"version/1.11"}},"_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1654"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/1654"},"issue":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1654"},"comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1654/comments"},"review_comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1654/comments"},"review_comment":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1654/commits"},"statuses":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/f296e20e70568a0f2bef1fb3b75b508280e5a490"}},"author_association":"CONTRIBUTOR"}} | {
"id": 65616760,
"name": "Minecolonies/minecolonies",
"url": "https://api.github.com/repos/Minecolonies/minecolonies"
} | {
"id": 19393044,
"login": "MinecoloniesSonar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19393044?",
"url": "https://api.github.com/users/MinecoloniesSonar"
} | {
"id": 5167336,
"login": "Minecolonies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5167336?",
"url": "https://api.github.com/orgs/Minecolonies"
} | 2017-11-17T22:47:57 | 6872413525 | {"actor":{"display_login":"MinecoloniesSonar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/151876720","pull_request_review_id":77654047,"id":151876720,"diff_hunk":"@@ -7,8 +7,11 @@\n /**\n * Class to create the modBlocks.\n * References to the blocks can be made here\n+ *\n+ * We disabled the following finals since we are neither able to mark the items as final, nor do we want to provide public accessors.\n */\n-public class ModBlocks\n+@SuppressWarnings({\"squid:ClassVariableVisibilityCheck\", \"squid:S2444\", \"squid:S1444\", \"squid:S1820\" , })","path":"src/main/java/com/minecolonies/coremod/blocks/ModBlocks.java","position":8,"original_position":8,"commit_id":"8efc45386f8bdb495e94178b9a2caf65964c872a","original_commit_id":"8efc45386f8bdb495e94178b9a2caf65964c872a","user":{"login":"MinecoloniesSonar","id":19393044,"avatar_url":"https://avatars3.githubusercontent.com/u/19393044?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecoloniesSonar","html_url":"https://github.com/MinecoloniesSonar","followers_url":"https://api.github.com/users/MinecoloniesSonar/followers","following_url":"https://api.github.com/users/MinecoloniesSonar/following{/other_user}","gists_url":"https://api.github.com/users/MinecoloniesSonar/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecoloniesSonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecoloniesSonar/subscriptions","organizations_url":"https://api.github.com/users/MinecoloniesSonar/orgs","repos_url":"https://api.github.com/users/MinecoloniesSonar/repos","events_url":"https://api.github.com/users/MinecoloniesSonar/events{/privacy}","received_events_url":"https://api.github.com/users/MinecoloniesSonar/received_events","type":"User","site_admin":false},"body":" Suppressing the 'squid:ClassVariableVisibilityCheck, squid:S2444, squid:S1444, squid:S1820' warnings is not allowed [](https://sonar.orionminecraft.com/coding_rules#rule_key=squid%3AS1309)\n","created_at":"2017-11-19T20:27:13Z","updated_at":"2017-11-19T20:27:13Z","html_url":"https://github.com/Minecolonies/minecolonies/pull/1659#discussion_r151876720","pull_request_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1659","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/151876720"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/1659#discussion_r151876720"},"pull_request":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1659"}}},"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1659","id":153513591,"html_url":"https://github.com/Minecolonies/minecolonies/pull/1659","diff_url":"https://github.com/Minecolonies/minecolonies/pull/1659.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/1659.patch","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1659","number":1659,"state":"open","locked":false,"title":"Paperwall type (#1654) - Port 1.12","user":{"login":"Raycoms","id":6438347,"avatar_url":"https://avatars1.githubusercontent.com/u/6438347?v=4","gravatar_id":"","url":"https://api.github.com/users/Raycoms","html_url":"https://github.com/Raycoms","followers_url":"https://api.github.com/users/Raycoms/followers","following_url":"https://api.github.com/users/Raycoms/following{/other_user}","gists_url":"https://api.github.com/users/Raycoms/gists{/gist_id}","starred_url":"https://api.github.com/users/Raycoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raycoms/subscriptions","organizations_url":"https://api.github.com/users/Raycoms/orgs","repos_url":"https://api.github.com/users/Raycoms/repos","events_url":"https://api.github.com/users/Raycoms/events{/privacy}","received_events_url":"https://api.github.com/users/Raycoms/received_events","type":"User","site_admin":false},"body":"* First part of paper wall.\r\n\r\nTextures required.\r\n\r\n* New textures.\r\n\r\n* Add craft and Switch to jungle texture\r\n\r\nAlso fixes some codacy\r\n\r\n* Added newlines\r\n\r\n* Requested changes and codacy/sonar fixes\r\n\r\n* Codacy\r\n\r\n* More codacy and sonar\r\n\r\n* Another codacy and sonar\r\n\r\nTrying to figure out what does it require to be fixed\r\n\r\n* Codacy\r\n\r\n* Should work\r\n\r\n* Another try\r\n\r\n* Codacy\r\n\r\n* Sonar\r\n\r\n* Sonar\r\n\r\nSomebody once told me that I have to change line. I have my pen in hand to do it...\r\n\r\n* Sonar should change it's mind\r\n\r\n* First attempt\r\n\r\n* Second part\r\n\r\n* Some adaptions\r\n\r\n* some more\r\n\r\n* Push\r\n\r\n* Push some fixes\r\n\r\n* some more adaptions\r\n\r\n* more adaptions\r\n\r\n* switch to correct model loading\r\n\r\n* At correct event only at the client\r\n\r\n* copy modblock registry from 1.12\r\n\r\n* correctly register everything!\r\n\r\n* Finish it\r\n\r\n* Optimize imports\r\n\r\n* Sonar fixes\r\n\r\n* Make sonar happy\r\n\r\n* fix critical\r\n\r\n* make codacity happy\r\n\r\n* more codacity\r\n\r\n* sonar critical\r\n\r\n* Adapt following orion\r\n\r\n* User interfaces\r\n\r\n* Making it use generics.\r\n\r\n* Fix the construction tape\r\n\r\nCloses #\r\nCloses #\r\nCloses #\r\n\r\n# Changes proposed in this pull request:\r\n-\r\n-\r\n-\r\n\r\nReview please\r\n","created_at":"2017-11-19T20:21:47Z","updated_at":"2017-11-19T20:27:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88f780c2bf94a8f57fee794bfa8d0ea4636b8cb1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1659/commits","review_comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1659/comments","review_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1659/comments","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/8efc45386f8bdb495e94178b9a2caf65964c872a","head":{"label":"Minecolonies:port1.12/paperwalltype","ref":"port1.12/paperwalltype","sha":"8efc45386f8bdb495e94178b9a2caf65964c872a","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-11-19T01:50:58Z","pushed_at":"2017-11-19T20:22:05Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":35651,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":119,"forks":50,"open_issues":119,"watchers":58,"default_branch":"version/1.11"}},"base":{"label":"Minecolonies:version/1.12","ref":"version/1.12","sha":"e191b8ee0892c0ffd688aefdba02290428afca62","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-11-19T01:50:58Z","pushed_at":"2017-11-19T20:22:05Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":35651,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":119,"forks":50,"open_issues":119,"watchers":58,"default_branch":"version/1.11"}},"_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1659"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/1659"},"issue":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1659"},"comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1659/comments"},"review_comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1659/comments"},"review_comment":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1659/commits"},"statuses":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/8efc45386f8bdb495e94178b9a2caf65964c872a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 65616760,
"name": "Minecolonies/minecolonies",
"url": "https://api.github.com/repos/Minecolonies/minecolonies"
} | {
"id": 19393044,
"login": "MinecoloniesSonar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19393044?",
"url": "https://api.github.com/users/MinecoloniesSonar"
} | {
"id": 5167336,
"login": "Minecolonies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5167336?",
"url": "https://api.github.com/orgs/Minecolonies"
} | 2017-11-19T20:27:13 | 6876050022 | {"actor":{"display_login":"MinecoloniesSonar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/99494762","pull_request_review_id":20174132,"id":99494762,"diff_hunk":"@@ -0,0 +1,165 @@\n+package com.minecolonies.coremod.commands;\n+\n+import com.minecolonies.coremod.colony.Colony;\n+import com.minecolonies.coremod.colony.ColonyManager;\n+import com.minecolonies.coremod.colony.IColony;\n+import net.minecraft.command.CommandException;\n+import net.minecraft.command.ICommandSender;\n+import net.minecraft.entity.player.EntityPlayer;\n+import net.minecraft.server.MinecraftServer;\n+import net.minecraft.util.math.BlockPos;\n+import net.minecraft.util.text.TextComponentString;\n+import org.jetbrains.annotations.NotNull;\n+\n+import javax.annotation.Nullable;\n+import java.util.Collections;\n+import java.util.List;\n+\n+/**\n+ * Parent class for all citizen related commands, contains code which is the same for all commands relating citizens.\n+ */\n+public abstract class AbstractCitizensCommands extends AbstractSingleCommand\n+{\n+ private static final String NO_ARGUMENTS = \"Please define a valid citizen and/or colony\";\n+\n+ /**\n+ * Initialize this SubCommand with it's parents.\n+ *\n+ * @param parents an array of all the parents.\n+ */\n+ public AbstractCitizensCommands(@NotNull final String... parents)\n+ {\n+ super(parents);\n+ }\n+\n+ @NotNull\n+ @Override\n+ public String getCommandUsage(@NotNull final ICommandSender sender)\n+ {\n+ return super.getCommandUsage(sender) + \"<ColonyId> <CitizenId>\";\n+ }\n+\n+ @Override\n+ public void execute(@NotNull final MinecraftServer server, @NotNull final ICommandSender sender, @NotNull final String... args) throws CommandException\n+ {\n+ if(args.length == 0)\n+ {\n+ sender.getCommandSenderEntity().addChatMessage(new TextComponentString(NO_ARGUMENTS));\n+ return;\n+ }\n+\n+ boolean firstArgumentColonyId = true;\n+ int colonyId = -1;\n+ if(args.length >= 2)\n+ {\n+ colonyId = getIthArgument(args, 0, -1);\n+ if(colonyId == -1)\n+ {\n+ firstArgumentColonyId = false;\n+ }\n+ }\n+\n+ final Colony colony;\n+ if(sender instanceof EntityPlayer && colonyId == -1)\n+ {\n+ IColony tempColony = ColonyManager.getIColonyByOwner(sender.getEntityWorld(), (EntityPlayer) sender);","path":"src/main/java/com/minecolonies/coremod/commands/AbstractCitizensCommands.java","position":65,"original_position":65,"commit_id":"9f727452bfd06e25e2035ef0b4ee5d529d4857f3","original_commit_id":"9f727452bfd06e25e2035ef0b4ee5d529d4857f3","user":{"login":"MinecoloniesSonar","id":19393044,"avatar_url":"https://avatars.githubusercontent.com/u/19393044?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecoloniesSonar","html_url":"https://github.com/MinecoloniesSonar","followers_url":"https://api.github.com/users/MinecoloniesSonar/followers","following_url":"https://api.github.com/users/MinecoloniesSonar/following{/other_user}","gists_url":"https://api.github.com/users/MinecoloniesSonar/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecoloniesSonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecoloniesSonar/subscriptions","organizations_url":"https://api.github.com/users/MinecoloniesSonar/orgs","repos_url":"https://api.github.com/users/MinecoloniesSonar/repos","events_url":"https://api.github.com/users/MinecoloniesSonar/events{/privacy}","received_events_url":"https://api.github.com/users/MinecoloniesSonar/received_events","type":"User","site_admin":false},"body":" Local variable 'tempColony' could be declared final [](http://home.kk-sc.de:9000/coding_rules#rule_key=pmd%3ALocalVariableCouldBeFinal)\n","created_at":"2017-02-05T17:40:17Z","updated_at":"2017-02-05T17:40:17Z","html_url":"https://github.com/Minecolonies/minecolonies/pull/551#discussion_r99494762","pull_request_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/551","_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/99494762"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/551#discussion_r99494762"},"pull_request":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/551"}}},"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/551","id":104707187,"html_url":"https://github.com/Minecolonies/minecolonies/pull/551","diff_url":"https://github.com/Minecolonies/minecolonies/pull/551.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/551.patch","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/551","number":551,"state":"open","locked":false,"title":"Feature/#386 rtp command","user":{"login":"Raycoms","id":6438347,"avatar_url":"https://avatars.githubusercontent.com/u/6438347?v=3","gravatar_id":"","url":"https://api.github.com/users/Raycoms","html_url":"https://github.com/Raycoms","followers_url":"https://api.github.com/users/Raycoms/followers","following_url":"https://api.github.com/users/Raycoms/following{/other_user}","gists_url":"https://api.github.com/users/Raycoms/gists{/gist_id}","starred_url":"https://api.github.com/users/Raycoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raycoms/subscriptions","organizations_url":"https://api.github.com/users/Raycoms/orgs","repos_url":"https://api.github.com/users/Raycoms/repos","events_url":"https://api.github.com/users/Raycoms/events{/privacy}","received_events_url":"https://api.github.com/users/Raycoms/received_events","type":"User","site_admin":false},"body":"Closes #386 \r\n\r\n# Changes proposed in this pull request:\r\n- Makes all commands configurable per config\r\n- Adds an rtp command\r\n- Improves all commands and fixes some bugs\r\nReview please\r\n\r\nThis is @opmis his pr.\r\n","created_at":"2017-02-05T17:27:55Z","updated_at":"2017-02-05T17:40:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f225f2797643cfdab4c2d05fa3b467eea45d6563","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/551/commits","review_comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/551/comments","review_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/551/comments","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/9f727452bfd06e25e2035ef0b4ee5d529d4857f3","head":{"label":"Minecolonies:feature/#386-Rtp-command","ref":"feature/#386-Rtp-command","sha":"9f727452bfd06e25e2035ef0b4ee5d529d4857f3","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-02-03T11:40:03Z","pushed_at":"2017-02-05T17:27:55Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":12668,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":95,"forks":29,"open_issues":95,"watchers":18,"default_branch":"develop"}},"base":{"label":"Minecolonies:develop","ref":"develop","sha":"081f9aa0bd570764a4113174cf92581e7f24c7f8","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-02-03T11:40:03Z","pushed_at":"2017-02-05T17:27:55Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":12668,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":95,"forks":29,"open_issues":95,"watchers":18,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/551"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/551"},"issue":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/551"},"comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/9f727452bfd06e25e2035ef0b4ee5d529d4857f3"}}}} | {
"id": 65616760,
"name": "Minecolonies/minecolonies",
"url": "https://api.github.com/repos/Minecolonies/minecolonies"
} | {
"id": 19393044,
"login": "MinecoloniesSonar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19393044?",
"url": "https://api.github.com/users/MinecoloniesSonar"
} | {
"id": 5167336,
"login": "Minecolonies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5167336?",
"url": "https://api.github.com/orgs/Minecolonies"
} | 2017-02-05T17:40:17 | 5269075906 | {"actor":{"display_login":"MinecoloniesSonar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/125178664","pull_request_review_id":47546159,"id":125178664,"diff_hunk":"@@ -0,0 +1,55 @@\n+package com.minecolonies.coremod.client.render.mobs.barbarians;\n+\n+import com.minecolonies.coremod.entity.ai.mobs.barbarians.AbstractEntityBarbarian;\n+import com.minecolonies.coremod.entity.ai.mobs.barbarians.EntityBarbarian;\n+import com.minecolonies.coremod.entity.ai.mobs.barbarians.EntityChiefBarbarian;\n+import net.minecraft.client.model.ModelBiped;\n+import net.minecraft.client.renderer.entity.RenderLiving;\n+import net.minecraft.client.renderer.entity.RenderManager;\n+import net.minecraft.client.renderer.entity.layers.LayerBipedArmor;\n+import net.minecraft.client.renderer.entity.layers.LayerHeldItem;\n+import net.minecraft.util.ResourceLocation;\n+\n+import javax.annotation.Nonnull;\n+\n+/**\n+ * Abstract for rendering Barbarians.\n+ */\n+public class AbstractRendererBarbarian extends RenderLiving<AbstractEntityBarbarian>\n+{\n+ private static final float SHADOW_SIZE = 0.5F;\n+ private final ResourceLocation mobTexture;\n+\n+ /**\n+ * Constructor method for renderer\n+ *\n+ * @param renderManagerIn the renderManager\n+ */\n+ public AbstractRendererBarbarian(final RenderManager renderManagerIn, Class barbarian)","path":"src/main/java/com/minecolonies/coremod/client/render/mobs/barbarians/AbstractRendererBarbarian.java","position":28,"original_position":28,"commit_id":"bf553cc76f7d9da7b1562c3c09375f58a63a01f7","original_commit_id":"bf553cc76f7d9da7b1562c3c09375f58a63a01f7","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars2.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Parameter 'barbarian' is not assigned and could be declared final](https://www.codacy.com/app/Minecolonies/minecolonies/pullRequest?prid=748490)","created_at":"2017-07-02T09:48:57Z","updated_at":"2017-07-02T09:48:57Z","html_url":"https://github.com/Minecolonies/minecolonies/pull/1245#discussion_r125178664","pull_request_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1245","_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/125178664"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/1245#discussion_r125178664"},"pull_request":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1245"}}},"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1245","id":128515191,"html_url":"https://github.com/Minecolonies/minecolonies/pull/1245","diff_url":"https://github.com/Minecolonies/minecolonies/pull/1245.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/1245.patch","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1245","number":1245,"state":"open","locked":false,"title":"Re barbarians1.10","user":{"login":"Asherslab","id":28527281,"avatar_url":"https://avatars2.githubusercontent.com/u/28527281?v=3","gravatar_id":"","url":"https://api.github.com/users/Asherslab","html_url":"https://github.com/Asherslab","followers_url":"https://api.github.com/users/Asherslab/followers","following_url":"https://api.github.com/users/Asherslab/following{/other_user}","gists_url":"https://api.github.com/users/Asherslab/gists{/gist_id}","starred_url":"https://api.github.com/users/Asherslab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asherslab/subscriptions","organizations_url":"https://api.github.com/users/Asherslab/orgs","repos_url":"https://api.github.com/users/Asherslab/repos","events_url":"https://api.github.com/users/Asherslab/events{/privacy}","received_events_url":"https://api.github.com/users/Asherslab/received_events","type":"User","site_admin":false},"body":"\r\n# Changes proposed in this pull request:\r\n- Barbarians\r\n- Guards help each other out\r\n\r\nReview please\r\n","created_at":"2017-07-02T09:46:41Z","updated_at":"2017-07-02T09:48:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08f7091b038461af756fc0e43fb13b0fc0d9ac27","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1245/commits","review_comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1245/comments","review_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1245/comments","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/bf553cc76f7d9da7b1562c3c09375f58a63a01f7","head":{"label":"Minecolonies:ReBarbarians1.10","ref":"ReBarbarians1.10","sha":"bf553cc76f7d9da7b1562c3c09375f58a63a01f7","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars0.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars0.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-06-27T14:43:48Z","pushed_at":"2017-07-02T09:46:41Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":22449,"stargazers_count":45,"watchers_count":45,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":125,"forks":35,"open_issues":125,"watchers":45,"default_branch":"version/1.11"}},"base":{"label":"Minecolonies:version/1.10","ref":"version/1.10","sha":"a3de0f7733d63373ce2640ff984f37c7bf655807","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars0.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars0.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-06-27T14:43:48Z","pushed_at":"2017-07-02T09:46:41Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"[email protected]:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":22449,"stargazers_count":45,"watchers_count":45,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":125,"forks":35,"open_issues":125,"watchers":45,"default_branch":"version/1.11"}},"_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1245"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/1245"},"issue":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1245"},"comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1245/comments"},"review_comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1245/comments"},"review_comment":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1245/commits"},"statuses":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/bf553cc76f7d9da7b1562c3c09375f58a63a01f7"}}}} | {
"id": 65616760,
"name": "Minecolonies/minecolonies",
"url": "https://api.github.com/repos/Minecolonies/minecolonies"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 5167336,
"login": "Minecolonies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5167336?",
"url": "https://api.github.com/orgs/Minecolonies"
} | 2017-07-02T09:48:57 | 6178152285 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments/137008888","pull_request_review_id":60586371,"id":137008888,"diff_hunk":"@@ -0,0 +1,120 @@\n+import * as uuid from \"uuid\";\n+import * as ua from \"universal-analytics\";\n+import { AnalyticsClients } from \"../../common/constants\";\n+\n+export class GoogleAnalyticsProvider implements IGoogleAnalyticsProvider {\n+\tprivate static GA_TRACKING_ID = \"UA-111455-44\";\n+\tprivate currentPage: string;\n+\n+\tconstructor(private clientId: string,\n+\t\tprivate $staticConfig: IStaticConfig,\n+\t\tprivate $hostInfo: IHostInfo,\n+\t\tprivate $osInfo: IOsInfo) {\n+\t}\n+\n+\tpublic async trackHit(trackInfo: IGoogleAnalyticsData): Promise<void> {\n+\t\tconst visitor = ua({\n+\t\t\ttid: GoogleAnalyticsProvider.GA_TRACKING_ID,\n+\t\t\tcid: this.clientId,\n+\t\t\theaders: {\n+\t\t\t\t[\"User-Agent\"]: this.getUserAgentString()\n+\t\t\t}\n+\t\t});\n+\n+\t\tthis.setCustomDimensions(visitor, trackInfo.customDimensions);\n+\n+\t\tswitch (trackInfo.googleAnalyticsDataType) {\n+\t\t\tcase GoogleAnalyticsDataType.Page:\n+\t\t\t\tawait this.trackPageView(visitor, <IGoogleAnalyticsPageviewData>trackInfo);\n+\t\t\t\tbreak;\n+\t\t\tcase GoogleAnalyticsDataType.Event:\n+\t\t\t\tawait this.trackEvent(visitor, <IGoogleAnalyticsEventData>trackInfo);\n+\t\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tprivate setCustomDimensions(visitor: ua.Visitor, customDimensions: IStringDictionary): void {\n+\t\tconst defaultValues: IStringDictionary = {\n+\t\t\t[GoogleAnalyticsCustomDimensions.cliVersion]: this.$staticConfig.version,\n+\t\t\t[GoogleAnalyticsCustomDimensions.nodeVersion]: process.version,\n+\t\t\t[GoogleAnalyticsCustomDimensions.clientID]: this.clientId,\n+\t\t\t[GoogleAnalyticsCustomDimensions.projectType]: null,\n+\t\t\t[GoogleAnalyticsCustomDimensions.sessionID]: uuid.v4(),\n+\t\t\t[GoogleAnalyticsCustomDimensions.client]: AnalyticsClients.Unknown\n+\t\t};\n+\n+\t\tcustomDimensions = _.merge(defaultValues, customDimensions);\n+\n+\t\t_.each(customDimensions, (value, key) => {\n+\t\t\tvisitor.set(key, value);\n+\t\t});\n+\t}\n+\n+\tprivate trackEvent(visitor: ua.Visitor, trackInfo: IGoogleAnalyticsEventData): Promise<void> {\n+\t\treturn new Promise<void>((resolve, reject) => {\n+\t\t\tvisitor.event(trackInfo.category, trackInfo.action, trackInfo.label, trackInfo.value, { p: this.currentPage }, (err: Error) => {\n+\t\t\t\tif (err) {\n+\t\t\t\t\treject(err);\n+\t\t\t\t\treturn;\n+\t\t\t\t}\n+\n+\t\t\t\tresolve();\n+\t\t\t});\n+\t\t});\n+\t}\n+\n+\tprivate trackPageView(visitor: ua.Visitor, trackInfo: IGoogleAnalyticsPageviewData): Promise<void> {\n+\t\treturn new Promise<void>((resolve, reject) => {\n+\t\t\tthis.currentPage = trackInfo.path;\n+\n+\t\t\tconst pageViewData: ua.PageviewParams = {\n+\t\t\t\tdp: trackInfo.path,\n+\t\t\t\tdt: trackInfo.title\n+\t\t\t};\n+\n+\t\t\tvisitor.pageview(pageViewData, (err) => {\n+\t\t\t\tif (err) {\n+\t\t\t\t\treject(err);\n+\t\t\t\t\treturn;\n+\t\t\t\t}\n+\n+\t\t\t\tresolve();\n+\t\t\t});\n+\t\t});\n+\t}\n+\n+\tprivate getUserAgentString(): string {\n+\t\tlet osString = \"\";\n+\t\tconst osRelease = this.$osInfo.release();\n+\n+\t\tif (this.$hostInfo.isWindows) {\n+\t\t\tosString = `Windows NT ${osRelease}`;\n+\t\t} else if (this.$hostInfo.isDarwin) {\n+\t\t\tosString = `Macintosh`;\n+\t\t\tconst macRelease = this.getMacOSReleaseVersion(osRelease);\n+\t\t\tif (macRelease) {\n+\t\t\t\tosString += `; Intel Mac OS X ${macRelease}`;\n+\t\t\t}\n+\t\t} else {\n+\t\t\tosString = `Linux x86`;\n+\t\t\tif (this.$osInfo.arch() === \"x64\") {\n+\t\t\t\tosString += \"_64\";\n+\t\t\t}\n+\t\t}\n+\n+\t\tconst userAgent = `tnsCli/${this.$staticConfig.version} (${osString}; ${this.$osInfo.arch()})`;\n+\n+\t\treturn userAgent;\n+\t}\n+\n+\tprivate getMacOSReleaseVersion(osRelease: string): string {\n+\t\t// https://en.wikipedia.org/wiki/Darwin_(operating_system)#Release_history\n+\t\t// Each macOS version is labeled 10.<version>, where it looks like <versions> is taken from the major version returned by os.release() (16.x.x for example) and substituting 4 from it.","path":"lib/services/analytics/google-analytics-provider.ts","position":112,"original_position":112,"commit_id":"9bd85d810603bdcd8aceed4d092a9d40e3d131b7","original_commit_id":"9bd85d810603bdcd8aceed4d092a9d40e3d131b7","user":{"login":"Mitko-Kerezov","id":6683316,"avatar_url":"https://avatars0.githubusercontent.com/u/6683316?v=4","gravatar_id":"","url":"https://api.github.com/users/Mitko-Kerezov","html_url":"https://github.com/Mitko-Kerezov","followers_url":"https://api.github.com/users/Mitko-Kerezov/followers","following_url":"https://api.github.com/users/Mitko-Kerezov/following{/other_user}","gists_url":"https://api.github.com/users/Mitko-Kerezov/gists{/gist_id}","starred_url":"https://api.github.com/users/Mitko-Kerezov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mitko-Kerezov/subscriptions","organizations_url":"https://api.github.com/users/Mitko-Kerezov/orgs","repos_url":"https://api.github.com/users/Mitko-Kerezov/repos","events_url":"https://api.github.com/users/Mitko-Kerezov/events{/privacy}","received_events_url":"https://api.github.com/users/Mitko-Kerezov/received_events","type":"User","site_admin":false},"body":"I think `substituting` here should be `subtracting` 💭 ","created_at":"2017-09-05T14:45:55Z","updated_at":"2017-09-05T14:51:11Z","html_url":"https://github.com/NativeScript/nativescript-cli/pull/3088#discussion_r137008888","pull_request_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3088","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments/137008888"},"html":{"href":"https://github.com/NativeScript/nativescript-cli/pull/3088#discussion_r137008888"},"pull_request":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3088"}}},"pull_request":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3088","id":137442593,"html_url":"https://github.com/NativeScript/nativescript-cli/pull/3088","diff_url":"https://github.com/NativeScript/nativescript-cli/pull/3088.diff","patch_url":"https://github.com/NativeScript/nativescript-cli/pull/3088.patch","issue_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/3088","number":3088,"state":"open","locked":false,"title":"Improve analytics","user":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars1.githubusercontent.com/u/8351653?v=4","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"body":"We have a requirement to track information in several different providers. However, this may slow down CLI's operations as each track (at least for some of the providers) may last around 100-300ms.\r\nIn order to track in multiple analytics provider without slowing down CLI commands, move the tracking to a new process. The process is detached from CLI, so when CLI finishes its work it will exit, while the child process will remain alive until it sends all required information. The new process is called `analytics-broker-process`, it is detached from CLI, but it there's IPC channel between them, so CLI can send information to be tracked. Just before CLI dies, it will send \"finish\" message to the `broker` process and the IPC channel will be closed.\r\n\r\nIn CLI implement a new `analytics-service`, so when the methods `track`, `trackFeature` and `trackException` are called, instead of tracking directly in CLI's process (i.e. the old implementation), to send information to the broker process.\r\nThe only exception is tracking of the answer if user allows us to send anonymous statistics. As this action requires user interaction, it is executed in CLI's process, a new eqatec analytics monitor is started and the answer is sent to it. After that the analytics is stopped. In case the answer is \"yes\" and there is more information that we want to track in the current process, it will be send to broker and tracked in all providers. In case the answer is \"no\", no other data will be tracked.\r\n\r\nThe broker process is started from analytics process once per process, i.e. on each CLI process (which have something to track) there's a corresponding `analytics-broker-process`. Once it is initialized, it sends BrokerReadyToReceive message to CLI and CLI knows that it can start sending tracking information. Initialization phase is creating a new instance of AnalyticsBroker and attaching handlers for `message` and `disconnect` events. The AnalyitcsBroker itself has a single purpose - sends tracking data to all available prociders. Currently the only provider is `eqatecAnalyticsProvider`. Once CLI sends \"finish\" message (or `analytics-broker-process` receives `disconnect` event), the process sends information to all providers that there's nothing more to be tracked. When all providers finish their work, they should disocnnect themselves from the broker process and it will exit gracefully.\r\n\r\n`EqatecAnalyticsProvider` is used to track features and exceptions in Progress Telerik Analytics. Our requirement is to track features in two projects (same data should be send to both of them) and exceptions in another project. Each of them should be in a separate child process, so failure in one of them will not reflect the others. So the provider starts all required processes. When broker sends information to the provider, it sends it to all required child processes, for example if a feature should be tracked, the provider will send information for it to the two processes used for feature tracking.\r\n\r\nEach eqatec child process is a new Node.js process runnign `eqatec-analytics-process`. Again - this is a detached process. Once it is initialized, it sends \"EqatecAnalyticsReadyToReceive\" message to the `EqatecAnalyitcsProvider` and it knows it can send information to the new child process. The initialization phase is creation of new instance of `EqatectAnalyticsService`, attaching to \"message\" and \"disconnect\" events. Once `EqatecAnalyitcsProvider` receives `EqatecAnalyticsReadyToReceive` message, it sends initialization data for the eqatec monitor. It includes the analytics project API key, user id, current sessions count, etc. The information is persisted in a file on user's machine, so this file should be updated from a single process. As we might have 3 eqatec analytics processes, the provider is the only place where the file should be read and updated.\r\n\r\nWhen `eqatec-analytics-process` receives initialization data, it creates a new instance of the `EqatectAnalyticsService` class with it. However a monitor is not started yet. It will be started when there's something to be tracked, i.e. once `eqatec-analytics-process` receives feature or exception to be tracked.\r\n\r\nWhen `eqatec-analytics-process` receives \"finish\" message, it awaits all pending requests and after that disconnets itself from the parent. In case this operation fails, the process just exits, which will allow the parent to exit gracefully.\r\n\r\nRemove the public `startEqatecMonitor` method from API - it has not been used.\r\n\r\nA simple scheme of the processes is shown below:\r\n\r\n\r\n\r\n## UPDATE\r\nAfter latest discussion and commits, all EqatecAnalytics are ran in the analytics-broker-process directly. Also AcceptTrackFeatureUsage is moved to this process, so no tracking should happen in CLI itself.\r\n\r\n\r\n\r\n\r\n## UPDATE 2\r\n### Add tracking to Google Analytics\r\n\r\nAdd new methods to track information in Google Analytics(GA). As the data that we want to track is different than the one we track in Eqatec Analytics, call the new methods whenever we want to send some information to GA.\r\nChange the broker process to send information to Eqatec Analytics when we want to track feature or exception and to GA only when the new method for tracking there is called.\r\n\r\nIn Google Analytics (GA) we track two types of data - pages (called pageviews) and events. Each command is tracked as a page - we only track the name of the command as a page:\r\n* `tns build android` will be tracked as visited page - `build android`\r\n* `tns run` will be tracked as visited page - `run`\r\n\r\nWhen we want to track some additional actions that happen during execution of each command, we send events to GA. Each event has the following data:\r\n* category - currently we do not have a specific category for each action, so it is hardcoded to \"CLI\".\r\n* action - this is the real action that will be tracked, for example `Build`, `LiveSync`, `Deploy`, etc.\r\n* label - contains specific inforamation for the current action, for example what is the platform, device type, etc. In many cases we send labels with a lot of information, but as the value must be string, we use `_` as a separator. For example:\r\n * Action `Build` may have the following label: `Android_Debug_Incremental`. This is `<platform>_<build configuration>_<build type>`.\r\n * Action `LiveSync` may have the following label: `Android_Emulator_5.1`. This is `<platform>_<device type>_<device os version>`.\r\n\r\n#### Custom dimensions\r\nFor each additional data may be send to GA via Custom Dimensions. More about them can be found [here](https://support.google.com/analytics/answer/2709828). We are using several custom dimensions, most of them have hit scope, i.e. their values are saved for the current hit (event or page), but may be changed for the next time. The only exclusion is `session id` - it has session scope, so whenever it is sent, the new value overwrites the values of the \"session id\" property in all hits of the current session.\r\nOne interesting custom dimension is `Client` - it will be set to the value of `--analyticsClient` in case it is passed. In case not, we'll set it to \"CLI\" when terminal is interactive and \"Unknown\" when terminal is not interactive.\r\n\r\n#### Sessions - what is session for GA\r\nIn Eqatec Analytics we call `stopMonitor` at the end of each command. So the session there is one command. In GA we've decided to keep the default way of measuring a session - a session is stopped when there are 30 inactive minutes, i.e. no data is sent from 30 minutes. This allows us to investigate the behavior and the flow of commands a user is executing in a single session (during the day for example).\r\n\r\n#### Client ID and User ID:\r\nCurrently we do not send User ID to GA, we use Client ID instead as sending User IDs requires different logic and agreements. For us all users are anonymous.\r\n\r\n#### User-Agent\r\nWhen sending requests to GA, we need to set correct User-Agent, so GA will be able to understand the Operating System. For each OS the string is painfully specific... Current implementation works fine for Windows, Linux and macOS.\r\n\r\n#### Implementation\r\nIn order to send data to GA, we are using a `universal-analytics` npm package. We cannot use Google's default libraries (`analytics.js`, `gtag.js`) as they are written for browser. So the only way to track data is to use the Measurement Protocol (directly send http requests). However, `universal-analytics` package provides a very good abstraction over the Measurement Protocol, so we are using it instead of implementing each call.\r\n\r\nMore information about Measurement protocol:\r\nhttps://developers.google.com/analytics/devguides/collection/protocol/v1/parameters\r\n","created_at":"2017-08-24T12:31:09Z","updated_at":"2017-09-05T14:51:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c05ef35a581045fb6b9c73f2ca452dc3cbcdcd4","assignee":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars1.githubusercontent.com/u/8351653?v=4","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"assignees":[{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars1.githubusercontent.com/u/8351653?v=4","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nadyaA","id":6064810,"avatar_url":"https://avatars2.githubusercontent.com/u/6064810?v=4","gravatar_id":"","url":"https://api.github.com/users/nadyaA","html_url":"https://github.com/nadyaA","followers_url":"https://api.github.com/users/nadyaA/followers","following_url":"https://api.github.com/users/nadyaA/following{/other_user}","gists_url":"https://api.github.com/users/nadyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/nadyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadyaA/subscriptions","organizations_url":"https://api.github.com/users/nadyaA/orgs","repos_url":"https://api.github.com/users/nadyaA/repos","events_url":"https://api.github.com/users/nadyaA/events{/privacy}","received_events_url":"https://api.github.com/users/nadyaA/received_events","type":"User","site_admin":false},{"login":"TomaNikolov","id":9978471,"avatar_url":"https://avatars3.githubusercontent.com/u/9978471?v=4","gravatar_id":"","url":"https://api.github.com/users/TomaNikolov","html_url":"https://github.com/TomaNikolov","followers_url":"https://api.github.com/users/TomaNikolov/followers","following_url":"https://api.github.com/users/TomaNikolov/following{/other_user}","gists_url":"https://api.github.com/users/TomaNikolov/gists{/gist_id}","starred_url":"https://api.github.com/users/TomaNikolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomaNikolov/subscriptions","organizations_url":"https://api.github.com/users/TomaNikolov/orgs","repos_url":"https://api.github.com/users/TomaNikolov/repos","events_url":"https://api.github.com/users/TomaNikolov/events{/privacy}","received_events_url":"https://api.github.com/users/TomaNikolov/received_events","type":"User","site_admin":false},{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars1.githubusercontent.com/u/10463529?v=4","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/milestones/56","html_url":"https://github.com/NativeScript/nativescript-cli/milestone/56","labels_url":"https://api.github.com/repos/NativeScript/nativescript-cli/milestones/56/labels","id":2564756,"number":56,"title":"3.2.0","description":"","creator":{"login":"pkoleva","id":7813201,"avatar_url":"https://avatars1.githubusercontent.com/u/7813201?v=4","gravatar_id":"","url":"https://api.github.com/users/pkoleva","html_url":"https://github.com/pkoleva","followers_url":"https://api.github.com/users/pkoleva/followers","following_url":"https://api.github.com/users/pkoleva/following{/other_user}","gists_url":"https://api.github.com/users/pkoleva/gists{/gist_id}","starred_url":"https://api.github.com/users/pkoleva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkoleva/subscriptions","organizations_url":"https://api.github.com/users/pkoleva/orgs","repos_url":"https://api.github.com/users/pkoleva/repos","events_url":"https://api.github.com/users/pkoleva/events{/privacy}","received_events_url":"https://api.github.com/users/pkoleva/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":31,"state":"open","created_at":"2017-06-06T11:53:15Z","updated_at":"2017-08-29T10:15:30Z","due_on":"2017-08-22T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3088/commits","review_comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3088/comments","review_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/3088/comments","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/9bd85d810603bdcd8aceed4d092a9d40e3d131b7","head":{"label":"NativeScript:vladimirov/analytics","ref":"vladimirov/analytics","sha":"9bd85d810603bdcd8aceed4d092a9d40e3d131b7","user":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":21347346,"name":"nativescript-cli","full_name":"NativeScript/nativescript-cli","owner":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NativeScript/nativescript-cli","description":"Command-line interface for building NativeScript apps","fork":false,"url":"https://api.github.com/repos/NativeScript/nativescript-cli","forks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/forks","keys_url":"https://api.github.com/repos/NativeScript/nativescript-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/nativescript-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/nativescript-cli/teams","hooks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/events","assignees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/nativescript-cli/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/tags","blobs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/nativescript-cli/languages","stargazers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscription","commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/nativescript-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/nativescript-cli/merges","archive_url":"https://api.github.com/repos/NativeScript/nativescript-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/nativescript-cli/downloads","issues_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/nativescript-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/nativescript-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/nativescript-cli/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/nativescript-cli/releases{/id}","deployments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/deployments","created_at":"2014-06-30T10:21:20Z","updated_at":"2017-09-04T17:17:09Z","pushed_at":"2017-09-05T12:28:44Z","git_url":"git://github.com/NativeScript/nativescript-cli.git","ssh_url":"[email protected]:NativeScript/nativescript-cli.git","clone_url":"https://github.com/NativeScript/nativescript-cli.git","svn_url":"https://github.com/NativeScript/nativescript-cli","homepage":"https://www.npmjs.com/package/nativescript","size":37627,"stargazers_count":567,"watchers_count":567,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":128,"forks":110,"open_issues":128,"watchers":567,"default_branch":"master"}},"base":{"label":"NativeScript:master","ref":"master","sha":"608737f28c013b1b02755116aa8820c37837bc10","user":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":21347346,"name":"nativescript-cli","full_name":"NativeScript/nativescript-cli","owner":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NativeScript/nativescript-cli","description":"Command-line interface for building NativeScript apps","fork":false,"url":"https://api.github.com/repos/NativeScript/nativescript-cli","forks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/forks","keys_url":"https://api.github.com/repos/NativeScript/nativescript-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/nativescript-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/nativescript-cli/teams","hooks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/events","assignees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/nativescript-cli/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/tags","blobs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/nativescript-cli/languages","stargazers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscription","commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/nativescript-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/nativescript-cli/merges","archive_url":"https://api.github.com/repos/NativeScript/nativescript-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/nativescript-cli/downloads","issues_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/nativescript-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/nativescript-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/nativescript-cli/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/nativescript-cli/releases{/id}","deployments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/deployments","created_at":"2014-06-30T10:21:20Z","updated_at":"2017-09-04T17:17:09Z","pushed_at":"2017-09-05T12:28:44Z","git_url":"git://github.com/NativeScript/nativescript-cli.git","ssh_url":"[email protected]:NativeScript/nativescript-cli.git","clone_url":"https://github.com/NativeScript/nativescript-cli.git","svn_url":"https://github.com/NativeScript/nativescript-cli","homepage":"https://www.npmjs.com/package/nativescript","size":37627,"stargazers_count":567,"watchers_count":567,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":128,"forks":110,"open_issues":128,"watchers":567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3088"},"html":{"href":"https://github.com/NativeScript/nativescript-cli/pull/3088"},"issue":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/3088"},"comments":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/3088/comments"},"review_comments":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3088/comments"},"review_comment":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3088/commits"},"statuses":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/9bd85d810603bdcd8aceed4d092a9d40e3d131b7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 21347346,
"name": "NativeScript/nativescript-cli",
"url": "https://api.github.com/repos/NativeScript/nativescript-cli"
} | {
"id": 6683316,
"login": "Mitko-Kerezov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6683316?",
"url": "https://api.github.com/users/Mitko-Kerezov"
} | {
"id": 7392261,
"login": "NativeScript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7392261?",
"url": "https://api.github.com/orgs/NativeScript"
} | 2017-09-05T14:45:55 | 6551467629 | {"actor":{"display_login":"Mitko-Kerezov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OceanParcels/parcels/pulls/comments/149956502","pull_request_review_id":75431433,"id":149956502,"diff_hunk":"@@ -69,26 +69,45 @@ The best way to get started with Parcels is to have a look at the Jupyter notebo\n \n * `Plotting tutorial <http://nbviewer.jupyter.org/github/OceanParcels/parcels/blob/master/examples/tutorial_plotting.ipynb>`_ for further explanation on the plotting capabilities of Parcels\n \n-Installing Parcels\n-===================================\n+Installing Parcels on Linux and macOS\n+=====================================\n+\n+Parcels depends on a working Python installation, a netCDF installation, a C\n+compiler, and various Python packages. \n+\n+The simplest way to install Parcels is to use Anaconda and Conda-Forge for all \n+requirements. This is the “batteries-included” solution probably suitable for most users.\n+\n+1. Install Anaconda's Miniconda following the steps at https://conda.io/docs/user-guide/install/. Be sure to download the Python 2.7 version.\n+\n+2. Download Parcels' `environment.yml <https://raw.githubusercontent.com/OceanParcels/parcels/install_via_conda/environment.yml>`_ file and run::\n+\n+ source $HOME/miniconda2/bin/activate root\n+ conda env create -f environment.yml -n py2_parcels\n+ source $HOME/miniconda2/bin/activate py2_parcels\n+ pip install git+https://github.com/OceanParcels/parcels.git@master\n+\n+3. Validate the installation by downloading the `example_peninsula.py <https://raw.githubusercontent.com/OceanParcels/parcels/master/examples/example_peninsula.py>`_ file and then run::\n+\n+ python example_peninsula.py --fieldset 100 100\n+\n+4. Optionally, if you want to run all the examples and tutorials, you may want to download the example hydrodynamic fields by downloading the `pull_data.py <https://raw.githubusercontent.com/OceanParcels/parcels/master/parcels/scripts/pull_data.py>`_ file and then run::\n+\n+ python pull_data.py\n \n-The latest version of Parcels, including tests and examples, \n-can be obtained directly from github via::\n- git clone https://github.com/OceanParcels/parcels.git\n- cd parcels; pip install -r requirements.txt\n- python scripts/pull_data.py\n- export PYTHONPATH=\"$PYTHONPATH:$PWD\"\n+5. The next time you log in to your machine and want to work with Parcels, activate the environment with::\n \n-In order for Parcels to work from any directory, add the following line to \n-your ~/.bash_profile::\n- export PYTHONPATH=\"$PYTHONPATH:$PWD\"\n+ source $HOME/miniconda2/bin/activate py2_parcels","path":"docs/index.rst","position":58,"original_position":43,"commit_id":"19e74fa316962f2025998ae6681447d3e713155b","original_commit_id":"6bdeacde721d1691b43f3c70d7fb1178b7b5e571","user":{"login":"delandmeterp","id":31093031,"avatar_url":"https://avatars2.githubusercontent.com/u/31093031?v=4","gravatar_id":"","url":"https://api.github.com/users/delandmeterp","html_url":"https://github.com/delandmeterp","followers_url":"https://api.github.com/users/delandmeterp/followers","following_url":"https://api.github.com/users/delandmeterp/following{/other_user}","gists_url":"https://api.github.com/users/delandmeterp/gists{/gist_id}","starred_url":"https://api.github.com/users/delandmeterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delandmeterp/subscriptions","organizations_url":"https://api.github.com/users/delandmeterp/orgs","repos_url":"https://api.github.com/users/delandmeterp/repos","events_url":"https://api.github.com/users/delandmeterp/events{/privacy}","received_events_url":"https://api.github.com/users/delandmeterp/received_events","type":"User","site_admin":false},"body":"Ok, you're right","created_at":"2017-11-09T13:11:51Z","updated_at":"2017-11-09T13:13:05Z","html_url":"https://github.com/OceanParcels/parcels/pull/228#discussion_r149956502","pull_request_url":"https://api.github.com/repos/OceanParcels/parcels/pulls/228","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/comments/149956502"},"html":{"href":"https://github.com/OceanParcels/parcels/pull/228#discussion_r149956502"},"pull_request":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/228"}},"in_reply_to_id":149884386},"pull_request":{"url":"https://api.github.com/repos/OceanParcels/parcels/pulls/228","id":150584849,"html_url":"https://github.com/OceanParcels/parcels/pull/228","diff_url":"https://github.com/OceanParcels/parcels/pull/228.diff","patch_url":"https://github.com/OceanParcels/parcels/pull/228.patch","issue_url":"https://api.github.com/repos/OceanParcels/parcels/issues/228","number":228,"state":"closed","locked":false,"title":"Install via conda","user":{"login":"erikvansebille","id":14315062,"avatar_url":"https://avatars0.githubusercontent.com/u/14315062?v=4","gravatar_id":"","url":"https://api.github.com/users/erikvansebille","html_url":"https://github.com/erikvansebille","followers_url":"https://api.github.com/users/erikvansebille/followers","following_url":"https://api.github.com/users/erikvansebille/following{/other_user}","gists_url":"https://api.github.com/users/erikvansebille/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvansebille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvansebille/subscriptions","organizations_url":"https://api.github.com/users/erikvansebille/orgs","repos_url":"https://api.github.com/users/erikvansebille/repos","events_url":"https://api.github.com/users/erikvansebille/events{/privacy}","received_events_url":"https://api.github.com/users/erikvansebille/received_events","type":"User","site_admin":false},"body":"Changing the installation scripts and notes to install via `conda-forge`, as suggested by @willirath and @rabernat. \r\nAim is to fix #225 and #104, and also #226 as that was playing havoc on Travis","created_at":"2017-11-03T17:22:03Z","updated_at":"2017-11-09T13:13:05Z","closed_at":"2017-11-09T13:12:00Z","merged_at":"2017-11-09T13:12:00Z","merge_commit_sha":"2c2240076fc58abb12fb12d527c4711d297f174a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OceanParcels/parcels/pulls/228/commits","review_comments_url":"https://api.github.com/repos/OceanParcels/parcels/pulls/228/comments","review_comment_url":"https://api.github.com/repos/OceanParcels/parcels/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OceanParcels/parcels/issues/228/comments","statuses_url":"https://api.github.com/repos/OceanParcels/parcels/statuses/19e74fa316962f2025998ae6681447d3e713155b","head":{"label":"OceanParcels:install_via_conda","ref":"install_via_conda","sha":"19e74fa316962f2025998ae6681447d3e713155b","user":{"login":"OceanParcels","id":14887518,"avatar_url":"https://avatars3.githubusercontent.com/u/14887518?v=4","gravatar_id":"","url":"https://api.github.com/users/OceanParcels","html_url":"https://github.com/OceanParcels","followers_url":"https://api.github.com/users/OceanParcels/followers","following_url":"https://api.github.com/users/OceanParcels/following{/other_user}","gists_url":"https://api.github.com/users/OceanParcels/gists{/gist_id}","starred_url":"https://api.github.com/users/OceanParcels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OceanParcels/subscriptions","organizations_url":"https://api.github.com/users/OceanParcels/orgs","repos_url":"https://api.github.com/users/OceanParcels/repos","events_url":"https://api.github.com/users/OceanParcels/events{/privacy}","received_events_url":"https://api.github.com/users/OceanParcels/received_events","type":"Organization","site_admin":false},"repo":{"id":43358723,"name":"parcels","full_name":"OceanParcels/parcels","owner":{"login":"OceanParcels","id":14887518,"avatar_url":"https://avatars3.githubusercontent.com/u/14887518?v=4","gravatar_id":"","url":"https://api.github.com/users/OceanParcels","html_url":"https://github.com/OceanParcels","followers_url":"https://api.github.com/users/OceanParcels/followers","following_url":"https://api.github.com/users/OceanParcels/following{/other_user}","gists_url":"https://api.github.com/users/OceanParcels/gists{/gist_id}","starred_url":"https://api.github.com/users/OceanParcels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OceanParcels/subscriptions","organizations_url":"https://api.github.com/users/OceanParcels/orgs","repos_url":"https://api.github.com/users/OceanParcels/repos","events_url":"https://api.github.com/users/OceanParcels/events{/privacy}","received_events_url":"https://api.github.com/users/OceanParcels/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OceanParcels/parcels","description":"Main code for Parcels (Probably A Really Computationally Efficient Lagrangian Simulator)","fork":false,"url":"https://api.github.com/repos/OceanParcels/parcels","forks_url":"https://api.github.com/repos/OceanParcels/parcels/forks","keys_url":"https://api.github.com/repos/OceanParcels/parcels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OceanParcels/parcels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OceanParcels/parcels/teams","hooks_url":"https://api.github.com/repos/OceanParcels/parcels/hooks","issue_events_url":"https://api.github.com/repos/OceanParcels/parcels/issues/events{/number}","events_url":"https://api.github.com/repos/OceanParcels/parcels/events","assignees_url":"https://api.github.com/repos/OceanParcels/parcels/assignees{/user}","branches_url":"https://api.github.com/repos/OceanParcels/parcels/branches{/branch}","tags_url":"https://api.github.com/repos/OceanParcels/parcels/tags","blobs_url":"https://api.github.com/repos/OceanParcels/parcels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OceanParcels/parcels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OceanParcels/parcels/git/refs{/sha}","trees_url":"https://api.github.com/repos/OceanParcels/parcels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OceanParcels/parcels/statuses/{sha}","languages_url":"https://api.github.com/repos/OceanParcels/parcels/languages","stargazers_url":"https://api.github.com/repos/OceanParcels/parcels/stargazers","contributors_url":"https://api.github.com/repos/OceanParcels/parcels/contributors","subscribers_url":"https://api.github.com/repos/OceanParcels/parcels/subscribers","subscription_url":"https://api.github.com/repos/OceanParcels/parcels/subscription","commits_url":"https://api.github.com/repos/OceanParcels/parcels/commits{/sha}","git_commits_url":"https://api.github.com/repos/OceanParcels/parcels/git/commits{/sha}","comments_url":"https://api.github.com/repos/OceanParcels/parcels/comments{/number}","issue_comment_url":"https://api.github.com/repos/OceanParcels/parcels/issues/comments{/number}","contents_url":"https://api.github.com/repos/OceanParcels/parcels/contents/{+path}","compare_url":"https://api.github.com/repos/OceanParcels/parcels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OceanParcels/parcels/merges","archive_url":"https://api.github.com/repos/OceanParcels/parcels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OceanParcels/parcels/downloads","issues_url":"https://api.github.com/repos/OceanParcels/parcels/issues{/number}","pulls_url":"https://api.github.com/repos/OceanParcels/parcels/pulls{/number}","milestones_url":"https://api.github.com/repos/OceanParcels/parcels/milestones{/number}","notifications_url":"https://api.github.com/repos/OceanParcels/parcels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OceanParcels/parcels/labels{/name}","releases_url":"https://api.github.com/repos/OceanParcels/parcels/releases{/id}","deployments_url":"https://api.github.com/repos/OceanParcels/parcels/deployments","created_at":"2015-09-29T09:43:00Z","updated_at":"2017-11-01T14:01:51Z","pushed_at":"2017-11-09T13:12:04Z","git_url":"git://github.com/OceanParcels/parcels.git","ssh_url":"[email protected]:OceanParcels/parcels.git","clone_url":"https://github.com/OceanParcels/parcels.git","svn_url":"https://github.com/OceanParcels/parcels","homepage":"http://www.oceanparcels.org","size":4976,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":15,"forks":17,"open_issues":15,"watchers":12,"default_branch":"master"}},"base":{"label":"OceanParcels:master","ref":"master","sha":"b9cda2503253b4ea26dd5c8162b2457773f598a5","user":{"login":"OceanParcels","id":14887518,"avatar_url":"https://avatars3.githubusercontent.com/u/14887518?v=4","gravatar_id":"","url":"https://api.github.com/users/OceanParcels","html_url":"https://github.com/OceanParcels","followers_url":"https://api.github.com/users/OceanParcels/followers","following_url":"https://api.github.com/users/OceanParcels/following{/other_user}","gists_url":"https://api.github.com/users/OceanParcels/gists{/gist_id}","starred_url":"https://api.github.com/users/OceanParcels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OceanParcels/subscriptions","organizations_url":"https://api.github.com/users/OceanParcels/orgs","repos_url":"https://api.github.com/users/OceanParcels/repos","events_url":"https://api.github.com/users/OceanParcels/events{/privacy}","received_events_url":"https://api.github.com/users/OceanParcels/received_events","type":"Organization","site_admin":false},"repo":{"id":43358723,"name":"parcels","full_name":"OceanParcels/parcels","owner":{"login":"OceanParcels","id":14887518,"avatar_url":"https://avatars3.githubusercontent.com/u/14887518?v=4","gravatar_id":"","url":"https://api.github.com/users/OceanParcels","html_url":"https://github.com/OceanParcels","followers_url":"https://api.github.com/users/OceanParcels/followers","following_url":"https://api.github.com/users/OceanParcels/following{/other_user}","gists_url":"https://api.github.com/users/OceanParcels/gists{/gist_id}","starred_url":"https://api.github.com/users/OceanParcels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OceanParcels/subscriptions","organizations_url":"https://api.github.com/users/OceanParcels/orgs","repos_url":"https://api.github.com/users/OceanParcels/repos","events_url":"https://api.github.com/users/OceanParcels/events{/privacy}","received_events_url":"https://api.github.com/users/OceanParcels/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OceanParcels/parcels","description":"Main code for Parcels (Probably A Really Computationally Efficient Lagrangian Simulator)","fork":false,"url":"https://api.github.com/repos/OceanParcels/parcels","forks_url":"https://api.github.com/repos/OceanParcels/parcels/forks","keys_url":"https://api.github.com/repos/OceanParcels/parcels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OceanParcels/parcels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OceanParcels/parcels/teams","hooks_url":"https://api.github.com/repos/OceanParcels/parcels/hooks","issue_events_url":"https://api.github.com/repos/OceanParcels/parcels/issues/events{/number}","events_url":"https://api.github.com/repos/OceanParcels/parcels/events","assignees_url":"https://api.github.com/repos/OceanParcels/parcels/assignees{/user}","branches_url":"https://api.github.com/repos/OceanParcels/parcels/branches{/branch}","tags_url":"https://api.github.com/repos/OceanParcels/parcels/tags","blobs_url":"https://api.github.com/repos/OceanParcels/parcels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OceanParcels/parcels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OceanParcels/parcels/git/refs{/sha}","trees_url":"https://api.github.com/repos/OceanParcels/parcels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OceanParcels/parcels/statuses/{sha}","languages_url":"https://api.github.com/repos/OceanParcels/parcels/languages","stargazers_url":"https://api.github.com/repos/OceanParcels/parcels/stargazers","contributors_url":"https://api.github.com/repos/OceanParcels/parcels/contributors","subscribers_url":"https://api.github.com/repos/OceanParcels/parcels/subscribers","subscription_url":"https://api.github.com/repos/OceanParcels/parcels/subscription","commits_url":"https://api.github.com/repos/OceanParcels/parcels/commits{/sha}","git_commits_url":"https://api.github.com/repos/OceanParcels/parcels/git/commits{/sha}","comments_url":"https://api.github.com/repos/OceanParcels/parcels/comments{/number}","issue_comment_url":"https://api.github.com/repos/OceanParcels/parcels/issues/comments{/number}","contents_url":"https://api.github.com/repos/OceanParcels/parcels/contents/{+path}","compare_url":"https://api.github.com/repos/OceanParcels/parcels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OceanParcels/parcels/merges","archive_url":"https://api.github.com/repos/OceanParcels/parcels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OceanParcels/parcels/downloads","issues_url":"https://api.github.com/repos/OceanParcels/parcels/issues{/number}","pulls_url":"https://api.github.com/repos/OceanParcels/parcels/pulls{/number}","milestones_url":"https://api.github.com/repos/OceanParcels/parcels/milestones{/number}","notifications_url":"https://api.github.com/repos/OceanParcels/parcels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OceanParcels/parcels/labels{/name}","releases_url":"https://api.github.com/repos/OceanParcels/parcels/releases{/id}","deployments_url":"https://api.github.com/repos/OceanParcels/parcels/deployments","created_at":"2015-09-29T09:43:00Z","updated_at":"2017-11-01T14:01:51Z","pushed_at":"2017-11-09T13:12:04Z","git_url":"git://github.com/OceanParcels/parcels.git","ssh_url":"[email protected]:OceanParcels/parcels.git","clone_url":"https://github.com/OceanParcels/parcels.git","svn_url":"https://github.com/OceanParcels/parcels","homepage":"http://www.oceanparcels.org","size":4976,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":15,"forks":17,"open_issues":15,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/228"},"html":{"href":"https://github.com/OceanParcels/parcels/pull/228"},"issue":{"href":"https://api.github.com/repos/OceanParcels/parcels/issues/228"},"comments":{"href":"https://api.github.com/repos/OceanParcels/parcels/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/OceanParcels/parcels/statuses/19e74fa316962f2025998ae6681447d3e713155b"}},"author_association":"OWNER"}} | {
"id": 43358723,
"name": "OceanParcels/parcels",
"url": "https://api.github.com/repos/OceanParcels/parcels"
} | {
"id": 31093031,
"login": "delandmeterp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31093031?",
"url": "https://api.github.com/users/delandmeterp"
} | {
"id": 14887518,
"login": "OceanParcels",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14887518?",
"url": "https://api.github.com/orgs/OceanParcels"
} | 2017-11-09T13:11:51 | 6832021635 | {"actor":{"display_login":"delandmeterp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/comments/125716911","pull_request_review_id":48133618,"id":125716911,"diff_hunk":"@@ -1579,6 +1579,85 @@ algorithm\n end if;\n end createBipartiteGraph;\n \n+public function createFMIModelDerivatives\n+\"This function genererate the stucture output and the\n+ partial derivatives for FMI, which are basically the jacobian matrices.\n+ author: wbraun\"\n+ input BackendDAE.BackendDAE inBackendDAE;\n+ output BackendDAE.SymbolicJacobians outJacobianMatrixes = {};\n+ output DAE.FunctionTree outFunctionTree;\n+protected\n+ BackendDAE.BackendDAE backendDAE,emptyBDAE;\n+ BackendDAE.EqSystem eqSyst;\n+ Option<BackendDAE.SymbolicJacobian> outJacobian;\n+\n+ list<BackendDAE.Var> varlst, knvarlst, states, inputvars, outputvars, paramvars, indepVars, depVars;\n+\n+ BackendDAE.Variables v,globalKnownVars,statesarr,inputvarsarr,paramvarsarr,outputvarsarr, depVarsArr;\n+\n+ BackendDAE.SparsePattern sparsePattern;\n+ BackendDAE.SparseColoring sparseColoring;\n+\n+ DAE.FunctionTree funcs, functionTree;\n+\n+ BackendDAE.ExtraInfo ei;\n+ FCore.Cache cache;\n+ FCore.Graph graph;\n+algorithm\n+try\n+\t// for now perform on collapsed system","path":"Compiler/BackEnd/SymbolicJacobian.mo","position":30,"original_position":30,"commit_id":"7755c35825ae27613bbdd3389d9958ee3bff0fbd","original_commit_id":"7755c35825ae27613bbdd3389d9958ee3bff0fbd","user":{"login":"sjoelund","id":3016460,"avatar_url":"https://avatars3.githubusercontent.com/u/3016460?v=3","gravatar_id":"","url":"https://api.github.com/users/sjoelund","html_url":"https://github.com/sjoelund","followers_url":"https://api.github.com/users/sjoelund/followers","following_url":"https://api.github.com/users/sjoelund/following{/other_user}","gists_url":"https://api.github.com/users/sjoelund/gists{/gist_id}","starred_url":"https://api.github.com/users/sjoelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjoelund/subscriptions","organizations_url":"https://api.github.com/users/sjoelund/orgs","repos_url":"https://api.github.com/users/sjoelund/repos","events_url":"https://api.github.com/users/sjoelund/events{/privacy}","received_events_url":"https://api.github.com/users/sjoelund/received_events","type":"User","site_admin":false},"body":"Not since we added the pre-commit hook that replaces all tabs. You shouldn't disable it ;)","created_at":"2017-07-05T18:06:47Z","updated_at":"2017-07-05T18:06:47Z","html_url":"https://github.com/OpenModelica/OMCompiler/pull/1715#discussion_r125716911","pull_request_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1715","_links":{"self":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/comments/125716911"},"html":{"href":"https://github.com/OpenModelica/OMCompiler/pull/1715#discussion_r125716911"},"pull_request":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1715"}}},"pull_request":{"url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1715","id":128983152,"html_url":"https://github.com/OpenModelica/OMCompiler/pull/1715","diff_url":"https://github.com/OpenModelica/OMCompiler/pull/1715.diff","patch_url":"https://github.com/OpenModelica/OMCompiler/pull/1715.patch","issue_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/1715","number":1715,"state":"open","locked":false,"title":"fixing continuous partial derivatives for fmi","user":{"login":"wibraun","id":7063430,"avatar_url":"https://avatars3.githubusercontent.com/u/7063430?v=3","gravatar_id":"","url":"https://api.github.com/users/wibraun","html_url":"https://github.com/wibraun","followers_url":"https://api.github.com/users/wibraun/followers","following_url":"https://api.github.com/users/wibraun/following{/other_user}","gists_url":"https://api.github.com/users/wibraun/gists{/gist_id}","starred_url":"https://api.github.com/users/wibraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wibraun/subscriptions","organizations_url":"https://api.github.com/users/wibraun/orgs","repos_url":"https://api.github.com/users/wibraun/repos","events_url":"https://api.github.com/users/wibraun/events{/privacy}","received_events_url":"https://api.github.com/users/wibraun/received_events","type":"User","site_admin":false},"body":"- rewrite the structure for the dependencies and the partial derivatives generation\r\n- enable them by default\r\n- adjust C-runtime code generation","created_at":"2017-07-05T14:53:58Z","updated_at":"2017-07-05T18:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30987c135ed118951aae197e29e75a74595004b9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1715/commits","review_comments_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1715/comments","review_comment_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/1715/comments","statuses_url":"https://api.github.com/repos/OpenModelica/OMCompiler/statuses/7755c35825ae27613bbdd3389d9958ee3bff0fbd","head":{"label":"wibraun:fmi20Der","ref":"fmi20Der","sha":"7755c35825ae27613bbdd3389d9958ee3bff0fbd","user":{"login":"wibraun","id":7063430,"avatar_url":"https://avatars3.githubusercontent.com/u/7063430?v=3","gravatar_id":"","url":"https://api.github.com/users/wibraun","html_url":"https://github.com/wibraun","followers_url":"https://api.github.com/users/wibraun/followers","following_url":"https://api.github.com/users/wibraun/following{/other_user}","gists_url":"https://api.github.com/users/wibraun/gists{/gist_id}","starred_url":"https://api.github.com/users/wibraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wibraun/subscriptions","organizations_url":"https://api.github.com/users/wibraun/orgs","repos_url":"https://api.github.com/users/wibraun/repos","events_url":"https://api.github.com/users/wibraun/events{/privacy}","received_events_url":"https://api.github.com/users/wibraun/received_events","type":"User","site_admin":false},"repo":{"id":35423583,"name":"OMCompiler","full_name":"wibraun/OMCompiler","owner":{"login":"wibraun","id":7063430,"avatar_url":"https://avatars3.githubusercontent.com/u/7063430?v=3","gravatar_id":"","url":"https://api.github.com/users/wibraun","html_url":"https://github.com/wibraun","followers_url":"https://api.github.com/users/wibraun/followers","following_url":"https://api.github.com/users/wibraun/following{/other_user}","gists_url":"https://api.github.com/users/wibraun/gists{/gist_id}","starred_url":"https://api.github.com/users/wibraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wibraun/subscriptions","organizations_url":"https://api.github.com/users/wibraun/orgs","repos_url":"https://api.github.com/users/wibraun/repos","events_url":"https://api.github.com/users/wibraun/events{/privacy}","received_events_url":"https://api.github.com/users/wibraun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wibraun/OMCompiler","description":"The OpenModelica Compiler is the core of the OpenModelica project, which is an open-source Modelica-based modeling and simulation environment intended for industrial and academic usage.","fork":true,"url":"https://api.github.com/repos/wibraun/OMCompiler","forks_url":"https://api.github.com/repos/wibraun/OMCompiler/forks","keys_url":"https://api.github.com/repos/wibraun/OMCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wibraun/OMCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wibraun/OMCompiler/teams","hooks_url":"https://api.github.com/repos/wibraun/OMCompiler/hooks","issue_events_url":"https://api.github.com/repos/wibraun/OMCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/wibraun/OMCompiler/events","assignees_url":"https://api.github.com/repos/wibraun/OMCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/wibraun/OMCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/wibraun/OMCompiler/tags","blobs_url":"https://api.github.com/repos/wibraun/OMCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wibraun/OMCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wibraun/OMCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/wibraun/OMCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wibraun/OMCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/wibraun/OMCompiler/languages","stargazers_url":"https://api.github.com/repos/wibraun/OMCompiler/stargazers","contributors_url":"https://api.github.com/repos/wibraun/OMCompiler/contributors","subscribers_url":"https://api.github.com/repos/wibraun/OMCompiler/subscribers","subscription_url":"https://api.github.com/repos/wibraun/OMCompiler/subscription","commits_url":"https://api.github.com/repos/wibraun/OMCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/wibraun/OMCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/wibraun/OMCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/wibraun/OMCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/wibraun/OMCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/wibraun/OMCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wibraun/OMCompiler/merges","archive_url":"https://api.github.com/repos/wibraun/OMCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wibraun/OMCompiler/downloads","issues_url":"https://api.github.com/repos/wibraun/OMCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/wibraun/OMCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/wibraun/OMCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/wibraun/OMCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wibraun/OMCompiler/labels{/name}","releases_url":"https://api.github.com/repos/wibraun/OMCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/wibraun/OMCompiler/deployments","created_at":"2015-05-11T12:51:33Z","updated_at":"2016-01-13T14:18:47Z","pushed_at":"2017-07-05T15:03:42Z","git_url":"git://github.com/wibraun/OMCompiler.git","ssh_url":"[email protected]:wibraun/OMCompiler.git","clone_url":"https://github.com/wibraun/OMCompiler.git","svn_url":"https://github.com/wibraun/OMCompiler","homepage":"https://trac.openmodelica.org/OpenModelica","size":68861,"stargazers_count":0,"watchers_count":0,"language":"Modelica","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenModelica:master","ref":"master","sha":"0b0a647ac755cd9152ff8833b65f66ca94aec5f2","user":{"login":"OpenModelica","id":4006504,"avatar_url":"https://avatars2.githubusercontent.com/u/4006504?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenModelica","html_url":"https://github.com/OpenModelica","followers_url":"https://api.github.com/users/OpenModelica/followers","following_url":"https://api.github.com/users/OpenModelica/following{/other_user}","gists_url":"https://api.github.com/users/OpenModelica/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModelica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModelica/subscriptions","organizations_url":"https://api.github.com/users/OpenModelica/orgs","repos_url":"https://api.github.com/users/OpenModelica/repos","events_url":"https://api.github.com/users/OpenModelica/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModelica/received_events","type":"Organization","site_admin":false},"repo":{"id":35014743,"name":"OMCompiler","full_name":"OpenModelica/OMCompiler","owner":{"login":"OpenModelica","id":4006504,"avatar_url":"https://avatars2.githubusercontent.com/u/4006504?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenModelica","html_url":"https://github.com/OpenModelica","followers_url":"https://api.github.com/users/OpenModelica/followers","following_url":"https://api.github.com/users/OpenModelica/following{/other_user}","gists_url":"https://api.github.com/users/OpenModelica/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModelica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModelica/subscriptions","organizations_url":"https://api.github.com/users/OpenModelica/orgs","repos_url":"https://api.github.com/users/OpenModelica/repos","events_url":"https://api.github.com/users/OpenModelica/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModelica/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenModelica/OMCompiler","description":"The OpenModelica Compiler is the core of the OpenModelica project, which is an open-source Modelica-based modeling and simulation environment intended for industrial and academic usage.","fork":false,"url":"https://api.github.com/repos/OpenModelica/OMCompiler","forks_url":"https://api.github.com/repos/OpenModelica/OMCompiler/forks","keys_url":"https://api.github.com/repos/OpenModelica/OMCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenModelica/OMCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenModelica/OMCompiler/teams","hooks_url":"https://api.github.com/repos/OpenModelica/OMCompiler/hooks","issue_events_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/OpenModelica/OMCompiler/events","assignees_url":"https://api.github.com/repos/OpenModelica/OMCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/OpenModelica/OMCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/OpenModelica/OMCompiler/tags","blobs_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenModelica/OMCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenModelica/OMCompiler/languages","stargazers_url":"https://api.github.com/repos/OpenModelica/OMCompiler/stargazers","contributors_url":"https://api.github.com/repos/OpenModelica/OMCompiler/contributors","subscribers_url":"https://api.github.com/repos/OpenModelica/OMCompiler/subscribers","subscription_url":"https://api.github.com/repos/OpenModelica/OMCompiler/subscription","commits_url":"https://api.github.com/repos/OpenModelica/OMCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenModelica/OMCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenModelica/OMCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenModelica/OMCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/OpenModelica/OMCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenModelica/OMCompiler/merges","archive_url":"https://api.github.com/repos/OpenModelica/OMCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenModelica/OMCompiler/downloads","issues_url":"https://api.github.com/repos/OpenModelica/OMCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenModelica/OMCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenModelica/OMCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenModelica/OMCompiler/labels{/name}","releases_url":"https://api.github.com/repos/OpenModelica/OMCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/OpenModelica/OMCompiler/deployments","created_at":"2015-05-04T04:53:52Z","updated_at":"2017-05-23T21:51:07Z","pushed_at":"2017-07-05T15:47:50Z","git_url":"git://github.com/OpenModelica/OMCompiler.git","ssh_url":"[email protected]:OpenModelica/OMCompiler.git","clone_url":"https://github.com/OpenModelica/OMCompiler.git","svn_url":"https://github.com/OpenModelica/OMCompiler","homepage":"https://trac.openmodelica.org/OpenModelica","size":68228,"stargazers_count":18,"watchers_count":18,"language":"Modelica","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":10,"forks":50,"open_issues":10,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1715"},"html":{"href":"https://github.com/OpenModelica/OMCompiler/pull/1715"},"issue":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/1715"},"comments":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/issues/1715/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1715/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/pulls/1715/commits"},"statuses":{"href":"https://api.github.com/repos/OpenModelica/OMCompiler/statuses/7755c35825ae27613bbdd3389d9958ee3bff0fbd"}}}} | {
"id": 35014743,
"name": "OpenModelica/OMCompiler",
"url": "https://api.github.com/repos/OpenModelica/OMCompiler"
} | {
"id": 3016460,
"login": "sjoelund",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3016460?",
"url": "https://api.github.com/users/sjoelund"
} | {
"id": 4006504,
"login": "OpenModelica",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4006504?",
"url": "https://api.github.com/orgs/OpenModelica"
} | 2017-07-05T18:06:47 | 6197986436 | {"actor":{"display_login":"sjoelund"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/106592075","pull_request_review_id":27521045,"id":106592075,"diff_hunk":"@@ -65,4 +88,46 @@ if [[ ${BUILD_AND_INSTALL:-OFF} == 'ON' ]]; then\n fi\n fi\n \n+# generate production docker image Dockerfile\n+if [ ${USE_MIRROR} ]; then\n+ MIRROR_UPDATE=\"sed 's@http:\\/\\/archive.ubuntu.com\\/ubuntu\\/@mirror:\\/\\/mirrors.ubuntu.com\\/mirrors.txt@' -i /etc/apt/sources.list && \\\\\"\n+else\n+ MIRROR_UPDATE=\"\\\\\"\n+fi\n+\n+cat > /paddle/build/Dockerfile <<EOF","path":"paddle/scripts/docker/build.sh","position":54,"original_position":54,"commit_id":"1ab419a1bdd5dd5013d923b156ac44c8db0d8955","original_commit_id":"1ab419a1bdd5dd5013d923b156ac44c8db0d8955","user":{"login":"gangliao","id":3071933,"avatar_url":"https://avatars3.githubusercontent.com/u/3071933?v=3","gravatar_id":"","url":"https://api.github.com/users/gangliao","html_url":"https://github.com/gangliao","followers_url":"https://api.github.com/users/gangliao/followers","following_url":"https://api.github.com/users/gangliao/following{/other_user}","gists_url":"https://api.github.com/users/gangliao/gists{/gist_id}","starred_url":"https://api.github.com/users/gangliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gangliao/subscriptions","organizations_url":"https://api.github.com/users/gangliao/orgs","repos_url":"https://api.github.com/users/gangliao/repos","events_url":"https://api.github.com/users/gangliao/events{/privacy}","received_events_url":"https://api.github.com/users/gangliao/received_events","type":"User","site_admin":false},"body":"与多个tags对应","created_at":"2017-03-17T06:47:08Z","updated_at":"2017-03-17T06:47:08Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/1598#discussion_r106592075","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1598","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/106592075"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/1598#discussion_r106592075"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1598"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1598","id":110088143,"html_url":"https://github.com/PaddlePaddle/Paddle/pull/1598","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/1598.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/1598.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/1598","number":1598,"state":"open","locked":false,"title":"Thinner docker image","user":{"login":"typhoonzero","id":13348433,"avatar_url":"https://avatars2.githubusercontent.com/u/13348433?v=3","gravatar_id":"","url":"https://api.github.com/users/typhoonzero","html_url":"https://github.com/typhoonzero","followers_url":"https://api.github.com/users/typhoonzero/followers","following_url":"https://api.github.com/users/typhoonzero/following{/other_user}","gists_url":"https://api.github.com/users/typhoonzero/gists{/gist_id}","starred_url":"https://api.github.com/users/typhoonzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typhoonzero/subscriptions","organizations_url":"https://api.github.com/users/typhoonzero/orgs","repos_url":"https://api.github.com/users/typhoonzero/repos","events_url":"https://api.github.com/users/typhoonzero/events{/privacy}","received_events_url":"https://api.github.com/users/typhoonzero/received_events","type":"User","site_admin":false},"body":"1. build a docker image to build paddle\r\n1. copy out binaries\r\n1. build the paddle-core image\r\n\r\nTODO:\r\nother images like jupyter and woboq stuff?","created_at":"2017-03-10T09:13:22Z","updated_at":"2017-03-17T06:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"454f6b77603cc6397b35340e5b8446f85b4f0ca4","assignee":{"login":"helinwang","id":1724178,"avatar_url":"https://avatars0.githubusercontent.com/u/1724178?v=3","gravatar_id":"","url":"https://api.github.com/users/helinwang","html_url":"https://github.com/helinwang","followers_url":"https://api.github.com/users/helinwang/followers","following_url":"https://api.github.com/users/helinwang/following{/other_user}","gists_url":"https://api.github.com/users/helinwang/gists{/gist_id}","starred_url":"https://api.github.com/users/helinwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helinwang/subscriptions","organizations_url":"https://api.github.com/users/helinwang/orgs","repos_url":"https://api.github.com/users/helinwang/repos","events_url":"https://api.github.com/users/helinwang/events{/privacy}","received_events_url":"https://api.github.com/users/helinwang/received_events","type":"User","site_admin":false},"assignees":[{"login":"helinwang","id":1724178,"avatar_url":"https://avatars0.githubusercontent.com/u/1724178?v=3","gravatar_id":"","url":"https://api.github.com/users/helinwang","html_url":"https://github.com/helinwang","followers_url":"https://api.github.com/users/helinwang/followers","following_url":"https://api.github.com/users/helinwang/following{/other_user}","gists_url":"https://api.github.com/users/helinwang/gists{/gist_id}","starred_url":"https://api.github.com/users/helinwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helinwang/subscriptions","organizations_url":"https://api.github.com/users/helinwang/orgs","repos_url":"https://api.github.com/users/helinwang/repos","events_url":"https://api.github.com/users/helinwang/events{/privacy}","received_events_url":"https://api.github.com/users/helinwang/received_events","type":"User","site_admin":false},{"login":"gangliao","id":3071933,"avatar_url":"https://avatars3.githubusercontent.com/u/3071933?v=3","gravatar_id":"","url":"https://api.github.com/users/gangliao","html_url":"https://github.com/gangliao","followers_url":"https://api.github.com/users/gangliao/followers","following_url":"https://api.github.com/users/gangliao/following{/other_user}","gists_url":"https://api.github.com/users/gangliao/gists{/gist_id}","starred_url":"https://api.github.com/users/gangliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gangliao/subscriptions","organizations_url":"https://api.github.com/users/gangliao/orgs","repos_url":"https://api.github.com/users/gangliao/repos","events_url":"https://api.github.com/users/gangliao/events{/privacy}","received_events_url":"https://api.github.com/users/gangliao/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1598/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1598/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/1598/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/1ab419a1bdd5dd5013d923b156ac44c8db0d8955","head":{"label":"typhoonzero:thinnerdocker","ref":"thinnerdocker","sha":"1ab419a1bdd5dd5013d923b156ac44c8db0d8955","user":{"login":"typhoonzero","id":13348433,"avatar_url":"https://avatars2.githubusercontent.com/u/13348433?v=3","gravatar_id":"","url":"https://api.github.com/users/typhoonzero","html_url":"https://github.com/typhoonzero","followers_url":"https://api.github.com/users/typhoonzero/followers","following_url":"https://api.github.com/users/typhoonzero/following{/other_user}","gists_url":"https://api.github.com/users/typhoonzero/gists{/gist_id}","starred_url":"https://api.github.com/users/typhoonzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typhoonzero/subscriptions","organizations_url":"https://api.github.com/users/typhoonzero/orgs","repos_url":"https://api.github.com/users/typhoonzero/repos","events_url":"https://api.github.com/users/typhoonzero/events{/privacy}","received_events_url":"https://api.github.com/users/typhoonzero/received_events","type":"User","site_admin":false},"repo":{"id":83394080,"name":"Paddle","full_name":"typhoonzero/Paddle","owner":{"login":"typhoonzero","id":13348433,"avatar_url":"https://avatars2.githubusercontent.com/u/13348433?v=3","gravatar_id":"","url":"https://api.github.com/users/typhoonzero","html_url":"https://github.com/typhoonzero","followers_url":"https://api.github.com/users/typhoonzero/followers","following_url":"https://api.github.com/users/typhoonzero/following{/other_user}","gists_url":"https://api.github.com/users/typhoonzero/gists{/gist_id}","starred_url":"https://api.github.com/users/typhoonzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typhoonzero/subscriptions","organizations_url":"https://api.github.com/users/typhoonzero/orgs","repos_url":"https://api.github.com/users/typhoonzero/repos","events_url":"https://api.github.com/users/typhoonzero/events{/privacy}","received_events_url":"https://api.github.com/users/typhoonzero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/typhoonzero/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/typhoonzero/Paddle","forks_url":"https://api.github.com/repos/typhoonzero/Paddle/forks","keys_url":"https://api.github.com/repos/typhoonzero/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typhoonzero/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typhoonzero/Paddle/teams","hooks_url":"https://api.github.com/repos/typhoonzero/Paddle/hooks","issue_events_url":"https://api.github.com/repos/typhoonzero/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/typhoonzero/Paddle/events","assignees_url":"https://api.github.com/repos/typhoonzero/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/typhoonzero/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/typhoonzero/Paddle/tags","blobs_url":"https://api.github.com/repos/typhoonzero/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typhoonzero/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typhoonzero/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/typhoonzero/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typhoonzero/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/typhoonzero/Paddle/languages","stargazers_url":"https://api.github.com/repos/typhoonzero/Paddle/stargazers","contributors_url":"https://api.github.com/repos/typhoonzero/Paddle/contributors","subscribers_url":"https://api.github.com/repos/typhoonzero/Paddle/subscribers","subscription_url":"https://api.github.com/repos/typhoonzero/Paddle/subscription","commits_url":"https://api.github.com/repos/typhoonzero/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/typhoonzero/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/typhoonzero/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/typhoonzero/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/typhoonzero/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/typhoonzero/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typhoonzero/Paddle/merges","archive_url":"https://api.github.com/repos/typhoonzero/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typhoonzero/Paddle/downloads","issues_url":"https://api.github.com/repos/typhoonzero/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/typhoonzero/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/typhoonzero/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/typhoonzero/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typhoonzero/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/typhoonzero/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/typhoonzero/Paddle/deployments","created_at":"2017-02-28T05:40:12Z","updated_at":"2017-02-28T05:40:32Z","pushed_at":"2017-03-17T05:31:53Z","git_url":"git://github.com/typhoonzero/Paddle.git","ssh_url":"[email protected]:typhoonzero/Paddle.git","clone_url":"https://github.com/typhoonzero/Paddle.git","svn_url":"https://github.com/typhoonzero/Paddle","homepage":"http://www.paddlepaddle.org/","size":22031,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"56fcf9c1d00362c17074b23d7bd37ae7f1a03984","user":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars0.githubusercontent.com/u/23534030?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"name":"Paddle","full_name":"PaddlePaddle/Paddle","owner":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars0.githubusercontent.com/u/23534030?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2017-03-17T06:46:57Z","pushed_at":"2017-03-17T05:46:15Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"[email protected]:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":24773,"stargazers_count":4586,"watchers_count":4586,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1174,"mirror_url":null,"open_issues_count":313,"forks":1174,"open_issues":313,"watchers":4586,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1598"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/1598"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/1598"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/1598/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1598/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1598/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/1ab419a1bdd5dd5013d923b156ac44c8db0d8955"}}}} | {
"id": 65711522,
"name": "PaddlePaddle/Paddle",
"url": "https://api.github.com/repos/PaddlePaddle/Paddle"
} | {
"id": 3071933,
"login": "gangliao",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3071933?",
"url": "https://api.github.com/users/gangliao"
} | {
"id": 23534030,
"login": "PaddlePaddle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534030?",
"url": "https://api.github.com/orgs/PaddlePaddle"
} | 2017-03-17T06:47:08 | 5511773666 | {"actor":{"display_login":"gangliao"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/129792731","pull_request_review_id":52600815,"id":129792731,"diff_hunk":"@@ -0,0 +1,251 @@\n+# RNN 变长输入设计\n+对变长序列的学习，现有主流框架比如 tensorflow, pytorch, caffe2, mxnet 等均使用了padding的方式，\n+即将一个mini-batch内不同长度的序列补0到固定长度参与计算。\n+\n+现有Paddle的 `RecurrentLayerGroup` 实现了无padding的变长序列支持，本文也将基于该模块的思路，设计重构后的变长序列支持。\n+\n+## 非padding 变长序列的意义\n+由于tensor必须有明确的shape，因此基于tensor 的主流框架在存储变长序列时，\n+必须用zero-padding的方式将变长序列补全为固定shape的tensor。\n+\n+由于padding是一种框架实现变长序列的妥协， 从用户角度，在使用RNN类模型时自然会比较介意padding的存在，\n+因此会有pytorch中对非padding方式变长序列支持长篇的讨论[3]。\n+\n+由于padding对内存和计算会有额外的消耗，tensorflow和mxnet均使用了bucketing来就行优化[1][2]，\n+但不管是padding还是bucket，对于用户都是额外的使用负担。\n+\n+因此，**paddle原生支持变长序列的方式，能直接满足用户对变长序列的最直接的需求，在当前主流平台中可以算是一大优势**。\n+\n+但对变长序列的支持，需要对目前框架做一些修改，下面讨论如何在最小修改下支持变长序列。\n+\n+## 变长数据格式\n+目前 Paddle 会将一个mini-batch内的数据存储在一维的内存上，\n+额外使用 `Argument.sequenceStartPositions` 来存储每个句子的信息。\n+\n+基于当前重构现状，我们使用如下设计来存储变长数据格式\n+\n+- 扩充 Tensor 以支持存储变长序列的信息（这部分信息后续用SeqPosVar表示）\n+- Op 的 `InferShape` 会更新outputs 的`SeqPosVar`\n+- 为了兼容序列Op（比如RNN）和传统Op（比如FC），序列的所有元素均flatten追加存储到一个mini-batch中\n+ - 比如，长度分别为2,3,4的三个句子会存储为一个size为9的`mini-batch`\n+ - 额外会有一个`SeqPosVar`，存储句子的结构，比如offest：`0,2,5,9`\n+ \n+为了支持sub-sequence，Paddle里使用 `Argument.subSequenceStartPositions` 来存储2维的序列信息，更高维度的序列无法支持；\n+这里为了扩展性，将SeqPosVar定义成如下数据结构来支持N维的序列信息的存储\n+\n+```c++\n+std::vector <std::vector<std::vector<int>> seq_start_positions_;\n+```\n+\n+附录中演示如何用二维的vector来存储多个 level 的变长序列的start position.\n+\n+Tensor 扩展为\n+```c++\n+/*\n+ * Tensor storing sequences.\n+ */\n+class TensorWithSequence {\n+public:\n+ Tenser *tensor() { return tensor_; }\n+\n+ /*\n+ * get an element of current level.\n+ */\n+ TensorWithSequence Element(int element) const;\n+\n+ /*\n+ * get an element of n-th level.\n+ * NOTE low performance.\n+ */\n+ TensorWithSequence Element(int level, int element) const;\n+\n+ /*\n+ * get number of elements in n-th level.\n+ */\n+ size_t Elements(int level = 0) const;\n+\n+ /*\n+ * get the number of levels of sequences.\n+ */\n+ size_t Levels() const;\n+\n+ /*\n+ * copy other's pointers to share their data.\n+ */\n+ void ShareDataFrom(const TensorWithSequence &other);\n+\n+ /*\n+ * just copy other's sequence info (use shared_ptr to share memory).\n+ */\n+ void ShareSeqPosFrom(const TensorWithSequence &other);\n+\n+ /*\n+ * copy others' sequence info for mutation.\n+ */\n+ void CopySeqPosFrom(const TensorWithSequence &other);","path":"paddle/operators/rnn_design.md","position":85,"original_position":85,"commit_id":"d3213e4ca3e1c56e74583d7e67e8d1c41f1987ef","original_commit_id":"a74e7981033b078de477b7b7452e8322c9933575","user":{"login":"luotao1","id":6836917,"avatar_url":"https://avatars0.githubusercontent.com/u/6836917?v=4","gravatar_id":"","url":"https://api.github.com/users/luotao1","html_url":"https://github.com/luotao1","followers_url":"https://api.github.com/users/luotao1/followers","following_url":"https://api.github.com/users/luotao1/following{/other_user}","gists_url":"https://api.github.com/users/luotao1/gists{/gist_id}","starred_url":"https://api.github.com/users/luotao1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luotao1/subscriptions","organizations_url":"https://api.github.com/users/luotao1/orgs","repos_url":"https://api.github.com/users/luotao1/repos","events_url":"https://api.github.com/users/luotao1/events{/privacy}","received_events_url":"https://api.github.com/users/luotao1/received_events","type":"User","site_admin":false},"body":"shareDataFrom, ShareSeqPosFrom, CopySeqPosFrom会在哪儿用到呢？","created_at":"2017-07-27T09:24:17Z","updated_at":"2017-07-27T09:36:38Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/3011#discussion_r129792731","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/3011","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/129792731"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/3011#discussion_r129792731"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/3011"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/3011","id":131726218,"html_url":"https://github.com/PaddlePaddle/Paddle/pull/3011","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/3011.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/3011.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/3011","number":3011,"state":"open","locked":false,"title":"RNN变长输入设计","user":{"login":"Superjom","id":328693,"avatar_url":"https://avatars1.githubusercontent.com/u/328693?v=4","gravatar_id":"","url":"https://api.github.com/users/Superjom","html_url":"https://github.com/Superjom","followers_url":"https://api.github.com/users/Superjom/followers","following_url":"https://api.github.com/users/Superjom/following{/other_user}","gists_url":"https://api.github.com/users/Superjom/gists{/gist_id}","starred_url":"https://api.github.com/users/Superjom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Superjom/subscriptions","organizations_url":"https://api.github.com/users/Superjom/orgs","repos_url":"https://api.github.com/users/Superjom/repos","events_url":"https://api.github.com/users/Superjom/events{/privacy}","received_events_url":"https://api.github.com/users/Superjom/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-21T08:48:58Z","updated_at":"2017-07-27T09:36:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a28499c7289c43db27315cb6a06bc605bafd358","assignee":{"login":"Superjom","id":328693,"avatar_url":"https://avatars1.githubusercontent.com/u/328693?v=4","gravatar_id":"","url":"https://api.github.com/users/Superjom","html_url":"https://github.com/Superjom","followers_url":"https://api.github.com/users/Superjom/followers","following_url":"https://api.github.com/users/Superjom/following{/other_user}","gists_url":"https://api.github.com/users/Superjom/gists{/gist_id}","starred_url":"https://api.github.com/users/Superjom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Superjom/subscriptions","organizations_url":"https://api.github.com/users/Superjom/orgs","repos_url":"https://api.github.com/users/Superjom/repos","events_url":"https://api.github.com/users/Superjom/events{/privacy}","received_events_url":"https://api.github.com/users/Superjom/received_events","type":"User","site_admin":false},"assignees":[{"login":"Superjom","id":328693,"avatar_url":"https://avatars1.githubusercontent.com/u/328693?v=4","gravatar_id":"","url":"https://api.github.com/users/Superjom","html_url":"https://github.com/Superjom","followers_url":"https://api.github.com/users/Superjom/followers","following_url":"https://api.github.com/users/Superjom/following{/other_user}","gists_url":"https://api.github.com/users/Superjom/gists{/gist_id}","starred_url":"https://api.github.com/users/Superjom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Superjom/subscriptions","organizations_url":"https://api.github.com/users/Superjom/orgs","repos_url":"https://api.github.com/users/Superjom/repos","events_url":"https://api.github.com/users/Superjom/events{/privacy}","received_events_url":"https://api.github.com/users/Superjom/received_events","type":"User","site_admin":false},{"login":"jacquesqiao","id":3048612,"avatar_url":"https://avatars0.githubusercontent.com/u/3048612?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquesqiao","html_url":"https://github.com/jacquesqiao","followers_url":"https://api.github.com/users/jacquesqiao/followers","following_url":"https://api.github.com/users/jacquesqiao/following{/other_user}","gists_url":"https://api.github.com/users/jacquesqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesqiao/subscriptions","organizations_url":"https://api.github.com/users/jacquesqiao/orgs","repos_url":"https://api.github.com/users/jacquesqiao/repos","events_url":"https://api.github.com/users/jacquesqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesqiao/received_events","type":"User","site_admin":false},{"login":"luotao1","id":6836917,"avatar_url":"https://avatars0.githubusercontent.com/u/6836917?v=4","gravatar_id":"","url":"https://api.github.com/users/luotao1","html_url":"https://github.com/luotao1","followers_url":"https://api.github.com/users/luotao1/followers","following_url":"https://api.github.com/users/luotao1/following{/other_user}","gists_url":"https://api.github.com/users/luotao1/gists{/gist_id}","starred_url":"https://api.github.com/users/luotao1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luotao1/subscriptions","organizations_url":"https://api.github.com/users/luotao1/orgs","repos_url":"https://api.github.com/users/luotao1/repos","events_url":"https://api.github.com/users/luotao1/events{/privacy}","received_events_url":"https://api.github.com/users/luotao1/received_events","type":"User","site_admin":false},{"login":"qingqing01","id":7845005,"avatar_url":"https://avatars0.githubusercontent.com/u/7845005?v=4","gravatar_id":"","url":"https://api.github.com/users/qingqing01","html_url":"https://github.com/qingqing01","followers_url":"https://api.github.com/users/qingqing01/followers","following_url":"https://api.github.com/users/qingqing01/following{/other_user}","gists_url":"https://api.github.com/users/qingqing01/gists{/gist_id}","starred_url":"https://api.github.com/users/qingqing01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qingqing01/subscriptions","organizations_url":"https://api.github.com/users/qingqing01/orgs","repos_url":"https://api.github.com/users/qingqing01/repos","events_url":"https://api.github.com/users/qingqing01/events{/privacy}","received_events_url":"https://api.github.com/users/qingqing01/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/3011/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/3011/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/3011/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/d3213e4ca3e1c56e74583d7e67e8d1c41f1987ef","head":{"label":"Superjom:rnn_varilen_design","ref":"rnn_varilen_design","sha":"d3213e4ca3e1c56e74583d7e67e8d1c41f1987ef","user":{"login":"Superjom","id":328693,"avatar_url":"https://avatars1.githubusercontent.com/u/328693?v=4","gravatar_id":"","url":"https://api.github.com/users/Superjom","html_url":"https://github.com/Superjom","followers_url":"https://api.github.com/users/Superjom/followers","following_url":"https://api.github.com/users/Superjom/following{/other_user}","gists_url":"https://api.github.com/users/Superjom/gists{/gist_id}","starred_url":"https://api.github.com/users/Superjom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Superjom/subscriptions","organizations_url":"https://api.github.com/users/Superjom/orgs","repos_url":"https://api.github.com/users/Superjom/repos","events_url":"https://api.github.com/users/Superjom/events{/privacy}","received_events_url":"https://api.github.com/users/Superjom/received_events","type":"User","site_admin":false},"repo":{"id":66896049,"name":"Paddle","full_name":"Superjom/Paddle","owner":{"login":"Superjom","id":328693,"avatar_url":"https://avatars1.githubusercontent.com/u/328693?v=4","gravatar_id":"","url":"https://api.github.com/users/Superjom","html_url":"https://github.com/Superjom","followers_url":"https://api.github.com/users/Superjom/followers","following_url":"https://api.github.com/users/Superjom/following{/other_user}","gists_url":"https://api.github.com/users/Superjom/gists{/gist_id}","starred_url":"https://api.github.com/users/Superjom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Superjom/subscriptions","organizations_url":"https://api.github.com/users/Superjom/orgs","repos_url":"https://api.github.com/users/Superjom/repos","events_url":"https://api.github.com/users/Superjom/events{/privacy}","received_events_url":"https://api.github.com/users/Superjom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Superjom/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/Superjom/Paddle","forks_url":"https://api.github.com/repos/Superjom/Paddle/forks","keys_url":"https://api.github.com/repos/Superjom/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Superjom/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Superjom/Paddle/teams","hooks_url":"https://api.github.com/repos/Superjom/Paddle/hooks","issue_events_url":"https://api.github.com/repos/Superjom/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/Superjom/Paddle/events","assignees_url":"https://api.github.com/repos/Superjom/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/Superjom/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/Superjom/Paddle/tags","blobs_url":"https://api.github.com/repos/Superjom/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Superjom/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Superjom/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Superjom/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Superjom/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/Superjom/Paddle/languages","stargazers_url":"https://api.github.com/repos/Superjom/Paddle/stargazers","contributors_url":"https://api.github.com/repos/Superjom/Paddle/contributors","subscribers_url":"https://api.github.com/repos/Superjom/Paddle/subscribers","subscription_url":"https://api.github.com/repos/Superjom/Paddle/subscription","commits_url":"https://api.github.com/repos/Superjom/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Superjom/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Superjom/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Superjom/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Superjom/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/Superjom/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Superjom/Paddle/merges","archive_url":"https://api.github.com/repos/Superjom/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Superjom/Paddle/downloads","issues_url":"https://api.github.com/repos/Superjom/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/Superjom/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/Superjom/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/Superjom/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Superjom/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/Superjom/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/Superjom/Paddle/deployments","created_at":"2016-08-30T01:45:54Z","updated_at":"2016-08-30T01:45:57Z","pushed_at":"2017-07-27T09:33:11Z","git_url":"git://github.com/Superjom/Paddle.git","ssh_url":"[email protected]:Superjom/Paddle.git","clone_url":"https://github.com/Superjom/Paddle.git","svn_url":"https://github.com/Superjom/Paddle","homepage":null,"size":22814,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"afe7bf61799396add69c1a871f9e90c2007e4f8c","user":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"name":"Paddle","full_name":"PaddlePaddle/Paddle","owner":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2017-07-27T08:18:59Z","pushed_at":"2017-07-27T09:34:09Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"[email protected]:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":42488,"stargazers_count":5214,"watchers_count":5214,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1383,"mirror_url":null,"open_issues_count":533,"forks":1383,"open_issues":533,"watchers":5214,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/3011"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/3011"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/3011"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/3011/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/3011/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/3011/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/d3213e4ca3e1c56e74583d7e67e8d1c41f1987ef"}}}} | {
"id": 65711522,
"name": "PaddlePaddle/Paddle",
"url": "https://api.github.com/repos/PaddlePaddle/Paddle"
} | {
"id": 6836917,
"login": "luotao1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6836917?",
"url": "https://api.github.com/users/luotao1"
} | {
"id": 23534030,
"login": "PaddlePaddle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534030?",
"url": "https://api.github.com/orgs/PaddlePaddle"
} | 2017-07-27T09:24:17 | 6339947188 | {"actor":{"display_login":"luotao1"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.