type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/106090091","pull_request_review_id":26995886,"id":106090091,"diff_hunk":"@@ -0,0 +1,57 @@\n+import logging\n+from homeassistant.helpers import discovery\n+from homeassistant.helpers.entity import (Entity, generate_entity_id)\n+from homeassistant.loader import get_component\n+\n+REQUIREMENTS = ['https://github.com/gurumitts/pylutron-caseta/archive/0.1.0.zip#'\n+ 'pylutron-caseta==0.1.0']\n+\n+_LOGGER = logging.getLogger(__name__)\n+\n+LUTRON_CASETA_SMARTBRIDGE = 'lutron_smartbridge'\n+LUTRON_CASETA_DEVICES = 'lutron_devices'\n+\n+DOMAIN = 'lutron_caseta'\n+\n+def setup(hass, base_config):\n+ \"\"\"Setup the Lutron component.\"\"\"\n+ from pylutron_caseta.smartbridge import Smartbridge\n+\n+ hass.data[LUTRON_CASETA_SMARTBRIDGE] = None\n+ hass.data[LUTRON_CASETA_DEVICES] = None\n+\n+\n+ config = base_config.get(DOMAIN)\n+ hass.data[LUTRON_CASETA_SMARTBRIDGE] = Smartbridge(\n+ hostname=config['host'],\n+ username=config['user'],\n+ password=config['password']\n+ )\n+ caseta_devices = hass.data[LUTRON_CASETA_SMARTBRIDGE].get_devices()\n+ _LOGGER.error(\"Connected to Lutron smartbridge at %s\", config['host'])\n+\n+ # [Currently]Only supports lutron wall dimmers as hass lights\n+ # [Future] switches should be trivial to add\n+ components = {\"light\": [], \"switch\": []}\n+\n+ for device in caseta_devices:\n+ # Lutron wall dimmers will be mapped as lights\n+ if device[\"type\"] == \"WallDimmer\":\n+ components[\"light\"].append(device)\n+ if device[\"type\"] == \"WallSwitch\":\n+ components[\"switch\"].append(device)\n+ # Need to support more Lutron devices but I don't have any more.\n+\n+ hass.data[LUTRON_CASETA_DEVICES] = components\n+ _LOGGER.error(hass.data[LUTRON_CASETA_DEVICES])\n+\n+ for component in components:\n+ if len(components[component]) > 0:\n+ discovery.load_platform(hass, component, DOMAIN, None, base_config)\n+ return True\n+\n+\n+\n+\n+\n+ return True","path":"homeassistant/components/lutron_caseta.py","position":57,"original_position":57,"commit_id":"a0043ecba355fabe3e2e5c712c8a67c726d368fd","original_commit_id":"a0043ecba355fabe3e2e5c712c8a67c726d368fd","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"too many blank lines (5)","created_at":"2017-03-15T05:49:41Z","updated_at":"2017-03-15T05:49:41Z","html_url":"https://github.com/home-assistant/home-assistant/pull/6631#discussion_r106090091","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6631","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/106090091"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/6631#discussion_r106090091"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6631"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6631","id":110774207,"html_url":"https://github.com/home-assistant/home-assistant/pull/6631","diff_url":"https://github.com/home-assistant/home-assistant/pull/6631.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/6631.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/6631","number":6631,"state":"open","locked":false,"title":"Adds Support for Lutron Caseta devices. ","user":{"login":"gurumitts","id":8779943,"avatar_url":"https://avatars3.githubusercontent.com/u/8779943?v=3","gravatar_id":"","url":"https://api.github.com/users/gurumitts","html_url":"https://github.com/gurumitts","followers_url":"https://api.github.com/users/gurumitts/followers","following_url":"https://api.github.com/users/gurumitts/following{/other_user}","gists_url":"https://api.github.com/users/gurumitts/gists{/gist_id}","starred_url":"https://api.github.com/users/gurumitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurumitts/subscriptions","organizations_url":"https://api.github.com/users/gurumitts/orgs","repos_url":"https://api.github.com/users/gurumitts/repos","events_url":"https://api.github.com/users/gurumitts/events{/privacy}","received_events_url":"https://api.github.com/users/gurumitts/received_events","type":"User","site_admin":false},"body":"## Description:\r\nAdds Support for Lutron Caseta devices. The Caseta devices behave differently that the already supported Lutron RadioRA 2 system. \r\n\r\n**Related issue (if applicable):** fixes # NA\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):\r\nhttps://github.com/home-assistant/home-assistant.github.io/pull/2262\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nlutron_caseta:\r\n host: <best_to_use_a_static _ip_for_the_smartbridge>\r\n user: <smartbridge_username defaults to lutron>\r\n password: <smartbridge_password defaults to integration>\r\n```\r\n\r\n## Checklist:\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n - [x] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2017-03-15T05:49:31Z","updated_at":"2017-03-15T05:49:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0d621d0a44c52a29610d3d7ec3a8d78a474eb39","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6631/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6631/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/6631/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/a0043ecba355fabe3e2e5c712c8a67c726d368fd","head":{"label":"gurumitts:dev","ref":"dev","sha":"a0043ecba355fabe3e2e5c712c8a67c726d368fd","user":{"login":"gurumitts","id":8779943,"avatar_url":"https://avatars3.githubusercontent.com/u/8779943?v=3","gravatar_id":"","url":"https://api.github.com/users/gurumitts","html_url":"https://github.com/gurumitts","followers_url":"https://api.github.com/users/gurumitts/followers","following_url":"https://api.github.com/users/gurumitts/following{/other_user}","gists_url":"https://api.github.com/users/gurumitts/gists{/gist_id}","starred_url":"https://api.github.com/users/gurumitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurumitts/subscriptions","organizations_url":"https://api.github.com/users/gurumitts/orgs","repos_url":"https://api.github.com/users/gurumitts/repos","events_url":"https://api.github.com/users/gurumitts/events{/privacy}","received_events_url":"https://api.github.com/users/gurumitts/received_events","type":"User","site_admin":false},"repo":{"id":83813296,"name":"home-assistant","full_name":"gurumitts/home-assistant","owner":{"login":"gurumitts","id":8779943,"avatar_url":"https://avatars3.githubusercontent.com/u/8779943?v=3","gravatar_id":"","url":"https://api.github.com/users/gurumitts","html_url":"https://github.com/gurumitts","followers_url":"https://api.github.com/users/gurumitts/followers","following_url":"https://api.github.com/users/gurumitts/following{/other_user}","gists_url":"https://api.github.com/users/gurumitts/gists{/gist_id}","starred_url":"https://api.github.com/users/gurumitts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurumitts/subscriptions","organizations_url":"https://api.github.com/users/gurumitts/orgs","repos_url":"https://api.github.com/users/gurumitts/repos","events_url":"https://api.github.com/users/gurumitts/events{/privacy}","received_events_url":"https://api.github.com/users/gurumitts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gurumitts/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/gurumitts/home-assistant","forks_url":"https://api.github.com/repos/gurumitts/home-assistant/forks","keys_url":"https://api.github.com/repos/gurumitts/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gurumitts/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gurumitts/home-assistant/teams","hooks_url":"https://api.github.com/repos/gurumitts/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/gurumitts/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/gurumitts/home-assistant/events","assignees_url":"https://api.github.com/repos/gurumitts/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/gurumitts/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/gurumitts/home-assistant/tags","blobs_url":"https://api.github.com/repos/gurumitts/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gurumitts/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gurumitts/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/gurumitts/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gurumitts/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/gurumitts/home-assistant/languages","stargazers_url":"https://api.github.com/repos/gurumitts/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/gurumitts/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/gurumitts/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/gurumitts/home-assistant/subscription","commits_url":"https://api.github.com/repos/gurumitts/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/gurumitts/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/gurumitts/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/gurumitts/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/gurumitts/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/gurumitts/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gurumitts/home-assistant/merges","archive_url":"https://api.github.com/repos/gurumitts/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gurumitts/home-assistant/downloads","issues_url":"https://api.github.com/repos/gurumitts/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/gurumitts/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/gurumitts/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/gurumitts/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gurumitts/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/gurumitts/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/gurumitts/home-assistant/deployments","created_at":"2017-03-03T15:34:42Z","updated_at":"2017-03-03T15:34:49Z","pushed_at":"2017-03-15T05:37:17Z","git_url":"git://github.com/gurumitts/home-assistant.git","ssh_url":"[email protected]:gurumitts/home-assistant.git","clone_url":"https://github.com/gurumitts/home-assistant.git","svn_url":"https://github.com/gurumitts/home-assistant","homepage":"https://home-assistant.io","size":54876,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"97b9d3bd21a3f81d2eaf53a49f3be9d5d6ae4bf1","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2017-03-14T23:43:48Z","pushed_at":"2017-03-15T05:49:32Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"[email protected]:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":54862,"stargazers_count":6162,"watchers_count":6162,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1781,"mirror_url":null,"open_issues_count":470,"forks":1781,"open_issues":470,"watchers":6162,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6631"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/6631"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/6631"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/6631/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6631/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6631/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/a0043ecba355fabe3e2e5c712c8a67c726d368fd"}}}} | {
"id": 12888993,
"name": "home-assistant/home-assistant",
"url": "https://api.github.com/repos/home-assistant/home-assistant"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 13844975,
"login": "home-assistant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13844975?",
"url": "https://api.github.com/orgs/home-assistant"
} | 2017-03-15T05:49:41 | 5495717124 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/122512067","pull_request_review_id":44639888,"id":122512067,"diff_hunk":"@@ -43,6 +51,34 @@\n TOKEN_CHANGE_INTERVAL = timedelta(minutes=5)\n _RND = SystemRandom()\n \n+CAMERA_SERVICE_SCHEMA = vol.Schema({\n+ vol.Optional(ATTR_ENTITY_ID): cv.entity_ids,\n+})\n+\n+\n+def en_motion_detection(hass, entity_id=None):\n+ \"\"\"Enable Motion Detection.\"\"\"\n+ hass.add_job(async_en_motion_detection, hass, entity_id)\n+\n+\n+@callback\n+def async_en_motion_detection(hass, entity_id=None):\n+ \"\"\"Enable motion detection on given Entities.\"\"\"\n+ data = {ATTR_ENTITY_ID: entity_id} if entity_id else None\n+ hass.async_add_job(hass.services.async_call(DOMAIN, SERVICE_EN_MOTION, data))\n+\n+\n+def disen_motion_detection(hass, entity_id=None):\n+ \"\"\"Disable Motion Detection.\"\"\"\n+ hass.add_job(async_disen_motion_detection, hass, entity_id)\n+\n+\n+@callback\n+def async_disen_motion_detection(hass, entity_id=None):\n+ \"\"\"Disable motion detection on given Entitiess.\"\"\"\n+ data = {ATTR_ENTITY_ID: entity_id} if entity_id else None\n+ hass.async_add_job(hass.services.async_call(DOMAIN, SERVICE_DISEN_MOTION, data))","path":"homeassistant/components/camera/__init__.py","position":63,"original_position":63,"commit_id":"c1a8382a4a0daf1cb921301ddd186a8b54279603","original_commit_id":"c1a8382a4a0daf1cb921301ddd186a8b54279603","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"line too long (84 > 79 characters)","created_at":"2017-06-16T19:02:41Z","updated_at":"2017-06-16T19:02:41Z","html_url":"https://github.com/home-assistant/home-assistant/pull/7961#discussion_r122512067","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7961","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/122512067"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/7961#discussion_r122512067"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7961"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7961","id":124690071,"html_url":"https://github.com/home-assistant/home-assistant/pull/7961","diff_url":"https://github.com/home-assistant/home-assistant/pull/7961.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/7961.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/7961","number":7961,"state":"open","locked":false,"title":"Camera services arm disarm including Netgear Arlo","user":{"login":"viswa-swami","id":7004531,"avatar_url":"https://avatars0.githubusercontent.com/u/7004531?v=3","gravatar_id":"","url":"https://api.github.com/users/viswa-swami","html_url":"https://github.com/viswa-swami","followers_url":"https://api.github.com/users/viswa-swami/followers","following_url":"https://api.github.com/users/viswa-swami/following{/other_user}","gists_url":"https://api.github.com/users/viswa-swami/gists{/gist_id}","starred_url":"https://api.github.com/users/viswa-swami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viswa-swami/subscriptions","organizations_url":"https://api.github.com/users/viswa-swami/orgs","repos_url":"https://api.github.com/users/viswa-swami/repos","events_url":"https://api.github.com/users/viswa-swami/events{/privacy}","received_events_url":"https://api.github.com/users/viswa-swami/received_events","type":"User","site_admin":false},"body":"## Description:\r\nCamera component needs a service called \"Arm/Disarm\" to be able to arm a camera on demand or via automation. Similarly for disarm.\r\n\r\nArm: It will enable motion detection and also record the video/snapshot depending on camera setting\r\nDisarm: It will disable motion detection and will not record anything.\r\n\r\nThe arguments (entity_id) is optional so that with just 'arm' or 'disarm' call, user can arm/disarm all the cameras in a shot. Otherwise provide the specific entity_id of camera to arm/disarm if camera supports it.\r\n\r\nThis goes hand-in-hand with arlo camera where home assistant talks to the Arlo base station (Note that, for Arlo, we need to talk to base station/hub to control the cameras and not the cameras itself) to arm/disable all the cameras at once, for example.\r\n\r\nThese services are applicable to Foscam cameras too. For example, in my home setup, I currently have a shell command to arm/disarm the camera whenever we are not in home. This shell command can be avoided if the arm/disarm service is available in camera component itself. I can add the arm/disarm functionality for foscam cameras also once this codeset is done/committed/pushed.\r\n\r\nI am not sure if we need to update the documentation anywhere on this concern. If there is any, let me know and i can update the same.\r\n\r\nThese status can be used to create a camera based sensor to indicate whether the cameras are armed or disarmed. That is next once these code are done.\r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n\r\n```\r\n\r\n## Checklist:\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2017-06-08T16:16:00Z","updated_at":"2017-06-16T19:02:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c1958b1031e2f0d16a03a7bf8753e39181a80bd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7961/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7961/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/7961/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/c1a8382a4a0daf1cb921301ddd186a8b54279603","head":{"label":"viswa-swami:arlo_services_arm_disarm","ref":"arlo_services_arm_disarm","sha":"c1a8382a4a0daf1cb921301ddd186a8b54279603","user":{"login":"viswa-swami","id":7004531,"avatar_url":"https://avatars0.githubusercontent.com/u/7004531?v=3","gravatar_id":"","url":"https://api.github.com/users/viswa-swami","html_url":"https://github.com/viswa-swami","followers_url":"https://api.github.com/users/viswa-swami/followers","following_url":"https://api.github.com/users/viswa-swami/following{/other_user}","gists_url":"https://api.github.com/users/viswa-swami/gists{/gist_id}","starred_url":"https://api.github.com/users/viswa-swami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viswa-swami/subscriptions","organizations_url":"https://api.github.com/users/viswa-swami/orgs","repos_url":"https://api.github.com/users/viswa-swami/repos","events_url":"https://api.github.com/users/viswa-swami/events{/privacy}","received_events_url":"https://api.github.com/users/viswa-swami/received_events","type":"User","site_admin":false},"repo":{"id":87460317,"name":"home-assistant","full_name":"viswa-swami/home-assistant","owner":{"login":"viswa-swami","id":7004531,"avatar_url":"https://avatars0.githubusercontent.com/u/7004531?v=3","gravatar_id":"","url":"https://api.github.com/users/viswa-swami","html_url":"https://github.com/viswa-swami","followers_url":"https://api.github.com/users/viswa-swami/followers","following_url":"https://api.github.com/users/viswa-swami/following{/other_user}","gists_url":"https://api.github.com/users/viswa-swami/gists{/gist_id}","starred_url":"https://api.github.com/users/viswa-swami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viswa-swami/subscriptions","organizations_url":"https://api.github.com/users/viswa-swami/orgs","repos_url":"https://api.github.com/users/viswa-swami/repos","events_url":"https://api.github.com/users/viswa-swami/events{/privacy}","received_events_url":"https://api.github.com/users/viswa-swami/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viswa-swami/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/viswa-swami/home-assistant","forks_url":"https://api.github.com/repos/viswa-swami/home-assistant/forks","keys_url":"https://api.github.com/repos/viswa-swami/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viswa-swami/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viswa-swami/home-assistant/teams","hooks_url":"https://api.github.com/repos/viswa-swami/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/viswa-swami/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/viswa-swami/home-assistant/events","assignees_url":"https://api.github.com/repos/viswa-swami/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/viswa-swami/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/viswa-swami/home-assistant/tags","blobs_url":"https://api.github.com/repos/viswa-swami/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viswa-swami/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viswa-swami/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/viswa-swami/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viswa-swami/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/viswa-swami/home-assistant/languages","stargazers_url":"https://api.github.com/repos/viswa-swami/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/viswa-swami/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/viswa-swami/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/viswa-swami/home-assistant/subscription","commits_url":"https://api.github.com/repos/viswa-swami/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/viswa-swami/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/viswa-swami/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/viswa-swami/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/viswa-swami/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/viswa-swami/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viswa-swami/home-assistant/merges","archive_url":"https://api.github.com/repos/viswa-swami/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viswa-swami/home-assistant/downloads","issues_url":"https://api.github.com/repos/viswa-swami/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/viswa-swami/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/viswa-swami/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/viswa-swami/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viswa-swami/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/viswa-swami/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/viswa-swami/home-assistant/deployments","created_at":"2017-04-06T18:12:09Z","updated_at":"2017-04-06T18:12:15Z","pushed_at":"2017-06-16T19:02:30Z","git_url":"git://github.com/viswa-swami/home-assistant.git","ssh_url":"[email protected]:viswa-swami/home-assistant.git","clone_url":"https://github.com/viswa-swami/home-assistant.git","svn_url":"https://github.com/viswa-swami/home-assistant","homepage":"https://home-assistant.io","size":63516,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"0863d502102c0f66511097f6f237e4f3de7b1f4c","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2017-06-16T17:54:04Z","pushed_at":"2017-06-16T19:02:32Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"[email protected]:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":64036,"stargazers_count":7122,"watchers_count":7122,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2128,"mirror_url":null,"open_issues_count":432,"forks":2128,"open_issues":432,"watchers":7122,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7961"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/7961"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/7961"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/7961/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7961/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7961/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/c1a8382a4a0daf1cb921301ddd186a8b54279603"}}}} | {
"id": 12888993,
"name": "home-assistant/home-assistant",
"url": "https://api.github.com/repos/home-assistant/home-assistant"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 13844975,
"login": "home-assistant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13844975?",
"url": "https://api.github.com/orgs/home-assistant"
} | 2017-06-16T19:02:41 | 6082492627 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/116269359","pull_request_review_id":37883032,"id":116269359,"diff_hunk":"@@ -41,7 +45,10 @@\n \n CONF_SERVER = 'server'\n \n+SERVICE_LIFX_SET_COLOR = 'lifx_set_color'","path":"homeassistant/components/light/lifx/__init__.py","position":null,"original_position":32,"commit_id":"fce8ff2748f1e06587df1888932626a7592524c0","original_commit_id":"012c8c6f37d44f9da3beec83ccbd902ae16fec33","user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars0.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"I guess we can think of other names, set_attributes, set_properties… guess all of them are slightly confusing.","created_at":"2017-05-12T16:19:16Z","updated_at":"2017-05-12T16:19:16Z","html_url":"https://github.com/home-assistant/home-assistant/pull/7552#discussion_r116269359","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7552","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/116269359"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/7552#discussion_r116269359"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7552"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7552","id":120170880,"html_url":"https://github.com/home-assistant/home-assistant/pull/7552","diff_url":"https://github.com/home-assistant/home-assistant/pull/7552.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/7552.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/7552","number":7552,"state":"open","locked":false,"title":"LIFX: add lifx_set_state service call","user":{"login":"amelchio","id":26174915,"avatar_url":"https://avatars0.githubusercontent.com/u/26174915?v=3","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nAs suggested in #7477, this is a LIFX-specific service that is just like `light.turn_on` except it does not actually turn on the light (unless asked to).\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#2620\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nautomation:\r\n # Reset all lights from our evening fun (but do not light up the whole house).\r\n - alias: Bright morning light\r\n trigger:\r\n platform: time\r\n after: '06:00'\r\n action:\r\n - service: light.lifx_set_state\r\n data:\r\n color_temp: 200\r\n brightness: 200\r\n transition: 180\r\n```\r\n\r\n## Checklist:\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n - [X] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n - [X] Local tests with `tox` run successfully.","created_at":"2017-05-11T18:23:43Z","updated_at":"2017-05-12T16:19:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dbe2a65ad9ec6aa5d49356e79991d6cae129b90","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7552/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7552/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/7552/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/fce8ff2748f1e06587df1888932626a7592524c0","head":{"label":"amelchio:lifx-set_color","ref":"lifx-set_color","sha":"fce8ff2748f1e06587df1888932626a7592524c0","user":{"login":"amelchio","id":26174915,"avatar_url":"https://avatars0.githubusercontent.com/u/26174915?v=3","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false},"repo":{"id":83846619,"name":"home-assistant","full_name":"amelchio/home-assistant","owner":{"login":"amelchio","id":26174915,"avatar_url":"https://avatars0.githubusercontent.com/u/26174915?v=3","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amelchio/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/amelchio/home-assistant","forks_url":"https://api.github.com/repos/amelchio/home-assistant/forks","keys_url":"https://api.github.com/repos/amelchio/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amelchio/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amelchio/home-assistant/teams","hooks_url":"https://api.github.com/repos/amelchio/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/amelchio/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/amelchio/home-assistant/events","assignees_url":"https://api.github.com/repos/amelchio/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/amelchio/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/amelchio/home-assistant/tags","blobs_url":"https://api.github.com/repos/amelchio/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amelchio/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amelchio/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/amelchio/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amelchio/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/amelchio/home-assistant/languages","stargazers_url":"https://api.github.com/repos/amelchio/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/amelchio/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/amelchio/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/amelchio/home-assistant/subscription","commits_url":"https://api.github.com/repos/amelchio/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/amelchio/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/amelchio/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/amelchio/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/amelchio/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/amelchio/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amelchio/home-assistant/merges","archive_url":"https://api.github.com/repos/amelchio/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amelchio/home-assistant/downloads","issues_url":"https://api.github.com/repos/amelchio/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/amelchio/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/amelchio/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/amelchio/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amelchio/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/amelchio/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/amelchio/home-assistant/deployments","created_at":"2017-03-03T22:19:44Z","updated_at":"2017-03-03T22:19:50Z","pushed_at":"2017-05-12T11:16:19Z","git_url":"git://github.com/amelchio/home-assistant.git","ssh_url":"[email protected]:amelchio/home-assistant.git","clone_url":"https://github.com/amelchio/home-assistant.git","svn_url":"https://github.com/amelchio/home-assistant","homepage":"https://home-assistant.io","size":61717,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"452c3a1b25c5f0dec2c844367b397174f69e4e1c","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2017-05-12T16:18:19Z","pushed_at":"2017-05-12T16:02:11Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"[email protected]:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":61659,"stargazers_count":6803,"watchers_count":6803,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2009,"mirror_url":null,"open_issues_count":454,"forks":2009,"open_issues":454,"watchers":6803,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7552"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/7552"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/7552"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/7552/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7552/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/7552/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/fce8ff2748f1e06587df1888932626a7592524c0"}}}} | {
"id": 12888993,
"name": "home-assistant/home-assistant",
"url": "https://api.github.com/repos/home-assistant/home-assistant"
} | {
"id": 1444314,
"login": "balloob",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1444314?",
"url": "https://api.github.com/users/balloob"
} | {
"id": 13844975,
"login": "home-assistant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13844975?",
"url": "https://api.github.com/orgs/home-assistant"
} | 2017-05-12T16:19:16 | 5862448404 | {"actor":{"display_login":"balloob"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/151755770","pull_request_review_id":77519938,"id":151755770,"diff_hunk":"@@ -0,0 +1,230 @@\n+\"\"\"\r\n+Support for the Hive devices.\r\n+\r\n+For more details about this platform, please refer to the documentation at\r\n+https://home-assistant.io/components/hive/\r\n+\"\"\"\r\n+import logging\r\n+from datetime import datetime\r\n+\r\n+from homeassistant.components.climate import (ENTITY_ID_FORMAT, ClimateDevice,\r\n+ STATE_AUTO, STATE_HEAT,\r\n+ STATE_OFF, STATE_ON)\r\n+from homeassistant.const import ATTR_TEMPERATURE, TEMP_CELSIUS\r\n+from homeassistant.components.hive import DATA_HIVE\r\n+\r\n+DEPENDENCIES = ['hive']\r\n+\r\n+_LOGGER = logging.getLogger(__name__)\r\n+\r\n+\r\n+def setup_platform(hass, config, add_devices, hivedevice, discovery_info=None):\r\n+ \"\"\"Set up Hive climate devices.\"\"\"\r\n+ session = hass.data.get(DATA_HIVE)\r\n+\r\n+ add_devices([HiveClimateEntity(hass, session, hivedevice)])\r\n+\r\n+\r\n+class HiveClimateEntity(ClimateDevice):\r\n+ \"\"\"Hive Climate Device.\"\"\"\r\n+\r\n+ def __init__(self, hass, Session, HiveDevice):\r\n+ \"\"\"Initialize the Climate device.\"\"\"\r\n+ self.node_id = HiveDevice[\"Hive_NodeID\"]\r\n+ self.node_name = HiveDevice[\"Hive_NodeName\"]\r\n+ self.device_type = HiveDevice[\"HA_DeviceType\"]\r\n+ self.hass = hass\r\n+ self.session = Session\r\n+\r\n+ if self.device_type == \"Heating\":\r\n+ set_entity_id = \"Hive_Heating\"\r\n+ self.session.heating = self.session.core.Heating()\r\n+ self.modes = [STATE_AUTO, STATE_HEAT, STATE_OFF]\r\n+ elif self.device_type == \"HotWater\":\r\n+ set_entity_id = \"Hive_HotWater\"\r\n+ self.session.hotwater = self.session.core.Hotwater()\r\n+ self.modes = [STATE_AUTO, STATE_ON, STATE_OFF]\r\n+ if self.node_name is not None:\r\n+ set_entity_id = set_entity_id + \"_\" \\\r\n+ + self.node_name.replace(\" \", \"_\")\r\n+ self.entity_id = ENTITY_ID_FORMAT.format(set_entity_id.lower())\r","path":"homeassistant/components/climate/hive.py","position":50,"original_position":50,"commit_id":"5e7d8725b94f5dcbc4162d42efca1fa8b34ee6ff","original_commit_id":"5e7d8725b94f5dcbc4162d42efca1fa8b34ee6ff","user":{"login":"tinloaf","id":442687,"avatar_url":"https://avatars3.githubusercontent.com/u/442687?v=4","gravatar_id":"","url":"https://api.github.com/users/tinloaf","html_url":"https://github.com/tinloaf","followers_url":"https://api.github.com/users/tinloaf/followers","following_url":"https://api.github.com/users/tinloaf/following{/other_user}","gists_url":"https://api.github.com/users/tinloaf/gists{/gist_id}","starred_url":"https://api.github.com/users/tinloaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinloaf/subscriptions","organizations_url":"https://api.github.com/users/tinloaf/orgs","repos_url":"https://api.github.com/users/tinloaf/repos","events_url":"https://api.github.com/users/tinloaf/events{/privacy}","received_events_url":"https://api.github.com/users/tinloaf/received_events","type":"User","site_admin":false},"body":"I think it would be better to use `generate_entity_id` here, which makes sure that there are no duplicates.","created_at":"2017-11-17T18:25:55Z","updated_at":"2017-11-17T18:30:57Z","html_url":"https://github.com/home-assistant/home-assistant/pull/9804#discussion_r151755770","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9804","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/151755770"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/9804#discussion_r151755770"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9804"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9804","id":145812606,"html_url":"https://github.com/home-assistant/home-assistant/pull/9804","diff_url":"https://github.com/home-assistant/home-assistant/pull/9804.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/9804.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/9804","number":9804,"state":"open","locked":false,"title":"New Hive Component / Platforms","user":{"login":"Rendili","id":30532082,"avatar_url":"https://avatars1.githubusercontent.com/u/30532082?v=4","gravatar_id":"","url":"https://api.github.com/users/Rendili","html_url":"https://github.com/Rendili","followers_url":"https://api.github.com/users/Rendili/followers","following_url":"https://api.github.com/users/Rendili/following{/other_user}","gists_url":"https://api.github.com/users/Rendili/gists{/gist_id}","starred_url":"https://api.github.com/users/Rendili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rendili/subscriptions","organizations_url":"https://api.github.com/users/Rendili/orgs","repos_url":"https://api.github.com/users/Rendili/repos","events_url":"https://api.github.com/users/Rendili/events{/privacy}","received_events_url":"https://api.github.com/users/Rendili/received_events","type":"User","site_admin":false},"body":"## Description:\r\nNew Hive platform supporting heating, hotwater, lights, switches and sensors from Hive.\r\n\r\n**Related issue (if applicable):** N/A\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#3577\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nhive: \r\n username: YOUR_USERNAME \r\n password: YOUR_PASSWORD \r\n```\r\n\r\n## Checklist:\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n - [x] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n - [x] New files were added to `.coveragerc`. \r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2017-10-10T22:02:37Z","updated_at":"2017-11-17T18:30:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41eb05230c4938446d9c1ede45c91b08932e973a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrey-git","id":5478779,"avatar_url":"https://avatars0.githubusercontent.com/u/5478779?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-git","html_url":"https://github.com/andrey-git","followers_url":"https://api.github.com/users/andrey-git/followers","following_url":"https://api.github.com/users/andrey-git/following{/other_user}","gists_url":"https://api.github.com/users/andrey-git/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-git/subscriptions","organizations_url":"https://api.github.com/users/andrey-git/orgs","repos_url":"https://api.github.com/users/andrey-git/repos","events_url":"https://api.github.com/users/andrey-git/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-git/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9804/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9804/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/9804/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/5e7d8725b94f5dcbc4162d42efca1fa8b34ee6ff","head":{"label":"Rendili:dev","ref":"dev","sha":"5e7d8725b94f5dcbc4162d42efca1fa8b34ee6ff","user":{"login":"Rendili","id":30532082,"avatar_url":"https://avatars1.githubusercontent.com/u/30532082?v=4","gravatar_id":"","url":"https://api.github.com/users/Rendili","html_url":"https://github.com/Rendili","followers_url":"https://api.github.com/users/Rendili/followers","following_url":"https://api.github.com/users/Rendili/following{/other_user}","gists_url":"https://api.github.com/users/Rendili/gists{/gist_id}","starred_url":"https://api.github.com/users/Rendili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rendili/subscriptions","organizations_url":"https://api.github.com/users/Rendili/orgs","repos_url":"https://api.github.com/users/Rendili/repos","events_url":"https://api.github.com/users/Rendili/events{/privacy}","received_events_url":"https://api.github.com/users/Rendili/received_events","type":"User","site_admin":false},"repo":{"id":100419617,"name":"home-assistant","full_name":"Rendili/home-assistant","owner":{"login":"Rendili","id":30532082,"avatar_url":"https://avatars1.githubusercontent.com/u/30532082?v=4","gravatar_id":"","url":"https://api.github.com/users/Rendili","html_url":"https://github.com/Rendili","followers_url":"https://api.github.com/users/Rendili/followers","following_url":"https://api.github.com/users/Rendili/following{/other_user}","gists_url":"https://api.github.com/users/Rendili/gists{/gist_id}","starred_url":"https://api.github.com/users/Rendili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rendili/subscriptions","organizations_url":"https://api.github.com/users/Rendili/orgs","repos_url":"https://api.github.com/users/Rendili/repos","events_url":"https://api.github.com/users/Rendili/events{/privacy}","received_events_url":"https://api.github.com/users/Rendili/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rendili/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/Rendili/home-assistant","forks_url":"https://api.github.com/repos/Rendili/home-assistant/forks","keys_url":"https://api.github.com/repos/Rendili/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rendili/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rendili/home-assistant/teams","hooks_url":"https://api.github.com/repos/Rendili/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/Rendili/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/Rendili/home-assistant/events","assignees_url":"https://api.github.com/repos/Rendili/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/Rendili/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/Rendili/home-assistant/tags","blobs_url":"https://api.github.com/repos/Rendili/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rendili/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rendili/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rendili/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rendili/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/Rendili/home-assistant/languages","stargazers_url":"https://api.github.com/repos/Rendili/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/Rendili/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/Rendili/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/Rendili/home-assistant/subscription","commits_url":"https://api.github.com/repos/Rendili/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rendili/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rendili/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rendili/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rendili/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/Rendili/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rendili/home-assistant/merges","archive_url":"https://api.github.com/repos/Rendili/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rendili/home-assistant/downloads","issues_url":"https://api.github.com/repos/Rendili/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/Rendili/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/Rendili/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/Rendili/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rendili/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/Rendili/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/Rendili/home-assistant/deployments","created_at":"2017-08-15T21:09:13Z","updated_at":"2017-08-15T21:09:22Z","pushed_at":"2017-11-17T18:14:29Z","git_url":"git://github.com/Rendili/home-assistant.git","ssh_url":"[email protected]:Rendili/home-assistant.git","clone_url":"https://github.com/Rendili/home-assistant.git","svn_url":"https://github.com/Rendili/home-assistant","homepage":"https://home-assistant.io","size":74680,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"5359001c043825d3c2e94f834373cbb9e5099fef","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2017-11-17T17:03:20Z","pushed_at":"2017-11-17T18:29:25Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"[email protected]:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":75266,"stargazers_count":10277,"watchers_count":10277,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2923,"mirror_url":null,"archived":false,"open_issues_count":598,"forks":2923,"open_issues":598,"watchers":10277,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9804"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/9804"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/9804"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/9804/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9804/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/9804/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/5e7d8725b94f5dcbc4162d42efca1fa8b34ee6ff"}},"author_association":"NONE"}} | {
"id": 12888993,
"name": "home-assistant/home-assistant",
"url": "https://api.github.com/repos/home-assistant/home-assistant"
} | {
"id": 442687,
"login": "tinloaf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/442687?",
"url": "https://api.github.com/users/tinloaf"
} | {
"id": 13844975,
"login": "home-assistant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13844975?",
"url": "https://api.github.com/orgs/home-assistant"
} | 2017-11-17T18:25:55 | 6871401090 | {"actor":{"display_login":"tinloaf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/comments/123291299","pull_request_review_id":45480400,"id":123291299,"diff_hunk":"@@ -2,3 +2,35 @@\n \n + Parameters\n + id (number, `1`) - ID of the library entry resource\n+\n++ Attributes (libraryEntriesAttributes)\n+\n+### GET List [GET /anime-characters]\n+\n++ Response 200 (application/vnd.api+json)\n+ + Attributes\n+ + data (array, required)\n+ + (libraryEntries)\n+ + meta (object, required)\n+ + count: 0 (number, required) \n+ <!-- Because of some errors with NSFW entries-->","path":"blueprint/user-libraries/library-entries.apib","position":15,"original_position":15,"commit_id":"383ad0e5a18ae1a2b0fb6a412c338cdcfd69f4bf","original_commit_id":"383ad0e5a18ae1a2b0fb6a412c338cdcfd69f4bf","user":{"login":"wopian","id":3440094,"avatar_url":"https://avatars3.githubusercontent.com/u/3440094?v=3","gravatar_id":"","url":"https://api.github.com/users/wopian","html_url":"https://github.com/wopian","followers_url":"https://api.github.com/users/wopian/followers","following_url":"https://api.github.com/users/wopian/following{/other_user}","gists_url":"https://api.github.com/users/wopian/gists{/gist_id}","starred_url":"https://api.github.com/users/wopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wopian/subscriptions","organizations_url":"https://api.github.com/users/wopian/orgs","repos_url":"https://api.github.com/users/wopian/repos","events_url":"https://api.github.com/users/wopian/events{/privacy}","received_events_url":"https://api.github.com/users/wopian/received_events","type":"User","site_admin":false},"body":"❌ MSON doesn't have comments of any kind - this will display `<!-- ... -->` literally in the response attributes","created_at":"2017-06-21T15:57:11Z","updated_at":"2017-06-21T16:01:46Z","html_url":"https://github.com/hummingbird-me/api-docs/pull/39#discussion_r123291299","pull_request_url":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/comments/123291299"},"html":{"href":"https://github.com/hummingbird-me/api-docs/pull/39#discussion_r123291299"},"pull_request":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/39","id":126517725,"html_url":"https://github.com/hummingbird-me/api-docs/pull/39","diff_url":"https://github.com/hummingbird-me/api-docs/pull/39.diff","patch_url":"https://github.com/hummingbird-me/api-docs/pull/39.patch","issue_url":"https://api.github.com/repos/hummingbird-me/api-docs/issues/39","number":39,"state":"open","locked":false,"title":"added userLibrary Documentation","user":{"login":"JasonLighthunter","id":6705325,"avatar_url":"https://avatars0.githubusercontent.com/u/6705325?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLighthunter","html_url":"https://github.com/JasonLighthunter","followers_url":"https://api.github.com/users/JasonLighthunter/followers","following_url":"https://api.github.com/users/JasonLighthunter/following{/other_user}","gists_url":"https://api.github.com/users/JasonLighthunter/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLighthunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLighthunter/subscriptions","organizations_url":"https://api.github.com/users/JasonLighthunter/orgs","repos_url":"https://api.github.com/users/JasonLighthunter/repos","events_url":"https://api.github.com/users/JasonLighthunter/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLighthunter/received_events","type":"User","site_admin":false},"body":"- Because of the errors with NSFW entries I could not find the total number of entries, and have left it as 0","created_at":"2017-06-20T12:15:57Z","updated_at":"2017-06-21T16:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b64f88ea5d6b1c0b982cdf15cad47a17ab858052","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/39/commits","review_comments_url":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/39/comments","review_comment_url":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hummingbird-me/api-docs/issues/39/comments","statuses_url":"https://api.github.com/repos/hummingbird-me/api-docs/statuses/383ad0e5a18ae1a2b0fb6a412c338cdcfd69f4bf","head":{"label":"JasonLighthunter:library_entries_documentation","ref":"library_entries_documentation","sha":"383ad0e5a18ae1a2b0fb6a412c338cdcfd69f4bf","user":{"login":"JasonLighthunter","id":6705325,"avatar_url":"https://avatars0.githubusercontent.com/u/6705325?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLighthunter","html_url":"https://github.com/JasonLighthunter","followers_url":"https://api.github.com/users/JasonLighthunter/followers","following_url":"https://api.github.com/users/JasonLighthunter/following{/other_user}","gists_url":"https://api.github.com/users/JasonLighthunter/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLighthunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLighthunter/subscriptions","organizations_url":"https://api.github.com/users/JasonLighthunter/orgs","repos_url":"https://api.github.com/users/JasonLighthunter/repos","events_url":"https://api.github.com/users/JasonLighthunter/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLighthunter/received_events","type":"User","site_admin":false},"repo":{"id":93599470,"name":"api-docs","full_name":"JasonLighthunter/api-docs","owner":{"login":"JasonLighthunter","id":6705325,"avatar_url":"https://avatars0.githubusercontent.com/u/6705325?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLighthunter","html_url":"https://github.com/JasonLighthunter","followers_url":"https://api.github.com/users/JasonLighthunter/followers","following_url":"https://api.github.com/users/JasonLighthunter/following{/other_user}","gists_url":"https://api.github.com/users/JasonLighthunter/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLighthunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLighthunter/subscriptions","organizations_url":"https://api.github.com/users/JasonLighthunter/orgs","repos_url":"https://api.github.com/users/JasonLighthunter/repos","events_url":"https://api.github.com/users/JasonLighthunter/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLighthunter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JasonLighthunter/api-docs","description":"🤖 API documentation for Kitsu","fork":true,"url":"https://api.github.com/repos/JasonLighthunter/api-docs","forks_url":"https://api.github.com/repos/JasonLighthunter/api-docs/forks","keys_url":"https://api.github.com/repos/JasonLighthunter/api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JasonLighthunter/api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JasonLighthunter/api-docs/teams","hooks_url":"https://api.github.com/repos/JasonLighthunter/api-docs/hooks","issue_events_url":"https://api.github.com/repos/JasonLighthunter/api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/JasonLighthunter/api-docs/events","assignees_url":"https://api.github.com/repos/JasonLighthunter/api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/JasonLighthunter/api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/JasonLighthunter/api-docs/tags","blobs_url":"https://api.github.com/repos/JasonLighthunter/api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JasonLighthunter/api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JasonLighthunter/api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/JasonLighthunter/api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JasonLighthunter/api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/JasonLighthunter/api-docs/languages","stargazers_url":"https://api.github.com/repos/JasonLighthunter/api-docs/stargazers","contributors_url":"https://api.github.com/repos/JasonLighthunter/api-docs/contributors","subscribers_url":"https://api.github.com/repos/JasonLighthunter/api-docs/subscribers","subscription_url":"https://api.github.com/repos/JasonLighthunter/api-docs/subscription","commits_url":"https://api.github.com/repos/JasonLighthunter/api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/JasonLighthunter/api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/JasonLighthunter/api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/JasonLighthunter/api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/JasonLighthunter/api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/JasonLighthunter/api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JasonLighthunter/api-docs/merges","archive_url":"https://api.github.com/repos/JasonLighthunter/api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JasonLighthunter/api-docs/downloads","issues_url":"https://api.github.com/repos/JasonLighthunter/api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/JasonLighthunter/api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/JasonLighthunter/api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/JasonLighthunter/api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JasonLighthunter/api-docs/labels{/name}","releases_url":"https://api.github.com/repos/JasonLighthunter/api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/JasonLighthunter/api-docs/deployments","created_at":"2017-06-07T06:16:47Z","updated_at":"2017-06-07T06:16:48Z","pushed_at":"2017-06-20T12:15:45Z","git_url":"git://github.com/JasonLighthunter/api-docs.git","ssh_url":"[email protected]:JasonLighthunter/api-docs.git","clone_url":"https://github.com/JasonLighthunter/api-docs.git","svn_url":"https://github.com/JasonLighthunter/api-docs","homepage":"http://docs.kitsu.apiary.io","size":181,"stargazers_count":0,"watchers_count":0,"language":"API Blueprint","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"source"}},"base":{"label":"hummingbird-me:source","ref":"source","sha":"049d46f2c733eebb0264bcc646a44606d1a6db1b","user":{"login":"hummingbird-me","id":7648832,"avatar_url":"https://avatars0.githubusercontent.com/u/7648832?v=3","gravatar_id":"","url":"https://api.github.com/users/hummingbird-me","html_url":"https://github.com/hummingbird-me","followers_url":"https://api.github.com/users/hummingbird-me/followers","following_url":"https://api.github.com/users/hummingbird-me/following{/other_user}","gists_url":"https://api.github.com/users/hummingbird-me/gists{/gist_id}","starred_url":"https://api.github.com/users/hummingbird-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hummingbird-me/subscriptions","organizations_url":"https://api.github.com/users/hummingbird-me/orgs","repos_url":"https://api.github.com/users/hummingbird-me/repos","events_url":"https://api.github.com/users/hummingbird-me/events{/privacy}","received_events_url":"https://api.github.com/users/hummingbird-me/received_events","type":"Organization","site_admin":false},"repo":{"id":92471764,"name":"api-docs","full_name":"hummingbird-me/api-docs","owner":{"login":"hummingbird-me","id":7648832,"avatar_url":"https://avatars0.githubusercontent.com/u/7648832?v=3","gravatar_id":"","url":"https://api.github.com/users/hummingbird-me","html_url":"https://github.com/hummingbird-me","followers_url":"https://api.github.com/users/hummingbird-me/followers","following_url":"https://api.github.com/users/hummingbird-me/following{/other_user}","gists_url":"https://api.github.com/users/hummingbird-me/gists{/gist_id}","starred_url":"https://api.github.com/users/hummingbird-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hummingbird-me/subscriptions","organizations_url":"https://api.github.com/users/hummingbird-me/orgs","repos_url":"https://api.github.com/users/hummingbird-me/repos","events_url":"https://api.github.com/users/hummingbird-me/events{/privacy}","received_events_url":"https://api.github.com/users/hummingbird-me/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hummingbird-me/api-docs","description":"🤖 API documentation for Kitsu","fork":false,"url":"https://api.github.com/repos/hummingbird-me/api-docs","forks_url":"https://api.github.com/repos/hummingbird-me/api-docs/forks","keys_url":"https://api.github.com/repos/hummingbird-me/api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hummingbird-me/api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hummingbird-me/api-docs/teams","hooks_url":"https://api.github.com/repos/hummingbird-me/api-docs/hooks","issue_events_url":"https://api.github.com/repos/hummingbird-me/api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/hummingbird-me/api-docs/events","assignees_url":"https://api.github.com/repos/hummingbird-me/api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/hummingbird-me/api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/hummingbird-me/api-docs/tags","blobs_url":"https://api.github.com/repos/hummingbird-me/api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hummingbird-me/api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hummingbird-me/api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/hummingbird-me/api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hummingbird-me/api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/hummingbird-me/api-docs/languages","stargazers_url":"https://api.github.com/repos/hummingbird-me/api-docs/stargazers","contributors_url":"https://api.github.com/repos/hummingbird-me/api-docs/contributors","subscribers_url":"https://api.github.com/repos/hummingbird-me/api-docs/subscribers","subscription_url":"https://api.github.com/repos/hummingbird-me/api-docs/subscription","commits_url":"https://api.github.com/repos/hummingbird-me/api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/hummingbird-me/api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/hummingbird-me/api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/hummingbird-me/api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/hummingbird-me/api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/hummingbird-me/api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hummingbird-me/api-docs/merges","archive_url":"https://api.github.com/repos/hummingbird-me/api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hummingbird-me/api-docs/downloads","issues_url":"https://api.github.com/repos/hummingbird-me/api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/hummingbird-me/api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/hummingbird-me/api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/hummingbird-me/api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hummingbird-me/api-docs/labels{/name}","releases_url":"https://api.github.com/repos/hummingbird-me/api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/hummingbird-me/api-docs/deployments","created_at":"2017-05-26T04:21:01Z","updated_at":"2017-06-07T20:00:09Z","pushed_at":"2017-06-21T15:26:40Z","git_url":"git://github.com/hummingbird-me/api-docs.git","ssh_url":"[email protected]:hummingbird-me/api-docs.git","clone_url":"https://github.com/hummingbird-me/api-docs.git","svn_url":"https://github.com/hummingbird-me/api-docs","homepage":"http://docs.kitsu.apiary.io","size":266,"stargazers_count":9,"watchers_count":9,"language":"API Blueprint","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":9,"default_branch":"source"}},"_links":{"self":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/39"},"html":{"href":"https://github.com/hummingbird-me/api-docs/pull/39"},"issue":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/issues/39"},"comments":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/hummingbird-me/api-docs/statuses/383ad0e5a18ae1a2b0fb6a412c338cdcfd69f4bf"}}}} | {
"id": 92471764,
"name": "hummingbird-me/api-docs",
"url": "https://api.github.com/repos/hummingbird-me/api-docs"
} | {
"id": 3440094,
"login": "wopian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3440094?",
"url": "https://api.github.com/users/wopian"
} | {
"id": 7648832,
"login": "hummingbird-me",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7648832?",
"url": "https://api.github.com/orgs/hummingbird-me"
} | 2017-06-21T15:57:11 | 6110979569 | {"actor":{"display_login":"wopian"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/comments/111521263","pull_request_review_id":32775064,"id":111521263,"diff_hunk":"@@ -0,0 +1,34 @@\n+:ruby\n+ type_collection = field.polymorphic_type_collection\n+ type_column = field.association.foreign_type.to_s\n+ selected_type = field.bindings[:object].send(type_column)\n+ selected = field.bindings[:object].send(field.association.name)\n+ collection = selected ? [[field.formatted_value, selected.id]] : [[]]\n+ column_type_dom_id = form.dom_id(field).sub(\n+ field.method_name.to_s, type_column\n+ )\n+ current_action = params[:action].in?(['create', 'new']) ? 'create' : 'update'\n+\n+ default_options = { float_left: false }\n+\n+ js_data = type_collection.inject({}) do |options, model|\n+ model_name = model[0].downcase\n+ source_abstract_model = RailsAdmin.config(form.object.class).abstract_model\n+ options.merge(model_name => {\n+ xhr: true,\n+ remote_source: index_path(\n+ model_name,\n+ source_object_id: form.object.id,\n+ source_abstract_model: source_abstract_model.to_param,\n+ current_action: current_action,\n+ compact: true\n+ ),\n+ float_left: false\n+ })\n+ end\n+\n+.form-inline\n+ - js_data.each do |model, value|\n+ %div{ id: \"#{model}-js-options\", data: { options: value.to_json } }\n+ = form.select type_column, type_collection, {include_blank: true, selected: selected_type}, class: \"form-control\", id: column_type_dom_id, data: { polymorphic: true, urls: field.polymorphic_type_urls.to_json }","path":"app/views/rails_admin/main/_form_polymorphic_association.html.haml","position":33,"original_position":33,"commit_id":"d1f8a5cfd8a0d5472024373f87e593a984f11f3e","original_commit_id":"d1f8a5cfd8a0d5472024373f87e593a984f11f3e","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long. [211/80]","created_at":"2017-04-14T02:34:40Z","updated_at":"2017-04-14T02:34:41Z","html_url":"https://github.com/hummingbird-me/hummingbird-server/pull/96#discussion_r111521263","pull_request_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/comments/111521263"},"html":{"href":"https://github.com/hummingbird-me/hummingbird-server/pull/96#discussion_r111521263"},"pull_request":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/96","id":114731582,"html_url":"https://github.com/hummingbird-me/hummingbird-server/pull/96","diff_url":"https://github.com/hummingbird-me/hummingbird-server/pull/96.diff","patch_url":"https://github.com/hummingbird-me/hummingbird-server/pull/96.patch","issue_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/issues/96","number":96,"state":"open","locked":false,"title":"rails admin fixes","user":{"login":"matthewdias","id":3302524,"avatar_url":"https://avatars3.githubusercontent.com/u/3302524?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdias","html_url":"https://github.com/matthewdias","followers_url":"https://api.github.com/users/matthewdias/followers","following_url":"https://api.github.com/users/matthewdias/following{/other_user}","gists_url":"https://api.github.com/users/matthewdias/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdias/subscriptions","organizations_url":"https://api.github.com/users/matthewdias/orgs","repos_url":"https://api.github.com/users/matthewdias/repos","events_url":"https://api.github.com/users/matthewdias/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdias/received_events","type":"User","site_admin":false},"body":"[bug](https://kitsu.io/feedback/bugs/p/rails-admin-config-bugs)\r\n\r\n- [x] make list view not terrible\r\n- [x] episodes\r\n- [x] mappings\r\n- [x] streaming links\r\n- [x] media relationships","created_at":"2017-04-07T02:18:25Z","updated_at":"2017-04-14T02:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2621f2c608977ddb639b90a3226155b3a781fe97","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/96/commits","review_comments_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/96/comments","review_comment_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/issues/96/comments","statuses_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/statuses/d1f8a5cfd8a0d5472024373f87e593a984f11f3e","head":{"label":"matthewdias:rails-admin-fixes","ref":"rails-admin-fixes","sha":"d1f8a5cfd8a0d5472024373f87e593a984f11f3e","user":{"login":"matthewdias","id":3302524,"avatar_url":"https://avatars3.githubusercontent.com/u/3302524?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdias","html_url":"https://github.com/matthewdias","followers_url":"https://api.github.com/users/matthewdias/followers","following_url":"https://api.github.com/users/matthewdias/following{/other_user}","gists_url":"https://api.github.com/users/matthewdias/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdias/subscriptions","organizations_url":"https://api.github.com/users/matthewdias/orgs","repos_url":"https://api.github.com/users/matthewdias/repos","events_url":"https://api.github.com/users/matthewdias/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdias/received_events","type":"User","site_admin":false},"repo":{"id":82972158,"name":"hummingbird-server","full_name":"matthewdias/hummingbird-server","owner":{"login":"matthewdias","id":3302524,"avatar_url":"https://avatars3.githubusercontent.com/u/3302524?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdias","html_url":"https://github.com/matthewdias","followers_url":"https://api.github.com/users/matthewdias/followers","following_url":"https://api.github.com/users/matthewdias/following{/other_user}","gists_url":"https://api.github.com/users/matthewdias/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdias/subscriptions","organizations_url":"https://api.github.com/users/matthewdias/orgs","repos_url":"https://api.github.com/users/matthewdias/repos","events_url":"https://api.github.com/users/matthewdias/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewdias/hummingbird-server","description":":steam_locomotive: Rails API server for Kitsu","fork":true,"url":"https://api.github.com/repos/matthewdias/hummingbird-server","forks_url":"https://api.github.com/repos/matthewdias/hummingbird-server/forks","keys_url":"https://api.github.com/repos/matthewdias/hummingbird-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewdias/hummingbird-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewdias/hummingbird-server/teams","hooks_url":"https://api.github.com/repos/matthewdias/hummingbird-server/hooks","issue_events_url":"https://api.github.com/repos/matthewdias/hummingbird-server/issues/events{/number}","events_url":"https://api.github.com/repos/matthewdias/hummingbird-server/events","assignees_url":"https://api.github.com/repos/matthewdias/hummingbird-server/assignees{/user}","branches_url":"https://api.github.com/repos/matthewdias/hummingbird-server/branches{/branch}","tags_url":"https://api.github.com/repos/matthewdias/hummingbird-server/tags","blobs_url":"https://api.github.com/repos/matthewdias/hummingbird-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewdias/hummingbird-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewdias/hummingbird-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewdias/hummingbird-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewdias/hummingbird-server/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewdias/hummingbird-server/languages","stargazers_url":"https://api.github.com/repos/matthewdias/hummingbird-server/stargazers","contributors_url":"https://api.github.com/repos/matthewdias/hummingbird-server/contributors","subscribers_url":"https://api.github.com/repos/matthewdias/hummingbird-server/subscribers","subscription_url":"https://api.github.com/repos/matthewdias/hummingbird-server/subscription","commits_url":"https://api.github.com/repos/matthewdias/hummingbird-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewdias/hummingbird-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewdias/hummingbird-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewdias/hummingbird-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewdias/hummingbird-server/contents/{+path}","compare_url":"https://api.github.com/repos/matthewdias/hummingbird-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewdias/hummingbird-server/merges","archive_url":"https://api.github.com/repos/matthewdias/hummingbird-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewdias/hummingbird-server/downloads","issues_url":"https://api.github.com/repos/matthewdias/hummingbird-server/issues{/number}","pulls_url":"https://api.github.com/repos/matthewdias/hummingbird-server/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewdias/hummingbird-server/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewdias/hummingbird-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewdias/hummingbird-server/labels{/name}","releases_url":"https://api.github.com/repos/matthewdias/hummingbird-server/releases{/id}","deployments_url":"https://api.github.com/repos/matthewdias/hummingbird-server/deployments","created_at":"2017-02-23T21:15:43Z","updated_at":"2017-02-23T21:15:45Z","pushed_at":"2017-04-14T02:34:26Z","git_url":"git://github.com/matthewdias/hummingbird-server.git","ssh_url":"[email protected]:matthewdias/hummingbird-server.git","clone_url":"https://github.com/matthewdias/hummingbird-server.git","svn_url":"https://github.com/matthewdias/hummingbird-server","homepage":"","size":2599,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"the-future"}},"base":{"label":"hummingbird-me:the-future","ref":"the-future","sha":"050169366b52ba67bc9d98cb94ed3418531413a9","user":{"login":"hummingbird-me","id":7648832,"avatar_url":"https://avatars0.githubusercontent.com/u/7648832?v=3","gravatar_id":"","url":"https://api.github.com/users/hummingbird-me","html_url":"https://github.com/hummingbird-me","followers_url":"https://api.github.com/users/hummingbird-me/followers","following_url":"https://api.github.com/users/hummingbird-me/following{/other_user}","gists_url":"https://api.github.com/users/hummingbird-me/gists{/gist_id}","starred_url":"https://api.github.com/users/hummingbird-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hummingbird-me/subscriptions","organizations_url":"https://api.github.com/users/hummingbird-me/orgs","repos_url":"https://api.github.com/users/hummingbird-me/repos","events_url":"https://api.github.com/users/hummingbird-me/events{/privacy}","received_events_url":"https://api.github.com/users/hummingbird-me/received_events","type":"Organization","site_admin":false},"repo":{"id":68339720,"name":"hummingbird-server","full_name":"hummingbird-me/hummingbird-server","owner":{"login":"hummingbird-me","id":7648832,"avatar_url":"https://avatars0.githubusercontent.com/u/7648832?v=3","gravatar_id":"","url":"https://api.github.com/users/hummingbird-me","html_url":"https://github.com/hummingbird-me","followers_url":"https://api.github.com/users/hummingbird-me/followers","following_url":"https://api.github.com/users/hummingbird-me/following{/other_user}","gists_url":"https://api.github.com/users/hummingbird-me/gists{/gist_id}","starred_url":"https://api.github.com/users/hummingbird-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hummingbird-me/subscriptions","organizations_url":"https://api.github.com/users/hummingbird-me/orgs","repos_url":"https://api.github.com/users/hummingbird-me/repos","events_url":"https://api.github.com/users/hummingbird-me/events{/privacy}","received_events_url":"https://api.github.com/users/hummingbird-me/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hummingbird-me/hummingbird-server","description":":steam_locomotive: Rails API server for Kitsu","fork":false,"url":"https://api.github.com/repos/hummingbird-me/hummingbird-server","forks_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/forks","keys_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/teams","hooks_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/hooks","issue_events_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/issues/events{/number}","events_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/events","assignees_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/assignees{/user}","branches_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/branches{/branch}","tags_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/tags","blobs_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/statuses/{sha}","languages_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/languages","stargazers_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/stargazers","contributors_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/contributors","subscribers_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/subscribers","subscription_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/subscription","commits_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/contents/{+path}","compare_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/merges","archive_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/downloads","issues_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/issues{/number}","pulls_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls{/number}","milestones_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/milestones{/number}","notifications_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/labels{/name}","releases_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/releases{/id}","deployments_url":"https://api.github.com/repos/hummingbird-me/hummingbird-server/deployments","created_at":"2016-09-15T23:36:19Z","updated_at":"2017-03-30T01:31:52Z","pushed_at":"2017-04-14T02:34:28Z","git_url":"git://github.com/hummingbird-me/hummingbird-server.git","ssh_url":"[email protected]:hummingbird-me/hummingbird-server.git","clone_url":"https://github.com/hummingbird-me/hummingbird-server.git","svn_url":"https://github.com/hummingbird-me/hummingbird-server","homepage":"","size":2681,"stargazers_count":44,"watchers_count":44,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":8,"forks":56,"open_issues":8,"watchers":44,"default_branch":"the-future"}},"_links":{"self":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/96"},"html":{"href":"https://github.com/hummingbird-me/hummingbird-server/pull/96"},"issue":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/issues/96"},"comments":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird-server/statuses/d1f8a5cfd8a0d5472024373f87e593a984f11f3e"}}}} | {
"id": 68339720,
"name": "hummingbird-me/hummingbird-server",
"url": "https://api.github.com/repos/hummingbird-me/hummingbird-server"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 7648832,
"login": "hummingbird-me",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7648832?",
"url": "https://api.github.com/orgs/hummingbird-me"
} | 2017-04-14T02:34:40 | 5688236239 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments/96702733","pull_request_review_id":17292530,"id":96702733,"diff_hunk":"@@ -25,6 +34,9 @@ pm.status_path = /fpm-status\n \n Setting | Default | Description | Type\n --------|---------|-------------|-----\n+uri | fpm-status | Path part of the URL, with or without the leading / | string","path":"docs/collectors/PhpFpmCollector.md","position":20,"original_position":20,"commit_id":"05993a35fa4cfc46573ec47b2aff2de20b4b27ca","original_commit_id":"05993a35fa4cfc46573ec47b2aff2de20b4b27ca","user":{"login":"shortdudey123","id":3051981,"avatar_url":"https://avatars.githubusercontent.com/u/3051981?v=3","gravatar_id":"","url":"https://api.github.com/users/shortdudey123","html_url":"https://github.com/shortdudey123","followers_url":"https://api.github.com/users/shortdudey123/followers","following_url":"https://api.github.com/users/shortdudey123/following{/other_user}","gists_url":"https://api.github.com/users/shortdudey123/gists{/gist_id}","starred_url":"https://api.github.com/users/shortdudey123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shortdudey123/subscriptions","organizations_url":"https://api.github.com/users/shortdudey123/orgs","repos_url":"https://api.github.com/users/shortdudey123/repos","events_url":"https://api.github.com/users/shortdudey123/events{/privacy}","received_events_url":"https://api.github.com/users/shortdudey123/received_events","type":"User","site_admin":false},"body":"Alphabetize","created_at":"2017-01-18T18:32:08Z","updated_at":"2017-01-18T18:32:11Z","html_url":"https://github.com/python-diamond/Diamond/pull/579#discussion_r96702733","pull_request_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/579","_links":{"self":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments/96702733"},"html":{"href":"https://github.com/python-diamond/Diamond/pull/579#discussion_r96702733"},"pull_request":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/579"}}},"pull_request":{"url":"https://api.github.com/repos/python-diamond/Diamond/pulls/579","id":102084487,"html_url":"https://github.com/python-diamond/Diamond/pull/579","diff_url":"https://github.com/python-diamond/Diamond/pull/579.diff","patch_url":"https://github.com/python-diamond/Diamond/pull/579.patch","issue_url":"https://api.github.com/repos/python-diamond/Diamond/issues/579","number":579,"state":"open","locked":false,"title":"Complete the list of accepted variables for phpfpm collector","user":{"login":"gjedeer","id":315648,"avatar_url":"https://avatars.githubusercontent.com/u/315648?v=3","gravatar_id":"","url":"https://api.github.com/users/gjedeer","html_url":"https://github.com/gjedeer","followers_url":"https://api.github.com/users/gjedeer/followers","following_url":"https://api.github.com/users/gjedeer/following{/other_user}","gists_url":"https://api.github.com/users/gjedeer/gists{/gist_id}","starred_url":"https://api.github.com/users/gjedeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjedeer/subscriptions","organizations_url":"https://api.github.com/users/gjedeer/orgs","repos_url":"https://api.github.com/users/gjedeer/repos","events_url":"https://api.github.com/users/gjedeer/events{/privacy}","received_events_url":"https://api.github.com/users/gjedeer/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-18T15:13:25Z","updated_at":"2017-01-18T18:32:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c1f021187c66251af355a34b2f629fb544e6b14","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/579/commits","review_comments_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/579/comments","review_comment_url":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-diamond/Diamond/issues/579/comments","statuses_url":"https://api.github.com/repos/python-diamond/Diamond/statuses/05993a35fa4cfc46573ec47b2aff2de20b4b27ca","head":{"label":"gjedeer:patch-1","ref":"patch-1","sha":"05993a35fa4cfc46573ec47b2aff2de20b4b27ca","user":{"login":"gjedeer","id":315648,"avatar_url":"https://avatars.githubusercontent.com/u/315648?v=3","gravatar_id":"","url":"https://api.github.com/users/gjedeer","html_url":"https://github.com/gjedeer","followers_url":"https://api.github.com/users/gjedeer/followers","following_url":"https://api.github.com/users/gjedeer/following{/other_user}","gists_url":"https://api.github.com/users/gjedeer/gists{/gist_id}","starred_url":"https://api.github.com/users/gjedeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjedeer/subscriptions","organizations_url":"https://api.github.com/users/gjedeer/orgs","repos_url":"https://api.github.com/users/gjedeer/repos","events_url":"https://api.github.com/users/gjedeer/events{/privacy}","received_events_url":"https://api.github.com/users/gjedeer/received_events","type":"User","site_admin":false},"repo":{"id":79351770,"name":"Diamond-1","full_name":"gjedeer/Diamond-1","owner":{"login":"gjedeer","id":315648,"avatar_url":"https://avatars.githubusercontent.com/u/315648?v=3","gravatar_id":"","url":"https://api.github.com/users/gjedeer","html_url":"https://github.com/gjedeer","followers_url":"https://api.github.com/users/gjedeer/followers","following_url":"https://api.github.com/users/gjedeer/following{/other_user}","gists_url":"https://api.github.com/users/gjedeer/gists{/gist_id}","starred_url":"https://api.github.com/users/gjedeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjedeer/subscriptions","organizations_url":"https://api.github.com/users/gjedeer/orgs","repos_url":"https://api.github.com/users/gjedeer/repos","events_url":"https://api.github.com/users/gjedeer/events{/privacy}","received_events_url":"https://api.github.com/users/gjedeer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gjedeer/Diamond-1","description":"Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.","fork":true,"url":"https://api.github.com/repos/gjedeer/Diamond-1","forks_url":"https://api.github.com/repos/gjedeer/Diamond-1/forks","keys_url":"https://api.github.com/repos/gjedeer/Diamond-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gjedeer/Diamond-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gjedeer/Diamond-1/teams","hooks_url":"https://api.github.com/repos/gjedeer/Diamond-1/hooks","issue_events_url":"https://api.github.com/repos/gjedeer/Diamond-1/issues/events{/number}","events_url":"https://api.github.com/repos/gjedeer/Diamond-1/events","assignees_url":"https://api.github.com/repos/gjedeer/Diamond-1/assignees{/user}","branches_url":"https://api.github.com/repos/gjedeer/Diamond-1/branches{/branch}","tags_url":"https://api.github.com/repos/gjedeer/Diamond-1/tags","blobs_url":"https://api.github.com/repos/gjedeer/Diamond-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gjedeer/Diamond-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gjedeer/Diamond-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/gjedeer/Diamond-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gjedeer/Diamond-1/statuses/{sha}","languages_url":"https://api.github.com/repos/gjedeer/Diamond-1/languages","stargazers_url":"https://api.github.com/repos/gjedeer/Diamond-1/stargazers","contributors_url":"https://api.github.com/repos/gjedeer/Diamond-1/contributors","subscribers_url":"https://api.github.com/repos/gjedeer/Diamond-1/subscribers","subscription_url":"https://api.github.com/repos/gjedeer/Diamond-1/subscription","commits_url":"https://api.github.com/repos/gjedeer/Diamond-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/gjedeer/Diamond-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/gjedeer/Diamond-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/gjedeer/Diamond-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/gjedeer/Diamond-1/contents/{+path}","compare_url":"https://api.github.com/repos/gjedeer/Diamond-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gjedeer/Diamond-1/merges","archive_url":"https://api.github.com/repos/gjedeer/Diamond-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gjedeer/Diamond-1/downloads","issues_url":"https://api.github.com/repos/gjedeer/Diamond-1/issues{/number}","pulls_url":"https://api.github.com/repos/gjedeer/Diamond-1/pulls{/number}","milestones_url":"https://api.github.com/repos/gjedeer/Diamond-1/milestones{/number}","notifications_url":"https://api.github.com/repos/gjedeer/Diamond-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gjedeer/Diamond-1/labels{/name}","releases_url":"https://api.github.com/repos/gjedeer/Diamond-1/releases{/id}","deployments_url":"https://api.github.com/repos/gjedeer/Diamond-1/deployments","created_at":"2017-01-18T15:10:26Z","updated_at":"2017-01-18T15:10:30Z","pushed_at":"2017-01-18T15:13:19Z","git_url":"git://github.com/gjedeer/Diamond-1.git","ssh_url":"[email protected]:gjedeer/Diamond-1.git","clone_url":"https://github.com/gjedeer/Diamond-1.git","svn_url":"https://github.com/gjedeer/Diamond-1","homepage":"http://diamond.readthedocs.org/","size":3357,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-diamond:master","ref":"master","sha":"8c7ea91d633caab0158cc5852a6b02f7a794422e","user":{"login":"python-diamond","id":5668086,"avatar_url":"https://avatars.githubusercontent.com/u/5668086?v=3","gravatar_id":"","url":"https://api.github.com/users/python-diamond","html_url":"https://github.com/python-diamond","followers_url":"https://api.github.com/users/python-diamond/followers","following_url":"https://api.github.com/users/python-diamond/following{/other_user}","gists_url":"https://api.github.com/users/python-diamond/gists{/gist_id}","starred_url":"https://api.github.com/users/python-diamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-diamond/subscriptions","organizations_url":"https://api.github.com/users/python-diamond/orgs","repos_url":"https://api.github.com/users/python-diamond/repos","events_url":"https://api.github.com/users/python-diamond/events{/privacy}","received_events_url":"https://api.github.com/users/python-diamond/received_events","type":"Organization","site_admin":false},"repo":{"id":13512018,"name":"Diamond","full_name":"python-diamond/Diamond","owner":{"login":"python-diamond","id":5668086,"avatar_url":"https://avatars.githubusercontent.com/u/5668086?v=3","gravatar_id":"","url":"https://api.github.com/users/python-diamond","html_url":"https://github.com/python-diamond","followers_url":"https://api.github.com/users/python-diamond/followers","following_url":"https://api.github.com/users/python-diamond/following{/other_user}","gists_url":"https://api.github.com/users/python-diamond/gists{/gist_id}","starred_url":"https://api.github.com/users/python-diamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-diamond/subscriptions","organizations_url":"https://api.github.com/users/python-diamond/orgs","repos_url":"https://api.github.com/users/python-diamond/repos","events_url":"https://api.github.com/users/python-diamond/events{/privacy}","received_events_url":"https://api.github.com/users/python-diamond/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-diamond/Diamond","description":"Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.","fork":false,"url":"https://api.github.com/repos/python-diamond/Diamond","forks_url":"https://api.github.com/repos/python-diamond/Diamond/forks","keys_url":"https://api.github.com/repos/python-diamond/Diamond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-diamond/Diamond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-diamond/Diamond/teams","hooks_url":"https://api.github.com/repos/python-diamond/Diamond/hooks","issue_events_url":"https://api.github.com/repos/python-diamond/Diamond/issues/events{/number}","events_url":"https://api.github.com/repos/python-diamond/Diamond/events","assignees_url":"https://api.github.com/repos/python-diamond/Diamond/assignees{/user}","branches_url":"https://api.github.com/repos/python-diamond/Diamond/branches{/branch}","tags_url":"https://api.github.com/repos/python-diamond/Diamond/tags","blobs_url":"https://api.github.com/repos/python-diamond/Diamond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-diamond/Diamond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-diamond/Diamond/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-diamond/Diamond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-diamond/Diamond/statuses/{sha}","languages_url":"https://api.github.com/repos/python-diamond/Diamond/languages","stargazers_url":"https://api.github.com/repos/python-diamond/Diamond/stargazers","contributors_url":"https://api.github.com/repos/python-diamond/Diamond/contributors","subscribers_url":"https://api.github.com/repos/python-diamond/Diamond/subscribers","subscription_url":"https://api.github.com/repos/python-diamond/Diamond/subscription","commits_url":"https://api.github.com/repos/python-diamond/Diamond/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-diamond/Diamond/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-diamond/Diamond/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-diamond/Diamond/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-diamond/Diamond/contents/{+path}","compare_url":"https://api.github.com/repos/python-diamond/Diamond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-diamond/Diamond/merges","archive_url":"https://api.github.com/repos/python-diamond/Diamond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-diamond/Diamond/downloads","issues_url":"https://api.github.com/repos/python-diamond/Diamond/issues{/number}","pulls_url":"https://api.github.com/repos/python-diamond/Diamond/pulls{/number}","milestones_url":"https://api.github.com/repos/python-diamond/Diamond/milestones{/number}","notifications_url":"https://api.github.com/repos/python-diamond/Diamond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-diamond/Diamond/labels{/name}","releases_url":"https://api.github.com/repos/python-diamond/Diamond/releases{/id}","deployments_url":"https://api.github.com/repos/python-diamond/Diamond/deployments","created_at":"2013-10-11T23:32:13Z","updated_at":"2017-01-18T00:58:45Z","pushed_at":"2017-01-18T15:13:26Z","git_url":"git://github.com/python-diamond/Diamond.git","ssh_url":"[email protected]:python-diamond/Diamond.git","clone_url":"https://github.com/python-diamond/Diamond.git","svn_url":"https://github.com/python-diamond/Diamond","homepage":"http://diamond.readthedocs.org/","size":3357,"stargazers_count":815,"watchers_count":815,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":395,"mirror_url":null,"open_issues_count":227,"forks":395,"open_issues":227,"watchers":815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/579"},"html":{"href":"https://github.com/python-diamond/Diamond/pull/579"},"issue":{"href":"https://api.github.com/repos/python-diamond/Diamond/issues/579"},"comments":{"href":"https://api.github.com/repos/python-diamond/Diamond/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-diamond/Diamond/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/python-diamond/Diamond/statuses/05993a35fa4cfc46573ec47b2aff2de20b4b27ca"}}}} | {
"id": 13512018,
"name": "python-diamond/Diamond",
"url": "https://api.github.com/repos/python-diamond/Diamond"
} | {
"id": 3051981,
"login": "shortdudey123",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3051981?",
"url": "https://api.github.com/users/shortdudey123"
} | {
"id": 5668086,
"login": "python-diamond",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5668086?",
"url": "https://api.github.com/orgs/python-diamond"
} | 2017-01-18T18:32:08 | 5174414232 | {"actor":{"display_login":"shortdudey123"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ruby-formatter/rufo/pulls/comments/144702557","pull_request_review_id":69401212,"id":144702557,"diff_hunk":"@@ -144,5 +143,5 @@ EOF\n #~# EXPECTED\n \n <<~EOF\n-#{1 }#{2}","path":"spec/lib/rufo/formatter_source_specs/2.3/squiggly_heredoc.rb.spec","position":12,"original_position":12,"commit_id":"e827316101cbe76d5a67fa8e457a12b4eedfe428","original_commit_id":"e827316101cbe76d5a67fa8e457a12b4eedfe428","user":{"login":"bessey","id":708200,"avatar_url":"https://avatars2.githubusercontent.com/u/708200?v=4","gravatar_id":"","url":"https://api.github.com/users/bessey","html_url":"https://github.com/bessey","followers_url":"https://api.github.com/users/bessey/followers","following_url":"https://api.github.com/users/bessey/following{/other_user}","gists_url":"https://api.github.com/users/bessey/gists{/gist_id}","starred_url":"https://api.github.com/users/bessey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bessey/subscriptions","organizations_url":"https://api.github.com/users/bessey/orgs","repos_url":"https://api.github.com/users/bessey/repos","events_url":"https://api.github.com/users/bessey/events{/privacy}","received_events_url":"https://api.github.com/users/bessey/received_events","type":"User","site_admin":false},"body":"(For others benefit, these refer to Ruby 2.X versions, as in, Ruby 2.3.5, 2.4.2 and 2.5.0-dev. Took me a moment!)\r\n\r\nGlad to hear they're being backported to things we use in production. So are you saying on 2.3.5 this test would pass?:\r\n\r\n#~# ORIGINAL heredoc_squiggly_extra_spaces\r\n```ruby\r\n<<~EOF\r\n#{1} #{2}\r\nEOF\r\n\r\n#~# EXPECTED\r\n\r\n<<~EOF\r\n#{1} #{2}\r\nEOF\r\n```","created_at":"2017-10-14T20:15:15Z","updated_at":"2017-10-14T20:15:19Z","html_url":"https://github.com/ruby-formatter/rufo/pull/33#discussion_r144702557","pull_request_url":"https://api.github.com/repos/ruby-formatter/rufo/pulls/33","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ruby-formatter/rufo/pulls/comments/144702557"},"html":{"href":"https://github.com/ruby-formatter/rufo/pull/33#discussion_r144702557"},"pull_request":{"href":"https://api.github.com/repos/ruby-formatter/rufo/pulls/33"}},"in_reply_to_id":144683407},"pull_request":{"url":"https://api.github.com/repos/ruby-formatter/rufo/pulls/33","id":146472979,"html_url":"https://github.com/ruby-formatter/rufo/pull/33","diff_url":"https://github.com/ruby-formatter/rufo/pull/33.diff","patch_url":"https://github.com/ruby-formatter/rufo/pull/33.patch","issue_url":"https://api.github.com/repos/ruby-formatter/rufo/issues/33","number":33,"state":"open","locked":false,"title":"Swap squiggly heredoc tokens when ripper lexer emits out of sequence","user":{"login":"mjago","id":18483,"avatar_url":"https://avatars2.githubusercontent.com/u/18483?v=4","gravatar_id":"","url":"https://api.github.com/users/mjago","html_url":"https://github.com/mjago","followers_url":"https://api.github.com/users/mjago/followers","following_url":"https://api.github.com/users/mjago/following{/other_user}","gists_url":"https://api.github.com/users/mjago/gists{/gist_id}","starred_url":"https://api.github.com/users/mjago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjago/subscriptions","organizations_url":"https://api.github.com/users/mjago/orgs","repos_url":"https://api.github.com/users/mjago/repos","events_url":"https://api.github.com/users/mjago/events{/privacy}","received_events_url":"https://api.github.com/users/mjago/received_events","type":"User","site_admin":false},"body":"Fix for #6 where ripper emits tokens out of sequence.\r\n\r\ni.e.: ```ruby -rripper -rpp -e 'pp Ripper.lex(\"<<~EOF\\n \\#{1}\\#{2}\\nEOF\")'```\r\ngives:\r\n```[[[1, 0], :on_heredoc_beg, \"<<~EOF\"],\r\n [[1, 6], :on_nl, \"\\n\"],\r\n [[2, 1], :on_embexpr_beg, \"\\#{\"],\r\n [[2, 1], :on_tstring_content, \"\"],\r\n [[2, 3], :on_int, \"1\"],\r\n [[2, 4], :on_embexpr_end, \"}\"],\r\n [[2, 5], :on_embexpr_beg, \"\\#{\"],\r\n [[2, 7], :on_int, \"2\"],\r\n [[2, 8], :on_embexpr_end, \"}\"],\r\n [[2, 9], :on_tstring_content, \"\\n\"],\r\n [[3, 0], :on_heredoc_end, \"EOF\"]]```","created_at":"2017-10-13T14:33:02Z","updated_at":"2017-10-14T20:15:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be5baaf844618a553f8ac3fe1a04a62b61e04111","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruby-formatter/rufo/pulls/33/commits","review_comments_url":"https://api.github.com/repos/ruby-formatter/rufo/pulls/33/comments","review_comment_url":"https://api.github.com/repos/ruby-formatter/rufo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruby-formatter/rufo/issues/33/comments","statuses_url":"https://api.github.com/repos/ruby-formatter/rufo/statuses/e827316101cbe76d5a67fa8e457a12b4eedfe428","head":{"label":"mjago:squiggly_heredoc_token_bug","ref":"squiggly_heredoc_token_bug","sha":"e827316101cbe76d5a67fa8e457a12b4eedfe428","user":{"login":"mjago","id":18483,"avatar_url":"https://avatars2.githubusercontent.com/u/18483?v=4","gravatar_id":"","url":"https://api.github.com/users/mjago","html_url":"https://github.com/mjago","followers_url":"https://api.github.com/users/mjago/followers","following_url":"https://api.github.com/users/mjago/following{/other_user}","gists_url":"https://api.github.com/users/mjago/gists{/gist_id}","starred_url":"https://api.github.com/users/mjago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjago/subscriptions","organizations_url":"https://api.github.com/users/mjago/orgs","repos_url":"https://api.github.com/users/mjago/repos","events_url":"https://api.github.com/users/mjago/events{/privacy}","received_events_url":"https://api.github.com/users/mjago/received_events","type":"User","site_admin":false},"repo":{"id":97473547,"name":"rufo","full_name":"mjago/rufo","owner":{"login":"mjago","id":18483,"avatar_url":"https://avatars2.githubusercontent.com/u/18483?v=4","gravatar_id":"","url":"https://api.github.com/users/mjago","html_url":"https://github.com/mjago","followers_url":"https://api.github.com/users/mjago/followers","following_url":"https://api.github.com/users/mjago/following{/other_user}","gists_url":"https://api.github.com/users/mjago/gists{/gist_id}","starred_url":"https://api.github.com/users/mjago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjago/subscriptions","organizations_url":"https://api.github.com/users/mjago/orgs","repos_url":"https://api.github.com/users/mjago/repos","events_url":"https://api.github.com/users/mjago/events{/privacy}","received_events_url":"https://api.github.com/users/mjago/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjago/rufo","description":"The Ruby Formatter - created by @asterite","fork":true,"url":"https://api.github.com/repos/mjago/rufo","forks_url":"https://api.github.com/repos/mjago/rufo/forks","keys_url":"https://api.github.com/repos/mjago/rufo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjago/rufo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjago/rufo/teams","hooks_url":"https://api.github.com/repos/mjago/rufo/hooks","issue_events_url":"https://api.github.com/repos/mjago/rufo/issues/events{/number}","events_url":"https://api.github.com/repos/mjago/rufo/events","assignees_url":"https://api.github.com/repos/mjago/rufo/assignees{/user}","branches_url":"https://api.github.com/repos/mjago/rufo/branches{/branch}","tags_url":"https://api.github.com/repos/mjago/rufo/tags","blobs_url":"https://api.github.com/repos/mjago/rufo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjago/rufo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjago/rufo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjago/rufo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjago/rufo/statuses/{sha}","languages_url":"https://api.github.com/repos/mjago/rufo/languages","stargazers_url":"https://api.github.com/repos/mjago/rufo/stargazers","contributors_url":"https://api.github.com/repos/mjago/rufo/contributors","subscribers_url":"https://api.github.com/repos/mjago/rufo/subscribers","subscription_url":"https://api.github.com/repos/mjago/rufo/subscription","commits_url":"https://api.github.com/repos/mjago/rufo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjago/rufo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjago/rufo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjago/rufo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjago/rufo/contents/{+path}","compare_url":"https://api.github.com/repos/mjago/rufo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjago/rufo/merges","archive_url":"https://api.github.com/repos/mjago/rufo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjago/rufo/downloads","issues_url":"https://api.github.com/repos/mjago/rufo/issues{/number}","pulls_url":"https://api.github.com/repos/mjago/rufo/pulls{/number}","milestones_url":"https://api.github.com/repos/mjago/rufo/milestones{/number}","notifications_url":"https://api.github.com/repos/mjago/rufo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjago/rufo/labels{/name}","releases_url":"https://api.github.com/repos/mjago/rufo/releases{/id}","deployments_url":"https://api.github.com/repos/mjago/rufo/deployments","created_at":"2017-07-17T12:26:37Z","updated_at":"2017-07-17T12:26:38Z","pushed_at":"2017-10-13T22:24:32Z","git_url":"git://github.com/mjago/rufo.git","ssh_url":"[email protected]:mjago/rufo.git","clone_url":"https://github.com/mjago/rufo.git","svn_url":"https://github.com/mjago/rufo","homepage":"","size":425,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruby-formatter:master","ref":"master","sha":"a0e54539375ed13b925efd7df7dc403f01630315","user":{"login":"ruby-formatter","id":30173546,"avatar_url":"https://avatars1.githubusercontent.com/u/30173546?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby-formatter","html_url":"https://github.com/ruby-formatter","followers_url":"https://api.github.com/users/ruby-formatter/followers","following_url":"https://api.github.com/users/ruby-formatter/following{/other_user}","gists_url":"https://api.github.com/users/ruby-formatter/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-formatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-formatter/subscriptions","organizations_url":"https://api.github.com/users/ruby-formatter/orgs","repos_url":"https://api.github.com/users/ruby-formatter/repos","events_url":"https://api.github.com/users/ruby-formatter/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-formatter/received_events","type":"Organization","site_admin":false},"repo":{"id":97214803,"name":"rufo","full_name":"ruby-formatter/rufo","owner":{"login":"ruby-formatter","id":30173546,"avatar_url":"https://avatars1.githubusercontent.com/u/30173546?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby-formatter","html_url":"https://github.com/ruby-formatter","followers_url":"https://api.github.com/users/ruby-formatter/followers","following_url":"https://api.github.com/users/ruby-formatter/following{/other_user}","gists_url":"https://api.github.com/users/ruby-formatter/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-formatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-formatter/subscriptions","organizations_url":"https://api.github.com/users/ruby-formatter/orgs","repos_url":"https://api.github.com/users/ruby-formatter/repos","events_url":"https://api.github.com/users/ruby-formatter/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-formatter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruby-formatter/rufo","description":"The Ruby Formatter - created by @asterite","fork":false,"url":"https://api.github.com/repos/ruby-formatter/rufo","forks_url":"https://api.github.com/repos/ruby-formatter/rufo/forks","keys_url":"https://api.github.com/repos/ruby-formatter/rufo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby-formatter/rufo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby-formatter/rufo/teams","hooks_url":"https://api.github.com/repos/ruby-formatter/rufo/hooks","issue_events_url":"https://api.github.com/repos/ruby-formatter/rufo/issues/events{/number}","events_url":"https://api.github.com/repos/ruby-formatter/rufo/events","assignees_url":"https://api.github.com/repos/ruby-formatter/rufo/assignees{/user}","branches_url":"https://api.github.com/repos/ruby-formatter/rufo/branches{/branch}","tags_url":"https://api.github.com/repos/ruby-formatter/rufo/tags","blobs_url":"https://api.github.com/repos/ruby-formatter/rufo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby-formatter/rufo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby-formatter/rufo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby-formatter/rufo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby-formatter/rufo/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby-formatter/rufo/languages","stargazers_url":"https://api.github.com/repos/ruby-formatter/rufo/stargazers","contributors_url":"https://api.github.com/repos/ruby-formatter/rufo/contributors","subscribers_url":"https://api.github.com/repos/ruby-formatter/rufo/subscribers","subscription_url":"https://api.github.com/repos/ruby-formatter/rufo/subscription","commits_url":"https://api.github.com/repos/ruby-formatter/rufo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby-formatter/rufo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby-formatter/rufo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby-formatter/rufo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruby-formatter/rufo/contents/{+path}","compare_url":"https://api.github.com/repos/ruby-formatter/rufo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby-formatter/rufo/merges","archive_url":"https://api.github.com/repos/ruby-formatter/rufo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby-formatter/rufo/downloads","issues_url":"https://api.github.com/repos/ruby-formatter/rufo/issues{/number}","pulls_url":"https://api.github.com/repos/ruby-formatter/rufo/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby-formatter/rufo/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby-formatter/rufo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby-formatter/rufo/labels{/name}","releases_url":"https://api.github.com/repos/ruby-formatter/rufo/releases{/id}","deployments_url":"https://api.github.com/repos/ruby-formatter/rufo/deployments","created_at":"2017-07-14T09:02:45Z","updated_at":"2017-10-11T22:19:35Z","pushed_at":"2017-10-14T02:17:06Z","git_url":"git://github.com/ruby-formatter/rufo.git","ssh_url":"[email protected]:ruby-formatter/rufo.git","clone_url":"https://github.com/ruby-formatter/rufo.git","svn_url":"https://github.com/ruby-formatter/rufo","homepage":"","size":439,"stargazers_count":64,"watchers_count":64,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":6,"forks":10,"open_issues":6,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby-formatter/rufo/pulls/33"},"html":{"href":"https://github.com/ruby-formatter/rufo/pull/33"},"issue":{"href":"https://api.github.com/repos/ruby-formatter/rufo/issues/33"},"comments":{"href":"https://api.github.com/repos/ruby-formatter/rufo/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby-formatter/rufo/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby-formatter/rufo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruby-formatter/rufo/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/ruby-formatter/rufo/statuses/e827316101cbe76d5a67fa8e457a12b4eedfe428"}},"author_association":"OWNER"}} | {
"id": 97214803,
"name": "ruby-formatter/rufo",
"url": "https://api.github.com/repos/ruby-formatter/rufo"
} | {
"id": 708200,
"login": "bessey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/708200?",
"url": "https://api.github.com/users/bessey"
} | {
"id": 30173546,
"login": "ruby-formatter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30173546?",
"url": "https://api.github.com/orgs/ruby-formatter"
} | 2017-10-14T20:15:15 | 6717360281 | {"actor":{"display_login":"bessey"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/comments/133837597","pull_request_review_id":57065180,"id":133837597,"diff_hunk":"@@ -1,4 +1,24 @@\n import Ember from 'ember';\n \n export default Ember.Component.extend({\n+ session: Ember.inject.service(),\n+ removePipelineError: null,\n+ actions: {\n+ /**\n+ * Action to remove a pipeline from a collection\n+ *\n+ * @param {Number} pipelineId - id of pipeline to remove\n+ * @param {Number} collectionId - id of collection to remove from\n+ * @returns {Promise}\n+ */\n+ pipelineRemove(pipelineId, collectionId) {\n+ return this.get('onPipelineRemove')(+pipelineId, collectionId)\n+ .then(() => {\n+ this.set('removePipelineError', null);\n+ })\n+ .catch(() => {\n+ this.set('removePipelineError', 'User does not have permission');","path":"app/components/collection-view/component.js","position":20,"original_position":20,"commit_id":"c696bde0aab0b85321a77ba31d2133a2424c51eb","original_commit_id":"c696bde0aab0b85321a77ba31d2133a2424c51eb","user":{"login":"joelseq","id":12389411,"avatar_url":"https://avatars0.githubusercontent.com/u/12389411?v=4","gravatar_id":"","url":"https://api.github.com/users/joelseq","html_url":"https://github.com/joelseq","followers_url":"https://api.github.com/users/joelseq/followers","following_url":"https://api.github.com/users/joelseq/following{/other_user}","gists_url":"https://api.github.com/users/joelseq/gists{/gist_id}","starred_url":"https://api.github.com/users/joelseq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelseq/subscriptions","organizations_url":"https://api.github.com/users/joelseq/orgs","repos_url":"https://api.github.com/users/joelseq/repos","events_url":"https://api.github.com/users/joelseq/events{/privacy}","received_events_url":"https://api.github.com/users/joelseq/received_events","type":"User","site_admin":false},"body":"I'll change it to handle cases for API errors too","created_at":"2017-08-17T21:47:29Z","updated_at":"2017-08-17T21:47:29Z","html_url":"https://github.com/screwdriver-cd/ui/pull/203#discussion_r133837597","pull_request_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/comments/133837597"},"html":{"href":"https://github.com/screwdriver-cd/ui/pull/203#discussion_r133837597"},"pull_request":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/203","id":136354317,"html_url":"https://github.com/screwdriver-cd/ui/pull/203","diff_url":"https://github.com/screwdriver-cd/ui/pull/203.diff","patch_url":"https://github.com/screwdriver-cd/ui/pull/203.patch","issue_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/203","number":203,"state":"open","locked":false,"title":"feat(collections): Add remove pipeline functionality","user":{"login":"joelseq","id":12389411,"avatar_url":"https://avatars0.githubusercontent.com/u/12389411?v=4","gravatar_id":"","url":"https://api.github.com/users/joelseq","html_url":"https://github.com/joelseq","followers_url":"https://api.github.com/users/joelseq/followers","following_url":"https://api.github.com/users/joelseq/following{/other_user}","gists_url":"https://api.github.com/users/joelseq/gists{/gist_id}","starred_url":"https://api.github.com/users/joelseq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelseq/subscriptions","organizations_url":"https://api.github.com/users/joelseq/orgs","repos_url":"https://api.github.com/users/joelseq/repos","events_url":"https://api.github.com/users/joelseq/events{/privacy}","received_events_url":"https://api.github.com/users/joelseq/received_events","type":"User","site_admin":false},"body":"Example:\r\n\r\n","created_at":"2017-08-17T21:10:10Z","updated_at":"2017-08-17T21:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9788b3b420705f318b47ec8211ab23090d207dee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"minz1027","id":20427140,"avatar_url":"https://avatars0.githubusercontent.com/u/20427140?v=4","gravatar_id":"","url":"https://api.github.com/users/minz1027","html_url":"https://github.com/minz1027","followers_url":"https://api.github.com/users/minz1027/followers","following_url":"https://api.github.com/users/minz1027/following{/other_user}","gists_url":"https://api.github.com/users/minz1027/gists{/gist_id}","starred_url":"https://api.github.com/users/minz1027/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minz1027/subscriptions","organizations_url":"https://api.github.com/users/minz1027/orgs","repos_url":"https://api.github.com/users/minz1027/repos","events_url":"https://api.github.com/users/minz1027/events{/privacy}","received_events_url":"https://api.github.com/users/minz1027/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/203/commits","review_comments_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/203/comments","review_comment_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/203/comments","statuses_url":"https://api.github.com/repos/screwdriver-cd/ui/statuses/c696bde0aab0b85321a77ba31d2133a2424c51eb","head":{"label":"screwdriver-cd:delete-collections-pipelines","ref":"delete-collections-pipelines","sha":"c696bde0aab0b85321a77ba31d2133a2424c51eb","user":{"login":"screwdriver-cd","id":19417863,"avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":64884594,"name":"ui","full_name":"screwdriver-cd/ui","owner":{"login":"screwdriver-cd","id":19417863,"avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/screwdriver-cd/ui","description":"Screwdriver UI","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/ui","forks_url":"https://api.github.com/repos/screwdriver-cd/ui/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/ui/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/ui/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/ui/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/ui/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/ui/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/ui/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/ui/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/ui/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/ui/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/ui/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/ui/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/ui/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/ui/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/ui/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/ui/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/ui/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/ui/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/ui/deployments","created_at":"2016-08-03T22:48:11Z","updated_at":"2017-08-13T07:48:20Z","pushed_at":"2017-08-17T21:10:11Z","git_url":"git://github.com/screwdriver-cd/ui.git","ssh_url":"[email protected]:screwdriver-cd/ui.git","clone_url":"https://github.com/screwdriver-cd/ui.git","svn_url":"https://github.com/screwdriver-cd/ui","homepage":"https://cd.screwdriver.cd/pipelines/7","size":2493,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"screwdriver-cd:master","ref":"master","sha":"49c5fd307f3256d4f84d02d2dbcd1daa826dee5b","user":{"login":"screwdriver-cd","id":19417863,"avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":64884594,"name":"ui","full_name":"screwdriver-cd/ui","owner":{"login":"screwdriver-cd","id":19417863,"avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/screwdriver-cd/ui","description":"Screwdriver UI","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/ui","forks_url":"https://api.github.com/repos/screwdriver-cd/ui/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/ui/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/ui/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/ui/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/ui/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/ui/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/ui/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/ui/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/ui/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/ui/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/ui/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/ui/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/ui/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/ui/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/ui/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/ui/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/ui/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/ui/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/ui/deployments","created_at":"2016-08-03T22:48:11Z","updated_at":"2017-08-13T07:48:20Z","pushed_at":"2017-08-17T21:10:11Z","git_url":"git://github.com/screwdriver-cd/ui.git","ssh_url":"[email protected]:screwdriver-cd/ui.git","clone_url":"https://github.com/screwdriver-cd/ui.git","svn_url":"https://github.com/screwdriver-cd/ui","homepage":"https://cd.screwdriver.cd/pipelines/7","size":2493,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/203"},"html":{"href":"https://github.com/screwdriver-cd/ui/pull/203"},"issue":{"href":"https://api.github.com/repos/screwdriver-cd/ui/issues/203"},"comments":{"href":"https://api.github.com/repos/screwdriver-cd/ui/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/screwdriver-cd/ui/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/screwdriver-cd/ui/statuses/c696bde0aab0b85321a77ba31d2133a2424c51eb"}}}} | {
"id": 64884594,
"name": "screwdriver-cd/ui",
"url": "https://api.github.com/repos/screwdriver-cd/ui"
} | {
"id": 12389411,
"login": "joelseq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12389411?",
"url": "https://api.github.com/users/joelseq"
} | {
"id": 19417863,
"login": "screwdriver-cd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19417863?",
"url": "https://api.github.com/orgs/screwdriver-cd"
} | 2017-08-17T21:47:29 | 6476036487 | {"actor":{"display_login":"joelseq"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tango-controls/cppTango/pulls/comments/130087792","pull_request_review_id":52928140,"id":130087792,"diff_hunk":"@@ -0,0 +1,3273 @@\n+//\n+// Created by ingvord on 10/24/16.\n+//\n+\n+#include <tango.h>\n+#include <tango/client/eventconsumer.h>\n+#include \"event_consumer.tpp\"\n+\n+omni_mutex Tango::EventConsumer::ev_consumer_inst_mutex;\n+\n+Tango::EventConsumerKeepAliveThread *Tango::EventConsumer::keep_alive_thread = NULL;\n+map<std::string,std::string> Tango::EventConsumer::device_channel_map;\n+map<std::string,Tango::EventChannelStruct> Tango::EventConsumer::channel_map;\n+map<std::string,Tango::EventCallBackStruct> Tango::EventConsumer::event_callback_map;\n+ReadersWritersLock \tTango::EventConsumer::map_modification_lock;\n+\n+vector<Tango::EventNotConnected> Tango::EventConsumer::event_not_connected;\n+int Tango::EventConsumer::subscribe_event_id = 0;\n+vector<string> Tango::EventConsumer::env_var_fqdn_prefix;\n+map<string,string> Tango::EventConsumer::alias_map;\n+\n+Tango::KeepAliveThCmd Tango::EventConsumer::cmd;\n+\n+//+--------------------------------------------------------------------------------------------------------------------\n+//\n+// method :\n+//\t\tEventConsumer::add_new_callback()\n+//\n+// description :\n+//\t\tAdd a new callback to an already existing event entry in the callback map\n+//\n+// argument :\n+//\t\tin :\n+//\t\t\t- iter : Iterator in the callback map\n+//\t\t\t- callback : Pointer to the Callback object\n+//\t\t\t- ev_queue : Pointer to the event queue\n+//\t\t\t- event_id : The event identifier\n+//\n+//--------------------------------------------------------------------------------------------------------------------\n+\n+int Tango::EventConsumer::add_new_callback(EvCbIte &iter, CallBack *callback, EventQueue *ev_queue, int event_id) {\n+ EventSubscribeStruct ess;\n+ int ret_event_id = event_id;\n+\n+ if (ret_event_id <= 0) {\n+ subscribe_event_id++;\n+ ret_event_id = subscribe_event_id;\n+ }\n+\n+ ess.id = ret_event_id;\n+ ess.callback = callback;\n+ ess.ev_queue = ev_queue;\n+\n+ iter->second.callback_list.push_back(ess);\n+\n+ return ret_event_id;\n+}\n+\n+\n+//+------------------------------------------------------------------------------------------------------------------\n+//\n+// method :\n+//\t\tEventConsumer::get_fire_sync_event()\n+//\n+// description :\n+//\t\tGet event data and fire a synchronous event\n+//\n+// argument :\n+//\t\tin :\n+//\t\t\t- device : The device pointer\n+//\t\t\t- callback : The callback pointer\n+//\t\t\t- ev_queue : The event queue\n+//\t\t\t- event : The event type\n+//\t\t\t- event_name : The event name\n+//\t\t\t- obj_name : The attribute/pipe name\n+//\t\t\t- cb :\n+//\t\t\t- callback_key :\n+//\n+//-------------------------------------------------------------------------------------------------------------------\n+\n+void Tango::EventConsumer::get_fire_sync_event(DeviceProxy *device, CallBack *callback, EventQueue *ev_queue,\n+ EventType event,\n+ string &event_name, const string &obj_name, EventCallBackStruct &cb,\n+ string &callback_key) {\n+\n+//\n+// A small 10 mS sleep here! This is required in case there is a push_event in the read_attribute (or pipe)\n+// method on the device side. This sleep gives time to ZMQ to send its subscription message\n+//\n+\n+#ifndef _TG_WINDOWS_\n+ struct timespec to_wait, inter;\n+ to_wait.tv_sec = 0;\n+ to_wait.tv_nsec = 10000000;\n+\n+ nanosleep(&to_wait, &inter);\n+#else\n+ Sleep(25);\n+#endif\n+\n+ if ((event == CHANGE_EVENT) ||\n+ (event == QUALITY_EVENT) ||\n+ (event == ARCHIVE_EVENT) ||\n+ (event == USER_EVENT) ||\n+ (event == PERIODIC_EVENT)) {\n+ DevErrorList err;\n+ err.length(0);\n+\n+ string domain_name;\n+ string::size_type pos;\n+\n+ if ((pos = device_name.find(MODIFIER_DBASE_NO)) != string::npos) {\n+ domain_name = device_name;\n+ string tmp = '/' + obj_name_lower;\n+ domain_name.insert(pos, tmp);\n+ } else\n+ domain_name = device_name + '/' + obj_name_lower;\n+\n+ AttributeValue_5 *av_5 = Tango_nullptr;\n+ DeviceAttribute *da = Tango_nullptr;\n+ FwdEventData *event_data;\n+\n+ try {\n+ if (cb.fwd_att == true) {\n+ device->read_attribute(obj_name.c_str(), av_5);\n+ if (av_5->err_list.length() != 0) {\n+ err = av_5->err_list;\n+ err.length(err.length() - 1);\n+ }\n+ } else {\n+ da = new DeviceAttribute();\n+ *da = device->read_attribute(obj_name.c_str());\n+ if (da->has_failed() == true) {\n+ err = da->get_err_stack();\n+ err.length(err.length() - 1);\n+ }\n+ }\n+ }\n+ catch (DevFailed &e) {\n+ err = e.errors;\n+ }\n+\n+ string local_event_name = event_name;\n+ pos = local_event_name.find(EVENT_COMPAT);\n+ if (pos != string::npos)\n+ local_event_name.erase(0, EVENT_COMPAT_IDL5_SIZE);\n+\n+ if (cb.fwd_att == true) {\n+ da = new DeviceAttribute();\n+ event_data = new FwdEventData(device, domain_name, local_event_name, da, err);\n+ event_data->set_av_5(av_5);\n+ } else {\n+ event_data = new FwdEventData(device, domain_name, local_event_name, da, err);\n+ }\n+\n+ AutoTangoMonitor _mon(cb.callback_monitor);\n+\n+//\n+// If a callback method was specified, call it!\n+//\n+\n+ if (callback != NULL) {\n+ try {\n+ callback->push_event(event_data);\n+ }\n+ catch (...) {\n+ cerr << \"EventConsumer::subscribe_event() exception in callback method of \" << callback_key << endl;\n+ }\n+\n+ delete event_data;\n+ if (cb.fwd_att == true)\n+ delete[] av_5;\n+ }\n+\n+//\n+// No calback method, the event has to be inserted into the event queue\n+//\n+\n+ else {\n+ ev_queue->insert_event(event_data);\n+ }\n+ } else if (event == ATTR_CONF_EVENT) {\n+ DevErrorList err;\n+ err.length(0);\n+ string domain_name = device_name + \"/\" + obj_name_lower;\n+ AttributeInfoEx *aie = NULL;\n+\n+ string local_event_name = event_name;\n+ string::size_type pos = local_event_name.find(EVENT_COMPAT);\n+ if (pos != string::npos)\n+ local_event_name.erase(0, EVENT_COMPAT_IDL5_SIZE);\n+\n+ try {\n+ aie = new AttributeInfoEx();\n+ *aie = device->get_attribute_config(const_cast<string &>(obj_name));\n+ }\n+ catch (DevFailed &e) {\n+ err = e.errors;\n+ }\n+\n+ FwdAttrConfEventData *event_data = new FwdAttrConfEventData(device,\n+ domain_name,\n+ local_event_name,\n+ aie,\n+ err);\n+ AutoTangoMonitor _mon(cb.callback_monitor);\n+\n+//\n+// If a callback method was specified, call it!\n+//\n+\n+ if (callback != NULL) {\n+ try {\n+ callback->push_event(event_data);\n+ }\n+ catch (...) {\n+ cerr << \"EventConsumer::subscribe_event() exception in callback method of \" << callback_key << endl;\n+ }\n+ delete event_data;\n+ }\n+\n+//\n+// No calback method, the event has to be inserted into the event queue\n+//\n+\n+ else {\n+ ev_queue->insert_event(event_data);\n+ }\n+ } else if (event == INTERFACE_CHANGE_EVENT) {\n+ DevErrorList err;\n+ err.length(0);\n+ CommandInfoList *c_list = Tango_nullptr;\n+ AttributeInfoListEx *a_list = Tango_nullptr;\n+ string ev_name(EventName[INTERFACE_CHANGE_EVENT]);\n+\n+ try {\n+ c_list = device->command_list_query();\n+ a_list = device->attribute_list_query_ex();\n+ }\n+ catch (DevFailed &e) {\n+ delete c_list;\n+ c_list = Tango_nullptr;\n+ delete a_list;\n+ a_list = Tango_nullptr;\n+\n+ err = e.errors;\n+ }\n+\n+ DevIntrChangeEventData *event_data = new DevIntrChangeEventData(device,\n+ ev_name, device_name,\n+ c_list, a_list, true,\n+ err);\n+\n+ AutoTangoMonitor _mon(cb.callback_monitor);\n+\n+//\n+// if a callback method was specified, call it!\n+//\n+\n+ if (callback != NULL) {\n+ try {\n+ callback->push_event(event_data);\n+ }\n+ catch (...) {\n+ cerr << \"EventConsumer::subscribe_event() exception in callback method of \" << callback_key << endl;\n+ }\n+\n+ delete event_data;\n+ delete c_list;\n+ delete a_list;\n+ }\n+\n+//\n+// No calback method, the event has to be instered into the event queue\n+//\n+\n+ else {\n+ ev_queue->insert_event(event_data);\n+ }\n+ } else if (event == PIPE_EVENT) {\n+ DevErrorList err;\n+ err.length(0);\n+\n+ string domain_name;\n+ string::size_type pos;\n+\n+ if ((pos = device_name.find(MODIFIER_DBASE_NO)) != string::npos) {\n+ domain_name = device_name;\n+ string tmp = '/' + obj_name_lower;\n+ domain_name.insert(pos, tmp);\n+ } else\n+ domain_name = device_name + '/' + obj_name_lower;\n+\n+ DevicePipe *da = Tango_nullptr;\n+ PipeEventData *event_data;\n+\n+ try {\n+ da = new DevicePipe();\n+ *da = device->read_pipe(obj_name);\n+ }\n+ catch (DevFailed &e) {\n+ err = e.errors;\n+ }\n+\n+ event_data = new PipeEventData(device, domain_name, event_name, da, err);\n+\n+ AutoTangoMonitor _mon(cb.callback_monitor);\n+\n+//\n+// If a callback method was specified, call it!\n+//\n+\n+ if (callback != NULL) {\n+ try {\n+ callback->push_event(event_data);\n+ }\n+ catch (...) {\n+ cerr << \"EventConsumer::subscribe_event() exception in callback method of \" << callback_key << endl;\n+ }\n+\n+ delete event_data;\n+ }\n+\n+//\n+// No calback method, the event has to be inserted into the event queue\n+//\n+\n+ else {\n+ ev_queue->insert_event(event_data);\n+ }\n+ }\n+}\n+\n+//+--------------------------------------------------------------------------------------------------------------------\n+//\n+// method :\n+//\t\tEventConsumer::EventConsumer\n+//\n+// description :\n+//\t\tConstructor for the EventConsumer class\n+//\n+//--------------------------------------------------------------------------------------------------------------------\n+\n+Tango::EventConsumer::EventConsumer(ApiUtil *api_ptr)\n+{\n+\n+//\n+// Build and store the fqdn prefix for devices in the TANGO_HOST environment variable (in lower case letters)\n+//\n+\n+ if (env_var_fqdn_prefix.empty() == true)\n+ {\n+ try\n+ {\n+ Database *db = (api_ptr->get_db_vect())[api_ptr->get_db_ind()];\n+ string prefix = \"tango://\" + db->get_db_host() + ':' + db->get_db_port() + '/' ;\n+ env_var_fqdn_prefix.push_back(prefix);\n+\n+ if (db->is_multi_tango_host() == true)\n+ {\n+ vector<string> &tango_hosts = db->get_multi_host();\n+ vector<string> &tango_ports = db->get_multi_port();\n+ for (unsigned int i = 1;i < tango_hosts.size();i++)\n+ {\n+ string prefix = \"tango://\" + tango_hosts[i] + ':' + tango_ports[i] + '/' ;\n+ env_var_fqdn_prefix.push_back(prefix);\n+ }\n+ }\n+\n+ for (size_t loop = 0;loop < env_var_fqdn_prefix.size();++loop)\n+ transform(env_var_fqdn_prefix[loop].begin(),env_var_fqdn_prefix[loop].end(),env_var_fqdn_prefix[loop].begin(),::tolower);\n+\n+//\n+// Also get Db server defined in DB but not in the user TANGO_HOST env. variable\n+//\n+\n+ get_cs_tango_host(db);\n+ }\n+ catch (Tango::DevFailed &)\n+ {\n+ env_var_fqdn_prefix.push_back(TangoHostNotSet);\n+ }\n+ }\n+\n+//\n+// initialise the unique event id for the client;\n+//\n+\n+ if (keep_alive_thread == NULL)\n+ subscribe_event_id = 0;\n+\n+//\n+// Install a function to be executed at exit. This is the only way I found to properly shutdown and destroy the ORB.\n+// Don't do this for windows DLL.\n+//\n+// Is this necessary when events are used within a server ?\n+//\n+\n+#ifndef _USRDLL\n+ if ((api_ptr->in_server() == false) && (api_ptr->is_lock_exit_installed() == false))\n+ {\n+ atexit(leavefunc);\n+ api_ptr->set_sig_handler();\n+ api_ptr->set_lock_exit_installed(true);\n+ }\n+#endif\n+\n+//\n+// Miscellaneous init\n+//\n+\n+ cmd.cmd_pending = false;\n+ if (keep_alive_thread == NULL)\n+ api_ptr->need_reset_already_flag(true);\n+\n+ thread_id = 0;\n+\n+//\n+// Create and start the EventConsumerKeepAliveThread. Do this at the method's end because the keep_alive_thread\n+// ptr is also used as a \"init done\" flag.\n+//\n+\n+ if (keep_alive_thread == NULL)\n+ {\n+ keep_alive_thread = new EventConsumerKeepAliveThread(cmd);\n+ keep_alive_thread->start();\n+ }\n+\n+}\n+\n+\n+//+--------------------------------------------------------------------------------------------------------------------\n+//\n+// method :\n+//\t\tEventConsumer::get_cs_tango_host()\n+//\n+// description :\n+//\t\tGet from a Tango control system which TANGO_HOST are available. This info comes from the Tango CS database\n+//\n+// argument :\n+//\t\tin :\n+//\t\t\t- db : Control system database pointer\n+//\n+//--------------------------------------------------------------------------------------------------------------------\n+\n+void Tango::EventConsumer::get_cs_tango_host(Database *db)\n+{\n+ try\n+ {\n+ DeviceData dd;\n+ dd = db->command_inout(\"DbGetCSDbServerList\");\n+ vector<string> vs;\n+ dd >> vs;\n+\n+//\n+// Do we have a CS with a host alias used as TANGO_HOST?\n+// It true and if we don't know this alias, store its definition in the alias map\n+//\n+\n+ if (vs.size() == 1)\n+ {\n+ string lower_vs(vs[0]);\n+ transform(lower_vs.begin(),lower_vs.end(),lower_vs.begin(),::tolower);\n+ string::size_type pos = lower_vs.find(':');\n+ if (pos != string::npos)\n+ lower_vs.erase(pos);\n+\n+ string tg_host(db->get_orig_tango_host());\n+ transform(tg_host.begin(),tg_host.end(),tg_host.begin(),::tolower);\n+\n+ if (tg_host.empty() == false && lower_vs != tg_host)\n+ {\n+ if (alias_map.find(tg_host) == alias_map.end())\n+ {\n+#ifdef INIT_LIST\n+ alias_map.insert({lower_vs,tg_host});\n+#else\n+ alias_map.insert(make_pair(lower_vs,tg_host));\n+#endif\n+ }\n+ }\n+ }\n+\n+//\n+// Serveral Db servers for one TANGO_HOST case\n+//\n+\n+ vector<string>::iterator pos;\n+\n+ for (unsigned int i = 0;i < vs.size();i++)\n+ {\n+ transform(vs[i].begin(),vs[i].end(),vs[i].begin(),::tolower);\n+#ifdef HAS_LAMBDA_FUNC\n+ pos = find_if(env_var_fqdn_prefix.begin(),env_var_fqdn_prefix.end(),\n+ [&] (string str) -> bool\n+ {\n+ if (str.find(vs[i]) != string::npos)\n+ return true;\n+ else\n+ return false;\n+ });\n+\n+ if (pos == env_var_fqdn_prefix.end())\n+ {\n+ string prefix = \"tango://\" + vs[i] + '/' ;\n+ env_var_fqdn_prefix.push_back(prefix);\n+ }\n+#else\n+ unsigned int j;\n+\t\t\tfor (j = 0;j < env_var_fqdn_prefix.size();++j)\n+\t\t\t{\n+\t\t\t\tif (env_var_fqdn_prefix[j].find(vs[i]) != string::npos)\n+\t\t\t\t{\n+\t\t\t\t\tbreak;\n+\t\t\t\t}\n+\t\t\t}\n+\n+\t\t\tif (j == env_var_fqdn_prefix.size())\n+\t\t\t{\n+\t\t\t\tstring prefix = \"tango://\" + vs[i] + '/';\n+\t\t\t\tenv_var_fqdn_prefix.push_back(prefix);\n+\t\t\t}\n+#endif\n+ }\n+ }\n+ catch(...) {}\n+}\n+\n+\n+//+--------------------------------------------------------------------------------------------------------------------\n+//\n+// method :\n+//\t\tEventConsumer::shutdown()\n+//\n+// description :\n+//\t\tMethod to stop the keep alive thread and to disconnect from all used event channels\n+//\n+//--------------------------------------------------------------------------------------------------------------------\n+void Tango::EventConsumer::shutdown()\n+{\n+ cout3 << \"calling Tango::EventConsumer::shutdown() \\n\";\n+\n+//\n+// First, shutdown the keep alive thread\n+//\n+\n+ shutdown_keep_alive_thread();\n+\n+//\n+// cleanup map containers\n+//\n+\n+ cleanup_EventChannel_map();\n+}\n+\n+\n+//+----------------------------------------------------------------------------\n+//\n+// method : \t\tEventConsumer::shutdown_keep_alive_thread()\n+//\n+// description : \tAsk the KeepAliveThread to suicide and wait for this to\n+// happen\n+//\n+//-----------------------------------------------------------------------------\n+\n+void Tango::EventConsumer::shutdown_keep_alive_thread()\n+{\n+//\n+// Shut-down the KeepAliveThread and wait for it to exit\n+//\n+\n+ if (keep_alive_thread != NULL)\n+ {\n+ {\n+ omni_mutex_lock sync(cmd);\n+\n+ cmd.cmd_pending = true;\n+ cmd.cmd_code = EXIT_TH;\n+\n+ cmd.cond.signal();\n+ }\n+\n+ int *rv;\n+ keep_alive_thread->join((void **)&rv);\n+\n+ keep_alive_thread = NULL;\n+ }\n+}\n+\n+\n+//+------------------------------------------------------------------------------------------------------------------\n+//\n+// method :\n+//\t\tEventConsumer::connect()\n+//\n+// description :\n+//\t\tThis method is a wrapper around the connection to the event channel (heartbeat event)\n+//\n+// argument :\n+//\t\tin :\n+//\t\t\t- device_proxy : The device handle\n+// - d_name : The FQDN (lower case)\n+// - dd : The server command result (Used by ZMQ event system only)\n+// - adm_name : The admin device name\n+//\t\t\t- necm :\n+//\n+//------------------------------------------------------------------------------------------------------------------\n+\n+void Tango::EventConsumer::connect(DeviceProxy *device_proxy,string &d_name,DeviceData &dd,string &adm_name,bool &necm)\n+{\n+ string channel_name = adm_name;\n+ if (device_proxy->get_from_env_var() == true)\n+ {\n+ channel_name.insert(0,env_var_fqdn_prefix[0]);\n+ }\n+\n+//\n+// If no connection exists to this channel then connect to it. Sometimes, this method is called in order to reconnect\n+// to the notifd. In such a case, the lock is already locked before the method is called\n+//\n+\n+ std::map<std::string,EventChannelStruct>::iterator ipos = channel_map.find(channel_name);\n+ if (ipos == channel_map.end())\n+ {\n+ connect_event_channel(channel_name,device_proxy->get_device_db(),false,dd);\n+ }\n+\n+\n+ if (device_proxy->get_from_env_var() == true)\n+ {\n+ adm_name.insert(0,env_var_fqdn_prefix[0]);\n+ }\n+\n+//\n+// Init adm device name in channel map entry\n+//\n+\n+ if (ipos == channel_map.end())\n+ {\n+ channel_map[channel_name].full_adm_name = adm_name;\n+ necm = true;\n+ }\n+\n+//\n+// Add entry in device_channel_map map\n+//\n+\n+ device_channel_map[d_name] = channel_name;\n+}\n+\n+\n+//+-----------------------------------------------------------------------------------------------------------------\n+//\n+// method :\n+//\t\tEventConsumer::attr_to_device()\n+//\n+// description :\n+//\t\tMethod to initialize in the DeviceAttribute instance given to the user the attribute value which are received\n+// in a AttrValUnion (or in a class inheriting from)\n+//\n+// argument :\n+//\t\tin :\n+//\t\t\t- attr_value :\n+//\t\t\t- attr_value_3 :\n+//\t\t\t- vers :\n+//\t\tout :\n+//\t\t\t- dev_attr :\n+//\n+//-------------------------------------------------------------------------------------------------------------------\n+\n+void Tango::EventConsumer::attr_to_device(const AttributeValue *attr_value,\n+ const AttributeValue_3 *attr_value_3,\n+ long vers,DeviceAttribute *dev_attr)\n+{\n+ const DevVarLongArray *tmp_seq_lo;\n+ DevLong *tmp_lo;\n+ const DevVarLong64Array *tmp_seq_64;\n+ DevLong64 *tmp_64;\n+ const DevVarShortArray *tmp_seq_sh;\n+ DevShort *tmp_sh;\n+ const DevVarDoubleArray *tmp_seq_db;\n+ DevDouble *tmp_db;\n+ const DevVarStringArray *tmp_seq_str;\n+ char **tmp_str;\n+ const DevVarFloatArray *tmp_seq_fl;\n+ DevFloat *tmp_fl;\n+ const DevVarBooleanArray *tmp_seq_boo;\n+ DevBoolean *tmp_boo;\n+ const DevVarUShortArray *tmp_seq_ush;\n+ DevUShort *tmp_ush;\n+ const DevVarCharArray *tmp_seq_uch;\n+ DevUChar *tmp_uch;\n+ const DevVarULongArray *tmp_seq_ulo;\n+ DevULong *tmp_ulo;\n+ const DevVarULong64Array *tmp_seq_u64;\n+ DevULong64 *tmp_ulolo;\n+ const DevVarStateArray *tmp_seq_state;\n+ Tango::DevState *tmp_state;\n+\n+ DevULong max,len;\n+\n+ if (vers == 3)\n+ {\n+ dev_attr->name = attr_value_3->name;\n+ dev_attr->quality = attr_value_3->quality;\n+ dev_attr->time = attr_value_3->time;\n+ dev_attr->dim_x = attr_value_3->r_dim.dim_x;\n+ dev_attr->dim_y = attr_value_3->r_dim.dim_y;\n+ dev_attr->set_w_dim_x(attr_value_3->w_dim.dim_x);\n+ dev_attr->set_w_dim_y(attr_value_3->w_dim.dim_y);\n+ dev_attr->err_list = new DevErrorList(attr_value_3->err_list);\n+ }\n+ else\n+ {\n+ dev_attr->name = attr_value->name;\n+ dev_attr->quality = attr_value->quality;\n+ dev_attr->time = attr_value->time;\n+ dev_attr->dim_x = attr_value->dim_x;\n+ dev_attr->dim_y = attr_value->dim_y;\n+ }\n+\n+ if (dev_attr->quality != Tango::ATTR_INVALID)\n+ {\n+ CORBA::TypeCode_var ty;\n+ if (vers == 3)\n+ ty = attr_value_3->value.type();\n+ else\n+ ty = attr_value->value.type();\n+\n+ if (ty->kind() == CORBA::tk_enum)\n+ {\n+ attr_value_3->value >>= dev_attr->d_state;\n+ dev_attr->d_state_filled = true;\n+ }\n+ else\n+ {\n+ CORBA::TypeCode_var ty_alias = ty->content_type();\n+ CORBA::TypeCode_var ty_seq = ty_alias->content_type();\n+ switch (ty_seq->kind())\n+ {\n+ case CORBA::tk_long:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_lo;\n+ else\n+ attr_value->value >>= tmp_seq_lo;\n+ max = tmp_seq_lo->maximum();\n+ len = tmp_seq_lo->length();\n+ if (tmp_seq_lo->release() == true)\n+ {\n+ tmp_lo = (const_cast<DevVarLongArray *>(tmp_seq_lo))->get_buffer((DevBoolean)true);\n+ dev_attr->LongSeq = new DevVarLongArray(max,len,tmp_lo,true);\n+ }\n+ else\n+ {\n+ tmp_lo = const_cast<DevLong *>(tmp_seq_lo->get_buffer());\n+ dev_attr->LongSeq = new DevVarLongArray(max,len,tmp_lo,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_longlong:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_64;\n+ else\n+ attr_value->value >>= tmp_seq_64;\n+ max = tmp_seq_64->maximum();\n+ len = tmp_seq_64->length();\n+ if (tmp_seq_64->release() == true)\n+ {\n+ tmp_64 = (const_cast<DevVarLong64Array *>(tmp_seq_64))->get_buffer((DevBoolean)true);\n+ dev_attr->Long64Seq = new DevVarLong64Array(max,len,tmp_64,true);\n+ }\n+ else\n+ {\n+ tmp_64 = const_cast<DevLong64 *>(tmp_seq_64->get_buffer());\n+ dev_attr->Long64Seq = new DevVarLong64Array(max,len,tmp_64,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_short:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_sh;\n+ else\n+ attr_value->value >>= tmp_seq_sh;\n+ max = tmp_seq_sh->maximum();\n+ len = tmp_seq_sh->length();\n+ if (tmp_seq_sh->release() == true)\n+ {\n+ tmp_sh = (const_cast<DevVarShortArray *>(tmp_seq_sh))->get_buffer((DevBoolean)true);\n+ dev_attr->ShortSeq = new DevVarShortArray(max,len,tmp_sh,true);\n+ }\n+ else\n+ {\n+ tmp_sh = const_cast<DevShort *>(tmp_seq_sh->get_buffer());\n+ dev_attr->ShortSeq = new DevVarShortArray(max,len,tmp_sh,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_double:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_db;\n+ else\n+ attr_value->value >>= tmp_seq_db;\n+ max = tmp_seq_db->maximum();\n+ len = tmp_seq_db->length();\n+ if (tmp_seq_db->release() == true)\n+ {\n+ tmp_db = (const_cast<DevVarDoubleArray *>(tmp_seq_db))->get_buffer((DevBoolean)true);\n+ dev_attr->DoubleSeq = new DevVarDoubleArray(max,len,tmp_db,true);\n+ }\n+ else\n+ {\n+ tmp_db = const_cast<DevDouble *>(tmp_seq_db->get_buffer());\n+ dev_attr->DoubleSeq = new DevVarDoubleArray(max,len,tmp_db,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_string:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_str;\n+ else\n+ attr_value->value >>= tmp_seq_str;\n+ max = tmp_seq_str->maximum();\n+ len = tmp_seq_str->length();\n+ if (tmp_seq_str->release() == true)\n+ {\n+ tmp_str = (const_cast<DevVarStringArray *>(tmp_seq_str))->get_buffer((DevBoolean)true);\n+ dev_attr->StringSeq = new DevVarStringArray(max,len,tmp_str,true);\n+ }\n+ else\n+ {\n+ tmp_str = const_cast<char **>(tmp_seq_str->get_buffer());\n+ dev_attr->StringSeq = new DevVarStringArray(max,len,tmp_str,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_float:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_fl;\n+ else\n+ attr_value->value >>= tmp_seq_fl;\n+ max = tmp_seq_fl->maximum();\n+ len = tmp_seq_fl->length();\n+ if (tmp_seq_fl->release() == true)\n+ {\n+ tmp_fl = (const_cast<DevVarFloatArray *>(tmp_seq_fl))->get_buffer((DevBoolean)true);\n+ dev_attr->FloatSeq = new DevVarFloatArray(max,len,tmp_fl,true);\n+ }\n+ else\n+ {\n+ tmp_fl = const_cast<DevFloat *>(tmp_seq_fl->get_buffer());\n+ dev_attr->FloatSeq = new DevVarFloatArray(max,len,tmp_fl,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_boolean:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_boo;\n+ else\n+ attr_value->value >>= tmp_seq_boo;\n+ max = tmp_seq_boo->maximum();\n+ len = tmp_seq_boo->length();\n+ if (tmp_seq_boo->release() == true)\n+ {\n+ tmp_boo = (const_cast<DevVarBooleanArray *>(tmp_seq_boo))->get_buffer((DevBoolean)true);\n+ dev_attr->BooleanSeq = new DevVarBooleanArray(max,len,tmp_boo,true);\n+ }\n+ else\n+ {\n+ tmp_boo = const_cast<DevBoolean *>(tmp_seq_boo->get_buffer());\n+ dev_attr->BooleanSeq = new DevVarBooleanArray(max,len,tmp_boo,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_ushort:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_ush;\n+ else\n+ attr_value->value >>= tmp_seq_ush;\n+ max = tmp_seq_ush->maximum();\n+ len = tmp_seq_ush->length();\n+ if (tmp_seq_ush->release() == true)\n+ {\n+ tmp_ush = (const_cast<DevVarUShortArray *>(tmp_seq_ush))->get_buffer((DevBoolean)true);\n+ dev_attr->UShortSeq = new DevVarUShortArray(max,len,tmp_ush,true);\n+ }\n+ else\n+ {\n+ tmp_ush = const_cast<DevUShort *>(tmp_seq_ush->get_buffer());\n+ dev_attr->UShortSeq = new DevVarUShortArray(max,len,tmp_ush,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_octet:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_uch;\n+ else\n+ attr_value->value >>= tmp_seq_uch;\n+ max = tmp_seq_uch->maximum();\n+ len = tmp_seq_uch->length();\n+ if (tmp_seq_uch->release() == true)\n+ {\n+ tmp_uch = (const_cast<DevVarCharArray *>(tmp_seq_uch))->get_buffer((DevBoolean)true);\n+ dev_attr->UCharSeq = new DevVarCharArray(max,len,tmp_uch,true);\n+ }\n+ else\n+ {\n+ tmp_uch = const_cast<DevUChar *>(tmp_seq_uch->get_buffer());\n+ dev_attr->UCharSeq = new DevVarCharArray(max,len,tmp_uch,false);\n+ }\n+ break;\n+\n+ case CORBA::tk_ulong:\n+ if (vers == 3)\n+ attr_value_3->value >>= tmp_seq_ulo;","path":"src/client/event_consumer.cpp","position":914,"original_position":914,"commit_id":"e4efe942ff01136f7faf2cf6509dc70e98e78bdd","original_commit_id":"e4efe942ff01136f7faf2cf6509dc70e98e78bdd","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [full block {} expected in the control structure](https://www.codacy.com/app/tango-controls/cppTango/pullRequest?prid=675502)","created_at":"2017-07-28T13:22:59Z","updated_at":"2017-07-28T13:22:59Z","html_url":"https://github.com/tango-controls/cppTango/pull/295#discussion_r130087792","pull_request_url":"https://api.github.com/repos/tango-controls/cppTango/pulls/295","_links":{"self":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/comments/130087792"},"html":{"href":"https://github.com/tango-controls/cppTango/pull/295#discussion_r130087792"},"pull_request":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/tango-controls/cppTango/pulls/295","id":90617429,"html_url":"https://github.com/tango-controls/cppTango/pull/295","diff_url":"https://github.com/tango-controls/cppTango/pull/295.diff","patch_url":"https://github.com/tango-controls/cppTango/pull/295.patch","issue_url":"https://api.github.com/repos/tango-controls/cppTango/issues/295","number":295,"state":"open","locked":false,"title":"remove NotifdEvent","user":{"login":"Ingvord","id":11678364,"avatar_url":"https://avatars0.githubusercontent.com/u/11678364?v=4","gravatar_id":"","url":"https://api.github.com/users/Ingvord","html_url":"https://github.com/Ingvord","followers_url":"https://api.github.com/users/Ingvord/followers","following_url":"https://api.github.com/users/Ingvord/following{/other_user}","gists_url":"https://api.github.com/users/Ingvord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ingvord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ingvord/subscriptions","organizations_url":"https://api.github.com/users/Ingvord/orgs","repos_url":"https://api.github.com/users/Ingvord/repos","events_url":"https://api.github.com/users/Ingvord/events{/privacy}","received_events_url":"https://api.github.com/users/Ingvord/received_events","type":"User","site_admin":false},"body":"Progress: remove NotifdEventConsumer\n","created_at":"2016-10-24T13:58:37Z","updated_at":"2017-07-28T13:23:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"455234ad8a81afaca4e73b8692f1ea189a817d1b","assignee":{"login":"Ingvord","id":11678364,"avatar_url":"https://avatars0.githubusercontent.com/u/11678364?v=4","gravatar_id":"","url":"https://api.github.com/users/Ingvord","html_url":"https://github.com/Ingvord","followers_url":"https://api.github.com/users/Ingvord/followers","following_url":"https://api.github.com/users/Ingvord/following{/other_user}","gists_url":"https://api.github.com/users/Ingvord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ingvord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ingvord/subscriptions","organizations_url":"https://api.github.com/users/Ingvord/orgs","repos_url":"https://api.github.com/users/Ingvord/repos","events_url":"https://api.github.com/users/Ingvord/events{/privacy}","received_events_url":"https://api.github.com/users/Ingvord/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ingvord","id":11678364,"avatar_url":"https://avatars0.githubusercontent.com/u/11678364?v=4","gravatar_id":"","url":"https://api.github.com/users/Ingvord","html_url":"https://github.com/Ingvord","followers_url":"https://api.github.com/users/Ingvord/followers","following_url":"https://api.github.com/users/Ingvord/following{/other_user}","gists_url":"https://api.github.com/users/Ingvord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ingvord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ingvord/subscriptions","organizations_url":"https://api.github.com/users/Ingvord/orgs","repos_url":"https://api.github.com/users/Ingvord/repos","events_url":"https://api.github.com/users/Ingvord/events{/privacy}","received_events_url":"https://api.github.com/users/Ingvord/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tango-controls/cppTango/pulls/295/commits","review_comments_url":"https://api.github.com/repos/tango-controls/cppTango/pulls/295/comments","review_comment_url":"https://api.github.com/repos/tango-controls/cppTango/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tango-controls/cppTango/issues/295/comments","statuses_url":"https://api.github.com/repos/tango-controls/cppTango/statuses/e4efe942ff01136f7faf2cf6509dc70e98e78bdd","head":{"label":"Ingvord:refactoring-RemoveNotifd","ref":"refactoring-RemoveNotifd","sha":"e4efe942ff01136f7faf2cf6509dc70e98e78bdd","user":{"login":"Ingvord","id":11678364,"avatar_url":"https://avatars0.githubusercontent.com/u/11678364?v=4","gravatar_id":"","url":"https://api.github.com/users/Ingvord","html_url":"https://github.com/Ingvord","followers_url":"https://api.github.com/users/Ingvord/followers","following_url":"https://api.github.com/users/Ingvord/following{/other_user}","gists_url":"https://api.github.com/users/Ingvord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ingvord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ingvord/subscriptions","organizations_url":"https://api.github.com/users/Ingvord/orgs","repos_url":"https://api.github.com/users/Ingvord/repos","events_url":"https://api.github.com/users/Ingvord/events{/privacy}","received_events_url":"https://api.github.com/users/Ingvord/received_events","type":"User","site_admin":false},"repo":{"id":67682913,"name":"cppTango","full_name":"Ingvord/cppTango","owner":{"login":"Ingvord","id":11678364,"avatar_url":"https://avatars0.githubusercontent.com/u/11678364?v=4","gravatar_id":"","url":"https://api.github.com/users/Ingvord","html_url":"https://github.com/Ingvord","followers_url":"https://api.github.com/users/Ingvord/followers","following_url":"https://api.github.com/users/Ingvord/following{/other_user}","gists_url":"https://api.github.com/users/Ingvord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ingvord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ingvord/subscriptions","organizations_url":"https://api.github.com/users/Ingvord/orgs","repos_url":"https://api.github.com/users/Ingvord/repos","events_url":"https://api.github.com/users/Ingvord/events{/privacy}","received_events_url":"https://api.github.com/users/Ingvord/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ingvord/cppTango","description":null,"fork":true,"url":"https://api.github.com/repos/Ingvord/cppTango","forks_url":"https://api.github.com/repos/Ingvord/cppTango/forks","keys_url":"https://api.github.com/repos/Ingvord/cppTango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ingvord/cppTango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ingvord/cppTango/teams","hooks_url":"https://api.github.com/repos/Ingvord/cppTango/hooks","issue_events_url":"https://api.github.com/repos/Ingvord/cppTango/issues/events{/number}","events_url":"https://api.github.com/repos/Ingvord/cppTango/events","assignees_url":"https://api.github.com/repos/Ingvord/cppTango/assignees{/user}","branches_url":"https://api.github.com/repos/Ingvord/cppTango/branches{/branch}","tags_url":"https://api.github.com/repos/Ingvord/cppTango/tags","blobs_url":"https://api.github.com/repos/Ingvord/cppTango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ingvord/cppTango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ingvord/cppTango/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ingvord/cppTango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ingvord/cppTango/statuses/{sha}","languages_url":"https://api.github.com/repos/Ingvord/cppTango/languages","stargazers_url":"https://api.github.com/repos/Ingvord/cppTango/stargazers","contributors_url":"https://api.github.com/repos/Ingvord/cppTango/contributors","subscribers_url":"https://api.github.com/repos/Ingvord/cppTango/subscribers","subscription_url":"https://api.github.com/repos/Ingvord/cppTango/subscription","commits_url":"https://api.github.com/repos/Ingvord/cppTango/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ingvord/cppTango/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ingvord/cppTango/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ingvord/cppTango/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ingvord/cppTango/contents/{+path}","compare_url":"https://api.github.com/repos/Ingvord/cppTango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ingvord/cppTango/merges","archive_url":"https://api.github.com/repos/Ingvord/cppTango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ingvord/cppTango/downloads","issues_url":"https://api.github.com/repos/Ingvord/cppTango/issues{/number}","pulls_url":"https://api.github.com/repos/Ingvord/cppTango/pulls{/number}","milestones_url":"https://api.github.com/repos/Ingvord/cppTango/milestones{/number}","notifications_url":"https://api.github.com/repos/Ingvord/cppTango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ingvord/cppTango/labels{/name}","releases_url":"https://api.github.com/repos/Ingvord/cppTango/releases{/id}","deployments_url":"https://api.github.com/repos/Ingvord/cppTango/deployments","created_at":"2016-09-08T08:13:34Z","updated_at":"2016-10-24T10:28:23Z","pushed_at":"2017-07-28T13:20:11Z","git_url":"git://github.com/Ingvord/cppTango.git","ssh_url":"[email protected]:Ingvord/cppTango.git","clone_url":"https://github.com/Ingvord/cppTango.git","svn_url":"https://github.com/Ingvord/cppTango","homepage":"https://tango-controls.github.io/cppTango","size":8216,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tango-controls:master","ref":"master","sha":"d510b59551dcbd60edce415a43cffe01f81481a3","user":{"login":"tango-controls","id":15830606,"avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":67682672,"name":"cppTango","full_name":"tango-controls/cppTango","owner":{"login":"tango-controls","id":15830606,"avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tango-controls/cppTango","description":"TANGO kernel c++ implementation","fork":false,"url":"https://api.github.com/repos/tango-controls/cppTango","forks_url":"https://api.github.com/repos/tango-controls/cppTango/forks","keys_url":"https://api.github.com/repos/tango-controls/cppTango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tango-controls/cppTango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tango-controls/cppTango/teams","hooks_url":"https://api.github.com/repos/tango-controls/cppTango/hooks","issue_events_url":"https://api.github.com/repos/tango-controls/cppTango/issues/events{/number}","events_url":"https://api.github.com/repos/tango-controls/cppTango/events","assignees_url":"https://api.github.com/repos/tango-controls/cppTango/assignees{/user}","branches_url":"https://api.github.com/repos/tango-controls/cppTango/branches{/branch}","tags_url":"https://api.github.com/repos/tango-controls/cppTango/tags","blobs_url":"https://api.github.com/repos/tango-controls/cppTango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tango-controls/cppTango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tango-controls/cppTango/git/refs{/sha}","trees_url":"https://api.github.com/repos/tango-controls/cppTango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tango-controls/cppTango/statuses/{sha}","languages_url":"https://api.github.com/repos/tango-controls/cppTango/languages","stargazers_url":"https://api.github.com/repos/tango-controls/cppTango/stargazers","contributors_url":"https://api.github.com/repos/tango-controls/cppTango/contributors","subscribers_url":"https://api.github.com/repos/tango-controls/cppTango/subscribers","subscription_url":"https://api.github.com/repos/tango-controls/cppTango/subscription","commits_url":"https://api.github.com/repos/tango-controls/cppTango/commits{/sha}","git_commits_url":"https://api.github.com/repos/tango-controls/cppTango/git/commits{/sha}","comments_url":"https://api.github.com/repos/tango-controls/cppTango/comments{/number}","issue_comment_url":"https://api.github.com/repos/tango-controls/cppTango/issues/comments{/number}","contents_url":"https://api.github.com/repos/tango-controls/cppTango/contents/{+path}","compare_url":"https://api.github.com/repos/tango-controls/cppTango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tango-controls/cppTango/merges","archive_url":"https://api.github.com/repos/tango-controls/cppTango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tango-controls/cppTango/downloads","issues_url":"https://api.github.com/repos/tango-controls/cppTango/issues{/number}","pulls_url":"https://api.github.com/repos/tango-controls/cppTango/pulls{/number}","milestones_url":"https://api.github.com/repos/tango-controls/cppTango/milestones{/number}","notifications_url":"https://api.github.com/repos/tango-controls/cppTango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tango-controls/cppTango/labels{/name}","releases_url":"https://api.github.com/repos/tango-controls/cppTango/releases{/id}","deployments_url":"https://api.github.com/repos/tango-controls/cppTango/deployments","created_at":"2016-09-08T08:10:34Z","updated_at":"2017-07-24T13:55:19Z","pushed_at":"2017-07-28T13:20:12Z","git_url":"git://github.com/tango-controls/cppTango.git","ssh_url":"[email protected]:tango-controls/cppTango.git","clone_url":"https://github.com/tango-controls/cppTango.git","svn_url":"https://github.com/tango-controls/cppTango","homepage":"http://tango-controls.org","size":8011,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":61,"forks":14,"open_issues":61,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/295"},"html":{"href":"https://github.com/tango-controls/cppTango/pull/295"},"issue":{"href":"https://api.github.com/repos/tango-controls/cppTango/issues/295"},"comments":{"href":"https://api.github.com/repos/tango-controls/cppTango/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/tango-controls/cppTango/statuses/e4efe942ff01136f7faf2cf6509dc70e98e78bdd"}}}} | {
"id": 67682672,
"name": "tango-controls/cppTango",
"url": "https://api.github.com/repos/tango-controls/cppTango"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 15830606,
"login": "tango-controls",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15830606?",
"url": "https://api.github.com/orgs/tango-controls"
} | 2017-07-28T13:22:59 | 6349597576 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/comments/136900263","pull_request_review_id":60500754,"id":136900263,"diff_hunk":"@@ -32,26 +30,25 @@ def tearDown(self):\n \n def test_if_in_var(self):\n # DTML test 1: if, in, and var:\n- pass # for unittest\n- \"\"\"\n- %(comment)[ blah %(comment)]\n- <html><head><title>Test of documentation templates</title></head>\n- <body>\n- %(if args)[\n- <dl><dt>The arguments to this test program were:<p>\n- <dd>\n- <ul>\n- %(in args)[\n- <li>Argument number %(num)d was %(arg)s\n- %(in args)]\n- </ul></dl><p>\n- %(if args)]\n- %(else args)[\n- No arguments were given.<p>\n- %(else args)]\n- And thats da trooth.\n- </body></html>\n- \"\"\"\n+ # \"\"\"\n+ # %(comment)[ blah %(comment)]\n+ # <html><head><title>Test of documentation templates</title></head>\n+ # <body>\n+ # %(if args)[\n+ # <dl><dt>The arguments to this test program were:<p>\n+ # <dd>\n+ # <ul>\n+ # %(in args)[\n+ # <li>Argument number %(num)d was %(arg)s\n+ # %(in args)]\n+ # </ul></dl><p>\n+ # %(if args)]\n+ # %(else args)[\n+ # No arguments were given.<p>\n+ # %(else args)]\n+ # And thats da trooth.\n+ # </body></html>\n+ # \"\"\"","path":"src/zope/pagetemplate/tests/test_basictemplate.py","position":null,"original_position":51,"commit_id":"5c69a15df699dfa278a60ff6e5eb063acd982979","original_commit_id":"67c529190c57b5ff47de51694a21a173223da0de","user":{"login":"icemac","id":386619,"avatar_url":"https://avatars1.githubusercontent.com/u/386619?v=4","gravatar_id":"","url":"https://api.github.com/users/icemac","html_url":"https://github.com/icemac","followers_url":"https://api.github.com/users/icemac/followers","following_url":"https://api.github.com/users/icemac/following{/other_user}","gists_url":"https://api.github.com/users/icemac/gists{/gist_id}","starred_url":"https://api.github.com/users/icemac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icemac/subscriptions","organizations_url":"https://api.github.com/users/icemac/orgs","repos_url":"https://api.github.com/users/icemac/repos","events_url":"https://api.github.com/users/icemac/events{/privacy}","received_events_url":"https://api.github.com/users/icemac/received_events","type":"User","site_admin":false},"body":"I meant the entire comment. It is not clear that it is a copy of the file contents. When the file contents are changed it is not sure that it will be changed here, too. As modern editors allow to view more than one file at once I'd suggest to remove the entire comment. (I consider it as duplicate code.)","created_at":"2017-09-05T05:57:01Z","updated_at":"2017-09-05T05:57:01Z","html_url":"https://github.com/zopefoundation/zope.pagetemplate/pull/12#discussion_r136900263","pull_request_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/comments/136900263"},"html":{"href":"https://github.com/zopefoundation/zope.pagetemplate/pull/12#discussion_r136900263"},"pull_request":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/12"}},"in_reply_to_id":136750893},"pull_request":{"url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/12","id":136561901,"html_url":"https://github.com/zopefoundation/zope.pagetemplate/pull/12","diff_url":"https://github.com/zopefoundation/zope.pagetemplate/pull/12.diff","patch_url":"https://github.com/zopefoundation/zope.pagetemplate/pull/12.patch","issue_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues/12","number":12,"state":"closed","locked":false,"title":"100% Test Coverage. ","user":{"login":"jamadden","id":1256082,"avatar_url":"https://avatars3.githubusercontent.com/u/1256082?v=4","gravatar_id":"","url":"https://api.github.com/users/jamadden","html_url":"https://github.com/jamadden","followers_url":"https://api.github.com/users/jamadden/followers","following_url":"https://api.github.com/users/jamadden/following{/other_user}","gists_url":"https://api.github.com/users/jamadden/gists{/gist_id}","starred_url":"https://api.github.com/users/jamadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamadden/subscriptions","organizations_url":"https://api.github.com/users/jamadden/orgs","repos_url":"https://api.github.com/users/jamadden/repos","events_url":"https://api.github.com/users/jamadden/events{/privacy}","received_events_url":"https://api.github.com/users/jamadden/received_events","type":"User","site_admin":false},"body":"Fixes #9 (currently based on #11 with one additional commit for the coverage)\r\n\r\nTwo potentially important changes: \r\n\r\n- Removed unused code in the tests/ package. If other packages were using it, they will need updates. (They probably shouldn't be, but that's happened before.) \r\n- Changed `TraversableModuleImporter` to catch `ImportError` instead of `KeyError`. There's no way the underlying `SimpleModuleImporter` can raise a KeyError anymore. I think this is the desired semantic but I am not 100% sure.\r\n\r\n\r\n\r\n","created_at":"2017-08-18T20:49:13Z","updated_at":"2017-09-05T05:57:01Z","closed_at":"2017-09-04T13:01:38Z","merged_at":"2017-09-04T13:01:38Z","merge_commit_sha":"4e38b01e582697a3b208ca46ade59dc24556fc41","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/12/commits","review_comments_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/12/comments","review_comment_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues/12/comments","statuses_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/statuses/5c69a15df699dfa278a60ff6e5eb063acd982979","head":{"label":"zopefoundation:coverage","ref":"coverage","sha":"5c69a15df699dfa278a60ff6e5eb063acd982979","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars1.githubusercontent.com/u/1163184?v=4","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":8361486,"name":"zope.pagetemplate","full_name":"zopefoundation/zope.pagetemplate","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars1.githubusercontent.com/u/1163184?v=4","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/zope.pagetemplate","description":"Zope Page Templates","fork":false,"url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate","forks_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/forks","keys_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/teams","hooks_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/events","assignees_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/tags","blobs_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/subscription","commits_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/merges","archive_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/downloads","issues_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/deployments","created_at":"2013-02-22T16:49:20Z","updated_at":"2016-03-24T02:19:38Z","pushed_at":"2017-09-04T13:03:47Z","git_url":"git://github.com/zopefoundation/zope.pagetemplate.git","ssh_url":"[email protected]:zopefoundation/zope.pagetemplate.git","clone_url":"https://github.com/zopefoundation/zope.pagetemplate.git","svn_url":"https://github.com/zopefoundation/zope.pagetemplate","homepage":"","size":544,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zopefoundation:master","ref":"master","sha":"b40f742baf274b154f2c3ddbadd8f7098ec4f260","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars1.githubusercontent.com/u/1163184?v=4","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":8361486,"name":"zope.pagetemplate","full_name":"zopefoundation/zope.pagetemplate","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars1.githubusercontent.com/u/1163184?v=4","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/zope.pagetemplate","description":"Zope Page Templates","fork":false,"url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate","forks_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/forks","keys_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/teams","hooks_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/events","assignees_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/tags","blobs_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/subscription","commits_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/merges","archive_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/downloads","issues_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/deployments","created_at":"2013-02-22T16:49:20Z","updated_at":"2016-03-24T02:19:38Z","pushed_at":"2017-09-04T13:03:47Z","git_url":"git://github.com/zopefoundation/zope.pagetemplate.git","ssh_url":"[email protected]:zopefoundation/zope.pagetemplate.git","clone_url":"https://github.com/zopefoundation/zope.pagetemplate.git","svn_url":"https://github.com/zopefoundation/zope.pagetemplate","homepage":"","size":544,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/12"},"html":{"href":"https://github.com/zopefoundation/zope.pagetemplate/pull/12"},"issue":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues/12"},"comments":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/zopefoundation/zope.pagetemplate/statuses/5c69a15df699dfa278a60ff6e5eb063acd982979"}},"author_association":"OWNER"}} | {
"id": 8361486,
"name": "zopefoundation/zope.pagetemplate",
"url": "https://api.github.com/repos/zopefoundation/zope.pagetemplate"
} | {
"id": 386619,
"login": "icemac",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/386619?",
"url": "https://api.github.com/users/icemac"
} | {
"id": 1163184,
"login": "zopefoundation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1163184?",
"url": "https://api.github.com/orgs/zopefoundation"
} | 2017-09-05T05:57:01 | 6549282895 | {"actor":{"display_login":"icemac"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/comments/135016148","pull_request_review_id":58378723,"id":135016148,"diff_hunk":"@@ -59,6 +59,7 @@ rpmbuild -bs /root/rpmbuild/SOURCES/${fed_repo}.spec\n #TODO\n # Should be a fedora-packager-setup command and a kinit. Will also probably require some packages like fedora-packager/python-krbV\n # Build the package into ./results_${fed_repo}/$VERSION/$RELEASE/ and concurrently do a koji build\n+kinit -k -t /home/fedora.keytab $FEDORA_PRINCIPAL","path":"config/Dockerfiles/rpmbuild/rpmbuild-test.sh","position":4,"original_position":4,"commit_id":"2ad75fc65bb5032e40be397c4dec44564ac0367c","original_commit_id":"2ad75fc65bb5032e40be397c4dec44564ac0367c","user":{"login":"scoheb","id":3596711,"avatar_url":"https://avatars1.githubusercontent.com/u/3596711?v=4","gravatar_id":"","url":"https://api.github.com/users/scoheb","html_url":"https://github.com/scoheb","followers_url":"https://api.github.com/users/scoheb/followers","following_url":"https://api.github.com/users/scoheb/following{/other_user}","gists_url":"https://api.github.com/users/scoheb/gists{/gist_id}","starred_url":"https://api.github.com/users/scoheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoheb/subscriptions","organizations_url":"https://api.github.com/users/scoheb/orgs","repos_url":"https://api.github.com/users/scoheb/repos","events_url":"https://api.github.com/users/scoheb/events{/privacy}","received_events_url":"https://api.github.com/users/scoheb/received_events","type":"User","site_admin":false},"body":"We need to add a check at top of script to make sure that **FEDORA_PRINCIPAL** is populated","created_at":"2017-08-24T13:37:19Z","updated_at":"2017-08-24T13:37:20Z","html_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline/pull/306#discussion_r135016148","pull_request_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/comments/135016148"},"html":{"href":"https://github.com/CentOS-PaaS-SIG/ci-pipeline/pull/306#discussion_r135016148"},"pull_request":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/306","id":137455124,"html_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline/pull/306","diff_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline/pull/306.diff","patch_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline/pull/306.patch","issue_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues/306","number":306,"state":"open","locked":false,"title":"do kinit in rpmbuild script so we can authenticate against koji.","user":{"login":"p3ck","id":2686136,"avatar_url":"https://avatars0.githubusercontent.com/u/2686136?v=4","gravatar_id":"","url":"https://api.github.com/users/p3ck","html_url":"https://github.com/p3ck","followers_url":"https://api.github.com/users/p3ck/followers","following_url":"https://api.github.com/users/p3ck/following{/other_user}","gists_url":"https://api.github.com/users/p3ck/gists{/gist_id}","starred_url":"https://api.github.com/users/p3ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p3ck/subscriptions","organizations_url":"https://api.github.com/users/p3ck/orgs","repos_url":"https://api.github.com/users/p3ck/repos","events_url":"https://api.github.com/users/p3ck/events{/privacy}","received_events_url":"https://api.github.com/users/p3ck/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-24T13:32:37Z","updated_at":"2017-08-24T13:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"993d3578066faa53a4cef8af918c54d7f5af0808","assignee":null,"assignees":[],"requested_reviewers":[{"login":"johnbieren","id":7284629,"avatar_url":"https://avatars3.githubusercontent.com/u/7284629?v=4","gravatar_id":"","url":"https://api.github.com/users/johnbieren","html_url":"https://github.com/johnbieren","followers_url":"https://api.github.com/users/johnbieren/followers","following_url":"https://api.github.com/users/johnbieren/following{/other_user}","gists_url":"https://api.github.com/users/johnbieren/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbieren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbieren/subscriptions","organizations_url":"https://api.github.com/users/johnbieren/orgs","repos_url":"https://api.github.com/users/johnbieren/repos","events_url":"https://api.github.com/users/johnbieren/events{/privacy}","received_events_url":"https://api.github.com/users/johnbieren/received_events","type":"User","site_admin":false},{"login":"robnester-rh","id":26954384,"avatar_url":"https://avatars3.githubusercontent.com/u/26954384?v=4","gravatar_id":"","url":"https://api.github.com/users/robnester-rh","html_url":"https://github.com/robnester-rh","followers_url":"https://api.github.com/users/robnester-rh/followers","following_url":"https://api.github.com/users/robnester-rh/following{/other_user}","gists_url":"https://api.github.com/users/robnester-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/robnester-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robnester-rh/subscriptions","organizations_url":"https://api.github.com/users/robnester-rh/orgs","repos_url":"https://api.github.com/users/robnester-rh/repos","events_url":"https://api.github.com/users/robnester-rh/events{/privacy}","received_events_url":"https://api.github.com/users/robnester-rh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/306/commits","review_comments_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/306/comments","review_comment_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues/306/comments","statuses_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/statuses/2ad75fc65bb5032e40be397c4dec44564ac0367c","head":{"label":"CentOS-PaaS-SIG:p3ck","ref":"p3ck","sha":"2ad75fc65bb5032e40be397c4dec44564ac0367c","user":{"login":"CentOS-PaaS-SIG","id":19438073,"avatar_url":"https://avatars0.githubusercontent.com/u/19438073?v=4","gravatar_id":"","url":"https://api.github.com/users/CentOS-PaaS-SIG","html_url":"https://github.com/CentOS-PaaS-SIG","followers_url":"https://api.github.com/users/CentOS-PaaS-SIG/followers","following_url":"https://api.github.com/users/CentOS-PaaS-SIG/following{/other_user}","gists_url":"https://api.github.com/users/CentOS-PaaS-SIG/gists{/gist_id}","starred_url":"https://api.github.com/users/CentOS-PaaS-SIG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CentOS-PaaS-SIG/subscriptions","organizations_url":"https://api.github.com/users/CentOS-PaaS-SIG/orgs","repos_url":"https://api.github.com/users/CentOS-PaaS-SIG/repos","events_url":"https://api.github.com/users/CentOS-PaaS-SIG/events{/privacy}","received_events_url":"https://api.github.com/users/CentOS-PaaS-SIG/received_events","type":"Organization","site_admin":false},"repo":{"id":84829792,"name":"ci-pipeline","full_name":"CentOS-PaaS-SIG/ci-pipeline","owner":{"login":"CentOS-PaaS-SIG","id":19438073,"avatar_url":"https://avatars0.githubusercontent.com/u/19438073?v=4","gravatar_id":"","url":"https://api.github.com/users/CentOS-PaaS-SIG","html_url":"https://github.com/CentOS-PaaS-SIG","followers_url":"https://api.github.com/users/CentOS-PaaS-SIG/followers","following_url":"https://api.github.com/users/CentOS-PaaS-SIG/following{/other_user}","gists_url":"https://api.github.com/users/CentOS-PaaS-SIG/gists{/gist_id}","starred_url":"https://api.github.com/users/CentOS-PaaS-SIG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CentOS-PaaS-SIG/subscriptions","organizations_url":"https://api.github.com/users/CentOS-PaaS-SIG/orgs","repos_url":"https://api.github.com/users/CentOS-PaaS-SIG/repos","events_url":"https://api.github.com/users/CentOS-PaaS-SIG/events{/privacy}","received_events_url":"https://api.github.com/users/CentOS-PaaS-SIG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline","description":"There are many projects that are concentrated on CI for Atomic Openshift. This is focused on complete CI testing of all Atomic and Base Runtime components for a new Atomic deliverable that comes from Fedora sources.","fork":false,"url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline","forks_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/forks","keys_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/teams","hooks_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/hooks","issue_events_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/events","assignees_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/tags","blobs_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/languages","stargazers_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/stargazers","contributors_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/contributors","subscribers_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/subscribers","subscription_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/subscription","commits_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/merges","archive_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/downloads","issues_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/deployments","created_at":"2017-03-13T13:30:23Z","updated_at":"2017-08-23T15:36:25Z","pushed_at":"2017-08-24T13:32:37Z","git_url":"git://github.com/CentOS-PaaS-SIG/ci-pipeline.git","ssh_url":"[email protected]:CentOS-PaaS-SIG/ci-pipeline.git","clone_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline.git","svn_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline","homepage":"","size":1657,"stargazers_count":1,"watchers_count":1,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"CentOS-PaaS-SIG:master","ref":"master","sha":"c8bc63f055b0bc73867c1b19e1536b13dc98a931","user":{"login":"CentOS-PaaS-SIG","id":19438073,"avatar_url":"https://avatars0.githubusercontent.com/u/19438073?v=4","gravatar_id":"","url":"https://api.github.com/users/CentOS-PaaS-SIG","html_url":"https://github.com/CentOS-PaaS-SIG","followers_url":"https://api.github.com/users/CentOS-PaaS-SIG/followers","following_url":"https://api.github.com/users/CentOS-PaaS-SIG/following{/other_user}","gists_url":"https://api.github.com/users/CentOS-PaaS-SIG/gists{/gist_id}","starred_url":"https://api.github.com/users/CentOS-PaaS-SIG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CentOS-PaaS-SIG/subscriptions","organizations_url":"https://api.github.com/users/CentOS-PaaS-SIG/orgs","repos_url":"https://api.github.com/users/CentOS-PaaS-SIG/repos","events_url":"https://api.github.com/users/CentOS-PaaS-SIG/events{/privacy}","received_events_url":"https://api.github.com/users/CentOS-PaaS-SIG/received_events","type":"Organization","site_admin":false},"repo":{"id":84829792,"name":"ci-pipeline","full_name":"CentOS-PaaS-SIG/ci-pipeline","owner":{"login":"CentOS-PaaS-SIG","id":19438073,"avatar_url":"https://avatars0.githubusercontent.com/u/19438073?v=4","gravatar_id":"","url":"https://api.github.com/users/CentOS-PaaS-SIG","html_url":"https://github.com/CentOS-PaaS-SIG","followers_url":"https://api.github.com/users/CentOS-PaaS-SIG/followers","following_url":"https://api.github.com/users/CentOS-PaaS-SIG/following{/other_user}","gists_url":"https://api.github.com/users/CentOS-PaaS-SIG/gists{/gist_id}","starred_url":"https://api.github.com/users/CentOS-PaaS-SIG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CentOS-PaaS-SIG/subscriptions","organizations_url":"https://api.github.com/users/CentOS-PaaS-SIG/orgs","repos_url":"https://api.github.com/users/CentOS-PaaS-SIG/repos","events_url":"https://api.github.com/users/CentOS-PaaS-SIG/events{/privacy}","received_events_url":"https://api.github.com/users/CentOS-PaaS-SIG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline","description":"There are many projects that are concentrated on CI for Atomic Openshift. This is focused on complete CI testing of all Atomic and Base Runtime components for a new Atomic deliverable that comes from Fedora sources.","fork":false,"url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline","forks_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/forks","keys_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/teams","hooks_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/hooks","issue_events_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/events","assignees_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/tags","blobs_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/languages","stargazers_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/stargazers","contributors_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/contributors","subscribers_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/subscribers","subscription_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/subscription","commits_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/merges","archive_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/downloads","issues_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/deployments","created_at":"2017-03-13T13:30:23Z","updated_at":"2017-08-23T15:36:25Z","pushed_at":"2017-08-24T13:32:37Z","git_url":"git://github.com/CentOS-PaaS-SIG/ci-pipeline.git","ssh_url":"[email protected]:CentOS-PaaS-SIG/ci-pipeline.git","clone_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline.git","svn_url":"https://github.com/CentOS-PaaS-SIG/ci-pipeline","homepage":"","size":1657,"stargazers_count":1,"watchers_count":1,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/306"},"html":{"href":"https://github.com/CentOS-PaaS-SIG/ci-pipeline/pull/306"},"issue":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues/306"},"comments":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline/statuses/2ad75fc65bb5032e40be397c4dec44564ac0367c"}}}} | {
"id": 84829792,
"name": "CentOS-PaaS-SIG/ci-pipeline",
"url": "https://api.github.com/repos/CentOS-PaaS-SIG/ci-pipeline"
} | {
"id": 3596711,
"login": "scoheb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3596711?",
"url": "https://api.github.com/users/scoheb"
} | {
"id": 19438073,
"login": "CentOS-PaaS-SIG",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19438073?",
"url": "https://api.github.com/orgs/CentOS-PaaS-SIG"
} | 2017-08-24T13:37:19 | 6507526060 | {"actor":{"display_login":"scoheb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DefactoSoftware/website/pulls/comments/133769065","pull_request_review_id":56988042,"id":133769065,"diff_hunk":"@@ -91,6 +91,8 @@\n when :nl\n redirect \"workshop-convenant-mt.html\", to: \"convenant-medische-technologie.html\"\n redirect \"hosting.html\", to: \"hosting-security.html\"\n+ redirect \"blog/learningspaces-op-websummit.html\", to: \"/blog/capp-agile-learning-op-websummit/\"","path":"config.rb","position":4,"original_position":4,"commit_id":"be30778ff073e4a81488a9426b1b2ca60f1e4a89","original_commit_id":"be30778ff073e4a81488a9426b1b2ca60f1e4a89","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long. [97/80]","created_at":"2017-08-17T16:52:40Z","updated_at":"2017-08-17T16:52:40Z","html_url":"https://github.com/DefactoSoftware/website/pull/802#discussion_r133769065","pull_request_url":"https://api.github.com/repos/DefactoSoftware/website/pulls/802","_links":{"self":{"href":"https://api.github.com/repos/DefactoSoftware/website/pulls/comments/133769065"},"html":{"href":"https://github.com/DefactoSoftware/website/pull/802#discussion_r133769065"},"pull_request":{"href":"https://api.github.com/repos/DefactoSoftware/website/pulls/802"}}},"pull_request":{"url":"https://api.github.com/repos/DefactoSoftware/website/pulls/802","id":136252828,"html_url":"https://github.com/DefactoSoftware/website/pull/802","diff_url":"https://github.com/DefactoSoftware/website/pull/802.diff","patch_url":"https://github.com/DefactoSoftware/website/pull/802.patch","issue_url":"https://api.github.com/repos/DefactoSoftware/website/issues/802","number":802,"state":"open","locked":false,"title":"Change LearningSpaces to CAPP agile","user":{"login":"sdegeus","id":29703808,"avatar_url":"https://avatars2.githubusercontent.com/u/29703808?v=4","gravatar_id":"","url":"https://api.github.com/users/sdegeus","html_url":"https://github.com/sdegeus","followers_url":"https://api.github.com/users/sdegeus/followers","following_url":"https://api.github.com/users/sdegeus/following{/other_user}","gists_url":"https://api.github.com/users/sdegeus/gists{/gist_id}","starred_url":"https://api.github.com/users/sdegeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdegeus/subscriptions","organizations_url":"https://api.github.com/users/sdegeus/orgs","repos_url":"https://api.github.com/users/sdegeus/repos","events_url":"https://api.github.com/users/sdegeus/events{/privacy}","received_events_url":"https://api.github.com/users/sdegeus/received_events","type":"User","site_admin":false},"body":"Changed all mentions of Learning Spaces to CAPP Agile and updated the links. ","created_at":"2017-08-17T13:09:59Z","updated_at":"2017-08-17T16:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"677f730d5f76acc86abe60a1af750c1eb608b79b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefactoSoftware/website/pulls/802/commits","review_comments_url":"https://api.github.com/repos/DefactoSoftware/website/pulls/802/comments","review_comment_url":"https://api.github.com/repos/DefactoSoftware/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefactoSoftware/website/issues/802/comments","statuses_url":"https://api.github.com/repos/DefactoSoftware/website/statuses/be30778ff073e4a81488a9426b1b2ca60f1e4a89","head":{"label":"DefactoSoftware:stephanie/ls-to-cappagile","ref":"stephanie/ls-to-cappagile","sha":"be30778ff073e4a81488a9426b1b2ca60f1e4a89","user":{"login":"DefactoSoftware","id":3899757,"avatar_url":"https://avatars3.githubusercontent.com/u/3899757?v=4","gravatar_id":"","url":"https://api.github.com/users/DefactoSoftware","html_url":"https://github.com/DefactoSoftware","followers_url":"https://api.github.com/users/DefactoSoftware/followers","following_url":"https://api.github.com/users/DefactoSoftware/following{/other_user}","gists_url":"https://api.github.com/users/DefactoSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/DefactoSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefactoSoftware/subscriptions","organizations_url":"https://api.github.com/users/DefactoSoftware/orgs","repos_url":"https://api.github.com/users/DefactoSoftware/repos","events_url":"https://api.github.com/users/DefactoSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/DefactoSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":15392660,"name":"website","full_name":"DefactoSoftware/website","owner":{"login":"DefactoSoftware","id":3899757,"avatar_url":"https://avatars3.githubusercontent.com/u/3899757?v=4","gravatar_id":"","url":"https://api.github.com/users/DefactoSoftware","html_url":"https://github.com/DefactoSoftware","followers_url":"https://api.github.com/users/DefactoSoftware/followers","following_url":"https://api.github.com/users/DefactoSoftware/following{/other_user}","gists_url":"https://api.github.com/users/DefactoSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/DefactoSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefactoSoftware/subscriptions","organizations_url":"https://api.github.com/users/DefactoSoftware/orgs","repos_url":"https://api.github.com/users/DefactoSoftware/repos","events_url":"https://api.github.com/users/DefactoSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/DefactoSoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefactoSoftware/website","description":"Defacto website","fork":false,"url":"https://api.github.com/repos/DefactoSoftware/website","forks_url":"https://api.github.com/repos/DefactoSoftware/website/forks","keys_url":"https://api.github.com/repos/DefactoSoftware/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefactoSoftware/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefactoSoftware/website/teams","hooks_url":"https://api.github.com/repos/DefactoSoftware/website/hooks","issue_events_url":"https://api.github.com/repos/DefactoSoftware/website/issues/events{/number}","events_url":"https://api.github.com/repos/DefactoSoftware/website/events","assignees_url":"https://api.github.com/repos/DefactoSoftware/website/assignees{/user}","branches_url":"https://api.github.com/repos/DefactoSoftware/website/branches{/branch}","tags_url":"https://api.github.com/repos/DefactoSoftware/website/tags","blobs_url":"https://api.github.com/repos/DefactoSoftware/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefactoSoftware/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefactoSoftware/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefactoSoftware/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefactoSoftware/website/statuses/{sha}","languages_url":"https://api.github.com/repos/DefactoSoftware/website/languages","stargazers_url":"https://api.github.com/repos/DefactoSoftware/website/stargazers","contributors_url":"https://api.github.com/repos/DefactoSoftware/website/contributors","subscribers_url":"https://api.github.com/repos/DefactoSoftware/website/subscribers","subscription_url":"https://api.github.com/repos/DefactoSoftware/website/subscription","commits_url":"https://api.github.com/repos/DefactoSoftware/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefactoSoftware/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefactoSoftware/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefactoSoftware/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefactoSoftware/website/contents/{+path}","compare_url":"https://api.github.com/repos/DefactoSoftware/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefactoSoftware/website/merges","archive_url":"https://api.github.com/repos/DefactoSoftware/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefactoSoftware/website/downloads","issues_url":"https://api.github.com/repos/DefactoSoftware/website/issues{/number}","pulls_url":"https://api.github.com/repos/DefactoSoftware/website/pulls{/number}","milestones_url":"https://api.github.com/repos/DefactoSoftware/website/milestones{/number}","notifications_url":"https://api.github.com/repos/DefactoSoftware/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefactoSoftware/website/labels{/name}","releases_url":"https://api.github.com/repos/DefactoSoftware/website/releases{/id}","deployments_url":"https://api.github.com/repos/DefactoSoftware/website/deployments","created_at":"2013-12-23T10:09:03Z","updated_at":"2017-05-12T18:06:47Z","pushed_at":"2017-08-17T16:52:30Z","git_url":"git://github.com/DefactoSoftware/website.git","ssh_url":"[email protected]:DefactoSoftware/website.git","clone_url":"https://github.com/DefactoSoftware/website.git","svn_url":"https://github.com/DefactoSoftware/website","homepage":"http://www.defacto.nl/","size":120677,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":31,"forks":6,"open_issues":31,"watchers":8,"default_branch":"master"}},"base":{"label":"DefactoSoftware:master","ref":"master","sha":"4bc9c689e52f892459b5f2d8dc0668a31dc81aa5","user":{"login":"DefactoSoftware","id":3899757,"avatar_url":"https://avatars3.githubusercontent.com/u/3899757?v=4","gravatar_id":"","url":"https://api.github.com/users/DefactoSoftware","html_url":"https://github.com/DefactoSoftware","followers_url":"https://api.github.com/users/DefactoSoftware/followers","following_url":"https://api.github.com/users/DefactoSoftware/following{/other_user}","gists_url":"https://api.github.com/users/DefactoSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/DefactoSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefactoSoftware/subscriptions","organizations_url":"https://api.github.com/users/DefactoSoftware/orgs","repos_url":"https://api.github.com/users/DefactoSoftware/repos","events_url":"https://api.github.com/users/DefactoSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/DefactoSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":15392660,"name":"website","full_name":"DefactoSoftware/website","owner":{"login":"DefactoSoftware","id":3899757,"avatar_url":"https://avatars3.githubusercontent.com/u/3899757?v=4","gravatar_id":"","url":"https://api.github.com/users/DefactoSoftware","html_url":"https://github.com/DefactoSoftware","followers_url":"https://api.github.com/users/DefactoSoftware/followers","following_url":"https://api.github.com/users/DefactoSoftware/following{/other_user}","gists_url":"https://api.github.com/users/DefactoSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/DefactoSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefactoSoftware/subscriptions","organizations_url":"https://api.github.com/users/DefactoSoftware/orgs","repos_url":"https://api.github.com/users/DefactoSoftware/repos","events_url":"https://api.github.com/users/DefactoSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/DefactoSoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefactoSoftware/website","description":"Defacto website","fork":false,"url":"https://api.github.com/repos/DefactoSoftware/website","forks_url":"https://api.github.com/repos/DefactoSoftware/website/forks","keys_url":"https://api.github.com/repos/DefactoSoftware/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefactoSoftware/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefactoSoftware/website/teams","hooks_url":"https://api.github.com/repos/DefactoSoftware/website/hooks","issue_events_url":"https://api.github.com/repos/DefactoSoftware/website/issues/events{/number}","events_url":"https://api.github.com/repos/DefactoSoftware/website/events","assignees_url":"https://api.github.com/repos/DefactoSoftware/website/assignees{/user}","branches_url":"https://api.github.com/repos/DefactoSoftware/website/branches{/branch}","tags_url":"https://api.github.com/repos/DefactoSoftware/website/tags","blobs_url":"https://api.github.com/repos/DefactoSoftware/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefactoSoftware/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefactoSoftware/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefactoSoftware/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefactoSoftware/website/statuses/{sha}","languages_url":"https://api.github.com/repos/DefactoSoftware/website/languages","stargazers_url":"https://api.github.com/repos/DefactoSoftware/website/stargazers","contributors_url":"https://api.github.com/repos/DefactoSoftware/website/contributors","subscribers_url":"https://api.github.com/repos/DefactoSoftware/website/subscribers","subscription_url":"https://api.github.com/repos/DefactoSoftware/website/subscription","commits_url":"https://api.github.com/repos/DefactoSoftware/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefactoSoftware/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefactoSoftware/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefactoSoftware/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefactoSoftware/website/contents/{+path}","compare_url":"https://api.github.com/repos/DefactoSoftware/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefactoSoftware/website/merges","archive_url":"https://api.github.com/repos/DefactoSoftware/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefactoSoftware/website/downloads","issues_url":"https://api.github.com/repos/DefactoSoftware/website/issues{/number}","pulls_url":"https://api.github.com/repos/DefactoSoftware/website/pulls{/number}","milestones_url":"https://api.github.com/repos/DefactoSoftware/website/milestones{/number}","notifications_url":"https://api.github.com/repos/DefactoSoftware/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefactoSoftware/website/labels{/name}","releases_url":"https://api.github.com/repos/DefactoSoftware/website/releases{/id}","deployments_url":"https://api.github.com/repos/DefactoSoftware/website/deployments","created_at":"2013-12-23T10:09:03Z","updated_at":"2017-05-12T18:06:47Z","pushed_at":"2017-08-17T16:52:30Z","git_url":"git://github.com/DefactoSoftware/website.git","ssh_url":"[email protected]:DefactoSoftware/website.git","clone_url":"https://github.com/DefactoSoftware/website.git","svn_url":"https://github.com/DefactoSoftware/website","homepage":"http://www.defacto.nl/","size":120677,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":31,"forks":6,"open_issues":31,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefactoSoftware/website/pulls/802"},"html":{"href":"https://github.com/DefactoSoftware/website/pull/802"},"issue":{"href":"https://api.github.com/repos/DefactoSoftware/website/issues/802"},"comments":{"href":"https://api.github.com/repos/DefactoSoftware/website/issues/802/comments"},"review_comments":{"href":"https://api.github.com/repos/DefactoSoftware/website/pulls/802/comments"},"review_comment":{"href":"https://api.github.com/repos/DefactoSoftware/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefactoSoftware/website/pulls/802/commits"},"statuses":{"href":"https://api.github.com/repos/DefactoSoftware/website/statuses/be30778ff073e4a81488a9426b1b2ca60f1e4a89"}}}} | {
"id": 15392660,
"name": "DefactoSoftware/website",
"url": "https://api.github.com/repos/DefactoSoftware/website"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 3899757,
"login": "DefactoSoftware",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3899757?",
"url": "https://api.github.com/orgs/DefactoSoftware"
} | 2017-08-17T16:52:40 | 6473906476 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments/132837292","pull_request_review_id":55960980,"id":132837292,"diff_hunk":"@@ -950,29 +950,71 @@ def fractions(min_value=None, max_value=None, max_denominator=None):\n max_denominator must be at least 1.\n \n \"\"\"\n+ if min_value is not None:\n+ try:\n+ min_value = Fraction(min_value)\n+ except (TypeError, ValueError):\n+ raise InvalidArgument('min_value=%r to Fraction' % (min_value,))\n+ if max_value is not None:\n+ try:\n+ max_value = Fraction(max_value)\n+ except (TypeError, ValueError):\n+ raise InvalidArgument('max_value=%r to Fraction' % (max_value,))\n+ if min_value == max_value:\n+ return just(min_value)\n+\n check_valid_bound(min_value, 'min_value')\n check_valid_bound(max_value, 'max_value')\n check_valid_interval(min_value, max_value, 'min_value', 'max_value')\n \n check_valid_integer(max_denominator)\n if max_denominator is not None and max_denominator < 1:\n+ raise InvalidArgument('Denominator=%r must be >= 1' % max_denominator)\n+\n+ def clip_denominator(frac):\n+ \"\"\"Clip fraction to a max denominator, and bump back over bounds.\"\"\"\n+ if max_denominator is None:\n+ return frac\n+ val = frac.limit_denominator(max_denominator)\n+ if min_value is not None and val < min_value:","path":"src/hypothesis/strategies.py","position":49,"original_position":48,"commit_id":"72339ed338ff5ac1adf880432f1b3fd10a5d1b3d","original_commit_id":"cb74ffec91d5eccb6602cf6dcf93a7e0d667bff1","user":{"login":"DRMacIver","id":28623,"avatar_url":"https://avatars0.githubusercontent.com/u/28623?v=4","gravatar_id":"","url":"https://api.github.com/users/DRMacIver","html_url":"https://github.com/DRMacIver","followers_url":"https://api.github.com/users/DRMacIver/followers","following_url":"https://api.github.com/users/DRMacIver/following{/other_user}","gists_url":"https://api.github.com/users/DRMacIver/gists{/gist_id}","starred_url":"https://api.github.com/users/DRMacIver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DRMacIver/subscriptions","organizations_url":"https://api.github.com/users/DRMacIver/orgs","repos_url":"https://api.github.com/users/DRMacIver/repos","events_url":"https://api.github.com/users/DRMacIver/events{/privacy}","received_events_url":"https://api.github.com/users/DRMacIver/received_events","type":"User","site_admin":false},"body":"Actually I don't entirely understand why the `limit_denominator` does anything at all. Doesn't `dm_func` below ensure we're in the right denominator range? ","created_at":"2017-08-13T10:22:12Z","updated_at":"2017-08-13T10:49:05Z","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/777#discussion_r132837292","pull_request_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/777","_links":{"self":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments/132837292"},"html":{"href":"https://github.com/HypothesisWorks/hypothesis-python/pull/777#discussion_r132837292"},"pull_request":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/777"}}},"pull_request":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/777","id":135451403,"html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/777","diff_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/777.diff","patch_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/777.patch","issue_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/777","number":777,"state":"open","locked":false,"title":"Bugfixes for fractions() and decimals()","user":{"login":"Zac-HD","id":12229877,"avatar_url":"https://avatars1.githubusercontent.com/u/12229877?v=4","gravatar_id":"","url":"https://api.github.com/users/Zac-HD","html_url":"https://github.com/Zac-HD","followers_url":"https://api.github.com/users/Zac-HD/followers","following_url":"https://api.github.com/users/Zac-HD/following{/other_user}","gists_url":"https://api.github.com/users/Zac-HD/gists{/gist_id}","starred_url":"https://api.github.com/users/Zac-HD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zac-HD/subscriptions","organizations_url":"https://api.github.com/users/Zac-HD/orgs","repos_url":"https://api.github.com/users/Zac-HD/repos","events_url":"https://api.github.com/users/Zac-HD/events{/privacy}","received_events_url":"https://api.github.com/users/Zac-HD/received_events","type":"User","site_admin":false},"body":"Fixes #725, fixes #739, fixes a previously-latent bug in the denominator bounds I spotted along the way.\r\n\r\nThese were pretty easy to track down, but getting the regression tests and new bounds-fuzzing tests to pass with full coverage was a real pain - the sooner I can forget Python 2 compatibility issues for str and int the happier I'll be. Anyway, it's working now.","created_at":"2017-08-12T07:36:07Z","updated_at":"2017-08-13T10:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d646ec171794b7c46ad51d01008c9064dd89a4a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/777/commits","review_comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/777/comments","review_comment_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/777/comments","statuses_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/72339ed338ff5ac1adf880432f1b3fd10a5d1b3d","head":{"label":"Zac-HD:decimals-strategy","ref":"decimals-strategy","sha":"72339ed338ff5ac1adf880432f1b3fd10a5d1b3d","user":{"login":"Zac-HD","id":12229877,"avatar_url":"https://avatars1.githubusercontent.com/u/12229877?v=4","gravatar_id":"","url":"https://api.github.com/users/Zac-HD","html_url":"https://github.com/Zac-HD","followers_url":"https://api.github.com/users/Zac-HD/followers","following_url":"https://api.github.com/users/Zac-HD/following{/other_user}","gists_url":"https://api.github.com/users/Zac-HD/gists{/gist_id}","starred_url":"https://api.github.com/users/Zac-HD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zac-HD/subscriptions","organizations_url":"https://api.github.com/users/Zac-HD/orgs","repos_url":"https://api.github.com/users/Zac-HD/repos","events_url":"https://api.github.com/users/Zac-HD/events{/privacy}","received_events_url":"https://api.github.com/users/Zac-HD/received_events","type":"User","site_admin":false},"repo":{"id":82669519,"name":"hypothesis-python","full_name":"Zac-HD/hypothesis-python","owner":{"login":"Zac-HD","id":12229877,"avatar_url":"https://avatars1.githubusercontent.com/u/12229877?v=4","gravatar_id":"","url":"https://api.github.com/users/Zac-HD","html_url":"https://github.com/Zac-HD","followers_url":"https://api.github.com/users/Zac-HD/followers","following_url":"https://api.github.com/users/Zac-HD/following{/other_user}","gists_url":"https://api.github.com/users/Zac-HD/gists{/gist_id}","starred_url":"https://api.github.com/users/Zac-HD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zac-HD/subscriptions","organizations_url":"https://api.github.com/users/Zac-HD/orgs","repos_url":"https://api.github.com/users/Zac-HD/repos","events_url":"https://api.github.com/users/Zac-HD/events{/privacy}","received_events_url":"https://api.github.com/users/Zac-HD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zac-HD/hypothesis-python","description":"Advanced property-based (QuickCheck-like) testing for Python","fork":true,"url":"https://api.github.com/repos/Zac-HD/hypothesis-python","forks_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/forks","keys_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/teams","hooks_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/hooks","issue_events_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/issues/events{/number}","events_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/events","assignees_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/assignees{/user}","branches_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/branches{/branch}","tags_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/tags","blobs_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/languages","stargazers_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/stargazers","contributors_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/contributors","subscribers_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/subscribers","subscription_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/subscription","commits_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/contents/{+path}","compare_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/merges","archive_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/downloads","issues_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/issues{/number}","pulls_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/labels{/name}","releases_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/releases{/id}","deployments_url":"https://api.github.com/repos/Zac-HD/hypothesis-python/deployments","created_at":"2017-02-21T10:56:41Z","updated_at":"2017-02-21T10:56:44Z","pushed_at":"2017-08-13T10:16:43Z","git_url":"git://github.com/Zac-HD/hypothesis-python.git","ssh_url":"[email protected]:Zac-HD/hypothesis-python.git","clone_url":"https://github.com/Zac-HD/hypothesis-python.git","svn_url":"https://github.com/Zac-HD/hypothesis-python","homepage":"http://hypothesis.works","size":6972,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HypothesisWorks:master","ref":"master","sha":"d03be5f8bc995de2e4dafb6da43b7ac8f0e86b8d","user":{"login":"HypothesisWorks","id":18481919,"avatar_url":"https://avatars1.githubusercontent.com/u/18481919?v=4","gravatar_id":"","url":"https://api.github.com/users/HypothesisWorks","html_url":"https://github.com/HypothesisWorks","followers_url":"https://api.github.com/users/HypothesisWorks/followers","following_url":"https://api.github.com/users/HypothesisWorks/following{/other_user}","gists_url":"https://api.github.com/users/HypothesisWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/HypothesisWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HypothesisWorks/subscriptions","organizations_url":"https://api.github.com/users/HypothesisWorks/orgs","repos_url":"https://api.github.com/users/HypothesisWorks/repos","events_url":"https://api.github.com/users/HypothesisWorks/events{/privacy}","received_events_url":"https://api.github.com/users/HypothesisWorks/received_events","type":"Organization","site_admin":false},"repo":{"id":8685799,"name":"hypothesis-python","full_name":"HypothesisWorks/hypothesis-python","owner":{"login":"HypothesisWorks","id":18481919,"avatar_url":"https://avatars1.githubusercontent.com/u/18481919?v=4","gravatar_id":"","url":"https://api.github.com/users/HypothesisWorks","html_url":"https://github.com/HypothesisWorks","followers_url":"https://api.github.com/users/HypothesisWorks/followers","following_url":"https://api.github.com/users/HypothesisWorks/following{/other_user}","gists_url":"https://api.github.com/users/HypothesisWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/HypothesisWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HypothesisWorks/subscriptions","organizations_url":"https://api.github.com/users/HypothesisWorks/orgs","repos_url":"https://api.github.com/users/HypothesisWorks/repos","events_url":"https://api.github.com/users/HypothesisWorks/events{/privacy}","received_events_url":"https://api.github.com/users/HypothesisWorks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HypothesisWorks/hypothesis-python","description":"Advanced property-based (QuickCheck-like) testing for Python","fork":false,"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python","forks_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/forks","keys_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/teams","hooks_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/hooks","issue_events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/events{/number}","events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/events","assignees_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/assignees{/user}","branches_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/branches{/branch}","tags_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/tags","blobs_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/{sha}","languages_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/languages","stargazers_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/stargazers","contributors_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/contributors","subscribers_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/subscribers","subscription_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/subscription","commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/contents/{+path}","compare_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/merges","archive_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/downloads","issues_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues{/number}","pulls_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls{/number}","milestones_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/milestones{/number}","notifications_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/labels{/name}","releases_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/releases{/id}","deployments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/deployments","created_at":"2013-03-10T13:51:19Z","updated_at":"2017-08-12T07:11:21Z","pushed_at":"2017-08-13T10:16:44Z","git_url":"git://github.com/HypothesisWorks/hypothesis-python.git","ssh_url":"[email protected]:HypothesisWorks/hypothesis-python.git","clone_url":"https://github.com/HypothesisWorks/hypothesis-python.git","svn_url":"https://github.com/HypothesisWorks/hypothesis-python","homepage":"http://hypothesis.works","size":7170,"stargazers_count":2012,"watchers_count":2012,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":118,"forks":185,"open_issues":118,"watchers":2012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/777"},"html":{"href":"https://github.com/HypothesisWorks/hypothesis-python/pull/777"},"issue":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/777"},"comments":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/72339ed338ff5ac1adf880432f1b3fd10a5d1b3d"}}}} | {
"id": 8685799,
"name": "HypothesisWorks/hypothesis-python",
"url": "https://api.github.com/repos/HypothesisWorks/hypothesis-python"
} | {
"id": 28623,
"login": "DRMacIver",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28623?",
"url": "https://api.github.com/users/DRMacIver"
} | {
"id": 18481919,
"login": "HypothesisWorks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18481919?",
"url": "https://api.github.com/orgs/HypothesisWorks"
} | 2017-08-13T10:22:12 | 6445761221 | {"actor":{"display_login":"DRMacIver"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/comments/137117567","pull_request_review_id":60744325,"id":137117567,"diff_hunk":"@@ -397,17 +454,24 @@ namespace glTF2 {\n \n inline void Write(Value& obj, Sampler& b, AssetWriter& w)","path":"code/glTF2AssetWriter.inl","position":278,"original_position":278,"commit_id":"7048cfc154081bd3a7f8c304343ab573187f23e7","original_commit_id":"7048cfc154081bd3a7f8c304343ab573187f23e7","user":{"login":"dhritzkiv","id":1349865,"avatar_url":"https://avatars1.githubusercontent.com/u/1349865?v=4","gravatar_id":"","url":"https://api.github.com/users/dhritzkiv","html_url":"https://github.com/dhritzkiv","followers_url":"https://api.github.com/users/dhritzkiv/followers","following_url":"https://api.github.com/users/dhritzkiv/following{/other_user}","gists_url":"https://api.github.com/users/dhritzkiv/gists{/gist_id}","starred_url":"https://api.github.com/users/dhritzkiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhritzkiv/subscriptions","organizations_url":"https://api.github.com/users/dhritzkiv/orgs","repos_url":"https://api.github.com/users/dhritzkiv/repos","events_url":"https://api.github.com/users/dhritzkiv/events{/privacy}","received_events_url":"https://api.github.com/users/dhritzkiv/received_events","type":"User","site_admin":false},"body":"True. At that point (in the Exporter), it's not actually empty, but has default values set. It's only in AssetWriter that those default values get pruned.","created_at":"2017-09-05T21:19:54Z","updated_at":"2017-09-05T21:19:54Z","html_url":"https://github.com/Matter-and-Form/assimp/pull/7#discussion_r137117567","pull_request_url":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/7","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/comments/137117567"},"html":{"href":"https://github.com/Matter-and-Form/assimp/pull/7#discussion_r137117567"},"pull_request":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/7"}},"in_reply_to_id":137112485},"pull_request":{"url":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/7","id":139348148,"html_url":"https://github.com/Matter-and-Form/assimp/pull/7","diff_url":"https://github.com/Matter-and-Form/assimp/pull/7.diff","patch_url":"https://github.com/Matter-and-Form/assimp/pull/7.patch","issue_url":"https://api.github.com/repos/Matter-and-Form/assimp/issues/7","number":7,"state":"open","locked":false,"title":"Feature/gltf2 importer","user":{"login":"johnmaf","id":20818991,"avatar_url":"https://avatars2.githubusercontent.com/u/20818991?v=4","gravatar_id":"","url":"https://api.github.com/users/johnmaf","html_url":"https://github.com/johnmaf","followers_url":"https://api.github.com/users/johnmaf/followers","following_url":"https://api.github.com/users/johnmaf/following{/other_user}","gists_url":"https://api.github.com/users/johnmaf/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmaf/subscriptions","organizations_url":"https://api.github.com/users/johnmaf/orgs","repos_url":"https://api.github.com/users/johnmaf/repos","events_url":"https://api.github.com/users/johnmaf/events{/privacy}","received_events_url":"https://api.github.com/users/johnmaf/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-05T15:07:23Z","updated_at":"2017-09-05T21:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c171d525ef24f8ff192bb79d4745d595dde842e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Matter-and-Form/assimp/issues/7/comments","statuses_url":"https://api.github.com/repos/Matter-and-Form/assimp/statuses/7048cfc154081bd3a7f8c304343ab573187f23e7","head":{"label":"Matter-and-Form:feature/gltf2-importer","ref":"feature/gltf2-importer","sha":"7048cfc154081bd3a7f8c304343ab573187f23e7","user":{"login":"Matter-and-Form","id":7966657,"avatar_url":"https://avatars2.githubusercontent.com/u/7966657?v=4","gravatar_id":"","url":"https://api.github.com/users/Matter-and-Form","html_url":"https://github.com/Matter-and-Form","followers_url":"https://api.github.com/users/Matter-and-Form/followers","following_url":"https://api.github.com/users/Matter-and-Form/following{/other_user}","gists_url":"https://api.github.com/users/Matter-and-Form/gists{/gist_id}","starred_url":"https://api.github.com/users/Matter-and-Form/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matter-and-Form/subscriptions","organizations_url":"https://api.github.com/users/Matter-and-Form/orgs","repos_url":"https://api.github.com/users/Matter-and-Form/repos","events_url":"https://api.github.com/users/Matter-and-Form/events{/privacy}","received_events_url":"https://api.github.com/users/Matter-and-Form/received_events","type":"Organization","site_admin":false},"repo":{"id":76380225,"name":"assimp","full_name":"Matter-and-Form/assimp","owner":{"login":"Matter-and-Form","id":7966657,"avatar_url":"https://avatars2.githubusercontent.com/u/7966657?v=4","gravatar_id":"","url":"https://api.github.com/users/Matter-and-Form","html_url":"https://github.com/Matter-and-Form","followers_url":"https://api.github.com/users/Matter-and-Form/followers","following_url":"https://api.github.com/users/Matter-and-Form/following{/other_user}","gists_url":"https://api.github.com/users/Matter-and-Form/gists{/gist_id}","starred_url":"https://api.github.com/users/Matter-and-Form/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matter-and-Form/subscriptions","organizations_url":"https://api.github.com/users/Matter-and-Form/orgs","repos_url":"https://api.github.com/users/Matter-and-Form/repos","events_url":"https://api.github.com/users/Matter-and-Form/events{/privacy}","received_events_url":"https://api.github.com/users/Matter-and-Form/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Matter-and-Form/assimp","description":"Official Open Asset Import Library Repository. Loads 40+ 3D file formats into one unified and clean data structure. ","fork":true,"url":"https://api.github.com/repos/Matter-and-Form/assimp","forks_url":"https://api.github.com/repos/Matter-and-Form/assimp/forks","keys_url":"https://api.github.com/repos/Matter-and-Form/assimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Matter-and-Form/assimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Matter-and-Form/assimp/teams","hooks_url":"https://api.github.com/repos/Matter-and-Form/assimp/hooks","issue_events_url":"https://api.github.com/repos/Matter-and-Form/assimp/issues/events{/number}","events_url":"https://api.github.com/repos/Matter-and-Form/assimp/events","assignees_url":"https://api.github.com/repos/Matter-and-Form/assimp/assignees{/user}","branches_url":"https://api.github.com/repos/Matter-and-Form/assimp/branches{/branch}","tags_url":"https://api.github.com/repos/Matter-and-Form/assimp/tags","blobs_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Matter-and-Form/assimp/statuses/{sha}","languages_url":"https://api.github.com/repos/Matter-and-Form/assimp/languages","stargazers_url":"https://api.github.com/repos/Matter-and-Form/assimp/stargazers","contributors_url":"https://api.github.com/repos/Matter-and-Form/assimp/contributors","subscribers_url":"https://api.github.com/repos/Matter-and-Form/assimp/subscribers","subscription_url":"https://api.github.com/repos/Matter-and-Form/assimp/subscription","commits_url":"https://api.github.com/repos/Matter-and-Form/assimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Matter-and-Form/assimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Matter-and-Form/assimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Matter-and-Form/assimp/contents/{+path}","compare_url":"https://api.github.com/repos/Matter-and-Form/assimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Matter-and-Form/assimp/merges","archive_url":"https://api.github.com/repos/Matter-and-Form/assimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Matter-and-Form/assimp/downloads","issues_url":"https://api.github.com/repos/Matter-and-Form/assimp/issues{/number}","pulls_url":"https://api.github.com/repos/Matter-and-Form/assimp/pulls{/number}","milestones_url":"https://api.github.com/repos/Matter-and-Form/assimp/milestones{/number}","notifications_url":"https://api.github.com/repos/Matter-and-Form/assimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Matter-and-Form/assimp/labels{/name}","releases_url":"https://api.github.com/repos/Matter-and-Form/assimp/releases{/id}","deployments_url":"https://api.github.com/repos/Matter-and-Form/assimp/deployments","created_at":"2016-12-13T17:01:21Z","updated_at":"2017-06-20T14:13:25Z","pushed_at":"2017-09-05T20:41:09Z","git_url":"git://github.com/Matter-and-Form/assimp.git","ssh_url":"[email protected]:Matter-and-Form/assimp.git","clone_url":"https://github.com/Matter-and-Form/assimp.git","svn_url":"https://github.com/Matter-and-Form/assimp","homepage":"http://www.assimp.org","size":151594,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Matter-and-Form:master","ref":"master","sha":"91f6a9a721e56fa026ff62a6722702e74e9bf1fe","user":{"login":"Matter-and-Form","id":7966657,"avatar_url":"https://avatars2.githubusercontent.com/u/7966657?v=4","gravatar_id":"","url":"https://api.github.com/users/Matter-and-Form","html_url":"https://github.com/Matter-and-Form","followers_url":"https://api.github.com/users/Matter-and-Form/followers","following_url":"https://api.github.com/users/Matter-and-Form/following{/other_user}","gists_url":"https://api.github.com/users/Matter-and-Form/gists{/gist_id}","starred_url":"https://api.github.com/users/Matter-and-Form/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matter-and-Form/subscriptions","organizations_url":"https://api.github.com/users/Matter-and-Form/orgs","repos_url":"https://api.github.com/users/Matter-and-Form/repos","events_url":"https://api.github.com/users/Matter-and-Form/events{/privacy}","received_events_url":"https://api.github.com/users/Matter-and-Form/received_events","type":"Organization","site_admin":false},"repo":{"id":76380225,"name":"assimp","full_name":"Matter-and-Form/assimp","owner":{"login":"Matter-and-Form","id":7966657,"avatar_url":"https://avatars2.githubusercontent.com/u/7966657?v=4","gravatar_id":"","url":"https://api.github.com/users/Matter-and-Form","html_url":"https://github.com/Matter-and-Form","followers_url":"https://api.github.com/users/Matter-and-Form/followers","following_url":"https://api.github.com/users/Matter-and-Form/following{/other_user}","gists_url":"https://api.github.com/users/Matter-and-Form/gists{/gist_id}","starred_url":"https://api.github.com/users/Matter-and-Form/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matter-and-Form/subscriptions","organizations_url":"https://api.github.com/users/Matter-and-Form/orgs","repos_url":"https://api.github.com/users/Matter-and-Form/repos","events_url":"https://api.github.com/users/Matter-and-Form/events{/privacy}","received_events_url":"https://api.github.com/users/Matter-and-Form/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Matter-and-Form/assimp","description":"Official Open Asset Import Library Repository. Loads 40+ 3D file formats into one unified and clean data structure. ","fork":true,"url":"https://api.github.com/repos/Matter-and-Form/assimp","forks_url":"https://api.github.com/repos/Matter-and-Form/assimp/forks","keys_url":"https://api.github.com/repos/Matter-and-Form/assimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Matter-and-Form/assimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Matter-and-Form/assimp/teams","hooks_url":"https://api.github.com/repos/Matter-and-Form/assimp/hooks","issue_events_url":"https://api.github.com/repos/Matter-and-Form/assimp/issues/events{/number}","events_url":"https://api.github.com/repos/Matter-and-Form/assimp/events","assignees_url":"https://api.github.com/repos/Matter-and-Form/assimp/assignees{/user}","branches_url":"https://api.github.com/repos/Matter-and-Form/assimp/branches{/branch}","tags_url":"https://api.github.com/repos/Matter-and-Form/assimp/tags","blobs_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Matter-and-Form/assimp/statuses/{sha}","languages_url":"https://api.github.com/repos/Matter-and-Form/assimp/languages","stargazers_url":"https://api.github.com/repos/Matter-and-Form/assimp/stargazers","contributors_url":"https://api.github.com/repos/Matter-and-Form/assimp/contributors","subscribers_url":"https://api.github.com/repos/Matter-and-Form/assimp/subscribers","subscription_url":"https://api.github.com/repos/Matter-and-Form/assimp/subscription","commits_url":"https://api.github.com/repos/Matter-and-Form/assimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Matter-and-Form/assimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Matter-and-Form/assimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Matter-and-Form/assimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Matter-and-Form/assimp/contents/{+path}","compare_url":"https://api.github.com/repos/Matter-and-Form/assimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Matter-and-Form/assimp/merges","archive_url":"https://api.github.com/repos/Matter-and-Form/assimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Matter-and-Form/assimp/downloads","issues_url":"https://api.github.com/repos/Matter-and-Form/assimp/issues{/number}","pulls_url":"https://api.github.com/repos/Matter-and-Form/assimp/pulls{/number}","milestones_url":"https://api.github.com/repos/Matter-and-Form/assimp/milestones{/number}","notifications_url":"https://api.github.com/repos/Matter-and-Form/assimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Matter-and-Form/assimp/labels{/name}","releases_url":"https://api.github.com/repos/Matter-and-Form/assimp/releases{/id}","deployments_url":"https://api.github.com/repos/Matter-and-Form/assimp/deployments","created_at":"2016-12-13T17:01:21Z","updated_at":"2017-06-20T14:13:25Z","pushed_at":"2017-09-05T20:41:09Z","git_url":"git://github.com/Matter-and-Form/assimp.git","ssh_url":"[email protected]:Matter-and-Form/assimp.git","clone_url":"https://github.com/Matter-and-Form/assimp.git","svn_url":"https://github.com/Matter-and-Form/assimp","homepage":"http://www.assimp.org","size":151594,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/7"},"html":{"href":"https://github.com/Matter-and-Form/assimp/pull/7"},"issue":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/issues/7"},"comments":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Matter-and-Form/assimp/statuses/7048cfc154081bd3a7f8c304343ab573187f23e7"}},"author_association":"COLLABORATOR"}} | {
"id": 76380225,
"name": "Matter-and-Form/assimp",
"url": "https://api.github.com/repos/Matter-and-Form/assimp"
} | {
"id": 1349865,
"login": "dhritzkiv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1349865?",
"url": "https://api.github.com/users/dhritzkiv"
} | {
"id": 7966657,
"login": "Matter-and-Form",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7966657?",
"url": "https://api.github.com/orgs/Matter-and-Form"
} | 2017-09-05T21:19:54 | 6553173720 | {"actor":{"display_login":"dhritzkiv"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/comments/106008878","pull_request_review_id":26912965,"id":106008878,"diff_hunk":"@@ -1269,77 +1267,114 @@ def make_query(self, _db, identifier_type, identifiers, log=None):\n 'Restricted to identifier type \"%s\".' % identifier_type\n )\n query = query.filter(Identifier.type==identifier_type)\n- '''\n- 'SELECT editions.id AS editions_id, editions.data_source_id AS editions_data_source_id, editions.primary_identifier_id AS editions_primary_identifier_id, \n- editions.title AS editions_title, editions.sort_title AS editions_sort_title, editions.subtitle AS editions_subtitle, editions.series AS editions_series, \n- editions.series_position AS editions_series_position, editions.permanent_work_id AS editions_permanent_work_id, editions.author AS editions_author, \n- editions.sort_author AS editions_sort_author, editions.language AS editions_language, editions.publisher AS editions_publisher, \n- editions.imprint AS editions_imprint, editions.issued AS editions_issued, editions.published AS editions_published, editions.medium AS editions_medium, \n- editions.cover_id AS editions_cover_id, editions.cover_full_url AS editions_cover_full_url, editions.cover_thumbnail_url AS editions_cover_thumbnail_url, \n- editions.open_access_download_url AS editions_open_access_download_url, editions.simple_opds_entry AS editions_simple_opds_entry, \n- editions.extra AS editions_extra \\n\n- FROM editions, identifiers \\n\n- WHERE editions.primary_identifier_id IN (:primary_identifier_id_1) AND identifiers.type = :type_1'\n- '''\n \n if log:\n log.info(\n \"Processing %d editions.\", query.count()\n )\n+ print \"Processing %d editions.\", query.count()\n+\n return query.order_by(Edition.id)\n \n \n def run(self, batch_size=10):\n param_args = self.parse_command_line(self._db)\n \n- #if param_args.identifiers:\n+ if param_args.identifiers:\n # we're asked about a specific set of work contributors\n- #identifier_ids = [x.id for x in param_args.identifiers]\n+ identifier_ids = [x.id for x in param_args.identifiers]\n \n self.query = self.make_query(\n self._db, param_args.identifier_type, param_args.identifiers, self.log\n )\n \n editions = True\n offset = 0\n+ output = \"ContributorID|\\tSortName|\\tDisplayName|\\tComputedSortName|\\tMatchRatio_Etc|\\tResolution\"\n+ print output.encode(\"utf8\")\n+\n while editions:\n- editions = self.query.offset(offset).limit(batch_size).all()\n+ my_query = self.query.offset(offset).limit(batch_size)\n+ editions = my_query.all()\n+\n for edition in editions:\n if edition.contributions:\n for contribution in edition.contributions:\n- self.process_contribution(self._db, contribution, edition)\n+ self.process_contribution(self._db, contribution, self.log)\n offset += batch_size\n+\n self._db.commit()\n self._db.commit()\n \n \n @classmethod\n- def process_contribution(cls, _db, contribution, edition):\n- if not contribution or not edition:\n+ def process_contribution(cls, _db, contribution, log=None):\n+ if not contribution or not contribution.edition:\n return\n \n contributor = contribution.contributor\n \n- identifier = edition.primary_identifier\n+ identifier = contribution.edition.primary_identifier\n+\n+ if contributor.sort_name and contributor.display_name:\n+ \n+ computed_sort_name_local_new = unicodedata.normalize(\"NFKD\", unicode(display_name_to_sort_name(contributor.display_name)))\n+ # Did HumanName parser produce a differet result from the plain comma replacement?\n+ if (contributor.sort_name.strip().lower() != computed_sort_name_local_new.strip().lower()):\n+ # computed names don't match. by how much? if it's a matter of a comma or a misplaced \n+ # suffix, we can fix without asking for human intervention. if the names are very different, \n+ # there's a chance the sort and display names are different on purpose, s.a. when foreign names \n+ # are passed as translated into only one of the fields, or when the author has a popular pseudonym. \n+ # best ask a human.\n+\n+ # if the relative lengths are off than by a stray space or comma, ask a human\n+ # it probably means that a human metadata professional had added an explanation/expansion to the \n+ # sort_name, s.a. \"Bob A. Jones\" --> \"Bob A. (Allan) Jones\", and we'd rather not replace this data \n+ # with the \"Jones, Bob A.\" that the auto-algorigthm would generate.\n+ length_difference = len(contributor.sort_name.strip()) - len(computed_sort_name_local_new.strip())\n+ if abs(length_difference) > 3:\n+ cls.register_problem(source=\"CheckContributorNamesInDB\", contribution=contribution, contributor=contributor, \n+ computed_sort_name=computed_sort_name_local_new, log=log)\n+ output = \"%s|\\t%s|\\t%s|\\t%s|\\tlength|\\tcomplain\" % (contributor.id, contributor.sort_name, contributor.display_name, computed_sort_name_local_new, match_ratio)\n+ print output.encode(\"utf8\")\n+ return\n+\n+ match_ratio = contributor_name_match_ratio(contributor.sort_name, computed_sort_name_local_new, normalize_names=False)\n+\n+ if (match_ratio < 40):\n+ # ask a human. this kind of score can happen when the sort_name is a transliteration of the display_name, \n+ # and is non-trivial to fix. \n+ cls.register_problem(source=\"CheckContributorNamesInDB\", contribution=contribution, contributor=contributor, \n+ computed_sort_name=computed_sort_name_local_new, log=log)\n+ output = \"%s|\\t%s|\\t%s|\\t%s|\\t%s|\\tcomplain\" % (contributor.id, contributor.sort_name, contributor.display_name, computed_sort_name_local_new, match_ratio)\n+ print output.encode(\"utf8\")\n+ else:\n+ # we can fix it!\n+ output = \"%s|\\t%s|\\t%s|\\t%s|\\t%s|\\tfix\" % (contributor.id, contributor.sort_name, contributor.display_name, computed_sort_name_local_new, match_ratio)\n+ print output.encode(\"utf8\")\n+\n+ contributor.sort_name = computed_sort_name_local_new\n \n- computed_sort_name_local = display_name_to_sort_name(contributor.display_name, advanced=True)\n- success = cls.check_sort_name(computed_sort_name_local, contributor, edition, DataSource.INTERNAL_PROCESSING, CoverageRecord.REPAIR_SORT_NAME_OPERATION)\n- if not success:\n- output = \"Contributor[%s]: contributor_sort_name=%s, contributor_display_name=%s: INTERNAL MISMATCH\" % (contributor.id, contributor.sort_name, contributor.display_name)\n- print output.encode(\"utf8\")\n+ # also change edition.sort_author, if the author was primary\n+ edition_contributors = contribution.edition.author_contributors\n+ if (len(edition_contributors) > 0 and (edition_contributors[0].id == contributor.id)):\n+ contribution.edition.sort_author = computed_sort_name_local_new","path":"scripts.py","position":null,"original_position":205,"commit_id":"b8203389a167e78b23c79f17db6f2871f61ed035","original_commit_id":"b8203389a167e78b23c79f17db6f2871f61ed035","user":{"login":"leonardr","id":662474,"avatar_url":"https://avatars3.githubusercontent.com/u/662474?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardr","html_url":"https://github.com/leonardr","followers_url":"https://api.github.com/users/leonardr/followers","following_url":"https://api.github.com/users/leonardr/following{/other_user}","gists_url":"https://api.github.com/users/leonardr/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardr/subscriptions","organizations_url":"https://api.github.com/users/leonardr/orgs","repos_url":"https://api.github.com/users/leonardr/repos","events_url":"https://api.github.com/users/leonardr/events{/privacy}","received_events_url":"https://api.github.com/users/leonardr/received_events","type":"User","site_admin":false},"body":"I would expect calculate_author() to manage Edition.sort_author. Is there a reason why it wouldn't work to set the contributor sort_name and then call Edition.calculate_author()?","created_at":"2017-03-14T19:46:27Z","updated_at":"2017-03-14T19:46:27Z","html_url":"https://github.com/NYPL-Simplified/server_core/pull/454#discussion_r106008878","pull_request_url":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/454","_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/comments/106008878"},"html":{"href":"https://github.com/NYPL-Simplified/server_core/pull/454#discussion_r106008878"},"pull_request":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/454"}}},"pull_request":{"url":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/454","id":104853603,"html_url":"https://github.com/NYPL-Simplified/server_core/pull/454","diff_url":"https://github.com/NYPL-Simplified/server_core/pull/454.diff","patch_url":"https://github.com/NYPL-Simplified/server_core/pull/454.patch","issue_url":"https://api.github.com/repos/NYPL-Simplified/server_core/issues/454","number":454,"state":"open","locked":false,"title":"Sort name cleaning","user":{"login":"daryanypl","id":18293410,"avatar_url":"https://avatars2.githubusercontent.com/u/18293410?v=3","gravatar_id":"","url":"https://api.github.com/users/daryanypl","html_url":"https://github.com/daryanypl","followers_url":"https://api.github.com/users/daryanypl/followers","following_url":"https://api.github.com/users/daryanypl/following{/other_user}","gists_url":"https://api.github.com/users/daryanypl/gists{/gist_id}","starred_url":"https://api.github.com/users/daryanypl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daryanypl/subscriptions","organizations_url":"https://api.github.com/users/daryanypl/orgs","repos_url":"https://api.github.com/users/daryanypl/repos","events_url":"https://api.github.com/users/daryanypl/events{/privacy}","received_events_url":"https://api.github.com/users/daryanypl/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-06T18:22:24Z","updated_at":"2017-03-14T19:46:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"833513ea5b025291def8061e7648186a078b2856","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/454/commits","review_comments_url":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/454/comments","review_comment_url":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYPL-Simplified/server_core/issues/454/comments","statuses_url":"https://api.github.com/repos/NYPL-Simplified/server_core/statuses/b8203389a167e78b23c79f17db6f2871f61ed035","head":{"label":"NYPL-Simplified:sort_name_cleaning","ref":"sort_name_cleaning","sha":"b8203389a167e78b23c79f17db6f2871f61ed035","user":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars2.githubusercontent.com/u/16416905?v=3","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":27601287,"name":"server_core","full_name":"NYPL-Simplified/server_core","owner":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars2.githubusercontent.com/u/16416905?v=3","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL-Simplified/server_core","description":"Shared data model and utilities for Library Simplified server applications","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/server_core","forks_url":"https://api.github.com/repos/NYPL-Simplified/server_core/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/server_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/server_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/server_core/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/server_core/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/server_core/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/server_core/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/server_core/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/server_core/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/server_core/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/server_core/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/server_core/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/server_core/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/server_core/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/server_core/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/server_core/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/server_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/server_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/server_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/server_core/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/server_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/server_core/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/server_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/server_core/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/server_core/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/server_core/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/server_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/server_core/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/server_core/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/server_core/deployments","created_at":"2014-12-05T17:03:04Z","updated_at":"2016-10-24T19:50:10Z","pushed_at":"2017-03-14T17:57:51Z","git_url":"git://github.com/NYPL-Simplified/server_core.git","ssh_url":"[email protected]:NYPL-Simplified/server_core.git","clone_url":"https://github.com/NYPL-Simplified/server_core.git","svn_url":"https://github.com/NYPL-Simplified/server_core","homepage":null,"size":5727,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":47,"forks":2,"open_issues":47,"watchers":0,"default_branch":"master"}},"base":{"label":"NYPL-Simplified:master","ref":"master","sha":"e1d034b540e2ca2890b982f14591274862cc59b0","user":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars2.githubusercontent.com/u/16416905?v=3","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":27601287,"name":"server_core","full_name":"NYPL-Simplified/server_core","owner":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars2.githubusercontent.com/u/16416905?v=3","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL-Simplified/server_core","description":"Shared data model and utilities for Library Simplified server applications","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/server_core","forks_url":"https://api.github.com/repos/NYPL-Simplified/server_core/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/server_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/server_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/server_core/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/server_core/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/server_core/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/server_core/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/server_core/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/server_core/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/server_core/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/server_core/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/server_core/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/server_core/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/server_core/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/server_core/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/server_core/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/server_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/server_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/server_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/server_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/server_core/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/server_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/server_core/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/server_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/server_core/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/server_core/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/server_core/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/server_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/server_core/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/server_core/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/server_core/deployments","created_at":"2014-12-05T17:03:04Z","updated_at":"2016-10-24T19:50:10Z","pushed_at":"2017-03-14T17:57:51Z","git_url":"git://github.com/NYPL-Simplified/server_core.git","ssh_url":"[email protected]:NYPL-Simplified/server_core.git","clone_url":"https://github.com/NYPL-Simplified/server_core.git","svn_url":"https://github.com/NYPL-Simplified/server_core","homepage":null,"size":5727,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":47,"forks":2,"open_issues":47,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/454"},"html":{"href":"https://github.com/NYPL-Simplified/server_core/pull/454"},"issue":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/issues/454"},"comments":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/issues/454/comments"},"review_comments":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/454/comments"},"review_comment":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/pulls/454/commits"},"statuses":{"href":"https://api.github.com/repos/NYPL-Simplified/server_core/statuses/b8203389a167e78b23c79f17db6f2871f61ed035"}}}} | {
"id": 27601287,
"name": "NYPL-Simplified/server_core",
"url": "https://api.github.com/repos/NYPL-Simplified/server_core"
} | {
"id": 662474,
"login": "leonardr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/662474?",
"url": "https://api.github.com/users/leonardr"
} | {
"id": 16416905,
"login": "NYPL-Simplified",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16416905?",
"url": "https://api.github.com/orgs/NYPL-Simplified"
} | 2017-03-14T19:46:27 | 5492974120 | {"actor":{"display_login":"leonardr"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments/104765195","pull_request_review_id":25616410,"id":104765195,"diff_hunk":"@@ -312,6 +324,55 @@ protected override void OnLoad( EventArgs e )\n pnlDupWarning.Visible = false;\n nbSaveAccount.Visible = false;\n \n+ string accountParameterType = string.Empty;\n+ using ( var rockContext = new RockContext() )\n+ {\n+ if ( !string.IsNullOrWhiteSpace( PageParameter( \"account\" ) ) )\n+ {\n+ List<int> accountParameter = new List<int>();\n+ accountParameterType = \"invalid\";\n+ foreach ( string acctId in PageParameter( \"account\" ).Split( ',' ) )\n+ {\n+ int id = 0;\n+ if ( int.TryParse( acctId, out id ) )\n+ {\n+ accountParameter.Add( id );\n+ }\n+ }\n+ _parameterAccounts = new FinancialAccountService( rockContext ).Queryable()\n+ .Where( f =>\n+ accountParameter.Contains( f.Id ) &&\n+ f.IsActive &&\n+ (f.StartDate == null || f.StartDate <= RockDateTime.Today) &&\n+ (f.EndDate == null || f.EndDate >= RockDateTime.Today) ).ToList();\n+ if ( _parameterAccounts.Count > 0 )\n+ {\n+ accountParameterType = \"valid\";\n+ }\n+ }\n+ if ( !string.IsNullOrWhiteSpace( PageParameter( \"glaccount\" ) ) )\n+ {\n+ List<string> glAccountParameter = PageParameter( \"glaccount\" ).Split( ',' ).ToList();\n+ _parameterAccounts.AddRange( new FinancialAccountService( rockContext ).Queryable()\n+ .Where( f =>\n+ glAccountParameter.Contains( f.GlCode ) &&\n+ f.IsActive &&","path":"RockWeb/Blocks/Finance/TransactionEntry.ascx.cs","position":69,"original_position":69,"commit_id":"56a1fb445d9f895c73f6ce93e392c4d839ba0e9b","original_commit_id":"56a1fb445d9f895c73f6ce93e392c4d839ba0e9b","user":{"login":"treyhendon","id":3513589,"avatar_url":"https://avatars2.githubusercontent.com/u/3513589?v=3","gravatar_id":"","url":"https://api.github.com/users/treyhendon","html_url":"https://github.com/treyhendon","followers_url":"https://api.github.com/users/treyhendon/followers","following_url":"https://api.github.com/users/treyhendon/following{/other_user}","gists_url":"https://api.github.com/users/treyhendon/gists{/gist_id}","starred_url":"https://api.github.com/users/treyhendon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treyhendon/subscriptions","organizations_url":"https://api.github.com/users/treyhendon/orgs","repos_url":"https://api.github.com/users/treyhendon/repos","events_url":"https://api.github.com/users/treyhendon/events{/privacy}","received_events_url":"https://api.github.com/users/treyhendon/received_events","type":"User","site_admin":false},"body":"I added that flag and have also added a Block Setting that will let you bypass if desired. The primary use case of this is for some Missionary Accounts that we don't want displayed on the default Contribution page.","created_at":"2017-03-07T20:03:49Z","updated_at":"2017-03-07T20:03:49Z","html_url":"https://github.com/SparkDevNetwork/Rock/pull/2034#discussion_r104765195","pull_request_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2034","_links":{"self":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments/104765195"},"html":{"href":"https://github.com/SparkDevNetwork/Rock/pull/2034#discussion_r104765195"},"pull_request":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2034"}}},"pull_request":{"url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2034","id":106844839,"html_url":"https://github.com/SparkDevNetwork/Rock/pull/2034","diff_url":"https://github.com/SparkDevNetwork/Rock/pull/2034.diff","patch_url":"https://github.com/SparkDevNetwork/Rock/pull/2034.patch","issue_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/2034","number":2034,"state":"open","locked":false,"title":"Added Features to the Transaction Entry Block","user":{"login":"treyhendon","id":3513589,"avatar_url":"https://avatars2.githubusercontent.com/u/3513589?v=3","gravatar_id":"","url":"https://api.github.com/users/treyhendon","html_url":"https://github.com/treyhendon","followers_url":"https://api.github.com/users/treyhendon/followers","following_url":"https://api.github.com/users/treyhendon/following{/other_user}","gists_url":"https://api.github.com/users/treyhendon/gists{/gist_id}","starred_url":"https://api.github.com/users/treyhendon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treyhendon/subscriptions","organizations_url":"https://api.github.com/users/treyhendon/orgs","repos_url":"https://api.github.com/users/treyhendon/repos","events_url":"https://api.github.com/users/treyhendon/events{/privacy}","received_events_url":"https://api.github.com/users/treyhendon/received_events","type":"User","site_admin":false},"body":"Added Campus Context options, URL Param Values to Attribute Values, and URL Param to Selected Account list in the Transaction Entry block.\n\n# Contributor Agreement\n_Have you filled out and sent your [Spark Contributor Agreement](http://www.rockrms.com/Content/RockExternal/Misc/Contributor Agreement.pdf) to secretary [at] sparkdevnetwork.org?_\nYes\n\n# Context\n_What is the problem you encountered that lead to you creating this pull request?_\n**Two problems:**\n1. Needed to control the list of Accounts displayed and save Transaction Attribute Values all via URL Params for third party integration.\n2. Needed to have the Campus Context apply to the Account List when not controlling list of Accounts via URL.\n\n# Goal\n_What will this pull request achieve and how will this fix the problem?_\n**Three main goals:**\n1. URL Parameter to control displayed Accounts.\n2. URL Parameter Values saved to Transaction Attribute Values.\n3. Campus Context options when block is in \"normal\" use.\n\n# Strategy\n_How have you implemented your solution?_\nAdded campus context and parameter processing to the Selected Accounts and Available Accounts population logic.\n\n# Possible Implications\n_What could this change potentially impact? Are there any security considerations? Where could this potentially affect backwards compatibility?_\nShould be none. The Account List URL param is the starting list and rules like start/end date and IsPublic are still respected. Also, the Campus Context filter defaults to being turned off.\n\n# Screenshots\n_Provide us some screenshots if your pull request either alters existing UI or provides new UI. Arrows and labels are helpful._\n\n\n\n\n# Documentation\n_If your change effects the UI or needs to be documented in one of the existing [user guides](http://www.rockrms.com/Learn/Documentation), please provide the brief write-up here:_","created_at":"2017-02-18T02:46:08Z","updated_at":"2017-03-07T20:03:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31e7c741d0c96a6728eb01e96a924419a7b6a9c0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2034/commits","review_comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2034/comments","review_comment_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/2034/comments","statuses_url":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/56a1fb445d9f895c73f6ce93e392c4d839ba0e9b","head":{"label":"treyhendon:feature-th-transactionEntryURLParams","ref":"feature-th-transactionEntryURLParams","sha":"56a1fb445d9f895c73f6ce93e392c4d839ba0e9b","user":{"login":"treyhendon","id":3513589,"avatar_url":"https://avatars2.githubusercontent.com/u/3513589?v=3","gravatar_id":"","url":"https://api.github.com/users/treyhendon","html_url":"https://github.com/treyhendon","followers_url":"https://api.github.com/users/treyhendon/followers","following_url":"https://api.github.com/users/treyhendon/following{/other_user}","gists_url":"https://api.github.com/users/treyhendon/gists{/gist_id}","starred_url":"https://api.github.com/users/treyhendon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treyhendon/subscriptions","organizations_url":"https://api.github.com/users/treyhendon/orgs","repos_url":"https://api.github.com/users/treyhendon/repos","events_url":"https://api.github.com/users/treyhendon/events{/privacy}","received_events_url":"https://api.github.com/users/treyhendon/received_events","type":"User","site_admin":false},"repo":{"id":25554358,"name":"Rock","full_name":"treyhendon/Rock","owner":{"login":"treyhendon","id":3513589,"avatar_url":"https://avatars2.githubusercontent.com/u/3513589?v=3","gravatar_id":"","url":"https://api.github.com/users/treyhendon","html_url":"https://github.com/treyhendon","followers_url":"https://api.github.com/users/treyhendon/followers","following_url":"https://api.github.com/users/treyhendon/following{/other_user}","gists_url":"https://api.github.com/users/treyhendon/gists{/gist_id}","starred_url":"https://api.github.com/users/treyhendon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treyhendon/subscriptions","organizations_url":"https://api.github.com/users/treyhendon/orgs","repos_url":"https://api.github.com/users/treyhendon/repos","events_url":"https://api.github.com/users/treyhendon/events{/privacy}","received_events_url":"https://api.github.com/users/treyhendon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/treyhendon/Rock","description":"An open source CMS, Relationship Management System (RMS) and composable application framework.","fork":true,"url":"https://api.github.com/repos/treyhendon/Rock","forks_url":"https://api.github.com/repos/treyhendon/Rock/forks","keys_url":"https://api.github.com/repos/treyhendon/Rock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/treyhendon/Rock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/treyhendon/Rock/teams","hooks_url":"https://api.github.com/repos/treyhendon/Rock/hooks","issue_events_url":"https://api.github.com/repos/treyhendon/Rock/issues/events{/number}","events_url":"https://api.github.com/repos/treyhendon/Rock/events","assignees_url":"https://api.github.com/repos/treyhendon/Rock/assignees{/user}","branches_url":"https://api.github.com/repos/treyhendon/Rock/branches{/branch}","tags_url":"https://api.github.com/repos/treyhendon/Rock/tags","blobs_url":"https://api.github.com/repos/treyhendon/Rock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/treyhendon/Rock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/treyhendon/Rock/git/refs{/sha}","trees_url":"https://api.github.com/repos/treyhendon/Rock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/treyhendon/Rock/statuses/{sha}","languages_url":"https://api.github.com/repos/treyhendon/Rock/languages","stargazers_url":"https://api.github.com/repos/treyhendon/Rock/stargazers","contributors_url":"https://api.github.com/repos/treyhendon/Rock/contributors","subscribers_url":"https://api.github.com/repos/treyhendon/Rock/subscribers","subscription_url":"https://api.github.com/repos/treyhendon/Rock/subscription","commits_url":"https://api.github.com/repos/treyhendon/Rock/commits{/sha}","git_commits_url":"https://api.github.com/repos/treyhendon/Rock/git/commits{/sha}","comments_url":"https://api.github.com/repos/treyhendon/Rock/comments{/number}","issue_comment_url":"https://api.github.com/repos/treyhendon/Rock/issues/comments{/number}","contents_url":"https://api.github.com/repos/treyhendon/Rock/contents/{+path}","compare_url":"https://api.github.com/repos/treyhendon/Rock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/treyhendon/Rock/merges","archive_url":"https://api.github.com/repos/treyhendon/Rock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/treyhendon/Rock/downloads","issues_url":"https://api.github.com/repos/treyhendon/Rock/issues{/number}","pulls_url":"https://api.github.com/repos/treyhendon/Rock/pulls{/number}","milestones_url":"https://api.github.com/repos/treyhendon/Rock/milestones{/number}","notifications_url":"https://api.github.com/repos/treyhendon/Rock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/treyhendon/Rock/labels{/name}","releases_url":"https://api.github.com/repos/treyhendon/Rock/releases{/id}","deployments_url":"https://api.github.com/repos/treyhendon/Rock/deployments","created_at":"2014-10-22T01:03:23Z","updated_at":"2016-07-08T14:35:59Z","pushed_at":"2017-03-07T00:50:20Z","git_url":"git://github.com/treyhendon/Rock.git","ssh_url":"[email protected]:treyhendon/Rock.git","clone_url":"https://github.com/treyhendon/Rock.git","svn_url":"https://github.com/treyhendon/Rock","homepage":"www.rockrms.com","size":1131414,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SparkDevNetwork:develop","ref":"develop","sha":"29172ee1f8b86ba652024fbf19b7642c0e6fde2c","user":{"login":"SparkDevNetwork","id":548191,"avatar_url":"https://avatars1.githubusercontent.com/u/548191?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkDevNetwork","html_url":"https://github.com/SparkDevNetwork","followers_url":"https://api.github.com/users/SparkDevNetwork/followers","following_url":"https://api.github.com/users/SparkDevNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparkDevNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkDevNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkDevNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparkDevNetwork/orgs","repos_url":"https://api.github.com/users/SparkDevNetwork/repos","events_url":"https://api.github.com/users/SparkDevNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparkDevNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":1614137,"name":"Rock","full_name":"SparkDevNetwork/Rock","owner":{"login":"SparkDevNetwork","id":548191,"avatar_url":"https://avatars1.githubusercontent.com/u/548191?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkDevNetwork","html_url":"https://github.com/SparkDevNetwork","followers_url":"https://api.github.com/users/SparkDevNetwork/followers","following_url":"https://api.github.com/users/SparkDevNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparkDevNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkDevNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkDevNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparkDevNetwork/orgs","repos_url":"https://api.github.com/users/SparkDevNetwork/repos","events_url":"https://api.github.com/users/SparkDevNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparkDevNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SparkDevNetwork/Rock","description":"An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.","fork":false,"url":"https://api.github.com/repos/SparkDevNetwork/Rock","forks_url":"https://api.github.com/repos/SparkDevNetwork/Rock/forks","keys_url":"https://api.github.com/repos/SparkDevNetwork/Rock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SparkDevNetwork/Rock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SparkDevNetwork/Rock/teams","hooks_url":"https://api.github.com/repos/SparkDevNetwork/Rock/hooks","issue_events_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/events{/number}","events_url":"https://api.github.com/repos/SparkDevNetwork/Rock/events","assignees_url":"https://api.github.com/repos/SparkDevNetwork/Rock/assignees{/user}","branches_url":"https://api.github.com/repos/SparkDevNetwork/Rock/branches{/branch}","tags_url":"https://api.github.com/repos/SparkDevNetwork/Rock/tags","blobs_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/refs{/sha}","trees_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/{sha}","languages_url":"https://api.github.com/repos/SparkDevNetwork/Rock/languages","stargazers_url":"https://api.github.com/repos/SparkDevNetwork/Rock/stargazers","contributors_url":"https://api.github.com/repos/SparkDevNetwork/Rock/contributors","subscribers_url":"https://api.github.com/repos/SparkDevNetwork/Rock/subscribers","subscription_url":"https://api.github.com/repos/SparkDevNetwork/Rock/subscription","commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/commits{/sha}","git_commits_url":"https://api.github.com/repos/SparkDevNetwork/Rock/git/commits{/sha}","comments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/comments{/number}","issue_comment_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/comments{/number}","contents_url":"https://api.github.com/repos/SparkDevNetwork/Rock/contents/{+path}","compare_url":"https://api.github.com/repos/SparkDevNetwork/Rock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SparkDevNetwork/Rock/merges","archive_url":"https://api.github.com/repos/SparkDevNetwork/Rock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SparkDevNetwork/Rock/downloads","issues_url":"https://api.github.com/repos/SparkDevNetwork/Rock/issues{/number}","pulls_url":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls{/number}","milestones_url":"https://api.github.com/repos/SparkDevNetwork/Rock/milestones{/number}","notifications_url":"https://api.github.com/repos/SparkDevNetwork/Rock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SparkDevNetwork/Rock/labels{/name}","releases_url":"https://api.github.com/repos/SparkDevNetwork/Rock/releases{/id}","deployments_url":"https://api.github.com/repos/SparkDevNetwork/Rock/deployments","created_at":"2011-04-14T13:11:46Z","updated_at":"2017-03-07T18:06:01Z","pushed_at":"2017-03-07T19:07:58Z","git_url":"git://github.com/SparkDevNetwork/Rock.git","ssh_url":"[email protected]:SparkDevNetwork/Rock.git","clone_url":"https://github.com/SparkDevNetwork/Rock.git","svn_url":"https://github.com/SparkDevNetwork/Rock","homepage":"http://www.rockrms.com","size":1166526,"stargazers_count":199,"watchers_count":199,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":142,"mirror_url":null,"open_issues_count":229,"forks":142,"open_issues":229,"watchers":199,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2034"},"html":{"href":"https://github.com/SparkDevNetwork/Rock/pull/2034"},"issue":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/2034"},"comments":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/issues/2034/comments"},"review_comments":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2034/comments"},"review_comment":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/pulls/2034/commits"},"statuses":{"href":"https://api.github.com/repos/SparkDevNetwork/Rock/statuses/56a1fb445d9f895c73f6ce93e392c4d839ba0e9b"}}}} | {
"id": 1614137,
"name": "SparkDevNetwork/Rock",
"url": "https://api.github.com/repos/SparkDevNetwork/Rock"
} | {
"id": 3513589,
"login": "treyhendon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3513589?",
"url": "https://api.github.com/users/treyhendon"
} | {
"id": 548191,
"login": "SparkDevNetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/548191?",
"url": "https://api.github.com/orgs/SparkDevNetwork"
} | 2017-03-07T20:03:49 | 5450234306 | {"actor":{"display_login":"treyhendon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/TykTechnologies/tyk/pulls/comments/113878370","pull_request_review_id":35303231,"id":113878370,"diff_hunk":"@@ -750,6 +750,50 @@ func TestQuota(t *testing.T) {\n \t}\n }\n \n+func TestDistributedQuotaSingleNode(t *testing.T) {\n+\tspec := createSpecTest(t, nonExpiringDefNoWhiteList)\n+\tsession := createQuotaSession()\n+\tkeyId := testKey(t, \"key\")\n+\tspec.SessionManager.UpdateSession(keyId, session, 60)\n+\tdefer spec.SessionManager.ResetQuota(keyId, session)\n+\n+\trecorder := httptest.NewRecorder()\n+\tparam := make(url.Values)\n+\treq, err := http.NewRequest(\"GET\", param.Encode(), nil)","path":"gateway_test.go","position":13,"original_position":13,"commit_id":"0aa83273284dc7754eb1e00913df4b54c2a17439","original_commit_id":"0aa83273284dc7754eb1e00913df4b54c2a17439","user":{"login":"lonelycode","id":2444409,"avatar_url":"https://avatars3.githubusercontent.com/u/2444409?v=3","gravatar_id":"","url":"https://api.github.com/users/lonelycode","html_url":"https://github.com/lonelycode","followers_url":"https://api.github.com/users/lonelycode/followers","following_url":"https://api.github.com/users/lonelycode/following{/other_user}","gists_url":"https://api.github.com/users/lonelycode/gists{/gist_id}","starred_url":"https://api.github.com/users/lonelycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonelycode/subscriptions","organizations_url":"https://api.github.com/users/lonelycode/orgs","repos_url":"https://api.github.com/users/lonelycode/repos","events_url":"https://api.github.com/users/lonelycode/events{/privacy}","received_events_url":"https://api.github.com/users/lonelycode/received_events","type":"User","site_admin":false},"body":"Nothing probably - copypasta, will fix.","created_at":"2017-04-28T08:28:44Z","updated_at":"2017-04-28T08:28:44Z","html_url":"https://github.com/TykTechnologies/tyk/pull/696#discussion_r113878370","pull_request_url":"https://api.github.com/repos/TykTechnologies/tyk/pulls/696","_links":{"self":{"href":"https://api.github.com/repos/TykTechnologies/tyk/pulls/comments/113878370"},"html":{"href":"https://github.com/TykTechnologies/tyk/pull/696#discussion_r113878370"},"pull_request":{"href":"https://api.github.com/repos/TykTechnologies/tyk/pulls/696"}}},"pull_request":{"url":"https://api.github.com/repos/TykTechnologies/tyk/pulls/696","id":117820449,"html_url":"https://github.com/TykTechnologies/tyk/pull/696","diff_url":"https://github.com/TykTechnologies/tyk/pull/696.diff","patch_url":"https://github.com/TykTechnologies/tyk/pull/696.patch","issue_url":"https://api.github.com/repos/TykTechnologies/tyk/issues/696","number":696,"state":"open","locked":false,"title":"Squashed distributed quota branch","user":{"login":"lonelycode","id":2444409,"avatar_url":"https://avatars3.githubusercontent.com/u/2444409?v=3","gravatar_id":"","url":"https://api.github.com/users/lonelycode","html_url":"https://github.com/lonelycode","followers_url":"https://api.github.com/users/lonelycode/followers","following_url":"https://api.github.com/users/lonelycode/following{/other_user}","gists_url":"https://api.github.com/users/lonelycode/gists{/gist_id}","starred_url":"https://api.github.com/users/lonelycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonelycode/subscriptions","organizations_url":"https://api.github.com/users/lonelycode/orgs","repos_url":"https://api.github.com/users/lonelycode/repos","events_url":"https://api.github.com/users/lonelycode/events{/privacy}","received_events_url":"https://api.github.com/users/lonelycode/received_events","type":"User","site_admin":false},"body":"(This is a squashed version of #674, which is closed)\r\n\r\nOk this is a complicated one.\r\n\r\nDistributed Quota feature (lets call it a beta): instead of having the quota enforced by a shared counter in redis, the counter is in-memory and counters are shared across a message bus to other cluster gateways, then merged, to create a distributed total. This means no centralised state and no one-to-one linkage with Redis.\r\n\r\n**What we are trying to achieve:**\r\n\r\n1. Stop having a one-to-one relationship with redis, when a counter-based quota is enforced, every inbound request means a roundtrip to redis, this is expensive and adds latency, even if done async it floods the redis connection counter pool and means performance degrades as traffic increases\r\n2. Make counter operations faster: Since these are in-memory and are merged in the background, the counter is entirely in-memory and no round-trip or lookup is required. This should improve throughput for metered connections\r\n3. The new DQ Quota object means that actually we can introduce new metering metrics because it is an abstraction\r\n4. Managed redis writes (or any persistence), since the distributed cluster, with a single leader, will only write to the store every `x` interval (default to 3 seconds), so no matter how high the load, the writes speed isn't a linear relation to throughput.\r\n\r\nTo enable set the following in `tyk.conf`:\r\n\r\n- `use_distributed_counter` to `true`: This enables the feature \r\n- `distributed_quota_set_master` to `true`: Since we only have redis as a pub/sub mechanism at the moment, we need all nodes to be masters, this causes all nodes to persist the CRDT list and is therefore fault tolerant. This is optional, obviously, if you can be completely sure that your master will not fail - so long as one node is set as master we are clear.\r\n\r\nIt will work in single-host mode just like a regular quota.\r\n\r\nThere is a unit test, but multi-host testing was done manually, as well a failure conditions:\r\n\r\n*Manual testing procedure:*\r\n\r\nThis is best done with a docker env because you need to generate a network of gateways.\r\n\r\n1. Start 3 gateways against a dashboard and configure an API that uses token auth\r\n2. Set up a gateway in CE mode and create an open API that round robins to the 3 other gateways, we are basically forcing distributed access via the CE gateway\r\n3. Create a token with a quota inthe distributed nodes (dashboard)\r\n4. Send traffic to the CE gateway APi that is round-robinning to the 3 nodes\r\n5. Watch the returned headers of the response, there will be an X-Ratelimit-Remaining header that should count down\r\n6. Ensure that an error is returned once you reach the quota\r\n\r\nNote: The countdown is only partially accurate due to the distributed persistence, *however* the quota *will* be enforced accurately.\r\n\r\nFurther testing should then be the above procedure but with the following changes:\r\n\r\n1. Start the cluster, then stop all instances mid-test, then start again\r\n2. Start the cluster, kill one of the 3 nodes and then start it again while sending traffic (the requests will fail when the request hits a dead server, but that doesn;t matter, the quota should count down and continue to be enforced when it remains down AND when it is brought back online).","created_at":"2017-04-26T22:05:29Z","updated_at":"2017-04-28T08:28:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a065fbc48e4a3ed2bbb2320469c608a537b3005","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TykTechnologies/tyk/pulls/696/commits","review_comments_url":"https://api.github.com/repos/TykTechnologies/tyk/pulls/696/comments","review_comment_url":"https://api.github.com/repos/TykTechnologies/tyk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TykTechnologies/tyk/issues/696/comments","statuses_url":"https://api.github.com/repos/TykTechnologies/tyk/statuses/0aa83273284dc7754eb1e00913df4b54c2a17439","head":{"label":"TykTechnologies:dq-squash","ref":"dq-squash","sha":"0aa83273284dc7754eb1e00913df4b54c2a17439","user":{"login":"TykTechnologies","id":16121529,"avatar_url":"https://avatars0.githubusercontent.com/u/16121529?v=3","gravatar_id":"","url":"https://api.github.com/users/TykTechnologies","html_url":"https://github.com/TykTechnologies","followers_url":"https://api.github.com/users/TykTechnologies/followers","following_url":"https://api.github.com/users/TykTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/TykTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/TykTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TykTechnologies/subscriptions","organizations_url":"https://api.github.com/users/TykTechnologies/orgs","repos_url":"https://api.github.com/users/TykTechnologies/repos","events_url":"https://api.github.com/users/TykTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/TykTechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":19537979,"name":"tyk","full_name":"TykTechnologies/tyk","owner":{"login":"TykTechnologies","id":16121529,"avatar_url":"https://avatars0.githubusercontent.com/u/16121529?v=3","gravatar_id":"","url":"https://api.github.com/users/TykTechnologies","html_url":"https://github.com/TykTechnologies","followers_url":"https://api.github.com/users/TykTechnologies/followers","following_url":"https://api.github.com/users/TykTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/TykTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/TykTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TykTechnologies/subscriptions","organizations_url":"https://api.github.com/users/TykTechnologies/orgs","repos_url":"https://api.github.com/users/TykTechnologies/repos","events_url":"https://api.github.com/users/TykTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/TykTechnologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TykTechnologies/tyk","description":"Tyk Open Source API Gateway written in Go","fork":false,"url":"https://api.github.com/repos/TykTechnologies/tyk","forks_url":"https://api.github.com/repos/TykTechnologies/tyk/forks","keys_url":"https://api.github.com/repos/TykTechnologies/tyk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TykTechnologies/tyk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TykTechnologies/tyk/teams","hooks_url":"https://api.github.com/repos/TykTechnologies/tyk/hooks","issue_events_url":"https://api.github.com/repos/TykTechnologies/tyk/issues/events{/number}","events_url":"https://api.github.com/repos/TykTechnologies/tyk/events","assignees_url":"https://api.github.com/repos/TykTechnologies/tyk/assignees{/user}","branches_url":"https://api.github.com/repos/TykTechnologies/tyk/branches{/branch}","tags_url":"https://api.github.com/repos/TykTechnologies/tyk/tags","blobs_url":"https://api.github.com/repos/TykTechnologies/tyk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TykTechnologies/tyk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TykTechnologies/tyk/git/refs{/sha}","trees_url":"https://api.github.com/repos/TykTechnologies/tyk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TykTechnologies/tyk/statuses/{sha}","languages_url":"https://api.github.com/repos/TykTechnologies/tyk/languages","stargazers_url":"https://api.github.com/repos/TykTechnologies/tyk/stargazers","contributors_url":"https://api.github.com/repos/TykTechnologies/tyk/contributors","subscribers_url":"https://api.github.com/repos/TykTechnologies/tyk/subscribers","subscription_url":"https://api.github.com/repos/TykTechnologies/tyk/subscription","commits_url":"https://api.github.com/repos/TykTechnologies/tyk/commits{/sha}","git_commits_url":"https://api.github.com/repos/TykTechnologies/tyk/git/commits{/sha}","comments_url":"https://api.github.com/repos/TykTechnologies/tyk/comments{/number}","issue_comment_url":"https://api.github.com/repos/TykTechnologies/tyk/issues/comments{/number}","contents_url":"https://api.github.com/repos/TykTechnologies/tyk/contents/{+path}","compare_url":"https://api.github.com/repos/TykTechnologies/tyk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TykTechnologies/tyk/merges","archive_url":"https://api.github.com/repos/TykTechnologies/tyk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TykTechnologies/tyk/downloads","issues_url":"https://api.github.com/repos/TykTechnologies/tyk/issues{/number}","pulls_url":"https://api.github.com/repos/TykTechnologies/tyk/pulls{/number}","milestones_url":"https://api.github.com/repos/TykTechnologies/tyk/milestones{/number}","notifications_url":"https://api.github.com/repos/TykTechnologies/tyk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TykTechnologies/tyk/labels{/name}","releases_url":"https://api.github.com/repos/TykTechnologies/tyk/releases{/id}","deployments_url":"https://api.github.com/repos/TykTechnologies/tyk/deployments","created_at":"2014-05-07T14:38:24Z","updated_at":"2017-04-28T07:06:49Z","pushed_at":"2017-04-28T05:57:00Z","git_url":"git://github.com/TykTechnologies/tyk.git","ssh_url":"[email protected]:TykTechnologies/tyk.git","clone_url":"https://github.com/TykTechnologies/tyk.git","svn_url":"https://github.com/TykTechnologies/tyk","homepage":"","size":115266,"stargazers_count":1940,"watchers_count":1940,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":130,"forks":330,"open_issues":130,"watchers":1940,"default_branch":"master"}},"base":{"label":"TykTechnologies:master","ref":"master","sha":"408d9e5db663135a8d8af0ced58154733e63b867","user":{"login":"TykTechnologies","id":16121529,"avatar_url":"https://avatars0.githubusercontent.com/u/16121529?v=3","gravatar_id":"","url":"https://api.github.com/users/TykTechnologies","html_url":"https://github.com/TykTechnologies","followers_url":"https://api.github.com/users/TykTechnologies/followers","following_url":"https://api.github.com/users/TykTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/TykTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/TykTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TykTechnologies/subscriptions","organizations_url":"https://api.github.com/users/TykTechnologies/orgs","repos_url":"https://api.github.com/users/TykTechnologies/repos","events_url":"https://api.github.com/users/TykTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/TykTechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":19537979,"name":"tyk","full_name":"TykTechnologies/tyk","owner":{"login":"TykTechnologies","id":16121529,"avatar_url":"https://avatars0.githubusercontent.com/u/16121529?v=3","gravatar_id":"","url":"https://api.github.com/users/TykTechnologies","html_url":"https://github.com/TykTechnologies","followers_url":"https://api.github.com/users/TykTechnologies/followers","following_url":"https://api.github.com/users/TykTechnologies/following{/other_user}","gists_url":"https://api.github.com/users/TykTechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/TykTechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TykTechnologies/subscriptions","organizations_url":"https://api.github.com/users/TykTechnologies/orgs","repos_url":"https://api.github.com/users/TykTechnologies/repos","events_url":"https://api.github.com/users/TykTechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/TykTechnologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TykTechnologies/tyk","description":"Tyk Open Source API Gateway written in Go","fork":false,"url":"https://api.github.com/repos/TykTechnologies/tyk","forks_url":"https://api.github.com/repos/TykTechnologies/tyk/forks","keys_url":"https://api.github.com/repos/TykTechnologies/tyk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TykTechnologies/tyk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TykTechnologies/tyk/teams","hooks_url":"https://api.github.com/repos/TykTechnologies/tyk/hooks","issue_events_url":"https://api.github.com/repos/TykTechnologies/tyk/issues/events{/number}","events_url":"https://api.github.com/repos/TykTechnologies/tyk/events","assignees_url":"https://api.github.com/repos/TykTechnologies/tyk/assignees{/user}","branches_url":"https://api.github.com/repos/TykTechnologies/tyk/branches{/branch}","tags_url":"https://api.github.com/repos/TykTechnologies/tyk/tags","blobs_url":"https://api.github.com/repos/TykTechnologies/tyk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TykTechnologies/tyk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TykTechnologies/tyk/git/refs{/sha}","trees_url":"https://api.github.com/repos/TykTechnologies/tyk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TykTechnologies/tyk/statuses/{sha}","languages_url":"https://api.github.com/repos/TykTechnologies/tyk/languages","stargazers_url":"https://api.github.com/repos/TykTechnologies/tyk/stargazers","contributors_url":"https://api.github.com/repos/TykTechnologies/tyk/contributors","subscribers_url":"https://api.github.com/repos/TykTechnologies/tyk/subscribers","subscription_url":"https://api.github.com/repos/TykTechnologies/tyk/subscription","commits_url":"https://api.github.com/repos/TykTechnologies/tyk/commits{/sha}","git_commits_url":"https://api.github.com/repos/TykTechnologies/tyk/git/commits{/sha}","comments_url":"https://api.github.com/repos/TykTechnologies/tyk/comments{/number}","issue_comment_url":"https://api.github.com/repos/TykTechnologies/tyk/issues/comments{/number}","contents_url":"https://api.github.com/repos/TykTechnologies/tyk/contents/{+path}","compare_url":"https://api.github.com/repos/TykTechnologies/tyk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TykTechnologies/tyk/merges","archive_url":"https://api.github.com/repos/TykTechnologies/tyk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TykTechnologies/tyk/downloads","issues_url":"https://api.github.com/repos/TykTechnologies/tyk/issues{/number}","pulls_url":"https://api.github.com/repos/TykTechnologies/tyk/pulls{/number}","milestones_url":"https://api.github.com/repos/TykTechnologies/tyk/milestones{/number}","notifications_url":"https://api.github.com/repos/TykTechnologies/tyk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TykTechnologies/tyk/labels{/name}","releases_url":"https://api.github.com/repos/TykTechnologies/tyk/releases{/id}","deployments_url":"https://api.github.com/repos/TykTechnologies/tyk/deployments","created_at":"2014-05-07T14:38:24Z","updated_at":"2017-04-28T07:06:49Z","pushed_at":"2017-04-28T05:57:00Z","git_url":"git://github.com/TykTechnologies/tyk.git","ssh_url":"[email protected]:TykTechnologies/tyk.git","clone_url":"https://github.com/TykTechnologies/tyk.git","svn_url":"https://github.com/TykTechnologies/tyk","homepage":"","size":115266,"stargazers_count":1940,"watchers_count":1940,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":130,"forks":330,"open_issues":130,"watchers":1940,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TykTechnologies/tyk/pulls/696"},"html":{"href":"https://github.com/TykTechnologies/tyk/pull/696"},"issue":{"href":"https://api.github.com/repos/TykTechnologies/tyk/issues/696"},"comments":{"href":"https://api.github.com/repos/TykTechnologies/tyk/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/TykTechnologies/tyk/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/TykTechnologies/tyk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TykTechnologies/tyk/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/TykTechnologies/tyk/statuses/0aa83273284dc7754eb1e00913df4b54c2a17439"}}}} | {
"id": 19537979,
"name": "TykTechnologies/tyk",
"url": "https://api.github.com/repos/TykTechnologies/tyk"
} | {
"id": 2444409,
"login": "lonelycode",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2444409?",
"url": "https://api.github.com/users/lonelycode"
} | {
"id": 16121529,
"login": "TykTechnologies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16121529?",
"url": "https://api.github.com/orgs/TykTechnologies"
} | 2017-04-28T08:28:44 | 5774834964 | {"actor":{"display_login":"lonelycode"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bigdatagenomics/mango/pulls/comments/140322191","pull_request_review_id":64378401,"id":140322191,"diff_hunk":"@@ -176,5 +176,30 @@\n <artifactId>hadoop-bam</artifactId>\n <scope>compile</scope>\n </dependency>\n+ <dependency>\n+ <groupId>com.google.protobuf</groupId>\n+ <artifactId>protobuf-java</artifactId>\n+ <version>3.0.0-beta-3</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>com.google.protobuf</groupId>\n+ <artifactId>protobuf-java-util</artifactId>\n+ <version>3.0.0-beta-3</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.ga4gh</groupId>\n+ <artifactId>ga4gh-schemas</artifactId>\n+ <version>0.6.0a10</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.bdgenomics.convert</groupId>\n+ <artifactId>convert-ga4gh</artifactId>\n+ <version>0.2.0-SNAPSHOT</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.bdgenomics.convert</groupId>\n+ <artifactId>convert</artifactId>\n+ <version>0.2.0-SNAPSHOT</version>","path":"mango-core/pom.xml","position":27,"original_position":27,"commit_id":"ea575555009ca6019228797785e9c63bfd0cb803","original_commit_id":"ea575555009ca6019228797785e9c63bfd0cb803","user":{"login":"akmorrow13","id":6503416,"avatar_url":"https://avatars1.githubusercontent.com/u/6503416?v=4","gravatar_id":"","url":"https://api.github.com/users/akmorrow13","html_url":"https://github.com/akmorrow13","followers_url":"https://api.github.com/users/akmorrow13/followers","following_url":"https://api.github.com/users/akmorrow13/following{/other_user}","gists_url":"https://api.github.com/users/akmorrow13/gists{/gist_id}","starred_url":"https://api.github.com/users/akmorrow13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akmorrow13/subscriptions","organizations_url":"https://api.github.com/users/akmorrow13/orgs","repos_url":"https://api.github.com/users/akmorrow13/repos","events_url":"https://api.github.com/users/akmorrow13/events{/privacy}","received_events_url":"https://api.github.com/users/akmorrow13/received_events","type":"User","site_admin":false},"body":"this is dependent on a new release of bdg-convert.\r\nhttps://github.com/bigdatagenomics/bdg-convert/issues/36","created_at":"2017-09-21T18:23:27Z","updated_at":"2017-09-21T18:24:34Z","html_url":"https://github.com/bigdatagenomics/mango/pull/316#discussion_r140322191","pull_request_url":"https://api.github.com/repos/bigdatagenomics/mango/pulls/316","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/mango/pulls/comments/140322191"},"html":{"href":"https://github.com/bigdatagenomics/mango/pull/316#discussion_r140322191"},"pull_request":{"href":"https://api.github.com/repos/bigdatagenomics/mango/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/bigdatagenomics/mango/pulls/316","id":142411697,"html_url":"https://github.com/bigdatagenomics/mango/pull/316","diff_url":"https://github.com/bigdatagenomics/mango/pull/316.diff","patch_url":"https://github.com/bigdatagenomics/mango/pull/316.patch","issue_url":"https://api.github.com/repos/bigdatagenomics/mango/issues/316","number":316,"state":"open","locked":false,"title":"Add ga4gh converters and tests","user":{"login":"jpdna","id":7423296,"avatar_url":"https://avatars2.githubusercontent.com/u/7423296?v=4","gravatar_id":"","url":"https://api.github.com/users/jpdna","html_url":"https://github.com/jpdna","followers_url":"https://api.github.com/users/jpdna/followers","following_url":"https://api.github.com/users/jpdna/following{/other_user}","gists_url":"https://api.github.com/users/jpdna/gists{/gist_id}","starred_url":"https://api.github.com/users/jpdna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpdna/subscriptions","organizations_url":"https://api.github.com/users/jpdna/orgs","repos_url":"https://api.github.com/users/jpdna/repos","events_url":"https://api.github.com/users/jpdna/events{/privacy}","received_events_url":"https://api.github.com/users/jpdna/received_events","type":"User","site_admin":false},"body":"Depends on https://github.com/bigdatagenomics/bdg-convert/pull/35","created_at":"2017-09-21T18:20:02Z","updated_at":"2017-09-21T18:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5a546019fa247206702324edc8e93a7cb840234","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigdatagenomics/mango/pulls/316/commits","review_comments_url":"https://api.github.com/repos/bigdatagenomics/mango/pulls/316/comments","review_comment_url":"https://api.github.com/repos/bigdatagenomics/mango/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigdatagenomics/mango/issues/316/comments","statuses_url":"https://api.github.com/repos/bigdatagenomics/mango/statuses/ea575555009ca6019228797785e9c63bfd0cb803","head":{"label":"jpdna:ga4gh_on_master_Sept21","ref":"ga4gh_on_master_Sept21","sha":"ea575555009ca6019228797785e9c63bfd0cb803","user":{"login":"jpdna","id":7423296,"avatar_url":"https://avatars2.githubusercontent.com/u/7423296?v=4","gravatar_id":"","url":"https://api.github.com/users/jpdna","html_url":"https://github.com/jpdna","followers_url":"https://api.github.com/users/jpdna/followers","following_url":"https://api.github.com/users/jpdna/following{/other_user}","gists_url":"https://api.github.com/users/jpdna/gists{/gist_id}","starred_url":"https://api.github.com/users/jpdna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpdna/subscriptions","organizations_url":"https://api.github.com/users/jpdna/orgs","repos_url":"https://api.github.com/users/jpdna/repos","events_url":"https://api.github.com/users/jpdna/events{/privacy}","received_events_url":"https://api.github.com/users/jpdna/received_events","type":"User","site_admin":false},"repo":{"id":62752651,"name":"mango","full_name":"jpdna/mango","owner":{"login":"jpdna","id":7423296,"avatar_url":"https://avatars2.githubusercontent.com/u/7423296?v=4","gravatar_id":"","url":"https://api.github.com/users/jpdna","html_url":"https://github.com/jpdna","followers_url":"https://api.github.com/users/jpdna/followers","following_url":"https://api.github.com/users/jpdna/following{/other_user}","gists_url":"https://api.github.com/users/jpdna/gists{/gist_id}","starred_url":"https://api.github.com/users/jpdna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpdna/subscriptions","organizations_url":"https://api.github.com/users/jpdna/orgs","repos_url":"https://api.github.com/users/jpdna/repos","events_url":"https://api.github.com/users/jpdna/events{/privacy}","received_events_url":"https://api.github.com/users/jpdna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpdna/mango","description":"A scalable genome browser. Apache 2 licensed.","fork":true,"url":"https://api.github.com/repos/jpdna/mango","forks_url":"https://api.github.com/repos/jpdna/mango/forks","keys_url":"https://api.github.com/repos/jpdna/mango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpdna/mango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpdna/mango/teams","hooks_url":"https://api.github.com/repos/jpdna/mango/hooks","issue_events_url":"https://api.github.com/repos/jpdna/mango/issues/events{/number}","events_url":"https://api.github.com/repos/jpdna/mango/events","assignees_url":"https://api.github.com/repos/jpdna/mango/assignees{/user}","branches_url":"https://api.github.com/repos/jpdna/mango/branches{/branch}","tags_url":"https://api.github.com/repos/jpdna/mango/tags","blobs_url":"https://api.github.com/repos/jpdna/mango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpdna/mango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpdna/mango/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpdna/mango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpdna/mango/statuses/{sha}","languages_url":"https://api.github.com/repos/jpdna/mango/languages","stargazers_url":"https://api.github.com/repos/jpdna/mango/stargazers","contributors_url":"https://api.github.com/repos/jpdna/mango/contributors","subscribers_url":"https://api.github.com/repos/jpdna/mango/subscribers","subscription_url":"https://api.github.com/repos/jpdna/mango/subscription","commits_url":"https://api.github.com/repos/jpdna/mango/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpdna/mango/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpdna/mango/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpdna/mango/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpdna/mango/contents/{+path}","compare_url":"https://api.github.com/repos/jpdna/mango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpdna/mango/merges","archive_url":"https://api.github.com/repos/jpdna/mango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpdna/mango/downloads","issues_url":"https://api.github.com/repos/jpdna/mango/issues{/number}","pulls_url":"https://api.github.com/repos/jpdna/mango/pulls{/number}","milestones_url":"https://api.github.com/repos/jpdna/mango/milestones{/number}","notifications_url":"https://api.github.com/repos/jpdna/mango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpdna/mango/labels{/name}","releases_url":"https://api.github.com/repos/jpdna/mango/releases{/id}","deployments_url":"https://api.github.com/repos/jpdna/mango/deployments","created_at":"2016-07-06T20:54:42Z","updated_at":"2016-07-06T20:54:43Z","pushed_at":"2017-09-21T18:17:57Z","git_url":"git://github.com/jpdna/mango.git","ssh_url":"[email protected]:jpdna/mango.git","clone_url":"https://github.com/jpdna/mango.git","svn_url":"https://github.com/jpdna/mango","homepage":"","size":71442,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bigdatagenomics:master","ref":"master","sha":"d33471fee6b7863ed864a42ab7adc963422f4978","user":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars3.githubusercontent.com/u/5839438?v=4","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":31675394,"name":"mango","full_name":"bigdatagenomics/mango","owner":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars3.githubusercontent.com/u/5839438?v=4","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigdatagenomics/mango","description":"A scalable genome browser. Apache 2 licensed.","fork":false,"url":"https://api.github.com/repos/bigdatagenomics/mango","forks_url":"https://api.github.com/repos/bigdatagenomics/mango/forks","keys_url":"https://api.github.com/repos/bigdatagenomics/mango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigdatagenomics/mango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigdatagenomics/mango/teams","hooks_url":"https://api.github.com/repos/bigdatagenomics/mango/hooks","issue_events_url":"https://api.github.com/repos/bigdatagenomics/mango/issues/events{/number}","events_url":"https://api.github.com/repos/bigdatagenomics/mango/events","assignees_url":"https://api.github.com/repos/bigdatagenomics/mango/assignees{/user}","branches_url":"https://api.github.com/repos/bigdatagenomics/mango/branches{/branch}","tags_url":"https://api.github.com/repos/bigdatagenomics/mango/tags","blobs_url":"https://api.github.com/repos/bigdatagenomics/mango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigdatagenomics/mango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigdatagenomics/mango/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigdatagenomics/mango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigdatagenomics/mango/statuses/{sha}","languages_url":"https://api.github.com/repos/bigdatagenomics/mango/languages","stargazers_url":"https://api.github.com/repos/bigdatagenomics/mango/stargazers","contributors_url":"https://api.github.com/repos/bigdatagenomics/mango/contributors","subscribers_url":"https://api.github.com/repos/bigdatagenomics/mango/subscribers","subscription_url":"https://api.github.com/repos/bigdatagenomics/mango/subscription","commits_url":"https://api.github.com/repos/bigdatagenomics/mango/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigdatagenomics/mango/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigdatagenomics/mango/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigdatagenomics/mango/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigdatagenomics/mango/contents/{+path}","compare_url":"https://api.github.com/repos/bigdatagenomics/mango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigdatagenomics/mango/merges","archive_url":"https://api.github.com/repos/bigdatagenomics/mango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigdatagenomics/mango/downloads","issues_url":"https://api.github.com/repos/bigdatagenomics/mango/issues{/number}","pulls_url":"https://api.github.com/repos/bigdatagenomics/mango/pulls{/number}","milestones_url":"https://api.github.com/repos/bigdatagenomics/mango/milestones{/number}","notifications_url":"https://api.github.com/repos/bigdatagenomics/mango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigdatagenomics/mango/labels{/name}","releases_url":"https://api.github.com/repos/bigdatagenomics/mango/releases{/id}","deployments_url":"https://api.github.com/repos/bigdatagenomics/mango/deployments","created_at":"2015-03-04T19:24:20Z","updated_at":"2017-08-24T16:50:28Z","pushed_at":"2017-09-21T18:20:19Z","git_url":"git://github.com/bigdatagenomics/mango.git","ssh_url":"[email protected]:bigdatagenomics/mango.git","clone_url":"https://github.com/bigdatagenomics/mango.git","svn_url":"https://github.com/bigdatagenomics/mango","homepage":"","size":58874,"stargazers_count":47,"watchers_count":47,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":44,"forks":16,"open_issues":44,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/mango/pulls/316"},"html":{"href":"https://github.com/bigdatagenomics/mango/pull/316"},"issue":{"href":"https://api.github.com/repos/bigdatagenomics/mango/issues/316"},"comments":{"href":"https://api.github.com/repos/bigdatagenomics/mango/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/bigdatagenomics/mango/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/bigdatagenomics/mango/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigdatagenomics/mango/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/bigdatagenomics/mango/statuses/ea575555009ca6019228797785e9c63bfd0cb803"}},"author_association":"OWNER"}} | {
"id": 31675394,
"name": "bigdatagenomics/mango",
"url": "https://api.github.com/repos/bigdatagenomics/mango"
} | {
"id": 6503416,
"login": "akmorrow13",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6503416?",
"url": "https://api.github.com/users/akmorrow13"
} | {
"id": 5839438,
"login": "bigdatagenomics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5839438?",
"url": "https://api.github.com/orgs/bigdatagenomics"
} | 2017-09-21T18:23:27 | 6621239613 | {"actor":{"display_login":"akmorrow13"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/118735094","pull_request_review_id":40558571,"id":118735094,"diff_hunk":"@@ -87,8 +86,14 @@ private[adam] class AlignmentRecordArraySerializer extends IntervalArraySerializ\n }\n }\n \n-object AlignmentRecordRDD {\n+object AlignmentRecordRDD extends Serializable {\n \n+ /**\n+ * Builds an AlignmentRecordRDD for unaligned reads.\n+ *\n+ * @param rdd The underlying AlignmentRecord RDD.\n+ * @return A new AlignmentRecordRDD.\n+ */\n def unaligned(rdd: RDD[AlignmentRecord]): AlignmentRecordRDD = {\n AlignmentRecordRDD(rdd,\n SequenceDictionary.empty,","path":"adam-core/src/main/scala/org/bdgenomics/adam/rdd/read/AlignmentRecordRDD.scala","position":25,"original_position":25,"commit_id":"4f314aa38d998944fb07ab3271245e03ac2c5c12","original_commit_id":"4f314aa38d998944fb07ab3271245e03ac2c5c12","user":{"login":"heuermh","id":35293,"avatar_url":"https://avatars1.githubusercontent.com/u/35293?v=3","gravatar_id":"","url":"https://api.github.com/users/heuermh","html_url":"https://github.com/heuermh","followers_url":"https://api.github.com/users/heuermh/followers","following_url":"https://api.github.com/users/heuermh/following{/other_user}","gists_url":"https://api.github.com/users/heuermh/gists{/gist_id}","starred_url":"https://api.github.com/users/heuermh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuermh/subscriptions","organizations_url":"https://api.github.com/users/heuermh/orgs","repos_url":"https://api.github.com/users/heuermh/repos","events_url":"https://api.github.com/users/heuermh/events{/privacy}","received_events_url":"https://api.github.com/users/heuermh/received_events","type":"User","site_admin":false},"body":"This could call `AlignmentRecordRDD(rdd, sequences, recordGroupDictionary, None)` directly","created_at":"2017-05-26T16:02:13Z","updated_at":"2017-05-26T16:04:22Z","html_url":"https://github.com/bigdatagenomics/adam/pull/1324#discussion_r118735094","pull_request_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1324","_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/118735094"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/1324#discussion_r118735094"},"pull_request":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1324"}}},"pull_request":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1324","id":99263155,"html_url":"https://github.com/bigdatagenomics/adam/pull/1324","diff_url":"https://github.com/bigdatagenomics/adam/pull/1324.diff","patch_url":"https://github.com/bigdatagenomics/adam/pull/1324.patch","issue_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1324","number":1324,"state":"open","locked":false,"title":"Efficient Joins and (re)Partitioning","user":{"login":"devin-petersohn","id":10732128,"avatar_url":"https://avatars3.githubusercontent.com/u/10732128?v=3","gravatar_id":"","url":"https://api.github.com/users/devin-petersohn","html_url":"https://github.com/devin-petersohn","followers_url":"https://api.github.com/users/devin-petersohn/followers","following_url":"https://api.github.com/users/devin-petersohn/following{/other_user}","gists_url":"https://api.github.com/users/devin-petersohn/gists{/gist_id}","starred_url":"https://api.github.com/users/devin-petersohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devin-petersohn/subscriptions","organizations_url":"https://api.github.com/users/devin-petersohn/orgs","repos_url":"https://api.github.com/users/devin-petersohn/repos","events_url":"https://api.github.com/users/devin-petersohn/events{/privacy}","received_events_url":"https://api.github.com/users/devin-petersohn/received_events","type":"User","site_admin":false},"body":"Ready for review.","created_at":"2016-12-23T16:59:20Z","updated_at":"2017-05-26T16:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"970479c28164804d57b122edfe9509a6fee8816d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/bigdatagenomics/adam/milestones/16","html_url":"https://github.com/bigdatagenomics/adam/milestone/16","labels_url":"https://api.github.com/repos/bigdatagenomics/adam/milestones/16/labels","id":2068939,"number":16,"title":"0.23.0","description":"","creator":{"login":"heuermh","id":35293,"avatar_url":"https://avatars1.githubusercontent.com/u/35293?v=3","gravatar_id":"","url":"https://api.github.com/users/heuermh","html_url":"https://github.com/heuermh","followers_url":"https://api.github.com/users/heuermh/followers","following_url":"https://api.github.com/users/heuermh/following{/other_user}","gists_url":"https://api.github.com/users/heuermh/gists{/gist_id}","starred_url":"https://api.github.com/users/heuermh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuermh/subscriptions","organizations_url":"https://api.github.com/users/heuermh/orgs","repos_url":"https://api.github.com/users/heuermh/repos","events_url":"https://api.github.com/users/heuermh/events{/privacy}","received_events_url":"https://api.github.com/users/heuermh/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":55,"state":"open","created_at":"2016-10-13T22:02:14Z","updated_at":"2017-05-25T16:48:53Z","due_on":"2017-05-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1324/commits","review_comments_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1324/comments","review_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1324/comments","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/4f314aa38d998944fb07ab3271245e03ac2c5c12","head":{"label":"devin-petersohn:partitioner","ref":"partitioner","sha":"4f314aa38d998944fb07ab3271245e03ac2c5c12","user":{"login":"devin-petersohn","id":10732128,"avatar_url":"https://avatars3.githubusercontent.com/u/10732128?v=3","gravatar_id":"","url":"https://api.github.com/users/devin-petersohn","html_url":"https://github.com/devin-petersohn","followers_url":"https://api.github.com/users/devin-petersohn/followers","following_url":"https://api.github.com/users/devin-petersohn/following{/other_user}","gists_url":"https://api.github.com/users/devin-petersohn/gists{/gist_id}","starred_url":"https://api.github.com/users/devin-petersohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devin-petersohn/subscriptions","organizations_url":"https://api.github.com/users/devin-petersohn/orgs","repos_url":"https://api.github.com/users/devin-petersohn/repos","events_url":"https://api.github.com/users/devin-petersohn/events{/privacy}","received_events_url":"https://api.github.com/users/devin-petersohn/received_events","type":"User","site_admin":false},"repo":{"id":67724277,"name":"adam","full_name":"devin-petersohn/adam","owner":{"login":"devin-petersohn","id":10732128,"avatar_url":"https://avatars3.githubusercontent.com/u/10732128?v=3","gravatar_id":"","url":"https://api.github.com/users/devin-petersohn","html_url":"https://github.com/devin-petersohn","followers_url":"https://api.github.com/users/devin-petersohn/followers","following_url":"https://api.github.com/users/devin-petersohn/following{/other_user}","gists_url":"https://api.github.com/users/devin-petersohn/gists{/gist_id}","starred_url":"https://api.github.com/users/devin-petersohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devin-petersohn/subscriptions","organizations_url":"https://api.github.com/users/devin-petersohn/orgs","repos_url":"https://api.github.com/users/devin-petersohn/repos","events_url":"https://api.github.com/users/devin-petersohn/events{/privacy}","received_events_url":"https://api.github.com/users/devin-petersohn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devin-petersohn/adam","description":"ADAM is a genomics analysis platform with specialized file formats built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":true,"url":"https://api.github.com/repos/devin-petersohn/adam","forks_url":"https://api.github.com/repos/devin-petersohn/adam/forks","keys_url":"https://api.github.com/repos/devin-petersohn/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devin-petersohn/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devin-petersohn/adam/teams","hooks_url":"https://api.github.com/repos/devin-petersohn/adam/hooks","issue_events_url":"https://api.github.com/repos/devin-petersohn/adam/issues/events{/number}","events_url":"https://api.github.com/repos/devin-petersohn/adam/events","assignees_url":"https://api.github.com/repos/devin-petersohn/adam/assignees{/user}","branches_url":"https://api.github.com/repos/devin-petersohn/adam/branches{/branch}","tags_url":"https://api.github.com/repos/devin-petersohn/adam/tags","blobs_url":"https://api.github.com/repos/devin-petersohn/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devin-petersohn/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devin-petersohn/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/devin-petersohn/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devin-petersohn/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/devin-petersohn/adam/languages","stargazers_url":"https://api.github.com/repos/devin-petersohn/adam/stargazers","contributors_url":"https://api.github.com/repos/devin-petersohn/adam/contributors","subscribers_url":"https://api.github.com/repos/devin-petersohn/adam/subscribers","subscription_url":"https://api.github.com/repos/devin-petersohn/adam/subscription","commits_url":"https://api.github.com/repos/devin-petersohn/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/devin-petersohn/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/devin-petersohn/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/devin-petersohn/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/devin-petersohn/adam/contents/{+path}","compare_url":"https://api.github.com/repos/devin-petersohn/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devin-petersohn/adam/merges","archive_url":"https://api.github.com/repos/devin-petersohn/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devin-petersohn/adam/downloads","issues_url":"https://api.github.com/repos/devin-petersohn/adam/issues{/number}","pulls_url":"https://api.github.com/repos/devin-petersohn/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/devin-petersohn/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/devin-petersohn/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devin-petersohn/adam/labels{/name}","releases_url":"https://api.github.com/repos/devin-petersohn/adam/releases{/id}","deployments_url":"https://api.github.com/repos/devin-petersohn/adam/deployments","created_at":"2016-09-08T17:16:12Z","updated_at":"2016-09-08T17:16:15Z","pushed_at":"2017-05-26T03:38:20Z","git_url":"git://github.com/devin-petersohn/adam.git","ssh_url":"[email protected]:devin-petersohn/adam.git","clone_url":"https://github.com/devin-petersohn/adam.git","svn_url":"https://github.com/devin-petersohn/adam","homepage":"http://bdgenomics.org/","size":7284,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"bigdatagenomics:master","ref":"master","sha":"3ea4f18e2275bdbed7609403098aa4194b03003a","user":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars0.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":14541530,"name":"adam","full_name":"bigdatagenomics/adam","owner":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars0.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigdatagenomics/adam","description":"ADAM is a genomics analysis platform with specialized file formats built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":false,"url":"https://api.github.com/repos/bigdatagenomics/adam","forks_url":"https://api.github.com/repos/bigdatagenomics/adam/forks","keys_url":"https://api.github.com/repos/bigdatagenomics/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigdatagenomics/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigdatagenomics/adam/teams","hooks_url":"https://api.github.com/repos/bigdatagenomics/adam/hooks","issue_events_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/events{/number}","events_url":"https://api.github.com/repos/bigdatagenomics/adam/events","assignees_url":"https://api.github.com/repos/bigdatagenomics/adam/assignees{/user}","branches_url":"https://api.github.com/repos/bigdatagenomics/adam/branches{/branch}","tags_url":"https://api.github.com/repos/bigdatagenomics/adam/tags","blobs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigdatagenomics/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigdatagenomics/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/bigdatagenomics/adam/languages","stargazers_url":"https://api.github.com/repos/bigdatagenomics/adam/stargazers","contributors_url":"https://api.github.com/repos/bigdatagenomics/adam/contributors","subscribers_url":"https://api.github.com/repos/bigdatagenomics/adam/subscribers","subscription_url":"https://api.github.com/repos/bigdatagenomics/adam/subscription","commits_url":"https://api.github.com/repos/bigdatagenomics/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigdatagenomics/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigdatagenomics/adam/contents/{+path}","compare_url":"https://api.github.com/repos/bigdatagenomics/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigdatagenomics/adam/merges","archive_url":"https://api.github.com/repos/bigdatagenomics/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigdatagenomics/adam/downloads","issues_url":"https://api.github.com/repos/bigdatagenomics/adam/issues{/number}","pulls_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/bigdatagenomics/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/bigdatagenomics/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigdatagenomics/adam/labels{/name}","releases_url":"https://api.github.com/repos/bigdatagenomics/adam/releases{/id}","deployments_url":"https://api.github.com/repos/bigdatagenomics/adam/deployments","created_at":"2013-11-19T23:47:57Z","updated_at":"2017-05-25T10:37:19Z","pushed_at":"2017-05-26T03:38:23Z","git_url":"git://github.com/bigdatagenomics/adam.git","ssh_url":"[email protected]:bigdatagenomics/adam.git","clone_url":"https://github.com/bigdatagenomics/adam.git","svn_url":"https://github.com/bigdatagenomics/adam","homepage":"http://bdgenomics.org/","size":7458,"stargazers_count":619,"watchers_count":619,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":226,"mirror_url":null,"open_issues_count":89,"forks":226,"open_issues":89,"watchers":619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1324"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/1324"},"issue":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/1324"},"comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/1324/comments"},"review_comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1324/comments"},"review_comment":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1324/commits"},"statuses":{"href":"https://api.github.com/repos/bigdatagenomics/adam/statuses/4f314aa38d998944fb07ab3271245e03ac2c5c12"}}}} | {
"id": 14541530,
"name": "bigdatagenomics/adam",
"url": "https://api.github.com/repos/bigdatagenomics/adam"
} | {
"id": 35293,
"login": "heuermh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35293?",
"url": "https://api.github.com/users/heuermh"
} | {
"id": 5839438,
"login": "bigdatagenomics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5839438?",
"url": "https://api.github.com/orgs/bigdatagenomics"
} | 2017-05-26T16:02:13 | 5950194094 | {"actor":{"display_login":"heuermh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/comments/137450717","pull_request_review_id":61118108,"id":137450717,"diff_hunk":"@@ -0,0 +1,18 @@\n+<!DOCTYPE html>\r\n+<html>\r\n+<head>\r\n+ <meta charset=\"utf-8\">\r\n+ <title>Домашнее задание №1а</title>\r\n+</head>\r\n+<body>\r\n+ <h3 align=center>Дневник партизана</h3>\r","path":"dz/dz1/diary.html","position":8,"original_position":8,"commit_id":"81a87a3825ea2ddd2711d6dd18479445761aa554","original_commit_id":"81a87a3825ea2ddd2711d6dd18479445761aa554","user":{"login":"fd1-44-17","id":31530428,"avatar_url":"https://avatars0.githubusercontent.com/u/31530428?v=4","gravatar_id":"","url":"https://api.github.com/users/fd1-44-17","html_url":"https://github.com/fd1-44-17","followers_url":"https://api.github.com/users/fd1-44-17/followers","following_url":"https://api.github.com/users/fd1-44-17/following{/other_user}","gists_url":"https://api.github.com/users/fd1-44-17/gists{/gist_id}","starred_url":"https://api.github.com/users/fd1-44-17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fd1-44-17/subscriptions","organizations_url":"https://api.github.com/users/fd1-44-17/orgs","repos_url":"https://api.github.com/users/fd1-44-17/repos","events_url":"https://api.github.com/users/fd1-44-17/events{/privacy}","received_events_url":"https://api.github.com/users/fd1-44-17/received_events","type":"User","site_admin":false},"body":"Где кавычки?","created_at":"2017-09-07T05:48:06Z","updated_at":"2017-09-07T05:49:57Z","html_url":"https://github.com/fd1-44-17-group/kirillunited/pull/2#discussion_r137450717","pull_request_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/2","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/comments/137450717"},"html":{"href":"https://github.com/fd1-44-17-group/kirillunited/pull/2#discussion_r137450717"},"pull_request":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/2","id":139490639,"html_url":"https://github.com/fd1-44-17-group/kirillunited/pull/2","diff_url":"https://github.com/fd1-44-17-group/kirillunited/pull/2.diff","patch_url":"https://github.com/fd1-44-17-group/kirillunited/pull/2.patch","issue_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues/2","number":2,"state":"open","locked":false,"title":"Dz 0409","user":{"login":"KirillUnited","id":31469909,"avatar_url":"https://avatars1.githubusercontent.com/u/31469909?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillUnited","html_url":"https://github.com/KirillUnited","followers_url":"https://api.github.com/users/KirillUnited/followers","following_url":"https://api.github.com/users/KirillUnited/following{/other_user}","gists_url":"https://api.github.com/users/KirillUnited/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillUnited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillUnited/subscriptions","organizations_url":"https://api.github.com/users/KirillUnited/orgs","repos_url":"https://api.github.com/users/KirillUnited/repos","events_url":"https://api.github.com/users/KirillUnited/events{/privacy}","received_events_url":"https://api.github.com/users/KirillUnited/received_events","type":"User","site_admin":false},"body":"@fd1-44-17 ","created_at":"2017-09-06T07:33:45Z","updated_at":"2017-09-07T05:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bb668ac64dd31b20094df20d04b493d32055047","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/2/commits","review_comments_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/2/comments","review_comment_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues/2/comments","statuses_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/statuses/81a87a3825ea2ddd2711d6dd18479445761aa554","head":{"label":"fd1-44-17-group:dz-0409","ref":"dz-0409","sha":"81a87a3825ea2ddd2711d6dd18479445761aa554","user":{"login":"fd1-44-17-group","id":31530559,"avatar_url":"https://avatars0.githubusercontent.com/u/31530559?v=4","gravatar_id":"","url":"https://api.github.com/users/fd1-44-17-group","html_url":"https://github.com/fd1-44-17-group","followers_url":"https://api.github.com/users/fd1-44-17-group/followers","following_url":"https://api.github.com/users/fd1-44-17-group/following{/other_user}","gists_url":"https://api.github.com/users/fd1-44-17-group/gists{/gist_id}","starred_url":"https://api.github.com/users/fd1-44-17-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fd1-44-17-group/subscriptions","organizations_url":"https://api.github.com/users/fd1-44-17-group/orgs","repos_url":"https://api.github.com/users/fd1-44-17-group/repos","events_url":"https://api.github.com/users/fd1-44-17-group/events{/privacy}","received_events_url":"https://api.github.com/users/fd1-44-17-group/received_events","type":"Organization","site_admin":false},"repo":{"id":102288310,"name":"kirillunited","full_name":"fd1-44-17-group/kirillunited","owner":{"login":"fd1-44-17-group","id":31530559,"avatar_url":"https://avatars0.githubusercontent.com/u/31530559?v=4","gravatar_id":"","url":"https://api.github.com/users/fd1-44-17-group","html_url":"https://github.com/fd1-44-17-group","followers_url":"https://api.github.com/users/fd1-44-17-group/followers","following_url":"https://api.github.com/users/fd1-44-17-group/following{/other_user}","gists_url":"https://api.github.com/users/fd1-44-17-group/gists{/gist_id}","starred_url":"https://api.github.com/users/fd1-44-17-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fd1-44-17-group/subscriptions","organizations_url":"https://api.github.com/users/fd1-44-17-group/orgs","repos_url":"https://api.github.com/users/fd1-44-17-group/repos","events_url":"https://api.github.com/users/fd1-44-17-group/events{/privacy}","received_events_url":"https://api.github.com/users/fd1-44-17-group/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fd1-44-17-group/kirillunited","description":"repository of KirillUnited","fork":false,"url":"https://api.github.com/repos/fd1-44-17-group/kirillunited","forks_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/forks","keys_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/teams","hooks_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/hooks","issue_events_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues/events{/number}","events_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/events","assignees_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/assignees{/user}","branches_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/branches{/branch}","tags_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/tags","blobs_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/refs{/sha}","trees_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/statuses/{sha}","languages_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/languages","stargazers_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/stargazers","contributors_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/contributors","subscribers_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/subscribers","subscription_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/subscription","commits_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/commits{/sha}","git_commits_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/commits{/sha}","comments_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/comments{/number}","issue_comment_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues/comments{/number}","contents_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/contents/{+path}","compare_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/merges","archive_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/downloads","issues_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues{/number}","pulls_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls{/number}","milestones_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/milestones{/number}","notifications_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/labels{/name}","releases_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/releases{/id}","deployments_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/deployments","created_at":"2017-09-03T19:16:47Z","updated_at":"2017-09-03T19:16:47Z","pushed_at":"2017-09-06T07:33:46Z","git_url":"git://github.com/fd1-44-17-group/kirillunited.git","ssh_url":"[email protected]:fd1-44-17-group/kirillunited.git","clone_url":"https://github.com/fd1-44-17-group/kirillunited.git","svn_url":"https://github.com/fd1-44-17-group/kirillunited","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fd1-44-17-group:master","ref":"master","sha":"407fbc8e2e829477bbb5f3c12adf6de01c4fdc71","user":{"login":"fd1-44-17-group","id":31530559,"avatar_url":"https://avatars0.githubusercontent.com/u/31530559?v=4","gravatar_id":"","url":"https://api.github.com/users/fd1-44-17-group","html_url":"https://github.com/fd1-44-17-group","followers_url":"https://api.github.com/users/fd1-44-17-group/followers","following_url":"https://api.github.com/users/fd1-44-17-group/following{/other_user}","gists_url":"https://api.github.com/users/fd1-44-17-group/gists{/gist_id}","starred_url":"https://api.github.com/users/fd1-44-17-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fd1-44-17-group/subscriptions","organizations_url":"https://api.github.com/users/fd1-44-17-group/orgs","repos_url":"https://api.github.com/users/fd1-44-17-group/repos","events_url":"https://api.github.com/users/fd1-44-17-group/events{/privacy}","received_events_url":"https://api.github.com/users/fd1-44-17-group/received_events","type":"Organization","site_admin":false},"repo":{"id":102288310,"name":"kirillunited","full_name":"fd1-44-17-group/kirillunited","owner":{"login":"fd1-44-17-group","id":31530559,"avatar_url":"https://avatars0.githubusercontent.com/u/31530559?v=4","gravatar_id":"","url":"https://api.github.com/users/fd1-44-17-group","html_url":"https://github.com/fd1-44-17-group","followers_url":"https://api.github.com/users/fd1-44-17-group/followers","following_url":"https://api.github.com/users/fd1-44-17-group/following{/other_user}","gists_url":"https://api.github.com/users/fd1-44-17-group/gists{/gist_id}","starred_url":"https://api.github.com/users/fd1-44-17-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fd1-44-17-group/subscriptions","organizations_url":"https://api.github.com/users/fd1-44-17-group/orgs","repos_url":"https://api.github.com/users/fd1-44-17-group/repos","events_url":"https://api.github.com/users/fd1-44-17-group/events{/privacy}","received_events_url":"https://api.github.com/users/fd1-44-17-group/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fd1-44-17-group/kirillunited","description":"repository of KirillUnited","fork":false,"url":"https://api.github.com/repos/fd1-44-17-group/kirillunited","forks_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/forks","keys_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/teams","hooks_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/hooks","issue_events_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues/events{/number}","events_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/events","assignees_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/assignees{/user}","branches_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/branches{/branch}","tags_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/tags","blobs_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/refs{/sha}","trees_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/statuses/{sha}","languages_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/languages","stargazers_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/stargazers","contributors_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/contributors","subscribers_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/subscribers","subscription_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/subscription","commits_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/commits{/sha}","git_commits_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/git/commits{/sha}","comments_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/comments{/number}","issue_comment_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues/comments{/number}","contents_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/contents/{+path}","compare_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/merges","archive_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/downloads","issues_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues{/number}","pulls_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls{/number}","milestones_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/milestones{/number}","notifications_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/labels{/name}","releases_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/releases{/id}","deployments_url":"https://api.github.com/repos/fd1-44-17-group/kirillunited/deployments","created_at":"2017-09-03T19:16:47Z","updated_at":"2017-09-03T19:16:47Z","pushed_at":"2017-09-06T07:33:46Z","git_url":"git://github.com/fd1-44-17-group/kirillunited.git","ssh_url":"[email protected]:fd1-44-17-group/kirillunited.git","clone_url":"https://github.com/fd1-44-17-group/kirillunited.git","svn_url":"https://github.com/fd1-44-17-group/kirillunited","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/2"},"html":{"href":"https://github.com/fd1-44-17-group/kirillunited/pull/2"},"issue":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues/2"},"comments":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/fd1-44-17-group/kirillunited/statuses/81a87a3825ea2ddd2711d6dd18479445761aa554"}},"author_association":"COLLABORATOR"}} | {
"id": 102288310,
"name": "fd1-44-17-group/kirillunited",
"url": "https://api.github.com/repos/fd1-44-17-group/kirillunited"
} | {
"id": 31530428,
"login": "fd1-44-17",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31530428?",
"url": "https://api.github.com/users/fd1-44-17"
} | {
"id": 31530559,
"login": "fd1-44-17-group",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31530559?",
"url": "https://api.github.com/orgs/fd1-44-17-group"
} | 2017-09-07T05:48:06 | 6559684763 | {"actor":{"display_login":"fd1-44-17"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/113923253","pull_request_review_id":35352359,"id":113923253,"diff_hunk":"@@ -43,17 +42,21 @@ class Ssc ssc =>\n SscGStateClass ssc where\n -- | Load global state from DB by recreating it from recent blocks.\n sscLoadGlobalState\n- :: (HasContext LrcContext m, MonadDB m, WithLogger m)\n+ :: (MonadDB m, WithLogger m)\n => m (SscGlobalState ssc)\n+ -- | Dump global state to DB.\n+ sscGlobalStateToBatch :: SscGlobalState ssc -> Tagged ssc [SomeBatchOp]","path":"src/Pos/Ssc/Class/Storage.hs","position":27,"original_position":27,"commit_id":"c594cc13b6eb2d05a6a560bb25e4c4f533c7a328","original_commit_id":"c594cc13b6eb2d05a6a560bb25e4c4f533c7a328","user":{"login":"neongreen","id":1523306,"avatar_url":"https://avatars0.githubusercontent.com/u/1523306?v=3","gravatar_id":"","url":"https://api.github.com/users/neongreen","html_url":"https://github.com/neongreen","followers_url":"https://api.github.com/users/neongreen/followers","following_url":"https://api.github.com/users/neongreen/following{/other_user}","gists_url":"https://api.github.com/users/neongreen/gists{/gist_id}","starred_url":"https://api.github.com/users/neongreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neongreen/subscriptions","organizations_url":"https://api.github.com/users/neongreen/orgs","repos_url":"https://api.github.com/users/neongreen/repos","events_url":"https://api.github.com/users/neongreen/events{/privacy}","received_events_url":"https://api.github.com/users/neongreen/received_events","type":"User","site_admin":false},"body":"`SscGlobalState` is a type family, and it's not necessarily injective. If two different instances define `SscGlobalState Foo = ()` and `SscGlobaState Bar = ()`, then if you pass `()` to `sscGlobalStateToBatch`, it won't know which `ssc` to use.","created_at":"2017-04-28T12:52:22Z","updated_at":"2017-04-28T12:52:22Z","html_url":"https://github.com/input-output-hk/cardano-sl/pull/298#discussion_r113923253","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/298","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/113923253"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/298#discussion_r113923253"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/298","id":118130753,"html_url":"https://github.com/input-output-hk/cardano-sl/pull/298","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/298.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/298.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/298","number":298,"state":"open","locked":false,"title":"Feature/csl1062 optimize ssc loading","user":{"login":"pva701","id":7355273,"avatar_url":"https://avatars2.githubusercontent.com/u/7355273?v=3","gravatar_id":"","url":"https://api.github.com/users/pva701","html_url":"https://github.com/pva701","followers_url":"https://api.github.com/users/pva701/followers","following_url":"https://api.github.com/users/pva701/following{/other_user}","gists_url":"https://api.github.com/users/pva701/gists{/gist_id}","starred_url":"https://api.github.com/users/pva701/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pva701/subscriptions","organizations_url":"https://api.github.com/users/pva701/orgs","repos_url":"https://api.github.com/users/pva701/repos","events_url":"https://api.github.com/users/pva701/events{/privacy}","received_events_url":"https://api.github.com/users/pva701/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-28T11:13:11Z","updated_at":"2017-04-28T12:52:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7baeb547043ef38f6feb7ea95556f97ba8fe797","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/298/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/298/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/298/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/c594cc13b6eb2d05a6a560bb25e4c4f533c7a328","head":{"label":"input-output-hk:feature/csl1062-optimize-ssc-loading","ref":"feature/csl1062-optimize-ssc-loading","sha":"c594cc13b6eb2d05a6a560bb25e4c4f533c7a328","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"A cryptographic currency","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2017-04-26T10:30:08Z","pushed_at":"2017-04-28T12:41:02Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"[email protected]:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":18789,"stargazers_count":155,"watchers_count":155,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":13,"forks":14,"open_issues":13,"watchers":155,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"0e1c901c729e006a4a8e76899495b5ec278304d5","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"A cryptographic currency","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2017-04-26T10:30:08Z","pushed_at":"2017-04-28T12:41:02Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"[email protected]:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":18789,"stargazers_count":155,"watchers_count":155,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":13,"forks":14,"open_issues":13,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/298"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/298"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/298"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/c594cc13b6eb2d05a6a560bb25e4c4f533c7a328"}}}} | {
"id": 70913997,
"name": "input-output-hk/cardano-sl",
"url": "https://api.github.com/repos/input-output-hk/cardano-sl"
} | {
"id": 1523306,
"login": "neongreen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1523306?",
"url": "https://api.github.com/users/neongreen"
} | {
"id": 12909177,
"login": "input-output-hk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12909177?",
"url": "https://api.github.com/orgs/input-output-hk"
} | 2017-04-28T12:52:22 | 5776291254 | {"actor":{"display_login":"neongreen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/111925942","pull_request_review_id":33200556,"id":111925942,"diff_hunk":"@@ -0,0 +1,77 @@\n+{-# LANGUAGE TemplateHaskell #-}\n+\n+-- Types related Poll update system\n+\n+module Pos.Update.Poll.PollState\n+ (\n+ -- * Types\n+ PollState (..)\n+\n+ -- * Lenses\n+ -- * PollState\n+ , psBlockVersions\n+ , psAdoptedBV\n+ , psSoftwareVersion\n+ , psEpochProposers\n+ , psConfirmedBVs\n+ , psConfirmedProposals\n+ , psActiveProposals\n+ , psDelActivePropsIdx\n+ , psSlottingData\n+ , psUndecidedProposals\n+ , psDecidedProposals\n+ , psStakePerEpoch\n+ , psMultiRichmenStake\n+ , psIssuersStakes\n+ ) where\n+\n+import Control.Lens (makeLenses)\n+import Data.HashSet (HashSet)\n+import Data.HashMap.Strict (HashMap)\n+import Universum\n+\n+import Pos.Core.Types (BlockVersionData, Coin)\n+import Pos.Lrc.DB.Issuers (IssuersStakes)\n+import Pos.Slotting.Types (SlottingData)\n+import Pos.Ssc.GodTossing.Toss.Pure (MultiRichmenStake)\n+import Pos.Types (ApplicationName, BlockVersion,\n+ EpochIndex, NumSoftwareVersion,\n+ SoftwareVersion, StakeholderId)\n+import Pos.Update.Core (UpId)\n+import Pos.Update.Poll (BlockVersionState,\n+ ConfirmedProposalState,\n+ DecidedProposalState, ProposalState,\n+ UndecidedProposalState)\n+import Pos.Util.Modifier (MapModifier)\n+\n+data PollState = PollState\n+ { -- | All proposed block versions with their states\n+ _psBlockVersions :: !(MapModifier BlockVersion BlockVersionState)\n+ -- | Presently adopted block version with its data\n+ , _psAdoptedBV :: !(BlockVersion, BlockVersionData)\n+ -- | Software version of this node\n+ , _psSoftwareVersion :: !SoftwareVersion\n+ -- | All stakeholders who made proposals in the current epoch\n+ , _psEpochProposers :: !(HashSet StakeholderId)\n+ -- | All applications in use and their latest (confirmed) versions\n+ , _psConfirmedBVs :: !(MapModifier ApplicationName NumSoftwareVersion)\n+ -- | All proposed software versions and their state\n+ , _psConfirmedProposals :: !(MapModifier SoftwareVersion ConfirmedProposalState)\n+ -- | All update proposals and their states\n+ , _psActiveProposals :: !(MapModifier UpId ProposalState)\n+ -- | Update proposals for each application\n+ , _psDelActivePropsIdx :: !(HashMap ApplicationName (HashSet UpId))","path":"src/Pos/Update/Poll/PollState.hs","position":null,"original_position":63,"commit_id":"fdd7e7e532946e6f7fbf164d25f664166c0c11e0","original_commit_id":"ee5af95cee8dfbd4c221fb976001da40d1abcc1c","user":{"login":"gromakovsky","id":2556409,"avatar_url":"https://avatars3.githubusercontent.com/u/2556409?v=3","gravatar_id":"","url":"https://api.github.com/users/gromakovsky","html_url":"https://github.com/gromakovsky","followers_url":"https://api.github.com/users/gromakovsky/followers","following_url":"https://api.github.com/users/gromakovsky/following{/other_user}","gists_url":"https://api.github.com/users/gromakovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/gromakovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gromakovsky/subscriptions","organizations_url":"https://api.github.com/users/gromakovsky/orgs","repos_url":"https://api.github.com/users/gromakovsky/repos","events_url":"https://api.github.com/users/gromakovsky/events{/privacy}","received_events_url":"https://api.github.com/users/gromakovsky/received_events","type":"User","site_admin":false},"body":"Yes, but in `PollModifier` it represents map from application name to proposal ids for **deleted** proposals, hence `del` in name. Here it's a map for all proposals, not only deleted.","created_at":"2017-04-18T11:01:39Z","updated_at":"2017-04-18T11:01:39Z","html_url":"https://github.com/input-output-hk/cardano-sl/pull/240#discussion_r111925942","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/240","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/111925942"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/240#discussion_r111925942"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/240","id":116013215,"html_url":"https://github.com/input-output-hk/cardano-sl/pull/240","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/240.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/240.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/240","number":240,"state":"open","locked":false,"title":"Task/csl979 purepoll","user":{"login":"rockbmb","id":16455833,"avatar_url":"https://avatars3.githubusercontent.com/u/16455833?v=3","gravatar_id":"","url":"https://api.github.com/users/rockbmb","html_url":"https://github.com/rockbmb","followers_url":"https://api.github.com/users/rockbmb/followers","following_url":"https://api.github.com/users/rockbmb/following{/other_user}","gists_url":"https://api.github.com/users/rockbmb/gists{/gist_id}","starred_url":"https://api.github.com/users/rockbmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockbmb/subscriptions","organizations_url":"https://api.github.com/users/rockbmb/orgs","repos_url":"https://api.github.com/users/rockbmb/repos","events_url":"https://api.github.com/users/rockbmb/events{/privacy}","received_events_url":"https://api.github.com/users/rockbmb/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-15T04:14:21Z","updated_at":"2017-04-18T11:01:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6ad06bf7ff07c57e943da677141f79952868193","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/240/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/240/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/240/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/fdd7e7e532946e6f7fbf164d25f664166c0c11e0","head":{"label":"input-output-hk:task/csl979-purepoll","ref":"task/csl979-purepoll","sha":"fdd7e7e532946e6f7fbf164d25f664166c0c11e0","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"A cryptographic currency","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2017-04-18T09:51:31Z","pushed_at":"2017-04-18T10:24:20Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"[email protected]:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":18647,"stargazers_count":152,"watchers_count":152,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":12,"forks":14,"open_issues":12,"watchers":152,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"36e8653654a36ca327c76e39f29adbfdee2b7d9a","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"A cryptographic currency","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2017-04-18T09:51:31Z","pushed_at":"2017-04-18T10:24:20Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"[email protected]:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":18647,"stargazers_count":152,"watchers_count":152,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":12,"forks":14,"open_issues":12,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/240"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/240"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/240"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/fdd7e7e532946e6f7fbf164d25f664166c0c11e0"}}}} | {
"id": 70913997,
"name": "input-output-hk/cardano-sl",
"url": "https://api.github.com/repos/input-output-hk/cardano-sl"
} | {
"id": 2556409,
"login": "gromakovsky",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2556409?",
"url": "https://api.github.com/users/gromakovsky"
} | {
"id": 12909177,
"login": "input-output-hk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12909177?",
"url": "https://api.github.com/orgs/input-output-hk"
} | 2017-04-18T11:01:39 | 5706356142 | {"actor":{"display_login":"gromakovsky"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/comments/132123678","pull_request_review_id":55169546,"id":132123678,"diff_hunk":"@@ -25,6 +25,11 @@\n Changes\n =======\n \n+Version 1.0.0b4 (released 2017-08-09)\n+-------------------------------------\n+\n+- Fixes for Content Security Poclicy (CSP).\n+","path":"CHANGES.rst","position":8,"original_position":8,"commit_id":"56946f337e7593dc65b8875f119c8cafb0cd734a","original_commit_id":"56946f337e7593dc65b8875f119c8cafb0cd734a","user":{"login":"nharraud","id":5708796,"avatar_url":"https://avatars3.githubusercontent.com/u/5708796?v=4","gravatar_id":"","url":"https://api.github.com/users/nharraud","html_url":"https://github.com/nharraud","followers_url":"https://api.github.com/users/nharraud/followers","following_url":"https://api.github.com/users/nharraud/following{/other_user}","gists_url":"https://api.github.com/users/nharraud/gists{/gist_id}","starred_url":"https://api.github.com/users/nharraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nharraud/subscriptions","organizations_url":"https://api.github.com/users/nharraud/orgs","repos_url":"https://api.github.com/users/nharraud/repos","events_url":"https://api.github.com/users/nharraud/events{/privacy}","received_events_url":"https://api.github.com/users/nharraud/received_events","type":"User","site_admin":false},"body":"There is no need to keep the previous version here. You can take a look at other release commits [like this one](https://github.com/inveniosoftware/invenio-assets/commit/0e5fe263d359d06151854a0b93b005a031fbd59a). As long as we are in alpha/beta we just replace the previous message.","created_at":"2017-08-09T08:45:02Z","updated_at":"2017-08-09T08:45:02Z","html_url":"https://github.com/inveniosoftware/invenio-i18n/pull/60#discussion_r132123678","pull_request_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/comments/132123678"},"html":{"href":"https://github.com/inveniosoftware/invenio-i18n/pull/60#discussion_r132123678"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/60","id":134837597,"html_url":"https://github.com/inveniosoftware/invenio-i18n/pull/60","diff_url":"https://github.com/inveniosoftware/invenio-i18n/pull/60.diff","patch_url":"https://github.com/inveniosoftware/invenio-i18n/pull/60.patch","issue_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/issues/60","number":60,"state":"open","locked":false,"title":"release: v1.0.0b4","user":{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Harris Tzovanakis <[email protected]>","created_at":"2017-08-09T08:33:51Z","updated_at":"2017-08-09T08:45:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"239de6c3346d98d799b17ee8e9e1a151ba52534b","assignee":{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false},"assignees":[{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/60/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/60/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/issues/60/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/statuses/56946f337e7593dc65b8875f119c8cafb0cd734a","head":{"label":"drjova:release-v1.0.0b3","ref":"release-v1.0.0b3","sha":"56946f337e7593dc65b8875f119c8cafb0cd734a","user":{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false},"repo":{"id":81221640,"name":"invenio-i18n","full_name":"drjova/invenio-i18n","owner":{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drjova/invenio-i18n","description":"Invenio internationalization module.","fork":true,"url":"https://api.github.com/repos/drjova/invenio-i18n","forks_url":"https://api.github.com/repos/drjova/invenio-i18n/forks","keys_url":"https://api.github.com/repos/drjova/invenio-i18n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drjova/invenio-i18n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drjova/invenio-i18n/teams","hooks_url":"https://api.github.com/repos/drjova/invenio-i18n/hooks","issue_events_url":"https://api.github.com/repos/drjova/invenio-i18n/issues/events{/number}","events_url":"https://api.github.com/repos/drjova/invenio-i18n/events","assignees_url":"https://api.github.com/repos/drjova/invenio-i18n/assignees{/user}","branches_url":"https://api.github.com/repos/drjova/invenio-i18n/branches{/branch}","tags_url":"https://api.github.com/repos/drjova/invenio-i18n/tags","blobs_url":"https://api.github.com/repos/drjova/invenio-i18n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drjova/invenio-i18n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drjova/invenio-i18n/git/refs{/sha}","trees_url":"https://api.github.com/repos/drjova/invenio-i18n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drjova/invenio-i18n/statuses/{sha}","languages_url":"https://api.github.com/repos/drjova/invenio-i18n/languages","stargazers_url":"https://api.github.com/repos/drjova/invenio-i18n/stargazers","contributors_url":"https://api.github.com/repos/drjova/invenio-i18n/contributors","subscribers_url":"https://api.github.com/repos/drjova/invenio-i18n/subscribers","subscription_url":"https://api.github.com/repos/drjova/invenio-i18n/subscription","commits_url":"https://api.github.com/repos/drjova/invenio-i18n/commits{/sha}","git_commits_url":"https://api.github.com/repos/drjova/invenio-i18n/git/commits{/sha}","comments_url":"https://api.github.com/repos/drjova/invenio-i18n/comments{/number}","issue_comment_url":"https://api.github.com/repos/drjova/invenio-i18n/issues/comments{/number}","contents_url":"https://api.github.com/repos/drjova/invenio-i18n/contents/{+path}","compare_url":"https://api.github.com/repos/drjova/invenio-i18n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drjova/invenio-i18n/merges","archive_url":"https://api.github.com/repos/drjova/invenio-i18n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drjova/invenio-i18n/downloads","issues_url":"https://api.github.com/repos/drjova/invenio-i18n/issues{/number}","pulls_url":"https://api.github.com/repos/drjova/invenio-i18n/pulls{/number}","milestones_url":"https://api.github.com/repos/drjova/invenio-i18n/milestones{/number}","notifications_url":"https://api.github.com/repos/drjova/invenio-i18n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drjova/invenio-i18n/labels{/name}","releases_url":"https://api.github.com/repos/drjova/invenio-i18n/releases{/id}","deployments_url":"https://api.github.com/repos/drjova/invenio-i18n/deployments","created_at":"2017-02-07T15:14:13Z","updated_at":"2017-02-07T15:14:14Z","pushed_at":"2017-08-09T08:43:07Z","git_url":"git://github.com/drjova/invenio-i18n.git","ssh_url":"[email protected]:drjova/invenio-i18n.git","clone_url":"https://github.com/drjova/invenio-i18n.git","svn_url":"https://github.com/drjova/invenio-i18n","homepage":"https://invenio-i18n.readthedocs.io/","size":128,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inveniosoftware:master","ref":"master","sha":"32325f004177d564e8e0e86bc4260f7d2e585aa9","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars1.githubusercontent.com/u/1157480?v=4","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":43965656,"name":"invenio-i18n","full_name":"inveniosoftware/invenio-i18n","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars1.githubusercontent.com/u/1157480?v=4","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/invenio-i18n","description":"Invenio internationalization module.","fork":false,"url":"https://api.github.com/repos/inveniosoftware/invenio-i18n","forks_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/forks","keys_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/events","assignees_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/issues/comments{/number}","contents_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/merges","archive_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/releases{/id}","deployments_url":"https://api.github.com/repos/inveniosoftware/invenio-i18n/deployments","created_at":"2015-10-09T15:55:51Z","updated_at":"2017-05-09T07:57:40Z","pushed_at":"2017-08-09T08:43:08Z","git_url":"git://github.com/inveniosoftware/invenio-i18n.git","ssh_url":"[email protected]:inveniosoftware/invenio-i18n.git","clone_url":"https://github.com/inveniosoftware/invenio-i18n.git","svn_url":"https://github.com/inveniosoftware/invenio-i18n","homepage":"https://invenio-i18n.readthedocs.io","size":133,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/60"},"html":{"href":"https://github.com/inveniosoftware/invenio-i18n/pull/60"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/issues/60"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/invenio-i18n/statuses/56946f337e7593dc65b8875f119c8cafb0cd734a"}}}} | {
"id": 43965656,
"name": "inveniosoftware/invenio-i18n",
"url": "https://api.github.com/repos/inveniosoftware/invenio-i18n"
} | {
"id": 5708796,
"login": "nharraud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5708796?",
"url": "https://api.github.com/users/nharraud"
} | {
"id": 1157480,
"login": "inveniosoftware",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1157480?",
"url": "https://api.github.com/orgs/inveniosoftware"
} | 2017-08-09T08:45:02 | 6422543726 | {"actor":{"display_login":"nharraud"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/comments/149175125","pull_request_review_id":74528619,"id":149175125,"diff_hunk":"@@ -62,38 +127,54 @@ class LazyLoad {\n image.removeAttribute('data-lazy')\n \n if (placeholder.getAttribute('data-srcset')) {\n- this.parseBreakpoints(image, placeholder.getAttribute('data-srcset'))\n-\n- return image\n+ this.checkBreakpointsSource(image, placeholder.getAttribute('data-srcset'))\n+ } else {\n+ image.src = placeholder.getAttribute('data-src')\n }\n \n- image.src = placeholder.getAttribute('data-src')\n-\n return image\n }\n \n+ /**\n+ * Parse all data-attr from [data-lazy] to <image />\n+ * but prevent [data-lazy], [data-srcset] and [data-src] to be setted in img\n+ *\n+ * @param {[DOM]} image\n+ * @param {[NamedNodeMap]} attributes - any html attribute from [data-lazy]\n+ * @return {[DOM]} image with attributes from [data-lazy]\n+ */\n parseAttributes (image, attributes) {\n- Array.prototype.forEach.call(attributes, (attr) => {\n- if (attr.name !== this.options.selector || attr.name !== 'data-srcset' || attr.name !== 'data-src') {\n+ Array.from(attributes, (attr) => {\n+ if (!this.isDefaultAttribute(attr.name)) {\n image.setAttribute(attr.name, attr.value)\n }\n })\n \n return image\n }\n \n- parseBreakpoints (image, breakpoints) {\n- image.removeAttribute('data-srcset')\n+ /**\n+ * Check if string has any of data-attr\n+ *\n+ * @param {[String]} name\n+ * @return {Boolean}\n+ */\n+ isDefaultAttribute (name) {\n+ return name.match(/^data-(lazy|srcset|src)$/)\n+ }\n \n- breakpoints = breakpoints.split(/,\\s+/g).map(breakpoint => {\n- breakpoint = breakpoint.trim().split(/\\s+/)\n+ /**\n+ * Check breakpoints variation and return an imagem with source","path":"src/js/components/lazy-load.js","position":184,"original_position":184,"commit_id":"9a20334a77ca27e5dc6aa6d94858c52cef6ce9cc","original_commit_id":"9a20334a77ca27e5dc6aa6d94858c52cef6ce9cc","user":{"login":"willamesoares","id":6568078,"avatar_url":"https://avatars2.githubusercontent.com/u/6568078?v=4","gravatar_id":"","url":"https://api.github.com/users/willamesoares","html_url":"https://github.com/willamesoares","followers_url":"https://api.github.com/users/willamesoares/followers","following_url":"https://api.github.com/users/willamesoares/following{/other_user}","gists_url":"https://api.github.com/users/willamesoares/gists{/gist_id}","starred_url":"https://api.github.com/users/willamesoares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willamesoares/subscriptions","organizations_url":"https://api.github.com/users/willamesoares/orgs","repos_url":"https://api.github.com/users/willamesoares/repos","events_url":"https://api.github.com/users/willamesoares/events{/privacy}","received_events_url":"https://api.github.com/users/willamesoares/received_events","type":"User","site_admin":false},"body":"Add period at the end.","created_at":"2017-11-06T19:17:06Z","updated_at":"2017-11-06T19:17:06Z","html_url":"https://github.com/leroy-merlin-br/garden/pull/316#discussion_r149175125","pull_request_url":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/316","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/comments/149175125"},"html":{"href":"https://github.com/leroy-merlin-br/garden/pull/316#discussion_r149175125"},"pull_request":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/316","id":148206300,"html_url":"https://github.com/leroy-merlin-br/garden/pull/316","diff_url":"https://github.com/leroy-merlin-br/garden/pull/316.diff","patch_url":"https://github.com/leroy-merlin-br/garden/pull/316.patch","issue_url":"https://api.github.com/repos/leroy-merlin-br/garden/issues/316","number":316,"state":"open","locked":false,"title":"feat(lazyload): removing jQuery from Lazyload","user":{"login":"perna","id":1197591,"avatar_url":"https://avatars0.githubusercontent.com/u/1197591?v=4","gravatar_id":"","url":"https://api.github.com/users/perna","html_url":"https://github.com/perna","followers_url":"https://api.github.com/users/perna/followers","following_url":"https://api.github.com/users/perna/following{/other_user}","gists_url":"https://api.github.com/users/perna/gists{/gist_id}","starred_url":"https://api.github.com/users/perna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perna/subscriptions","organizations_url":"https://api.github.com/users/perna/orgs","repos_url":"https://api.github.com/users/perna/repos","events_url":"https://api.github.com/users/perna/events{/privacy}","received_events_url":"https://api.github.com/users/perna/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-23T18:30:25Z","updated_at":"2017-11-06T19:17:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43e9e2957dd8a29e4d9487096ea899ae65150ca9","assignee":{"login":"perna","id":1197591,"avatar_url":"https://avatars0.githubusercontent.com/u/1197591?v=4","gravatar_id":"","url":"https://api.github.com/users/perna","html_url":"https://github.com/perna","followers_url":"https://api.github.com/users/perna/followers","following_url":"https://api.github.com/users/perna/following{/other_user}","gists_url":"https://api.github.com/users/perna/gists{/gist_id}","starred_url":"https://api.github.com/users/perna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perna/subscriptions","organizations_url":"https://api.github.com/users/perna/orgs","repos_url":"https://api.github.com/users/perna/repos","events_url":"https://api.github.com/users/perna/events{/privacy}","received_events_url":"https://api.github.com/users/perna/received_events","type":"User","site_admin":false},"assignees":[{"login":"perna","id":1197591,"avatar_url":"https://avatars0.githubusercontent.com/u/1197591?v=4","gravatar_id":"","url":"https://api.github.com/users/perna","html_url":"https://github.com/perna","followers_url":"https://api.github.com/users/perna/followers","following_url":"https://api.github.com/users/perna/following{/other_user}","gists_url":"https://api.github.com/users/perna/gists{/gist_id}","starred_url":"https://api.github.com/users/perna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perna/subscriptions","organizations_url":"https://api.github.com/users/perna/orgs","repos_url":"https://api.github.com/users/perna/repos","events_url":"https://api.github.com/users/perna/events{/privacy}","received_events_url":"https://api.github.com/users/perna/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"leandrogrillo","id":1045308,"avatar_url":"https://avatars3.githubusercontent.com/u/1045308?v=4","gravatar_id":"","url":"https://api.github.com/users/leandrogrillo","html_url":"https://github.com/leandrogrillo","followers_url":"https://api.github.com/users/leandrogrillo/followers","following_url":"https://api.github.com/users/leandrogrillo/following{/other_user}","gists_url":"https://api.github.com/users/leandrogrillo/gists{/gist_id}","starred_url":"https://api.github.com/users/leandrogrillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leandrogrillo/subscriptions","organizations_url":"https://api.github.com/users/leandrogrillo/orgs","repos_url":"https://api.github.com/users/leandrogrillo/repos","events_url":"https://api.github.com/users/leandrogrillo/events{/privacy}","received_events_url":"https://api.github.com/users/leandrogrillo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/leroy-merlin-br/garden/milestones/6","html_url":"https://github.com/leroy-merlin-br/garden/milestone/6","labels_url":"https://api.github.com/repos/leroy-merlin-br/garden/milestones/6/labels","id":2818036,"number":6,"title":"v1","description":"","creator":{"login":"leandrogrillo","id":1045308,"avatar_url":"https://avatars3.githubusercontent.com/u/1045308?v=4","gravatar_id":"","url":"https://api.github.com/users/leandrogrillo","html_url":"https://github.com/leandrogrillo","followers_url":"https://api.github.com/users/leandrogrillo/followers","following_url":"https://api.github.com/users/leandrogrillo/following{/other_user}","gists_url":"https://api.github.com/users/leandrogrillo/gists{/gist_id}","starred_url":"https://api.github.com/users/leandrogrillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leandrogrillo/subscriptions","organizations_url":"https://api.github.com/users/leandrogrillo/orgs","repos_url":"https://api.github.com/users/leandrogrillo/repos","events_url":"https://api.github.com/users/leandrogrillo/events{/privacy}","received_events_url":"https://api.github.com/users/leandrogrillo/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":12,"state":"open","created_at":"2017-10-05T18:24:09Z","updated_at":"2017-11-06T18:41:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/316/commits","review_comments_url":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/316/comments","review_comment_url":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leroy-merlin-br/garden/issues/316/comments","statuses_url":"https://api.github.com/repos/leroy-merlin-br/garden/statuses/9a20334a77ca27e5dc6aa6d94858c52cef6ce9cc","head":{"label":"leroy-merlin-br:refactor/lazyload-component","ref":"refactor/lazyload-component","sha":"9a20334a77ca27e5dc6aa6d94858c52cef6ce9cc","user":{"login":"leroy-merlin-br","id":4422202,"avatar_url":"https://avatars1.githubusercontent.com/u/4422202?v=4","gravatar_id":"","url":"https://api.github.com/users/leroy-merlin-br","html_url":"https://github.com/leroy-merlin-br","followers_url":"https://api.github.com/users/leroy-merlin-br/followers","following_url":"https://api.github.com/users/leroy-merlin-br/following{/other_user}","gists_url":"https://api.github.com/users/leroy-merlin-br/gists{/gist_id}","starred_url":"https://api.github.com/users/leroy-merlin-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leroy-merlin-br/subscriptions","organizations_url":"https://api.github.com/users/leroy-merlin-br/orgs","repos_url":"https://api.github.com/users/leroy-merlin-br/repos","events_url":"https://api.github.com/users/leroy-merlin-br/events{/privacy}","received_events_url":"https://api.github.com/users/leroy-merlin-br/received_events","type":"Organization","site_admin":false},"repo":{"id":48196975,"name":"garden","full_name":"leroy-merlin-br/garden","owner":{"login":"leroy-merlin-br","id":4422202,"avatar_url":"https://avatars1.githubusercontent.com/u/4422202?v=4","gravatar_id":"","url":"https://api.github.com/users/leroy-merlin-br","html_url":"https://github.com/leroy-merlin-br","followers_url":"https://api.github.com/users/leroy-merlin-br/followers","following_url":"https://api.github.com/users/leroy-merlin-br/following{/other_user}","gists_url":"https://api.github.com/users/leroy-merlin-br/gists{/gist_id}","starred_url":"https://api.github.com/users/leroy-merlin-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leroy-merlin-br/subscriptions","organizations_url":"https://api.github.com/users/leroy-merlin-br/orgs","repos_url":"https://api.github.com/users/leroy-merlin-br/repos","events_url":"https://api.github.com/users/leroy-merlin-br/events{/privacy}","received_events_url":"https://api.github.com/users/leroy-merlin-br/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leroy-merlin-br/garden","description":"A styleguide based on Leroy Merlin needs","fork":false,"url":"https://api.github.com/repos/leroy-merlin-br/garden","forks_url":"https://api.github.com/repos/leroy-merlin-br/garden/forks","keys_url":"https://api.github.com/repos/leroy-merlin-br/garden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leroy-merlin-br/garden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leroy-merlin-br/garden/teams","hooks_url":"https://api.github.com/repos/leroy-merlin-br/garden/hooks","issue_events_url":"https://api.github.com/repos/leroy-merlin-br/garden/issues/events{/number}","events_url":"https://api.github.com/repos/leroy-merlin-br/garden/events","assignees_url":"https://api.github.com/repos/leroy-merlin-br/garden/assignees{/user}","branches_url":"https://api.github.com/repos/leroy-merlin-br/garden/branches{/branch}","tags_url":"https://api.github.com/repos/leroy-merlin-br/garden/tags","blobs_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/refs{/sha}","trees_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leroy-merlin-br/garden/statuses/{sha}","languages_url":"https://api.github.com/repos/leroy-merlin-br/garden/languages","stargazers_url":"https://api.github.com/repos/leroy-merlin-br/garden/stargazers","contributors_url":"https://api.github.com/repos/leroy-merlin-br/garden/contributors","subscribers_url":"https://api.github.com/repos/leroy-merlin-br/garden/subscribers","subscription_url":"https://api.github.com/repos/leroy-merlin-br/garden/subscription","commits_url":"https://api.github.com/repos/leroy-merlin-br/garden/commits{/sha}","git_commits_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/commits{/sha}","comments_url":"https://api.github.com/repos/leroy-merlin-br/garden/comments{/number}","issue_comment_url":"https://api.github.com/repos/leroy-merlin-br/garden/issues/comments{/number}","contents_url":"https://api.github.com/repos/leroy-merlin-br/garden/contents/{+path}","compare_url":"https://api.github.com/repos/leroy-merlin-br/garden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leroy-merlin-br/garden/merges","archive_url":"https://api.github.com/repos/leroy-merlin-br/garden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leroy-merlin-br/garden/downloads","issues_url":"https://api.github.com/repos/leroy-merlin-br/garden/issues{/number}","pulls_url":"https://api.github.com/repos/leroy-merlin-br/garden/pulls{/number}","milestones_url":"https://api.github.com/repos/leroy-merlin-br/garden/milestones{/number}","notifications_url":"https://api.github.com/repos/leroy-merlin-br/garden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leroy-merlin-br/garden/labels{/name}","releases_url":"https://api.github.com/repos/leroy-merlin-br/garden/releases{/id}","deployments_url":"https://api.github.com/repos/leroy-merlin-br/garden/deployments","created_at":"2015-12-17T20:36:16Z","updated_at":"2017-11-04T16:59:21Z","pushed_at":"2017-11-06T18:53:59Z","git_url":"git://github.com/leroy-merlin-br/garden.git","ssh_url":"[email protected]:leroy-merlin-br/garden.git","clone_url":"https://github.com/leroy-merlin-br/garden.git","svn_url":"https://github.com/leroy-merlin-br/garden","homepage":"http://styleguide.leroymerlin.com.br","size":2656,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":10,"open_issues":8,"watchers":51,"default_branch":"master"}},"base":{"label":"leroy-merlin-br:feat/v1","ref":"feat/v1","sha":"25c5d04479d00c79c04f3e2554f27d2b83cf0959","user":{"login":"leroy-merlin-br","id":4422202,"avatar_url":"https://avatars1.githubusercontent.com/u/4422202?v=4","gravatar_id":"","url":"https://api.github.com/users/leroy-merlin-br","html_url":"https://github.com/leroy-merlin-br","followers_url":"https://api.github.com/users/leroy-merlin-br/followers","following_url":"https://api.github.com/users/leroy-merlin-br/following{/other_user}","gists_url":"https://api.github.com/users/leroy-merlin-br/gists{/gist_id}","starred_url":"https://api.github.com/users/leroy-merlin-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leroy-merlin-br/subscriptions","organizations_url":"https://api.github.com/users/leroy-merlin-br/orgs","repos_url":"https://api.github.com/users/leroy-merlin-br/repos","events_url":"https://api.github.com/users/leroy-merlin-br/events{/privacy}","received_events_url":"https://api.github.com/users/leroy-merlin-br/received_events","type":"Organization","site_admin":false},"repo":{"id":48196975,"name":"garden","full_name":"leroy-merlin-br/garden","owner":{"login":"leroy-merlin-br","id":4422202,"avatar_url":"https://avatars1.githubusercontent.com/u/4422202?v=4","gravatar_id":"","url":"https://api.github.com/users/leroy-merlin-br","html_url":"https://github.com/leroy-merlin-br","followers_url":"https://api.github.com/users/leroy-merlin-br/followers","following_url":"https://api.github.com/users/leroy-merlin-br/following{/other_user}","gists_url":"https://api.github.com/users/leroy-merlin-br/gists{/gist_id}","starred_url":"https://api.github.com/users/leroy-merlin-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leroy-merlin-br/subscriptions","organizations_url":"https://api.github.com/users/leroy-merlin-br/orgs","repos_url":"https://api.github.com/users/leroy-merlin-br/repos","events_url":"https://api.github.com/users/leroy-merlin-br/events{/privacy}","received_events_url":"https://api.github.com/users/leroy-merlin-br/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leroy-merlin-br/garden","description":"A styleguide based on Leroy Merlin needs","fork":false,"url":"https://api.github.com/repos/leroy-merlin-br/garden","forks_url":"https://api.github.com/repos/leroy-merlin-br/garden/forks","keys_url":"https://api.github.com/repos/leroy-merlin-br/garden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leroy-merlin-br/garden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leroy-merlin-br/garden/teams","hooks_url":"https://api.github.com/repos/leroy-merlin-br/garden/hooks","issue_events_url":"https://api.github.com/repos/leroy-merlin-br/garden/issues/events{/number}","events_url":"https://api.github.com/repos/leroy-merlin-br/garden/events","assignees_url":"https://api.github.com/repos/leroy-merlin-br/garden/assignees{/user}","branches_url":"https://api.github.com/repos/leroy-merlin-br/garden/branches{/branch}","tags_url":"https://api.github.com/repos/leroy-merlin-br/garden/tags","blobs_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/refs{/sha}","trees_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leroy-merlin-br/garden/statuses/{sha}","languages_url":"https://api.github.com/repos/leroy-merlin-br/garden/languages","stargazers_url":"https://api.github.com/repos/leroy-merlin-br/garden/stargazers","contributors_url":"https://api.github.com/repos/leroy-merlin-br/garden/contributors","subscribers_url":"https://api.github.com/repos/leroy-merlin-br/garden/subscribers","subscription_url":"https://api.github.com/repos/leroy-merlin-br/garden/subscription","commits_url":"https://api.github.com/repos/leroy-merlin-br/garden/commits{/sha}","git_commits_url":"https://api.github.com/repos/leroy-merlin-br/garden/git/commits{/sha}","comments_url":"https://api.github.com/repos/leroy-merlin-br/garden/comments{/number}","issue_comment_url":"https://api.github.com/repos/leroy-merlin-br/garden/issues/comments{/number}","contents_url":"https://api.github.com/repos/leroy-merlin-br/garden/contents/{+path}","compare_url":"https://api.github.com/repos/leroy-merlin-br/garden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leroy-merlin-br/garden/merges","archive_url":"https://api.github.com/repos/leroy-merlin-br/garden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leroy-merlin-br/garden/downloads","issues_url":"https://api.github.com/repos/leroy-merlin-br/garden/issues{/number}","pulls_url":"https://api.github.com/repos/leroy-merlin-br/garden/pulls{/number}","milestones_url":"https://api.github.com/repos/leroy-merlin-br/garden/milestones{/number}","notifications_url":"https://api.github.com/repos/leroy-merlin-br/garden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leroy-merlin-br/garden/labels{/name}","releases_url":"https://api.github.com/repos/leroy-merlin-br/garden/releases{/id}","deployments_url":"https://api.github.com/repos/leroy-merlin-br/garden/deployments","created_at":"2015-12-17T20:36:16Z","updated_at":"2017-11-04T16:59:21Z","pushed_at":"2017-11-06T18:53:59Z","git_url":"git://github.com/leroy-merlin-br/garden.git","ssh_url":"[email protected]:leroy-merlin-br/garden.git","clone_url":"https://github.com/leroy-merlin-br/garden.git","svn_url":"https://github.com/leroy-merlin-br/garden","homepage":"http://styleguide.leroymerlin.com.br","size":2656,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":10,"open_issues":8,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/316"},"html":{"href":"https://github.com/leroy-merlin-br/garden/pull/316"},"issue":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/issues/316"},"comments":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/leroy-merlin-br/garden/statuses/9a20334a77ca27e5dc6aa6d94858c52cef6ce9cc"}},"author_association":"COLLABORATOR"}} | {
"id": 48196975,
"name": "leroy-merlin-br/garden",
"url": "https://api.github.com/repos/leroy-merlin-br/garden"
} | {
"id": 6568078,
"login": "willamesoares",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6568078?",
"url": "https://api.github.com/users/willamesoares"
} | {
"id": 4422202,
"login": "leroy-merlin-br",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4422202?",
"url": "https://api.github.com/orgs/leroy-merlin-br"
} | 2017-11-06T19:17:06 | 6816335363 | {"actor":{"display_login":"willamesoares"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/comments/133691583","pull_request_review_id":56887266,"id":133691583,"diff_hunk":"@@ -0,0 +1,9 @@\n+FROM jboss/keycloak-ha-postgres\n+\n+ADD docker-entrypoint.sh /opt/jboss/","path":"keycloak/deploy/docker/Dockerfile","position":3,"original_position":3,"commit_id":"832f7f461c608977e59ebbbc5d511a20f68ea8dd","original_commit_id":"832f7f461c608977e59ebbbc5d511a20f68ea8dd","user":{"login":"kochhar","id":103850,"avatar_url":"https://avatars2.githubusercontent.com/u/103850?v=4","gravatar_id":"","url":"https://api.github.com/users/kochhar","html_url":"https://github.com/kochhar","followers_url":"https://api.github.com/users/kochhar/followers","following_url":"https://api.github.com/users/kochhar/following{/other_user}","gists_url":"https://api.github.com/users/kochhar/gists{/gist_id}","starred_url":"https://api.github.com/users/kochhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochhar/subscriptions","organizations_url":"https://api.github.com/users/kochhar/orgs","repos_url":"https://api.github.com/users/kochhar/repos","events_url":"https://api.github.com/users/kochhar/events{/privacy}","received_events_url":"https://api.github.com/users/kochhar/received_events","type":"User","site_admin":false},"body":"Also need to change the standalone-ha.xml during the build to set\r\n1. database configuration\r\n1. logging configuration \r\n1. jgroups cluster configuration.","created_at":"2017-08-17T11:54:07Z","updated_at":"2017-08-17T11:55:18Z","html_url":"https://github.com/project-sunbird/sunbird-auth/pull/2#discussion_r133691583","pull_request_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/comments/133691583"},"html":{"href":"https://github.com/project-sunbird/sunbird-auth/pull/2#discussion_r133691583"},"pull_request":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/2","id":134621858,"html_url":"https://github.com/project-sunbird/sunbird-auth/pull/2","diff_url":"https://github.com/project-sunbird/sunbird-auth/pull/2.diff","patch_url":"https://github.com/project-sunbird/sunbird-auth/pull/2.patch","issue_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/issues/2","number":2,"state":"open","locked":false,"title":"Issue #1 feat: docker compose files for keycloak","user":{"login":"devops-ekstep","id":17425432,"avatar_url":"https://avatars1.githubusercontent.com/u/17425432?v=4","gravatar_id":"","url":"https://api.github.com/users/devops-ekstep","html_url":"https://github.com/devops-ekstep","followers_url":"https://api.github.com/users/devops-ekstep/followers","following_url":"https://api.github.com/users/devops-ekstep/following{/other_user}","gists_url":"https://api.github.com/users/devops-ekstep/gists{/gist_id}","starred_url":"https://api.github.com/users/devops-ekstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devops-ekstep/subscriptions","organizations_url":"https://api.github.com/users/devops-ekstep/orgs","repos_url":"https://api.github.com/users/devops-ekstep/repos","events_url":"https://api.github.com/users/devops-ekstep/events{/privacy}","received_events_url":"https://api.github.com/users/devops-ekstep/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-08T10:03:25Z","updated_at":"2017-08-17T11:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42976d517ce7e48b39bb138f611571da677d5b89","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/2/commits","review_comments_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/2/comments","review_comment_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/issues/2/comments","statuses_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/statuses/832f7f461c608977e59ebbbc5d511a20f68ea8dd","head":{"label":"devops-ekstep:keycloak-v1.0","ref":"keycloak-v1.0","sha":"832f7f461c608977e59ebbbc5d511a20f68ea8dd","user":{"login":"devops-ekstep","id":17425432,"avatar_url":"https://avatars1.githubusercontent.com/u/17425432?v=4","gravatar_id":"","url":"https://api.github.com/users/devops-ekstep","html_url":"https://github.com/devops-ekstep","followers_url":"https://api.github.com/users/devops-ekstep/followers","following_url":"https://api.github.com/users/devops-ekstep/following{/other_user}","gists_url":"https://api.github.com/users/devops-ekstep/gists{/gist_id}","starred_url":"https://api.github.com/users/devops-ekstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devops-ekstep/subscriptions","organizations_url":"https://api.github.com/users/devops-ekstep/orgs","repos_url":"https://api.github.com/users/devops-ekstep/repos","events_url":"https://api.github.com/users/devops-ekstep/events{/privacy}","received_events_url":"https://api.github.com/users/devops-ekstep/received_events","type":"User","site_admin":false},"repo":{"id":99673083,"name":"sunbird-auth","full_name":"devops-ekstep/sunbird-auth","owner":{"login":"devops-ekstep","id":17425432,"avatar_url":"https://avatars1.githubusercontent.com/u/17425432?v=4","gravatar_id":"","url":"https://api.github.com/users/devops-ekstep","html_url":"https://github.com/devops-ekstep","followers_url":"https://api.github.com/users/devops-ekstep/followers","following_url":"https://api.github.com/users/devops-ekstep/following{/other_user}","gists_url":"https://api.github.com/users/devops-ekstep/gists{/gist_id}","starred_url":"https://api.github.com/users/devops-ekstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devops-ekstep/subscriptions","organizations_url":"https://api.github.com/users/devops-ekstep/orgs","repos_url":"https://api.github.com/users/devops-ekstep/repos","events_url":"https://api.github.com/users/devops-ekstep/events{/privacy}","received_events_url":"https://api.github.com/users/devops-ekstep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devops-ekstep/sunbird-auth","description":"Repository for sunbird authentication service","fork":true,"url":"https://api.github.com/repos/devops-ekstep/sunbird-auth","forks_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/forks","keys_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/teams","hooks_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/hooks","issue_events_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/issues/events{/number}","events_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/events","assignees_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/assignees{/user}","branches_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/branches{/branch}","tags_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/tags","blobs_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/languages","stargazers_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/stargazers","contributors_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/contributors","subscribers_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/subscribers","subscription_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/subscription","commits_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/contents/{+path}","compare_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/merges","archive_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/downloads","issues_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/issues{/number}","pulls_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/labels{/name}","releases_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/releases{/id}","deployments_url":"https://api.github.com/repos/devops-ekstep/sunbird-auth/deployments","created_at":"2017-08-08T09:05:22Z","updated_at":"2017-08-08T06:44:16Z","pushed_at":"2017-08-17T11:08:46Z","git_url":"git://github.com/devops-ekstep/sunbird-auth.git","ssh_url":"[email protected]:devops-ekstep/sunbird-auth.git","clone_url":"https://github.com/devops-ekstep/sunbird-auth.git","svn_url":"https://github.com/devops-ekstep/sunbird-auth","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"project-sunbird:master","ref":"master","sha":"48856b9229e1c4c451ebd437d75ee6f3a18ef920","user":{"login":"project-sunbird","id":26705730,"avatar_url":"https://avatars1.githubusercontent.com/u/26705730?v=4","gravatar_id":"","url":"https://api.github.com/users/project-sunbird","html_url":"https://github.com/project-sunbird","followers_url":"https://api.github.com/users/project-sunbird/followers","following_url":"https://api.github.com/users/project-sunbird/following{/other_user}","gists_url":"https://api.github.com/users/project-sunbird/gists{/gist_id}","starred_url":"https://api.github.com/users/project-sunbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-sunbird/subscriptions","organizations_url":"https://api.github.com/users/project-sunbird/orgs","repos_url":"https://api.github.com/users/project-sunbird/repos","events_url":"https://api.github.com/users/project-sunbird/events{/privacy}","received_events_url":"https://api.github.com/users/project-sunbird/received_events","type":"Organization","site_admin":false},"repo":{"id":99659589,"name":"sunbird-auth","full_name":"project-sunbird/sunbird-auth","owner":{"login":"project-sunbird","id":26705730,"avatar_url":"https://avatars1.githubusercontent.com/u/26705730?v=4","gravatar_id":"","url":"https://api.github.com/users/project-sunbird","html_url":"https://github.com/project-sunbird","followers_url":"https://api.github.com/users/project-sunbird/followers","following_url":"https://api.github.com/users/project-sunbird/following{/other_user}","gists_url":"https://api.github.com/users/project-sunbird/gists{/gist_id}","starred_url":"https://api.github.com/users/project-sunbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-sunbird/subscriptions","organizations_url":"https://api.github.com/users/project-sunbird/orgs","repos_url":"https://api.github.com/users/project-sunbird/repos","events_url":"https://api.github.com/users/project-sunbird/events{/privacy}","received_events_url":"https://api.github.com/users/project-sunbird/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/project-sunbird/sunbird-auth","description":"Repository for sunbird authentication service","fork":false,"url":"https://api.github.com/repos/project-sunbird/sunbird-auth","forks_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/forks","keys_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/teams","hooks_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/hooks","issue_events_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/issues/events{/number}","events_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/events","assignees_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/assignees{/user}","branches_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/branches{/branch}","tags_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/tags","blobs_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/languages","stargazers_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/stargazers","contributors_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/contributors","subscribers_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/subscribers","subscription_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/subscription","commits_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/contents/{+path}","compare_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/merges","archive_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/downloads","issues_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/issues{/number}","pulls_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/labels{/name}","releases_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/releases{/id}","deployments_url":"https://api.github.com/repos/project-sunbird/sunbird-auth/deployments","created_at":"2017-08-08T06:44:16Z","updated_at":"2017-08-08T06:44:16Z","pushed_at":"2017-08-17T11:08:48Z","git_url":"git://github.com/project-sunbird/sunbird-auth.git","ssh_url":"[email protected]:project-sunbird/sunbird-auth.git","clone_url":"https://github.com/project-sunbird/sunbird-auth.git","svn_url":"https://github.com/project-sunbird/sunbird-auth","homepage":null,"size":14,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/2"},"html":{"href":"https://github.com/project-sunbird/sunbird-auth/pull/2"},"issue":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/issues/2"},"comments":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/project-sunbird/sunbird-auth/statuses/832f7f461c608977e59ebbbc5d511a20f68ea8dd"}}}} | {
"id": 99659589,
"name": "project-sunbird/sunbird-auth",
"url": "https://api.github.com/repos/project-sunbird/sunbird-auth"
} | {
"id": 103850,
"login": "kochhar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/103850?",
"url": "https://api.github.com/users/kochhar"
} | {
"id": 26705730,
"login": "project-sunbird",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26705730?",
"url": "https://api.github.com/orgs/project-sunbird"
} | 2017-08-17T11:54:07 | 6471539844 | {"actor":{"display_login":"kochhar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/comments/140612881","pull_request_review_id":64717935,"id":140612881,"diff_hunk":"@@ -236,46 +256,59 @@ def tell(self, x, y, fit=True):\n warnings.simplefilter(\"ignore\")\n est.fit(self.space.transform(self.Xi), self.yi)\n \n+ if hasattr(self, \"next_xs_\") and self.acq_func == \"gp_hedge\":\n+ self.gains_ -= est.predict(np.vstack(self.next_xs_))","path":"skopt/optimizer/optimizer.py","position":53,"original_position":53,"commit_id":"67dd5aa226a1151d6bcad3e7c759a39848b82f01","original_commit_id":"67dd5aa226a1151d6bcad3e7c759a39848b82f01","user":{"login":"kejiashi","id":13544908,"avatar_url":"https://avatars2.githubusercontent.com/u/13544908?v=4","gravatar_id":"","url":"https://api.github.com/users/kejiashi","html_url":"https://github.com/kejiashi","followers_url":"https://api.github.com/users/kejiashi/followers","following_url":"https://api.github.com/users/kejiashi/following{/other_user}","gists_url":"https://api.github.com/users/kejiashi/gists{/gist_id}","starred_url":"https://api.github.com/users/kejiashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kejiashi/subscriptions","organizations_url":"https://api.github.com/users/kejiashi/orgs","repos_url":"https://api.github.com/users/kejiashi/repos","events_url":"https://api.github.com/users/kejiashi/events{/privacy}","received_events_url":"https://api.github.com/users/kejiashi/received_events","type":"User","site_admin":false},"body":"@betatim Excuse me for the late reply. It could be a false alarm, since I did a [test](https://github.com/kejiashi/optimization-dump-truck/blob/master/hedge_test.ipynb) and found no issue with the original code. But I think some of my understandings of the code need to be corrected and discussed. Let me open a new issue.","created_at":"2017-09-22T23:04:15Z","updated_at":"2017-09-22T23:04:16Z","html_url":"https://github.com/scikit-optimize/scikit-optimize/pull/306#discussion_r140612881","pull_request_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/comments/140612881"},"html":{"href":"https://github.com/scikit-optimize/scikit-optimize/pull/306#discussion_r140612881"},"pull_request":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/306"}},"in_reply_to_id":140037830},"pull_request":{"url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/306","id":103985123,"html_url":"https://github.com/scikit-optimize/scikit-optimize/pull/306","diff_url":"https://github.com/scikit-optimize/scikit-optimize/pull/306.diff","patch_url":"https://github.com/scikit-optimize/scikit-optimize/pull/306.patch","issue_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/306","number":306,"state":"closed","locked":false,"title":"[MRG] Implement GP-Hedge acquisition function","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars3.githubusercontent.com/u/1867024?v=4","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"body":"This implements the GP-Hedge acquisition function as described in Algorithm 2 of https://dslpitt.org/uai/papers/11/p327-hoffman.pdf \r\n\r\nThe idea is given a number of acquisition functions, at every `tell` to choose the best acquisition function that gives the maximum gain.","created_at":"2017-01-31T17:33:59Z","updated_at":"2017-09-22T23:04:16Z","closed_at":"2017-02-10T15:11:02Z","merged_at":"2017-02-10T15:11:02Z","merge_commit_sha":"acbbc761e5c1b9bbb273473cf7a917b35314b2b1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/milestones/3","html_url":"https://github.com/scikit-optimize/scikit-optimize/milestone/3","labels_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/milestones/3/labels","id":2131704,"number":3,"title":"0.3","description":"","creator":{"login":"glouppe","id":477771,"avatar_url":"https://avatars3.githubusercontent.com/u/477771?v=4","gravatar_id":"","url":"https://api.github.com/users/glouppe","html_url":"https://github.com/glouppe","followers_url":"https://api.github.com/users/glouppe/followers","following_url":"https://api.github.com/users/glouppe/following{/other_user}","gists_url":"https://api.github.com/users/glouppe/gists{/gist_id}","starred_url":"https://api.github.com/users/glouppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glouppe/subscriptions","organizations_url":"https://api.github.com/users/glouppe/orgs","repos_url":"https://api.github.com/users/glouppe/repos","events_url":"https://api.github.com/users/glouppe/events{/privacy}","received_events_url":"https://api.github.com/users/glouppe/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":15,"state":"closed","created_at":"2016-11-13T13:32:29Z","updated_at":"2017-02-14T06:58:31Z","due_on":null,"closed_at":"2017-02-14T06:58:31Z"},"commits_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/306/commits","review_comments_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/306/comments","review_comment_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/306/comments","statuses_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/statuses/67dd5aa226a1151d6bcad3e7c759a39848b82f01","head":{"label":"MechCoder:gp_hedge","ref":"gp_hedge","sha":"67dd5aa226a1151d6bcad3e7c759a39848b82f01","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars3.githubusercontent.com/u/1867024?v=4","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"repo":{"id":56717415,"name":"scikit-optimize","full_name":"MechCoder/scikit-optimize","owner":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars3.githubusercontent.com/u/1867024?v=4","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MechCoder/scikit-optimize","description":"A sandmine for blackbox optimization methods following the scipy.optimize interface","fork":true,"url":"https://api.github.com/repos/MechCoder/scikit-optimize","forks_url":"https://api.github.com/repos/MechCoder/scikit-optimize/forks","keys_url":"https://api.github.com/repos/MechCoder/scikit-optimize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MechCoder/scikit-optimize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MechCoder/scikit-optimize/teams","hooks_url":"https://api.github.com/repos/MechCoder/scikit-optimize/hooks","issue_events_url":"https://api.github.com/repos/MechCoder/scikit-optimize/issues/events{/number}","events_url":"https://api.github.com/repos/MechCoder/scikit-optimize/events","assignees_url":"https://api.github.com/repos/MechCoder/scikit-optimize/assignees{/user}","branches_url":"https://api.github.com/repos/MechCoder/scikit-optimize/branches{/branch}","tags_url":"https://api.github.com/repos/MechCoder/scikit-optimize/tags","blobs_url":"https://api.github.com/repos/MechCoder/scikit-optimize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MechCoder/scikit-optimize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MechCoder/scikit-optimize/git/refs{/sha}","trees_url":"https://api.github.com/repos/MechCoder/scikit-optimize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MechCoder/scikit-optimize/statuses/{sha}","languages_url":"https://api.github.com/repos/MechCoder/scikit-optimize/languages","stargazers_url":"https://api.github.com/repos/MechCoder/scikit-optimize/stargazers","contributors_url":"https://api.github.com/repos/MechCoder/scikit-optimize/contributors","subscribers_url":"https://api.github.com/repos/MechCoder/scikit-optimize/subscribers","subscription_url":"https://api.github.com/repos/MechCoder/scikit-optimize/subscription","commits_url":"https://api.github.com/repos/MechCoder/scikit-optimize/commits{/sha}","git_commits_url":"https://api.github.com/repos/MechCoder/scikit-optimize/git/commits{/sha}","comments_url":"https://api.github.com/repos/MechCoder/scikit-optimize/comments{/number}","issue_comment_url":"https://api.github.com/repos/MechCoder/scikit-optimize/issues/comments{/number}","contents_url":"https://api.github.com/repos/MechCoder/scikit-optimize/contents/{+path}","compare_url":"https://api.github.com/repos/MechCoder/scikit-optimize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MechCoder/scikit-optimize/merges","archive_url":"https://api.github.com/repos/MechCoder/scikit-optimize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MechCoder/scikit-optimize/downloads","issues_url":"https://api.github.com/repos/MechCoder/scikit-optimize/issues{/number}","pulls_url":"https://api.github.com/repos/MechCoder/scikit-optimize/pulls{/number}","milestones_url":"https://api.github.com/repos/MechCoder/scikit-optimize/milestones{/number}","notifications_url":"https://api.github.com/repos/MechCoder/scikit-optimize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MechCoder/scikit-optimize/labels{/name}","releases_url":"https://api.github.com/repos/MechCoder/scikit-optimize/releases{/id}","deployments_url":"https://api.github.com/repos/MechCoder/scikit-optimize/deployments","created_at":"2016-04-20T20:04:15Z","updated_at":"2016-10-25T19:25:46Z","pushed_at":"2017-09-11T01:32:18Z","git_url":"git://github.com/MechCoder/scikit-optimize.git","ssh_url":"[email protected]:MechCoder/scikit-optimize.git","clone_url":"https://github.com/MechCoder/scikit-optimize.git","svn_url":"https://github.com/MechCoder/scikit-optimize","homepage":null,"size":8112,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-optimize:master","ref":"master","sha":"c8c4087b4774a51edd6cf58378ad79787c16acda","user":{"login":"scikit-optimize","id":18578550,"avatar_url":"https://avatars2.githubusercontent.com/u/18578550?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-optimize","html_url":"https://github.com/scikit-optimize","followers_url":"https://api.github.com/users/scikit-optimize/followers","following_url":"https://api.github.com/users/scikit-optimize/following{/other_user}","gists_url":"https://api.github.com/users/scikit-optimize/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-optimize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-optimize/subscriptions","organizations_url":"https://api.github.com/users/scikit-optimize/orgs","repos_url":"https://api.github.com/users/scikit-optimize/repos","events_url":"https://api.github.com/users/scikit-optimize/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-optimize/received_events","type":"Organization","site_admin":false},"repo":{"id":54340642,"name":"scikit-optimize","full_name":"scikit-optimize/scikit-optimize","owner":{"login":"scikit-optimize","id":18578550,"avatar_url":"https://avatars2.githubusercontent.com/u/18578550?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-optimize","html_url":"https://github.com/scikit-optimize","followers_url":"https://api.github.com/users/scikit-optimize/followers","following_url":"https://api.github.com/users/scikit-optimize/following{/other_user}","gists_url":"https://api.github.com/users/scikit-optimize/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-optimize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-optimize/subscriptions","organizations_url":"https://api.github.com/users/scikit-optimize/orgs","repos_url":"https://api.github.com/users/scikit-optimize/repos","events_url":"https://api.github.com/users/scikit-optimize/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-optimize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-optimize/scikit-optimize","description":"Sequential model-based optimization with a `scipy.optimize` interface","fork":false,"url":"https://api.github.com/repos/scikit-optimize/scikit-optimize","forks_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/forks","keys_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/teams","hooks_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/hooks","issue_events_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/events","assignees_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/tags","blobs_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/languages","stargazers_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/stargazers","contributors_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/contributors","subscribers_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/subscribers","subscription_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/subscription","commits_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/merges","archive_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/downloads","issues_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/labels{/name}","releases_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/deployments","created_at":"2016-03-20T21:10:54Z","updated_at":"2017-09-22T14:45:28Z","pushed_at":"2017-09-21T15:14:30Z","git_url":"git://github.com/scikit-optimize/scikit-optimize.git","ssh_url":"[email protected]:scikit-optimize/scikit-optimize.git","clone_url":"https://github.com/scikit-optimize/scikit-optimize.git","svn_url":"https://github.com/scikit-optimize/scikit-optimize","homepage":"https://scikit-optimize.github.io","size":8134,"stargazers_count":581,"watchers_count":581,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":95,"forks":109,"open_issues":95,"watchers":581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/306"},"html":{"href":"https://github.com/scikit-optimize/scikit-optimize/pull/306"},"issue":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/306"},"comments":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-optimize/scikit-optimize/statuses/67dd5aa226a1151d6bcad3e7c759a39848b82f01"}},"author_association":"OWNER"}} | {
"id": 54340642,
"name": "scikit-optimize/scikit-optimize",
"url": "https://api.github.com/repos/scikit-optimize/scikit-optimize"
} | {
"id": 13544908,
"login": "kejiashi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13544908?",
"url": "https://api.github.com/users/kejiashi"
} | {
"id": 18578550,
"login": "scikit-optimize",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18578550?",
"url": "https://api.github.com/orgs/scikit-optimize"
} | 2017-09-22T23:04:15 | 6627120835 | {"actor":{"display_login":"kejiashi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments/100752546","pull_request_review_id":21465820,"id":100752546,"diff_hunk":"@@ -0,0 +1,155 @@\n+---------------------------------------------------------------------------------------------\n+-- Requirement summary:\n+-- SDL must send WARNINGS (success:true) to mobile app in case HMI respond WARNINGS to at least one HMI-portions\n+--\n+-- Description:\n+-- test is intended to check that SDL sends WARNINGS (success:true) to mobile app in case HMI respond WARNINGS to at least one HMI-portions\n+-- Checks that SDL sends WARNINGS(success:true) to mobile app in case HMI respond WARNINGS(success:true) to UI.PerformAudioPassThru and ANY successfull result code to TTS.Speak\n+--\n+-- 1. Used preconditions:\n+-- App is registered and activated SUCCESSFULLY\n+-- 2. Performed steps:\n+-- MOB -> SDL: sends PerformAudioPassThru\n+-- HMI -> SDL: UI.PerformAudioPassThru (WARNINGS), TTS.Speak (cyclically checked cases fo result codes SUCCESS, WARNINGS, WRONG_LANGUAGE, RETRY, SAVED)\n+--\n+-- Expected result:\n+-- SDL -> HMI: resends UI.PerformAudioPassThru and TTS.Speak\n+-- SDL -> MOB: PerformAudioPassThru (resultcode: WARNINGS, success: true)\n+---------------------------------------------------------------------------------------------\n+\n+--[[ General configuration parameters ]]\n+config.deviceMAC = \"12ca17b49af2289436f303e0166030a21e525d266e209267433801a8fd4071a0\"\n+-- ToDo (vvvakulenko): remove after issue \"ATF does not stop HB timers by closing session and connection\" is resolved\n+config.defaultProtocolVersion = 2\n+\n+--[[ Required Shared libraries ]]\n+local commonFunctions = require ('user_modules/shared_testcases/commonFunctions')\n+local commonSteps = require ('user_modules/shared_testcases/commonSteps')\n+local commonPreconditions = require('user_modules/shared_testcases/commonPreconditions')\n+local testCasesForPolicyTable = require('user_modules/shared_testcases/testCasesForPolicyTable')\n+local testCasesForPerformAudioPassThru = require('user_modules/shared_testcases/testCasesForPerformAudioPassThru')\n+local commonTestCases = require('user_modules/shared_testcases/commonTestCases')\n+config.SDLStoragePath = commonPreconditions:GetPathToSDL() .. \"storage/\"\n+\n+--[[ Local Variables ]]\n+local storagePath = config.SDLStoragePath..config.application1.registerAppInterfaceParams.appID.. \"_\" .. config.deviceMAC.. \"/\"\n+local ServerAddress = commonFunctions:read_parameter_from_smart_device_link_ini(\"ServerAddress\")\n+\n+--[[ General Precondition before ATF start ]]\n+commonFunctions:SDLForceStop()\n+commonSteps:DeleteLogsFiles()\n+commonSteps:DeletePolicyTable()\n+testCasesForPolicyTable:precondition_updatePolicy_AllowFunctionInHmiLeves({\"BACKGROUND\", \"FULL\", \"LIMITED\"},\"PerformAudioPassThru\")\n+\n+--[[ General Settings for configuration ]]\n+Test = require('connecttest')\n+require('user_modules/AppTypes')\n+\n+--[[ Preconditions ]]\n+commonFunctions:newTestCasesGroup(\"Preconditions\")\n+\n+commonSteps:PutFile(\"Precondition_PutFile\", \"icon.png\")\n+\n+function Test:Precondition_Check_audioPassThruIcon_Existence()\n+ testCasesForPerformAudioPassThru.Check_audioPassThruIcon_Existence(self, \"icon.png\")\n+end\n+\n+function Test:Precondition_ActivationApp()\n+ local request_id = self.hmiConnection:SendRequest(\"SDL.ActivateApp\", { appID = self.applications[config.application1.registerAppInterfaceParams.appName]})\n+ EXPECT_HMIRESPONSE(request_id)\n+ :Do(function(_,data)\n+ if (data.result.isSDLAllowed ~= true) then\n+ local request_id1 = self.hmiConnection:SendRequest(\"SDL.GetUserFriendlyMessage\", {language = \"EN-US\", messageCodes = {\"DataConsent\"}})\n+ EXPECT_HMIRESPONSE(request_id1)\n+ :Do(function(_,_)\n+ self.hmiConnection:SendNotification(\"SDL.OnAllowSDLFunctionality\", {allowed = true, source = \"GUI\", device = {id = config.deviceMAC, name = ServerAddress}})\n+ EXPECT_HMICALL(\"BasicCommunication.ActivateApp\")\n+ :Do(function(_,data1)\n+ self.hmiConnection:SendResponse(data1.id,\"BasicCommunication.ActivateApp\", \"SUCCESS\", {})\n+ end)\n+ end)\n+ end\n+ end)\n+ EXPECT_NOTIFICATION(\"OnHMIStatus\", {hmiLevel = \"FULL\", systemContext = \"MAIN\"})\n+end\n+\n+--[[ Test ]]\n+commonFunctions:newTestCasesGroup(\"Test\")\n+\n+local resultCodes = {\"SUCCESS\", \"WARNINGS\", \"WRONG_LANGUAGE\", \"RETRY\", \"SAVED\"}\n+\n+for i=1,#resultCodes do\n+ Test[\"TestStep_PerformAudioPassThru_UI_PerformAudioPassThru_WARNINGS_and_TTS_Speak_\"..resultCodes[i]] = function(self)\n+ local cor_id= self.mobileSession:SendRPC(\"PerformAudioPassThru\",\n+ {\n+ initialPrompt = {{ text = \"Makeyourchoise\", type = \"TEXT\" }},\n+ audioPassThruDisplayText1 = \"DisplayText1\",\n+ audioPassThruDisplayText2 = \"DisplayText2\",\n+ samplingRate = \"8KHZ\",\n+ maxDuration = 2000,\n+ bitsPerSample = \"8_BIT\",\n+ audioType = \"PCM\",\n+ muteAudio = true\n+ })\n+\n+ EXPECT_HMICALL(\"TTS.Speak\",\n+ {\n+ speakType = \"AUDIO_PASS_THRU\",\n+ ttsChunks = {{ text = \"Makeyourchoise\", type = \"TEXT\" }},\n+ appID = self.applications[config.application1.registerAppInterfaceParams.appName]\n+ })\n+ :Do(function(_,data)\n+ self.hmiConnection:SendNotification(\"TTS.Started\",{ })\n+ local function ttsSpeakResponce()\n+ self.hmiConnection:SendResponse (data.id, data.method, resultCodes[i], {})\n+ self.hmiConnection:SendNotification(\"TTS.Stopped\")\n+ end\n+ end)","path":"test_scripts/API/PerformAudioPassThru/013_ATF_PerformAudioPassThru_UI_PerformAudioPassThru_WARNINGS.lua","position":null,"original_position":107,"commit_id":"17ed7dc07e0cff8d970b028361fc2bd7e3e34701","original_commit_id":"e918b0eb111ad4ad1ec05a7115d6475f303f678f","user":{"login":"vvvakulenko","id":17296046,"avatar_url":"https://avatars.githubusercontent.com/u/17296046?v=3","gravatar_id":"","url":"https://api.github.com/users/vvvakulenko","html_url":"https://github.com/vvvakulenko","followers_url":"https://api.github.com/users/vvvakulenko/followers","following_url":"https://api.github.com/users/vvvakulenko/following{/other_user}","gists_url":"https://api.github.com/users/vvvakulenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vvvakulenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvvakulenko/subscriptions","organizations_url":"https://api.github.com/users/vvvakulenko/orgs","repos_url":"https://api.github.com/users/vvvakulenko/repos","events_url":"https://api.github.com/users/vvvakulenko/events{/privacy}","received_events_url":"https://api.github.com/users/vvvakulenko/received_events","type":"User","site_admin":false},"body":"@istoimenova , updated in commit 17ed7dc07e0cff8d970b028361fc2bd7e3e34701","created_at":"2017-02-13T09:28:19Z","updated_at":"2017-02-13T09:28:19Z","html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/1114#discussion_r100752546","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/1114","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments/100752546"},"html":{"href":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/1114#discussion_r100752546"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/1114"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/1114","id":105470887,"html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/1114","diff_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/1114.diff","patch_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/1114.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/1114","number":1114,"state":"open","locked":false,"title":"Add script checking case when HMI responds WARNINGS(success:true) to…","user":{"login":"vvvakulenko","id":17296046,"avatar_url":"https://avatars.githubusercontent.com/u/17296046?v=3","gravatar_id":"","url":"https://api.github.com/users/vvvakulenko","html_url":"https://github.com/vvvakulenko","followers_url":"https://api.github.com/users/vvvakulenko/followers","following_url":"https://api.github.com/users/vvvakulenko/following{/other_user}","gists_url":"https://api.github.com/users/vvvakulenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vvvakulenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvvakulenko/subscriptions","organizations_url":"https://api.github.com/users/vvvakulenko/orgs","repos_url":"https://api.github.com/users/vvvakulenko/repos","events_url":"https://api.github.com/users/vvvakulenko/events{/privacy}","received_events_url":"https://api.github.com/users/vvvakulenko/received_events","type":"User","site_admin":false},"body":"… UI.PerformAudioPassThru and ANY successfull result code to TTS.Speak\r\nScript is a part of TS #666","created_at":"2017-02-09T17:07:31Z","updated_at":"2017-02-13T09:28:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86512738eccff8226f3571664f69ccdfc43ee5e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/1114/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/1114/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/1114/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/17ed7dc07e0cff8d970b028361fc2bd7e3e34701","head":{"label":"vvvakulenko:feature/WARNINGS_PerformAudioPassThru_UI_PerformAudioPassThru_WARNINGS","ref":"feature/WARNINGS_PerformAudioPassThru_UI_PerformAudioPassThru_WARNINGS","sha":"17ed7dc07e0cff8d970b028361fc2bd7e3e34701","user":{"login":"vvvakulenko","id":17296046,"avatar_url":"https://avatars.githubusercontent.com/u/17296046?v=3","gravatar_id":"","url":"https://api.github.com/users/vvvakulenko","html_url":"https://github.com/vvvakulenko","followers_url":"https://api.github.com/users/vvvakulenko/followers","following_url":"https://api.github.com/users/vvvakulenko/following{/other_user}","gists_url":"https://api.github.com/users/vvvakulenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vvvakulenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvvakulenko/subscriptions","organizations_url":"https://api.github.com/users/vvvakulenko/orgs","repos_url":"https://api.github.com/users/vvvakulenko/repos","events_url":"https://api.github.com/users/vvvakulenko/events{/privacy}","received_events_url":"https://api.github.com/users/vvvakulenko/received_events","type":"User","site_admin":false},"repo":{"id":73722061,"name":"sdl_atf_test_scripts-open","full_name":"vvvakulenko/sdl_atf_test_scripts-open","owner":{"login":"vvvakulenko","id":17296046,"avatar_url":"https://avatars.githubusercontent.com/u/17296046?v=3","gravatar_id":"","url":"https://api.github.com/users/vvvakulenko","html_url":"https://github.com/vvvakulenko","followers_url":"https://api.github.com/users/vvvakulenko/followers","following_url":"https://api.github.com/users/vvvakulenko/following{/other_user}","gists_url":"https://api.github.com/users/vvvakulenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vvvakulenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvvakulenko/subscriptions","organizations_url":"https://api.github.com/users/vvvakulenko/orgs","repos_url":"https://api.github.com/users/vvvakulenko/repos","events_url":"https://api.github.com/users/vvvakulenko/events{/privacy}","received_events_url":"https://api.github.com/users/vvvakulenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvvakulenko/sdl_atf_test_scripts-open","description":"Test scripts for sdl_atf","fork":true,"url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open","forks_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/forks","keys_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/teams","hooks_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/hooks","issue_events_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/issues/events{/number}","events_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/events","assignees_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/assignees{/user}","branches_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/branches{/branch}","tags_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/tags","blobs_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/statuses/{sha}","languages_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/languages","stargazers_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/stargazers","contributors_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/contributors","subscribers_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/subscribers","subscription_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/subscription","commits_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/contents/{+path}","compare_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/merges","archive_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/downloads","issues_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/issues{/number}","pulls_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/pulls{/number}","milestones_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/milestones{/number}","notifications_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/labels{/name}","releases_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/releases{/id}","deployments_url":"https://api.github.com/repos/vvvakulenko/sdl_atf_test_scripts-open/deployments","created_at":"2016-11-14T16:01:08Z","updated_at":"2016-11-14T16:06:36Z","pushed_at":"2017-02-13T09:27:16Z","git_url":"git://github.com/vvvakulenko/sdl_atf_test_scripts-open.git","ssh_url":"[email protected]:vvvakulenko/sdl_atf_test_scripts-open.git","clone_url":"https://github.com/vvvakulenko/sdl_atf_test_scripts-open.git","svn_url":"https://github.com/vvvakulenko/sdl_atf_test_scripts-open","homepage":null,"size":21260,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:feature/extended_policy_functionality","ref":"feature/extended_policy_functionality","sha":"6d501731310664f87765891ee9270189378aae89","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":53459525,"name":"sdl_atf_test_scripts","full_name":"smartdevicelink/sdl_atf_test_scripts","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts","description":"Test scripts for sdl_atf","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/deployments","created_at":"2016-03-09T01:53:02Z","updated_at":"2016-12-20T07:08:41Z","pushed_at":"2017-02-13T09:27:16Z","git_url":"git://github.com/smartdevicelink/sdl_atf_test_scripts.git","ssh_url":"[email protected]:smartdevicelink/sdl_atf_test_scripts.git","clone_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts.git","svn_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts","homepage":null,"size":22480,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":17,"forks":25,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/1114"},"html":{"href":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/1114"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/1114"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/1114/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/1114/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/1114/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/17ed7dc07e0cff8d970b028361fc2bd7e3e34701"}}}} | {
"id": 53459525,
"name": "smartdevicelink/sdl_atf_test_scripts",
"url": "https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts"
} | {
"id": 17296046,
"login": "vvvakulenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17296046?",
"url": "https://api.github.com/users/vvvakulenko"
} | {
"id": 8671397,
"login": "smartdevicelink",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8671397?",
"url": "https://api.github.com/orgs/smartdevicelink"
} | 2017-02-13T09:28:19 | 5312559801 | {"actor":{"display_login":"vvvakulenko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/comments/132546100","pull_request_review_id":55639870,"id":132546100,"diff_hunk":"@@ -488,24 +684,28 @@ public static void CreateAndWriteMyMzmlWithCalibratedSpectra(IMsDataFile<IMsData\n {\n name = CentroidNames[myMsDataFile.GetOneBasedScan(i).IsCentroid],\n accession = CentroidAccessions[myMsDataFile.GetOneBasedScan(i).IsCentroid],\n- cvRef = \"MS\"\n+ cvRef = \"MS\",\n+ value = \"\"\n };\n if (PolarityNames.TryGetValue(myMsDataFile.GetOneBasedScan(i).Polarity, out string polarityName) && PolarityAccessions.TryGetValue(myMsDataFile.GetOneBasedScan(i).Polarity, out string polarityAccession))\n {\n mzML.run.spectrumList.spectrum[i - 1].cvParam[3] = new Generated.CVParamType()\n {\n name = polarityName,\n accession = polarityAccession,\n- cvRef = \"MS\"\n+ cvRef = \"MS\",\n+ value = \"\"\n };\n }\n // Spectrum title\n+ //string title = System.IO.Path.GetFileNameWithoutExtension(outputFile);\n mzML.run.spectrumList.spectrum[i - 1].cvParam[4] = new Generated.CVParamType()\n {\n name = \"spectrum title\",\n accession = \"MS:1000796\",\n- value = myMsDataFile.GetOneBasedScan(i).OneBasedScanNumber.ToString(),\n- cvRef = \"MS\"\n+ value = title + \".\" + (i + 1) + \".\" + (i + 1) + \".\" + \" File:\\\"\\\", NativeID:\\\"\" + mzML.run.spectrumList.spectrum[i - 1].id + \"\\\"\",","path":"MzML/MzmlMethods.cs","position":492,"original_position":492,"commit_id":"46b190bd182ce92b0661e91f6fee1041841f0649","original_commit_id":"46b190bd182ce92b0661e91f6fee1041841f0649","user":{"login":"stefanks","id":5972770,"avatar_url":"https://avatars1.githubusercontent.com/u/5972770?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanks","html_url":"https://github.com/stefanks","followers_url":"https://api.github.com/users/stefanks/followers","following_url":"https://api.github.com/users/stefanks/following{/other_user}","gists_url":"https://api.github.com/users/stefanks/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanks/subscriptions","organizations_url":"https://api.github.com/users/stefanks/orgs","repos_url":"https://api.github.com/users/stefanks/repos","events_url":"https://api.github.com/users/stefanks/events{/privacy}","received_events_url":"https://api.github.com/users/stefanks/received_events","type":"User","site_admin":false},"body":"try without spectrum title","created_at":"2017-08-10T19:28:02Z","updated_at":"2017-08-10T19:28:02Z","html_url":"https://github.com/smith-chem-wisc/mzLib/pull/218#discussion_r132546100","pull_request_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/comments/132546100"},"html":{"href":"https://github.com/smith-chem-wisc/mzLib/pull/218#discussion_r132546100"},"pull_request":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/218","id":134055007,"html_url":"https://github.com/smith-chem-wisc/mzLib/pull/218","diff_url":"https://github.com/smith-chem-wisc/mzLib/pull/218.diff","patch_url":"https://github.com/smith-chem-wisc/mzLib/pull/218.patch","issue_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/issues/218","number":218,"state":"open","locked":false,"title":"Indexed Mzml File Writing and semantic fixes","user":{"login":"dippman","id":12360199,"avatar_url":"https://avatars2.githubusercontent.com/u/12360199?v=4","gravatar_id":"","url":"https://api.github.com/users/dippman","html_url":"https://github.com/dippman","followers_url":"https://api.github.com/users/dippman/followers","following_url":"https://api.github.com/users/dippman/following{/other_user}","gists_url":"https://api.github.com/users/dippman/gists{/gist_id}","starred_url":"https://api.github.com/users/dippman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dippman/subscriptions","organizations_url":"https://api.github.com/users/dippman/orgs","repos_url":"https://api.github.com/users/dippman/repos","events_url":"https://api.github.com/users/dippman/events{/privacy}","received_events_url":"https://api.github.com/users/dippman/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-03T22:24:55Z","updated_at":"2017-08-10T19:28:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6df117ab38ab87b09ee111ea7fcebb039b7a3a6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/218/commits","review_comments_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/218/comments","review_comment_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/issues/218/comments","statuses_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/statuses/46b190bd182ce92b0661e91f6fee1041841f0649","head":{"label":"dippman:master","ref":"master","sha":"46b190bd182ce92b0661e91f6fee1041841f0649","user":{"login":"dippman","id":12360199,"avatar_url":"https://avatars2.githubusercontent.com/u/12360199?v=4","gravatar_id":"","url":"https://api.github.com/users/dippman","html_url":"https://github.com/dippman","followers_url":"https://api.github.com/users/dippman/followers","following_url":"https://api.github.com/users/dippman/following{/other_user}","gists_url":"https://api.github.com/users/dippman/gists{/gist_id}","starred_url":"https://api.github.com/users/dippman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dippman/subscriptions","organizations_url":"https://api.github.com/users/dippman/orgs","repos_url":"https://api.github.com/users/dippman/repos","events_url":"https://api.github.com/users/dippman/events{/privacy}","received_events_url":"https://api.github.com/users/dippman/received_events","type":"User","site_admin":false},"repo":{"id":96571584,"name":"mzLib","full_name":"dippman/mzLib","owner":{"login":"dippman","id":12360199,"avatar_url":"https://avatars2.githubusercontent.com/u/12360199?v=4","gravatar_id":"","url":"https://api.github.com/users/dippman","html_url":"https://github.com/dippman","followers_url":"https://api.github.com/users/dippman/followers","following_url":"https://api.github.com/users/dippman/following{/other_user}","gists_url":"https://api.github.com/users/dippman/gists{/gist_id}","starred_url":"https://api.github.com/users/dippman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dippman/subscriptions","organizations_url":"https://api.github.com/users/dippman/orgs","repos_url":"https://api.github.com/users/dippman/repos","events_url":"https://api.github.com/users/dippman/events{/privacy}","received_events_url":"https://api.github.com/users/dippman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dippman/mzLib","description":"Library for mass spectrometry projects","fork":true,"url":"https://api.github.com/repos/dippman/mzLib","forks_url":"https://api.github.com/repos/dippman/mzLib/forks","keys_url":"https://api.github.com/repos/dippman/mzLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dippman/mzLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dippman/mzLib/teams","hooks_url":"https://api.github.com/repos/dippman/mzLib/hooks","issue_events_url":"https://api.github.com/repos/dippman/mzLib/issues/events{/number}","events_url":"https://api.github.com/repos/dippman/mzLib/events","assignees_url":"https://api.github.com/repos/dippman/mzLib/assignees{/user}","branches_url":"https://api.github.com/repos/dippman/mzLib/branches{/branch}","tags_url":"https://api.github.com/repos/dippman/mzLib/tags","blobs_url":"https://api.github.com/repos/dippman/mzLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dippman/mzLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dippman/mzLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/dippman/mzLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dippman/mzLib/statuses/{sha}","languages_url":"https://api.github.com/repos/dippman/mzLib/languages","stargazers_url":"https://api.github.com/repos/dippman/mzLib/stargazers","contributors_url":"https://api.github.com/repos/dippman/mzLib/contributors","subscribers_url":"https://api.github.com/repos/dippman/mzLib/subscribers","subscription_url":"https://api.github.com/repos/dippman/mzLib/subscription","commits_url":"https://api.github.com/repos/dippman/mzLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/dippman/mzLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/dippman/mzLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/dippman/mzLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/dippman/mzLib/contents/{+path}","compare_url":"https://api.github.com/repos/dippman/mzLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dippman/mzLib/merges","archive_url":"https://api.github.com/repos/dippman/mzLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dippman/mzLib/downloads","issues_url":"https://api.github.com/repos/dippman/mzLib/issues{/number}","pulls_url":"https://api.github.com/repos/dippman/mzLib/pulls{/number}","milestones_url":"https://api.github.com/repos/dippman/mzLib/milestones{/number}","notifications_url":"https://api.github.com/repos/dippman/mzLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dippman/mzLib/labels{/name}","releases_url":"https://api.github.com/repos/dippman/mzLib/releases{/id}","deployments_url":"https://api.github.com/repos/dippman/mzLib/deployments","created_at":"2017-07-07T19:46:44Z","updated_at":"2017-07-07T19:46:46Z","pushed_at":"2017-08-10T18:06:53Z","git_url":"git://github.com/dippman/mzLib.git","ssh_url":"[email protected]:dippman/mzLib.git","clone_url":"https://github.com/dippman/mzLib.git","svn_url":"https://github.com/dippman/mzLib","homepage":null,"size":72347,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smith-chem-wisc:master","ref":"master","sha":"2df88928ee70df34cd854ab3f04074b9f4e4540b","user":{"login":"smith-chem-wisc","id":15989786,"avatar_url":"https://avatars3.githubusercontent.com/u/15989786?v=4","gravatar_id":"","url":"https://api.github.com/users/smith-chem-wisc","html_url":"https://github.com/smith-chem-wisc","followers_url":"https://api.github.com/users/smith-chem-wisc/followers","following_url":"https://api.github.com/users/smith-chem-wisc/following{/other_user}","gists_url":"https://api.github.com/users/smith-chem-wisc/gists{/gist_id}","starred_url":"https://api.github.com/users/smith-chem-wisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smith-chem-wisc/subscriptions","organizations_url":"https://api.github.com/users/smith-chem-wisc/orgs","repos_url":"https://api.github.com/users/smith-chem-wisc/repos","events_url":"https://api.github.com/users/smith-chem-wisc/events{/privacy}","received_events_url":"https://api.github.com/users/smith-chem-wisc/received_events","type":"Organization","site_admin":false},"repo":{"id":66583013,"name":"mzLib","full_name":"smith-chem-wisc/mzLib","owner":{"login":"smith-chem-wisc","id":15989786,"avatar_url":"https://avatars3.githubusercontent.com/u/15989786?v=4","gravatar_id":"","url":"https://api.github.com/users/smith-chem-wisc","html_url":"https://github.com/smith-chem-wisc","followers_url":"https://api.github.com/users/smith-chem-wisc/followers","following_url":"https://api.github.com/users/smith-chem-wisc/following{/other_user}","gists_url":"https://api.github.com/users/smith-chem-wisc/gists{/gist_id}","starred_url":"https://api.github.com/users/smith-chem-wisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smith-chem-wisc/subscriptions","organizations_url":"https://api.github.com/users/smith-chem-wisc/orgs","repos_url":"https://api.github.com/users/smith-chem-wisc/repos","events_url":"https://api.github.com/users/smith-chem-wisc/events{/privacy}","received_events_url":"https://api.github.com/users/smith-chem-wisc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smith-chem-wisc/mzLib","description":"Library for mass spectrometry projects","fork":false,"url":"https://api.github.com/repos/smith-chem-wisc/mzLib","forks_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/forks","keys_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/teams","hooks_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/hooks","issue_events_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/issues/events{/number}","events_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/events","assignees_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/assignees{/user}","branches_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/branches{/branch}","tags_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/tags","blobs_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/statuses/{sha}","languages_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/languages","stargazers_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/stargazers","contributors_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/contributors","subscribers_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/subscribers","subscription_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/subscription","commits_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/contents/{+path}","compare_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/merges","archive_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/downloads","issues_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/issues{/number}","pulls_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls{/number}","milestones_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/milestones{/number}","notifications_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/labels{/name}","releases_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/releases{/id}","deployments_url":"https://api.github.com/repos/smith-chem-wisc/mzLib/deployments","created_at":"2016-08-25T18:27:39Z","updated_at":"2017-04-22T22:51:06Z","pushed_at":"2017-08-10T18:06:54Z","git_url":"git://github.com/smith-chem-wisc/mzLib.git","ssh_url":"[email protected]:smith-chem-wisc/mzLib.git","clone_url":"https://github.com/smith-chem-wisc/mzLib.git","svn_url":"https://github.com/smith-chem-wisc/mzLib","homepage":null,"size":72354,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":13,"forks":9,"open_issues":13,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/218"},"html":{"href":"https://github.com/smith-chem-wisc/mzLib/pull/218"},"issue":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/issues/218"},"comments":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/smith-chem-wisc/mzLib/statuses/46b190bd182ce92b0661e91f6fee1041841f0649"}}}} | {
"id": 66583013,
"name": "smith-chem-wisc/mzLib",
"url": "https://api.github.com/repos/smith-chem-wisc/mzLib"
} | {
"id": 5972770,
"login": "stefanks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5972770?",
"url": "https://api.github.com/users/stefanks"
} | {
"id": 15989786,
"login": "smith-chem-wisc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15989786?",
"url": "https://api.github.com/orgs/smith-chem-wisc"
} | 2017-08-10T19:28:02 | 6435948053 | {"actor":{"display_login":"stefanks"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-batch/pulls/comments/144977084","pull_request_review_id":69700194,"id":144977084,"diff_hunk":"@@ -210,70 +210,73 @@ Be very careful with the implementation of\n `Object.equals()` and `Object.hashCode()` in the\n key returned by `RetryState`. The best advice is\n to use a business key to identify the items. In the case of a JMS\n- message the message ID can be used.\n+ message, the message ID can be used.\n ====\n \n \n-When the retry is exhausted there is also the option to handle the\n+When the retry is exhausted, there is also the option to handle the\n failed item in a different way, instead of calling the\n- `RetryCallback` (which is presumed now to be likely\n+ `RetryCallback` (which is now presumed to be likely\n to fail). Just like in the stateless case, this option is provided by\n the `RecoveryCallback`, which can be provided by\n passing it in to the `execute` method of\n `RetryOperations`.\n \n The decision to retry or not is actually delegated to a regular\n `RetryPolicy`, so the usual concerns about limits\n- and timeouts can be injected there (see below).\n+ and timeouts can be injected there (described later in this chapter).\n+\n+// TODO This section has no example. It could use one (or more) to show how to inject\n+// `RetryContextCache` into `RetryTemplate` and passing the `RecoveryCallback` to\n+// `RetryOperations`\n \n [[retryPolicies]]\n \n \n === Retry Policies\n \n-Inside a `RetryTemplate` the decision to retry\n+Inside a `RetryTemplate`, the decision to retry\n or fail in the `execute` method is determined by a\n- `RetryPolicy` which is also a factory for the\n+ `RetryPolicy`, which is also a factory for the\n `RetryContext`. The\n `RetryTemplate` has the responsibility to use the\n current policy to create a `RetryContext` and pass\n that in to the `RetryCallback` at every attempt.\n- After a callback fails the `RetryTemplate` has to\n+ After a callback fails, the `RetryTemplate` has to\n make a call to the `RetryPolicy` to ask it to update\n- its state (which will be stored in the\n- `RetryContext`), and then it asks the policy if\n- another attempt can be made. If another attempt cannot be made (e.g. a\n+ its state (which is stored in the\n+ `RetryContext`) and then asks the policy if\n+ another attempt can be made. If another attempt cannot be made (such as when a\n limit is reached or a timeout is detected) then the policy is also\n- responsible for handling the exhausted state. Simple implementations will\n- just throw `RetryExhaustedException` which will cause\n+ responsible for handling the exhausted state. Simple implementations\n+ throw `RetryExhaustedException`, which causes\n any enclosing transaction to be rolled back. More sophisticated\n implementations might attempt to take some recovery action, in which case\n the transaction can remain intact.\n \n \n [TIP]\n ====\n-Failures are inherently either retryable or not - if the same\n+Failures are inherently either retryable or not. If the same\n exception is always going to be thrown from the business logic, it\n- doesn't help to retry it. So don't retry on all exception types - try to\n- focus on only those exceptions that you expect to be retryable. It's not\n+ does no good to retry it. So do not retry on all exception types. Rather, try to\n+ focus on only those exceptions that you expect to be retryable. It is not\n usually harmful to the business logic to retry more aggressively, but\n- it's wasteful because if a failure is deterministic there will be time\n- spent retrying something that you know in advance is fatal.\n+ it is wasteful, because, if a failure is deterministic, you spend time\n+ retrying something that you know in advance is fatal.\n ====\n \n \n Spring Batch provides some simple general purpose implementations of\n- stateless `RetryPolicy`, for example a\n- `SimpleRetryPolicy`, and the\n- `TimeoutRetryPolicy` used in the example\n- above.\n+ stateless `RetryPolicy`, such as\n+ `SimpleRetryPolicy` and\n+ `TimeoutRetryPolicy` (used in the preceding example).\n \n-The `SimpleRetryPolicy` just allows a retry on\n+The `SimpleRetryPolicy` allows a retry on","path":"spring-batch-docs/asciidoc/retry.adoc","position":277,"original_position":277,"commit_id":"38aa8427bb168de435546e9c278233b33b7bf40f","original_commit_id":"38aa8427bb168de435546e9c278233b33b7bf40f","user":{"login":"cppwfs","id":695673,"avatar_url":"https://avatars1.githubusercontent.com/u/695673?v=4","gravatar_id":"","url":"https://api.github.com/users/cppwfs","html_url":"https://github.com/cppwfs","followers_url":"https://api.github.com/users/cppwfs/followers","following_url":"https://api.github.com/users/cppwfs/following{/other_user}","gists_url":"https://api.github.com/users/cppwfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cppwfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppwfs/subscriptions","organizations_url":"https://api.github.com/users/cppwfs/orgs","repos_url":"https://api.github.com/users/cppwfs/repos","events_url":"https://api.github.com/users/cppwfs/events{/privacy}","received_events_url":"https://api.github.com/users/cppwfs/received_events","type":"User","site_admin":false},"body":"nitpicky but 2 spaces.","created_at":"2017-10-16T21:43:38Z","updated_at":"2017-10-16T21:53:01Z","html_url":"https://github.com/spring-projects/spring-batch/pull/522#discussion_r144977084","pull_request_url":"https://api.github.com/repos/spring-projects/spring-batch/pulls/522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-batch/pulls/comments/144977084"},"html":{"href":"https://github.com/spring-projects/spring-batch/pull/522#discussion_r144977084"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-batch/pulls/522"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-batch/pulls/522","id":145227541,"html_url":"https://github.com/spring-projects/spring-batch/pull/522","diff_url":"https://github.com/spring-projects/spring-batch/pull/522.diff","patch_url":"https://github.com/spring-projects/spring-batch/pull/522.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-batch/issues/522","number":522,"state":"open","locked":false,"title":"Editing pass for retry.adoc","user":{"login":"Buzzardo","id":5225162,"avatar_url":"https://avatars3.githubusercontent.com/u/5225162?v=4","gravatar_id":"","url":"https://api.github.com/users/Buzzardo","html_url":"https://github.com/Buzzardo","followers_url":"https://api.github.com/users/Buzzardo/followers","following_url":"https://api.github.com/users/Buzzardo/following{/other_user}","gists_url":"https://api.github.com/users/Buzzardo/gists{/gist_id}","starred_url":"https://api.github.com/users/Buzzardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Buzzardo/subscriptions","organizations_url":"https://api.github.com/users/Buzzardo/orgs","repos_url":"https://api.github.com/users/Buzzardo/repos","events_url":"https://api.github.com/users/Buzzardo/events{/privacy}","received_events_url":"https://api.github.com/users/Buzzardo/received_events","type":"User","site_admin":false},"body":"I made it more readable and consistent and fixed up sentence errors. I added a TODO for a spot that could benefit from an example or two.","created_at":"2017-10-06T19:22:01Z","updated_at":"2017-10-16T21:53:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29dfbc471312f76c6d07c5f9816ca5cd568c77be","assignee":{"login":"cppwfs","id":695673,"avatar_url":"https://avatars1.githubusercontent.com/u/695673?v=4","gravatar_id":"","url":"https://api.github.com/users/cppwfs","html_url":"https://github.com/cppwfs","followers_url":"https://api.github.com/users/cppwfs/followers","following_url":"https://api.github.com/users/cppwfs/following{/other_user}","gists_url":"https://api.github.com/users/cppwfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cppwfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppwfs/subscriptions","organizations_url":"https://api.github.com/users/cppwfs/orgs","repos_url":"https://api.github.com/users/cppwfs/repos","events_url":"https://api.github.com/users/cppwfs/events{/privacy}","received_events_url":"https://api.github.com/users/cppwfs/received_events","type":"User","site_admin":false},"assignees":[{"login":"cppwfs","id":695673,"avatar_url":"https://avatars1.githubusercontent.com/u/695673?v=4","gravatar_id":"","url":"https://api.github.com/users/cppwfs","html_url":"https://github.com/cppwfs","followers_url":"https://api.github.com/users/cppwfs/followers","following_url":"https://api.github.com/users/cppwfs/following{/other_user}","gists_url":"https://api.github.com/users/cppwfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cppwfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppwfs/subscriptions","organizations_url":"https://api.github.com/users/cppwfs/orgs","repos_url":"https://api.github.com/users/cppwfs/repos","events_url":"https://api.github.com/users/cppwfs/events{/privacy}","received_events_url":"https://api.github.com/users/cppwfs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-batch/pulls/522/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-batch/pulls/522/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-batch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-batch/issues/522/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-batch/statuses/38aa8427bb168de435546e9c278233b33b7bf40f","head":{"label":"Buzzardo:editing_retry","ref":"editing_retry","sha":"38aa8427bb168de435546e9c278233b33b7bf40f","user":{"login":"Buzzardo","id":5225162,"avatar_url":"https://avatars3.githubusercontent.com/u/5225162?v=4","gravatar_id":"","url":"https://api.github.com/users/Buzzardo","html_url":"https://github.com/Buzzardo","followers_url":"https://api.github.com/users/Buzzardo/followers","following_url":"https://api.github.com/users/Buzzardo/following{/other_user}","gists_url":"https://api.github.com/users/Buzzardo/gists{/gist_id}","starred_url":"https://api.github.com/users/Buzzardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Buzzardo/subscriptions","organizations_url":"https://api.github.com/users/Buzzardo/orgs","repos_url":"https://api.github.com/users/Buzzardo/repos","events_url":"https://api.github.com/users/Buzzardo/events{/privacy}","received_events_url":"https://api.github.com/users/Buzzardo/received_events","type":"User","site_admin":false},"repo":{"id":105547279,"name":"spring-batch","full_name":"Buzzardo/spring-batch","owner":{"login":"Buzzardo","id":5225162,"avatar_url":"https://avatars3.githubusercontent.com/u/5225162?v=4","gravatar_id":"","url":"https://api.github.com/users/Buzzardo","html_url":"https://github.com/Buzzardo","followers_url":"https://api.github.com/users/Buzzardo/followers","following_url":"https://api.github.com/users/Buzzardo/following{/other_user}","gists_url":"https://api.github.com/users/Buzzardo/gists{/gist_id}","starred_url":"https://api.github.com/users/Buzzardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Buzzardo/subscriptions","organizations_url":"https://api.github.com/users/Buzzardo/orgs","repos_url":"https://api.github.com/users/Buzzardo/repos","events_url":"https://api.github.com/users/Buzzardo/events{/privacy}","received_events_url":"https://api.github.com/users/Buzzardo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Buzzardo/spring-batch","description":"Spring Batch is a framework for writing offline and batch applications using Spring and Java","fork":true,"url":"https://api.github.com/repos/Buzzardo/spring-batch","forks_url":"https://api.github.com/repos/Buzzardo/spring-batch/forks","keys_url":"https://api.github.com/repos/Buzzardo/spring-batch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Buzzardo/spring-batch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Buzzardo/spring-batch/teams","hooks_url":"https://api.github.com/repos/Buzzardo/spring-batch/hooks","issue_events_url":"https://api.github.com/repos/Buzzardo/spring-batch/issues/events{/number}","events_url":"https://api.github.com/repos/Buzzardo/spring-batch/events","assignees_url":"https://api.github.com/repos/Buzzardo/spring-batch/assignees{/user}","branches_url":"https://api.github.com/repos/Buzzardo/spring-batch/branches{/branch}","tags_url":"https://api.github.com/repos/Buzzardo/spring-batch/tags","blobs_url":"https://api.github.com/repos/Buzzardo/spring-batch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Buzzardo/spring-batch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Buzzardo/spring-batch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Buzzardo/spring-batch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Buzzardo/spring-batch/statuses/{sha}","languages_url":"https://api.github.com/repos/Buzzardo/spring-batch/languages","stargazers_url":"https://api.github.com/repos/Buzzardo/spring-batch/stargazers","contributors_url":"https://api.github.com/repos/Buzzardo/spring-batch/contributors","subscribers_url":"https://api.github.com/repos/Buzzardo/spring-batch/subscribers","subscription_url":"https://api.github.com/repos/Buzzardo/spring-batch/subscription","commits_url":"https://api.github.com/repos/Buzzardo/spring-batch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Buzzardo/spring-batch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Buzzardo/spring-batch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Buzzardo/spring-batch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Buzzardo/spring-batch/contents/{+path}","compare_url":"https://api.github.com/repos/Buzzardo/spring-batch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Buzzardo/spring-batch/merges","archive_url":"https://api.github.com/repos/Buzzardo/spring-batch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Buzzardo/spring-batch/downloads","issues_url":"https://api.github.com/repos/Buzzardo/spring-batch/issues{/number}","pulls_url":"https://api.github.com/repos/Buzzardo/spring-batch/pulls{/number}","milestones_url":"https://api.github.com/repos/Buzzardo/spring-batch/milestones{/number}","notifications_url":"https://api.github.com/repos/Buzzardo/spring-batch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Buzzardo/spring-batch/labels{/name}","releases_url":"https://api.github.com/repos/Buzzardo/spring-batch/releases{/id}","deployments_url":"https://api.github.com/repos/Buzzardo/spring-batch/deployments","created_at":"2017-10-02T14:55:31Z","updated_at":"2017-10-02T14:55:39Z","pushed_at":"2017-10-16T19:54:14Z","git_url":"git://github.com/Buzzardo/spring-batch.git","ssh_url":"[email protected]:Buzzardo/spring-batch.git","clone_url":"https://github.com/Buzzardo/spring-batch.git","svn_url":"https://github.com/Buzzardo/spring-batch","homepage":"http://projects.spring.io/spring-batch/","size":86585,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"61f265edd78ce31723b6c84e39a461a2c9d741ef","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":1089149,"name":"spring-batch","full_name":"spring-projects/spring-batch","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-batch","description":"Spring Batch is a framework for writing offline and batch applications using Spring and Java","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-batch","forks_url":"https://api.github.com/repos/spring-projects/spring-batch/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-batch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-batch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-batch/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-batch/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-batch/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-batch/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-batch/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-batch/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-batch/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-batch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-batch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-batch/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-batch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-batch/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-batch/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-batch/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-batch/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-batch/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-batch/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-batch/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-batch/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-batch/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-batch/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-batch/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-batch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-batch/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-batch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-batch/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-batch/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-batch/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-batch/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-batch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-batch/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-batch/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-batch/deployments","created_at":"2010-11-17T17:53:45Z","updated_at":"2017-10-16T13:13:19Z","pushed_at":"2017-10-16T19:54:58Z","git_url":"git://github.com/spring-projects/spring-batch.git","ssh_url":"[email protected]:spring-projects/spring-batch.git","clone_url":"https://github.com/spring-projects/spring-batch.git","svn_url":"https://github.com/spring-projects/spring-batch","homepage":"http://projects.spring.io/spring-batch/","size":86513,"stargazers_count":835,"watchers_count":835,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":913,"mirror_url":null,"open_issues_count":50,"forks":913,"open_issues":50,"watchers":835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-batch/pulls/522"},"html":{"href":"https://github.com/spring-projects/spring-batch/pull/522"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-batch/issues/522"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-batch/issues/522/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-batch/pulls/522/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-batch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-batch/pulls/522/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-batch/statuses/38aa8427bb168de435546e9c278233b33b7bf40f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1089149,
"name": "spring-projects/spring-batch",
"url": "https://api.github.com/repos/spring-projects/spring-batch"
} | {
"id": 695673,
"login": "cppwfs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/695673?",
"url": "https://api.github.com/users/cppwfs"
} | {
"id": 317776,
"login": "spring-projects",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/317776?",
"url": "https://api.github.com/orgs/spring-projects"
} | 2017-10-16T21:43:38 | 6724287521 | {"actor":{"display_login":"cppwfs"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/comments/105338465","pull_request_review_id":26214171,"id":105338465,"diff_hunk":"@@ -285,7 +292,7 @@ ExtractTextPlugin.prototype.apply = function(compiler) {\n \t\t\t\tcallback();\n \t\t\t}.bind(this));\n \t\t}.bind(this));\n-\t\tcompilation.plugin(\"additional-assets\", function(callback) {\n+\t\tcompilation.plugin(\"before-chunk-assets\", function() {","path":"index.js","position":19,"original_position":19,"commit_id":"360c155567b5e5f61ee0ecdab6d46c01a277b8c4","original_commit_id":"c0bfa7076f96634a50437a8384117833c9eece21","user":{"login":"bebraw","id":166921,"avatar_url":"https://avatars3.githubusercontent.com/u/166921?v=3","gravatar_id":"","url":"https://api.github.com/users/bebraw","html_url":"https://github.com/bebraw","followers_url":"https://api.github.com/users/bebraw/followers","following_url":"https://api.github.com/users/bebraw/following{/other_user}","gists_url":"https://api.github.com/users/bebraw/gists{/gist_id}","starred_url":"https://api.github.com/users/bebraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebraw/subscriptions","organizations_url":"https://api.github.com/users/bebraw/orgs","repos_url":"https://api.github.com/users/bebraw/repos","events_url":"https://api.github.com/users/bebraw/events{/privacy}","received_events_url":"https://api.github.com/users/bebraw/received_events","type":"User","site_admin":false},"body":"Maybe the question is what's worth testing. It could be possible there is no good way just yet.","created_at":"2017-03-10T06:37:21Z","updated_at":"2017-03-10T06:37:21Z","html_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/457#discussion_r105338465","pull_request_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/457","_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/comments/105338465"},"html":{"href":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/457#discussion_r105338465"},"pull_request":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/457","id":109961067,"html_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/457","diff_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/457.diff","patch_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/457.patch","issue_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/457","number":457,"state":"open","locked":false,"title":"Support hot module replacement","user":{"login":"cletusw","id":862638,"avatar_url":"https://avatars2.githubusercontent.com/u/862638?v=3","gravatar_id":"","url":"https://api.github.com/users/cletusw","html_url":"https://github.com/cletusw","followers_url":"https://api.github.com/users/cletusw/followers","following_url":"https://api.github.com/users/cletusw/following{/other_user}","gists_url":"https://api.github.com/users/cletusw/gists{/gist_id}","starred_url":"https://api.github.com/users/cletusw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cletusw/subscriptions","organizations_url":"https://api.github.com/users/cletusw/orgs","repos_url":"https://api.github.com/users/cletusw/repos","events_url":"https://api.github.com/users/cletusw/events{/privacy}","received_events_url":"https://api.github.com/users/cletusw/received_events","type":"User","site_admin":false},"body":"Fixes #30 \r\n\r\nBased on #89, https://github.com/TrejGun/extract-text-webpack-plugin/","created_at":"2017-03-09T17:07:58Z","updated_at":"2017-03-10T06:37:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c03d013f04c4a2e37990cff3a2ede695dd061c71","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/457/commits","review_comments_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/457/comments","review_comment_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/457/comments","statuses_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/statuses/360c155567b5e5f61ee0ecdab6d46c01a277b8c4","head":{"label":"cletusw:hmr","ref":"hmr","sha":"360c155567b5e5f61ee0ecdab6d46c01a277b8c4","user":{"login":"cletusw","id":862638,"avatar_url":"https://avatars2.githubusercontent.com/u/862638?v=3","gravatar_id":"","url":"https://api.github.com/users/cletusw","html_url":"https://github.com/cletusw","followers_url":"https://api.github.com/users/cletusw/followers","following_url":"https://api.github.com/users/cletusw/following{/other_user}","gists_url":"https://api.github.com/users/cletusw/gists{/gist_id}","starred_url":"https://api.github.com/users/cletusw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cletusw/subscriptions","organizations_url":"https://api.github.com/users/cletusw/orgs","repos_url":"https://api.github.com/users/cletusw/repos","events_url":"https://api.github.com/users/cletusw/events{/privacy}","received_events_url":"https://api.github.com/users/cletusw/received_events","type":"User","site_admin":false},"repo":{"id":81247906,"name":"extract-text-webpack-plugin","full_name":"cletusw/extract-text-webpack-plugin","owner":{"login":"cletusw","id":862638,"avatar_url":"https://avatars2.githubusercontent.com/u/862638?v=3","gravatar_id":"","url":"https://api.github.com/users/cletusw","html_url":"https://github.com/cletusw","followers_url":"https://api.github.com/users/cletusw/followers","following_url":"https://api.github.com/users/cletusw/following{/other_user}","gists_url":"https://api.github.com/users/cletusw/gists{/gist_id}","starred_url":"https://api.github.com/users/cletusw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cletusw/subscriptions","organizations_url":"https://api.github.com/users/cletusw/orgs","repos_url":"https://api.github.com/users/cletusw/repos","events_url":"https://api.github.com/users/cletusw/events{/privacy}","received_events_url":"https://api.github.com/users/cletusw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cletusw/extract-text-webpack-plugin","description":"Extract text from bundle into a file.","fork":true,"url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin","forks_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/forks","keys_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/events","assignees_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/merges","archive_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/cletusw/extract-text-webpack-plugin/deployments","created_at":"2017-02-07T19:54:29Z","updated_at":"2017-02-07T19:54:31Z","pushed_at":"2017-03-10T06:12:57Z","git_url":"git://github.com/cletusw/extract-text-webpack-plugin.git","ssh_url":"[email protected]:cletusw/extract-text-webpack-plugin.git","clone_url":"https://github.com/cletusw/extract-text-webpack-plugin.git","svn_url":"https://github.com/cletusw/extract-text-webpack-plugin","homepage":"https://www.npmjs.com/package/extract-text-webpack-plugin","size":182,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack-contrib:master","ref":"master","sha":"75cb09eed13d15cec8f974b1210920a7f249f8e2","user":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars0.githubusercontent.com/u/25012217?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":16297741,"name":"extract-text-webpack-plugin","full_name":"webpack-contrib/extract-text-webpack-plugin","owner":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars0.githubusercontent.com/u/25012217?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin","description":"Extract text from bundle into a file.","fork":false,"url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin","forks_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/forks","keys_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/events","assignees_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/merges","archive_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/deployments","created_at":"2014-01-28T00:28:36Z","updated_at":"2017-03-10T06:32:05Z","pushed_at":"2017-03-10T06:12:58Z","git_url":"git://github.com/webpack-contrib/extract-text-webpack-plugin.git","ssh_url":"[email protected]:webpack-contrib/extract-text-webpack-plugin.git","clone_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin.git","svn_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin","homepage":"https://www.npmjs.com/package/extract-text-webpack-plugin","size":207,"stargazers_count":1796,"watchers_count":1796,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":305,"mirror_url":null,"open_issues_count":95,"forks":305,"open_issues":95,"watchers":1796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/457"},"html":{"href":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/457"},"issue":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/457"},"comments":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/statuses/360c155567b5e5f61ee0ecdab6d46c01a277b8c4"}}}} | {
"id": 16297741,
"name": "webpack-contrib/extract-text-webpack-plugin",
"url": "https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin"
} | {
"id": 166921,
"login": "bebraw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/166921?",
"url": "https://api.github.com/users/bebraw"
} | {
"id": 25012217,
"login": "webpack-contrib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25012217?",
"url": "https://api.github.com/orgs/webpack-contrib"
} | 2017-03-10T06:37:21 | 5468542898 | {"actor":{"display_login":"bebraw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments/103924619","pull_request_review_id":24730974,"id":103924619,"diff_hunk":"@@ -0,0 +1,172 @@\n+package edu.cornell.kfs.concur.batch.service.impl;\n+\n+import org.apache.commons.io.FileUtils;\n+import org.apache.commons.io.IOUtils;\n+import org.apache.commons.lang.StringUtils;\n+\n+import java.io.File;\n+import java.io.FileInputStream;\n+import java.io.FileNotFoundException;\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+import org.kuali.kfs.sys.batch.BatchInputFileType;\n+import org.kuali.kfs.sys.batch.service.BatchInputFileService;\n+import org.kuali.rice.core.api.util.type.KualiDecimal;\n+\n+import edu.cornell.kfs.concur.ConcurConstants;\n+import edu.cornell.kfs.concur.batch.businessobject.ConcurRequestExtractFile;\n+import edu.cornell.kfs.concur.batch.service.ConcurRequestExtractFileService;\n+import edu.cornell.kfs.concur.batch.service.ConcurRequestExtractFileValidationService;\n+\n+public class ConcurRequestExtractFileServiceImpl implements ConcurRequestExtractFileService {\n+ private static org.apache.log4j.Logger LOG = org.apache.log4j.Logger.getLogger(ConcurRequestExtractFileServiceImpl.class);\n+ protected String acceptedDirectoryName;\n+ protected String rejectedDirectoryName;\n+ protected BatchInputFileType batchInputFileType;\n+ protected BatchInputFileService batchInputFileService;\n+ protected ConcurRequestExtractFileValidationService concurRequestExtractFileValidationService;\n+\n+ public List<String> getUnprocessedRequestExtractFiles() {\n+ List<String> fileNamesToLoad = getBatchInputFileService().listInputFileNamesWithDoneFile(getBatchInputFileType());\n+ return fileNamesToLoad;\n+ }\n+\n+ public boolean processFile(String requestExtractFileName) {\n+ boolean processingSuccess = true;\n+ Object parsedFile;","path":"src/main/java/edu/cornell/kfs/concur/batch/service/impl/ConcurRequestExtractFileServiceImpl.java","position":39,"original_position":39,"commit_id":"313749a87898235a395755c2b0e1708aa7f371da","original_commit_id":"313749a87898235a395755c2b0e1708aa7f371da","user":{"login":"nkimble","id":6460968,"avatar_url":"https://avatars0.githubusercontent.com/u/6460968?v=3","gravatar_id":"","url":"https://api.github.com/users/nkimble","html_url":"https://github.com/nkimble","followers_url":"https://api.github.com/users/nkimble/followers","following_url":"https://api.github.com/users/nkimble/following{/other_user}","gists_url":"https://api.github.com/users/nkimble/gists{/gist_id}","starred_url":"https://api.github.com/users/nkimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkimble/subscriptions","organizations_url":"https://api.github.com/users/nkimble/orgs","repos_url":"https://api.github.com/users/nkimble/repos","events_url":"https://api.github.com/users/nkimble/events{/privacy}","received_events_url":"https://api.github.com/users/nkimble/received_events","type":"User","site_admin":false},"body":"Will adjust the code.","created_at":"2017-03-02T13:37:28Z","updated_at":"2017-03-02T13:37:28Z","html_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/319#discussion_r103924619","pull_request_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/319","_links":{"self":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments/103924619"},"html":{"href":"https://github.com/CU-CommunityApps/cu-kfs/pull/319#discussion_r103924619"},"pull_request":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/319"}}},"pull_request":{"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/319","id":108614126,"html_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/319","diff_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/319.diff","patch_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/319.patch","issue_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/319","number":319,"state":"open","locked":false,"title":"KFSPTS-7377: New services created to parse Concur Request Extract file into POJO and perform high level header row file validation.","user":{"login":"nkimble","id":6460968,"avatar_url":"https://avatars0.githubusercontent.com/u/6460968?v=3","gravatar_id":"","url":"https://api.github.com/users/nkimble","html_url":"https://github.com/nkimble","followers_url":"https://api.github.com/users/nkimble/followers","following_url":"https://api.github.com/users/nkimble/following{/other_user}","gists_url":"https://api.github.com/users/nkimble/gists{/gist_id}","starred_url":"https://api.github.com/users/nkimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkimble/subscriptions","organizations_url":"https://api.github.com/users/nkimble/orgs","repos_url":"https://api.github.com/users/nkimble/repos","events_url":"https://api.github.com/users/nkimble/events{/privacy}","received_events_url":"https://api.github.com/users/nkimble/received_events","type":"User","site_admin":false},"body":"KFSPTS-7377: New services created to parse Concur Request Extract file into POJO and perform high level header row file validation.","created_at":"2017-03-01T19:47:08Z","updated_at":"2017-03-02T13:37:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c131b92d1a8e1c0096d9de91f03c5d93af8e3836","assignee":{"login":"db483","id":5119449,"avatar_url":"https://avatars0.githubusercontent.com/u/5119449?v=3","gravatar_id":"","url":"https://api.github.com/users/db483","html_url":"https://github.com/db483","followers_url":"https://api.github.com/users/db483/followers","following_url":"https://api.github.com/users/db483/following{/other_user}","gists_url":"https://api.github.com/users/db483/gists{/gist_id}","starred_url":"https://api.github.com/users/db483/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/db483/subscriptions","organizations_url":"https://api.github.com/users/db483/orgs","repos_url":"https://api.github.com/users/db483/repos","events_url":"https://api.github.com/users/db483/events{/privacy}","received_events_url":"https://api.github.com/users/db483/received_events","type":"User","site_admin":false},"assignees":[{"login":"db483","id":5119449,"avatar_url":"https://avatars0.githubusercontent.com/u/5119449?v=3","gravatar_id":"","url":"https://api.github.com/users/db483","html_url":"https://github.com/db483","followers_url":"https://api.github.com/users/db483/followers","following_url":"https://api.github.com/users/db483/following{/other_user}","gists_url":"https://api.github.com/users/db483/gists{/gist_id}","starred_url":"https://api.github.com/users/db483/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/db483/subscriptions","organizations_url":"https://api.github.com/users/db483/orgs","repos_url":"https://api.github.com/users/db483/repos","events_url":"https://api.github.com/users/db483/events{/privacy}","received_events_url":"https://api.github.com/users/db483/received_events","type":"User","site_admin":false},{"login":"jhulslander","id":5121156,"avatar_url":"https://avatars3.githubusercontent.com/u/5121156?v=3","gravatar_id":"","url":"https://api.github.com/users/jhulslander","html_url":"https://github.com/jhulslander","followers_url":"https://api.github.com/users/jhulslander/followers","following_url":"https://api.github.com/users/jhulslander/following{/other_user}","gists_url":"https://api.github.com/users/jhulslander/gists{/gist_id}","starred_url":"https://api.github.com/users/jhulslander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhulslander/subscriptions","organizations_url":"https://api.github.com/users/jhulslander/orgs","repos_url":"https://api.github.com/users/jhulslander/repos","events_url":"https://api.github.com/users/jhulslander/events{/privacy}","received_events_url":"https://api.github.com/users/jhulslander/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/319/commits","review_comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/319/comments","review_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/319/comments","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/313749a87898235a395755c2b0e1708aa7f371da","head":{"label":"CU-CommunityApps:KFSPTS-7377","ref":"KFSPTS-7377","sha":"313749a87898235a395755c2b0e1708aa7f371da","user":{"login":"CU-CommunityApps","id":5115848,"avatar_url":"https://avatars3.githubusercontent.com/u/5115848?v=3","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"repo":{"id":12188834,"name":"cu-kfs","full_name":"CU-CommunityApps/cu-kfs","owner":{"login":"CU-CommunityApps","id":5115848,"avatar_url":"https://avatars3.githubusercontent.com/u/5115848?v=3","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CU-CommunityApps/cu-kfs","description":null,"fork":false,"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs","forks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/forks","keys_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/teams","hooks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/hooks","issue_events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/events{/number}","events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/events","assignees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/assignees{/user}","branches_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/branches{/branch}","tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/tags","blobs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/languages","stargazers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/stargazers","contributors_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contributors","subscribers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscribers","subscription_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscription","commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contents/{+path}","compare_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/merges","archive_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/downloads","issues_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues{/number}","pulls_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/labels{/name}","releases_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/releases{/id}","deployments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/deployments","created_at":"2013-08-18T01:55:18Z","updated_at":"2017-01-30T18:36:17Z","pushed_at":"2017-03-02T13:11:46Z","git_url":"git://github.com/CU-CommunityApps/cu-kfs.git","ssh_url":"[email protected]:CU-CommunityApps/cu-kfs.git","clone_url":"https://github.com/CU-CommunityApps/cu-kfs.git","svn_url":"https://github.com/CU-CommunityApps/cu-kfs","homepage":null,"size":19540,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"CU-CommunityApps:develop","ref":"develop","sha":"e3fc0900319a9505687e40b5c829d1e5ac413077","user":{"login":"CU-CommunityApps","id":5115848,"avatar_url":"https://avatars3.githubusercontent.com/u/5115848?v=3","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"repo":{"id":12188834,"name":"cu-kfs","full_name":"CU-CommunityApps/cu-kfs","owner":{"login":"CU-CommunityApps","id":5115848,"avatar_url":"https://avatars3.githubusercontent.com/u/5115848?v=3","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CU-CommunityApps/cu-kfs","description":null,"fork":false,"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs","forks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/forks","keys_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/teams","hooks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/hooks","issue_events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/events{/number}","events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/events","assignees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/assignees{/user}","branches_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/branches{/branch}","tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/tags","blobs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/languages","stargazers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/stargazers","contributors_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contributors","subscribers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscribers","subscription_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscription","commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contents/{+path}","compare_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/merges","archive_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/downloads","issues_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues{/number}","pulls_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/labels{/name}","releases_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/releases{/id}","deployments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/deployments","created_at":"2013-08-18T01:55:18Z","updated_at":"2017-01-30T18:36:17Z","pushed_at":"2017-03-02T13:11:46Z","git_url":"git://github.com/CU-CommunityApps/cu-kfs.git","ssh_url":"[email protected]:CU-CommunityApps/cu-kfs.git","clone_url":"https://github.com/CU-CommunityApps/cu-kfs.git","svn_url":"https://github.com/CU-CommunityApps/cu-kfs","homepage":null,"size":19540,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/319"},"html":{"href":"https://github.com/CU-CommunityApps/cu-kfs/pull/319"},"issue":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/319"},"comments":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/313749a87898235a395755c2b0e1708aa7f371da"}}}} | {
"id": 12188834,
"name": "CU-CommunityApps/cu-kfs",
"url": "https://api.github.com/repos/CU-CommunityApps/cu-kfs"
} | {
"id": 6460968,
"login": "nkimble",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6460968?",
"url": "https://api.github.com/users/nkimble"
} | {
"id": 5115848,
"login": "CU-CommunityApps",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5115848?",
"url": "https://api.github.com/orgs/CU-CommunityApps"
} | 2017-03-02T13:37:28 | 5419947641 | {"actor":{"display_login":"nkimble"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments/95862714","pull_request_review_id":16430712,"id":95862714,"diff_hunk":"@@ -0,0 +1,106 @@\n+package edu.cornell.kfs.concur.service.impl;\n+\n+import java.net.URI;\n+import java.net.URISyntaxException;\n+import java.util.Collection;\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+\n+import javax.ws.rs.HttpMethod;\n+import javax.ws.rs.core.MediaType;\n+\n+import org.kuali.kfs.krad.service.BusinessObjectService;\n+import org.kuali.rice.krad.util.ObjectUtils;\n+\n+import com.sun.jersey.api.client.Client;\n+import com.sun.jersey.api.client.ClientRequest;\n+import com.sun.jersey.api.client.ClientResponse;\n+import com.sun.jersey.api.client.config.ClientConfig;\n+import com.sun.jersey.api.client.config.DefaultClientConfig;\n+\n+import edu.cornell.kfs.concur.ConcurConstants;\n+import edu.cornell.kfs.concur.ConcurPropertyConstants;\n+import edu.cornell.kfs.concur.rest.xmlObjects.AccessTokenDTO;\n+import edu.cornell.kfs.concur.service.ConcurAccessTokenService;\n+import edu.cornell.kfs.sys.businessobject.WebServiceCredential;\n+import edu.cornell.kfs.sys.service.WebServiceCredentialService;\n+\n+public class ConcurAccessTokenServiceImpl implements ConcurAccessTokenService {\n+ private static org.apache.log4j.Logger LOG = org.apache.log4j.Logger.getLogger(ConcurAccessTokenServiceImpl.class);\n+\n+ protected String concurRefreshAccessTokenURL;\n+ protected WebServiceCredentialService webServiceCredentialService;\n+\n+ @Override\n+ public void refreshAccessToken() {\n+ AccessTokenDTO refreshedToken = buildRefreshAccessTokenOutput();\n+ webServiceCredentialService.updateWebServiceCredentialValue(ConcurConstants.CONCUR_ACCESS_TOKEN_EXPIRATION_DATE, refreshedToken.getExpirationDate()); \n+ }\n+\n+ private AccessTokenDTO buildRefreshAccessTokenOutput() {\n+ ClientConfig clientConfig = new DefaultClientConfig();\n+ Client client = Client.create(clientConfig);\n+\n+ ClientResponse response = client.handle(buildRefreshAccessTokenClientRequest()); \n+ AccessTokenDTO refreshedToken = response.getEntity(AccessTokenDTO.class);\n+\n+ return refreshedToken;\n+ }\n+\n+ protected ClientRequest buildRefreshAccessTokenClientRequest() {\n+ ClientRequest.Builder builder = new ClientRequest.Builder();\n+ builder.accept(MediaType.APPLICATION_XML);\n+ builder.header(ConcurConstants.AUTHORIZATION_PROPERTY,ConcurConstants.OAUTH_AUTHENTICATION_SCHEME + getConcurAccessToken());\n+ URI uri;\n+ try {\n+ uri = new URI(getConcurRefreshAccessTokenURL()\n+ + ConcurConstants.REFRESH_TOKEN_URL_PARAM\n+ + getConcurRefreshToken()\n+ + ConcurConstants.CLIENT_ID_URL_PARAM\n+ + getConcurConsumerKey()\n+ + ConcurConstants.CLIENT_SECRET_URL_PARAM\n+ + getConcurSecretKey());\n+ } catch (URISyntaxException e) {\n+ throw new RuntimeException(e);","path":"src/main/java/edu/cornell/kfs/concur/service/impl/ConcurAccessTokenServiceImpl.java","position":65,"original_position":65,"commit_id":"e8b0e1c641df39f41bc5e1d81642626946ad1b5f","original_commit_id":"e8b0e1c641df39f41bc5e1d81642626946ad1b5f","user":{"login":"bhutchinson","id":1806259,"avatar_url":"https://avatars.githubusercontent.com/u/1806259?v=3","gravatar_id":"","url":"https://api.github.com/users/bhutchinson","html_url":"https://github.com/bhutchinson","followers_url":"https://api.github.com/users/bhutchinson/followers","following_url":"https://api.github.com/users/bhutchinson/following{/other_user}","gists_url":"https://api.github.com/users/bhutchinson/gists{/gist_id}","starred_url":"https://api.github.com/users/bhutchinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhutchinson/subscriptions","organizations_url":"https://api.github.com/users/bhutchinson/orgs","repos_url":"https://api.github.com/users/bhutchinson/repos","events_url":"https://api.github.com/users/bhutchinson/events{/privacy}","received_events_url":"https://api.github.com/users/bhutchinson/received_events","type":"User","site_admin":false},"body":"It might be helpful to include a message along with the exception when creating this new RuntimeException to add context that could help with possible troubleshooting.","created_at":"2017-01-12T19:11:45Z","updated_at":"2017-01-12T19:19:16Z","html_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/262#discussion_r95862714","pull_request_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/262","_links":{"self":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments/95862714"},"html":{"href":"https://github.com/CU-CommunityApps/cu-kfs/pull/262#discussion_r95862714"},"pull_request":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/262"}}},"pull_request":{"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/262","id":101219874,"html_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/262","diff_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/262.diff","patch_url":"https://github.com/CU-CommunityApps/cu-kfs/pull/262.patch","issue_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/262","number":262,"state":"open","locked":false,"title":"KFSPTS-7184 add refresh concur access token funcionality","user":{"login":"db483","id":5119449,"avatar_url":"https://avatars.githubusercontent.com/u/5119449?v=3","gravatar_id":"","url":"https://api.github.com/users/db483","html_url":"https://github.com/db483","followers_url":"https://api.github.com/users/db483/followers","following_url":"https://api.github.com/users/db483/following{/other_user}","gists_url":"https://api.github.com/users/db483/gists{/gist_id}","starred_url":"https://api.github.com/users/db483/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/db483/subscriptions","organizations_url":"https://api.github.com/users/db483/orgs","repos_url":"https://api.github.com/users/db483/repos","events_url":"https://api.github.com/users/db483/events{/privacy}","received_events_url":"https://api.github.com/users/db483/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-12T09:09:54Z","updated_at":"2017-01-12T19:19:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"712df9da7a1f67217e79382b7014e38dd27e92b8","assignee":{"login":"bhutchinson","id":1806259,"avatar_url":"https://avatars.githubusercontent.com/u/1806259?v=3","gravatar_id":"","url":"https://api.github.com/users/bhutchinson","html_url":"https://github.com/bhutchinson","followers_url":"https://api.github.com/users/bhutchinson/followers","following_url":"https://api.github.com/users/bhutchinson/following{/other_user}","gists_url":"https://api.github.com/users/bhutchinson/gists{/gist_id}","starred_url":"https://api.github.com/users/bhutchinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhutchinson/subscriptions","organizations_url":"https://api.github.com/users/bhutchinson/orgs","repos_url":"https://api.github.com/users/bhutchinson/repos","events_url":"https://api.github.com/users/bhutchinson/events{/privacy}","received_events_url":"https://api.github.com/users/bhutchinson/received_events","type":"User","site_admin":false},"assignees":[{"login":"bhutchinson","id":1806259,"avatar_url":"https://avatars.githubusercontent.com/u/1806259?v=3","gravatar_id":"","url":"https://api.github.com/users/bhutchinson","html_url":"https://github.com/bhutchinson","followers_url":"https://api.github.com/users/bhutchinson/followers","following_url":"https://api.github.com/users/bhutchinson/following{/other_user}","gists_url":"https://api.github.com/users/bhutchinson/gists{/gist_id}","starred_url":"https://api.github.com/users/bhutchinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhutchinson/subscriptions","organizations_url":"https://api.github.com/users/bhutchinson/orgs","repos_url":"https://api.github.com/users/bhutchinson/repos","events_url":"https://api.github.com/users/bhutchinson/events{/privacy}","received_events_url":"https://api.github.com/users/bhutchinson/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/262/commits","review_comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/262/comments","review_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/262/comments","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/e8b0e1c641df39f41bc5e1d81642626946ad1b5f","head":{"label":"CU-CommunityApps:KFSPTS-7184","ref":"KFSPTS-7184","sha":"e8b0e1c641df39f41bc5e1d81642626946ad1b5f","user":{"login":"CU-CommunityApps","id":5115848,"avatar_url":"https://avatars.githubusercontent.com/u/5115848?v=3","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"repo":{"id":12188834,"name":"cu-kfs","full_name":"CU-CommunityApps/cu-kfs","owner":{"login":"CU-CommunityApps","id":5115848,"avatar_url":"https://avatars.githubusercontent.com/u/5115848?v=3","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CU-CommunityApps/cu-kfs","description":null,"fork":false,"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs","forks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/forks","keys_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/teams","hooks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/hooks","issue_events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/events{/number}","events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/events","assignees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/assignees{/user}","branches_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/branches{/branch}","tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/tags","blobs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/languages","stargazers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/stargazers","contributors_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contributors","subscribers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscribers","subscription_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscription","commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contents/{+path}","compare_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/merges","archive_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/downloads","issues_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues{/number}","pulls_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/labels{/name}","releases_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/releases{/id}","deployments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/deployments","created_at":"2013-08-18T01:55:18Z","updated_at":"2016-11-16T23:48:27Z","pushed_at":"2017-01-12T18:47:27Z","git_url":"git://github.com/CU-CommunityApps/cu-kfs.git","ssh_url":"[email protected]:CU-CommunityApps/cu-kfs.git","clone_url":"https://github.com/CU-CommunityApps/cu-kfs.git","svn_url":"https://github.com/CU-CommunityApps/cu-kfs","homepage":null,"size":19114,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"CU-CommunityApps:post6-upgrade","ref":"post6-upgrade","sha":"20cc812ee36101a4cc23ebf05cdeb0b867d29ae7","user":{"login":"CU-CommunityApps","id":5115848,"avatar_url":"https://avatars.githubusercontent.com/u/5115848?v=3","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"repo":{"id":12188834,"name":"cu-kfs","full_name":"CU-CommunityApps/cu-kfs","owner":{"login":"CU-CommunityApps","id":5115848,"avatar_url":"https://avatars.githubusercontent.com/u/5115848?v=3","gravatar_id":"","url":"https://api.github.com/users/CU-CommunityApps","html_url":"https://github.com/CU-CommunityApps","followers_url":"https://api.github.com/users/CU-CommunityApps/followers","following_url":"https://api.github.com/users/CU-CommunityApps/following{/other_user}","gists_url":"https://api.github.com/users/CU-CommunityApps/gists{/gist_id}","starred_url":"https://api.github.com/users/CU-CommunityApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CU-CommunityApps/subscriptions","organizations_url":"https://api.github.com/users/CU-CommunityApps/orgs","repos_url":"https://api.github.com/users/CU-CommunityApps/repos","events_url":"https://api.github.com/users/CU-CommunityApps/events{/privacy}","received_events_url":"https://api.github.com/users/CU-CommunityApps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CU-CommunityApps/cu-kfs","description":null,"fork":false,"url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs","forks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/forks","keys_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/teams","hooks_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/hooks","issue_events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/events{/number}","events_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/events","assignees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/assignees{/user}","branches_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/branches{/branch}","tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/tags","blobs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/languages","stargazers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/stargazers","contributors_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contributors","subscribers_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscribers","subscription_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/subscription","commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/contents/{+path}","compare_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/merges","archive_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/downloads","issues_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues{/number}","pulls_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/labels{/name}","releases_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/releases{/id}","deployments_url":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/deployments","created_at":"2013-08-18T01:55:18Z","updated_at":"2016-11-16T23:48:27Z","pushed_at":"2017-01-12T18:47:27Z","git_url":"git://github.com/CU-CommunityApps/cu-kfs.git","ssh_url":"[email protected]:CU-CommunityApps/cu-kfs.git","clone_url":"https://github.com/CU-CommunityApps/cu-kfs.git","svn_url":"https://github.com/CU-CommunityApps/cu-kfs","homepage":null,"size":19114,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/262"},"html":{"href":"https://github.com/CU-CommunityApps/cu-kfs/pull/262"},"issue":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/262"},"comments":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/CU-CommunityApps/cu-kfs/statuses/e8b0e1c641df39f41bc5e1d81642626946ad1b5f"}}}} | {
"id": 12188834,
"name": "CU-CommunityApps/cu-kfs",
"url": "https://api.github.com/repos/CU-CommunityApps/cu-kfs"
} | {
"id": 1806259,
"login": "bhutchinson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1806259?",
"url": "https://api.github.com/users/bhutchinson"
} | {
"id": 5115848,
"login": "CU-CommunityApps",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5115848?",
"url": "https://api.github.com/orgs/CU-CommunityApps"
} | 2017-01-12T19:11:45 | 5144665325 | {"actor":{"display_login":"bhutchinson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/comments/140569731","pull_request_review_id":64667820,"id":140569731,"diff_hunk":"@@ -1,6 +1,6 @@\n Pod::Spec.new do |s|\n s.name = \"Theme\"\n- s.version = \"3.2.0\"","path":"Theme.podspec","position":3,"original_position":3,"commit_id":"8b01241bc46c53c479366c3c1e8235817eb5a4f3","original_commit_id":"8b01241bc46c53c479366c3c1e8235817eb5a4f3","user":{"login":"stephanheilner","id":2056085,"avatar_url":"https://avatars3.githubusercontent.com/u/2056085?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanheilner","html_url":"https://github.com/stephanheilner","followers_url":"https://api.github.com/users/stephanheilner/followers","following_url":"https://api.github.com/users/stephanheilner/following{/other_user}","gists_url":"https://api.github.com/users/stephanheilner/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanheilner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanheilner/subscriptions","organizations_url":"https://api.github.com/users/stephanheilner/orgs","repos_url":"https://api.github.com/users/stephanheilner/repos","events_url":"https://api.github.com/users/stephanheilner/events{/privacy}","received_events_url":"https://api.github.com/users/stephanheilner/received_events","type":"User","site_admin":false},"body":"Would this be a 4.0.0 change? Does it break backwards compatibility?","created_at":"2017-09-22T18:49:46Z","updated_at":"2017-09-22T18:49:46Z","html_url":"https://github.com/CrossWaterBridge/Theme/pull/8#discussion_r140569731","pull_request_url":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/comments/140569731"},"html":{"href":"https://github.com/CrossWaterBridge/Theme/pull/8#discussion_r140569731"},"pull_request":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/8","id":142645299,"html_url":"https://github.com/CrossWaterBridge/Theme/pull/8","diff_url":"https://github.com/CrossWaterBridge/Theme/pull/8.diff","patch_url":"https://github.com/CrossWaterBridge/Theme/pull/8.patch","issue_url":"https://api.github.com/repos/CrossWaterBridge/Theme/issues/8","number":8,"state":"open","locked":false,"title":"Updated to compile with Swift 4","user":{"login":"brandenr","id":1273389,"avatar_url":"https://avatars1.githubusercontent.com/u/1273389?v=4","gravatar_id":"","url":"https://api.github.com/users/brandenr","html_url":"https://github.com/brandenr","followers_url":"https://api.github.com/users/brandenr/followers","following_url":"https://api.github.com/users/brandenr/following{/other_user}","gists_url":"https://api.github.com/users/brandenr/gists{/gist_id}","starred_url":"https://api.github.com/users/brandenr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandenr/subscriptions","organizations_url":"https://api.github.com/users/brandenr/orgs","repos_url":"https://api.github.com/users/brandenr/repos","events_url":"https://api.github.com/users/brandenr/events{/privacy}","received_events_url":"https://api.github.com/users/brandenr/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-22T18:48:52Z","updated_at":"2017-09-22T18:49:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db27ef574446bf611531be6c23297dbb8af78784","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/8/commits","review_comments_url":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/8/comments","review_comment_url":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CrossWaterBridge/Theme/issues/8/comments","statuses_url":"https://api.github.com/repos/CrossWaterBridge/Theme/statuses/8b01241bc46c53c479366c3c1e8235817eb5a4f3","head":{"label":"brandenr:swift-4","ref":"swift-4","sha":"8b01241bc46c53c479366c3c1e8235817eb5a4f3","user":{"login":"brandenr","id":1273389,"avatar_url":"https://avatars1.githubusercontent.com/u/1273389?v=4","gravatar_id":"","url":"https://api.github.com/users/brandenr","html_url":"https://github.com/brandenr","followers_url":"https://api.github.com/users/brandenr/followers","following_url":"https://api.github.com/users/brandenr/following{/other_user}","gists_url":"https://api.github.com/users/brandenr/gists{/gist_id}","starred_url":"https://api.github.com/users/brandenr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandenr/subscriptions","organizations_url":"https://api.github.com/users/brandenr/orgs","repos_url":"https://api.github.com/users/brandenr/repos","events_url":"https://api.github.com/users/brandenr/events{/privacy}","received_events_url":"https://api.github.com/users/brandenr/received_events","type":"User","site_admin":false},"repo":{"id":88654771,"name":"Theme","full_name":"brandenr/Theme","owner":{"login":"brandenr","id":1273389,"avatar_url":"https://avatars1.githubusercontent.com/u/1273389?v=4","gravatar_id":"","url":"https://api.github.com/users/brandenr","html_url":"https://github.com/brandenr","followers_url":"https://api.github.com/users/brandenr/followers","following_url":"https://api.github.com/users/brandenr/following{/other_user}","gists_url":"https://api.github.com/users/brandenr/gists{/gist_id}","starred_url":"https://api.github.com/users/brandenr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandenr/subscriptions","organizations_url":"https://api.github.com/users/brandenr/orgs","repos_url":"https://api.github.com/users/brandenr/repos","events_url":"https://api.github.com/users/brandenr/events{/privacy}","received_events_url":"https://api.github.com/users/brandenr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brandenr/Theme","description":"Support one or more configurable appearance themes.","fork":true,"url":"https://api.github.com/repos/brandenr/Theme","forks_url":"https://api.github.com/repos/brandenr/Theme/forks","keys_url":"https://api.github.com/repos/brandenr/Theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandenr/Theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandenr/Theme/teams","hooks_url":"https://api.github.com/repos/brandenr/Theme/hooks","issue_events_url":"https://api.github.com/repos/brandenr/Theme/issues/events{/number}","events_url":"https://api.github.com/repos/brandenr/Theme/events","assignees_url":"https://api.github.com/repos/brandenr/Theme/assignees{/user}","branches_url":"https://api.github.com/repos/brandenr/Theme/branches{/branch}","tags_url":"https://api.github.com/repos/brandenr/Theme/tags","blobs_url":"https://api.github.com/repos/brandenr/Theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandenr/Theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandenr/Theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandenr/Theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandenr/Theme/statuses/{sha}","languages_url":"https://api.github.com/repos/brandenr/Theme/languages","stargazers_url":"https://api.github.com/repos/brandenr/Theme/stargazers","contributors_url":"https://api.github.com/repos/brandenr/Theme/contributors","subscribers_url":"https://api.github.com/repos/brandenr/Theme/subscribers","subscription_url":"https://api.github.com/repos/brandenr/Theme/subscription","commits_url":"https://api.github.com/repos/brandenr/Theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandenr/Theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandenr/Theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandenr/Theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandenr/Theme/contents/{+path}","compare_url":"https://api.github.com/repos/brandenr/Theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandenr/Theme/merges","archive_url":"https://api.github.com/repos/brandenr/Theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandenr/Theme/downloads","issues_url":"https://api.github.com/repos/brandenr/Theme/issues{/number}","pulls_url":"https://api.github.com/repos/brandenr/Theme/pulls{/number}","milestones_url":"https://api.github.com/repos/brandenr/Theme/milestones{/number}","notifications_url":"https://api.github.com/repos/brandenr/Theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandenr/Theme/labels{/name}","releases_url":"https://api.github.com/repos/brandenr/Theme/releases{/id}","deployments_url":"https://api.github.com/repos/brandenr/Theme/deployments","created_at":"2017-04-18T17:58:11Z","updated_at":"2017-04-18T17:58:13Z","pushed_at":"2017-09-22T18:48:16Z","git_url":"git://github.com/brandenr/Theme.git","ssh_url":"[email protected]:brandenr/Theme.git","clone_url":"https://github.com/brandenr/Theme.git","svn_url":"https://github.com/brandenr/Theme","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CrossWaterBridge:master","ref":"master","sha":"d969498541cc4eb212fa758480ba201db2aa83db","user":{"login":"CrossWaterBridge","id":10014287,"avatar_url":"https://avatars2.githubusercontent.com/u/10014287?v=4","gravatar_id":"","url":"https://api.github.com/users/CrossWaterBridge","html_url":"https://github.com/CrossWaterBridge","followers_url":"https://api.github.com/users/CrossWaterBridge/followers","following_url":"https://api.github.com/users/CrossWaterBridge/following{/other_user}","gists_url":"https://api.github.com/users/CrossWaterBridge/gists{/gist_id}","starred_url":"https://api.github.com/users/CrossWaterBridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrossWaterBridge/subscriptions","organizations_url":"https://api.github.com/users/CrossWaterBridge/orgs","repos_url":"https://api.github.com/users/CrossWaterBridge/repos","events_url":"https://api.github.com/users/CrossWaterBridge/events{/privacy}","received_events_url":"https://api.github.com/users/CrossWaterBridge/received_events","type":"Organization","site_admin":false},"repo":{"id":48707199,"name":"Theme","full_name":"CrossWaterBridge/Theme","owner":{"login":"CrossWaterBridge","id":10014287,"avatar_url":"https://avatars2.githubusercontent.com/u/10014287?v=4","gravatar_id":"","url":"https://api.github.com/users/CrossWaterBridge","html_url":"https://github.com/CrossWaterBridge","followers_url":"https://api.github.com/users/CrossWaterBridge/followers","following_url":"https://api.github.com/users/CrossWaterBridge/following{/other_user}","gists_url":"https://api.github.com/users/CrossWaterBridge/gists{/gist_id}","starred_url":"https://api.github.com/users/CrossWaterBridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrossWaterBridge/subscriptions","organizations_url":"https://api.github.com/users/CrossWaterBridge/orgs","repos_url":"https://api.github.com/users/CrossWaterBridge/repos","events_url":"https://api.github.com/users/CrossWaterBridge/events{/privacy}","received_events_url":"https://api.github.com/users/CrossWaterBridge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CrossWaterBridge/Theme","description":"Support one or more configurable appearance themes.","fork":false,"url":"https://api.github.com/repos/CrossWaterBridge/Theme","forks_url":"https://api.github.com/repos/CrossWaterBridge/Theme/forks","keys_url":"https://api.github.com/repos/CrossWaterBridge/Theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CrossWaterBridge/Theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CrossWaterBridge/Theme/teams","hooks_url":"https://api.github.com/repos/CrossWaterBridge/Theme/hooks","issue_events_url":"https://api.github.com/repos/CrossWaterBridge/Theme/issues/events{/number}","events_url":"https://api.github.com/repos/CrossWaterBridge/Theme/events","assignees_url":"https://api.github.com/repos/CrossWaterBridge/Theme/assignees{/user}","branches_url":"https://api.github.com/repos/CrossWaterBridge/Theme/branches{/branch}","tags_url":"https://api.github.com/repos/CrossWaterBridge/Theme/tags","blobs_url":"https://api.github.com/repos/CrossWaterBridge/Theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CrossWaterBridge/Theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CrossWaterBridge/Theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/CrossWaterBridge/Theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CrossWaterBridge/Theme/statuses/{sha}","languages_url":"https://api.github.com/repos/CrossWaterBridge/Theme/languages","stargazers_url":"https://api.github.com/repos/CrossWaterBridge/Theme/stargazers","contributors_url":"https://api.github.com/repos/CrossWaterBridge/Theme/contributors","subscribers_url":"https://api.github.com/repos/CrossWaterBridge/Theme/subscribers","subscription_url":"https://api.github.com/repos/CrossWaterBridge/Theme/subscription","commits_url":"https://api.github.com/repos/CrossWaterBridge/Theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/CrossWaterBridge/Theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/CrossWaterBridge/Theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/CrossWaterBridge/Theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/CrossWaterBridge/Theme/contents/{+path}","compare_url":"https://api.github.com/repos/CrossWaterBridge/Theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CrossWaterBridge/Theme/merges","archive_url":"https://api.github.com/repos/CrossWaterBridge/Theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CrossWaterBridge/Theme/downloads","issues_url":"https://api.github.com/repos/CrossWaterBridge/Theme/issues{/number}","pulls_url":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls{/number}","milestones_url":"https://api.github.com/repos/CrossWaterBridge/Theme/milestones{/number}","notifications_url":"https://api.github.com/repos/CrossWaterBridge/Theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CrossWaterBridge/Theme/labels{/name}","releases_url":"https://api.github.com/repos/CrossWaterBridge/Theme/releases{/id}","deployments_url":"https://api.github.com/repos/CrossWaterBridge/Theme/deployments","created_at":"2015-12-28T18:50:40Z","updated_at":"2017-05-30T19:17:09Z","pushed_at":"2017-09-22T18:48:52Z","git_url":"git://github.com/CrossWaterBridge/Theme.git","ssh_url":"[email protected]:CrossWaterBridge/Theme.git","clone_url":"https://github.com/CrossWaterBridge/Theme.git","svn_url":"https://github.com/CrossWaterBridge/Theme","homepage":null,"size":41,"stargazers_count":3,"watchers_count":3,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/8"},"html":{"href":"https://github.com/CrossWaterBridge/Theme/pull/8"},"issue":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/issues/8"},"comments":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/CrossWaterBridge/Theme/statuses/8b01241bc46c53c479366c3c1e8235817eb5a4f3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 48707199,
"name": "CrossWaterBridge/Theme",
"url": "https://api.github.com/repos/CrossWaterBridge/Theme"
} | {
"id": 2056085,
"login": "stephanheilner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2056085?",
"url": "https://api.github.com/users/stephanheilner"
} | {
"id": 10014287,
"login": "CrossWaterBridge",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10014287?",
"url": "https://api.github.com/orgs/CrossWaterBridge"
} | 2017-09-22T18:49:46 | 6626272588 | {"actor":{"display_login":"stephanheilner"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/comments/121493490","pull_request_review_id":43525915,"id":121493490,"diff_hunk":"@@ -0,0 +1,337 @@\n+# tests.test_boundaries\n+# Ensure that the decision boundary visualizations work.\n+#\n+# Author: Author: Nathan Danielsen <[email protected]>\n+# Created: Sun Mar 19 13:01:29 2017 -0400\n+#\n+# Copyright (C) 2017 District Data Labs\n+# For license information, see LICENSE.txt\n+#\n+# ID: test_knn.py [] [email protected] $\n+\"\"\"\n+Ensure that the Decision Boundary visualizations work.\n+\"\"\"\n+\n+##########################################################################\n+# Imports\n+##########################################################################\n+\n+try:\n+ from unittest import mock\n+except ImportError:\n+ import mock\n+\n+from collections import OrderedDict\n+import numpy as np\n+\n+try:\n+ import pandas as pd\n+except ImportError:\n+ pd = None\n+\n+import unittest\n+from tests.base import VisualTestCase\n+from yellowbrick.classifier import *\n+from yellowbrick.exceptions import YellowbrickTypeError\n+from yellowbrick.exceptions import YellowbrickValueError\n+\n+from sklearn import datasets\n+from sklearn import neighbors\n+from sklearn import naive_bayes\n+##########################################################################\n+# Data\n+##########################################################################\n+# yapf: disable\n+X = np.array([\n+ [2.318, 2.727, 4.260, 7.212, 4.792, ],\n+ [2.315, 2.726, 4.295, 7.140, 4.783, ],\n+ [2.315, 2.724, 4.260, 7.135, 4.779, ],\n+ [2.110, 3.609, 4.330, 7.985, 5.595, ],\n+ [2.110, 3.626, 4.330, 8.203, 5.621, ],\n+ [2.110, 3.620, 4.470, 8.210, 5.612, ],\n+ [2.318, 2.727, 4.260, 7.212, 4.792, ],\n+ [2.315, 2.726, 4.295, 7.140, 4.783, ],\n+ [2.315, 2.724, 4.260, 7.135, 4.779, ],\n+ [2.110, 3.609, 4.330, 7.985, 5.595, ],\n+ [2.110, 3.626, 4.330, 8.203, 5.621, ],\n+ [2.110, 3.620, 4.470, 8.210, 5.612, ]\n+ ])\n+\n+y = np.array([1, 2, 1, 2, 1, 0, 0, 1, 3, 1, 3, 2])\n+\n+X_two_cols = X[:, :2]\n+# yapf: enable\n+##########################################################################\n+# Residuals Plots test case\n+##########################################################################\n+\n+\n+class DecisionBoundariesVisualizerTest(VisualTestCase):\n+ \"\"\"Testcases for the DecisionBoundariesVisualizers \"\"\"\n+\n+ def test_decision_bounardies(self):\n+ \"\"\"Assert no errors occur during KnnDecisionBoundariesVisualizer","path":"tests/test_classifier/test_boundaries.py","position":73,"original_position":73,"commit_id":"612d8a5237d3d9343c2a0488c4fd6d4a1d686a09","original_commit_id":"612d8a5237d3d9343c2a0488c4fd6d4a1d686a09","user":{"login":"bbengfort","id":745966,"avatar_url":"https://avatars3.githubusercontent.com/u/745966?v=3","gravatar_id":"","url":"https://api.github.com/users/bbengfort","html_url":"https://github.com/bbengfort","followers_url":"https://api.github.com/users/bbengfort/followers","following_url":"https://api.github.com/users/bbengfort/following{/other_user}","gists_url":"https://api.github.com/users/bbengfort/gists{/gist_id}","starred_url":"https://api.github.com/users/bbengfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbengfort/subscriptions","organizations_url":"https://api.github.com/users/bbengfort/orgs","repos_url":"https://api.github.com/users/bbengfort/repos","events_url":"https://api.github.com/users/bbengfort/events{/privacy}","received_events_url":"https://api.github.com/users/bbengfort/received_events","type":"User","site_admin":false},"body":"With the -v flag on nosetests set, the first line of the docstring is used in the test description; this isn't a big deal, but just wanted to note that the word \"integration\" would be chopped off during tests. I think it's pretty readable even so. ","created_at":"2017-06-12T18:40:29Z","updated_at":"2017-06-12T19:04:48Z","html_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/196#discussion_r121493490","pull_request_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/comments/121493490"},"html":{"href":"https://github.com/DistrictDataLabs/yellowbrick/pull/196#discussion_r121493490"},"pull_request":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/196","id":115534570,"html_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/196","diff_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/196.diff","patch_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/196.patch","issue_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/196","number":196,"state":"open","locked":false,"title":"Decision Boundary Visualizer","user":{"login":"ndanielsen","id":2944777,"avatar_url":"https://avatars3.githubusercontent.com/u/2944777?v=3","gravatar_id":"","url":"https://api.github.com/users/ndanielsen","html_url":"https://github.com/ndanielsen","followers_url":"https://api.github.com/users/ndanielsen/followers","following_url":"https://api.github.com/users/ndanielsen/following{/other_user}","gists_url":"https://api.github.com/users/ndanielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/ndanielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndanielsen/subscriptions","organizations_url":"https://api.github.com/users/ndanielsen/orgs","repos_url":"https://api.github.com/users/ndanielsen/repos","events_url":"https://api.github.com/users/ndanielsen/events{/privacy}","received_events_url":"https://api.github.com/users/ndanielsen/received_events","type":"User","site_admin":false},"body":"Update: \r\n\r\nThe DecisionBoundaryVisualizer visualizes the model decisions given a two feature space. Next iteration on this will include ability to select one class along with score metrics with selected class.\r\n\r\nThis visualizer supports numpy structured arrays, dataframes and normal ndarrays. \r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2017-04-12T12:50:51Z","updated_at":"2017-06-12T19:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef2c6864384f79ad244cee24394714c3aa314b2d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/milestones/6","html_url":"https://github.com/DistrictDataLabs/yellowbrick/milestone/6","labels_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/milestones/6/labels","id":1987698,"number":6,"title":"Backlog","description":"Great ideas that should be considered for the next version!","creator":{"login":"bbengfort","id":745966,"avatar_url":"https://avatars3.githubusercontent.com/u/745966?v=3","gravatar_id":"","url":"https://api.github.com/users/bbengfort","html_url":"https://github.com/bbengfort","followers_url":"https://api.github.com/users/bbengfort/followers","following_url":"https://api.github.com/users/bbengfort/following{/other_user}","gists_url":"https://api.github.com/users/bbengfort/gists{/gist_id}","starred_url":"https://api.github.com/users/bbengfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbengfort/subscriptions","organizations_url":"https://api.github.com/users/bbengfort/orgs","repos_url":"https://api.github.com/users/bbengfort/repos","events_url":"https://api.github.com/users/bbengfort/events{/privacy}","received_events_url":"https://api.github.com/users/bbengfort/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":13,"state":"open","created_at":"2016-09-07T00:55:52Z","updated_at":"2017-06-05T17:32:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/196/commits","review_comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/196/comments","review_comment_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/196/comments","statuses_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/statuses/612d8a5237d3d9343c2a0488c4fd6d4a1d686a09","head":{"label":"DistrictDataLabs:neighbors","ref":"neighbors","sha":"612d8a5237d3d9343c2a0488c4fd6d4a1d686a09","user":{"login":"DistrictDataLabs","id":7107115,"avatar_url":"https://avatars1.githubusercontent.com/u/7107115?v=3","gravatar_id":"","url":"https://api.github.com/users/DistrictDataLabs","html_url":"https://github.com/DistrictDataLabs","followers_url":"https://api.github.com/users/DistrictDataLabs/followers","following_url":"https://api.github.com/users/DistrictDataLabs/following{/other_user}","gists_url":"https://api.github.com/users/DistrictDataLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DistrictDataLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DistrictDataLabs/subscriptions","organizations_url":"https://api.github.com/users/DistrictDataLabs/orgs","repos_url":"https://api.github.com/users/DistrictDataLabs/repos","events_url":"https://api.github.com/users/DistrictDataLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DistrictDataLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":59121694,"name":"yellowbrick","full_name":"DistrictDataLabs/yellowbrick","owner":{"login":"DistrictDataLabs","id":7107115,"avatar_url":"https://avatars1.githubusercontent.com/u/7107115?v=3","gravatar_id":"","url":"https://api.github.com/users/DistrictDataLabs","html_url":"https://github.com/DistrictDataLabs","followers_url":"https://api.github.com/users/DistrictDataLabs/followers","following_url":"https://api.github.com/users/DistrictDataLabs/following{/other_user}","gists_url":"https://api.github.com/users/DistrictDataLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DistrictDataLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DistrictDataLabs/subscriptions","organizations_url":"https://api.github.com/users/DistrictDataLabs/orgs","repos_url":"https://api.github.com/users/DistrictDataLabs/repos","events_url":"https://api.github.com/users/DistrictDataLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DistrictDataLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DistrictDataLabs/yellowbrick","description":"Visual analysis and diagnostic tools to facilitate machine learning model selection.","fork":false,"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick","forks_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/forks","keys_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/teams","hooks_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/hooks","issue_events_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/events{/number}","events_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/events","assignees_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/assignees{/user}","branches_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/branches{/branch}","tags_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/tags","blobs_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/refs{/sha}","trees_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/statuses/{sha}","languages_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/languages","stargazers_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/stargazers","contributors_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/contributors","subscribers_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/subscribers","subscription_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/subscription","commits_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/commits{/sha}","git_commits_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/commits{/sha}","comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/comments{/number}","issue_comment_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/comments{/number}","contents_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/contents/{+path}","compare_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/merges","archive_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/downloads","issues_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues{/number}","pulls_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls{/number}","milestones_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/milestones{/number}","notifications_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/labels{/name}","releases_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/releases{/id}","deployments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/deployments","created_at":"2016-05-18T14:12:17Z","updated_at":"2017-06-12T18:56:41Z","pushed_at":"2017-06-12T17:14:18Z","git_url":"git://github.com/DistrictDataLabs/yellowbrick.git","ssh_url":"[email protected]:DistrictDataLabs/yellowbrick.git","clone_url":"https://github.com/DistrictDataLabs/yellowbrick.git","svn_url":"https://github.com/DistrictDataLabs/yellowbrick","homepage":"http://www.scikit-yb.org/","size":22105,"stargazers_count":314,"watchers_count":314,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":76,"forks":88,"open_issues":76,"watchers":314,"default_branch":"develop"}},"base":{"label":"DistrictDataLabs:develop","ref":"develop","sha":"bd2bf1e39929f218e548d016e86c47b64d7f7a81","user":{"login":"DistrictDataLabs","id":7107115,"avatar_url":"https://avatars1.githubusercontent.com/u/7107115?v=3","gravatar_id":"","url":"https://api.github.com/users/DistrictDataLabs","html_url":"https://github.com/DistrictDataLabs","followers_url":"https://api.github.com/users/DistrictDataLabs/followers","following_url":"https://api.github.com/users/DistrictDataLabs/following{/other_user}","gists_url":"https://api.github.com/users/DistrictDataLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DistrictDataLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DistrictDataLabs/subscriptions","organizations_url":"https://api.github.com/users/DistrictDataLabs/orgs","repos_url":"https://api.github.com/users/DistrictDataLabs/repos","events_url":"https://api.github.com/users/DistrictDataLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DistrictDataLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":59121694,"name":"yellowbrick","full_name":"DistrictDataLabs/yellowbrick","owner":{"login":"DistrictDataLabs","id":7107115,"avatar_url":"https://avatars1.githubusercontent.com/u/7107115?v=3","gravatar_id":"","url":"https://api.github.com/users/DistrictDataLabs","html_url":"https://github.com/DistrictDataLabs","followers_url":"https://api.github.com/users/DistrictDataLabs/followers","following_url":"https://api.github.com/users/DistrictDataLabs/following{/other_user}","gists_url":"https://api.github.com/users/DistrictDataLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DistrictDataLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DistrictDataLabs/subscriptions","organizations_url":"https://api.github.com/users/DistrictDataLabs/orgs","repos_url":"https://api.github.com/users/DistrictDataLabs/repos","events_url":"https://api.github.com/users/DistrictDataLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DistrictDataLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DistrictDataLabs/yellowbrick","description":"Visual analysis and diagnostic tools to facilitate machine learning model selection.","fork":false,"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick","forks_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/forks","keys_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/teams","hooks_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/hooks","issue_events_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/events{/number}","events_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/events","assignees_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/assignees{/user}","branches_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/branches{/branch}","tags_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/tags","blobs_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/refs{/sha}","trees_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/statuses/{sha}","languages_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/languages","stargazers_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/stargazers","contributors_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/contributors","subscribers_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/subscribers","subscription_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/subscription","commits_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/commits{/sha}","git_commits_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/commits{/sha}","comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/comments{/number}","issue_comment_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/comments{/number}","contents_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/contents/{+path}","compare_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/merges","archive_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/downloads","issues_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues{/number}","pulls_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls{/number}","milestones_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/milestones{/number}","notifications_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/labels{/name}","releases_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/releases{/id}","deployments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/deployments","created_at":"2016-05-18T14:12:17Z","updated_at":"2017-06-12T18:56:41Z","pushed_at":"2017-06-12T17:14:18Z","git_url":"git://github.com/DistrictDataLabs/yellowbrick.git","ssh_url":"[email protected]:DistrictDataLabs/yellowbrick.git","clone_url":"https://github.com/DistrictDataLabs/yellowbrick.git","svn_url":"https://github.com/DistrictDataLabs/yellowbrick","homepage":"http://www.scikit-yb.org/","size":22105,"stargazers_count":314,"watchers_count":314,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":76,"forks":88,"open_issues":76,"watchers":314,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/196"},"html":{"href":"https://github.com/DistrictDataLabs/yellowbrick/pull/196"},"issue":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/196"},"comments":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/statuses/612d8a5237d3d9343c2a0488c4fd6d4a1d686a09"}}}} | {
"id": 59121694,
"name": "DistrictDataLabs/yellowbrick",
"url": "https://api.github.com/repos/DistrictDataLabs/yellowbrick"
} | {
"id": 745966,
"login": "bbengfort",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/745966?",
"url": "https://api.github.com/users/bbengfort"
} | {
"id": 7107115,
"login": "DistrictDataLabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7107115?",
"url": "https://api.github.com/orgs/DistrictDataLabs"
} | 2017-06-12T18:40:29 | 6049582716 | {"actor":{"display_login":"bbengfort"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/comments/112997395","pull_request_review_id":34353517,"id":112997395,"diff_hunk":"@@ -0,0 +1,27 @@\n+/**\n+ * Created by Maxi on 24.04.17.\n+ */\n+\n+import React from 'react';\n+import style from './style.scss';\n+import BookCollection from './../book-collection';","path":"client/app/components/bibliothek/index.js","position":7,"original_position":7,"commit_id":"2cf4d7823fb66373b31c8bcff0d47bc082eaef3a","original_commit_id":"2cf4d7823fb66373b31c8bcff0d47bc082eaef3a","user":{"login":"3rfan","id":1698331,"avatar_url":"https://avatars2.githubusercontent.com/u/1698331?v=3","gravatar_id":"","url":"https://api.github.com/users/3rfan","html_url":"https://github.com/3rfan","followers_url":"https://api.github.com/users/3rfan/followers","following_url":"https://api.github.com/users/3rfan/following{/other_user}","gists_url":"https://api.github.com/users/3rfan/gists{/gist_id}","starred_url":"https://api.github.com/users/3rfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3rfan/subscriptions","organizations_url":"https://api.github.com/users/3rfan/orgs","repos_url":"https://api.github.com/users/3rfan/repos","events_url":"https://api.github.com/users/3rfan/events{/privacy}","received_events_url":"https://api.github.com/users/3rfan/received_events","type":"User","site_admin":false},"body":"After my merge you can use app/components/book-collection without using relative paths","created_at":"2017-04-24T16:45:53Z","updated_at":"2017-04-24T16:45:53Z","html_url":"https://github.com/FHS-TeamFabulous/MMP2b/pull/6#discussion_r112997395","pull_request_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/comments/112997395"},"html":{"href":"https://github.com/FHS-TeamFabulous/MMP2b/pull/6#discussion_r112997395"},"pull_request":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/6","id":117288305,"html_url":"https://github.com/FHS-TeamFabulous/MMP2b/pull/6","diff_url":"https://github.com/FHS-TeamFabulous/MMP2b/pull/6.diff","patch_url":"https://github.com/FHS-TeamFabulous/MMP2b/pull/6.patch","issue_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues/6","number":6,"state":"open","locked":false,"title":"Layouting of the Frontpage","user":{"login":"MFSepplive","id":12484761,"avatar_url":"https://avatars2.githubusercontent.com/u/12484761?v=3","gravatar_id":"","url":"https://api.github.com/users/MFSepplive","html_url":"https://github.com/MFSepplive","followers_url":"https://api.github.com/users/MFSepplive/followers","following_url":"https://api.github.com/users/MFSepplive/following{/other_user}","gists_url":"https://api.github.com/users/MFSepplive/gists{/gist_id}","starred_url":"https://api.github.com/users/MFSepplive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFSepplive/subscriptions","organizations_url":"https://api.github.com/users/MFSepplive/orgs","repos_url":"https://api.github.com/users/MFSepplive/repos","events_url":"https://api.github.com/users/MFSepplive/events{/privacy}","received_events_url":"https://api.github.com/users/MFSepplive/received_events","type":"User","site_admin":false},"body":"Still have to change some inline styling so dont be upset :D ","created_at":"2017-04-24T15:09:12Z","updated_at":"2017-04-24T16:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17870bb4ac0b99c32a8568ef00d8c127ca2fdafa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/6/commits","review_comments_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/6/comments","review_comment_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues/6/comments","statuses_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/statuses/2cf4d7823fb66373b31c8bcff0d47bc082eaef3a","head":{"label":"FHS-TeamFabulous:maxi","ref":"maxi","sha":"2cf4d7823fb66373b31c8bcff0d47bc082eaef3a","user":{"login":"FHS-TeamFabulous","id":27743573,"avatar_url":"https://avatars2.githubusercontent.com/u/27743573?v=3","gravatar_id":"","url":"https://api.github.com/users/FHS-TeamFabulous","html_url":"https://github.com/FHS-TeamFabulous","followers_url":"https://api.github.com/users/FHS-TeamFabulous/followers","following_url":"https://api.github.com/users/FHS-TeamFabulous/following{/other_user}","gists_url":"https://api.github.com/users/FHS-TeamFabulous/gists{/gist_id}","starred_url":"https://api.github.com/users/FHS-TeamFabulous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHS-TeamFabulous/subscriptions","organizations_url":"https://api.github.com/users/FHS-TeamFabulous/orgs","repos_url":"https://api.github.com/users/FHS-TeamFabulous/repos","events_url":"https://api.github.com/users/FHS-TeamFabulous/events{/privacy}","received_events_url":"https://api.github.com/users/FHS-TeamFabulous/received_events","type":"Organization","site_admin":false},"repo":{"id":88672332,"name":"MMP2b","full_name":"FHS-TeamFabulous/MMP2b","owner":{"login":"FHS-TeamFabulous","id":27743573,"avatar_url":"https://avatars2.githubusercontent.com/u/27743573?v=3","gravatar_id":"","url":"https://api.github.com/users/FHS-TeamFabulous","html_url":"https://github.com/FHS-TeamFabulous","followers_url":"https://api.github.com/users/FHS-TeamFabulous/followers","following_url":"https://api.github.com/users/FHS-TeamFabulous/following{/other_user}","gists_url":"https://api.github.com/users/FHS-TeamFabulous/gists{/gist_id}","starred_url":"https://api.github.com/users/FHS-TeamFabulous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHS-TeamFabulous/subscriptions","organizations_url":"https://api.github.com/users/FHS-TeamFabulous/orgs","repos_url":"https://api.github.com/users/FHS-TeamFabulous/repos","events_url":"https://api.github.com/users/FHS-TeamFabulous/events{/privacy}","received_events_url":"https://api.github.com/users/FHS-TeamFabulous/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FHS-TeamFabulous/MMP2b","description":"Our MMP2b Project for the 4th term at FH-Salzburg","fork":false,"url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b","forks_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/forks","keys_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/teams","hooks_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/hooks","issue_events_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues/events{/number}","events_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/events","assignees_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/assignees{/user}","branches_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/branches{/branch}","tags_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/tags","blobs_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/refs{/sha}","trees_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/statuses/{sha}","languages_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/languages","stargazers_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/stargazers","contributors_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/contributors","subscribers_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/subscribers","subscription_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/subscription","commits_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/commits{/sha}","git_commits_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/commits{/sha}","comments_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/comments{/number}","issue_comment_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues/comments{/number}","contents_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/contents/{+path}","compare_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/merges","archive_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/downloads","issues_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues{/number}","pulls_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls{/number}","milestones_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/milestones{/number}","notifications_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/labels{/name}","releases_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/releases{/id}","deployments_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/deployments","created_at":"2017-04-18T21:30:56Z","updated_at":"2017-04-23T11:42:33Z","pushed_at":"2017-04-24T15:10:36Z","git_url":"git://github.com/FHS-TeamFabulous/MMP2b.git","ssh_url":"[email protected]:FHS-TeamFabulous/MMP2b.git","clone_url":"https://github.com/FHS-TeamFabulous/MMP2b.git","svn_url":"https://github.com/FHS-TeamFabulous/MMP2b","homepage":null,"size":254,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"FHS-TeamFabulous:master","ref":"master","sha":"6f53ab43e0e1e6fb428c434eba9d93a5a88f82e7","user":{"login":"FHS-TeamFabulous","id":27743573,"avatar_url":"https://avatars2.githubusercontent.com/u/27743573?v=3","gravatar_id":"","url":"https://api.github.com/users/FHS-TeamFabulous","html_url":"https://github.com/FHS-TeamFabulous","followers_url":"https://api.github.com/users/FHS-TeamFabulous/followers","following_url":"https://api.github.com/users/FHS-TeamFabulous/following{/other_user}","gists_url":"https://api.github.com/users/FHS-TeamFabulous/gists{/gist_id}","starred_url":"https://api.github.com/users/FHS-TeamFabulous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHS-TeamFabulous/subscriptions","organizations_url":"https://api.github.com/users/FHS-TeamFabulous/orgs","repos_url":"https://api.github.com/users/FHS-TeamFabulous/repos","events_url":"https://api.github.com/users/FHS-TeamFabulous/events{/privacy}","received_events_url":"https://api.github.com/users/FHS-TeamFabulous/received_events","type":"Organization","site_admin":false},"repo":{"id":88672332,"name":"MMP2b","full_name":"FHS-TeamFabulous/MMP2b","owner":{"login":"FHS-TeamFabulous","id":27743573,"avatar_url":"https://avatars2.githubusercontent.com/u/27743573?v=3","gravatar_id":"","url":"https://api.github.com/users/FHS-TeamFabulous","html_url":"https://github.com/FHS-TeamFabulous","followers_url":"https://api.github.com/users/FHS-TeamFabulous/followers","following_url":"https://api.github.com/users/FHS-TeamFabulous/following{/other_user}","gists_url":"https://api.github.com/users/FHS-TeamFabulous/gists{/gist_id}","starred_url":"https://api.github.com/users/FHS-TeamFabulous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FHS-TeamFabulous/subscriptions","organizations_url":"https://api.github.com/users/FHS-TeamFabulous/orgs","repos_url":"https://api.github.com/users/FHS-TeamFabulous/repos","events_url":"https://api.github.com/users/FHS-TeamFabulous/events{/privacy}","received_events_url":"https://api.github.com/users/FHS-TeamFabulous/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FHS-TeamFabulous/MMP2b","description":"Our MMP2b Project for the 4th term at FH-Salzburg","fork":false,"url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b","forks_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/forks","keys_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/teams","hooks_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/hooks","issue_events_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues/events{/number}","events_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/events","assignees_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/assignees{/user}","branches_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/branches{/branch}","tags_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/tags","blobs_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/refs{/sha}","trees_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/statuses/{sha}","languages_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/languages","stargazers_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/stargazers","contributors_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/contributors","subscribers_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/subscribers","subscription_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/subscription","commits_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/commits{/sha}","git_commits_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/git/commits{/sha}","comments_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/comments{/number}","issue_comment_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues/comments{/number}","contents_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/contents/{+path}","compare_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/merges","archive_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/downloads","issues_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues{/number}","pulls_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls{/number}","milestones_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/milestones{/number}","notifications_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/labels{/name}","releases_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/releases{/id}","deployments_url":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/deployments","created_at":"2017-04-18T21:30:56Z","updated_at":"2017-04-23T11:42:33Z","pushed_at":"2017-04-24T15:10:36Z","git_url":"git://github.com/FHS-TeamFabulous/MMP2b.git","ssh_url":"[email protected]:FHS-TeamFabulous/MMP2b.git","clone_url":"https://github.com/FHS-TeamFabulous/MMP2b.git","svn_url":"https://github.com/FHS-TeamFabulous/MMP2b","homepage":null,"size":254,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/6"},"html":{"href":"https://github.com/FHS-TeamFabulous/MMP2b/pull/6"},"issue":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues/6"},"comments":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/FHS-TeamFabulous/MMP2b/statuses/2cf4d7823fb66373b31c8bcff0d47bc082eaef3a"}}}} | {
"id": 88672332,
"name": "FHS-TeamFabulous/MMP2b",
"url": "https://api.github.com/repos/FHS-TeamFabulous/MMP2b"
} | {
"id": 1698331,
"login": "3rfan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1698331?",
"url": "https://api.github.com/users/3rfan"
} | {
"id": 27743573,
"login": "FHS-TeamFabulous",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27743573?",
"url": "https://api.github.com/orgs/FHS-TeamFabulous"
} | 2017-04-24T16:45:53 | 5745560170 | {"actor":{"display_login":"3rfan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/comments/98102629","pull_request_review_id":18732515,"id":98102629,"diff_hunk":"@@ -0,0 +1,54 @@\n+package io.intrepid.contest.screens.entrysubmission.entryimage;\n+\n+import android.graphics.Bitmap;\n+import android.support.annotation.NonNull;\n+\n+import io.intrepid.contest.base.BasePresenter;\n+import io.intrepid.contest.base.PresenterConfiguration;\n+import timber.log.Timber;\n+\n+import static io.intrepid.contest.screens.entrysubmission.entryimage.EntryImageContract.Presenter;\n+import static io.intrepid.contest.screens.entrysubmission.entryimage.EntryImageContract.View;\n+\n+public class EntryImagePresenter extends BasePresenter<View> implements Presenter {","path":"app/src/main/java/io/intrepid/contest/screens/entrysubmission/entryimage/EntryImagePresenter.java","position":13,"original_position":13,"commit_id":"81f848a5d6f8ee076ca177cbcfed860410e4c2c0","original_commit_id":"81f848a5d6f8ee076ca177cbcfed860410e4c2c0","user":{"login":"jmccormack200","id":5806468,"avatar_url":"https://avatars.githubusercontent.com/u/5806468?v=3","gravatar_id":"","url":"https://api.github.com/users/jmccormack200","html_url":"https://github.com/jmccormack200","followers_url":"https://api.github.com/users/jmccormack200/followers","following_url":"https://api.github.com/users/jmccormack200/following{/other_user}","gists_url":"https://api.github.com/users/jmccormack200/gists{/gist_id}","starred_url":"https://api.github.com/users/jmccormack200/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmccormack200/subscriptions","organizations_url":"https://api.github.com/users/jmccormack200/orgs","repos_url":"https://api.github.com/users/jmccormack200/repos","events_url":"https://api.github.com/users/jmccormack200/events{/privacy}","received_events_url":"https://api.github.com/users/jmccormack200/received_events","type":"User","site_admin":false},"body":"I think this can be package local","created_at":"2017-01-26T22:02:50Z","updated_at":"2017-01-26T22:12:37Z","html_url":"https://github.com/IntrepidPursuits/ContestAndroid/pull/7#discussion_r98102629","pull_request_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/comments/98102629"},"html":{"href":"https://github.com/IntrepidPursuits/ContestAndroid/pull/7#discussion_r98102629"},"pull_request":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/7","id":103394351,"html_url":"https://github.com/IntrepidPursuits/ContestAndroid/pull/7","diff_url":"https://github.com/IntrepidPursuits/ContestAndroid/pull/7.diff","patch_url":"https://github.com/IntrepidPursuits/ContestAndroid/pull/7.patch","issue_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues/7","number":7,"state":"open","locked":false,"title":"Add screen to add an image to the entry","user":{"login":"gsintrepid","id":22322113,"avatar_url":"https://avatars.githubusercontent.com/u/22322113?v=3","gravatar_id":"","url":"https://api.github.com/users/gsintrepid","html_url":"https://github.com/gsintrepid","followers_url":"https://api.github.com/users/gsintrepid/followers","following_url":"https://api.github.com/users/gsintrepid/following{/other_user}","gists_url":"https://api.github.com/users/gsintrepid/gists{/gist_id}","starred_url":"https://api.github.com/users/gsintrepid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsintrepid/subscriptions","organizations_url":"https://api.github.com/users/gsintrepid/orgs","repos_url":"https://api.github.com/users/gsintrepid/repos","events_url":"https://api.github.com/users/gsintrepid/events{/privacy}","received_events_url":"https://api.github.com/users/gsintrepid/received_events","type":"User","site_admin":false},"body":"- Lacking look-and-feel\r\n- Lacking tests","created_at":"2017-01-26T21:36:01Z","updated_at":"2017-01-26T22:12:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2c55b5d5b3ac2e883c7b9a6608a3491ff3f095d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/7/commits","review_comments_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/7/comments","review_comment_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues/7/comments","statuses_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/statuses/81f848a5d6f8ee076ca177cbcfed860410e4c2c0","head":{"label":"IntrepidPursuits:gabi/entryimage","ref":"gabi/entryimage","sha":"81f848a5d6f8ee076ca177cbcfed860410e4c2c0","user":{"login":"IntrepidPursuits","id":2151424,"avatar_url":"https://avatars.githubusercontent.com/u/2151424?v=3","gravatar_id":"","url":"https://api.github.com/users/IntrepidPursuits","html_url":"https://github.com/IntrepidPursuits","followers_url":"https://api.github.com/users/IntrepidPursuits/followers","following_url":"https://api.github.com/users/IntrepidPursuits/following{/other_user}","gists_url":"https://api.github.com/users/IntrepidPursuits/gists{/gist_id}","starred_url":"https://api.github.com/users/IntrepidPursuits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntrepidPursuits/subscriptions","organizations_url":"https://api.github.com/users/IntrepidPursuits/orgs","repos_url":"https://api.github.com/users/IntrepidPursuits/repos","events_url":"https://api.github.com/users/IntrepidPursuits/events{/privacy}","received_events_url":"https://api.github.com/users/IntrepidPursuits/received_events","type":"Organization","site_admin":false},"repo":{"id":79815220,"name":"ContestAndroid","full_name":"IntrepidPursuits/ContestAndroid","owner":{"login":"IntrepidPursuits","id":2151424,"avatar_url":"https://avatars.githubusercontent.com/u/2151424?v=3","gravatar_id":"","url":"https://api.github.com/users/IntrepidPursuits","html_url":"https://github.com/IntrepidPursuits","followers_url":"https://api.github.com/users/IntrepidPursuits/followers","following_url":"https://api.github.com/users/IntrepidPursuits/following{/other_user}","gists_url":"https://api.github.com/users/IntrepidPursuits/gists{/gist_id}","starred_url":"https://api.github.com/users/IntrepidPursuits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntrepidPursuits/subscriptions","organizations_url":"https://api.github.com/users/IntrepidPursuits/orgs","repos_url":"https://api.github.com/users/IntrepidPursuits/repos","events_url":"https://api.github.com/users/IntrepidPursuits/events{/privacy}","received_events_url":"https://api.github.com/users/IntrepidPursuits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IntrepidPursuits/ContestAndroid","description":null,"fork":false,"url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid","forks_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/forks","keys_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/teams","hooks_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/hooks","issue_events_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues/events{/number}","events_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/events","assignees_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/assignees{/user}","branches_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/branches{/branch}","tags_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/tags","blobs_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/statuses/{sha}","languages_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/languages","stargazers_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/stargazers","contributors_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/contributors","subscribers_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/subscribers","subscription_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/subscription","commits_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/contents/{+path}","compare_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/merges","archive_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/downloads","issues_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues{/number}","pulls_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls{/number}","milestones_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/milestones{/number}","notifications_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/labels{/name}","releases_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/releases{/id}","deployments_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/deployments","created_at":"2017-01-23T15:07:23Z","updated_at":"2017-01-23T16:44:50Z","pushed_at":"2017-01-26T22:03:08Z","git_url":"git://github.com/IntrepidPursuits/ContestAndroid.git","ssh_url":"[email protected]:IntrepidPursuits/ContestAndroid.git","clone_url":"https://github.com/IntrepidPursuits/ContestAndroid.git","svn_url":"https://github.com/IntrepidPursuits/ContestAndroid","homepage":null,"size":17455,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"IntrepidPursuits:master","ref":"master","sha":"08f584bbedc06e31b3d968a3a02c35ee58a540a7","user":{"login":"IntrepidPursuits","id":2151424,"avatar_url":"https://avatars.githubusercontent.com/u/2151424?v=3","gravatar_id":"","url":"https://api.github.com/users/IntrepidPursuits","html_url":"https://github.com/IntrepidPursuits","followers_url":"https://api.github.com/users/IntrepidPursuits/followers","following_url":"https://api.github.com/users/IntrepidPursuits/following{/other_user}","gists_url":"https://api.github.com/users/IntrepidPursuits/gists{/gist_id}","starred_url":"https://api.github.com/users/IntrepidPursuits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntrepidPursuits/subscriptions","organizations_url":"https://api.github.com/users/IntrepidPursuits/orgs","repos_url":"https://api.github.com/users/IntrepidPursuits/repos","events_url":"https://api.github.com/users/IntrepidPursuits/events{/privacy}","received_events_url":"https://api.github.com/users/IntrepidPursuits/received_events","type":"Organization","site_admin":false},"repo":{"id":79815220,"name":"ContestAndroid","full_name":"IntrepidPursuits/ContestAndroid","owner":{"login":"IntrepidPursuits","id":2151424,"avatar_url":"https://avatars.githubusercontent.com/u/2151424?v=3","gravatar_id":"","url":"https://api.github.com/users/IntrepidPursuits","html_url":"https://github.com/IntrepidPursuits","followers_url":"https://api.github.com/users/IntrepidPursuits/followers","following_url":"https://api.github.com/users/IntrepidPursuits/following{/other_user}","gists_url":"https://api.github.com/users/IntrepidPursuits/gists{/gist_id}","starred_url":"https://api.github.com/users/IntrepidPursuits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntrepidPursuits/subscriptions","organizations_url":"https://api.github.com/users/IntrepidPursuits/orgs","repos_url":"https://api.github.com/users/IntrepidPursuits/repos","events_url":"https://api.github.com/users/IntrepidPursuits/events{/privacy}","received_events_url":"https://api.github.com/users/IntrepidPursuits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IntrepidPursuits/ContestAndroid","description":null,"fork":false,"url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid","forks_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/forks","keys_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/teams","hooks_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/hooks","issue_events_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues/events{/number}","events_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/events","assignees_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/assignees{/user}","branches_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/branches{/branch}","tags_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/tags","blobs_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/statuses/{sha}","languages_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/languages","stargazers_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/stargazers","contributors_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/contributors","subscribers_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/subscribers","subscription_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/subscription","commits_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/contents/{+path}","compare_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/merges","archive_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/downloads","issues_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues{/number}","pulls_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls{/number}","milestones_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/milestones{/number}","notifications_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/labels{/name}","releases_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/releases{/id}","deployments_url":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/deployments","created_at":"2017-01-23T15:07:23Z","updated_at":"2017-01-23T16:44:50Z","pushed_at":"2017-01-26T22:03:08Z","git_url":"git://github.com/IntrepidPursuits/ContestAndroid.git","ssh_url":"[email protected]:IntrepidPursuits/ContestAndroid.git","clone_url":"https://github.com/IntrepidPursuits/ContestAndroid.git","svn_url":"https://github.com/IntrepidPursuits/ContestAndroid","homepage":null,"size":17455,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/7"},"html":{"href":"https://github.com/IntrepidPursuits/ContestAndroid/pull/7"},"issue":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues/7"},"comments":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/IntrepidPursuits/ContestAndroid/statuses/81f848a5d6f8ee076ca177cbcfed860410e4c2c0"}}}} | {
"id": 79815220,
"name": "IntrepidPursuits/ContestAndroid",
"url": "https://api.github.com/repos/IntrepidPursuits/ContestAndroid"
} | {
"id": 5806468,
"login": "jmccormack200",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5806468?",
"url": "https://api.github.com/users/jmccormack200"
} | {
"id": 2151424,
"login": "IntrepidPursuits",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2151424?",
"url": "https://api.github.com/orgs/IntrepidPursuits"
} | 2017-01-26T22:02:50 | 5220558989 | {"actor":{"display_login":"jmccormack200"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/comments/112078378","pull_request_review_id":33364480,"id":112078378,"diff_hunk":"@@ -169,11 +181,24 @@ public void deleteSurveyPermanently(StudyIdentifier studyId, GuidCreatedOnVersio\n checkArgument(StringUtils.isNotBlank(keys.getGuid()), \"Survey GUID cannot be null/blank\");\n checkArgument(keys.getCreatedOn() != 0L, \"Survey createdOn timestamp cannot be 0\");\n \n+ // verify shared module existence as well\n+ verifySharedModuleExistence(keys);\n+","path":"app/org/sagebionetworks/bridge/services/SurveyService.java","position":59,"original_position":59,"commit_id":"94e28cd4205d44a6931376b6e032a8e6c56f95d0","original_commit_id":"94e28cd4205d44a6931376b6e032a8e6c56f95d0","user":{"login":"DwayneJengSage","id":9541190,"avatar_url":"https://avatars3.githubusercontent.com/u/9541190?v=3","gravatar_id":"","url":"https://api.github.com/users/DwayneJengSage","html_url":"https://github.com/DwayneJengSage","followers_url":"https://api.github.com/users/DwayneJengSage/followers","following_url":"https://api.github.com/users/DwayneJengSage/following{/other_user}","gists_url":"https://api.github.com/users/DwayneJengSage/gists{/gist_id}","starred_url":"https://api.github.com/users/DwayneJengSage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DwayneJengSage/subscriptions","organizations_url":"https://api.github.com/users/DwayneJengSage/orgs","repos_url":"https://api.github.com/users/DwayneJengSage/repos","events_url":"https://api.github.com/users/DwayneJengSage/events{/privacy}","received_events_url":"https://api.github.com/users/DwayneJengSage/received_events","type":"User","site_admin":false},"body":"I think you misunderstood. I was suggesting moving it *into* checkConstraintsBeforePhysicalDelete(), not change the order.","created_at":"2017-04-18T22:21:23Z","updated_at":"2017-04-18T22:25:25Z","html_url":"https://github.com/Sage-Bionetworks/BridgePF/pull/1425#discussion_r112078378","pull_request_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1425","_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/comments/112078378"},"html":{"href":"https://github.com/Sage-Bionetworks/BridgePF/pull/1425#discussion_r112078378"},"pull_request":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1425"}}},"pull_request":{"url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1425","id":116209035,"html_url":"https://github.com/Sage-Bionetworks/BridgePF/pull/1425","diff_url":"https://github.com/Sage-Bionetworks/BridgePF/pull/1425.diff","patch_url":"https://github.com/Sage-Bionetworks/BridgePF/pull/1425.patch","issue_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/1425","number":1425,"state":"open","locked":false,"title":"Integrity modules","user":{"login":"zaclinsage","id":22622093,"avatar_url":"https://avatars1.githubusercontent.com/u/22622093?v=3","gravatar_id":"","url":"https://api.github.com/users/zaclinsage","html_url":"https://github.com/zaclinsage","followers_url":"https://api.github.com/users/zaclinsage/followers","following_url":"https://api.github.com/users/zaclinsage/following{/other_user}","gists_url":"https://api.github.com/users/zaclinsage/gists{/gist_id}","starred_url":"https://api.github.com/users/zaclinsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaclinsage/subscriptions","organizations_url":"https://api.github.com/users/zaclinsage/orgs","repos_url":"https://api.github.com/users/zaclinsage/repos","events_url":"https://api.github.com/users/zaclinsage/events{/privacy}","received_events_url":"https://api.github.com/users/zaclinsage/received_events","type":"User","site_admin":false},"body":"#unit tests done;\r\nadded integ tests done;\r\nsee also: https://github.com/Sage-Bionetworks/BridgeIntegrationTests/pull/151","created_at":"2017-04-17T21:40:36Z","updated_at":"2017-04-18T22:25:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4cf6a60e5bdc14de3ad3aba7756d3f126443d94","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1425/commits","review_comments_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1425/comments","review_comment_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/1425/comments","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/statuses/94e28cd4205d44a6931376b6e032a8e6c56f95d0","head":{"label":"zaclinsage:integrityModules","ref":"integrityModules","sha":"94e28cd4205d44a6931376b6e032a8e6c56f95d0","user":{"login":"zaclinsage","id":22622093,"avatar_url":"https://avatars1.githubusercontent.com/u/22622093?v=3","gravatar_id":"","url":"https://api.github.com/users/zaclinsage","html_url":"https://github.com/zaclinsage","followers_url":"https://api.github.com/users/zaclinsage/followers","following_url":"https://api.github.com/users/zaclinsage/following{/other_user}","gists_url":"https://api.github.com/users/zaclinsage/gists{/gist_id}","starred_url":"https://api.github.com/users/zaclinsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaclinsage/subscriptions","organizations_url":"https://api.github.com/users/zaclinsage/orgs","repos_url":"https://api.github.com/users/zaclinsage/repos","events_url":"https://api.github.com/users/zaclinsage/events{/privacy}","received_events_url":"https://api.github.com/users/zaclinsage/received_events","type":"User","site_admin":false},"repo":{"id":70000363,"name":"BridgePF","full_name":"zaclinsage/BridgePF","owner":{"login":"zaclinsage","id":22622093,"avatar_url":"https://avatars1.githubusercontent.com/u/22622093?v=3","gravatar_id":"","url":"https://api.github.com/users/zaclinsage","html_url":"https://github.com/zaclinsage","followers_url":"https://api.github.com/users/zaclinsage/followers","following_url":"https://api.github.com/users/zaclinsage/following{/other_user}","gists_url":"https://api.github.com/users/zaclinsage/gists{/gist_id}","starred_url":"https://api.github.com/users/zaclinsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaclinsage/subscriptions","organizations_url":"https://api.github.com/users/zaclinsage/orgs","repos_url":"https://api.github.com/users/zaclinsage/repos","events_url":"https://api.github.com/users/zaclinsage/events{/privacy}","received_events_url":"https://api.github.com/users/zaclinsage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zaclinsage/BridgePF","description":"Server software for Bridge-based mobile applications","fork":true,"url":"https://api.github.com/repos/zaclinsage/BridgePF","forks_url":"https://api.github.com/repos/zaclinsage/BridgePF/forks","keys_url":"https://api.github.com/repos/zaclinsage/BridgePF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaclinsage/BridgePF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaclinsage/BridgePF/teams","hooks_url":"https://api.github.com/repos/zaclinsage/BridgePF/hooks","issue_events_url":"https://api.github.com/repos/zaclinsage/BridgePF/issues/events{/number}","events_url":"https://api.github.com/repos/zaclinsage/BridgePF/events","assignees_url":"https://api.github.com/repos/zaclinsage/BridgePF/assignees{/user}","branches_url":"https://api.github.com/repos/zaclinsage/BridgePF/branches{/branch}","tags_url":"https://api.github.com/repos/zaclinsage/BridgePF/tags","blobs_url":"https://api.github.com/repos/zaclinsage/BridgePF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaclinsage/BridgePF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaclinsage/BridgePF/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaclinsage/BridgePF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaclinsage/BridgePF/statuses/{sha}","languages_url":"https://api.github.com/repos/zaclinsage/BridgePF/languages","stargazers_url":"https://api.github.com/repos/zaclinsage/BridgePF/stargazers","contributors_url":"https://api.github.com/repos/zaclinsage/BridgePF/contributors","subscribers_url":"https://api.github.com/repos/zaclinsage/BridgePF/subscribers","subscription_url":"https://api.github.com/repos/zaclinsage/BridgePF/subscription","commits_url":"https://api.github.com/repos/zaclinsage/BridgePF/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaclinsage/BridgePF/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaclinsage/BridgePF/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaclinsage/BridgePF/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaclinsage/BridgePF/contents/{+path}","compare_url":"https://api.github.com/repos/zaclinsage/BridgePF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaclinsage/BridgePF/merges","archive_url":"https://api.github.com/repos/zaclinsage/BridgePF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaclinsage/BridgePF/downloads","issues_url":"https://api.github.com/repos/zaclinsage/BridgePF/issues{/number}","pulls_url":"https://api.github.com/repos/zaclinsage/BridgePF/pulls{/number}","milestones_url":"https://api.github.com/repos/zaclinsage/BridgePF/milestones{/number}","notifications_url":"https://api.github.com/repos/zaclinsage/BridgePF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaclinsage/BridgePF/labels{/name}","releases_url":"https://api.github.com/repos/zaclinsage/BridgePF/releases{/id}","deployments_url":"https://api.github.com/repos/zaclinsage/BridgePF/deployments","created_at":"2016-10-04T19:49:08Z","updated_at":"2016-10-04T19:49:11Z","pushed_at":"2017-04-18T17:02:41Z","git_url":"git://github.com/zaclinsage/BridgePF.git","ssh_url":"[email protected]:zaclinsage/BridgePF.git","clone_url":"https://github.com/zaclinsage/BridgePF.git","svn_url":"https://github.com/zaclinsage/BridgePF","homepage":"","size":76830,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Sage-Bionetworks:develop","ref":"develop","sha":"ab1361ef99efc8794caf9c2bfb5fb46a49e698ba","user":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars1.githubusercontent.com/u/1250897?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":18604783,"name":"BridgePF","full_name":"Sage-Bionetworks/BridgePF","owner":{"login":"Sage-Bionetworks","id":1250897,"avatar_url":"https://avatars1.githubusercontent.com/u/1250897?v=3","gravatar_id":"","url":"https://api.github.com/users/Sage-Bionetworks","html_url":"https://github.com/Sage-Bionetworks","followers_url":"https://api.github.com/users/Sage-Bionetworks/followers","following_url":"https://api.github.com/users/Sage-Bionetworks/following{/other_user}","gists_url":"https://api.github.com/users/Sage-Bionetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage-Bionetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage-Bionetworks/subscriptions","organizations_url":"https://api.github.com/users/Sage-Bionetworks/orgs","repos_url":"https://api.github.com/users/Sage-Bionetworks/repos","events_url":"https://api.github.com/users/Sage-Bionetworks/events{/privacy}","received_events_url":"https://api.github.com/users/Sage-Bionetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sage-Bionetworks/BridgePF","description":"Server software for Bridge-based mobile applications","fork":false,"url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF","forks_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/forks","keys_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/teams","hooks_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/hooks","issue_events_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/events{/number}","events_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/events","assignees_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/assignees{/user}","branches_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/branches{/branch}","tags_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/tags","blobs_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/languages","stargazers_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/stargazers","contributors_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/contributors","subscribers_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/subscribers","subscription_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/subscription","commits_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/contents/{+path}","compare_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/merges","archive_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/downloads","issues_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues{/number}","pulls_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/labels{/name}","releases_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/releases{/id}","deployments_url":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/deployments","created_at":"2014-04-09T16:38:46Z","updated_at":"2017-03-14T23:08:18Z","pushed_at":"2017-04-18T17:02:42Z","git_url":"git://github.com/Sage-Bionetworks/BridgePF.git","ssh_url":"[email protected]:Sage-Bionetworks/BridgePF.git","clone_url":"https://github.com/Sage-Bionetworks/BridgePF.git","svn_url":"https://github.com/Sage-Bionetworks/BridgePF","homepage":"","size":76777,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":6,"forks":22,"open_issues":6,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1425"},"html":{"href":"https://github.com/Sage-Bionetworks/BridgePF/pull/1425"},"issue":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/1425"},"comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/issues/1425/comments"},"review_comments":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1425/comments"},"review_comment":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/pulls/1425/commits"},"statuses":{"href":"https://api.github.com/repos/Sage-Bionetworks/BridgePF/statuses/94e28cd4205d44a6931376b6e032a8e6c56f95d0"}}}} | {
"id": 18604783,
"name": "Sage-Bionetworks/BridgePF",
"url": "https://api.github.com/repos/Sage-Bionetworks/BridgePF"
} | {
"id": 9541190,
"login": "DwayneJengSage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9541190?",
"url": "https://api.github.com/users/DwayneJengSage"
} | {
"id": 1250897,
"login": "Sage-Bionetworks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1250897?",
"url": "https://api.github.com/orgs/Sage-Bionetworks"
} | 2017-04-18T22:21:23 | 5711194934 | {"actor":{"display_login":"DwayneJengSage"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments/98452083","pull_request_review_id":19092320,"id":98452083,"diff_hunk":"@@ -0,0 +1,44 @@\n+/*\n+ * Copyright 2017, TeamDev Ltd. All rights reserved.\n+ *\n+ * Redistribution and use in source and/or binary forms, with or without\n+ * modification, must retain the above copyright notice and the following\n+ * disclaimer.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+package org.spine3.server.entity;\n+\n+import com.google.common.base.Optional;\n+\n+import javax.annotation.CheckReturnValue;\n+\n+/**\n+ * A view on a repository.","path":"server/src/main/java/org/spine3/server/entity/RepositoryView.java","position":28,"original_position":28,"commit_id":"ba1dc5c46dc0f0f4951367d80ac982bcd62619bb","original_commit_id":"a09da3ec9db006e14aef33e648d3ae921b976e4d","user":{"login":"armiol","id":82468,"avatar_url":"https://avatars.githubusercontent.com/u/82468?v=3","gravatar_id":"","url":"https://api.github.com/users/armiol","html_url":"https://github.com/armiol","followers_url":"https://api.github.com/users/armiol/followers","following_url":"https://api.github.com/users/armiol/following{/other_user}","gists_url":"https://api.github.com/users/armiol/gists{/gist_id}","starred_url":"https://api.github.com/users/armiol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armiol/subscriptions","organizations_url":"https://api.github.com/users/armiol/orgs","repos_url":"https://api.github.com/users/armiol/repos","events_url":"https://api.github.com/users/armiol/events{/privacy}","received_events_url":"https://api.github.com/users/armiol/received_events","type":"User","site_admin":false},"body":"As a part of the public API, this class needs more details and/or samples.","created_at":"2017-01-30T14:35:29Z","updated_at":"2017-01-30T14:51:14Z","html_url":"https://github.com/SpineEventEngine/core-java/pull/294#discussion_r98452083","pull_request_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments/98452083"},"html":{"href":"https://github.com/SpineEventEngine/core-java/pull/294#discussion_r98452083"},"pull_request":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/294","id":103596610,"html_url":"https://github.com/SpineEventEngine/core-java/pull/294","diff_url":"https://github.com/SpineEventEngine/core-java/pull/294.diff","patch_url":"https://github.com/SpineEventEngine/core-java/pull/294.patch","issue_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/294","number":294,"state":"open","locked":false,"title":"Archived and deleted","user":{"login":"alexander-yevsyukov","id":3116444,"avatar_url":"https://avatars.githubusercontent.com/u/3116444?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-yevsyukov","html_url":"https://github.com/alexander-yevsyukov","followers_url":"https://api.github.com/users/alexander-yevsyukov/followers","following_url":"https://api.github.com/users/alexander-yevsyukov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-yevsyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-yevsyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-yevsyukov/subscriptions","organizations_url":"https://api.github.com/users/alexander-yevsyukov/orgs","repos_url":"https://api.github.com/users/alexander-yevsyukov/repos","events_url":"https://api.github.com/users/alexander-yevsyukov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-yevsyukov/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-28T02:10:37Z","updated_at":"2017-01-30T14:51:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"598ec74285b4e1ae2724291af19a807c6b0c92ae","assignee":{"login":"alexander-yevsyukov","id":3116444,"avatar_url":"https://avatars.githubusercontent.com/u/3116444?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-yevsyukov","html_url":"https://github.com/alexander-yevsyukov","followers_url":"https://api.github.com/users/alexander-yevsyukov/followers","following_url":"https://api.github.com/users/alexander-yevsyukov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-yevsyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-yevsyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-yevsyukov/subscriptions","organizations_url":"https://api.github.com/users/alexander-yevsyukov/orgs","repos_url":"https://api.github.com/users/alexander-yevsyukov/repos","events_url":"https://api.github.com/users/alexander-yevsyukov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-yevsyukov/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexander-yevsyukov","id":3116444,"avatar_url":"https://avatars.githubusercontent.com/u/3116444?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-yevsyukov","html_url":"https://github.com/alexander-yevsyukov","followers_url":"https://api.github.com/users/alexander-yevsyukov/followers","following_url":"https://api.github.com/users/alexander-yevsyukov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-yevsyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-yevsyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-yevsyukov/subscriptions","organizations_url":"https://api.github.com/users/alexander-yevsyukov/orgs","repos_url":"https://api.github.com/users/alexander-yevsyukov/repos","events_url":"https://api.github.com/users/alexander-yevsyukov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-yevsyukov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/294/commits","review_comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/294/comments","review_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/294/comments","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/ba1dc5c46dc0f0f4951367d80ac982bcd62619bb","head":{"label":"SpineEventEngine:archived-and-deleted","ref":"archived-and-deleted","sha":"ba1dc5c46dc0f0f4951367d80ac982bcd62619bb","user":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":38311906,"name":"core-java","full_name":"SpineEventEngine/core-java","owner":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpineEventEngine/core-java","description":"The Java implementation of the framework core.","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/core-java","forks_url":"https://api.github.com/repos/SpineEventEngine/core-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/core-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/core-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/core-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/core-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/core-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/core-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/core-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/core-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/core-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/core-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/core-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/core-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/core-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/core-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/core-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/core-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/core-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/core-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/core-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/core-java/deployments","created_at":"2015-06-30T13:50:58Z","updated_at":"2016-11-11T18:52:20Z","pushed_at":"2017-01-30T14:50:43Z","git_url":"git://github.com/SpineEventEngine/core-java.git","ssh_url":"[email protected]:SpineEventEngine/core-java.git","clone_url":"https://github.com/SpineEventEngine/core-java.git","svn_url":"https://github.com/SpineEventEngine/core-java","homepage":null,"size":7474,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":2,"default_branch":"master"}},"base":{"label":"SpineEventEngine:master","ref":"master","sha":"5aa2acbb7b865fba0109457af4d44ba65887c222","user":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":38311906,"name":"core-java","full_name":"SpineEventEngine/core-java","owner":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpineEventEngine/core-java","description":"The Java implementation of the framework core.","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/core-java","forks_url":"https://api.github.com/repos/SpineEventEngine/core-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/core-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/core-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/core-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/core-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/core-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/core-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/core-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/core-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/core-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/core-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/core-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/core-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/core-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/core-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/core-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/core-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/core-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/core-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/core-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/core-java/deployments","created_at":"2015-06-30T13:50:58Z","updated_at":"2016-11-11T18:52:20Z","pushed_at":"2017-01-30T14:50:43Z","git_url":"git://github.com/SpineEventEngine/core-java.git","ssh_url":"[email protected]:SpineEventEngine/core-java.git","clone_url":"https://github.com/SpineEventEngine/core-java.git","svn_url":"https://github.com/SpineEventEngine/core-java","homepage":null,"size":7474,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/294"},"html":{"href":"https://github.com/SpineEventEngine/core-java/pull/294"},"issue":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/issues/294"},"comments":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/ba1dc5c46dc0f0f4951367d80ac982bcd62619bb"}}}} | {
"id": 38311906,
"name": "SpineEventEngine/core-java",
"url": "https://api.github.com/repos/SpineEventEngine/core-java"
} | {
"id": 82468,
"login": "armiol",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/82468?",
"url": "https://api.github.com/users/armiol"
} | {
"id": 12821626,
"login": "SpineEventEngine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12821626?",
"url": "https://api.github.com/orgs/SpineEventEngine"
} | 2017-01-30T14:35:29 | 5234101600 | {"actor":{"display_login":"armiol"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/comments/95765864","pull_request_review_id":16330317,"id":95765864,"diff_hunk":"@@ -34,20 +38,21 @@ allow vnstatd_t self:process signal;\n allow vnstatd_t self:fifo_file rw_fifo_file_perms;\n allow vnstatd_t self:unix_stream_socket { accept listen };\n \n+manage_dirs_pattern(vnstatd_t, vnstatd_runtime_t, vnstatd_runtime_t)\n+manage_files_pattern(vnstatd_t, vnstatd_runtime_t, vnstatd_runtime_t)\n+files_pid_filetrans(vnstatd_t, vnstatd_runtime_t, { dir file })\n+\n manage_dirs_pattern(vnstatd_t, vnstatd_var_lib_t, vnstatd_var_lib_t)\n manage_files_pattern(vnstatd_t, vnstatd_var_lib_t, vnstatd_var_lib_t)\n-files_var_lib_filetrans(vnstatd_t, vnstatd_var_lib_t, { dir file })","path":"vnstatd.te","position":30,"original_position":30,"commit_id":"8f8a35761d5860b81a601f74bea33b6b7851ca4e","original_commit_id":"8f8a35761d5860b81a601f74bea33b6b7851ca4e","user":{"login":"cgzones","id":6131885,"avatar_url":"https://avatars.githubusercontent.com/u/6131885?v=3","gravatar_id":"","url":"https://api.github.com/users/cgzones","html_url":"https://github.com/cgzones","followers_url":"https://api.github.com/users/cgzones/followers","following_url":"https://api.github.com/users/cgzones/following{/other_user}","gists_url":"https://api.github.com/users/cgzones/gists{/gist_id}","starred_url":"https://api.github.com/users/cgzones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgzones/subscriptions","organizations_url":"https://api.github.com/users/cgzones/orgs","repos_url":"https://api.github.com/users/cgzones/repos","events_url":"https://api.github.com/users/cgzones/events{/privacy}","received_events_url":"https://api.github.com/users/cgzones/received_events","type":"User","site_admin":false},"body":"From my point of view programs should not be able to create directories/files in /var/lib.\r\nThese should be created by the package-manager or the installations script.","created_at":"2017-01-12T10:47:42Z","updated_at":"2017-01-12T10:47:42Z","html_url":"https://github.com/TresysTechnology/refpolicy-contrib/pull/32#discussion_r95765864","pull_request_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/comments/95765864"},"html":{"href":"https://github.com/TresysTechnology/refpolicy-contrib/pull/32#discussion_r95765864"},"pull_request":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/32","id":100342771,"html_url":"https://github.com/TresysTechnology/refpolicy-contrib/pull/32","diff_url":"https://github.com/TresysTechnology/refpolicy-contrib/pull/32.diff","patch_url":"https://github.com/TresysTechnology/refpolicy-contrib/pull/32.patch","issue_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/issues/32","number":32,"state":"open","locked":false,"title":"update vnstatd module","user":{"login":"cgzones","id":6131885,"avatar_url":"https://avatars.githubusercontent.com/u/6131885?v=3","gravatar_id":"","url":"https://api.github.com/users/cgzones","html_url":"https://github.com/cgzones","followers_url":"https://api.github.com/users/cgzones/followers","following_url":"https://api.github.com/users/cgzones/following{/other_user}","gists_url":"https://api.github.com/users/cgzones/gists{/gist_id}","starred_url":"https://api.github.com/users/cgzones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgzones/subscriptions","organizations_url":"https://api.github.com/users/cgzones/orgs","repos_url":"https://api.github.com/users/cgzones/repos","events_url":"https://api.github.com/users/cgzones/events{/privacy}","received_events_url":"https://api.github.com/users/cgzones/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-05T18:49:43Z","updated_at":"2017-01-12T10:47:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3a797537bd145f62d721797586456d1f165aede","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/32/commits","review_comments_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/32/comments","review_comment_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/issues/32/comments","statuses_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/statuses/8f8a35761d5860b81a601f74bea33b6b7851ca4e","head":{"label":"cgzones:vnstat_module","ref":"vnstat_module","sha":"8f8a35761d5860b81a601f74bea33b6b7851ca4e","user":{"login":"cgzones","id":6131885,"avatar_url":"https://avatars.githubusercontent.com/u/6131885?v=3","gravatar_id":"","url":"https://api.github.com/users/cgzones","html_url":"https://github.com/cgzones","followers_url":"https://api.github.com/users/cgzones/followers","following_url":"https://api.github.com/users/cgzones/following{/other_user}","gists_url":"https://api.github.com/users/cgzones/gists{/gist_id}","starred_url":"https://api.github.com/users/cgzones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgzones/subscriptions","organizations_url":"https://api.github.com/users/cgzones/orgs","repos_url":"https://api.github.com/users/cgzones/repos","events_url":"https://api.github.com/users/cgzones/events{/privacy}","received_events_url":"https://api.github.com/users/cgzones/received_events","type":"User","site_admin":false},"repo":{"id":75322082,"name":"refpolicy-contrib","full_name":"cgzones/refpolicy-contrib","owner":{"login":"cgzones","id":6131885,"avatar_url":"https://avatars.githubusercontent.com/u/6131885?v=3","gravatar_id":"","url":"https://api.github.com/users/cgzones","html_url":"https://github.com/cgzones","followers_url":"https://api.github.com/users/cgzones/followers","following_url":"https://api.github.com/users/cgzones/following{/other_user}","gists_url":"https://api.github.com/users/cgzones/gists{/gist_id}","starred_url":"https://api.github.com/users/cgzones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgzones/subscriptions","organizations_url":"https://api.github.com/users/cgzones/orgs","repos_url":"https://api.github.com/users/cgzones/repos","events_url":"https://api.github.com/users/cgzones/events{/privacy}","received_events_url":"https://api.github.com/users/cgzones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgzones/refpolicy-contrib","description":"SELinux Reference Policy Contributions Submodule","fork":true,"url":"https://api.github.com/repos/cgzones/refpolicy-contrib","forks_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/forks","keys_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/teams","hooks_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/hooks","issue_events_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/events","assignees_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/tags","blobs_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/languages","stargazers_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/stargazers","contributors_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/contributors","subscribers_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/subscribers","subscription_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/subscription","commits_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/merges","archive_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/downloads","issues_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/labels{/name}","releases_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/cgzones/refpolicy-contrib/deployments","created_at":"2016-12-01T18:46:52Z","updated_at":"2016-10-23T21:08:59Z","pushed_at":"2017-01-12T10:36:53Z","git_url":"git://github.com/cgzones/refpolicy-contrib.git","ssh_url":"[email protected]:cgzones/refpolicy-contrib.git","clone_url":"https://github.com/cgzones/refpolicy-contrib.git","svn_url":"https://github.com/cgzones/refpolicy-contrib","homepage":"https://github.com/TresysTechnology/refpolicy/wiki","size":2753,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TresysTechnology:master","ref":"master","sha":"ffa3d2fb0b8db0c7c14ff4b3e8322b75dfab88fd","user":{"login":"TresysTechnology","id":7213995,"avatar_url":"https://avatars.githubusercontent.com/u/7213995?v=3","gravatar_id":"","url":"https://api.github.com/users/TresysTechnology","html_url":"https://github.com/TresysTechnology","followers_url":"https://api.github.com/users/TresysTechnology/followers","following_url":"https://api.github.com/users/TresysTechnology/following{/other_user}","gists_url":"https://api.github.com/users/TresysTechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/TresysTechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TresysTechnology/subscriptions","organizations_url":"https://api.github.com/users/TresysTechnology/orgs","repos_url":"https://api.github.com/users/TresysTechnology/repos","events_url":"https://api.github.com/users/TresysTechnology/events{/privacy}","received_events_url":"https://api.github.com/users/TresysTechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":20223934,"name":"refpolicy-contrib","full_name":"TresysTechnology/refpolicy-contrib","owner":{"login":"TresysTechnology","id":7213995,"avatar_url":"https://avatars.githubusercontent.com/u/7213995?v=3","gravatar_id":"","url":"https://api.github.com/users/TresysTechnology","html_url":"https://github.com/TresysTechnology","followers_url":"https://api.github.com/users/TresysTechnology/followers","following_url":"https://api.github.com/users/TresysTechnology/following{/other_user}","gists_url":"https://api.github.com/users/TresysTechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/TresysTechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TresysTechnology/subscriptions","organizations_url":"https://api.github.com/users/TresysTechnology/orgs","repos_url":"https://api.github.com/users/TresysTechnology/repos","events_url":"https://api.github.com/users/TresysTechnology/events{/privacy}","received_events_url":"https://api.github.com/users/TresysTechnology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TresysTechnology/refpolicy-contrib","description":"SELinux Reference Policy Contributions Submodule","fork":false,"url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib","forks_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/forks","keys_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/teams","hooks_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/hooks","issue_events_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/events","assignees_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/tags","blobs_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/languages","stargazers_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/stargazers","contributors_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/contributors","subscribers_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/subscribers","subscription_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/subscription","commits_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/merges","archive_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/downloads","issues_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/labels{/name}","releases_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/deployments","created_at":"2014-05-27T14:56:49Z","updated_at":"2016-12-06T07:26:43Z","pushed_at":"2017-01-12T10:36:55Z","git_url":"git://github.com/TresysTechnology/refpolicy-contrib.git","ssh_url":"[email protected]:TresysTechnology/refpolicy-contrib.git","clone_url":"https://github.com/TresysTechnology/refpolicy-contrib.git","svn_url":"https://github.com/TresysTechnology/refpolicy-contrib","homepage":"https://github.com/TresysTechnology/refpolicy/wiki","size":2801,"stargazers_count":14,"watchers_count":14,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":11,"forks":21,"open_issues":11,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/32"},"html":{"href":"https://github.com/TresysTechnology/refpolicy-contrib/pull/32"},"issue":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/issues/32"},"comments":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/TresysTechnology/refpolicy-contrib/statuses/8f8a35761d5860b81a601f74bea33b6b7851ca4e"}}}} | {
"id": 20223934,
"name": "TresysTechnology/refpolicy-contrib",
"url": "https://api.github.com/repos/TresysTechnology/refpolicy-contrib"
} | {
"id": 6131885,
"login": "cgzones",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6131885?",
"url": "https://api.github.com/users/cgzones"
} | {
"id": 7213995,
"login": "TresysTechnology",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7213995?",
"url": "https://api.github.com/orgs/TresysTechnology"
} | 2017-01-12T10:47:42 | 5141720561 | {"actor":{"display_login":"cgzones"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/106275767","pull_request_review_id":27190908,"id":106275767,"diff_hunk":"@@ -19,6 +18,7 @@ $cc-color-button-regular: #e5e5e5;\n $cc-color-button-selected: #949494;\n $cc-color-black: #000;\n $cc-color-blue-dark: #002f58;\n+$cc-color-blue-grey: #8098a5;","path":"src/assets/stylesheets/colors.scss","position":12,"original_position":12,"commit_id":"6035c0c2c0e1aaedfb95e2412493dbadca5222a5","original_commit_id":"6035c0c2c0e1aaedfb95e2412493dbadca5222a5","user":{"login":"lyttam","id":12432859,"avatar_url":"https://avatars2.githubusercontent.com/u/12432859?v=3","gravatar_id":"","url":"https://api.github.com/users/lyttam","html_url":"https://github.com/lyttam","followers_url":"https://api.github.com/users/lyttam/followers","following_url":"https://api.github.com/users/lyttam/following{/other_user}","gists_url":"https://api.github.com/users/lyttam/gists{/gist_id}","starred_url":"https://api.github.com/users/lyttam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyttam/subscriptions","organizations_url":"https://api.github.com/users/lyttam/orgs","repos_url":"https://api.github.com/users/lyttam/repos","events_url":"https://api.github.com/users/lyttam/events{/privacy}","received_events_url":"https://api.github.com/users/lyttam/received_events","type":"User","site_admin":false},"body":"@davidlimcheng I made the color variable name more generic to avoid repetition.","created_at":"2017-03-15T20:34:57Z","updated_at":"2017-03-15T20:34:58Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6503#discussion_r106275767","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6503","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/106275767"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/6503#discussion_r106275767"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6503"}}},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6503","id":110745109,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6503","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6503.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6503.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6503","number":6503,"state":"open","locked":false,"title":"SISRP-30634 - Adds 'In Progress' icon on UGRD Degree Progress","user":{"login":"lyttam","id":12432859,"avatar_url":"https://avatars2.githubusercontent.com/u/12432859?v=3","gravatar_id":"","url":"https://api.github.com/users/lyttam","html_url":"https://github.com/lyttam","followers_url":"https://api.github.com/users/lyttam/followers","following_url":"https://api.github.com/users/lyttam/following{/other_user}","gists_url":"https://api.github.com/users/lyttam/gists{/gist_id}","starred_url":"https://api.github.com/users/lyttam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyttam/subscriptions","organizations_url":"https://api.github.com/users/lyttam/orgs","repos_url":"https://api.github.com/users/lyttam/repos","events_url":"https://api.github.com/users/lyttam/events{/privacy}","received_events_url":"https://api.github.com/users/lyttam/received_events","type":"User","site_admin":false},"body":"Parent: https://jira.berkeley.edu/browse/SISRP-25357\r\n\r\nAdds a new type of icon on the Undergrad Degree Progress card to indicate the new 'In Progress' status. (https://jira.berkeley.edu/browse/SISRP-30634)","created_at":"2017-03-15T00:15:17Z","updated_at":"2017-03-15T20:34:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdca7e93cbae6198873b2a4df1687e94c0366e3a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6503/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6503/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6503/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/6035c0c2c0e1aaedfb95e2412493dbadca5222a5","head":{"label":"lyttam:SISRP-25357","ref":"SISRP-25357","sha":"6035c0c2c0e1aaedfb95e2412493dbadca5222a5","user":{"login":"lyttam","id":12432859,"avatar_url":"https://avatars2.githubusercontent.com/u/12432859?v=3","gravatar_id":"","url":"https://api.github.com/users/lyttam","html_url":"https://github.com/lyttam","followers_url":"https://api.github.com/users/lyttam/followers","following_url":"https://api.github.com/users/lyttam/following{/other_user}","gists_url":"https://api.github.com/users/lyttam/gists{/gist_id}","starred_url":"https://api.github.com/users/lyttam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyttam/subscriptions","organizations_url":"https://api.github.com/users/lyttam/orgs","repos_url":"https://api.github.com/users/lyttam/repos","events_url":"https://api.github.com/users/lyttam/events{/privacy}","received_events_url":"https://api.github.com/users/lyttam/received_events","type":"User","site_admin":false},"repo":{"id":66117337,"name":"calcentral","full_name":"lyttam/calcentral","owner":{"login":"lyttam","id":12432859,"avatar_url":"https://avatars2.githubusercontent.com/u/12432859?v=3","gravatar_id":"","url":"https://api.github.com/users/lyttam","html_url":"https://github.com/lyttam","followers_url":"https://api.github.com/users/lyttam/followers","following_url":"https://api.github.com/users/lyttam/following{/other_user}","gists_url":"https://api.github.com/users/lyttam/gists{/gist_id}","starred_url":"https://api.github.com/users/lyttam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyttam/subscriptions","organizations_url":"https://api.github.com/users/lyttam/orgs","repos_url":"https://api.github.com/users/lyttam/repos","events_url":"https://api.github.com/users/lyttam/events{/privacy}","received_events_url":"https://api.github.com/users/lyttam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lyttam/calcentral","description":null,"fork":true,"url":"https://api.github.com/repos/lyttam/calcentral","forks_url":"https://api.github.com/repos/lyttam/calcentral/forks","keys_url":"https://api.github.com/repos/lyttam/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyttam/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyttam/calcentral/teams","hooks_url":"https://api.github.com/repos/lyttam/calcentral/hooks","issue_events_url":"https://api.github.com/repos/lyttam/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/lyttam/calcentral/events","assignees_url":"https://api.github.com/repos/lyttam/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/lyttam/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/lyttam/calcentral/tags","blobs_url":"https://api.github.com/repos/lyttam/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyttam/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyttam/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyttam/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyttam/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/lyttam/calcentral/languages","stargazers_url":"https://api.github.com/repos/lyttam/calcentral/stargazers","contributors_url":"https://api.github.com/repos/lyttam/calcentral/contributors","subscribers_url":"https://api.github.com/repos/lyttam/calcentral/subscribers","subscription_url":"https://api.github.com/repos/lyttam/calcentral/subscription","commits_url":"https://api.github.com/repos/lyttam/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyttam/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyttam/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyttam/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyttam/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/lyttam/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyttam/calcentral/merges","archive_url":"https://api.github.com/repos/lyttam/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyttam/calcentral/downloads","issues_url":"https://api.github.com/repos/lyttam/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/lyttam/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/lyttam/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/lyttam/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyttam/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/lyttam/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/lyttam/calcentral/deployments","created_at":"2016-08-19T23:03:32Z","updated_at":"2016-08-19T23:06:48Z","pushed_at":"2017-03-15T20:30:00Z","git_url":"git://github.com/lyttam/calcentral.git","ssh_url":"[email protected]:lyttam/calcentral.git","clone_url":"https://github.com/lyttam/calcentral.git","svn_url":"https://github.com/lyttam/calcentral","homepage":"https://calcentral.berkeley.edu","size":28246,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"e14d07912d8027ff51908990d259a7853ebc4a18","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars2.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars2.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":null,"fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/deployments","created_at":"2012-08-20T16:45:39Z","updated_at":"2017-03-02T05:02:13Z","pushed_at":"2017-03-15T20:30:01Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"[email protected]:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":28401,"stargazers_count":68,"watchers_count":68,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":2,"forks":65,"open_issues":2,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6503"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/6503"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6503"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6503/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6503/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6503/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/6035c0c2c0e1aaedfb95e2412493dbadca5222a5"}}}} | {
"id": 5483921,
"name": "ets-berkeley-edu/calcentral",
"url": "https://api.github.com/repos/ets-berkeley-edu/calcentral"
} | {
"id": 12432859,
"login": "lyttam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12432859?",
"url": "https://api.github.com/users/lyttam"
} | {
"id": 283538,
"login": "ets-berkeley-edu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/283538?",
"url": "https://api.github.com/orgs/ets-berkeley-edu"
} | 2017-03-15T20:34:57 | 5501334875 | {"actor":{"display_login":"lyttam"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/130410022","pull_request_review_id":53283018,"id":130410022,"diff_hunk":"@@ -50,6 +51,7 @@ class Terms\n attr_reader :campus\n \n def self.fetch(options = {})\n+ oldest =","path":"app/models/berkeley/terms.rb","position":null,"original_position":12,"commit_id":"e0171e97e74c7adcd5cb70c510e9ec420418275b","original_commit_id":"bc5220f1c3075fb2233d2ad87c4ddc27c625649c","user":{"login":"nkutub","id":20545717,"avatar_url":"https://avatars0.githubusercontent.com/u/20545717?v=4","gravatar_id":"","url":"https://api.github.com/users/nkutub","html_url":"https://github.com/nkutub","followers_url":"https://api.github.com/users/nkutub/followers","following_url":"https://api.github.com/users/nkutub/following{/other_user}","gists_url":"https://api.github.com/users/nkutub/gists{/gist_id}","starred_url":"https://api.github.com/users/nkutub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkutub/subscriptions","organizations_url":"https://api.github.com/users/nkutub/orgs","repos_url":"https://api.github.com/users/nkutub/repos","events_url":"https://api.github.com/users/nkutub/events{/privacy}","received_events_url":"https://api.github.com/users/nkutub/received_events","type":"User","site_admin":false},"body":"yup, @raydavis , fixed ","created_at":"2017-07-31T17:38:26Z","updated_at":"2017-07-31T17:38:26Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6777#discussion_r130410022","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6777","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/130410022"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/6777#discussion_r130410022"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6777"}}},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6777","id":133289249,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6777","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6777.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/6777.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6777","number":6777,"state":"open","locked":false,"title":"SISRP-32435 - Update SOR to CS- Pre-Spring 2010 Data is Missing","user":{"login":"nkutub","id":20545717,"avatar_url":"https://avatars0.githubusercontent.com/u/20545717?v=4","gravatar_id":"","url":"https://api.github.com/users/nkutub","html_url":"https://github.com/nkutub","followers_url":"https://api.github.com/users/nkutub/followers","following_url":"https://api.github.com/users/nkutub/following{/other_user}","gists_url":"https://api.github.com/users/nkutub/gists{/gist_id}","starred_url":"https://api.github.com/users/nkutub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkutub/subscriptions","organizations_url":"https://api.github.com/users/nkutub/orgs","repos_url":"https://api.github.com/users/nkutub/repos","events_url":"https://api.github.com/users/nkutub/events{/privacy}","received_events_url":"https://api.github.com/users/nkutub/received_events","type":"User","site_admin":false},"body":"https://jira.berkeley.edu/browse/SISRP-32435\r\n* temporarily pulling all terms from local JSON file \r\n* bug fix to terms logic \r\n* removed IN terms where clause for EDODB queries \r\n* all controlled by hub_terms_enabled feature flag. ","created_at":"2017-07-31T16:53:28Z","updated_at":"2017-07-31T17:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e8414291dcd9c6632839c8d80678353fedff7b1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6777/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6777/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6777/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/e0171e97e74c7adcd5cb70c510e9ec420418275b","head":{"label":"nkutub:SISRP-32435","ref":"SISRP-32435","sha":"e0171e97e74c7adcd5cb70c510e9ec420418275b","user":{"login":"nkutub","id":20545717,"avatar_url":"https://avatars0.githubusercontent.com/u/20545717?v=4","gravatar_id":"","url":"https://api.github.com/users/nkutub","html_url":"https://github.com/nkutub","followers_url":"https://api.github.com/users/nkutub/followers","following_url":"https://api.github.com/users/nkutub/following{/other_user}","gists_url":"https://api.github.com/users/nkutub/gists{/gist_id}","starred_url":"https://api.github.com/users/nkutub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkutub/subscriptions","organizations_url":"https://api.github.com/users/nkutub/orgs","repos_url":"https://api.github.com/users/nkutub/repos","events_url":"https://api.github.com/users/nkutub/events{/privacy}","received_events_url":"https://api.github.com/users/nkutub/received_events","type":"User","site_admin":false},"repo":{"id":63798985,"name":"calcentral","full_name":"nkutub/calcentral","owner":{"login":"nkutub","id":20545717,"avatar_url":"https://avatars0.githubusercontent.com/u/20545717?v=4","gravatar_id":"","url":"https://api.github.com/users/nkutub","html_url":"https://github.com/nkutub","followers_url":"https://api.github.com/users/nkutub/followers","following_url":"https://api.github.com/users/nkutub/following{/other_user}","gists_url":"https://api.github.com/users/nkutub/gists{/gist_id}","starred_url":"https://api.github.com/users/nkutub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkutub/subscriptions","organizations_url":"https://api.github.com/users/nkutub/orgs","repos_url":"https://api.github.com/users/nkutub/repos","events_url":"https://api.github.com/users/nkutub/events{/privacy}","received_events_url":"https://api.github.com/users/nkutub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkutub/calcentral","description":null,"fork":true,"url":"https://api.github.com/repos/nkutub/calcentral","forks_url":"https://api.github.com/repos/nkutub/calcentral/forks","keys_url":"https://api.github.com/repos/nkutub/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkutub/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkutub/calcentral/teams","hooks_url":"https://api.github.com/repos/nkutub/calcentral/hooks","issue_events_url":"https://api.github.com/repos/nkutub/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/nkutub/calcentral/events","assignees_url":"https://api.github.com/repos/nkutub/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/nkutub/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/nkutub/calcentral/tags","blobs_url":"https://api.github.com/repos/nkutub/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkutub/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkutub/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkutub/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkutub/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/nkutub/calcentral/languages","stargazers_url":"https://api.github.com/repos/nkutub/calcentral/stargazers","contributors_url":"https://api.github.com/repos/nkutub/calcentral/contributors","subscribers_url":"https://api.github.com/repos/nkutub/calcentral/subscribers","subscription_url":"https://api.github.com/repos/nkutub/calcentral/subscription","commits_url":"https://api.github.com/repos/nkutub/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkutub/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkutub/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkutub/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkutub/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/nkutub/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkutub/calcentral/merges","archive_url":"https://api.github.com/repos/nkutub/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkutub/calcentral/downloads","issues_url":"https://api.github.com/repos/nkutub/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/nkutub/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/nkutub/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/nkutub/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkutub/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/nkutub/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/nkutub/calcentral/deployments","created_at":"2016-07-20T16:58:40Z","updated_at":"2016-07-20T16:58:45Z","pushed_at":"2017-07-31T17:38:02Z","git_url":"git://github.com/nkutub/calcentral.git","ssh_url":"[email protected]:nkutub/calcentral.git","clone_url":"https://github.com/nkutub/calcentral.git","svn_url":"https://github.com/nkutub/calcentral","homepage":"https://calcentral.berkeley.edu","size":29076,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"b33c1cca3dbcc67da46327d479ce0c4edb5945d1","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars1.githubusercontent.com/u/283538?v=4","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars1.githubusercontent.com/u/283538?v=4","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":null,"fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/deployments","created_at":"2012-08-20T16:45:39Z","updated_at":"2017-07-25T09:01:29Z","pushed_at":"2017-07-31T17:38:04Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"[email protected]:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":29272,"stargazers_count":71,"watchers_count":71,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":2,"forks":65,"open_issues":2,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6777"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/6777"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6777"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/6777/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6777/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/6777/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/e0171e97e74c7adcd5cb70c510e9ec420418275b"}}}} | {
"id": 5483921,
"name": "ets-berkeley-edu/calcentral",
"url": "https://api.github.com/repos/ets-berkeley-edu/calcentral"
} | {
"id": 20545717,
"login": "nkutub",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20545717?",
"url": "https://api.github.com/users/nkutub"
} | {
"id": 283538,
"login": "ets-berkeley-edu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/283538?",
"url": "https://api.github.com/orgs/ets-berkeley-edu"
} | 2017-07-31T17:38:26 | 6363525681 | {"actor":{"display_login":"nkutub"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments/154212731","pull_request_review_id":80343287,"id":154212731,"diff_hunk":"@@ -242,6 +239,13 @@ def num_episodes(self):\n except Exception:\n raise RuntimeError('\"num_episodes\" must be overriden by children.')\n \n+ def num_examples(self):","path":"parlai/core/teachers.py","position":14,"original_position":14,"commit_id":"89008d07dfc7a93f8d535d6864abc2cfb4c303ec","original_commit_id":"dda1423848c4b29efc4212e98aeb8aa51a11818f","user":{"login":"jaseweston","id":11068664,"avatar_url":"https://avatars3.githubusercontent.com/u/11068664?v=4","gravatar_id":"","url":"https://api.github.com/users/jaseweston","html_url":"https://github.com/jaseweston","followers_url":"https://api.github.com/users/jaseweston/followers","following_url":"https://api.github.com/users/jaseweston/following{/other_user}","gists_url":"https://api.github.com/users/jaseweston/gists{/gist_id}","starred_url":"https://api.github.com/users/jaseweston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaseweston/subscriptions","organizations_url":"https://api.github.com/users/jaseweston/orgs","repos_url":"https://api.github.com/users/jaseweston/repos","events_url":"https://api.github.com/users/jaseweston/events{/privacy}","received_events_url":"https://api.github.com/users/jaseweston/received_events","type":"User","site_admin":false},"body":"i mean for tasks where the data is infinite, or where they can't/don't declare it. we probably shouldn't use 0 because it's numerical -- somehow None or inf seem to make more sense?","created_at":"2017-11-30T21:53:59Z","updated_at":"2017-11-30T21:53:59Z","html_url":"https://github.com/facebookresearch/ParlAI/pull/422#discussion_r154212731","pull_request_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments/154212731"},"html":{"href":"https://github.com/facebookresearch/ParlAI/pull/422#discussion_r154212731"},"pull_request":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422"}},"in_reply_to_id":154201316},"pull_request":{"url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422","id":155716692,"html_url":"https://github.com/facebookresearch/ParlAI/pull/422","diff_url":"https://github.com/facebookresearch/ParlAI/pull/422.diff","patch_url":"https://github.com/facebookresearch/ParlAI/pull/422.patch","issue_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/422","number":422,"state":"open","locked":false,"title":"Remove world iters, get rid of len, etc.","user":{"login":"klshuster","id":8562788,"avatar_url":"https://avatars3.githubusercontent.com/u/8562788?v=4","gravatar_id":"","url":"https://api.github.com/users/klshuster","html_url":"https://github.com/klshuster","followers_url":"https://api.github.com/users/klshuster/followers","following_url":"https://api.github.com/users/klshuster/following{/other_user}","gists_url":"https://api.github.com/users/klshuster/gists{/gist_id}","starred_url":"https://api.github.com/users/klshuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshuster/subscriptions","organizations_url":"https://api.github.com/users/klshuster/orgs","repos_url":"https://api.github.com/users/klshuster/repos","events_url":"https://api.github.com/users/klshuster/events{/privacy}","received_events_url":"https://api.github.com/users/klshuster/received_events","type":"User","site_admin":false},"body":"This PR includes the following:\r\n\r\n- remove `__iter__`, `__next__`, and `__len__` from worlds and agents\r\n- adds `num_examples` and `num_episodes` to all worlds, as well as agents in `teachers.py`\r\n- converts vqa_v2 teacher to a `FixedDialogTeacher`\r\n- misc changes to other agents to deal with removing `__len__`","created_at":"2017-11-30T20:55:18Z","updated_at":"2017-11-30T21:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dc6d698d6a9eed487f7a944d47072f43062a1f7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexholdenmiller","id":1141354,"avatar_url":"https://avatars1.githubusercontent.com/u/1141354?v=4","gravatar_id":"","url":"https://api.github.com/users/alexholdenmiller","html_url":"https://github.com/alexholdenmiller","followers_url":"https://api.github.com/users/alexholdenmiller/followers","following_url":"https://api.github.com/users/alexholdenmiller/following{/other_user}","gists_url":"https://api.github.com/users/alexholdenmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/alexholdenmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexholdenmiller/subscriptions","organizations_url":"https://api.github.com/users/alexholdenmiller/orgs","repos_url":"https://api.github.com/users/alexholdenmiller/repos","events_url":"https://api.github.com/users/alexholdenmiller/events{/privacy}","received_events_url":"https://api.github.com/users/alexholdenmiller/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/422/comments","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/89008d07dfc7a93f8d535d6864abc2cfb4c303ec","head":{"label":"klshuster:remove_world_iters","ref":"remove_world_iters","sha":"89008d07dfc7a93f8d535d6864abc2cfb4c303ec","user":{"login":"klshuster","id":8562788,"avatar_url":"https://avatars3.githubusercontent.com/u/8562788?v=4","gravatar_id":"","url":"https://api.github.com/users/klshuster","html_url":"https://github.com/klshuster","followers_url":"https://api.github.com/users/klshuster/followers","following_url":"https://api.github.com/users/klshuster/following{/other_user}","gists_url":"https://api.github.com/users/klshuster/gists{/gist_id}","starred_url":"https://api.github.com/users/klshuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshuster/subscriptions","organizations_url":"https://api.github.com/users/klshuster/orgs","repos_url":"https://api.github.com/users/klshuster/repos","events_url":"https://api.github.com/users/klshuster/events{/privacy}","received_events_url":"https://api.github.com/users/klshuster/received_events","type":"User","site_admin":false},"repo":{"id":104381545,"name":"ParlAI","full_name":"klshuster/ParlAI","owner":{"login":"klshuster","id":8562788,"avatar_url":"https://avatars3.githubusercontent.com/u/8562788?v=4","gravatar_id":"","url":"https://api.github.com/users/klshuster","html_url":"https://github.com/klshuster","followers_url":"https://api.github.com/users/klshuster/followers","following_url":"https://api.github.com/users/klshuster/following{/other_user}","gists_url":"https://api.github.com/users/klshuster/gists{/gist_id}","starred_url":"https://api.github.com/users/klshuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshuster/subscriptions","organizations_url":"https://api.github.com/users/klshuster/orgs","repos_url":"https://api.github.com/users/klshuster/repos","events_url":"https://api.github.com/users/klshuster/events{/privacy}","received_events_url":"https://api.github.com/users/klshuster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klshuster/ParlAI","description":"A framework for training and evaluating AI models on a variety of openly available dialog datasets.","fork":true,"url":"https://api.github.com/repos/klshuster/ParlAI","forks_url":"https://api.github.com/repos/klshuster/ParlAI/forks","keys_url":"https://api.github.com/repos/klshuster/ParlAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klshuster/ParlAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klshuster/ParlAI/teams","hooks_url":"https://api.github.com/repos/klshuster/ParlAI/hooks","issue_events_url":"https://api.github.com/repos/klshuster/ParlAI/issues/events{/number}","events_url":"https://api.github.com/repos/klshuster/ParlAI/events","assignees_url":"https://api.github.com/repos/klshuster/ParlAI/assignees{/user}","branches_url":"https://api.github.com/repos/klshuster/ParlAI/branches{/branch}","tags_url":"https://api.github.com/repos/klshuster/ParlAI/tags","blobs_url":"https://api.github.com/repos/klshuster/ParlAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klshuster/ParlAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klshuster/ParlAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/klshuster/ParlAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klshuster/ParlAI/statuses/{sha}","languages_url":"https://api.github.com/repos/klshuster/ParlAI/languages","stargazers_url":"https://api.github.com/repos/klshuster/ParlAI/stargazers","contributors_url":"https://api.github.com/repos/klshuster/ParlAI/contributors","subscribers_url":"https://api.github.com/repos/klshuster/ParlAI/subscribers","subscription_url":"https://api.github.com/repos/klshuster/ParlAI/subscription","commits_url":"https://api.github.com/repos/klshuster/ParlAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/klshuster/ParlAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/klshuster/ParlAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/klshuster/ParlAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/klshuster/ParlAI/contents/{+path}","compare_url":"https://api.github.com/repos/klshuster/ParlAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klshuster/ParlAI/merges","archive_url":"https://api.github.com/repos/klshuster/ParlAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klshuster/ParlAI/downloads","issues_url":"https://api.github.com/repos/klshuster/ParlAI/issues{/number}","pulls_url":"https://api.github.com/repos/klshuster/ParlAI/pulls{/number}","milestones_url":"https://api.github.com/repos/klshuster/ParlAI/milestones{/number}","notifications_url":"https://api.github.com/repos/klshuster/ParlAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klshuster/ParlAI/labels{/name}","releases_url":"https://api.github.com/repos/klshuster/ParlAI/releases{/id}","deployments_url":"https://api.github.com/repos/klshuster/ParlAI/deployments","created_at":"2017-09-21T18:03:42Z","updated_at":"2017-09-21T18:03:44Z","pushed_at":"2017-11-30T21:28:23Z","git_url":"git://github.com/klshuster/ParlAI.git","ssh_url":"[email protected]:klshuster/ParlAI.git","clone_url":"https://github.com/klshuster/ParlAI.git","svn_url":"https://github.com/klshuster/ParlAI","homepage":"parl.ai","size":5971,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"ed306b4f9095d77da8da4195fa1bc0fcefc437c7","user":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":89266735,"name":"ParlAI","full_name":"facebookresearch/ParlAI","owner":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/ParlAI","description":"A framework for training and evaluating AI models on a variety of openly available dialog datasets.","fork":false,"url":"https://api.github.com/repos/facebookresearch/ParlAI","forks_url":"https://api.github.com/repos/facebookresearch/ParlAI/forks","keys_url":"https://api.github.com/repos/facebookresearch/ParlAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/ParlAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/ParlAI/teams","hooks_url":"https://api.github.com/repos/facebookresearch/ParlAI/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/ParlAI/events","assignees_url":"https://api.github.com/repos/facebookresearch/ParlAI/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/ParlAI/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/tags","blobs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/ParlAI/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/ParlAI/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/ParlAI/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscription","commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/ParlAI/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/ParlAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/ParlAI/merges","archive_url":"https://api.github.com/repos/facebookresearch/ParlAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/ParlAI/downloads","issues_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/ParlAI/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/ParlAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/ParlAI/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/ParlAI/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/ParlAI/deployments","created_at":"2017-04-24T17:10:44Z","updated_at":"2017-11-30T20:28:31Z","pushed_at":"2017-11-30T21:28:24Z","git_url":"git://github.com/facebookresearch/ParlAI.git","ssh_url":"[email protected]:facebookresearch/ParlAI.git","clone_url":"https://github.com/facebookresearch/ParlAI.git","svn_url":"https://github.com/facebookresearch/ParlAI","homepage":"parl.ai","size":5990,"stargazers_count":2456,"watchers_count":2456,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":383,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":383,"open_issues":14,"watchers":2456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422"},"html":{"href":"https://github.com/facebookresearch/ParlAI/pull/422"},"issue":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/issues/422"},"comments":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/89008d07dfc7a93f8d535d6864abc2cfb4c303ec"}},"author_association":"CONTRIBUTOR"}} | {
"id": 89266735,
"name": "facebookresearch/ParlAI",
"url": "https://api.github.com/repos/facebookresearch/ParlAI"
} | {
"id": 11068664,
"login": "jaseweston",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11068664?",
"url": "https://api.github.com/users/jaseweston"
} | {
"id": 16943930,
"login": "facebookresearch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16943930?",
"url": "https://api.github.com/orgs/facebookresearch"
} | 2017-11-30T21:53:59 | 6927192907 | {"actor":{"display_login":"jaseweston"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jboss-switchyard/tools/pulls/comments/95372252","pull_request_review_id":15924294,"id":95372252,"diff_hunk":"@@ -603,11 +602,25 @@ protected Object calculate() {\n if (unwrapped != null || copyNamespaces != null) {\n final MessageComposerType msgComposer = SOAPFactory.eINSTANCE\n .createMessageComposerType();\n- if (unwrapped != null) {\n+ final MessageComposerType oldMsgComposer = _binding.getMessageComposer();\n+ boolean unwrappedChanged = true;","path":"eclipse/plugins/org.switchyard.tools.ui.editor/src/org/switchyard/tools/ui/editor/components/soap/SOAPBindingServiceComposite.java","position":14,"original_position":14,"commit_id":"646400dee242dd403abd2e77c8b1ffd5b12196f0","original_commit_id":"646400dee242dd403abd2e77c8b1ffd5b12196f0","user":{"login":"bfitzpat","id":530878,"avatar_url":"https://avatars.githubusercontent.com/u/530878?v=3","gravatar_id":"","url":"https://api.github.com/users/bfitzpat","html_url":"https://github.com/bfitzpat","followers_url":"https://api.github.com/users/bfitzpat/followers","following_url":"https://api.github.com/users/bfitzpat/following{/other_user}","gists_url":"https://api.github.com/users/bfitzpat/gists{/gist_id}","starred_url":"https://api.github.com/users/bfitzpat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfitzpat/subscriptions","organizations_url":"https://api.github.com/users/bfitzpat/orgs","repos_url":"https://api.github.com/users/bfitzpat/repos","events_url":"https://api.github.com/users/bfitzpat/events{/privacy}","received_events_url":"https://api.github.com/users/bfitzpat/received_events","type":"User","site_admin":false},"body":"Interesting thought. I'm not sure how much we want to spend on this code though. ","created_at":"2017-01-10T14:24:33Z","updated_at":"2017-01-10T14:24:33Z","html_url":"https://github.com/jboss-switchyard/tools/pull/649#discussion_r95372252","pull_request_url":"https://api.github.com/repos/jboss-switchyard/tools/pulls/649","_links":{"self":{"href":"https://api.github.com/repos/jboss-switchyard/tools/pulls/comments/95372252"},"html":{"href":"https://github.com/jboss-switchyard/tools/pull/649#discussion_r95372252"},"pull_request":{"href":"https://api.github.com/repos/jboss-switchyard/tools/pulls/649"}}},"pull_request":{"url":"https://api.github.com/repos/jboss-switchyard/tools/pulls/649","id":100385926,"html_url":"https://github.com/jboss-switchyard/tools/pull/649","diff_url":"https://github.com/jboss-switchyard/tools/pull/649.diff","patch_url":"https://github.com/jboss-switchyard/tools/pull/649.patch","issue_url":"https://api.github.com/repos/jboss-switchyard/tools/issues/649","number":649,"state":"open","locked":false,"title":"SWITCHYARD-2984 - fixed issue with unwrapped checkbox on soap bindings","user":{"login":"bfitzpat","id":530878,"avatar_url":"https://avatars.githubusercontent.com/u/530878?v=3","gravatar_id":"","url":"https://api.github.com/users/bfitzpat","html_url":"https://github.com/bfitzpat","followers_url":"https://api.github.com/users/bfitzpat/followers","following_url":"https://api.github.com/users/bfitzpat/following{/other_user}","gists_url":"https://api.github.com/users/bfitzpat/gists{/gist_id}","starred_url":"https://api.github.com/users/bfitzpat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfitzpat/subscriptions","organizations_url":"https://api.github.com/users/bfitzpat/orgs","repos_url":"https://api.github.com/users/bfitzpat/repos","events_url":"https://api.github.com/users/bfitzpat/events{/privacy}","received_events_url":"https://api.github.com/users/bfitzpat/received_events","type":"User","site_admin":false},"body":"-- unwrapped checkbox now is always enabled across all versions\r\n-- copynamespaces checkbox is handled a bit more intelligently to avoid\r\nintroducing validation errors in 2.0.x or below.","created_at":"2017-01-05T23:44:55Z","updated_at":"2017-01-10T14:24:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad9681da71694c82a26c076e1997ee122c9f4a08","assignee":{"login":"apupier","id":1105127,"avatar_url":"https://avatars.githubusercontent.com/u/1105127?v=3","gravatar_id":"","url":"https://api.github.com/users/apupier","html_url":"https://github.com/apupier","followers_url":"https://api.github.com/users/apupier/followers","following_url":"https://api.github.com/users/apupier/following{/other_user}","gists_url":"https://api.github.com/users/apupier/gists{/gist_id}","starred_url":"https://api.github.com/users/apupier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apupier/subscriptions","organizations_url":"https://api.github.com/users/apupier/orgs","repos_url":"https://api.github.com/users/apupier/repos","events_url":"https://api.github.com/users/apupier/events{/privacy}","received_events_url":"https://api.github.com/users/apupier/received_events","type":"User","site_admin":false},"assignees":[{"login":"apupier","id":1105127,"avatar_url":"https://avatars.githubusercontent.com/u/1105127?v=3","gravatar_id":"","url":"https://api.github.com/users/apupier","html_url":"https://github.com/apupier","followers_url":"https://api.github.com/users/apupier/followers","following_url":"https://api.github.com/users/apupier/following{/other_user}","gists_url":"https://api.github.com/users/apupier/gists{/gist_id}","starred_url":"https://api.github.com/users/apupier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apupier/subscriptions","organizations_url":"https://api.github.com/users/apupier/orgs","repos_url":"https://api.github.com/users/apupier/repos","events_url":"https://api.github.com/users/apupier/events{/privacy}","received_events_url":"https://api.github.com/users/apupier/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jboss-switchyard/tools/pulls/649/commits","review_comments_url":"https://api.github.com/repos/jboss-switchyard/tools/pulls/649/comments","review_comment_url":"https://api.github.com/repos/jboss-switchyard/tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jboss-switchyard/tools/issues/649/comments","statuses_url":"https://api.github.com/repos/jboss-switchyard/tools/statuses/646400dee242dd403abd2e77c8b1ffd5b12196f0","head":{"label":"bfitzpat:SWITCHYARD-2984","ref":"SWITCHYARD-2984","sha":"646400dee242dd403abd2e77c8b1ffd5b12196f0","user":{"login":"bfitzpat","id":530878,"avatar_url":"https://avatars.githubusercontent.com/u/530878?v=3","gravatar_id":"","url":"https://api.github.com/users/bfitzpat","html_url":"https://github.com/bfitzpat","followers_url":"https://api.github.com/users/bfitzpat/followers","following_url":"https://api.github.com/users/bfitzpat/following{/other_user}","gists_url":"https://api.github.com/users/bfitzpat/gists{/gist_id}","starred_url":"https://api.github.com/users/bfitzpat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfitzpat/subscriptions","organizations_url":"https://api.github.com/users/bfitzpat/orgs","repos_url":"https://api.github.com/users/bfitzpat/repos","events_url":"https://api.github.com/users/bfitzpat/events{/privacy}","received_events_url":"https://api.github.com/users/bfitzpat/received_events","type":"User","site_admin":false},"repo":{"id":3909717,"name":"tools","full_name":"bfitzpat/tools","owner":{"login":"bfitzpat","id":530878,"avatar_url":"https://avatars.githubusercontent.com/u/530878?v=3","gravatar_id":"","url":"https://api.github.com/users/bfitzpat","html_url":"https://github.com/bfitzpat","followers_url":"https://api.github.com/users/bfitzpat/followers","following_url":"https://api.github.com/users/bfitzpat/following{/other_user}","gists_url":"https://api.github.com/users/bfitzpat/gists{/gist_id}","starred_url":"https://api.github.com/users/bfitzpat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfitzpat/subscriptions","organizations_url":"https://api.github.com/users/bfitzpat/orgs","repos_url":"https://api.github.com/users/bfitzpat/repos","events_url":"https://api.github.com/users/bfitzpat/events{/privacy}","received_events_url":"https://api.github.com/users/bfitzpat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bfitzpat/tools","description":"Tooling modules for SwitchYard","fork":true,"url":"https://api.github.com/repos/bfitzpat/tools","forks_url":"https://api.github.com/repos/bfitzpat/tools/forks","keys_url":"https://api.github.com/repos/bfitzpat/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bfitzpat/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bfitzpat/tools/teams","hooks_url":"https://api.github.com/repos/bfitzpat/tools/hooks","issue_events_url":"https://api.github.com/repos/bfitzpat/tools/issues/events{/number}","events_url":"https://api.github.com/repos/bfitzpat/tools/events","assignees_url":"https://api.github.com/repos/bfitzpat/tools/assignees{/user}","branches_url":"https://api.github.com/repos/bfitzpat/tools/branches{/branch}","tags_url":"https://api.github.com/repos/bfitzpat/tools/tags","blobs_url":"https://api.github.com/repos/bfitzpat/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bfitzpat/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bfitzpat/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/bfitzpat/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bfitzpat/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/bfitzpat/tools/languages","stargazers_url":"https://api.github.com/repos/bfitzpat/tools/stargazers","contributors_url":"https://api.github.com/repos/bfitzpat/tools/contributors","subscribers_url":"https://api.github.com/repos/bfitzpat/tools/subscribers","subscription_url":"https://api.github.com/repos/bfitzpat/tools/subscription","commits_url":"https://api.github.com/repos/bfitzpat/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/bfitzpat/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/bfitzpat/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/bfitzpat/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/bfitzpat/tools/contents/{+path}","compare_url":"https://api.github.com/repos/bfitzpat/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bfitzpat/tools/merges","archive_url":"https://api.github.com/repos/bfitzpat/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bfitzpat/tools/downloads","issues_url":"https://api.github.com/repos/bfitzpat/tools/issues{/number}","pulls_url":"https://api.github.com/repos/bfitzpat/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/bfitzpat/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/bfitzpat/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bfitzpat/tools/labels{/name}","releases_url":"https://api.github.com/repos/bfitzpat/tools/releases{/id}","deployments_url":"https://api.github.com/repos/bfitzpat/tools/deployments","created_at":"2012-04-02T18:38:01Z","updated_at":"2015-04-23T20:12:55Z","pushed_at":"2017-01-05T23:44:37Z","git_url":"git://github.com/bfitzpat/tools.git","ssh_url":"[email protected]:bfitzpat/tools.git","clone_url":"https://github.com/bfitzpat/tools.git","svn_url":"https://github.com/bfitzpat/tools","homepage":"http://jboss.org/switchyard","size":16589,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"jboss-switchyard:master","ref":"master","sha":"0ebf2ccced509b4faa89cc46ff6bfeb0535c5e81","user":{"login":"jboss-switchyard","id":447316,"avatar_url":"https://avatars.githubusercontent.com/u/447316?v=3","gravatar_id":"","url":"https://api.github.com/users/jboss-switchyard","html_url":"https://github.com/jboss-switchyard","followers_url":"https://api.github.com/users/jboss-switchyard/followers","following_url":"https://api.github.com/users/jboss-switchyard/following{/other_user}","gists_url":"https://api.github.com/users/jboss-switchyard/gists{/gist_id}","starred_url":"https://api.github.com/users/jboss-switchyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboss-switchyard/subscriptions","organizations_url":"https://api.github.com/users/jboss-switchyard/orgs","repos_url":"https://api.github.com/users/jboss-switchyard/repos","events_url":"https://api.github.com/users/jboss-switchyard/events{/privacy}","received_events_url":"https://api.github.com/users/jboss-switchyard/received_events","type":"Organization","site_admin":false},"repo":{"id":2284823,"name":"tools","full_name":"jboss-switchyard/tools","owner":{"login":"jboss-switchyard","id":447316,"avatar_url":"https://avatars.githubusercontent.com/u/447316?v=3","gravatar_id":"","url":"https://api.github.com/users/jboss-switchyard","html_url":"https://github.com/jboss-switchyard","followers_url":"https://api.github.com/users/jboss-switchyard/followers","following_url":"https://api.github.com/users/jboss-switchyard/following{/other_user}","gists_url":"https://api.github.com/users/jboss-switchyard/gists{/gist_id}","starred_url":"https://api.github.com/users/jboss-switchyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboss-switchyard/subscriptions","organizations_url":"https://api.github.com/users/jboss-switchyard/orgs","repos_url":"https://api.github.com/users/jboss-switchyard/repos","events_url":"https://api.github.com/users/jboss-switchyard/events{/privacy}","received_events_url":"https://api.github.com/users/jboss-switchyard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jboss-switchyard/tools","description":"Tooling modules for SwitchYard","fork":false,"url":"https://api.github.com/repos/jboss-switchyard/tools","forks_url":"https://api.github.com/repos/jboss-switchyard/tools/forks","keys_url":"https://api.github.com/repos/jboss-switchyard/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jboss-switchyard/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jboss-switchyard/tools/teams","hooks_url":"https://api.github.com/repos/jboss-switchyard/tools/hooks","issue_events_url":"https://api.github.com/repos/jboss-switchyard/tools/issues/events{/number}","events_url":"https://api.github.com/repos/jboss-switchyard/tools/events","assignees_url":"https://api.github.com/repos/jboss-switchyard/tools/assignees{/user}","branches_url":"https://api.github.com/repos/jboss-switchyard/tools/branches{/branch}","tags_url":"https://api.github.com/repos/jboss-switchyard/tools/tags","blobs_url":"https://api.github.com/repos/jboss-switchyard/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jboss-switchyard/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jboss-switchyard/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/jboss-switchyard/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jboss-switchyard/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/jboss-switchyard/tools/languages","stargazers_url":"https://api.github.com/repos/jboss-switchyard/tools/stargazers","contributors_url":"https://api.github.com/repos/jboss-switchyard/tools/contributors","subscribers_url":"https://api.github.com/repos/jboss-switchyard/tools/subscribers","subscription_url":"https://api.github.com/repos/jboss-switchyard/tools/subscription","commits_url":"https://api.github.com/repos/jboss-switchyard/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/jboss-switchyard/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/jboss-switchyard/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/jboss-switchyard/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/jboss-switchyard/tools/contents/{+path}","compare_url":"https://api.github.com/repos/jboss-switchyard/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jboss-switchyard/tools/merges","archive_url":"https://api.github.com/repos/jboss-switchyard/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jboss-switchyard/tools/downloads","issues_url":"https://api.github.com/repos/jboss-switchyard/tools/issues{/number}","pulls_url":"https://api.github.com/repos/jboss-switchyard/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/jboss-switchyard/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/jboss-switchyard/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jboss-switchyard/tools/labels{/name}","releases_url":"https://api.github.com/repos/jboss-switchyard/tools/releases{/id}","deployments_url":"https://api.github.com/repos/jboss-switchyard/tools/deployments","created_at":"2011-08-28T20:05:06Z","updated_at":"2016-10-24T19:14:53Z","pushed_at":"2017-01-05T23:44:56Z","git_url":"git://github.com/jboss-switchyard/tools.git","ssh_url":"[email protected]:jboss-switchyard/tools.git","clone_url":"https://github.com/jboss-switchyard/tools.git","svn_url":"https://github.com/jboss-switchyard/tools","homepage":"http://jboss.org/switchyard","size":14256,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":4,"forks":28,"open_issues":4,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jboss-switchyard/tools/pulls/649"},"html":{"href":"https://github.com/jboss-switchyard/tools/pull/649"},"issue":{"href":"https://api.github.com/repos/jboss-switchyard/tools/issues/649"},"comments":{"href":"https://api.github.com/repos/jboss-switchyard/tools/issues/649/comments"},"review_comments":{"href":"https://api.github.com/repos/jboss-switchyard/tools/pulls/649/comments"},"review_comment":{"href":"https://api.github.com/repos/jboss-switchyard/tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jboss-switchyard/tools/pulls/649/commits"},"statuses":{"href":"https://api.github.com/repos/jboss-switchyard/tools/statuses/646400dee242dd403abd2e77c8b1ffd5b12196f0"}}}} | {
"id": 2284823,
"name": "jboss-switchyard/tools",
"url": "https://api.github.com/repos/jboss-switchyard/tools"
} | {
"id": 530878,
"login": "bfitzpat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/530878?",
"url": "https://api.github.com/users/bfitzpat"
} | {
"id": 447316,
"login": "jboss-switchyard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/447316?",
"url": "https://api.github.com/orgs/jboss-switchyard"
} | 2017-01-10T14:24:33 | 5129330295 | {"actor":{"display_login":"bfitzpat"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/comments/157097952","pull_request_review_id":83679604,"id":157097952,"diff_hunk":"@@ -261,62 +300,63 @@ If the node receives (or already knows) a payment preimage for an\n unresolved HTLC output it was offered for which it has committed to an\n outgoing HTLC, it MUST *resolve* the output by spending it using the\n HTLC-success transaction, and MUST resolve the output of that\n-HTLC-success transaction. Otherwise, if the other node is not\n+HTLC-success transaction. Otherwise, if the remote node is not\n irrevocably committed to the HTLC, it MUST NOT *resolve* the output by\n spending it.\n \n A node SHOULD resolve that HTLC-success transaction output by spending\n-it to a convenient address. If the output is spent (as recommended),\n+it to a convenient address. If the output is spent (as recommended),\n the output is *resolved* by the spending transaction, otherwise it is\n-considered *resolved* by the *commitment transaction* itself.\n+considered *resolved* by the commitment transaction itself.\n \n A node MUST wait until the `OP_CHECKSEQUENCEVERIFY` delay has passed\n-(as specified by the other node's `open_channel` `to_self_delay`\n+(as specified by the remote node's `open_channel` `to_self_delay`\n field) before spending that HTLC-success transaction output.\n \n If not otherwise resolved, once the HTLC output has expired, it is considered\n *irrevocably resolved*.\n \n-# Unilateral Close Handling: Other Node's Commitment Transaction\n+# Unilateral Close Handling: Remote Commitment Transaction\n \n-The other node's commitment transaction *resolves* the funding\n+The *remote node's* commitment transaction *resolves* the funding\n transaction output.\n \n-There are no delays constraining behavior here, so it's simpler than\n-when dealing with one's own commitment transaction.\n+There are no delays constraining node behavior in this case, so it's simpler for\n+a node to handle than the case in which it discovers its local commitment\n+transaction.\n \n ## Requirements\n \n-When a node sees a *commitment transaction* from the other node:\n+When a node discovers a commitment transaction from the *remote node*:\n \n 1. `to_remote`: No action is required; this is a simple P2WPKH output to us.\n- This output is considered *resolved* by the *commitment transaction* itself.\n-2. `to_local`:: No action required; this is a payment to them. This output is considered *resolved*\n- by the *commitment transaction*.\n-3. HTLCs offered by this node: See \"HTLC Output Handling: Their Commitment, Our Offers\" below.\n-4. HTLCs offered by the other node: See \"HTLC Output Handling: Their Commitment, Their Offers\" below.\n-\n-A node MUST handle the broadcast of any valid *commitment transaction*\n-from the other node in this way; if it is unable to do so it MUST warn\n+ This output is considered *resolved* by the commitment transaction itself.\n+2. `to_local`:: No action required; this is a payment to them. This output is considered *resolved*","path":"05-onchain.md","position":496,"original_position":496,"commit_id":"b41b4ef27426531cbc11e0415bf22a9770638338","original_commit_id":"b41b4ef27426531cbc11e0415bf22a9770638338","user":{"login":"shannona","id":1110886,"avatar_url":"https://avatars0.githubusercontent.com/u/1110886?v=4","gravatar_id":"","url":"https://api.github.com/users/shannona","html_url":"https://github.com/shannona","followers_url":"https://api.github.com/users/shannona/followers","following_url":"https://api.github.com/users/shannona/following{/other_user}","gists_url":"https://api.github.com/users/shannona/gists{/gist_id}","starred_url":"https://api.github.com/users/shannona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shannona/subscriptions","organizations_url":"https://api.github.com/users/shannona/orgs","repos_url":"https://api.github.com/users/shannona/repos","events_url":"https://api.github.com/users/shannona/events{/privacy}","received_events_url":"https://api.github.com/users/shannona/received_events","type":"User","site_admin":false},"body":"them->the remote node","created_at":"2017-12-15T00:22:55Z","updated_at":"2017-12-15T00:31:03Z","html_url":"https://github.com/lightningnetwork/lightning-rfc/pull/320#discussion_r157097952","pull_request_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/320","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/comments/157097952"},"html":{"href":"https://github.com/lightningnetwork/lightning-rfc/pull/320#discussion_r157097952"},"pull_request":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/320","id":157583264,"html_url":"https://github.com/lightningnetwork/lightning-rfc/pull/320","diff_url":"https://github.com/lightningnetwork/lightning-rfc/pull/320.diff","patch_url":"https://github.com/lightningnetwork/lightning-rfc/pull/320.patch","issue_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/320","number":320,"state":"open","locked":false,"title":"Bolt 5 copy edit","user":{"login":"toadlyBroodle","id":13908213,"avatar_url":"https://avatars1.githubusercontent.com/u/13908213?v=4","gravatar_id":"","url":"https://api.github.com/users/toadlyBroodle","html_url":"https://github.com/toadlyBroodle","followers_url":"https://api.github.com/users/toadlyBroodle/followers","following_url":"https://api.github.com/users/toadlyBroodle/following{/other_user}","gists_url":"https://api.github.com/users/toadlyBroodle/gists{/gist_id}","starred_url":"https://api.github.com/users/toadlyBroodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toadlyBroodle/subscriptions","organizations_url":"https://api.github.com/users/toadlyBroodle/orgs","repos_url":"https://api.github.com/users/toadlyBroodle/repos","events_url":"https://api.github.com/users/toadlyBroodle/events{/privacy}","received_events_url":"https://api.github.com/users/toadlyBroodle/received_events","type":"User","site_admin":false},"body":"-first pass copy edit of first half of document\r\n-bring in line with stylesheet\r\n-change us/them terminology to local/remote\r\n-restructure 'Requirements' sections","created_at":"2017-12-11T14:54:57Z","updated_at":"2017-12-15T00:31:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/320/commits","review_comments_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/320/comments","review_comment_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/320/comments","statuses_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/statuses/b41b4ef27426531cbc11e0415bf22a9770638338","head":{"label":"toadlyBroodle:bolt5-copy-edit","ref":"bolt5-copy-edit","sha":"b41b4ef27426531cbc11e0415bf22a9770638338","user":{"login":"toadlyBroodle","id":13908213,"avatar_url":"https://avatars1.githubusercontent.com/u/13908213?v=4","gravatar_id":"","url":"https://api.github.com/users/toadlyBroodle","html_url":"https://github.com/toadlyBroodle","followers_url":"https://api.github.com/users/toadlyBroodle/followers","following_url":"https://api.github.com/users/toadlyBroodle/following{/other_user}","gists_url":"https://api.github.com/users/toadlyBroodle/gists{/gist_id}","starred_url":"https://api.github.com/users/toadlyBroodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toadlyBroodle/subscriptions","organizations_url":"https://api.github.com/users/toadlyBroodle/orgs","repos_url":"https://api.github.com/users/toadlyBroodle/repos","events_url":"https://api.github.com/users/toadlyBroodle/events{/privacy}","received_events_url":"https://api.github.com/users/toadlyBroodle/received_events","type":"User","site_admin":false},"repo":{"id":113634963,"name":"lightning-rfc","full_name":"toadlyBroodle/lightning-rfc","owner":{"login":"toadlyBroodle","id":13908213,"avatar_url":"https://avatars1.githubusercontent.com/u/13908213?v=4","gravatar_id":"","url":"https://api.github.com/users/toadlyBroodle","html_url":"https://github.com/toadlyBroodle","followers_url":"https://api.github.com/users/toadlyBroodle/followers","following_url":"https://api.github.com/users/toadlyBroodle/following{/other_user}","gists_url":"https://api.github.com/users/toadlyBroodle/gists{/gist_id}","starred_url":"https://api.github.com/users/toadlyBroodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toadlyBroodle/subscriptions","organizations_url":"https://api.github.com/users/toadlyBroodle/orgs","repos_url":"https://api.github.com/users/toadlyBroodle/repos","events_url":"https://api.github.com/users/toadlyBroodle/events{/privacy}","received_events_url":"https://api.github.com/users/toadlyBroodle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toadlyBroodle/lightning-rfc","description":"Lightning Network Specifications","fork":true,"url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc","forks_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/forks","keys_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/teams","hooks_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/hooks","issue_events_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/issues/events{/number}","events_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/events","assignees_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/assignees{/user}","branches_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/branches{/branch}","tags_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/tags","blobs_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/git/refs{/sha}","trees_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/statuses/{sha}","languages_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/languages","stargazers_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/stargazers","contributors_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/contributors","subscribers_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/subscribers","subscription_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/subscription","commits_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/commits{/sha}","git_commits_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/git/commits{/sha}","comments_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/comments{/number}","issue_comment_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/issues/comments{/number}","contents_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/contents/{+path}","compare_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/merges","archive_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/downloads","issues_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/issues{/number}","pulls_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/pulls{/number}","milestones_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/milestones{/number}","notifications_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/labels{/name}","releases_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/releases{/id}","deployments_url":"https://api.github.com/repos/toadlyBroodle/lightning-rfc/deployments","created_at":"2017-12-09T02:20:20Z","updated_at":"2017-12-09T00:05:18Z","pushed_at":"2017-12-14T18:31:43Z","git_url":"git://github.com/toadlyBroodle/lightning-rfc.git","ssh_url":"[email protected]:toadlyBroodle/lightning-rfc.git","clone_url":"https://github.com/toadlyBroodle/lightning-rfc.git","svn_url":"https://github.com/toadlyBroodle/lightning-rfc","homepage":null,"size":884,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightningnetwork:master","ref":"master","sha":"f1ac62c0655426fbe24219499af6ae4443e87500","user":{"login":"lightningnetwork","id":13424735,"avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":73738971,"name":"lightning-rfc","full_name":"lightningnetwork/lightning-rfc","owner":{"login":"lightningnetwork","id":13424735,"avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightningnetwork/lightning-rfc","description":"Lightning Network Specifications","fork":false,"url":"https://api.github.com/repos/lightningnetwork/lightning-rfc","forks_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/forks","keys_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/teams","hooks_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/hooks","issue_events_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/events{/number}","events_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/events","assignees_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/assignees{/user}","branches_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/branches{/branch}","tags_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/tags","blobs_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/statuses/{sha}","languages_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/languages","stargazers_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/stargazers","contributors_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/contributors","subscribers_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/subscribers","subscription_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/subscription","commits_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/contents/{+path}","compare_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/merges","archive_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/downloads","issues_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues{/number}","pulls_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls{/number}","milestones_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/milestones{/number}","notifications_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/labels{/name}","releases_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/releases{/id}","deployments_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/deployments","created_at":"2016-11-14T19:21:45Z","updated_at":"2017-12-14T17:59:11Z","pushed_at":"2017-12-14T18:31:45Z","git_url":"git://github.com/lightningnetwork/lightning-rfc.git","ssh_url":"[email protected]:lightningnetwork/lightning-rfc.git","clone_url":"https://github.com/lightningnetwork/lightning-rfc.git","svn_url":"https://github.com/lightningnetwork/lightning-rfc","homepage":null,"size":935,"stargazers_count":328,"watchers_count":328,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":76,"open_issues":28,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/320"},"html":{"href":"https://github.com/lightningnetwork/lightning-rfc/pull/320"},"issue":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/320"},"comments":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/lightningnetwork/lightning-rfc/statuses/b41b4ef27426531cbc11e0415bf22a9770638338"}},"author_association":"COLLABORATOR"}} | {
"id": 73738971,
"name": "lightningnetwork/lightning-rfc",
"url": "https://api.github.com/repos/lightningnetwork/lightning-rfc"
} | {
"id": 1110886,
"login": "shannona",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1110886?",
"url": "https://api.github.com/users/shannona"
} | {
"id": 13424735,
"login": "lightningnetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13424735?",
"url": "https://api.github.com/orgs/lightningnetwork"
} | 2017-12-15T00:22:55 | 6991534814 | {"actor":{"display_login":"shannona"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/comments/106001971","pull_request_review_id":26905702,"id":106001971,"diff_hunk":"@@ -88,17 +88,9 @@ function run(command, presets) {\n `Ensure this module can be found relative to the root of the project.`);\n });\n \n- // Also grab any Neutrino config from package.json and merge it into the config at a higher precedence\n- if (Object.keys(config).length) {\n- api.config.merge(config);\n- }\n-\n- if (args.inspect) {\n- return inspect(api.getWebpackOptions());\n- }\n-\n- api[command](args)\n- .then(() => process.exit(0))\n+ api.load()\n+ .then(() => api.config.merge(config || {}))\n+ .then(() => args.inspect ? inspect(api.getWebpackOptions()) : api[command](args))","path":"packages/neutrino/bin/neutrino","position":17,"original_position":17,"commit_id":"4db7d19f41d445fa5fe5c9952ec64a21b14eaf75","original_commit_id":"4db7d19f41d445fa5fe5c9952ec64a21b14eaf75","user":{"login":"jaridmargolin","id":933685,"avatar_url":"https://avatars3.githubusercontent.com/u/933685?v=3","gravatar_id":"","url":"https://api.github.com/users/jaridmargolin","html_url":"https://github.com/jaridmargolin","followers_url":"https://api.github.com/users/jaridmargolin/followers","following_url":"https://api.github.com/users/jaridmargolin/following{/other_user}","gists_url":"https://api.github.com/users/jaridmargolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jaridmargolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaridmargolin/subscriptions","organizations_url":"https://api.github.com/users/jaridmargolin/orgs","repos_url":"https://api.github.com/users/jaridmargolin/repos","events_url":"https://api.github.com/users/jaridmargolin/events{/privacy}","received_events_url":"https://api.github.com/users/jaridmargolin/received_events","type":"User","site_admin":false},"body":"Hmmmm... I'm not 100% in love with breaking them up. For someone else consuming the code, I don't think it is immediately apparent that inspect results in an exit.\r\n\r\nKeeping them together in some sort of if/else or ternary shows that execution is one or the other. Ultimately your call. Just my 2 cents. ","created_at":"2017-03-14T19:13:26Z","updated_at":"2017-03-14T19:13:26Z","html_url":"https://github.com/mozilla-neutrino/neutrino-dev/pull/113#discussion_r106001971","pull_request_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/comments/106001971"},"html":{"href":"https://github.com/mozilla-neutrino/neutrino-dev/pull/113#discussion_r106001971"},"pull_request":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/113","id":110636802,"html_url":"https://github.com/mozilla-neutrino/neutrino-dev/pull/113","diff_url":"https://github.com/mozilla-neutrino/neutrino-dev/pull/113.diff","patch_url":"https://github.com/mozilla-neutrino/neutrino-dev/pull/113.patch","issue_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/113","number":113,"state":"open","locked":false,"title":"Alter Neutrino `use` method to return Promise.","user":{"login":"jaridmargolin","id":933685,"avatar_url":"https://avatars3.githubusercontent.com/u/933685?v=3","gravatar_id":"","url":"https://api.github.com/users/jaridmargolin","html_url":"https://github.com/jaridmargolin","followers_url":"https://api.github.com/users/jaridmargolin/followers","following_url":"https://api.github.com/users/jaridmargolin/following{/other_user}","gists_url":"https://api.github.com/users/jaridmargolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jaridmargolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaridmargolin/subscriptions","organizations_url":"https://api.github.com/users/jaridmargolin/orgs","repos_url":"https://api.github.com/users/jaridmargolin/repos","events_url":"https://api.github.com/users/jaridmargolin/events{/privacy}","received_events_url":"https://api.github.com/users/jaridmargolin/received_events","type":"User","site_admin":false},"body":"PR to start implementation discussion around #112\r\n","created_at":"2017-03-14T14:43:24Z","updated_at":"2017-03-14T19:13:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2116ee257097c98ed2cf97dce4d1cc157ae821a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/113/commits","review_comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/113/comments","review_comment_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/113/comments","statuses_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/statuses/4db7d19f41d445fa5fe5c9952ec64a21b14eaf75","head":{"label":"jaridmargolin:async-presets","ref":"async-presets","sha":"4db7d19f41d445fa5fe5c9952ec64a21b14eaf75","user":{"login":"jaridmargolin","id":933685,"avatar_url":"https://avatars3.githubusercontent.com/u/933685?v=3","gravatar_id":"","url":"https://api.github.com/users/jaridmargolin","html_url":"https://github.com/jaridmargolin","followers_url":"https://api.github.com/users/jaridmargolin/followers","following_url":"https://api.github.com/users/jaridmargolin/following{/other_user}","gists_url":"https://api.github.com/users/jaridmargolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jaridmargolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaridmargolin/subscriptions","organizations_url":"https://api.github.com/users/jaridmargolin/orgs","repos_url":"https://api.github.com/users/jaridmargolin/repos","events_url":"https://api.github.com/users/jaridmargolin/events{/privacy}","received_events_url":"https://api.github.com/users/jaridmargolin/received_events","type":"User","site_admin":false},"repo":{"id":84885241,"name":"neutrino-dev","full_name":"jaridmargolin/neutrino-dev","owner":{"login":"jaridmargolin","id":933685,"avatar_url":"https://avatars3.githubusercontent.com/u/933685?v=3","gravatar_id":"","url":"https://api.github.com/users/jaridmargolin","html_url":"https://github.com/jaridmargolin","followers_url":"https://api.github.com/users/jaridmargolin/followers","following_url":"https://api.github.com/users/jaridmargolin/following{/other_user}","gists_url":"https://api.github.com/users/jaridmargolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jaridmargolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaridmargolin/subscriptions","organizations_url":"https://api.github.com/users/jaridmargolin/orgs","repos_url":"https://api.github.com/users/jaridmargolin/repos","events_url":"https://api.github.com/users/jaridmargolin/events{/privacy}","received_events_url":"https://api.github.com/users/jaridmargolin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaridmargolin/neutrino-dev","description":"Create and build modern JavaScript applications with zero initial configuration.","fork":true,"url":"https://api.github.com/repos/jaridmargolin/neutrino-dev","forks_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/forks","keys_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/teams","hooks_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/hooks","issue_events_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/issues/events{/number}","events_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/events","assignees_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/assignees{/user}","branches_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/branches{/branch}","tags_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/tags","blobs_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/languages","stargazers_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/stargazers","contributors_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/contributors","subscribers_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/subscribers","subscription_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/subscription","commits_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/contents/{+path}","compare_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/merges","archive_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/downloads","issues_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/issues{/number}","pulls_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/labels{/name}","releases_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/releases{/id}","deployments_url":"https://api.github.com/repos/jaridmargolin/neutrino-dev/deployments","created_at":"2017-03-13T23:45:18Z","updated_at":"2017-03-13T23:45:20Z","pushed_at":"2017-03-14T17:45:17Z","git_url":"git://github.com/jaridmargolin/neutrino-dev.git","ssh_url":"[email protected]:jaridmargolin/neutrino-dev.git","clone_url":"https://github.com/jaridmargolin/neutrino-dev.git","svn_url":"https://github.com/jaridmargolin/neutrino-dev","homepage":"https://neutrino.js.org","size":2190,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-neutrino:master","ref":"master","sha":"c8fac6b6ed61737ff09540986152d09a7b8b8e38","user":{"login":"mozilla-neutrino","id":21367267,"avatar_url":"https://avatars0.githubusercontent.com/u/21367267?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-neutrino","html_url":"https://github.com/mozilla-neutrino","followers_url":"https://api.github.com/users/mozilla-neutrino/followers","following_url":"https://api.github.com/users/mozilla-neutrino/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-neutrino/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-neutrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-neutrino/subscriptions","organizations_url":"https://api.github.com/users/mozilla-neutrino/orgs","repos_url":"https://api.github.com/users/mozilla-neutrino/repos","events_url":"https://api.github.com/users/mozilla-neutrino/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-neutrino/received_events","type":"Organization","site_admin":false},"repo":{"id":80793561,"name":"neutrino-dev","full_name":"mozilla-neutrino/neutrino-dev","owner":{"login":"mozilla-neutrino","id":21367267,"avatar_url":"https://avatars0.githubusercontent.com/u/21367267?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-neutrino","html_url":"https://github.com/mozilla-neutrino","followers_url":"https://api.github.com/users/mozilla-neutrino/followers","following_url":"https://api.github.com/users/mozilla-neutrino/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-neutrino/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-neutrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-neutrino/subscriptions","organizations_url":"https://api.github.com/users/mozilla-neutrino/orgs","repos_url":"https://api.github.com/users/mozilla-neutrino/repos","events_url":"https://api.github.com/users/mozilla-neutrino/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-neutrino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-neutrino/neutrino-dev","description":"Create and build modern JavaScript applications with zero initial configuration.","fork":false,"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev","forks_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/forks","keys_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/teams","hooks_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/hooks","issue_events_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/events","assignees_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/tags","blobs_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/languages","stargazers_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/stargazers","contributors_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/contributors","subscribers_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/subscribers","subscription_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/subscription","commits_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/merges","archive_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/downloads","issues_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/deployments","created_at":"2017-02-03T03:27:20Z","updated_at":"2017-03-14T18:00:08Z","pushed_at":"2017-03-14T17:45:18Z","git_url":"git://github.com/mozilla-neutrino/neutrino-dev.git","ssh_url":"[email protected]:mozilla-neutrino/neutrino-dev.git","clone_url":"https://github.com/mozilla-neutrino/neutrino-dev.git","svn_url":"https://github.com/mozilla-neutrino/neutrino-dev","homepage":"https://neutrino.js.org","size":2188,"stargazers_count":1015,"watchers_count":1015,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":14,"forks":42,"open_issues":14,"watchers":1015,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/113"},"html":{"href":"https://github.com/mozilla-neutrino/neutrino-dev/pull/113"},"issue":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/113"},"comments":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/statuses/4db7d19f41d445fa5fe5c9952ec64a21b14eaf75"}}}} | {
"id": 80793561,
"name": "mozilla-neutrino/neutrino-dev",
"url": "https://api.github.com/repos/mozilla-neutrino/neutrino-dev"
} | {
"id": 933685,
"login": "jaridmargolin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/933685?",
"url": "https://api.github.com/users/jaridmargolin"
} | {
"id": 21367267,
"login": "mozilla-neutrino",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21367267?",
"url": "https://api.github.com/orgs/mozilla-neutrino"
} | 2017-03-14T19:13:26 | 5492760188 | {"actor":{"display_login":"jaridmargolin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments/159038220","pull_request_review_id":85926189,"id":159038220,"diff_hunk":"@@ -0,0 +1,38 @@\n+@import './_variables.scss';\n+\n+.currentTimeIndicator {\n+ position: absolute;\n+ z-index: $timetable-current-time-indicator-z-index;\n+ width: 0%;\n+ height: 100%;\n+ background: none;\n+}\n+\n+:global(.verticalMode) .currentTimeIndicator {\n+ width: 100%;\n+ height: 0%;\n+}\n+\n+.circularPart {\n+ position: absolute;\n+ top: -0.25rem;\n+ left: -0.25rem;\n+ width: 0.5rem;\n+ height: 0.5rem;\n+ border-radius: 50%;\n+ background: $primary;\n+}\n+\n+.linePart {\n+ position: relative;\n+ top: 0%;\n+ left: -0.05rem;","path":"www/src/js/views/timetable/CurrentTimeIndicator.scss","position":29,"original_position":29,"commit_id":"8dd628cdc1b702e0c18d8327d86209aa238cb0a7","original_commit_id":"8dd628cdc1b702e0c18d8327d86209aa238cb0a7","user":{"login":"ZhangYiJiang","id":445650,"avatar_url":"https://avatars0.githubusercontent.com/u/445650?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYiJiang","html_url":"https://github.com/ZhangYiJiang","followers_url":"https://api.github.com/users/ZhangYiJiang/followers","following_url":"https://api.github.com/users/ZhangYiJiang/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYiJiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYiJiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYiJiang/subscriptions","organizations_url":"https://api.github.com/users/ZhangYiJiang/orgs","repos_url":"https://api.github.com/users/ZhangYiJiang/repos","events_url":"https://api.github.com/users/ZhangYiJiang/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYiJiang/received_events","type":"User","site_admin":false},"body":"Ditto above - extract to variable ","created_at":"2017-12-29T09:01:35Z","updated_at":"2017-12-29T09:04:27Z","html_url":"https://github.com/nusmodifications/nusmods/pull/624#discussion_r159038220","pull_request_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/624","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments/159038220"},"html":{"href":"https://github.com/nusmodifications/nusmods/pull/624#discussion_r159038220"},"pull_request":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/624"}}},"pull_request":{"url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/624","id":160475003,"html_url":"https://github.com/nusmodifications/nusmods/pull/624","diff_url":"https://github.com/nusmodifications/nusmods/pull/624.diff","patch_url":"https://github.com/nusmodifications/nusmods/pull/624.patch","issue_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/624","number":624,"state":"open","locked":false,"title":"[WIP] Indicate timeslot on timetable","user":{"login":"zameschua","id":18271085,"avatar_url":"https://avatars1.githubusercontent.com/u/18271085?v=4","gravatar_id":"","url":"https://api.github.com/users/zameschua","html_url":"https://github.com/zameschua","followers_url":"https://api.github.com/users/zameschua/followers","following_url":"https://api.github.com/users/zameschua/following{/other_user}","gists_url":"https://api.github.com/users/zameschua/gists{/gist_id}","starred_url":"https://api.github.com/users/zameschua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zameschua/subscriptions","organizations_url":"https://api.github.com/users/zameschua/orgs","repos_url":"https://api.github.com/users/zameschua/repos","events_url":"https://api.github.com/users/zameschua/events{/privacy}","received_events_url":"https://api.github.com/users/zameschua/received_events","type":"User","site_admin":false},"body":"### Motivation\r\nThis is a port from v2\r\nReplaces #588 (because I'ma Git noob)\r\n\r\n*** Note that the time indicator will always follow Singapore's time zone\n\nEdit: also realised I should be doing npm run ci, and config my linter to work with flow. Will squash my commits before merging.\r\n\r\n### Current progress\r\nTrying to get the current time indicators to not-duplicate when the rows are stacked like that. Not sure how though, any tips? 😢 \r\n\r\n\r\n### Other screenshots\r\n#### Horizontal mode without obstruction\r\n\r\n#### Horizontal mode with obstruction\r\n\r\n\r\n#### Vertical mode without obstruction\r\n\r\n#### Vertical Mode with obstruction\r\n\r\n\r\n#### Night mode\r\n","created_at":"2017-12-29T05:43:37Z","updated_at":"2017-12-29T09:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed670e4b3d6075c4103d4ab91d662cc44527afb5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/624/commits","review_comments_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/624/comments","review_comment_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/624/comments","statuses_url":"https://api.github.com/repos/nusmodifications/nusmods/statuses/8dd628cdc1b702e0c18d8327d86209aa238cb0a7","head":{"label":"zameschua:indicate-timeslot","ref":"indicate-timeslot","sha":"8dd628cdc1b702e0c18d8327d86209aa238cb0a7","user":{"login":"zameschua","id":18271085,"avatar_url":"https://avatars1.githubusercontent.com/u/18271085?v=4","gravatar_id":"","url":"https://api.github.com/users/zameschua","html_url":"https://github.com/zameschua","followers_url":"https://api.github.com/users/zameschua/followers","following_url":"https://api.github.com/users/zameschua/following{/other_user}","gists_url":"https://api.github.com/users/zameschua/gists{/gist_id}","starred_url":"https://api.github.com/users/zameschua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zameschua/subscriptions","organizations_url":"https://api.github.com/users/zameschua/orgs","repos_url":"https://api.github.com/users/zameschua/repos","events_url":"https://api.github.com/users/zameschua/events{/privacy}","received_events_url":"https://api.github.com/users/zameschua/received_events","type":"User","site_admin":false},"repo":{"id":115649241,"name":"nusmods","full_name":"zameschua/nusmods","owner":{"login":"zameschua","id":18271085,"avatar_url":"https://avatars1.githubusercontent.com/u/18271085?v=4","gravatar_id":"","url":"https://api.github.com/users/zameschua","html_url":"https://github.com/zameschua","followers_url":"https://api.github.com/users/zameschua/followers","following_url":"https://api.github.com/users/zameschua/following{/other_user}","gists_url":"https://api.github.com/users/zameschua/gists{/gist_id}","starred_url":"https://api.github.com/users/zameschua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zameschua/subscriptions","organizations_url":"https://api.github.com/users/zameschua/orgs","repos_url":"https://api.github.com/users/zameschua/repos","events_url":"https://api.github.com/users/zameschua/events{/privacy}","received_events_url":"https://api.github.com/users/zameschua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zameschua/nusmods","description":"🏫 Unofficial course planning platform for National University of Singapore.","fork":true,"url":"https://api.github.com/repos/zameschua/nusmods","forks_url":"https://api.github.com/repos/zameschua/nusmods/forks","keys_url":"https://api.github.com/repos/zameschua/nusmods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zameschua/nusmods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zameschua/nusmods/teams","hooks_url":"https://api.github.com/repos/zameschua/nusmods/hooks","issue_events_url":"https://api.github.com/repos/zameschua/nusmods/issues/events{/number}","events_url":"https://api.github.com/repos/zameschua/nusmods/events","assignees_url":"https://api.github.com/repos/zameschua/nusmods/assignees{/user}","branches_url":"https://api.github.com/repos/zameschua/nusmods/branches{/branch}","tags_url":"https://api.github.com/repos/zameschua/nusmods/tags","blobs_url":"https://api.github.com/repos/zameschua/nusmods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zameschua/nusmods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zameschua/nusmods/git/refs{/sha}","trees_url":"https://api.github.com/repos/zameschua/nusmods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zameschua/nusmods/statuses/{sha}","languages_url":"https://api.github.com/repos/zameschua/nusmods/languages","stargazers_url":"https://api.github.com/repos/zameschua/nusmods/stargazers","contributors_url":"https://api.github.com/repos/zameschua/nusmods/contributors","subscribers_url":"https://api.github.com/repos/zameschua/nusmods/subscribers","subscription_url":"https://api.github.com/repos/zameschua/nusmods/subscription","commits_url":"https://api.github.com/repos/zameschua/nusmods/commits{/sha}","git_commits_url":"https://api.github.com/repos/zameschua/nusmods/git/commits{/sha}","comments_url":"https://api.github.com/repos/zameschua/nusmods/comments{/number}","issue_comment_url":"https://api.github.com/repos/zameschua/nusmods/issues/comments{/number}","contents_url":"https://api.github.com/repos/zameschua/nusmods/contents/{+path}","compare_url":"https://api.github.com/repos/zameschua/nusmods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zameschua/nusmods/merges","archive_url":"https://api.github.com/repos/zameschua/nusmods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zameschua/nusmods/downloads","issues_url":"https://api.github.com/repos/zameschua/nusmods/issues{/number}","pulls_url":"https://api.github.com/repos/zameschua/nusmods/pulls{/number}","milestones_url":"https://api.github.com/repos/zameschua/nusmods/milestones{/number}","notifications_url":"https://api.github.com/repos/zameschua/nusmods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zameschua/nusmods/labels{/name}","releases_url":"https://api.github.com/repos/zameschua/nusmods/releases{/id}","deployments_url":"https://api.github.com/repos/zameschua/nusmods/deployments","created_at":"2017-12-28T18:25:32Z","updated_at":"2017-12-28T18:25:34Z","pushed_at":"2017-12-29T05:54:38Z","git_url":"git://github.com/zameschua/nusmods.git","ssh_url":"[email protected]:zameschua/nusmods.git","clone_url":"https://github.com/zameschua/nusmods.git","svn_url":"https://github.com/zameschua/nusmods","homepage":"https://nusmods.com","size":8236,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nusmodifications:master","ref":"master","sha":"be36177f854f457e2c0a01a09b66874c13ee5c27","user":{"login":"nusmodifications","id":7428865,"avatar_url":"https://avatars3.githubusercontent.com/u/7428865?v=4","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"repo":{"id":5481861,"name":"nusmods","full_name":"nusmodifications/nusmods","owner":{"login":"nusmodifications","id":7428865,"avatar_url":"https://avatars3.githubusercontent.com/u/7428865?v=4","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nusmodifications/nusmods","description":"🏫 Unofficial course planning platform for National University of Singapore.","fork":false,"url":"https://api.github.com/repos/nusmodifications/nusmods","forks_url":"https://api.github.com/repos/nusmodifications/nusmods/forks","keys_url":"https://api.github.com/repos/nusmodifications/nusmods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nusmodifications/nusmods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nusmodifications/nusmods/teams","hooks_url":"https://api.github.com/repos/nusmodifications/nusmods/hooks","issue_events_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/events{/number}","events_url":"https://api.github.com/repos/nusmodifications/nusmods/events","assignees_url":"https://api.github.com/repos/nusmodifications/nusmods/assignees{/user}","branches_url":"https://api.github.com/repos/nusmodifications/nusmods/branches{/branch}","tags_url":"https://api.github.com/repos/nusmodifications/nusmods/tags","blobs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nusmodifications/nusmods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/refs{/sha}","trees_url":"https://api.github.com/repos/nusmodifications/nusmods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nusmodifications/nusmods/statuses/{sha}","languages_url":"https://api.github.com/repos/nusmodifications/nusmods/languages","stargazers_url":"https://api.github.com/repos/nusmodifications/nusmods/stargazers","contributors_url":"https://api.github.com/repos/nusmodifications/nusmods/contributors","subscribers_url":"https://api.github.com/repos/nusmodifications/nusmods/subscribers","subscription_url":"https://api.github.com/repos/nusmodifications/nusmods/subscription","commits_url":"https://api.github.com/repos/nusmodifications/nusmods/commits{/sha}","git_commits_url":"https://api.github.com/repos/nusmodifications/nusmods/git/commits{/sha}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/comments{/number}","issue_comment_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/comments{/number}","contents_url":"https://api.github.com/repos/nusmodifications/nusmods/contents/{+path}","compare_url":"https://api.github.com/repos/nusmodifications/nusmods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nusmodifications/nusmods/merges","archive_url":"https://api.github.com/repos/nusmodifications/nusmods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nusmodifications/nusmods/downloads","issues_url":"https://api.github.com/repos/nusmodifications/nusmods/issues{/number}","pulls_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls{/number}","milestones_url":"https://api.github.com/repos/nusmodifications/nusmods/milestones{/number}","notifications_url":"https://api.github.com/repos/nusmodifications/nusmods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nusmodifications/nusmods/labels{/name}","releases_url":"https://api.github.com/repos/nusmodifications/nusmods/releases{/id}","deployments_url":"https://api.github.com/repos/nusmodifications/nusmods/deployments","created_at":"2012-08-20T13:58:35Z","updated_at":"2017-12-29T05:30:41Z","pushed_at":"2017-12-29T08:52:46Z","git_url":"git://github.com/nusmodifications/nusmods.git","ssh_url":"[email protected]:nusmodifications/nusmods.git","clone_url":"https://github.com/nusmodifications/nusmods.git","svn_url":"https://github.com/nusmodifications/nusmods","homepage":"https://nusmods.com","size":8251,"stargazers_count":168,"watchers_count":168,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":82,"open_issues":56,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/624"},"html":{"href":"https://github.com/nusmodifications/nusmods/pull/624"},"issue":{"href":"https://api.github.com/repos/nusmodifications/nusmods/issues/624"},"comments":{"href":"https://api.github.com/repos/nusmodifications/nusmods/issues/624/comments"},"review_comments":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/624/comments"},"review_comment":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/624/commits"},"statuses":{"href":"https://api.github.com/repos/nusmodifications/nusmods/statuses/8dd628cdc1b702e0c18d8327d86209aa238cb0a7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 5481861,
"name": "nusmodifications/nusmods",
"url": "https://api.github.com/repos/nusmodifications/nusmods"
} | {
"id": 445650,
"login": "ZhangYiJiang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/445650?",
"url": "https://api.github.com/users/ZhangYiJiang"
} | {
"id": 7428865,
"login": "nusmodifications",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7428865?",
"url": "https://api.github.com/orgs/nusmodifications"
} | 2017-12-29T09:01:35 | 7039735227 | {"actor":{"display_login":"ZhangYiJiang"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/comments/108926010","pull_request_review_id":29991759,"id":108926010,"diff_hunk":"@@ -0,0 +1,22 @@\n+## Deploy the application to OpenShift using a Pipeline\n+\n+When deployed with a _pipeline_ the application is built from the sources (contained in a git repository) by a continuous integration server (Jenkins) running in OpenShift.\n+\n+// turn this into a list","path":"docs/topics/OBST-vertx-crud-deploy-to-openshift-pipeline.adoc","position":null,"original_position":5,"commit_id":"7ee10687c49dcecb69719f54473e0fcdbaa5cbbe","original_commit_id":"60daee0939f7436925e9c2fdc1f924887316ce07","user":{"login":"inoxx03","id":17914654,"avatar_url":"https://avatars1.githubusercontent.com/u/17914654?v=3","gravatar_id":"","url":"https://api.github.com/users/inoxx03","html_url":"https://github.com/inoxx03","followers_url":"https://api.github.com/users/inoxx03/followers","following_url":"https://api.github.com/users/inoxx03/following{/other_user}","gists_url":"https://api.github.com/users/inoxx03/gists{/gist_id}","starred_url":"https://api.github.com/users/inoxx03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoxx03/subscriptions","organizations_url":"https://api.github.com/users/inoxx03/orgs","repos_url":"https://api.github.com/users/inoxx03/repos","events_url":"https://api.github.com/users/inoxx03/events{/privacy}","received_events_url":"https://api.github.com/users/inoxx03/received_events","type":"User","site_admin":false},"body":"^^ changed to ordered list (since the order of the steps is fixed)","created_at":"2017-03-30T13:31:38Z","updated_at":"2017-03-30T13:31:38Z","html_url":"https://github.com/obsidian-toaster/documentation/pull/12#discussion_r108926010","pull_request_url":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/comments/108926010"},"html":{"href":"https://github.com/obsidian-toaster/documentation/pull/12#discussion_r108926010"},"pull_request":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/12","id":112744516,"html_url":"https://github.com/obsidian-toaster/documentation/pull/12","diff_url":"https://github.com/obsidian-toaster/documentation/pull/12.diff","patch_url":"https://github.com/obsidian-toaster/documentation/pull/12.patch","issue_url":"https://api.github.com/repos/obsidian-toaster/documentation/issues/12","number":12,"state":"open","locked":false,"title":"EXP 101: CRUD Quickstart documentation [WIP]","user":{"login":"inoxx03","id":17914654,"avatar_url":"https://avatars1.githubusercontent.com/u/17914654?v=3","gravatar_id":"","url":"https://api.github.com/users/inoxx03","html_url":"https://github.com/inoxx03","followers_url":"https://api.github.com/users/inoxx03/followers","following_url":"https://api.github.com/users/inoxx03/following{/other_user}","gists_url":"https://api.github.com/users/inoxx03/gists{/gist_id}","starred_url":"https://api.github.com/users/inoxx03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoxx03/subscriptions","organizations_url":"https://api.github.com/users/inoxx03/orgs","repos_url":"https://api.github.com/users/inoxx03/repos","events_url":"https://api.github.com/users/inoxx03/events{/privacy}","received_events_url":"https://api.github.com/users/inoxx03/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-27T13:26:49Z","updated_at":"2017-03-30T13:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d691c326fee850acda4465c0b485e38db27b5369","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/12/commits","review_comments_url":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/12/comments","review_comment_url":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/obsidian-toaster/documentation/issues/12/comments","statuses_url":"https://api.github.com/repos/obsidian-toaster/documentation/statuses/7ee10687c49dcecb69719f54473e0fcdbaa5cbbe","head":{"label":"inoxx03:EXP-101_JDB_Quickstart_experience","ref":"EXP-101_JDB_Quickstart_experience","sha":"7ee10687c49dcecb69719f54473e0fcdbaa5cbbe","user":{"login":"inoxx03","id":17914654,"avatar_url":"https://avatars1.githubusercontent.com/u/17914654?v=3","gravatar_id":"","url":"https://api.github.com/users/inoxx03","html_url":"https://github.com/inoxx03","followers_url":"https://api.github.com/users/inoxx03/followers","following_url":"https://api.github.com/users/inoxx03/following{/other_user}","gists_url":"https://api.github.com/users/inoxx03/gists{/gist_id}","starred_url":"https://api.github.com/users/inoxx03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoxx03/subscriptions","organizations_url":"https://api.github.com/users/inoxx03/orgs","repos_url":"https://api.github.com/users/inoxx03/repos","events_url":"https://api.github.com/users/inoxx03/events{/privacy}","received_events_url":"https://api.github.com/users/inoxx03/received_events","type":"User","site_admin":false},"repo":{"id":86094089,"name":"documentation","full_name":"inoxx03/documentation","owner":{"login":"inoxx03","id":17914654,"avatar_url":"https://avatars1.githubusercontent.com/u/17914654?v=3","gravatar_id":"","url":"https://api.github.com/users/inoxx03","html_url":"https://github.com/inoxx03","followers_url":"https://api.github.com/users/inoxx03/followers","following_url":"https://api.github.com/users/inoxx03/following{/other_user}","gists_url":"https://api.github.com/users/inoxx03/gists{/gist_id}","starred_url":"https://api.github.com/users/inoxx03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoxx03/subscriptions","organizations_url":"https://api.github.com/users/inoxx03/orgs","repos_url":"https://api.github.com/users/inoxx03/repos","events_url":"https://api.github.com/users/inoxx03/events{/privacy}","received_events_url":"https://api.github.com/users/inoxx03/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inoxx03/documentation","description":null,"fork":true,"url":"https://api.github.com/repos/inoxx03/documentation","forks_url":"https://api.github.com/repos/inoxx03/documentation/forks","keys_url":"https://api.github.com/repos/inoxx03/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inoxx03/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inoxx03/documentation/teams","hooks_url":"https://api.github.com/repos/inoxx03/documentation/hooks","issue_events_url":"https://api.github.com/repos/inoxx03/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/inoxx03/documentation/events","assignees_url":"https://api.github.com/repos/inoxx03/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/inoxx03/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/inoxx03/documentation/tags","blobs_url":"https://api.github.com/repos/inoxx03/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inoxx03/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inoxx03/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/inoxx03/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inoxx03/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/inoxx03/documentation/languages","stargazers_url":"https://api.github.com/repos/inoxx03/documentation/stargazers","contributors_url":"https://api.github.com/repos/inoxx03/documentation/contributors","subscribers_url":"https://api.github.com/repos/inoxx03/documentation/subscribers","subscription_url":"https://api.github.com/repos/inoxx03/documentation/subscription","commits_url":"https://api.github.com/repos/inoxx03/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/inoxx03/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/inoxx03/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/inoxx03/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/inoxx03/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/inoxx03/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inoxx03/documentation/merges","archive_url":"https://api.github.com/repos/inoxx03/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inoxx03/documentation/downloads","issues_url":"https://api.github.com/repos/inoxx03/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/inoxx03/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/inoxx03/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/inoxx03/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inoxx03/documentation/labels{/name}","releases_url":"https://api.github.com/repos/inoxx03/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/inoxx03/documentation/deployments","created_at":"2017-03-24T17:29:40Z","updated_at":"2017-03-24T17:29:42Z","pushed_at":"2017-03-30T13:00:50Z","git_url":"git://github.com/inoxx03/documentation.git","ssh_url":"[email protected]:inoxx03/documentation.git","clone_url":"https://github.com/inoxx03/documentation.git","svn_url":"https://github.com/inoxx03/documentation","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"obsidian-toaster:master","ref":"master","sha":"68595571b79e43a98601b7ed828d165d22b3a3fa","user":{"login":"obsidian-toaster","id":23121540,"avatar_url":"https://avatars2.githubusercontent.com/u/23121540?v=3","gravatar_id":"","url":"https://api.github.com/users/obsidian-toaster","html_url":"https://github.com/obsidian-toaster","followers_url":"https://api.github.com/users/obsidian-toaster/followers","following_url":"https://api.github.com/users/obsidian-toaster/following{/other_user}","gists_url":"https://api.github.com/users/obsidian-toaster/gists{/gist_id}","starred_url":"https://api.github.com/users/obsidian-toaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsidian-toaster/subscriptions","organizations_url":"https://api.github.com/users/obsidian-toaster/orgs","repos_url":"https://api.github.com/users/obsidian-toaster/repos","events_url":"https://api.github.com/users/obsidian-toaster/events{/privacy}","received_events_url":"https://api.github.com/users/obsidian-toaster/received_events","type":"Organization","site_admin":false},"repo":{"id":85718759,"name":"documentation","full_name":"obsidian-toaster/documentation","owner":{"login":"obsidian-toaster","id":23121540,"avatar_url":"https://avatars2.githubusercontent.com/u/23121540?v=3","gravatar_id":"","url":"https://api.github.com/users/obsidian-toaster","html_url":"https://github.com/obsidian-toaster","followers_url":"https://api.github.com/users/obsidian-toaster/followers","following_url":"https://api.github.com/users/obsidian-toaster/following{/other_user}","gists_url":"https://api.github.com/users/obsidian-toaster/gists{/gist_id}","starred_url":"https://api.github.com/users/obsidian-toaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obsidian-toaster/subscriptions","organizations_url":"https://api.github.com/users/obsidian-toaster/orgs","repos_url":"https://api.github.com/users/obsidian-toaster/repos","events_url":"https://api.github.com/users/obsidian-toaster/events{/privacy}","received_events_url":"https://api.github.com/users/obsidian-toaster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/obsidian-toaster/documentation","description":null,"fork":false,"url":"https://api.github.com/repos/obsidian-toaster/documentation","forks_url":"https://api.github.com/repos/obsidian-toaster/documentation/forks","keys_url":"https://api.github.com/repos/obsidian-toaster/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obsidian-toaster/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obsidian-toaster/documentation/teams","hooks_url":"https://api.github.com/repos/obsidian-toaster/documentation/hooks","issue_events_url":"https://api.github.com/repos/obsidian-toaster/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/obsidian-toaster/documentation/events","assignees_url":"https://api.github.com/repos/obsidian-toaster/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/obsidian-toaster/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/obsidian-toaster/documentation/tags","blobs_url":"https://api.github.com/repos/obsidian-toaster/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obsidian-toaster/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obsidian-toaster/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/obsidian-toaster/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obsidian-toaster/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/obsidian-toaster/documentation/languages","stargazers_url":"https://api.github.com/repos/obsidian-toaster/documentation/stargazers","contributors_url":"https://api.github.com/repos/obsidian-toaster/documentation/contributors","subscribers_url":"https://api.github.com/repos/obsidian-toaster/documentation/subscribers","subscription_url":"https://api.github.com/repos/obsidian-toaster/documentation/subscription","commits_url":"https://api.github.com/repos/obsidian-toaster/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/obsidian-toaster/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/obsidian-toaster/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/obsidian-toaster/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/obsidian-toaster/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/obsidian-toaster/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obsidian-toaster/documentation/merges","archive_url":"https://api.github.com/repos/obsidian-toaster/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obsidian-toaster/documentation/downloads","issues_url":"https://api.github.com/repos/obsidian-toaster/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/obsidian-toaster/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/obsidian-toaster/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/obsidian-toaster/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obsidian-toaster/documentation/labels{/name}","releases_url":"https://api.github.com/repos/obsidian-toaster/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/obsidian-toaster/documentation/deployments","created_at":"2017-03-21T15:27:12Z","updated_at":"2017-03-22T22:26:15Z","pushed_at":"2017-03-30T13:00:52Z","git_url":"git://github.com/obsidian-toaster/documentation.git","ssh_url":"[email protected]:obsidian-toaster/documentation.git","clone_url":"https://github.com/obsidian-toaster/documentation.git","svn_url":"https://github.com/obsidian-toaster/documentation","homepage":null,"size":32,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/12"},"html":{"href":"https://github.com/obsidian-toaster/documentation/pull/12"},"issue":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/issues/12"},"comments":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/obsidian-toaster/documentation/statuses/7ee10687c49dcecb69719f54473e0fcdbaa5cbbe"}}}} | {
"id": 85718759,
"name": "obsidian-toaster/documentation",
"url": "https://api.github.com/repos/obsidian-toaster/documentation"
} | {
"id": 17914654,
"login": "inoxx03",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17914654?",
"url": "https://api.github.com/users/inoxx03"
} | {
"id": 23121540,
"login": "obsidian-toaster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23121540?",
"url": "https://api.github.com/orgs/obsidian-toaster"
} | 2017-03-30T13:31:38 | 5595316354 | {"actor":{"display_login":"inoxx03"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/comments/130828250","pull_request_review_id":53744597,"id":130828250,"diff_hunk":"@@ -0,0 +1,48 @@\n+package com.redhat.che.keycloak.shared;\n+\n+import java.io.BufferedReader;\n+import java.io.IOException;\n+import java.io.InputStreamReader;\n+import java.net.HttpURLConnection;\n+import java.net.URL;\n+import java.util.Map;\n+\n+import java.util.logging.Logger;","path":"builds/fabric8-che/plugins/keycloak-plugin-shared/src/main/java/com/redhat/che/keycloak/shared/KeycloakSettings.java","position":10,"original_position":10,"commit_id":"9ee2053c87ee4c16a8ee4ca8a62500c22ae44e5b","original_commit_id":"9ee2053c87ee4c16a8ee4ca8a62500c22ae44e5b","user":{"login":"davidfestal","id":686586,"avatar_url":"https://avatars1.githubusercontent.com/u/686586?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfestal","html_url":"https://github.com/davidfestal","followers_url":"https://api.github.com/users/davidfestal/followers","following_url":"https://api.github.com/users/davidfestal/following{/other_user}","gists_url":"https://api.github.com/users/davidfestal/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfestal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfestal/subscriptions","organizations_url":"https://api.github.com/users/davidfestal/orgs","repos_url":"https://api.github.com/users/davidfestal/repos","events_url":"https://api.github.com/users/davidfestal/events{/privacy}","received_events_url":"https://api.github.com/users/davidfestal/received_events","type":"User","site_admin":false},"body":"yes, but the valve doesn't live in a web application context, and at start there were problems at runtime when using SLF4J (don't remember exactly the details) ","created_at":"2017-08-02T09:28:12Z","updated_at":"2017-08-02T09:28:12Z","html_url":"https://github.com/redhat-developer/rh-che/pull/235#discussion_r130828250","pull_request_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/235","_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/comments/130828250"},"html":{"href":"https://github.com/redhat-developer/rh-che/pull/235#discussion_r130828250"},"pull_request":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/235","id":133247350,"html_url":"https://github.com/redhat-developer/rh-che/pull/235","diff_url":"https://github.com/redhat-developer/rh-che/pull/235.diff","patch_url":"https://github.com/redhat-developer/rh-che/pull/235.patch","issue_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/235","number":235,"state":"open","locked":false,"title":"Configure Keycloak in the wsmaster properties, and make settings available through REST","user":{"login":"davidfestal","id":686586,"avatar_url":"https://avatars1.githubusercontent.com/u/686586?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfestal","html_url":"https://github.com/davidfestal","followers_url":"https://api.github.com/users/davidfestal/followers","following_url":"https://api.github.com/users/davidfestal/following{/other_user}","gists_url":"https://api.github.com/users/davidfestal/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfestal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfestal/subscriptions","organizations_url":"https://api.github.com/users/davidfestal/orgs","repos_url":"https://api.github.com/users/davidfestal/repos","events_url":"https://api.github.com/users/davidfestal/events{/privacy}","received_events_url":"https://api.github.com/users/davidfestal/received_events","type":"User","site_admin":false},"body":"This pull request allows configuring the main Keycloak settings (realm, auth URL, etc... as well as endpoints to retrieve associated tokens such as git) in the wsmaster properties. The settings are centralized in the wsmaster, and pulled through the `wsmaster/api/keycloak/settings` endpoint from the other places that need them: user-auth tomcat valve, wsagent, and client-side JavaScript code.\r\n\r\nThere is no need for `Keycloak.json` files anymore, since Keycloak configurations are now managed centrally by `KeycloakConfigResolver` classes for both the *UI* web applications (GWT application) and the *services* web applications (wsmaster and wsagent). Using `KeycloakConfigResolver`s allows centralizing the Keycloak settings in a single place in both the source code and the deployment, but was required anyway for the tomcat valve, due to specifics of the valve lifecycle.\r\n\r\nThis is the implementation of https://github.com/redhat-developer/rh-che/issues/133#issuecomment-316663409","created_at":"2017-07-31T13:38:23Z","updated_at":"2017-08-02T09:28:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdad57ace81334ef856399fd1e1c65e488f9db02","assignee":{"login":"davidfestal","id":686586,"avatar_url":"https://avatars1.githubusercontent.com/u/686586?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfestal","html_url":"https://github.com/davidfestal","followers_url":"https://api.github.com/users/davidfestal/followers","following_url":"https://api.github.com/users/davidfestal/following{/other_user}","gists_url":"https://api.github.com/users/davidfestal/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfestal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfestal/subscriptions","organizations_url":"https://api.github.com/users/davidfestal/orgs","repos_url":"https://api.github.com/users/davidfestal/repos","events_url":"https://api.github.com/users/davidfestal/events{/privacy}","received_events_url":"https://api.github.com/users/davidfestal/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidfestal","id":686586,"avatar_url":"https://avatars1.githubusercontent.com/u/686586?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfestal","html_url":"https://github.com/davidfestal","followers_url":"https://api.github.com/users/davidfestal/followers","following_url":"https://api.github.com/users/davidfestal/following{/other_user}","gists_url":"https://api.github.com/users/davidfestal/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfestal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfestal/subscriptions","organizations_url":"https://api.github.com/users/davidfestal/orgs","repos_url":"https://api.github.com/users/davidfestal/repos","events_url":"https://api.github.com/users/davidfestal/events{/privacy}","received_events_url":"https://api.github.com/users/davidfestal/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"l0rd","id":606959,"avatar_url":"https://avatars2.githubusercontent.com/u/606959?v=4","gravatar_id":"","url":"https://api.github.com/users/l0rd","html_url":"https://github.com/l0rd","followers_url":"https://api.github.com/users/l0rd/followers","following_url":"https://api.github.com/users/l0rd/following{/other_user}","gists_url":"https://api.github.com/users/l0rd/gists{/gist_id}","starred_url":"https://api.github.com/users/l0rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l0rd/subscriptions","organizations_url":"https://api.github.com/users/l0rd/orgs","repos_url":"https://api.github.com/users/l0rd/repos","events_url":"https://api.github.com/users/l0rd/events{/privacy}","received_events_url":"https://api.github.com/users/l0rd/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/235/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/235/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/235/comments","statuses_url":"https://api.github.com/repos/redhat-developer/rh-che/statuses/9ee2053c87ee4c16a8ee4ca8a62500c22ae44e5b","head":{"label":"davidfestal:rh-che-133","ref":"rh-che-133","sha":"9ee2053c87ee4c16a8ee4ca8a62500c22ae44e5b","user":{"login":"davidfestal","id":686586,"avatar_url":"https://avatars1.githubusercontent.com/u/686586?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfestal","html_url":"https://github.com/davidfestal","followers_url":"https://api.github.com/users/davidfestal/followers","following_url":"https://api.github.com/users/davidfestal/following{/other_user}","gists_url":"https://api.github.com/users/davidfestal/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfestal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfestal/subscriptions","organizations_url":"https://api.github.com/users/davidfestal/orgs","repos_url":"https://api.github.com/users/davidfestal/repos","events_url":"https://api.github.com/users/davidfestal/events{/privacy}","received_events_url":"https://api.github.com/users/davidfestal/received_events","type":"User","site_admin":false},"repo":{"id":86846560,"name":"rh-che","full_name":"davidfestal/rh-che","owner":{"login":"davidfestal","id":686586,"avatar_url":"https://avatars1.githubusercontent.com/u/686586?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfestal","html_url":"https://github.com/davidfestal","followers_url":"https://api.github.com/users/davidfestal/followers","following_url":"https://api.github.com/users/davidfestal/following{/other_user}","gists_url":"https://api.github.com/users/davidfestal/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfestal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfestal/subscriptions","organizations_url":"https://api.github.com/users/davidfestal/orgs","repos_url":"https://api.github.com/users/davidfestal/repos","events_url":"https://api.github.com/users/davidfestal/events{/privacy}","received_events_url":"https://api.github.com/users/davidfestal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidfestal/rh-che","description":"Red Hat Che distribution repository","fork":true,"url":"https://api.github.com/repos/davidfestal/rh-che","forks_url":"https://api.github.com/repos/davidfestal/rh-che/forks","keys_url":"https://api.github.com/repos/davidfestal/rh-che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidfestal/rh-che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidfestal/rh-che/teams","hooks_url":"https://api.github.com/repos/davidfestal/rh-che/hooks","issue_events_url":"https://api.github.com/repos/davidfestal/rh-che/issues/events{/number}","events_url":"https://api.github.com/repos/davidfestal/rh-che/events","assignees_url":"https://api.github.com/repos/davidfestal/rh-che/assignees{/user}","branches_url":"https://api.github.com/repos/davidfestal/rh-che/branches{/branch}","tags_url":"https://api.github.com/repos/davidfestal/rh-che/tags","blobs_url":"https://api.github.com/repos/davidfestal/rh-che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidfestal/rh-che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidfestal/rh-che/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidfestal/rh-che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidfestal/rh-che/statuses/{sha}","languages_url":"https://api.github.com/repos/davidfestal/rh-che/languages","stargazers_url":"https://api.github.com/repos/davidfestal/rh-che/stargazers","contributors_url":"https://api.github.com/repos/davidfestal/rh-che/contributors","subscribers_url":"https://api.github.com/repos/davidfestal/rh-che/subscribers","subscription_url":"https://api.github.com/repos/davidfestal/rh-che/subscription","commits_url":"https://api.github.com/repos/davidfestal/rh-che/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidfestal/rh-che/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidfestal/rh-che/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidfestal/rh-che/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidfestal/rh-che/contents/{+path}","compare_url":"https://api.github.com/repos/davidfestal/rh-che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidfestal/rh-che/merges","archive_url":"https://api.github.com/repos/davidfestal/rh-che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidfestal/rh-che/downloads","issues_url":"https://api.github.com/repos/davidfestal/rh-che/issues{/number}","pulls_url":"https://api.github.com/repos/davidfestal/rh-che/pulls{/number}","milestones_url":"https://api.github.com/repos/davidfestal/rh-che/milestones{/number}","notifications_url":"https://api.github.com/repos/davidfestal/rh-che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidfestal/rh-che/labels{/name}","releases_url":"https://api.github.com/repos/davidfestal/rh-che/releases{/id}","deployments_url":"https://api.github.com/repos/davidfestal/rh-che/deployments","created_at":"2017-03-31T17:59:12Z","updated_at":"2017-06-15T13:10:11Z","pushed_at":"2017-08-01T15:23:53Z","git_url":"git://github.com/davidfestal/rh-che.git","ssh_url":"[email protected]:davidfestal/rh-che.git","clone_url":"https://github.com/davidfestal/rh-che.git","svn_url":"https://github.com/davidfestal/rh-che","homepage":"","size":2644,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"redhat-developer:master","ref":"master","sha":"aed49508d696d689fdd0eefcda4200e50b0ec163","user":{"login":"redhat-developer","id":11033755,"avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":73191871,"name":"rh-che","full_name":"redhat-developer/rh-che","owner":{"login":"redhat-developer","id":11033755,"avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-developer/rh-che","description":"Red Hat Che distribution repository","fork":false,"url":"https://api.github.com/repos/redhat-developer/rh-che","forks_url":"https://api.github.com/repos/redhat-developer/rh-che/forks","keys_url":"https://api.github.com/repos/redhat-developer/rh-che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/rh-che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/rh-che/teams","hooks_url":"https://api.github.com/repos/redhat-developer/rh-che/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/rh-che/events","assignees_url":"https://api.github.com/repos/redhat-developer/rh-che/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/rh-che/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/rh-che/tags","blobs_url":"https://api.github.com/repos/redhat-developer/rh-che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/rh-che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/rh-che/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/rh-che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/rh-che/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/rh-che/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/rh-che/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/rh-che/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/rh-che/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/rh-che/subscription","commits_url":"https://api.github.com/repos/redhat-developer/rh-che/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/rh-che/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/rh-che/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/rh-che/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/rh-che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/rh-che/merges","archive_url":"https://api.github.com/repos/redhat-developer/rh-che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/rh-che/downloads","issues_url":"https://api.github.com/repos/redhat-developer/rh-che/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/rh-che/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/rh-che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/rh-che/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/rh-che/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/rh-che/deployments","created_at":"2016-11-08T14:09:37Z","updated_at":"2017-08-01T15:18:18Z","pushed_at":"2017-08-02T08:54:48Z","git_url":"git://github.com/redhat-developer/rh-che.git","ssh_url":"[email protected]:redhat-developer/rh-che.git","clone_url":"https://github.com/redhat-developer/rh-che.git","svn_url":"https://github.com/redhat-developer/rh-che","homepage":"","size":2567,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":62,"forks":18,"open_issues":62,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/235"},"html":{"href":"https://github.com/redhat-developer/rh-che/pull/235"},"issue":{"href":"https://api.github.com/repos/redhat-developer/rh-che/issues/235"},"comments":{"href":"https://api.github.com/repos/redhat-developer/rh-che/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/rh-che/statuses/9ee2053c87ee4c16a8ee4ca8a62500c22ae44e5b"}}}} | {
"id": 73191871,
"name": "redhat-developer/rh-che",
"url": "https://api.github.com/repos/redhat-developer/rh-che"
} | {
"id": 686586,
"login": "davidfestal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/686586?",
"url": "https://api.github.com/users/davidfestal"
} | {
"id": 11033755,
"login": "redhat-developer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11033755?",
"url": "https://api.github.com/orgs/redhat-developer"
} | 2017-08-02T09:28:12 | 6377204511 | {"actor":{"display_login":"davidfestal"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/comments/133461556","pull_request_review_id":56644397,"id":133461556,"diff_hunk":"@@ -65,57 +68,38 @@ Function Get-DbaSqlService {\n \tParam (\n \t\t[parameter(ValueFromPipeline = $true)]\n \t\t[Alias(\"cn\", \"host\", \"Server\")]\n-\t\t[string[]]$ComputerName = $env:COMPUTERNAME,\n+\t\t[DbaInstanceParameter[]]$ComputerName = $env:COMPUTERNAME,\n \t\t[Alias(\"Instance\")]\n \t\t[string[]]$InstanceName,\n \t\t[PSCredential]$Credential,\n-\t\t[ValidateSet(\"Agent\", \"Browser\", \"Engine\", \"FullText\", \"SSAS\", \"SSIS\", \"SSRS\", \"AnalysisServer\", \"ReportServer\", \"Search\", \"SqlAgent\", \"SqlBrowser\", \"SqlServer\", \"SqlServerIntegrationService\")]\n+\t\t[ValidateSet(\"Agent\", \"Browser\", \"Engine\", \"FullText\", \"SSAS\", \"SSIS\", \"SSRS\", \"AnalysisServer\", \"ReportServer\", \"FullTextFilter Daemon Launcher\", \"FullText Search\", \"SqlAgent\", \"SqlBrowser\", \"SqlServer\", \"SqlServerIntegrationService\")]","path":"functions/Get-DbaSqlService.ps1","position":20,"original_position":20,"commit_id":"4ab0d59ac398f38feba7ec5963612f8e0572b822","original_commit_id":"4ab0d59ac398f38feba7ec5963612f8e0572b822","user":{"login":"wsmelton","id":11204251,"avatar_url":"https://avatars2.githubusercontent.com/u/11204251?v=4","gravatar_id":"","url":"https://api.github.com/users/wsmelton","html_url":"https://github.com/wsmelton","followers_url":"https://api.github.com/users/wsmelton/followers","following_url":"https://api.github.com/users/wsmelton/following{/other_user}","gists_url":"https://api.github.com/users/wsmelton/gists{/gist_id}","starred_url":"https://api.github.com/users/wsmelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsmelton/subscriptions","organizations_url":"https://api.github.com/users/wsmelton/orgs","repos_url":"https://api.github.com/users/wsmelton/repos","events_url":"https://api.github.com/users/wsmelton/events{/privacy}","received_events_url":"https://api.github.com/users/wsmelton/received_events","type":"User","site_admin":false},"body":"There is already code break...the command is in a previous PR to be rewritten already. We need to pick one because you have to tab 15 times to get to `SqlServerIntegrationService`. I would go for the short names and see no reason to have it standardized to a corresponding SMO object.\r\n\r\nI believe the original purpose of the shorter names was to map those to the publicly-known name the services are referenced by.","created_at":"2017-08-16T14:14:32Z","updated_at":"2017-08-16T14:14:32Z","html_url":"https://github.com/sqlcollaborative/dbatools/pull/2050#discussion_r133461556","pull_request_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2050","_links":{"self":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/comments/133461556"},"html":{"href":"https://github.com/sqlcollaborative/dbatools/pull/2050#discussion_r133461556"},"pull_request":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2050"}}},"pull_request":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2050","id":134746956,"html_url":"https://github.com/sqlcollaborative/dbatools/pull/2050","diff_url":"https://github.com/sqlcollaborative/dbatools/pull/2050.diff","patch_url":"https://github.com/sqlcollaborative/dbatools/pull/2050.patch","issue_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/2050","number":2050,"state":"open","locked":false,"title":"Update/New Commands - Get-DbaSqlService, Stop/Start/Restart-DbaSqlService","user":{"login":"nvarscar","id":30303784,"avatar_url":"https://avatars3.githubusercontent.com/u/30303784?v=4","gravatar_id":"","url":"https://api.github.com/users/nvarscar","html_url":"https://github.com/nvarscar","followers_url":"https://api.github.com/users/nvarscar/followers","following_url":"https://api.github.com/users/nvarscar/following{/other_user}","gists_url":"https://api.github.com/users/nvarscar/gists{/gist_id}","starred_url":"https://api.github.com/users/nvarscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvarscar/subscriptions","organizations_url":"https://api.github.com/users/nvarscar/orgs","repos_url":"https://api.github.com/users/nvarscar/repos","events_url":"https://api.github.com/users/nvarscar/events{/privacy}","received_events_url":"https://api.github.com/users/nvarscar/received_events","type":"User","site_admin":false},"body":"<!-- Below information IS REQUIRED with every PR -->\r\n## Type of Change\r\n<!-- What type of change does your code introduce -->\r\n - [ ] Bug fix (non-breaking change, fixes #<enter issue number>)\r\n - [x] New feature (non-breaking change, adds functionality)\r\n - [ ] Breaking change (effects multiple commands or functionality)\r\n - [ ] Ran manual Pester test and has passed (`.\\tests\\manual.pester.ps1)\r\n - [x] Pester test is included\r\n<!-- Below this line you can erase anything that is not applicable -->\r\n### Purpose\r\nSubmitting updated code to match the dbatools/sqlservice branch.\r\nAlso, adding some more error handling to the Update-DbaSqlServiceStatus procedure\r\n\r\n### Approach\r\nMoved corresponding lines from the dbatools/sqlservice branch that use Get-DbaCmObject instead of Get-CimInstance\r\n\r\n### Commands to test\r\nGet-DbaSqlService, Stop/Start/Restart-DbaSqlService\r\n\r\n### Screenshots\r\nn/a\r\n\r\n### Learning\r\nGet-DbaCmObject seems to be a much better option.","created_at":"2017-08-08T20:06:48Z","updated_at":"2017-08-16T14:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"817297845cbfd7a9be53ff00e3075dff1926da46","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2050/commits","review_comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2050/comments","review_comment_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/2050/comments","statuses_url":"https://api.github.com/repos/sqlcollaborative/dbatools/statuses/4ab0d59ac398f38feba7ec5963612f8e0572b822","head":{"label":"nvarscar:sqlservicenvarscar","ref":"sqlservicenvarscar","sha":"4ab0d59ac398f38feba7ec5963612f8e0572b822","user":{"login":"nvarscar","id":30303784,"avatar_url":"https://avatars3.githubusercontent.com/u/30303784?v=4","gravatar_id":"","url":"https://api.github.com/users/nvarscar","html_url":"https://github.com/nvarscar","followers_url":"https://api.github.com/users/nvarscar/followers","following_url":"https://api.github.com/users/nvarscar/following{/other_user}","gists_url":"https://api.github.com/users/nvarscar/gists{/gist_id}","starred_url":"https://api.github.com/users/nvarscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvarscar/subscriptions","organizations_url":"https://api.github.com/users/nvarscar/orgs","repos_url":"https://api.github.com/users/nvarscar/repos","events_url":"https://api.github.com/users/nvarscar/events{/privacy}","received_events_url":"https://api.github.com/users/nvarscar/received_events","type":"User","site_admin":false},"repo":{"id":99722469,"name":"dbatools-nvarscar","full_name":"nvarscar/dbatools-nvarscar","owner":{"login":"nvarscar","id":30303784,"avatar_url":"https://avatars3.githubusercontent.com/u/30303784?v=4","gravatar_id":"","url":"https://api.github.com/users/nvarscar","html_url":"https://github.com/nvarscar","followers_url":"https://api.github.com/users/nvarscar/followers","following_url":"https://api.github.com/users/nvarscar/following{/other_user}","gists_url":"https://api.github.com/users/nvarscar/gists{/gist_id}","starred_url":"https://api.github.com/users/nvarscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvarscar/subscriptions","organizations_url":"https://api.github.com/users/nvarscar/orgs","repos_url":"https://api.github.com/users/nvarscar/repos","events_url":"https://api.github.com/users/nvarscar/events{/privacy}","received_events_url":"https://api.github.com/users/nvarscar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nvarscar/dbatools-nvarscar","description":"PowerShell module to help SQL Server Pros be more productive","fork":true,"url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar","forks_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/forks","keys_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/teams","hooks_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/hooks","issue_events_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/issues/events{/number}","events_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/events","assignees_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/assignees{/user}","branches_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/branches{/branch}","tags_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/tags","blobs_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/statuses/{sha}","languages_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/languages","stargazers_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/stargazers","contributors_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/contributors","subscribers_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/subscribers","subscription_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/subscription","commits_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/contents/{+path}","compare_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/merges","archive_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/downloads","issues_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/issues{/number}","pulls_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/pulls{/number}","milestones_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/milestones{/number}","notifications_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/labels{/name}","releases_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/releases{/id}","deployments_url":"https://api.github.com/repos/nvarscar/dbatools-nvarscar/deployments","created_at":"2017-08-08T18:09:05Z","updated_at":"2017-08-08T18:09:40Z","pushed_at":"2017-08-15T21:34:43Z","git_url":"git://github.com/nvarscar/dbatools-nvarscar.git","ssh_url":"[email protected]:nvarscar/dbatools-nvarscar.git","clone_url":"https://github.com/nvarscar/dbatools-nvarscar.git","svn_url":"https://github.com/nvarscar/dbatools-nvarscar","homepage":"https://dbatools.io","size":26415,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"sqlservicenvarscar"}},"base":{"label":"sqlcollaborative:sqlservicenvarscar","ref":"sqlservicenvarscar","sha":"5f3e9d4e873d4f88056da20fe4f8d561a2d71d50","user":{"login":"sqlcollaborative","id":22203347,"avatar_url":"https://avatars3.githubusercontent.com/u/22203347?v=4","gravatar_id":"","url":"https://api.github.com/users/sqlcollaborative","html_url":"https://github.com/sqlcollaborative","followers_url":"https://api.github.com/users/sqlcollaborative/followers","following_url":"https://api.github.com/users/sqlcollaborative/following{/other_user}","gists_url":"https://api.github.com/users/sqlcollaborative/gists{/gist_id}","starred_url":"https://api.github.com/users/sqlcollaborative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqlcollaborative/subscriptions","organizations_url":"https://api.github.com/users/sqlcollaborative/orgs","repos_url":"https://api.github.com/users/sqlcollaborative/repos","events_url":"https://api.github.com/users/sqlcollaborative/events{/privacy}","received_events_url":"https://api.github.com/users/sqlcollaborative/received_events","type":"Organization","site_admin":false},"repo":{"id":30215226,"name":"dbatools","full_name":"sqlcollaborative/dbatools","owner":{"login":"sqlcollaborative","id":22203347,"avatar_url":"https://avatars3.githubusercontent.com/u/22203347?v=4","gravatar_id":"","url":"https://api.github.com/users/sqlcollaborative","html_url":"https://github.com/sqlcollaborative","followers_url":"https://api.github.com/users/sqlcollaborative/followers","following_url":"https://api.github.com/users/sqlcollaborative/following{/other_user}","gists_url":"https://api.github.com/users/sqlcollaborative/gists{/gist_id}","starred_url":"https://api.github.com/users/sqlcollaborative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqlcollaborative/subscriptions","organizations_url":"https://api.github.com/users/sqlcollaborative/orgs","repos_url":"https://api.github.com/users/sqlcollaborative/repos","events_url":"https://api.github.com/users/sqlcollaborative/events{/privacy}","received_events_url":"https://api.github.com/users/sqlcollaborative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sqlcollaborative/dbatools","description":"PowerShell module to help SQL Server Pros be more productive","fork":false,"url":"https://api.github.com/repos/sqlcollaborative/dbatools","forks_url":"https://api.github.com/repos/sqlcollaborative/dbatools/forks","keys_url":"https://api.github.com/repos/sqlcollaborative/dbatools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sqlcollaborative/dbatools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sqlcollaborative/dbatools/teams","hooks_url":"https://api.github.com/repos/sqlcollaborative/dbatools/hooks","issue_events_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/events{/number}","events_url":"https://api.github.com/repos/sqlcollaborative/dbatools/events","assignees_url":"https://api.github.com/repos/sqlcollaborative/dbatools/assignees{/user}","branches_url":"https://api.github.com/repos/sqlcollaborative/dbatools/branches{/branch}","tags_url":"https://api.github.com/repos/sqlcollaborative/dbatools/tags","blobs_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/refs{/sha}","trees_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sqlcollaborative/dbatools/statuses/{sha}","languages_url":"https://api.github.com/repos/sqlcollaborative/dbatools/languages","stargazers_url":"https://api.github.com/repos/sqlcollaborative/dbatools/stargazers","contributors_url":"https://api.github.com/repos/sqlcollaborative/dbatools/contributors","subscribers_url":"https://api.github.com/repos/sqlcollaborative/dbatools/subscribers","subscription_url":"https://api.github.com/repos/sqlcollaborative/dbatools/subscription","commits_url":"https://api.github.com/repos/sqlcollaborative/dbatools/commits{/sha}","git_commits_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/commits{/sha}","comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/comments{/number}","issue_comment_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/comments{/number}","contents_url":"https://api.github.com/repos/sqlcollaborative/dbatools/contents/{+path}","compare_url":"https://api.github.com/repos/sqlcollaborative/dbatools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sqlcollaborative/dbatools/merges","archive_url":"https://api.github.com/repos/sqlcollaborative/dbatools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sqlcollaborative/dbatools/downloads","issues_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues{/number}","pulls_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls{/number}","milestones_url":"https://api.github.com/repos/sqlcollaborative/dbatools/milestones{/number}","notifications_url":"https://api.github.com/repos/sqlcollaborative/dbatools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sqlcollaborative/dbatools/labels{/name}","releases_url":"https://api.github.com/repos/sqlcollaborative/dbatools/releases{/id}","deployments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/deployments","created_at":"2015-02-02T23:50:31Z","updated_at":"2017-08-16T08:56:00Z","pushed_at":"2017-08-16T11:41:37Z","git_url":"git://github.com/sqlcollaborative/dbatools.git","ssh_url":"[email protected]:sqlcollaborative/dbatools.git","clone_url":"https://github.com/sqlcollaborative/dbatools.git","svn_url":"https://github.com/sqlcollaborative/dbatools","homepage":"https://dbatools.io","size":26708,"stargazers_count":366,"watchers_count":366,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"open_issues_count":212,"forks":208,"open_issues":212,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2050"},"html":{"href":"https://github.com/sqlcollaborative/dbatools/pull/2050"},"issue":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/2050"},"comments":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/2050/comments"},"review_comments":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2050/comments"},"review_comment":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2050/commits"},"statuses":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/statuses/4ab0d59ac398f38feba7ec5963612f8e0572b822"}}}} | {
"id": 30215226,
"name": "sqlcollaborative/dbatools",
"url": "https://api.github.com/repos/sqlcollaborative/dbatools"
} | {
"id": 11204251,
"login": "wsmelton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11204251?",
"url": "https://api.github.com/users/wsmelton"
} | {
"id": 22203347,
"login": "sqlcollaborative",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22203347?",
"url": "https://api.github.com/orgs/sqlcollaborative"
} | 2017-08-16T14:14:32 | 6463935429 | {"actor":{"display_login":"wsmelton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/comments/111797414","pull_request_review_id":33063843,"id":111797414,"diff_hunk":"@@ -0,0 +1,221 @@\n+package edu.umich.ctools.sectionsUtilityTool;\n+\n+import org.apache.commons.logging.Log;\n+import org.apache.commons.logging.LogFactory;\n+import org.apache.http.HttpStatus;\n+import org.apache.http.client.methods.HttpGet;\n+import org.json.JSONArray;\n+import org.json.JSONException;\n+import org.json.JSONObject;\n+\n+import javax.activation.DataHandler;\n+import javax.mail.*;\n+import javax.mail.internet.InternetAddress;\n+import javax.mail.internet.MimeBodyPart;\n+import javax.mail.internet.MimeMessage;\n+import javax.mail.internet.MimeMultipart;\n+import javax.mail.util.ByteArrayDataSource;\n+import java.util.Iterator;\n+import java.util.List;\n+import java.util.Properties;\n+\n+/**\n+ * Created by pushyami on 4/7/17.\n+ */\n+public class SISPollingThread implements Runnable {\n+\tprivate static Log M_log = LogFactory.getLog(SISPollingThread.class);\n+\n+\tvolatile boolean flag = true;\n+\tProperties appExtPropertiesFile = SectionsUtilityToolServlet.appExtPropertiesFile;\n+\tprivate int pollingAttempts =Integer.valueOf(appExtPropertiesFile.getProperty(Utils.SIS_POLLING_ATTEMPTS));\n+\tprivate int pollingFrequency =Integer.valueOf(appExtPropertiesFile.getProperty(Utils.SIS_POLLING_FREQUENCY));\n+\n+\n+\t@Override\n+\tpublic void run() {\n+\t\twhile (flag) {\n+\t\t\tM_log.debug(\"***************************** Starting polling Thread\");\n+\t\t\tList<SISDataHolderForEmail> pollingId = SectionsUtilityToolServlet.canvasPollingIds;\n+\t\t\tlistOFPolls(pollingId);\n+\t\t\tIterator<SISDataHolderForEmail> iterator = pollingId.iterator();\n+\t\t\twhile (iterator.hasNext()) {\n+\t\t\t\tSISDataHolderForEmail emailData = iterator.next();\n+\t\t\t\tM_log.debug(String.format(\"Number of attempts by for job %s are %s \"\n+\t\t\t\t\t\t, emailData.getPollingId(), emailData.getNumberOfTries()));\n+\t\t\t\tif (emailData.getNumberOfTries() >= pollingAttempts) {\n+\t\t\t\t\temailData.setSISUploadFailed(true);\n+\t\t\t\t\tsendEmailReport(emailData, null);\n+\t\t\t\t\titerator.remove();\n+\t\t\t\t}\n+\t\t\t\tApiResultWrapper arw = sisApiCallCheckingJobStatus(emailData);\n+\t\t\t\tint status = arw.getStatus();\n+\n+\t\t\t\tif (status != HttpStatus.SC_OK) {\n+\t\t\t\t\tM_log.warn(String.format(\"SIS polling call failed with status code %s due to %s\"\n+\t\t\t\t\t\t\t, status, arw.getMessage()));\n+\t\t\t\t\temailData.setNumberOfTries(1);\n+\t\t\t\t\tcontinue;\n+\t\t\t\t}\n+\n+\t\t\t\tString apiResp = arw.getApiResp();\n+\t\t\t\tif (!isSISUploadDone(apiResp)) {\n+\t\t\t\t\temailData.setNumberOfTries(1);\n+\t\t\t\t\tcontinue;\n+\t\t\t\t}\n+\t\t\t\tsendEmailReport(emailData, apiResp);\n+\t\t\t\titerator.remove();\n+\n+\t\t\t}\n+\t\t\tlistOFPolls(pollingId);\n+\t\t\tM_log.debug(\"***************************** Finish polling Thread\");\n+\n+\t\t\ttry {\n+\t\t\t\tThread.sleep(pollingFrequency);\n+\t\t\t} catch (InterruptedException e) {\n+\t\t\t\tM_log.error(\"Canvas polling thread got Interrupted due to \"+e.getMessage());\n+\t\t\t} catch (Exception e) {\n+\t\t\t\tM_log.error(\"Canvas polling thread got Interrupted due to \"+e.getMessage());\n+\t\t\t}\n+\n+\t\t}\n+\n+\t}\n+\n+\tprivate void listOFPolls(List<SISDataHolderForEmail> pollingId) {\n+\t\tfor (SISDataHolderForEmail daa: pollingId){\n+\t\tM_log.debug(\"PollingList\" +daa.getPollingId());\n+\t\t}\n+\t}\n+\n+\tpublic static boolean isSISUploadDone(String apiResp){\n+\t\tM_log.debug(\"isSISUploadDone() call\");\n+\t\tJSONObject resp = new JSONObject(apiResp);\n+\t\tint progress = (int) resp.get(\"progress\");\n+\t\tif (progress == 100) {\n+\t\t\treturn true;\n+\t\t}\n+\t\treturn false;\n+\n+\t}\n+\n+\tprivate ApiResultWrapper sisApiCallCheckingJobStatus(SISDataHolderForEmail data) {\n+\t\tString url = Utils.urlConstructor(\"/accounts/1/sis_imports/\", String.valueOf(data.getPollingId()));\n+\t\tApiResultWrapper arw = Utils.makeApiCall(new HttpGet(url));\n+\t\treturn arw;\n+\t}\n+\n+\tpublic void sendEmailReport(SISDataHolderForEmail data, String apiResp) {\n+\t\tM_log.debug(\"sendEmailReport(): Called\");\n+\t\tString fromAddress = appExtPropertiesFile.getProperty(Utils.FRIEND_CONTACT_EMAIL);\n+\t\tString ccAddress = appExtPropertiesFile.getProperty(Utils.SIS_REPORT_CC_ADDRESS);\n+\n+\t\tProperties properties = System.getProperties();\n+\t\tproperties.put(Utils.MAIL_SMTP_AUTH, \"false\");\n+\t\tproperties.put(Utils.MAIL_SMTP_STARTTLS, \"true\");\n+\t\tproperties.put(Utils.MAIL_SMTP_HOST, appExtPropertiesFile.getProperty(Utils.MAIL_HOST));\n+\t\t//if enabled will print out raw email body to logs.\n+\t\tproperties.put(Utils.MAIL_DEBUG, appExtPropertiesFile.getProperty(Utils.IS_MAIL_DEBUG_ENABLED));\n+\n+\t\tSession session = Session.getInstance(properties);\n+\t\tMimeMessage message = new MimeMessage(session);\n+\t\tString errmsg = \"Problem in sending the email for course %s due to %s\";\n+\t\ttry {\n+\t\t\tmessage.addRecipient(Message.RecipientType.CC, new InternetAddress(ccAddress));\n+\t\t\tmessage.addRecipient(Message.RecipientType.TO, new InternetAddress(data.getEmailAddress()));\n+\t\t\tmessage.setFrom(new InternetAddress(fromAddress));\n+\t\t\tmessage.setSubject(String.format(data.getSisProcessType().getDescription() + \" \" + data.getCourseId()));\n+\n+\t\t\t//if canvas taking long time to process the sis request, after X attempts intentionally we take the request\n+\t\t\t// out of the thread pool that's when apiResp is null and we send a email to user about this situation.\n+\t\t\tif ((apiResp == null) && data.isSISUploadFailed()) {","path":"src/main/java/edu/umich/ctools/sectionsUtilityTool/SISPollingThread.java","position":134,"original_position":130,"commit_id":"11a6d554fcade56d26c8ca8ae6572866a1b8be17","original_commit_id":"0a07f757ce4b5d14161f3b94f8c7af616bbfd35a","user":{"login":"pushyamig","id":8579775,"avatar_url":"https://avatars1.githubusercontent.com/u/8579775?v=3","gravatar_id":"","url":"https://api.github.com/users/pushyamig","html_url":"https://github.com/pushyamig","followers_url":"https://api.github.com/users/pushyamig/followers","following_url":"https://api.github.com/users/pushyamig/following{/other_user}","gists_url":"https://api.github.com/users/pushyamig/gists{/gist_id}","starred_url":"https://api.github.com/users/pushyamig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushyamig/subscriptions","organizations_url":"https://api.github.com/users/pushyamig/orgs","repos_url":"https://api.github.com/users/pushyamig/repos","events_url":"https://api.github.com/users/pushyamig/events{/privacy}","received_events_url":"https://api.github.com/users/pushyamig/received_events","type":"User","site_admin":false},"body":"Yup., I changed it for now. BSA will come up better one","created_at":"2017-04-17T18:57:50Z","updated_at":"2017-04-17T18:57:50Z","html_url":"https://github.com/tl-its-umich-edu/canvas_course_manager/pull/163#discussion_r111797414","pull_request_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/comments/111797414"},"html":{"href":"https://github.com/tl-its-umich-edu/canvas_course_manager/pull/163#discussion_r111797414"},"pull_request":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/163","id":115974082,"html_url":"https://github.com/tl-its-umich-edu/canvas_course_manager/pull/163","diff_url":"https://github.com/tl-its-umich-edu/canvas_course_manager/pull/163.diff","patch_url":"https://github.com/tl-its-umich-edu/canvas_course_manager/pull/163.patch","issue_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/issues/163","number":163,"state":"open","locked":false,"title":"Ccm3 17","user":{"login":"pushyamig","id":8579775,"avatar_url":"https://avatars1.githubusercontent.com/u/8579775?v=3","gravatar_id":"","url":"https://api.github.com/users/pushyamig","html_url":"https://github.com/pushyamig","followers_url":"https://api.github.com/users/pushyamig/followers","following_url":"https://api.github.com/users/pushyamig/following{/other_user}","gists_url":"https://api.github.com/users/pushyamig/gists{/gist_id}","starred_url":"https://api.github.com/users/pushyamig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushyamig/subscriptions","organizations_url":"https://api.github.com/users/pushyamig/orgs","repos_url":"https://api.github.com/users/pushyamig/repos","events_url":"https://api.github.com/users/pushyamig/events{/privacy}","received_events_url":"https://api.github.com/users/pushyamig/received_events","type":"User","site_admin":false},"body":"@dlhaines @zqian \r\n\r\nThis code review is doing couple of things\r\n1) sending SIS_upload request to canvas along with the sis content as a csv content\r\n2) Starting a Background thread to poll the results of the sis upload, once we get a 100% confirmation from canvas that the process is done, we took the polling request out of the Polling List. `SISPollingThread` is handling this. This class polls SISRequest to canvas for done status, if the request is not done after X amount of attempts we take the request out of the Polling thread. All the status update to the account admin is done through email. Note, the email content will look simple BSA might change it upon there interest.\r\n\r\nMinor things changed:\r\n1) Separated `CanvasAccountAdminFinder`that is doing Account admin check for enabling the SIS process. This is a Refactoring as keeping code simple. This part of the class is already code reviewed.\r\n2) I would say when code reviewing it i request `?w=1` as i had some indentation issues i solved my best. This will make reviewer life simple while reviewing\r\n ","created_at":"2017-04-14T18:59:58Z","updated_at":"2017-04-17T18:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54f64b5cd20362aa02c7ac796ef75978428ec773","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/163/commits","review_comments_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/163/comments","review_comment_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/issues/163/comments","statuses_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/statuses/11a6d554fcade56d26c8ca8ae6572866a1b8be17","head":{"label":"pushyamig:CCM3-17","ref":"CCM3-17","sha":"11a6d554fcade56d26c8ca8ae6572866a1b8be17","user":{"login":"pushyamig","id":8579775,"avatar_url":"https://avatars1.githubusercontent.com/u/8579775?v=3","gravatar_id":"","url":"https://api.github.com/users/pushyamig","html_url":"https://github.com/pushyamig","followers_url":"https://api.github.com/users/pushyamig/followers","following_url":"https://api.github.com/users/pushyamig/following{/other_user}","gists_url":"https://api.github.com/users/pushyamig/gists{/gist_id}","starred_url":"https://api.github.com/users/pushyamig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushyamig/subscriptions","organizations_url":"https://api.github.com/users/pushyamig/orgs","repos_url":"https://api.github.com/users/pushyamig/repos","events_url":"https://api.github.com/users/pushyamig/events{/privacy}","received_events_url":"https://api.github.com/users/pushyamig/received_events","type":"User","site_admin":false},"repo":{"id":33677040,"name":"canvas_course_manager","full_name":"pushyamig/canvas_course_manager","owner":{"login":"pushyamig","id":8579775,"avatar_url":"https://avatars1.githubusercontent.com/u/8579775?v=3","gravatar_id":"","url":"https://api.github.com/users/pushyamig","html_url":"https://github.com/pushyamig","followers_url":"https://api.github.com/users/pushyamig/followers","following_url":"https://api.github.com/users/pushyamig/following{/other_user}","gists_url":"https://api.github.com/users/pushyamig/gists{/gist_id}","starred_url":"https://api.github.com/users/pushyamig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushyamig/subscriptions","organizations_url":"https://api.github.com/users/pushyamig/orgs","repos_url":"https://api.github.com/users/pushyamig/repos","events_url":"https://api.github.com/users/pushyamig/events{/privacy}","received_events_url":"https://api.github.com/users/pushyamig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pushyamig/canvas_course_manager","description":null,"fork":true,"url":"https://api.github.com/repos/pushyamig/canvas_course_manager","forks_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/forks","keys_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/teams","hooks_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/hooks","issue_events_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/issues/events{/number}","events_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/events","assignees_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/assignees{/user}","branches_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/branches{/branch}","tags_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/tags","blobs_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/languages","stargazers_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/stargazers","contributors_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/contributors","subscribers_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/subscribers","subscription_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/subscription","commits_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/contents/{+path}","compare_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/merges","archive_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/downloads","issues_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/issues{/number}","pulls_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/labels{/name}","releases_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/releases{/id}","deployments_url":"https://api.github.com/repos/pushyamig/canvas_course_manager/deployments","created_at":"2015-04-09T15:31:18Z","updated_at":"2017-02-22T19:23:38Z","pushed_at":"2017-04-17T18:50:04Z","git_url":"git://github.com/pushyamig/canvas_course_manager.git","ssh_url":"[email protected]:pushyamig/canvas_course_manager.git","clone_url":"https://github.com/pushyamig/canvas_course_manager.git","svn_url":"https://github.com/pushyamig/canvas_course_manager","homepage":null,"size":1595,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tl-its-umich-edu:master","ref":"master","sha":"b648dce7fbf9d5ae347c1084acb5302cfc1edcef","user":{"login":"tl-its-umich-edu","id":8292960,"avatar_url":"https://avatars0.githubusercontent.com/u/8292960?v=3","gravatar_id":"","url":"https://api.github.com/users/tl-its-umich-edu","html_url":"https://github.com/tl-its-umich-edu","followers_url":"https://api.github.com/users/tl-its-umich-edu/followers","following_url":"https://api.github.com/users/tl-its-umich-edu/following{/other_user}","gists_url":"https://api.github.com/users/tl-its-umich-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/tl-its-umich-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tl-its-umich-edu/subscriptions","organizations_url":"https://api.github.com/users/tl-its-umich-edu/orgs","repos_url":"https://api.github.com/users/tl-its-umich-edu/repos","events_url":"https://api.github.com/users/tl-its-umich-edu/events{/privacy}","received_events_url":"https://api.github.com/users/tl-its-umich-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":33675673,"name":"canvas_course_manager","full_name":"tl-its-umich-edu/canvas_course_manager","owner":{"login":"tl-its-umich-edu","id":8292960,"avatar_url":"https://avatars0.githubusercontent.com/u/8292960?v=3","gravatar_id":"","url":"https://api.github.com/users/tl-its-umich-edu","html_url":"https://github.com/tl-its-umich-edu","followers_url":"https://api.github.com/users/tl-its-umich-edu/followers","following_url":"https://api.github.com/users/tl-its-umich-edu/following{/other_user}","gists_url":"https://api.github.com/users/tl-its-umich-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/tl-its-umich-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tl-its-umich-edu/subscriptions","organizations_url":"https://api.github.com/users/tl-its-umich-edu/orgs","repos_url":"https://api.github.com/users/tl-its-umich-edu/repos","events_url":"https://api.github.com/users/tl-its-umich-edu/events{/privacy}","received_events_url":"https://api.github.com/users/tl-its-umich-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tl-its-umich-edu/canvas_course_manager","description":null,"fork":false,"url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager","forks_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/forks","keys_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/teams","hooks_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/hooks","issue_events_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/issues/events{/number}","events_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/events","assignees_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/assignees{/user}","branches_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/branches{/branch}","tags_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/tags","blobs_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/languages","stargazers_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/stargazers","contributors_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/contributors","subscribers_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/subscribers","subscription_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/subscription","commits_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/contents/{+path}","compare_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/merges","archive_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/downloads","issues_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/issues{/number}","pulls_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/labels{/name}","releases_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/releases{/id}","deployments_url":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/deployments","created_at":"2015-04-09T15:06:37Z","updated_at":"2017-03-02T18:51:19Z","pushed_at":"2017-04-17T18:50:05Z","git_url":"git://github.com/tl-its-umich-edu/canvas_course_manager.git","ssh_url":"[email protected]:tl-its-umich-edu/canvas_course_manager.git","clone_url":"https://github.com/tl-its-umich-edu/canvas_course_manager.git","svn_url":"https://github.com/tl-its-umich-edu/canvas_course_manager","homepage":null,"size":1577,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/163"},"html":{"href":"https://github.com/tl-its-umich-edu/canvas_course_manager/pull/163"},"issue":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/issues/163"},"comments":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager/statuses/11a6d554fcade56d26c8ca8ae6572866a1b8be17"}}}} | {
"id": 33675673,
"name": "tl-its-umich-edu/canvas_course_manager",
"url": "https://api.github.com/repos/tl-its-umich-edu/canvas_course_manager"
} | {
"id": 8579775,
"login": "pushyamig",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8579775?",
"url": "https://api.github.com/users/pushyamig"
} | {
"id": 8292960,
"login": "tl-its-umich-edu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8292960?",
"url": "https://api.github.com/orgs/tl-its-umich-edu"
} | 2017-04-17T18:57:50 | 5701742733 | {"actor":{"display_login":"pushyamig"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments/123077657","pull_request_review_id":45247971,"id":123077657,"diff_hunk":"@@ -229,3 +232,19 @@\n \t\t\tair.temperature -= heat/total_heat_capacity\n \tif(network)\n \t\tnetwork.update = 1\n+\n+\n+//Slows down the rate of update_icon() when many of them are called simultaneously and prevents some duplicate processing\n+/datum/pipeline/proc/process_update_icon_queue()","path":"code/ATMOSPHERICS/datum_pipeline.dm","position":17,"original_position":17,"commit_id":"52d3651551afeb0dc57276f6593cb44e702e9602","original_commit_id":"52d3651551afeb0dc57276f6593cb44e702e9602","user":{"login":"Chewyfungus","id":3300686,"avatar_url":"https://avatars1.githubusercontent.com/u/3300686?v=3","gravatar_id":"","url":"https://api.github.com/users/Chewyfungus","html_url":"https://github.com/Chewyfungus","followers_url":"https://api.github.com/users/Chewyfungus/followers","following_url":"https://api.github.com/users/Chewyfungus/following{/other_user}","gists_url":"https://api.github.com/users/Chewyfungus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chewyfungus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chewyfungus/subscriptions","organizations_url":"https://api.github.com/users/Chewyfungus/orgs","repos_url":"https://api.github.com/users/Chewyfungus/repos","events_url":"https://api.github.com/users/Chewyfungus/events{/privacy}","received_events_url":"https://api.github.com/users/Chewyfungus/received_events","type":"User","site_admin":false},"body":"oh man what a boof, I'll upload the fix in a few hours, thanks","created_at":"2017-06-20T19:51:17Z","updated_at":"2017-06-20T19:51:17Z","html_url":"https://github.com/vgstation-coders/vgstation13/pull/15253#discussion_r123077657","pull_request_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/15253","_links":{"self":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments/123077657"},"html":{"href":"https://github.com/vgstation-coders/vgstation13/pull/15253#discussion_r123077657"},"pull_request":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/15253"}}},"pull_request":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/15253","id":126424125,"html_url":"https://github.com/vgstation-coders/vgstation13/pull/15253","diff_url":"https://github.com/vgstation-coders/vgstation13/pull/15253.diff","patch_url":"https://github.com/vgstation-coders/vgstation13/pull/15253.patch","issue_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/15253","number":15253,"state":"open","locked":false,"title":"Prevents some duplicate calls of update_icon() during explosions","user":{"login":"Chewyfungus","id":3300686,"avatar_url":"https://avatars1.githubusercontent.com/u/3300686?v=3","gravatar_id":"","url":"https://api.github.com/users/Chewyfungus","html_url":"https://github.com/Chewyfungus","followers_url":"https://api.github.com/users/Chewyfungus/followers","following_url":"https://api.github.com/users/Chewyfungus/following{/other_user}","gists_url":"https://api.github.com/users/Chewyfungus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chewyfungus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chewyfungus/subscriptions","organizations_url":"https://api.github.com/users/Chewyfungus/orgs","repos_url":"https://api.github.com/users/Chewyfungus/repos","events_url":"https://api.github.com/users/Chewyfungus/events{/privacy}","received_events_url":"https://api.github.com/users/Chewyfungus/received_events","type":"User","site_admin":false},"body":"### update_icon() is needlessly called many times during explosions. ###\r\n----\r\n* A pipe that's destroyed will call update_icon() on itself and on any nearby pipes that will be visually affected by this pipe disappearing. \r\n* It's a pretty meaty proc, so this isn't a very good thing to have happen when it doesn't need to.\r\n----\r\n### The solution that clusterfack suggested I implement was the following:\r\n* Whenever a pipe would call update_icon(), instead add it to a list in its parent pipeline, and set a flag equal to true\r\n* In the parent pipeline, whenever something is added to this list, the list begins processing this as a queue by taking the pipe stored in the list and calling update_icon() for it if its update flag is set to true. \r\n* Then, after update_icon() is called, set this flag to false. If this pipe is in the list multiple times, it will be prevented from calling this function needlessly.\r\n\r\nThe results of this change are as follows:\r\n\r\n\r\n\r\n\r\n\r\n<!--\r\nPull requests must be atomic. Change one set of related things at a time. Bundling sucks for everyone.\r\nThis means, primarily, that you shouldn't fix bugs and add content in the same PR. When we mean 'bundling', we mean making one PR for multiple, unrelated changes.\r\n\r\nTest your changes. PRs that do not compile will not be accepted.\r\nTesting your changes locally is incredibly important. If you break the serb we will be very upset with you.\r\n\r\nLarge changes require discussion. If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN IRC.\r\n\r\nMerging your own PRs is considered bad practice, as it generally means you bypass peer review, which is a core part of how we develop.\r\n\r\nIt is also suggested that you hop into irc.rizon.net #vgstation to discuss your changes, or if you need help.\r\n\r\nWhen working with in body changelogs, the syntax is as follows:\r\n:cl: (as the emoji)\r\n * rscadd: Did stuff!\r\n * rscdel: did other stuff!\r\n\r\nfor the keys you can use in a changelog, they are the same as described in html/changelogs/example.yml\r\nNOTE that anything *after* the :cl: will be parsed as a changelog, if it somehow manages to be parseable as such, so always put the changelog at the VERY end!\r\n-->\r\n","created_at":"2017-06-20T00:22:55Z","updated_at":"2017-06-20T19:51:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b660fc5068134d877345cae206dd09731131f1d5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/15253/commits","review_comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/15253/comments","review_comment_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/15253/comments","statuses_url":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/52d3651551afeb0dc57276f6593cb44e702e9602","head":{"label":"Chewyfungus:update_icon_optimization","ref":"update_icon_optimization","sha":"52d3651551afeb0dc57276f6593cb44e702e9602","user":{"login":"Chewyfungus","id":3300686,"avatar_url":"https://avatars1.githubusercontent.com/u/3300686?v=3","gravatar_id":"","url":"https://api.github.com/users/Chewyfungus","html_url":"https://github.com/Chewyfungus","followers_url":"https://api.github.com/users/Chewyfungus/followers","following_url":"https://api.github.com/users/Chewyfungus/following{/other_user}","gists_url":"https://api.github.com/users/Chewyfungus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chewyfungus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chewyfungus/subscriptions","organizations_url":"https://api.github.com/users/Chewyfungus/orgs","repos_url":"https://api.github.com/users/Chewyfungus/repos","events_url":"https://api.github.com/users/Chewyfungus/events{/privacy}","received_events_url":"https://api.github.com/users/Chewyfungus/received_events","type":"User","site_admin":false},"repo":{"id":94830944,"name":"vgstation13","full_name":"Chewyfungus/vgstation13","owner":{"login":"Chewyfungus","id":3300686,"avatar_url":"https://avatars1.githubusercontent.com/u/3300686?v=3","gravatar_id":"","url":"https://api.github.com/users/Chewyfungus","html_url":"https://github.com/Chewyfungus","followers_url":"https://api.github.com/users/Chewyfungus/followers","following_url":"https://api.github.com/users/Chewyfungus/following{/other_user}","gists_url":"https://api.github.com/users/Chewyfungus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chewyfungus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chewyfungus/subscriptions","organizations_url":"https://api.github.com/users/Chewyfungus/orgs","repos_url":"https://api.github.com/users/Chewyfungus/repos","events_url":"https://api.github.com/users/Chewyfungus/events{/privacy}","received_events_url":"https://api.github.com/users/Chewyfungus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chewyfungus/vgstation13","description":"Butts","fork":true,"url":"https://api.github.com/repos/Chewyfungus/vgstation13","forks_url":"https://api.github.com/repos/Chewyfungus/vgstation13/forks","keys_url":"https://api.github.com/repos/Chewyfungus/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chewyfungus/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chewyfungus/vgstation13/teams","hooks_url":"https://api.github.com/repos/Chewyfungus/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/Chewyfungus/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/Chewyfungus/vgstation13/events","assignees_url":"https://api.github.com/repos/Chewyfungus/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/Chewyfungus/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/Chewyfungus/vgstation13/tags","blobs_url":"https://api.github.com/repos/Chewyfungus/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chewyfungus/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chewyfungus/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chewyfungus/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chewyfungus/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/Chewyfungus/vgstation13/languages","stargazers_url":"https://api.github.com/repos/Chewyfungus/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/Chewyfungus/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/Chewyfungus/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/Chewyfungus/vgstation13/subscription","commits_url":"https://api.github.com/repos/Chewyfungus/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chewyfungus/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chewyfungus/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chewyfungus/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chewyfungus/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/Chewyfungus/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chewyfungus/vgstation13/merges","archive_url":"https://api.github.com/repos/Chewyfungus/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chewyfungus/vgstation13/downloads","issues_url":"https://api.github.com/repos/Chewyfungus/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/Chewyfungus/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/Chewyfungus/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/Chewyfungus/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chewyfungus/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/Chewyfungus/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/Chewyfungus/vgstation13/deployments","created_at":"2017-06-19T23:59:56Z","updated_at":"2017-06-20T00:00:10Z","pushed_at":"2017-06-20T00:18:10Z","git_url":"git://github.com/Chewyfungus/vgstation13.git","ssh_url":"[email protected]:Chewyfungus/vgstation13.git","clone_url":"https://github.com/Chewyfungus/vgstation13.git","svn_url":"https://github.com/Chewyfungus/vgstation13","homepage":"","size":1145811,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Bleeding-Edge"}},"base":{"label":"vgstation-coders:Bleeding-Edge","ref":"Bleeding-Edge","sha":"eaa3f967bf2515a79203398c35578d9d58df91d2","user":{"login":"vgstation-coders","id":26489760,"avatar_url":"https://avatars1.githubusercontent.com/u/26489760?v=3","gravatar_id":"","url":"https://api.github.com/users/vgstation-coders","html_url":"https://github.com/vgstation-coders","followers_url":"https://api.github.com/users/vgstation-coders/followers","following_url":"https://api.github.com/users/vgstation-coders/following{/other_user}","gists_url":"https://api.github.com/users/vgstation-coders/gists{/gist_id}","starred_url":"https://api.github.com/users/vgstation-coders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgstation-coders/subscriptions","organizations_url":"https://api.github.com/users/vgstation-coders/orgs","repos_url":"https://api.github.com/users/vgstation-coders/repos","events_url":"https://api.github.com/users/vgstation-coders/events{/privacy}","received_events_url":"https://api.github.com/users/vgstation-coders/received_events","type":"Organization","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"vgstation-coders/vgstation13","owner":{"login":"vgstation-coders","id":26489760,"avatar_url":"https://avatars1.githubusercontent.com/u/26489760?v=3","gravatar_id":"","url":"https://api.github.com/users/vgstation-coders","html_url":"https://github.com/vgstation-coders","followers_url":"https://api.github.com/users/vgstation-coders/followers","following_url":"https://api.github.com/users/vgstation-coders/following{/other_user}","gists_url":"https://api.github.com/users/vgstation-coders/gists{/gist_id}","starred_url":"https://api.github.com/users/vgstation-coders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgstation-coders/subscriptions","organizations_url":"https://api.github.com/users/vgstation-coders/orgs","repos_url":"https://api.github.com/users/vgstation-coders/repos","events_url":"https://api.github.com/users/vgstation-coders/events{/privacy}","received_events_url":"https://api.github.com/users/vgstation-coders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vgstation-coders/vgstation13","description":"Butts","fork":false,"url":"https://api.github.com/repos/vgstation-coders/vgstation13","forks_url":"https://api.github.com/repos/vgstation-coders/vgstation13/forks","keys_url":"https://api.github.com/repos/vgstation-coders/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vgstation-coders/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vgstation-coders/vgstation13/teams","hooks_url":"https://api.github.com/repos/vgstation-coders/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/vgstation-coders/vgstation13/events","assignees_url":"https://api.github.com/repos/vgstation-coders/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/vgstation-coders/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/vgstation-coders/vgstation13/tags","blobs_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/vgstation-coders/vgstation13/languages","stargazers_url":"https://api.github.com/repos/vgstation-coders/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/vgstation-coders/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/vgstation-coders/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/vgstation-coders/vgstation13/subscription","commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/vgstation-coders/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/vgstation-coders/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vgstation-coders/vgstation13/merges","archive_url":"https://api.github.com/repos/vgstation-coders/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vgstation-coders/vgstation13/downloads","issues_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/vgstation-coders/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/vgstation-coders/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/vgstation-coders/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/deployments","created_at":"2013-06-02T19:39:54Z","updated_at":"2017-06-15T17:09:10Z","pushed_at":"2017-06-20T17:52:32Z","git_url":"git://github.com/vgstation-coders/vgstation13.git","ssh_url":"[email protected]:vgstation-coders/vgstation13.git","clone_url":"https://github.com/vgstation-coders/vgstation13.git","svn_url":"https://github.com/vgstation-coders/vgstation13","homepage":"","size":1145813,"stargazers_count":118,"watchers_count":118,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":1805,"forks":172,"open_issues":1805,"watchers":118,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/15253"},"html":{"href":"https://github.com/vgstation-coders/vgstation13/pull/15253"},"issue":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/15253"},"comments":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/15253/comments"},"review_comments":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/15253/comments"},"review_comment":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/15253/commits"},"statuses":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/52d3651551afeb0dc57276f6593cb44e702e9602"}}}} | {
"id": 10441188,
"name": "vgstation-coders/vgstation13",
"url": "https://api.github.com/repos/vgstation-coders/vgstation13"
} | {
"id": 3300686,
"login": "Chewyfungus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3300686?",
"url": "https://api.github.com/users/Chewyfungus"
} | {
"id": 26489760,
"login": "vgstation-coders",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26489760?",
"url": "https://api.github.com/orgs/vgstation-coders"
} | 2017-06-20T19:51:17 | 6103946010 | {"actor":{"display_login":"Chewyfungus"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/comments/158871805","pull_request_review_id":85733593,"id":158871805,"diff_hunk":"@@ -0,0 +1,26 @@\n+import React, { Component, Fragment } from 'react';\n+import Button from '../src/components/Button';\n+import MaterialThemeProvider from '../src/theme/ThemeProvider';\n+import { Drawer } from '../src/components/Drawer';\n+\n+export default class PortalPage extends Component {\n+ state = {\n+ open: false,\n+ };\n+\n+ toggleOpen = () => this.setState({ open: !this.state.open });\n+\n+ render() {\n+ return (\n+ <MaterialThemeProvider theme={{ primary: '#03A9F4' }}>\n+ <Fragment>\n+ <Drawer open={this.state.open} handleRequestClose={this.toggleOpen}>","path":"pages/drawer.js","position":17,"original_position":17,"commit_id":"fcf34590c0ff6e5b1178f4b53b674494e446f575","original_commit_id":"fcf34590c0ff6e5b1178f4b53b674494e446f575","user":{"login":"AriLFrankel","id":17049809,"avatar_url":"https://avatars1.githubusercontent.com/u/17049809?v=4","gravatar_id":"","url":"https://api.github.com/users/AriLFrankel","html_url":"https://github.com/AriLFrankel","followers_url":"https://api.github.com/users/AriLFrankel/followers","following_url":"https://api.github.com/users/AriLFrankel/following{/other_user}","gists_url":"https://api.github.com/users/AriLFrankel/gists{/gist_id}","starred_url":"https://api.github.com/users/AriLFrankel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AriLFrankel/subscriptions","organizations_url":"https://api.github.com/users/AriLFrankel/orgs","repos_url":"https://api.github.com/users/AriLFrankel/repos","events_url":"https://api.github.com/users/AriLFrankel/events{/privacy}","received_events_url":"https://api.github.com/users/AriLFrankel/received_events","type":"User","site_admin":false},"body":"How would I do a non-temporary drawer?\r\n\r\nIf I pass in `temporary={false}`, open still would default to false.","created_at":"2017-12-27T21:46:23Z","updated_at":"2017-12-27T22:00:48Z","html_url":"https://github.com/ConciergeAuctions/styled-material-components/pull/79#discussion_r158871805","pull_request_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/79","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/comments/158871805"},"html":{"href":"https://github.com/ConciergeAuctions/styled-material-components/pull/79#discussion_r158871805"},"pull_request":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/79","id":160062832,"html_url":"https://github.com/ConciergeAuctions/styled-material-components/pull/79","diff_url":"https://github.com/ConciergeAuctions/styled-material-components/pull/79.diff","patch_url":"https://github.com/ConciergeAuctions/styled-material-components/pull/79.patch","issue_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/issues/79","number":79,"state":"open","locked":false,"title":"Drawer Component + Portal first pass","user":{"login":"brad-decker","id":4448075,"avatar_url":"https://avatars2.githubusercontent.com/u/4448075?v=4","gravatar_id":"","url":"https://api.github.com/users/brad-decker","html_url":"https://github.com/brad-decker","followers_url":"https://api.github.com/users/brad-decker/followers","following_url":"https://api.github.com/users/brad-decker/following{/other_user}","gists_url":"https://api.github.com/users/brad-decker/gists{/gist_id}","starred_url":"https://api.github.com/users/brad-decker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad-decker/subscriptions","organizations_url":"https://api.github.com/users/brad-decker/orgs","repos_url":"https://api.github.com/users/brad-decker/repos","events_url":"https://api.github.com/users/brad-decker/events{/privacy}","received_events_url":"https://api.github.com/users/brad-decker/received_events","type":"User","site_admin":false},"body":"Also fixes #9 \r\n\r\nhttps://docs-txsaxitvca.now.sh","created_at":"2017-12-25T16:48:36Z","updated_at":"2017-12-27T22:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d82c66e103095a32983a0a8cd20c911726aae7e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iamdavid0091","id":13578465,"avatar_url":"https://avatars0.githubusercontent.com/u/13578465?v=4","gravatar_id":"","url":"https://api.github.com/users/iamdavid0091","html_url":"https://github.com/iamdavid0091","followers_url":"https://api.github.com/users/iamdavid0091/followers","following_url":"https://api.github.com/users/iamdavid0091/following{/other_user}","gists_url":"https://api.github.com/users/iamdavid0091/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdavid0091/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdavid0091/subscriptions","organizations_url":"https://api.github.com/users/iamdavid0091/orgs","repos_url":"https://api.github.com/users/iamdavid0091/repos","events_url":"https://api.github.com/users/iamdavid0091/events{/privacy}","received_events_url":"https://api.github.com/users/iamdavid0091/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/79/commits","review_comments_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/79/comments","review_comment_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/issues/79/comments","statuses_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/statuses/fcf34590c0ff6e5b1178f4b53b674494e446f575","head":{"label":"brad-decker:master","ref":"master","sha":"fcf34590c0ff6e5b1178f4b53b674494e446f575","user":{"login":"brad-decker","id":4448075,"avatar_url":"https://avatars2.githubusercontent.com/u/4448075?v=4","gravatar_id":"","url":"https://api.github.com/users/brad-decker","html_url":"https://github.com/brad-decker","followers_url":"https://api.github.com/users/brad-decker/followers","following_url":"https://api.github.com/users/brad-decker/following{/other_user}","gists_url":"https://api.github.com/users/brad-decker/gists{/gist_id}","starred_url":"https://api.github.com/users/brad-decker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad-decker/subscriptions","organizations_url":"https://api.github.com/users/brad-decker/orgs","repos_url":"https://api.github.com/users/brad-decker/repos","events_url":"https://api.github.com/users/brad-decker/events{/privacy}","received_events_url":"https://api.github.com/users/brad-decker/received_events","type":"User","site_admin":false},"repo":{"id":115203223,"name":"styled-material-components","full_name":"brad-decker/styled-material-components","owner":{"login":"brad-decker","id":4448075,"avatar_url":"https://avatars2.githubusercontent.com/u/4448075?v=4","gravatar_id":"","url":"https://api.github.com/users/brad-decker","html_url":"https://github.com/brad-decker","followers_url":"https://api.github.com/users/brad-decker/followers","following_url":"https://api.github.com/users/brad-decker/following{/other_user}","gists_url":"https://api.github.com/users/brad-decker/gists{/gist_id}","starred_url":"https://api.github.com/users/brad-decker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad-decker/subscriptions","organizations_url":"https://api.github.com/users/brad-decker/orgs","repos_url":"https://api.github.com/users/brad-decker/repos","events_url":"https://api.github.com/users/brad-decker/events{/privacy}","received_events_url":"https://api.github.com/users/brad-decker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brad-decker/styled-material-components","description":"Coming Soon","fork":true,"url":"https://api.github.com/repos/brad-decker/styled-material-components","forks_url":"https://api.github.com/repos/brad-decker/styled-material-components/forks","keys_url":"https://api.github.com/repos/brad-decker/styled-material-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brad-decker/styled-material-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brad-decker/styled-material-components/teams","hooks_url":"https://api.github.com/repos/brad-decker/styled-material-components/hooks","issue_events_url":"https://api.github.com/repos/brad-decker/styled-material-components/issues/events{/number}","events_url":"https://api.github.com/repos/brad-decker/styled-material-components/events","assignees_url":"https://api.github.com/repos/brad-decker/styled-material-components/assignees{/user}","branches_url":"https://api.github.com/repos/brad-decker/styled-material-components/branches{/branch}","tags_url":"https://api.github.com/repos/brad-decker/styled-material-components/tags","blobs_url":"https://api.github.com/repos/brad-decker/styled-material-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brad-decker/styled-material-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brad-decker/styled-material-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/brad-decker/styled-material-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brad-decker/styled-material-components/statuses/{sha}","languages_url":"https://api.github.com/repos/brad-decker/styled-material-components/languages","stargazers_url":"https://api.github.com/repos/brad-decker/styled-material-components/stargazers","contributors_url":"https://api.github.com/repos/brad-decker/styled-material-components/contributors","subscribers_url":"https://api.github.com/repos/brad-decker/styled-material-components/subscribers","subscription_url":"https://api.github.com/repos/brad-decker/styled-material-components/subscription","commits_url":"https://api.github.com/repos/brad-decker/styled-material-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/brad-decker/styled-material-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/brad-decker/styled-material-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/brad-decker/styled-material-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/brad-decker/styled-material-components/contents/{+path}","compare_url":"https://api.github.com/repos/brad-decker/styled-material-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brad-decker/styled-material-components/merges","archive_url":"https://api.github.com/repos/brad-decker/styled-material-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brad-decker/styled-material-components/downloads","issues_url":"https://api.github.com/repos/brad-decker/styled-material-components/issues{/number}","pulls_url":"https://api.github.com/repos/brad-decker/styled-material-components/pulls{/number}","milestones_url":"https://api.github.com/repos/brad-decker/styled-material-components/milestones{/number}","notifications_url":"https://api.github.com/repos/brad-decker/styled-material-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brad-decker/styled-material-components/labels{/name}","releases_url":"https://api.github.com/repos/brad-decker/styled-material-components/releases{/id}","deployments_url":"https://api.github.com/repos/brad-decker/styled-material-components/deployments","created_at":"2017-12-23T15:10:34Z","updated_at":"2017-12-23T15:10:36Z","pushed_at":"2017-12-27T19:52:48Z","git_url":"git://github.com/brad-decker/styled-material-components.git","ssh_url":"[email protected]:brad-decker/styled-material-components.git","clone_url":"https://github.com/brad-decker/styled-material-components.git","svn_url":"https://github.com/brad-decker/styled-material-components","homepage":"","size":769,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ConciergeAuctions:master","ref":"master","sha":"6fafb4988b1b6bb7f846da344cdc51fb6be6b3a1","user":{"login":"ConciergeAuctions","id":10405966,"avatar_url":"https://avatars3.githubusercontent.com/u/10405966?v=4","gravatar_id":"","url":"https://api.github.com/users/ConciergeAuctions","html_url":"https://github.com/ConciergeAuctions","followers_url":"https://api.github.com/users/ConciergeAuctions/followers","following_url":"https://api.github.com/users/ConciergeAuctions/following{/other_user}","gists_url":"https://api.github.com/users/ConciergeAuctions/gists{/gist_id}","starred_url":"https://api.github.com/users/ConciergeAuctions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConciergeAuctions/subscriptions","organizations_url":"https://api.github.com/users/ConciergeAuctions/orgs","repos_url":"https://api.github.com/users/ConciergeAuctions/repos","events_url":"https://api.github.com/users/ConciergeAuctions/events{/privacy}","received_events_url":"https://api.github.com/users/ConciergeAuctions/received_events","type":"Organization","site_admin":false},"repo":{"id":92553109,"name":"styled-material-components","full_name":"ConciergeAuctions/styled-material-components","owner":{"login":"ConciergeAuctions","id":10405966,"avatar_url":"https://avatars3.githubusercontent.com/u/10405966?v=4","gravatar_id":"","url":"https://api.github.com/users/ConciergeAuctions","html_url":"https://github.com/ConciergeAuctions","followers_url":"https://api.github.com/users/ConciergeAuctions/followers","following_url":"https://api.github.com/users/ConciergeAuctions/following{/other_user}","gists_url":"https://api.github.com/users/ConciergeAuctions/gists{/gist_id}","starred_url":"https://api.github.com/users/ConciergeAuctions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConciergeAuctions/subscriptions","organizations_url":"https://api.github.com/users/ConciergeAuctions/orgs","repos_url":"https://api.github.com/users/ConciergeAuctions/repos","events_url":"https://api.github.com/users/ConciergeAuctions/events{/privacy}","received_events_url":"https://api.github.com/users/ConciergeAuctions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConciergeAuctions/styled-material-components","description":"Coming Soon","fork":false,"url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components","forks_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/forks","keys_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/teams","hooks_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/hooks","issue_events_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/issues/events{/number}","events_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/events","assignees_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/assignees{/user}","branches_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/branches{/branch}","tags_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/tags","blobs_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/languages","stargazers_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/stargazers","contributors_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/contributors","subscribers_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/subscribers","subscription_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/subscription","commits_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/contents/{+path}","compare_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/merges","archive_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/downloads","issues_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/issues{/number}","pulls_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/labels{/name}","releases_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/releases{/id}","deployments_url":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/deployments","created_at":"2017-05-26T22:31:13Z","updated_at":"2017-12-20T23:54:22Z","pushed_at":"2017-12-27T19:52:50Z","git_url":"git://github.com/ConciergeAuctions/styled-material-components.git","ssh_url":"[email protected]:ConciergeAuctions/styled-material-components.git","clone_url":"https://github.com/ConciergeAuctions/styled-material-components.git","svn_url":"https://github.com/ConciergeAuctions/styled-material-components","homepage":"","size":634,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":49,"license":null,"forks":14,"open_issues":49,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/79"},"html":{"href":"https://github.com/ConciergeAuctions/styled-material-components/pull/79"},"issue":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/issues/79"},"comments":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/ConciergeAuctions/styled-material-components/statuses/fcf34590c0ff6e5b1178f4b53b674494e446f575"}},"author_association":"OWNER"}} | {
"id": 92553109,
"name": "ConciergeAuctions/styled-material-components",
"url": "https://api.github.com/repos/ConciergeAuctions/styled-material-components"
} | {
"id": 17049809,
"login": "AriLFrankel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17049809?",
"url": "https://api.github.com/users/AriLFrankel"
} | {
"id": 10405966,
"login": "ConciergeAuctions",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10405966?",
"url": "https://api.github.com/orgs/ConciergeAuctions"
} | 2017-12-27T21:46:23 | 7035220635 | {"actor":{"display_login":"AriLFrankel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/comments/106823755","pull_request_review_id":27763593,"id":106823755,"diff_hunk":"@@ -796,7 +796,7 @@\n \"<a href=\\\"//i.imgur.com/O32cDWE.png\\\" data-lightbox=\\\"img-enlarge\\\"><img class=\\\"img-responsive\\\" src=\\\"//i.imgur.com/O32cDWE.png\\\" title=\\\"Click to enlarge\\\" alt=\\\"An \\\"inline\\\" button is as small as the text it contains. In this image, it's centered. Below it is a \\\"block-level\\\" button, which stretches to fill the entire horizontal space.'></a>\",\n \"通过使用 <code>span</code> 元素，你可以把几个元素放在一起。你甚至可以用此为一个元素的不同部分指定样式。\",\n \"把 \\\"Things cats love\\\" 中的 \\\"love\\\" 放到 <code>span</code> 标签下。然后为其添加 <code>text-danger</code> class 来使文字变成红色。\",\n- \"下面是完成后 \\\"Top 3 things cats hate\\\" 元素的显示效果：\",\n+ \"下面是完成后 \\\"Top 3 things cats <code>hate</code>\\\" 元素的显示效果：\",","path":"seed/challenges/01-front-end-development-certification/bootstrap.json","position":5,"original_position":5,"commit_id":"a09cd876f46e49179d50de3e0974052a7810f13b","original_commit_id":"a09cd876f46e49179d50de3e0974052a7810f13b","user":{"login":"S1ngS1ng","id":13592559,"avatar_url":"https://avatars2.githubusercontent.com/u/13592559?v=3","gravatar_id":"","url":"https://api.github.com/users/S1ngS1ng","html_url":"https://github.com/S1ngS1ng","followers_url":"https://api.github.com/users/S1ngS1ng/followers","following_url":"https://api.github.com/users/S1ngS1ng/following{/other_user}","gists_url":"https://api.github.com/users/S1ngS1ng/gists{/gist_id}","starred_url":"https://api.github.com/users/S1ngS1ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S1ngS1ng/subscriptions","organizations_url":"https://api.github.com/users/S1ngS1ng/orgs","repos_url":"https://api.github.com/users/S1ngS1ng/repos","events_url":"https://api.github.com/users/S1ngS1ng/events{/privacy}","received_events_url":"https://api.github.com/users/S1ngS1ng/received_events","type":"User","site_admin":false},"body":"Original instruction:\r\n```\r\nHere's how you would do this with the \"Top 3 things cats hate\" element:\r\n```\r\n\r\nConsider this?\r\n```\r\n举个例子，对于 \\\"Top 3 things cats hate\\\"，你应该这样写：\r\n\r\n\"<code><p>Top 3 things cats <span class = \\\"text-danger\\\">hate:</span></p></code>\"\r\n```\r\n\r\n**The point of the changes is to clarify that the following code is just an EXAMPLE**","created_at":"2017-03-20T00:14:04Z","updated_at":"2017-03-20T00:14:08Z","html_url":"https://github.com/FreeCodeCampChina/freecodecamp.cn/pull/203#discussion_r106823755","pull_request_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/comments/106823755"},"html":{"href":"https://github.com/FreeCodeCampChina/freecodecamp.cn/pull/203#discussion_r106823755"},"pull_request":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/203","id":111447467,"html_url":"https://github.com/FreeCodeCampChina/freecodecamp.cn/pull/203","diff_url":"https://github.com/FreeCodeCampChina/freecodecamp.cn/pull/203.diff","patch_url":"https://github.com/FreeCodeCampChina/freecodecamp.cn/pull/203.patch","issue_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/issues/203","number":203,"state":"open","locked":false,"title":"Enhance color of HTML in an attempt to make things more clear","user":{"login":"wudifeixue","id":7316929,"avatar_url":"https://avatars1.githubusercontent.com/u/7316929?v=3","gravatar_id":"","url":"https://api.github.com/users/wudifeixue","html_url":"https://github.com/wudifeixue","followers_url":"https://api.github.com/users/wudifeixue/followers","following_url":"https://api.github.com/users/wudifeixue/following{/other_user}","gists_url":"https://api.github.com/users/wudifeixue/gists{/gist_id}","starred_url":"https://api.github.com/users/wudifeixue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wudifeixue/subscriptions","organizations_url":"https://api.github.com/users/wudifeixue/orgs","repos_url":"https://api.github.com/users/wudifeixue/repos","events_url":"https://api.github.com/users/wudifeixue/events{/privacy}","received_events_url":"https://api.github.com/users/wudifeixue/received_events","type":"User","site_admin":false},"body":"* [ ] LGTM\r\n* [ ] LGTM\r\n\r\nIn this pull request:\r\nSolves issue #197 \r\nFix multiple commits problem in pull request #202 ","created_at":"2017-03-19T12:07:49Z","updated_at":"2017-03-20T00:14:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03c86f3a87680a03e5949c1ba444f28806b62b12","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/203/commits","review_comments_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/203/comments","review_comment_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/issues/203/comments","statuses_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/statuses/a09cd876f46e49179d50de3e0974052a7810f13b","head":{"label":"wudifeixue:enhance-html-color","ref":"enhance-html-color","sha":"a09cd876f46e49179d50de3e0974052a7810f13b","user":{"login":"wudifeixue","id":7316929,"avatar_url":"https://avatars1.githubusercontent.com/u/7316929?v=3","gravatar_id":"","url":"https://api.github.com/users/wudifeixue","html_url":"https://github.com/wudifeixue","followers_url":"https://api.github.com/users/wudifeixue/followers","following_url":"https://api.github.com/users/wudifeixue/following{/other_user}","gists_url":"https://api.github.com/users/wudifeixue/gists{/gist_id}","starred_url":"https://api.github.com/users/wudifeixue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wudifeixue/subscriptions","organizations_url":"https://api.github.com/users/wudifeixue/orgs","repos_url":"https://api.github.com/users/wudifeixue/repos","events_url":"https://api.github.com/users/wudifeixue/events{/privacy}","received_events_url":"https://api.github.com/users/wudifeixue/received_events","type":"User","site_admin":false},"repo":{"id":81705711,"name":"freecodecamp.cn","full_name":"wudifeixue/freecodecamp.cn","owner":{"login":"wudifeixue","id":7316929,"avatar_url":"https://avatars1.githubusercontent.com/u/7316929?v=3","gravatar_id":"","url":"https://api.github.com/users/wudifeixue","html_url":"https://github.com/wudifeixue","followers_url":"https://api.github.com/users/wudifeixue/followers","following_url":"https://api.github.com/users/wudifeixue/following{/other_user}","gists_url":"https://api.github.com/users/wudifeixue/gists{/gist_id}","starred_url":"https://api.github.com/users/wudifeixue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wudifeixue/subscriptions","organizations_url":"https://api.github.com/users/wudifeixue/orgs","repos_url":"https://api.github.com/users/wudifeixue/repos","events_url":"https://api.github.com/users/wudifeixue/events{/privacy}","received_events_url":"https://api.github.com/users/wudifeixue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wudifeixue/freecodecamp.cn","description":"看源码请到Code，提问请到Issues，提交代码请到Pull requests，看学习心得请到Wiki。多谢合作，么么哒，^_^。","fork":true,"url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn","forks_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/forks","keys_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/teams","hooks_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/hooks","issue_events_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/issues/events{/number}","events_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/events","assignees_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/assignees{/user}","branches_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/branches{/branch}","tags_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/tags","blobs_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/git/refs{/sha}","trees_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/statuses/{sha}","languages_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/languages","stargazers_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/stargazers","contributors_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/contributors","subscribers_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/subscribers","subscription_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/subscription","commits_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/commits{/sha}","git_commits_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/git/commits{/sha}","comments_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/comments{/number}","issue_comment_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/issues/comments{/number}","contents_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/contents/{+path}","compare_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/merges","archive_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/downloads","issues_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/issues{/number}","pulls_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/pulls{/number}","milestones_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/milestones{/number}","notifications_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/labels{/name}","releases_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/releases{/id}","deployments_url":"https://api.github.com/repos/wudifeixue/freecodecamp.cn/deployments","created_at":"2017-02-12T05:41:03Z","updated_at":"2017-02-12T05:41:07Z","pushed_at":"2017-03-19T07:26:56Z","git_url":"git://github.com/wudifeixue/freecodecamp.cn.git","ssh_url":"[email protected]:wudifeixue/freecodecamp.cn.git","clone_url":"https://github.com/wudifeixue/freecodecamp.cn.git","svn_url":"https://github.com/wudifeixue/freecodecamp.cn","homepage":null,"size":30276,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"FreeCodeCampChina:dev","ref":"dev","sha":"e56c986bf3283e7d5a8ba400a4e07766e76ec8d6","user":{"login":"FreeCodeCampChina","id":18478284,"avatar_url":"https://avatars3.githubusercontent.com/u/18478284?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeCodeCampChina","html_url":"https://github.com/FreeCodeCampChina","followers_url":"https://api.github.com/users/FreeCodeCampChina/followers","following_url":"https://api.github.com/users/FreeCodeCampChina/following{/other_user}","gists_url":"https://api.github.com/users/FreeCodeCampChina/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeCodeCampChina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeCodeCampChina/subscriptions","organizations_url":"https://api.github.com/users/FreeCodeCampChina/orgs","repos_url":"https://api.github.com/users/FreeCodeCampChina/repos","events_url":"https://api.github.com/users/FreeCodeCampChina/events{/privacy}","received_events_url":"https://api.github.com/users/FreeCodeCampChina/received_events","type":"Organization","site_admin":false},"repo":{"id":69629434,"name":"freecodecamp.cn","full_name":"FreeCodeCampChina/freecodecamp.cn","owner":{"login":"FreeCodeCampChina","id":18478284,"avatar_url":"https://avatars3.githubusercontent.com/u/18478284?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeCodeCampChina","html_url":"https://github.com/FreeCodeCampChina","followers_url":"https://api.github.com/users/FreeCodeCampChina/followers","following_url":"https://api.github.com/users/FreeCodeCampChina/following{/other_user}","gists_url":"https://api.github.com/users/FreeCodeCampChina/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeCodeCampChina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeCodeCampChina/subscriptions","organizations_url":"https://api.github.com/users/FreeCodeCampChina/orgs","repos_url":"https://api.github.com/users/FreeCodeCampChina/repos","events_url":"https://api.github.com/users/FreeCodeCampChina/events{/privacy}","received_events_url":"https://api.github.com/users/FreeCodeCampChina/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeCodeCampChina/freecodecamp.cn","description":"看源码请到Code，提问请到Issues，提交代码请到Pull requests，看学习心得请到Wiki。多谢合作，么么哒，^_^。","fork":false,"url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn","forks_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/forks","keys_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/teams","hooks_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/hooks","issue_events_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/issues/events{/number}","events_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/events","assignees_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/assignees{/user}","branches_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/branches{/branch}","tags_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/tags","blobs_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/languages","stargazers_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/stargazers","contributors_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/contributors","subscribers_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/subscribers","subscription_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/subscription","commits_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/contents/{+path}","compare_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/merges","archive_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/downloads","issues_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/issues{/number}","pulls_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/labels{/name}","releases_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/releases{/id}","deployments_url":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/deployments","created_at":"2016-09-30T03:13:43Z","updated_at":"2017-03-19T21:35:24Z","pushed_at":"2017-03-19T12:07:50Z","git_url":"git://github.com/FreeCodeCampChina/freecodecamp.cn.git","ssh_url":"[email protected]:FreeCodeCampChina/freecodecamp.cn.git","clone_url":"https://github.com/FreeCodeCampChina/freecodecamp.cn.git","svn_url":"https://github.com/FreeCodeCampChina/freecodecamp.cn","homepage":null,"size":30276,"stargazers_count":10277,"watchers_count":10277,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":448,"mirror_url":null,"open_issues_count":12,"forks":448,"open_issues":12,"watchers":10277,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/203"},"html":{"href":"https://github.com/FreeCodeCampChina/freecodecamp.cn/pull/203"},"issue":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/issues/203"},"comments":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn/statuses/a09cd876f46e49179d50de3e0974052a7810f13b"}}}} | {
"id": 69629434,
"name": "FreeCodeCampChina/freecodecamp.cn",
"url": "https://api.github.com/repos/FreeCodeCampChina/freecodecamp.cn"
} | {
"id": 13592559,
"login": "S1ngS1ng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13592559?",
"url": "https://api.github.com/users/S1ngS1ng"
} | {
"id": 18478284,
"login": "FreeCodeCampChina",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18478284?",
"url": "https://api.github.com/orgs/FreeCodeCampChina"
} | 2017-03-20T00:14:04 | 5522541048 | {"actor":{"display_login":"S1ngS1ng"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/comments/97591663","pull_request_review_id":18205836,"id":97591663,"diff_hunk":"@@ -41,5 +64,13 @@ public static void writeBagitFile(final Version version, final Charset encoding,\n final String secondLine = \"Tag-File-Character-Encoding : \" + encoding + System.lineSeparator();\n logger.debug(\"Writing line [{}] to [{}]\", secondLine, bagitPath);\n Files.write(bagitPath, secondLine.getBytes(StandardCharsets.UTF_8), StandardOpenOption.WRITE, StandardOpenOption.APPEND);\n+ \n+ if(version.compareTo(ONE_DOT_ZERO) >= 0 && payloadByteCount != null && payloadFileCount != null){ //if it is 1.0 or greater\n+ final String thirdLine = \"Payload-Byte-Count : \" + payloadByteCount + System.lineSeparator();","path":"src/main/java/gov/loc/repository/bagit/writer/BagitFileWriter.java","position":43,"original_position":43,"commit_id":"c837810d38d8bc48b8b42f276c7608edecf1c92f","original_commit_id":"c837810d38d8bc48b8b42f276c7608edecf1c92f","user":{"login":"acdha","id":46565,"avatar_url":"https://avatars.githubusercontent.com/u/46565?v=3","gravatar_id":"","url":"https://api.github.com/users/acdha","html_url":"https://github.com/acdha","followers_url":"https://api.github.com/users/acdha/followers","following_url":"https://api.github.com/users/acdha/following{/other_user}","gists_url":"https://api.github.com/users/acdha/gists{/gist_id}","starred_url":"https://api.github.com/users/acdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdha/subscriptions","organizations_url":"https://api.github.com/users/acdha/orgs","repos_url":"https://api.github.com/users/acdha/repos","events_url":"https://api.github.com/users/acdha/events{/privacy}","received_events_url":"https://api.github.com/users/acdha/received_events","type":"User","site_admin":false},"body":"I'm wondering whether now is the right time to fix the naming convention here - `firstLine`, et al. are making me itch a bit. \r\n\r\nAlso, looking at the `Files.write` code, this is repeatedly opening the same file with a bunch of redundant options and the getBytes calls are being repeated on every line as well. Could all of this be collapsed into a single array with 2-4 lines for a single [`Files.write`](https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#write-java.nio.file.Path-java.lang.Iterable-java.nio.charset.Charset-java.nio.file.OpenOption...-) call using the form which accepts text and the target output encoding?","created_at":"2017-01-24T16:39:49Z","updated_at":"2017-01-24T16:39:49Z","html_url":"https://github.com/LibraryOfCongress/bagit-java/pull/80#discussion_r97591663","pull_request_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/comments/97591663"},"html":{"href":"https://github.com/LibraryOfCongress/bagit-java/pull/80#discussion_r97591663"},"pull_request":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/80","id":102946835,"html_url":"https://github.com/LibraryOfCongress/bagit-java/pull/80","diff_url":"https://github.com/LibraryOfCongress/bagit-java/pull/80.diff","patch_url":"https://github.com/LibraryOfCongress/bagit-java/pull/80.patch","issue_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/80","number":80,"state":"open","locked":false,"title":"as per the proposed spec, allow for payload-oxum to be in bagit.txt","user":{"login":"johnscancella","id":8711605,"avatar_url":"https://avatars.githubusercontent.com/u/8711605?v=3","gravatar_id":"","url":"https://api.github.com/users/johnscancella","html_url":"https://github.com/johnscancella","followers_url":"https://api.github.com/users/johnscancella/followers","following_url":"https://api.github.com/users/johnscancella/following{/other_user}","gists_url":"https://api.github.com/users/johnscancella/gists{/gist_id}","starred_url":"https://api.github.com/users/johnscancella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnscancella/subscriptions","organizations_url":"https://api.github.com/users/johnscancella/orgs","repos_url":"https://api.github.com/users/johnscancella/repos","events_url":"https://api.github.com/users/johnscancella/events{/privacy}","received_events_url":"https://api.github.com/users/johnscancella/received_events","type":"User","site_admin":false},"body":"only merge if https://github.com/loc-rdc/bagitspec/pull/2 is accepted","created_at":"2017-01-24T15:57:19Z","updated_at":"2017-01-24T16:39:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bc7c664e76366317b07f86ba3f4f25d80c41468","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/80/commits","review_comments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/80/comments","review_comment_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/80/comments","statuses_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/statuses/c837810d38d8bc48b8b42f276c7608edecf1c92f","head":{"label":"LibraryOfCongress:migrate_payload_oxum","ref":"migrate_payload_oxum","sha":"c837810d38d8bc48b8b42f276c7608edecf1c92f","user":{"login":"LibraryOfCongress","id":2070730,"avatar_url":"https://avatars.githubusercontent.com/u/2070730?v=3","gravatar_id":"","url":"https://api.github.com/users/LibraryOfCongress","html_url":"https://github.com/LibraryOfCongress","followers_url":"https://api.github.com/users/LibraryOfCongress/followers","following_url":"https://api.github.com/users/LibraryOfCongress/following{/other_user}","gists_url":"https://api.github.com/users/LibraryOfCongress/gists{/gist_id}","starred_url":"https://api.github.com/users/LibraryOfCongress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibraryOfCongress/subscriptions","organizations_url":"https://api.github.com/users/LibraryOfCongress/orgs","repos_url":"https://api.github.com/users/LibraryOfCongress/repos","events_url":"https://api.github.com/users/LibraryOfCongress/events{/privacy}","received_events_url":"https://api.github.com/users/LibraryOfCongress/received_events","type":"Organization","site_admin":false},"repo":{"id":10645334,"name":"bagit-java","full_name":"LibraryOfCongress/bagit-java","owner":{"login":"LibraryOfCongress","id":2070730,"avatar_url":"https://avatars.githubusercontent.com/u/2070730?v=3","gravatar_id":"","url":"https://api.github.com/users/LibraryOfCongress","html_url":"https://github.com/LibraryOfCongress","followers_url":"https://api.github.com/users/LibraryOfCongress/followers","following_url":"https://api.github.com/users/LibraryOfCongress/following{/other_user}","gists_url":"https://api.github.com/users/LibraryOfCongress/gists{/gist_id}","starred_url":"https://api.github.com/users/LibraryOfCongress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibraryOfCongress/subscriptions","organizations_url":"https://api.github.com/users/LibraryOfCongress/orgs","repos_url":"https://api.github.com/users/LibraryOfCongress/repos","events_url":"https://api.github.com/users/LibraryOfCongress/events{/privacy}","received_events_url":"https://api.github.com/users/LibraryOfCongress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LibraryOfCongress/bagit-java","description":"Java library to support the BagIt specification.","fork":false,"url":"https://api.github.com/repos/LibraryOfCongress/bagit-java","forks_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/forks","keys_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/teams","hooks_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/hooks","issue_events_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/events{/number}","events_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/events","assignees_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/assignees{/user}","branches_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/branches{/branch}","tags_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/tags","blobs_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/statuses/{sha}","languages_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/languages","stargazers_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/stargazers","contributors_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/contributors","subscribers_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/subscribers","subscription_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/subscription","commits_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/contents/{+path}","compare_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/merges","archive_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/downloads","issues_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues{/number}","pulls_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls{/number}","milestones_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/milestones{/number}","notifications_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/labels{/name}","releases_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/releases{/id}","deployments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/deployments","created_at":"2013-06-12T15:02:44Z","updated_at":"2017-01-20T20:51:13Z","pushed_at":"2017-01-24T15:57:20Z","git_url":"git://github.com/LibraryOfCongress/bagit-java.git","ssh_url":"[email protected]:LibraryOfCongress/bagit-java.git","clone_url":"https://github.com/LibraryOfCongress/bagit-java.git","svn_url":"https://github.com/LibraryOfCongress/bagit-java","homepage":"","size":148757,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":4,"forks":30,"open_issues":4,"watchers":33,"default_branch":"master"}},"base":{"label":"LibraryOfCongress:master","ref":"master","sha":"87a33bc7008c405997bb50c9a54b972bedd41b65","user":{"login":"LibraryOfCongress","id":2070730,"avatar_url":"https://avatars.githubusercontent.com/u/2070730?v=3","gravatar_id":"","url":"https://api.github.com/users/LibraryOfCongress","html_url":"https://github.com/LibraryOfCongress","followers_url":"https://api.github.com/users/LibraryOfCongress/followers","following_url":"https://api.github.com/users/LibraryOfCongress/following{/other_user}","gists_url":"https://api.github.com/users/LibraryOfCongress/gists{/gist_id}","starred_url":"https://api.github.com/users/LibraryOfCongress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibraryOfCongress/subscriptions","organizations_url":"https://api.github.com/users/LibraryOfCongress/orgs","repos_url":"https://api.github.com/users/LibraryOfCongress/repos","events_url":"https://api.github.com/users/LibraryOfCongress/events{/privacy}","received_events_url":"https://api.github.com/users/LibraryOfCongress/received_events","type":"Organization","site_admin":false},"repo":{"id":10645334,"name":"bagit-java","full_name":"LibraryOfCongress/bagit-java","owner":{"login":"LibraryOfCongress","id":2070730,"avatar_url":"https://avatars.githubusercontent.com/u/2070730?v=3","gravatar_id":"","url":"https://api.github.com/users/LibraryOfCongress","html_url":"https://github.com/LibraryOfCongress","followers_url":"https://api.github.com/users/LibraryOfCongress/followers","following_url":"https://api.github.com/users/LibraryOfCongress/following{/other_user}","gists_url":"https://api.github.com/users/LibraryOfCongress/gists{/gist_id}","starred_url":"https://api.github.com/users/LibraryOfCongress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibraryOfCongress/subscriptions","organizations_url":"https://api.github.com/users/LibraryOfCongress/orgs","repos_url":"https://api.github.com/users/LibraryOfCongress/repos","events_url":"https://api.github.com/users/LibraryOfCongress/events{/privacy}","received_events_url":"https://api.github.com/users/LibraryOfCongress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LibraryOfCongress/bagit-java","description":"Java library to support the BagIt specification.","fork":false,"url":"https://api.github.com/repos/LibraryOfCongress/bagit-java","forks_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/forks","keys_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/teams","hooks_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/hooks","issue_events_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/events{/number}","events_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/events","assignees_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/assignees{/user}","branches_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/branches{/branch}","tags_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/tags","blobs_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/statuses/{sha}","languages_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/languages","stargazers_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/stargazers","contributors_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/contributors","subscribers_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/subscribers","subscription_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/subscription","commits_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/contents/{+path}","compare_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/merges","archive_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/downloads","issues_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues{/number}","pulls_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls{/number}","milestones_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/milestones{/number}","notifications_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/labels{/name}","releases_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/releases{/id}","deployments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/deployments","created_at":"2013-06-12T15:02:44Z","updated_at":"2017-01-20T20:51:13Z","pushed_at":"2017-01-24T15:57:20Z","git_url":"git://github.com/LibraryOfCongress/bagit-java.git","ssh_url":"[email protected]:LibraryOfCongress/bagit-java.git","clone_url":"https://github.com/LibraryOfCongress/bagit-java.git","svn_url":"https://github.com/LibraryOfCongress/bagit-java","homepage":"","size":148757,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":4,"forks":30,"open_issues":4,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/80"},"html":{"href":"https://github.com/LibraryOfCongress/bagit-java/pull/80"},"issue":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/80"},"comments":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/statuses/c837810d38d8bc48b8b42f276c7608edecf1c92f"}}}} | {
"id": 10645334,
"name": "LibraryOfCongress/bagit-java",
"url": "https://api.github.com/repos/LibraryOfCongress/bagit-java"
} | {
"id": 46565,
"login": "acdha",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46565?",
"url": "https://api.github.com/users/acdha"
} | {
"id": 2070730,
"login": "LibraryOfCongress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2070730?",
"url": "https://api.github.com/orgs/LibraryOfCongress"
} | 2017-01-24T16:39:49 | 5204921942 | {"actor":{"display_login":"acdha"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/comments/144844215","pull_request_review_id":69552223,"id":144844215,"diff_hunk":"@@ -0,0 +1,564 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<?xml-model href=\"http://www.stoa.org/epidoc/schema/latest/tei-epidoc.rng\" schematypens=\"http://relaxng.org/ns/structure/1.0\"?>\n+<TEI xmlns=\"http://www.tei-c.org/ns/1.0\">\n+ <teiHeader xml:lang=\"eng\">\n+ <fileDesc>\n+ <titleStmt>\n+ <title xml:lang=\"lat\">Dicaearchi, ut fertur, potius vero Athenaei Descriptionis\n+ Graeciae Fragmenta tria</title>\n+ <author>Ps. Dicaearchus</author>\n+ <!-- for the related identification issue see https://github.com/PerseusDL/catalog_data/issues/82 -->\n+ <editor xml:lang=\"lat\">Carolus Müllerus</editor>\n+ <funder>Harvard Library Arcadia Fund</funder>\n+ <principal>Gregory Crane</principal>\n+ <respStmt>\n+ <persName xml:id=\"DDD\">Digital Divide Data</persName>\n+ <resp>Corrected and encoded the text</resp>\n+ </respStmt>\n+ <respStmt>\n+ <persName>Gregory Crane</persName>\n+ <resp>Editor-in-Chief, Perseus Digital Library</resp>\n+ </respStmt>\n+ <respStmt>\n+ <persName>Matt Munson</persName>\n+ <resp>Project Manager (University of Leipzig), 2016 - present</resp>\n+ </respStmt>\n+ <respStmt>\n+ <persName>Annette Gessner</persName>\n+ <resp>Project Assistant (University of Leipzig) 2015 - present</resp>\n+ </respStmt>\n+ <respStmt>\n+ <persName>Thibault Clérice</persName>\n+ <resp>Lead Developer (University of Leipzig) 2015 - 2017</resp>\n+ </respStmt>\n+ <respStmt>\n+ <persName>Bruce Robertson</persName>\n+ <resp>Technical Advisor</resp>\n+\n+ </respStmt>\n+ </titleStmt>\n+ <publicationStmt>\n+ <authority>Harvard College Library</authority>\n+ <idno type=\"filename\">tlg0066.tlg001.1st1K-grc1.xml</idno>\n+ <availability>\n+ <p>Available under a Creative Commons Attribution-ShareAlike 4.0 International\n+ License</p>\n+ </availability>\n+ <date>2017</date>\n+ <publisher>Harvard College Library</publisher>\n+ <pubPlace>United States</pubPlace>\n+ </publicationStmt>\n+ <sourceDesc>\n+ <listBibl>\n+ <biblStruct>\n+ <monogr>\n+\n+ <title>Geographi Graeci Minores</title>\n+ <editor>\n+ <persName>\n+ <name xml:lang=\"lat\">Carolus Müller</name>","path":"data/tlg0066/tlg001/tlg0066.tlg001.1st1K-grc1.xml","position":59,"original_position":59,"commit_id":"525205ae0766a36914b6ace203b35697eb24bb9e","original_commit_id":"525205ae0766a36914b6ace203b35697eb24bb9e","user":{"login":"sonofmun","id":3787067,"avatar_url":"https://avatars3.githubusercontent.com/u/3787067?v=4","gravatar_id":"","url":"https://api.github.com/users/sonofmun","html_url":"https://github.com/sonofmun","followers_url":"https://api.github.com/users/sonofmun/followers","following_url":"https://api.github.com/users/sonofmun/following{/other_user}","gists_url":"https://api.github.com/users/sonofmun/gists{/gist_id}","starred_url":"https://api.github.com/users/sonofmun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonofmun/subscriptions","organizations_url":"https://api.github.com/users/sonofmun/orgs","repos_url":"https://api.github.com/users/sonofmun/repos","events_url":"https://api.github.com/users/sonofmun/events{/privacy}","received_events_url":"https://api.github.com/users/sonofmun/received_events","type":"User","site_admin":false},"body":"Above the last name is \"Müllerus\"","created_at":"2017-10-16T13:21:46Z","updated_at":"2017-10-16T13:24:23Z","html_url":"https://github.com/OpenGreekAndLatin/First1KGreek/pull/1796#discussion_r144844215","pull_request_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/1796","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/comments/144844215"},"html":{"href":"https://github.com/OpenGreekAndLatin/First1KGreek/pull/1796#discussion_r144844215"},"pull_request":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/1796"}}},"pull_request":{"url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/1796","id":141061036,"html_url":"https://github.com/OpenGreekAndLatin/First1KGreek/pull/1796","diff_url":"https://github.com/OpenGreekAndLatin/First1KGreek/pull/1796.diff","patch_url":"https://github.com/OpenGreekAndLatin/First1KGreek/pull/1796.patch","issue_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/issues/1796","number":1796,"state":"open","locked":false,"title":"Added Geographi Graeci Minores volume 1","user":{"login":"ChiaraPalladino","id":15249889,"avatar_url":"https://avatars0.githubusercontent.com/u/15249889?v=4","gravatar_id":"","url":"https://api.github.com/users/ChiaraPalladino","html_url":"https://github.com/ChiaraPalladino","followers_url":"https://api.github.com/users/ChiaraPalladino/followers","following_url":"https://api.github.com/users/ChiaraPalladino/following{/other_user}","gists_url":"https://api.github.com/users/ChiaraPalladino/gists{/gist_id}","starred_url":"https://api.github.com/users/ChiaraPalladino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChiaraPalladino/subscriptions","organizations_url":"https://api.github.com/users/ChiaraPalladino/orgs","repos_url":"https://api.github.com/users/ChiaraPalladino/repos","events_url":"https://api.github.com/users/ChiaraPalladino/events{/privacy}","received_events_url":"https://api.github.com/users/ChiaraPalladino/received_events","type":"User","site_admin":false},"body":"Finally starting to add the new files from Mueller vol. 1. ","created_at":"2017-09-14T12:31:50Z","updated_at":"2017-10-16T13:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aeb4d878b344bd965945d3126b6c20d4ebc9687b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/1796/commits","review_comments_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/1796/comments","review_comment_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/issues/1796/comments","statuses_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/statuses/525205ae0766a36914b6ace203b35697eb24bb9e","head":{"label":"ChiaraPalladino:ggm1","ref":"ggm1","sha":"525205ae0766a36914b6ace203b35697eb24bb9e","user":{"login":"ChiaraPalladino","id":15249889,"avatar_url":"https://avatars0.githubusercontent.com/u/15249889?v=4","gravatar_id":"","url":"https://api.github.com/users/ChiaraPalladino","html_url":"https://github.com/ChiaraPalladino","followers_url":"https://api.github.com/users/ChiaraPalladino/followers","following_url":"https://api.github.com/users/ChiaraPalladino/following{/other_user}","gists_url":"https://api.github.com/users/ChiaraPalladino/gists{/gist_id}","starred_url":"https://api.github.com/users/ChiaraPalladino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChiaraPalladino/subscriptions","organizations_url":"https://api.github.com/users/ChiaraPalladino/orgs","repos_url":"https://api.github.com/users/ChiaraPalladino/repos","events_url":"https://api.github.com/users/ChiaraPalladino/events{/privacy}","received_events_url":"https://api.github.com/users/ChiaraPalladino/received_events","type":"User","site_admin":false},"repo":{"id":100610359,"name":"First1KGreek","full_name":"ChiaraPalladino/First1KGreek","owner":{"login":"ChiaraPalladino","id":15249889,"avatar_url":"https://avatars0.githubusercontent.com/u/15249889?v=4","gravatar_id":"","url":"https://api.github.com/users/ChiaraPalladino","html_url":"https://github.com/ChiaraPalladino","followers_url":"https://api.github.com/users/ChiaraPalladino/followers","following_url":"https://api.github.com/users/ChiaraPalladino/following{/other_user}","gists_url":"https://api.github.com/users/ChiaraPalladino/gists{/gist_id}","starred_url":"https://api.github.com/users/ChiaraPalladino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChiaraPalladino/subscriptions","organizations_url":"https://api.github.com/users/ChiaraPalladino/orgs","repos_url":"https://api.github.com/users/ChiaraPalladino/repos","events_url":"https://api.github.com/users/ChiaraPalladino/events{/privacy}","received_events_url":"https://api.github.com/users/ChiaraPalladino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChiaraPalladino/First1KGreek","description":"XML files for the works in the First Thousand Years of Greek Project. ","fork":true,"url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek","forks_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/forks","keys_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/teams","hooks_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/hooks","issue_events_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/issues/events{/number}","events_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/events","assignees_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/assignees{/user}","branches_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/branches{/branch}","tags_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/tags","blobs_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/statuses/{sha}","languages_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/languages","stargazers_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/stargazers","contributors_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/contributors","subscribers_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/subscribers","subscription_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/subscription","commits_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/contents/{+path}","compare_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/merges","archive_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/downloads","issues_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/issues{/number}","pulls_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/pulls{/number}","milestones_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/milestones{/number}","notifications_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/labels{/name}","releases_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/releases{/id}","deployments_url":"https://api.github.com/repos/ChiaraPalladino/First1KGreek/deployments","created_at":"2017-08-17T14:08:47Z","updated_at":"2017-08-17T14:09:05Z","pushed_at":"2017-09-20T08:17:33Z","git_url":"git://github.com/ChiaraPalladino/First1KGreek.git","ssh_url":"[email protected]:ChiaraPalladino/First1KGreek.git","clone_url":"https://github.com/ChiaraPalladino/First1KGreek.git","svn_url":"https://github.com/ChiaraPalladino/First1KGreek","homepage":"http://opengreekandlatin.github.io/First1KGreek/","size":570252,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenGreekAndLatin:master","ref":"master","sha":"ae0639e7bc9a3fbbc869d7d03bb53fad4ffbf778","user":{"login":"OpenGreekAndLatin","id":6459378,"avatar_url":"https://avatars2.githubusercontent.com/u/6459378?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenGreekAndLatin","html_url":"https://github.com/OpenGreekAndLatin","followers_url":"https://api.github.com/users/OpenGreekAndLatin/followers","following_url":"https://api.github.com/users/OpenGreekAndLatin/following{/other_user}","gists_url":"https://api.github.com/users/OpenGreekAndLatin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGreekAndLatin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGreekAndLatin/subscriptions","organizations_url":"https://api.github.com/users/OpenGreekAndLatin/orgs","repos_url":"https://api.github.com/users/OpenGreekAndLatin/repos","events_url":"https://api.github.com/users/OpenGreekAndLatin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGreekAndLatin/received_events","type":"Organization","site_admin":false},"repo":{"id":56595003,"name":"First1KGreek","full_name":"OpenGreekAndLatin/First1KGreek","owner":{"login":"OpenGreekAndLatin","id":6459378,"avatar_url":"https://avatars2.githubusercontent.com/u/6459378?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenGreekAndLatin","html_url":"https://github.com/OpenGreekAndLatin","followers_url":"https://api.github.com/users/OpenGreekAndLatin/followers","following_url":"https://api.github.com/users/OpenGreekAndLatin/following{/other_user}","gists_url":"https://api.github.com/users/OpenGreekAndLatin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGreekAndLatin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGreekAndLatin/subscriptions","organizations_url":"https://api.github.com/users/OpenGreekAndLatin/orgs","repos_url":"https://api.github.com/users/OpenGreekAndLatin/repos","events_url":"https://api.github.com/users/OpenGreekAndLatin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGreekAndLatin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenGreekAndLatin/First1KGreek","description":"XML files for the works in the First Thousand Years of Greek Project. ","fork":false,"url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek","forks_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/forks","keys_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/teams","hooks_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/hooks","issue_events_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/issues/events{/number}","events_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/events","assignees_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/assignees{/user}","branches_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/branches{/branch}","tags_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/tags","blobs_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/languages","stargazers_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/stargazers","contributors_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/contributors","subscribers_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/subscribers","subscription_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/subscription","commits_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/contents/{+path}","compare_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/merges","archive_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/downloads","issues_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/issues{/number}","pulls_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/labels{/name}","releases_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/releases{/id}","deployments_url":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/deployments","created_at":"2016-04-19T12:32:06Z","updated_at":"2017-10-07T12:15:04Z","pushed_at":"2017-10-16T10:30:24Z","git_url":"git://github.com/OpenGreekAndLatin/First1KGreek.git","ssh_url":"[email protected]:OpenGreekAndLatin/First1KGreek.git","clone_url":"https://github.com/OpenGreekAndLatin/First1KGreek.git","svn_url":"https://github.com/OpenGreekAndLatin/First1KGreek","homepage":"http://opengreekandlatin.github.io/First1KGreek/","size":581931,"stargazers_count":19,"watchers_count":19,"language":"XSLT","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":73,"forks":30,"open_issues":73,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/1796"},"html":{"href":"https://github.com/OpenGreekAndLatin/First1KGreek/pull/1796"},"issue":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/issues/1796"},"comments":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/issues/1796/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/1796/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/pulls/1796/commits"},"statuses":{"href":"https://api.github.com/repos/OpenGreekAndLatin/First1KGreek/statuses/525205ae0766a36914b6ace203b35697eb24bb9e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 56595003,
"name": "OpenGreekAndLatin/First1KGreek",
"url": "https://api.github.com/repos/OpenGreekAndLatin/First1KGreek"
} | {
"id": 3787067,
"login": "sonofmun",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3787067?",
"url": "https://api.github.com/users/sonofmun"
} | {
"id": 6459378,
"login": "OpenGreekAndLatin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6459378?",
"url": "https://api.github.com/orgs/OpenGreekAndLatin"
} | 2017-10-16T13:21:46 | 6721876908 | {"actor":{"display_login":"sonofmun"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/comments/151576910","pull_request_review_id":77310513,"id":151576910,"diff_hunk":"@@ -34,21 +49,21 @@ export default class AnnotationViewer extends Component {\n onClick={(e) => this.props.callbacks.onDelete(e, this.props.annotation)}>Delete</button>\n </span>\n <div>\n- {this.props.annotation.fields.annotationPriority}\n+ {(this.props.annotation.fields || {}).annotationPriority}\n </div>\n <div>\n- {this.props.annotation.fields.comment}\n+ {(this.props.annotation.fields || {}).comment}\n </div>\n <div>\n- {this.props.annotation.fields.link}\n+ {(this.props.annotation.fields || {}).link}\n </div>\n <div>\n- {this.props.annotation.fields.linkTitle}\n+ {(this.props.annotation.fields || {}).linkTitle}\n </div>\n <div>\n- {this.props.annotation.fields.isLinkOnly}\n+ {(this.props.annotation.fields || {}).isLinkOnly}","path":"src/pp-annotator/viewer/AnnotationViewer.tsx","position":49,"original_position":49,"commit_id":"849f1ff704befb0841bdd815aac88ee57107c161","original_commit_id":"02e6e73d490cad34c70023e80c73ee378417967f","user":{"login":"msz","id":3967778,"avatar_url":"https://avatars0.githubusercontent.com/u/3967778?v=4","gravatar_id":"","url":"https://api.github.com/users/msz","html_url":"https://github.com/msz","followers_url":"https://api.github.com/users/msz/followers","following_url":"https://api.github.com/users/msz/following{/other_user}","gists_url":"https://api.github.com/users/msz/gists{/gist_id}","starred_url":"https://api.github.com/users/msz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msz/subscriptions","organizations_url":"https://api.github.com/users/msz/orgs","repos_url":"https://api.github.com/users/msz/repos","events_url":"https://api.github.com/users/msz/events{/privacy}","received_events_url":"https://api.github.com/users/msz/received_events","type":"User","site_admin":false},"body":"to tymczasowy hack, już nie jest potrzebny bo zmieniłem interfejs","created_at":"2017-11-17T00:39:38Z","updated_at":"2017-11-17T00:39:38Z","html_url":"https://github.com/PrzypisPowszechny/pp-client/pull/8#discussion_r151576910","pull_request_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/comments/151576910"},"html":{"href":"https://github.com/PrzypisPowszechny/pp-client/pull/8#discussion_r151576910"},"pull_request":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/8"}},"in_reply_to_id":151530157},"pull_request":{"url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/8","id":152108113,"html_url":"https://github.com/PrzypisPowszechny/pp-client/pull/8","diff_url":"https://github.com/PrzypisPowszechny/pp-client/pull/8.diff","patch_url":"https://github.com/PrzypisPowszechny/pp-client/pull/8.patch","issue_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/issues/8","number":8,"state":"open","locked":false,"title":"[WIP] add typescript","user":{"login":"msz","id":3967778,"avatar_url":"https://avatars0.githubusercontent.com/u/3967778?v=4","gravatar_id":"","url":"https://api.github.com/users/msz","html_url":"https://github.com/msz","followers_url":"https://api.github.com/users/msz/followers","following_url":"https://api.github.com/users/msz/following{/other_user}","gists_url":"https://api.github.com/users/msz/gists{/gist_id}","starred_url":"https://api.github.com/users/msz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msz/subscriptions","organizations_url":"https://api.github.com/users/msz/orgs","repos_url":"https://api.github.com/users/msz/repos","events_url":"https://api.github.com/users/msz/events{/privacy}","received_events_url":"https://api.github.com/users/msz/received_events","type":"User","site_admin":false},"body":"- [x] convert codebase to typescript\n- [x] enable strict flags\n- [ ] add tslint + prettier","created_at":"2017-11-12T15:07:46Z","updated_at":"2017-11-17T00:39:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb8a511b04b65da1740f0598fa010766adb674e0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/8/commits","review_comments_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/8/comments","review_comment_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/issues/8/comments","statuses_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/statuses/849f1ff704befb0841bdd815aac88ee57107c161","head":{"label":"msz:add-typescript","ref":"add-typescript","sha":"849f1ff704befb0841bdd815aac88ee57107c161","user":{"login":"msz","id":3967778,"avatar_url":"https://avatars0.githubusercontent.com/u/3967778?v=4","gravatar_id":"","url":"https://api.github.com/users/msz","html_url":"https://github.com/msz","followers_url":"https://api.github.com/users/msz/followers","following_url":"https://api.github.com/users/msz/following{/other_user}","gists_url":"https://api.github.com/users/msz/gists{/gist_id}","starred_url":"https://api.github.com/users/msz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msz/subscriptions","organizations_url":"https://api.github.com/users/msz/orgs","repos_url":"https://api.github.com/users/msz/repos","events_url":"https://api.github.com/users/msz/events{/privacy}","received_events_url":"https://api.github.com/users/msz/received_events","type":"User","site_admin":false},"repo":{"id":110439636,"name":"pp-client","full_name":"msz/pp-client","owner":{"login":"msz","id":3967778,"avatar_url":"https://avatars0.githubusercontent.com/u/3967778?v=4","gravatar_id":"","url":"https://api.github.com/users/msz","html_url":"https://github.com/msz","followers_url":"https://api.github.com/users/msz/followers","following_url":"https://api.github.com/users/msz/following{/other_user}","gists_url":"https://api.github.com/users/msz/gists{/gist_id}","starred_url":"https://api.github.com/users/msz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msz/subscriptions","organizations_url":"https://api.github.com/users/msz/orgs","repos_url":"https://api.github.com/users/msz/repos","events_url":"https://api.github.com/users/msz/events{/privacy}","received_events_url":"https://api.github.com/users/msz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msz/pp-client","description":null,"fork":true,"url":"https://api.github.com/repos/msz/pp-client","forks_url":"https://api.github.com/repos/msz/pp-client/forks","keys_url":"https://api.github.com/repos/msz/pp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msz/pp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msz/pp-client/teams","hooks_url":"https://api.github.com/repos/msz/pp-client/hooks","issue_events_url":"https://api.github.com/repos/msz/pp-client/issues/events{/number}","events_url":"https://api.github.com/repos/msz/pp-client/events","assignees_url":"https://api.github.com/repos/msz/pp-client/assignees{/user}","branches_url":"https://api.github.com/repos/msz/pp-client/branches{/branch}","tags_url":"https://api.github.com/repos/msz/pp-client/tags","blobs_url":"https://api.github.com/repos/msz/pp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msz/pp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msz/pp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/msz/pp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msz/pp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/msz/pp-client/languages","stargazers_url":"https://api.github.com/repos/msz/pp-client/stargazers","contributors_url":"https://api.github.com/repos/msz/pp-client/contributors","subscribers_url":"https://api.github.com/repos/msz/pp-client/subscribers","subscription_url":"https://api.github.com/repos/msz/pp-client/subscription","commits_url":"https://api.github.com/repos/msz/pp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/msz/pp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/msz/pp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/msz/pp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/msz/pp-client/contents/{+path}","compare_url":"https://api.github.com/repos/msz/pp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msz/pp-client/merges","archive_url":"https://api.github.com/repos/msz/pp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msz/pp-client/downloads","issues_url":"https://api.github.com/repos/msz/pp-client/issues{/number}","pulls_url":"https://api.github.com/repos/msz/pp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/msz/pp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/msz/pp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msz/pp-client/labels{/name}","releases_url":"https://api.github.com/repos/msz/pp-client/releases{/id}","deployments_url":"https://api.github.com/repos/msz/pp-client/deployments","created_at":"2017-11-12T14:34:29Z","updated_at":"2017-11-12T14:34:30Z","pushed_at":"2017-11-16T21:40:10Z","git_url":"git://github.com/msz/pp-client.git","ssh_url":"[email protected]:msz/pp-client.git","clone_url":"https://github.com/msz/pp-client.git","svn_url":"https://github.com/msz/pp-client","homepage":null,"size":1171,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PrzypisPowszechny:develop","ref":"develop","sha":"8483f85603b23dc7b32eac3281f68504665e7cc2","user":{"login":"PrzypisPowszechny","id":29638054,"avatar_url":"https://avatars2.githubusercontent.com/u/29638054?v=4","gravatar_id":"","url":"https://api.github.com/users/PrzypisPowszechny","html_url":"https://github.com/PrzypisPowszechny","followers_url":"https://api.github.com/users/PrzypisPowszechny/followers","following_url":"https://api.github.com/users/PrzypisPowszechny/following{/other_user}","gists_url":"https://api.github.com/users/PrzypisPowszechny/gists{/gist_id}","starred_url":"https://api.github.com/users/PrzypisPowszechny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrzypisPowszechny/subscriptions","organizations_url":"https://api.github.com/users/PrzypisPowszechny/orgs","repos_url":"https://api.github.com/users/PrzypisPowszechny/repos","events_url":"https://api.github.com/users/PrzypisPowszechny/events{/privacy}","received_events_url":"https://api.github.com/users/PrzypisPowszechny/received_events","type":"Organization","site_admin":false},"repo":{"id":97049654,"name":"pp-client","full_name":"PrzypisPowszechny/pp-client","owner":{"login":"PrzypisPowszechny","id":29638054,"avatar_url":"https://avatars2.githubusercontent.com/u/29638054?v=4","gravatar_id":"","url":"https://api.github.com/users/PrzypisPowszechny","html_url":"https://github.com/PrzypisPowszechny","followers_url":"https://api.github.com/users/PrzypisPowszechny/followers","following_url":"https://api.github.com/users/PrzypisPowszechny/following{/other_user}","gists_url":"https://api.github.com/users/PrzypisPowszechny/gists{/gist_id}","starred_url":"https://api.github.com/users/PrzypisPowszechny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrzypisPowszechny/subscriptions","organizations_url":"https://api.github.com/users/PrzypisPowszechny/orgs","repos_url":"https://api.github.com/users/PrzypisPowszechny/repos","events_url":"https://api.github.com/users/PrzypisPowszechny/events{/privacy}","received_events_url":"https://api.github.com/users/PrzypisPowszechny/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrzypisPowszechny/pp-client","description":null,"fork":false,"url":"https://api.github.com/repos/PrzypisPowszechny/pp-client","forks_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/forks","keys_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/teams","hooks_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/hooks","issue_events_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/issues/events{/number}","events_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/events","assignees_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/assignees{/user}","branches_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/branches{/branch}","tags_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/tags","blobs_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/languages","stargazers_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/stargazers","contributors_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/contributors","subscribers_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/subscribers","subscription_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/subscription","commits_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/contents/{+path}","compare_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/merges","archive_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/downloads","issues_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/issues{/number}","pulls_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/labels{/name}","releases_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/releases{/id}","deployments_url":"https://api.github.com/repos/PrzypisPowszechny/pp-client/deployments","created_at":"2017-07-12T20:33:45Z","updated_at":"2017-11-07T14:38:42Z","pushed_at":"2017-11-16T21:40:11Z","git_url":"git://github.com/PrzypisPowszechny/pp-client.git","ssh_url":"[email protected]:PrzypisPowszechny/pp-client.git","clone_url":"https://github.com/PrzypisPowszechny/pp-client.git","svn_url":"https://github.com/PrzypisPowszechny/pp-client","homepage":null,"size":1275,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/8"},"html":{"href":"https://github.com/PrzypisPowszechny/pp-client/pull/8"},"issue":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/issues/8"},"comments":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/PrzypisPowszechny/pp-client/statuses/849f1ff704befb0841bdd815aac88ee57107c161"}},"author_association":"COLLABORATOR"}} | {
"id": 97049654,
"name": "PrzypisPowszechny/pp-client",
"url": "https://api.github.com/repos/PrzypisPowszechny/pp-client"
} | {
"id": 3967778,
"login": "msz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3967778?",
"url": "https://api.github.com/users/msz"
} | {
"id": 29638054,
"login": "PrzypisPowszechny",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29638054?",
"url": "https://api.github.com/orgs/PrzypisPowszechny"
} | 2017-11-17T00:39:38 | 6867469118 | {"actor":{"display_login":"msz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/comments/107180214","pull_request_review_id":28136153,"id":107180214,"diff_hunk":"@@ -1,8 +1,9 @@\n+set(CMAKE_CXX_COMPILER \"${PROJECT_BINARY_DIR}/compiler/bin/clang++\")\n \n-if(COMMAND CMAKE_FORCE_CXX_COMPILER)\n-CMAKE_FORCE_CXX_COMPILER(\"${PROJECT_BINARY_DIR}/compiler/bin/clang++\" MCWAMPCC)\n-endif()\n add_executable(cmake-test cmake-test.cpp)\n+\n+add_dependencies(cmake-test world)","path":"cmake-tests/CMakeLists.txt","position":8,"original_position":8,"commit_id":"e6a4fc4536191efc12331e27be9f8cae3393e244","original_commit_id":"e6a4fc4536191efc12331e27be9f8cae3393e244","user":{"login":"pfultz2","id":1306044,"avatar_url":"https://avatars2.githubusercontent.com/u/1306044?v=3","gravatar_id":"","url":"https://api.github.com/users/pfultz2","html_url":"https://github.com/pfultz2","followers_url":"https://api.github.com/users/pfultz2/followers","following_url":"https://api.github.com/users/pfultz2/following{/other_user}","gists_url":"https://api.github.com/users/pfultz2/gists{/gist_id}","starred_url":"https://api.github.com/users/pfultz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfultz2/subscriptions","organizations_url":"https://api.github.com/users/pfultz2/orgs","repos_url":"https://api.github.com/users/pfultz2/repos","events_url":"https://api.github.com/users/pfultz2/events{/privacy}","received_events_url":"https://api.github.com/users/pfultz2/received_events","type":"User","site_admin":false},"body":"This breaks the test when ran as standalone, which is useful for testing the `find_package(hcc)` logic. Either this line should be moved into the `if(TARGET hccrt)` conditional block or hccrt should be update to depend on the world target, so this line can be removed.","created_at":"2017-03-21T15:04:51Z","updated_at":"2017-03-21T15:04:51Z","html_url":"https://github.com/RadeonOpenCompute/hcc/pull/267#discussion_r107180214","pull_request_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/267","_links":{"self":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/comments/107180214"},"html":{"href":"https://github.com/RadeonOpenCompute/hcc/pull/267#discussion_r107180214"},"pull_request":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/267"}}},"pull_request":{"url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/267","id":111520895,"html_url":"https://github.com/RadeonOpenCompute/hcc/pull/267","diff_url":"https://github.com/RadeonOpenCompute/hcc/pull/267.diff","patch_url":"https://github.com/RadeonOpenCompute/hcc/pull/267.patch","issue_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/267","number":267,"state":"open","locked":false,"title":"refine cmake files:","user":{"login":"dfukalov","id":1671137,"avatar_url":"https://avatars2.githubusercontent.com/u/1671137?v=3","gravatar_id":"","url":"https://api.github.com/users/dfukalov","html_url":"https://github.com/dfukalov","followers_url":"https://api.github.com/users/dfukalov/followers","following_url":"https://api.github.com/users/dfukalov/following{/other_user}","gists_url":"https://api.github.com/users/dfukalov/gists{/gist_id}","starred_url":"https://api.github.com/users/dfukalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfukalov/subscriptions","organizations_url":"https://api.github.com/users/dfukalov/orgs","repos_url":"https://api.github.com/users/dfukalov/repos","events_url":"https://api.github.com/users/dfukalov/events{/privacy}","received_events_url":"https://api.github.com/users/dfukalov/received_events","type":"User","site_admin":false},"body":"1. use add_subdirectory to include llvm/clang tree instead of add_custom_target.\r\n there were explicit cmake&make invokes for each hcc build\r\n2. version string building code moved out to function add_version_info_from_git\r\n3. removed confusing instruction to do \"make world\" for first time\r\n4. removed a number of not used variables (like EXECUTABLE_OUTPUT_PATH)\r\n5. removed use of ProcessorCount() since the llvm tree make is a part of whole\r\n hcc build\r\n6. removed using CMAKE_FORCE_CXX_COMPILER - it is deprecated in cmake 3.6","created_at":"2017-03-20T10:17:37Z","updated_at":"2017-03-21T15:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8731919f34ec62b9bc75c3a17f92d39743ce40f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/267/commits","review_comments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/267/comments","review_comment_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/267/comments","statuses_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/statuses/e6a4fc4536191efc12331e27be9f8cae3393e244","head":{"label":"RadeonOpenCompute:cmake_refine","ref":"cmake_refine","sha":"e6a4fc4536191efc12331e27be9f8cae3393e244","user":{"login":"RadeonOpenCompute","id":16900649,"avatar_url":"https://avatars0.githubusercontent.com/u/16900649?v=3","gravatar_id":"","url":"https://api.github.com/users/RadeonOpenCompute","html_url":"https://github.com/RadeonOpenCompute","followers_url":"https://api.github.com/users/RadeonOpenCompute/followers","following_url":"https://api.github.com/users/RadeonOpenCompute/following{/other_user}","gists_url":"https://api.github.com/users/RadeonOpenCompute/gists{/gist_id}","starred_url":"https://api.github.com/users/RadeonOpenCompute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadeonOpenCompute/subscriptions","organizations_url":"https://api.github.com/users/RadeonOpenCompute/orgs","repos_url":"https://api.github.com/users/RadeonOpenCompute/repos","events_url":"https://api.github.com/users/RadeonOpenCompute/events{/privacy}","received_events_url":"https://api.github.com/users/RadeonOpenCompute/received_events","type":"Organization","site_admin":false},"repo":{"id":54489277,"name":"hcc","full_name":"RadeonOpenCompute/hcc","owner":{"login":"RadeonOpenCompute","id":16900649,"avatar_url":"https://avatars0.githubusercontent.com/u/16900649?v=3","gravatar_id":"","url":"https://api.github.com/users/RadeonOpenCompute","html_url":"https://github.com/RadeonOpenCompute","followers_url":"https://api.github.com/users/RadeonOpenCompute/followers","following_url":"https://api.github.com/users/RadeonOpenCompute/following{/other_user}","gists_url":"https://api.github.com/users/RadeonOpenCompute/gists{/gist_id}","starred_url":"https://api.github.com/users/RadeonOpenCompute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadeonOpenCompute/subscriptions","organizations_url":"https://api.github.com/users/RadeonOpenCompute/orgs","repos_url":"https://api.github.com/users/RadeonOpenCompute/repos","events_url":"https://api.github.com/users/RadeonOpenCompute/events{/privacy}","received_events_url":"https://api.github.com/users/RadeonOpenCompute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RadeonOpenCompute/hcc","description":"HCC is an Open Source, Optimizing C++ Compiler for Heterogeneous Compute currently for the ROCm GPU Computing Platform","fork":false,"url":"https://api.github.com/repos/RadeonOpenCompute/hcc","forks_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/forks","keys_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/teams","hooks_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/hooks","issue_events_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/events{/number}","events_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/events","assignees_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/assignees{/user}","branches_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/branches{/branch}","tags_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/tags","blobs_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/statuses/{sha}","languages_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/languages","stargazers_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/stargazers","contributors_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/contributors","subscribers_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/subscribers","subscription_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/subscription","commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/contents/{+path}","compare_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/merges","archive_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/downloads","issues_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues{/number}","pulls_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls{/number}","milestones_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/milestones{/number}","notifications_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/labels{/name}","releases_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/releases{/id}","deployments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/deployments","created_at":"2016-03-22T16:04:00Z","updated_at":"2017-03-20T23:29:35Z","pushed_at":"2017-03-20T10:17:37Z","git_url":"git://github.com/RadeonOpenCompute/hcc.git","ssh_url":"[email protected]:RadeonOpenCompute/hcc.git","clone_url":"https://github.com/RadeonOpenCompute/hcc.git","svn_url":"https://github.com/RadeonOpenCompute/hcc","homepage":"https://github.com/RadeonOpenCompute/hcc/wiki","size":19615,"stargazers_count":116,"watchers_count":116,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":20,"forks":35,"open_issues":20,"watchers":116,"default_branch":"clang_tot_upgrade"}},"base":{"label":"RadeonOpenCompute:clang_tot_upgrade","ref":"clang_tot_upgrade","sha":"17883d4a4c3efcc54394af35476c3f01bb60c9dd","user":{"login":"RadeonOpenCompute","id":16900649,"avatar_url":"https://avatars0.githubusercontent.com/u/16900649?v=3","gravatar_id":"","url":"https://api.github.com/users/RadeonOpenCompute","html_url":"https://github.com/RadeonOpenCompute","followers_url":"https://api.github.com/users/RadeonOpenCompute/followers","following_url":"https://api.github.com/users/RadeonOpenCompute/following{/other_user}","gists_url":"https://api.github.com/users/RadeonOpenCompute/gists{/gist_id}","starred_url":"https://api.github.com/users/RadeonOpenCompute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadeonOpenCompute/subscriptions","organizations_url":"https://api.github.com/users/RadeonOpenCompute/orgs","repos_url":"https://api.github.com/users/RadeonOpenCompute/repos","events_url":"https://api.github.com/users/RadeonOpenCompute/events{/privacy}","received_events_url":"https://api.github.com/users/RadeonOpenCompute/received_events","type":"Organization","site_admin":false},"repo":{"id":54489277,"name":"hcc","full_name":"RadeonOpenCompute/hcc","owner":{"login":"RadeonOpenCompute","id":16900649,"avatar_url":"https://avatars0.githubusercontent.com/u/16900649?v=3","gravatar_id":"","url":"https://api.github.com/users/RadeonOpenCompute","html_url":"https://github.com/RadeonOpenCompute","followers_url":"https://api.github.com/users/RadeonOpenCompute/followers","following_url":"https://api.github.com/users/RadeonOpenCompute/following{/other_user}","gists_url":"https://api.github.com/users/RadeonOpenCompute/gists{/gist_id}","starred_url":"https://api.github.com/users/RadeonOpenCompute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadeonOpenCompute/subscriptions","organizations_url":"https://api.github.com/users/RadeonOpenCompute/orgs","repos_url":"https://api.github.com/users/RadeonOpenCompute/repos","events_url":"https://api.github.com/users/RadeonOpenCompute/events{/privacy}","received_events_url":"https://api.github.com/users/RadeonOpenCompute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RadeonOpenCompute/hcc","description":"HCC is an Open Source, Optimizing C++ Compiler for Heterogeneous Compute currently for the ROCm GPU Computing Platform","fork":false,"url":"https://api.github.com/repos/RadeonOpenCompute/hcc","forks_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/forks","keys_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/teams","hooks_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/hooks","issue_events_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/events{/number}","events_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/events","assignees_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/assignees{/user}","branches_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/branches{/branch}","tags_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/tags","blobs_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/statuses/{sha}","languages_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/languages","stargazers_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/stargazers","contributors_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/contributors","subscribers_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/subscribers","subscription_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/subscription","commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/contents/{+path}","compare_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/merges","archive_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/downloads","issues_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues{/number}","pulls_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls{/number}","milestones_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/milestones{/number}","notifications_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/labels{/name}","releases_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/releases{/id}","deployments_url":"https://api.github.com/repos/RadeonOpenCompute/hcc/deployments","created_at":"2016-03-22T16:04:00Z","updated_at":"2017-03-20T23:29:35Z","pushed_at":"2017-03-20T10:17:37Z","git_url":"git://github.com/RadeonOpenCompute/hcc.git","ssh_url":"[email protected]:RadeonOpenCompute/hcc.git","clone_url":"https://github.com/RadeonOpenCompute/hcc.git","svn_url":"https://github.com/RadeonOpenCompute/hcc","homepage":"https://github.com/RadeonOpenCompute/hcc/wiki","size":19615,"stargazers_count":116,"watchers_count":116,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":20,"forks":35,"open_issues":20,"watchers":116,"default_branch":"clang_tot_upgrade"}},"_links":{"self":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/267"},"html":{"href":"https://github.com/RadeonOpenCompute/hcc/pull/267"},"issue":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/267"},"comments":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/RadeonOpenCompute/hcc/statuses/e6a4fc4536191efc12331e27be9f8cae3393e244"}}}} | {
"id": 54489277,
"name": "RadeonOpenCompute/hcc",
"url": "https://api.github.com/repos/RadeonOpenCompute/hcc"
} | {
"id": 1306044,
"login": "pfultz2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1306044?",
"url": "https://api.github.com/users/pfultz2"
} | {
"id": 16900649,
"login": "RadeonOpenCompute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16900649?",
"url": "https://api.github.com/orgs/RadeonOpenCompute"
} | 2017-03-21T15:04:51 | 5534266163 | {"actor":{"display_login":"pfultz2"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/comments/135586651","pull_request_review_id":59014031,"id":135586651,"diff_hunk":"@@ -44,50 +44,45 @@ abstract class VeracodeTask extends DefaultTask {\n 'fileId' : '123',\n 'mode' : 'action|actionSummary|verbose',\n 'maxUploadAttempts': '123',\n- 'fileId' : 'xxx',\n 'buildId1' : '123',\n 'buildId2' : '123'\n ]\n \n- def requiredArguments = []\n+ List<String> requiredArguments = []\n+ List<String> optionalArguments = []\n \n VeracodeTask() {\n group = 'Veracode'\n }\n \n abstract void run()\n \n- final String correctUsage() {\n- StringBuilder sb = new StringBuilder(\"Example of usage: gradle ${getName()}\")\n- requiredArguments.each() {\n- if (!isArgumentOptional(it)) {\n- sb.append(\" -P${it}=${validArguments.get(it)}\")\n- } else {\n- String originalArgument = it.substring(0, it.length() - OPTIONAL.length())\n- sb.append(\" [-P${originalArgument}=${validArguments.get(originalArgument)}]\")\n- }\n+ protected static String correctUsage(String taskName,\n+ List<String> requiredArguments,\n+ List<String> optionalArguments) {\n+ StringBuilder sb = new StringBuilder(\"Missing required arguments: gradle ${taskName}\")\n+ requiredArguments.each() { arg ->\n+ sb.append(\" -P${arg}=${validArguments.get(arg)}\")","path":"src/main/groovy/com/calgaryscientific/gradle/VeracodeTask.groovy","position":50,"original_position":50,"commit_id":"7893183dde046c73484b92c7968e69855926bae3","original_commit_id":"7893183dde046c73484b92c7968e69855926bae3","user":{"login":"tonytvo","id":9420482,"avatar_url":"https://avatars0.githubusercontent.com/u/9420482?v=4","gravatar_id":"","url":"https://api.github.com/users/tonytvo","html_url":"https://github.com/tonytvo","followers_url":"https://api.github.com/users/tonytvo/followers","following_url":"https://api.github.com/users/tonytvo/following{/other_user}","gists_url":"https://api.github.com/users/tonytvo/gists{/gist_id}","starred_url":"https://api.github.com/users/tonytvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonytvo/subscriptions","organizations_url":"https://api.github.com/users/tonytvo/orgs","repos_url":"https://api.github.com/users/tonytvo/repos","events_url":"https://api.github.com/users/tonytvo/events{/privacy}","received_events_url":"https://api.github.com/users/tonytvo/received_events","type":"User","site_admin":false},"body":"I would do something with groovy idiom: requiredArguments.collect { arg -> -P${arg}=${validArguments.get(arg)} }.join(' ')","created_at":"2017-08-28T17:44:43Z","updated_at":"2017-08-28T17:44:43Z","html_url":"https://github.com/calgaryscientific/veracode-gradle-plugin/pull/11#discussion_r135586651","pull_request_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/comments/135586651"},"html":{"href":"https://github.com/calgaryscientific/veracode-gradle-plugin/pull/11#discussion_r135586651"},"pull_request":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/11","id":137995475,"html_url":"https://github.com/calgaryscientific/veracode-gradle-plugin/pull/11","diff_url":"https://github.com/calgaryscientific/veracode-gradle-plugin/pull/11.diff","patch_url":"https://github.com/calgaryscientific/veracode-gradle-plugin/pull/11.patch","issue_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues/11","number":11,"state":"open","locked":false,"title":"People/davidgamba/rmd 20676 refactor required and optional task arguments 2","user":{"login":"DavidGamba","id":1115287,"avatar_url":"https://avatars2.githubusercontent.com/u/1115287?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidGamba","html_url":"https://github.com/DavidGamba","followers_url":"https://api.github.com/users/DavidGamba/followers","following_url":"https://api.github.com/users/DavidGamba/following{/other_user}","gists_url":"https://api.github.com/users/DavidGamba/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidGamba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidGamba/subscriptions","organizations_url":"https://api.github.com/users/DavidGamba/orgs","repos_url":"https://api.github.com/users/DavidGamba/repos","events_url":"https://api.github.com/users/DavidGamba/events{/privacy}","received_events_url":"https://api.github.com/users/DavidGamba/received_events","type":"User","site_admin":false},"body":"@tonytvo please review.","created_at":"2017-08-28T17:24:39Z","updated_at":"2017-08-28T17:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"942abfd88aa4aa6e7bcebb83dac8127fe106280e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/11/commits","review_comments_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/11/comments","review_comment_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues/11/comments","statuses_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/statuses/7893183dde046c73484b92c7968e69855926bae3","head":{"label":"calgaryscientific:people/davidgamba/rmd-20676-refactor-required-and-optional-task-arguments-2","ref":"people/davidgamba/rmd-20676-refactor-required-and-optional-task-arguments-2","sha":"7893183dde046c73484b92c7968e69855926bae3","user":{"login":"calgaryscientific","id":1659802,"avatar_url":"https://avatars3.githubusercontent.com/u/1659802?v=4","gravatar_id":"","url":"https://api.github.com/users/calgaryscientific","html_url":"https://github.com/calgaryscientific","followers_url":"https://api.github.com/users/calgaryscientific/followers","following_url":"https://api.github.com/users/calgaryscientific/following{/other_user}","gists_url":"https://api.github.com/users/calgaryscientific/gists{/gist_id}","starred_url":"https://api.github.com/users/calgaryscientific/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calgaryscientific/subscriptions","organizations_url":"https://api.github.com/users/calgaryscientific/orgs","repos_url":"https://api.github.com/users/calgaryscientific/repos","events_url":"https://api.github.com/users/calgaryscientific/events{/privacy}","received_events_url":"https://api.github.com/users/calgaryscientific/received_events","type":"Organization","site_admin":false},"repo":{"id":97640765,"name":"veracode-gradle-plugin","full_name":"calgaryscientific/veracode-gradle-plugin","owner":{"login":"calgaryscientific","id":1659802,"avatar_url":"https://avatars3.githubusercontent.com/u/1659802?v=4","gravatar_id":"","url":"https://api.github.com/users/calgaryscientific","html_url":"https://github.com/calgaryscientific","followers_url":"https://api.github.com/users/calgaryscientific/followers","following_url":"https://api.github.com/users/calgaryscientific/following{/other_user}","gists_url":"https://api.github.com/users/calgaryscientific/gists{/gist_id}","starred_url":"https://api.github.com/users/calgaryscientific/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calgaryscientific/subscriptions","organizations_url":"https://api.github.com/users/calgaryscientific/orgs","repos_url":"https://api.github.com/users/calgaryscientific/repos","events_url":"https://api.github.com/users/calgaryscientific/events{/privacy}","received_events_url":"https://api.github.com/users/calgaryscientific/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/calgaryscientific/veracode-gradle-plugin","description":"Veracode Tools","fork":true,"url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin","forks_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/forks","keys_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/events","assignees_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/merges","archive_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/deployments","created_at":"2017-07-18T20:25:37Z","updated_at":"2017-07-20T22:29:18Z","pushed_at":"2017-08-28T17:24:40Z","git_url":"git://github.com/calgaryscientific/veracode-gradle-plugin.git","ssh_url":"[email protected]:calgaryscientific/veracode-gradle-plugin.git","clone_url":"https://github.com/calgaryscientific/veracode-gradle-plugin.git","svn_url":"https://github.com/calgaryscientific/veracode-gradle-plugin","homepage":null,"size":263,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"calgaryscientific:master","ref":"master","sha":"8de62e15c9caa000b3f9aa6965fadf9535bb0507","user":{"login":"calgaryscientific","id":1659802,"avatar_url":"https://avatars3.githubusercontent.com/u/1659802?v=4","gravatar_id":"","url":"https://api.github.com/users/calgaryscientific","html_url":"https://github.com/calgaryscientific","followers_url":"https://api.github.com/users/calgaryscientific/followers","following_url":"https://api.github.com/users/calgaryscientific/following{/other_user}","gists_url":"https://api.github.com/users/calgaryscientific/gists{/gist_id}","starred_url":"https://api.github.com/users/calgaryscientific/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calgaryscientific/subscriptions","organizations_url":"https://api.github.com/users/calgaryscientific/orgs","repos_url":"https://api.github.com/users/calgaryscientific/repos","events_url":"https://api.github.com/users/calgaryscientific/events{/privacy}","received_events_url":"https://api.github.com/users/calgaryscientific/received_events","type":"Organization","site_admin":false},"repo":{"id":97640765,"name":"veracode-gradle-plugin","full_name":"calgaryscientific/veracode-gradle-plugin","owner":{"login":"calgaryscientific","id":1659802,"avatar_url":"https://avatars3.githubusercontent.com/u/1659802?v=4","gravatar_id":"","url":"https://api.github.com/users/calgaryscientific","html_url":"https://github.com/calgaryscientific","followers_url":"https://api.github.com/users/calgaryscientific/followers","following_url":"https://api.github.com/users/calgaryscientific/following{/other_user}","gists_url":"https://api.github.com/users/calgaryscientific/gists{/gist_id}","starred_url":"https://api.github.com/users/calgaryscientific/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calgaryscientific/subscriptions","organizations_url":"https://api.github.com/users/calgaryscientific/orgs","repos_url":"https://api.github.com/users/calgaryscientific/repos","events_url":"https://api.github.com/users/calgaryscientific/events{/privacy}","received_events_url":"https://api.github.com/users/calgaryscientific/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/calgaryscientific/veracode-gradle-plugin","description":"Veracode Tools","fork":true,"url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin","forks_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/forks","keys_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/events","assignees_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/merges","archive_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/deployments","created_at":"2017-07-18T20:25:37Z","updated_at":"2017-07-20T22:29:18Z","pushed_at":"2017-08-28T17:24:40Z","git_url":"git://github.com/calgaryscientific/veracode-gradle-plugin.git","ssh_url":"[email protected]:calgaryscientific/veracode-gradle-plugin.git","clone_url":"https://github.com/calgaryscientific/veracode-gradle-plugin.git","svn_url":"https://github.com/calgaryscientific/veracode-gradle-plugin","homepage":null,"size":263,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/11"},"html":{"href":"https://github.com/calgaryscientific/veracode-gradle-plugin/pull/11"},"issue":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues/11"},"comments":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin/statuses/7893183dde046c73484b92c7968e69855926bae3"}}}} | {
"id": 97640765,
"name": "calgaryscientific/veracode-gradle-plugin",
"url": "https://api.github.com/repos/calgaryscientific/veracode-gradle-plugin"
} | {
"id": 9420482,
"login": "tonytvo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9420482?",
"url": "https://api.github.com/users/tonytvo"
} | {
"id": 1659802,
"login": "calgaryscientific",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1659802?",
"url": "https://api.github.com/orgs/calgaryscientific"
} | 2017-08-28T17:44:43 | 6520738560 | {"actor":{"display_login":"tonytvo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/comments/118361344","pull_request_review_id":40146882,"id":118361344,"diff_hunk":"@@ -36,80 +36,23 @@ static void Main(string[] args)\n \r\n public void UpdateQuality()\r\n {\r\n- for (var i = 0; i < Items.Count; i++)\r\n+ foreach (var item in Items)\r\n {\r\n- if (Items[i].Name != \"Aged Brie\" && Items[i].Name != \"Backstage passes to a TAFKAL80ETC concert\")\r\n+ if (!StoreItemIdentifier.IsLegendaryItem(item))\r\n {\r\n- if (Items[i].Quality > 0)\r\n- {\r\n- if (Items[i].Name != \"Sulfuras, Hand of Ragnaros\")\r\n- {\r\n- Items[i].Quality = Items[i].Quality - 1;\r\n- }\r\n- }\r\n- }\r\n- else\r\n- {\r\n- if (Items[i].Quality < 50)\r\n- {\r\n- Items[i].Quality = Items[i].Quality + 1;\r\n-\r\n- if (Items[i].Name == \"Backstage passes to a TAFKAL80ETC concert\")\r\n- {\r\n- if (Items[i].SellIn < 11)\r\n- {\r\n- if (Items[i].Quality < 50)\r\n- {\r\n- Items[i].Quality = Items[i].Quality + 1;\r\n- }\r\n- }\r\n-\r\n- if (Items[i].SellIn < 6)\r\n- {\r\n- if (Items[i].Quality < 50)\r\n- {\r\n- Items[i].Quality = Items[i].Quality + 1;\r\n- }\r\n- }\r\n- }\r\n- }\r\n- }\r\n-\r\n- if (Items[i].Name != \"Sulfuras, Hand of Ragnaros\")\r\n- {\r\n- Items[i].SellIn = Items[i].SellIn - 1;\r\n- }\r\n-\r\n- if (Items[i].SellIn < 0)\r\n- {\r\n- if (Items[i].Name != \"Aged Brie\")\r\n- {\r\n- if (Items[i].Name != \"Backstage passes to a TAFKAL80ETC concert\")\r\n- {\r\n- if (Items[i].Quality > 0)\r\n- {\r\n- if (Items[i].Name != \"Sulfuras, Hand of Ragnaros\")\r\n- {\r\n- Items[i].Quality = Items[i].Quality - 1;\r\n- }\r\n- }\r\n- }\r\n- else\r\n- {\r\n- Items[i].Quality = Items[i].Quality - Items[i].Quality;\r\n- }\r\n- }\r\n+ StoreItemUpdater.PassTime(item);\r\n+\r\n+ if (StoreItemIdentifier.IsAgedItem(item))\r\n+ StoreItemUpdater.UpdateAgedItemQuality(item);\r\n+ else if (StoreItemIdentifier.IsBackstagePasses(item))\r\n+ StoreItemUpdater.UpdateBackstagePassesQuality(item);\r\n+ else if (StoreItemIdentifier.IsConjuredItem(item))\r\n+ StoreItemUpdater.UpdateConjuredItemQuality(item);\r\n else\r\n- {\r\n- if (Items[i].Quality < 50)\r\n- {\r\n- Items[i].Quality = Items[i].Quality + 1;\r\n- }\r\n- }\r\n+ StoreItemUpdater.UpdateItemQuality(item);\r\n }\r\n }\r\n }\r\n-\r\n }\r\n \r\n public class Item\r","path":"src/GildedRose.Console/Program.cs","position":103,"original_position":103,"commit_id":"e60b80e5bd333007d7fafec06e6c57f72c503190","original_commit_id":"e60b80e5bd333007d7fafec06e6c57f72c503190","user":{"login":"FGS-TBittner","id":26417588,"avatar_url":"https://avatars0.githubusercontent.com/u/26417588?v=3","gravatar_id":"","url":"https://api.github.com/users/FGS-TBittner","html_url":"https://github.com/FGS-TBittner","followers_url":"https://api.github.com/users/FGS-TBittner/followers","following_url":"https://api.github.com/users/FGS-TBittner/following{/other_user}","gists_url":"https://api.github.com/users/FGS-TBittner/gists{/gist_id}","starred_url":"https://api.github.com/users/FGS-TBittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FGS-TBittner/subscriptions","organizations_url":"https://api.github.com/users/FGS-TBittner/orgs","repos_url":"https://api.github.com/users/FGS-TBittner/repos","events_url":"https://api.github.com/users/FGS-TBittner/events{/privacy}","received_events_url":"https://api.github.com/users/FGS-TBittner/received_events","type":"User","site_admin":false},"body":"The way the instructions read to me made it seem like `UpdateQuality` was the only thing that could change in the `Program` file. Does the `Main` function need to be changed at all?","created_at":"2017-05-24T20:50:41Z","updated_at":"2017-05-24T20:50:41Z","html_url":"https://github.com/foxguardsolutions/CodeCamp-GildedRose/pull/4#discussion_r118361344","pull_request_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/comments/118361344"},"html":{"href":"https://github.com/foxguardsolutions/CodeCamp-GildedRose/pull/4#discussion_r118361344"},"pull_request":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/4","id":122302735,"html_url":"https://github.com/foxguardsolutions/CodeCamp-GildedRose/pull/4","diff_url":"https://github.com/foxguardsolutions/CodeCamp-GildedRose/pull/4.diff","patch_url":"https://github.com/foxguardsolutions/CodeCamp-GildedRose/pull/4.patch","issue_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/issues/4","number":4,"state":"open","locked":false,"title":"TBittner - Gilded Rose Solution","user":{"login":"FGS-TBittner","id":26417588,"avatar_url":"https://avatars0.githubusercontent.com/u/26417588?v=3","gravatar_id":"","url":"https://api.github.com/users/FGS-TBittner","html_url":"https://github.com/FGS-TBittner","followers_url":"https://api.github.com/users/FGS-TBittner/followers","following_url":"https://api.github.com/users/FGS-TBittner/following{/other_user}","gists_url":"https://api.github.com/users/FGS-TBittner/gists{/gist_id}","starred_url":"https://api.github.com/users/FGS-TBittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FGS-TBittner/subscriptions","organizations_url":"https://api.github.com/users/FGS-TBittner/orgs","repos_url":"https://api.github.com/users/FGS-TBittner/repos","events_url":"https://api.github.com/users/FGS-TBittner/events{/privacy}","received_events_url":"https://api.github.com/users/FGS-TBittner/received_events","type":"User","site_admin":false},"body":"Gilded Rose `UpdateQuality` function refactored to a more easily modified state. `UpdateQuality` rules added for \"conjured\" `Item`s as specified in the README file.","created_at":"2017-05-24T19:14:04Z","updated_at":"2017-05-24T20:50:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcf91cbd94b7ebfdaabedaf35ae02b897a2a5da9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/4/commits","review_comments_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/4/comments","review_comment_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/issues/4/comments","statuses_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/statuses/e60b80e5bd333007d7fafec06e6c57f72c503190","head":{"label":"FGS-TBittner:tbittner","ref":"tbittner","sha":"e60b80e5bd333007d7fafec06e6c57f72c503190","user":{"login":"FGS-TBittner","id":26417588,"avatar_url":"https://avatars0.githubusercontent.com/u/26417588?v=3","gravatar_id":"","url":"https://api.github.com/users/FGS-TBittner","html_url":"https://github.com/FGS-TBittner","followers_url":"https://api.github.com/users/FGS-TBittner/followers","following_url":"https://api.github.com/users/FGS-TBittner/following{/other_user}","gists_url":"https://api.github.com/users/FGS-TBittner/gists{/gist_id}","starred_url":"https://api.github.com/users/FGS-TBittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FGS-TBittner/subscriptions","organizations_url":"https://api.github.com/users/FGS-TBittner/orgs","repos_url":"https://api.github.com/users/FGS-TBittner/repos","events_url":"https://api.github.com/users/FGS-TBittner/events{/privacy}","received_events_url":"https://api.github.com/users/FGS-TBittner/received_events","type":"User","site_admin":false},"repo":{"id":91810374,"name":"CodeCamp-GildedRose","full_name":"FGS-TBittner/CodeCamp-GildedRose","owner":{"login":"FGS-TBittner","id":26417588,"avatar_url":"https://avatars0.githubusercontent.com/u/26417588?v=3","gravatar_id":"","url":"https://api.github.com/users/FGS-TBittner","html_url":"https://github.com/FGS-TBittner","followers_url":"https://api.github.com/users/FGS-TBittner/followers","following_url":"https://api.github.com/users/FGS-TBittner/following{/other_user}","gists_url":"https://api.github.com/users/FGS-TBittner/gists{/gist_id}","starred_url":"https://api.github.com/users/FGS-TBittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FGS-TBittner/subscriptions","organizations_url":"https://api.github.com/users/FGS-TBittner/orgs","repos_url":"https://api.github.com/users/FGS-TBittner/repos","events_url":"https://api.github.com/users/FGS-TBittner/events{/privacy}","received_events_url":"https://api.github.com/users/FGS-TBittner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FGS-TBittner/CodeCamp-GildedRose","description":"Refactoring Kata","fork":true,"url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose","forks_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/forks","keys_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/teams","hooks_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/hooks","issue_events_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/issues/events{/number}","events_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/events","assignees_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/assignees{/user}","branches_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/branches{/branch}","tags_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/tags","blobs_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/git/refs{/sha}","trees_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/statuses/{sha}","languages_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/languages","stargazers_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/stargazers","contributors_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/contributors","subscribers_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/subscribers","subscription_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/subscription","commits_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/commits{/sha}","git_commits_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/git/commits{/sha}","comments_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/comments{/number}","issue_comment_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/issues/comments{/number}","contents_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/contents/{+path}","compare_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/merges","archive_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/downloads","issues_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/issues{/number}","pulls_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/pulls{/number}","milestones_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/milestones{/number}","notifications_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/labels{/name}","releases_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/releases{/id}","deployments_url":"https://api.github.com/repos/FGS-TBittner/CodeCamp-GildedRose/deployments","created_at":"2017-05-19T13:45:52Z","updated_at":"2017-05-19T13:45:53Z","pushed_at":"2017-05-24T19:02:34Z","git_url":"git://github.com/FGS-TBittner/CodeCamp-GildedRose.git","ssh_url":"[email protected]:FGS-TBittner/CodeCamp-GildedRose.git","clone_url":"https://github.com/FGS-TBittner/CodeCamp-GildedRose.git","svn_url":"https://github.com/FGS-TBittner/CodeCamp-GildedRose","homepage":"","size":5459,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"foxguardsolutions:tbittner","ref":"tbittner","sha":"90ec1ef17172cb485f25c02331d6f22f63472ac6","user":{"login":"foxguardsolutions","id":10062567,"avatar_url":"https://avatars1.githubusercontent.com/u/10062567?v=3","gravatar_id":"","url":"https://api.github.com/users/foxguardsolutions","html_url":"https://github.com/foxguardsolutions","followers_url":"https://api.github.com/users/foxguardsolutions/followers","following_url":"https://api.github.com/users/foxguardsolutions/following{/other_user}","gists_url":"https://api.github.com/users/foxguardsolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/foxguardsolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxguardsolutions/subscriptions","organizations_url":"https://api.github.com/users/foxguardsolutions/orgs","repos_url":"https://api.github.com/users/foxguardsolutions/repos","events_url":"https://api.github.com/users/foxguardsolutions/events{/privacy}","received_events_url":"https://api.github.com/users/foxguardsolutions/received_events","type":"Organization","site_admin":false},"repo":{"id":41683916,"name":"CodeCamp-GildedRose","full_name":"foxguardsolutions/CodeCamp-GildedRose","owner":{"login":"foxguardsolutions","id":10062567,"avatar_url":"https://avatars1.githubusercontent.com/u/10062567?v=3","gravatar_id":"","url":"https://api.github.com/users/foxguardsolutions","html_url":"https://github.com/foxguardsolutions","followers_url":"https://api.github.com/users/foxguardsolutions/followers","following_url":"https://api.github.com/users/foxguardsolutions/following{/other_user}","gists_url":"https://api.github.com/users/foxguardsolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/foxguardsolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxguardsolutions/subscriptions","organizations_url":"https://api.github.com/users/foxguardsolutions/orgs","repos_url":"https://api.github.com/users/foxguardsolutions/repos","events_url":"https://api.github.com/users/foxguardsolutions/events{/privacy}","received_events_url":"https://api.github.com/users/foxguardsolutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foxguardsolutions/CodeCamp-GildedRose","description":"Refactoring Kata","fork":true,"url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose","forks_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/forks","keys_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/teams","hooks_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/hooks","issue_events_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/issues/events{/number}","events_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/events","assignees_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/assignees{/user}","branches_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/branches{/branch}","tags_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/tags","blobs_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/git/refs{/sha}","trees_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/statuses/{sha}","languages_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/languages","stargazers_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/stargazers","contributors_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/contributors","subscribers_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/subscribers","subscription_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/subscription","commits_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/commits{/sha}","git_commits_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/git/commits{/sha}","comments_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/comments{/number}","issue_comment_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/issues/comments{/number}","contents_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/contents/{+path}","compare_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/merges","archive_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/downloads","issues_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/issues{/number}","pulls_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls{/number}","milestones_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/milestones{/number}","notifications_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/labels{/name}","releases_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/releases{/id}","deployments_url":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/deployments","created_at":"2015-08-31T15:32:36Z","updated_at":"2016-11-14T15:28:03Z","pushed_at":"2017-05-24T19:14:04Z","git_url":"git://github.com/foxguardsolutions/CodeCamp-GildedRose.git","ssh_url":"[email protected]:foxguardsolutions/CodeCamp-GildedRose.git","clone_url":"https://github.com/foxguardsolutions/CodeCamp-GildedRose.git","svn_url":"https://github.com/foxguardsolutions/CodeCamp-GildedRose","homepage":"","size":5447,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/4"},"html":{"href":"https://github.com/foxguardsolutions/CodeCamp-GildedRose/pull/4"},"issue":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/issues/4"},"comments":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose/statuses/e60b80e5bd333007d7fafec06e6c57f72c503190"}}}} | {
"id": 41683916,
"name": "foxguardsolutions/CodeCamp-GildedRose",
"url": "https://api.github.com/repos/foxguardsolutions/CodeCamp-GildedRose"
} | {
"id": 26417588,
"login": "FGS-TBittner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26417588?",
"url": "https://api.github.com/users/FGS-TBittner"
} | {
"id": 10062567,
"login": "foxguardsolutions",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10062567?",
"url": "https://api.github.com/orgs/foxguardsolutions"
} | 2017-05-24T20:50:41 | 5937365242 | {"actor":{"display_login":"FGS-TBittner"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/comments/148396822","pull_request_review_id":73626749,"id":148396822,"diff_hunk":"@@ -311,6 +318,17 @@ def has_read_record_permission(user, record):\n return has_admin_permission()\n \n \n+def has_read_record_eos_path_permission(user, record):\n+ \"\"\"Check if user has eos path permissions.\"\"\"\n+ user_provides = get_user_provides()\n+ # Allow e-group members only\n+ read_access_groups = current_app.config.get('VIDEOS_EOS_PATH_EGROUPS', [])\n+\n+ if not set(user_provides).isdisjoint(set(read_access_groups)):","path":"cds/modules/records/permissions.py","position":38,"original_position":38,"commit_id":"b495d8dd08a478774576ceb6d4c56b91eeb05f82","original_commit_id":"b495d8dd08a478774576ceb6d4c56b91eeb05f82","user":{"login":"ntarocco","id":2089455,"avatar_url":"https://avatars1.githubusercontent.com/u/2089455?v=4","gravatar_id":"","url":"https://api.github.com/users/ntarocco","html_url":"https://github.com/ntarocco","followers_url":"https://api.github.com/users/ntarocco/followers","following_url":"https://api.github.com/users/ntarocco/following{/other_user}","gists_url":"https://api.github.com/users/ntarocco/gists{/gist_id}","starred_url":"https://api.github.com/users/ntarocco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntarocco/subscriptions","organizations_url":"https://api.github.com/users/ntarocco/orgs","repos_url":"https://api.github.com/users/ntarocco/repos","events_url":"https://api.github.com/users/ntarocco/events{/privacy}","received_events_url":"https://api.github.com/users/ntarocco/received_events","type":"User","site_admin":false},"body":"nice! is it worth to add a quick comment to explain?","created_at":"2017-11-01T22:00:55Z","updated_at":"2017-11-01T22:16:31Z","html_url":"https://github.com/CERNDocumentServer/cds-videos/pull/1273#discussion_r148396822","pull_request_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/1273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/comments/148396822"},"html":{"href":"https://github.com/CERNDocumentServer/cds-videos/pull/1273#discussion_r148396822"},"pull_request":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/1273"}}},"pull_request":{"url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/1273","id":150099479,"html_url":"https://github.com/CERNDocumentServer/cds-videos/pull/1273","diff_url":"https://github.com/CERNDocumentServer/cds-videos/pull/1273.diff","patch_url":"https://github.com/CERNDocumentServer/cds-videos/pull/1273.patch","issue_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/issues/1273","number":1273,"state":"open","locked":false,"title":"global: addition of EOS path","user":{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false},"body":"* Adds the EOS path to library field, which is only visible to\r\n admins add users that are part of ``VIDEOS_EOS_PATH_EGROUPS``.\r\n (closes #1257)\r\n\r\nSigned-off-by: Harris Tzovanakis <[email protected]>","created_at":"2017-11-01T17:38:30Z","updated_at":"2017-11-01T22:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66eff6a334bb31cf275e54d3d5d3152fcb115eff","assignee":null,"assignees":[],"requested_reviewers":[{"login":"egabancho","id":582735,"avatar_url":"https://avatars2.githubusercontent.com/u/582735?v=4","gravatar_id":"","url":"https://api.github.com/users/egabancho","html_url":"https://github.com/egabancho","followers_url":"https://api.github.com/users/egabancho/followers","following_url":"https://api.github.com/users/egabancho/following{/other_user}","gists_url":"https://api.github.com/users/egabancho/gists{/gist_id}","starred_url":"https://api.github.com/users/egabancho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egabancho/subscriptions","organizations_url":"https://api.github.com/users/egabancho/orgs","repos_url":"https://api.github.com/users/egabancho/repos","events_url":"https://api.github.com/users/egabancho/events{/privacy}","received_events_url":"https://api.github.com/users/egabancho/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/1273/commits","review_comments_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/1273/comments","review_comment_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/issues/1273/comments","statuses_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/statuses/b495d8dd08a478774576ceb6d4c56b91eeb05f82","head":{"label":"drjova:eos-path","ref":"eos-path","sha":"b495d8dd08a478774576ceb6d4c56b91eeb05f82","user":{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false},"repo":{"id":19571893,"name":"cds-demosite","full_name":"drjova/cds-demosite","owner":{"login":"drjova","id":4287772,"avatar_url":"https://avatars3.githubusercontent.com/u/4287772?v=4","gravatar_id":"","url":"https://api.github.com/users/drjova","html_url":"https://github.com/drjova","followers_url":"https://api.github.com/users/drjova/followers","following_url":"https://api.github.com/users/drjova/following{/other_user}","gists_url":"https://api.github.com/users/drjova/gists{/gist_id}","starred_url":"https://api.github.com/users/drjova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drjova/subscriptions","organizations_url":"https://api.github.com/users/drjova/orgs","repos_url":"https://api.github.com/users/drjova/repos","events_url":"https://api.github.com/users/drjova/events{/privacy}","received_events_url":"https://api.github.com/users/drjova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drjova/cds-demosite","description":"A demosite for cds-next","fork":true,"url":"https://api.github.com/repos/drjova/cds-demosite","forks_url":"https://api.github.com/repos/drjova/cds-demosite/forks","keys_url":"https://api.github.com/repos/drjova/cds-demosite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drjova/cds-demosite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drjova/cds-demosite/teams","hooks_url":"https://api.github.com/repos/drjova/cds-demosite/hooks","issue_events_url":"https://api.github.com/repos/drjova/cds-demosite/issues/events{/number}","events_url":"https://api.github.com/repos/drjova/cds-demosite/events","assignees_url":"https://api.github.com/repos/drjova/cds-demosite/assignees{/user}","branches_url":"https://api.github.com/repos/drjova/cds-demosite/branches{/branch}","tags_url":"https://api.github.com/repos/drjova/cds-demosite/tags","blobs_url":"https://api.github.com/repos/drjova/cds-demosite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drjova/cds-demosite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drjova/cds-demosite/git/refs{/sha}","trees_url":"https://api.github.com/repos/drjova/cds-demosite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drjova/cds-demosite/statuses/{sha}","languages_url":"https://api.github.com/repos/drjova/cds-demosite/languages","stargazers_url":"https://api.github.com/repos/drjova/cds-demosite/stargazers","contributors_url":"https://api.github.com/repos/drjova/cds-demosite/contributors","subscribers_url":"https://api.github.com/repos/drjova/cds-demosite/subscribers","subscription_url":"https://api.github.com/repos/drjova/cds-demosite/subscription","commits_url":"https://api.github.com/repos/drjova/cds-demosite/commits{/sha}","git_commits_url":"https://api.github.com/repos/drjova/cds-demosite/git/commits{/sha}","comments_url":"https://api.github.com/repos/drjova/cds-demosite/comments{/number}","issue_comment_url":"https://api.github.com/repos/drjova/cds-demosite/issues/comments{/number}","contents_url":"https://api.github.com/repos/drjova/cds-demosite/contents/{+path}","compare_url":"https://api.github.com/repos/drjova/cds-demosite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drjova/cds-demosite/merges","archive_url":"https://api.github.com/repos/drjova/cds-demosite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drjova/cds-demosite/downloads","issues_url":"https://api.github.com/repos/drjova/cds-demosite/issues{/number}","pulls_url":"https://api.github.com/repos/drjova/cds-demosite/pulls{/number}","milestones_url":"https://api.github.com/repos/drjova/cds-demosite/milestones{/number}","notifications_url":"https://api.github.com/repos/drjova/cds-demosite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drjova/cds-demosite/labels{/name}","releases_url":"https://api.github.com/repos/drjova/cds-demosite/releases{/id}","deployments_url":"https://api.github.com/repos/drjova/cds-demosite/deployments","created_at":"2014-05-08T12:03:59Z","updated_at":"2016-11-28T17:39:04Z","pushed_at":"2017-11-01T18:11:06Z","git_url":"git://github.com/drjova/cds-demosite.git","ssh_url":"[email protected]:drjova/cds-demosite.git","clone_url":"https://github.com/drjova/cds-demosite.git","svn_url":"https://github.com/drjova/cds-demosite","homepage":"","size":76710,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"cdslabs_qa"}},"base":{"label":"CERNDocumentServer:cdslabs_qa","ref":"cdslabs_qa","sha":"6d50606969c9211358a97e574c57fd06f273dd63","user":{"login":"CERNDocumentServer","id":7450686,"avatar_url":"https://avatars2.githubusercontent.com/u/7450686?v=4","gravatar_id":"","url":"https://api.github.com/users/CERNDocumentServer","html_url":"https://github.com/CERNDocumentServer","followers_url":"https://api.github.com/users/CERNDocumentServer/followers","following_url":"https://api.github.com/users/CERNDocumentServer/following{/other_user}","gists_url":"https://api.github.com/users/CERNDocumentServer/gists{/gist_id}","starred_url":"https://api.github.com/users/CERNDocumentServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CERNDocumentServer/subscriptions","organizations_url":"https://api.github.com/users/CERNDocumentServer/orgs","repos_url":"https://api.github.com/users/CERNDocumentServer/repos","events_url":"https://api.github.com/users/CERNDocumentServer/events{/privacy}","received_events_url":"https://api.github.com/users/CERNDocumentServer/received_events","type":"Organization","site_admin":false},"repo":{"id":19456880,"name":"cds-videos","full_name":"CERNDocumentServer/cds-videos","owner":{"login":"CERNDocumentServer","id":7450686,"avatar_url":"https://avatars2.githubusercontent.com/u/7450686?v=4","gravatar_id":"","url":"https://api.github.com/users/CERNDocumentServer","html_url":"https://github.com/CERNDocumentServer","followers_url":"https://api.github.com/users/CERNDocumentServer/followers","following_url":"https://api.github.com/users/CERNDocumentServer/following{/other_user}","gists_url":"https://api.github.com/users/CERNDocumentServer/gists{/gist_id}","starred_url":"https://api.github.com/users/CERNDocumentServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CERNDocumentServer/subscriptions","organizations_url":"https://api.github.com/users/CERNDocumentServer/orgs","repos_url":"https://api.github.com/users/CERNDocumentServer/repos","events_url":"https://api.github.com/users/CERNDocumentServer/events{/privacy}","received_events_url":"https://api.github.com/users/CERNDocumentServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CERNDocumentServer/cds-videos","description":"Access articles, reports and multimedia content in HEP","fork":false,"url":"https://api.github.com/repos/CERNDocumentServer/cds-videos","forks_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/forks","keys_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/teams","hooks_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/hooks","issue_events_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/issues/events{/number}","events_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/events","assignees_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/assignees{/user}","branches_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/branches{/branch}","tags_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/tags","blobs_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/git/refs{/sha}","trees_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/statuses/{sha}","languages_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/languages","stargazers_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/stargazers","contributors_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/contributors","subscribers_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/subscribers","subscription_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/subscription","commits_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/commits{/sha}","git_commits_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/git/commits{/sha}","comments_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/comments{/number}","issue_comment_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/issues/comments{/number}","contents_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/contents/{+path}","compare_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/merges","archive_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/downloads","issues_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/issues{/number}","pulls_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls{/number}","milestones_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/milestones{/number}","notifications_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/labels{/name}","releases_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/releases{/id}","deployments_url":"https://api.github.com/repos/CERNDocumentServer/cds-videos/deployments","created_at":"2014-05-05T13:36:39Z","updated_at":"2017-08-31T09:05:30Z","pushed_at":"2017-11-01T21:27:39Z","git_url":"git://github.com/CERNDocumentServer/cds-videos.git","ssh_url":"[email protected]:CERNDocumentServer/cds-videos.git","clone_url":"https://github.com/CERNDocumentServer/cds-videos.git","svn_url":"https://github.com/CERNDocumentServer/cds-videos","homepage":"http://cds.cern.ch","size":76512,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":84,"forks":22,"open_issues":84,"watchers":2,"default_branch":"cdslabs_qa"}},"_links":{"self":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/1273"},"html":{"href":"https://github.com/CERNDocumentServer/cds-videos/pull/1273"},"issue":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/issues/1273"},"comments":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/issues/1273/comments"},"review_comments":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/1273/comments"},"review_comment":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/pulls/1273/commits"},"statuses":{"href":"https://api.github.com/repos/CERNDocumentServer/cds-videos/statuses/b495d8dd08a478774576ceb6d4c56b91eeb05f82"}},"author_association":"OWNER"}} | {
"id": 19456880,
"name": "CERNDocumentServer/cds-videos",
"url": "https://api.github.com/repos/CERNDocumentServer/cds-videos"
} | {
"id": 2089455,
"login": "ntarocco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2089455?",
"url": "https://api.github.com/users/ntarocco"
} | {
"id": 7450686,
"login": "CERNDocumentServer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7450686?",
"url": "https://api.github.com/orgs/CERNDocumentServer"
} | 2017-11-01T22:00:55 | 6797309053 | {"actor":{"display_login":"ntarocco"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/comments/152098990","pull_request_review_id":77908773,"id":152098990,"diff_hunk":"@@ -27,6 +27,52 @@\n <md-button ng-click=\"$ctrl.removeCache(0, $event)\" ng-disabled=\"$ctrl.cacheInfo.disableDeleteCache\"><i class=\"material-icons\">delete</i></md-button>","path":"src/browser/cacheDisplay.html","position":1,"original_position":1,"commit_id":"8553606ce440b26e17b166fb9a7cb067d585a4d1","original_commit_id":"8553606ce440b26e17b166fb9a7cb067d585a4d1","user":{"login":"kevinsrose","id":13342312,"avatar_url":"https://avatars0.githubusercontent.com/u/13342312?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinsrose","html_url":"https://github.com/kevinsrose","followers_url":"https://api.github.com/users/kevinsrose/followers","following_url":"https://api.github.com/users/kevinsrose/following{/other_user}","gists_url":"https://api.github.com/users/kevinsrose/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsrose/subscriptions","organizations_url":"https://api.github.com/users/kevinsrose/orgs","repos_url":"https://api.github.com/users/kevinsrose/repos","events_url":"https://api.github.com/users/kevinsrose/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsrose/received_events","type":"User","site_admin":false},"body":"Ok yeah to answer my own question, it seems like moving this line below the md-card-content area you added fixes the issue brought up in my earlier comment.","created_at":"2017-11-20T20:13:25Z","updated_at":"2017-11-20T20:13:25Z","html_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator/pull/116#discussion_r152098990","pull_request_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/comments/152098990"},"html":{"href":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator/pull/116#discussion_r152098990"},"pull_request":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/116","id":153718379,"html_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator/pull/116","diff_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator/pull/116.diff","patch_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator/pull/116.patch","issue_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues/116","number":116,"state":"open","locked":false,"title":"Issue 84","user":{"login":"wthompson40","id":17521156,"avatar_url":"https://avatars3.githubusercontent.com/u/17521156?v=4","gravatar_id":"","url":"https://api.github.com/users/wthompson40","html_url":"https://github.com/wthompson40","followers_url":"https://api.github.com/users/wthompson40/followers","following_url":"https://api.github.com/users/wthompson40/following{/other_user}","gists_url":"https://api.github.com/users/wthompson40/gists{/gist_id}","starred_url":"https://api.github.com/users/wthompson40/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthompson40/subscriptions","organizations_url":"https://api.github.com/users/wthompson40/orgs","repos_url":"https://api.github.com/users/wthompson40/repos","events_url":"https://api.github.com/users/wthompson40/events{/privacy}","received_events_url":"https://api.github.com/users/wthompson40/received_events","type":"User","site_admin":false},"body":"Address breakdown visualization - dynamically changes with cache parameters being changed.","created_at":"2017-11-20T19:47:36Z","updated_at":"2017-11-20T20:13:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5654c3ac188eefb39d86620acb30e7773490dd02","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/116/commits","review_comments_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/116/comments","review_comment_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues/116/comments","statuses_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/statuses/8553606ce440b26e17b166fb9a7cb067d585a4d1","head":{"label":"Ctrl-Alt-Delicious:issue-84","ref":"issue-84","sha":"8553606ce440b26e17b166fb9a7cb067d585a4d1","user":{"login":"Ctrl-Alt-Delicious","id":31353635,"avatar_url":"https://avatars3.githubusercontent.com/u/31353635?v=4","gravatar_id":"","url":"https://api.github.com/users/Ctrl-Alt-Delicious","html_url":"https://github.com/Ctrl-Alt-Delicious","followers_url":"https://api.github.com/users/Ctrl-Alt-Delicious/followers","following_url":"https://api.github.com/users/Ctrl-Alt-Delicious/following{/other_user}","gists_url":"https://api.github.com/users/Ctrl-Alt-Delicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Ctrl-Alt-Delicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ctrl-Alt-Delicious/subscriptions","organizations_url":"https://api.github.com/users/Ctrl-Alt-Delicious/orgs","repos_url":"https://api.github.com/users/Ctrl-Alt-Delicious/repos","events_url":"https://api.github.com/users/Ctrl-Alt-Delicious/events{/privacy}","received_events_url":"https://api.github.com/users/Ctrl-Alt-Delicious/received_events","type":"Organization","site_admin":false},"repo":{"id":101423084,"name":"CacheSimulator","full_name":"Ctrl-Alt-Delicious/CacheSimulator","owner":{"login":"Ctrl-Alt-Delicious","id":31353635,"avatar_url":"https://avatars3.githubusercontent.com/u/31353635?v=4","gravatar_id":"","url":"https://api.github.com/users/Ctrl-Alt-Delicious","html_url":"https://github.com/Ctrl-Alt-Delicious","followers_url":"https://api.github.com/users/Ctrl-Alt-Delicious/followers","following_url":"https://api.github.com/users/Ctrl-Alt-Delicious/following{/other_user}","gists_url":"https://api.github.com/users/Ctrl-Alt-Delicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Ctrl-Alt-Delicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ctrl-Alt-Delicious/subscriptions","organizations_url":"https://api.github.com/users/Ctrl-Alt-Delicious/orgs","repos_url":"https://api.github.com/users/Ctrl-Alt-Delicious/repos","events_url":"https://api.github.com/users/Ctrl-Alt-Delicious/events{/privacy}","received_events_url":"https://api.github.com/users/Ctrl-Alt-Delicious/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator","description":"Cache Visual Simulator for CS 2200 at Georgia Tech","fork":false,"url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator","forks_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/forks","keys_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/teams","hooks_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/hooks","issue_events_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues/events{/number}","events_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/events","assignees_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/assignees{/user}","branches_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/branches{/branch}","tags_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/tags","blobs_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/statuses/{sha}","languages_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/languages","stargazers_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/stargazers","contributors_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/contributors","subscribers_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/subscribers","subscription_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/subscription","commits_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/contents/{+path}","compare_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/merges","archive_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/downloads","issues_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues{/number}","pulls_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls{/number}","milestones_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/milestones{/number}","notifications_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/labels{/name}","releases_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/releases{/id}","deployments_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/deployments","created_at":"2017-08-25T16:39:24Z","updated_at":"2017-11-12T21:01:37Z","pushed_at":"2017-11-20T20:06:53Z","git_url":"git://github.com/Ctrl-Alt-Delicious/CacheSimulator.git","ssh_url":"[email protected]:Ctrl-Alt-Delicious/CacheSimulator.git","clone_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator.git","svn_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator","homepage":null,"size":46056,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"Ctrl-Alt-Delicious:master","ref":"master","sha":"8d13e87c2f7a4b28323bfc553dc12069f95ea555","user":{"login":"Ctrl-Alt-Delicious","id":31353635,"avatar_url":"https://avatars3.githubusercontent.com/u/31353635?v=4","gravatar_id":"","url":"https://api.github.com/users/Ctrl-Alt-Delicious","html_url":"https://github.com/Ctrl-Alt-Delicious","followers_url":"https://api.github.com/users/Ctrl-Alt-Delicious/followers","following_url":"https://api.github.com/users/Ctrl-Alt-Delicious/following{/other_user}","gists_url":"https://api.github.com/users/Ctrl-Alt-Delicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Ctrl-Alt-Delicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ctrl-Alt-Delicious/subscriptions","organizations_url":"https://api.github.com/users/Ctrl-Alt-Delicious/orgs","repos_url":"https://api.github.com/users/Ctrl-Alt-Delicious/repos","events_url":"https://api.github.com/users/Ctrl-Alt-Delicious/events{/privacy}","received_events_url":"https://api.github.com/users/Ctrl-Alt-Delicious/received_events","type":"Organization","site_admin":false},"repo":{"id":101423084,"name":"CacheSimulator","full_name":"Ctrl-Alt-Delicious/CacheSimulator","owner":{"login":"Ctrl-Alt-Delicious","id":31353635,"avatar_url":"https://avatars3.githubusercontent.com/u/31353635?v=4","gravatar_id":"","url":"https://api.github.com/users/Ctrl-Alt-Delicious","html_url":"https://github.com/Ctrl-Alt-Delicious","followers_url":"https://api.github.com/users/Ctrl-Alt-Delicious/followers","following_url":"https://api.github.com/users/Ctrl-Alt-Delicious/following{/other_user}","gists_url":"https://api.github.com/users/Ctrl-Alt-Delicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Ctrl-Alt-Delicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ctrl-Alt-Delicious/subscriptions","organizations_url":"https://api.github.com/users/Ctrl-Alt-Delicious/orgs","repos_url":"https://api.github.com/users/Ctrl-Alt-Delicious/repos","events_url":"https://api.github.com/users/Ctrl-Alt-Delicious/events{/privacy}","received_events_url":"https://api.github.com/users/Ctrl-Alt-Delicious/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator","description":"Cache Visual Simulator for CS 2200 at Georgia Tech","fork":false,"url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator","forks_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/forks","keys_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/teams","hooks_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/hooks","issue_events_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues/events{/number}","events_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/events","assignees_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/assignees{/user}","branches_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/branches{/branch}","tags_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/tags","blobs_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/statuses/{sha}","languages_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/languages","stargazers_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/stargazers","contributors_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/contributors","subscribers_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/subscribers","subscription_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/subscription","commits_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/contents/{+path}","compare_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/merges","archive_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/downloads","issues_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues{/number}","pulls_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls{/number}","milestones_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/milestones{/number}","notifications_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/labels{/name}","releases_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/releases{/id}","deployments_url":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/deployments","created_at":"2017-08-25T16:39:24Z","updated_at":"2017-11-12T21:01:37Z","pushed_at":"2017-11-20T20:06:53Z","git_url":"git://github.com/Ctrl-Alt-Delicious/CacheSimulator.git","ssh_url":"[email protected]:Ctrl-Alt-Delicious/CacheSimulator.git","clone_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator.git","svn_url":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator","homepage":null,"size":46056,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/116"},"html":{"href":"https://github.com/Ctrl-Alt-Delicious/CacheSimulator/pull/116"},"issue":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues/116"},"comments":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator/statuses/8553606ce440b26e17b166fb9a7cb067d585a4d1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 101423084,
"name": "Ctrl-Alt-Delicious/CacheSimulator",
"url": "https://api.github.com/repos/Ctrl-Alt-Delicious/CacheSimulator"
} | {
"id": 13342312,
"login": "kevinsrose",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13342312?",
"url": "https://api.github.com/users/kevinsrose"
} | {
"id": 31353635,
"login": "Ctrl-Alt-Delicious",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31353635?",
"url": "https://api.github.com/orgs/Ctrl-Alt-Delicious"
} | 2017-11-20T20:13:25 | 6880879434 | {"actor":{"display_login":"kevinsrose"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/152078266","pull_request_review_id":77884629,"id":152078266,"diff_hunk":"@@ -51,12 +52,12 @@\n gid_output.ExecuteInitialize()\n \n ## Creation of the Kratos model (build sub_model_parts or submeshes)\n-StructureModel = {ProjectParameters[\"problem_data\"][\"model_part_name\"].GetString(): main_model_part}\n-\n-## Get the list of the sub_model_parts in where the processes are to be applied\n+StructureModel = Model()\n+StructureModel.AddModelPart(main_model_part)\n+# Get the list of the sub_model_parts in where the processes are to be applied\n for i in range(ProjectParameters[\"solver_settings\"][\"processes_sub_model_part_list\"].size()):","path":"applications/StructuralMechanicsApplication/python_scripts/kratos_main_structural.py","position":20,"original_position":20,"commit_id":"eef31a39c79e740b0db33474cd821021bb8309a9","original_commit_id":"eef31a39c79e740b0db33474cd821021bb8309a9","user":{"login":"RiccardoRossi","id":8059665,"avatar_url":"https://avatars1.githubusercontent.com/u/8059665?v=4","gravatar_id":"","url":"https://api.github.com/users/RiccardoRossi","html_url":"https://github.com/RiccardoRossi","followers_url":"https://api.github.com/users/RiccardoRossi/followers","following_url":"https://api.github.com/users/RiccardoRossi/following{/other_user}","gists_url":"https://api.github.com/users/RiccardoRossi/gists{/gist_id}","starred_url":"https://api.github.com/users/RiccardoRossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RiccardoRossi/subscriptions","organizations_url":"https://api.github.com/users/RiccardoRossi/orgs","repos_url":"https://api.github.com/users/RiccardoRossi/repos","events_url":"https://api.github.com/users/RiccardoRossi/events{/privacy}","received_events_url":"https://api.github.com/users/RiccardoRossi/received_events","type":"User","site_admin":false},"body":"you don't need to do this. Once you add the StructureModel, it adds alone all of its submodelparts. That's actually the point of it... (one of)","created_at":"2017-11-20T18:50:45Z","updated_at":"2017-11-20T18:51:30Z","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/1053#discussion_r152078266","pull_request_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1053","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/152078266"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/1053#discussion_r152078266"},"pull_request":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1053"}}},"pull_request":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1053","id":153597764,"html_url":"https://github.com/KratosMultiphysics/Kratos/pull/1053","diff_url":"https://github.com/KratosMultiphysics/Kratos/pull/1053.diff","patch_url":"https://github.com/KratosMultiphysics/Kratos/pull/1053.patch","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1053","number":1053,"state":"open","locked":false,"title":"Updating with model the StructuralMechanics main script","user":{"login":"loumalouomega","id":19991680,"avatar_url":"https://avatars2.githubusercontent.com/u/19991680?v=4","gravatar_id":"","url":"https://api.github.com/users/loumalouomega","html_url":"https://github.com/loumalouomega","followers_url":"https://api.github.com/users/loumalouomega/followers","following_url":"https://api.github.com/users/loumalouomega/following{/other_user}","gists_url":"https://api.github.com/users/loumalouomega/gists{/gist_id}","starred_url":"https://api.github.com/users/loumalouomega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loumalouomega/subscriptions","organizations_url":"https://api.github.com/users/loumalouomega/orgs","repos_url":"https://api.github.com/users/loumalouomega/repos","events_url":"https://api.github.com/users/loumalouomega/events{/privacy}","received_events_url":"https://api.github.com/users/loumalouomega/received_events","type":"User","site_admin":false},"body":"Concerning #1045 ","created_at":"2017-11-20T10:51:45Z","updated_at":"2017-11-20T18:51:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fcc0a3b8f34b28036d006cfb2e3f37c50961343","assignee":{"login":"loumalouomega","id":19991680,"avatar_url":"https://avatars2.githubusercontent.com/u/19991680?v=4","gravatar_id":"","url":"https://api.github.com/users/loumalouomega","html_url":"https://github.com/loumalouomega","followers_url":"https://api.github.com/users/loumalouomega/followers","following_url":"https://api.github.com/users/loumalouomega/following{/other_user}","gists_url":"https://api.github.com/users/loumalouomega/gists{/gist_id}","starred_url":"https://api.github.com/users/loumalouomega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loumalouomega/subscriptions","organizations_url":"https://api.github.com/users/loumalouomega/orgs","repos_url":"https://api.github.com/users/loumalouomega/repos","events_url":"https://api.github.com/users/loumalouomega/events{/privacy}","received_events_url":"https://api.github.com/users/loumalouomega/received_events","type":"User","site_admin":false},"assignees":[{"login":"loumalouomega","id":19991680,"avatar_url":"https://avatars2.githubusercontent.com/u/19991680?v=4","gravatar_id":"","url":"https://api.github.com/users/loumalouomega","html_url":"https://github.com/loumalouomega","followers_url":"https://api.github.com/users/loumalouomega/followers","following_url":"https://api.github.com/users/loumalouomega/following{/other_user}","gists_url":"https://api.github.com/users/loumalouomega/gists{/gist_id}","starred_url":"https://api.github.com/users/loumalouomega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loumalouomega/subscriptions","organizations_url":"https://api.github.com/users/loumalouomega/orgs","repos_url":"https://api.github.com/users/loumalouomega/repos","events_url":"https://api.github.com/users/loumalouomega/events{/privacy}","received_events_url":"https://api.github.com/users/loumalouomega/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1053/commits","review_comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1053/comments","review_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1053/comments","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/eef31a39c79e740b0db33474cd821021bb8309a9","head":{"label":"KratosMultiphysics:feature-model-main-script","ref":"feature-model-main-script","sha":"eef31a39c79e740b0db33474cd821021bb8309a9","user":{"login":"KratosMultiphysics","id":24840449,"avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"name":"Kratos","full_name":"KratosMultiphysics/Kratos","owner":{"login":"KratosMultiphysics","id":24840449,"avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2017-11-20T10:06:00Z","pushed_at":"2017-11-20T18:35:24Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"[email protected]:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1388657,"stargazers_count":64,"watchers_count":64,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":72,"forks":17,"open_issues":72,"watchers":64,"default_branch":"master"}},"base":{"label":"KratosMultiphysics:master","ref":"master","sha":"62a1bb2eeb38a415eb88e45385a8e779227b53c9","user":{"login":"KratosMultiphysics","id":24840449,"avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"name":"Kratos","full_name":"KratosMultiphysics/Kratos","owner":{"login":"KratosMultiphysics","id":24840449,"avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2017-11-20T10:06:00Z","pushed_at":"2017-11-20T18:35:24Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"[email protected]:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1388657,"stargazers_count":64,"watchers_count":64,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":72,"forks":17,"open_issues":72,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1053"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/1053"},"issue":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1053"},"comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1053/comments"},"review_comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1053/comments"},"review_comment":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/1053/commits"},"statuses":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/eef31a39c79e740b0db33474cd821021bb8309a9"}},"author_association":"MEMBER"}} | {
"id": 81815495,
"name": "KratosMultiphysics/Kratos",
"url": "https://api.github.com/repos/KratosMultiphysics/Kratos"
} | {
"id": 8059665,
"login": "RiccardoRossi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8059665?",
"url": "https://api.github.com/users/RiccardoRossi"
} | {
"id": 24840449,
"login": "KratosMultiphysics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24840449?",
"url": "https://api.github.com/orgs/KratosMultiphysics"
} | 2017-11-20T18:50:45 | 6880503990 | {"actor":{"display_login":"RiccardoRossi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/comments/146737874","pull_request_review_id":71722977,"id":146737874,"diff_hunk":"@@ -0,0 +1,159 @@\n+#if UNITY_EDITOR\n+using System;\n+using System.Collections.Generic;\n+using System.IO;\n+using UnityEditor.Experimental.EditorVR.UI;\n+using UnityEngine;\n+using UnityEngine.InputNew;\n+\n+namespace UnityEditor.Experimental.EditorVR.Core\n+{\n+ [CreateAssetMenu(menuName = \"EditorVR/EXR Proxy Affordance Map\", fileName = \"NewProxyAffordanceMap.asset\")]\n+ public class ProxyAffordanceMap : ScriptableObject\n+ {\n+ // TODO REMOVE - 5.6 HACK that remedies items not appearing in the create menu\n+#if UNITY_EDITOR\n+ [MenuItem(\"Assets/Create/EditorVR/EditorVR Proxy Affordance Map\")]\n+ public static void Create()\n+ {\n+ var path = AssetDatabase.GetAssetPath(Selection.activeObject);\n+\n+ if (string.IsNullOrEmpty(path))\n+ path = \"Assets\";\n+\n+ if (!Directory.Exists(path))\n+ path = Path.GetDirectoryName(path);\n+\n+ var affordanceMap = ScriptableObject.CreateInstance<ProxyAffordanceMap>();\n+ path = AssetDatabase.GenerateUniqueAssetPath(path + \"/NewProxyAffordanceMap.asset\");\n+ AssetDatabase.CreateAsset(affordanceMap, path);\n+ }\n+#endif\n+\n+ public enum VisibilityControlType\n+ {\n+ colorProperty,\n+ alphaProperty,\n+ materialSwap\n+ }\n+\n+ [Serializable]\n+ public class AffordanceVisibilityDefinition\n+ {\n+ [SerializeField]\n+ VisibilityControlType m_VisibilityType;\n+\n+ [SerializeField] // colorProperty field\n+ string m_ColorProperty = \"_Color\"; // Consider custom inspector that only displays this if this visibility type is chosen\n+\n+ [SerializeField] // alphaProperty field\n+ string m_AlphaProperty = \"_Alpha\"; // Consider custom inspector that only displays this if this visibility type is chosen\n+\n+ [SerializeField]\n+ Color m_HiddenColor = new Color(1f, 1f, 1f, 0f);\n+\n+ [SerializeField]\n+ float m_HiddenAlpha;\n+\n+ [SerializeField]\n+ Material m_HiddenMaterial;\n+\n+ /// <summary>\n+ /// The renderer & cloned materials associated with this affordance\n+ /// Cloned materials associated with the renderer will have their properties animated by the ProxyUI\n+ /// Element 1: Original material\n+ /// Element 2: Original color, Color.a is used for alpha-only animation\n+ /// Element 3: Hidden color, Color.a is used for alpha-only animation\n+ /// Element 4: Animate FROM color (used in animated coroutines), color.a is used for alpha-only animation\n+ /// Element 5: Animate TO color (used in animated coroutines), color.a is used for alpha-only animation\n+ /// </summary>\n+ public List<Tuple<Material, Color, Color, Color, Color>> materialsAndAssociatedColors { get; set; }\n+\n+ /// <summary>\n+ /// The hidden color of the material\n+ /// </summary>\n+ public Color hiddenColor { get { return m_HiddenColor; } set { m_HiddenColor = value; } }\n+\n+ /// <summary>\n+ /// The hidden alpha value of the material\n+ /// </summary>\n+ public float hiddenAlpha { get { return m_HiddenAlpha; } set { m_HiddenAlpha = value; } }\n+\n+ /// <summary>\n+ /// The material to with which to swap instead of animating visibility (material blending is not supported)\n+ /// </summary>\n+ public Material hiddenMaterial { get { return m_HiddenMaterial; } set { m_HiddenMaterial = value; } }\n+\n+ public Coroutine affordanceVisibilityCoroutine;\n+ public VisibilityControlType visibilityType { get { return m_VisibilityType; } set { m_VisibilityType = value; } }\n+ public string colorProperty { get { return m_ColorProperty; } set { m_ColorProperty = value; } }\n+ public string alphaProperty { get { return m_AlphaProperty; } set { m_AlphaProperty = value; } }\n+ }\n+\n+ [Serializable]\n+ public class AffordanceAnimationDefinition\n+ {\n+ [FlagsProperty]\n+ [SerializeField]\n+ AxisFlags m_TranslateAxes;\n+\n+ [FlagsProperty]\n+ [SerializeField]\n+ AxisFlags m_RotateAxes;\n+\n+ [SerializeField]\n+ float m_Min;\n+\n+ [SerializeField]\n+ float m_Max = 5f;\n+\n+ [SerializeField]\n+ bool m_ReverseForRightHand;\n+\n+ public AxisFlags translateAxes { get { return m_TranslateAxes; } set { m_TranslateAxes = value; } }\n+ public AxisFlags rotateAxes { get { return m_RotateAxes; } set { m_RotateAxes = value; } }\n+ public float min { get { return m_Min; } set { m_Min = value; } }\n+ public float max { get { return m_Max; } set { m_Max = value; } }\n+ public bool reverseForRightHand { get { return m_ReverseForRightHand; } set { m_ReverseForRightHand = value; } }\n+ }\n+\n+ [Serializable]\n+ public class AffordanceDefinition\n+ {\n+ [SerializeField]\n+ VRInputDevice.VRControl m_Control;\n+\n+ [SerializeField]\n+ AffordanceAnimationDefinition m_AnimationDefinition;","path":"Scripts/Helpers/ProxyAffordanceMap.cs","position":127,"original_position":127,"commit_id":"98655efd70b5ab108ff23dd64b41b3f7390f972b","original_commit_id":"98655efd70b5ab108ff23dd64b41b3f7390f972b","user":{"login":"dunity","id":24598883,"avatar_url":"https://avatars1.githubusercontent.com/u/24598883?v=4","gravatar_id":"","url":"https://api.github.com/users/dunity","html_url":"https://github.com/dunity","followers_url":"https://api.github.com/users/dunity/followers","following_url":"https://api.github.com/users/dunity/following{/other_user}","gists_url":"https://api.github.com/users/dunity/gists{/gist_id}","starred_url":"https://api.github.com/users/dunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunity/subscriptions","organizations_url":"https://api.github.com/users/dunity/orgs","repos_url":"https://api.github.com/users/dunity/repos","events_url":"https://api.github.com/users/dunity/events{/privacy}","received_events_url":"https://api.github.com/users/dunity/received_events","type":"User","site_admin":false},"body":"There are fallbacks for an entire definition to the default definition. I feel that extending the system to support fallbacks of individual definition properties might be best suited for another task/PR.","created_at":"2017-10-25T01:52:17Z","updated_at":"2017-10-25T01:52:17Z","html_url":"https://github.com/Unity-Technologies/EditorVR/pull/356#discussion_r146737874","pull_request_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/356","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/comments/146737874"},"html":{"href":"https://github.com/Unity-Technologies/EditorVR/pull/356#discussion_r146737874"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/356"}},"in_reply_to_id":145839656},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/356","id":147474603,"html_url":"https://github.com/Unity-Technologies/EditorVR/pull/356","diff_url":"https://github.com/Unity-Technologies/EditorVR/pull/356.diff","patch_url":"https://github.com/Unity-Technologies/EditorVR/pull/356.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues/356","number":356,"state":"open","locked":false,"title":"Automatic proxy (semi)transparency support + ProxyAnimator support","user":{"login":"dunity","id":24598883,"avatar_url":"https://avatars1.githubusercontent.com/u/24598883?v=4","gravatar_id":"","url":"https://api.github.com/users/dunity","html_url":"https://github.com/dunity","followers_url":"https://api.github.com/users/dunity/followers","following_url":"https://api.github.com/users/dunity/following{/other_user}","gists_url":"https://api.github.com/users/dunity/gists{/gist_id}","starred_url":"https://api.github.com/users/dunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunity/subscriptions","organizations_url":"https://api.github.com/users/dunity/orgs","repos_url":"https://api.github.com/users/dunity/repos","events_url":"https://api.github.com/users/dunity/events{/privacy}","received_events_url":"https://api.github.com/users/dunity/received_events","type":"User","site_admin":false},"body":"### Purpose of this PR\r\nAdd automatic animated transparency support for proxies. Static, non-interactive elements remain semi-transparent. Affordances, proxy elements that can be interacted with (buttons, analog, etc) become opaque when feedback is being displayed on them (for a brief period of time), or when the user shakes their hands back and forth (which makes the body meshes opaque as well for a brief time).\r\n\r\n_This PR is based off of the original controller-transparency PR, and also includes ProxyAnimator arch refactors to accommodate the new ProxyAffordanceMap structure._ https://github.com/Unity-Technologies/EditorVR/pull/355\r\n\r\n### Testing status\r\n\r\nTested in Various scenes and image effect environments, appeared as expected.\r\n\r\n### Technical risk\r\n\r\nLow - The changes herein don't affect many areas outside the TwoHandedProxyBase. Care has been given, to avoid altering any of the ways in which the feedback system has been implemented in THPB. The shake-to-reveal functionality also allows for feedback to be added/removed as it did previously; in my tests there were no conflicts with the current way in which this functions alongside feedback in THPB.\r\n\r\n### Comments to reviewers\r\n\r\nI separated, into another branch, the merging of the proxy animator data into ProxyAffordanceMaps (via a new AnimationDefinition data class). That code now resides in improvements/dylanu/controller-transparency-animator-support; to be PR'd after this. I broke out the code into that branch, In order to get this merged, and prevent more constant code-drift from this AffordanceMap architecture, due to additional time needed to finish the animator merge and support in AffordanceMaps.\r\nDue to the nature of supporting (semi)transparency in the the shaders/materials for proxies, there is the usual \"depth popping\" visual artifact on some controller elements at certain angles. An additional z-only prepass can be added to negate the effect if too distracting, coming at the expense of additional draws. I plan on mocking this up for perf testing, and design approval later.","created_at":"2017-10-19T06:17:20Z","updated_at":"2017-10-25T01:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"319641513316a33980751e0492c3011832e9ca75","assignee":{"login":"dunity","id":24598883,"avatar_url":"https://avatars1.githubusercontent.com/u/24598883?v=4","gravatar_id":"","url":"https://api.github.com/users/dunity","html_url":"https://github.com/dunity","followers_url":"https://api.github.com/users/dunity/followers","following_url":"https://api.github.com/users/dunity/following{/other_user}","gists_url":"https://api.github.com/users/dunity/gists{/gist_id}","starred_url":"https://api.github.com/users/dunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunity/subscriptions","organizations_url":"https://api.github.com/users/dunity/orgs","repos_url":"https://api.github.com/users/dunity/repos","events_url":"https://api.github.com/users/dunity/events{/privacy}","received_events_url":"https://api.github.com/users/dunity/received_events","type":"User","site_admin":false},"assignees":[{"login":"dunity","id":24598883,"avatar_url":"https://avatars1.githubusercontent.com/u/24598883?v=4","gravatar_id":"","url":"https://api.github.com/users/dunity","html_url":"https://github.com/dunity","followers_url":"https://api.github.com/users/dunity/followers","following_url":"https://api.github.com/users/dunity/following{/other_user}","gists_url":"https://api.github.com/users/dunity/gists{/gist_id}","starred_url":"https://api.github.com/users/dunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunity/subscriptions","organizations_url":"https://api.github.com/users/dunity/orgs","repos_url":"https://api.github.com/users/dunity/repos","events_url":"https://api.github.com/users/dunity/events{/privacy}","received_events_url":"https://api.github.com/users/dunity/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jono-unity","id":22459418,"avatar_url":"https://avatars3.githubusercontent.com/u/22459418?v=4","gravatar_id":"","url":"https://api.github.com/users/jono-unity","html_url":"https://github.com/jono-unity","followers_url":"https://api.github.com/users/jono-unity/followers","following_url":"https://api.github.com/users/jono-unity/following{/other_user}","gists_url":"https://api.github.com/users/jono-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/jono-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jono-unity/subscriptions","organizations_url":"https://api.github.com/users/jono-unity/orgs","repos_url":"https://api.github.com/users/jono-unity/repos","events_url":"https://api.github.com/users/jono-unity/events{/privacy}","received_events_url":"https://api.github.com/users/jono-unity/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/356/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/356/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues/356/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/statuses/98655efd70b5ab108ff23dd64b41b3f7390f972b","head":{"label":"Unity-Technologies:improvements/dylanu/controller-transparency-animator-support","ref":"improvements/dylanu/controller-transparency-animator-support","sha":"98655efd70b5ab108ff23dd64b41b3f7390f972b","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":76560415,"name":"EditorVR","full_name":"Unity-Technologies/EditorVR","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/EditorVR","description":"Author VR in VR - See blog post for supporting downloads:","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/EditorVR","forks_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/deployments","created_at":"2016-12-15T13:05:40Z","updated_at":"2017-10-21T11:49:32Z","pushed_at":"2017-10-24T22:19:45Z","git_url":"git://github.com/Unity-Technologies/EditorVR.git","ssh_url":"[email protected]:Unity-Technologies/EditorVR.git","clone_url":"https://github.com/Unity-Technologies/EditorVR.git","svn_url":"https://github.com/Unity-Technologies/EditorVR","homepage":"https://blogs.unity3d.com/2016/12/15/editorvr-experimental-build-available-today/","size":9453,"stargazers_count":410,"watchers_count":410,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":83,"forks":78,"open_issues":83,"watchers":410,"default_branch":"development"}},"base":{"label":"Unity-Technologies:improvements/schoen/feedback","ref":"improvements/schoen/feedback","sha":"0a7d690c223a88f66488b9d1d8323bad920876d6","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":76560415,"name":"EditorVR","full_name":"Unity-Technologies/EditorVR","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/EditorVR","description":"Author VR in VR - See blog post for supporting downloads:","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/EditorVR","forks_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/EditorVR/deployments","created_at":"2016-12-15T13:05:40Z","updated_at":"2017-10-21T11:49:32Z","pushed_at":"2017-10-24T22:19:45Z","git_url":"git://github.com/Unity-Technologies/EditorVR.git","ssh_url":"[email protected]:Unity-Technologies/EditorVR.git","clone_url":"https://github.com/Unity-Technologies/EditorVR.git","svn_url":"https://github.com/Unity-Technologies/EditorVR","homepage":"https://blogs.unity3d.com/2016/12/15/editorvr-experimental-build-available-today/","size":9453,"stargazers_count":410,"watchers_count":410,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":83,"forks":78,"open_issues":83,"watchers":410,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/356"},"html":{"href":"https://github.com/Unity-Technologies/EditorVR/pull/356"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues/356"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/EditorVR/statuses/98655efd70b5ab108ff23dd64b41b3f7390f972b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 76560415,
"name": "Unity-Technologies/EditorVR",
"url": "https://api.github.com/repos/Unity-Technologies/EditorVR"
} | {
"id": 24598883,
"login": "dunity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24598883?",
"url": "https://api.github.com/users/dunity"
} | {
"id": 426196,
"login": "Unity-Technologies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/426196?",
"url": "https://api.github.com/orgs/Unity-Technologies"
} | 2017-10-25T01:52:17 | 6761454647 | {"actor":{"display_login":"dunity"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/comments/126925432","pull_request_review_id":49456492,"id":126925432,"diff_hunk":"@@ -36,7 +36,10 @@ SysTime influxSysTime(string time) @safe\n import std.stdio: stderr;\n import std.algorithm: countUntil;\n \n- debug stderr.writeln(\"Could not convert \", time, \" due to a Phobos bug, reducing precision\");\n+ debug {\n+ (() @trusted => stderr)()\n+ .writeln(\"Could not convert \", time, \" due to a Phobos bug, reducing precision\");\n+ }","path":"source/influxdb/api.d","position":8,"original_position":8,"commit_id":"7f79ffe0e04a8a7252b69ae587f64dd45349af6b","original_commit_id":"7f79ffe0e04a8a7252b69ae587f64dd45349af6b","user":{"login":"John-Colvin","id":1867189,"avatar_url":"https://avatars3.githubusercontent.com/u/1867189?v=3","gravatar_id":"","url":"https://api.github.com/users/John-Colvin","html_url":"https://github.com/John-Colvin","followers_url":"https://api.github.com/users/John-Colvin/followers","following_url":"https://api.github.com/users/John-Colvin/following{/other_user}","gists_url":"https://api.github.com/users/John-Colvin/gists{/gist_id}","starred_url":"https://api.github.com/users/John-Colvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/John-Colvin/subscriptions","organizations_url":"https://api.github.com/users/John-Colvin/orgs","repos_url":"https://api.github.com/users/John-Colvin/repos","events_url":"https://api.github.com/users/John-Colvin/events{/privacy}","received_events_url":"https://api.github.com/users/John-Colvin/received_events","type":"User","site_admin":false},"body":"Sorry about the `{}`, apparently `debug (() => 1)().writeln;` isn't valid syntax.","created_at":"2017-07-12T11:05:32Z","updated_at":"2017-07-12T11:05:32Z","html_url":"https://github.com/kaleidicassociates/influx-d/pull/20#discussion_r126925432","pull_request_url":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/comments/126925432"},"html":{"href":"https://github.com/kaleidicassociates/influx-d/pull/20#discussion_r126925432"},"pull_request":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/20","id":130111502,"html_url":"https://github.com/kaleidicassociates/influx-d/pull/20","diff_url":"https://github.com/kaleidicassociates/influx-d/pull/20.diff","patch_url":"https://github.com/kaleidicassociates/influx-d/pull/20.patch","issue_url":"https://api.github.com/repos/kaleidicassociates/influx-d/issues/20","number":20,"state":"open","locked":false,"title":"trusted stderr","user":{"login":"John-Colvin","id":1867189,"avatar_url":"https://avatars3.githubusercontent.com/u/1867189?v=3","gravatar_id":"","url":"https://api.github.com/users/John-Colvin","html_url":"https://github.com/John-Colvin","followers_url":"https://api.github.com/users/John-Colvin/followers","following_url":"https://api.github.com/users/John-Colvin/following{/other_user}","gists_url":"https://api.github.com/users/John-Colvin/gists{/gist_id}","starred_url":"https://api.github.com/users/John-Colvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/John-Colvin/subscriptions","organizations_url":"https://api.github.com/users/John-Colvin/orgs","repos_url":"https://api.github.com/users/John-Colvin/repos","events_url":"https://api.github.com/users/John-Colvin/events{/privacy}","received_events_url":"https://api.github.com/users/John-Colvin/received_events","type":"User","site_admin":false},"body":"it would be great if the `std{in,out,err}` properties were `@trusted`, but they aren't.","created_at":"2017-07-12T11:03:49Z","updated_at":"2017-07-12T11:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c49fbbe7eadf5fc9251f941f88e9e6add397a00","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/20/commits","review_comments_url":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/20/comments","review_comment_url":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaleidicassociates/influx-d/issues/20/comments","statuses_url":"https://api.github.com/repos/kaleidicassociates/influx-d/statuses/7f79ffe0e04a8a7252b69ae587f64dd45349af6b","head":{"label":"John-Colvin:patch-1","ref":"patch-1","sha":"7f79ffe0e04a8a7252b69ae587f64dd45349af6b","user":{"login":"John-Colvin","id":1867189,"avatar_url":"https://avatars3.githubusercontent.com/u/1867189?v=3","gravatar_id":"","url":"https://api.github.com/users/John-Colvin","html_url":"https://github.com/John-Colvin","followers_url":"https://api.github.com/users/John-Colvin/followers","following_url":"https://api.github.com/users/John-Colvin/following{/other_user}","gists_url":"https://api.github.com/users/John-Colvin/gists{/gist_id}","starred_url":"https://api.github.com/users/John-Colvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/John-Colvin/subscriptions","organizations_url":"https://api.github.com/users/John-Colvin/orgs","repos_url":"https://api.github.com/users/John-Colvin/repos","events_url":"https://api.github.com/users/John-Colvin/events{/privacy}","received_events_url":"https://api.github.com/users/John-Colvin/received_events","type":"User","site_admin":false},"repo":{"id":96997216,"name":"influx-d","full_name":"John-Colvin/influx-d","owner":{"login":"John-Colvin","id":1867189,"avatar_url":"https://avatars3.githubusercontent.com/u/1867189?v=3","gravatar_id":"","url":"https://api.github.com/users/John-Colvin","html_url":"https://github.com/John-Colvin","followers_url":"https://api.github.com/users/John-Colvin/followers","following_url":"https://api.github.com/users/John-Colvin/following{/other_user}","gists_url":"https://api.github.com/users/John-Colvin/gists{/gist_id}","starred_url":"https://api.github.com/users/John-Colvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/John-Colvin/subscriptions","organizations_url":"https://api.github.com/users/John-Colvin/orgs","repos_url":"https://api.github.com/users/John-Colvin/repos","events_url":"https://api.github.com/users/John-Colvin/events{/privacy}","received_events_url":"https://api.github.com/users/John-Colvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/John-Colvin/influx-d","description":"D programming language wrapper for InfluxDB","fork":true,"url":"https://api.github.com/repos/John-Colvin/influx-d","forks_url":"https://api.github.com/repos/John-Colvin/influx-d/forks","keys_url":"https://api.github.com/repos/John-Colvin/influx-d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/John-Colvin/influx-d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/John-Colvin/influx-d/teams","hooks_url":"https://api.github.com/repos/John-Colvin/influx-d/hooks","issue_events_url":"https://api.github.com/repos/John-Colvin/influx-d/issues/events{/number}","events_url":"https://api.github.com/repos/John-Colvin/influx-d/events","assignees_url":"https://api.github.com/repos/John-Colvin/influx-d/assignees{/user}","branches_url":"https://api.github.com/repos/John-Colvin/influx-d/branches{/branch}","tags_url":"https://api.github.com/repos/John-Colvin/influx-d/tags","blobs_url":"https://api.github.com/repos/John-Colvin/influx-d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/John-Colvin/influx-d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/John-Colvin/influx-d/git/refs{/sha}","trees_url":"https://api.github.com/repos/John-Colvin/influx-d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/John-Colvin/influx-d/statuses/{sha}","languages_url":"https://api.github.com/repos/John-Colvin/influx-d/languages","stargazers_url":"https://api.github.com/repos/John-Colvin/influx-d/stargazers","contributors_url":"https://api.github.com/repos/John-Colvin/influx-d/contributors","subscribers_url":"https://api.github.com/repos/John-Colvin/influx-d/subscribers","subscription_url":"https://api.github.com/repos/John-Colvin/influx-d/subscription","commits_url":"https://api.github.com/repos/John-Colvin/influx-d/commits{/sha}","git_commits_url":"https://api.github.com/repos/John-Colvin/influx-d/git/commits{/sha}","comments_url":"https://api.github.com/repos/John-Colvin/influx-d/comments{/number}","issue_comment_url":"https://api.github.com/repos/John-Colvin/influx-d/issues/comments{/number}","contents_url":"https://api.github.com/repos/John-Colvin/influx-d/contents/{+path}","compare_url":"https://api.github.com/repos/John-Colvin/influx-d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/John-Colvin/influx-d/merges","archive_url":"https://api.github.com/repos/John-Colvin/influx-d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/John-Colvin/influx-d/downloads","issues_url":"https://api.github.com/repos/John-Colvin/influx-d/issues{/number}","pulls_url":"https://api.github.com/repos/John-Colvin/influx-d/pulls{/number}","milestones_url":"https://api.github.com/repos/John-Colvin/influx-d/milestones{/number}","notifications_url":"https://api.github.com/repos/John-Colvin/influx-d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/John-Colvin/influx-d/labels{/name}","releases_url":"https://api.github.com/repos/John-Colvin/influx-d/releases{/id}","deployments_url":"https://api.github.com/repos/John-Colvin/influx-d/deployments","created_at":"2017-07-12T10:49:46Z","updated_at":"2017-07-12T10:49:48Z","pushed_at":"2017-07-12T10:55:33Z","git_url":"git://github.com/John-Colvin/influx-d.git","ssh_url":"[email protected]:John-Colvin/influx-d.git","clone_url":"https://github.com/John-Colvin/influx-d.git","svn_url":"https://github.com/John-Colvin/influx-d","homepage":"http://influxdb.code.kaleidic.io","size":116,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kaleidicassociates:master","ref":"master","sha":"b3376ac418ab6ce9116f40870920b918ae8363ca","user":{"login":"kaleidicassociates","id":15332810,"avatar_url":"https://avatars3.githubusercontent.com/u/15332810?v=3","gravatar_id":"","url":"https://api.github.com/users/kaleidicassociates","html_url":"https://github.com/kaleidicassociates","followers_url":"https://api.github.com/users/kaleidicassociates/followers","following_url":"https://api.github.com/users/kaleidicassociates/following{/other_user}","gists_url":"https://api.github.com/users/kaleidicassociates/gists{/gist_id}","starred_url":"https://api.github.com/users/kaleidicassociates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaleidicassociates/subscriptions","organizations_url":"https://api.github.com/users/kaleidicassociates/orgs","repos_url":"https://api.github.com/users/kaleidicassociates/repos","events_url":"https://api.github.com/users/kaleidicassociates/events{/privacy}","received_events_url":"https://api.github.com/users/kaleidicassociates/received_events","type":"Organization","site_admin":false},"repo":{"id":85126883,"name":"influx-d","full_name":"kaleidicassociates/influx-d","owner":{"login":"kaleidicassociates","id":15332810,"avatar_url":"https://avatars3.githubusercontent.com/u/15332810?v=3","gravatar_id":"","url":"https://api.github.com/users/kaleidicassociates","html_url":"https://github.com/kaleidicassociates","followers_url":"https://api.github.com/users/kaleidicassociates/followers","following_url":"https://api.github.com/users/kaleidicassociates/following{/other_user}","gists_url":"https://api.github.com/users/kaleidicassociates/gists{/gist_id}","starred_url":"https://api.github.com/users/kaleidicassociates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaleidicassociates/subscriptions","organizations_url":"https://api.github.com/users/kaleidicassociates/orgs","repos_url":"https://api.github.com/users/kaleidicassociates/repos","events_url":"https://api.github.com/users/kaleidicassociates/events{/privacy}","received_events_url":"https://api.github.com/users/kaleidicassociates/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaleidicassociates/influx-d","description":"D programming language wrapper for InfluxDB","fork":false,"url":"https://api.github.com/repos/kaleidicassociates/influx-d","forks_url":"https://api.github.com/repos/kaleidicassociates/influx-d/forks","keys_url":"https://api.github.com/repos/kaleidicassociates/influx-d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaleidicassociates/influx-d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaleidicassociates/influx-d/teams","hooks_url":"https://api.github.com/repos/kaleidicassociates/influx-d/hooks","issue_events_url":"https://api.github.com/repos/kaleidicassociates/influx-d/issues/events{/number}","events_url":"https://api.github.com/repos/kaleidicassociates/influx-d/events","assignees_url":"https://api.github.com/repos/kaleidicassociates/influx-d/assignees{/user}","branches_url":"https://api.github.com/repos/kaleidicassociates/influx-d/branches{/branch}","tags_url":"https://api.github.com/repos/kaleidicassociates/influx-d/tags","blobs_url":"https://api.github.com/repos/kaleidicassociates/influx-d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaleidicassociates/influx-d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaleidicassociates/influx-d/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaleidicassociates/influx-d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaleidicassociates/influx-d/statuses/{sha}","languages_url":"https://api.github.com/repos/kaleidicassociates/influx-d/languages","stargazers_url":"https://api.github.com/repos/kaleidicassociates/influx-d/stargazers","contributors_url":"https://api.github.com/repos/kaleidicassociates/influx-d/contributors","subscribers_url":"https://api.github.com/repos/kaleidicassociates/influx-d/subscribers","subscription_url":"https://api.github.com/repos/kaleidicassociates/influx-d/subscription","commits_url":"https://api.github.com/repos/kaleidicassociates/influx-d/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaleidicassociates/influx-d/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaleidicassociates/influx-d/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaleidicassociates/influx-d/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaleidicassociates/influx-d/contents/{+path}","compare_url":"https://api.github.com/repos/kaleidicassociates/influx-d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaleidicassociates/influx-d/merges","archive_url":"https://api.github.com/repos/kaleidicassociates/influx-d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaleidicassociates/influx-d/downloads","issues_url":"https://api.github.com/repos/kaleidicassociates/influx-d/issues{/number}","pulls_url":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls{/number}","milestones_url":"https://api.github.com/repos/kaleidicassociates/influx-d/milestones{/number}","notifications_url":"https://api.github.com/repos/kaleidicassociates/influx-d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaleidicassociates/influx-d/labels{/name}","releases_url":"https://api.github.com/repos/kaleidicassociates/influx-d/releases{/id}","deployments_url":"https://api.github.com/repos/kaleidicassociates/influx-d/deployments","created_at":"2017-03-15T22:24:46Z","updated_at":"2017-05-26T19:26:04Z","pushed_at":"2017-07-12T11:03:50Z","git_url":"git://github.com/kaleidicassociates/influx-d.git","ssh_url":"[email protected]:kaleidicassociates/influx-d.git","clone_url":"https://github.com/kaleidicassociates/influx-d.git","svn_url":"https://github.com/kaleidicassociates/influx-d","homepage":"http://influxdb.code.kaleidic.io","size":116,"stargazers_count":6,"watchers_count":6,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/20"},"html":{"href":"https://github.com/kaleidicassociates/influx-d/pull/20"},"issue":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/issues/20"},"comments":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/kaleidicassociates/influx-d/statuses/7f79ffe0e04a8a7252b69ae587f64dd45349af6b"}}}} | {
"id": 85126883,
"name": "kaleidicassociates/influx-d",
"url": "https://api.github.com/repos/kaleidicassociates/influx-d"
} | {
"id": 1867189,
"login": "John-Colvin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1867189?",
"url": "https://api.github.com/users/John-Colvin"
} | {
"id": 15332810,
"login": "kaleidicassociates",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15332810?",
"url": "https://api.github.com/orgs/kaleidicassociates"
} | 2017-07-12T11:05:32 | 6240101707 | {"actor":{"display_login":"John-Colvin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/comments/151361636","pull_request_review_id":77055026,"id":151361636,"diff_hunk":"@@ -45,59 +35,49 @@ in it::\n \t\t}\n \t}\n \n-Then save the file to your **application/Controllers/** directory.\n+然后将这个文件保存在 **application/Controllers/** 目录下。\n \n-Now normally you would visit the your site using a URL similar to this::\n+通常你会使用如下的URL访问你的网站::\n \n \texample.com/index.php/tools/message/to\n \n-Instead, we are going to open Terminal in Mac/Linux or go to Run > \"cmd\"\n-in Windows and navigate to our CodeIgniter project's web root.\n+然而，我们现在要打开 Mac/Linux 下的 Terminal 或者在 Windows 下点击 运行并输入“cmd”之后进入我们 CodeIgniter 项目的 web 根目录，并执行以下命令：\n \n .. code-block:: bash\n \n \t$ cd /path/to/project/public\n \t$ php index.php tools message\n \n-If you did it right, you should see *Hello World!* printed.\n+如果你的操作正确，你将会看到这个输出 *Hello World!* \n \n .. code-block:: bash\n \n \t$ php index.php tools message \"John Smith\"\n \n-Here we are passing it a argument in the same way that URL parameters\n-work. \"John Smith\" is passed as a argument and output is::\n+我们可以在这里像传入URL参数一样，传入一个参数。“John Smith”这个参数作为输入得到的的输出如下::\n \n \tHello John Smith!\n \n-That's the basics!\n+这里是基础!\n ==================\n \n-That, in a nutshell, is all there is to know about controllers on the\n-command line. Remember that this is just a normal controller, so routing\n-and ``_remap()`` works fine.\n+简而言之，就是我们要知道命令行上的控制器。需要记住的是，这是一个正常的控制器，所以路由和 ``_remap()`` 都是正常运作的。\n \n-However, CodeIgniter provides additional tools to make creating CLI-accessible\n-scripts even more pleasant, include CLI-only routing, and a library that helps\n-you with CLI-only tools.\n+但是， CodeIgniter 提供了额外的工具，可以是更加轻松地创建 CLI 可访问的脚本：包括 CLI-only 路由和一个帮助你使用 CLI-only 工具的库。\n \n-CLI-Only Routing\n+CLI-Only 路由\n ----------------\n \n-In your **Routes.php** file you can create routes that are only accessible from\n-the CLI as easily as you would create any other route. Instead of using the ``get()``,\n-``post()``, or similar method, you would use the ``cli()`` method. Everything else\n-works exactly like a normal route definition::\n+在 **Routes.php** 文件中你可以像创建其他路由的方式轻松新建只能通过 CLI 方式访问的路由，这些路由并不是使用类似 ``get()`` 、\n+``post()`` ，或者其他类似的方法，在这里你需要使用 ``cli()`` 方法::","path":"source/general/cli.rst","position":111,"original_position":111,"commit_id":"24427e251000d5a63521883be3689ca5d5558a92","original_commit_id":"24427e251000d5a63521883be3689ca5d5558a92","user":{"login":"zhangxiaoshua","id":31472394,"avatar_url":"https://avatars3.githubusercontent.com/u/31472394?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangxiaoshua","html_url":"https://github.com/zhangxiaoshua","followers_url":"https://api.github.com/users/zhangxiaoshua/followers","following_url":"https://api.github.com/users/zhangxiaoshua/following{/other_user}","gists_url":"https://api.github.com/users/zhangxiaoshua/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxiaoshua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxiaoshua/subscriptions","organizations_url":"https://api.github.com/users/zhangxiaoshua/orgs","repos_url":"https://api.github.com/users/zhangxiaoshua/repos","events_url":"https://api.github.com/users/zhangxiaoshua/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxiaoshua/received_events","type":"User","site_admin":false},"body":"其他一切功能都像正常的路由定义一样。","created_at":"2017-11-16T09:36:48Z","updated_at":"2017-11-16T09:36:48Z","html_url":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide/pull/19#discussion_r151361636","pull_request_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/comments/151361636"},"html":{"href":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide/pull/19#discussion_r151361636"},"pull_request":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/19","id":151814879,"html_url":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide/pull/19","diff_url":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide/pull/19.diff","patch_url":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide/pull/19.patch","issue_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/issues/19","number":19,"state":"open","locked":false,"title":"/source/general/cli.rst 翻译完成","user":{"login":"summer7c","id":14966692,"avatar_url":"https://avatars0.githubusercontent.com/u/14966692?v=4","gravatar_id":"","url":"https://api.github.com/users/summer7c","html_url":"https://github.com/summer7c","followers_url":"https://api.github.com/users/summer7c/followers","following_url":"https://api.github.com/users/summer7c/following{/other_user}","gists_url":"https://api.github.com/users/summer7c/gists{/gist_id}","starred_url":"https://api.github.com/users/summer7c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summer7c/subscriptions","organizations_url":"https://api.github.com/users/summer7c/orgs","repos_url":"https://api.github.com/users/summer7c/repos","events_url":"https://api.github.com/users/summer7c/events{/privacy}","received_events_url":"https://api.github.com/users/summer7c/received_events","type":"User","site_admin":false},"body":"/source/general/cli.rst 翻译完成","created_at":"2017-11-10T02:49:57Z","updated_at":"2017-11-16T09:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95a9331a96d52b7cc5910685b945b1c19dd084b0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/19/commits","review_comments_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/19/comments","review_comment_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/issues/19/comments","statuses_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/statuses/24427e251000d5a63521883be3689ca5d5558a92","head":{"label":"summer7c:master","ref":"master","sha":"24427e251000d5a63521883be3689ca5d5558a92","user":{"login":"summer7c","id":14966692,"avatar_url":"https://avatars0.githubusercontent.com/u/14966692?v=4","gravatar_id":"","url":"https://api.github.com/users/summer7c","html_url":"https://github.com/summer7c","followers_url":"https://api.github.com/users/summer7c/followers","following_url":"https://api.github.com/users/summer7c/following{/other_user}","gists_url":"https://api.github.com/users/summer7c/gists{/gist_id}","starred_url":"https://api.github.com/users/summer7c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summer7c/subscriptions","organizations_url":"https://api.github.com/users/summer7c/orgs","repos_url":"https://api.github.com/users/summer7c/repos","events_url":"https://api.github.com/users/summer7c/events{/privacy}","received_events_url":"https://api.github.com/users/summer7c/received_events","type":"User","site_admin":false},"repo":{"id":110082494,"name":"codeigniter4-user-guide","full_name":"summer7c/codeigniter4-user-guide","owner":{"login":"summer7c","id":14966692,"avatar_url":"https://avatars0.githubusercontent.com/u/14966692?v=4","gravatar_id":"","url":"https://api.github.com/users/summer7c","html_url":"https://github.com/summer7c","followers_url":"https://api.github.com/users/summer7c/followers","following_url":"https://api.github.com/users/summer7c/following{/other_user}","gists_url":"https://api.github.com/users/summer7c/gists{/gist_id}","starred_url":"https://api.github.com/users/summer7c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summer7c/subscriptions","organizations_url":"https://api.github.com/users/summer7c/orgs","repos_url":"https://api.github.com/users/summer7c/repos","events_url":"https://api.github.com/users/summer7c/events{/privacy}","received_events_url":"https://api.github.com/users/summer7c/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/summer7c/codeigniter4-user-guide","description":"CodeIgniter 4 Chinese User Guide - CodeIgniter 4 简体中文手册","fork":true,"url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide","forks_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/forks","keys_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/teams","hooks_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/hooks","issue_events_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/issues/events{/number}","events_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/events","assignees_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/assignees{/user}","branches_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/branches{/branch}","tags_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/tags","blobs_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/languages","stargazers_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/stargazers","contributors_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/contributors","subscribers_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/subscribers","subscription_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/subscription","commits_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/contents/{+path}","compare_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/merges","archive_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/downloads","issues_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/issues{/number}","pulls_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/labels{/name}","releases_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/releases{/id}","deployments_url":"https://api.github.com/repos/summer7c/codeigniter4-user-guide/deployments","created_at":"2017-11-09T07:32:39Z","updated_at":"2017-11-09T07:32:41Z","pushed_at":"2017-11-10T02:48:25Z","git_url":"git://github.com/summer7c/codeigniter4-user-guide.git","ssh_url":"[email protected]:summer7c/codeigniter4-user-guide.git","clone_url":"https://github.com/summer7c/codeigniter4-user-guide.git","svn_url":"https://github.com/summer7c/codeigniter4-user-guide","homepage":"https://codeigniter-chinese.github.io/codeigniter4-user-guide/","size":32580,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CodeIgniter-Chinese:master","ref":"master","sha":"b212989fc4dab0db88b3b4d1f8cb4f7daf527444","user":{"login":"CodeIgniter-Chinese","id":1214715,"avatar_url":"https://avatars0.githubusercontent.com/u/1214715?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeIgniter-Chinese","html_url":"https://github.com/CodeIgniter-Chinese","followers_url":"https://api.github.com/users/CodeIgniter-Chinese/followers","following_url":"https://api.github.com/users/CodeIgniter-Chinese/following{/other_user}","gists_url":"https://api.github.com/users/CodeIgniter-Chinese/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeIgniter-Chinese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeIgniter-Chinese/subscriptions","organizations_url":"https://api.github.com/users/CodeIgniter-Chinese/orgs","repos_url":"https://api.github.com/users/CodeIgniter-Chinese/repos","events_url":"https://api.github.com/users/CodeIgniter-Chinese/events{/privacy}","received_events_url":"https://api.github.com/users/CodeIgniter-Chinese/received_events","type":"Organization","site_admin":false},"repo":{"id":101713997,"name":"codeigniter4-user-guide","full_name":"CodeIgniter-Chinese/codeigniter4-user-guide","owner":{"login":"CodeIgniter-Chinese","id":1214715,"avatar_url":"https://avatars0.githubusercontent.com/u/1214715?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeIgniter-Chinese","html_url":"https://github.com/CodeIgniter-Chinese","followers_url":"https://api.github.com/users/CodeIgniter-Chinese/followers","following_url":"https://api.github.com/users/CodeIgniter-Chinese/following{/other_user}","gists_url":"https://api.github.com/users/CodeIgniter-Chinese/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeIgniter-Chinese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeIgniter-Chinese/subscriptions","organizations_url":"https://api.github.com/users/CodeIgniter-Chinese/orgs","repos_url":"https://api.github.com/users/CodeIgniter-Chinese/repos","events_url":"https://api.github.com/users/CodeIgniter-Chinese/events{/privacy}","received_events_url":"https://api.github.com/users/CodeIgniter-Chinese/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide","description":"CodeIgniter 4 Chinese User Guide - CodeIgniter 4 简体中文手册","fork":false,"url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide","forks_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/forks","keys_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/teams","hooks_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/hooks","issue_events_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/issues/events{/number}","events_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/events","assignees_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/assignees{/user}","branches_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/branches{/branch}","tags_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/tags","blobs_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/languages","stargazers_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/stargazers","contributors_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/contributors","subscribers_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/subscribers","subscription_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/subscription","commits_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/contents/{+path}","compare_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/merges","archive_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/downloads","issues_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/issues{/number}","pulls_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/labels{/name}","releases_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/releases{/id}","deployments_url":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/deployments","created_at":"2017-08-29T03:17:40Z","updated_at":"2017-11-15T10:48:17Z","pushed_at":"2017-11-10T02:49:58Z","git_url":"git://github.com/CodeIgniter-Chinese/codeigniter4-user-guide.git","ssh_url":"[email protected]:CodeIgniter-Chinese/codeigniter4-user-guide.git","clone_url":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide.git","svn_url":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide","homepage":"https://codeigniter-chinese.github.io/codeigniter4-user-guide/","size":32570,"stargazers_count":11,"watchers_count":11,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/19"},"html":{"href":"https://github.com/CodeIgniter-Chinese/codeigniter4-user-guide/pull/19"},"issue":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/issues/19"},"comments":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide/statuses/24427e251000d5a63521883be3689ca5d5558a92"}},"author_association":"CONTRIBUTOR"}} | {
"id": 101713997,
"name": "CodeIgniter-Chinese/codeigniter4-user-guide",
"url": "https://api.github.com/repos/CodeIgniter-Chinese/codeigniter4-user-guide"
} | {
"id": 31472394,
"login": "zhangxiaoshua",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31472394?",
"url": "https://api.github.com/users/zhangxiaoshua"
} | {
"id": 1214715,
"login": "CodeIgniter-Chinese",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1214715?",
"url": "https://api.github.com/orgs/CodeIgniter-Chinese"
} | 2017-11-16T09:36:48 | 6863282438 | {"actor":{"display_login":"zhangxiaoshua"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/comments/113985823","pull_request_review_id":35422775,"id":113985823,"diff_hunk":"@@ -13,7 +13,8 @@ import '../stylesheets/panels/annotationSelector.styl';\n var AnnotationSelector = Panel.extend({\n events: _.extend(Panel.prototype.events, {\n 'click .h-toggle-annotation': 'toggleAnnotation',\n- 'click .h-delete-annotation': 'deleteAnnotation'\n+ 'click .h-delete-annotation': 'deleteAnnotation',\n+ 'click .h-download-annotation': 'downloadAnnotation'","path":"web_client/panels/AnnotationSelector.js","position":6,"original_position":6,"commit_id":"eafe8c0904fd42ec2a346b9dfef486b1b4b4b75f","original_commit_id":"eafe8c0904fd42ec2a346b9dfef486b1b4b4b75f","user":{"login":"jbeezley","id":31890,"avatar_url":"https://avatars1.githubusercontent.com/u/31890?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeezley","html_url":"https://github.com/jbeezley","followers_url":"https://api.github.com/users/jbeezley/followers","following_url":"https://api.github.com/users/jbeezley/following{/other_user}","gists_url":"https://api.github.com/users/jbeezley/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeezley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeezley/subscriptions","organizations_url":"https://api.github.com/users/jbeezley/orgs","repos_url":"https://api.github.com/users/jbeezley/repos","events_url":"https://api.github.com/users/jbeezley/events{/privacy}","received_events_url":"https://api.github.com/users/jbeezley/received_events","type":"User","site_admin":false},"body":"That's leftover code. I'll remove it.","created_at":"2017-04-28T17:56:01Z","updated_at":"2017-04-28T17:56:01Z","html_url":"https://github.com/DigitalSlideArchive/HistomicsTK/pull/324#discussion_r113985823","pull_request_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/324","_links":{"self":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/comments/113985823"},"html":{"href":"https://github.com/DigitalSlideArchive/HistomicsTK/pull/324#discussion_r113985823"},"pull_request":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/324","id":118151478,"html_url":"https://github.com/DigitalSlideArchive/HistomicsTK/pull/324","diff_url":"https://github.com/DigitalSlideArchive/HistomicsTK/pull/324.diff","patch_url":"https://github.com/DigitalSlideArchive/HistomicsTK/pull/324.patch","issue_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues/324","number":324,"state":"open","locked":false,"title":"Add a link to download annotations","user":{"login":"jbeezley","id":31890,"avatar_url":"https://avatars1.githubusercontent.com/u/31890?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeezley","html_url":"https://github.com/jbeezley","followers_url":"https://api.github.com/users/jbeezley/followers","following_url":"https://api.github.com/users/jbeezley/following{/other_user}","gists_url":"https://api.github.com/users/jbeezley/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeezley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeezley/subscriptions","organizations_url":"https://api.github.com/users/jbeezley/orgs","repos_url":"https://api.github.com/users/jbeezley/repos","events_url":"https://api.github.com/users/jbeezley/events{/privacy}","received_events_url":"https://api.github.com/users/jbeezley/received_events","type":"User","site_admin":false},"body":"This functional, however, there is a problem when attempting to download a large annotation. It takes the server several seconds to respond while the user has no indication that anything is happening. The only way I can think of to deal with this is:\r\n1. Add a `click` handler to the link which does the download and adds a spinner. This will not work if the user tries to download via \"Save As\" in the context menu.\r\n2. Add an endpoint `GET annotation/:id/download` that initiates a multipart download via paged responses.\r\nIf 2. is possible, I think it would be best because it doesn't override the browser's default behavior.\r\n\r\nCloses #323","created_at":"2017-04-28T13:24:48Z","updated_at":"2017-04-28T17:56:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac5660e4b316f426397d7530fbe04a5289a2769e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/324/commits","review_comments_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/324/comments","review_comment_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues/324/comments","statuses_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/statuses/eafe8c0904fd42ec2a346b9dfef486b1b4b4b75f","head":{"label":"DigitalSlideArchive:download-annotation","ref":"download-annotation","sha":"eafe8c0904fd42ec2a346b9dfef486b1b4b4b75f","user":{"login":"DigitalSlideArchive","id":13769637,"avatar_url":"https://avatars1.githubusercontent.com/u/13769637?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalSlideArchive","html_url":"https://github.com/DigitalSlideArchive","followers_url":"https://api.github.com/users/DigitalSlideArchive/followers","following_url":"https://api.github.com/users/DigitalSlideArchive/following{/other_user}","gists_url":"https://api.github.com/users/DigitalSlideArchive/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalSlideArchive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalSlideArchive/subscriptions","organizations_url":"https://api.github.com/users/DigitalSlideArchive/orgs","repos_url":"https://api.github.com/users/DigitalSlideArchive/repos","events_url":"https://api.github.com/users/DigitalSlideArchive/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalSlideArchive/received_events","type":"Organization","site_admin":false},"repo":{"id":44324447,"name":"HistomicsTK","full_name":"DigitalSlideArchive/HistomicsTK","owner":{"login":"DigitalSlideArchive","id":13769637,"avatar_url":"https://avatars1.githubusercontent.com/u/13769637?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalSlideArchive","html_url":"https://github.com/DigitalSlideArchive","followers_url":"https://api.github.com/users/DigitalSlideArchive/followers","following_url":"https://api.github.com/users/DigitalSlideArchive/following{/other_user}","gists_url":"https://api.github.com/users/DigitalSlideArchive/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalSlideArchive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalSlideArchive/subscriptions","organizations_url":"https://api.github.com/users/DigitalSlideArchive/orgs","repos_url":"https://api.github.com/users/DigitalSlideArchive/repos","events_url":"https://api.github.com/users/DigitalSlideArchive/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalSlideArchive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DigitalSlideArchive/HistomicsTK","description":"A Python and REST API for Histopathology Image Analysis","fork":false,"url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK","forks_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/forks","keys_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/teams","hooks_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/hooks","issue_events_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/events","assignees_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/tags","blobs_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/languages","stargazers_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/stargazers","contributors_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/contributors","subscribers_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/subscribers","subscription_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/subscription","commits_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/merges","archive_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/downloads","issues_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/labels{/name}","releases_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/releases{/id}","deployments_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/deployments","created_at":"2015-10-15T14:49:21Z","updated_at":"2017-04-27T08:56:30Z","pushed_at":"2017-04-28T17:13:54Z","git_url":"git://github.com/DigitalSlideArchive/HistomicsTK.git","ssh_url":"[email protected]:DigitalSlideArchive/HistomicsTK.git","clone_url":"https://github.com/DigitalSlideArchive/HistomicsTK.git","svn_url":"https://github.com/DigitalSlideArchive/HistomicsTK","homepage":"https://digitalslidearchive.github.io/HistomicsTK/","size":40361,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":50,"forks":9,"open_issues":50,"watchers":19,"default_branch":"master"}},"base":{"label":"DigitalSlideArchive:master","ref":"master","sha":"7c79c2158342cb5c3d3cc4614a807c7d7f1c19e8","user":{"login":"DigitalSlideArchive","id":13769637,"avatar_url":"https://avatars1.githubusercontent.com/u/13769637?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalSlideArchive","html_url":"https://github.com/DigitalSlideArchive","followers_url":"https://api.github.com/users/DigitalSlideArchive/followers","following_url":"https://api.github.com/users/DigitalSlideArchive/following{/other_user}","gists_url":"https://api.github.com/users/DigitalSlideArchive/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalSlideArchive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalSlideArchive/subscriptions","organizations_url":"https://api.github.com/users/DigitalSlideArchive/orgs","repos_url":"https://api.github.com/users/DigitalSlideArchive/repos","events_url":"https://api.github.com/users/DigitalSlideArchive/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalSlideArchive/received_events","type":"Organization","site_admin":false},"repo":{"id":44324447,"name":"HistomicsTK","full_name":"DigitalSlideArchive/HistomicsTK","owner":{"login":"DigitalSlideArchive","id":13769637,"avatar_url":"https://avatars1.githubusercontent.com/u/13769637?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalSlideArchive","html_url":"https://github.com/DigitalSlideArchive","followers_url":"https://api.github.com/users/DigitalSlideArchive/followers","following_url":"https://api.github.com/users/DigitalSlideArchive/following{/other_user}","gists_url":"https://api.github.com/users/DigitalSlideArchive/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalSlideArchive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalSlideArchive/subscriptions","organizations_url":"https://api.github.com/users/DigitalSlideArchive/orgs","repos_url":"https://api.github.com/users/DigitalSlideArchive/repos","events_url":"https://api.github.com/users/DigitalSlideArchive/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalSlideArchive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DigitalSlideArchive/HistomicsTK","description":"A Python and REST API for Histopathology Image Analysis","fork":false,"url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK","forks_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/forks","keys_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/teams","hooks_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/hooks","issue_events_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/events","assignees_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/tags","blobs_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/languages","stargazers_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/stargazers","contributors_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/contributors","subscribers_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/subscribers","subscription_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/subscription","commits_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/merges","archive_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/downloads","issues_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/labels{/name}","releases_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/releases{/id}","deployments_url":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/deployments","created_at":"2015-10-15T14:49:21Z","updated_at":"2017-04-27T08:56:30Z","pushed_at":"2017-04-28T17:13:54Z","git_url":"git://github.com/DigitalSlideArchive/HistomicsTK.git","ssh_url":"[email protected]:DigitalSlideArchive/HistomicsTK.git","clone_url":"https://github.com/DigitalSlideArchive/HistomicsTK.git","svn_url":"https://github.com/DigitalSlideArchive/HistomicsTK","homepage":"https://digitalslidearchive.github.io/HistomicsTK/","size":40361,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":50,"forks":9,"open_issues":50,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/324"},"html":{"href":"https://github.com/DigitalSlideArchive/HistomicsTK/pull/324"},"issue":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues/324"},"comments":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/DigitalSlideArchive/HistomicsTK/statuses/eafe8c0904fd42ec2a346b9dfef486b1b4b4b75f"}}}} | {
"id": 44324447,
"name": "DigitalSlideArchive/HistomicsTK",
"url": "https://api.github.com/repos/DigitalSlideArchive/HistomicsTK"
} | {
"id": 31890,
"login": "jbeezley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31890?",
"url": "https://api.github.com/users/jbeezley"
} | {
"id": 13769637,
"login": "DigitalSlideArchive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13769637?",
"url": "https://api.github.com/orgs/DigitalSlideArchive"
} | 2017-04-28T17:56:01 | 5778380692 | {"actor":{"display_login":"jbeezley"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/comments/107558596","pull_request_review_id":28539186,"id":107558596,"diff_hunk":"@@ -0,0 +1,6 @@\n+steps:\n+- name: 'gcr.io/${PROJECT_ID}/go1-builder:<BUILD_TAG>'","path":"runtime-builder/go-1.8.yaml","position":2,"original_position":2,"commit_id":"d7a2b1f539e5d64630d38191f3eb94888a533a48","original_commit_id":"d7a2b1f539e5d64630d38191f3eb94888a533a48","user":{"login":"cybrcodr","id":1845151,"avatar_url":"https://avatars3.githubusercontent.com/u/1845151?v=3","gravatar_id":"","url":"https://api.github.com/users/cybrcodr","html_url":"https://github.com/cybrcodr","followers_url":"https://api.github.com/users/cybrcodr/followers","following_url":"https://api.github.com/users/cybrcodr/following{/other_user}","gists_url":"https://api.github.com/users/cybrcodr/gists{/gist_id}","starred_url":"https://api.github.com/users/cybrcodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cybrcodr/subscriptions","organizations_url":"https://api.github.com/users/cybrcodr/orgs","repos_url":"https://api.github.com/users/cybrcodr/repos","events_url":"https://api.github.com/users/cybrcodr/events{/privacy}","received_events_url":"https://api.github.com/users/cybrcodr/received_events","type":"User","site_admin":false},"body":"s/${PROJECT_ID}/gcp-runtimes/\r\ns/<BUILD_TAG>/1.8/\r\n\r\nThis file will be used directly as the input for the publishing system to produce a published version of this. As Nick mentioned, the system will know how to replace 1.8 with the digest tag.","created_at":"2017-03-22T23:35:13Z","updated_at":"2017-03-22T23:35:13Z","html_url":"https://github.com/GoogleCloudPlatform/golang-docker/pull/74#discussion_r107558596","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/comments/107558596"},"html":{"href":"https://github.com/GoogleCloudPlatform/golang-docker/pull/74#discussion_r107558596"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/74","id":112117686,"html_url":"https://github.com/GoogleCloudPlatform/golang-docker/pull/74","diff_url":"https://github.com/GoogleCloudPlatform/golang-docker/pull/74.diff","patch_url":"https://github.com/GoogleCloudPlatform/golang-docker/pull/74.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/issues/74","number":74,"state":"open","locked":false,"title":"runtime-builder: add build steps files for deployment.","user":{"login":"shantuo","id":8689543,"avatar_url":"https://avatars0.githubusercontent.com/u/8689543?v=3","gravatar_id":"","url":"https://api.github.com/users/shantuo","html_url":"https://github.com/shantuo","followers_url":"https://api.github.com/users/shantuo/followers","following_url":"https://api.github.com/users/shantuo/following{/other_user}","gists_url":"https://api.github.com/users/shantuo/gists{/gist_id}","starred_url":"https://api.github.com/users/shantuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantuo/subscriptions","organizations_url":"https://api.github.com/users/shantuo/orgs","repos_url":"https://api.github.com/users/shantuo/repos","events_url":"https://api.github.com/users/shantuo/events{/privacy}","received_events_url":"https://api.github.com/users/shantuo/received_events","type":"User","site_admin":false},"body":"This includes the build step files to use with the new runtime builder deployment. I will include a README describing how to use them once we finalize the details.","created_at":"2017-03-22T21:44:04Z","updated_at":"2017-03-22T23:35:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cae10e2578d76f4f1b9dfd2efb460347891ebd28","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/74/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/74/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/issues/74/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/statuses/d7a2b1f539e5d64630d38191f3eb94888a533a48","head":{"label":"shantuo:buildsteps","ref":"buildsteps","sha":"d7a2b1f539e5d64630d38191f3eb94888a533a48","user":{"login":"shantuo","id":8689543,"avatar_url":"https://avatars0.githubusercontent.com/u/8689543?v=3","gravatar_id":"","url":"https://api.github.com/users/shantuo","html_url":"https://github.com/shantuo","followers_url":"https://api.github.com/users/shantuo/followers","following_url":"https://api.github.com/users/shantuo/following{/other_user}","gists_url":"https://api.github.com/users/shantuo/gists{/gist_id}","starred_url":"https://api.github.com/users/shantuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantuo/subscriptions","organizations_url":"https://api.github.com/users/shantuo/orgs","repos_url":"https://api.github.com/users/shantuo/repos","events_url":"https://api.github.com/users/shantuo/events{/privacy}","received_events_url":"https://api.github.com/users/shantuo/received_events","type":"User","site_admin":false},"repo":{"id":75883189,"name":"golang-docker","full_name":"shantuo/golang-docker","owner":{"login":"shantuo","id":8689543,"avatar_url":"https://avatars0.githubusercontent.com/u/8689543?v=3","gravatar_id":"","url":"https://api.github.com/users/shantuo","html_url":"https://github.com/shantuo","followers_url":"https://api.github.com/users/shantuo/followers","following_url":"https://api.github.com/users/shantuo/following{/other_user}","gists_url":"https://api.github.com/users/shantuo/gists{/gist_id}","starred_url":"https://api.github.com/users/shantuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantuo/subscriptions","organizations_url":"https://api.github.com/users/shantuo/orgs","repos_url":"https://api.github.com/users/shantuo/repos","events_url":"https://api.github.com/users/shantuo/events{/privacy}","received_events_url":"https://api.github.com/users/shantuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shantuo/golang-docker","description":"Docker images for Go on Google App Engine","fork":true,"url":"https://api.github.com/repos/shantuo/golang-docker","forks_url":"https://api.github.com/repos/shantuo/golang-docker/forks","keys_url":"https://api.github.com/repos/shantuo/golang-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shantuo/golang-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shantuo/golang-docker/teams","hooks_url":"https://api.github.com/repos/shantuo/golang-docker/hooks","issue_events_url":"https://api.github.com/repos/shantuo/golang-docker/issues/events{/number}","events_url":"https://api.github.com/repos/shantuo/golang-docker/events","assignees_url":"https://api.github.com/repos/shantuo/golang-docker/assignees{/user}","branches_url":"https://api.github.com/repos/shantuo/golang-docker/branches{/branch}","tags_url":"https://api.github.com/repos/shantuo/golang-docker/tags","blobs_url":"https://api.github.com/repos/shantuo/golang-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shantuo/golang-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shantuo/golang-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/shantuo/golang-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shantuo/golang-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/shantuo/golang-docker/languages","stargazers_url":"https://api.github.com/repos/shantuo/golang-docker/stargazers","contributors_url":"https://api.github.com/repos/shantuo/golang-docker/contributors","subscribers_url":"https://api.github.com/repos/shantuo/golang-docker/subscribers","subscription_url":"https://api.github.com/repos/shantuo/golang-docker/subscription","commits_url":"https://api.github.com/repos/shantuo/golang-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/shantuo/golang-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/shantuo/golang-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/shantuo/golang-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/shantuo/golang-docker/contents/{+path}","compare_url":"https://api.github.com/repos/shantuo/golang-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shantuo/golang-docker/merges","archive_url":"https://api.github.com/repos/shantuo/golang-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shantuo/golang-docker/downloads","issues_url":"https://api.github.com/repos/shantuo/golang-docker/issues{/number}","pulls_url":"https://api.github.com/repos/shantuo/golang-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/shantuo/golang-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/shantuo/golang-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shantuo/golang-docker/labels{/name}","releases_url":"https://api.github.com/repos/shantuo/golang-docker/releases{/id}","deployments_url":"https://api.github.com/repos/shantuo/golang-docker/deployments","created_at":"2016-12-07T23:07:52Z","updated_at":"2016-12-07T23:07:53Z","pushed_at":"2017-03-22T21:42:01Z","git_url":"git://github.com/shantuo/golang-docker.git","ssh_url":"[email protected]:shantuo/golang-docker.git","clone_url":"https://github.com/shantuo/golang-docker.git","svn_url":"https://github.com/shantuo/golang-docker","homepage":"","size":61,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"4cebc91c82df46b66608dbe88650fbbe1f976bd5","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20344872,"name":"golang-docker","full_name":"GoogleCloudPlatform/golang-docker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/golang-docker","description":"Docker images for Go on Google App Engine","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/deployments","created_at":"2014-05-30T22:59:34Z","updated_at":"2017-03-15T03:34:07Z","pushed_at":"2017-03-22T23:16:21Z","git_url":"git://github.com/GoogleCloudPlatform/golang-docker.git","ssh_url":"[email protected]:GoogleCloudPlatform/golang-docker.git","clone_url":"https://github.com/GoogleCloudPlatform/golang-docker.git","svn_url":"https://github.com/GoogleCloudPlatform/golang-docker","homepage":"","size":58,"stargazers_count":130,"watchers_count":130,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":6,"forks":44,"open_issues":6,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/74"},"html":{"href":"https://github.com/GoogleCloudPlatform/golang-docker/pull/74"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/issues/74"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/golang-docker/statuses/d7a2b1f539e5d64630d38191f3eb94888a533a48"}}}} | {
"id": 20344872,
"name": "GoogleCloudPlatform/golang-docker",
"url": "https://api.github.com/repos/GoogleCloudPlatform/golang-docker"
} | {
"id": 1845151,
"login": "cybrcodr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1845151?",
"url": "https://api.github.com/users/cybrcodr"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2017-03-22T23:35:13 | 5546099622 | {"actor":{"display_login":"cybrcodr"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/105653236","pull_request_review_id":26541856,"id":105653236,"diff_hunk":"@@ -364,19 +364,29 @@ public void MultipleSpans()\n mockConsumer.Setup(c => c.Receive(Match.Create(rootMatcher)));\n \n var childThreadsReleased = new ManualResetEventSlim(initialState: false);\n+ var startedChildSpans = 0;\n \n Func<string, string, Task> op = async (childName, grandchildName) =>\n {\n childThreadsReleased.Wait();\n \n using (tracer.StartSpan(childName))\n {\n+ Interlocked.Increment(ref startedChildSpans);\n+\n await Task.Yield();\n using (tracer.StartSpan(grandchildName))\n {\n await Task.Yield();\n }\n- await Task.Yield();\n+\n+ do\n+ {\n+ await Task.Yield();\n+ // Don't allow the span to close until both are started\n+ // to make sure we only get a single Receive call below\n+ // instead of two.\n+ } while (startedChildSpans < 2);","path":"apis/Google.Cloud.Diagnostics.Common/Google.Cloud.Diagnostics.Common.Tests/Trace/SimpleManagedTracerTest.cs","position":152,"original_position":27,"commit_id":"bc0e487a19347cf56b3bea8ade9b7febaff57e0d","original_commit_id":"bc0e487a19347cf56b3bea8ade9b7febaff57e0d","user":{"login":"evildour","id":4014815,"avatar_url":"https://avatars1.githubusercontent.com/u/4014815?v=3","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"body":"No, that's a good point. Fixed.","created_at":"2017-03-13T12:58:31Z","updated_at":"2017-03-13T12:58:32Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/855#discussion_r105653236","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/855","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/105653236"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/855#discussion_r105653236"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/855"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/855","id":109544161,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/855","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/855.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/855.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/855","number":855,"state":"open","locked":false,"title":"Support for async and overlapping traces","user":{"login":"evildour","id":4014815,"avatar_url":"https://avatars1.githubusercontent.com/u/4014815?v=3","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-07T18:42:18Z","updated_at":"2017-03-13T12:58:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cc095e3b3da4e52f5abb20384556e06b5f370fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/855/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/855/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/855/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/bc0e487a19347cf56b3bea8ade9b7febaff57e0d","head":{"label":"evildour:logical-call-context","ref":"logical-call-context","sha":"bc0e487a19347cf56b3bea8ade9b7febaff57e0d","user":{"login":"evildour","id":4014815,"avatar_url":"https://avatars1.githubusercontent.com/u/4014815?v=3","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"repo":{"id":62015644,"name":"google-cloud-dotnet","full_name":"evildour/google-cloud-dotnet","owner":{"login":"evildour","id":4014815,"avatar_url":"https://avatars1.githubusercontent.com/u/4014815?v=3","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evildour/google-cloud-dotnet","description":"Google Cloud Client Library for .NET","fork":true,"url":"https://api.github.com/repos/evildour/google-cloud-dotnet","forks_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/deployments","created_at":"2016-06-27T01:02:10Z","updated_at":"2016-10-24T18:27:48Z","pushed_at":"2017-03-13T12:48:45Z","git_url":"git://github.com/evildour/google-cloud-dotnet.git","ssh_url":"[email protected]:evildour/google-cloud-dotnet.git","clone_url":"https://github.com/evildour/google-cloud-dotnet.git","svn_url":"https://github.com/evildour/google-cloud-dotnet","homepage":null,"size":10787,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"fde388172537f91ce7d94e9d1bbb8c2a2497cd43","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":35877412,"name":"google-cloud-dotnet","full_name":"GoogleCloudPlatform/google-cloud-dotnet","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","description":"Google Cloud Client Library for .NET","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/deployments","created_at":"2015-05-19T11:14:02Z","updated_at":"2017-03-11T20:44:26Z","pushed_at":"2017-03-13T12:11:11Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","ssh_url":"[email protected]:GoogleCloudPlatform/google-cloud-dotnet.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","homepage":"https://googlecloudplatform.github.io/google-cloud-dotnet/","size":16829,"stargazers_count":90,"watchers_count":90,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":49,"forks":41,"open_issues":49,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/855"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/855"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/855"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/855/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/855/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/855/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/bc0e487a19347cf56b3bea8ade9b7febaff57e0d"}}}} | {
"id": 35877412,
"name": "GoogleCloudPlatform/google-cloud-dotnet",
"url": "https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet"
} | {
"id": 4014815,
"login": "evildour",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4014815?",
"url": "https://api.github.com/users/evildour"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2017-03-13T12:58:31 | 5482008504 | {"actor":{"display_login":"evildour"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/comments/145482540","pull_request_review_id":70287957,"id":145482540,"diff_hunk":"@@ -0,0 +1,237 @@\n+/**\n+ * Copyright 2017 Google Inc.\n+ * <p>\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ * <p>\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ * <p>\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.example.dlp;\n+\n+import com.google.cloud.dlp.v2beta1.DlpServiceClient;\n+import com.google.common.io.BaseEncoding;\n+import com.google.privacy.dlp.v2beta1.*;\n+import com.google.privacy.dlp.v2beta1.InfoTypeTransformations.InfoTypeTransformation;\n+import com.google.privacy.dlp.v2beta1.CryptoReplaceFfxFpeConfig.FfxCommonNativeAlphabet;\n+import com.google.protobuf.ByteString;\n+import org.apache.commons.cli.*;\n+\n+public class DeId {\n+\n+ private static void deidentifyWithMask(String string, Character maskingCharacter, int numberToMask) {\n+ // [START dlp_deidentify_mask]\n+ // instantiate a client\n+ try (DlpServiceClient dlpServiceClient = DlpServiceClient.create()) {\n+\n+ // The string to deidentify\n+ // string = \"My SSN is 372819127\";\n+\n+ // (Optional) The maximum number of sensitive characters to mask in a match\n+ // If omitted from the request or set to 0, the API will mask any matching characters\n+ // numberToMask = 5;\n+\n+ // (Optional) The character to mask matching sensitive data with\n+ // maskingCharacter = 'x';\n+\n+ ContentItem contentItem =\n+ ContentItem.newBuilder()\n+ .setType(\"text/plain\")\n+ .setValue(string)\n+ .build();\n+\n+ CharacterMaskConfig characterMaskConfig =\n+ CharacterMaskConfig.newBuilder()\n+ .setMaskingCharacter(maskingCharacter.toString())\n+ .setNumberToMask(numberToMask)\n+ .build();\n+\n+ PrimitiveTransformation primitiveTransformation =\n+ PrimitiveTransformation.newBuilder()\n+ .setCharacterMaskConfig(characterMaskConfig)\n+ .build();\n+\n+ InfoTypeTransformation infoTypeTransformationObject =\n+ InfoTypeTransformation.newBuilder()\n+ .setPrimitiveTransformation(primitiveTransformation)\n+ .build();\n+\n+ InfoTypeTransformations infoTypeTransformationArray =","path":"dlp/src/main/java/com/example/dlp/DeId.java","position":66,"original_position":66,"commit_id":"28ae8292ae469a59e46728abdae9ecbd9ceafd11","original_commit_id":"28ae8292ae469a59e46728abdae9ecbd9ceafd11","user":{"login":"jabubake","id":23587163,"avatar_url":"https://avatars2.githubusercontent.com/u/23587163?v=4","gravatar_id":"","url":"https://api.github.com/users/jabubake","html_url":"https://github.com/jabubake","followers_url":"https://api.github.com/users/jabubake/followers","following_url":"https://api.github.com/users/jabubake/following{/other_user}","gists_url":"https://api.github.com/users/jabubake/gists{/gist_id}","starred_url":"https://api.github.com/users/jabubake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jabubake/subscriptions","organizations_url":"https://api.github.com/users/jabubake/orgs","repos_url":"https://api.github.com/users/jabubake/repos","events_url":"https://api.github.com/users/jabubake/events{/privacy}","received_events_url":"https://api.github.com/users/jabubake/received_events","type":"User","site_admin":false},"body":"Given all these objects that get created just to create a request, it would be to provide a comment above each to state what it is. It is unfortunate that `InfoTypeTransformations` object exists to just provide an `InfoTypeTransformation[]` surface. `PrimitiveTransformation`, `InfoTypeTransformation` also seem pretty confusing. In an ideal world, `PrimitveTransformation`, `InfoTypeTransformation`, `InfoTypeTransformations` are un-necessary objects.","created_at":"2017-10-18T17:18:29Z","updated_at":"2017-10-18T17:26:22Z","html_url":"https://github.com/GoogleCloudPlatform/java-docs-samples/pull/841#discussion_r145482540","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/841","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/comments/145482540"},"html":{"href":"https://github.com/GoogleCloudPlatform/java-docs-samples/pull/841#discussion_r145482540"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/841"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/841","id":139682306,"html_url":"https://github.com/GoogleCloudPlatform/java-docs-samples/pull/841","diff_url":"https://github.com/GoogleCloudPlatform/java-docs-samples/pull/841.diff","patch_url":"https://github.com/GoogleCloudPlatform/java-docs-samples/pull/841.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues/841","number":841,"state":"open","locked":false,"title":"Add new DLP samples (Bigquery, DeID, Risk Analysis)","user":{"login":"ace-n","id":2309317,"avatar_url":"https://avatars2.githubusercontent.com/u/2309317?v=4","gravatar_id":"","url":"https://api.github.com/users/ace-n","html_url":"https://github.com/ace-n","followers_url":"https://api.github.com/users/ace-n/followers","following_url":"https://api.github.com/users/ace-n/following{/other_user}","gists_url":"https://api.github.com/users/ace-n/gists{/gist_id}","starred_url":"https://api.github.com/users/ace-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ace-n/subscriptions","organizations_url":"https://api.github.com/users/ace-n/orgs","repos_url":"https://api.github.com/users/ace-n/repos","events_url":"https://api.github.com/users/ace-n/events{/privacy}","received_events_url":"https://api.github.com/users/ace-n/received_events","type":"User","site_admin":false},"body":"~**Do not merge** until this code has been:~\r\n~a) tested~\r\n~b) updated to use new client libraries (as the current ones don't support scanning BigQuery)~\r\n\r\n~_Reminder:_ this should be reviewed on a best-effort basis.~","created_at":"2017-09-06T22:52:19Z","updated_at":"2017-10-18T17:26:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75f7da8f2eec1d4f811d78a28f3fda8bd976178f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/841/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/841/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues/841/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/statuses/28ae8292ae469a59e46728abdae9ecbd9ceafd11","head":{"label":"GoogleCloudPlatform:dlp-bq","ref":"dlp-bq","sha":"28ae8292ae469a59e46728abdae9ecbd9ceafd11","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":32895424,"name":"java-docs-samples","full_name":"GoogleCloudPlatform/java-docs-samples","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/java-docs-samples","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/deployments","created_at":"2015-03-25T22:48:38Z","updated_at":"2017-10-17T18:56:43Z","pushed_at":"2017-10-18T16:59:17Z","git_url":"git://github.com/GoogleCloudPlatform/java-docs-samples.git","ssh_url":"[email protected]:GoogleCloudPlatform/java-docs-samples.git","clone_url":"https://github.com/GoogleCloudPlatform/java-docs-samples.git","svn_url":"https://github.com/GoogleCloudPlatform/java-docs-samples","homepage":null,"size":8910,"stargazers_count":372,"watchers_count":372,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":935,"mirror_url":null,"open_issues_count":78,"forks":935,"open_issues":78,"watchers":372,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"596a9dcff743d0681de4e12011c2d59257bbe2c5","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":32895424,"name":"java-docs-samples","full_name":"GoogleCloudPlatform/java-docs-samples","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/java-docs-samples","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/deployments","created_at":"2015-03-25T22:48:38Z","updated_at":"2017-10-17T18:56:43Z","pushed_at":"2017-10-18T16:59:17Z","git_url":"git://github.com/GoogleCloudPlatform/java-docs-samples.git","ssh_url":"[email protected]:GoogleCloudPlatform/java-docs-samples.git","clone_url":"https://github.com/GoogleCloudPlatform/java-docs-samples.git","svn_url":"https://github.com/GoogleCloudPlatform/java-docs-samples","homepage":null,"size":8910,"stargazers_count":372,"watchers_count":372,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":935,"mirror_url":null,"open_issues_count":78,"forks":935,"open_issues":78,"watchers":372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/841"},"html":{"href":"https://github.com/GoogleCloudPlatform/java-docs-samples/pull/841"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues/841"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/issues/841/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/841/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/pulls/841/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples/statuses/28ae8292ae469a59e46728abdae9ecbd9ceafd11"}},"author_association":"NONE"}} | {
"id": 32895424,
"name": "GoogleCloudPlatform/java-docs-samples",
"url": "https://api.github.com/repos/GoogleCloudPlatform/java-docs-samples"
} | {
"id": 23587163,
"login": "jabubake",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23587163?",
"url": "https://api.github.com/users/jabubake"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2017-10-18T17:18:29 | 6734265013 | {"actor":{"display_login":"jabubake"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/147339802","pull_request_review_id":72415541,"id":147339802,"diff_hunk":"@@ -24,6 +23,232 @@ namespace Google.Cloud.Bigtable.V2\n public partial class BigtableClient\n {\n /// <summary>\n+ /// Mutates a row atomically based on the output of a predicate Reader filter.\n+ /// </summary>\n+ /// <remarks>\n+ /// <para>\n+ /// Note that string is implicitly convertible to <see cref=\"BigtableByteString\"/>, so <paramref name=\"rowKey\"/> can\n+ /// be specified using a string as well and its UTF-8 representations will be used.\n+ /// </para>\n+ /// <para>\n+ /// This method simply delegates to <see cref=\"CheckAndMutateRow(CheckAndMutateRowRequest, CallSettings)\"/>.\n+ /// </para>\n+ /// </remarks>\n+ /// <param name=\"tableName\">\n+ /// The unique name of the table to which the conditional mutation should be\n+ /// applied. Must not be null.\n+ /// </param>\n+ /// <param name=\"rowKey\">\n+ /// The key of the row to which the conditional mutation should be applied.\n+ /// Must not be empty.\n+ /// </param>\n+ /// <param name=\"predicateFilter\">\n+ /// The filter to be applied to the contents of the specified row. Depending\n+ /// on whether or not any results are yielded, either <paramref name=\"trueMutations\"/> or\n+ /// <paramref name=\"falseMutations\"/> will be executed. If null, checks that the row contains\n+ /// any values at all.\n+ /// </param>\n+ /// <param name=\"trueMutations\">\n+ /// Changes to be atomically applied to the specified row if <paramref name=\"predicateFilter\"/>\n+ /// yields at least one cell when applied to <paramref name=\"rowKey\"/>. Entries are applied in\n+ /// order, meaning that earlier mutations can be masked by later ones.\n+ /// Must contain at least one entry if <paramref name=\"falseMutations\"/> is null or empty, and\n+ /// at most 100000. Can be null or empty, but must not contain null elements.\n+ /// </param>\n+ /// <param name=\"falseMutations\">\n+ /// Changes to be atomically applied to the specified row if <paramref name=\"predicateFilter\"/>\n+ /// does not yield any cells when applied to <paramref name=\"rowKey\"/>. Entries are applied in\n+ /// order, meaning that earlier mutations can be masked by later ones.\n+ /// Must contain at least one entry if <paramref name=\"trueMutations\"/> is null or empty, and\n+ /// at most 100000. Can be null or empty, but must not contain null elements.\n+ /// </param>\n+ /// <param name=\"callSettings\">\n+ /// If not null, applies overrides to this RPC call.\n+ /// </param>\n+ /// <returns>\n+ /// The response from trying to mutate the row.\n+ /// </returns>\n+ public virtual CheckAndMutateRowResponse CheckAndMutateRow(\n+ TableName tableName,\n+ BigtableByteString rowKey,\n+ RowFilter predicateFilter,\n+ IEnumerable<Mutation> trueMutations,\n+ IEnumerable<Mutation> falseMutations,\n+ CallSettings callSettings = null) =>\n+ CheckAndMutateRow(\n+ CreateCheckAndMutateRowRequest(tableName, rowKey, predicateFilter, trueMutations, falseMutations),\n+ callSettings);\n+\n+ /// <summary>\n+ /// Mutates a row atomically based on the output of a predicate Reader filter.\n+ /// </summary>\n+ /// <remarks>\n+ /// <para>\n+ /// Note that string is implicitly convertible to <see cref=\"BigtableByteString\"/>, so <paramref name=\"rowKey\"/> can\n+ /// be specified using a string as well and its UTF-8 representations will be used.\n+ /// </para>\n+ /// <para>\n+ /// This method simply delegates to <see cref=\"CheckAndMutateRow(CheckAndMutateRowRequest, CallSettings)\"/>.\n+ /// </para>\n+ /// </remarks>\n+ /// <param name=\"tableName\">\n+ /// The unique name of the table to which the conditional mutation should be\n+ /// applied. Must not be null.\n+ /// </param>\n+ /// <param name=\"rowKey\">\n+ /// The key of the row to which the conditional mutation should be applied.\n+ /// Must not be empty.\n+ /// </param>\n+ /// <param name=\"predicateFilter\">\n+ /// The filter to be applied to the contents of the specified row. Depending\n+ /// on whether or not any results are yielded, <paramref name=\"trueMutations\"/> may or may not\n+ /// be executed. If null, checks that the row contains any values at all.\n+ /// </param>\n+ /// <param name=\"trueMutations\">\n+ /// Changes to be atomically applied to the specified row if <paramref name=\"predicateFilter\"/>\n+ /// yields at least one cell when applied to <paramref name=\"rowKey\"/>. Entries are applied in\n+ /// order, meaning that earlier mutations can be masked by later ones.\n+ /// Must contain at least one entry and at most 100000. Must not be null, or contain null elements.\n+ /// </param>\n+ /// <returns>\n+ /// The response from trying to mutate the row.\n+ /// </returns>\n+ public virtual CheckAndMutateRowResponse CheckAndMutateRow(\n+ TableName tableName,\n+ BigtableByteString rowKey,\n+ RowFilter predicateFilter,\n+ params Mutation[] trueMutations) =>\n+ CheckAndMutateRow(\n+ CreateCheckAndMutateRowRequest(tableName, rowKey, predicateFilter, trueMutations, falseMutations: null));\n+\n+ /// <summary>\n+ /// Asynchronously mutates a row atomically based on the output of a predicate Reader filter.\n+ /// </summary>\n+ /// <remarks>\n+ /// <para>\n+ /// Note that string is implicitly convertible to <see cref=\"BigtableByteString\"/>, so <paramref name=\"rowKey\"/> can\n+ /// be specified using a string as well and its UTF-8 representations will be used.\n+ /// </para>\n+ /// <para>\n+ /// This method simply delegates to <see cref=\"CheckAndMutateRow(CheckAndMutateRowRequest, CallSettings)\"/>.","path":"apis/Google.Cloud.Bigtable.V2/Google.Cloud.Bigtable.V2/BigtableClientPartial.cs","position":20,"original_position":119,"commit_id":"7581544f0ae7534a0a6e18880a8b09480ae0300e","original_commit_id":"7581544f0ae7534a0a6e18880a8b09480ae0300e","user":{"login":"jskeet","id":17011,"avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"body":"Async","created_at":"2017-10-27T07:29:28Z","updated_at":"2017-10-27T07:34:41Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1585#discussion_r147339802","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1585","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/147339802"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1585#discussion_r147339802"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1585"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1585","id":148766331,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1585","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1585.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1585.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/1585","number":1585,"state":"open","locked":false,"title":"RowFilter factory methods and CheckAndMutateRow support","user":{"login":"evildour","id":4014815,"avatar_url":"https://avatars2.githubusercontent.com/u/4014815?v=4","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"body":"Probably easiest to review one commit at a time.","created_at":"2017-10-25T20:01:03Z","updated_at":"2017-10-27T07:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cff0cf0eba5fda770a5c7bde74862a72b7282a0","assignee":{"login":"jskeet","id":17011,"avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"assignees":[{"login":"jskeet","id":17011,"avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1585/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1585/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/1585/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/7581544f0ae7534a0a6e18880a8b09480ae0300e","head":{"label":"evildour:bt-check-and-mutate","ref":"bt-check-and-mutate","sha":"7581544f0ae7534a0a6e18880a8b09480ae0300e","user":{"login":"evildour","id":4014815,"avatar_url":"https://avatars2.githubusercontent.com/u/4014815?v=4","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"repo":{"id":62015644,"name":"google-cloud-dotnet","full_name":"evildour/google-cloud-dotnet","owner":{"login":"evildour","id":4014815,"avatar_url":"https://avatars2.githubusercontent.com/u/4014815?v=4","gravatar_id":"","url":"https://api.github.com/users/evildour","html_url":"https://github.com/evildour","followers_url":"https://api.github.com/users/evildour/followers","following_url":"https://api.github.com/users/evildour/following{/other_user}","gists_url":"https://api.github.com/users/evildour/gists{/gist_id}","starred_url":"https://api.github.com/users/evildour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evildour/subscriptions","organizations_url":"https://api.github.com/users/evildour/orgs","repos_url":"https://api.github.com/users/evildour/repos","events_url":"https://api.github.com/users/evildour/events{/privacy}","received_events_url":"https://api.github.com/users/evildour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evildour/google-cloud-dotnet","description":"Google Cloud Client Library for .NET","fork":true,"url":"https://api.github.com/repos/evildour/google-cloud-dotnet","forks_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/evildour/google-cloud-dotnet/deployments","created_at":"2016-06-27T01:02:10Z","updated_at":"2016-10-24T18:27:48Z","pushed_at":"2017-10-25T20:00:34Z","git_url":"git://github.com/evildour/google-cloud-dotnet.git","ssh_url":"[email protected]:evildour/google-cloud-dotnet.git","clone_url":"https://github.com/evildour/google-cloud-dotnet.git","svn_url":"https://github.com/evildour/google-cloud-dotnet","homepage":null,"size":13944,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"8e00b6b46ec4625e3810021a5e88e25b5a91a7c7","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":35877412,"name":"google-cloud-dotnet","full_name":"GoogleCloudPlatform/google-cloud-dotnet","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","description":"Google Cloud Client Libraries for .NET","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/deployments","created_at":"2015-05-19T11:14:02Z","updated_at":"2017-10-25T11:06:39Z","pushed_at":"2017-10-26T18:11:44Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","ssh_url":"[email protected]:GoogleCloudPlatform/google-cloud-dotnet.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","homepage":"https://googlecloudplatform.github.io/google-cloud-dotnet/","size":40945,"stargazers_count":168,"watchers_count":168,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":43,"forks":66,"open_issues":43,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1585"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1585"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/1585"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/1585/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1585/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1585/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/7581544f0ae7534a0a6e18880a8b09480ae0300e"}},"author_association":"COLLABORATOR"}} | {
"id": 35877412,
"name": "GoogleCloudPlatform/google-cloud-dotnet",
"url": "https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet"
} | {
"id": 17011,
"login": "jskeet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17011?",
"url": "https://api.github.com/users/jskeet"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2017-10-27T07:29:28 | 6773728177 | {"actor":{"display_login":"jskeet"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/101944529","pull_request_review_id":22684870,"id":101944529,"diff_hunk":"@@ -0,0 +1,82 @@\n+/*\n+ * Copyright 2017 Google Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+/*\n+ * EDITING INSTRUCTIONS\n+ * This file is referenced in Subscriber's javadoc. Any change to this file should be reflected in\n+ * PubSub's javadoc.\n+ */\n+\n+package com.google.cloud.examples.pubsub.snippets;\n+\n+import com.google.api.gax.core.SettableRpcFuture;\n+import com.google.cloud.pubsub.spi.v1.AckReply;\n+import com.google.cloud.pubsub.spi.v1.AckReplyConsumer;\n+import com.google.cloud.pubsub.spi.v1.MessageReceiver;\n+import com.google.cloud.pubsub.spi.v1.Subscriber;\n+import com.google.pubsub.v1.PubsubMessage;\n+import com.google.pubsub.v1.SubscriptionName;\n+import java.util.concurrent.atomic.AtomicInteger;\n+import java.util.concurrent.Executor;\n+import java.util.concurrent.TimeUnit;\n+\n+public class SubscriberSnippets {\n+\n+ private final SubscriptionName subscription;\n+\n+ public SubscriberSnippets(SubscriptionName subscription) {\n+ this.subscription = subscription;\n+ }\n+\n+ /**\n+ * Example of receiving a specific number of messages.\n+ */\n+ // [TARGET startAsync()]\n+ // [VARIABLE \"my_project_name\"]\n+ // [VARIABLE \"my_subscription_name\"]\n+ // [VARIABLE 3]\n+ public void startAsync(int receiveNum) throws Exception {\n+ // [START startAsync]\n+ final AtomicInteger pendingReceives = new AtomicInteger(receiveNum);\n+ final SettableRpcFuture<Void> done = new SettableRpcFuture<>();\n+\n+ MessageReceiver receiver = new MessageReceiver() {\n+ public void receiveMessage(final PubsubMessage message, final AckReplyConsumer consumer) {\n+ System.out.println(\"got message: \" + message);","path":"google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java","position":58,"original_position":58,"commit_id":"4bd5d48058bf916573c4a916e7e2f6b1fecebda2","original_commit_id":"4bd5d48058bf916573c4a916e7e2f6b1fecebda2","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [System.out.println is used](https://www.codacy.com/app/mziccard/google-cloud-java/pullRequest?prid=515357)","created_at":"2017-02-20T03:49:38Z","updated_at":"2017-02-20T03:49:38Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1613#discussion_r101944529","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1613","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/101944529"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1613#discussion_r101944529"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1613"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1613","id":105844278,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1613","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1613.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1613.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1613","number":1613,"state":"open","locked":false,"title":"add Subscriber snippet","user":{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"body":"The snippet is very long, but the shortest I can make it without loosing\r\ndetails.","created_at":"2017-02-13T07:56:01Z","updated_at":"2017-02-20T03:49:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9f3e03ac1b62f753eefa45059ff161c23abe727","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1613/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1613/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1613/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/4bd5d48058bf916573c4a916e7e2f6b1fecebda2","head":{"label":"pongad:subscriber-snippet","ref":"subscriber-snippet","sha":"4bd5d48058bf916573c4a916e7e2f6b1fecebda2","user":{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"repo":{"id":47151174,"name":"google-cloud-java","full_name":"pongad/google-cloud-java","owner":{"login":"pongad","id":1617025,"avatar_url":"https://avatars.githubusercontent.com/u/1617025?v=3","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pongad/google-cloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/pongad/google-cloud-java","forks_url":"https://api.github.com/repos/pongad/google-cloud-java/forks","keys_url":"https://api.github.com/repos/pongad/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pongad/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pongad/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/pongad/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/pongad/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/pongad/google-cloud-java/events","assignees_url":"https://api.github.com/repos/pongad/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/pongad/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/pongad/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/pongad/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pongad/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pongad/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/pongad/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pongad/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/pongad/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/pongad/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/pongad/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/pongad/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/pongad/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/pongad/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/pongad/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/pongad/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/pongad/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/pongad/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/pongad/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pongad/google-cloud-java/merges","archive_url":"https://api.github.com/repos/pongad/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pongad/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/pongad/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/pongad/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/pongad/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/pongad/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pongad/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/pongad/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/pongad/google-cloud-java/deployments","created_at":"2015-11-30T22:56:21Z","updated_at":"2016-12-04T23:35:55Z","pushed_at":"2017-02-20T03:46:24Z","git_url":"git://github.com/pongad/google-cloud-java.git","ssh_url":"[email protected]:pongad/google-cloud-java.git","clone_url":"https://github.com/pongad/google-cloud-java.git","svn_url":"https://github.com/pongad/google-cloud-java","homepage":"http://googlecloudplatform.github.io/gcloud-java/","size":86216,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"68ce84d313b7745b1dc37be300522ea1c051063b","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"name":"google-cloud-java","full_name":"GoogleCloudPlatform/google-cloud-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2017-02-19T01:10:49Z","pushed_at":"2017-02-20T03:46:25Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-java.git","ssh_url":"[email protected]:GoogleCloudPlatform/google-cloud-java.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-java.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","homepage":"http://googlecloudplatform.github.io/google-cloud-java/","size":104410,"stargazers_count":240,"watchers_count":240,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":134,"mirror_url":null,"open_issues_count":174,"forks":134,"open_issues":174,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1613"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1613"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1613"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1613/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1613/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1613/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/4bd5d48058bf916573c4a916e7e2f6b1fecebda2"}}}} | {
"id": 26181278,
"name": "GoogleCloudPlatform/google-cloud-java",
"url": "https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2017-02-20T03:49:38 | 5353148117 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/comments/104247306","pull_request_review_id":25075600,"id":104247306,"diff_hunk":"@@ -219,21 +219,37 @@ def main(unused_argv=None):\n max_crm_calls = configs.get('max_crm_api_calls_per_100_seconds', 400)\n crm_rate_limiter = RateLimiter(max_crm_calls, 100)\n \n- try:\n- load_projects_pipeline.run(\n- dao, cycle_timestamp, configs, crm_rate_limiter)\n- load_projects_iam_policies_pipeline.run(\n- dao, cycle_timestamp, configs, crm_rate_limiter)\n- load_org_iam_policies_pipeline.run(\n- dao, cycle_timestamp, configs, crm_rate_limiter)\n- except LoadDataPipelineError as e:\n- LOGGER.error('Encountered error to load data. Abort.\\n{0}'.format(e))\n- _complete_snapshot_cycle(dao, cycle_timestamp, 'FAILURE')\n- sys.exit()\n-\n- _complete_snapshot_cycle(dao, cycle_timestamp, 'SUCCESS')\n- _send_email(cycle_timestamp, 'SUCCESS', configs.get('sendgrid_api_key'),\n- configs.get('email_sender'), configs.get('email_recipient'))\n+ pipelines = [\n+ { 'pipeline': load_projects_pipeline,\n+ 'status': '' },\n+ { 'pipeline': load_projects_iam_policies_pipeline,\n+ 'status': '' },\n+ { 'pipeline': load_org_iam_policies_pipeline,\n+ 'status': '' },\n+ ]\n+\n+ for pipeline in pipelines:\n+ try:\n+ pipeline['pipeline'].run(\n+ dao, cycle_timestamp, configs, crm_rate_limiter)\n+ pipeline['status'] = 'SUCCESS'\n+ except LoadDataPipelineError as e:\n+ LOGGER.error(\n+ 'Encountered error to load data.\\n{0}'.format(e))\n+ pipeline['status'] = 'FAILURE'\n+\n+ succeeded = filter(lambda p: p['status'] == 'SUCCESS', pipelines)","path":"google/cloud/security/inventory/inventory_loader.py","position":38,"original_position":38,"commit_id":"a425c3d7e769c2ec25a279984c50bad68e0ecd92","original_commit_id":"a425c3d7e769c2ec25a279984c50bad68e0ecd92","user":{"login":"ahoying","id":4105300,"avatar_url":"https://avatars1.githubusercontent.com/u/4105300?v=3","gravatar_id":"","url":"https://api.github.com/users/ahoying","html_url":"https://github.com/ahoying","followers_url":"https://api.github.com/users/ahoying/followers","following_url":"https://api.github.com/users/ahoying/following{/other_user}","gists_url":"https://api.github.com/users/ahoying/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoying/subscriptions","organizations_url":"https://api.github.com/users/ahoying/orgs","repos_url":"https://api.github.com/users/ahoying/repos","events_url":"https://api.github.com/users/ahoying/events{/privacy}","received_events_url":"https://api.github.com/users/ahoying/received_events","type":"User","site_admin":false},"body":"I think something like this would be more readable:\r\n\r\nsucceeded = [p['status'] == 'SUCCESS' for p in pipelines]\r\n\r\nif all(succeeded):\r\n snapshot_cycle_status == 'SUCCESS'\r\nelif any(succeeded):\r\n snapshot_cycle_status == 'PARTIAL_SUCCESS'\r\nelse:\r\n snapshot_cycle_status == 'FAILURE'\r\n","created_at":"2017-03-03T21:37:00Z","updated_at":"2017-03-03T21:37:24Z","html_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/42#discussion_r104247306","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/comments/104247306"},"html":{"href":"https://github.com/GoogleCloudPlatform/forseti-security/pull/42#discussion_r104247306"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/42","id":109055602,"html_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/42","diff_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/42.diff","patch_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/42.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/42","number":42,"state":"open","locked":false,"title":"Inventory: don't halt pipeline runner if there are errors","user":{"login":"carise","id":14340,"avatar_url":"https://avatars3.githubusercontent.com/u/14340?v=3","gravatar_id":"","url":"https://api.github.com/users/carise","html_url":"https://github.com/carise","followers_url":"https://api.github.com/users/carise/followers","following_url":"https://api.github.com/users/carise/following{/other_user}","gists_url":"https://api.github.com/users/carise/gists{/gist_id}","starred_url":"https://api.github.com/users/carise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carise/subscriptions","organizations_url":"https://api.github.com/users/carise/orgs","repos_url":"https://api.github.com/users/carise/repos","events_url":"https://api.github.com/users/carise/events{/privacy}","received_events_url":"https://api.github.com/users/carise/received_events","type":"User","site_admin":false},"body":"Also, send an email after the inventory loader is done.\r\n\r\nSome DM template changes for scope.","created_at":"2017-03-03T21:06:39Z","updated_at":"2017-03-03T21:37:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e07b1e6c3db1ae13cc634414a07ed39190fc8dff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/42/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/42/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/42/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/statuses/a425c3d7e769c2ec25a279984c50bad68e0ecd92","head":{"label":"GoogleCloudPlatform:dm-inventory-changes","ref":"dm-inventory-changes","sha":"a425c3d7e769c2ec25a279984c50bad68e0ecd92","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":82210080,"name":"forseti-security","full_name":"GoogleCloudPlatform/forseti-security","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/forseti-security","description":"A suite of security tools that provide visibility, detection, and enforcement for an organization's use of Google Cloud Platform.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/deployments","created_at":"2017-02-16T18:01:26Z","updated_at":"2017-03-03T20:27:35Z","pushed_at":"2017-03-03T21:19:29Z","git_url":"git://github.com/GoogleCloudPlatform/forseti-security.git","ssh_url":"[email protected]:GoogleCloudPlatform/forseti-security.git","clone_url":"https://github.com/GoogleCloudPlatform/forseti-security.git","svn_url":"https://github.com/GoogleCloudPlatform/forseti-security","homepage":"","size":195,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"73a843ca592ae0ea332be54dd8a8ac52947486c7","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":82210080,"name":"forseti-security","full_name":"GoogleCloudPlatform/forseti-security","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/forseti-security","description":"A suite of security tools that provide visibility, detection, and enforcement for an organization's use of Google Cloud Platform.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/deployments","created_at":"2017-02-16T18:01:26Z","updated_at":"2017-03-03T20:27:35Z","pushed_at":"2017-03-03T21:19:29Z","git_url":"git://github.com/GoogleCloudPlatform/forseti-security.git","ssh_url":"[email protected]:GoogleCloudPlatform/forseti-security.git","clone_url":"https://github.com/GoogleCloudPlatform/forseti-security.git","svn_url":"https://github.com/GoogleCloudPlatform/forseti-security","homepage":"","size":195,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/42"},"html":{"href":"https://github.com/GoogleCloudPlatform/forseti-security/pull/42"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/42"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/statuses/a425c3d7e769c2ec25a279984c50bad68e0ecd92"}}}} | {
"id": 82210080,
"name": "GoogleCloudPlatform/forseti-security",
"url": "https://api.github.com/repos/GoogleCloudPlatform/forseti-security"
} | {
"id": 4105300,
"login": "ahoying",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4105300?",
"url": "https://api.github.com/users/ahoying"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2017-03-03T21:37:00 | 5430563100 | {"actor":{"display_login":"ahoying"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/148155455","pull_request_review_id":73355138,"id":148155455,"diff_hunk":"@@ -413,19 +450,33 @@ void write(String uploadId, byte[] toWrite, int toWriteOffset, long destOffset,\n *\n * @throws StorageException upon failure\n */\n+ Policy getIamPolicy(String bucket, Map<Option, ?> options);\n+\n+ /**\n+ * Returns the IAM policy for the specified bucket.\n+ *\n+ * @throws StorageException upon failure\n+ */\n Policy getIamPolicy(String bucket);\n \n /**\n * Updates the IAM policy for the specified bucket.\n *\n * @throws StorageException upon failure\n */\n+ Policy setIamPolicy(String bucket, Policy policy, Map<Option, ?> options);\n+\n+ /**\n+ * Updates the IAM policy for the specified bucket.\n+ *\n+ * @throws StorageException upon failure\n+ */\n Policy setIamPolicy(String bucket, Policy policy);\n \n /**\n * Tests whether the caller holds the specified permissions for the specified bucket.\n *\n * @throws StorageException upon failure\n */\n- TestIamPermissionsResponse testIamPermissions(String bucket, List<String> permissions);\n+ TestIamPermissionsResponse testIamPermissions(String bucket, List<String> permissions, Map<Option, ?> options);","path":"google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/StorageRpc.java","position":105,"original_position":105,"commit_id":"450a76af8628eff3d5024c380255cf628659ac46","original_commit_id":"450a76af8628eff3d5024c380255cf628659ac46","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [JUnit 4 tests that execute tests should use the @Test annotation](https://www.codacy.com/app/mziccard/google-cloud-java/pullRequest?prid=1024477)","created_at":"2017-10-31T23:45:57Z","updated_at":"2017-10-31T23:45:57Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2558#discussion_r148155455","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2558","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/148155455"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2558#discussion_r148155455"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2558"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2558","id":149071181,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2558","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2558.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2558.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2558","number":2558,"state":"open","locked":false,"title":"Requester pays test iam permissions WIP","user":{"login":"andreamlin","id":4016818,"avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"body":"Expose userProject for the operations\r\n- storage.objects.list\r\n- storage.bucket.testIamPermissions","created_at":"2017-10-26T23:43:39Z","updated_at":"2017-10-31T23:45:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12ef7f5d5a3ce9dfa1684d333fc200cac8dab6db","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2558/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2558/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2558/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/450a76af8628eff3d5024c380255cf628659ac46","head":{"label":"andreamlin:requester_pays_test_iam_permissions","ref":"requester_pays_test_iam_permissions","sha":"450a76af8628eff3d5024c380255cf628659ac46","user":{"login":"andreamlin","id":4016818,"avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"repo":{"id":99830591,"name":"google-cloud-java","full_name":"andreamlin/google-cloud-java","owner":{"login":"andreamlin","id":4016818,"avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreamlin/google-cloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/andreamlin/google-cloud-java","forks_url":"https://api.github.com/repos/andreamlin/google-cloud-java/forks","keys_url":"https://api.github.com/repos/andreamlin/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreamlin/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreamlin/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/andreamlin/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/andreamlin/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/andreamlin/google-cloud-java/events","assignees_url":"https://api.github.com/repos/andreamlin/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/andreamlin/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/andreamlin/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/andreamlin/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreamlin/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreamlin/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreamlin/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreamlin/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/andreamlin/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/andreamlin/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/andreamlin/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/andreamlin/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/andreamlin/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/andreamlin/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreamlin/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreamlin/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreamlin/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreamlin/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/andreamlin/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreamlin/google-cloud-java/merges","archive_url":"https://api.github.com/repos/andreamlin/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreamlin/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/andreamlin/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/andreamlin/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/andreamlin/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/andreamlin/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreamlin/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/andreamlin/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/andreamlin/google-cloud-java/deployments","created_at":"2017-08-09T16:36:12Z","updated_at":"2017-08-09T16:36:18Z","pushed_at":"2017-10-31T23:39:08Z","git_url":"git://github.com/andreamlin/google-cloud-java.git","ssh_url":"[email protected]:andreamlin/google-cloud-java.git","clone_url":"https://github.com/andreamlin/google-cloud-java.git","svn_url":"https://github.com/andreamlin/google-cloud-java","homepage":"https://googlecloudplatform.github.io/google-cloud-java/","size":15307,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"ca271453a6d62e302832eef460849812fd7ce4ab","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"name":"google-cloud-java","full_name":"GoogleCloudPlatform/google-cloud-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2017-10-30T15:18:04Z","pushed_at":"2017-10-31T23:39:10Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-java.git","ssh_url":"[email protected]:GoogleCloudPlatform/google-cloud-java.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-java.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","homepage":"https://googlecloudplatform.github.io/google-cloud-java/","size":217743,"stargazers_count":454,"watchers_count":454,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":166,"forks":295,"open_issues":166,"watchers":454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2558"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/2558"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2558"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/2558/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2558/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/2558/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/450a76af8628eff3d5024c380255cf628659ac46"}},"author_association":"CONTRIBUTOR"}} | {
"id": 26181278,
"name": "GoogleCloudPlatform/google-cloud-java",
"url": "https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2017-10-31T23:45:57 | 6792359850 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/101677735","pull_request_review_id":22414486,"id":101677735,"diff_hunk":"@@ -645,6 +657,92 @@ def _deDotKeys(self, res):\n return res\n \n \n+class InfluxDBPublisher(SamplePublisher):\n+\n+ def __init__(self, influx_uri=None, influx_db_name=None):\n+ # set to default above in flags unless changed\n+ self.influx_uri = influx_uri\n+ self.influx_db_name = influx_db_name\n+\n+ def PublishSamples(self, samples):\n+ formated_samples = []\n+ for sample in samples:\n+ formated_samples.append(self._ConstructSample(sample))\n+ self._Publish(formated_samples)\n+\n+ def _Publish(self, formated_samples):\n+ try:\n+ self._CreateDB()\n+ body = '\\n'.join(formated_samples)\n+ self._WriteData(body)\n+ except (IOError, httplib.HTTPException) as http_exception:\n+ logging.error('Error connecting to the database: %s', http_exception)\n+\n+ def _ConstructSample(self, sample):\n+ timestamp = str(int((10 ** 9) * sample['timestamp']))\n+ measurement = 'perfkitbenchmarker'\n+\n+ tag_set_metadata = ''\n+ if 'metadata' in sample:\n+ if sample['metadata']:\n+ tag_set_metadata = ','.join(self._FormatToKeyValue(sample['metadata']))\n+ tag_keys = ('test', 'official', 'owner', 'run_uri', 'sample_uri',\n+ 'metric', 'unit')\n+ ordered_tags = collections.OrderedDict([(k, sample[k]) for k in tag_keys])\n+ tag_set = ','.join(self._FormatToKeyValue(ordered_tags))\n+ if tag_set_metadata:\n+ tag_set += ',' + tag_set_metadata\n+\n+ field_set = '%s=%s' % ('value', sample['value'])\n+\n+ sample_constructed_body = '%s,%s %s %s' % (measurement, tag_set,\n+ field_set, timestamp)\n+ return sample_constructed_body\n+\n+ def _FormatToKeyValue(self, sample):\n+ key_value_pairs = []\n+ for k, v in sample.iteritems():\n+ if v == '':\n+ v = '\\\\\"\\\\\"'\n+ v = str(v)\n+ v = v.replace(',', '\\,')\n+ v = v.replace(' ', '\\ ')\n+ key_value_pairs.append('%s=%s' % (k, v))\n+ return key_value_pairs\n+\n+ def _CreateDB(self):","path":"perfkitbenchmarker/publisher.py","position":101,"original_position":92,"commit_id":"4e448f6fcf702fa6c5fece169c3756c79e28544c","original_commit_id":"2119948e281e71449be3875c9bc5545a59158707","user":{"login":"besanradwan","id":8431220,"avatar_url":"https://avatars.githubusercontent.com/u/8431220?v=3","gravatar_id":"","url":"https://api.github.com/users/besanradwan","html_url":"https://github.com/besanradwan","followers_url":"https://api.github.com/users/besanradwan/followers","following_url":"https://api.github.com/users/besanradwan/following{/other_user}","gists_url":"https://api.github.com/users/besanradwan/gists{/gist_id}","starred_url":"https://api.github.com/users/besanradwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besanradwan/subscriptions","organizations_url":"https://api.github.com/users/besanradwan/orgs","repos_url":"https://api.github.com/users/besanradwan/repos","events_url":"https://api.github.com/users/besanradwan/events{/privacy}","received_events_url":"https://api.github.com/users/besanradwan/received_events","type":"User","site_admin":false},"body":"Done! @gareth-ferneyhough thanks for the feedback.","created_at":"2017-02-17T03:02:28Z","updated_at":"2017-02-17T03:02:28Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1278#discussion_r101677735","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/1278","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/101677735"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1278#discussion_r101677735"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/1278"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/1278","id":102176561,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1278","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1278.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1278.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/1278","number":1278,"state":"open","locked":false,"title":"Add the capability to publish to InfluxDB","user":{"login":"besanradwan","id":8431220,"avatar_url":"https://avatars.githubusercontent.com/u/8431220?v=3","gravatar_id":"","url":"https://api.github.com/users/besanradwan","html_url":"https://github.com/besanradwan","followers_url":"https://api.github.com/users/besanradwan/followers","following_url":"https://api.github.com/users/besanradwan/following{/other_user}","gists_url":"https://api.github.com/users/besanradwan/gists{/gist_id}","starred_url":"https://api.github.com/users/besanradwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besanradwan/subscriptions","organizations_url":"https://api.github.com/users/besanradwan/orgs","repos_url":"https://api.github.com/users/besanradwan/repos","events_url":"https://api.github.com/users/besanradwan/events{/privacy}","received_events_url":"https://api.github.com/users/besanradwan/received_events","type":"User","site_admin":false},"body":"This code aims to add the capability for PKB to publish directly to InfluxDB\r\n\r\nThe publishing of data from PKB benchmarks can done either by specifiying a pre-existing Influx DB publisher or with none specified it will create a new one or re-use a pre-existing DB called perfkit. By default if no uri is specified it will publish the data to localhost.","created_at":"2017-01-19T00:05:22Z","updated_at":"2017-02-17T03:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1026e531ca009515e155865c622c12a6765d15a5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/1278/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/1278/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/1278/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/4e448f6fcf702fa6c5fece169c3756c79e28544c","head":{"label":"besanradwan:influx_db_publisher","ref":"influx_db_publisher","sha":"4e448f6fcf702fa6c5fece169c3756c79e28544c","user":{"login":"besanradwan","id":8431220,"avatar_url":"https://avatars.githubusercontent.com/u/8431220?v=3","gravatar_id":"","url":"https://api.github.com/users/besanradwan","html_url":"https://github.com/besanradwan","followers_url":"https://api.github.com/users/besanradwan/followers","following_url":"https://api.github.com/users/besanradwan/following{/other_user}","gists_url":"https://api.github.com/users/besanradwan/gists{/gist_id}","starred_url":"https://api.github.com/users/besanradwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besanradwan/subscriptions","organizations_url":"https://api.github.com/users/besanradwan/orgs","repos_url":"https://api.github.com/users/besanradwan/repos","events_url":"https://api.github.com/users/besanradwan/events{/privacy}","received_events_url":"https://api.github.com/users/besanradwan/received_events","type":"User","site_admin":false},"repo":{"id":47644493,"name":"PerfKitBenchmarker","full_name":"besanradwan/PerfKitBenchmarker","owner":{"login":"besanradwan","id":8431220,"avatar_url":"https://avatars.githubusercontent.com/u/8431220?v=3","gravatar_id":"","url":"https://api.github.com/users/besanradwan","html_url":"https://github.com/besanradwan","followers_url":"https://api.github.com/users/besanradwan/followers","following_url":"https://api.github.com/users/besanradwan/following{/other_user}","gists_url":"https://api.github.com/users/besanradwan/gists{/gist_id}","starred_url":"https://api.github.com/users/besanradwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besanradwan/subscriptions","organizations_url":"https://api.github.com/users/besanradwan/orgs","repos_url":"https://api.github.com/users/besanradwan/repos","events_url":"https://api.github.com/users/besanradwan/events{/privacy}","received_events_url":"https://api.github.com/users/besanradwan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/besanradwan/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/releases{/id}","deployments_url":"https://api.github.com/repos/besanradwan/PerfKitBenchmarker/deployments","created_at":"2015-12-08T19:31:27Z","updated_at":"2016-11-17T17:21:12Z","pushed_at":"2017-02-17T03:01:42Z","git_url":"git://github.com/besanradwan/PerfKitBenchmarker.git","ssh_url":"[email protected]:besanradwan/PerfKitBenchmarker.git","clone_url":"https://github.com/besanradwan/PerfKitBenchmarker.git","svn_url":"https://github.com/besanradwan/PerfKitBenchmarker","homepage":"","size":8152,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"68debe7fdf57ae093631a9e8ab6810783e4cd537","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks use defaults to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/deployments","created_at":"2014-07-17T17:23:26Z","updated_at":"2017-02-14T09:18:18Z","pushed_at":"2017-02-17T03:01:43Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"[email protected]:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"","size":8787,"stargazers_count":767,"watchers_count":767,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":194,"mirror_url":null,"open_issues_count":156,"forks":194,"open_issues":156,"watchers":767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/1278"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1278"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/1278"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/1278/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/1278/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/1278/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/4e448f6fcf702fa6c5fece169c3756c79e28544c"}}}} | {
"id": 21950910,
"name": "GoogleCloudPlatform/PerfKitBenchmarker",
"url": "https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker"
} | {
"id": 8431220,
"login": "besanradwan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8431220?",
"url": "https://api.github.com/users/besanradwan"
} | {
"id": 2810941,
"login": "GoogleCloudPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2810941?",
"url": "https://api.github.com/orgs/GoogleCloudPlatform"
} | 2017-02-17T03:02:28 | 5341471023 | {"actor":{"display_login":"besanradwan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/comments/144637556","pull_request_review_id":69326543,"id":144637556,"diff_hunk":"@@ -2,25 +2,29 @@\n * License, v. 2.0. If a copy of the MPL was not distributed with this\n * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n \n+\n // Script to add meters from a .xlsx file\n const reqPromise = require('request-promise-native');\n-const XLSX = require('xlsx');\n const path = require('path');\n+const readCSV = require('../server/services/readCSV');\n const promisify = require('es6-promisify');\n const parseString = require('xml2js').parseString;\n const Meter = require('../server/models/Meter');\n+const _ = require('lodash');\n const stopDB = require('../server/models/database').stopDB;\n \n const parseXMLPromisified = promisify(parseString);\n \n-function parseXLSX(filename) {\n-\tconst workbook = XLSX.readFile(filename);\n-\t// This isn't a property so we don't want dot-notation\n-\tconst worksheet = workbook.Sheets['Sheet1']; // eslint-disable-line dot-notation\n-\treturn XLSX.utils.sheet_to_json(worksheet);\n+async function parseCSV(filename) {\n+\t// returns a list of lists representing the lines of the file\n+\tconst meterInfo = await readCSV(filename);\n+\t// the headers should be in the first line\n+\tconst headers = meterInfo[0];\n+\tconst meterDataRows = meterInfo.slice(1);\n+\tconst formattedData = meterDataRows.map(row => _.zipObject(headers, row));\n+\tconsole.log(formattedData);","path":"src/scripts/addMamacMeters.js","position":30,"original_position":30,"commit_id":"4d1c7ff8730d6cf526af95b39215a78f30c9fd3a","original_commit_id":"4d1c7ff8730d6cf526af95b39215a78f30c9fd3a","user":{"login":"johndiiorio","id":22435660,"avatar_url":"https://avatars2.githubusercontent.com/u/22435660?v=4","gravatar_id":"","url":"https://api.github.com/users/johndiiorio","html_url":"https://github.com/johndiiorio","followers_url":"https://api.github.com/users/johndiiorio/followers","following_url":"https://api.github.com/users/johndiiorio/following{/other_user}","gists_url":"https://api.github.com/users/johndiiorio/gists{/gist_id}","starred_url":"https://api.github.com/users/johndiiorio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johndiiorio/subscriptions","organizations_url":"https://api.github.com/users/johndiiorio/orgs","repos_url":"https://api.github.com/users/johndiiorio/repos","events_url":"https://api.github.com/users/johndiiorio/events{/privacy}","received_events_url":"https://api.github.com/users/johndiiorio/received_events","type":"User","site_admin":false},"body":"Remove unnecessary console.log","created_at":"2017-10-13T19:21:17Z","updated_at":"2017-10-13T19:23:46Z","html_url":"https://github.com/OpenEnergyDashboard/OED/pull/154#discussion_r144637556","pull_request_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/154","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/comments/144637556"},"html":{"href":"https://github.com/OpenEnergyDashboard/OED/pull/154#discussion_r144637556"},"pull_request":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/154","id":145593209,"html_url":"https://github.com/OpenEnergyDashboard/OED/pull/154","diff_url":"https://github.com/OpenEnergyDashboard/OED/pull/154.diff","patch_url":"https://github.com/OpenEnergyDashboard/OED/pull/154.patch","issue_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues/154","number":154,"state":"open","locked":false,"title":"Read meter details from csv","user":{"login":"jameeters","id":12907039,"avatar_url":"https://avatars2.githubusercontent.com/u/12907039?v=4","gravatar_id":"","url":"https://api.github.com/users/jameeters","html_url":"https://github.com/jameeters","followers_url":"https://api.github.com/users/jameeters/followers","following_url":"https://api.github.com/users/jameeters/following{/other_user}","gists_url":"https://api.github.com/users/jameeters/gists{/gist_id}","starred_url":"https://api.github.com/users/jameeters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameeters/subscriptions","organizations_url":"https://api.github.com/users/jameeters/orgs","repos_url":"https://api.github.com/users/jameeters/repos","events_url":"https://api.github.com/users/jameeters/events{/privacy}","received_events_url":"https://api.github.com/users/jameeters/received_events","type":"User","site_admin":false},"body":"This addresses #128. We now read the IPs from a .csv file instead of a .xlsx file.","created_at":"2017-10-10T03:41:20Z","updated_at":"2017-10-13T19:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c94b7128b24229a0184b491241d7116265d9741b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/OpenEnergyDashboard/OED/milestones/3","html_url":"https://github.com/OpenEnergyDashboard/OED/milestone/3","labels_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/milestones/3/labels","id":2823351,"number":3,"title":"0.3 Release","description":"Features to target for the 0.3 release.","creator":{"login":"LeoTindall","id":3290365,"avatar_url":"https://avatars0.githubusercontent.com/u/3290365?v=4","gravatar_id":"","url":"https://api.github.com/users/LeoTindall","html_url":"https://github.com/LeoTindall","followers_url":"https://api.github.com/users/LeoTindall/followers","following_url":"https://api.github.com/users/LeoTindall/following{/other_user}","gists_url":"https://api.github.com/users/LeoTindall/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoTindall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoTindall/subscriptions","organizations_url":"https://api.github.com/users/LeoTindall/orgs","repos_url":"https://api.github.com/users/LeoTindall/repos","events_url":"https://api.github.com/users/LeoTindall/events{/privacy}","received_events_url":"https://api.github.com/users/LeoTindall/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2017-10-09T03:32:22Z","updated_at":"2017-10-11T19:49:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/154/commits","review_comments_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/154/comments","review_comment_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues/154/comments","statuses_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/statuses/4d1c7ff8730d6cf526af95b39215a78f30c9fd3a","head":{"label":"OpenEnergyDashboard:read_meter_details_from_csv","ref":"read_meter_details_from_csv","sha":"4d1c7ff8730d6cf526af95b39215a78f30c9fd3a","user":{"login":"OpenEnergyDashboard","id":32343363,"avatar_url":"https://avatars1.githubusercontent.com/u/32343363?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenEnergyDashboard","html_url":"https://github.com/OpenEnergyDashboard","followers_url":"https://api.github.com/users/OpenEnergyDashboard/followers","following_url":"https://api.github.com/users/OpenEnergyDashboard/following{/other_user}","gists_url":"https://api.github.com/users/OpenEnergyDashboard/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenEnergyDashboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenEnergyDashboard/subscriptions","organizations_url":"https://api.github.com/users/OpenEnergyDashboard/orgs","repos_url":"https://api.github.com/users/OpenEnergyDashboard/repos","events_url":"https://api.github.com/users/OpenEnergyDashboard/events{/privacy}","received_events_url":"https://api.github.com/users/OpenEnergyDashboard/received_events","type":"Organization","site_admin":false},"repo":{"id":71814050,"name":"OED","full_name":"OpenEnergyDashboard/OED","owner":{"login":"OpenEnergyDashboard","id":32343363,"avatar_url":"https://avatars1.githubusercontent.com/u/32343363?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenEnergyDashboard","html_url":"https://github.com/OpenEnergyDashboard","followers_url":"https://api.github.com/users/OpenEnergyDashboard/followers","following_url":"https://api.github.com/users/OpenEnergyDashboard/following{/other_user}","gists_url":"https://api.github.com/users/OpenEnergyDashboard/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenEnergyDashboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenEnergyDashboard/subscriptions","organizations_url":"https://api.github.com/users/OpenEnergyDashboard/orgs","repos_url":"https://api.github.com/users/OpenEnergyDashboard/repos","events_url":"https://api.github.com/users/OpenEnergyDashboard/events{/privacy}","received_events_url":"https://api.github.com/users/OpenEnergyDashboard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenEnergyDashboard/OED","description":"Open Energy Dashboard (OED)","fork":false,"url":"https://api.github.com/repos/OpenEnergyDashboard/OED","forks_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/forks","keys_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/teams","hooks_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/hooks","issue_events_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues/events{/number}","events_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/events","assignees_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/assignees{/user}","branches_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/branches{/branch}","tags_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/tags","blobs_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/languages","stargazers_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/stargazers","contributors_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/contributors","subscribers_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/subscribers","subscription_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/subscription","commits_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/contents/{+path}","compare_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/merges","archive_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/downloads","issues_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues{/number}","pulls_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/labels{/name}","releases_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/releases{/id}","deployments_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/deployments","created_at":"2016-10-24T17:30:37Z","updated_at":"2017-09-27T20:40:32Z","pushed_at":"2017-10-13T19:20:00Z","git_url":"git://github.com/OpenEnergyDashboard/OED.git","ssh_url":"[email protected]:OpenEnergyDashboard/OED.git","clone_url":"https://github.com/OpenEnergyDashboard/OED.git","svn_url":"https://github.com/OpenEnergyDashboard/OED","homepage":"","size":7502,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":49,"forks":2,"open_issues":49,"watchers":10,"default_branch":"master"}},"base":{"label":"OpenEnergyDashboard:master","ref":"master","sha":"d970d5695ddd6241a714845cb01a345efc41dbae","user":{"login":"OpenEnergyDashboard","id":32343363,"avatar_url":"https://avatars1.githubusercontent.com/u/32343363?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenEnergyDashboard","html_url":"https://github.com/OpenEnergyDashboard","followers_url":"https://api.github.com/users/OpenEnergyDashboard/followers","following_url":"https://api.github.com/users/OpenEnergyDashboard/following{/other_user}","gists_url":"https://api.github.com/users/OpenEnergyDashboard/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenEnergyDashboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenEnergyDashboard/subscriptions","organizations_url":"https://api.github.com/users/OpenEnergyDashboard/orgs","repos_url":"https://api.github.com/users/OpenEnergyDashboard/repos","events_url":"https://api.github.com/users/OpenEnergyDashboard/events{/privacy}","received_events_url":"https://api.github.com/users/OpenEnergyDashboard/received_events","type":"Organization","site_admin":false},"repo":{"id":71814050,"name":"OED","full_name":"OpenEnergyDashboard/OED","owner":{"login":"OpenEnergyDashboard","id":32343363,"avatar_url":"https://avatars1.githubusercontent.com/u/32343363?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenEnergyDashboard","html_url":"https://github.com/OpenEnergyDashboard","followers_url":"https://api.github.com/users/OpenEnergyDashboard/followers","following_url":"https://api.github.com/users/OpenEnergyDashboard/following{/other_user}","gists_url":"https://api.github.com/users/OpenEnergyDashboard/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenEnergyDashboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenEnergyDashboard/subscriptions","organizations_url":"https://api.github.com/users/OpenEnergyDashboard/orgs","repos_url":"https://api.github.com/users/OpenEnergyDashboard/repos","events_url":"https://api.github.com/users/OpenEnergyDashboard/events{/privacy}","received_events_url":"https://api.github.com/users/OpenEnergyDashboard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenEnergyDashboard/OED","description":"Open Energy Dashboard (OED)","fork":false,"url":"https://api.github.com/repos/OpenEnergyDashboard/OED","forks_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/forks","keys_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/teams","hooks_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/hooks","issue_events_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues/events{/number}","events_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/events","assignees_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/assignees{/user}","branches_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/branches{/branch}","tags_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/tags","blobs_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/languages","stargazers_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/stargazers","contributors_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/contributors","subscribers_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/subscribers","subscription_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/subscription","commits_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/contents/{+path}","compare_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/merges","archive_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/downloads","issues_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues{/number}","pulls_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/labels{/name}","releases_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/releases{/id}","deployments_url":"https://api.github.com/repos/OpenEnergyDashboard/OED/deployments","created_at":"2016-10-24T17:30:37Z","updated_at":"2017-09-27T20:40:32Z","pushed_at":"2017-10-13T19:20:00Z","git_url":"git://github.com/OpenEnergyDashboard/OED.git","ssh_url":"[email protected]:OpenEnergyDashboard/OED.git","clone_url":"https://github.com/OpenEnergyDashboard/OED.git","svn_url":"https://github.com/OpenEnergyDashboard/OED","homepage":"","size":7502,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":49,"forks":2,"open_issues":49,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/154"},"html":{"href":"https://github.com/OpenEnergyDashboard/OED/pull/154"},"issue":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues/154"},"comments":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/OpenEnergyDashboard/OED/statuses/4d1c7ff8730d6cf526af95b39215a78f30c9fd3a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 71814050,
"name": "OpenEnergyDashboard/OED",
"url": "https://api.github.com/repos/OpenEnergyDashboard/OED"
} | {
"id": 22435660,
"login": "johndiiorio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22435660?",
"url": "https://api.github.com/users/johndiiorio"
} | {
"id": 32343363,
"login": "OpenEnergyDashboard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32343363?",
"url": "https://api.github.com/orgs/OpenEnergyDashboard"
} | 2017-10-13T19:21:17 | 6715043760 | {"actor":{"display_login":"johndiiorio"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/comments/148958250","pull_request_review_id":74282336,"id":148958250,"diff_hunk":"@@ -1,12 +1,92 @@\n <!DOCTYPE html>\n <html lang=\"ru\">\n- <head>\n- <meta charset=\"utf-8\">\n- <title>HTML Academy: Глейси</title>\n- </head>\n- <body>\n-\n- <p>Репозиторий создан для обучения на интенсивном онлайн‑курсе «<a href=\"https://htmlacademy.ru/intensive/htmlcss\">Базовый HTML и CSS</a>».</p>\n-\n- </body>\n+<head>\n+ <meta charset=\"utf-8\">\n+ <title>HTML Academy: Глейси</title>\n+</head>\n+<body>\n+<header class=\"main-header\">\n+ <nav class=\"main-navigation\">\n+ <a class=\"main-header-logo\">\n+ <img src=\"\" width=\"0\" height=\"0\" alt=\"Gllacy shop logo\">\n+ </a>\n+ <ul class=\"site-navigation\">\n+ <li><a href>Каталог</a></li>\n+ <li><a href>Доставка и оплата</a></li>\n+ <li><a href>О компании</a></li>\n+ </ul>\n+ <ul class=\"user-navigation\">\n+ <li class=\"search\"></li>\n+ <li class=\"login-link\">Вход</li>\n+ <li class=\"basket\">Пусто</li>\n+ </ul>\n+ </nav>\n+ <span>С 10 до 20, ежедневно</span><br/>","path":"index.html","position":33,"original_position":33,"commit_id":"2f34725b0855a2c4607d5a4dab060f3c7cbe7c9d","original_commit_id":"2d750894c5a4cbb7c923f5cab660f9717d7878d7","user":{"login":"Makiss","id":12518297,"avatar_url":"https://avatars1.githubusercontent.com/u/12518297?v=4","gravatar_id":"","url":"https://api.github.com/users/Makiss","html_url":"https://github.com/Makiss","followers_url":"https://api.github.com/users/Makiss/followers","following_url":"https://api.github.com/users/Makiss/following{/other_user}","gists_url":"https://api.github.com/users/Makiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Makiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makiss/subscriptions","organizations_url":"https://api.github.com/users/Makiss/orgs","repos_url":"https://api.github.com/users/Makiss/repos","events_url":"https://api.github.com/users/Makiss/events{/privacy}","received_events_url":"https://api.github.com/users/Makiss/received_events","type":"User","site_admin":false},"body":"График и контактный телефон нужно обернуть во что-то. Лучше всего подойдет абзац. Также здесь можно обойтись одним спаном","created_at":"2017-11-05T14:08:33Z","updated_at":"2017-11-05T14:08:33Z","html_url":"https://github.com/htmlacademy-htmlcss/549897-gllacy/pull/2#discussion_r148958250","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/comments/148958250"},"html":{"href":"https://github.com/htmlacademy-htmlcss/549897-gllacy/pull/2#discussion_r148958250"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/2","id":150676385,"html_url":"https://github.com/htmlacademy-htmlcss/549897-gllacy/pull/2","diff_url":"https://github.com/htmlacademy-htmlcss/549897-gllacy/pull/2.diff","patch_url":"https://github.com/htmlacademy-htmlcss/549897-gllacy/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/issues/2","number":2,"state":"open","locked":false,"title":"Разметка личного проекта","user":{"login":"Avenirre","id":30600480,"avatar_url":"https://avatars1.githubusercontent.com/u/30600480?v=4","gravatar_id":"","url":"https://api.github.com/users/Avenirre","html_url":"https://github.com/Avenirre","followers_url":"https://api.github.com/users/Avenirre/followers","following_url":"https://api.github.com/users/Avenirre/following{/other_user}","gists_url":"https://api.github.com/users/Avenirre/gists{/gist_id}","starred_url":"https://api.github.com/users/Avenirre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avenirre/subscriptions","organizations_url":"https://api.github.com/users/Avenirre/orgs","repos_url":"https://api.github.com/users/Avenirre/repos","events_url":"https://api.github.com/users/Avenirre/events{/privacy}","received_events_url":"https://api.github.com/users/Avenirre/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Разметка личного проекта](https://up.htmlacademy.ru/htmlcss/19/user/549897/tasks/13)","created_at":"2017-11-04T13:20:29Z","updated_at":"2017-11-05T14:08:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcee4e69ad9f956d95126cd54131dc09c9380a91","assignee":{"login":"Makiss","id":12518297,"avatar_url":"https://avatars1.githubusercontent.com/u/12518297?v=4","gravatar_id":"","url":"https://api.github.com/users/Makiss","html_url":"https://github.com/Makiss","followers_url":"https://api.github.com/users/Makiss/followers","following_url":"https://api.github.com/users/Makiss/following{/other_user}","gists_url":"https://api.github.com/users/Makiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Makiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makiss/subscriptions","organizations_url":"https://api.github.com/users/Makiss/orgs","repos_url":"https://api.github.com/users/Makiss/repos","events_url":"https://api.github.com/users/Makiss/events{/privacy}","received_events_url":"https://api.github.com/users/Makiss/received_events","type":"User","site_admin":false},"assignees":[{"login":"Makiss","id":12518297,"avatar_url":"https://avatars1.githubusercontent.com/u/12518297?v=4","gravatar_id":"","url":"https://api.github.com/users/Makiss","html_url":"https://github.com/Makiss","followers_url":"https://api.github.com/users/Makiss/followers","following_url":"https://api.github.com/users/Makiss/following{/other_user}","gists_url":"https://api.github.com/users/Makiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Makiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makiss/subscriptions","organizations_url":"https://api.github.com/users/Makiss/orgs","repos_url":"https://api.github.com/users/Makiss/repos","events_url":"https://api.github.com/users/Makiss/events{/privacy}","received_events_url":"https://api.github.com/users/Makiss/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/statuses/2f34725b0855a2c4607d5a4dab060f3c7cbe7c9d","head":{"label":"Avenirre:master","ref":"master","sha":"2f34725b0855a2c4607d5a4dab060f3c7cbe7c9d","user":{"login":"Avenirre","id":30600480,"avatar_url":"https://avatars1.githubusercontent.com/u/30600480?v=4","gravatar_id":"","url":"https://api.github.com/users/Avenirre","html_url":"https://github.com/Avenirre","followers_url":"https://api.github.com/users/Avenirre/followers","following_url":"https://api.github.com/users/Avenirre/following{/other_user}","gists_url":"https://api.github.com/users/Avenirre/gists{/gist_id}","starred_url":"https://api.github.com/users/Avenirre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avenirre/subscriptions","organizations_url":"https://api.github.com/users/Avenirre/orgs","repos_url":"https://api.github.com/users/Avenirre/repos","events_url":"https://api.github.com/users/Avenirre/events{/privacy}","received_events_url":"https://api.github.com/users/Avenirre/received_events","type":"User","site_admin":false},"repo":{"id":108896242,"name":"549897-gllacy","full_name":"Avenirre/549897-gllacy","owner":{"login":"Avenirre","id":30600480,"avatar_url":"https://avatars1.githubusercontent.com/u/30600480?v=4","gravatar_id":"","url":"https://api.github.com/users/Avenirre","html_url":"https://github.com/Avenirre","followers_url":"https://api.github.com/users/Avenirre/followers","following_url":"https://api.github.com/users/Avenirre/following{/other_user}","gists_url":"https://api.github.com/users/Avenirre/gists{/gist_id}","starred_url":"https://api.github.com/users/Avenirre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avenirre/subscriptions","organizations_url":"https://api.github.com/users/Avenirre/orgs","repos_url":"https://api.github.com/users/Avenirre/repos","events_url":"https://api.github.com/users/Avenirre/events{/privacy}","received_events_url":"https://api.github.com/users/Avenirre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Avenirre/549897-gllacy","description":"Roman Vinokurov","fork":true,"url":"https://api.github.com/repos/Avenirre/549897-gllacy","forks_url":"https://api.github.com/repos/Avenirre/549897-gllacy/forks","keys_url":"https://api.github.com/repos/Avenirre/549897-gllacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Avenirre/549897-gllacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Avenirre/549897-gllacy/teams","hooks_url":"https://api.github.com/repos/Avenirre/549897-gllacy/hooks","issue_events_url":"https://api.github.com/repos/Avenirre/549897-gllacy/issues/events{/number}","events_url":"https://api.github.com/repos/Avenirre/549897-gllacy/events","assignees_url":"https://api.github.com/repos/Avenirre/549897-gllacy/assignees{/user}","branches_url":"https://api.github.com/repos/Avenirre/549897-gllacy/branches{/branch}","tags_url":"https://api.github.com/repos/Avenirre/549897-gllacy/tags","blobs_url":"https://api.github.com/repos/Avenirre/549897-gllacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Avenirre/549897-gllacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Avenirre/549897-gllacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Avenirre/549897-gllacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Avenirre/549897-gllacy/statuses/{sha}","languages_url":"https://api.github.com/repos/Avenirre/549897-gllacy/languages","stargazers_url":"https://api.github.com/repos/Avenirre/549897-gllacy/stargazers","contributors_url":"https://api.github.com/repos/Avenirre/549897-gllacy/contributors","subscribers_url":"https://api.github.com/repos/Avenirre/549897-gllacy/subscribers","subscription_url":"https://api.github.com/repos/Avenirre/549897-gllacy/subscription","commits_url":"https://api.github.com/repos/Avenirre/549897-gllacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Avenirre/549897-gllacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Avenirre/549897-gllacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Avenirre/549897-gllacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Avenirre/549897-gllacy/contents/{+path}","compare_url":"https://api.github.com/repos/Avenirre/549897-gllacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Avenirre/549897-gllacy/merges","archive_url":"https://api.github.com/repos/Avenirre/549897-gllacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Avenirre/549897-gllacy/downloads","issues_url":"https://api.github.com/repos/Avenirre/549897-gllacy/issues{/number}","pulls_url":"https://api.github.com/repos/Avenirre/549897-gllacy/pulls{/number}","milestones_url":"https://api.github.com/repos/Avenirre/549897-gllacy/milestones{/number}","notifications_url":"https://api.github.com/repos/Avenirre/549897-gllacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Avenirre/549897-gllacy/labels{/name}","releases_url":"https://api.github.com/repos/Avenirre/549897-gllacy/releases{/id}","deployments_url":"https://api.github.com/repos/Avenirre/549897-gllacy/deployments","created_at":"2017-10-30T19:07:02Z","updated_at":"2017-10-30T19:07:04Z","pushed_at":"2017-11-04T13:18:52Z","git_url":"git://github.com/Avenirre/549897-gllacy.git","ssh_url":"[email protected]:Avenirre/549897-gllacy.git","clone_url":"https://github.com/Avenirre/549897-gllacy.git","svn_url":"https://github.com/Avenirre/549897-gllacy","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"2843716b813971c29c8731201e68769e9e25348c","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":108895220,"name":"549897-gllacy","full_name":"htmlacademy-htmlcss/549897-gllacy","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/549897-gllacy","description":"Roman Vinokurov","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/deployments","created_at":"2017-10-30T18:58:03Z","updated_at":"2017-10-30T19:24:49Z","pushed_at":"2017-11-04T13:20:30Z","git_url":"git://github.com/htmlacademy-htmlcss/549897-gllacy.git","ssh_url":"[email protected]:htmlacademy-htmlcss/549897-gllacy.git","clone_url":"https://github.com/htmlacademy-htmlcss/549897-gllacy.git","svn_url":"https://github.com/htmlacademy-htmlcss/549897-gllacy","homepage":"https://github.com/Avenirre/549897-gllacy","size":4,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/2"},"html":{"href":"https://github.com/htmlacademy-htmlcss/549897-gllacy/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy/statuses/2f34725b0855a2c4607d5a4dab060f3c7cbe7c9d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 108895220,
"name": "htmlacademy-htmlcss/549897-gllacy",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/549897-gllacy"
} | {
"id": 12518297,
"login": "Makiss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12518297?",
"url": "https://api.github.com/users/Makiss"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-11-05T14:08:33 | 6811050116 | {"actor":{"display_login":"Makiss"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/comments/112767128","pull_request_review_id":34110236,"id":112767128,"diff_hunk":"@@ -17,59 +19,76 @@\n \t\t\t\t<li><a href=\"#\">Контакты</a></li>\n \t\t\t</ul>\n \t\t</nav>\n-\t\t<div class=\"basket\">\n-\t\t\t<a href=\"#\">Корзина</a>\n-\t\t</div>\n-\t<h1>Магазин готовых шаблонов</h1>\n-\t</header>\n+\t\t<div class=\"basket\"> <a href=\"#\">Корзина</a> </div>\n+\t\t<h1>Магазин готовых шаблонов</h1> </header>\n \t<main>\n-\t\t<form name=\"filter-form\" action=\"?\" method=\"get\">\n-\t\t\t<fieldset class=\"price\">\n-\t\t\t\t<legend>Стоимость</legend>\n-\t\t\t</fieldset>\n-\t\t\t<fieldset class=\"grid\">\n-\t\t\t\t<legend>Сетка:</legend>\n-\t\t\t\t<input type=\"radio\" value=\"responsive\" id=\"responsive\" name=\"grid\">\n-\t\t\t\t<label for=\"responsive\">Адаптивная</label>\n-\t\t\t\t<input type=\"radio\" value=\"fix\" id=\"fix\" name=\"grid\">\n-\t\t\t\t<label for=\"fix\">Фиксированная</label>\n-\t\t\t\t<input type=\"radio\" id=\"flex\" value=\"flex\" name=\"grid\">\n-\t\t\t\t<label for=\"flex\">Резиновая</label>\n-\t\t\t</fieldset>\n-\t\t\t<fieldset class=\"features\">\n-\t\t\t\t<legend>Особенности</legend>\n-\t\t\t\t<input type=\"checkbox\" id=\"slider\" name=\"features\" checked=\"\">\n-\t\t\t\t<label for=\"slider\">Слайдер</label>\n-\t\t\t\t<input type=\"checkbox\" id=\"features-block\" name=\"features\">\n-\t\t\t\t<label for=\"features-block\">Блок преимуществ</label>\n-\t\t\t\t<input type=\"checkbox\" id=\"news\" name=\"features\" checked>\n-\t\t\t\t<label for=\"news\">Новости</label>\n-\t\t\t\t<input type=\"checkbox\" id=\"gallery\" name=\"features\">\n-\t\t\t\t<label for=\"gallery\">Галерея</label>\n-\t\t\t\t<input type=\"checkbox\" id=\"basket\" name=\"features\">\n-\t\t\t\t<label for=\"basket\">Корзина</label>\n-\t\t\t\t<input type=\"submit\" value=\"Показать\">\n-\t\t\t</fieldset>\n-\t\t</form>\n-\t\t<article class=\"assortment\">\n-\t\t\t<div class=\"sedona\">\n-\t\t\t\t<img src=\"//placehold.it/576x360\" alt=\"sedona\">\n-\t\t\t</div>\n-\t\t\t<div class=\"pink\">\n-\t\t\t\t<img src=\"//placehold.it/576x360\" alt=\"pink\">\n-\t\t\t</div>\n-\t\t\t<div class=\"borodinski\">\n-\t\t\t\t<img src=\"//placehold.it/576x360\" alt=\"borodinski\">\n-\t\t\t</div>\n-\t\t\t<div class=\"mishka\">\n-\t\t\t\t<img src=\"//placehold.it/576x360\" alt=\"mishka\">\n-\t\t\t</div>\n-\t\t\t<div class=\"a+\">\n-\t\t\t\t<img src=\"//placehold.it/576x360\" alt=\"a+\">\n-\t\t\t</div>\n-\t\t\t<div class=\"kvast\">\n-\t\t\t\t<img src=\"//placehold.it/576x360\" alt=\"kvast\">\n-\t\t\t</div>\n+\t\t<aside>\n+\t\t\t<form name=\"filter-form\" action=\"?\" method=\"get\">\n+\t\t\t\t<fieldset class=\"price\">\n+\t\t\t\t\t<legend>Стоимость</legend>\n+\t\t\t\t</fieldset>\n+\t\t\t\t<fieldset class=\"grid\">\n+\t\t\t\t\t<legend>Сетка:</legend>\n+\t\t\t\t\t<input type=\"radio\" value=\"responsive\" id=\"responsive\" name=\"grid\">\n+\t\t\t\t\t<label for=\"responsive\">Адаптивная</label>\n+\t\t\t\t\t<input type=\"radio\" value=\"fix\" id=\"fix\" name=\"grid\">\n+\t\t\t\t\t<label for=\"fix\">Фиксированная</label>\n+\t\t\t\t\t<input type=\"radio\" id=\"flex\" value=\"flex\" name=\"grid\">\n+\t\t\t\t\t<label for=\"flex\">Резиновая</label>\n+\t\t\t\t</fieldset>\n+\t\t\t\t<fieldset class=\"features\">\n+\t\t\t\t\t<legend>Особенности</legend>\n+\t\t\t\t\t<input type=\"checkbox\" id=\"slider\" name=\"features\" checked=\"\">\n+\t\t\t\t\t<label for=\"slider\">Слайдер</label>\n+\t\t\t\t\t<input type=\"checkbox\" id=\"features-block\" name=\"features\">\n+\t\t\t\t\t<label for=\"features-block\">Блок преимуществ</label>\n+\t\t\t\t\t<input type=\"checkbox\" id=\"news\" name=\"features\" checked>\n+\t\t\t\t\t<label for=\"news\">Новости</label>\n+\t\t\t\t\t<input type=\"checkbox\" id=\"gallery\" name=\"features\">\n+\t\t\t\t\t<label for=\"gallery\">Галерея</label>\n+\t\t\t\t\t<input type=\"checkbox\" id=\"basket\" name=\"features\">\n+\t\t\t\t\t<label for=\"basket\">Корзина</label>\n+\t\t\t\t\t<input type=\"submit\" value=\"Показать\"> </fieldset>\n+\t\t\t</form>\n+\t\t</aside>\n+\t\t<div class=\"ol\"> <span>Сортировать</span>\n+\t\t\t<ol>\n+\t\t\t\t<li><a>По цене</a></li>\n+\t\t\t\t<li><a href=\"#\">По типу</a></li>\n+\t\t\t\t<li><a href=\"#\">По названию</a></li>\n+\t\t\t</ol>\n+\t\t</div>\n+\t\t<section class=\"assortment\">\n+\t\t\t<article class=\"layout\"> <img src=\"//placehold.it/576x360\" alt=\"sedona\">\n+\t\t\t\t<div class=\"card\">\n+\t\t\t\t\t<h3>Седона</h3>\n+\t\t\t\t\t<p>Информационный сайт для туристов</p> <a href=\"#\" class=\"price-btn\">9 900 руб.</a> </div>","path":"catalog.html","position":63,"original_position":119,"commit_id":"90f1bce82483e59214f99f115eba3607dc231507","original_commit_id":"7e712f096c0d1911f2784b1dcfb88cf88eef9bb3","user":{"login":"biggus-dickus","id":14337215,"avatar_url":"https://avatars1.githubusercontent.com/u/14337215?v=3","gravatar_id":"","url":"https://api.github.com/users/biggus-dickus","html_url":"https://github.com/biggus-dickus","followers_url":"https://api.github.com/users/biggus-dickus/followers","following_url":"https://api.github.com/users/biggus-dickus/following{/other_user}","gists_url":"https://api.github.com/users/biggus-dickus/gists{/gist_id}","starred_url":"https://api.github.com/users/biggus-dickus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biggus-dickus/subscriptions","organizations_url":"https://api.github.com/users/biggus-dickus/orgs","repos_url":"https://api.github.com/users/biggus-dickus/repos","events_url":"https://api.github.com/users/biggus-dickus/events{/privacy}","received_events_url":"https://api.github.com/users/biggus-dickus/received_events","type":"User","site_admin":false},"body":"Закрывающие дивы попереноси на новую строку, на один уровень с открывающим (единообразное форматирование).","created_at":"2017-04-21T20:10:01Z","updated_at":"2017-04-21T20:42:27Z","html_url":"https://github.com/htmlacademy-htmlcss/288979-nerds/pull/2#discussion_r112767128","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/comments/112767128"},"html":{"href":"https://github.com/htmlacademy-htmlcss/288979-nerds/pull/2#discussion_r112767128"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/2","id":116636877,"html_url":"https://github.com/htmlacademy-htmlcss/288979-nerds/pull/2","diff_url":"https://github.com/htmlacademy-htmlcss/288979-nerds/pull/2.diff","patch_url":"https://github.com/htmlacademy-htmlcss/288979-nerds/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/issues/2","number":2,"state":"open","locked":false,"title":"Разметка личного проекта","user":{"login":"lunteri","id":24916843,"avatar_url":"https://avatars1.githubusercontent.com/u/24916843?v=3","gravatar_id":"","url":"https://api.github.com/users/lunteri","html_url":"https://github.com/lunteri","followers_url":"https://api.github.com/users/lunteri/followers","following_url":"https://api.github.com/users/lunteri/following{/other_user}","gists_url":"https://api.github.com/users/lunteri/gists{/gist_id}","starred_url":"https://api.github.com/users/lunteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunteri/subscriptions","organizations_url":"https://api.github.com/users/lunteri/orgs","repos_url":"https://api.github.com/users/lunteri/repos","events_url":"https://api.github.com/users/lunteri/events{/privacy}","received_events_url":"https://api.github.com/users/lunteri/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Разметка личного проекта](https://up.htmlacademy.ru/htmlcss/17/user/288979/tasks/16)\n\n:boom: https://htmlacademy-htmlcss.github.io/288979-nerds/2/","created_at":"2017-04-19T20:39:26Z","updated_at":"2017-04-21T20:42:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a397626b6c9fefeb580bc24201a09395fd350379","assignee":{"login":"biggus-dickus","id":14337215,"avatar_url":"https://avatars1.githubusercontent.com/u/14337215?v=3","gravatar_id":"","url":"https://api.github.com/users/biggus-dickus","html_url":"https://github.com/biggus-dickus","followers_url":"https://api.github.com/users/biggus-dickus/followers","following_url":"https://api.github.com/users/biggus-dickus/following{/other_user}","gists_url":"https://api.github.com/users/biggus-dickus/gists{/gist_id}","starred_url":"https://api.github.com/users/biggus-dickus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biggus-dickus/subscriptions","organizations_url":"https://api.github.com/users/biggus-dickus/orgs","repos_url":"https://api.github.com/users/biggus-dickus/repos","events_url":"https://api.github.com/users/biggus-dickus/events{/privacy}","received_events_url":"https://api.github.com/users/biggus-dickus/received_events","type":"User","site_admin":false},"assignees":[{"login":"biggus-dickus","id":14337215,"avatar_url":"https://avatars1.githubusercontent.com/u/14337215?v=3","gravatar_id":"","url":"https://api.github.com/users/biggus-dickus","html_url":"https://github.com/biggus-dickus","followers_url":"https://api.github.com/users/biggus-dickus/followers","following_url":"https://api.github.com/users/biggus-dickus/following{/other_user}","gists_url":"https://api.github.com/users/biggus-dickus/gists{/gist_id}","starred_url":"https://api.github.com/users/biggus-dickus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biggus-dickus/subscriptions","organizations_url":"https://api.github.com/users/biggus-dickus/orgs","repos_url":"https://api.github.com/users/biggus-dickus/repos","events_url":"https://api.github.com/users/biggus-dickus/events{/privacy}","received_events_url":"https://api.github.com/users/biggus-dickus/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/statuses/90f1bce82483e59214f99f115eba3607dc231507","head":{"label":"lunteri:master","ref":"master","sha":"90f1bce82483e59214f99f115eba3607dc231507","user":{"login":"lunteri","id":24916843,"avatar_url":"https://avatars1.githubusercontent.com/u/24916843?v=3","gravatar_id":"","url":"https://api.github.com/users/lunteri","html_url":"https://github.com/lunteri","followers_url":"https://api.github.com/users/lunteri/followers","following_url":"https://api.github.com/users/lunteri/following{/other_user}","gists_url":"https://api.github.com/users/lunteri/gists{/gist_id}","starred_url":"https://api.github.com/users/lunteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunteri/subscriptions","organizations_url":"https://api.github.com/users/lunteri/orgs","repos_url":"https://api.github.com/users/lunteri/repos","events_url":"https://api.github.com/users/lunteri/events{/privacy}","received_events_url":"https://api.github.com/users/lunteri/received_events","type":"User","site_admin":false},"repo":{"id":87920563,"name":"288979-nerds","full_name":"lunteri/288979-nerds","owner":{"login":"lunteri","id":24916843,"avatar_url":"https://avatars1.githubusercontent.com/u/24916843?v=3","gravatar_id":"","url":"https://api.github.com/users/lunteri","html_url":"https://github.com/lunteri","followers_url":"https://api.github.com/users/lunteri/followers","following_url":"https://api.github.com/users/lunteri/following{/other_user}","gists_url":"https://api.github.com/users/lunteri/gists{/gist_id}","starred_url":"https://api.github.com/users/lunteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunteri/subscriptions","organizations_url":"https://api.github.com/users/lunteri/orgs","repos_url":"https://api.github.com/users/lunteri/repos","events_url":"https://api.github.com/users/lunteri/events{/privacy}","received_events_url":"https://api.github.com/users/lunteri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lunteri/288979-nerds","description":"Екатерина Субботина","fork":true,"url":"https://api.github.com/repos/lunteri/288979-nerds","forks_url":"https://api.github.com/repos/lunteri/288979-nerds/forks","keys_url":"https://api.github.com/repos/lunteri/288979-nerds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lunteri/288979-nerds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lunteri/288979-nerds/teams","hooks_url":"https://api.github.com/repos/lunteri/288979-nerds/hooks","issue_events_url":"https://api.github.com/repos/lunteri/288979-nerds/issues/events{/number}","events_url":"https://api.github.com/repos/lunteri/288979-nerds/events","assignees_url":"https://api.github.com/repos/lunteri/288979-nerds/assignees{/user}","branches_url":"https://api.github.com/repos/lunteri/288979-nerds/branches{/branch}","tags_url":"https://api.github.com/repos/lunteri/288979-nerds/tags","blobs_url":"https://api.github.com/repos/lunteri/288979-nerds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lunteri/288979-nerds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lunteri/288979-nerds/git/refs{/sha}","trees_url":"https://api.github.com/repos/lunteri/288979-nerds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lunteri/288979-nerds/statuses/{sha}","languages_url":"https://api.github.com/repos/lunteri/288979-nerds/languages","stargazers_url":"https://api.github.com/repos/lunteri/288979-nerds/stargazers","contributors_url":"https://api.github.com/repos/lunteri/288979-nerds/contributors","subscribers_url":"https://api.github.com/repos/lunteri/288979-nerds/subscribers","subscription_url":"https://api.github.com/repos/lunteri/288979-nerds/subscription","commits_url":"https://api.github.com/repos/lunteri/288979-nerds/commits{/sha}","git_commits_url":"https://api.github.com/repos/lunteri/288979-nerds/git/commits{/sha}","comments_url":"https://api.github.com/repos/lunteri/288979-nerds/comments{/number}","issue_comment_url":"https://api.github.com/repos/lunteri/288979-nerds/issues/comments{/number}","contents_url":"https://api.github.com/repos/lunteri/288979-nerds/contents/{+path}","compare_url":"https://api.github.com/repos/lunteri/288979-nerds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lunteri/288979-nerds/merges","archive_url":"https://api.github.com/repos/lunteri/288979-nerds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lunteri/288979-nerds/downloads","issues_url":"https://api.github.com/repos/lunteri/288979-nerds/issues{/number}","pulls_url":"https://api.github.com/repos/lunteri/288979-nerds/pulls{/number}","milestones_url":"https://api.github.com/repos/lunteri/288979-nerds/milestones{/number}","notifications_url":"https://api.github.com/repos/lunteri/288979-nerds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lunteri/288979-nerds/labels{/name}","releases_url":"https://api.github.com/repos/lunteri/288979-nerds/releases{/id}","deployments_url":"https://api.github.com/repos/lunteri/288979-nerds/deployments","created_at":"2017-04-11T10:20:51Z","updated_at":"2017-04-11T10:20:53Z","pushed_at":"2017-04-21T13:53:24Z","git_url":"git://github.com/lunteri/288979-nerds.git","ssh_url":"[email protected]:lunteri/288979-nerds.git","clone_url":"https://github.com/lunteri/288979-nerds.git","svn_url":"https://github.com/lunteri/288979-nerds","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"221b0ce31b9c774d45381409717f508616787a73","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars0.githubusercontent.com/u/16576942?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":87919890,"name":"288979-nerds","full_name":"htmlacademy-htmlcss/288979-nerds","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars0.githubusercontent.com/u/16576942?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/288979-nerds","description":"Екатерина Субботина","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/deployments","created_at":"2017-04-11T10:13:37Z","updated_at":"2017-04-11T11:05:31Z","pushed_at":"2017-04-21T13:56:03Z","git_url":"git://github.com/htmlacademy-htmlcss/288979-nerds.git","ssh_url":"[email protected]:htmlacademy-htmlcss/288979-nerds.git","clone_url":"https://github.com/htmlacademy-htmlcss/288979-nerds.git","svn_url":"https://github.com/htmlacademy-htmlcss/288979-nerds","homepage":"https://github.com/lunteri/288979-nerds","size":13,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/2"},"html":{"href":"https://github.com/htmlacademy-htmlcss/288979-nerds/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds/statuses/90f1bce82483e59214f99f115eba3607dc231507"}}}} | {
"id": 87919890,
"name": "htmlacademy-htmlcss/288979-nerds",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/288979-nerds"
} | {
"id": 14337215,
"login": "biggus-dickus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14337215?",
"url": "https://api.github.com/users/biggus-dickus"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-04-21T20:10:01 | 5734677288 | {"actor":{"display_login":"biggus-dickus"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/comments/97408133","pull_request_review_id":18014837,"id":97408133,"diff_hunk":"@@ -0,0 +1,141 @@\n+<!DOCTYPE html>\n+<html lang=\"ru\">\n+ <head>\n+ <meta charset=\"utf-8\">\n+ <title>Средства для ухода</title>\n+ <link rel=\"stylesheet\" href=\"style.css\">\n+ </head>\n+ <body>\n+ <header class=\"page-header\">\n+ <div class=\"container\">\n+ <nav class=\"main-nav\">\n+ <ul>\n+ <li>\n+ <a href=\"#\">Информация</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Новости</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Прайс-лист</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Магазин</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Контакты</a>\n+ </li>\n+ </ul>\n+ </nav>\n+ <div class=\"user-block\">\n+ <a class=\"login\" href=\"#\">Вход</a>\n+ </div>\n+ </div>\n+ </header>\n+ <main class=\"container\">\n+ <h1>Средства для ухода</h1>\n+ <nav class=\"breadcrumbs\">\n+ <ul>\n+ <li>\n+ <a href=\"#\">Главная</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Магазин</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Средства для ухода</a>\n+ </li>\n+ </ul>\n+ </nav>\n+ <div class=\"manufacturer\">\n+ <h2>Производители:</h2>\n+ <form action=\"#\" method=\"post\">\n+ <input type=\"checkbox\" name=\"option1\" checked>Baxter of California<br>\n+ <input type=\"checkbox\" name=\"option2\" >Mr Natty<br>\n+ <input type=\"checkbox\" name=\"option3\" checked>Suavecito<br>\n+ <input type=\"checkbox\" name=\"option1\">Malin+Goetz<br>\n+ <input type=\"checkbox\" name=\"option1\">Murray's<br>\n+ <input type=\"checkbox\" name=\"option1\" checked>American Crew\n+ </form>\n+ </div>\n+ <div class=\"product-groups\">\n+ <h2>Производители:</h2>\n+ <form action=\"#\" method=\"post\">\n+ <input type=\"radio\" name=\"option1\">Бритвенные принадлежности<br>\n+ <input type=\"radio\" name=\"option2\" checked>Средства для ухода<br>\n+ <input type=\"radio\" name=\"option3\">Аксессуары<br>\n+ </form>\n+ </div>\n+ <a class=\"btn selection\" href=\"#\">Показать</a>\n+ <article id=\"\" class=\"product\"><!--id=\"\" на перспективу для подключения к базе данных товаров. Если не надо, уберу. (Вячеслав Корзун)-->\n+ <img src=\"img/Layer-47small.jpg\" alt=\"Набор для путешествий «Baxter of California»\" width=\"220\" height=\"165\"> <!--Изображения всё-таки вырезал. )) (Вячеслав Корзун)-->\n+ <h3 class=\"product-description\">Набор для путешествий<br>\n+ «Baxter of California»</h3>\n+ <p class=\"price\">2900 руб.</p>\n+ <a class=\"btn buy\" href=\"#\">Купить</a>\n+ </article>\n+ <article id=\"\" class=\"product\">\n+ <img src=\"img/Layer-30small.jpg\" alt=\"Увлажняющий кондиционер «Baxter of California»\" width=\"220\" height=\"165\">\n+ <h3 class=\"product-description\">Увлажняющий кондиционер<br>\n+ «Baxter of California»</h3>\n+ <p class=\"price\">750 руб.</p>\n+ <a class=\"btn buy\" href=\"#\">Купить</a>\n+ </article>\n+ <article id=\"\" class=\"product\">\n+ <img src=\"img/Layer-39small.jpg\" alt=\"Гель для волос «SUAVECITO»\" width=\"220\" height=\"165\">\n+ <h3 class=\"product-description\">Гель для волосй<br>\n+ «SUAVECITO»</h3>\n+ <p class=\"price\">290 руб.</p>\n+ <a class=\"btn buy\" href=\"#\">Купить</a>\n+ </article>\n+ <article id=\"\" class=\"product\">\n+ <img src=\"img/Layer-32small.jpg\" alt=\"Глина для укладки волос «AMERICAN CREW»\" width=\"220\" height=\"165\">\n+ <h3 class=\"product-description\">Глина для укладки волос<br>\n+ «American crew»</h3>\n+ <p class=\"price\">500 руб.</p>\n+ <a class=\"btn buy\" href=\"#\">Купить</a>\n+ </article>\n+ <article id=\"\" class=\"product\">\n+ <img src=\"img/Layer-33small.jpg\" alt=\"Гель для волос «AMERICAN CREW»\" width=\"220\" height=\"165\">\n+ <h3 class=\"product-description\">Гель для волос<br>\n+ «American crew»</h3>\n+ <p class=\"price\">300 руб.</p>\n+ <a class=\"btn buy\" href=\"#\">Купить</a>\n+ </article>\n+ <article id=\"\" class=\"product\">\n+ <img src=\"img/Layer-42small.jpg\" alt=\"Набор для бритья «Baxter of California»\" width=\"220\" height=\"165\">\n+ <h3 class=\"product-description\">Набор для бритья<br>\n+ «Baxter of California»</h3>\n+ <p class=\"price\">3900 руб.</p>\n+ <a class=\"btn buy\" href=\"#\">Купить</a>\n+ </article>\n+ <div class=\"catalog-page\">\n+ <a class=\"btn catalog-page-1\" href=\"#\">1</a>","path":"catalog.html","position":113,"original_position":113,"commit_id":"ad5b27528f5073a4bbecdd1d351f3fc2aeab39ad","original_commit_id":"ad5b27528f5073a4bbecdd1d351f3fc2aeab39ad","user":{"login":"GoshaEgorian","id":8870929,"avatar_url":"https://avatars.githubusercontent.com/u/8870929?v=3","gravatar_id":"","url":"https://api.github.com/users/GoshaEgorian","html_url":"https://github.com/GoshaEgorian","followers_url":"https://api.github.com/users/GoshaEgorian/followers","following_url":"https://api.github.com/users/GoshaEgorian/following{/other_user}","gists_url":"https://api.github.com/users/GoshaEgorian/gists{/gist_id}","starred_url":"https://api.github.com/users/GoshaEgorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoshaEgorian/subscriptions","organizations_url":"https://api.github.com/users/GoshaEgorian/orgs","repos_url":"https://api.github.com/users/GoshaEgorian/repos","events_url":"https://api.github.com/users/GoshaEgorian/events{/privacy}","received_events_url":"https://api.github.com/users/GoshaEgorian/received_events","type":"User","site_admin":false},"body":"Аналогично хлебным крошкам, такие блоки обычно называют \"paginator\", переименуй, пожалуйста.","created_at":"2017-01-23T20:27:50Z","updated_at":"2017-01-23T20:28:55Z","html_url":"https://github.com/htmlacademy-htmlcss/240581-barbershop/pull/1#discussion_r97408133","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/comments/97408133"},"html":{"href":"https://github.com/htmlacademy-htmlcss/240581-barbershop/pull/1#discussion_r97408133"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/1","id":102592208,"html_url":"https://github.com/htmlacademy-htmlcss/240581-barbershop/pull/1","diff_url":"https://github.com/htmlacademy-htmlcss/240581-barbershop/pull/1.diff","patch_url":"https://github.com/htmlacademy-htmlcss/240581-barbershop/pull/1.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/issues/1","number":1,"state":"open","locked":false,"title":"Разметка «Барбершопа»","user":{"login":"vya58","id":24439617,"avatar_url":"https://avatars.githubusercontent.com/u/24439617?v=3","gravatar_id":"","url":"https://api.github.com/users/vya58","html_url":"https://github.com/vya58","followers_url":"https://api.github.com/users/vya58/followers","following_url":"https://api.github.com/users/vya58/following{/other_user}","gists_url":"https://api.github.com/users/vya58/gists{/gist_id}","starred_url":"https://api.github.com/users/vya58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vya58/subscriptions","organizations_url":"https://api.github.com/users/vya58/orgs","repos_url":"https://api.github.com/users/vya58/repos","events_url":"https://api.github.com/users/vya58/events{/privacy}","received_events_url":"https://api.github.com/users/vya58/received_events","type":"User","site_admin":false},"body":"Разметка страниц:\r\n1) catalog.html.\r\n2) catalog-item.html\r\n3) barbershop-price.html\n\n---\n:mortar_board: [Разметка «Барбершопа»](https://up.htmlacademy.ru/htmlcss/16/user/240581/tasks/15)","created_at":"2017-01-21T18:49:51Z","updated_at":"2017-01-23T20:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d2562955664a008b4f430e6192d3aa732a0544b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/1/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/1/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/issues/1/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/statuses/ad5b27528f5073a4bbecdd1d351f3fc2aeab39ad","head":{"label":"vya58:master","ref":"master","sha":"ad5b27528f5073a4bbecdd1d351f3fc2aeab39ad","user":{"login":"vya58","id":24439617,"avatar_url":"https://avatars.githubusercontent.com/u/24439617?v=3","gravatar_id":"","url":"https://api.github.com/users/vya58","html_url":"https://github.com/vya58","followers_url":"https://api.github.com/users/vya58/followers","following_url":"https://api.github.com/users/vya58/following{/other_user}","gists_url":"https://api.github.com/users/vya58/gists{/gist_id}","starred_url":"https://api.github.com/users/vya58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vya58/subscriptions","organizations_url":"https://api.github.com/users/vya58/orgs","repos_url":"https://api.github.com/users/vya58/repos","events_url":"https://api.github.com/users/vya58/events{/privacy}","received_events_url":"https://api.github.com/users/vya58/received_events","type":"User","site_admin":false},"repo":{"id":79244800,"name":"240581-barbershop","full_name":"vya58/240581-barbershop","owner":{"login":"vya58","id":24439617,"avatar_url":"https://avatars.githubusercontent.com/u/24439617?v=3","gravatar_id":"","url":"https://api.github.com/users/vya58","html_url":"https://github.com/vya58","followers_url":"https://api.github.com/users/vya58/followers","following_url":"https://api.github.com/users/vya58/following{/other_user}","gists_url":"https://api.github.com/users/vya58/gists{/gist_id}","starred_url":"https://api.github.com/users/vya58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vya58/subscriptions","organizations_url":"https://api.github.com/users/vya58/orgs","repos_url":"https://api.github.com/users/vya58/repos","events_url":"https://api.github.com/users/vya58/events{/privacy}","received_events_url":"https://api.github.com/users/vya58/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vya58/240581-barbershop","description":"Вячеслав Корзун","fork":true,"url":"https://api.github.com/repos/vya58/240581-barbershop","forks_url":"https://api.github.com/repos/vya58/240581-barbershop/forks","keys_url":"https://api.github.com/repos/vya58/240581-barbershop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vya58/240581-barbershop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vya58/240581-barbershop/teams","hooks_url":"https://api.github.com/repos/vya58/240581-barbershop/hooks","issue_events_url":"https://api.github.com/repos/vya58/240581-barbershop/issues/events{/number}","events_url":"https://api.github.com/repos/vya58/240581-barbershop/events","assignees_url":"https://api.github.com/repos/vya58/240581-barbershop/assignees{/user}","branches_url":"https://api.github.com/repos/vya58/240581-barbershop/branches{/branch}","tags_url":"https://api.github.com/repos/vya58/240581-barbershop/tags","blobs_url":"https://api.github.com/repos/vya58/240581-barbershop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vya58/240581-barbershop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vya58/240581-barbershop/git/refs{/sha}","trees_url":"https://api.github.com/repos/vya58/240581-barbershop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vya58/240581-barbershop/statuses/{sha}","languages_url":"https://api.github.com/repos/vya58/240581-barbershop/languages","stargazers_url":"https://api.github.com/repos/vya58/240581-barbershop/stargazers","contributors_url":"https://api.github.com/repos/vya58/240581-barbershop/contributors","subscribers_url":"https://api.github.com/repos/vya58/240581-barbershop/subscribers","subscription_url":"https://api.github.com/repos/vya58/240581-barbershop/subscription","commits_url":"https://api.github.com/repos/vya58/240581-barbershop/commits{/sha}","git_commits_url":"https://api.github.com/repos/vya58/240581-barbershop/git/commits{/sha}","comments_url":"https://api.github.com/repos/vya58/240581-barbershop/comments{/number}","issue_comment_url":"https://api.github.com/repos/vya58/240581-barbershop/issues/comments{/number}","contents_url":"https://api.github.com/repos/vya58/240581-barbershop/contents/{+path}","compare_url":"https://api.github.com/repos/vya58/240581-barbershop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vya58/240581-barbershop/merges","archive_url":"https://api.github.com/repos/vya58/240581-barbershop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vya58/240581-barbershop/downloads","issues_url":"https://api.github.com/repos/vya58/240581-barbershop/issues{/number}","pulls_url":"https://api.github.com/repos/vya58/240581-barbershop/pulls{/number}","milestones_url":"https://api.github.com/repos/vya58/240581-barbershop/milestones{/number}","notifications_url":"https://api.github.com/repos/vya58/240581-barbershop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vya58/240581-barbershop/labels{/name}","releases_url":"https://api.github.com/repos/vya58/240581-barbershop/releases{/id}","deployments_url":"https://api.github.com/repos/vya58/240581-barbershop/deployments","created_at":"2017-01-17T16:02:51Z","updated_at":"2017-01-17T16:02:53Z","pushed_at":"2017-01-22T10:34:55Z","git_url":"git://github.com/vya58/240581-barbershop.git","ssh_url":"[email protected]:vya58/240581-barbershop.git","clone_url":"https://github.com/vya58/240581-barbershop.git","svn_url":"https://github.com/vya58/240581-barbershop","homepage":null,"size":227,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"a3febc70da790a0196ec727e1f174a7996bcbffc","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars.githubusercontent.com/u/16576942?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":79244190,"name":"240581-barbershop","full_name":"htmlacademy-htmlcss/240581-barbershop","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars.githubusercontent.com/u/16576942?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/240581-barbershop","description":"Вячеслав Корзун","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/deployments","created_at":"2017-01-17T15:56:11Z","updated_at":"2017-01-21T18:50:26Z","pushed_at":"2017-01-22T10:34:56Z","git_url":"git://github.com/htmlacademy-htmlcss/240581-barbershop.git","ssh_url":"[email protected]:htmlacademy-htmlcss/240581-barbershop.git","clone_url":"https://github.com/htmlacademy-htmlcss/240581-barbershop.git","svn_url":"https://github.com/htmlacademy-htmlcss/240581-barbershop","homepage":"https://github.com/vya58/240581-barbershop","size":5,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/1"},"html":{"href":"https://github.com/htmlacademy-htmlcss/240581-barbershop/pull/1"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/issues/1"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop/statuses/ad5b27528f5073a4bbecdd1d351f3fc2aeab39ad"}}}} | {
"id": 79244190,
"name": "htmlacademy-htmlcss/240581-barbershop",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/240581-barbershop"
} | {
"id": 8870929,
"login": "GoshaEgorian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8870929?",
"url": "https://api.github.com/users/GoshaEgorian"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-01-23T20:27:50 | 5199294814 | {"actor":{"display_login":"GoshaEgorian"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/comments/97877983","pull_request_review_id":18502234,"id":97877983,"diff_hunk":"@@ -0,0 +1,156 @@\n+<!DOCTYPE html>\n+<html lang=\"ru\">\n+ <head>\n+ <meta charset=\"utf-8\">\n+ <title>Барбершоп «Бородинский»</title>\n+ </head>\n+ <body>\n+ <header class=\"main-header\">\n+ <div class=\"container\">\n+ <a class=\"header-logo\"></a>\n+ <nav>\n+ <ul>\n+ <li>\n+ <a href=\"#\">Информация</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Новости</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Прайс-лист</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Магазин</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Контакты</a>\n+ </li>\n+ \n+ </ul>\n+ </nav>\n+ <div class=\"user-block\">\n+ <a class=\"login\" href=\"#\">Вход</a>\n+ </div>\n+ </div> \n+ </header>\n+ <main class=\"container\">\n+ <h1>Средства для ухода</h1>\n+ <div class=\"breadcrumbs\">\n+ <ul>\n+ <li>Главная</li>\n+ <li>Магазин</li>\n+ <li>Средства для ухода</li>\n+ </ul>\n+ </div>\n+ <div class=\"left-section\">\n+ <form class=\"filter\" action=\"#\" method=\"post\">\n+ <fieldset class=\"brands\">\n+ <legend>Производители</legend>\n+ <input type=\"checkbox\" name=\"brand-1\"><label for=\"brand-1\">Baxter of California</label>\n+ <input type=\"checkbox\" name=\"brand-2\"><label for=\"brand-2\">Mr Natty</label>\n+ <input type=\"checkbox\" name=\"brand-3\"><label for=\"brand-3\">Suavecito</label>\n+ <input type=\"checkbox\" name=\"brand-4\"><label for=\"brand-4\">Malin+Goetz</label>\n+ <input type=\"checkbox\" name=\"brand-5\"><label for=\"brand-5\">Murray’s</label>\n+ <input type=\"checkbox\" name=\"brand-6\"><label for=\"brand-6\">American Crew</label>\n+ </fieldset>\n+ <fieldset class=\"groups\">\n+ <input type=\"radio\" name=\"group-1\"><label for=\"group-1\">Бритвенные принадлежности</label>\n+ <input type=\"radio\" name=\"group-2\"><label for=\"group-2\">Средства для ухода</label>\n+ <input type=\"radio\" name=\"group-3\"><label for=\"group-3\">Аксессуары</label>\n+ <input type=\"submit\" value=\"Показать\" class=\"view-button\">\n+ </fieldset>\n+ <input type=\"submit\" value=\"Показать\" class=\"view-button\">\n+ </form>\n+ </div>\n+ <div class=\"right-section\">\n+ <article class=\"item\">\n+ <figure class=\"item-content\">\n+ <img src=\"#\" width=\"220\" height=\"165\" alt=\"Фото товара\">","path":"home work/catalog.html","position":68,"original_position":68,"commit_id":"5a70d3b779eecfd479a14d7db776d4e5ce7d800f","original_commit_id":"5a70d3b779eecfd479a14d7db776d4e5ce7d800f","user":{"login":"poymanov","id":13321928,"avatar_url":"https://avatars.githubusercontent.com/u/13321928?v=3","gravatar_id":"","url":"https://api.github.com/users/poymanov","html_url":"https://github.com/poymanov","followers_url":"https://api.github.com/users/poymanov/followers","following_url":"https://api.github.com/users/poymanov/following{/other_user}","gists_url":"https://api.github.com/users/poymanov/gists{/gist_id}","starred_url":"https://api.github.com/users/poymanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poymanov/subscriptions","organizations_url":"https://api.github.com/users/poymanov/orgs","repos_url":"https://api.github.com/users/poymanov/repos","events_url":"https://api.github.com/users/poymanov/events{/privacy}","received_events_url":"https://api.github.com/users/poymanov/received_events","type":"User","site_admin":false},"body":"Картинку лучше обернуть в блок и в ссылку. Потому что по логике при клике на картинку мы переходим в карточку товара.","created_at":"2017-01-25T21:05:50Z","updated_at":"2017-01-25T21:05:50Z","html_url":"https://github.com/htmlacademy-htmlcss/124218-barbershop/pull/1#discussion_r97877983","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/comments/97877983"},"html":{"href":"https://github.com/htmlacademy-htmlcss/124218-barbershop/pull/1#discussion_r97877983"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/1","id":103191023,"html_url":"https://github.com/htmlacademy-htmlcss/124218-barbershop/pull/1","diff_url":"https://github.com/htmlacademy-htmlcss/124218-barbershop/pull/1.diff","patch_url":"https://github.com/htmlacademy-htmlcss/124218-barbershop/pull/1.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/issues/1","number":1,"state":"open","locked":false,"title":"Разметка «Барбершопа»","user":{"login":"max4eh0v","id":25248227,"avatar_url":"https://avatars.githubusercontent.com/u/25248227?v=3","gravatar_id":"","url":"https://api.github.com/users/max4eh0v","html_url":"https://github.com/max4eh0v","followers_url":"https://api.github.com/users/max4eh0v/followers","following_url":"https://api.github.com/users/max4eh0v/following{/other_user}","gists_url":"https://api.github.com/users/max4eh0v/gists{/gist_id}","starred_url":"https://api.github.com/users/max4eh0v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max4eh0v/subscriptions","organizations_url":"https://api.github.com/users/max4eh0v/orgs","repos_url":"https://api.github.com/users/max4eh0v/repos","events_url":"https://api.github.com/users/max4eh0v/events{/privacy}","received_events_url":"https://api.github.com/users/max4eh0v/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Разметка «Барбершопа»](https://up.htmlacademy.ru/htmlcss/16/user/124218/tasks/15)","created_at":"2017-01-25T19:52:24Z","updated_at":"2017-01-25T21:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8393fbd703ab5c4e6d9b79c3c0a3267bbc517e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/1/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/1/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/issues/1/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/statuses/5a70d3b779eecfd479a14d7db776d4e5ce7d800f","head":{"label":"max4eh0v:master","ref":"master","sha":"5a70d3b779eecfd479a14d7db776d4e5ce7d800f","user":{"login":"max4eh0v","id":25248227,"avatar_url":"https://avatars.githubusercontent.com/u/25248227?v=3","gravatar_id":"","url":"https://api.github.com/users/max4eh0v","html_url":"https://github.com/max4eh0v","followers_url":"https://api.github.com/users/max4eh0v/followers","following_url":"https://api.github.com/users/max4eh0v/following{/other_user}","gists_url":"https://api.github.com/users/max4eh0v/gists{/gist_id}","starred_url":"https://api.github.com/users/max4eh0v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max4eh0v/subscriptions","organizations_url":"https://api.github.com/users/max4eh0v/orgs","repos_url":"https://api.github.com/users/max4eh0v/repos","events_url":"https://api.github.com/users/max4eh0v/events{/privacy}","received_events_url":"https://api.github.com/users/max4eh0v/received_events","type":"User","site_admin":false},"repo":{"id":79569322,"name":"124218-barbershop","full_name":"max4eh0v/124218-barbershop","owner":{"login":"max4eh0v","id":25248227,"avatar_url":"https://avatars.githubusercontent.com/u/25248227?v=3","gravatar_id":"","url":"https://api.github.com/users/max4eh0v","html_url":"https://github.com/max4eh0v","followers_url":"https://api.github.com/users/max4eh0v/followers","following_url":"https://api.github.com/users/max4eh0v/following{/other_user}","gists_url":"https://api.github.com/users/max4eh0v/gists{/gist_id}","starred_url":"https://api.github.com/users/max4eh0v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max4eh0v/subscriptions","organizations_url":"https://api.github.com/users/max4eh0v/orgs","repos_url":"https://api.github.com/users/max4eh0v/repos","events_url":"https://api.github.com/users/max4eh0v/events{/privacy}","received_events_url":"https://api.github.com/users/max4eh0v/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/max4eh0v/124218-barbershop","description":"Максим Яций","fork":true,"url":"https://api.github.com/repos/max4eh0v/124218-barbershop","forks_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/forks","keys_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/teams","hooks_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/hooks","issue_events_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/issues/events{/number}","events_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/events","assignees_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/assignees{/user}","branches_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/branches{/branch}","tags_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/tags","blobs_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/git/refs{/sha}","trees_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/statuses/{sha}","languages_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/languages","stargazers_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/stargazers","contributors_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/contributors","subscribers_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/subscribers","subscription_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/subscription","commits_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/commits{/sha}","git_commits_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/git/commits{/sha}","comments_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/comments{/number}","issue_comment_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/issues/comments{/number}","contents_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/contents/{+path}","compare_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/merges","archive_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/downloads","issues_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/issues{/number}","pulls_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/pulls{/number}","milestones_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/milestones{/number}","notifications_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/labels{/name}","releases_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/releases{/id}","deployments_url":"https://api.github.com/repos/max4eh0v/124218-barbershop/deployments","created_at":"2017-01-20T15:12:22Z","updated_at":"2017-01-20T15:12:24Z","pushed_at":"2017-01-25T19:51:32Z","git_url":"git://github.com/max4eh0v/124218-barbershop.git","ssh_url":"[email protected]:max4eh0v/124218-barbershop.git","clone_url":"https://github.com/max4eh0v/124218-barbershop.git","svn_url":"https://github.com/max4eh0v/124218-barbershop","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"e3d9bdbe60e9f260cb0b0e59420105c1a0da9466","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars.githubusercontent.com/u/16576942?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":79569274,"name":"124218-barbershop","full_name":"htmlacademy-htmlcss/124218-barbershop","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars.githubusercontent.com/u/16576942?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/124218-barbershop","description":"Максим Яций","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/deployments","created_at":"2017-01-20T15:11:56Z","updated_at":"2017-01-25T19:52:35Z","pushed_at":"2017-01-25T19:52:24Z","git_url":"git://github.com/htmlacademy-htmlcss/124218-barbershop.git","ssh_url":"[email protected]:htmlacademy-htmlcss/124218-barbershop.git","clone_url":"https://github.com/htmlacademy-htmlcss/124218-barbershop.git","svn_url":"https://github.com/htmlacademy-htmlcss/124218-barbershop","homepage":"https://github.com/max4eh0v/124218-barbershop","size":5,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/1"},"html":{"href":"https://github.com/htmlacademy-htmlcss/124218-barbershop/pull/1"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/issues/1"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop/statuses/5a70d3b779eecfd479a14d7db776d4e5ce7d800f"}}}} | {
"id": 79569274,
"name": "htmlacademy-htmlcss/124218-barbershop",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/124218-barbershop"
} | {
"id": 13321928,
"login": "poymanov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13321928?",
"url": "https://api.github.com/users/poymanov"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-01-25T21:05:50 | 5213556519 | {"actor":{"display_login":"poymanov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/comments/132944414","pull_request_review_id":56068526,"id":132944414,"diff_hunk":"@@ -0,0 +1,134 @@\n+<!DOCTYPE html>\n+<html>\n+ <head>\n+ <meta charset=\"utf-8\">\n+ <title>HTML Academy: Седона</title>\n+ </head>\n+ <body>\n+ <header class=\"main-header\">\n+ <a class=\"main-header-logo\" href=\"index.html\">\n+ <img class=\"img-logo\" src=\"img/logo.svg\" width=\"\" height=\"\" alt=\"Логотип Седона\">\n+ </a> \n+ <nav class=\"main-navigation\">\n+ <ul class=\"site-navigation\">\n+ <li>\n+ <a href=\"#\" title=\"Информация\">Информация</a>\n+ </li>\n+ <li>\n+ <a href=\"#\" title=\"Фото и видео\">Фото и видео</a>\n+ </li>\n+ <li>\n+ <a href=\"#\" title=\"Карта штата\">Карта штата</a>\n+ </li>\n+ <li>\n+ <a href=\"#\" title=\"Гостиницы\">Гостиницы</a>\n+ </li>\n+ </ul>\n+ </nav>\n+ </header>\n+ <main>\n+ <section class=\"hotel-parameters\">\n+ <h1 class visully-hidden>Параметры гостинцы</h1>\n+ <form class=\"filter\" method=\"get\" action=\"https://echo.htmlacademy.ru\">\n+ <fieldset>\n+ <legend>Инфраструктура:</legend>\n+ <ul class=\"infrastructure\">\n+ <li class=\"filter-option\">\n+ <input class=\"visually-hidden filter-input filter-input-checkbox\" type=\"checkbox\" name=\"swimmingpool\" checked> \n+ Бассейн\n+ </li>\n+ <li class=\"filter-option\">\n+ <input class=\"visually-hidden filter-input filter-input-checkbox\" type=\"checkbox\" name=\"parking\"> \n+ Парковка\n+ </li>\n+ <li class=\"filter-option\">\n+ <input class=\"visually-hidden filter-input filter-input-checkbox\" type=\"checkbox\" name=\"wifi\"> \n+ Wi-fi\n+ </li>\n+ </ul>\n+ </fieldset>\n+ <fieldset>\n+ <legend>Тип жилья:</legend>\n+ <ul class=\"home-type\">\n+ <li class=\"filter-option\">\n+ <input class=\"visually-hidden filter-input filter-input-checkbox\" type=\"checkbox\" name=\"hotel\" checked> \n+ Гостиница\n+ </li>\n+ <li class=\"filter-option\">\n+ <input class=\"visually-hidden filter-input filter-input-checkbox\" type=\"checkbox\" name=\"motel\" checked> \n+ Мотель\n+ </li>\n+ <li class=\"filter-option\">\n+ <input class=\"visually-hidden filter-input filter-input-checkbox\" type=\"checkbox\" name=\"apartments\" checked> \n+ Апартаменты\n+ </li>\n+ </ul>\n+ </fieldset>\n+ </form>\n+ <div class=\"price\">\n+ <label for=\"price\">Стоимость в сутки(Р):</label>\n+ <span class=\"price-range\">От 0</span>\n+ <span class=\"price-range\">До 3000</span>\n+ <input type=\"range\" id=\"price\" name=\"price\" min=\"0\" max=\"3000\" step=\"500\">\n+ </div>\n+ <div class=\"buttons\">\n+ <input type=\"submit\" value=\"Показать\">\n+ </div>\n+ </section>\n+ <section class=\"hotel-options\">\n+ <h2>Найдено:3</h2>\n+ <div class=\"hotel-sorting\">\n+ <p>Сортировка:</p>\n+ <span class=\"sort\" rel=\"price\">По цене</span>\n+ <span class=\"sort\" rel=\"type\">По типу</span>\n+ <span class=\"sort\" rel=\"rating\">По рейтингу</span>\n+ <ul class=\"hotel-options-table\">\n+ <li class=\"hotel-options-item\">\n+ <img src=\"img/amara-resort.svg\" width=\"\" height=\"\" alt=\"Фото Amara Resort\">\n+ <h2>Amara Resort & Spa</h2>\n+ <span class=\"type\">Гостиница</span>\n+ <span class=\"price\">от 3500 Р.</span>\n+ <a class=\"button-more\" href=\"#\">Подробнее</a>","path":"hotels.html","position":91,"original_position":91,"commit_id":"7217867c0e88dbb2d8b5834917e0e1ee1ff1ce73","original_commit_id":"7217867c0e88dbb2d8b5834917e0e1ee1ff1ce73","user":{"login":"anplitova","id":16723477,"avatar_url":"https://avatars3.githubusercontent.com/u/16723477?v=4","gravatar_id":"","url":"https://api.github.com/users/anplitova","html_url":"https://github.com/anplitova","followers_url":"https://api.github.com/users/anplitova/followers","following_url":"https://api.github.com/users/anplitova/following{/other_user}","gists_url":"https://api.github.com/users/anplitova/gists{/gist_id}","starred_url":"https://api.github.com/users/anplitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anplitova/subscriptions","organizations_url":"https://api.github.com/users/anplitova/orgs","repos_url":"https://api.github.com/users/anplitova/repos","events_url":"https://api.github.com/users/anplitova/events{/privacy}","received_events_url":"https://api.github.com/users/anplitova/received_events","type":"User","site_admin":false},"body":"Ссылки отличаются только цветом, сделай два класса общий для одинаковых свойств, второй для отметки цвета.","created_at":"2017-08-14T13:02:27Z","updated_at":"2017-08-14T13:38:35Z","html_url":"https://github.com/htmlacademy-htmlcss/448513-sedona/pull/2#discussion_r132944414","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/comments/132944414"},"html":{"href":"https://github.com/htmlacademy-htmlcss/448513-sedona/pull/2#discussion_r132944414"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/2","id":135468381,"html_url":"https://github.com/htmlacademy-htmlcss/448513-sedona/pull/2","diff_url":"https://github.com/htmlacademy-htmlcss/448513-sedona/pull/2.diff","patch_url":"https://github.com/htmlacademy-htmlcss/448513-sedona/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/issues/2","number":2,"state":"open","locked":false,"title":"Разметка личного проекта","user":{"login":"LenaGleb","id":20544604,"avatar_url":"https://avatars3.githubusercontent.com/u/20544604?v=4","gravatar_id":"","url":"https://api.github.com/users/LenaGleb","html_url":"https://github.com/LenaGleb","followers_url":"https://api.github.com/users/LenaGleb/followers","following_url":"https://api.github.com/users/LenaGleb/following{/other_user}","gists_url":"https://api.github.com/users/LenaGleb/gists{/gist_id}","starred_url":"https://api.github.com/users/LenaGleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LenaGleb/subscriptions","organizations_url":"https://api.github.com/users/LenaGleb/orgs","repos_url":"https://api.github.com/users/LenaGleb/repos","events_url":"https://api.github.com/users/LenaGleb/events{/privacy}","received_events_url":"https://api.github.com/users/LenaGleb/received_events","type":"User","site_admin":false},"body":"Попытка №1:)\n\n---\n:mortar_board: [Разметка личного проекта](https://up.htmlacademy.ru/htmlcss/18/user/448513/tasks/16)","created_at":"2017-08-12T18:20:13Z","updated_at":"2017-08-14T13:38:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b17851b1044795dbe810abf4138efb16d1e9c62f","assignee":{"login":"anplitova","id":16723477,"avatar_url":"https://avatars3.githubusercontent.com/u/16723477?v=4","gravatar_id":"","url":"https://api.github.com/users/anplitova","html_url":"https://github.com/anplitova","followers_url":"https://api.github.com/users/anplitova/followers","following_url":"https://api.github.com/users/anplitova/following{/other_user}","gists_url":"https://api.github.com/users/anplitova/gists{/gist_id}","starred_url":"https://api.github.com/users/anplitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anplitova/subscriptions","organizations_url":"https://api.github.com/users/anplitova/orgs","repos_url":"https://api.github.com/users/anplitova/repos","events_url":"https://api.github.com/users/anplitova/events{/privacy}","received_events_url":"https://api.github.com/users/anplitova/received_events","type":"User","site_admin":false},"assignees":[{"login":"anplitova","id":16723477,"avatar_url":"https://avatars3.githubusercontent.com/u/16723477?v=4","gravatar_id":"","url":"https://api.github.com/users/anplitova","html_url":"https://github.com/anplitova","followers_url":"https://api.github.com/users/anplitova/followers","following_url":"https://api.github.com/users/anplitova/following{/other_user}","gists_url":"https://api.github.com/users/anplitova/gists{/gist_id}","starred_url":"https://api.github.com/users/anplitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anplitova/subscriptions","organizations_url":"https://api.github.com/users/anplitova/orgs","repos_url":"https://api.github.com/users/anplitova/repos","events_url":"https://api.github.com/users/anplitova/events{/privacy}","received_events_url":"https://api.github.com/users/anplitova/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/statuses/7217867c0e88dbb2d8b5834917e0e1ee1ff1ce73","head":{"label":"LenaGleb:master","ref":"master","sha":"7217867c0e88dbb2d8b5834917e0e1ee1ff1ce73","user":{"login":"LenaGleb","id":20544604,"avatar_url":"https://avatars3.githubusercontent.com/u/20544604?v=4","gravatar_id":"","url":"https://api.github.com/users/LenaGleb","html_url":"https://github.com/LenaGleb","followers_url":"https://api.github.com/users/LenaGleb/followers","following_url":"https://api.github.com/users/LenaGleb/following{/other_user}","gists_url":"https://api.github.com/users/LenaGleb/gists{/gist_id}","starred_url":"https://api.github.com/users/LenaGleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LenaGleb/subscriptions","organizations_url":"https://api.github.com/users/LenaGleb/orgs","repos_url":"https://api.github.com/users/LenaGleb/repos","events_url":"https://api.github.com/users/LenaGleb/events{/privacy}","received_events_url":"https://api.github.com/users/LenaGleb/received_events","type":"User","site_admin":false},"repo":{"id":99712415,"name":"448513-sedona","full_name":"LenaGleb/448513-sedona","owner":{"login":"LenaGleb","id":20544604,"avatar_url":"https://avatars3.githubusercontent.com/u/20544604?v=4","gravatar_id":"","url":"https://api.github.com/users/LenaGleb","html_url":"https://github.com/LenaGleb","followers_url":"https://api.github.com/users/LenaGleb/followers","following_url":"https://api.github.com/users/LenaGleb/following{/other_user}","gists_url":"https://api.github.com/users/LenaGleb/gists{/gist_id}","starred_url":"https://api.github.com/users/LenaGleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LenaGleb/subscriptions","organizations_url":"https://api.github.com/users/LenaGleb/orgs","repos_url":"https://api.github.com/users/LenaGleb/repos","events_url":"https://api.github.com/users/LenaGleb/events{/privacy}","received_events_url":"https://api.github.com/users/LenaGleb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LenaGleb/448513-sedona","description":"Elena Glebkovskaya","fork":true,"url":"https://api.github.com/repos/LenaGleb/448513-sedona","forks_url":"https://api.github.com/repos/LenaGleb/448513-sedona/forks","keys_url":"https://api.github.com/repos/LenaGleb/448513-sedona/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LenaGleb/448513-sedona/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LenaGleb/448513-sedona/teams","hooks_url":"https://api.github.com/repos/LenaGleb/448513-sedona/hooks","issue_events_url":"https://api.github.com/repos/LenaGleb/448513-sedona/issues/events{/number}","events_url":"https://api.github.com/repos/LenaGleb/448513-sedona/events","assignees_url":"https://api.github.com/repos/LenaGleb/448513-sedona/assignees{/user}","branches_url":"https://api.github.com/repos/LenaGleb/448513-sedona/branches{/branch}","tags_url":"https://api.github.com/repos/LenaGleb/448513-sedona/tags","blobs_url":"https://api.github.com/repos/LenaGleb/448513-sedona/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LenaGleb/448513-sedona/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LenaGleb/448513-sedona/git/refs{/sha}","trees_url":"https://api.github.com/repos/LenaGleb/448513-sedona/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LenaGleb/448513-sedona/statuses/{sha}","languages_url":"https://api.github.com/repos/LenaGleb/448513-sedona/languages","stargazers_url":"https://api.github.com/repos/LenaGleb/448513-sedona/stargazers","contributors_url":"https://api.github.com/repos/LenaGleb/448513-sedona/contributors","subscribers_url":"https://api.github.com/repos/LenaGleb/448513-sedona/subscribers","subscription_url":"https://api.github.com/repos/LenaGleb/448513-sedona/subscription","commits_url":"https://api.github.com/repos/LenaGleb/448513-sedona/commits{/sha}","git_commits_url":"https://api.github.com/repos/LenaGleb/448513-sedona/git/commits{/sha}","comments_url":"https://api.github.com/repos/LenaGleb/448513-sedona/comments{/number}","issue_comment_url":"https://api.github.com/repos/LenaGleb/448513-sedona/issues/comments{/number}","contents_url":"https://api.github.com/repos/LenaGleb/448513-sedona/contents/{+path}","compare_url":"https://api.github.com/repos/LenaGleb/448513-sedona/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LenaGleb/448513-sedona/merges","archive_url":"https://api.github.com/repos/LenaGleb/448513-sedona/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LenaGleb/448513-sedona/downloads","issues_url":"https://api.github.com/repos/LenaGleb/448513-sedona/issues{/number}","pulls_url":"https://api.github.com/repos/LenaGleb/448513-sedona/pulls{/number}","milestones_url":"https://api.github.com/repos/LenaGleb/448513-sedona/milestones{/number}","notifications_url":"https://api.github.com/repos/LenaGleb/448513-sedona/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LenaGleb/448513-sedona/labels{/name}","releases_url":"https://api.github.com/repos/LenaGleb/448513-sedona/releases{/id}","deployments_url":"https://api.github.com/repos/LenaGleb/448513-sedona/deployments","created_at":"2017-08-08T16:14:16Z","updated_at":"2017-08-08T16:14:18Z","pushed_at":"2017-08-13T14:34:14Z","git_url":"git://github.com/LenaGleb/448513-sedona.git","ssh_url":"[email protected]:LenaGleb/448513-sedona.git","clone_url":"https://github.com/LenaGleb/448513-sedona.git","svn_url":"https://github.com/LenaGleb/448513-sedona","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"7c6979eb89cc3fdabba14ecdc289a37f4e411e9f","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":99611779,"name":"448513-sedona","full_name":"htmlacademy-htmlcss/448513-sedona","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/448513-sedona","description":"Elena Glebkovskaya","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/deployments","created_at":"2017-08-07T19:18:57Z","updated_at":"2017-08-08T16:34:01Z","pushed_at":"2017-08-13T14:34:16Z","git_url":"git://github.com/htmlacademy-htmlcss/448513-sedona.git","ssh_url":"[email protected]:htmlacademy-htmlcss/448513-sedona.git","clone_url":"https://github.com/htmlacademy-htmlcss/448513-sedona.git","svn_url":"https://github.com/htmlacademy-htmlcss/448513-sedona","homepage":"https://github.com/LenaGleb/448513-sedona","size":4,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/2"},"html":{"href":"https://github.com/htmlacademy-htmlcss/448513-sedona/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona/statuses/7217867c0e88dbb2d8b5834917e0e1ee1ff1ce73"}}}} | {
"id": 99611779,
"name": "htmlacademy-htmlcss/448513-sedona",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/448513-sedona"
} | {
"id": 16723477,
"login": "anplitova",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16723477?",
"url": "https://api.github.com/users/anplitova"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-08-14T13:02:27 | 6448747157 | {"actor":{"display_login":"anplitova"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/comments/135597699","pull_request_review_id":59026497,"id":135597699,"diff_hunk":"@@ -1,18 +1,543 @@\n body {\n+ margin: 0;\n+ padding: 0;\n font-family: 'PT Sans', 'Arial', sans-serif;\n font-size: 14px;\n font-weight: bold;\n- line-height: 21px;\n+ line-height: 26px;\n+ color: #000000;\n+ text-transform: uppercase;\n+ background-color: #f1f1f1;\n+}\n+\n+a {\n+ text-decoration: none;\n+}\n+\n+.container {\n+ margin: 0 auto;\n+ width: 1200px;\n+ background-color: #ffffff;\n+}\n+\n+.main-nav {\n+ background-color: #ffffff;\n+}\n+\n+.main-nav-list {\n+ list-style: none;\n+}\n+\n+.main-nav-list a {\n color: #000000;\n-/* text-transform: uppercase; */\n }\n \n-.main-title {\n+.main-nav-list a:hover,\n+.main-nav-list a:focus {\n+ color: #81b3d2;\n+}\n+\n+.main-nav-list a:active {\n+ color: rgba(0, 0, 0, 0.3);\n+}\n+\n+.promo {\n+ background-image: url(/img/background.jpg);\n+/* background-position: top center; */\n+ background-repeat: no-repeat;\n+}\n+\n+.intro {\n+ text-align: center;\n+}\n+\n+.intro .main-title {\n font-size: 21px;\n- line-height: 26px;\n }\n \n-.search-title {\n+.intro p {\n+ font-weight: normal;\n+ color: #333333;\n+}\n+\n+.features-item {\n+ line-height: 21px;\n+ color: #ffffff;\n+ text-align: center;\n+ background-color: #81b3d2;\n+}\n+\n+.features-item .features-title {\n+ font-size: 21px;\n+}\n+\n+.features-item .features-num,\n+.features-item p {\n+ font-weight: normal;\n+}\n+\n+.features-item-light {\n+ background-color: #ffffff;\n+}\n+\n+.features-item-light .features-title,\n+.features-item-dark .features-title {\n+ color: #000000;\n+}\n+\n+.features-item-light p,\n+.features-item-dark p,\n+.features-item-dark .features-num {\n+ color: #333333;\n+}\n+\n+.features-item-dark {\n+ background-color: #eeeeee;\n+}\n+\n+.living-svg {\n+ background-color: transparent;\n+ width: 75px;\n+ height: 72px;\n+}\n+\n+.food-svg {\n+ background-color: transparent;\n+ width: 74px;\n+ height: 70px;\n+}\n+\n+.souvenirs-svg {\n+ background-color: transparent;\n+ width: 64px;\n+ height: 76px;\n+}\n+\n+.search {\n+ text-align: center;\n+}\n+\n+.search .search-title {\n font-size: 30px;\n line-height: 36px;\n }\n+\n+.search p {\n+ font-weight: normal;\n+ line-height: 24px;\n+ color: #333333;\n+}\n+\n+.search .search-btn {\n+ font-size: 21px;\n+ color: #ffffff;\n+ background-color: #766357;\n+}\n+\n+.search .search-btn:hover,\n+.search .search-btn:focus {\n+ background-color: #604e43;\n+}\n+\n+.search .search-btn:active {\n+ color: rgba(255, 255, 255, 0.3);\n+ background-color: #503e33;\n+}\n+\n+.search-form-item input {\n+ font: inherit;\n+ border: none;\n+ background-color: #f2f2f2;\n+}\n+\n+.search-form-item input:hover {\n+ background-color: #ebebeb;\n+ outline: none;\n+}\n+\n+.search-form-item input:focus {\n+ background-color: #ffffff;\n+ outline: 2px solid #e5e5e5;\n+}\n+\n+.search-form-btn {\n+ font: inherit;\n+ font-size: 21px;\n+ color: #ffffff;\n+ border: none;\n+ background-color: #81b3d2;\n+}\n+\n+.search-form-btn:hover,\n+.search-form-btn:focus {\n+ background-color: #669ec0;\n+}\n+\n+.search-form-btn:active {\n+ color: rgba(255, 255, 255, 0.3);\n+ background-color: #5496bd;\n+}\n+\n+.icon-calendar {\n+ border: none;\n+ background-color: transparent;\n+}\n+\n+.icon-calendar-svg {\n+ width: 21px;\n+ height: 22px;\n+ background-color: transparent;\n+ fill: #a9a9a9;\n+}\n+\n+.icon-calendar-svg:hover,\n+.icon-calendar-svg:focus {\n+ fill: #000000;\n+}\n+\n+.icon-calendar-svg:active {\n+ fill: #81b3d2;\n+}\n+\n+.icon-minus {\n+ width: 11px;\n+ height: 11px;\n+ border: none;\n+ background-color: #f2f2f2;\n+ background-image: url(/img/icon-minus.png);\n+ background-repeat: no-repeat;\n+ background-position: center center;\n+}\n+\n+.icon-plus {\n+ width: 11px;\n+ height: 11px;\n+ border: none;\n+ background-color: #f2f2f2;\n+ background-image: url(/img/icon-plus.png);\n+ background-repeat: no-repeat;\n+ background-position: center center;\n+}\n+\n+.footer-wrapper,\n+.page-footer {\n+ text-align: center;\n+ background-color: rgba(249, 251, 246, 0.9);\n+}\n+\n+.hashtag {\n+ font-size: 21px;\n+}\n+\n+.social ul {\n+ list-style: none;\n+}\n+\n+.social-btn {\n+ color: #ffffff;\n+ background-color: #81b3d2;\n+}\n+\n+.social-btn:hover,\n+.social-btn:focus {\n+ background-color: #669ec0;\n+}\n+\n+.social-btn:active {\n+ color: rgba(255, 255, 255, 0.3);\n+ background-color: #5496bd;\n+}\n+\n+.social-btn-tw {\n+ width: 17px;\n+ height: 15px;\n+ background-color: transparent;\n+ fill: #ffffff;\n+}\n+\n+.social-btn-fb {\n+ width: 12px;\n+ height: 22px;\n+ background-color: transparent;\n+ fill: #ffffff;\n+}\n+\n+.social-btn-yt {\n+ width: 20px;\n+ height: 16px;\n+ background-color: transparent;\n+ fill: #ffffff;\n+}\n+\n+.social-btn-tw:hover,\n+.social-btn-fb:hover,\n+.social-btn-yt:hover,\n+.social-btn-tw:focus,\n+.social-btn-fb:focus,\n+.social-btn-yt:focus {\n+ background-color: transparent;\n+ fill: #ffffff;\n+}\n+\n+.social-btn-tw:active,\n+.social-btn-fb:active,\n+.social-btn-yt:active {\n+ background-color: #5496bd;\n+ fill: rgba(255, 255, 255, 0.3);\n+}\n+\n+.copyright b {\n+ font-weight: normal;\n+}\n+\n+.htmlacademy-logo {\n+ width: 115px;\n+ height: 41px;\n+ background-color: transparent;\n+ fill: #231f20;\n+}\n+\n+.htmlacademy-logo:hover,\n+.htmlacademy-logo:focus {\n+ fill: #81b3d2;\n+}\n+\n+.htmlacademy-logo:active {\n+ fill: #bdbbbc;\n+}\n+\n+\n+\n+.nav-item-current a {\n+ color: #766357;\n+}\n+\n+.hotel-filter {\n+ background-image: url(/img/filter-background.jpg);\n+ background-repeat: no-repeat;\n+/* background-position: center center; */\n+}\n+\n+.hotel-filter-form {\n+ color: #ffffff;\n+ line-height: 21px;\n+}\n+\n+.hotel-filter-group {","path":"css/style.css","position":331,"original_position":331,"commit_id":"fe43dd3adcf457e56584dbb6461aaacec87a9a3d","original_commit_id":"fe43dd3adcf457e56584dbb6461aaacec87a9a3d","user":{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"body":".hotel-filter-group,\r\n.hotel-filter-price{}","created_at":"2017-08-28T18:28:02Z","updated_at":"2017-08-28T18:28:02Z","html_url":"https://github.com/htmlacademy-htmlcss/194706-sedona/pull/5#discussion_r135597699","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/comments/135597699"},"html":{"href":"https://github.com/htmlacademy-htmlcss/194706-sedona/pull/5#discussion_r135597699"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/5","id":137886138,"html_url":"https://github.com/htmlacademy-htmlcss/194706-sedona/pull/5","diff_url":"https://github.com/htmlacademy-htmlcss/194706-sedona/pull/5.diff","patch_url":"https://github.com/htmlacademy-htmlcss/194706-sedona/pull/5.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/issues/5","number":5,"state":"open","locked":false,"title":"Базовая стилизация личного проекта","user":{"login":"jonney8840","id":27193613,"avatar_url":"https://avatars1.githubusercontent.com/u/27193613?v=4","gravatar_id":"","url":"https://api.github.com/users/jonney8840","html_url":"https://github.com/jonney8840","followers_url":"https://api.github.com/users/jonney8840/followers","following_url":"https://api.github.com/users/jonney8840/following{/other_user}","gists_url":"https://api.github.com/users/jonney8840/gists{/gist_id}","starred_url":"https://api.github.com/users/jonney8840/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonney8840/subscriptions","organizations_url":"https://api.github.com/users/jonney8840/orgs","repos_url":"https://api.github.com/users/jonney8840/repos","events_url":"https://api.github.com/users/jonney8840/events{/privacy}","received_events_url":"https://api.github.com/users/jonney8840/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Базовая стилизация личного проекта](https://up.htmlacademy.ru/htmlcss/18/user/194706/tasks/35)\n\n:boom: https://htmlacademy-htmlcss.github.io/194706-sedona/5/","created_at":"2017-08-28T07:26:53Z","updated_at":"2017-08-28T18:28:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"843066a3fa6ae6b07cfa0e1afe9867e8946caf6e","assignee":{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/5/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/5/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/issues/5/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/statuses/fe43dd3adcf457e56584dbb6461aaacec87a9a3d","head":{"label":"jonney8840:master","ref":"master","sha":"fe43dd3adcf457e56584dbb6461aaacec87a9a3d","user":{"login":"jonney8840","id":27193613,"avatar_url":"https://avatars1.githubusercontent.com/u/27193613?v=4","gravatar_id":"","url":"https://api.github.com/users/jonney8840","html_url":"https://github.com/jonney8840","followers_url":"https://api.github.com/users/jonney8840/followers","following_url":"https://api.github.com/users/jonney8840/following{/other_user}","gists_url":"https://api.github.com/users/jonney8840/gists{/gist_id}","starred_url":"https://api.github.com/users/jonney8840/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonney8840/subscriptions","organizations_url":"https://api.github.com/users/jonney8840/orgs","repos_url":"https://api.github.com/users/jonney8840/repos","events_url":"https://api.github.com/users/jonney8840/events{/privacy}","received_events_url":"https://api.github.com/users/jonney8840/received_events","type":"User","site_admin":false},"repo":{"id":99651213,"name":"194706-sedona","full_name":"jonney8840/194706-sedona","owner":{"login":"jonney8840","id":27193613,"avatar_url":"https://avatars1.githubusercontent.com/u/27193613?v=4","gravatar_id":"","url":"https://api.github.com/users/jonney8840","html_url":"https://github.com/jonney8840","followers_url":"https://api.github.com/users/jonney8840/followers","following_url":"https://api.github.com/users/jonney8840/following{/other_user}","gists_url":"https://api.github.com/users/jonney8840/gists{/gist_id}","starred_url":"https://api.github.com/users/jonney8840/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonney8840/subscriptions","organizations_url":"https://api.github.com/users/jonney8840/orgs","repos_url":"https://api.github.com/users/jonney8840/repos","events_url":"https://api.github.com/users/jonney8840/events{/privacy}","received_events_url":"https://api.github.com/users/jonney8840/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonney8840/194706-sedona","description":"Yevgeniy Alishevets","fork":true,"url":"https://api.github.com/repos/jonney8840/194706-sedona","forks_url":"https://api.github.com/repos/jonney8840/194706-sedona/forks","keys_url":"https://api.github.com/repos/jonney8840/194706-sedona/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonney8840/194706-sedona/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonney8840/194706-sedona/teams","hooks_url":"https://api.github.com/repos/jonney8840/194706-sedona/hooks","issue_events_url":"https://api.github.com/repos/jonney8840/194706-sedona/issues/events{/number}","events_url":"https://api.github.com/repos/jonney8840/194706-sedona/events","assignees_url":"https://api.github.com/repos/jonney8840/194706-sedona/assignees{/user}","branches_url":"https://api.github.com/repos/jonney8840/194706-sedona/branches{/branch}","tags_url":"https://api.github.com/repos/jonney8840/194706-sedona/tags","blobs_url":"https://api.github.com/repos/jonney8840/194706-sedona/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonney8840/194706-sedona/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonney8840/194706-sedona/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonney8840/194706-sedona/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonney8840/194706-sedona/statuses/{sha}","languages_url":"https://api.github.com/repos/jonney8840/194706-sedona/languages","stargazers_url":"https://api.github.com/repos/jonney8840/194706-sedona/stargazers","contributors_url":"https://api.github.com/repos/jonney8840/194706-sedona/contributors","subscribers_url":"https://api.github.com/repos/jonney8840/194706-sedona/subscribers","subscription_url":"https://api.github.com/repos/jonney8840/194706-sedona/subscription","commits_url":"https://api.github.com/repos/jonney8840/194706-sedona/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonney8840/194706-sedona/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonney8840/194706-sedona/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonney8840/194706-sedona/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonney8840/194706-sedona/contents/{+path}","compare_url":"https://api.github.com/repos/jonney8840/194706-sedona/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonney8840/194706-sedona/merges","archive_url":"https://api.github.com/repos/jonney8840/194706-sedona/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonney8840/194706-sedona/downloads","issues_url":"https://api.github.com/repos/jonney8840/194706-sedona/issues{/number}","pulls_url":"https://api.github.com/repos/jonney8840/194706-sedona/pulls{/number}","milestones_url":"https://api.github.com/repos/jonney8840/194706-sedona/milestones{/number}","notifications_url":"https://api.github.com/repos/jonney8840/194706-sedona/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonney8840/194706-sedona/labels{/name}","releases_url":"https://api.github.com/repos/jonney8840/194706-sedona/releases{/id}","deployments_url":"https://api.github.com/repos/jonney8840/194706-sedona/deployments","created_at":"2017-08-08T04:49:00Z","updated_at":"2017-08-08T04:49:02Z","pushed_at":"2017-08-28T07:26:51Z","git_url":"git://github.com/jonney8840/194706-sedona.git","ssh_url":"[email protected]:jonney8840/194706-sedona.git","clone_url":"https://github.com/jonney8840/194706-sedona.git","svn_url":"https://github.com/jonney8840/194706-sedona","homepage":null,"size":462,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"8135d13d520341c3bbeafe50b2ef5e99f2d68ed2","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":99649826,"name":"194706-sedona","full_name":"htmlacademy-htmlcss/194706-sedona","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/194706-sedona","description":"Yevgeniy Alishevets","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/deployments","created_at":"2017-08-08T04:24:55Z","updated_at":"2017-08-08T05:36:05Z","pushed_at":"2017-08-28T13:59:29Z","git_url":"git://github.com/htmlacademy-htmlcss/194706-sedona.git","ssh_url":"[email protected]:htmlacademy-htmlcss/194706-sedona.git","clone_url":"https://github.com/htmlacademy-htmlcss/194706-sedona.git","svn_url":"https://github.com/htmlacademy-htmlcss/194706-sedona","homepage":"https://github.com/jonney8840/194706-sedona","size":457,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/5"},"html":{"href":"https://github.com/htmlacademy-htmlcss/194706-sedona/pull/5"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/issues/5"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona/statuses/fe43dd3adcf457e56584dbb6461aaacec87a9a3d"}}}} | {
"id": 99649826,
"name": "htmlacademy-htmlcss/194706-sedona",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/194706-sedona"
} | {
"id": 9842814,
"login": "sergeykravchenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9842814?",
"url": "https://api.github.com/users/sergeykravchenko"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-08-28T18:28:02 | 6520917572 | {"actor":{"display_login":"sergeykravchenko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/comments/151755035","pull_request_review_id":77519818,"id":151755035,"diff_hunk":"@@ -0,0 +1,603 @@\n+body {\n+\tmargin: 0;\n+\tpadding: 0;\n+\n+\tfont: normal 400 13px/24px \"PT Sans\", \"Calibri\", sans-serif;","path":"css/style.css","position":5,"original_position":5,"commit_id":"f03cb32789a896d212e8f871ff0ceb83298bfbf9","original_commit_id":"f03cb32789a896d212e8f871ff0ceb83298bfbf9","user":{"login":"ad-ovo","id":9592349,"avatar_url":"https://avatars2.githubusercontent.com/u/9592349?v=4","gravatar_id":"","url":"https://api.github.com/users/ad-ovo","html_url":"https://github.com/ad-ovo","followers_url":"https://api.github.com/users/ad-ovo/followers","following_url":"https://api.github.com/users/ad-ovo/following{/other_user}","gists_url":"https://api.github.com/users/ad-ovo/gists{/gist_id}","starred_url":"https://api.github.com/users/ad-ovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ad-ovo/subscriptions","organizations_url":"https://api.github.com/users/ad-ovo/orgs","repos_url":"https://api.github.com/users/ad-ovo/repos","events_url":"https://api.github.com/users/ad-ovo/events{/privacy}","received_events_url":"https://api.github.com/users/ad-ovo/received_events","type":"User","site_admin":false},"body":"ух, всегда последовательность для font путала :)\r\n\r\nкак и в случае с background-image/color/position/ и тд удобней прописывать все раздельно, тк читается проще, а правится в разы проще\r\n\r\nно можешь оставить и так, если хочешь","created_at":"2017-11-17T18:22:37Z","updated_at":"2017-11-17T18:22:37Z","html_url":"https://github.com/htmlacademy-htmlcss/173685-technomart/pull/5#discussion_r151755035","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/comments/151755035"},"html":{"href":"https://github.com/htmlacademy-htmlcss/173685-technomart/pull/5#discussion_r151755035"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/5","id":153122461,"html_url":"https://github.com/htmlacademy-htmlcss/173685-technomart/pull/5","diff_url":"https://github.com/htmlacademy-htmlcss/173685-technomart/pull/5.diff","patch_url":"https://github.com/htmlacademy-htmlcss/173685-technomart/pull/5.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/issues/5","number":5,"state":"open","locked":false,"title":"Базовая стилизация личного проекта","user":{"login":"kseveru","id":26481621,"avatar_url":"https://avatars1.githubusercontent.com/u/26481621?v=4","gravatar_id":"","url":"https://api.github.com/users/kseveru","html_url":"https://github.com/kseveru","followers_url":"https://api.github.com/users/kseveru/followers","following_url":"https://api.github.com/users/kseveru/following{/other_user}","gists_url":"https://api.github.com/users/kseveru/gists{/gist_id}","starred_url":"https://api.github.com/users/kseveru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kseveru/subscriptions","organizations_url":"https://api.github.com/users/kseveru/orgs","repos_url":"https://api.github.com/users/kseveru/repos","events_url":"https://api.github.com/users/kseveru/events{/privacy}","received_events_url":"https://api.github.com/users/kseveru/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Базовая стилизация личного проекта](https://up.htmlacademy.ru/htmlcss/19/user/173685/tasks/35)\n\n:boom: https://htmlacademy-htmlcss.github.io/173685-technomart/5/","created_at":"2017-11-16T18:57:35Z","updated_at":"2017-11-17T18:22:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"201348e9433eeee7ed440731ddac8c5cdc375c48","assignee":{"login":"ad-ovo","id":9592349,"avatar_url":"https://avatars2.githubusercontent.com/u/9592349?v=4","gravatar_id":"","url":"https://api.github.com/users/ad-ovo","html_url":"https://github.com/ad-ovo","followers_url":"https://api.github.com/users/ad-ovo/followers","following_url":"https://api.github.com/users/ad-ovo/following{/other_user}","gists_url":"https://api.github.com/users/ad-ovo/gists{/gist_id}","starred_url":"https://api.github.com/users/ad-ovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ad-ovo/subscriptions","organizations_url":"https://api.github.com/users/ad-ovo/orgs","repos_url":"https://api.github.com/users/ad-ovo/repos","events_url":"https://api.github.com/users/ad-ovo/events{/privacy}","received_events_url":"https://api.github.com/users/ad-ovo/received_events","type":"User","site_admin":false},"assignees":[{"login":"ad-ovo","id":9592349,"avatar_url":"https://avatars2.githubusercontent.com/u/9592349?v=4","gravatar_id":"","url":"https://api.github.com/users/ad-ovo","html_url":"https://github.com/ad-ovo","followers_url":"https://api.github.com/users/ad-ovo/followers","following_url":"https://api.github.com/users/ad-ovo/following{/other_user}","gists_url":"https://api.github.com/users/ad-ovo/gists{/gist_id}","starred_url":"https://api.github.com/users/ad-ovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ad-ovo/subscriptions","organizations_url":"https://api.github.com/users/ad-ovo/orgs","repos_url":"https://api.github.com/users/ad-ovo/repos","events_url":"https://api.github.com/users/ad-ovo/events{/privacy}","received_events_url":"https://api.github.com/users/ad-ovo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/5/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/5/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/issues/5/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/statuses/f03cb32789a896d212e8f871ff0ceb83298bfbf9","head":{"label":"kseveru:master","ref":"master","sha":"f03cb32789a896d212e8f871ff0ceb83298bfbf9","user":{"login":"kseveru","id":26481621,"avatar_url":"https://avatars1.githubusercontent.com/u/26481621?v=4","gravatar_id":"","url":"https://api.github.com/users/kseveru","html_url":"https://github.com/kseveru","followers_url":"https://api.github.com/users/kseveru/followers","following_url":"https://api.github.com/users/kseveru/following{/other_user}","gists_url":"https://api.github.com/users/kseveru/gists{/gist_id}","starred_url":"https://api.github.com/users/kseveru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kseveru/subscriptions","organizations_url":"https://api.github.com/users/kseveru/orgs","repos_url":"https://api.github.com/users/kseveru/repos","events_url":"https://api.github.com/users/kseveru/events{/privacy}","received_events_url":"https://api.github.com/users/kseveru/received_events","type":"User","site_admin":false},"repo":{"id":109135519,"name":"173685-technomart","full_name":"kseveru/173685-technomart","owner":{"login":"kseveru","id":26481621,"avatar_url":"https://avatars1.githubusercontent.com/u/26481621?v=4","gravatar_id":"","url":"https://api.github.com/users/kseveru","html_url":"https://github.com/kseveru","followers_url":"https://api.github.com/users/kseveru/followers","following_url":"https://api.github.com/users/kseveru/following{/other_user}","gists_url":"https://api.github.com/users/kseveru/gists{/gist_id}","starred_url":"https://api.github.com/users/kseveru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kseveru/subscriptions","organizations_url":"https://api.github.com/users/kseveru/orgs","repos_url":"https://api.github.com/users/kseveru/repos","events_url":"https://api.github.com/users/kseveru/events{/privacy}","received_events_url":"https://api.github.com/users/kseveru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kseveru/173685-technomart","description":"Ольга Гордина","fork":true,"url":"https://api.github.com/repos/kseveru/173685-technomart","forks_url":"https://api.github.com/repos/kseveru/173685-technomart/forks","keys_url":"https://api.github.com/repos/kseveru/173685-technomart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kseveru/173685-technomart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kseveru/173685-technomart/teams","hooks_url":"https://api.github.com/repos/kseveru/173685-technomart/hooks","issue_events_url":"https://api.github.com/repos/kseveru/173685-technomart/issues/events{/number}","events_url":"https://api.github.com/repos/kseveru/173685-technomart/events","assignees_url":"https://api.github.com/repos/kseveru/173685-technomart/assignees{/user}","branches_url":"https://api.github.com/repos/kseveru/173685-technomart/branches{/branch}","tags_url":"https://api.github.com/repos/kseveru/173685-technomart/tags","blobs_url":"https://api.github.com/repos/kseveru/173685-technomart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kseveru/173685-technomart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kseveru/173685-technomart/git/refs{/sha}","trees_url":"https://api.github.com/repos/kseveru/173685-technomart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kseveru/173685-technomart/statuses/{sha}","languages_url":"https://api.github.com/repos/kseveru/173685-technomart/languages","stargazers_url":"https://api.github.com/repos/kseveru/173685-technomart/stargazers","contributors_url":"https://api.github.com/repos/kseveru/173685-technomart/contributors","subscribers_url":"https://api.github.com/repos/kseveru/173685-technomart/subscribers","subscription_url":"https://api.github.com/repos/kseveru/173685-technomart/subscription","commits_url":"https://api.github.com/repos/kseveru/173685-technomart/commits{/sha}","git_commits_url":"https://api.github.com/repos/kseveru/173685-technomart/git/commits{/sha}","comments_url":"https://api.github.com/repos/kseveru/173685-technomart/comments{/number}","issue_comment_url":"https://api.github.com/repos/kseveru/173685-technomart/issues/comments{/number}","contents_url":"https://api.github.com/repos/kseveru/173685-technomart/contents/{+path}","compare_url":"https://api.github.com/repos/kseveru/173685-technomart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kseveru/173685-technomart/merges","archive_url":"https://api.github.com/repos/kseveru/173685-technomart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kseveru/173685-technomart/downloads","issues_url":"https://api.github.com/repos/kseveru/173685-technomart/issues{/number}","pulls_url":"https://api.github.com/repos/kseveru/173685-technomart/pulls{/number}","milestones_url":"https://api.github.com/repos/kseveru/173685-technomart/milestones{/number}","notifications_url":"https://api.github.com/repos/kseveru/173685-technomart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kseveru/173685-technomart/labels{/name}","releases_url":"https://api.github.com/repos/kseveru/173685-technomart/releases{/id}","deployments_url":"https://api.github.com/repos/kseveru/173685-technomart/deployments","created_at":"2017-11-01T13:35:01Z","updated_at":"2017-11-01T13:35:03Z","pushed_at":"2017-11-17T15:32:56Z","git_url":"git://github.com/kseveru/173685-technomart.git","ssh_url":"[email protected]:kseveru/173685-technomart.git","clone_url":"https://github.com/kseveru/173685-technomart.git","svn_url":"https://github.com/kseveru/173685-technomart","homepage":null,"size":421,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"ae4c4f9eae0ef46767df174eb9a4d27a517ca5cc","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":109135246,"name":"173685-technomart","full_name":"htmlacademy-htmlcss/173685-technomart","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/173685-technomart","description":"Ольга Гордина","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/deployments","created_at":"2017-11-01T13:32:38Z","updated_at":"2017-11-01T17:03:50Z","pushed_at":"2017-11-17T15:33:32Z","git_url":"git://github.com/htmlacademy-htmlcss/173685-technomart.git","ssh_url":"[email protected]:htmlacademy-htmlcss/173685-technomart.git","clone_url":"https://github.com/htmlacademy-htmlcss/173685-technomart.git","svn_url":"https://github.com/htmlacademy-htmlcss/173685-technomart","homepage":"https://github.com/kseveru/173685-technomart","size":427,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/5"},"html":{"href":"https://github.com/htmlacademy-htmlcss/173685-technomart/pull/5"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/issues/5"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart/statuses/f03cb32789a896d212e8f871ff0ceb83298bfbf9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 109135246,
"name": "htmlacademy-htmlcss/173685-technomart",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/173685-technomart"
} | {
"id": 9592349,
"login": "ad-ovo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9592349?",
"url": "https://api.github.com/users/ad-ovo"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-11-17T18:22:37 | 6871365918 | {"actor":{"display_login":"ad-ovo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/comments/137551644","pull_request_review_id":61197213,"id":137551644,"diff_hunk":"@@ -139,17 +159,81 @@ body {\n }\n \n .user-navigation {\n+ display: flex;\n+ justify-content: space-between;\n padding: 0;\n margin: 0;\n width: 500px;\n }\n \n .user-navigation a {\n+ position: relative;\n+ padding-left: 27px;\n color: #000000;\n font: inherit;\n text-decoration: none;\n }\n \n+.user-navigation .login-link {\n+ margin-right: 190px;\n+}\n+\n+.user-navigation .login-link-in {\n+ margin-right: 20px;\n+}\n+\n+.user-navigation .сompare {\n+ margin-right: 16px;\n+}\n+\n+.user-navigation .login-link::before {\n+ content: \"\";\n+ position: absolute;\n+ top: 9px;\n+ left: 0px;\n+ width: 13px;\n+ height: 12px;\n+ background-image: url(\"../img/user.svg\");\n+ background-repeat: no-repeat;\n+ background-position: 0 0;\n+}\n+\n+.user-navigation .login-link-in::before {\n+ content: \"\";\n+ position: absolute;\n+ top: 9px;\n+ left: 0px;\n+ width: 13px;\n+ height: 12px;\n+ background-image: url(\"../img/user.svg\");\n+ background-repeat: no-repeat;\n+ background-position: 0 0;\n+}\n+\n+.user-navigation .сompare::before {\n+ content: \"\";\n+ position: absolute;\n+ top: 11px;\n+ left: 8px;\n+ width: 13px;\n+ height: 12px;\n+ background-image: url(\"../img/compare.svg\");\n+ background-repeat: no-repeat;\n+ background-position: 0 0;\n+}\n+\n+.user-navigation .cart::before {\n+ content: \"\";\n+ position: absolute;\n+ top: 9px;\n+ left: 4px;\n+ width: 13px;","path":"css/style.css","position":128,"original_position":128,"commit_id":"96d5312a9dc61ec29350c2de186c4365175fd77b","original_commit_id":"96d5312a9dc61ec29350c2de186c4365175fd77b","user":{"login":"olegbilyk","id":15265408,"avatar_url":"https://avatars0.githubusercontent.com/u/15265408?v=4","gravatar_id":"","url":"https://api.github.com/users/olegbilyk","html_url":"https://github.com/olegbilyk","followers_url":"https://api.github.com/users/olegbilyk/followers","following_url":"https://api.github.com/users/olegbilyk/following{/other_user}","gists_url":"https://api.github.com/users/olegbilyk/gists{/gist_id}","starred_url":"https://api.github.com/users/olegbilyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegbilyk/subscriptions","organizations_url":"https://api.github.com/users/olegbilyk/orgs","repos_url":"https://api.github.com/users/olegbilyk/repos","events_url":"https://api.github.com/users/olegbilyk/events{/privacy}","received_events_url":"https://api.github.com/users/olegbilyk/received_events","type":"User","site_admin":false},"body":"лучше выравнивать в процентах \r\nтакже с иконками остальными в меню ","created_at":"2017-09-07T14:18:06Z","updated_at":"2017-09-07T14:52:04Z","html_url":"https://github.com/htmlacademy-htmlcss/192116-device/pull/6#discussion_r137551644","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/comments/137551644"},"html":{"href":"https://github.com/htmlacademy-htmlcss/192116-device/pull/6#discussion_r137551644"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/6","id":139360928,"html_url":"https://github.com/htmlacademy-htmlcss/192116-device/pull/6","diff_url":"https://github.com/htmlacademy-htmlcss/192116-device/pull/6.diff","patch_url":"https://github.com/htmlacademy-htmlcss/192116-device/pull/6.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/issues/6","number":6,"state":"open","locked":false,"title":"Декоративные элементы личного проекта","user":{"login":"kiyashko","id":30874362,"avatar_url":"https://avatars3.githubusercontent.com/u/30874362?v=4","gravatar_id":"","url":"https://api.github.com/users/kiyashko","html_url":"https://github.com/kiyashko","followers_url":"https://api.github.com/users/kiyashko/followers","following_url":"https://api.github.com/users/kiyashko/following{/other_user}","gists_url":"https://api.github.com/users/kiyashko/gists{/gist_id}","starred_url":"https://api.github.com/users/kiyashko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiyashko/subscriptions","organizations_url":"https://api.github.com/users/kiyashko/orgs","repos_url":"https://api.github.com/users/kiyashko/repos","events_url":"https://api.github.com/users/kiyashko/events{/privacy}","received_events_url":"https://api.github.com/users/kiyashko/received_events","type":"User","site_admin":false},"body":"Предварительная проверка на визуализацию.\n\n---\n:mortar_board: [Декоративные элементы личного проекта](https://up.htmlacademy.ru/htmlcss/18/user/192116/tasks/47)\n\n:boom: https://htmlacademy-htmlcss.github.io/192116-device/6/","created_at":"2017-09-05T15:58:48Z","updated_at":"2017-09-07T14:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c87eb42f79c8769a01567e10452db02369061a5f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/6/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/6/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/issues/6/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/statuses/96d5312a9dc61ec29350c2de186c4365175fd77b","head":{"label":"kiyashko:master","ref":"master","sha":"96d5312a9dc61ec29350c2de186c4365175fd77b","user":{"login":"kiyashko","id":30874362,"avatar_url":"https://avatars3.githubusercontent.com/u/30874362?v=4","gravatar_id":"","url":"https://api.github.com/users/kiyashko","html_url":"https://github.com/kiyashko","followers_url":"https://api.github.com/users/kiyashko/followers","following_url":"https://api.github.com/users/kiyashko/following{/other_user}","gists_url":"https://api.github.com/users/kiyashko/gists{/gist_id}","starred_url":"https://api.github.com/users/kiyashko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiyashko/subscriptions","organizations_url":"https://api.github.com/users/kiyashko/orgs","repos_url":"https://api.github.com/users/kiyashko/repos","events_url":"https://api.github.com/users/kiyashko/events{/privacy}","received_events_url":"https://api.github.com/users/kiyashko/received_events","type":"User","site_admin":false},"repo":{"id":99836643,"name":"192116-device","full_name":"kiyashko/192116-device","owner":{"login":"kiyashko","id":30874362,"avatar_url":"https://avatars3.githubusercontent.com/u/30874362?v=4","gravatar_id":"","url":"https://api.github.com/users/kiyashko","html_url":"https://github.com/kiyashko","followers_url":"https://api.github.com/users/kiyashko/followers","following_url":"https://api.github.com/users/kiyashko/following{/other_user}","gists_url":"https://api.github.com/users/kiyashko/gists{/gist_id}","starred_url":"https://api.github.com/users/kiyashko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiyashko/subscriptions","organizations_url":"https://api.github.com/users/kiyashko/orgs","repos_url":"https://api.github.com/users/kiyashko/repos","events_url":"https://api.github.com/users/kiyashko/events{/privacy}","received_events_url":"https://api.github.com/users/kiyashko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kiyashko/192116-device","description":"Сергей Кияшко","fork":true,"url":"https://api.github.com/repos/kiyashko/192116-device","forks_url":"https://api.github.com/repos/kiyashko/192116-device/forks","keys_url":"https://api.github.com/repos/kiyashko/192116-device/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiyashko/192116-device/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiyashko/192116-device/teams","hooks_url":"https://api.github.com/repos/kiyashko/192116-device/hooks","issue_events_url":"https://api.github.com/repos/kiyashko/192116-device/issues/events{/number}","events_url":"https://api.github.com/repos/kiyashko/192116-device/events","assignees_url":"https://api.github.com/repos/kiyashko/192116-device/assignees{/user}","branches_url":"https://api.github.com/repos/kiyashko/192116-device/branches{/branch}","tags_url":"https://api.github.com/repos/kiyashko/192116-device/tags","blobs_url":"https://api.github.com/repos/kiyashko/192116-device/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiyashko/192116-device/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiyashko/192116-device/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiyashko/192116-device/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiyashko/192116-device/statuses/{sha}","languages_url":"https://api.github.com/repos/kiyashko/192116-device/languages","stargazers_url":"https://api.github.com/repos/kiyashko/192116-device/stargazers","contributors_url":"https://api.github.com/repos/kiyashko/192116-device/contributors","subscribers_url":"https://api.github.com/repos/kiyashko/192116-device/subscribers","subscription_url":"https://api.github.com/repos/kiyashko/192116-device/subscription","commits_url":"https://api.github.com/repos/kiyashko/192116-device/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiyashko/192116-device/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiyashko/192116-device/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiyashko/192116-device/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiyashko/192116-device/contents/{+path}","compare_url":"https://api.github.com/repos/kiyashko/192116-device/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiyashko/192116-device/merges","archive_url":"https://api.github.com/repos/kiyashko/192116-device/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiyashko/192116-device/downloads","issues_url":"https://api.github.com/repos/kiyashko/192116-device/issues{/number}","pulls_url":"https://api.github.com/repos/kiyashko/192116-device/pulls{/number}","milestones_url":"https://api.github.com/repos/kiyashko/192116-device/milestones{/number}","notifications_url":"https://api.github.com/repos/kiyashko/192116-device/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiyashko/192116-device/labels{/name}","releases_url":"https://api.github.com/repos/kiyashko/192116-device/releases{/id}","deployments_url":"https://api.github.com/repos/kiyashko/192116-device/deployments","created_at":"2017-08-09T17:44:29Z","updated_at":"2017-08-09T20:46:21Z","pushed_at":"2017-09-07T11:15:13Z","git_url":"git://github.com/kiyashko/192116-device.git","ssh_url":"[email protected]:kiyashko/192116-device.git","clone_url":"https://github.com/kiyashko/192116-device.git","svn_url":"https://github.com/kiyashko/192116-device","homepage":null,"size":438,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"ce27db184cee0e83ad5c181ce85936e770a38d10","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":99836185,"name":"192116-device","full_name":"htmlacademy-htmlcss/192116-device","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/192116-device","description":"Сергей Кияшко","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/deployments","created_at":"2017-08-09T17:39:27Z","updated_at":"2017-08-27T23:52:20Z","pushed_at":"2017-09-07T11:38:15Z","git_url":"git://github.com/htmlacademy-htmlcss/192116-device.git","ssh_url":"[email protected]:htmlacademy-htmlcss/192116-device.git","clone_url":"https://github.com/htmlacademy-htmlcss/192116-device.git","svn_url":"https://github.com/htmlacademy-htmlcss/192116-device","homepage":"https://github.com/kiyashko/192116-device","size":471,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/6"},"html":{"href":"https://github.com/htmlacademy-htmlcss/192116-device/pull/6"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/issues/6"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/192116-device/statuses/96d5312a9dc61ec29350c2de186c4365175fd77b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 99836185,
"name": "htmlacademy-htmlcss/192116-device",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/192116-device"
} | {
"id": 15265408,
"login": "olegbilyk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15265408?",
"url": "https://api.github.com/users/olegbilyk"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-09-07T14:18:06 | 6561918687 | {"actor":{"display_login":"olegbilyk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/comments/150700232","pull_request_review_id":76289454,"id":150700232,"diff_hunk":"@@ -22,8 +22,8 @@\n <div class=\"advertising-poster\">\n <b>Долго, дорого, скрупулезно.</b>\n <p>Математически выверенный дизайн для вашего сайта или мобильного приложения.</p>\n- <a href=\"information\">узнать больше</a>\n- <img src=\"http://placehold.it/150x100\" alt=\"картинка\"> <!-- три смартфона -->\n+ <a href=\"information\"><button type=\"button\">узнать больше</button></a>\n+ <img src=\"http://placehold.it/150x100\" alt=\"картинка\"> <!-- три смартфона -->","path":"index.html","position":7,"original_position":7,"commit_id":"c4164c5d8d992e0d5f9f5736f67804b11fd2feca","original_commit_id":"c4164c5d8d992e0d5f9f5736f67804b11fd2feca","user":{"login":"AnnaKanina","id":33236076,"avatar_url":"https://avatars2.githubusercontent.com/u/33236076?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaKanina","html_url":"https://github.com/AnnaKanina","followers_url":"https://api.github.com/users/AnnaKanina/followers","following_url":"https://api.github.com/users/AnnaKanina/following{/other_user}","gists_url":"https://api.github.com/users/AnnaKanina/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaKanina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaKanina/subscriptions","organizations_url":"https://api.github.com/users/AnnaKanina/orgs","repos_url":"https://api.github.com/users/AnnaKanina/repos","events_url":"https://api.github.com/users/AnnaKanina/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaKanina/received_events","type":"User","site_admin":false},"body":"Каких?","created_at":"2017-11-13T23:46:46Z","updated_at":"2017-11-13T23:46:46Z","html_url":"https://github.com/htmlacademy-htmlcss/372395-nerds/pull/5#discussion_r150700232","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/comments/150700232"},"html":{"href":"https://github.com/htmlacademy-htmlcss/372395-nerds/pull/5#discussion_r150700232"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/5"}},"in_reply_to_id":150610822},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/5","id":152122538,"html_url":"https://github.com/htmlacademy-htmlcss/372395-nerds/pull/5","diff_url":"https://github.com/htmlacademy-htmlcss/372395-nerds/pull/5.diff","patch_url":"https://github.com/htmlacademy-htmlcss/372395-nerds/pull/5.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/issues/5","number":5,"state":"open","locked":false,"title":"Завершаем разметку личного проекта","user":{"login":"AnnaKanina","id":33236076,"avatar_url":"https://avatars2.githubusercontent.com/u/33236076?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaKanina","html_url":"https://github.com/AnnaKanina","followers_url":"https://api.github.com/users/AnnaKanina/followers","following_url":"https://api.github.com/users/AnnaKanina/following{/other_user}","gists_url":"https://api.github.com/users/AnnaKanina/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaKanina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaKanina/subscriptions","organizations_url":"https://api.github.com/users/AnnaKanina/orgs","repos_url":"https://api.github.com/users/AnnaKanina/repos","events_url":"https://api.github.com/users/AnnaKanina/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaKanina/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Завершаем разметку личного проекта](https://up.htmlacademy.ru/htmlcss/19/user/372395/tasks/29)\n\n:boom: https://htmlacademy-htmlcss.github.io/372395-nerds/5/","created_at":"2017-11-12T20:46:09Z","updated_at":"2017-11-13T23:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77349675fed7a1a5849515ba662c2878f46c76e5","assignee":{"login":"Zveroboev","id":27211707,"avatar_url":"https://avatars2.githubusercontent.com/u/27211707?v=4","gravatar_id":"","url":"https://api.github.com/users/Zveroboev","html_url":"https://github.com/Zveroboev","followers_url":"https://api.github.com/users/Zveroboev/followers","following_url":"https://api.github.com/users/Zveroboev/following{/other_user}","gists_url":"https://api.github.com/users/Zveroboev/gists{/gist_id}","starred_url":"https://api.github.com/users/Zveroboev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zveroboev/subscriptions","organizations_url":"https://api.github.com/users/Zveroboev/orgs","repos_url":"https://api.github.com/users/Zveroboev/repos","events_url":"https://api.github.com/users/Zveroboev/events{/privacy}","received_events_url":"https://api.github.com/users/Zveroboev/received_events","type":"User","site_admin":false},"assignees":[{"login":"Zveroboev","id":27211707,"avatar_url":"https://avatars2.githubusercontent.com/u/27211707?v=4","gravatar_id":"","url":"https://api.github.com/users/Zveroboev","html_url":"https://github.com/Zveroboev","followers_url":"https://api.github.com/users/Zveroboev/followers","following_url":"https://api.github.com/users/Zveroboev/following{/other_user}","gists_url":"https://api.github.com/users/Zveroboev/gists{/gist_id}","starred_url":"https://api.github.com/users/Zveroboev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zveroboev/subscriptions","organizations_url":"https://api.github.com/users/Zveroboev/orgs","repos_url":"https://api.github.com/users/Zveroboev/repos","events_url":"https://api.github.com/users/Zveroboev/events{/privacy}","received_events_url":"https://api.github.com/users/Zveroboev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/5/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/5/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/issues/5/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/statuses/c4164c5d8d992e0d5f9f5736f67804b11fd2feca","head":{"label":"AnnaKanina:master","ref":"master","sha":"c4164c5d8d992e0d5f9f5736f67804b11fd2feca","user":{"login":"AnnaKanina","id":33236076,"avatar_url":"https://avatars2.githubusercontent.com/u/33236076?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaKanina","html_url":"https://github.com/AnnaKanina","followers_url":"https://api.github.com/users/AnnaKanina/followers","following_url":"https://api.github.com/users/AnnaKanina/following{/other_user}","gists_url":"https://api.github.com/users/AnnaKanina/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaKanina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaKanina/subscriptions","organizations_url":"https://api.github.com/users/AnnaKanina/orgs","repos_url":"https://api.github.com/users/AnnaKanina/repos","events_url":"https://api.github.com/users/AnnaKanina/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaKanina/received_events","type":"User","site_admin":false},"repo":{"id":108980999,"name":"372395-nerds","full_name":"AnnaKanina/372395-nerds","owner":{"login":"AnnaKanina","id":33236076,"avatar_url":"https://avatars2.githubusercontent.com/u/33236076?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaKanina","html_url":"https://github.com/AnnaKanina","followers_url":"https://api.github.com/users/AnnaKanina/followers","following_url":"https://api.github.com/users/AnnaKanina/following{/other_user}","gists_url":"https://api.github.com/users/AnnaKanina/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaKanina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaKanina/subscriptions","organizations_url":"https://api.github.com/users/AnnaKanina/orgs","repos_url":"https://api.github.com/users/AnnaKanina/repos","events_url":"https://api.github.com/users/AnnaKanina/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaKanina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnnaKanina/372395-nerds","description":"Анна Канина","fork":true,"url":"https://api.github.com/repos/AnnaKanina/372395-nerds","forks_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/forks","keys_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/teams","hooks_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/hooks","issue_events_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/issues/events{/number}","events_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/events","assignees_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/assignees{/user}","branches_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/branches{/branch}","tags_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/tags","blobs_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/statuses/{sha}","languages_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/languages","stargazers_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/stargazers","contributors_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/contributors","subscribers_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/subscribers","subscription_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/subscription","commits_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/contents/{+path}","compare_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/merges","archive_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/downloads","issues_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/issues{/number}","pulls_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/pulls{/number}","milestones_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/milestones{/number}","notifications_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/labels{/name}","releases_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/releases{/id}","deployments_url":"https://api.github.com/repos/AnnaKanina/372395-nerds/deployments","created_at":"2017-10-31T10:36:56Z","updated_at":"2017-10-31T10:36:58Z","pushed_at":"2017-11-12T20:44:39Z","git_url":"git://github.com/AnnaKanina/372395-nerds.git","ssh_url":"[email protected]:AnnaKanina/372395-nerds.git","clone_url":"https://github.com/AnnaKanina/372395-nerds.git","svn_url":"https://github.com/AnnaKanina/372395-nerds","homepage":null,"size":2405,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"cd2301025bea34c4b6c3fc1c1f74d85317450661","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":108914185,"name":"372395-nerds","full_name":"htmlacademy-htmlcss/372395-nerds","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/372395-nerds","description":"Анна Канина","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/deployments","created_at":"2017-10-30T22:12:42Z","updated_at":"2017-11-01T19:59:54Z","pushed_at":"2017-11-13T17:26:39Z","git_url":"git://github.com/htmlacademy-htmlcss/372395-nerds.git","ssh_url":"[email protected]:htmlacademy-htmlcss/372395-nerds.git","clone_url":"https://github.com/htmlacademy-htmlcss/372395-nerds.git","svn_url":"https://github.com/htmlacademy-htmlcss/372395-nerds","homepage":"https://github.com/AnnaKanina/372395-nerds","size":2424,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/5"},"html":{"href":"https://github.com/htmlacademy-htmlcss/372395-nerds/pull/5"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/issues/5"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds/statuses/c4164c5d8d992e0d5f9f5736f67804b11fd2feca"}},"author_association":"CONTRIBUTOR"}} | {
"id": 108914185,
"name": "htmlacademy-htmlcss/372395-nerds",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/372395-nerds"
} | {
"id": 33236076,
"login": "AnnaKanina",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33236076?",
"url": "https://api.github.com/users/AnnaKanina"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-11-13T23:46:46 | 6849828764 | {"actor":{"display_login":"AnnaKanina"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/comments/133650164","pull_request_review_id":56854287,"id":133650164,"diff_hunk":"@@ -2,11 +2,212 @@\n <html lang=\"ru\">\n <head>\n <meta charset=\"utf-8\">\n- <title>HTML Academy: Глейси</title>\n+ <title>Глейси</title>\n </head>\n <body>\n+ <input type=\"radio\" id=\"btn-1\" name=\"toggle\" checked>\n+ <input type=\"radio\" id=\"btn-2\" name=\"toggle\">\n+ <input type=\"radio\" id=\"btn-3\" name=\"toggle\">\n+ <div class=\"content-wrapper\">\n+ <header class=\"main-header\">\n+ <nav class=\"main-nav\">\n+ <a><img src=\"img/logo.png\" alt=\"Логотип Глейси\" width=\"\" height=\"\"></a>\n+ <ul class=\"site-nav\">\n+ <li class=\"has-children\">\n+ <a href=\"catalog.html\">Каталог</a>\n+ <ul class=\"submenu\">\n+ <li class=\"submenu-item\"><a href=\"#\">Новинки</a></li>\n+ <li class=\"submenu-item\"><a href=\"#\">Сливочное</a></li>\n+ <li class=\"submenu-item\"><a href=\"#\">Щербеты</a></li>\n+ <li class=\"submenu-item\"><a href=\"#\">Фруктовый лёд</a></li>\n+ <li class=\"submenu-item\"><a href=\"#\">Мелорин</a></li>\n+ </ul>\n+ </li>\n+ <li><a href=\"#\">Доставка и оплата</a></li>\n+ <li><a href=\"#\">О компании</a></li>\n+ </ul>\n+ <ul class=\"user-nav\">\n+ <li>\n+ <a class=\"search-link\" href=\"#\">Поиск</a>\n+ <form class=\"search-form\" action=\"https://echo.htmlacademy.ru\" method=\"get\">\n+ <input type=\"search\" name=\"search\" id=\"search-field\" required>\n+ <label for=\"search-field\">Что ищем?</label>\n+ </form>\n+ </li>\n+ <li>\n+ <a class=\"login-link\">Вход</a>\n+ <form class=\"login-form\" action=\"https://echo.htmlacademy.ru\" method=\"get\">\n+ <input type=\"email\" name=\"email\" id=\"mail-field\" required>\n+ <label for=\"mail-field\">Электронная почта</label>\n+ <input type=\"password\" name=\"password\" id=\"pass-field\" required>\n+ <label for=\"pass-field\">Пароль</label>\n+ <a class=\"submit-btn btn\" href=\"#\">Войти</a> <!-- или это через input subbmit? -->\n+ </form>\n+ <a href=\"#\">Забыли пароль?</a><br> <!-- Или это внутри формы? Или в div? -->\n+ <a href=\"#\">Новая регистрация?</a>\n+ </li>\n+ <li>\n+ <a class=\"cart-link\">Пусто</a>\n+ </li>\n+ </ul>\n+ </nav>\n+ <p class=\"contact\">с 10 до 20, ежедневно<br>\n+ <a class=\"contacts-phone\" href=\"tel:+7-812-450-25-25\">8 812 450-25-25</a>\n+ </p>\n+ </header>\n \n- <p>Репозиторий создан для обучения на интенсивном онлайн‑курсе «<a href=\"https://htmlacademy.ru/intensive/htmlcss\">Базовый HTML и CSS</a>».</p>\n+ <main class=\"container\">\n+ <h1 class=\"visually-hidden\">Магазин мороженного Глейси</h1>\n+ <section class=\"slider\">\n+ <ul class=\"slider-list\">\n+ <li class=\"slide\" id=\"slide-1\">\n+ <h2 class=\"slide-title\">Крем-брюле и пломбир с малиновым джемом</h2>\n+ <a class=\"slider-btn btn\" href=\"#\">Давайте оба!</a> <!-- я так понимаю что это ссылка на акцию, а не кнопка добавить в корзину -->\n+ </li>\n+ <li class=\"slide\" id=\"slide-2\"> <!-- Спратянный слайд -->\n+ <h2 class=\"slide-title\">Шоколадный пломбир и лимонный сорбет</h2>\n+ <a class=\"slider-btn btn\" href=\"#\">Давайте оба!</a>\n+ </li>\n+ <li class=\"slide\" id=\"slide-3\"> <!-- Спратянный слайд -->\n+ <h2 class=\"slide-title\">Пломбир с помадкой и клубничный щербет</h2>\n+ <a class=\"slider-btn btn\" href=\"#\">Давайте оба!</a>\n+ </li>\n+ </ul>\n+ <div class=\"slider-controls\">\n+ <label for=\"btn-1\"></label>\n+ <label for=\"btn-2\"></label>\n+ <label for=\"btn-3\"></label>\n+ </div>\n+ </section>\n \n+ <section class=\"banners\">\n+ <article class=\"banner-item\">\n+ <h2 class=\"banner-item-title\">Малинка даром!</h2>\n+ <p class=\"banner-text\">При покупке 2 кг любого фруктового мороженого, добавим в ваш заказ банку малинового варенья бесплатно.</p>\n+ <a class=\"banner-btn btn\">Хочу варенье!</a>\n+ </article>\n+ <article class=\"banner-item\">\n+ <h2 class=\"banner-item-title\">Шоколадки даром!</h2>\n+ <p class=\"banner-text\">При покупке 2 кг пломбира, добавим в ваш заказ упаковку вкуснейшей шоколадной присыпки совершенно бесплатно.</p>\n+ <a class=\"banner-btn btn\">Хочу шоколадки!</a>\n+ </article>\n+ </section>\n+\n+ <section class=\"hit-products\">\n+ <ul class=\"hit-item\">","path":"index.html","position":98,"original_position":98,"commit_id":"cc9e479cf88f79b03ae5ae0df27ddcbb904e7806","original_commit_id":"cc9e479cf88f79b03ae5ae0df27ddcbb904e7806","user":{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"body":"catalog-list","created_at":"2017-08-17T08:19:54Z","updated_at":"2017-08-17T08:19:54Z","html_url":"https://github.com/htmlacademy-htmlcss/464667-gllacy/pull/2#discussion_r133650164","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/comments/133650164"},"html":{"href":"https://github.com/htmlacademy-htmlcss/464667-gllacy/pull/2#discussion_r133650164"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/2","id":135866729,"html_url":"https://github.com/htmlacademy-htmlcss/464667-gllacy/pull/2","diff_url":"https://github.com/htmlacademy-htmlcss/464667-gllacy/pull/2.diff","patch_url":"https://github.com/htmlacademy-htmlcss/464667-gllacy/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/issues/2","number":2,"state":"open","locked":false,"title":"Разметка личного проекта","user":{"login":"kud77","id":29689244,"avatar_url":"https://avatars1.githubusercontent.com/u/29689244?v=4","gravatar_id":"","url":"https://api.github.com/users/kud77","html_url":"https://github.com/kud77","followers_url":"https://api.github.com/users/kud77/followers","following_url":"https://api.github.com/users/kud77/following{/other_user}","gists_url":"https://api.github.com/users/kud77/gists{/gist_id}","starred_url":"https://api.github.com/users/kud77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kud77/subscriptions","organizations_url":"https://api.github.com/users/kud77/orgs","repos_url":"https://api.github.com/users/kud77/repos","events_url":"https://api.github.com/users/kud77/events{/privacy}","received_events_url":"https://api.github.com/users/kud77/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Разметка личного проекта](https://up.htmlacademy.ru/htmlcss/18/user/464667/tasks/16)","created_at":"2017-08-15T18:55:21Z","updated_at":"2017-08-17T08:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86193a41358ad04cafd0156c7a12485b4b73c880","assignee":{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/statuses/cc9e479cf88f79b03ae5ae0df27ddcbb904e7806","head":{"label":"kud77:master","ref":"master","sha":"cc9e479cf88f79b03ae5ae0df27ddcbb904e7806","user":{"login":"kud77","id":29689244,"avatar_url":"https://avatars1.githubusercontent.com/u/29689244?v=4","gravatar_id":"","url":"https://api.github.com/users/kud77","html_url":"https://github.com/kud77","followers_url":"https://api.github.com/users/kud77/followers","following_url":"https://api.github.com/users/kud77/following{/other_user}","gists_url":"https://api.github.com/users/kud77/gists{/gist_id}","starred_url":"https://api.github.com/users/kud77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kud77/subscriptions","organizations_url":"https://api.github.com/users/kud77/orgs","repos_url":"https://api.github.com/users/kud77/repos","events_url":"https://api.github.com/users/kud77/events{/privacy}","received_events_url":"https://api.github.com/users/kud77/received_events","type":"User","site_admin":false},"repo":{"id":99728457,"name":"464667-gllacy","full_name":"kud77/464667-gllacy","owner":{"login":"kud77","id":29689244,"avatar_url":"https://avatars1.githubusercontent.com/u/29689244?v=4","gravatar_id":"","url":"https://api.github.com/users/kud77","html_url":"https://github.com/kud77","followers_url":"https://api.github.com/users/kud77/followers","following_url":"https://api.github.com/users/kud77/following{/other_user}","gists_url":"https://api.github.com/users/kud77/gists{/gist_id}","starred_url":"https://api.github.com/users/kud77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kud77/subscriptions","organizations_url":"https://api.github.com/users/kud77/orgs","repos_url":"https://api.github.com/users/kud77/repos","events_url":"https://api.github.com/users/kud77/events{/privacy}","received_events_url":"https://api.github.com/users/kud77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kud77/464667-gllacy","description":"Aleksandr Kudinov","fork":true,"url":"https://api.github.com/repos/kud77/464667-gllacy","forks_url":"https://api.github.com/repos/kud77/464667-gllacy/forks","keys_url":"https://api.github.com/repos/kud77/464667-gllacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kud77/464667-gllacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kud77/464667-gllacy/teams","hooks_url":"https://api.github.com/repos/kud77/464667-gllacy/hooks","issue_events_url":"https://api.github.com/repos/kud77/464667-gllacy/issues/events{/number}","events_url":"https://api.github.com/repos/kud77/464667-gllacy/events","assignees_url":"https://api.github.com/repos/kud77/464667-gllacy/assignees{/user}","branches_url":"https://api.github.com/repos/kud77/464667-gllacy/branches{/branch}","tags_url":"https://api.github.com/repos/kud77/464667-gllacy/tags","blobs_url":"https://api.github.com/repos/kud77/464667-gllacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kud77/464667-gllacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kud77/464667-gllacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kud77/464667-gllacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kud77/464667-gllacy/statuses/{sha}","languages_url":"https://api.github.com/repos/kud77/464667-gllacy/languages","stargazers_url":"https://api.github.com/repos/kud77/464667-gllacy/stargazers","contributors_url":"https://api.github.com/repos/kud77/464667-gllacy/contributors","subscribers_url":"https://api.github.com/repos/kud77/464667-gllacy/subscribers","subscription_url":"https://api.github.com/repos/kud77/464667-gllacy/subscription","commits_url":"https://api.github.com/repos/kud77/464667-gllacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kud77/464667-gllacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kud77/464667-gllacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kud77/464667-gllacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kud77/464667-gllacy/contents/{+path}","compare_url":"https://api.github.com/repos/kud77/464667-gllacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kud77/464667-gllacy/merges","archive_url":"https://api.github.com/repos/kud77/464667-gllacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kud77/464667-gllacy/downloads","issues_url":"https://api.github.com/repos/kud77/464667-gllacy/issues{/number}","pulls_url":"https://api.github.com/repos/kud77/464667-gllacy/pulls{/number}","milestones_url":"https://api.github.com/repos/kud77/464667-gllacy/milestones{/number}","notifications_url":"https://api.github.com/repos/kud77/464667-gllacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kud77/464667-gllacy/labels{/name}","releases_url":"https://api.github.com/repos/kud77/464667-gllacy/releases{/id}","deployments_url":"https://api.github.com/repos/kud77/464667-gllacy/deployments","created_at":"2017-08-08T19:25:07Z","updated_at":"2017-08-08T19:25:09Z","pushed_at":"2017-08-16T17:54:27Z","git_url":"git://github.com/kud77/464667-gllacy.git","ssh_url":"[email protected]:kud77/464667-gllacy.git","clone_url":"https://github.com/kud77/464667-gllacy.git","svn_url":"https://github.com/kud77/464667-gllacy","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"9e2b5f6c0399f4d3d10f3a5207d0590233e94f2b","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":99726425,"name":"464667-gllacy","full_name":"htmlacademy-htmlcss/464667-gllacy","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/464667-gllacy","description":"Aleksandr Kudinov","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/deployments","created_at":"2017-08-08T18:57:52Z","updated_at":"2017-08-08T19:56:26Z","pushed_at":"2017-08-16T17:54:29Z","git_url":"git://github.com/htmlacademy-htmlcss/464667-gllacy.git","ssh_url":"[email protected]:htmlacademy-htmlcss/464667-gllacy.git","clone_url":"https://github.com/htmlacademy-htmlcss/464667-gllacy.git","svn_url":"https://github.com/htmlacademy-htmlcss/464667-gllacy","homepage":"https://github.com/kud77/464667-gllacy","size":4,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/2"},"html":{"href":"https://github.com/htmlacademy-htmlcss/464667-gllacy/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy/statuses/cc9e479cf88f79b03ae5ae0df27ddcbb904e7806"}}}} | {
"id": 99726425,
"name": "htmlacademy-htmlcss/464667-gllacy",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/464667-gllacy"
} | {
"id": 9842814,
"login": "sergeykravchenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9842814?",
"url": "https://api.github.com/users/sergeykravchenko"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-08-17T08:19:54 | 6470157959 | {"actor":{"display_login":"sergeykravchenko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/comments/152792898","pull_request_review_id":78708086,"id":152792898,"diff_hunk":"@@ -298,51 +302,53 @@ <h2 class=\"visually-hidden\">Пагинация</h2>\n </section>\n </main>\n <footer class=\"main-footer\">\n- <div class=\"social\">\n- <ul class=\"social-list\">\n- <li class=\"social-item\">\n- <a class=\"social-link twitter\" href=\"#\" aria-label=\"Twitter\">\n- <img class=\"social-image\" src=\"img/twitter.svg\" width=\"31\" height=\"31\" alt=\"twitter\">\n- </a>\n- </li>\n- <li class=\"social-item\">\n- <a class=\"social-link instagram\" href=\"#\" aria-label=\"Instagram\">\n- <img class=\"social-image\" src=\"img/instagram.svg\" width=\"31\" height=\"31\" alt=\"instagram\">\n- </a>\n- </li>\n- <li class=\"social-item\">\n- <a class=\"social-link facebook\" href=\"#\" aria-label=\"Facebook\">\n- <img class=\"social-image\" src=\"img/fb.svg\" width=\"31\" height=\"31\" alt=\"facebook\">\n- </a>\n- </li>\n- <li class=\"social-item\">\n- <a class=\"social-link vkontakte\" href=\"#\" aria-label=\"Vkontakte\">\n- <img class=\"social-image\" src=\"img/vk.svg\" width=\"31\" height=\"31\" alt=\"vkontakte\">\n- </a>\n- </li>\n- </ul>\n- </div>\n- <div class=\"footer-menu\">\n- <ul class=\"footer-list\">\n- <li class=\"footer-item\">\n- <a href=\"#\" class=\"footer-link bold\">Для поставщиков</a>\n- </li>\n- <li class=\"footer-item\">\n- <a href=\"#\" class=\"footer-link\">Наши документы</a>\n- </li>\n- <li class=\"footer-item\">\n- <a href=\"#\" class=\"footer-link\">О производстве</a>\n- </li>\n- <li class=\"footer-item\">\n- <a href=\"#\" class=\"footer-link\">Экологические стандарты</a>\n- </li>\n- </ul>\n- </div>\n- <div class=\"footer-copyright\">\n- <p class=\"footer-copyright-logo\">\n- <img class=\"copyright-logo\" src=\"img/logo-htmlacademy.svg\" alt=\"Логотип HTMLAcademy\" width=\"110\" height=\"42\">\n- </p>\n- <p class=\"footer-copyright-text\">Сделано в <a class=\"footer-copyright-link\" href=\"index.html\">HTML Academy</a>© 2017</p>\n+ <div class=\"container\">\n+ <div class=\"social\">\n+ <ul class=\"social-list\">\n+ <li class=\"social-item\">\n+ <a class=\"social-link twitter\" href=\"#\" aria-label=\"Twitter\">\n+ <img class=\"social-image\" src=\"img/twitter.svg\" width=\"31\" height=\"31\" alt=\"twitter\">","path":"catalog.html","position":145,"original_position":145,"commit_id":"02f512e38befdd09a47c27cb15e32d17ae0e044c","original_commit_id":"02f512e38befdd09a47c27cb15e32d17ae0e044c","user":{"login":"artemka107","id":18405633,"avatar_url":"https://avatars0.githubusercontent.com/u/18405633?v=4","gravatar_id":"","url":"https://api.github.com/users/artemka107","html_url":"https://github.com/artemka107","followers_url":"https://api.github.com/users/artemka107/followers","following_url":"https://api.github.com/users/artemka107/following{/other_user}","gists_url":"https://api.github.com/users/artemka107/gists{/gist_id}","starred_url":"https://api.github.com/users/artemka107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artemka107/subscriptions","organizations_url":"https://api.github.com/users/artemka107/orgs","repos_url":"https://api.github.com/users/artemka107/repos","events_url":"https://api.github.com/users/artemka107/events{/privacy}","received_events_url":"https://api.github.com/users/artemka107/received_events","type":"User","site_admin":false},"body":"нужно будет потом заменить эти img на svg код","created_at":"2017-11-23T12:49:05Z","updated_at":"2017-11-23T12:49:06Z","html_url":"https://github.com/htmlacademy-htmlcss/294647-gllacy/pull/5#discussion_r152792898","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/comments/152792898"},"html":{"href":"https://github.com/htmlacademy-htmlcss/294647-gllacy/pull/5#discussion_r152792898"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/5","id":154275208,"html_url":"https://github.com/htmlacademy-htmlcss/294647-gllacy/pull/5","diff_url":"https://github.com/htmlacademy-htmlcss/294647-gllacy/pull/5.diff","patch_url":"https://github.com/htmlacademy-htmlcss/294647-gllacy/pull/5.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/issues/5","number":5,"state":"open","locked":false,"title":"Сетка личного проекта на флексах","user":{"login":"potomkina","id":33158755,"avatar_url":"https://avatars0.githubusercontent.com/u/33158755?v=4","gravatar_id":"","url":"https://api.github.com/users/potomkina","html_url":"https://github.com/potomkina","followers_url":"https://api.github.com/users/potomkina/followers","following_url":"https://api.github.com/users/potomkina/following{/other_user}","gists_url":"https://api.github.com/users/potomkina/gists{/gist_id}","starred_url":"https://api.github.com/users/potomkina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potomkina/subscriptions","organizations_url":"https://api.github.com/users/potomkina/orgs","repos_url":"https://api.github.com/users/potomkina/repos","events_url":"https://api.github.com/users/potomkina/events{/privacy}","received_events_url":"https://api.github.com/users/potomkina/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Сетка личного проекта на флексах](https://up.htmlacademy.ru/htmlcss/19/user/294647/tasks/42)","created_at":"2017-11-22T23:26:29Z","updated_at":"2017-11-23T12:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d34a523b0c6c791bb27c23eaa6224dd9a6f39f4d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/5/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/5/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/issues/5/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/statuses/02f512e38befdd09a47c27cb15e32d17ae0e044c","head":{"label":"potomkina:master","ref":"master","sha":"02f512e38befdd09a47c27cb15e32d17ae0e044c","user":{"login":"potomkina","id":33158755,"avatar_url":"https://avatars0.githubusercontent.com/u/33158755?v=4","gravatar_id":"","url":"https://api.github.com/users/potomkina","html_url":"https://github.com/potomkina","followers_url":"https://api.github.com/users/potomkina/followers","following_url":"https://api.github.com/users/potomkina/following{/other_user}","gists_url":"https://api.github.com/users/potomkina/gists{/gist_id}","starred_url":"https://api.github.com/users/potomkina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potomkina/subscriptions","organizations_url":"https://api.github.com/users/potomkina/orgs","repos_url":"https://api.github.com/users/potomkina/repos","events_url":"https://api.github.com/users/potomkina/events{/privacy}","received_events_url":"https://api.github.com/users/potomkina/received_events","type":"User","site_admin":false},"repo":{"id":109045008,"name":"294647-gllacy","full_name":"potomkina/294647-gllacy","owner":{"login":"potomkina","id":33158755,"avatar_url":"https://avatars0.githubusercontent.com/u/33158755?v=4","gravatar_id":"","url":"https://api.github.com/users/potomkina","html_url":"https://github.com/potomkina","followers_url":"https://api.github.com/users/potomkina/followers","following_url":"https://api.github.com/users/potomkina/following{/other_user}","gists_url":"https://api.github.com/users/potomkina/gists{/gist_id}","starred_url":"https://api.github.com/users/potomkina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potomkina/subscriptions","organizations_url":"https://api.github.com/users/potomkina/orgs","repos_url":"https://api.github.com/users/potomkina/repos","events_url":"https://api.github.com/users/potomkina/events{/privacy}","received_events_url":"https://api.github.com/users/potomkina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/potomkina/294647-gllacy","description":"Анна Потёмкина","fork":true,"url":"https://api.github.com/repos/potomkina/294647-gllacy","forks_url":"https://api.github.com/repos/potomkina/294647-gllacy/forks","keys_url":"https://api.github.com/repos/potomkina/294647-gllacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/potomkina/294647-gllacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/potomkina/294647-gllacy/teams","hooks_url":"https://api.github.com/repos/potomkina/294647-gllacy/hooks","issue_events_url":"https://api.github.com/repos/potomkina/294647-gllacy/issues/events{/number}","events_url":"https://api.github.com/repos/potomkina/294647-gllacy/events","assignees_url":"https://api.github.com/repos/potomkina/294647-gllacy/assignees{/user}","branches_url":"https://api.github.com/repos/potomkina/294647-gllacy/branches{/branch}","tags_url":"https://api.github.com/repos/potomkina/294647-gllacy/tags","blobs_url":"https://api.github.com/repos/potomkina/294647-gllacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/potomkina/294647-gllacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/potomkina/294647-gllacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/potomkina/294647-gllacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/potomkina/294647-gllacy/statuses/{sha}","languages_url":"https://api.github.com/repos/potomkina/294647-gllacy/languages","stargazers_url":"https://api.github.com/repos/potomkina/294647-gllacy/stargazers","contributors_url":"https://api.github.com/repos/potomkina/294647-gllacy/contributors","subscribers_url":"https://api.github.com/repos/potomkina/294647-gllacy/subscribers","subscription_url":"https://api.github.com/repos/potomkina/294647-gllacy/subscription","commits_url":"https://api.github.com/repos/potomkina/294647-gllacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/potomkina/294647-gllacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/potomkina/294647-gllacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/potomkina/294647-gllacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/potomkina/294647-gllacy/contents/{+path}","compare_url":"https://api.github.com/repos/potomkina/294647-gllacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/potomkina/294647-gllacy/merges","archive_url":"https://api.github.com/repos/potomkina/294647-gllacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/potomkina/294647-gllacy/downloads","issues_url":"https://api.github.com/repos/potomkina/294647-gllacy/issues{/number}","pulls_url":"https://api.github.com/repos/potomkina/294647-gllacy/pulls{/number}","milestones_url":"https://api.github.com/repos/potomkina/294647-gllacy/milestones{/number}","notifications_url":"https://api.github.com/repos/potomkina/294647-gllacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/potomkina/294647-gllacy/labels{/name}","releases_url":"https://api.github.com/repos/potomkina/294647-gllacy/releases{/id}","deployments_url":"https://api.github.com/repos/potomkina/294647-gllacy/deployments","created_at":"2017-10-31T19:47:30Z","updated_at":"2017-10-31T19:47:32Z","pushed_at":"2017-11-22T23:23:11Z","git_url":"git://github.com/potomkina/294647-gllacy.git","ssh_url":"[email protected]:potomkina/294647-gllacy.git","clone_url":"https://github.com/potomkina/294647-gllacy.git","svn_url":"https://github.com/potomkina/294647-gllacy","homepage":null,"size":3825,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"0270d1429a517d3f10e4352dc53cf06e945cf860","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":108982586,"name":"294647-gllacy","full_name":"htmlacademy-htmlcss/294647-gllacy","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars3.githubusercontent.com/u/16576942?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/294647-gllacy","description":"Анна Потёмкина","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/deployments","created_at":"2017-10-31T10:52:47Z","updated_at":"2017-10-31T20:00:22Z","pushed_at":"2017-11-22T23:26:29Z","git_url":"git://github.com/htmlacademy-htmlcss/294647-gllacy.git","ssh_url":"[email protected]:htmlacademy-htmlcss/294647-gllacy.git","clone_url":"https://github.com/htmlacademy-htmlcss/294647-gllacy.git","svn_url":"https://github.com/htmlacademy-htmlcss/294647-gllacy","homepage":"https://github.com/potomkina/294647-gllacy","size":3622,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/5"},"html":{"href":"https://github.com/htmlacademy-htmlcss/294647-gllacy/pull/5"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/issues/5"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy/statuses/02f512e38befdd09a47c27cb15e32d17ae0e044c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 108982586,
"name": "htmlacademy-htmlcss/294647-gllacy",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/294647-gllacy"
} | {
"id": 18405633,
"login": "artemka107",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18405633?",
"url": "https://api.github.com/users/artemka107"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-11-23T12:49:05 | 6895154702 | {"actor":{"display_login":"artemka107"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/comments/97501246","pull_request_review_id":18111424,"id":97501246,"diff_hunk":"@@ -5,8 +5,199 @@\n <title>HTML Academy: Глейси</title>\n </head>\n <body>\n-\n- <p>Репозиторий создан для обучения на интенсивном онлайн‑курсе «<a href=\"https://htmlacademy.ru/intensive/htmlcss\">Базовый HTML и CSS</a>».</p>\n-\n+ <header class=\"main-header\">\n+ <div class=\"container\">\n+ <a class=\"logo\" href=\"#\">\n+ <img src=\"http://placehold.it/150x50\" width=\"150\" height=\"50\" alt=\"Магазин «Глейси»\">\n+ </a>\n+ <nav class=\"main-navigation\">\n+ <ul>\n+ <li>\n+ <a href=\"#\">Каталог</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">Доставка и оплата</a>\n+ </li>\n+ <li>\n+ <a href=\"#\">О Компании</a>\n+ </li>\n+ </ul>\n+ </nav>\n+ <div class=\"user-block\">\n+ <a class=\"search\" href=\"#\">\n+ <img src=\"http://placehold.it/20x20\" width=\"20\" height=\"20\" alt=\"Поиск\">\n+ </a>\n+ <a class=\"login\" href=\"#\">Вход</a>\n+ <a class=\"basket\" href=\"#\">Пусто</a>\n+ </div>\n+ <div class=\"time-work\">\n+ <p>с 10 до 20, ежедневно<br>\n+ <b>8 812 450-25-25</b>\n+ </p>\n+ </div>\n+ </div>\n+ </header>\n+ <main class=\"inner-main\">\n+ <div class=\"container\">\n+ <section class=\"slider\">\n+ <input type=\"radio\" id=\"btn-1\" name=\"toggle\" checked>\n+ <input type=\"radio\" id=\"btn-2\" name=\"toggle\">\n+ <input type=\"radio\" id=\"btn-3\" name=\"toggle\">\n+ <div class=\"slide\" id=\"slide1\">\n+ <img src=\"http://placehold.it/500x300\" width=\"500\" height=\"300\" alt=\"Крем-брюле и пломбир с малиновым джемом\">\n+ <div class=\"slide-title\">Крем-брюле и пломбир с малиновым джемом</div>\n+ <a class=\"slide-btn\" href=\"#\">Давайте оба!</a>\n+ </div>\n+ <div class=\"slide\" id=\"slide2\">\n+ <img src=\"http://placehold.it/500x300\" width=\"500\" height=\"300\" alt=\"Шоколадный пломбир и лимонный сорбет\">\n+ <div class=\"slide-title\">Шоколадный пломбир и лимонный сорбет</div>\n+ <a class=\"slide-btn\" href=\"#\">Давайте оба!</a>\n+ </div>\n+ <div class=\"slide\" id=\"slide3\">\n+ <img src=\"http://placehold.it/500x300\" width=\"500\" height=\"300\" alt=\"Пломбир с помадкой и клубничный щербет\">\n+ <div class=\"slide-title\">Пломбир с помадкой и клубничный щербет</div>\n+ <a class=\"slide-btn\" href=\"#\">Давайте оба!</a>\n+ </div>\n+ <div class=\"slider-controls\">\n+ <label for=\"btn-1\"></label>\n+ <label for=\"btn-2\"></label>\n+ <label for=\"btn-3\"></label>\n+ </div>\n+ </section>\n+ <section class=\"action\">\n+ <article class=\"action-item\">\n+ <b class=\"action-name\">Малинка даром!</b>\n+ <p>При покупке 2 кг любого фруктового мороженого, добавим в ваш заказ банку малинового варенья бесплатно.</p>\n+ <a class=\"action-btn\" href=\"#\">Хочу варенье!</a>\n+ </article>\n+ <article class=\"action-item\">\n+ <b class=\"action-name\">Шоколадки даром!</b>\n+ <p>При покупке 2 кг пломбира, добавим в ваш заказ упаковку вкуснейшей шоколадной присыпки совершенно бесплатно.</p>\n+ <a class=\"action-btn\" href=\"#\">Хочу шоколадки!</a>\n+ </article>\n+ </section>\n+ <section class=\"popular-items\">\n+ <article class=\"catalog-item\">\n+ <a class=\"catalog-item-img\" href=\"#\">","path":"index.html","position":80,"original_position":80,"commit_id":"030f82c9fb52ffd0a03ac0a074eac93d1979fef4","original_commit_id":"030f82c9fb52ffd0a03ac0a074eac93d1979fef4","user":{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars.githubusercontent.com/u/9842814?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"body":"здесь просто img ссылку удали","created_at":"2017-01-24T09:12:11Z","updated_at":"2017-01-24T09:12:11Z","html_url":"https://github.com/htmlacademy-htmlcss/300839-gllacy/pull/2#discussion_r97501246","pull_request_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/comments/97501246"},"html":{"href":"https://github.com/htmlacademy-htmlcss/300839-gllacy/pull/2#discussion_r97501246"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/2","id":102692379,"html_url":"https://github.com/htmlacademy-htmlcss/300839-gllacy/pull/2","diff_url":"https://github.com/htmlacademy-htmlcss/300839-gllacy/pull/2.diff","patch_url":"https://github.com/htmlacademy-htmlcss/300839-gllacy/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/issues/2","number":2,"state":"open","locked":false,"title":"Разметка личного проекта","user":{"login":"Pampushka-Lju","id":25172283,"avatar_url":"https://avatars.githubusercontent.com/u/25172283?v=3","gravatar_id":"","url":"https://api.github.com/users/Pampushka-Lju","html_url":"https://github.com/Pampushka-Lju","followers_url":"https://api.github.com/users/Pampushka-Lju/followers","following_url":"https://api.github.com/users/Pampushka-Lju/following{/other_user}","gists_url":"https://api.github.com/users/Pampushka-Lju/gists{/gist_id}","starred_url":"https://api.github.com/users/Pampushka-Lju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pampushka-Lju/subscriptions","organizations_url":"https://api.github.com/users/Pampushka-Lju/orgs","repos_url":"https://api.github.com/users/Pampushka-Lju/repos","events_url":"https://api.github.com/users/Pampushka-Lju/events{/privacy}","received_events_url":"https://api.github.com/users/Pampushka-Lju/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Разметка личного проекта](https://up.htmlacademy.ru/htmlcss/16/user/300839/tasks/16)","created_at":"2017-01-23T10:32:56Z","updated_at":"2017-01-24T09:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b76534a8b3130cdb3bd01630d31c901d336a9d72","assignee":{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars.githubusercontent.com/u/9842814?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars.githubusercontent.com/u/9842814?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/statuses/030f82c9fb52ffd0a03ac0a074eac93d1979fef4","head":{"label":"Pampushka-Lju:master","ref":"master","sha":"030f82c9fb52ffd0a03ac0a074eac93d1979fef4","user":{"login":"Pampushka-Lju","id":25172283,"avatar_url":"https://avatars.githubusercontent.com/u/25172283?v=3","gravatar_id":"","url":"https://api.github.com/users/Pampushka-Lju","html_url":"https://github.com/Pampushka-Lju","followers_url":"https://api.github.com/users/Pampushka-Lju/followers","following_url":"https://api.github.com/users/Pampushka-Lju/following{/other_user}","gists_url":"https://api.github.com/users/Pampushka-Lju/gists{/gist_id}","starred_url":"https://api.github.com/users/Pampushka-Lju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pampushka-Lju/subscriptions","organizations_url":"https://api.github.com/users/Pampushka-Lju/orgs","repos_url":"https://api.github.com/users/Pampushka-Lju/repos","events_url":"https://api.github.com/users/Pampushka-Lju/events{/privacy}","received_events_url":"https://api.github.com/users/Pampushka-Lju/received_events","type":"User","site_admin":false},"repo":{"id":79415441,"name":"300839-gllacy","full_name":"Pampushka-Lju/300839-gllacy","owner":{"login":"Pampushka-Lju","id":25172283,"avatar_url":"https://avatars.githubusercontent.com/u/25172283?v=3","gravatar_id":"","url":"https://api.github.com/users/Pampushka-Lju","html_url":"https://github.com/Pampushka-Lju","followers_url":"https://api.github.com/users/Pampushka-Lju/followers","following_url":"https://api.github.com/users/Pampushka-Lju/following{/other_user}","gists_url":"https://api.github.com/users/Pampushka-Lju/gists{/gist_id}","starred_url":"https://api.github.com/users/Pampushka-Lju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pampushka-Lju/subscriptions","organizations_url":"https://api.github.com/users/Pampushka-Lju/orgs","repos_url":"https://api.github.com/users/Pampushka-Lju/repos","events_url":"https://api.github.com/users/Pampushka-Lju/events{/privacy}","received_events_url":"https://api.github.com/users/Pampushka-Lju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pampushka-Lju/300839-gllacy","description":"Альбина Сафина","fork":true,"url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy","forks_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/forks","keys_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/teams","hooks_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/hooks","issue_events_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/issues/events{/number}","events_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/events","assignees_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/assignees{/user}","branches_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/branches{/branch}","tags_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/tags","blobs_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/statuses/{sha}","languages_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/languages","stargazers_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/stargazers","contributors_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/contributors","subscribers_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/subscribers","subscription_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/subscription","commits_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/contents/{+path}","compare_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/merges","archive_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/downloads","issues_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/issues{/number}","pulls_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/pulls{/number}","milestones_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/milestones{/number}","notifications_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/labels{/name}","releases_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/releases{/id}","deployments_url":"https://api.github.com/repos/Pampushka-Lju/300839-gllacy/deployments","created_at":"2017-01-19T04:28:01Z","updated_at":"2017-01-19T04:28:02Z","pushed_at":"2017-01-23T10:20:56Z","git_url":"git://github.com/Pampushka-Lju/300839-gllacy.git","ssh_url":"[email protected]:Pampushka-Lju/300839-gllacy.git","clone_url":"https://github.com/Pampushka-Lju/300839-gllacy.git","svn_url":"https://github.com/Pampushka-Lju/300839-gllacy","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-htmlcss:master","ref":"master","sha":"bc08b31d531264fc5d9bd94202eb8c5590d94743","user":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars.githubusercontent.com/u/16576942?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"repo":{"id":79241343,"name":"300839-gllacy","full_name":"htmlacademy-htmlcss/300839-gllacy","owner":{"login":"htmlacademy-htmlcss","id":16576942,"avatar_url":"https://avatars.githubusercontent.com/u/16576942?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-htmlcss","html_url":"https://github.com/htmlacademy-htmlcss","followers_url":"https://api.github.com/users/htmlacademy-htmlcss/followers","following_url":"https://api.github.com/users/htmlacademy-htmlcss/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-htmlcss/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-htmlcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-htmlcss/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-htmlcss/orgs","repos_url":"https://api.github.com/users/htmlacademy-htmlcss/repos","events_url":"https://api.github.com/users/htmlacademy-htmlcss/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-htmlcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-htmlcss/300839-gllacy","description":"Альбина Сафина","fork":false,"url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy","forks_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/forks","keys_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/teams","hooks_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/events","assignees_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/tags","blobs_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/subscription","commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/merges","archive_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/downloads","issues_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/deployments","created_at":"2017-01-17T15:30:05Z","updated_at":"2017-01-19T05:40:31Z","pushed_at":"2017-01-23T10:32:57Z","git_url":"git://github.com/htmlacademy-htmlcss/300839-gllacy.git","ssh_url":"[email protected]:htmlacademy-htmlcss/300839-gllacy.git","clone_url":"https://github.com/htmlacademy-htmlcss/300839-gllacy.git","svn_url":"https://github.com/htmlacademy-htmlcss/300839-gllacy","homepage":"https://github.com/Pampushka-Lju/300839-gllacy","size":7,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/2"},"html":{"href":"https://github.com/htmlacademy-htmlcss/300839-gllacy/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy/statuses/030f82c9fb52ffd0a03ac0a074eac93d1979fef4"}}}} | {
"id": 79241343,
"name": "htmlacademy-htmlcss/300839-gllacy",
"url": "https://api.github.com/repos/htmlacademy-htmlcss/300839-gllacy"
} | {
"id": 9842814,
"login": "sergeykravchenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9842814?",
"url": "https://api.github.com/users/sergeykravchenko"
} | {
"id": 16576942,
"login": "htmlacademy-htmlcss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16576942?",
"url": "https://api.github.com/orgs/htmlacademy-htmlcss"
} | 2017-01-24T09:12:11 | 5202329354 | {"actor":{"display_login":"sergeykravchenko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/132791661","pull_request_review_id":55916238,"id":132791661,"diff_hunk":"@@ -59,7 +59,7 @@ The provided modifiers are:\n | --------------------- | ------------------------------------------------------- |\n | `mdc-linear-progress--indeterminate` | Puts the linear progress indicator in an indeterminate state. |\n | `mdc-linear-progress--reversed` | Reverses the direction of the linear progress indicator. |\n-| `mdc-linear-progress--accent` | Colors the button with the accent color. |\n+| `mdc-linear-progress--accent` | Colors the button with the secondary color. |","path":"packages/mdc-linear-progress/README.md","position":null,"original_position":5,"commit_id":"14810b67b1cd21edfef00eab68bbf75e3c15c21d","original_commit_id":"3e3b81e4a6bb56a6f2b6c05fc0e8b06fb97e9430","user":{"login":"acdvorak","id":409245,"avatar_url":"https://avatars1.githubusercontent.com/u/409245?v=4","gravatar_id":"","url":"https://api.github.com/users/acdvorak","html_url":"https://github.com/acdvorak","followers_url":"https://api.github.com/users/acdvorak/followers","following_url":"https://api.github.com/users/acdvorak/following{/other_user}","gists_url":"https://api.github.com/users/acdvorak/gists{/gist_id}","starred_url":"https://api.github.com/users/acdvorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdvorak/subscriptions","organizations_url":"https://api.github.com/users/acdvorak/orgs","repos_url":"https://api.github.com/users/acdvorak/repos","events_url":"https://api.github.com/users/acdvorak/events{/privacy}","received_events_url":"https://api.github.com/users/acdvorak/received_events","type":"User","site_admin":false},"body":"Done - looks like an old copy/paste bug 🙂 ","created_at":"2017-08-11T22:00:35Z","updated_at":"2017-08-11T22:00:35Z","html_url":"https://github.com/material-components/material-components-web/pull/1116#discussion_r132791661","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/1116","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/132791661"},"html":{"href":"https://github.com/material-components/material-components-web/pull/1116#discussion_r132791661"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/1116"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/1116","id":135249957,"html_url":"https://github.com/material-components/material-components-web/pull/1116","diff_url":"https://github.com/material-components/material-components-web/pull/1116.diff","patch_url":"https://github.com/material-components/material-components-web/pull/1116.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/1116","number":1116,"state":"open","locked":false,"title":"feat(theme): Add light/dark variants for primary/secondary color, and rename `accent` to `secondary`","user":{"login":"acdvorak","id":409245,"avatar_url":"https://avatars1.githubusercontent.com/u/409245?v=4","gravatar_id":"","url":"https://api.github.com/users/acdvorak","html_url":"https://github.com/acdvorak","followers_url":"https://api.github.com/users/acdvorak/followers","following_url":"https://api.github.com/users/acdvorak/following{/other_user}","gists_url":"https://api.github.com/users/acdvorak/gists{/gist_id}","starred_url":"https://api.github.com/users/acdvorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdvorak/subscriptions","organizations_url":"https://api.github.com/users/acdvorak/orgs","repos_url":"https://api.github.com/users/acdvorak/repos","events_url":"https://api.github.com/users/acdvorak/events{/privacy}","received_events_url":"https://api.github.com/users/acdvorak/received_events","type":"User","site_admin":false},"body":"* In the spec, \"accent\" was renamed to \"secondary\".\r\n* This PR only changes \"accent\" to \"secondary\" for variables defined within the `mdc-theme` package. Modifier classes for individual components (e.g., `mdc-button--accent`) remain unchanged for now.\r\n* For backward compatibility, `$mdc-theme-accent` still exists, and `$mdc-theme-secondary` points to it. This ensures that clients that were previously overriding `$mdc-theme-accent` will continue to work.\r\n* Light/dark tonal variants are not yet being used, but will become used soon when we update our components to align with an upcoming version of the spec.\r\n\r\nBREAKING CHANGE","created_at":"2017-08-11T00:35:04Z","updated_at":"2017-08-11T22:00:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"300ddc4ec8d458e2c4d0d7908cba489dbe78971a","assignee":{"login":"lynnjepsen","id":4703432,"avatar_url":"https://avatars2.githubusercontent.com/u/4703432?v=4","gravatar_id":"","url":"https://api.github.com/users/lynnjepsen","html_url":"https://github.com/lynnjepsen","followers_url":"https://api.github.com/users/lynnjepsen/followers","following_url":"https://api.github.com/users/lynnjepsen/following{/other_user}","gists_url":"https://api.github.com/users/lynnjepsen/gists{/gist_id}","starred_url":"https://api.github.com/users/lynnjepsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynnjepsen/subscriptions","organizations_url":"https://api.github.com/users/lynnjepsen/orgs","repos_url":"https://api.github.com/users/lynnjepsen/repos","events_url":"https://api.github.com/users/lynnjepsen/events{/privacy}","received_events_url":"https://api.github.com/users/lynnjepsen/received_events","type":"User","site_admin":false},"assignees":[{"login":"lynnjepsen","id":4703432,"avatar_url":"https://avatars2.githubusercontent.com/u/4703432?v=4","gravatar_id":"","url":"https://api.github.com/users/lynnjepsen","html_url":"https://github.com/lynnjepsen","followers_url":"https://api.github.com/users/lynnjepsen/followers","following_url":"https://api.github.com/users/lynnjepsen/following{/other_user}","gists_url":"https://api.github.com/users/lynnjepsen/gists{/gist_id}","starred_url":"https://api.github.com/users/lynnjepsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynnjepsen/subscriptions","organizations_url":"https://api.github.com/users/lynnjepsen/orgs","repos_url":"https://api.github.com/users/lynnjepsen/repos","events_url":"https://api.github.com/users/lynnjepsen/events{/privacy}","received_events_url":"https://api.github.com/users/lynnjepsen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/material-components/material-components-web/milestones/8","html_url":"https://github.com/material-components/material-components-web/milestone/8","labels_url":"https://api.github.com/repos/material-components/material-components-web/milestones/8/labels","id":2689873,"number":8,"title":"Theme Improvements","description":"- Make color theming more parameterizable and consistent across all components.\r\n- Add light & dark tonal variants for primary and secondary (aka accent) colors.\r\n- Create SCSS mixins for all components to allow easy custom color theming.\r\n- Improve theming support on demo pages (including dark mode).","creator":{"login":"acdvorak","id":409245,"avatar_url":"https://avatars1.githubusercontent.com/u/409245?v=4","gravatar_id":"","url":"https://api.github.com/users/acdvorak","html_url":"https://github.com/acdvorak","followers_url":"https://api.github.com/users/acdvorak/followers","following_url":"https://api.github.com/users/acdvorak/following{/other_user}","gists_url":"https://api.github.com/users/acdvorak/gists{/gist_id}","starred_url":"https://api.github.com/users/acdvorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdvorak/subscriptions","organizations_url":"https://api.github.com/users/acdvorak/orgs","repos_url":"https://api.github.com/users/acdvorak/repos","events_url":"https://api.github.com/users/acdvorak/events{/privacy}","received_events_url":"https://api.github.com/users/acdvorak/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":2,"state":"open","created_at":"2017-08-09T05:12:29Z","updated_at":"2017-08-11T21:43:33Z","due_on":"2017-09-19T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/1116/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/1116/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/1116/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/14810b67b1cd21edfef00eab68bbf75e3c15c21d","head":{"label":"material-components:feat/m2-theme/step02-light-dark-variants","ref":"feat/m2-theme/step02-light-dark-variants","sha":"14810b67b1cd21edfef00eab68bbf75e3c15c21d","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2017-08-11T17:33:20Z","pushed_at":"2017-08-11T22:00:27Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"[email protected]:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":52888,"stargazers_count":5561,"watchers_count":5561,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":569,"mirror_url":null,"open_issues_count":210,"forks":569,"open_issues":210,"watchers":5561,"default_branch":"master"}},"base":{"label":"material-components:master","ref":"master","sha":"05e83e98fbea54b1b430b71dee69b25f50b56efd","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2017-08-11T17:33:20Z","pushed_at":"2017-08-11T22:00:27Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"[email protected]:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":52888,"stargazers_count":5561,"watchers_count":5561,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":569,"mirror_url":null,"open_issues_count":210,"forks":569,"open_issues":210,"watchers":5561,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/1116"},"html":{"href":"https://github.com/material-components/material-components-web/pull/1116"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/1116"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/1116/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/1116/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/1116/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/14810b67b1cd21edfef00eab68bbf75e3c15c21d"}}}} | {
"id": 75642389,
"name": "material-components/material-components-web",
"url": "https://api.github.com/repos/material-components/material-components-web"
} | {
"id": 409245,
"login": "acdvorak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/409245?",
"url": "https://api.github.com/users/acdvorak"
} | {
"id": 19478152,
"login": "material-components",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19478152?",
"url": "https://api.github.com/orgs/material-components"
} | 2017-08-11T22:00:35 | 6443478057 | {"actor":{"display_login":"acdvorak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/comments/100717107","pull_request_review_id":21429996,"id":100717107,"diff_hunk":"@@ -0,0 +1,10 @@\n+package seedu.addressbook.data.person;\n+\n+public interface Printable {","path":"src/seedu/addressbook/data/person/Printable.java","position":3,"original_position":3,"commit_id":"6bf2e8de48f73f72dbe49f1dad314fbfb703d138","original_commit_id":"6bf2e8de48f73f72dbe49f1dad314fbfb703d138","user":{"login":"sooyj","id":8551571,"avatar_url":"https://avatars.githubusercontent.com/u/8551571?v=3","gravatar_id":"","url":"https://api.github.com/users/sooyj","html_url":"https://github.com/sooyj","followers_url":"https://api.github.com/users/sooyj/followers","following_url":"https://api.github.com/users/sooyj/following{/other_user}","gists_url":"https://api.github.com/users/sooyj/gists{/gist_id}","starred_url":"https://api.github.com/users/sooyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooyj/subscriptions","organizations_url":"https://api.github.com/users/sooyj/orgs","repos_url":"https://api.github.com/users/sooyj/repos","events_url":"https://api.github.com/users/sooyj/events{/privacy}","received_events_url":"https://api.github.com/users/sooyj/received_events","type":"User","site_admin":false},"body":"Good job on defining the interface properly. Remember to add simple header comment :-). ","created_at":"2017-02-13T02:48:51Z","updated_at":"2017-02-13T02:49:10Z","html_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/872#discussion_r100717107","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/872","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/comments/100717107"},"html":{"href":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/872#discussion_r100717107"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/872"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/872","id":105370931,"html_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/872","diff_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/872.diff","patch_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/872.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/872","number":872,"state":"open","locked":false,"title":"[T4A4][T15-A4]Peng Chong","user":{"login":"Ellie-Peng","id":22662651,"avatar_url":"https://avatars.githubusercontent.com/u/22662651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ellie-Peng","html_url":"https://github.com/Ellie-Peng","followers_url":"https://api.github.com/users/Ellie-Peng/followers","following_url":"https://api.github.com/users/Ellie-Peng/following{/other_user}","gists_url":"https://api.github.com/users/Ellie-Peng/gists{/gist_id}","starred_url":"https://api.github.com/users/Ellie-Peng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ellie-Peng/subscriptions","organizations_url":"https://api.github.com/users/Ellie-Peng/orgs","repos_url":"https://api.github.com/users/Ellie-Peng/repos","events_url":"https://api.github.com/users/Ellie-Peng/events{/privacy}","received_events_url":"https://api.github.com/users/Ellie-Peng/received_events","type":"User","site_admin":false},"body":"Ready for Review","created_at":"2017-02-09T07:06:27Z","updated_at":"2017-02-13T02:49:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a5170e797ef7f52e39ac9b837184ebfba538fde","assignee":{"login":"sooyj","id":8551571,"avatar_url":"https://avatars.githubusercontent.com/u/8551571?v=3","gravatar_id":"","url":"https://api.github.com/users/sooyj","html_url":"https://github.com/sooyj","followers_url":"https://api.github.com/users/sooyj/followers","following_url":"https://api.github.com/users/sooyj/following{/other_user}","gists_url":"https://api.github.com/users/sooyj/gists{/gist_id}","starred_url":"https://api.github.com/users/sooyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooyj/subscriptions","organizations_url":"https://api.github.com/users/sooyj/orgs","repos_url":"https://api.github.com/users/sooyj/repos","events_url":"https://api.github.com/users/sooyj/events{/privacy}","received_events_url":"https://api.github.com/users/sooyj/received_events","type":"User","site_admin":false},"assignees":[{"login":"sooyj","id":8551571,"avatar_url":"https://avatars.githubusercontent.com/u/8551571?v=3","gravatar_id":"","url":"https://api.github.com/users/sooyj","html_url":"https://github.com/sooyj","followers_url":"https://api.github.com/users/sooyj/followers","following_url":"https://api.github.com/users/sooyj/following{/other_user}","gists_url":"https://api.github.com/users/sooyj/gists{/gist_id}","starred_url":"https://api.github.com/users/sooyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooyj/subscriptions","organizations_url":"https://api.github.com/users/sooyj/orgs","repos_url":"https://api.github.com/users/sooyj/repos","events_url":"https://api.github.com/users/sooyj/events{/privacy}","received_events_url":"https://api.github.com/users/sooyj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/872/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/872/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/872/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/statuses/6bf2e8de48f73f72dbe49f1dad314fbfb703d138","head":{"label":"Ellie-Peng:T4A4","ref":"T4A4","sha":"6bf2e8de48f73f72dbe49f1dad314fbfb703d138","user":{"login":"Ellie-Peng","id":22662651,"avatar_url":"https://avatars.githubusercontent.com/u/22662651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ellie-Peng","html_url":"https://github.com/Ellie-Peng","followers_url":"https://api.github.com/users/Ellie-Peng/followers","following_url":"https://api.github.com/users/Ellie-Peng/following{/other_user}","gists_url":"https://api.github.com/users/Ellie-Peng/gists{/gist_id}","starred_url":"https://api.github.com/users/Ellie-Peng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ellie-Peng/subscriptions","organizations_url":"https://api.github.com/users/Ellie-Peng/orgs","repos_url":"https://api.github.com/users/Ellie-Peng/repos","events_url":"https://api.github.com/users/Ellie-Peng/events{/privacy}","received_events_url":"https://api.github.com/users/Ellie-Peng/received_events","type":"User","site_admin":false},"repo":{"id":80574279,"name":"addressbook-level2","full_name":"Ellie-Peng/addressbook-level2","owner":{"login":"Ellie-Peng","id":22662651,"avatar_url":"https://avatars.githubusercontent.com/u/22662651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ellie-Peng","html_url":"https://github.com/Ellie-Peng","followers_url":"https://api.github.com/users/Ellie-Peng/followers","following_url":"https://api.github.com/users/Ellie-Peng/following{/other_user}","gists_url":"https://api.github.com/users/Ellie-Peng/gists{/gist_id}","starred_url":"https://api.github.com/users/Ellie-Peng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ellie-Peng/subscriptions","organizations_url":"https://api.github.com/users/Ellie-Peng/orgs","repos_url":"https://api.github.com/users/Ellie-Peng/repos","events_url":"https://api.github.com/users/Ellie-Peng/events{/privacy}","received_events_url":"https://api.github.com/users/Ellie-Peng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ellie-Peng/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2","forks_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/forks","keys_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/events","assignees_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/merges","archive_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/Ellie-Peng/addressbook-level2/deployments","created_at":"2017-01-31T23:50:28Z","updated_at":"2017-01-31T23:50:30Z","pushed_at":"2017-02-11T12:51:57Z","git_url":"git://github.com/Ellie-Peng/addressbook-level2.git","ssh_url":"[email protected]:Ellie-Peng/addressbook-level2.git","clone_url":"https://github.com/Ellie-Peng/addressbook-level2.git","svn_url":"https://github.com/Ellie-Peng/addressbook-level2","homepage":null,"size":3119,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1617S2:master","ref":"master","sha":"7614ce12db98852ef53a42c50c89b87fad0a2872","user":{"login":"nus-cs2103-AY1617S2","id":24604536,"avatar_url":"https://avatars.githubusercontent.com/u/24604536?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1617S2","html_url":"https://github.com/nus-cs2103-AY1617S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1617S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1617S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1617S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1617S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1617S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1617S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1617S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1617S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1617S2/received_events","type":"Organization","site_admin":false},"repo":{"id":76956252,"name":"addressbook-level2","full_name":"nus-cs2103-AY1617S2/addressbook-level2","owner":{"login":"nus-cs2103-AY1617S2","id":24604536,"avatar_url":"https://avatars.githubusercontent.com/u/24604536?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1617S2","html_url":"https://github.com/nus-cs2103-AY1617S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1617S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1617S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1617S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1617S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1617S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1617S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1617S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1617S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1617S2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/deployments","created_at":"2016-12-20T12:51:37Z","updated_at":"2017-02-01T14:41:26Z","pushed_at":"2017-02-12T15:52:07Z","git_url":"git://github.com/nus-cs2103-AY1617S2/addressbook-level2.git","ssh_url":"[email protected]:nus-cs2103-AY1617S2/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2","homepage":null,"size":3101,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":655,"forks":166,"open_issues":655,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/872"},"html":{"href":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/872"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/872"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/872/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/872/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/872/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/statuses/6bf2e8de48f73f72dbe49f1dad314fbfb703d138"}}}} | {
"id": 76956252,
"name": "nus-cs2103-AY1617S2/addressbook-level2",
"url": "https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2"
} | {
"id": 8551571,
"login": "sooyj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8551571?",
"url": "https://api.github.com/users/sooyj"
} | {
"id": 24604536,
"login": "nus-cs2103-AY1617S2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24604536?",
"url": "https://api.github.com/orgs/nus-cs2103-AY1617S2"
} | 2017-02-13T02:48:51 | 5311301478 | {"actor":{"display_login":"sooyj"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/comments/144384469","pull_request_review_id":69035044,"id":144384469,"diff_hunk":"@@ -16627,24 +17141,35 @@ IndexResult = ss_client.Webhooks.list_webhooks(\n \t\"pageSize\": 100,\n \t\"totalPages\": 1,\n \t\"totalCount\": 1,\n-\t\"data\": [\n-\t\t{\n-\t\t\t\"id\": 4503604829677444,\n-\t\t\t\"name\": \"Webhook #5\",\n-\t\t\t\"scope\": \"sheet\",\n-\t\t\t\"scopeObjectId\": 6761855684241284,\n-\t\t\t\"events\": [\n-\t\t\t\t\"*.*\"\n-\t\t\t],\n-\t\t\t\"callbackUrl\": \"http://www.myApp.com/webhooks\",\n-\t\t\t\"sharedSecret\": \"216ejjzdnq17mq1q8xs7d4hu8b\",\n-\t\t\t\"enabled\": true,\n-\t\t\t\"status\": \"ENABLED\",\n-\t\t\t\"version\": 1,\n-\t\t\t\"createdAt\": \"2015-11-03T14:52:21Z\",\n-\t\t\t\"modifiedAt\": \"2015-11-04T19:05:40Z\"\n-\t\t}\n-\t]\n+ \"data\": \n+ [{\n+ \"id\": 4503604829677444,\n+ \"name\": \"Webhook #5\",\n+ \"scope\": \"sheet\",\n+ \"scopeObjectId\": 6761855684241284,\n+ \"events\": [ \"*.*\" ],\n+ \"callbackUrl\": \"http://www.myApp.com/webhooks\",\n+ \"sharedSecret\": \"216ejjzfoo17mq1q8xs7d4hu8b\",\n+ \"enabled\": true,\n+ \"status\": \"ENABLED\",\n+ \"version\": 1,\n+ \"createdAt\": \"2015-11-03T14:52:21Z\",\n+ \"modifiedAt\": \"2015-11-04T19:05:40Z\"\n+ },\n+ {","path":"source/index.html.md.erb","position":2756,"original_position":2756,"commit_id":"3fe3829dd519dcba516b16a9966e54608531c282","original_commit_id":"3fe3829dd519dcba516b16a9966e54608531c282","user":{"login":"seweil","id":5559808,"avatar_url":"https://avatars3.githubusercontent.com/u/5559808?v=4","gravatar_id":"","url":"https://api.github.com/users/seweil","html_url":"https://github.com/seweil","followers_url":"https://api.github.com/users/seweil/followers","following_url":"https://api.github.com/users/seweil/following{/other_user}","gists_url":"https://api.github.com/users/seweil/gists{/gist_id}","starred_url":"https://api.github.com/users/seweil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seweil/subscriptions","organizations_url":"https://api.github.com/users/seweil/orgs","repos_url":"https://api.github.com/users/seweil/repos","events_url":"https://api.github.com/users/seweil/events{/privacy}","received_events_url":"https://api.github.com/users/seweil/received_events","type":"User","site_admin":false},"body":"Not sure there's any benefit to showing two items. (And doesn't match 'totalCount')","created_at":"2017-10-12T19:14:48Z","updated_at":"2017-10-12T19:14:48Z","html_url":"https://github.com/smartsheet-platform/api-docs/pull/54#discussion_r144384469","pull_request_url":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/54","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/comments/144384469"},"html":{"href":"https://github.com/smartsheet-platform/api-docs/pull/54#discussion_r144384469"},"pull_request":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/54","id":145826614,"html_url":"https://github.com/smartsheet-platform/api-docs/pull/54","diff_url":"https://github.com/smartsheet-platform/api-docs/pull/54.diff","patch_url":"https://github.com/smartsheet-platform/api-docs/pull/54.patch","issue_url":"https://api.github.com/repos/smartsheet-platform/api-docs/issues/54","number":54,"state":"open","locked":false,"title":"Kevinf nodejs october","user":{"login":"kfansler","id":27781522,"avatar_url":"https://avatars3.githubusercontent.com/u/27781522?v=4","gravatar_id":"","url":"https://api.github.com/users/kfansler","html_url":"https://github.com/kfansler","followers_url":"https://api.github.com/users/kfansler/followers","following_url":"https://api.github.com/users/kfansler/following{/other_user}","gists_url":"https://api.github.com/users/kfansler/gists{/gist_id}","starred_url":"https://api.github.com/users/kfansler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfansler/subscriptions","organizations_url":"https://api.github.com/users/kfansler/orgs","repos_url":"https://api.github.com/users/kfansler/repos","events_url":"https://api.github.com/users/kfansler/events{/privacy}","received_events_url":"https://api.github.com/users/kfansler/received_events","type":"User","site_admin":false},"body":"All samples for Node.js are either in these files or I’m tracking why they aren’t.\nAll new Pariveda samples have been tested against the beta.","created_at":"2017-10-10T23:40:55Z","updated_at":"2017-10-12T19:14:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"205b8cdab05e265fc3a9c7dab78ee64d3372a1e8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/54/commits","review_comments_url":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/54/comments","review_comment_url":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartsheet-platform/api-docs/issues/54/comments","statuses_url":"https://api.github.com/repos/smartsheet-platform/api-docs/statuses/3fe3829dd519dcba516b16a9966e54608531c282","head":{"label":"smartsheet-platform:kevinf-nodejs-october","ref":"kevinf-nodejs-october","sha":"3fe3829dd519dcba516b16a9966e54608531c282","user":{"login":"smartsheet-platform","id":4391117,"avatar_url":"https://avatars2.githubusercontent.com/u/4391117?v=4","gravatar_id":"","url":"https://api.github.com/users/smartsheet-platform","html_url":"https://github.com/smartsheet-platform","followers_url":"https://api.github.com/users/smartsheet-platform/followers","following_url":"https://api.github.com/users/smartsheet-platform/following{/other_user}","gists_url":"https://api.github.com/users/smartsheet-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/smartsheet-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartsheet-platform/subscriptions","organizations_url":"https://api.github.com/users/smartsheet-platform/orgs","repos_url":"https://api.github.com/users/smartsheet-platform/repos","events_url":"https://api.github.com/users/smartsheet-platform/events{/privacy}","received_events_url":"https://api.github.com/users/smartsheet-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":34817873,"name":"api-docs","full_name":"smartsheet-platform/api-docs","owner":{"login":"smartsheet-platform","id":4391117,"avatar_url":"https://avatars2.githubusercontent.com/u/4391117?v=4","gravatar_id":"","url":"https://api.github.com/users/smartsheet-platform","html_url":"https://github.com/smartsheet-platform","followers_url":"https://api.github.com/users/smartsheet-platform/followers","following_url":"https://api.github.com/users/smartsheet-platform/following{/other_user}","gists_url":"https://api.github.com/users/smartsheet-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/smartsheet-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartsheet-platform/subscriptions","organizations_url":"https://api.github.com/users/smartsheet-platform/orgs","repos_url":"https://api.github.com/users/smartsheet-platform/repos","events_url":"https://api.github.com/users/smartsheet-platform/events{/privacy}","received_events_url":"https://api.github.com/users/smartsheet-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartsheet-platform/api-docs","description":"API Documentation source files for Smartsheet API 2.0","fork":true,"url":"https://api.github.com/repos/smartsheet-platform/api-docs","forks_url":"https://api.github.com/repos/smartsheet-platform/api-docs/forks","keys_url":"https://api.github.com/repos/smartsheet-platform/api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartsheet-platform/api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartsheet-platform/api-docs/teams","hooks_url":"https://api.github.com/repos/smartsheet-platform/api-docs/hooks","issue_events_url":"https://api.github.com/repos/smartsheet-platform/api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/smartsheet-platform/api-docs/events","assignees_url":"https://api.github.com/repos/smartsheet-platform/api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/smartsheet-platform/api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/smartsheet-platform/api-docs/tags","blobs_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartsheet-platform/api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/smartsheet-platform/api-docs/languages","stargazers_url":"https://api.github.com/repos/smartsheet-platform/api-docs/stargazers","contributors_url":"https://api.github.com/repos/smartsheet-platform/api-docs/contributors","subscribers_url":"https://api.github.com/repos/smartsheet-platform/api-docs/subscribers","subscription_url":"https://api.github.com/repos/smartsheet-platform/api-docs/subscription","commits_url":"https://api.github.com/repos/smartsheet-platform/api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartsheet-platform/api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartsheet-platform/api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartsheet-platform/api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/smartsheet-platform/api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartsheet-platform/api-docs/merges","archive_url":"https://api.github.com/repos/smartsheet-platform/api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartsheet-platform/api-docs/downloads","issues_url":"https://api.github.com/repos/smartsheet-platform/api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/smartsheet-platform/api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/smartsheet-platform/api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartsheet-platform/api-docs/labels{/name}","releases_url":"https://api.github.com/repos/smartsheet-platform/api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/smartsheet-platform/api-docs/deployments","created_at":"2015-04-29T20:55:45Z","updated_at":"2017-04-19T18:31:50Z","pushed_at":"2017-10-12T18:20:42Z","git_url":"git://github.com/smartsheet-platform/api-docs.git","ssh_url":"[email protected]:smartsheet-platform/api-docs.git","clone_url":"https://github.com/smartsheet-platform/api-docs.git","svn_url":"https://github.com/smartsheet-platform/api-docs","homepage":"http://smartsheet-platform.github.io/api-docs","size":6227,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"smartsheet-platform:master","ref":"master","sha":"d1cc6441b6e4e2a3d47ab9cbd117d11ae4505fee","user":{"login":"smartsheet-platform","id":4391117,"avatar_url":"https://avatars2.githubusercontent.com/u/4391117?v=4","gravatar_id":"","url":"https://api.github.com/users/smartsheet-platform","html_url":"https://github.com/smartsheet-platform","followers_url":"https://api.github.com/users/smartsheet-platform/followers","following_url":"https://api.github.com/users/smartsheet-platform/following{/other_user}","gists_url":"https://api.github.com/users/smartsheet-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/smartsheet-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartsheet-platform/subscriptions","organizations_url":"https://api.github.com/users/smartsheet-platform/orgs","repos_url":"https://api.github.com/users/smartsheet-platform/repos","events_url":"https://api.github.com/users/smartsheet-platform/events{/privacy}","received_events_url":"https://api.github.com/users/smartsheet-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":34817873,"name":"api-docs","full_name":"smartsheet-platform/api-docs","owner":{"login":"smartsheet-platform","id":4391117,"avatar_url":"https://avatars2.githubusercontent.com/u/4391117?v=4","gravatar_id":"","url":"https://api.github.com/users/smartsheet-platform","html_url":"https://github.com/smartsheet-platform","followers_url":"https://api.github.com/users/smartsheet-platform/followers","following_url":"https://api.github.com/users/smartsheet-platform/following{/other_user}","gists_url":"https://api.github.com/users/smartsheet-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/smartsheet-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartsheet-platform/subscriptions","organizations_url":"https://api.github.com/users/smartsheet-platform/orgs","repos_url":"https://api.github.com/users/smartsheet-platform/repos","events_url":"https://api.github.com/users/smartsheet-platform/events{/privacy}","received_events_url":"https://api.github.com/users/smartsheet-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartsheet-platform/api-docs","description":"API Documentation source files for Smartsheet API 2.0","fork":true,"url":"https://api.github.com/repos/smartsheet-platform/api-docs","forks_url":"https://api.github.com/repos/smartsheet-platform/api-docs/forks","keys_url":"https://api.github.com/repos/smartsheet-platform/api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartsheet-platform/api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartsheet-platform/api-docs/teams","hooks_url":"https://api.github.com/repos/smartsheet-platform/api-docs/hooks","issue_events_url":"https://api.github.com/repos/smartsheet-platform/api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/smartsheet-platform/api-docs/events","assignees_url":"https://api.github.com/repos/smartsheet-platform/api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/smartsheet-platform/api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/smartsheet-platform/api-docs/tags","blobs_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartsheet-platform/api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/smartsheet-platform/api-docs/languages","stargazers_url":"https://api.github.com/repos/smartsheet-platform/api-docs/stargazers","contributors_url":"https://api.github.com/repos/smartsheet-platform/api-docs/contributors","subscribers_url":"https://api.github.com/repos/smartsheet-platform/api-docs/subscribers","subscription_url":"https://api.github.com/repos/smartsheet-platform/api-docs/subscription","commits_url":"https://api.github.com/repos/smartsheet-platform/api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartsheet-platform/api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartsheet-platform/api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartsheet-platform/api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartsheet-platform/api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/smartsheet-platform/api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartsheet-platform/api-docs/merges","archive_url":"https://api.github.com/repos/smartsheet-platform/api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartsheet-platform/api-docs/downloads","issues_url":"https://api.github.com/repos/smartsheet-platform/api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/smartsheet-platform/api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/smartsheet-platform/api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartsheet-platform/api-docs/labels{/name}","releases_url":"https://api.github.com/repos/smartsheet-platform/api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/smartsheet-platform/api-docs/deployments","created_at":"2015-04-29T20:55:45Z","updated_at":"2017-04-19T18:31:50Z","pushed_at":"2017-10-12T18:20:42Z","git_url":"git://github.com/smartsheet-platform/api-docs.git","ssh_url":"[email protected]:smartsheet-platform/api-docs.git","clone_url":"https://github.com/smartsheet-platform/api-docs.git","svn_url":"https://github.com/smartsheet-platform/api-docs","homepage":"http://smartsheet-platform.github.io/api-docs","size":6227,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/54"},"html":{"href":"https://github.com/smartsheet-platform/api-docs/pull/54"},"issue":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/issues/54"},"comments":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/smartsheet-platform/api-docs/statuses/3fe3829dd519dcba516b16a9966e54608531c282"}},"author_association":"COLLABORATOR"}} | {
"id": 34817873,
"name": "smartsheet-platform/api-docs",
"url": "https://api.github.com/repos/smartsheet-platform/api-docs"
} | {
"id": 5559808,
"login": "seweil",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5559808?",
"url": "https://api.github.com/users/seweil"
} | {
"id": 4391117,
"login": "smartsheet-platform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4391117?",
"url": "https://api.github.com/orgs/smartsheet-platform"
} | 2017-10-12T19:14:48 | 6709830454 | {"actor":{"display_login":"seweil"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/comments/141711965","pull_request_review_id":65970720,"id":141711965,"diff_hunk":"@@ -988,7 +988,7 @@ unittest\n const TestStr = \"Ce qui se conçoit bien s'énonce clairement - Et les mots pour le dire arrivent aisément\";\n scope appender = new Buffer();\n char[32] log_buffer;\n- Logger log = Log.lookup(\"ocean.util.log.Logger.TestLogTrim\")\n+ Logger log = (new Logger(Log.hierarchy(), \"dummy\"))","path":"src/ocean/util/log/Logger.d","position":5,"original_position":5,"commit_id":"6d81aab9cd4a4950d1579f5426e6a5ea06c28606","original_commit_id":"6d81aab9cd4a4950d1579f5426e6a5ea06c28606","user":{"login":"mihails-strasuns-sociomantic","id":4718368,"avatar_url":"https://avatars3.githubusercontent.com/u/4718368?v=4","gravatar_id":"","url":"https://api.github.com/users/mihails-strasuns-sociomantic","html_url":"https://github.com/mihails-strasuns-sociomantic","followers_url":"https://api.github.com/users/mihails-strasuns-sociomantic/followers","following_url":"https://api.github.com/users/mihails-strasuns-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/mihails-strasuns-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/mihails-strasuns-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihails-strasuns-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/mihails-strasuns-sociomantic/orgs","repos_url":"https://api.github.com/users/mihails-strasuns-sociomantic/repos","events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/received_events","type":"User","site_admin":false},"body":"AFAICS there is not destructor for `Logger` so it shouldn't matter","created_at":"2017-09-28T19:20:07Z","updated_at":"2017-09-28T19:20:07Z","html_url":"https://github.com/sociomantic-tsunami/ocean/pull/271#discussion_r141711965","pull_request_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/271","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/comments/141711965"},"html":{"href":"https://github.com/sociomantic-tsunami/ocean/pull/271#discussion_r141711965"},"pull_request":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/271"}},"in_reply_to_id":140553057},"pull_request":{"url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/271","id":142625501,"html_url":"https://github.com/sociomantic-tsunami/ocean/pull/271","diff_url":"https://github.com/sociomantic-tsunami/ocean/pull/271.diff","patch_url":"https://github.com/sociomantic-tsunami/ocean/pull/271.patch","issue_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/271","number":271,"state":"open","locked":false,"title":"Rework logger test to not rely on state","user":{"login":"mihails-strasuns-sociomantic","id":4718368,"avatar_url":"https://avatars3.githubusercontent.com/u/4718368?v=4","gravatar_id":"","url":"https://api.github.com/users/mihails-strasuns-sociomantic","html_url":"https://github.com/mihails-strasuns-sociomantic","followers_url":"https://api.github.com/users/mihails-strasuns-sociomantic/followers","following_url":"https://api.github.com/users/mihails-strasuns-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/mihails-strasuns-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/mihails-strasuns-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihails-strasuns-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/mihails-strasuns-sociomantic/orgs","repos_url":"https://api.github.com/users/mihails-strasuns-sociomantic/repos","events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/received_events","type":"User","site_admin":false},"body":"Previosuly test case would fail if some other module configures log\nsystem in module constructor in some incompatible way.","created_at":"2017-09-22T17:00:20Z","updated_at":"2017-09-28T19:20:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01cd17bb3f9d083e1bcebc9ceeff9fdaa7e68796","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/sociomantic-tsunami/ocean/milestones/43","html_url":"https://github.com/sociomantic-tsunami/ocean/milestone/43","labels_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/milestones/43/labels","id":2785747,"number":43,"title":"v3.3.4","description":"","creator":{"login":"mihails-strasuns-sociomantic","id":4718368,"avatar_url":"https://avatars3.githubusercontent.com/u/4718368?v=4","gravatar_id":"","url":"https://api.github.com/users/mihails-strasuns-sociomantic","html_url":"https://github.com/mihails-strasuns-sociomantic","followers_url":"https://api.github.com/users/mihails-strasuns-sociomantic/followers","following_url":"https://api.github.com/users/mihails-strasuns-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/mihails-strasuns-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/mihails-strasuns-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihails-strasuns-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/mihails-strasuns-sociomantic/orgs","repos_url":"https://api.github.com/users/mihails-strasuns-sociomantic/repos","events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2017-09-22T16:30:35Z","updated_at":"2017-09-28T19:17:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/271/commits","review_comments_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/271/comments","review_comment_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/271/comments","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/statuses/6d81aab9cd4a4950d1579f5426e6a5ea06c28606","head":{"label":"mihails-strasuns-sociomantic:log-test-state","ref":"log-test-state","sha":"6d81aab9cd4a4950d1579f5426e6a5ea06c28606","user":{"login":"mihails-strasuns-sociomantic","id":4718368,"avatar_url":"https://avatars3.githubusercontent.com/u/4718368?v=4","gravatar_id":"","url":"https://api.github.com/users/mihails-strasuns-sociomantic","html_url":"https://github.com/mihails-strasuns-sociomantic","followers_url":"https://api.github.com/users/mihails-strasuns-sociomantic/followers","following_url":"https://api.github.com/users/mihails-strasuns-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/mihails-strasuns-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/mihails-strasuns-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihails-strasuns-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/mihails-strasuns-sociomantic/orgs","repos_url":"https://api.github.com/users/mihails-strasuns-sociomantic/repos","events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/received_events","type":"User","site_admin":false},"repo":{"id":84554085,"name":"ocean","full_name":"mihails-strasuns-sociomantic/ocean","owner":{"login":"mihails-strasuns-sociomantic","id":4718368,"avatar_url":"https://avatars3.githubusercontent.com/u/4718368?v=4","gravatar_id":"","url":"https://api.github.com/users/mihails-strasuns-sociomantic","html_url":"https://github.com/mihails-strasuns-sociomantic","followers_url":"https://api.github.com/users/mihails-strasuns-sociomantic/followers","following_url":"https://api.github.com/users/mihails-strasuns-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/mihails-strasuns-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/mihails-strasuns-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihails-strasuns-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/mihails-strasuns-sociomantic/orgs","repos_url":"https://api.github.com/users/mihails-strasuns-sociomantic/repos","events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mihails-strasuns-sociomantic/ocean","description":"General purpose, platform-dependant, high-performance library for D","fork":true,"url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean","forks_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/forks","keys_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/teams","hooks_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/hooks","issue_events_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/issues/events{/number}","events_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/events","assignees_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/assignees{/user}","branches_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/branches{/branch}","tags_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/tags","blobs_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/git/refs{/sha}","trees_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/statuses/{sha}","languages_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/languages","stargazers_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/stargazers","contributors_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/contributors","subscribers_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/subscribers","subscription_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/subscription","commits_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/commits{/sha}","git_commits_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/git/commits{/sha}","comments_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/comments{/number}","issue_comment_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/issues/comments{/number}","contents_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/contents/{+path}","compare_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/merges","archive_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/downloads","issues_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/issues{/number}","pulls_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/pulls{/number}","milestones_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/milestones{/number}","notifications_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/labels{/name}","releases_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/releases{/id}","deployments_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/ocean/deployments","created_at":"2017-03-10T11:39:35Z","updated_at":"2017-03-10T11:39:39Z","pushed_at":"2017-09-22T17:00:19Z","git_url":"git://github.com/mihails-strasuns-sociomantic/ocean.git","ssh_url":"[email protected]:mihails-strasuns-sociomantic/ocean.git","clone_url":"https://github.com/mihails-strasuns-sociomantic/ocean.git","svn_url":"https://github.com/mihails-strasuns-sociomantic/ocean","homepage":null,"size":3362,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3.x.x"}},"base":{"label":"sociomantic-tsunami:v3.3.x","ref":"v3.3.x","sha":"5a0f31ee0a57528ae665b04f4537c341b97d4e29","user":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars0.githubusercontent.com/u/16766217?v=4","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"repo":{"id":62304010,"name":"ocean","full_name":"sociomantic-tsunami/ocean","owner":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars0.githubusercontent.com/u/16766217?v=4","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sociomantic-tsunami/ocean","description":"General purpose, platform-dependant, high-performance library for D","fork":false,"url":"https://api.github.com/repos/sociomantic-tsunami/ocean","forks_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/forks","keys_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/teams","hooks_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/hooks","issue_events_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/events{/number}","events_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/events","assignees_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/assignees{/user}","branches_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/branches{/branch}","tags_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/tags","blobs_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/refs{/sha}","trees_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/statuses/{sha}","languages_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/languages","stargazers_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/stargazers","contributors_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/contributors","subscribers_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/subscribers","subscription_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/subscription","commits_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/commits{/sha}","git_commits_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/commits{/sha}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/comments{/number}","issue_comment_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/comments{/number}","contents_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/contents/{+path}","compare_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/merges","archive_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/downloads","issues_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues{/number}","pulls_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls{/number}","milestones_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/milestones{/number}","notifications_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/labels{/name}","releases_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/releases{/id}","deployments_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/deployments","created_at":"2016-06-30T11:01:55Z","updated_at":"2017-08-19T12:42:40Z","pushed_at":"2017-09-28T19:17:47Z","git_url":"git://github.com/sociomantic-tsunami/ocean.git","ssh_url":"[email protected]:sociomantic-tsunami/ocean.git","clone_url":"https://github.com/sociomantic-tsunami/ocean.git","svn_url":"https://github.com/sociomantic-tsunami/ocean","homepage":null,"size":3380,"stargazers_count":38,"watchers_count":38,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":39,"forks":28,"open_issues":39,"watchers":38,"default_branch":"v3.x.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/271"},"html":{"href":"https://github.com/sociomantic-tsunami/ocean/pull/271"},"issue":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/271"},"comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/statuses/6d81aab9cd4a4950d1579f5426e6a5ea06c28606"}},"author_association":"CONTRIBUTOR"}} | {
"id": 62304010,
"name": "sociomantic-tsunami/ocean",
"url": "https://api.github.com/repos/sociomantic-tsunami/ocean"
} | {
"id": 4718368,
"login": "mihails-strasuns-sociomantic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4718368?",
"url": "https://api.github.com/users/mihails-strasuns-sociomantic"
} | {
"id": 16766217,
"login": "sociomantic-tsunami",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16766217?",
"url": "https://api.github.com/orgs/sociomantic-tsunami"
} | 2017-09-28T19:20:07 | 6651249192 | {"actor":{"display_login":"mihails-strasuns-sociomantic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/comments/146163165","pull_request_review_id":71065327,"id":146163165,"diff_hunk":"@@ -85,20 +87,24 @@ public void edit() throws Exception {\n index = INDEX_SECOND_PERSON;\n command = EditCommand.COMMAND_WORD_ABBREVIATIONS.iterator().next() + \" \" + index.getOneBased() + NAME_DESC_BOB\n + PHONE_DESC_BOB + EMAIL_DESC_BOB + ADDRESS_DESC_BOB + TAG_DESC_FRIEND + TAG_DESC_HUSBAND;\n- assertCommandSuccess(command, index, BOB);\n+ personToEdit = getModel().getLatestPersonList().get(index.getZeroBased());\n+ editedPerson = new PersonBuilder().withName(VALID_NAME_BOB).withPhone(VALID_PHONE_BOB)\n+ .withEmail(VALID_EMAIL_BOB).withAddress(VALID_ADDRESS_BOB).withTags(VALID_TAG_FRIEND, VALID_TAG_HUSBAND)\n+ .build(personToEdit.getTags());\n+ assertCommandSuccess(command, index, editedPerson);\n \n /* Case: edit some fields -> edited */\n index = INDEX_FIRST_PERSON;\n command = EditCommand.COMMAND_WORD + \" \" + index.getOneBased() + TAG_DESC_FRIEND;\n- ReadOnlyPerson personToEdit = getModel().getLatestPersonList().get(index.getZeroBased());\n- editedPerson = new PersonBuilder(personToEdit).withTags(VALID_TAG_FRIEND).build();\n+ personToEdit = getModel().getLatestPersonList().get(index.getZeroBased());\n+ editedPerson = new PersonBuilder(personToEdit).withTags(VALID_TAG_FRIEND).build(personToEdit.getTags());\n assertCommandSuccess(command, index, editedPerson);\n \n- /* Case: clear tags -> cleared */\n+ /* Case: empty tag parameter -> no effect */","path":"src/test/java/systemtests/EditCommandSystemTest.java","position":33,"original_position":33,"commit_id":"d7624fb8e5af31e4c7b3130b70a66e80edcc6f1f","original_commit_id":"d7624fb8e5af31e4c7b3130b70a66e80edcc6f1f","user":{"login":"ZY-Ang","id":23255196,"avatar_url":"https://avatars0.githubusercontent.com/u/23255196?v=4","gravatar_id":"","url":"https://api.github.com/users/ZY-Ang","html_url":"https://github.com/ZY-Ang","followers_url":"https://api.github.com/users/ZY-Ang/followers","following_url":"https://api.github.com/users/ZY-Ang/following{/other_user}","gists_url":"https://api.github.com/users/ZY-Ang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZY-Ang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZY-Ang/subscriptions","organizations_url":"https://api.github.com/users/ZY-Ang/orgs","repos_url":"https://api.github.com/users/ZY-Ang/repos","events_url":"https://api.github.com/users/ZY-Ang/events{/privacy}","received_events_url":"https://api.github.com/users/ZY-Ang/received_events","type":"User","site_admin":false},"body":"Perhaps. I'll try to work something in.","created_at":"2017-10-23T04:04:33Z","updated_at":"2017-10-23T04:04:33Z","html_url":"https://github.com/CS2103AUG2017-W11-B2/main/pull/81#discussion_r146163165","pull_request_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/81","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/comments/146163165"},"html":{"href":"https://github.com/CS2103AUG2017-W11-B2/main/pull/81#discussion_r146163165"},"pull_request":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/81"}},"in_reply_to_id":146131501},"pull_request":{"url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/81","id":147975769,"html_url":"https://github.com/CS2103AUG2017-W11-B2/main/pull/81","diff_url":"https://github.com/CS2103AUG2017-W11-B2/main/pull/81.diff","patch_url":"https://github.com/CS2103AUG2017-W11-B2/main/pull/81.patch","issue_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/issues/81","number":81,"state":"open","locked":false,"title":"Edit tags will toggle instead of resetting all tags of a person","user":{"login":"ZY-Ang","id":23255196,"avatar_url":"https://avatars0.githubusercontent.com/u/23255196?v=4","gravatar_id":"","url":"https://api.github.com/users/ZY-Ang","html_url":"https://github.com/ZY-Ang","followers_url":"https://api.github.com/users/ZY-Ang/followers","following_url":"https://api.github.com/users/ZY-Ang/following{/other_user}","gists_url":"https://api.github.com/users/ZY-Ang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZY-Ang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZY-Ang/subscriptions","organizations_url":"https://api.github.com/users/ZY-Ang/orgs","repos_url":"https://api.github.com/users/ZY-Ang/repos","events_url":"https://api.github.com/users/ZY-Ang/events{/privacy}","received_events_url":"https://api.github.com/users/ZY-Ang/received_events","type":"User","site_admin":false},"body":"E.g. Tommy is listed as index `1` and has tags `school` and `classmates`.\n`edit 1 t/school t/jackass` will remove `school` from Tommy's tags and add `jackass` to his list of tags.","created_at":"2017-10-22T04:51:34Z","updated_at":"2017-10-23T04:04:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf0c108a94e0b2e06e43aa1ee77d428d767d7641","assignee":{"login":"ZY-Ang","id":23255196,"avatar_url":"https://avatars0.githubusercontent.com/u/23255196?v=4","gravatar_id":"","url":"https://api.github.com/users/ZY-Ang","html_url":"https://github.com/ZY-Ang","followers_url":"https://api.github.com/users/ZY-Ang/followers","following_url":"https://api.github.com/users/ZY-Ang/following{/other_user}","gists_url":"https://api.github.com/users/ZY-Ang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZY-Ang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZY-Ang/subscriptions","organizations_url":"https://api.github.com/users/ZY-Ang/orgs","repos_url":"https://api.github.com/users/ZY-Ang/repos","events_url":"https://api.github.com/users/ZY-Ang/events{/privacy}","received_events_url":"https://api.github.com/users/ZY-Ang/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZY-Ang","id":23255196,"avatar_url":"https://avatars0.githubusercontent.com/u/23255196?v=4","gravatar_id":"","url":"https://api.github.com/users/ZY-Ang","html_url":"https://github.com/ZY-Ang","followers_url":"https://api.github.com/users/ZY-Ang/followers","following_url":"https://api.github.com/users/ZY-Ang/following{/other_user}","gists_url":"https://api.github.com/users/ZY-Ang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZY-Ang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZY-Ang/subscriptions","organizations_url":"https://api.github.com/users/ZY-Ang/orgs","repos_url":"https://api.github.com/users/ZY-Ang/repos","events_url":"https://api.github.com/users/ZY-Ang/events{/privacy}","received_events_url":"https://api.github.com/users/ZY-Ang/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mingruiii","id":31034193,"avatar_url":"https://avatars3.githubusercontent.com/u/31034193?v=4","gravatar_id":"","url":"https://api.github.com/users/mingruiii","html_url":"https://github.com/mingruiii","followers_url":"https://api.github.com/users/mingruiii/followers","following_url":"https://api.github.com/users/mingruiii/following{/other_user}","gists_url":"https://api.github.com/users/mingruiii/gists{/gist_id}","starred_url":"https://api.github.com/users/mingruiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingruiii/subscriptions","organizations_url":"https://api.github.com/users/mingruiii/orgs","repos_url":"https://api.github.com/users/mingruiii/repos","events_url":"https://api.github.com/users/mingruiii/events{/privacy}","received_events_url":"https://api.github.com/users/mingruiii/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/milestones/4","html_url":"https://github.com/CS2103AUG2017-W11-B2/main/milestone/4","labels_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/milestones/4/labels","id":2835988,"number":4,"title":"v1.3","description":"","creator":{"login":"ZY-Ang","id":23255196,"avatar_url":"https://avatars0.githubusercontent.com/u/23255196?v=4","gravatar_id":"","url":"https://api.github.com/users/ZY-Ang","html_url":"https://github.com/ZY-Ang","followers_url":"https://api.github.com/users/ZY-Ang/followers","following_url":"https://api.github.com/users/ZY-Ang/following{/other_user}","gists_url":"https://api.github.com/users/ZY-Ang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZY-Ang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZY-Ang/subscriptions","organizations_url":"https://api.github.com/users/ZY-Ang/orgs","repos_url":"https://api.github.com/users/ZY-Ang/repos","events_url":"https://api.github.com/users/ZY-Ang/events{/privacy}","received_events_url":"https://api.github.com/users/ZY-Ang/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":3,"state":"open","created_at":"2017-10-13T16:12:01Z","updated_at":"2017-10-22T18:47:20Z","due_on":"2017-10-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/81/commits","review_comments_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/81/comments","review_comment_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/issues/81/comments","statuses_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/statuses/d7624fb8e5af31e4c7b3130b70a66e80edcc6f1f","head":{"label":"ZY-Ang:EditTagsToggle","ref":"EditTagsToggle","sha":"d7624fb8e5af31e4c7b3130b70a66e80edcc6f1f","user":{"login":"ZY-Ang","id":23255196,"avatar_url":"https://avatars0.githubusercontent.com/u/23255196?v=4","gravatar_id":"","url":"https://api.github.com/users/ZY-Ang","html_url":"https://github.com/ZY-Ang","followers_url":"https://api.github.com/users/ZY-Ang/followers","following_url":"https://api.github.com/users/ZY-Ang/following{/other_user}","gists_url":"https://api.github.com/users/ZY-Ang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZY-Ang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZY-Ang/subscriptions","organizations_url":"https://api.github.com/users/ZY-Ang/orgs","repos_url":"https://api.github.com/users/ZY-Ang/repos","events_url":"https://api.github.com/users/ZY-Ang/events{/privacy}","received_events_url":"https://api.github.com/users/ZY-Ang/received_events","type":"User","site_admin":false},"repo":{"id":104472372,"name":"The-Rolodex","full_name":"ZY-Ang/The-Rolodex","owner":{"login":"ZY-Ang","id":23255196,"avatar_url":"https://avatars0.githubusercontent.com/u/23255196?v=4","gravatar_id":"","url":"https://api.github.com/users/ZY-Ang","html_url":"https://github.com/ZY-Ang","followers_url":"https://api.github.com/users/ZY-Ang/followers","following_url":"https://api.github.com/users/ZY-Ang/following{/other_user}","gists_url":"https://api.github.com/users/ZY-Ang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZY-Ang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZY-Ang/subscriptions","organizations_url":"https://api.github.com/users/ZY-Ang/orgs","repos_url":"https://api.github.com/users/ZY-Ang/repos","events_url":"https://api.github.com/users/ZY-Ang/events{/privacy}","received_events_url":"https://api.github.com/users/ZY-Ang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZY-Ang/The-Rolodex","description":"Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/ZY-Ang/The-Rolodex","forks_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/forks","keys_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/teams","hooks_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/hooks","issue_events_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/issues/events{/number}","events_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/events","assignees_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/assignees{/user}","branches_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/branches{/branch}","tags_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/tags","blobs_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/statuses/{sha}","languages_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/languages","stargazers_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/stargazers","contributors_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/contributors","subscribers_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/subscribers","subscription_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/subscription","commits_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/contents/{+path}","compare_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/merges","archive_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/downloads","issues_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/issues{/number}","pulls_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/pulls{/number}","milestones_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/milestones{/number}","notifications_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/labels{/name}","releases_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/releases{/id}","deployments_url":"https://api.github.com/repos/ZY-Ang/The-Rolodex/deployments","created_at":"2017-09-22T12:33:38Z","updated_at":"2017-09-22T12:33:41Z","pushed_at":"2017-10-22T06:12:12Z","git_url":"git://github.com/ZY-Ang/The-Rolodex.git","ssh_url":"[email protected]:ZY-Ang/The-Rolodex.git","clone_url":"https://github.com/ZY-Ang/The-Rolodex.git","svn_url":"https://github.com/ZY-Ang/The-Rolodex","homepage":"https://nus-cs2103-AY1718S1.github.io/addressbook-level4","size":8359,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CS2103AUG2017-W11-B2:master","ref":"master","sha":"998e2cd21bbf99a8b73c19a965994d9ecebe97b9","user":{"login":"CS2103AUG2017-W11-B2","id":32017605,"avatar_url":"https://avatars1.githubusercontent.com/u/32017605?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103AUG2017-W11-B2","html_url":"https://github.com/CS2103AUG2017-W11-B2","followers_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/followers","following_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/following{/other_user}","gists_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/subscriptions","organizations_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/orgs","repos_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/repos","events_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/received_events","type":"Organization","site_admin":false},"repo":{"id":104471493,"name":"main","full_name":"CS2103AUG2017-W11-B2/main","owner":{"login":"CS2103AUG2017-W11-B2","id":32017605,"avatar_url":"https://avatars1.githubusercontent.com/u/32017605?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103AUG2017-W11-B2","html_url":"https://github.com/CS2103AUG2017-W11-B2","followers_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/followers","following_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/following{/other_user}","gists_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/subscriptions","organizations_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/orgs","repos_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/repos","events_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103AUG2017-W11-B2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CS2103AUG2017-W11-B2/main","description":"CLI-Based Desktop Address Book application","fork":true,"url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main","forks_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/forks","keys_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/teams","hooks_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/hooks","issue_events_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/issues/events{/number}","events_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/events","assignees_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/assignees{/user}","branches_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/branches{/branch}","tags_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/tags","blobs_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/statuses/{sha}","languages_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/languages","stargazers_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/stargazers","contributors_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/contributors","subscribers_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/subscribers","subscription_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/subscription","commits_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/contents/{+path}","compare_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/merges","archive_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/downloads","issues_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/issues{/number}","pulls_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls{/number}","milestones_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/milestones{/number}","notifications_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/labels{/name}","releases_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/releases{/id}","deployments_url":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/deployments","created_at":"2017-09-22T12:22:58Z","updated_at":"2017-10-15T07:36:23Z","pushed_at":"2017-10-22T18:47:21Z","git_url":"git://github.com/CS2103AUG2017-W11-B2/main.git","ssh_url":"[email protected]:CS2103AUG2017-W11-B2/main.git","clone_url":"https://github.com/CS2103AUG2017-W11-B2/main.git","svn_url":"https://github.com/CS2103AUG2017-W11-B2/main","homepage":"https://CS2103AUG2017-W11-B2.github.io","size":8436,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":29,"forks":3,"open_issues":29,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/81"},"html":{"href":"https://github.com/CS2103AUG2017-W11-B2/main/pull/81"},"issue":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/issues/81"},"comments":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/CS2103AUG2017-W11-B2/main/statuses/d7624fb8e5af31e4c7b3130b70a66e80edcc6f1f"}},"author_association":"OWNER"}} | {
"id": 104471493,
"name": "CS2103AUG2017-W11-B2/main",
"url": "https://api.github.com/repos/CS2103AUG2017-W11-B2/main"
} | {
"id": 23255196,
"login": "ZY-Ang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23255196?",
"url": "https://api.github.com/users/ZY-Ang"
} | {
"id": 32017605,
"login": "CS2103AUG2017-W11-B2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32017605?",
"url": "https://api.github.com/orgs/CS2103AUG2017-W11-B2"
} | 2017-10-23T04:04:33 | 6750352627 | {"actor":{"display_login":"ZY-Ang"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/comments/151206362","pull_request_review_id":76876833,"id":151206362,"diff_hunk":"@@ -60,6 +60,8 @@ class Meta:\n 'exit_url': \"Specify the page where you want to send your participants after they've completed the study.\",\n 'short_description': 'Give your study a description here.',\n 'long_description': 'Explain the purpose of your study here.',\n+ 'contact_info': 'This should give the name of the PI for your study, and an email address where the PI or study staff can be reached with questions. Format: PIs Name (contact: [email protected])',\n+ 'criteria': 'Text shown to families - this is not used to actually verify eligibility.'","path":"studies/forms.py","position":22,"original_position":14,"commit_id":"160e66dfa21a0cfca850df8a86e442f91e152782","original_commit_id":"61ed288144fa0e9d4496725e4b706d84ed16d498","user":{"login":"kimberscott","id":9554627,"avatar_url":"https://avatars2.githubusercontent.com/u/9554627?v=4","gravatar_id":"","url":"https://api.github.com/users/kimberscott","html_url":"https://github.com/kimberscott","followers_url":"https://api.github.com/users/kimberscott/followers","following_url":"https://api.github.com/users/kimberscott/following{/other_user}","gists_url":"https://api.github.com/users/kimberscott/gists{/gist_id}","starred_url":"https://api.github.com/users/kimberscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimberscott/subscriptions","organizations_url":"https://api.github.com/users/kimberscott/orgs","repos_url":"https://api.github.com/users/kimberscott/repos","events_url":"https://api.github.com/users/kimberscott/events{/privacy}","received_events_url":"https://api.github.com/users/kimberscott/received_events","type":"User","site_admin":false},"body":"Changed this, also proposed simple fix to keep the shared fields consistent but it's a bit clunky, feel free to leave out!","created_at":"2017-11-15T18:05:09Z","updated_at":"2017-11-15T18:05:09Z","html_url":"https://github.com/CenterForOpenScience/lookit-api/pull/84#discussion_r151206362","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/84","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/comments/151206362"},"html":{"href":"https://github.com/CenterForOpenScience/lookit-api/pull/84#discussion_r151206362"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/84"}},"in_reply_to_id":150930094},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/84","id":152023535,"html_url":"https://github.com/CenterForOpenScience/lookit-api/pull/84","diff_url":"https://github.com/CenterForOpenScience/lookit-api/pull/84.diff","patch_url":"https://github.com/CenterForOpenScience/lookit-api/pull/84.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/issues/84","number":84,"state":"open","locked":false,"title":"Additions for experimenter usability","user":{"login":"kimberscott","id":9554627,"avatar_url":"https://avatars2.githubusercontent.com/u/9554627?v=4","gravatar_id":"","url":"https://api.github.com/users/kimberscott","html_url":"https://github.com/kimberscott","followers_url":"https://api.github.com/users/kimberscott/followers","following_url":"https://api.github.com/users/kimberscott/following{/other_user}","gists_url":"https://api.github.com/users/kimberscott/gists{/gist_id}","starred_url":"https://api.github.com/users/kimberscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimberscott/subscriptions","organizations_url":"https://api.github.com/users/kimberscott/orgs","repos_url":"https://api.github.com/users/kimberscott/repos","events_url":"https://api.github.com/users/kimberscott/events{/privacy}","received_events_url":"https://api.github.com/users/kimberscott/received_events","type":"User","site_admin":false},"body":"Add date_created fields to user and demographic data. For users, this allows us to easily see when people are signing up, and check the impact of various recruitment efforts. For demographic data this lets us fetch the most recent data more easily, as well as seeing when changes were made.\r\n\r\nI've made some minor formatting changes to the study detail view to make longer text fields a bit more readable.\r\n\r\nAdd some explanations to researchers about what they should put in the contact info field and the age cutoff fields.\r\n\r\nProposed solution for giving access to email addresses to users with can_read_usernames permissions only (separate basic/full serializers for user data, selected in view based on permissions).","created_at":"2017-11-10T23:24:45Z","updated_at":"2017-11-15T18:05:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d43c988b63a3849c7610052d8732235c8667773d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/84/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/84/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/issues/84/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/statuses/160e66dfa21a0cfca850df8a86e442f91e152782","head":{"label":"kimberscott:develop","ref":"develop","sha":"160e66dfa21a0cfca850df8a86e442f91e152782","user":{"login":"kimberscott","id":9554627,"avatar_url":"https://avatars2.githubusercontent.com/u/9554627?v=4","gravatar_id":"","url":"https://api.github.com/users/kimberscott","html_url":"https://github.com/kimberscott","followers_url":"https://api.github.com/users/kimberscott/followers","following_url":"https://api.github.com/users/kimberscott/following{/other_user}","gists_url":"https://api.github.com/users/kimberscott/gists{/gist_id}","starred_url":"https://api.github.com/users/kimberscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimberscott/subscriptions","organizations_url":"https://api.github.com/users/kimberscott/orgs","repos_url":"https://api.github.com/users/kimberscott/repos","events_url":"https://api.github.com/users/kimberscott/events{/privacy}","received_events_url":"https://api.github.com/users/kimberscott/received_events","type":"User","site_admin":false},"repo":{"id":108324481,"name":"lookit-api","full_name":"kimberscott/lookit-api","owner":{"login":"kimberscott","id":9554627,"avatar_url":"https://avatars2.githubusercontent.com/u/9554627?v=4","gravatar_id":"","url":"https://api.github.com/users/kimberscott","html_url":"https://github.com/kimberscott","followers_url":"https://api.github.com/users/kimberscott/followers","following_url":"https://api.github.com/users/kimberscott/following{/other_user}","gists_url":"https://api.github.com/users/kimberscott/gists{/gist_id}","starred_url":"https://api.github.com/users/kimberscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimberscott/subscriptions","organizations_url":"https://api.github.com/users/kimberscott/orgs","repos_url":"https://api.github.com/users/kimberscott/repos","events_url":"https://api.github.com/users/kimberscott/events{/privacy}","received_events_url":"https://api.github.com/users/kimberscott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kimberscott/lookit-api","description":"Codebase for Lookit v2 and Experimenter v2. Includes an API.","fork":true,"url":"https://api.github.com/repos/kimberscott/lookit-api","forks_url":"https://api.github.com/repos/kimberscott/lookit-api/forks","keys_url":"https://api.github.com/repos/kimberscott/lookit-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kimberscott/lookit-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kimberscott/lookit-api/teams","hooks_url":"https://api.github.com/repos/kimberscott/lookit-api/hooks","issue_events_url":"https://api.github.com/repos/kimberscott/lookit-api/issues/events{/number}","events_url":"https://api.github.com/repos/kimberscott/lookit-api/events","assignees_url":"https://api.github.com/repos/kimberscott/lookit-api/assignees{/user}","branches_url":"https://api.github.com/repos/kimberscott/lookit-api/branches{/branch}","tags_url":"https://api.github.com/repos/kimberscott/lookit-api/tags","blobs_url":"https://api.github.com/repos/kimberscott/lookit-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kimberscott/lookit-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kimberscott/lookit-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/kimberscott/lookit-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kimberscott/lookit-api/statuses/{sha}","languages_url":"https://api.github.com/repos/kimberscott/lookit-api/languages","stargazers_url":"https://api.github.com/repos/kimberscott/lookit-api/stargazers","contributors_url":"https://api.github.com/repos/kimberscott/lookit-api/contributors","subscribers_url":"https://api.github.com/repos/kimberscott/lookit-api/subscribers","subscription_url":"https://api.github.com/repos/kimberscott/lookit-api/subscription","commits_url":"https://api.github.com/repos/kimberscott/lookit-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/kimberscott/lookit-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/kimberscott/lookit-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/kimberscott/lookit-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/kimberscott/lookit-api/contents/{+path}","compare_url":"https://api.github.com/repos/kimberscott/lookit-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kimberscott/lookit-api/merges","archive_url":"https://api.github.com/repos/kimberscott/lookit-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kimberscott/lookit-api/downloads","issues_url":"https://api.github.com/repos/kimberscott/lookit-api/issues{/number}","pulls_url":"https://api.github.com/repos/kimberscott/lookit-api/pulls{/number}","milestones_url":"https://api.github.com/repos/kimberscott/lookit-api/milestones{/number}","notifications_url":"https://api.github.com/repos/kimberscott/lookit-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kimberscott/lookit-api/labels{/name}","releases_url":"https://api.github.com/repos/kimberscott/lookit-api/releases{/id}","deployments_url":"https://api.github.com/repos/kimberscott/lookit-api/deployments","created_at":"2017-10-25T20:48:46Z","updated_at":"2017-10-25T20:48:48Z","pushed_at":"2017-11-15T18:04:21Z","git_url":"git://github.com/kimberscott/lookit-api.git","ssh_url":"[email protected]:kimberscott/lookit-api.git","clone_url":"https://github.com/kimberscott/lookit-api.git","svn_url":"https://github.com/kimberscott/lookit-api","homepage":"http://lookit-api.readthedocs.io/en/latest/","size":11282,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"335d9f875a9bd2e70db4c1629a2daeeb7c91a76c","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":88179669,"name":"lookit-api","full_name":"CenterForOpenScience/lookit-api","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars1.githubusercontent.com/u/3344584?v=4","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/lookit-api","description":"Codebase for Lookit v2 and Experimenter v2. Includes an API.","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/lookit-api","forks_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/lookit-api/deployments","created_at":"2017-04-13T15:29:23Z","updated_at":"2017-09-27T22:14:14Z","pushed_at":"2017-11-15T18:04:22Z","git_url":"git://github.com/CenterForOpenScience/lookit-api.git","ssh_url":"[email protected]:CenterForOpenScience/lookit-api.git","clone_url":"https://github.com/CenterForOpenScience/lookit-api.git","svn_url":"https://github.com/CenterForOpenScience/lookit-api","homepage":"http://lookit-api.readthedocs.io/en/latest/","size":11261,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/84"},"html":{"href":"https://github.com/CenterForOpenScience/lookit-api/pull/84"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/issues/84"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit-api/statuses/160e66dfa21a0cfca850df8a86e442f91e152782"}},"author_association":"NONE"}} | {
"id": 88179669,
"name": "CenterForOpenScience/lookit-api",
"url": "https://api.github.com/repos/CenterForOpenScience/lookit-api"
} | {
"id": 9554627,
"login": "kimberscott",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9554627?",
"url": "https://api.github.com/users/kimberscott"
} | {
"id": 3344584,
"login": "CenterForOpenScience",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3344584?",
"url": "https://api.github.com/orgs/CenterForOpenScience"
} | 2017-11-15T18:05:09 | 6860046167 | {"actor":{"display_login":"kimberscott"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/comments/153407692","pull_request_review_id":79405618,"id":153407692,"diff_hunk":"@@ -67,8 +67,25 @@ function normalizeDate(dateObject, hours = 0, minutes = 0, seconds = 0, millisec\n return dateObject;\n }\n \n+/**\n+ * Eject real custom users props from props\n+ *\n+ * @method ejectOtherProps\n+ * @param {Object} props conponent props.\n+ * @param {Object} propTypes conponent props types.\n+ * @return {Object} custom props.\n+ */\n+function ejectOtherProps(props, propTypes) {\n+ return Object.keys(props)\n+ .filter(x => Object.keys(propTypes).indexOf(x) < 0)\n+ .reduce((prev, item) => {\n+ return { ...prev, [item]: props[item] };","path":"components/_helpers.js","position":16,"original_position":16,"commit_id":"023e92e00c4bbc77873639440e8ecc415fc697f5","original_commit_id":"023e92e00c4bbc77873639440e8ecc415fc697f5","user":{"login":"mAiNiNfEcTiOn","id":1002056,"avatar_url":"https://avatars1.githubusercontent.com/u/1002056?v=4","gravatar_id":"","url":"https://api.github.com/users/mAiNiNfEcTiOn","html_url":"https://github.com/mAiNiNfEcTiOn","followers_url":"https://api.github.com/users/mAiNiNfEcTiOn/followers","following_url":"https://api.github.com/users/mAiNiNfEcTiOn/following{/other_user}","gists_url":"https://api.github.com/users/mAiNiNfEcTiOn/gists{/gist_id}","starred_url":"https://api.github.com/users/mAiNiNfEcTiOn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mAiNiNfEcTiOn/subscriptions","organizations_url":"https://api.github.com/users/mAiNiNfEcTiOn/orgs","repos_url":"https://api.github.com/users/mAiNiNfEcTiOn/repos","events_url":"https://api.github.com/users/mAiNiNfEcTiOn/events{/privacy}","received_events_url":"https://api.github.com/users/mAiNiNfEcTiOn/received_events","type":"User","site_admin":false},"body":"uuuuuu, fancy! 😉 ","created_at":"2017-11-28T06:56:04Z","updated_at":"2017-11-28T06:58:42Z","html_url":"https://github.com/Travix-International/travix-ui-kit/pull/227#discussion_r153407692","pull_request_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/comments/153407692"},"html":{"href":"https://github.com/Travix-International/travix-ui-kit/pull/227#discussion_r153407692"},"pull_request":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/227","id":152175827,"html_url":"https://github.com/Travix-International/travix-ui-kit/pull/227","diff_url":"https://github.com/Travix-International/travix-ui-kit/pull/227.diff","patch_url":"https://github.com/Travix-International/travix-ui-kit/pull/227.patch","issue_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/227","number":227,"state":"open","locked":false,"title":"Fix Unknown Prop Warning","user":{"login":"AlleeX","id":10462372,"avatar_url":"https://avatars3.githubusercontent.com/u/10462372?v=4","gravatar_id":"","url":"https://api.github.com/users/AlleeX","html_url":"https://github.com/AlleeX","followers_url":"https://api.github.com/users/AlleeX/followers","following_url":"https://api.github.com/users/AlleeX/following{/other_user}","gists_url":"https://api.github.com/users/AlleeX/gists{/gist_id}","starred_url":"https://api.github.com/users/AlleeX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlleeX/subscriptions","organizations_url":"https://api.github.com/users/AlleeX/orgs","repos_url":"https://api.github.com/users/AlleeX/repos","events_url":"https://api.github.com/users/AlleeX/events{/privacy}","received_events_url":"https://api.github.com/users/AlleeX/received_events","type":"User","site_admin":false},"body":"# What does this PR do:\r\n\r\n Fix Unknown Prop Warning\r\n\r\n\r\n\r\n\r\n\r\n# Where should the reviewer start:\r\n\r\n Diff\r\n","created_at":"2017-11-13T08:17:28Z","updated_at":"2017-11-28T06:58:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b3e5b5b7a166edd60500a601bdc5836c0076d50","assignee":{"login":"AlleeX","id":10462372,"avatar_url":"https://avatars3.githubusercontent.com/u/10462372?v=4","gravatar_id":"","url":"https://api.github.com/users/AlleeX","html_url":"https://github.com/AlleeX","followers_url":"https://api.github.com/users/AlleeX/followers","following_url":"https://api.github.com/users/AlleeX/following{/other_user}","gists_url":"https://api.github.com/users/AlleeX/gists{/gist_id}","starred_url":"https://api.github.com/users/AlleeX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlleeX/subscriptions","organizations_url":"https://api.github.com/users/AlleeX/orgs","repos_url":"https://api.github.com/users/AlleeX/repos","events_url":"https://api.github.com/users/AlleeX/events{/privacy}","received_events_url":"https://api.github.com/users/AlleeX/received_events","type":"User","site_admin":false},"assignees":[{"login":"AlleeX","id":10462372,"avatar_url":"https://avatars3.githubusercontent.com/u/10462372?v=4","gravatar_id":"","url":"https://api.github.com/users/AlleeX","html_url":"https://github.com/AlleeX","followers_url":"https://api.github.com/users/AlleeX/followers","following_url":"https://api.github.com/users/AlleeX/following{/other_user}","gists_url":"https://api.github.com/users/AlleeX/gists{/gist_id}","starred_url":"https://api.github.com/users/AlleeX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlleeX/subscriptions","organizations_url":"https://api.github.com/users/AlleeX/orgs","repos_url":"https://api.github.com/users/AlleeX/repos","events_url":"https://api.github.com/users/AlleeX/events{/privacy}","received_events_url":"https://api.github.com/users/AlleeX/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/227/commits","review_comments_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/227/comments","review_comment_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/227/comments","statuses_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/statuses/023e92e00c4bbc77873639440e8ecc415fc697f5","head":{"label":"Travix-International:omit","ref":"omit","sha":"023e92e00c4bbc77873639440e8ecc415fc697f5","user":{"login":"Travix-International","id":13119702,"avatar_url":"https://avatars2.githubusercontent.com/u/13119702?v=4","gravatar_id":"","url":"https://api.github.com/users/Travix-International","html_url":"https://github.com/Travix-International","followers_url":"https://api.github.com/users/Travix-International/followers","following_url":"https://api.github.com/users/Travix-International/following{/other_user}","gists_url":"https://api.github.com/users/Travix-International/gists{/gist_id}","starred_url":"https://api.github.com/users/Travix-International/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Travix-International/subscriptions","organizations_url":"https://api.github.com/users/Travix-International/orgs","repos_url":"https://api.github.com/users/Travix-International/repos","events_url":"https://api.github.com/users/Travix-International/events{/privacy}","received_events_url":"https://api.github.com/users/Travix-International/received_events","type":"Organization","site_admin":false},"repo":{"id":78744180,"name":"travix-ui-kit","full_name":"Travix-International/travix-ui-kit","owner":{"login":"Travix-International","id":13119702,"avatar_url":"https://avatars2.githubusercontent.com/u/13119702?v=4","gravatar_id":"","url":"https://api.github.com/users/Travix-International","html_url":"https://github.com/Travix-International","followers_url":"https://api.github.com/users/Travix-International/followers","following_url":"https://api.github.com/users/Travix-International/following{/other_user}","gists_url":"https://api.github.com/users/Travix-International/gists{/gist_id}","starred_url":"https://api.github.com/users/Travix-International/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Travix-International/subscriptions","organizations_url":"https://api.github.com/users/Travix-International/orgs","repos_url":"https://api.github.com/users/Travix-International/repos","events_url":"https://api.github.com/users/Travix-International/events{/privacy}","received_events_url":"https://api.github.com/users/Travix-International/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Travix-International/travix-ui-kit","description":"Travix UI Components' repository.","fork":false,"url":"https://api.github.com/repos/Travix-International/travix-ui-kit","forks_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/forks","keys_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/teams","hooks_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/hooks","issue_events_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/events{/number}","events_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/events","assignees_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/assignees{/user}","branches_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/branches{/branch}","tags_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/tags","blobs_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/languages","stargazers_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/stargazers","contributors_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/contributors","subscribers_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/subscribers","subscription_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/subscription","commits_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/contents/{+path}","compare_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/merges","archive_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/downloads","issues_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues{/number}","pulls_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/labels{/name}","releases_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/releases{/id}","deployments_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/deployments","created_at":"2017-01-12T12:41:13Z","updated_at":"2017-10-11T11:24:49Z","pushed_at":"2017-11-27T22:18:10Z","git_url":"git://github.com/Travix-International/travix-ui-kit.git","ssh_url":"[email protected]:Travix-International/travix-ui-kit.git","clone_url":"https://github.com/Travix-International/travix-ui-kit.git","svn_url":"https://github.com/Travix-International/travix-ui-kit","homepage":null,"size":1139,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":10,"open_issues":25,"watchers":5,"default_branch":"master"}},"base":{"label":"Travix-International:master","ref":"master","sha":"f5e921bd14f06ea5845d5bdcec969602c34d0e2e","user":{"login":"Travix-International","id":13119702,"avatar_url":"https://avatars2.githubusercontent.com/u/13119702?v=4","gravatar_id":"","url":"https://api.github.com/users/Travix-International","html_url":"https://github.com/Travix-International","followers_url":"https://api.github.com/users/Travix-International/followers","following_url":"https://api.github.com/users/Travix-International/following{/other_user}","gists_url":"https://api.github.com/users/Travix-International/gists{/gist_id}","starred_url":"https://api.github.com/users/Travix-International/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Travix-International/subscriptions","organizations_url":"https://api.github.com/users/Travix-International/orgs","repos_url":"https://api.github.com/users/Travix-International/repos","events_url":"https://api.github.com/users/Travix-International/events{/privacy}","received_events_url":"https://api.github.com/users/Travix-International/received_events","type":"Organization","site_admin":false},"repo":{"id":78744180,"name":"travix-ui-kit","full_name":"Travix-International/travix-ui-kit","owner":{"login":"Travix-International","id":13119702,"avatar_url":"https://avatars2.githubusercontent.com/u/13119702?v=4","gravatar_id":"","url":"https://api.github.com/users/Travix-International","html_url":"https://github.com/Travix-International","followers_url":"https://api.github.com/users/Travix-International/followers","following_url":"https://api.github.com/users/Travix-International/following{/other_user}","gists_url":"https://api.github.com/users/Travix-International/gists{/gist_id}","starred_url":"https://api.github.com/users/Travix-International/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Travix-International/subscriptions","organizations_url":"https://api.github.com/users/Travix-International/orgs","repos_url":"https://api.github.com/users/Travix-International/repos","events_url":"https://api.github.com/users/Travix-International/events{/privacy}","received_events_url":"https://api.github.com/users/Travix-International/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Travix-International/travix-ui-kit","description":"Travix UI Components' repository.","fork":false,"url":"https://api.github.com/repos/Travix-International/travix-ui-kit","forks_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/forks","keys_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/teams","hooks_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/hooks","issue_events_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/events{/number}","events_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/events","assignees_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/assignees{/user}","branches_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/branches{/branch}","tags_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/tags","blobs_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/languages","stargazers_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/stargazers","contributors_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/contributors","subscribers_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/subscribers","subscription_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/subscription","commits_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/contents/{+path}","compare_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/merges","archive_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/downloads","issues_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues{/number}","pulls_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/labels{/name}","releases_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/releases{/id}","deployments_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/deployments","created_at":"2017-01-12T12:41:13Z","updated_at":"2017-10-11T11:24:49Z","pushed_at":"2017-11-27T22:18:10Z","git_url":"git://github.com/Travix-International/travix-ui-kit.git","ssh_url":"[email protected]:Travix-International/travix-ui-kit.git","clone_url":"https://github.com/Travix-International/travix-ui-kit.git","svn_url":"https://github.com/Travix-International/travix-ui-kit","homepage":null,"size":1139,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":10,"open_issues":25,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/227"},"html":{"href":"https://github.com/Travix-International/travix-ui-kit/pull/227"},"issue":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/227"},"comments":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/Travix-International/travix-ui-kit/statuses/023e92e00c4bbc77873639440e8ecc415fc697f5"}},"author_association":"CONTRIBUTOR"}} | {
"id": 78744180,
"name": "Travix-International/travix-ui-kit",
"url": "https://api.github.com/repos/Travix-International/travix-ui-kit"
} | {
"id": 1002056,
"login": "mAiNiNfEcTiOn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1002056?",
"url": "https://api.github.com/users/mAiNiNfEcTiOn"
} | {
"id": 13119702,
"login": "Travix-International",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13119702?",
"url": "https://api.github.com/orgs/Travix-International"
} | 2017-11-28T06:56:04 | 6911165255 | {"actor":{"display_login":"mAiNiNfEcTiOn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/comments/100683997","pull_request_review_id":21400506,"id":100683997,"diff_hunk":"@@ -85,7 +85,6 @@ public void inherit(RendererConfiguration ref) throws ConfigurationException {\n \t\tfilter = baseConf.filter;\n \n \t\t// Initialize our internal RendererConfiguration vars\n-\t\trenderCache = new HashMap<>();\n \t\tsortedHeaderMatcher = ref.sortedHeaderMatcher;","path":"src/main/java/net/pms/configuration/DeviceConfiguration.java","position":5,"original_position":5,"commit_id":"42a7dda74b686fcb0035ea3a45e5ea29705561ab","original_commit_id":"42a7dda74b686fcb0035ea3a45e5ea29705561ab","user":{"login":"SubJunk","id":584228,"avatar_url":"https://avatars.githubusercontent.com/u/584228?v=3","gravatar_id":"","url":"https://api.github.com/users/SubJunk","html_url":"https://github.com/SubJunk","followers_url":"https://api.github.com/users/SubJunk/followers","following_url":"https://api.github.com/users/SubJunk/following{/other_user}","gists_url":"https://api.github.com/users/SubJunk/gists{/gist_id}","starred_url":"https://api.github.com/users/SubJunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SubJunk/subscriptions","organizations_url":"https://api.github.com/users/SubJunk/orgs","repos_url":"https://api.github.com/users/SubJunk/repos","events_url":"https://api.github.com/users/SubJunk/events{/privacy}","received_events_url":"https://api.github.com/users/SubJunk/received_events","type":"User","site_admin":false},"body":"Cool, thanks for the approval!","created_at":"2017-02-12T05:41:56Z","updated_at":"2017-02-12T05:41:56Z","html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1189#discussion_r100683997","pull_request_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1189","_links":{"self":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/comments/100683997"},"html":{"href":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1189#discussion_r100683997"},"pull_request":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1189"}}},"pull_request":{"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1189","id":105776057,"html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1189","diff_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1189.diff","patch_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1189.patch","issue_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1189","number":1189,"state":"open","locked":false,"title":"Removed unused code that caused memory bloat","user":{"login":"SubJunk","id":584228,"avatar_url":"https://avatars.githubusercontent.com/u/584228?v=3","gravatar_id":"","url":"https://api.github.com/users/SubJunk","html_url":"https://github.com/SubJunk","followers_url":"https://api.github.com/users/SubJunk/followers","following_url":"https://api.github.com/users/SubJunk/following{/other_user}","gists_url":"https://api.github.com/users/SubJunk/gists{/gist_id}","starred_url":"https://api.github.com/users/SubJunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SubJunk/subscriptions","organizations_url":"https://api.github.com/users/SubJunk/orgs","repos_url":"https://api.github.com/users/SubJunk/repos","events_url":"https://api.github.com/users/SubJunk/events{/privacy}","received_events_url":"https://api.github.com/users/SubJunk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-12T02:05:59Z","updated_at":"2017-02-12T05:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd1e09df060f0d6ea39ef698443c365e96ac4b94","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1189/commits","review_comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1189/comments","review_comment_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1189/comments","statuses_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/statuses/42a7dda74b686fcb0035ea3a45e5ea29705561ab","head":{"label":"UniversalMediaServer:FixScanLeak","ref":"FixScanLeak","sha":"42a7dda74b686fcb0035ea3a45e5ea29705561ab","user":{"login":"UniversalMediaServer","id":1840565,"avatar_url":"https://avatars.githubusercontent.com/u/1840565?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalMediaServer","html_url":"https://github.com/UniversalMediaServer","followers_url":"https://api.github.com/users/UniversalMediaServer/followers","following_url":"https://api.github.com/users/UniversalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/UniversalMediaServer/orgs","repos_url":"https://api.github.com/users/UniversalMediaServer/repos","events_url":"https://api.github.com/users/UniversalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalMediaServer/received_events","type":"Organization","site_admin":false},"repo":{"id":4591214,"name":"UniversalMediaServer","full_name":"UniversalMediaServer/UniversalMediaServer","owner":{"login":"UniversalMediaServer","id":1840565,"avatar_url":"https://avatars.githubusercontent.com/u/1840565?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalMediaServer","html_url":"https://github.com/UniversalMediaServer","followers_url":"https://api.github.com/users/UniversalMediaServer/followers","following_url":"https://api.github.com/users/UniversalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/UniversalMediaServer/orgs","repos_url":"https://api.github.com/users/UniversalMediaServer/repos","events_url":"https://api.github.com/users/UniversalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalMediaServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer","description":"A DLNA-compliant UPnP Media Server.","fork":false,"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer","forks_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/forks","keys_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/teams","hooks_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/hooks","issue_events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/events{/number}","events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/events","assignees_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/assignees{/user}","branches_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/branches{/branch}","tags_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/tags","blobs_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/statuses/{sha}","languages_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/languages","stargazers_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/stargazers","contributors_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/contributors","subscribers_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/subscribers","subscription_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/subscription","commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/contents/{+path}","compare_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/merges","archive_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/downloads","issues_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues{/number}","pulls_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls{/number}","milestones_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/milestones{/number}","notifications_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/labels{/name}","releases_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/releases{/id}","deployments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/deployments","created_at":"2012-06-07T22:23:22Z","updated_at":"2017-02-05T12:19:58Z","pushed_at":"2017-02-12T04:13:10Z","git_url":"git://github.com/UniversalMediaServer/UniversalMediaServer.git","ssh_url":"[email protected]:UniversalMediaServer/UniversalMediaServer.git","clone_url":"https://github.com/UniversalMediaServer/UniversalMediaServer.git","svn_url":"https://github.com/UniversalMediaServer/UniversalMediaServer","homepage":null,"size":37977,"stargazers_count":477,"watchers_count":477,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":282,"forks":183,"open_issues":282,"watchers":477,"default_branch":"master"}},"base":{"label":"UniversalMediaServer:master","ref":"master","sha":"5453878a34d88c91ebfdc0e4d851d50d6b393329","user":{"login":"UniversalMediaServer","id":1840565,"avatar_url":"https://avatars.githubusercontent.com/u/1840565?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalMediaServer","html_url":"https://github.com/UniversalMediaServer","followers_url":"https://api.github.com/users/UniversalMediaServer/followers","following_url":"https://api.github.com/users/UniversalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/UniversalMediaServer/orgs","repos_url":"https://api.github.com/users/UniversalMediaServer/repos","events_url":"https://api.github.com/users/UniversalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalMediaServer/received_events","type":"Organization","site_admin":false},"repo":{"id":4591214,"name":"UniversalMediaServer","full_name":"UniversalMediaServer/UniversalMediaServer","owner":{"login":"UniversalMediaServer","id":1840565,"avatar_url":"https://avatars.githubusercontent.com/u/1840565?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalMediaServer","html_url":"https://github.com/UniversalMediaServer","followers_url":"https://api.github.com/users/UniversalMediaServer/followers","following_url":"https://api.github.com/users/UniversalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/UniversalMediaServer/orgs","repos_url":"https://api.github.com/users/UniversalMediaServer/repos","events_url":"https://api.github.com/users/UniversalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalMediaServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer","description":"A DLNA-compliant UPnP Media Server.","fork":false,"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer","forks_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/forks","keys_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/teams","hooks_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/hooks","issue_events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/events{/number}","events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/events","assignees_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/assignees{/user}","branches_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/branches{/branch}","tags_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/tags","blobs_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/statuses/{sha}","languages_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/languages","stargazers_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/stargazers","contributors_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/contributors","subscribers_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/subscribers","subscription_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/subscription","commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/contents/{+path}","compare_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/merges","archive_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/downloads","issues_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues{/number}","pulls_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls{/number}","milestones_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/milestones{/number}","notifications_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/labels{/name}","releases_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/releases{/id}","deployments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/deployments","created_at":"2012-06-07T22:23:22Z","updated_at":"2017-02-05T12:19:58Z","pushed_at":"2017-02-12T04:13:10Z","git_url":"git://github.com/UniversalMediaServer/UniversalMediaServer.git","ssh_url":"[email protected]:UniversalMediaServer/UniversalMediaServer.git","clone_url":"https://github.com/UniversalMediaServer/UniversalMediaServer.git","svn_url":"https://github.com/UniversalMediaServer/UniversalMediaServer","homepage":null,"size":37977,"stargazers_count":477,"watchers_count":477,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":282,"forks":183,"open_issues":282,"watchers":477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1189"},"html":{"href":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1189"},"issue":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1189"},"comments":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1189/comments"},"review_comments":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1189/comments"},"review_comment":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1189/commits"},"statuses":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/statuses/42a7dda74b686fcb0035ea3a45e5ea29705561ab"}}}} | {
"id": 4591214,
"name": "UniversalMediaServer/UniversalMediaServer",
"url": "https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer"
} | {
"id": 584228,
"login": "SubJunk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/584228?",
"url": "https://api.github.com/users/SubJunk"
} | {
"id": 1840565,
"login": "UniversalMediaServer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1840565?",
"url": "https://api.github.com/orgs/UniversalMediaServer"
} | 2017-02-12T05:41:56 | 5309089252 | {"actor":{"display_login":"SubJunk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/comments/104348120","pull_request_review_id":25180124,"id":104348120,"diff_hunk":"@@ -0,0 +1,154 @@\n+<!DOCTYPE html>\n+<html lang=\"ru\">\n+<head>\n+ <meta charset=\"utf-8\">\n+ <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">\n+ <meta http-equiv=\"X-UA-Compatible\" content=\"ie=edge\">\n+ <title>HTML Academy: Мишка - Вязание на заказ</title>\n+</head>\n+\n+<body>\n+ <header class=\"page-header\">\n+ <a class=\"page-header__logo\" href=\"index.html\"><img src=\"http://placehold.it/86x35\" alt=\"MISHKA\" width=\"86\" height=\"35\"></a>\n+\n+ <nav class=\"main-nav main-nav--closed\">\n+ <button class=\"main-nav__toggler\" type=\"button\">Открыть меню</button>\n+ <div class=\"main-nav__wrapper\">\n+ <ul class=\"main-nav__list\">\n+ <li class=\"main-nav__item main-nav__item--active\"><a href=\"catalog.html\">Каталог товаров</a></li>\n+ <li class=\"main-nav__item\"><a href=\"form.html\">Вязание на заказ</a></li>\n+ </ul>\n+\n+ <ul class=\"main-nav__user-list\">\n+ <li class=\"main-nav__user-item\"><a href=\"#\">Поиск по сайту</a></li>\n+ <li class=\"main-nav__user-item\"><a href=\"#\">Корзина: пока пуста</a></li>\n+ </ul>\n+ </div>\n+ </nav>\n+ </header>\n+\n+ <section class=\"knitting-order\">\n+ <h1 class=\"knitting-order__title\">Каталог товаров</h1>\n+\n+ <div class=\"knitting-order__wrapper\">\n+ <p class=\"knitting-order__intro\">Мы будем рады воплотить в жизнь ваши пожелания! Заполните простую форму заказа и мы свяжемся с вами, чтобы уточнить детали.</p>\n+\n+ <form class=\"knitting-order__form\" action=\"https://echo.htmlacademy.ru/\" method=\"post\">\n+ <fieldset class=\"knitting-order__fieldset\">\n+ <legend>Тип</legend>\n+ <ul class=\"knitting-order__fieldset-list\">\n+ <li class=\"knitting-order__type-item\">\n+ <input class=\"knitting-order__type-input\" type=\"radio\" id=\"type-one\" name=\"type-item\" value=\"type-one\" checked>\n+ <label class=\"knitting-order__type-label\" for=\"type-one\"> Аксессуар для интерьера</label>\n+ </li>\n+ <li class=\"knitting-order__type-item\">\n+ <input class=\"knitting-order__type-input\" type=\"radio\" id=\"type-two\" name=\"type-item\" value=\"type-two\">\n+ <label class=\"knitting-order__type-label\" for=\"type-two\"> Детская игрушка</label>\n+ </li>\n+ </ul>\n+ </fieldset>\n+\n+ <fieldset class=\"knitting-order__fieldset\">\n+ <legend>Цвет</legend>\n+ <ul class=\"knitting-order__fieldset-list\">\n+ <li class=\"knitting-order__color-item\">\n+ <label class=\"knitting-order__color-label\">\n+ <input class=\"knitting-order__color-input\" type=\"checkbox\" name=\"color-one\" checked>","path":"form.html","position":56,"original_position":56,"commit_id":"afd30753360e4a0d675c1c81805eecec5103b416","original_commit_id":"afd30753360e4a0d675c1c81805eecec5103b416","user":{"login":"mojereliev","id":13470898,"avatar_url":"https://avatars0.githubusercontent.com/u/13470898?v=3","gravatar_id":"","url":"https://api.github.com/users/mojereliev","html_url":"https://github.com/mojereliev","followers_url":"https://api.github.com/users/mojereliev/followers","following_url":"https://api.github.com/users/mojereliev/following{/other_user}","gists_url":"https://api.github.com/users/mojereliev/gists{/gist_id}","starred_url":"https://api.github.com/users/mojereliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojereliev/subscriptions","organizations_url":"https://api.github.com/users/mojereliev/orgs","repos_url":"https://api.github.com/users/mojereliev/repos","events_url":"https://api.github.com/users/mojereliev/events{/privacy}","received_events_url":"https://api.github.com/users/mojereliev/received_events","type":"User","site_admin":false},"body":"И тут, как и ниже у подобных конструкций","created_at":"2017-03-06T06:01:23Z","updated_at":"2017-03-06T06:03:55Z","html_url":"https://github.com/htmlacademy-adaptive/172908-mishka/pull/2#discussion_r104348120","pull_request_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/comments/104348120"},"html":{"href":"https://github.com/htmlacademy-adaptive/172908-mishka/pull/2#discussion_r104348120"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/2","id":109156943,"html_url":"https://github.com/htmlacademy-adaptive/172908-mishka/pull/2","diff_url":"https://github.com/htmlacademy-adaptive/172908-mishka/pull/2.diff","patch_url":"https://github.com/htmlacademy-adaptive/172908-mishka/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/issues/2","number":2,"state":"open","locked":false,"title":"Методичная разметка личного проекта","user":{"login":"ElizavetaOzerova","id":17642676,"avatar_url":"https://avatars3.githubusercontent.com/u/17642676?v=3","gravatar_id":"","url":"https://api.github.com/users/ElizavetaOzerova","html_url":"https://github.com/ElizavetaOzerova","followers_url":"https://api.github.com/users/ElizavetaOzerova/followers","following_url":"https://api.github.com/users/ElizavetaOzerova/following{/other_user}","gists_url":"https://api.github.com/users/ElizavetaOzerova/gists{/gist_id}","starred_url":"https://api.github.com/users/ElizavetaOzerova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElizavetaOzerova/subscriptions","organizations_url":"https://api.github.com/users/ElizavetaOzerova/orgs","repos_url":"https://api.github.com/users/ElizavetaOzerova/repos","events_url":"https://api.github.com/users/ElizavetaOzerova/events{/privacy}","received_events_url":"https://api.github.com/users/ElizavetaOzerova/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Методичная разметка личного проекта](https://up.htmlacademy.ru/adaptive/10/user/172908/tasks/8)\n\n:boom: https://htmlacademy-adaptive.github.io/172908-mishka/2/","created_at":"2017-03-05T17:29:56Z","updated_at":"2017-03-06T06:03:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f19954fe0b705862edd9096c572cc408c718f44","assignee":{"login":"mojereliev","id":13470898,"avatar_url":"https://avatars0.githubusercontent.com/u/13470898?v=3","gravatar_id":"","url":"https://api.github.com/users/mojereliev","html_url":"https://github.com/mojereliev","followers_url":"https://api.github.com/users/mojereliev/followers","following_url":"https://api.github.com/users/mojereliev/following{/other_user}","gists_url":"https://api.github.com/users/mojereliev/gists{/gist_id}","starred_url":"https://api.github.com/users/mojereliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojereliev/subscriptions","organizations_url":"https://api.github.com/users/mojereliev/orgs","repos_url":"https://api.github.com/users/mojereliev/repos","events_url":"https://api.github.com/users/mojereliev/events{/privacy}","received_events_url":"https://api.github.com/users/mojereliev/received_events","type":"User","site_admin":false},"assignees":[{"login":"mojereliev","id":13470898,"avatar_url":"https://avatars0.githubusercontent.com/u/13470898?v=3","gravatar_id":"","url":"https://api.github.com/users/mojereliev","html_url":"https://github.com/mojereliev","followers_url":"https://api.github.com/users/mojereliev/followers","following_url":"https://api.github.com/users/mojereliev/following{/other_user}","gists_url":"https://api.github.com/users/mojereliev/gists{/gist_id}","starred_url":"https://api.github.com/users/mojereliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojereliev/subscriptions","organizations_url":"https://api.github.com/users/mojereliev/orgs","repos_url":"https://api.github.com/users/mojereliev/repos","events_url":"https://api.github.com/users/mojereliev/events{/privacy}","received_events_url":"https://api.github.com/users/mojereliev/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/statuses/afd30753360e4a0d675c1c81805eecec5103b416","head":{"label":"ElizavetaOzerova:module2-task1","ref":"module2-task1","sha":"afd30753360e4a0d675c1c81805eecec5103b416","user":{"login":"ElizavetaOzerova","id":17642676,"avatar_url":"https://avatars3.githubusercontent.com/u/17642676?v=3","gravatar_id":"","url":"https://api.github.com/users/ElizavetaOzerova","html_url":"https://github.com/ElizavetaOzerova","followers_url":"https://api.github.com/users/ElizavetaOzerova/followers","following_url":"https://api.github.com/users/ElizavetaOzerova/following{/other_user}","gists_url":"https://api.github.com/users/ElizavetaOzerova/gists{/gist_id}","starred_url":"https://api.github.com/users/ElizavetaOzerova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElizavetaOzerova/subscriptions","organizations_url":"https://api.github.com/users/ElizavetaOzerova/orgs","repos_url":"https://api.github.com/users/ElizavetaOzerova/repos","events_url":"https://api.github.com/users/ElizavetaOzerova/events{/privacy}","received_events_url":"https://api.github.com/users/ElizavetaOzerova/received_events","type":"User","site_admin":false},"repo":{"id":83478966,"name":"172908-mishka","full_name":"ElizavetaOzerova/172908-mishka","owner":{"login":"ElizavetaOzerova","id":17642676,"avatar_url":"https://avatars3.githubusercontent.com/u/17642676?v=3","gravatar_id":"","url":"https://api.github.com/users/ElizavetaOzerova","html_url":"https://github.com/ElizavetaOzerova","followers_url":"https://api.github.com/users/ElizavetaOzerova/followers","following_url":"https://api.github.com/users/ElizavetaOzerova/following{/other_user}","gists_url":"https://api.github.com/users/ElizavetaOzerova/gists{/gist_id}","starred_url":"https://api.github.com/users/ElizavetaOzerova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElizavetaOzerova/subscriptions","organizations_url":"https://api.github.com/users/ElizavetaOzerova/orgs","repos_url":"https://api.github.com/users/ElizavetaOzerova/repos","events_url":"https://api.github.com/users/ElizavetaOzerova/events{/privacy}","received_events_url":"https://api.github.com/users/ElizavetaOzerova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ElizavetaOzerova/172908-mishka","description":"Елизавета Озерова","fork":true,"url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka","forks_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/forks","keys_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/teams","hooks_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/hooks","issue_events_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/issues/events{/number}","events_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/events","assignees_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/assignees{/user}","branches_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/branches{/branch}","tags_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/tags","blobs_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/statuses/{sha}","languages_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/languages","stargazers_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/stargazers","contributors_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/contributors","subscribers_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/subscribers","subscription_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/subscription","commits_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/contents/{+path}","compare_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/merges","archive_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/downloads","issues_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/issues{/number}","pulls_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/pulls{/number}","milestones_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/milestones{/number}","notifications_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/labels{/name}","releases_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/releases{/id}","deployments_url":"https://api.github.com/repos/ElizavetaOzerova/172908-mishka/deployments","created_at":"2017-02-28T21:04:13Z","updated_at":"2017-02-28T21:04:15Z","pushed_at":"2017-03-05T17:29:41Z","git_url":"git://github.com/ElizavetaOzerova/172908-mishka.git","ssh_url":"[email protected]:ElizavetaOzerova/172908-mishka.git","clone_url":"https://github.com/ElizavetaOzerova/172908-mishka.git","svn_url":"https://github.com/ElizavetaOzerova/172908-mishka","homepage":null,"size":14,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-adaptive:master","ref":"master","sha":"ac20d6f167b8e84f21207302f7702ced4ad27228","user":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars3.githubusercontent.com/u/9918669?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"repo":{"id":83395837,"name":"172908-mishka","full_name":"htmlacademy-adaptive/172908-mishka","owner":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars3.githubusercontent.com/u/9918669?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-adaptive/172908-mishka","description":"Елизавета Озерова","fork":false,"url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka","forks_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/forks","keys_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/teams","hooks_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/events","assignees_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/tags","blobs_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/subscription","commits_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/merges","archive_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/downloads","issues_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/deployments","created_at":"2017-02-28T06:03:41Z","updated_at":"2017-03-04T10:50:34Z","pushed_at":"2017-03-06T05:57:20Z","git_url":"git://github.com/htmlacademy-adaptive/172908-mishka.git","ssh_url":"[email protected]:htmlacademy-adaptive/172908-mishka.git","clone_url":"https://github.com/htmlacademy-adaptive/172908-mishka.git","svn_url":"https://github.com/htmlacademy-adaptive/172908-mishka","homepage":"https://github.com/ElizavetaOzerova/172908-mishka","size":8,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/2"},"html":{"href":"https://github.com/htmlacademy-adaptive/172908-mishka/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-adaptive/172908-mishka/statuses/afd30753360e4a0d675c1c81805eecec5103b416"}}}} | {
"id": 83395837,
"name": "htmlacademy-adaptive/172908-mishka",
"url": "https://api.github.com/repos/htmlacademy-adaptive/172908-mishka"
} | {
"id": 13470898,
"login": "mojereliev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13470898?",
"url": "https://api.github.com/users/mojereliev"
} | {
"id": 9918669,
"login": "htmlacademy-adaptive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9918669?",
"url": "https://api.github.com/orgs/htmlacademy-adaptive"
} | 2017-03-06T06:01:23 | 5437264404 | {"actor":{"display_login":"mojereliev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/comments/144244792","pull_request_review_id":68874113,"id":144244792,"diff_hunk":"@@ -3,13 +3,66 @@\n margin: $mgn;\n background-color: $bg-color;\n background-image: url(\"../img/[email protected]\");\n+ background-repeat: no-repeat;\n background-size: cover;\n- background-position: center center;\n+ background-position: center;\n height: 730px;\n+ display: table;\n }\n \n .page-header__top {\n+ display: flex;\n+ padding-top: 20px;\n+ width: 100%;\n position: absolute;\n top: 0;\n left: 0;\n+ height: 45px;\n+ background-color: rgba(0, 0, 0, 0.3);\n+}\n+\n+\n+@media (min-width: 660px) {\n+ .page-header {\n+ width: 100%;\n+ margin: $mgn;\n+ background-image: url(\"../img/[email protected]\");\n+ background-size: cover;\n+ }\n+\n+ .page-header__top {\n+ height: 110px;\n+ line-height: 110px;\n+ padding-top: 0;\n+ }\n+\n+ .page-header__top .wrapper {\n+ width: 620px;\n+ }\n+}\n+\n+@media (min-width: 960px) {\n+ .page-header {\n+ width: 100%;","path":"sass/page-header.scss","position":45,"original_position":45,"commit_id":"017e49cec2bcd8e927bbe0701204fa26ea2de3b1","original_commit_id":"017e49cec2bcd8e927bbe0701204fa26ea2de3b1","user":{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"body":"опять дублируешь (+ это правило мы уже удалил)\r\nв медиа пишется только то что переопределяется остальное все идет наследованием\r\nесли тебе не нужно перезаписывать правило и ты его не вносишь в медиа, то оно действует на всех экранах\r\nто что переопределил в медиа работается со значения медиа до конца, либо пока опять не переопределишь","created_at":"2017-10-12T10:01:52Z","updated_at":"2017-10-12T10:01:52Z","html_url":"https://github.com/htmlacademy-adaptive/224129-pink/pull/4#discussion_r144244792","pull_request_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/comments/144244792"},"html":{"href":"https://github.com/htmlacademy-adaptive/224129-pink/pull/4#discussion_r144244792"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/4","id":145916944,"html_url":"https://github.com/htmlacademy-adaptive/224129-pink/pull/4","diff_url":"https://github.com/htmlacademy-adaptive/224129-pink/pull/4.diff","patch_url":"https://github.com/htmlacademy-adaptive/224129-pink/pull/4.patch","issue_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/issues/4","number":4,"state":"open","locked":false,"title":"Верстаем адаптивные сетки","user":{"login":"allexfree","id":23383792,"avatar_url":"https://avatars0.githubusercontent.com/u/23383792?v=4","gravatar_id":"","url":"https://api.github.com/users/allexfree","html_url":"https://github.com/allexfree","followers_url":"https://api.github.com/users/allexfree/followers","following_url":"https://api.github.com/users/allexfree/following{/other_user}","gists_url":"https://api.github.com/users/allexfree/gists{/gist_id}","starred_url":"https://api.github.com/users/allexfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allexfree/subscriptions","organizations_url":"https://api.github.com/users/allexfree/orgs","repos_url":"https://api.github.com/users/allexfree/repos","events_url":"https://api.github.com/users/allexfree/events{/privacy}","received_events_url":"https://api.github.com/users/allexfree/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Верстаем адаптивные сетки](https://up.htmlacademy.ru/adaptive/12/user/224129/tasks/10)\n\n:boom: https://htmlacademy-adaptive.github.io/224129-pink/4/","created_at":"2017-10-11T10:56:13Z","updated_at":"2017-10-12T10:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9cad515954775470988655e2f2eba528886f11b","assignee":{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"sergeykravchenko","id":9842814,"avatar_url":"https://avatars1.githubusercontent.com/u/9842814?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykravchenko","html_url":"https://github.com/sergeykravchenko","followers_url":"https://api.github.com/users/sergeykravchenko/followers","following_url":"https://api.github.com/users/sergeykravchenko/following{/other_user}","gists_url":"https://api.github.com/users/sergeykravchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykravchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykravchenko/subscriptions","organizations_url":"https://api.github.com/users/sergeykravchenko/orgs","repos_url":"https://api.github.com/users/sergeykravchenko/repos","events_url":"https://api.github.com/users/sergeykravchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykravchenko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/4/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/4/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/issues/4/comments","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/statuses/017e49cec2bcd8e927bbe0701204fa26ea2de3b1","head":{"label":"allexfree:module4-task1","ref":"module4-task1","sha":"017e49cec2bcd8e927bbe0701204fa26ea2de3b1","user":{"login":"allexfree","id":23383792,"avatar_url":"https://avatars0.githubusercontent.com/u/23383792?v=4","gravatar_id":"","url":"https://api.github.com/users/allexfree","html_url":"https://github.com/allexfree","followers_url":"https://api.github.com/users/allexfree/followers","following_url":"https://api.github.com/users/allexfree/following{/other_user}","gists_url":"https://api.github.com/users/allexfree/gists{/gist_id}","starred_url":"https://api.github.com/users/allexfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allexfree/subscriptions","organizations_url":"https://api.github.com/users/allexfree/orgs","repos_url":"https://api.github.com/users/allexfree/repos","events_url":"https://api.github.com/users/allexfree/events{/privacy}","received_events_url":"https://api.github.com/users/allexfree/received_events","type":"User","site_admin":false},"repo":{"id":103988689,"name":"224129-pink","full_name":"allexfree/224129-pink","owner":{"login":"allexfree","id":23383792,"avatar_url":"https://avatars0.githubusercontent.com/u/23383792?v=4","gravatar_id":"","url":"https://api.github.com/users/allexfree","html_url":"https://github.com/allexfree","followers_url":"https://api.github.com/users/allexfree/followers","following_url":"https://api.github.com/users/allexfree/following{/other_user}","gists_url":"https://api.github.com/users/allexfree/gists{/gist_id}","starred_url":"https://api.github.com/users/allexfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allexfree/subscriptions","organizations_url":"https://api.github.com/users/allexfree/orgs","repos_url":"https://api.github.com/users/allexfree/repos","events_url":"https://api.github.com/users/allexfree/events{/privacy}","received_events_url":"https://api.github.com/users/allexfree/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allexfree/224129-pink","description":"Александр Ненахов","fork":true,"url":"https://api.github.com/repos/allexfree/224129-pink","forks_url":"https://api.github.com/repos/allexfree/224129-pink/forks","keys_url":"https://api.github.com/repos/allexfree/224129-pink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allexfree/224129-pink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allexfree/224129-pink/teams","hooks_url":"https://api.github.com/repos/allexfree/224129-pink/hooks","issue_events_url":"https://api.github.com/repos/allexfree/224129-pink/issues/events{/number}","events_url":"https://api.github.com/repos/allexfree/224129-pink/events","assignees_url":"https://api.github.com/repos/allexfree/224129-pink/assignees{/user}","branches_url":"https://api.github.com/repos/allexfree/224129-pink/branches{/branch}","tags_url":"https://api.github.com/repos/allexfree/224129-pink/tags","blobs_url":"https://api.github.com/repos/allexfree/224129-pink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allexfree/224129-pink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allexfree/224129-pink/git/refs{/sha}","trees_url":"https://api.github.com/repos/allexfree/224129-pink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allexfree/224129-pink/statuses/{sha}","languages_url":"https://api.github.com/repos/allexfree/224129-pink/languages","stargazers_url":"https://api.github.com/repos/allexfree/224129-pink/stargazers","contributors_url":"https://api.github.com/repos/allexfree/224129-pink/contributors","subscribers_url":"https://api.github.com/repos/allexfree/224129-pink/subscribers","subscription_url":"https://api.github.com/repos/allexfree/224129-pink/subscription","commits_url":"https://api.github.com/repos/allexfree/224129-pink/commits{/sha}","git_commits_url":"https://api.github.com/repos/allexfree/224129-pink/git/commits{/sha}","comments_url":"https://api.github.com/repos/allexfree/224129-pink/comments{/number}","issue_comment_url":"https://api.github.com/repos/allexfree/224129-pink/issues/comments{/number}","contents_url":"https://api.github.com/repos/allexfree/224129-pink/contents/{+path}","compare_url":"https://api.github.com/repos/allexfree/224129-pink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allexfree/224129-pink/merges","archive_url":"https://api.github.com/repos/allexfree/224129-pink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allexfree/224129-pink/downloads","issues_url":"https://api.github.com/repos/allexfree/224129-pink/issues{/number}","pulls_url":"https://api.github.com/repos/allexfree/224129-pink/pulls{/number}","milestones_url":"https://api.github.com/repos/allexfree/224129-pink/milestones{/number}","notifications_url":"https://api.github.com/repos/allexfree/224129-pink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allexfree/224129-pink/labels{/name}","releases_url":"https://api.github.com/repos/allexfree/224129-pink/releases{/id}","deployments_url":"https://api.github.com/repos/allexfree/224129-pink/deployments","created_at":"2017-09-18T20:29:30Z","updated_at":"2017-09-18T20:29:32Z","pushed_at":"2017-10-11T11:49:23Z","git_url":"git://github.com/allexfree/224129-pink.git","ssh_url":"[email protected]:allexfree/224129-pink.git","clone_url":"https://github.com/allexfree/224129-pink.git","svn_url":"https://github.com/allexfree/224129-pink","homepage":null,"size":2381,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-adaptive:master","ref":"master","sha":"ff112e0d21574b478d7d76270d816aeda3be6df1","user":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"repo":{"id":103988364,"name":"224129-pink","full_name":"htmlacademy-adaptive/224129-pink","owner":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-adaptive/224129-pink","description":"Александр Ненахов","fork":false,"url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink","forks_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/forks","keys_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/teams","hooks_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/events","assignees_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/tags","blobs_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/subscription","commits_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/merges","archive_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/downloads","issues_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/deployments","created_at":"2017-09-18T20:25:54Z","updated_at":"2017-09-19T13:08:08Z","pushed_at":"2017-10-12T08:18:12Z","git_url":"git://github.com/htmlacademy-adaptive/224129-pink.git","ssh_url":"[email protected]:htmlacademy-adaptive/224129-pink.git","clone_url":"https://github.com/htmlacademy-adaptive/224129-pink.git","svn_url":"https://github.com/htmlacademy-adaptive/224129-pink","homepage":"https://github.com/allexfree/224129-pink","size":2381,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/4"},"html":{"href":"https://github.com/htmlacademy-adaptive/224129-pink/pull/4"},"issue":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/issues/4"},"comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-adaptive/224129-pink/statuses/017e49cec2bcd8e927bbe0701204fa26ea2de3b1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 103988364,
"name": "htmlacademy-adaptive/224129-pink",
"url": "https://api.github.com/repos/htmlacademy-adaptive/224129-pink"
} | {
"id": 9842814,
"login": "sergeykravchenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9842814?",
"url": "https://api.github.com/users/sergeykravchenko"
} | {
"id": 9918669,
"login": "htmlacademy-adaptive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9918669?",
"url": "https://api.github.com/orgs/htmlacademy-adaptive"
} | 2017-10-12T10:01:52 | 6707194422 | {"actor":{"display_login":"sergeykravchenko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/comments/105432099","pull_request_review_id":26315822,"id":105432099,"diff_hunk":"@@ -0,0 +1,15 @@\n+@font-face {","path":"sass/blocks/font.scss","position":1,"original_position":1,"commit_id":"8b372139fe1a34367abe9b735f3d2cd23a45bd6e","original_commit_id":"62f30b410df63db112b7af756530109611514e63","user":{"login":"redly","id":1064836,"avatar_url":"https://avatars1.githubusercontent.com/u/1064836?v=3","gravatar_id":"","url":"https://api.github.com/users/redly","html_url":"https://github.com/redly","followers_url":"https://api.github.com/users/redly/followers","following_url":"https://api.github.com/users/redly/following{/other_user}","gists_url":"https://api.github.com/users/redly/gists{/gist_id}","starred_url":"https://api.github.com/users/redly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redly/subscriptions","organizations_url":"https://api.github.com/users/redly/orgs","repos_url":"https://api.github.com/users/redly/repos","events_url":"https://api.github.com/users/redly/events{/privacy}","received_events_url":"https://api.github.com/users/redly/received_events","type":"User","site_admin":false},"body":"Ну это же не блок\r\nЭто подключение шрифтов, зачем это в папке blocks?","created_at":"2017-03-10T16:23:59Z","updated_at":"2017-03-10T16:38:10Z","html_url":"https://github.com/htmlacademy-adaptive/247319-sedona/pull/3#discussion_r105432099","pull_request_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/comments/105432099"},"html":{"href":"https://github.com/htmlacademy-adaptive/247319-sedona/pull/3#discussion_r105432099"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/3","id":110117781,"html_url":"https://github.com/htmlacademy-adaptive/247319-sedona/pull/3","diff_url":"https://github.com/htmlacademy-adaptive/247319-sedona/pull/3.diff","patch_url":"https://github.com/htmlacademy-adaptive/247319-sedona/pull/3.patch","issue_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/issues/3","number":3,"state":"open","locked":false,"title":"Начинаем вёрстку с CSS-препроцессором","user":{"login":"Milaev","id":20668605,"avatar_url":"https://avatars2.githubusercontent.com/u/20668605?v=3","gravatar_id":"","url":"https://api.github.com/users/Milaev","html_url":"https://github.com/Milaev","followers_url":"https://api.github.com/users/Milaev/followers","following_url":"https://api.github.com/users/Milaev/following{/other_user}","gists_url":"https://api.github.com/users/Milaev/gists{/gist_id}","starred_url":"https://api.github.com/users/Milaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Milaev/subscriptions","organizations_url":"https://api.github.com/users/Milaev/orgs","repos_url":"https://api.github.com/users/Milaev/repos","events_url":"https://api.github.com/users/Milaev/events{/privacy}","received_events_url":"https://api.github.com/users/Milaev/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Начинаем вёрстку с CSS-препроцессором](https://up.htmlacademy.ru/adaptive/10/user/247319/tasks/12)\n\n:boom: https://htmlacademy-adaptive.github.io/247319-sedona/3/","created_at":"2017-03-10T12:17:59Z","updated_at":"2017-03-10T16:38:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44079836d3f8bfbd76257bcbf0ddcc101b37b33c","assignee":{"login":"redly","id":1064836,"avatar_url":"https://avatars1.githubusercontent.com/u/1064836?v=3","gravatar_id":"","url":"https://api.github.com/users/redly","html_url":"https://github.com/redly","followers_url":"https://api.github.com/users/redly/followers","following_url":"https://api.github.com/users/redly/following{/other_user}","gists_url":"https://api.github.com/users/redly/gists{/gist_id}","starred_url":"https://api.github.com/users/redly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redly/subscriptions","organizations_url":"https://api.github.com/users/redly/orgs","repos_url":"https://api.github.com/users/redly/repos","events_url":"https://api.github.com/users/redly/events{/privacy}","received_events_url":"https://api.github.com/users/redly/received_events","type":"User","site_admin":false},"assignees":[{"login":"redly","id":1064836,"avatar_url":"https://avatars1.githubusercontent.com/u/1064836?v=3","gravatar_id":"","url":"https://api.github.com/users/redly","html_url":"https://github.com/redly","followers_url":"https://api.github.com/users/redly/followers","following_url":"https://api.github.com/users/redly/following{/other_user}","gists_url":"https://api.github.com/users/redly/gists{/gist_id}","starred_url":"https://api.github.com/users/redly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redly/subscriptions","organizations_url":"https://api.github.com/users/redly/orgs","repos_url":"https://api.github.com/users/redly/repos","events_url":"https://api.github.com/users/redly/events{/privacy}","received_events_url":"https://api.github.com/users/redly/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/3/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/3/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/issues/3/comments","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/statuses/8b372139fe1a34367abe9b735f3d2cd23a45bd6e","head":{"label":"Milaev:module3-task1","ref":"module3-task1","sha":"8b372139fe1a34367abe9b735f3d2cd23a45bd6e","user":{"login":"Milaev","id":20668605,"avatar_url":"https://avatars2.githubusercontent.com/u/20668605?v=3","gravatar_id":"","url":"https://api.github.com/users/Milaev","html_url":"https://github.com/Milaev","followers_url":"https://api.github.com/users/Milaev/followers","following_url":"https://api.github.com/users/Milaev/following{/other_user}","gists_url":"https://api.github.com/users/Milaev/gists{/gist_id}","starred_url":"https://api.github.com/users/Milaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Milaev/subscriptions","organizations_url":"https://api.github.com/users/Milaev/orgs","repos_url":"https://api.github.com/users/Milaev/repos","events_url":"https://api.github.com/users/Milaev/events{/privacy}","received_events_url":"https://api.github.com/users/Milaev/received_events","type":"User","site_admin":false},"repo":{"id":83423922,"name":"247319-sedona","full_name":"Milaev/247319-sedona","owner":{"login":"Milaev","id":20668605,"avatar_url":"https://avatars2.githubusercontent.com/u/20668605?v=3","gravatar_id":"","url":"https://api.github.com/users/Milaev","html_url":"https://github.com/Milaev","followers_url":"https://api.github.com/users/Milaev/followers","following_url":"https://api.github.com/users/Milaev/following{/other_user}","gists_url":"https://api.github.com/users/Milaev/gists{/gist_id}","starred_url":"https://api.github.com/users/Milaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Milaev/subscriptions","organizations_url":"https://api.github.com/users/Milaev/orgs","repos_url":"https://api.github.com/users/Milaev/repos","events_url":"https://api.github.com/users/Milaev/events{/privacy}","received_events_url":"https://api.github.com/users/Milaev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Milaev/247319-sedona","description":"Роман Милаев","fork":true,"url":"https://api.github.com/repos/Milaev/247319-sedona","forks_url":"https://api.github.com/repos/Milaev/247319-sedona/forks","keys_url":"https://api.github.com/repos/Milaev/247319-sedona/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Milaev/247319-sedona/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Milaev/247319-sedona/teams","hooks_url":"https://api.github.com/repos/Milaev/247319-sedona/hooks","issue_events_url":"https://api.github.com/repos/Milaev/247319-sedona/issues/events{/number}","events_url":"https://api.github.com/repos/Milaev/247319-sedona/events","assignees_url":"https://api.github.com/repos/Milaev/247319-sedona/assignees{/user}","branches_url":"https://api.github.com/repos/Milaev/247319-sedona/branches{/branch}","tags_url":"https://api.github.com/repos/Milaev/247319-sedona/tags","blobs_url":"https://api.github.com/repos/Milaev/247319-sedona/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Milaev/247319-sedona/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Milaev/247319-sedona/git/refs{/sha}","trees_url":"https://api.github.com/repos/Milaev/247319-sedona/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Milaev/247319-sedona/statuses/{sha}","languages_url":"https://api.github.com/repos/Milaev/247319-sedona/languages","stargazers_url":"https://api.github.com/repos/Milaev/247319-sedona/stargazers","contributors_url":"https://api.github.com/repos/Milaev/247319-sedona/contributors","subscribers_url":"https://api.github.com/repos/Milaev/247319-sedona/subscribers","subscription_url":"https://api.github.com/repos/Milaev/247319-sedona/subscription","commits_url":"https://api.github.com/repos/Milaev/247319-sedona/commits{/sha}","git_commits_url":"https://api.github.com/repos/Milaev/247319-sedona/git/commits{/sha}","comments_url":"https://api.github.com/repos/Milaev/247319-sedona/comments{/number}","issue_comment_url":"https://api.github.com/repos/Milaev/247319-sedona/issues/comments{/number}","contents_url":"https://api.github.com/repos/Milaev/247319-sedona/contents/{+path}","compare_url":"https://api.github.com/repos/Milaev/247319-sedona/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Milaev/247319-sedona/merges","archive_url":"https://api.github.com/repos/Milaev/247319-sedona/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Milaev/247319-sedona/downloads","issues_url":"https://api.github.com/repos/Milaev/247319-sedona/issues{/number}","pulls_url":"https://api.github.com/repos/Milaev/247319-sedona/pulls{/number}","milestones_url":"https://api.github.com/repos/Milaev/247319-sedona/milestones{/number}","notifications_url":"https://api.github.com/repos/Milaev/247319-sedona/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Milaev/247319-sedona/labels{/name}","releases_url":"https://api.github.com/repos/Milaev/247319-sedona/releases{/id}","deployments_url":"https://api.github.com/repos/Milaev/247319-sedona/deployments","created_at":"2017-02-28T11:18:43Z","updated_at":"2017-03-09T13:32:23Z","pushed_at":"2017-03-10T16:37:19Z","git_url":"git://github.com/Milaev/247319-sedona.git","ssh_url":"[email protected]:Milaev/247319-sedona.git","clone_url":"https://github.com/Milaev/247319-sedona.git","svn_url":"https://github.com/Milaev/247319-sedona","homepage":null,"size":575,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-adaptive:master","ref":"master","sha":"24a83eaea27948543b53d7119f5fbbe7d86d99bf","user":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars3.githubusercontent.com/u/9918669?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"repo":{"id":83348500,"name":"247319-sedona","full_name":"htmlacademy-adaptive/247319-sedona","owner":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars3.githubusercontent.com/u/9918669?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-adaptive/247319-sedona","description":"Роман Милаев","fork":false,"url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona","forks_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/forks","keys_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/teams","hooks_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/events","assignees_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/tags","blobs_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/subscription","commits_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/merges","archive_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/downloads","issues_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/deployments","created_at":"2017-02-27T19:32:46Z","updated_at":"2017-03-09T13:11:17Z","pushed_at":"2017-03-10T16:37:20Z","git_url":"git://github.com/htmlacademy-adaptive/247319-sedona.git","ssh_url":"[email protected]:htmlacademy-adaptive/247319-sedona.git","clone_url":"https://github.com/htmlacademy-adaptive/247319-sedona.git","svn_url":"https://github.com/htmlacademy-adaptive/247319-sedona","homepage":"https://github.com/Milaev/247319-sedona","size":579,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/3"},"html":{"href":"https://github.com/htmlacademy-adaptive/247319-sedona/pull/3"},"issue":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/issues/3"},"comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-adaptive/247319-sedona/statuses/8b372139fe1a34367abe9b735f3d2cd23a45bd6e"}}}} | {
"id": 83348500,
"name": "htmlacademy-adaptive/247319-sedona",
"url": "https://api.github.com/repos/htmlacademy-adaptive/247319-sedona"
} | {
"id": 1064836,
"login": "redly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1064836?",
"url": "https://api.github.com/users/redly"
} | {
"id": 9918669,
"login": "htmlacademy-adaptive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9918669?",
"url": "https://api.github.com/orgs/htmlacademy-adaptive"
} | 2017-03-10T16:23:59 | 5471776307 | {"actor":{"display_login":"redly"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/comments/104310369","pull_request_review_id":25144037,"id":104310369,"diff_hunk":"@@ -0,0 +1,150 @@\n+<!DOCTYPE html>\n+<html lang=\"ru\">\n+ <head>\n+ <meta charset=\"UTF-8\">\n+ <title>Вязание на заказ</title>\n+ </head>\n+ <body>\n+\n+ <header class=\"page-header\">\n+ <a class=\"page-header__logo\" href=\"index.html\">\n+ <img src=\"http://placehold.it/86x35\" alt=\"Mishka logo\" width=\"86\" height=\"35\">\n+ </a>\n+ <nav class=\"page-header__menu\">\n+ <ul class=\"page-header__list\">\n+ <li class=\"page-header__item\"><a class=\"page-header__link\" href=\"catalog.html\">Каталог товаров</a></li>\n+ <li class=\"page-header__item\"><a class=\"page-header__link\">Вязание на заказ</a></li>\n+ <li class=\"page-header__item\"><a class=\"page-header__link\" href=\"#\">Поиск по сайту</a></li>\n+ <li class=\"page-header__item\"><a class=\"page-header__link\" href=\"#\">Корзина: пока пуста</a></li>\n+ </ul>\n+ </nav>\n+ </header>\n+\n+ <main class=\"page-main\">\n+\n+ <section class=\"mishka\">\n+ <h2 class=\"mishka__title\">Вязание на заказ</h2>\n+ </section>\n+\n+ <section class=\"content\">\n+ <p class=\"content__desc\">Мы будем рады воплотить в жизнь ваши пожелания! Заполните простую форму заказа и мы свяжемся с вами, чтобы уточнить детали.</p>\n+\n+ <form class=\"form\" action=\"https://echo.htmlacademy.ru/\" method=\"get\">\n+\n+ <fieldset class=\"form__fieldset\">\n+ <legend class=\"form__title\">Тип</legend>\n+ <label class=\"label label--type\">\n+ <input class=\"label__radio\" name=\"type\" type=\"radio\" value=\"Аксессуар для интерьера\" checked>\n+ <span class=\"label__circle\"></span>\n+ <span class=\"label__text\">Аксессуар для интерьера</span>\n+ </label>\n+ <label class=\"label label--type\">\n+ <input class=\"label__radio\" name=\"type\" type=\"radio\" value=\"Детская игрушка\">\n+ <span class=\"label__circle\"></span>\n+ <span class=\"label__text\">Детская игрушка</span>\n+ </label>\n+ </fieldset>\n+\n+ <fieldset class=\"form__fieldset\">\n+ <legend class=\"form__title\">Цвет</legend>\n+ <label class=\"label label--color\">\n+ <input class=\"label__checkbox\" name=\"color\" type=\"checkbox\" value=\"Белый\" checked>\n+ <span class=\"label__box\"></span>\n+ <span class=\"label__text\">Белый</span>\n+ </label>\n+ <label class=\"label label--color\">\n+ <input class=\"label__checkbox\" name=\"color\" type=\"checkbox\" value=\"Серый\" checked>\n+ <span class=\"label__box\"></span>\n+ <span class=\"label__text\">Серый</span>\n+ </label>\n+ <label class=\"label label--color\">\n+ <input class=\"label__checkbox\" name=\"color\" type=\"checkbox\" value=\"«Тиффани»\">\n+ <span class=\"label__box\"></span>\n+ <span class=\"label__text\">«Тиффани»</span>\n+ </label>\n+ <label class=\"label label--color\">\n+ <input class=\"label__checkbox\" name=\"color\" type=\"checkbox\" value=\"Черный\">\n+ <span class=\"label__box\"></span>\n+ <span class=\"label__text\">Черный</span>\n+ </label>\n+ <label class=\"label label--color\">\n+ <input class=\"label__checkbox\" name=\"color\" type=\"checkbox\" value=\"Розовый\">\n+ <span class=\"label__box\"></span>\n+ <span class=\"label__text\">Розовый</span>\n+ </label>\n+ <label class=\"label label--color\">\n+ <input class=\"label__checkbox\" name=\"color\" type=\"checkbox\" value=\"Оранжевый\">\n+ <span class=\"label__box\"></span>\n+ <span class=\"label__text\">Оранжевый</span>\n+ </label>\n+ </fieldset>\n+\n+ <fieldset class=\"form__fieldset\">\n+ <legend class=\"form__title\">Фио</legend>\n+ <label class=\"label label--name\">\n+ <span class=\"label__text\">Имя:</span>\n+ <input class=\"field\" type=\"text\" name=\"name\" placeholder=\"Введите ваше имя*\" required>","path":"form.html","position":86,"original_position":86,"commit_id":"a6233156ad595e4c94cf47bd8f1f79a196e5b34b","original_commit_id":"a6233156ad595e4c94cf47bd8f1f79a196e5b34b","user":{"login":"isqua","id":529247,"avatar_url":"https://avatars2.githubusercontent.com/u/529247?v=3","gravatar_id":"","url":"https://api.github.com/users/isqua","html_url":"https://github.com/isqua","followers_url":"https://api.github.com/users/isqua/followers","following_url":"https://api.github.com/users/isqua/following{/other_user}","gists_url":"https://api.github.com/users/isqua/gists{/gist_id}","starred_url":"https://api.github.com/users/isqua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isqua/subscriptions","organizations_url":"https://api.github.com/users/isqua/orgs","repos_url":"https://api.github.com/users/isqua/repos","events_url":"https://api.github.com/users/isqua/events{/privacy}","received_events_url":"https://api.github.com/users/isqua/received_events","type":"User","site_admin":false},"body":"А это какой блок/элемент?","created_at":"2017-03-05T11:30:16Z","updated_at":"2017-03-05T11:31:40Z","html_url":"https://github.com/htmlacademy-adaptive/214958-mishka/pull/2#discussion_r104310369","pull_request_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/comments/104310369"},"html":{"href":"https://github.com/htmlacademy-adaptive/214958-mishka/pull/2#discussion_r104310369"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/2","id":109102888,"html_url":"https://github.com/htmlacademy-adaptive/214958-mishka/pull/2","diff_url":"https://github.com/htmlacademy-adaptive/214958-mishka/pull/2.diff","patch_url":"https://github.com/htmlacademy-adaptive/214958-mishka/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/issues/2","number":2,"state":"open","locked":false,"title":"Методичная разметка личного проекта","user":{"login":"YakunovAnton","id":18160956,"avatar_url":"https://avatars1.githubusercontent.com/u/18160956?v=3","gravatar_id":"","url":"https://api.github.com/users/YakunovAnton","html_url":"https://github.com/YakunovAnton","followers_url":"https://api.github.com/users/YakunovAnton/followers","following_url":"https://api.github.com/users/YakunovAnton/following{/other_user}","gists_url":"https://api.github.com/users/YakunovAnton/gists{/gist_id}","starred_url":"https://api.github.com/users/YakunovAnton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YakunovAnton/subscriptions","organizations_url":"https://api.github.com/users/YakunovAnton/orgs","repos_url":"https://api.github.com/users/YakunovAnton/repos","events_url":"https://api.github.com/users/YakunovAnton/events{/privacy}","received_events_url":"https://api.github.com/users/YakunovAnton/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Методичная разметка личного проекта](https://up.htmlacademy.ru/adaptive/10/user/214958/tasks/8)\n\n:boom: https://htmlacademy-adaptive.github.io/214958-mishka/2/","created_at":"2017-03-04T10:24:53Z","updated_at":"2017-03-05T11:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb6421f72081c4649f6a4fa21e08a71d43a38f94","assignee":{"login":"isqua","id":529247,"avatar_url":"https://avatars2.githubusercontent.com/u/529247?v=3","gravatar_id":"","url":"https://api.github.com/users/isqua","html_url":"https://github.com/isqua","followers_url":"https://api.github.com/users/isqua/followers","following_url":"https://api.github.com/users/isqua/following{/other_user}","gists_url":"https://api.github.com/users/isqua/gists{/gist_id}","starred_url":"https://api.github.com/users/isqua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isqua/subscriptions","organizations_url":"https://api.github.com/users/isqua/orgs","repos_url":"https://api.github.com/users/isqua/repos","events_url":"https://api.github.com/users/isqua/events{/privacy}","received_events_url":"https://api.github.com/users/isqua/received_events","type":"User","site_admin":false},"assignees":[{"login":"isqua","id":529247,"avatar_url":"https://avatars2.githubusercontent.com/u/529247?v=3","gravatar_id":"","url":"https://api.github.com/users/isqua","html_url":"https://github.com/isqua","followers_url":"https://api.github.com/users/isqua/followers","following_url":"https://api.github.com/users/isqua/following{/other_user}","gists_url":"https://api.github.com/users/isqua/gists{/gist_id}","starred_url":"https://api.github.com/users/isqua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isqua/subscriptions","organizations_url":"https://api.github.com/users/isqua/orgs","repos_url":"https://api.github.com/users/isqua/repos","events_url":"https://api.github.com/users/isqua/events{/privacy}","received_events_url":"https://api.github.com/users/isqua/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/statuses/a6233156ad595e4c94cf47bd8f1f79a196e5b34b","head":{"label":"YakunovAnton:module2-task1","ref":"module2-task1","sha":"a6233156ad595e4c94cf47bd8f1f79a196e5b34b","user":{"login":"YakunovAnton","id":18160956,"avatar_url":"https://avatars1.githubusercontent.com/u/18160956?v=3","gravatar_id":"","url":"https://api.github.com/users/YakunovAnton","html_url":"https://github.com/YakunovAnton","followers_url":"https://api.github.com/users/YakunovAnton/followers","following_url":"https://api.github.com/users/YakunovAnton/following{/other_user}","gists_url":"https://api.github.com/users/YakunovAnton/gists{/gist_id}","starred_url":"https://api.github.com/users/YakunovAnton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YakunovAnton/subscriptions","organizations_url":"https://api.github.com/users/YakunovAnton/orgs","repos_url":"https://api.github.com/users/YakunovAnton/repos","events_url":"https://api.github.com/users/YakunovAnton/events{/privacy}","received_events_url":"https://api.github.com/users/YakunovAnton/received_events","type":"User","site_admin":false},"repo":{"id":83417809,"name":"mishka","full_name":"YakunovAnton/mishka","owner":{"login":"YakunovAnton","id":18160956,"avatar_url":"https://avatars1.githubusercontent.com/u/18160956?v=3","gravatar_id":"","url":"https://api.github.com/users/YakunovAnton","html_url":"https://github.com/YakunovAnton","followers_url":"https://api.github.com/users/YakunovAnton/followers","following_url":"https://api.github.com/users/YakunovAnton/following{/other_user}","gists_url":"https://api.github.com/users/YakunovAnton/gists{/gist_id}","starred_url":"https://api.github.com/users/YakunovAnton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YakunovAnton/subscriptions","organizations_url":"https://api.github.com/users/YakunovAnton/orgs","repos_url":"https://api.github.com/users/YakunovAnton/repos","events_url":"https://api.github.com/users/YakunovAnton/events{/privacy}","received_events_url":"https://api.github.com/users/YakunovAnton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YakunovAnton/mishka","description":"Антон Якунов","fork":true,"url":"https://api.github.com/repos/YakunovAnton/mishka","forks_url":"https://api.github.com/repos/YakunovAnton/mishka/forks","keys_url":"https://api.github.com/repos/YakunovAnton/mishka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YakunovAnton/mishka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YakunovAnton/mishka/teams","hooks_url":"https://api.github.com/repos/YakunovAnton/mishka/hooks","issue_events_url":"https://api.github.com/repos/YakunovAnton/mishka/issues/events{/number}","events_url":"https://api.github.com/repos/YakunovAnton/mishka/events","assignees_url":"https://api.github.com/repos/YakunovAnton/mishka/assignees{/user}","branches_url":"https://api.github.com/repos/YakunovAnton/mishka/branches{/branch}","tags_url":"https://api.github.com/repos/YakunovAnton/mishka/tags","blobs_url":"https://api.github.com/repos/YakunovAnton/mishka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YakunovAnton/mishka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YakunovAnton/mishka/git/refs{/sha}","trees_url":"https://api.github.com/repos/YakunovAnton/mishka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YakunovAnton/mishka/statuses/{sha}","languages_url":"https://api.github.com/repos/YakunovAnton/mishka/languages","stargazers_url":"https://api.github.com/repos/YakunovAnton/mishka/stargazers","contributors_url":"https://api.github.com/repos/YakunovAnton/mishka/contributors","subscribers_url":"https://api.github.com/repos/YakunovAnton/mishka/subscribers","subscription_url":"https://api.github.com/repos/YakunovAnton/mishka/subscription","commits_url":"https://api.github.com/repos/YakunovAnton/mishka/commits{/sha}","git_commits_url":"https://api.github.com/repos/YakunovAnton/mishka/git/commits{/sha}","comments_url":"https://api.github.com/repos/YakunovAnton/mishka/comments{/number}","issue_comment_url":"https://api.github.com/repos/YakunovAnton/mishka/issues/comments{/number}","contents_url":"https://api.github.com/repos/YakunovAnton/mishka/contents/{+path}","compare_url":"https://api.github.com/repos/YakunovAnton/mishka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YakunovAnton/mishka/merges","archive_url":"https://api.github.com/repos/YakunovAnton/mishka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YakunovAnton/mishka/downloads","issues_url":"https://api.github.com/repos/YakunovAnton/mishka/issues{/number}","pulls_url":"https://api.github.com/repos/YakunovAnton/mishka/pulls{/number}","milestones_url":"https://api.github.com/repos/YakunovAnton/mishka/milestones{/number}","notifications_url":"https://api.github.com/repos/YakunovAnton/mishka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YakunovAnton/mishka/labels{/name}","releases_url":"https://api.github.com/repos/YakunovAnton/mishka/releases{/id}","deployments_url":"https://api.github.com/repos/YakunovAnton/mishka/deployments","created_at":"2017-02-28T10:06:36Z","updated_at":"2017-02-28T10:08:38Z","pushed_at":"2017-03-05T09:29:47Z","git_url":"git://github.com/YakunovAnton/mishka.git","ssh_url":"[email protected]:YakunovAnton/mishka.git","clone_url":"https://github.com/YakunovAnton/mishka.git","svn_url":"https://github.com/YakunovAnton/mishka","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-adaptive:master","ref":"master","sha":"865cb916d6f1a6cc0a0da23e790936be15a1d356","user":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars3.githubusercontent.com/u/9918669?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"repo":{"id":83413322,"name":"214958-mishka","full_name":"htmlacademy-adaptive/214958-mishka","owner":{"login":"htmlacademy-adaptive","id":9918669,"avatar_url":"https://avatars3.githubusercontent.com/u/9918669?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-adaptive/214958-mishka","description":"Антон Якунов","fork":false,"url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka","forks_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/forks","keys_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/teams","hooks_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/events","assignees_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/tags","blobs_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/subscription","commits_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/merges","archive_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/downloads","issues_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/deployments","created_at":"2017-02-28T09:19:47Z","updated_at":"2017-02-28T10:30:01Z","pushed_at":"2017-03-05T09:29:49Z","git_url":"git://github.com/htmlacademy-adaptive/214958-mishka.git","ssh_url":"[email protected]:htmlacademy-adaptive/214958-mishka.git","clone_url":"https://github.com/htmlacademy-adaptive/214958-mishka.git","svn_url":"https://github.com/htmlacademy-adaptive/214958-mishka","homepage":"https://github.com/YakunovAnton/mishka","size":11,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/2"},"html":{"href":"https://github.com/htmlacademy-adaptive/214958-mishka/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-adaptive/214958-mishka/statuses/a6233156ad595e4c94cf47bd8f1f79a196e5b34b"}}}} | {
"id": 83413322,
"name": "htmlacademy-adaptive/214958-mishka",
"url": "https://api.github.com/repos/htmlacademy-adaptive/214958-mishka"
} | {
"id": 529247,
"login": "isqua",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/529247?",
"url": "https://api.github.com/users/isqua"
} | {
"id": 9918669,
"login": "htmlacademy-adaptive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9918669?",
"url": "https://api.github.com/orgs/htmlacademy-adaptive"
} | 2017-03-05T11:30:16 | 5434834036 | {"actor":{"display_login":"isqua"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.