type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments/133510905","pull_request_review_id":56700413,"id":133510905,"diff_hunk":"@@ -58,6 +60,9 @@\n PRIVATE_REGISTER_INTERFACE = '%s.%s' % (INTERFACE_BASE, 'Register')\n PRIVATE_REGISTER_DBUS_PATH = '%s/%s' % (ROOT_DBUS_PATH, 'Register')\n \n+UNREGISTER_INTERFACE = '%s.%s' % (INTERFACE_BASE, 'UnRegister')","path":"src/rhsmlib/dbus/constants.py","position":13,"original_position":13,"commit_id":"27c8905d92a6a0fc67cd8c4d4216706c500ae502","original_commit_id":"27c8905d92a6a0fc67cd8c4d4216706c500ae502","user":{"login":"awood","id":17975,"avatar_url":"https://avatars3.githubusercontent.com/u/17975?v=4","gravatar_id":"","url":"https://api.github.com/users/awood","html_url":"https://github.com/awood","followers_url":"https://api.github.com/users/awood/followers","following_url":"https://api.github.com/users/awood/following{/other_user}","gists_url":"https://api.github.com/users/awood/gists{/gist_id}","starred_url":"https://api.github.com/users/awood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awood/subscriptions","organizations_url":"https://api.github.com/users/awood/orgs","repos_url":"https://api.github.com/users/awood/repos","events_url":"https://api.github.com/users/awood/events{/privacy}","received_events_url":"https://api.github.com/users/awood/received_events","type":"User","site_admin":false},"body":"Please change to `Unregister`.","created_at":"2017-08-16T17:13:53Z","updated_at":"2017-08-16T17:23:45Z","html_url":"https://github.com/candlepin/subscription-manager/pull/1680#discussion_r133510905","pull_request_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1680","_links":{"self":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments/133510905"},"html":{"href":"https://github.com/candlepin/subscription-manager/pull/1680#discussion_r133510905"},"pull_request":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1680"}}},"pull_request":{"url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1680","id":135396172,"html_url":"https://github.com/candlepin/subscription-manager/pull/1680","diff_url":"https://github.com/candlepin/subscription-manager/pull/1680.diff","patch_url":"https://github.com/candlepin/subscription-manager/pull/1680.patch","issue_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/1680","number":1680,"state":"open","locked":false,"title":"D-Bus service for unregistering system","user":{"login":"jirihnidek","id":2057012,"avatar_url":"https://avatars1.githubusercontent.com/u/2057012?v=4","gravatar_id":"","url":"https://api.github.com/users/jirihnidek","html_url":"https://github.com/jirihnidek","followers_url":"https://api.github.com/users/jirihnidek/followers","following_url":"https://api.github.com/users/jirihnidek/following{/other_user}","gists_url":"https://api.github.com/users/jirihnidek/gists{/gist_id}","starred_url":"https://api.github.com/users/jirihnidek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirihnidek/subscriptions","organizations_url":"https://api.github.com/users/jirihnidek/orgs","repos_url":"https://api.github.com/users/jirihnidek/repos","events_url":"https://api.github.com/users/jirihnidek/events{/privacy}","received_events_url":"https://api.github.com/users/jirihnidek/received_events","type":"User","site_admin":false},"body":"* Added unregister module to service package\r\n* Added unregister module to dbus package\r\n* Added new path: `/com/redhat/RHSM1/UnRegister` and\r\n new interface: `com.redhat.RHSM1.Unregister`\r\n* The new interface includes new method: `UnRegister`. It\r\n can accept one argument with proxy definition.\r\n* It is possible to test new API using following commands\r\n\r\n $ busctl tree com.redhat.RHSM1\r\n $ busctl introspect com.redhat.RHSM1 /com/redhat/RHSM1/UnRegister\r\n $ dbus-send --system --print-reply --dest='com.redhat.RHSM1' \\\r\n '/com/redhat/RHSM1/UnRegister\" com.redhat.RHSM1.UnRegister.UnRegister \\\r\n dict:string:string:\"\",\"\"\r\n\r\n* New service is used in CLI and GUI\r\n* Added simple unit test for D-Bus object and new service.","created_at":"2017-08-11T18:47:27Z","updated_at":"2017-08-16T17:23:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e40de28419f40b78e4e7b0145d8351d6809aa0f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1680/commits","review_comments_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1680/comments","review_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/1680/comments","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/27c8905d92a6a0fc67cd8c4d4216706c500ae502","head":{"label":"candlepin:jhnidek/d-bus_unregister_service","ref":"jhnidek/d-bus_unregister_service","sha":"27c8905d92a6a0fc67cd8c4d4216706c500ae502","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars1.githubusercontent.com/u/1749632?v=4","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4360334,"name":"subscription-manager","full_name":"candlepin/subscription-manager","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars1.githubusercontent.com/u/1749632?v=4","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/subscription-manager","description":"A GUI and CLI client for Candlepin","fork":false,"url":"https://api.github.com/repos/candlepin/subscription-manager","forks_url":"https://api.github.com/repos/candlepin/subscription-manager/forks","keys_url":"https://api.github.com/repos/candlepin/subscription-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/subscription-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/subscription-manager/teams","hooks_url":"https://api.github.com/repos/candlepin/subscription-manager/hooks","issue_events_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/subscription-manager/events","assignees_url":"https://api.github.com/repos/candlepin/subscription-manager/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/subscription-manager/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/subscription-manager/tags","blobs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/subscription-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/subscription-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/subscription-manager/languages","stargazers_url":"https://api.github.com/repos/candlepin/subscription-manager/stargazers","contributors_url":"https://api.github.com/repos/candlepin/subscription-manager/contributors","subscribers_url":"https://api.github.com/repos/candlepin/subscription-manager/subscribers","subscription_url":"https://api.github.com/repos/candlepin/subscription-manager/subscription","commits_url":"https://api.github.com/repos/candlepin/subscription-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/subscription-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/subscription-manager/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/subscription-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/subscription-manager/merges","archive_url":"https://api.github.com/repos/candlepin/subscription-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/subscription-manager/downloads","issues_url":"https://api.github.com/repos/candlepin/subscription-manager/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/subscription-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/subscription-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/subscription-manager/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/subscription-manager/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/subscription-manager/deployments","created_at":"2012-05-17T16:13:30Z","updated_at":"2017-05-31T15:37:21Z","pushed_at":"2017-08-16T15:19:25Z","git_url":"git://github.com/candlepin/subscription-manager.git","ssh_url":"[email protected]:candlepin/subscription-manager.git","clone_url":"https://github.com/candlepin/subscription-manager.git","svn_url":"https://github.com/candlepin/subscription-manager","homepage":"http://candlepinproject.org/","size":40040,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":11,"forks":47,"open_issues":11,"watchers":18,"default_branch":"master"}},"base":{"label":"candlepin:master","ref":"master","sha":"1040a42dcfbc6922910cfff336c182d44629be93","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars1.githubusercontent.com/u/1749632?v=4","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4360334,"name":"subscription-manager","full_name":"candlepin/subscription-manager","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars1.githubusercontent.com/u/1749632?v=4","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/subscription-manager","description":"A GUI and CLI client for Candlepin","fork":false,"url":"https://api.github.com/repos/candlepin/subscription-manager","forks_url":"https://api.github.com/repos/candlepin/subscription-manager/forks","keys_url":"https://api.github.com/repos/candlepin/subscription-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/subscription-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/subscription-manager/teams","hooks_url":"https://api.github.com/repos/candlepin/subscription-manager/hooks","issue_events_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/subscription-manager/events","assignees_url":"https://api.github.com/repos/candlepin/subscription-manager/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/subscription-manager/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/subscription-manager/tags","blobs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/subscription-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/subscription-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/subscription-manager/languages","stargazers_url":"https://api.github.com/repos/candlepin/subscription-manager/stargazers","contributors_url":"https://api.github.com/repos/candlepin/subscription-manager/contributors","subscribers_url":"https://api.github.com/repos/candlepin/subscription-manager/subscribers","subscription_url":"https://api.github.com/repos/candlepin/subscription-manager/subscription","commits_url":"https://api.github.com/repos/candlepin/subscription-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/subscription-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/subscription-manager/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/subscription-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/subscription-manager/merges","archive_url":"https://api.github.com/repos/candlepin/subscription-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/subscription-manager/downloads","issues_url":"https://api.github.com/repos/candlepin/subscription-manager/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/subscription-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/subscription-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/subscription-manager/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/subscription-manager/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/subscription-manager/deployments","created_at":"2012-05-17T16:13:30Z","updated_at":"2017-05-31T15:37:21Z","pushed_at":"2017-08-16T15:19:25Z","git_url":"git://github.com/candlepin/subscription-manager.git","ssh_url":"[email protected]:candlepin/subscription-manager.git","clone_url":"https://github.com/candlepin/subscription-manager.git","svn_url":"https://github.com/candlepin/subscription-manager","homepage":"http://candlepinproject.org/","size":40040,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":11,"forks":47,"open_issues":11,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1680"},"html":{"href":"https://github.com/candlepin/subscription-manager/pull/1680"},"issue":{"href":"https://api.github.com/repos/candlepin/subscription-manager/issues/1680"},"comments":{"href":"https://api.github.com/repos/candlepin/subscription-manager/issues/1680/comments"},"review_comments":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1680/comments"},"review_comment":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1680/commits"},"statuses":{"href":"https://api.github.com/repos/candlepin/subscription-manager/statuses/27c8905d92a6a0fc67cd8c4d4216706c500ae502"}}}} | {
"id": 4360334,
"name": "candlepin/subscription-manager",
"url": "https://api.github.com/repos/candlepin/subscription-manager"
} | {
"id": 17975,
"login": "awood",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17975?",
"url": "https://api.github.com/users/awood"
} | {
"id": 1749632,
"login": "candlepin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1749632?",
"url": "https://api.github.com/orgs/candlepin"
} | 2017-08-16T17:13:53 | 6465531502 | {"actor":{"display_login":"awood"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/capnproto/capnproto/pulls/comments/150922310","pull_request_review_id":76539190,"id":150922310,"diff_hunk":"@@ -109,6 +113,73 @@ pthread_once_t registerReservedSignalOnce = PTHREAD_ONCE_INIT;\n \n } // namespace\n \n+struct UnixEventPort::ChildSet {\n+ std::map<pid_t, ChildExitPromiseAdapter*> waiters;\n+\n+ void checkExits();\n+};\n+\n+class UnixEventPort::ChildExitPromiseAdapter {\n+public:\n+ inline ChildExitPromiseAdapter(PromiseFulfiller<int>& fulfiller,\n+ ChildSet& childSet, Maybe<pid_t>& pidRef)\n+ : childSet(childSet),\n+ pid(KJ_REQUIRE_NONNULL(pidRef,\n+ \"`pid` must be non-null at the time `onChildExit()` is called\")),\n+ pidRef(pidRef), fulfiller(fulfiller) {\n+ KJ_REQUIRE(childSet.waiters.insert(std::make_pair(pid, this)).second,\n+ \"already called onChildExit() for this pid\");\n+ }\n+\n+ ~ChildExitPromiseAdapter() noexcept(false) {\n+ childSet.waiters.erase(pid);\n+ }\n+\n+ ChildSet& childSet;\n+ pid_t pid;\n+ Maybe<pid_t>& pidRef;\n+ PromiseFulfiller<int>& fulfiller;\n+};\n+\n+void UnixEventPort::ChildSet::checkExits() {\n+ for (;;) {\n+ int status;\n+ pid_t pid;\n+ KJ_SYSCALL(pid = waitpid(-1, &status, WNOHANG));\n+ if (pid == 0) break;\n+\n+ auto iter = waiters.find(pid);\n+ if (iter != waiters.end()) {\n+ iter->second->pidRef = nullptr;\n+ iter->second->fulfiller.fulfill(kj::cp(status));\n+ }\n+ }\n+}\n+\n+Promise<int> UnixEventPort::onChildExit(Maybe<pid_t>& pid) {\n+ ChildSet* cs;\n+ KJ_IF_MAYBE(c, childSet) {\n+ cs = *c;\n+ } else {\n+ // In theory we should do an atomic compare-and-swap on threadClaimedChildExits, but this is\n+ // for debug purposes only so it's not a big deal.\n+ KJ_REQUIRE(!threadClaimedChildExits,\n+ \"only one UnixEvertPort per process may listen for child exits\");","path":"c++/src/kj/async-unix.c++","position":73,"original_position":73,"commit_id":"b8b51f586858222f65e4f9f837cd4c80c7ff0aa9","original_commit_id":"b8b51f586858222f65e4f9f837cd4c80c7ff0aa9","user":{"login":"harrishancock","id":1030771,"avatar_url":"https://avatars0.githubusercontent.com/u/1030771?v=4","gravatar_id":"","url":"https://api.github.com/users/harrishancock","html_url":"https://github.com/harrishancock","followers_url":"https://api.github.com/users/harrishancock/followers","following_url":"https://api.github.com/users/harrishancock/following{/other_user}","gists_url":"https://api.github.com/users/harrishancock/gists{/gist_id}","starred_url":"https://api.github.com/users/harrishancock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrishancock/subscriptions","organizations_url":"https://api.github.com/users/harrishancock/orgs","repos_url":"https://api.github.com/users/harrishancock/repos","events_url":"https://api.github.com/users/harrishancock/events{/privacy}","received_events_url":"https://api.github.com/users/harrishancock/received_events","type":"User","site_admin":false},"body":"Should we also `KJ_REQUIRE(capturedChildExit)` here? By my reading, it appears that one could `captureSignal(SIGCHLD)` and then call `onChildExit(...)` and it would work, contradicting the doc comment for `onChildExit()`.","created_at":"2017-11-14T18:31:51Z","updated_at":"2017-11-14T18:36:27Z","html_url":"https://github.com/capnproto/capnproto/pull/585#discussion_r150922310","pull_request_url":"https://api.github.com/repos/capnproto/capnproto/pulls/585","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/capnproto/capnproto/pulls/comments/150922310"},"html":{"href":"https://github.com/capnproto/capnproto/pull/585#discussion_r150922310"},"pull_request":{"href":"https://api.github.com/repos/capnproto/capnproto/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/capnproto/capnproto/pulls/585","id":152392566,"html_url":"https://github.com/capnproto/capnproto/pull/585","diff_url":"https://github.com/capnproto/capnproto/pull/585.diff","patch_url":"https://github.com/capnproto/capnproto/pull/585.patch","issue_url":"https://api.github.com/repos/capnproto/capnproto/issues/585","number":585,"state":"open","locked":false,"title":"Extend UnixEventPort with the ability to listen for subprocess exit.","user":{"login":"kentonv","id":4001805,"avatar_url":"https://avatars0.githubusercontent.com/u/4001805?v=4","gravatar_id":"","url":"https://api.github.com/users/kentonv","html_url":"https://github.com/kentonv","followers_url":"https://api.github.com/users/kentonv/followers","following_url":"https://api.github.com/users/kentonv/following{/other_user}","gists_url":"https://api.github.com/users/kentonv/gists{/gist_id}","starred_url":"https://api.github.com/users/kentonv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentonv/subscriptions","organizations_url":"https://api.github.com/users/kentonv/orgs","repos_url":"https://api.github.com/users/kentonv/repos","events_url":"https://api.github.com/users/kentonv/events{/privacy}","received_events_url":"https://api.github.com/users/kentonv/received_events","type":"User","site_admin":false},"body":"(Later, we should add a nice subprocess API around this, maybe even one that can work on Windows too...)","created_at":"2017-11-14T01:38:20Z","updated_at":"2017-11-14T18:36:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"332fccb3e231941fda67cbd33939067805541a40","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/capnproto/capnproto/pulls/585/commits","review_comments_url":"https://api.github.com/repos/capnproto/capnproto/pulls/585/comments","review_comment_url":"https://api.github.com/repos/capnproto/capnproto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/capnproto/capnproto/issues/585/comments","statuses_url":"https://api.github.com/repos/capnproto/capnproto/statuses/b8b51f586858222f65e4f9f837cd4c80c7ff0aa9","head":{"label":"capnproto:subprocesses","ref":"subprocesses","sha":"b8b51f586858222f65e4f9f837cd4c80c7ff0aa9","user":{"login":"capnproto","id":29186932,"avatar_url":"https://avatars2.githubusercontent.com/u/29186932?v=4","gravatar_id":"","url":"https://api.github.com/users/capnproto","html_url":"https://github.com/capnproto","followers_url":"https://api.github.com/users/capnproto/followers","following_url":"https://api.github.com/users/capnproto/following{/other_user}","gists_url":"https://api.github.com/users/capnproto/gists{/gist_id}","starred_url":"https://api.github.com/users/capnproto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capnproto/subscriptions","organizations_url":"https://api.github.com/users/capnproto/orgs","repos_url":"https://api.github.com/users/capnproto/repos","events_url":"https://api.github.com/users/capnproto/events{/privacy}","received_events_url":"https://api.github.com/users/capnproto/received_events","type":"Organization","site_admin":false},"repo":{"id":9090933,"name":"capnproto","full_name":"capnproto/capnproto","owner":{"login":"capnproto","id":29186932,"avatar_url":"https://avatars2.githubusercontent.com/u/29186932?v=4","gravatar_id":"","url":"https://api.github.com/users/capnproto","html_url":"https://github.com/capnproto","followers_url":"https://api.github.com/users/capnproto/followers","following_url":"https://api.github.com/users/capnproto/following{/other_user}","gists_url":"https://api.github.com/users/capnproto/gists{/gist_id}","starred_url":"https://api.github.com/users/capnproto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capnproto/subscriptions","organizations_url":"https://api.github.com/users/capnproto/orgs","repos_url":"https://api.github.com/users/capnproto/repos","events_url":"https://api.github.com/users/capnproto/events{/privacy}","received_events_url":"https://api.github.com/users/capnproto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/capnproto/capnproto","description":"Cap'n Proto serialization/RPC system - core tools and C++ library","fork":false,"url":"https://api.github.com/repos/capnproto/capnproto","forks_url":"https://api.github.com/repos/capnproto/capnproto/forks","keys_url":"https://api.github.com/repos/capnproto/capnproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capnproto/capnproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capnproto/capnproto/teams","hooks_url":"https://api.github.com/repos/capnproto/capnproto/hooks","issue_events_url":"https://api.github.com/repos/capnproto/capnproto/issues/events{/number}","events_url":"https://api.github.com/repos/capnproto/capnproto/events","assignees_url":"https://api.github.com/repos/capnproto/capnproto/assignees{/user}","branches_url":"https://api.github.com/repos/capnproto/capnproto/branches{/branch}","tags_url":"https://api.github.com/repos/capnproto/capnproto/tags","blobs_url":"https://api.github.com/repos/capnproto/capnproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capnproto/capnproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capnproto/capnproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/capnproto/capnproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capnproto/capnproto/statuses/{sha}","languages_url":"https://api.github.com/repos/capnproto/capnproto/languages","stargazers_url":"https://api.github.com/repos/capnproto/capnproto/stargazers","contributors_url":"https://api.github.com/repos/capnproto/capnproto/contributors","subscribers_url":"https://api.github.com/repos/capnproto/capnproto/subscribers","subscription_url":"https://api.github.com/repos/capnproto/capnproto/subscription","commits_url":"https://api.github.com/repos/capnproto/capnproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/capnproto/capnproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/capnproto/capnproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/capnproto/capnproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/capnproto/capnproto/contents/{+path}","compare_url":"https://api.github.com/repos/capnproto/capnproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capnproto/capnproto/merges","archive_url":"https://api.github.com/repos/capnproto/capnproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capnproto/capnproto/downloads","issues_url":"https://api.github.com/repos/capnproto/capnproto/issues{/number}","pulls_url":"https://api.github.com/repos/capnproto/capnproto/pulls{/number}","milestones_url":"https://api.github.com/repos/capnproto/capnproto/milestones{/number}","notifications_url":"https://api.github.com/repos/capnproto/capnproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capnproto/capnproto/labels{/name}","releases_url":"https://api.github.com/repos/capnproto/capnproto/releases{/id}","deployments_url":"https://api.github.com/repos/capnproto/capnproto/deployments","created_at":"2013-03-29T02:38:48Z","updated_at":"2017-11-14T13:59:48Z","pushed_at":"2017-11-14T01:38:21Z","git_url":"git://github.com/capnproto/capnproto.git","ssh_url":"[email protected]:capnproto/capnproto.git","clone_url":"https://github.com/capnproto/capnproto.git","svn_url":"https://github.com/capnproto/capnproto","homepage":"https://capnproto.org","size":15286,"stargazers_count":5048,"watchers_count":5048,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":419,"mirror_url":null,"archived":false,"open_issues_count":75,"forks":419,"open_issues":75,"watchers":5048,"default_branch":"master"}},"base":{"label":"capnproto:master","ref":"master","sha":"d54b005b7d33cbb6f5d4ee6f339a0fa6ce20cc4a","user":{"login":"capnproto","id":29186932,"avatar_url":"https://avatars2.githubusercontent.com/u/29186932?v=4","gravatar_id":"","url":"https://api.github.com/users/capnproto","html_url":"https://github.com/capnproto","followers_url":"https://api.github.com/users/capnproto/followers","following_url":"https://api.github.com/users/capnproto/following{/other_user}","gists_url":"https://api.github.com/users/capnproto/gists{/gist_id}","starred_url":"https://api.github.com/users/capnproto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capnproto/subscriptions","organizations_url":"https://api.github.com/users/capnproto/orgs","repos_url":"https://api.github.com/users/capnproto/repos","events_url":"https://api.github.com/users/capnproto/events{/privacy}","received_events_url":"https://api.github.com/users/capnproto/received_events","type":"Organization","site_admin":false},"repo":{"id":9090933,"name":"capnproto","full_name":"capnproto/capnproto","owner":{"login":"capnproto","id":29186932,"avatar_url":"https://avatars2.githubusercontent.com/u/29186932?v=4","gravatar_id":"","url":"https://api.github.com/users/capnproto","html_url":"https://github.com/capnproto","followers_url":"https://api.github.com/users/capnproto/followers","following_url":"https://api.github.com/users/capnproto/following{/other_user}","gists_url":"https://api.github.com/users/capnproto/gists{/gist_id}","starred_url":"https://api.github.com/users/capnproto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capnproto/subscriptions","organizations_url":"https://api.github.com/users/capnproto/orgs","repos_url":"https://api.github.com/users/capnproto/repos","events_url":"https://api.github.com/users/capnproto/events{/privacy}","received_events_url":"https://api.github.com/users/capnproto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/capnproto/capnproto","description":"Cap'n Proto serialization/RPC system - core tools and C++ library","fork":false,"url":"https://api.github.com/repos/capnproto/capnproto","forks_url":"https://api.github.com/repos/capnproto/capnproto/forks","keys_url":"https://api.github.com/repos/capnproto/capnproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capnproto/capnproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capnproto/capnproto/teams","hooks_url":"https://api.github.com/repos/capnproto/capnproto/hooks","issue_events_url":"https://api.github.com/repos/capnproto/capnproto/issues/events{/number}","events_url":"https://api.github.com/repos/capnproto/capnproto/events","assignees_url":"https://api.github.com/repos/capnproto/capnproto/assignees{/user}","branches_url":"https://api.github.com/repos/capnproto/capnproto/branches{/branch}","tags_url":"https://api.github.com/repos/capnproto/capnproto/tags","blobs_url":"https://api.github.com/repos/capnproto/capnproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capnproto/capnproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capnproto/capnproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/capnproto/capnproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capnproto/capnproto/statuses/{sha}","languages_url":"https://api.github.com/repos/capnproto/capnproto/languages","stargazers_url":"https://api.github.com/repos/capnproto/capnproto/stargazers","contributors_url":"https://api.github.com/repos/capnproto/capnproto/contributors","subscribers_url":"https://api.github.com/repos/capnproto/capnproto/subscribers","subscription_url":"https://api.github.com/repos/capnproto/capnproto/subscription","commits_url":"https://api.github.com/repos/capnproto/capnproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/capnproto/capnproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/capnproto/capnproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/capnproto/capnproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/capnproto/capnproto/contents/{+path}","compare_url":"https://api.github.com/repos/capnproto/capnproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capnproto/capnproto/merges","archive_url":"https://api.github.com/repos/capnproto/capnproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capnproto/capnproto/downloads","issues_url":"https://api.github.com/repos/capnproto/capnproto/issues{/number}","pulls_url":"https://api.github.com/repos/capnproto/capnproto/pulls{/number}","milestones_url":"https://api.github.com/repos/capnproto/capnproto/milestones{/number}","notifications_url":"https://api.github.com/repos/capnproto/capnproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capnproto/capnproto/labels{/name}","releases_url":"https://api.github.com/repos/capnproto/capnproto/releases{/id}","deployments_url":"https://api.github.com/repos/capnproto/capnproto/deployments","created_at":"2013-03-29T02:38:48Z","updated_at":"2017-11-14T13:59:48Z","pushed_at":"2017-11-14T01:38:21Z","git_url":"git://github.com/capnproto/capnproto.git","ssh_url":"[email protected]:capnproto/capnproto.git","clone_url":"https://github.com/capnproto/capnproto.git","svn_url":"https://github.com/capnproto/capnproto","homepage":"https://capnproto.org","size":15286,"stargazers_count":5048,"watchers_count":5048,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":419,"mirror_url":null,"archived":false,"open_issues_count":75,"forks":419,"open_issues":75,"watchers":5048,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/capnproto/capnproto/pulls/585"},"html":{"href":"https://github.com/capnproto/capnproto/pull/585"},"issue":{"href":"https://api.github.com/repos/capnproto/capnproto/issues/585"},"comments":{"href":"https://api.github.com/repos/capnproto/capnproto/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/capnproto/capnproto/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/capnproto/capnproto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/capnproto/capnproto/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/capnproto/capnproto/statuses/b8b51f586858222f65e4f9f837cd4c80c7ff0aa9"}},"author_association":"OWNER"}} | {
"id": 9090933,
"name": "capnproto/capnproto",
"url": "https://api.github.com/repos/capnproto/capnproto"
} | {
"id": 1030771,
"login": "harrishancock",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1030771?",
"url": "https://api.github.com/users/harrishancock"
} | {
"id": 29186932,
"login": "capnproto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29186932?",
"url": "https://api.github.com/orgs/capnproto"
} | 2017-11-14T18:31:51 | 6854346713 | {"actor":{"display_login":"harrishancock"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/145656017","pull_request_review_id":70485548,"id":145656017,"diff_hunk":"@@ -5,13 +5,15 @@ Citra Emulator\n [](https://travis-ci.org/citra-emu/citra)\n [](https://ci.appveyor.com/project/bunnei/citra)\n \n-Citra is an experimental open-source Nintendo 3DS emulator/debugger written in C++. It is written with portability in mind, with builds actively maintained for Windows, Linux and macOS. Citra only emulates a subset of 3DS hardware and therefore is generally only useful for running/debugging homebrew applications. At this time, Citra is even able to boot several commercial games! Most of these do not run to a playable state, but we are working every day to advance the project forward.\n+Citra is an experimental open-source Nintendo 3DS emulator/debugger written in C++. It is written with portability in mind, with builds actively maintained for Windows, Linux and macOS. Citra only emulates a subset of 3DS hardware and therefore is generally only useful for running/debugging homebrew applications.\n+\n+Citra is even able to boot several commercial games! Some of of these do not run to a playable state, but most do, and we are working every day to advance the project forward. <b>Playable here means the same as \"OK\" in our [game compatibility list](https://citra-emu.org/game).</b>","path":"README.md","position":7,"original_position":7,"commit_id":"c1c04a70c26ab8801c1bd7120ea7d830b9bc18f7","original_commit_id":"c1c04a70c26ab8801c1bd7120ea7d830b9bc18f7","user":{"login":"baka0815","id":15894566,"avatar_url":"https://avatars2.githubusercontent.com/u/15894566?v=4","gravatar_id":"","url":"https://api.github.com/users/baka0815","html_url":"https://github.com/baka0815","followers_url":"https://api.github.com/users/baka0815/followers","following_url":"https://api.github.com/users/baka0815/following{/other_user}","gists_url":"https://api.github.com/users/baka0815/gists{/gist_id}","starred_url":"https://api.github.com/users/baka0815/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baka0815/subscriptions","organizations_url":"https://api.github.com/users/baka0815/orgs","repos_url":"https://api.github.com/users/baka0815/repos","events_url":"https://api.github.com/users/baka0815/events{/privacy}","received_events_url":"https://api.github.com/users/baka0815/received_events","type":"User","site_admin":false},"body":"``Some of of these do`` there is one \"of\" too much.","created_at":"2017-10-19T10:11:52Z","updated_at":"2017-10-19T10:11:52Z","html_url":"https://github.com/citra-emu/citra/pull/3008#discussion_r145656017","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/3008","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/145656017"},"html":{"href":"https://github.com/citra-emu/citra/pull/3008#discussion_r145656017"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3008"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/3008","id":146763062,"html_url":"https://github.com/citra-emu/citra/pull/3008","diff_url":"https://github.com/citra-emu/citra/pull/3008.diff","patch_url":"https://github.com/citra-emu/citra/pull/3008.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/3008","number":3008,"state":"open","locked":false,"title":"Updated readme file to describe current condition more accurately.","user":{"login":"adityaruplaha","id":30696515,"avatar_url":"https://avatars1.githubusercontent.com/u/30696515?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaruplaha","html_url":"https://github.com/adityaruplaha","followers_url":"https://api.github.com/users/adityaruplaha/followers","following_url":"https://api.github.com/users/adityaruplaha/following{/other_user}","gists_url":"https://api.github.com/users/adityaruplaha/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaruplaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaruplaha/subscriptions","organizations_url":"https://api.github.com/users/adityaruplaha/orgs","repos_url":"https://api.github.com/users/adityaruplaha/repos","events_url":"https://api.github.com/users/adityaruplaha/events{/privacy}","received_events_url":"https://api.github.com/users/adityaruplaha/received_events","type":"User","site_admin":false},"body":"Most games now run to a \"playable\" state. Updated License version to 3.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/citra-emu/citra/3008)\n<!-- Reviewable:end -->\n","created_at":"2017-10-16T11:44:43Z","updated_at":"2017-10-19T10:11:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36d82c40385daca2aabe79e2ced2a9d3b08923bb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/3008/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/3008/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/3008/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/c1c04a70c26ab8801c1bd7120ea7d830b9bc18f7","head":{"label":"adityaruplaha:patch-1","ref":"patch-1","sha":"c1c04a70c26ab8801c1bd7120ea7d830b9bc18f7","user":{"login":"adityaruplaha","id":30696515,"avatar_url":"https://avatars1.githubusercontent.com/u/30696515?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaruplaha","html_url":"https://github.com/adityaruplaha","followers_url":"https://api.github.com/users/adityaruplaha/followers","following_url":"https://api.github.com/users/adityaruplaha/following{/other_user}","gists_url":"https://api.github.com/users/adityaruplaha/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaruplaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaruplaha/subscriptions","organizations_url":"https://api.github.com/users/adityaruplaha/orgs","repos_url":"https://api.github.com/users/adityaruplaha/repos","events_url":"https://api.github.com/users/adityaruplaha/events{/privacy}","received_events_url":"https://api.github.com/users/adityaruplaha/received_events","type":"User","site_admin":false},"repo":{"id":107119130,"name":"citra","full_name":"adityaruplaha/citra","owner":{"login":"adityaruplaha","id":30696515,"avatar_url":"https://avatars1.githubusercontent.com/u/30696515?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaruplaha","html_url":"https://github.com/adityaruplaha","followers_url":"https://api.github.com/users/adityaruplaha/followers","following_url":"https://api.github.com/users/adityaruplaha/following{/other_user}","gists_url":"https://api.github.com/users/adityaruplaha/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaruplaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaruplaha/subscriptions","organizations_url":"https://api.github.com/users/adityaruplaha/orgs","repos_url":"https://api.github.com/users/adityaruplaha/repos","events_url":"https://api.github.com/users/adityaruplaha/events{/privacy}","received_events_url":"https://api.github.com/users/adityaruplaha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adityaruplaha/citra","description":"A Nintendo 3DS Emulator","fork":true,"url":"https://api.github.com/repos/adityaruplaha/citra","forks_url":"https://api.github.com/repos/adityaruplaha/citra/forks","keys_url":"https://api.github.com/repos/adityaruplaha/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adityaruplaha/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adityaruplaha/citra/teams","hooks_url":"https://api.github.com/repos/adityaruplaha/citra/hooks","issue_events_url":"https://api.github.com/repos/adityaruplaha/citra/issues/events{/number}","events_url":"https://api.github.com/repos/adityaruplaha/citra/events","assignees_url":"https://api.github.com/repos/adityaruplaha/citra/assignees{/user}","branches_url":"https://api.github.com/repos/adityaruplaha/citra/branches{/branch}","tags_url":"https://api.github.com/repos/adityaruplaha/citra/tags","blobs_url":"https://api.github.com/repos/adityaruplaha/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adityaruplaha/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adityaruplaha/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/adityaruplaha/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adityaruplaha/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/adityaruplaha/citra/languages","stargazers_url":"https://api.github.com/repos/adityaruplaha/citra/stargazers","contributors_url":"https://api.github.com/repos/adityaruplaha/citra/contributors","subscribers_url":"https://api.github.com/repos/adityaruplaha/citra/subscribers","subscription_url":"https://api.github.com/repos/adityaruplaha/citra/subscription","commits_url":"https://api.github.com/repos/adityaruplaha/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/adityaruplaha/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/adityaruplaha/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/adityaruplaha/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/adityaruplaha/citra/contents/{+path}","compare_url":"https://api.github.com/repos/adityaruplaha/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adityaruplaha/citra/merges","archive_url":"https://api.github.com/repos/adityaruplaha/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adityaruplaha/citra/downloads","issues_url":"https://api.github.com/repos/adityaruplaha/citra/issues{/number}","pulls_url":"https://api.github.com/repos/adityaruplaha/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/adityaruplaha/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/adityaruplaha/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adityaruplaha/citra/labels{/name}","releases_url":"https://api.github.com/repos/adityaruplaha/citra/releases{/id}","deployments_url":"https://api.github.com/repos/adityaruplaha/citra/deployments","created_at":"2017-10-16T11:35:41Z","updated_at":"2017-10-16T11:35:45Z","pushed_at":"2017-10-19T06:19:28Z","git_url":"git://github.com/adityaruplaha/citra.git","ssh_url":"[email protected]:adityaruplaha/citra.git","clone_url":"https://github.com/adityaruplaha/citra.git","svn_url":"https://github.com/adityaruplaha/citra","homepage":"https://citra-emu.org","size":17558,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"e9d1e8c95bbd50a4db1ec67d98a050b99fdd417d","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"A Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2017-10-19T09:45:07Z","pushed_at":"2017-10-19T06:20:09Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"[email protected]:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":20519,"stargazers_count":3327,"watchers_count":3327,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":808,"mirror_url":null,"open_issues_count":238,"forks":808,"open_issues":238,"watchers":3327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3008"},"html":{"href":"https://github.com/citra-emu/citra/pull/3008"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/3008"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/3008/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3008/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3008/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/c1c04a70c26ab8801c1bd7120ea7d830b9bc18f7"}},"author_association":"NONE"}} | {
"id": 19866730,
"name": "citra-emu/citra",
"url": "https://api.github.com/repos/citra-emu/citra"
} | {
"id": 15894566,
"login": "baka0815",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15894566?",
"url": "https://api.github.com/users/baka0815"
} | {
"id": 7605670,
"login": "citra-emu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7605670?",
"url": "https://api.github.com/orgs/citra-emu"
} | 2017-10-19T10:11:52 | 6737653240 | {"actor":{"display_login":"baka0815"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/site-www/pulls/comments/154203708","pull_request_review_id":80332703,"id":154203708,"diff_hunk":"@@ -57,8 +57,14 @@ For more information, see\n [Pub Assets and Transformers](/tools/pub/assets-and-transformers) and\n [Configuring the Built-in dart2js Compiler]({{site.webdev}}/tools/pub/dart2js-transformer).\n \n-All other fields are ignored. A simple but complete pubspec looks something\n-like the following:\n+All other fields are ignored. \n+\n+**Note:** The pubspec for [Flutter apps](https://flutter.io) supports\n+[a few additional fields](https://flutter.io/assets-and-images/) for managing assets. \n+\n+## Sample pubspec","path":"src/tools/pub/pubspec.md","position":11,"original_position":11,"commit_id":"ce430525eef5880596176a9c9c69e2634348a78c","original_commit_id":"ce430525eef5880596176a9c9c69e2634348a78c","user":{"login":"chalin","id":4140793,"avatar_url":"https://avatars1.githubusercontent.com/u/4140793?v=4","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"body":"I'd suggest dropping this heading.","created_at":"2017-11-30T21:17:27Z","updated_at":"2017-11-30T21:17:27Z","html_url":"https://github.com/dart-lang/site-www/pull/439#discussion_r154203708","pull_request_url":"https://api.github.com/repos/dart-lang/site-www/pulls/439","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/comments/154203708"},"html":{"href":"https://github.com/dart-lang/site-www/pull/439#discussion_r154203708"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/439"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/site-www/pulls/439","id":153584272,"html_url":"https://github.com/dart-lang/site-www/pull/439","diff_url":"https://github.com/dart-lang/site-www/pull/439.diff","patch_url":"https://github.com/dart-lang/site-www/pull/439.patch","issue_url":"https://api.github.com/repos/dart-lang/site-www/issues/439","number":439,"state":"open","locked":false,"title":"Cross-link to Flutter pubspec extensions","user":{"login":"mit-mit","id":13644170,"avatar_url":"https://avatars3.githubusercontent.com/u/13644170?v=4","gravatar_id":"","url":"https://api.github.com/users/mit-mit","html_url":"https://github.com/mit-mit","followers_url":"https://api.github.com/users/mit-mit/followers","following_url":"https://api.github.com/users/mit-mit/following{/other_user}","gists_url":"https://api.github.com/users/mit-mit/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-mit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-mit/subscriptions","organizations_url":"https://api.github.com/users/mit-mit/orgs","repos_url":"https://api.github.com/users/mit-mit/repos","events_url":"https://api.github.com/users/mit-mit/events{/privacy}","received_events_url":"https://api.github.com/users/mit-mit/received_events","type":"User","site_admin":false},"body":"Add a reference to the Flutter specific extensions to pubspec\r\n\r\nFixes https://github.com/dart-lang/site-www/issues/421","created_at":"2017-11-20T09:50:06Z","updated_at":"2017-11-30T21:17:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"294c40ba98bbde540f63a99ff525f0ab9d5a33e0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Sfshaza","id":6293442,"avatar_url":"https://avatars0.githubusercontent.com/u/6293442?v=4","gravatar_id":"","url":"https://api.github.com/users/Sfshaza","html_url":"https://github.com/Sfshaza","followers_url":"https://api.github.com/users/Sfshaza/followers","following_url":"https://api.github.com/users/Sfshaza/following{/other_user}","gists_url":"https://api.github.com/users/Sfshaza/gists{/gist_id}","starred_url":"https://api.github.com/users/Sfshaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sfshaza/subscriptions","organizations_url":"https://api.github.com/users/Sfshaza/orgs","repos_url":"https://api.github.com/users/Sfshaza/repos","events_url":"https://api.github.com/users/Sfshaza/events{/privacy}","received_events_url":"https://api.github.com/users/Sfshaza/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/site-www/pulls/439/commits","review_comments_url":"https://api.github.com/repos/dart-lang/site-www/pulls/439/comments","review_comment_url":"https://api.github.com/repos/dart-lang/site-www/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/site-www/issues/439/comments","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/ce430525eef5880596176a9c9c69e2634348a78c","head":{"label":"dart-lang:mit-mit-pubspec","ref":"mit-mit-pubspec","sha":"ce430525eef5880596176a9c9c69e2634348a78c","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63089994,"name":"site-www","full_name":"dart-lang/site-www","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-www","description":"Source for Dart website","fork":false,"url":"https://api.github.com/repos/dart-lang/site-www","forks_url":"https://api.github.com/repos/dart-lang/site-www/forks","keys_url":"https://api.github.com/repos/dart-lang/site-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-www/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-www/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-www/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-www/events","assignees_url":"https://api.github.com/repos/dart-lang/site-www/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-www/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-www/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-www/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-www/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-www/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-www/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-www/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-www/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-www/merges","archive_url":"https://api.github.com/repos/dart-lang/site-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-www/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-www/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-www/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-www/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-www/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-www/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-www/deployments","created_at":"2016-07-11T17:57:36Z","updated_at":"2017-11-28T15:39:46Z","pushed_at":"2017-11-30T20:32:18Z","git_url":"git://github.com/dart-lang/site-www.git","ssh_url":"[email protected]:dart-lang/site-www.git","clone_url":"https://github.com/dart-lang/site-www.git","svn_url":"https://github.com/dart-lang/site-www","homepage":"https://www.dartlang.org/","size":10813,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":41,"open_issues":121,"watchers":27,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"33c4e8e6f20824013ded9f59f846575cea19635a","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63089994,"name":"site-www","full_name":"dart-lang/site-www","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-www","description":"Source for Dart website","fork":false,"url":"https://api.github.com/repos/dart-lang/site-www","forks_url":"https://api.github.com/repos/dart-lang/site-www/forks","keys_url":"https://api.github.com/repos/dart-lang/site-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-www/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-www/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-www/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-www/events","assignees_url":"https://api.github.com/repos/dart-lang/site-www/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-www/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-www/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-www/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-www/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-www/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-www/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-www/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-www/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-www/merges","archive_url":"https://api.github.com/repos/dart-lang/site-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-www/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-www/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-www/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-www/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-www/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-www/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-www/deployments","created_at":"2016-07-11T17:57:36Z","updated_at":"2017-11-28T15:39:46Z","pushed_at":"2017-11-30T20:32:18Z","git_url":"git://github.com/dart-lang/site-www.git","ssh_url":"[email protected]:dart-lang/site-www.git","clone_url":"https://github.com/dart-lang/site-www.git","svn_url":"https://github.com/dart-lang/site-www","homepage":"https://www.dartlang.org/","size":10813,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":41,"open_issues":121,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/439"},"html":{"href":"https://github.com/dart-lang/site-www/pull/439"},"issue":{"href":"https://api.github.com/repos/dart-lang/site-www/issues/439"},"comments":{"href":"https://api.github.com/repos/dart-lang/site-www/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/site-www/statuses/ce430525eef5880596176a9c9c69e2634348a78c"}},"author_association":"OWNER"}} | {
"id": 63089994,
"name": "dart-lang/site-www",
"url": "https://api.github.com/repos/dart-lang/site-www"
} | {
"id": 4140793,
"login": "chalin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4140793?",
"url": "https://api.github.com/users/chalin"
} | {
"id": 1609975,
"login": "dart-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1609975?",
"url": "https://api.github.com/orgs/dart-lang"
} | 2017-11-30T21:17:27 | 6927026403 | {"actor":{"display_login":"chalin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/test/pulls/comments/123112423","pull_request_review_id":45278902,"id":123112423,"diff_hunk":"@@ -3,84 +3,81 @@\n // BSD-style license that can be found in the LICENSE file.\n \n import 'dart:async';\n+import 'package:collection/collection.dart';\n+\n import 'package:package_resolver/package_resolver.dart';\n import 'package:source_map_stack_trace/source_map_stack_trace.dart' as mapper;\n import 'package:source_maps/source_maps.dart';\n \n /// A class for mapping JS stack traces to Dart stack traces using source maps.\n class StackTraceMapper {\n /// The parsed source map.\n- final Mapping _mapping;\n+ Mapping _mapping;","path":"lib/src/util/stack_trace_mapper.dart","position":null,"original_position":14,"commit_id":"2582c9919b218bc27f2f875849b3b7af47b3e234","original_commit_id":"8de90cec121d6ec089f9007774056b0d1b527752","user":{"login":"grouma","id":1840773,"avatar_url":"https://avatars2.githubusercontent.com/u/1840773?v=3","gravatar_id":"","url":"https://api.github.com/users/grouma","html_url":"https://github.com/grouma","followers_url":"https://api.github.com/users/grouma/followers","following_url":"https://api.github.com/users/grouma/following{/other_user}","gists_url":"https://api.github.com/users/grouma/gists{/gist_id}","starred_url":"https://api.github.com/users/grouma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouma/subscriptions","organizations_url":"https://api.github.com/users/grouma/orgs","repos_url":"https://api.github.com/users/grouma/repos","events_url":"https://api.github.com/users/grouma/events{/privacy}","received_events_url":"https://api.github.com/users/grouma/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-06-20T22:26:11Z","updated_at":"2017-06-20T22:35:31Z","html_url":"https://github.com/dart-lang/test/pull/650#discussion_r123112423","pull_request_url":"https://api.github.com/repos/dart-lang/test/pulls/650","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/test/pulls/comments/123112423"},"html":{"href":"https://github.com/dart-lang/test/pull/650#discussion_r123112423"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/test/pulls/650"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/test/pulls/650","id":126124746,"html_url":"https://github.com/dart-lang/test/pull/650","diff_url":"https://github.com/dart-lang/test/pull/650.diff","patch_url":"https://github.com/dart-lang/test/pull/650.patch","issue_url":"https://api.github.com/repos/dart-lang/test/issues/650","number":650,"state":"open","locked":false,"title":"Configurable package folding","user":{"login":"grouma","id":1840773,"avatar_url":"https://avatars2.githubusercontent.com/u/1840773?v=3","gravatar_id":"","url":"https://api.github.com/users/grouma","html_url":"https://github.com/grouma","followers_url":"https://api.github.com/users/grouma/followers","following_url":"https://api.github.com/users/grouma/following{/other_user}","gists_url":"https://api.github.com/users/grouma/gists{/gist_id}","starred_url":"https://api.github.com/users/grouma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouma/subscriptions","organizations_url":"https://api.github.com/users/grouma/orgs","repos_url":"https://api.github.com/users/grouma/repos","events_url":"https://api.github.com/users/grouma/events{/privacy}","received_events_url":"https://api.github.com/users/grouma/received_events","type":"User","site_admin":false},"body":"- Allow StackTraceMapper to be serialized and deserialized\r\n- Send StackTraceMapper to remote isolate\r\n- Move all test chaining to the remote isolate\r\n- Enable new configurations for stack trace folding\r\n- Add corresponding tests\r\n\r\n\r\nThis will close https://github.com/dart-lang/test/issues/416\r\n","created_at":"2017-06-16T22:15:49Z","updated_at":"2017-06-20T22:35:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aab619d0c927bc9c99c7b4f4b50dea16f7876ef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/test/pulls/650/commits","review_comments_url":"https://api.github.com/repos/dart-lang/test/pulls/650/comments","review_comment_url":"https://api.github.com/repos/dart-lang/test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/test/issues/650/comments","statuses_url":"https://api.github.com/repos/dart-lang/test/statuses/2582c9919b218bc27f2f875849b3b7af47b3e234","head":{"label":"grouma:remote-mapping","ref":"remote-mapping","sha":"2582c9919b218bc27f2f875849b3b7af47b3e234","user":{"login":"grouma","id":1840773,"avatar_url":"https://avatars2.githubusercontent.com/u/1840773?v=3","gravatar_id":"","url":"https://api.github.com/users/grouma","html_url":"https://github.com/grouma","followers_url":"https://api.github.com/users/grouma/followers","following_url":"https://api.github.com/users/grouma/following{/other_user}","gists_url":"https://api.github.com/users/grouma/gists{/gist_id}","starred_url":"https://api.github.com/users/grouma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouma/subscriptions","organizations_url":"https://api.github.com/users/grouma/orgs","repos_url":"https://api.github.com/users/grouma/repos","events_url":"https://api.github.com/users/grouma/events{/privacy}","received_events_url":"https://api.github.com/users/grouma/received_events","type":"User","site_admin":false},"repo":{"id":85735820,"name":"test","full_name":"grouma/test","owner":{"login":"grouma","id":1840773,"avatar_url":"https://avatars2.githubusercontent.com/u/1840773?v=3","gravatar_id":"","url":"https://api.github.com/users/grouma","html_url":"https://github.com/grouma","followers_url":"https://api.github.com/users/grouma/followers","following_url":"https://api.github.com/users/grouma/following{/other_user}","gists_url":"https://api.github.com/users/grouma/gists{/gist_id}","starred_url":"https://api.github.com/users/grouma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouma/subscriptions","organizations_url":"https://api.github.com/users/grouma/orgs","repos_url":"https://api.github.com/users/grouma/repos","events_url":"https://api.github.com/users/grouma/events{/privacy}","received_events_url":"https://api.github.com/users/grouma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grouma/test","description":"A library for writing unit tests in Dart.","fork":true,"url":"https://api.github.com/repos/grouma/test","forks_url":"https://api.github.com/repos/grouma/test/forks","keys_url":"https://api.github.com/repos/grouma/test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grouma/test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grouma/test/teams","hooks_url":"https://api.github.com/repos/grouma/test/hooks","issue_events_url":"https://api.github.com/repos/grouma/test/issues/events{/number}","events_url":"https://api.github.com/repos/grouma/test/events","assignees_url":"https://api.github.com/repos/grouma/test/assignees{/user}","branches_url":"https://api.github.com/repos/grouma/test/branches{/branch}","tags_url":"https://api.github.com/repos/grouma/test/tags","blobs_url":"https://api.github.com/repos/grouma/test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grouma/test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grouma/test/git/refs{/sha}","trees_url":"https://api.github.com/repos/grouma/test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grouma/test/statuses/{sha}","languages_url":"https://api.github.com/repos/grouma/test/languages","stargazers_url":"https://api.github.com/repos/grouma/test/stargazers","contributors_url":"https://api.github.com/repos/grouma/test/contributors","subscribers_url":"https://api.github.com/repos/grouma/test/subscribers","subscription_url":"https://api.github.com/repos/grouma/test/subscription","commits_url":"https://api.github.com/repos/grouma/test/commits{/sha}","git_commits_url":"https://api.github.com/repos/grouma/test/git/commits{/sha}","comments_url":"https://api.github.com/repos/grouma/test/comments{/number}","issue_comment_url":"https://api.github.com/repos/grouma/test/issues/comments{/number}","contents_url":"https://api.github.com/repos/grouma/test/contents/{+path}","compare_url":"https://api.github.com/repos/grouma/test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grouma/test/merges","archive_url":"https://api.github.com/repos/grouma/test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grouma/test/downloads","issues_url":"https://api.github.com/repos/grouma/test/issues{/number}","pulls_url":"https://api.github.com/repos/grouma/test/pulls{/number}","milestones_url":"https://api.github.com/repos/grouma/test/milestones{/number}","notifications_url":"https://api.github.com/repos/grouma/test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grouma/test/labels{/name}","releases_url":"https://api.github.com/repos/grouma/test/releases{/id}","deployments_url":"https://api.github.com/repos/grouma/test/deployments","created_at":"2017-03-21T17:55:38Z","updated_at":"2017-03-21T17:55:40Z","pushed_at":"2017-06-20T22:35:25Z","git_url":"git://github.com/grouma/test.git","ssh_url":"[email protected]:grouma/test.git","clone_url":"https://github.com/grouma/test.git","svn_url":"https://github.com/grouma/test","homepage":"https://pub.dartlang.org/packages/test","size":3421,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"29973538105deb2d0c4da024a5bb0e85b4e9738a","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars3.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":28200583,"name":"test","full_name":"dart-lang/test","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars3.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/test","description":"A library for writing unit tests in Dart.","fork":false,"url":"https://api.github.com/repos/dart-lang/test","forks_url":"https://api.github.com/repos/dart-lang/test/forks","keys_url":"https://api.github.com/repos/dart-lang/test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/test/teams","hooks_url":"https://api.github.com/repos/dart-lang/test/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/test/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/test/events","assignees_url":"https://api.github.com/repos/dart-lang/test/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/test/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/test/tags","blobs_url":"https://api.github.com/repos/dart-lang/test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/test/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/test/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/test/languages","stargazers_url":"https://api.github.com/repos/dart-lang/test/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/test/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/test/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/test/subscription","commits_url":"https://api.github.com/repos/dart-lang/test/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/test/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/test/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/test/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/test/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/test/merges","archive_url":"https://api.github.com/repos/dart-lang/test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/test/downloads","issues_url":"https://api.github.com/repos/dart-lang/test/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/test/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/test/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/test/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/test/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/test/deployments","created_at":"2014-12-18T20:36:48Z","updated_at":"2017-06-13T21:54:22Z","pushed_at":"2017-06-20T22:35:27Z","git_url":"git://github.com/dart-lang/test.git","ssh_url":"[email protected]:dart-lang/test.git","clone_url":"https://github.com/dart-lang/test.git","svn_url":"https://github.com/dart-lang/test","homepage":"https://pub.dartlang.org/packages/test","size":3375,"stargazers_count":90,"watchers_count":90,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":67,"forks":83,"open_issues":67,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/test/pulls/650"},"html":{"href":"https://github.com/dart-lang/test/pull/650"},"issue":{"href":"https://api.github.com/repos/dart-lang/test/issues/650"},"comments":{"href":"https://api.github.com/repos/dart-lang/test/issues/650/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/test/pulls/650/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/test/pulls/650/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/test/statuses/2582c9919b218bc27f2f875849b3b7af47b3e234"}}}} | {
"id": 28200583,
"name": "dart-lang/test",
"url": "https://api.github.com/repos/dart-lang/test"
} | {
"id": 1840773,
"login": "grouma",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1840773?",
"url": "https://api.github.com/users/grouma"
} | {
"id": 1609975,
"login": "dart-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1609975?",
"url": "https://api.github.com/orgs/dart-lang"
} | 2017-06-20T22:26:11 | 6105079825 | {"actor":{"display_login":"grouma"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/discourse/discourse-solved/pulls/comments/103292684","pull_request_review_id":24074814,"id":103292684,"diff_hunk":"@@ -345,6 +345,16 @@ class ::TopicListItemSerializer\n def has_accepted_answer\n object.custom_fields[\"accepted_answer_post_id\"] ? true : false\n end\n+\n+ if SiteSetting.empty_box_on_unsolved","path":"plugin.rb","position":5,"original_position":5,"commit_id":"f17d8ca52e690030986aeca9d7785217025bb0e1","original_commit_id":"f17d8ca52e690030986aeca9d7785217025bb0e1","user":{"login":"SamSaffron","id":5213,"avatar_url":"https://avatars.githubusercontent.com/u/5213?v=3","gravatar_id":"","url":"https://api.github.com/users/SamSaffron","html_url":"https://github.com/SamSaffron","followers_url":"https://api.github.com/users/SamSaffron/followers","following_url":"https://api.github.com/users/SamSaffron/following{/other_user}","gists_url":"https://api.github.com/users/SamSaffron/gists{/gist_id}","starred_url":"https://api.github.com/users/SamSaffron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamSaffron/subscriptions","organizations_url":"https://api.github.com/users/SamSaffron/orgs","repos_url":"https://api.github.com/users/SamSaffron/repos","events_url":"https://api.github.com/users/SamSaffron/events{/privacy}","received_events_url":"https://api.github.com/users/SamSaffron/received_events","type":"User","site_admin":false},"body":"this means a site setting change will require a full application reload :( \r\n\r\njust use `include_can_have_answer?`","created_at":"2017-02-27T19:39:13Z","updated_at":"2017-02-27T19:39:13Z","html_url":"https://github.com/discourse/discourse-solved/pull/40#discussion_r103292684","pull_request_url":"https://api.github.com/repos/discourse/discourse-solved/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse-solved/pulls/comments/103292684"},"html":{"href":"https://github.com/discourse/discourse-solved/pull/40#discussion_r103292684"},"pull_request":{"href":"https://api.github.com/repos/discourse/discourse-solved/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/discourse/discourse-solved/pulls/40","id":108131694,"html_url":"https://github.com/discourse/discourse-solved/pull/40","diff_url":"https://github.com/discourse/discourse-solved/pull/40.diff","patch_url":"https://github.com/discourse/discourse-solved/pull/40.patch","issue_url":"https://api.github.com/repos/discourse/discourse-solved/issues/40","number":40,"state":"open","locked":false,"title":"Added empty box icon to unsolved topics","user":{"login":"davidtaylorhq","id":6270921,"avatar_url":"https://avatars.githubusercontent.com/u/6270921?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtaylorhq","html_url":"https://github.com/davidtaylorhq","followers_url":"https://api.github.com/users/davidtaylorhq/followers","following_url":"https://api.github.com/users/davidtaylorhq/following{/other_user}","gists_url":"https://api.github.com/users/davidtaylorhq/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtaylorhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtaylorhq/subscriptions","organizations_url":"https://api.github.com/users/davidtaylorhq/orgs","repos_url":"https://api.github.com/users/davidtaylorhq/repos","events_url":"https://api.github.com/users/davidtaylorhq/events{/privacy}","received_events_url":"https://api.github.com/users/davidtaylorhq/received_events","type":"User","site_admin":false},"body":"Adds a setting which allows displaying an \"Empty Box\" on topics which are eligible to receive an answer, but have not yet been solved. Disabled by default, so should not affect existing setups.\r\n\r\n<img width=\"318\" alt=\"screen shot 2017-02-27 at 15 01 44\" src=\"https://cloud.githubusercontent.com/assets/6270921/23366173/ad96d418-fcfd-11e6-925a-0752b0909164.png\">\r\n","created_at":"2017-02-27T15:02:35Z","updated_at":"2017-02-27T19:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c85a4c9499ccac400449e3b6200380c88cc6df34","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/discourse-solved/pulls/40/commits","review_comments_url":"https://api.github.com/repos/discourse/discourse-solved/pulls/40/comments","review_comment_url":"https://api.github.com/repos/discourse/discourse-solved/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/discourse-solved/issues/40/comments","statuses_url":"https://api.github.com/repos/discourse/discourse-solved/statuses/f17d8ca52e690030986aeca9d7785217025bb0e1","head":{"label":"davidtaylorhq:icon_on_unsolved","ref":"icon_on_unsolved","sha":"f17d8ca52e690030986aeca9d7785217025bb0e1","user":{"login":"davidtaylorhq","id":6270921,"avatar_url":"https://avatars.githubusercontent.com/u/6270921?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtaylorhq","html_url":"https://github.com/davidtaylorhq","followers_url":"https://api.github.com/users/davidtaylorhq/followers","following_url":"https://api.github.com/users/davidtaylorhq/following{/other_user}","gists_url":"https://api.github.com/users/davidtaylorhq/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtaylorhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtaylorhq/subscriptions","organizations_url":"https://api.github.com/users/davidtaylorhq/orgs","repos_url":"https://api.github.com/users/davidtaylorhq/repos","events_url":"https://api.github.com/users/davidtaylorhq/events{/privacy}","received_events_url":"https://api.github.com/users/davidtaylorhq/received_events","type":"User","site_admin":false},"repo":{"id":83322311,"name":"discourse-solved","full_name":"davidtaylorhq/discourse-solved","owner":{"login":"davidtaylorhq","id":6270921,"avatar_url":"https://avatars.githubusercontent.com/u/6270921?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtaylorhq","html_url":"https://github.com/davidtaylorhq","followers_url":"https://api.github.com/users/davidtaylorhq/followers","following_url":"https://api.github.com/users/davidtaylorhq/following{/other_user}","gists_url":"https://api.github.com/users/davidtaylorhq/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtaylorhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtaylorhq/subscriptions","organizations_url":"https://api.github.com/users/davidtaylorhq/orgs","repos_url":"https://api.github.com/users/davidtaylorhq/repos","events_url":"https://api.github.com/users/davidtaylorhq/events{/privacy}","received_events_url":"https://api.github.com/users/davidtaylorhq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidtaylorhq/discourse-solved","description":"Allow accepted answers on topics","fork":true,"url":"https://api.github.com/repos/davidtaylorhq/discourse-solved","forks_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/forks","keys_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/teams","hooks_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/hooks","issue_events_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/issues/events{/number}","events_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/events","assignees_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/assignees{/user}","branches_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/branches{/branch}","tags_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/tags","blobs_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/statuses/{sha}","languages_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/languages","stargazers_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/stargazers","contributors_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/contributors","subscribers_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/subscribers","subscription_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/subscription","commits_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/contents/{+path}","compare_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/merges","archive_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/downloads","issues_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/issues{/number}","pulls_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/pulls{/number}","milestones_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/milestones{/number}","notifications_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/labels{/name}","releases_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/releases{/id}","deployments_url":"https://api.github.com/repos/davidtaylorhq/discourse-solved/deployments","created_at":"2017-02-27T14:57:27Z","updated_at":"2017-02-27T14:57:29Z","pushed_at":"2017-02-27T18:38:14Z","git_url":"git://github.com/davidtaylorhq/discourse-solved.git","ssh_url":"[email protected]:davidtaylorhq/discourse-solved.git","clone_url":"https://github.com/davidtaylorhq/discourse-solved.git","svn_url":"https://github.com/davidtaylorhq/discourse-solved","homepage":null,"size":99,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"73e49096152a92075b112e8a356ab11fd28a2da8","user":{"login":"discourse","id":3220138,"avatar_url":"https://avatars.githubusercontent.com/u/3220138?v=3","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":35865534,"name":"discourse-solved","full_name":"discourse/discourse-solved","owner":{"login":"discourse","id":3220138,"avatar_url":"https://avatars.githubusercontent.com/u/3220138?v=3","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/discourse-solved","description":"Allow accepted answers on topics","fork":false,"url":"https://api.github.com/repos/discourse/discourse-solved","forks_url":"https://api.github.com/repos/discourse/discourse-solved/forks","keys_url":"https://api.github.com/repos/discourse/discourse-solved/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse-solved/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse-solved/teams","hooks_url":"https://api.github.com/repos/discourse/discourse-solved/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse-solved/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse-solved/events","assignees_url":"https://api.github.com/repos/discourse/discourse-solved/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse-solved/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse-solved/tags","blobs_url":"https://api.github.com/repos/discourse/discourse-solved/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse-solved/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse-solved/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse-solved/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse-solved/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse-solved/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse-solved/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse-solved/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse-solved/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse-solved/subscription","commits_url":"https://api.github.com/repos/discourse/discourse-solved/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse-solved/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse-solved/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse-solved/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse-solved/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse-solved/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse-solved/merges","archive_url":"https://api.github.com/repos/discourse/discourse-solved/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse-solved/downloads","issues_url":"https://api.github.com/repos/discourse/discourse-solved/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse-solved/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse-solved/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse-solved/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse-solved/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse-solved/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse-solved/deployments","created_at":"2015-05-19T07:11:49Z","updated_at":"2017-02-26T03:07:56Z","pushed_at":"2017-02-27T19:37:54Z","git_url":"git://github.com/discourse/discourse-solved.git","ssh_url":"[email protected]:discourse/discourse-solved.git","clone_url":"https://github.com/discourse/discourse-solved.git","svn_url":"https://github.com/discourse/discourse-solved","homepage":null,"size":91,"stargazers_count":45,"watchers_count":45,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":4,"forks":38,"open_issues":4,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse-solved/pulls/40"},"html":{"href":"https://github.com/discourse/discourse-solved/pull/40"},"issue":{"href":"https://api.github.com/repos/discourse/discourse-solved/issues/40"},"comments":{"href":"https://api.github.com/repos/discourse/discourse-solved/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/discourse-solved/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/discourse-solved/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/discourse-solved/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/discourse-solved/statuses/f17d8ca52e690030986aeca9d7785217025bb0e1"}}}} | {
"id": 35865534,
"name": "discourse/discourse-solved",
"url": "https://api.github.com/repos/discourse/discourse-solved"
} | {
"id": 5213,
"login": "SamSaffron",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5213?",
"url": "https://api.github.com/users/SamSaffron"
} | {
"id": 3220138,
"login": "discourse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3220138?",
"url": "https://api.github.com/orgs/discourse"
} | 2017-02-27T19:39:13 | 5399518242 | {"actor":{"display_login":"SamSaffron"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/duecredit/duecredit/pulls/comments/149454708","pull_request_review_id":74850326,"id":149454708,"diff_hunk":"@@ -15,18 +15,37 @@ level of reference detail, i.e. only references for actually used\n functionality will be presented back if software provides multiple\n citeable implementations.\n \n-\n+## Installation\n+\n+Duecredit is easy to install via pip, simply type:\n+ \n+ `pip install duecredit`\n+\n+## Examples\n \n-duecredit 101\n-=============\n+### To cite the modules you are using ","path":"README.md","position":23,"original_position":23,"commit_id":"99926b1544db21709bb6547780e1f9fa36e0817a","original_commit_id":"99926b1544db21709bb6547780e1f9fa36e0817a","user":{"login":"yarikoptic","id":39889,"avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"body":"I would say modules and methods","created_at":"2017-11-07T18:04:54Z","updated_at":"2017-11-07T18:04:54Z","html_url":"https://github.com/duecredit/duecredit/pull/120#discussion_r149454708","pull_request_url":"https://api.github.com/repos/duecredit/duecredit/pulls/120","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/duecredit/duecredit/pulls/comments/149454708"},"html":{"href":"https://github.com/duecredit/duecredit/pull/120#discussion_r149454708"},"pull_request":{"href":"https://api.github.com/repos/duecredit/duecredit/pulls/120"}},"in_reply_to_id":130699966},"pull_request":{"url":"https://api.github.com/repos/duecredit/duecredit/pulls/120","id":133537487,"html_url":"https://github.com/duecredit/duecredit/pull/120","diff_url":"https://github.com/duecredit/duecredit/pull/120.diff","patch_url":"https://github.com/duecredit/duecredit/pull/120.patch","issue_url":"https://api.github.com/repos/duecredit/duecredit/issues/120","number":120,"state":"open","locked":false,"title":"Improved Introduction to duecredit","user":{"login":"raamana","id":3196357,"avatar_url":"https://avatars2.githubusercontent.com/u/3196357?v=4","gravatar_id":"","url":"https://api.github.com/users/raamana","html_url":"https://github.com/raamana","followers_url":"https://api.github.com/users/raamana/followers","following_url":"https://api.github.com/users/raamana/following{/other_user}","gists_url":"https://api.github.com/users/raamana/gists{/gist_id}","starred_url":"https://api.github.com/users/raamana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raamana/subscriptions","organizations_url":"https://api.github.com/users/raamana/orgs","repos_url":"https://api.github.com/users/raamana/repos","events_url":"https://api.github.com/users/raamana/events{/privacy}","received_events_url":"https://api.github.com/users/raamana/received_events","type":"User","site_admin":false},"body":"Hey guys!\r\n\r\nGood job on gettting started in trying to solve this important problem. I appreciate the motivation and support the ideas. \r\n\r\nBut the README was difficult for me to follow, so I tried to improve it. I'm not sure if I even understand it correctly, this is to try improve it for everyone. Please feel free to correct and expand it as you see it.\r\n\r\nI will add this to my software once I get a handle on it.\r\n\r\nPradeep","created_at":"2017-08-01T18:13:11Z","updated_at":"2017-11-07T18:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d794891d991218d1d4a7e78a3cd58f2802d85b44","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/duecredit/duecredit/pulls/120/commits","review_comments_url":"https://api.github.com/repos/duecredit/duecredit/pulls/120/comments","review_comment_url":"https://api.github.com/repos/duecredit/duecredit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/duecredit/duecredit/issues/120/comments","statuses_url":"https://api.github.com/repos/duecredit/duecredit/statuses/99926b1544db21709bb6547780e1f9fa36e0817a","head":{"label":"raamana:master","ref":"master","sha":"99926b1544db21709bb6547780e1f9fa36e0817a","user":{"login":"raamana","id":3196357,"avatar_url":"https://avatars2.githubusercontent.com/u/3196357?v=4","gravatar_id":"","url":"https://api.github.com/users/raamana","html_url":"https://github.com/raamana","followers_url":"https://api.github.com/users/raamana/followers","following_url":"https://api.github.com/users/raamana/following{/other_user}","gists_url":"https://api.github.com/users/raamana/gists{/gist_id}","starred_url":"https://api.github.com/users/raamana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raamana/subscriptions","organizations_url":"https://api.github.com/users/raamana/orgs","repos_url":"https://api.github.com/users/raamana/repos","events_url":"https://api.github.com/users/raamana/events{/privacy}","received_events_url":"https://api.github.com/users/raamana/received_events","type":"User","site_admin":false},"repo":{"id":99027302,"name":"duecredit","full_name":"raamana/duecredit","owner":{"login":"raamana","id":3196357,"avatar_url":"https://avatars2.githubusercontent.com/u/3196357?v=4","gravatar_id":"","url":"https://api.github.com/users/raamana","html_url":"https://github.com/raamana","followers_url":"https://api.github.com/users/raamana/followers","following_url":"https://api.github.com/users/raamana/following{/other_user}","gists_url":"https://api.github.com/users/raamana/gists{/gist_id}","starred_url":"https://api.github.com/users/raamana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raamana/subscriptions","organizations_url":"https://api.github.com/users/raamana/orgs","repos_url":"https://api.github.com/users/raamana/repos","events_url":"https://api.github.com/users/raamana/events{/privacy}","received_events_url":"https://api.github.com/users/raamana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raamana/duecredit","description":"Automated collection and reporting of citations for used software/methods/datasets","fork":true,"url":"https://api.github.com/repos/raamana/duecredit","forks_url":"https://api.github.com/repos/raamana/duecredit/forks","keys_url":"https://api.github.com/repos/raamana/duecredit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raamana/duecredit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raamana/duecredit/teams","hooks_url":"https://api.github.com/repos/raamana/duecredit/hooks","issue_events_url":"https://api.github.com/repos/raamana/duecredit/issues/events{/number}","events_url":"https://api.github.com/repos/raamana/duecredit/events","assignees_url":"https://api.github.com/repos/raamana/duecredit/assignees{/user}","branches_url":"https://api.github.com/repos/raamana/duecredit/branches{/branch}","tags_url":"https://api.github.com/repos/raamana/duecredit/tags","blobs_url":"https://api.github.com/repos/raamana/duecredit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raamana/duecredit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raamana/duecredit/git/refs{/sha}","trees_url":"https://api.github.com/repos/raamana/duecredit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raamana/duecredit/statuses/{sha}","languages_url":"https://api.github.com/repos/raamana/duecredit/languages","stargazers_url":"https://api.github.com/repos/raamana/duecredit/stargazers","contributors_url":"https://api.github.com/repos/raamana/duecredit/contributors","subscribers_url":"https://api.github.com/repos/raamana/duecredit/subscribers","subscription_url":"https://api.github.com/repos/raamana/duecredit/subscription","commits_url":"https://api.github.com/repos/raamana/duecredit/commits{/sha}","git_commits_url":"https://api.github.com/repos/raamana/duecredit/git/commits{/sha}","comments_url":"https://api.github.com/repos/raamana/duecredit/comments{/number}","issue_comment_url":"https://api.github.com/repos/raamana/duecredit/issues/comments{/number}","contents_url":"https://api.github.com/repos/raamana/duecredit/contents/{+path}","compare_url":"https://api.github.com/repos/raamana/duecredit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raamana/duecredit/merges","archive_url":"https://api.github.com/repos/raamana/duecredit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raamana/duecredit/downloads","issues_url":"https://api.github.com/repos/raamana/duecredit/issues{/number}","pulls_url":"https://api.github.com/repos/raamana/duecredit/pulls{/number}","milestones_url":"https://api.github.com/repos/raamana/duecredit/milestones{/number}","notifications_url":"https://api.github.com/repos/raamana/duecredit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raamana/duecredit/labels{/name}","releases_url":"https://api.github.com/repos/raamana/duecredit/releases{/id}","deployments_url":"https://api.github.com/repos/raamana/duecredit/deployments","created_at":"2017-08-01T17:37:37Z","updated_at":"2017-08-01T17:37:38Z","pushed_at":"2017-08-01T18:09:29Z","git_url":"git://github.com/raamana/duecredit.git","ssh_url":"[email protected]:raamana/duecredit.git","clone_url":"https://github.com/raamana/duecredit.git","svn_url":"https://github.com/raamana/duecredit","homepage":"","size":814,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"duecredit:master","ref":"master","sha":"62da28f4f9bf40880516709d2e075586a2b02b48","user":{"login":"duecredit","id":12863039,"avatar_url":"https://avatars0.githubusercontent.com/u/12863039?v=4","gravatar_id":"","url":"https://api.github.com/users/duecredit","html_url":"https://github.com/duecredit","followers_url":"https://api.github.com/users/duecredit/followers","following_url":"https://api.github.com/users/duecredit/following{/other_user}","gists_url":"https://api.github.com/users/duecredit/gists{/gist_id}","starred_url":"https://api.github.com/users/duecredit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duecredit/subscriptions","organizations_url":"https://api.github.com/users/duecredit/orgs","repos_url":"https://api.github.com/users/duecredit/repos","events_url":"https://api.github.com/users/duecredit/events{/privacy}","received_events_url":"https://api.github.com/users/duecredit/received_events","type":"Organization","site_admin":false},"repo":{"id":34000285,"name":"duecredit","full_name":"duecredit/duecredit","owner":{"login":"duecredit","id":12863039,"avatar_url":"https://avatars0.githubusercontent.com/u/12863039?v=4","gravatar_id":"","url":"https://api.github.com/users/duecredit","html_url":"https://github.com/duecredit","followers_url":"https://api.github.com/users/duecredit/followers","following_url":"https://api.github.com/users/duecredit/following{/other_user}","gists_url":"https://api.github.com/users/duecredit/gists{/gist_id}","starred_url":"https://api.github.com/users/duecredit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duecredit/subscriptions","organizations_url":"https://api.github.com/users/duecredit/orgs","repos_url":"https://api.github.com/users/duecredit/repos","events_url":"https://api.github.com/users/duecredit/events{/privacy}","received_events_url":"https://api.github.com/users/duecredit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/duecredit/duecredit","description":"Automated collection and reporting of citations for used software/methods/datasets","fork":false,"url":"https://api.github.com/repos/duecredit/duecredit","forks_url":"https://api.github.com/repos/duecredit/duecredit/forks","keys_url":"https://api.github.com/repos/duecredit/duecredit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duecredit/duecredit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duecredit/duecredit/teams","hooks_url":"https://api.github.com/repos/duecredit/duecredit/hooks","issue_events_url":"https://api.github.com/repos/duecredit/duecredit/issues/events{/number}","events_url":"https://api.github.com/repos/duecredit/duecredit/events","assignees_url":"https://api.github.com/repos/duecredit/duecredit/assignees{/user}","branches_url":"https://api.github.com/repos/duecredit/duecredit/branches{/branch}","tags_url":"https://api.github.com/repos/duecredit/duecredit/tags","blobs_url":"https://api.github.com/repos/duecredit/duecredit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duecredit/duecredit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duecredit/duecredit/git/refs{/sha}","trees_url":"https://api.github.com/repos/duecredit/duecredit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duecredit/duecredit/statuses/{sha}","languages_url":"https://api.github.com/repos/duecredit/duecredit/languages","stargazers_url":"https://api.github.com/repos/duecredit/duecredit/stargazers","contributors_url":"https://api.github.com/repos/duecredit/duecredit/contributors","subscribers_url":"https://api.github.com/repos/duecredit/duecredit/subscribers","subscription_url":"https://api.github.com/repos/duecredit/duecredit/subscription","commits_url":"https://api.github.com/repos/duecredit/duecredit/commits{/sha}","git_commits_url":"https://api.github.com/repos/duecredit/duecredit/git/commits{/sha}","comments_url":"https://api.github.com/repos/duecredit/duecredit/comments{/number}","issue_comment_url":"https://api.github.com/repos/duecredit/duecredit/issues/comments{/number}","contents_url":"https://api.github.com/repos/duecredit/duecredit/contents/{+path}","compare_url":"https://api.github.com/repos/duecredit/duecredit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duecredit/duecredit/merges","archive_url":"https://api.github.com/repos/duecredit/duecredit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duecredit/duecredit/downloads","issues_url":"https://api.github.com/repos/duecredit/duecredit/issues{/number}","pulls_url":"https://api.github.com/repos/duecredit/duecredit/pulls{/number}","milestones_url":"https://api.github.com/repos/duecredit/duecredit/milestones{/number}","notifications_url":"https://api.github.com/repos/duecredit/duecredit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duecredit/duecredit/labels{/name}","releases_url":"https://api.github.com/repos/duecredit/duecredit/releases{/id}","deployments_url":"https://api.github.com/repos/duecredit/duecredit/deployments","created_at":"2015-04-15T14:56:22Z","updated_at":"2017-10-11T17:37:05Z","pushed_at":"2017-11-07T18:03:09Z","git_url":"git://github.com/duecredit/duecredit.git","ssh_url":"[email protected]:duecredit/duecredit.git","clone_url":"https://github.com/duecredit/duecredit.git","svn_url":"https://github.com/duecredit/duecredit","homepage":"","size":809,"stargazers_count":85,"watchers_count":85,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":29,"forks":14,"open_issues":29,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/duecredit/duecredit/pulls/120"},"html":{"href":"https://github.com/duecredit/duecredit/pull/120"},"issue":{"href":"https://api.github.com/repos/duecredit/duecredit/issues/120"},"comments":{"href":"https://api.github.com/repos/duecredit/duecredit/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/duecredit/duecredit/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/duecredit/duecredit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/duecredit/duecredit/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/duecredit/duecredit/statuses/99926b1544db21709bb6547780e1f9fa36e0817a"}},"author_association":"NONE"}} | {
"id": 34000285,
"name": "duecredit/duecredit",
"url": "https://api.github.com/repos/duecredit/duecredit"
} | {
"id": 39889,
"login": "yarikoptic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39889?",
"url": "https://api.github.com/users/yarikoptic"
} | {
"id": 12863039,
"login": "duecredit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12863039?",
"url": "https://api.github.com/orgs/duecredit"
} | 2017-11-07T18:04:54 | 6821859039 | {"actor":{"display_login":"yarikoptic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/comments/96431554","pull_request_review_id":17012109,"id":96431554,"diff_hunk":"@@ -0,0 +1,219 @@\n+<?php\n+/**\n+ * @file\n+ * Contains \\Drupal\\nexteuropa\\Context\\FieldContext.\n+ */\n+\n+namespace Drupal\\nexteuropa\\Context;\n+\n+use Behat\\Behat\\Context\\Context;\n+use Behat\\Gherkin\\Node\\TableNode;\n+\n+/**\n+ * Context with content type management.\n+ */\n+class ContentTypeContext implements Context {\n+\n+ /**\n+ * The list of node type before a scenario starts.\n+ *\n+ * @var array\n+ */\n+ protected $defaultNodeTypes = array();\n+\n+ /**\n+ * Remember the list of node type.\n+ *\n+ * @BeforeScenario\n+ */\n+ public function rememberCurrentNodeTypes() {\n+ foreach (node_type_get_types() as $result) {\n+ $this->defaultNodeTypes[$result->type] = $result->type;\n+ }\n+ }\n+\n+ /**\n+ * Removes any node types created after the last list node type remembered.\n+ *\n+ * @AfterScenario\n+ */\n+ public function resetNodeTypes() {\n+ if (empty($this->defaultNodeTypes)) {\n+ return;\n+ }\n+\n+ foreach (node_type_get_types() as $result) {\n+ if (!in_array($result->type, $this->defaultNodeTypes)) {\n+ node_type_delete($result->type);\n+ }\n+ }\n+ $this->defaultNodeTypes = array();\n+ }\n+\n+ /**\n+ * Add a field to a specified content type.\n+ *\n+ * @param string $arg1","path":"tests/src/Context/ContentTypeContext.php","position":56,"original_position":56,"commit_id":"e072f9073da2c05ffd3a9eaa81b7c38617b577a5","original_commit_id":"e072f9073da2c05ffd3a9eaa81b7c38617b577a5","user":{"login":"imanoleguskiza","id":14978592,"avatar_url":"https://avatars.githubusercontent.com/u/14978592?v=3","gravatar_id":"","url":"https://api.github.com/users/imanoleguskiza","html_url":"https://github.com/imanoleguskiza","followers_url":"https://api.github.com/users/imanoleguskiza/followers","following_url":"https://api.github.com/users/imanoleguskiza/following{/other_user}","gists_url":"https://api.github.com/users/imanoleguskiza/gists{/gist_id}","starred_url":"https://api.github.com/users/imanoleguskiza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imanoleguskiza/subscriptions","organizations_url":"https://api.github.com/users/imanoleguskiza/orgs","repos_url":"https://api.github.com/users/imanoleguskiza/repos","events_url":"https://api.github.com/users/imanoleguskiza/events{/privacy}","received_events_url":"https://api.github.com/users/imanoleguskiza/received_events","type":"User","site_admin":false},"body":"We should check that the content type $arg1 exists","created_at":"2017-01-17T15:11:53Z","updated_at":"2017-01-17T15:11:53Z","html_url":"https://github.com/ec-europa/platform-dev/pull/1132#discussion_r96431554","pull_request_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/1132","_links":{"self":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/comments/96431554"},"html":{"href":"https://github.com/ec-europa/platform-dev/pull/1132#discussion_r96431554"},"pull_request":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/1132"}}},"pull_request":{"url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/1132","id":100250493,"html_url":"https://github.com/ec-europa/platform-dev/pull/1132","diff_url":"https://github.com/ec-europa/platform-dev/pull/1132.diff","patch_url":"https://github.com/ec-europa/platform-dev/pull/1132.patch","issue_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/1132","number":1132,"state":"open","locked":false,"title":"Nept 225 : refactore field.multilingual.feature ","user":{"login":"gillesdeudon","id":8696408,"avatar_url":"https://avatars.githubusercontent.com/u/8696408?v=3","gravatar_id":"","url":"https://api.github.com/users/gillesdeudon","html_url":"https://github.com/gillesdeudon","followers_url":"https://api.github.com/users/gillesdeudon/followers","following_url":"https://api.github.com/users/gillesdeudon/following{/other_user}","gists_url":"https://api.github.com/users/gillesdeudon/gists{/gist_id}","starred_url":"https://api.github.com/users/gillesdeudon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gillesdeudon/subscriptions","organizations_url":"https://api.github.com/users/gillesdeudon/orgs","repos_url":"https://api.github.com/users/gillesdeudon/repos","events_url":"https://api.github.com/users/gillesdeudon/events{/privacy}","received_events_url":"https://api.github.com/users/gillesdeudon/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-05T08:25:11Z","updated_at":"2017-01-17T15:11:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc243e0b9e8178054f0520e77420e48a108455d1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/1132/comments","statuses_url":"https://api.github.com/repos/ec-europa/platform-dev/statuses/e072f9073da2c05ffd3a9eaa81b7c38617b577a5","head":{"label":"ec-europa:nept-225","ref":"nept-225","sha":"e072f9073da2c05ffd3a9eaa81b7c38617b577a5","user":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"repo":{"id":41666809,"name":"platform-dev","full_name":"ec-europa/platform-dev","owner":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ec-europa/platform-dev","description":"NextEuropa platform","fork":false,"url":"https://api.github.com/repos/ec-europa/platform-dev","forks_url":"https://api.github.com/repos/ec-europa/platform-dev/forks","keys_url":"https://api.github.com/repos/ec-europa/platform-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ec-europa/platform-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ec-europa/platform-dev/teams","hooks_url":"https://api.github.com/repos/ec-europa/platform-dev/hooks","issue_events_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ec-europa/platform-dev/events","assignees_url":"https://api.github.com/repos/ec-europa/platform-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ec-europa/platform-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ec-europa/platform-dev/tags","blobs_url":"https://api.github.com/repos/ec-europa/platform-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ec-europa/platform-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ec-europa/platform-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ec-europa/platform-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ec-europa/platform-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ec-europa/platform-dev/languages","stargazers_url":"https://api.github.com/repos/ec-europa/platform-dev/stargazers","contributors_url":"https://api.github.com/repos/ec-europa/platform-dev/contributors","subscribers_url":"https://api.github.com/repos/ec-europa/platform-dev/subscribers","subscription_url":"https://api.github.com/repos/ec-europa/platform-dev/subscription","commits_url":"https://api.github.com/repos/ec-europa/platform-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ec-europa/platform-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ec-europa/platform-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ec-europa/platform-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ec-europa/platform-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ec-europa/platform-dev/merges","archive_url":"https://api.github.com/repos/ec-europa/platform-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ec-europa/platform-dev/downloads","issues_url":"https://api.github.com/repos/ec-europa/platform-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ec-europa/platform-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ec-europa/platform-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ec-europa/platform-dev/labels{/name}","releases_url":"https://api.github.com/repos/ec-europa/platform-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ec-europa/platform-dev/deployments","created_at":"2015-08-31T09:16:12Z","updated_at":"2016-12-20T14:00:49Z","pushed_at":"2017-01-17T13:59:56Z","git_url":"git://github.com/ec-europa/platform-dev.git","ssh_url":"[email protected]:ec-europa/platform-dev.git","clone_url":"https://github.com/ec-europa/platform-dev.git","svn_url":"https://github.com/ec-europa/platform-dev","homepage":null,"size":48141,"stargazers_count":27,"watchers_count":27,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":49,"forks":26,"open_issues":49,"watchers":27,"default_branch":"master"}},"base":{"label":"ec-europa:release-2.4","ref":"release-2.4","sha":"abf3828092c5c7f5d46a74f38f9f900aefdc0794","user":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"repo":{"id":41666809,"name":"platform-dev","full_name":"ec-europa/platform-dev","owner":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ec-europa/platform-dev","description":"NextEuropa platform","fork":false,"url":"https://api.github.com/repos/ec-europa/platform-dev","forks_url":"https://api.github.com/repos/ec-europa/platform-dev/forks","keys_url":"https://api.github.com/repos/ec-europa/platform-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ec-europa/platform-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ec-europa/platform-dev/teams","hooks_url":"https://api.github.com/repos/ec-europa/platform-dev/hooks","issue_events_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ec-europa/platform-dev/events","assignees_url":"https://api.github.com/repos/ec-europa/platform-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ec-europa/platform-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ec-europa/platform-dev/tags","blobs_url":"https://api.github.com/repos/ec-europa/platform-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ec-europa/platform-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ec-europa/platform-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ec-europa/platform-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ec-europa/platform-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ec-europa/platform-dev/languages","stargazers_url":"https://api.github.com/repos/ec-europa/platform-dev/stargazers","contributors_url":"https://api.github.com/repos/ec-europa/platform-dev/contributors","subscribers_url":"https://api.github.com/repos/ec-europa/platform-dev/subscribers","subscription_url":"https://api.github.com/repos/ec-europa/platform-dev/subscription","commits_url":"https://api.github.com/repos/ec-europa/platform-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ec-europa/platform-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ec-europa/platform-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ec-europa/platform-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ec-europa/platform-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ec-europa/platform-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ec-europa/platform-dev/merges","archive_url":"https://api.github.com/repos/ec-europa/platform-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ec-europa/platform-dev/downloads","issues_url":"https://api.github.com/repos/ec-europa/platform-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ec-europa/platform-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ec-europa/platform-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ec-europa/platform-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ec-europa/platform-dev/labels{/name}","releases_url":"https://api.github.com/repos/ec-europa/platform-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ec-europa/platform-dev/deployments","created_at":"2015-08-31T09:16:12Z","updated_at":"2016-12-20T14:00:49Z","pushed_at":"2017-01-17T13:59:56Z","git_url":"git://github.com/ec-europa/platform-dev.git","ssh_url":"[email protected]:ec-europa/platform-dev.git","clone_url":"https://github.com/ec-europa/platform-dev.git","svn_url":"https://github.com/ec-europa/platform-dev","homepage":null,"size":48141,"stargazers_count":27,"watchers_count":27,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":49,"forks":26,"open_issues":49,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/1132"},"html":{"href":"https://github.com/ec-europa/platform-dev/pull/1132"},"issue":{"href":"https://api.github.com/repos/ec-europa/platform-dev/issues/1132"},"comments":{"href":"https://api.github.com/repos/ec-europa/platform-dev/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ec-europa/platform-dev/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/ec-europa/platform-dev/statuses/e072f9073da2c05ffd3a9eaa81b7c38617b577a5"}}}} | {
"id": 41666809,
"name": "ec-europa/platform-dev",
"url": "https://api.github.com/repos/ec-europa/platform-dev"
} | {
"id": 14978592,
"login": "imanoleguskiza",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14978592?",
"url": "https://api.github.com/users/imanoleguskiza"
} | {
"id": 10885565,
"login": "ec-europa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10885565?",
"url": "https://api.github.com/orgs/ec-europa"
} | 2017-01-17T15:11:53 | 5165996464 | {"actor":{"display_login":"imanoleguskiza"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/comments/122611808","pull_request_review_id":44741395,"id":122611808,"diff_hunk":"@@ -27,10 +28,18 @@ require.config({\n });\n \n \n-require(['jquery', 'pandoraPage', 'dataset_info_form', 'user_profile', 'register', 'login'], function ($, p, datasetForm, userProfile) {\n+require(['jquery', 'pandoraPage', 'dataset_info_form', 'user_profile','metis_tabs', 'register', 'login'], function ($, p, datasetForm, userProfile, metisTabs) {\n p.pageInit();\n datasetForm.formInit();\n // register.formInit();\n // login.formInit();\n userProfile.formInit();\n+ metisTabs.init(\n+ $('.eu-accordion-tabs'),\n+ {\n+ \"active\": 0,","path":"source/js/modules/main/templates/main-pandora.js","position":24,"original_position":24,"commit_id":"f20991415aae349c2f9856b00fe6e515805a047f","original_commit_id":"f20991415aae349c2f9856b00fe6e515805a047f","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Strings must use singlequote quotes","created_at":"2017-06-19T02:27:36Z","updated_at":"2017-06-19T02:27:37Z","html_url":"https://github.com/europeana/Europeana-Patternlab/pull/213#discussion_r122611808","pull_request_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/comments/122611808"},"html":{"href":"https://github.com/europeana/Europeana-Patternlab/pull/213#discussion_r122611808"},"pull_request":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/213","id":126214178,"html_url":"https://github.com/europeana/Europeana-Patternlab/pull/213","diff_url":"https://github.com/europeana/Europeana-Patternlab/pull/213.diff","patch_url":"https://github.com/europeana/Europeana-Patternlab/pull/213.patch","issue_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/213","number":213,"state":"open","locked":false,"title":"#2563 Create a page for a Dataset","user":{"login":"avlisodraude","id":5918438,"avatar_url":"https://avatars2.githubusercontent.com/u/5918438?v=3","gravatar_id":"","url":"https://api.github.com/users/avlisodraude","html_url":"https://github.com/avlisodraude","followers_url":"https://api.github.com/users/avlisodraude/followers","following_url":"https://api.github.com/users/avlisodraude/following{/other_user}","gists_url":"https://api.github.com/users/avlisodraude/gists{/gist_id}","starred_url":"https://api.github.com/users/avlisodraude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avlisodraude/subscriptions","organizations_url":"https://api.github.com/users/avlisodraude/orgs","repos_url":"https://api.github.com/users/avlisodraude/repos","events_url":"https://api.github.com/users/avlisodraude/events{/privacy}","received_events_url":"https://api.github.com/users/avlisodraude/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-19T02:27:31Z","updated_at":"2017-06-19T02:27:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eaa11c5921a013a7ec4ef983daf8aa3255d5144","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/213/commits","review_comments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/213/comments","review_comment_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/213/comments","statuses_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/statuses/f20991415aae349c2f9856b00fe6e515805a047f","head":{"label":"europeana:feat/2563-create-page-for-dataset","ref":"feat/2563-create-page-for-dataset","sha":"f20991415aae349c2f9856b00fe6e515805a047f","user":{"login":"europeana","id":4570681,"avatar_url":"https://avatars0.githubusercontent.com/u/4570681?v=3","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"repo":{"id":14299552,"name":"Europeana-Patternlab","full_name":"europeana/Europeana-Patternlab","owner":{"login":"europeana","id":4570681,"avatar_url":"https://avatars0.githubusercontent.com/u/4570681?v=3","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/europeana/Europeana-Patternlab","description":"Source code for the Europeana Web Style Guide. ","fork":false,"url":"https://api.github.com/repos/europeana/Europeana-Patternlab","forks_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/forks","keys_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/teams","hooks_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/hooks","issue_events_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/events{/number}","events_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/events","assignees_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/assignees{/user}","branches_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/branches{/branch}","tags_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/tags","blobs_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/statuses/{sha}","languages_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/languages","stargazers_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/stargazers","contributors_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/contributors","subscribers_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/subscribers","subscription_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/subscription","commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/contents/{+path}","compare_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/merges","archive_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/downloads","issues_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues{/number}","pulls_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls{/number}","milestones_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/milestones{/number}","notifications_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/labels{/name}","releases_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/releases{/id}","deployments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/deployments","created_at":"2013-11-11T11:53:37Z","updated_at":"2017-05-09T19:11:31Z","pushed_at":"2017-06-19T02:27:32Z","git_url":"git://github.com/europeana/Europeana-Patternlab.git","ssh_url":"[email protected]:europeana/Europeana-Patternlab.git","clone_url":"https://github.com/europeana/Europeana-Patternlab.git","svn_url":"https://github.com/europeana/Europeana-Patternlab","homepage":"http://styleguide.europeana.eu/","size":212871,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":7,"default_branch":"develop"}},"base":{"label":"europeana:develop","ref":"develop","sha":"2b4a4bfec7649ad34773332244c8f55e517c2420","user":{"login":"europeana","id":4570681,"avatar_url":"https://avatars0.githubusercontent.com/u/4570681?v=3","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"repo":{"id":14299552,"name":"Europeana-Patternlab","full_name":"europeana/Europeana-Patternlab","owner":{"login":"europeana","id":4570681,"avatar_url":"https://avatars0.githubusercontent.com/u/4570681?v=3","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/europeana/Europeana-Patternlab","description":"Source code for the Europeana Web Style Guide. ","fork":false,"url":"https://api.github.com/repos/europeana/Europeana-Patternlab","forks_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/forks","keys_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/teams","hooks_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/hooks","issue_events_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/events{/number}","events_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/events","assignees_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/assignees{/user}","branches_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/branches{/branch}","tags_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/tags","blobs_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/statuses/{sha}","languages_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/languages","stargazers_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/stargazers","contributors_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/contributors","subscribers_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/subscribers","subscription_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/subscription","commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/contents/{+path}","compare_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/merges","archive_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/downloads","issues_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues{/number}","pulls_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls{/number}","milestones_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/milestones{/number}","notifications_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/labels{/name}","releases_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/releases{/id}","deployments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/deployments","created_at":"2013-11-11T11:53:37Z","updated_at":"2017-05-09T19:11:31Z","pushed_at":"2017-06-19T02:27:32Z","git_url":"git://github.com/europeana/Europeana-Patternlab.git","ssh_url":"[email protected]:europeana/Europeana-Patternlab.git","clone_url":"https://github.com/europeana/Europeana-Patternlab.git","svn_url":"https://github.com/europeana/Europeana-Patternlab","homepage":"http://styleguide.europeana.eu/","size":212871,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/213"},"html":{"href":"https://github.com/europeana/Europeana-Patternlab/pull/213"},"issue":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/213"},"comments":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/statuses/f20991415aae349c2f9856b00fe6e515805a047f"}}}} | {
"id": 14299552,
"name": "europeana/Europeana-Patternlab",
"url": "https://api.github.com/repos/europeana/Europeana-Patternlab"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4570681,
"login": "europeana",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4570681?",
"url": "https://api.github.com/orgs/europeana"
} | 2017-06-19T02:27:36 | 6088999503 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/152239779","pull_request_review_id":78068537,"id":152239779,"diff_hunk":"@@ -28,6 +30,40 @@ public function __construct(ContentService $contentService, LocationService $loc\n $this->locationService = $locationService;\n }\n \n+ /**\n+ * Extracts and validate internal links.\n+ *\n+ * @param \\DOMDocument $xml\n+ * @return array\n+ */\n+ public function validateDocument(DOMDocument $xml)","path":"eZ/Publish/Core/FieldType/RichText/InternalLinkValidator.php","position":23,"original_position":23,"commit_id":"ff60c8dc7fa9e908c0666c98c499723307314c58","original_commit_id":"ff60c8dc7fa9e908c0666c98c499723307314c58","user":{"login":"alongosz","id":7099219,"avatar_url":"https://avatars1.githubusercontent.com/u/7099219?v=4","gravatar_id":"","url":"https://api.github.com/users/alongosz","html_url":"https://github.com/alongosz","followers_url":"https://api.github.com/users/alongosz/followers","following_url":"https://api.github.com/users/alongosz/following{/other_user}","gists_url":"https://api.github.com/users/alongosz/gists{/gist_id}","starred_url":"https://api.github.com/users/alongosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alongosz/subscriptions","organizations_url":"https://api.github.com/users/alongosz/orgs","repos_url":"https://api.github.com/users/alongosz/repos","events_url":"https://api.github.com/users/alongosz/events{/privacy}","received_events_url":"https://api.github.com/users/alongosz/received_events","type":"User","site_admin":false},"body":"However please use naming consistent with `eZ\\Publish\\Core\\FieldType\\RichText\\Validator::validate`. Your naming choice is better, but I prefer to have this aligned. On the other hand, as it's Core, we could change `validate` to `validateDocument`, but it's still risky, so +0.25 on the latter suggestion ;)","created_at":"2017-11-21T10:53:20Z","updated_at":"2017-11-21T10:55:32Z","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2154#discussion_r152239779","pull_request_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2154","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/152239779"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/2154#discussion_r152239779"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2154"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2154","id":153609487,"html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2154","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2154.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2154.patch","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2154","number":2154,"state":"open","locked":false,"title":"[WIP] EZP-28174: Validation of ezlocation:// and ezcontent:// links in the richtext field type","user":{"login":"adamwojs","id":211967,"avatar_url":"https://avatars1.githubusercontent.com/u/211967?v=4","gravatar_id":"","url":"https://api.github.com/users/adamwojs","html_url":"https://github.com/adamwojs","followers_url":"https://api.github.com/users/adamwojs/followers","following_url":"https://api.github.com/users/adamwojs/following{/other_user}","gists_url":"https://api.github.com/users/adamwojs/gists{/gist_id}","starred_url":"https://api.github.com/users/adamwojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamwojs/subscriptions","organizations_url":"https://api.github.com/users/adamwojs/orgs","repos_url":"https://api.github.com/users/adamwojs/repos","events_url":"https://api.github.com/users/adamwojs/events{/privacy}","received_events_url":"https://api.github.com/users/adamwojs/received_events","type":"User","site_admin":false},"body":"> JIRA: https://jira.ez.no/browse/EZP-28174\r\n\r\n## Description \r\n\r\nThis PR adds validation of `ezlocation://` and `ezcontent://` links on the the richtext field type definition level. \r\n\r\n\r\n\r\n\r\nCurrently, if link target does not exist the `NotFound` with message `Could not find 'location' with identifier '63'` exception is thrown (https://github.com/ezsystems/ezpublish-kernel/blob/6.7/eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php#L84) when content relations are processed\r\n\r\n## Steps to reproduce\r\n\r\n> 1. Create new Article (or another ContentType object which has RichText filed) for e.g. Article A,\r\n> 2. Create the second content object, for e.g. Article B. Let's assume, that this article has LocationId 63.\r\n> 3. Edit Article A, in RichText editor, add some paragraph with text, select few words and click on add URL button. Then, click on Select content, select Article B, then Save URL and publish content.\r\n> 4. Move Article B to trash.\r\n> 5. Try to edit Article A. It will be impossible to save until you manually remove previously the added link. If you edit the link, you will see ezlocation://63 in Link to: field.\r\n> \r\n\r\n## TODO\r\n\r\n- [ ] Validate architecture\r\n- [x] Adjust the validation error to protocol \r\n- [x] `UnauthorizedException` handling in `\\eZ\\Publish\\Core\\FieldType\\RichText\\InternalLinkValidator::validate`\r\n- [ ] Tests","created_at":"2017-11-20T11:49:32Z","updated_at":"2017-11-21T10:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22c06e32c385a6a6730ae06d4adfc9fa1fe25063","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2154/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2154/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2154/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/ff60c8dc7fa9e908c0666c98c499723307314c58","head":{"label":"adamwojs:fix-EZP-28174_ezlocation_to_non_existing_location_breaks_the_publication","ref":"fix-EZP-28174_ezlocation_to_non_existing_location_breaks_the_publication","sha":"ff60c8dc7fa9e908c0666c98c499723307314c58","user":{"login":"adamwojs","id":211967,"avatar_url":"https://avatars1.githubusercontent.com/u/211967?v=4","gravatar_id":"","url":"https://api.github.com/users/adamwojs","html_url":"https://github.com/adamwojs","followers_url":"https://api.github.com/users/adamwojs/followers","following_url":"https://api.github.com/users/adamwojs/following{/other_user}","gists_url":"https://api.github.com/users/adamwojs/gists{/gist_id}","starred_url":"https://api.github.com/users/adamwojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamwojs/subscriptions","organizations_url":"https://api.github.com/users/adamwojs/orgs","repos_url":"https://api.github.com/users/adamwojs/repos","events_url":"https://api.github.com/users/adamwojs/events{/privacy}","received_events_url":"https://api.github.com/users/adamwojs/received_events","type":"User","site_admin":false},"repo":{"id":87902104,"name":"ezpublish-kernel","full_name":"adamwojs/ezpublish-kernel","owner":{"login":"adamwojs","id":211967,"avatar_url":"https://avatars1.githubusercontent.com/u/211967?v=4","gravatar_id":"","url":"https://api.github.com/users/adamwojs","html_url":"https://github.com/adamwojs","followers_url":"https://api.github.com/users/adamwojs/followers","following_url":"https://api.github.com/users/adamwojs/following{/other_user}","gists_url":"https://api.github.com/users/adamwojs/gists{/gist_id}","starred_url":"https://api.github.com/users/adamwojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamwojs/subscriptions","organizations_url":"https://api.github.com/users/adamwojs/orgs","repos_url":"https://api.github.com/users/adamwojs/repos","events_url":"https://api.github.com/users/adamwojs/events{/privacy}","received_events_url":"https://api.github.com/users/adamwojs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamwojs/ezpublish-kernel","description":"Kernel (Repository, MVC layer, REST) for eZ Platform","fork":true,"url":"https://api.github.com/repos/adamwojs/ezpublish-kernel","forks_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/adamwojs/ezpublish-kernel/deployments","created_at":"2017-04-11T07:13:37Z","updated_at":"2017-04-11T07:13:48Z","pushed_at":"2017-11-20T14:29:26Z","git_url":"git://github.com/adamwojs/ezpublish-kernel.git","ssh_url":"[email protected]:adamwojs/ezpublish-kernel.git","clone_url":"https://github.com/adamwojs/ezpublish-kernel.git","svn_url":"https://github.com/adamwojs/ezpublish-kernel","homepage":"http://ezplatform.com/","size":49763,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:6.7","ref":"6.7","sha":"12023ad072b20069ee95c2b4cbfdf6f5184f7d2d","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1663890,"name":"ezpublish-kernel","full_name":"ezsystems/ezpublish-kernel","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-kernel","description":"Kernel (Repository, MVC layer, REST) for eZ Platform","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/deployments","created_at":"2011-04-26T08:54:24Z","updated_at":"2017-11-18T03:58:54Z","pushed_at":"2017-11-21T10:38:17Z","git_url":"git://github.com/ezsystems/ezpublish-kernel.git","ssh_url":"[email protected]:ezsystems/ezpublish-kernel.git","clone_url":"https://github.com/ezsystems/ezpublish-kernel.git","svn_url":"https://github.com/ezsystems/ezpublish-kernel","homepage":"http://ezplatform.com/","size":49967,"stargazers_count":133,"watchers_count":133,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":85,"forks":191,"open_issues":85,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2154"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/2154"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2154"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2154/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2154/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2154/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/ff60c8dc7fa9e908c0666c98c499723307314c58"}},"author_association":"MEMBER"}} | {
"id": 1663890,
"name": "ezsystems/ezpublish-kernel",
"url": "https://api.github.com/repos/ezsystems/ezpublish-kernel"
} | {
"id": 7099219,
"login": "alongosz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7099219?",
"url": "https://api.github.com/users/alongosz"
} | {
"id": 295311,
"login": "ezsystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/295311?",
"url": "https://api.github.com/orgs/ezsystems"
} | 2017-11-21T10:53:20 | 6883877617 | {"actor":{"display_login":"alongosz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/comments/96352955","pull_request_review_id":16930635,"id":96352955,"diff_hunk":"@@ -138,8 +136,39 @@ $textCenter: center;\n .db{ display: block; }\n .textCenter{ text-align: $textCenter; }\n .pointer{ cursor: pointer; }\n+//patternfly-site.css\n+h2{\n+ font-size: em(18);\n+ font-weight: 500;\n+ line-height: 1.4;\n+}\n+//card-view\n \n-//user -gravatar\n+.card-pf-view {\n+ .card-pf-top-element {\n+ .card-pf-icon-circle {\n+ @include Border(em(0.8), solid, $color-pf-blue-300); //#39a5dc;\n+ @include borderRadius(50%);\n+ @extend .db;\n+ font-size: em(36);\n+ height: em(34); //2.84em","path":"src/assets/stylesheets/custom.scss","position":37,"original_position":37,"commit_id":"7807ddc2da77d78f7c5182f17d9fd2f396ec0e8a","original_commit_id":"7807ddc2da77d78f7c5182f17d9fd2f396ec0e8a","user":{"login":"SMahil","id":10396359,"avatar_url":"https://avatars.githubusercontent.com/u/10396359?v=3","gravatar_id":"","url":"https://api.github.com/users/SMahil","html_url":"https://github.com/SMahil","followers_url":"https://api.github.com/users/SMahil/followers","following_url":"https://api.github.com/users/SMahil/following{/other_user}","gists_url":"https://api.github.com/users/SMahil/gists{/gist_id}","starred_url":"https://api.github.com/users/SMahil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMahil/subscriptions","organizations_url":"https://api.github.com/users/SMahil/orgs","repos_url":"https://api.github.com/users/SMahil/repos","events_url":"https://api.github.com/users/SMahil/events{/privacy}","received_events_url":"https://api.github.com/users/SMahil/received_events","type":"User","site_admin":false},"body":"em(36) doesnot give 102px here as the font-size acts as base font for the div","created_at":"2017-01-17T06:59:02Z","updated_at":"2017-01-17T06:59:02Z","html_url":"https://github.com/fabric8io/fabric8-planner/pull/751#discussion_r96352955","pull_request_url":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/751","_links":{"self":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/comments/96352955"},"html":{"href":"https://github.com/fabric8io/fabric8-planner/pull/751#discussion_r96352955"},"pull_request":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/751"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/751","id":101648419,"html_url":"https://github.com/fabric8io/fabric8-planner/pull/751","diff_url":"https://github.com/fabric8io/fabric8-planner/pull/751.diff","patch_url":"https://github.com/fabric8io/fabric8-planner/pull/751.patch","issue_url":"https://api.github.com/repos/fabric8io/fabric8-planner/issues/751","number":751,"state":"open","locked":false,"title":"match UI for WI type modal","user":{"login":"SMahil","id":10396359,"avatar_url":"https://avatars.githubusercontent.com/u/10396359?v=3","gravatar_id":"","url":"https://api.github.com/users/SMahil","html_url":"https://github.com/SMahil","followers_url":"https://api.github.com/users/SMahil/followers","following_url":"https://api.github.com/users/SMahil/following{/other_user}","gists_url":"https://api.github.com/users/SMahil/gists{/gist_id}","starred_url":"https://api.github.com/users/SMahil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMahil/subscriptions","organizations_url":"https://api.github.com/users/SMahil/orgs","repos_url":"https://api.github.com/users/SMahil/repos","events_url":"https://api.github.com/users/SMahil/events{/privacy}","received_events_url":"https://api.github.com/users/SMahil/received_events","type":"User","site_admin":false},"body":"#736 \r\n\r\n- Match UI for WI type modal\r\n- Match classes for WI action bar as per Patternfly","created_at":"2017-01-16T08:41:56Z","updated_at":"2017-01-17T06:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c6fa3c6da1f24743d84bfc43745a22c8b3add00","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/751/commits","review_comments_url":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/751/comments","review_comment_url":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/fabric8-planner/issues/751/comments","statuses_url":"https://api.github.com/repos/fabric8io/fabric8-planner/statuses/7807ddc2da77d78f7c5182f17d9fd2f396ec0e8a","head":{"label":"SMahil:alm-736","ref":"alm-736","sha":"7807ddc2da77d78f7c5182f17d9fd2f396ec0e8a","user":{"login":"SMahil","id":10396359,"avatar_url":"https://avatars.githubusercontent.com/u/10396359?v=3","gravatar_id":"","url":"https://api.github.com/users/SMahil","html_url":"https://github.com/SMahil","followers_url":"https://api.github.com/users/SMahil/followers","following_url":"https://api.github.com/users/SMahil/following{/other_user}","gists_url":"https://api.github.com/users/SMahil/gists{/gist_id}","starred_url":"https://api.github.com/users/SMahil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMahil/subscriptions","organizations_url":"https://api.github.com/users/SMahil/orgs","repos_url":"https://api.github.com/users/SMahil/repos","events_url":"https://api.github.com/users/SMahil/events{/privacy}","received_events_url":"https://api.github.com/users/SMahil/received_events","type":"User","site_admin":false},"repo":{"id":67703503,"name":"fabric8-planner","full_name":"SMahil/fabric8-planner","owner":{"login":"SMahil","id":10396359,"avatar_url":"https://avatars.githubusercontent.com/u/10396359?v=3","gravatar_id":"","url":"https://api.github.com/users/SMahil","html_url":"https://github.com/SMahil","followers_url":"https://api.github.com/users/SMahil/followers","following_url":"https://api.github.com/users/SMahil/following{/other_user}","gists_url":"https://api.github.com/users/SMahil/gists{/gist_id}","starred_url":"https://api.github.com/users/SMahil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMahil/subscriptions","organizations_url":"https://api.github.com/users/SMahil/orgs","repos_url":"https://api.github.com/users/SMahil/repos","events_url":"https://api.github.com/users/SMahil/events{/privacy}","received_events_url":"https://api.github.com/users/SMahil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SMahil/fabric8-planner","description":null,"fork":true,"url":"https://api.github.com/repos/SMahil/fabric8-planner","forks_url":"https://api.github.com/repos/SMahil/fabric8-planner/forks","keys_url":"https://api.github.com/repos/SMahil/fabric8-planner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SMahil/fabric8-planner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SMahil/fabric8-planner/teams","hooks_url":"https://api.github.com/repos/SMahil/fabric8-planner/hooks","issue_events_url":"https://api.github.com/repos/SMahil/fabric8-planner/issues/events{/number}","events_url":"https://api.github.com/repos/SMahil/fabric8-planner/events","assignees_url":"https://api.github.com/repos/SMahil/fabric8-planner/assignees{/user}","branches_url":"https://api.github.com/repos/SMahil/fabric8-planner/branches{/branch}","tags_url":"https://api.github.com/repos/SMahil/fabric8-planner/tags","blobs_url":"https://api.github.com/repos/SMahil/fabric8-planner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SMahil/fabric8-planner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SMahil/fabric8-planner/git/refs{/sha}","trees_url":"https://api.github.com/repos/SMahil/fabric8-planner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SMahil/fabric8-planner/statuses/{sha}","languages_url":"https://api.github.com/repos/SMahil/fabric8-planner/languages","stargazers_url":"https://api.github.com/repos/SMahil/fabric8-planner/stargazers","contributors_url":"https://api.github.com/repos/SMahil/fabric8-planner/contributors","subscribers_url":"https://api.github.com/repos/SMahil/fabric8-planner/subscribers","subscription_url":"https://api.github.com/repos/SMahil/fabric8-planner/subscription","commits_url":"https://api.github.com/repos/SMahil/fabric8-planner/commits{/sha}","git_commits_url":"https://api.github.com/repos/SMahil/fabric8-planner/git/commits{/sha}","comments_url":"https://api.github.com/repos/SMahil/fabric8-planner/comments{/number}","issue_comment_url":"https://api.github.com/repos/SMahil/fabric8-planner/issues/comments{/number}","contents_url":"https://api.github.com/repos/SMahil/fabric8-planner/contents/{+path}","compare_url":"https://api.github.com/repos/SMahil/fabric8-planner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SMahil/fabric8-planner/merges","archive_url":"https://api.github.com/repos/SMahil/fabric8-planner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SMahil/fabric8-planner/downloads","issues_url":"https://api.github.com/repos/SMahil/fabric8-planner/issues{/number}","pulls_url":"https://api.github.com/repos/SMahil/fabric8-planner/pulls{/number}","milestones_url":"https://api.github.com/repos/SMahil/fabric8-planner/milestones{/number}","notifications_url":"https://api.github.com/repos/SMahil/fabric8-planner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SMahil/fabric8-planner/labels{/name}","releases_url":"https://api.github.com/repos/SMahil/fabric8-planner/releases{/id}","deployments_url":"https://api.github.com/repos/SMahil/fabric8-planner/deployments","created_at":"2016-09-08T13:00:58Z","updated_at":"2017-01-12T12:32:08Z","pushed_at":"2017-01-17T06:28:46Z","git_url":"git://github.com/SMahil/fabric8-planner.git","ssh_url":"[email protected]:SMahil/fabric8-planner.git","clone_url":"https://github.com/SMahil/fabric8-planner.git","svn_url":"https://github.com/SMahil/fabric8-planner","homepage":"http://devdoc.almighty.io/","size":5297,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:master","ref":"master","sha":"4af7d3ebf39161165c1bb6f3cc5e3c82dfe209e6","user":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":63066512,"name":"fabric8-planner","full_name":"fabric8io/fabric8-planner","owner":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io/fabric8-planner","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8io/fabric8-planner","forks_url":"https://api.github.com/repos/fabric8io/fabric8-planner/forks","keys_url":"https://api.github.com/repos/fabric8io/fabric8-planner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/fabric8-planner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/fabric8-planner/teams","hooks_url":"https://api.github.com/repos/fabric8io/fabric8-planner/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/fabric8-planner/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/fabric8-planner/events","assignees_url":"https://api.github.com/repos/fabric8io/fabric8-planner/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/fabric8-planner/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/fabric8-planner/tags","blobs_url":"https://api.github.com/repos/fabric8io/fabric8-planner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/fabric8-planner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/fabric8-planner/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/fabric8-planner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/fabric8-planner/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/fabric8-planner/languages","stargazers_url":"https://api.github.com/repos/fabric8io/fabric8-planner/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/fabric8-planner/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/fabric8-planner/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/fabric8-planner/subscription","commits_url":"https://api.github.com/repos/fabric8io/fabric8-planner/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/fabric8-planner/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/fabric8-planner/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/fabric8-planner/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/fabric8-planner/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/fabric8-planner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/fabric8-planner/merges","archive_url":"https://api.github.com/repos/fabric8io/fabric8-planner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/fabric8-planner/downloads","issues_url":"https://api.github.com/repos/fabric8io/fabric8-planner/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/fabric8-planner/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/fabric8-planner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/fabric8-planner/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/fabric8-planner/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/fabric8-planner/deployments","created_at":"2016-07-11T12:36:20Z","updated_at":"2017-01-13T13:27:09Z","pushed_at":"2017-01-17T06:28:48Z","git_url":"git://github.com/fabric8io/fabric8-planner.git","ssh_url":"[email protected]:fabric8io/fabric8-planner.git","clone_url":"https://github.com/fabric8io/fabric8-planner.git","svn_url":"https://github.com/fabric8io/fabric8-planner","homepage":"http://devdoc.almighty.io/","size":5374,"stargazers_count":14,"watchers_count":14,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":218,"forks":29,"open_issues":218,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/751"},"html":{"href":"https://github.com/fabric8io/fabric8-planner/pull/751"},"issue":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/issues/751"},"comments":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/issues/751/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/751/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/pulls/751/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/fabric8-planner/statuses/7807ddc2da77d78f7c5182f17d9fd2f396ec0e8a"}}}} | {
"id": 63066512,
"name": "fabric8io/fabric8-planner",
"url": "https://api.github.com/repos/fabric8io/fabric8-planner"
} | {
"id": 10396359,
"login": "SMahil",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10396359?",
"url": "https://api.github.com/users/SMahil"
} | {
"id": 6074349,
"login": "fabric8io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6074349?",
"url": "https://api.github.com/orgs/fabric8io"
} | 2017-01-17T06:59:02 | 5163489563 | {"actor":{"display_login":"SMahil"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/comments/109701033","pull_request_review_id":30820323,"id":109701033,"diff_hunk":"@@ -15,44 +15,182 @@\n */\n package io.fabric8.maven.core.service;\n \n+import java.util.Objects;\n+import java.util.concurrent.ConcurrentHashMap;\n+\n+import io.fabric8.kubernetes.api.Controller;\n import io.fabric8.kubernetes.client.KubernetesClient;\n import io.fabric8.maven.core.access.ClusterAccess;\n import io.fabric8.maven.core.config.PlatformMode;\n import io.fabric8.maven.core.service.kubernetes.DockerBuildService;\n import io.fabric8.maven.core.service.openshift.OpenshiftBuildService;\n+import io.fabric8.maven.core.util.LazyBuilder;\n import io.fabric8.maven.docker.service.ServiceHub;\n import io.fabric8.maven.docker.util.Logger;\n import io.fabric8.openshift.client.OpenShiftClient;\n \n+import org.apache.maven.project.MavenProject;\n+import org.apache.maven.repository.RepositorySystem;\n+\n /**\n * @author nicola\n * @since 17/02/2017\n */\n public class Fabric8ServiceHub {\n \n- private BuildService buildService;\n+ /*\n+ * Configured resources\n+ */\n+ private ClusterAccess clusterAccess;\n+\n+ private PlatformMode platformMode;\n+\n+ private Logger log;\n+\n+ private ServiceHub dockerServiceHub;\n+\n+ private BuildService.BuildServiceConfig buildServiceConfig;\n+\n+ private RepositorySystem repositorySystem;\n+\n+ private MavenProject mavenProject;\n+\n+ /**\n+ * Configurable with default\n+ */\n+ private Controller controller;\n+\n+ /*\n+ * Computed resources\n+ */\n+\n+ private PlatformMode resolvedMode;\n \n- public Fabric8ServiceHub(ClusterAccess clusterAccess, PlatformMode mode, Logger log, ServiceHub dockerServiceHub) {\n- PlatformMode resolvedMode = clusterAccess.resolvePlatformMode(mode, log);\n- KubernetesClient client = clusterAccess.createDefaultClient(log);\n+ private KubernetesClient client;\n \n- // Creating platform-dependent services\n- if (resolvedMode == PlatformMode.kubernetes) {\n- // Kubernetes services\n- this.buildService = new DockerBuildService(dockerServiceHub);\n+ private ConcurrentHashMap<Class<?>, LazyBuilder<?>> services = new ConcurrentHashMap<>();\n \n- } else if(resolvedMode == PlatformMode.openshift) {\n- // Openshift services\n- this.buildService = new OpenshiftBuildService((OpenShiftClient) client, log, dockerServiceHub);\n+ private Fabric8ServiceHub() {\n+ }\n+\n+ private void init() {","path":"core/src/main/java/io/fabric8/maven/core/service/Fabric8ServiceHub.java","position":73,"original_position":73,"commit_id":"74ccdee1fb219f25834b398b2bc51a60f6da3b36","original_commit_id":"74ccdee1fb219f25834b398b2bc51a60f6da3b36","user":{"login":"pepperbot","id":25871694,"avatar_url":"https://avatars3.githubusercontent.com/u/25871694?v=3","gravatar_id":"","url":"https://api.github.com/users/pepperbot","html_url":"https://github.com/pepperbot","followers_url":"https://api.github.com/users/pepperbot/followers","following_url":"https://api.github.com/users/pepperbot/following{/other_user}","gists_url":"https://api.github.com/users/pepperbot/gists{/gist_id}","starred_url":"https://api.github.com/users/pepperbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepperbot/subscriptions","organizations_url":"https://api.github.com/users/pepperbot/orgs","repos_url":"https://api.github.com/users/pepperbot/repos","events_url":"https://api.github.com/users/pepperbot/events{/privacy}","received_events_url":"https://api.github.com/users/pepperbot/received_events","type":"User","site_admin":false},"body":" Move this method into \"Builder\". [](https://sonarqube.com/coding_rules#rule_key=squid%3AS3398)\n","created_at":"2017-04-04T15:47:02Z","updated_at":"2017-04-04T15:47:02Z","html_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/909#discussion_r109701033","pull_request_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/909","_links":{"self":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/comments/109701033"},"html":{"href":"https://github.com/fabric8io/fabric8-maven-plugin/pull/909#discussion_r109701033"},"pull_request":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/909"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/909","id":114180637,"html_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/909","diff_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/909.diff","patch_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/909.patch","issue_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/909","number":909,"state":"open","locked":false,"title":"Fix the spring-boot watch mojo: #832","user":{"login":"nicolaferraro","id":4151857,"avatar_url":"https://avatars1.githubusercontent.com/u/4151857?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaferraro","html_url":"https://github.com/nicolaferraro","followers_url":"https://api.github.com/users/nicolaferraro/followers","following_url":"https://api.github.com/users/nicolaferraro/following{/other_user}","gists_url":"https://api.github.com/users/nicolaferraro/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaferraro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaferraro/subscriptions","organizations_url":"https://api.github.com/users/nicolaferraro/orgs","repos_url":"https://api.github.com/users/nicolaferraro/repos","events_url":"https://api.github.com/users/nicolaferraro/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaferraro/received_events","type":"User","site_admin":false},"body":"This fixes the spring-boot watch mojo. I've done all changes on top of [this pr](https://github.com/fabric8io/fabric8-maven-plugin/pull/900), for simplicity.\r\n\r\nNow it can do port-forward directly to the pod, if no services are exposed by the pod controller. It is able to determine the right pod and port. Port forward uses the client tools. I plan to upgrade to using kubernetes client, to use at least the websocket version (kube 1.6+).\r\n\r\nAutomatic generation of the remote token now is fixed. I added an environment variable to the kubernetes deployment (the watch mojo is independent of other mojos). This was necessary because a recompilation of the project caused an update to the remote \"application.properties\" file, so that the token got lost when it was not set explicitly set by the user. The kubernetes deployment env variable overrides what is present in application.properties, so the remote token does not change during recompilation.\r\n\r\nI've **removed all dependencies to spring-boot from the plugin**. The devtools now are downloaded using maven repository system. The correct version is downloaded (version of spring-boot used in the client project). I've tested it with spring-boot [1.4.1.RELEASE, 1.5.2.RELEASE].","created_at":"2017-04-04T15:43:52Z","updated_at":"2017-04-04T15:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6b3a0d5a25b49841b3a83e64445deeac23bc5fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/909/commits","review_comments_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/909/comments","review_comment_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/909/comments","statuses_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/statuses/74ccdee1fb219f25834b398b2bc51a60f6da3b36","head":{"label":"nicolaferraro:fix-spring-boot","ref":"fix-spring-boot","sha":"74ccdee1fb219f25834b398b2bc51a60f6da3b36","user":{"login":"nicolaferraro","id":4151857,"avatar_url":"https://avatars1.githubusercontent.com/u/4151857?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaferraro","html_url":"https://github.com/nicolaferraro","followers_url":"https://api.github.com/users/nicolaferraro/followers","following_url":"https://api.github.com/users/nicolaferraro/following{/other_user}","gists_url":"https://api.github.com/users/nicolaferraro/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaferraro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaferraro/subscriptions","organizations_url":"https://api.github.com/users/nicolaferraro/orgs","repos_url":"https://api.github.com/users/nicolaferraro/repos","events_url":"https://api.github.com/users/nicolaferraro/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaferraro/received_events","type":"User","site_admin":false},"repo":{"id":63221530,"name":"fabric8-maven-plugin","full_name":"nicolaferraro/fabric8-maven-plugin","owner":{"login":"nicolaferraro","id":4151857,"avatar_url":"https://avatars1.githubusercontent.com/u/4151857?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaferraro","html_url":"https://github.com/nicolaferraro","followers_url":"https://api.github.com/users/nicolaferraro/followers","following_url":"https://api.github.com/users/nicolaferraro/following{/other_user}","gists_url":"https://api.github.com/users/nicolaferraro/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaferraro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaferraro/subscriptions","organizations_url":"https://api.github.com/users/nicolaferraro/orgs","repos_url":"https://api.github.com/users/nicolaferraro/repos","events_url":"https://api.github.com/users/nicolaferraro/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaferraro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolaferraro/fabric8-maven-plugin","description":"Maven plugin for getting your Java apps easily to Kubernetes and OpenShift","fork":true,"url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin","forks_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/forks","keys_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/teams","hooks_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/events","assignees_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/tags","blobs_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/subscription","commits_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/merges","archive_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/downloads","issues_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/nicolaferraro/fabric8-maven-plugin/deployments","created_at":"2016-07-13T06:45:22Z","updated_at":"2016-07-13T06:45:23Z","pushed_at":"2017-04-04T15:30:33Z","git_url":"git://github.com/nicolaferraro/fabric8-maven-plugin.git","ssh_url":"[email protected]:nicolaferraro/fabric8-maven-plugin.git","clone_url":"https://github.com/nicolaferraro/fabric8-maven-plugin.git","svn_url":"https://github.com/nicolaferraro/fabric8-maven-plugin","homepage":"","size":3057,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:master","ref":"master","sha":"556a8fbd2addc103b4083fa0621e1b23feb26093","user":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars2.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":55504627,"name":"fabric8-maven-plugin","full_name":"fabric8io/fabric8-maven-plugin","owner":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars2.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io/fabric8-maven-plugin","description":"Maven plugin for getting your Java apps on to Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin","forks_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/forks","keys_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/teams","hooks_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/events","assignees_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/tags","blobs_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/subscription","commits_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/merges","archive_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/downloads","issues_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/deployments","created_at":"2016-04-05T12:05:45Z","updated_at":"2017-03-21T03:14:05Z","pushed_at":"2017-04-04T15:43:53Z","git_url":"git://github.com/fabric8io/fabric8-maven-plugin.git","ssh_url":"[email protected]:fabric8io/fabric8-maven-plugin.git","clone_url":"https://github.com/fabric8io/fabric8-maven-plugin.git","svn_url":"https://github.com/fabric8io/fabric8-maven-plugin","homepage":"https://maven.fabric8.io","size":15435,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":144,"forks":46,"open_issues":144,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/909"},"html":{"href":"https://github.com/fabric8io/fabric8-maven-plugin/pull/909"},"issue":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/909"},"comments":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/909/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/909/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/909/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/statuses/74ccdee1fb219f25834b398b2bc51a60f6da3b36"}}}} | {
"id": 55504627,
"name": "fabric8io/fabric8-maven-plugin",
"url": "https://api.github.com/repos/fabric8io/fabric8-maven-plugin"
} | {
"id": 25871694,
"login": "pepperbot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25871694?",
"url": "https://api.github.com/users/pepperbot"
} | {
"id": 6074349,
"login": "fabric8io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6074349?",
"url": "https://api.github.com/orgs/fabric8io"
} | 2017-04-04T15:47:02 | 5623856053 | {"actor":{"display_login":"pepperbot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/geopandas/geopandas/pulls/comments/131173093","pull_request_review_id":54122190,"id":131173093,"diff_hunk":"@@ -41,14 +60,61 @@ class GeoDataFrame(GeoPandasBase, DataFrame):\n _metadata = ['crs', '_geometry_column_name']\n \n _geometry_column_name = DEFAULT_GEO_COLUMN_NAME\n+ _pandas_cls = pd.Series\n \n def __init__(self, *args, **kwargs):\n crs = kwargs.pop('crs', None)\n- geometry = kwargs.pop('geometry', None)\n- super(GeoDataFrame, self).__init__(*args, **kwargs)\n+\n+ geometry = kwargs.pop('geometry', 'geometry')\n+ [arg] = args\n+\n+ if isinstance(arg, BlockManager):\n+ super(GeoDataFrame, self).__init__(arg, **kwargs)\n+ self.crs = crs\n+ self._geometry_column_name = geometry\n+ return\n+\n+ gs = {}\n+\n+ if isinstance(arg, dict):\n+ for i, (k, v) in list(enumerate(arg.items())):\n+ if isinstance(v, GeoSeries):\n+ if 'columns' in kwargs:\n+ kwargs['columns'].pop(i)\n+ gs[k] = arg.pop(k)\n+ kwargs['index'] = v.index # TODO: assumes consistent index\n+\n+ if isinstance(arg, (dict, list, pd.Series, np.ndarray)):\n+ arg = pd.DataFrame(arg, **kwargs)\n+\n+ assert isinstance(arg, pd.DataFrame)","path":"geopandas/geodataframe.py","position":75,"original_position":72,"commit_id":"60ed39a1b0813655f155b742e128457aabcff49d","original_commit_id":"efdc91e29c70b5305180b191803f4412ab27bc28","user":{"login":"jorisvandenbossche","id":1020496,"avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"do you typically leave such asserts? \r\nWe could also raise a ValueError saying that the passed data is not supported","created_at":"2017-08-03T15:20:23Z","updated_at":"2017-08-03T15:47:47Z","html_url":"https://github.com/geopandas/geopandas/pull/467#discussion_r131173093","pull_request_url":"https://api.github.com/repos/geopandas/geopandas/pulls/467","_links":{"self":{"href":"https://api.github.com/repos/geopandas/geopandas/pulls/comments/131173093"},"html":{"href":"https://github.com/geopandas/geopandas/pull/467#discussion_r131173093"},"pull_request":{"href":"https://api.github.com/repos/geopandas/geopandas/pulls/467"}}},"pull_request":{"url":"https://api.github.com/repos/geopandas/geopandas/pulls/467","id":130874625,"html_url":"https://github.com/geopandas/geopandas/pull/467","diff_url":"https://github.com/geopandas/geopandas/pull/467.diff","patch_url":"https://github.com/geopandas/geopandas/pull/467.patch","issue_url":"https://api.github.com/repos/geopandas/geopandas/issues/467","number":467,"state":"open","locked":false,"title":"WIP - Cythonize geometry series operations","user":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"body":"This cythonizes a class of geometry operations within geoseries. It builds off of @jorisvandenbossche notebook in #430 by extending the set of operations and setting up a proper build environment.\r\n\r\nSome things to note\r\n\r\n1. There is a Cython build setup provided by @eriknw\r\n2. Cython code is only used if available, falling back on the previous Python solution\r\n3. @wmay has another attempt at https://github.com/Toblerity/Shapely/issues/501\r\n4. I get around a 50-100x speedup on a simple comparison\r\n5. There are some inconsistencies between this and what shapely does that I haven't yet tracked won\r\n6. There are still plenty of operations to do. This just expands on @jorisvandenbossche 's work","created_at":"2017-07-17T14:48:59Z","updated_at":"2017-08-03T15:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a39e67f76b9348224bf052159bab698cbb6d9f01","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/geopandas/geopandas/pulls/467/commits","review_comments_url":"https://api.github.com/repos/geopandas/geopandas/pulls/467/comments","review_comment_url":"https://api.github.com/repos/geopandas/geopandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geopandas/geopandas/issues/467/comments","statuses_url":"https://api.github.com/repos/geopandas/geopandas/statuses/60ed39a1b0813655f155b742e128457aabcff49d","head":{"label":"mrocklin:cythonize","ref":"cythonize","sha":"60ed39a1b0813655f155b742e128457aabcff49d","user":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"repo":{"id":97347151,"name":"geopandas","full_name":"mrocklin/geopandas","owner":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrocklin/geopandas","description":"Python tools for geographic data","fork":true,"url":"https://api.github.com/repos/mrocklin/geopandas","forks_url":"https://api.github.com/repos/mrocklin/geopandas/forks","keys_url":"https://api.github.com/repos/mrocklin/geopandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrocklin/geopandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrocklin/geopandas/teams","hooks_url":"https://api.github.com/repos/mrocklin/geopandas/hooks","issue_events_url":"https://api.github.com/repos/mrocklin/geopandas/issues/events{/number}","events_url":"https://api.github.com/repos/mrocklin/geopandas/events","assignees_url":"https://api.github.com/repos/mrocklin/geopandas/assignees{/user}","branches_url":"https://api.github.com/repos/mrocklin/geopandas/branches{/branch}","tags_url":"https://api.github.com/repos/mrocklin/geopandas/tags","blobs_url":"https://api.github.com/repos/mrocklin/geopandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrocklin/geopandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrocklin/geopandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrocklin/geopandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrocklin/geopandas/statuses/{sha}","languages_url":"https://api.github.com/repos/mrocklin/geopandas/languages","stargazers_url":"https://api.github.com/repos/mrocklin/geopandas/stargazers","contributors_url":"https://api.github.com/repos/mrocklin/geopandas/contributors","subscribers_url":"https://api.github.com/repos/mrocklin/geopandas/subscribers","subscription_url":"https://api.github.com/repos/mrocklin/geopandas/subscription","commits_url":"https://api.github.com/repos/mrocklin/geopandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrocklin/geopandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrocklin/geopandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrocklin/geopandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrocklin/geopandas/contents/{+path}","compare_url":"https://api.github.com/repos/mrocklin/geopandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrocklin/geopandas/merges","archive_url":"https://api.github.com/repos/mrocklin/geopandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrocklin/geopandas/downloads","issues_url":"https://api.github.com/repos/mrocklin/geopandas/issues{/number}","pulls_url":"https://api.github.com/repos/mrocklin/geopandas/pulls{/number}","milestones_url":"https://api.github.com/repos/mrocklin/geopandas/milestones{/number}","notifications_url":"https://api.github.com/repos/mrocklin/geopandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrocklin/geopandas/labels{/name}","releases_url":"https://api.github.com/repos/mrocklin/geopandas/releases{/id}","deployments_url":"https://api.github.com/repos/mrocklin/geopandas/deployments","created_at":"2017-07-15T23:08:09Z","updated_at":"2017-07-15T23:08:10Z","pushed_at":"2017-08-03T15:44:08Z","git_url":"git://github.com/mrocklin/geopandas.git","ssh_url":"[email protected]:mrocklin/geopandas.git","clone_url":"https://github.com/mrocklin/geopandas.git","svn_url":"https://github.com/mrocklin/geopandas","homepage":"","size":4865,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"geopandas:master","ref":"master","sha":"cfb31200024e4c3f5a1a4dc4d1576f4367e5336b","user":{"login":"geopandas","id":8130715,"avatar_url":"https://avatars2.githubusercontent.com/u/8130715?v=4","gravatar_id":"","url":"https://api.github.com/users/geopandas","html_url":"https://github.com/geopandas","followers_url":"https://api.github.com/users/geopandas/followers","following_url":"https://api.github.com/users/geopandas/following{/other_user}","gists_url":"https://api.github.com/users/geopandas/gists{/gist_id}","starred_url":"https://api.github.com/users/geopandas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geopandas/subscriptions","organizations_url":"https://api.github.com/users/geopandas/orgs","repos_url":"https://api.github.com/users/geopandas/repos","events_url":"https://api.github.com/users/geopandas/events{/privacy}","received_events_url":"https://api.github.com/users/geopandas/received_events","type":"Organization","site_admin":false},"repo":{"id":11002815,"name":"geopandas","full_name":"geopandas/geopandas","owner":{"login":"geopandas","id":8130715,"avatar_url":"https://avatars2.githubusercontent.com/u/8130715?v=4","gravatar_id":"","url":"https://api.github.com/users/geopandas","html_url":"https://github.com/geopandas","followers_url":"https://api.github.com/users/geopandas/followers","following_url":"https://api.github.com/users/geopandas/following{/other_user}","gists_url":"https://api.github.com/users/geopandas/gists{/gist_id}","starred_url":"https://api.github.com/users/geopandas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geopandas/subscriptions","organizations_url":"https://api.github.com/users/geopandas/orgs","repos_url":"https://api.github.com/users/geopandas/repos","events_url":"https://api.github.com/users/geopandas/events{/privacy}","received_events_url":"https://api.github.com/users/geopandas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geopandas/geopandas","description":"Python tools for geographic data","fork":false,"url":"https://api.github.com/repos/geopandas/geopandas","forks_url":"https://api.github.com/repos/geopandas/geopandas/forks","keys_url":"https://api.github.com/repos/geopandas/geopandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geopandas/geopandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geopandas/geopandas/teams","hooks_url":"https://api.github.com/repos/geopandas/geopandas/hooks","issue_events_url":"https://api.github.com/repos/geopandas/geopandas/issues/events{/number}","events_url":"https://api.github.com/repos/geopandas/geopandas/events","assignees_url":"https://api.github.com/repos/geopandas/geopandas/assignees{/user}","branches_url":"https://api.github.com/repos/geopandas/geopandas/branches{/branch}","tags_url":"https://api.github.com/repos/geopandas/geopandas/tags","blobs_url":"https://api.github.com/repos/geopandas/geopandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geopandas/geopandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geopandas/geopandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/geopandas/geopandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geopandas/geopandas/statuses/{sha}","languages_url":"https://api.github.com/repos/geopandas/geopandas/languages","stargazers_url":"https://api.github.com/repos/geopandas/geopandas/stargazers","contributors_url":"https://api.github.com/repos/geopandas/geopandas/contributors","subscribers_url":"https://api.github.com/repos/geopandas/geopandas/subscribers","subscription_url":"https://api.github.com/repos/geopandas/geopandas/subscription","commits_url":"https://api.github.com/repos/geopandas/geopandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/geopandas/geopandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/geopandas/geopandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/geopandas/geopandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/geopandas/geopandas/contents/{+path}","compare_url":"https://api.github.com/repos/geopandas/geopandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geopandas/geopandas/merges","archive_url":"https://api.github.com/repos/geopandas/geopandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geopandas/geopandas/downloads","issues_url":"https://api.github.com/repos/geopandas/geopandas/issues{/number}","pulls_url":"https://api.github.com/repos/geopandas/geopandas/pulls{/number}","milestones_url":"https://api.github.com/repos/geopandas/geopandas/milestones{/number}","notifications_url":"https://api.github.com/repos/geopandas/geopandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geopandas/geopandas/labels{/name}","releases_url":"https://api.github.com/repos/geopandas/geopandas/releases{/id}","deployments_url":"https://api.github.com/repos/geopandas/geopandas/deployments","created_at":"2013-06-27T17:03:47Z","updated_at":"2017-08-02T16:33:10Z","pushed_at":"2017-08-03T15:44:09Z","git_url":"git://github.com/geopandas/geopandas.git","ssh_url":"[email protected]:geopandas/geopandas.git","clone_url":"https://github.com/geopandas/geopandas.git","svn_url":"https://github.com/geopandas/geopandas","homepage":"","size":4783,"stargazers_count":786,"watchers_count":786,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":157,"mirror_url":null,"open_issues_count":123,"forks":157,"open_issues":123,"watchers":786,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geopandas/geopandas/pulls/467"},"html":{"href":"https://github.com/geopandas/geopandas/pull/467"},"issue":{"href":"https://api.github.com/repos/geopandas/geopandas/issues/467"},"comments":{"href":"https://api.github.com/repos/geopandas/geopandas/issues/467/comments"},"review_comments":{"href":"https://api.github.com/repos/geopandas/geopandas/pulls/467/comments"},"review_comment":{"href":"https://api.github.com/repos/geopandas/geopandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geopandas/geopandas/pulls/467/commits"},"statuses":{"href":"https://api.github.com/repos/geopandas/geopandas/statuses/60ed39a1b0813655f155b742e128457aabcff49d"}}}} | {
"id": 11002815,
"name": "geopandas/geopandas",
"url": "https://api.github.com/repos/geopandas/geopandas"
} | {
"id": 1020496,
"login": "jorisvandenbossche",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1020496?",
"url": "https://api.github.com/users/jorisvandenbossche"
} | {
"id": 8130715,
"login": "geopandas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8130715?",
"url": "https://api.github.com/orgs/geopandas"
} | 2017-08-03T15:20:23 | 6388559852 | {"actor":{"display_login":"jorisvandenbossche"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/comments/124633283","pull_request_review_id":46941836,"id":124633283,"diff_hunk":"@@ -155,9 +184,29 @@\n },\n \"scrolled\": false\n },\n- \"outputs\": [],\n+ \"outputs\": [\n+ {\n+ \"data\": {\n+ \"image/png\": \"iVBORw0KGgoAAAANSUhEUgAAAasAAALDCAYAAACrXi/HAAAABHNCSVQICAgIfAhkiAAAAAlwSFlz\\nAAALEgAACxIB0t1+/AAAIABJREFUeJzs3Xl8XHW9//HXJ0mTLgktdElLS2kLpa0FZQlXwiJBFkFA\\nvXoFRVmEn+VxXa9XxauI142rV1G8LCq7UOFSFbyyqAWRcLFEpKUsQgtXLDTdF5K2SbPn+/vje04z\\nnSaTSTIz58zM+/l4zGNmzvnmzHcmyzvf7/me79ecc4iIiMRZSdQVEBERGYzCSkREYk9hJSIisaew\\nEhGR2FNYiYhI7CmsREQk9hRWIiISeworERGJPYWViIjEnsJKRERiryzqCuSjSZMmuVmzZkVdjdhp\\nbW1l3LhxUVejYOnzzS59vtm1YsWKbc65ycP9eoXVMMyaNYvly5dHXY3Yqa+vp66uLupqFCx9vtml\\nzze7zOyNkXy9ugFFRCT2FFYiIhJ7CisREYk9hZWIiMSewkpERGJPYSUiIrGnsBIRkdhTWImISOwp\\nrEREJPYUViIiEnsKKxERiT2FlYiIxJ7CSkREYk9hJSIisaewEhGR2FNYiYhI7CmsREQk9hRWIiIS\\neworkXzQ0MDMu++GhoaoayISibKoKyAig2hogJNPZnZXF9x9Nzz2GNTWRl0rkZxSy0ok7urroasL\\nA+jo8M9FiozCSiTu6uqgJPhVNfPPRYqMwkok7mprYeFC/3jUKDj88GjrIxIBhZVIPujtpb26Gtrb\\nYcmSqGsjknMKK5F80NRE0zHHwIIFcNttUddGJOcUViL5oKmJrqoquOwy+POf4eWXo66RSE4prETi\\nrqMD2trorqyECy+EsjK1rqToKKxE4q6pCcCH1ZQp8J73wF13QWdnxBUTyR2FlUjcNTcD0F1V5Z9f\\ndhls2wYPPhhhpURyS2ElEndhyyoMq3e9C6ZPV1egFBWFlUjcBWHVVVnpn5eWwiWXwNKlsG5ddPUS\\nySGFlUjcJZ6zCl16KfT2ws9+Fk2dRHJMYSUSd8ndgABz5sApp8Dtt/vQEilwOQsrM3vdzFw/t4eD\\n/WZmXzezDWbWZmb1ZrYw6RgVZna9mW0zs1Yze8DMZiSV2d/MFpvZjuC22MwmJJWZaWYPBsfYZmbX\\nmVl59j8FkWHoL6zAD7RYs0YT20pRyGXL6lhgWsLtaMABvwj2XwF8Hvh0UHYL8KiZJf6G/gj4APBh\\n4CRgP+AhMytNKHNPcOwzg9vRwOJwZ1D2YaAqOMaHgX8CfpC5tyqSQc3NMG4crixpRZ/3vx/Gj9dA\\nCykKOQsr59xW59ym8Aa8G9gJ/MLMDPgX4LvOufucc38FLsYHygUAZjYeuAz4onPuUefcs8CFwFuB\\n04IyC/ABtcg51+CcawAuB84xs3lBVc4AFgIXOueedc49ig/Kj5vZfrn4LESGpKkJ9t9/3+1jxsBH\\nPgL33ben9SVSqCI5ZxWE02XAz51zbcBsYCrwSFgm2P6/wPHBpmOAUUllGoFVCWVqgRbgqYSXWwa0\\nJpVZFXxtaClQEbyGSLwMFFbguwI7OuCee3JbJ5Eci2qAxen4gLoleD41uN+cVG5zwr6pQA+wbZAy\\nW51zLtwZPN6SVCb5dbYFx56KSNw0NcGECf3vO/poOPJIdQVKwYtqWfuPA884556P6PWHzMwWAYsA\\nqqurqddJ7X20tLToc8mCmsZG2qdOHfDznf6OdzD3uutYfssttMydm/sKFgj9/MZbzsPKzKYA7wU+\\nmbB5U3BfDaxN2F6dsG8TUApMArYmlXkyocxkM7OwdRV0OU5JOs4JSdWaFBx7EwNwzt0M3AxQU1Pj\\n6rRa6z7q6+vR55IF3d1Uzp1LZWVl/5/v294GN91EzfPPw8c/nvPqFQr9/MZbFN2AlwAdwH8nbFuD\\nD4rTww1mNho/Wi88/7QC6EoqMwNYkFCmAajEn5cK1QLjksosSBryfnpQpxXDf1siWZLqnBX4fe9/\\nP9x9N7S15a5eIjmU07AKWjn/D7jXOdcSbg9aQT8CvmRm7zezw4Gf4QdL3BOU2QHcBnzPzE4zs6Pw\\nQ9JfAP4QlFkF/B64ycxqzawWuAl4yDn3SvByjwAvAXeZ2VFmdhrwfeAW59zO7H4CIkPU3Q27dqUO\\nK/ADLZqb4de/zk29RHIs1y2rOmAufQMrEn0PuBa4EViOvxbrDOfcroQy/wL8GliCH+XXApzrnOtJ\\nKHMB8Dx+hN/S4PGF4c6g7NnA7uAYS4D7gC+M+N2JZFow4/qAAyxCp5wCs2droIUUrJyes3LOPQ7Y\\nAPsc8PXgNtDXd+AvGv50ijJNwEcHqcda4JxBKywStfD6qcFaViUl8LGPwde+Bn//u5+OSaSAaG5A\\nkTgLW1aDhRX4mdjN4I47slolkSgorETiLN2WFcBBB/m1rn72M+jpGbS4SD5RWInE2VDCCvxAi3Xr\\n4JFHBi8rkkcUViJxFobVYAMsQu95D0yapIEWUnAUViJxNtSWVXk5XHghPPAAbN06eHmRPKGwEomz\\n5maoqPAzrKfrssugqwsWLx68rEieUFiJxNlgs1f0Z+FCePvbfVdg35zOInlNYSUSZ8MJK/Ctq5df\\nhqefznydRCKgsBKJs1TLg6Ry/vkwdqwGWkjBUFiJxNlwW1b77QfnnQf33gstLYOXF4k5hZVInDU3\\nDy+swHcFtrTAL3+Z2TqJREBhJRJnw21ZAZxwAsybp65AKQgKK5G46u0dWcvKDC69FJYtg9WrM1s3\\nkRxTWInE1c6dfuj5cAZYhC66CEpL4fbbM1cvkQgorETiaqizV/Rn6lQ45xy4805/obBInlJYicTV\\nUJYHSeWyy2DLFnj44ZHXSSQiCiuRuMpEywrgrLNg2jQNtJC8prASiatMhVVZGVx8Mfz2t7Bhw8jr\\nJRIBhZVIXGUqrMCPCuzt9eeuRPJQWdQVEJEBDHUtq1TmzoV3vANuvNGPMDzlFKitHflxRXJELSuR\\nuGpu9sPOKyszc7yTT4b16+Gqq+DUU6GhITPHFckBhZVIXIWzV5hl5nilpf6+txc6O6G+PjPHFckB\\nhZVIXI1kqqX+nHGGvzfzKwrX1WXu2CJZprASiatMh1VtLRx0EBx+ODz2mM5ZSV7RAAuRuBruWlap\\nTJ0KEycqqCTvqGUlEleZblmBX+dqx47MHlMkBxRWInE1khnXBzJ+vMJK8pLCSiSOnMtOy0phJXlK\\nYSUSR62t0N2dnbDauTOzxxTJAYWVSBxlcvaKRPvtB7t2QU9PZo8rkmUKK5E4yuS8gInGj/f3u3Zl\\n9rgiWaawEomjTK1llSwMK523kjyjsBKJo2y3rHTeSvKMwkokjrIdVmpZSZ5RWInEUTYHWIDCSvKO\\nwkokjpqa/ISzYUsoU9SykjylsBKJo+ZmHywlGf4V1TkryVMKK5E4ysbsFaCWleQthZVIHGUrrMaM\\n8YswKqwkzyisROIoG8uDQN95MIWV5BmFlUgcZatlBZofUPKSwkokjrKxPEhILSvJQworkTjKZstK\\nCzBKHlJYicRNe7u/qWUlsofCSiRusjV7RUhhJXlIYSUSN9maFzCkARaShxRWInGTreVBQuE5K+ey\\nc3yRLFBYicRNLlpWPT2we3d2ji+SBQorkbjJRViBzltJXlFYicRNrsJK560kjyisROImDKtMLw8S\\n0ppWkocUViJx09wMlZUwalR2jq9uQMlDCiuRuMnm7BWgsJK8pLASiZtchZXOWUkeUViJxE22w0rn\\nrCQP5TSszGyamd1pZlvNrN3MXjazkxP2uwFuNyaUqe9n/71Jr7O/mS02sx3BbbGZTUgqM9PMHjSz\\nVjPbZmbXmVl59j8FkUFkay2rUFWVv1dYSR4py9ULBWGxDPgTcDawFZgDbEkoNi3py2qAB4FfJG2/\\nA/hKwvO2pP33ADOBM4PntwKLgXODupQCDwPbgZOAicCdgAGfHto7E8mwbC4PAn6l4KoqhZXklZyF\\nFXAFsNE5d1HCtjWJBZxzmxKfm9l7gVedc08kHWt3ctmEr1mAD6kTnXMNwbbLgSfNbJ5z7hXgDGAh\\ncLBzrjEocwVwq5ld6ZxTZ75EJ9vdgKD5ASXv5LIb8H3A02a2xMy2mNlzZvYpM7P+CptZJfAh4JZ+\\ndn8o6Lp7ycyuMbOqhH21QAvwVMK2ZUArcHxCmVVhUAWWAhXAMcN6dyKZ0NUFLS25CSu1rCSP5LJl\\nNQf4BHAt8F3gSOD6YN8N/ZS/ACjHd88lugd4A9iAbx19B3grvrUEMBXY6lzfLJ3OOWdmW4J9YZnN\\nScfdBvQklBHJvWxPYhvSAoySZ3IZViXAcufcl4PnK81sLvBJ+g+rjwO/cc5tTdzonLs54emLZvYa\\n8BczO9o592w2Kg5gZouARQDV1dXU19dn66XyVktLiz6XERrT2MjbgVUbN7I56bPM5Od7RE8Po9at\\n41l9v/bQz2+85TKsNgIvJ21bBXw2uaCZHYkfXPGV5H39WIFvEc0FngU2AZPNzMLWVdDVOCXYR3B/\\nQtJxJgGlCWX2EoTkzQA1NTWurq4ujaoVl/r6evS5jNDTTwOw4PjjWZD0WWb08509G1au1PcrgX5+\\n4y2X56yWAfOSth2G79JLtgg/+OIPaRz3CHzIbAyeNwCV+PNSoVpgHH3nsRqABWY2I6HM6UAHPvxE\\nopGrbkCds5I8k8uwuhY4zsyuNLNDzeyDwGeAGxMLmdlY4CPAbYnnnYJ9h5jZ18ysxsxmmdm7gXuB\\nlfgwxDm3Cvg9cJOZ1ZpZLXAT8FAwEhDgEeAl4C4zO8rMTgO+D9yikYASqWzPuB7SOSvJMzkLK+fc\\nM/gRgecBfwWuBq4CfpxU9Hx8K+iOfg7TCZyKH7n3CnAdPnhOc871JJS7AHg+KLc0eHxhQl168Nd6\\n7caH3BLgPuALI3mPIiOWq7AaPx7a26GzM7uvI5IhuTxnhXPuYfzFuKnK3EH/QUUw1Pzk/vYllWsC\\nPjpImbXAOYMdSySnwrDK5gwWsPf8gJMmZfe1RDJAcwOKxElTE4we7W/ZpJnXJc8orETiJNtTLYU0\\nma3kGYWVSJzkYqolUMtK8o7CSiROch1Wmh9Q8oTCSiROsr08SEgtK8kzCiuROMlVy0rnrCTPKKxE\\n4iRXAyzUspI8o7ASiYveXh8euQir8nI/PF7nrCRPKKxE4mLHDnAuN2EFmh9Q8orCSiQucjXVUkjz\\nA0oeUViJxEWuploKqWUleURhJRIXuVoeJDR+vM5ZSd5QWInERa67AdWykjyisBKJC4WVyIAUViJx\\noQEWIgNSWInERVMTlJXB2LG5eb3x42HXLn99l0jMKaxE4iKcvcIsN68XzmKxa1duXk9kBBRWInGR\\nq3kBQ5pySfKIwkokLnIdVprMVvKIwkokLtSyEhmQwkokLnK1llVICzBKHlFYicRFrpYHCallJXlE\\nYSUSB87pnJVICgorkThoaYGeHrWsRAagsBKJg1zPXgH+4uPSUp2zkrygsBKJg1wvDwL+4mPNDyh5\\nQmElEgdRtKxA8wNK3lBYicRBrteyCqllJXlCYSUSB1G1rLQAo+QJhZVIHEQZVmpZSR5QWInEQVOT\\nH/BQVZXb19U5K8kTCiuROAinWirJ8a+kWlaSJxRWInGQ66mWQuE5K+dy/9oiQ6CwEomDXE+1FBo/\\nHrq7oa0t968tMgQKK5E4iDKsQF2BEnsKK5E4iCqsNJmt5AmFlUgc5Hotq5DWtJI8obASiYMoB1iA\\nWlYSeworkai1tUFHh8JKJAWFlUjUopq9AnTOSvKGwkokalGGlc5ZSZ5QWIlELYq1rELh9E5qWUnM\\nKaxEohbV8iDgVwquqlJYSewprESiFmU3IGgyW8kLCiuRqEUdVlrTSvKAwkokamFYhYMdck0zr0se\\nUFiJRK2pyZ83KiuL5vUVVpIHFFYiUYtq9oqQzllJHlBYiUQtqklsQzpnJXlAYSUStTiElVpWEnMK\\nK5GoxSGs2tqgqyu6OogMQmElErWolgcJaX5AyQMKK5GoRT3AQvMDSh5QWIlEqasLWlvjEVZqWUmM\\nKaxEohT17BWgsJK8kNOwMrNpZnanmW01s3Yze9nMTk7Y/zMzc0m3Pycdo8LMrjezbWbWamYPmNmM\\npDL7m9liM9sR3Bab2YSkMjPN7MHgGNvM7DozK8/uJyCSRGElkpacXTIfhMUy4E/A2cBWYA6wJano\\nH4ALE553Ju3/EfBe4MPAduCHwENmdoxzricocw8wEzgzeH4rsBg4N6hLKfBw8PUnAROBOwEDPj2S\\n9ykyJFEuDxIKB1jonJXEWC7nd7kC2Oicuyhh25p+ynU45zb1dwAzGw9cBnzMOfdosO1C4A3gNGCp\\nmS3Ah9SJzrmGoMzlwJNmNs859wpwBrAQONg51xiUuQK41cyudM7pt1ZyI8rlQUJqWUkeyGU34PuA\\np81siZltMbPnzOxTZmZJ5U4M9r9qZreY2ZSEfccAo4BHwg1B2KwCjg821QItwFMJX7cMaE0qsyoM\\nqsBSoCJ4DZHcUDegSFpy2bKaA3wCuBb4LnAkcH2w74bg/vfA/fgW1yzg28Afgy6+DmAq0ANsSzr2\\n5mAfwf1W55wLdzrnnJltSSqzOekY24JjT6UfZrYIWARQXV1NfX19Ou+5qLS0tOhzGaIDn36aw4Bl\\nL79M16Z+OxT2yObne1J5OetffJG/F/H3Tz+/8ZbLsCoBljvnvhw8X2lmc4FPEoSVc+7ehPIvmtkK\\nfBff2fgQi4xz7mbgZoCamhpXV1cXZXViqb6+Hn0uQ7RsGQAnnH02VFSkLJrVz3fCBGZOmMDMIv7+\\n6ec33nLZDbgReDlp2yr8QIh+Oec2AOuAucGmTUApMCmpaHWwLywzObF7MXg8JalMddIxJgXHTv3v\\nrUgmNTXBmDGDBlXWaX5AiblchtUyYF7StsPwLad+mdlkYDo+6ABWAF3A6QllZgAL6DtH1QBU4s9L\\nhWqBcUllFiQNeT8d6AheQyQ3op4XMKSwkpjLZVhdCxxnZlea2aFm9kHgM8CNAGZWaWbXmFmtmc0y\\nszrgAfzQ9l8DOOd2ALcB3zOz08zsKPyQ9BfwQ95xzq3Cn/u6KThWLXAT8FAwEhD8AI2XgLvM7Cgz\\nOw34PnCLRgJKTkU91VJIYSUxl7Owcs49gx8ReB7wV+Bq4Crgx0GRHuAI4DfAq/jrnl4Bap1zuxIO\\n9S/48FqCb621AOcmXGMFcAHwPH6E39Lg8Z5rt4KyZwO7g2MsAe4DvpCxNyySjri0rLQAo8RcTtfR\\nds49jL8Yt799bcC70jhGB/7C3QEv3nXONQEfHeQ4a4FzBns9kaxqaoKDDoq6FlqAUWJPcwOKRCku\\nLSt1A0rMKaxEohT1Wlah8eNh1y7o7Y26JiL9GrQbMJi+6MPAyfgLdcfg5/V7FvgdcF/QNSciQ9HT\\n47ve4tCy2m8/cM4HVjijhUiMDNiyMrOjzewPwErgBPyw72uAr+AHPzj8IIkNZvYlM4v4QhGRPBN2\\nu8UhrLQAo8RcqpbVr/HDuT8YDFjoVzA0/HP4kXRXZ7Z6IgUsDvMChhLnB4zDgA+RJKnCaq5zLnl5\\njn0EM5s3aC0okSGKa1iJxNCA3YDOuU4z+2PyooWpymeuWiJFIA5rWYXCNa0UVhJTg40GrAPUYhLJ\\nhjisZRXSOSuJOQ1dF4mKugFF0pbODBYzzGx0qgLBbBAiMhQKK5G0pRNWz6TYZ/gh7KWZqY5IEWlq\\ngvJyv0RI1MaOhdJShZXEVjphdRawPdsVESk64ewVfUuvRcfMD7LQOSuJqXTC6jnn3Jas10Sk2MRl\\neZCQ5geUGNMAC5GoxGUS25DCSmJssLB6A7/OlIhkmsJKJG0pw8o5N9s5p/NVItkQt7DSOSuJsbS6\\nAc3sADP7iZm9ambNZrYz8ZbtSooUpLgsDxJSy0piLN2Vgm8DjgJuBjbgh6uLyHA5pwEWIkOQblid\\nCpzunHs6m5URKRrhQodxDCvn4jGcXiRBuqMBtwAt2ayISFGJ0+wVof32g+5uaG+PuiYi+0g3rK4E\\nvmlmldmsjEjRiGNYacolibF0uwG/il/SfouZvQF0Je50zr01w/USKWxxWh4klBhWU6dGWxeRJOmG\\n1a+yWguRYhOn5UFCallJjKUVVs65b2S7IiJFJY7dgOECjLrWSmJowHNWZkMbDjTU8iJFLY5hpZaV\\nxFiqARarzeyjZlaR6gBmtsDMbgH+LbNVEylgTU1+SY6qqqhr0kdhJTGWqhtwEfA94AYzewxYjr8g\\nuB3YH3gLcCJwGHAdcEN2qypSQOK0PEhIYSUxNmBYOeeeAN5uZscDHwbOBw4GxgDbgJXA7cDPnXPN\\nOairSOFobo7XSEDoa+XpnJXE0KADLJxzTwFP5aAuIsUjbpPYgu+WrKxUy0piSetZiUQhjmEFmh9Q\\nYkthJRIFhZXIkCisRKIQ17DSmlYSUworkVxzLn5rWYXUspKYUliJ5FpbG3R1xbNlpbCSmFJYieRa\\nHGevCCmsJKYGHLpuZr2kuSKwc640YzUSKXRxDyuds5IYSnWd1Xn0hVU18E3g10BDsK0WeB/w71mr\\nnUghinNY7bcf7N7tuylHjYq6NiJ7pJrBYs+yIGb2APBl59wtCUVuN7O/4APrx9mrokiBieNaVqFw\\nyqWdO2HixGjrIpIg3XNW7wQe72f740BdxmojUgziuJZVSPMDSkylG1bbgH/qZ/s/AVszVx2RIhDn\\nbkCFlcRUuisFfw24w8xOoe+c1XHAacBl2aiYSMEKwyoMhjgJF2D8yU/gYx+D2tpo6yMSSKtl5Zy7\\nCzge38J6T3DbDpzgnLsze9UTKUBNTT6oSmM4iPaNN/z9bbfBqadCQ0Pq8iI5km7LCufc08BHslgX\\nkeIQ19krAP76V3/f2wudnVBfr9aVxEKqZe0PSPeWywqL5L3m5nierwI45RR/X1IC5eVQVxdpdURC\\nqVpW2xj8omALysSwP0MkpuI6iS30hdUZZ8DXvqZWlcRGqrA6JWe1ECkmTU0wb17Utejf2LFgBsce\\nq6CSWBlsWXsRybQ4t6zM/GrBu3ZFXRORvaQ9ka2ZVZvZF8zsJ2Y2Kdh2gpnNzl71RApQnAdYAFRV\\nKawkdtIKKzM7BngFPxrwMiC4GIPTgauzUzWRAtTR4ZcIiWvLCnxYtbREXQuRvaTbsroG+C/n3FFA\\nR8L2pcAJGa+VSKGK81RLIXUDSgylG1bHAP1d/LsRPyO7iKQjzlMthdQNKDGUbli1Af39ds0HtmSu\\nOiIFTmElMizphtVvgH83s4rguTOzWcB/AvdloV4ihSnOy4OEdM5KYijdsPoCcAB+hvWxwJ+AvwHN\\nwFezUzWRAqRzViLDktbcgM65ncCJZvZO4Gh8yD3rnPtDNisnUnDUDSgyLGlfZwXgnPujc+4a59z3\\nhhNUZjbNzO40s61m1m5mL5vZycG+UWb2n2b2gpm1mtlGM7vHzGYmHaPezFzS7d6kMvub2WIz2xHc\\nFpvZhKQyM83sweC1tpnZdWZWPtT3JDIk+RJWu3dDT0/UNRHZY8CWlZn9K/Bj51x78HhAzrkfDvZC\\nQVgsw3chno3vUpxD3wCNsfhW29XAc8B44AfA783src657oTD3QF8JeF5W9LL3QPMBM4Mnt8KLAbO\\nDepSCjyMX+bkJGAifrSjAZ8e7L2IDFtTE4wbB6NGRV2TgVVV+fvW1r71rUQilqob8NP4P+DtpP4D\\n7oBBwwq4AtjonLsoYduaPQdxbgf+IuM9zOxy4CVgAfBiwq7dzrlN/b2ImS3Ah9SJzrmGhOM8aWbz\\nnHOvAGcAC4GDnXONQZkrgFvN7Mqg21Mk8+I81VKostLf79qlsJLYGLAb0Dk32zm3PeHxQLc5ab7W\\n+4CnzWyJmW0xs+fM7FNmZim+JvxNaUra/qGg6+4lM7vGzKoS9tUCLcBTCduWAa34BSTDMqvCoAos\\nBSrw15SJZEdzc7xHAkJfy0rnrSRGUnUD9gDTnHNbzOx24LPOuZH89M4BPgFcC3wXOBK4Pth3Qz+v\\nX47vBnzQObcuYdc9wBvABnzr6DvAW/GtJYCpwFbn3J7lTZxzzsy2BPvCMpuTXnIb0JNQJrk+i4BF\\nANXV1dTX1w/6hotNS0uLPpdBvG3NGqykhOeG8Tnl6vOd+PrrHAGseOIJdm3qtwOjIOnnN95SdQO2\\nAZX4c0oXA18CRhJWJcBy59yXg+crzWwu8EmSwsrMyoCfAxOA9yTuc87dnPD0RTN7DfiLmR3tnHt2\\nBPVLKXjdmwFqampcnRal20d9fT36XAbhHMyaNazPKdef7zGHHVZUiy/q5zfeUoXVU8D/mNkK/MCD\\n68wseSADAM65S9N4rY3Ay0nbVgGfTdwQBNV/A0cAdWFXZAor8C2iucCzwCZgsplZ2LoKuhqnBPsI\\n7pPnNJyEX0SyeP6VlNxraoIjj4y6FqmpG1BiKNXQ9Qvx53Em4AdRTAQmD3BLxzIgecW5w/BdeoAf\\nvg4swXfrnTLQIIokR+BDZmPwvAHfIkxcOa4WGEffeawGYIGZzUgoczp+kt4V6bwZkWHJhwEWCiuJ\\noVSLL24GvghgZmuAD6fRyknlWuApM7sSH0hHAZ8hGIIetKh+CRyLH2LuzCw8f7TDOddmZofglyn5\\nLf4c01vw57VW4sMQ59wqM/s9cFNwngngJuChYCQgwCP4UYZ3mdnn8UH8feAWjQSUrOnu9gGQLwMs\\nNOWSxEhaFwUnjgwcLufcM/gRgecBf8VfT3UV8OOgyAzgvcCB+NbNxoTb+UGZTuBUfIvvFeA6fPCc\\n5pxLvILxAuD5oNzS4PGFCXXpwV/rtRsfckvwcxx+YSTvUSSlHTv8fdxbVolD10ViIq3pljLFOfcw\\n/mLc/va9jj83lurrG4GT03idJuCjg5RZC5wz2LFEMiYfZq8Af9EyKKwkVoY03ZKIjEC+hFVJiSaz\\nldhRWInkSr6EFWiZEIkdhZVIruTDWlYhtawkZtIKKzM7OZwdvZ/t78h8tUQKUD6sZRXSMiESM+m2\\nrK6lb56+RPsF+0RkMOoGFBm2dMNqHnvPeh76K/te6Csi/WlqgooKGDMm6poMTt2AEjPphlUb/vqn\\nZNPx1z59T4RyAAAgAElEQVSJyGDyYfaKkLoBJWbSDaulwH+a2Z7fNDM7AD/j+dJsVEyk4DQ15cfg\\nClBYSeyke1HwF4D/BV43sxeCbW/Fz8h+/oBfJSJ9mpvzq2Wlc1YSI2mFlXNuo5m9DT8vXzhl9J3A\\nPc653dmqnEhBaWqC6uqoa5GeykofVr29/iJhkYilPd1SEEq3ZLEuIoWtqQnmz4+6FukJJ7Ntbe17\\nLBKhVCsFvx+/Sm9X8HhAzrn7M14zkUKTbwMswJ+3UlhJDKRqWf0Kv8T7luDxQBx+PSkRGUhvrz9n\\nlS8DLMKZ13XeSmIi1XpWJf09FpFh2LXLL2mfjy0rkRhId7qldwSLIyZvL9V0SyJpyKfZK0BhJbGT\\nbovpceCAfrZPCPaJSCr5GlbqBpSYSDesDH9uKtlEoDVz1REpUPkWVlotWGIm5dB1M3sgeOiAn5tZ\\nR8LuUuBw4Kks1U2kcORbWKkbUGJmsOustgf3BjTh5wgMdQJ/QtdeiQwuXB4kX0YDKqwkZlKGlXPu\\nYwBm9jpwjXNOXX4iw5FvLatx4/y9zllJTKR1zso59w3nXKuZ1ZjZ+WY2DsDMxvU3SlBEkjQ1QWlp\\n37mguCsthbFj1bKS2EgraMysGvgN8A/481dzgb8DPwTagc9mq4IiBSGcvcIs6pqkTzOvS4wMZaXg\\nzfjRf4kT1/4SOCPTlRIpOPk01VJIYSUxkm4X3qnAqc65Jtv7P8PXgJkZr5VIocmnqZZC4czrIjGQ\\nbstqDP2vCDwZ3w0oIqmoZSUyIumG1f8ClyQ8d2ZWCnwJeCzTlRIpOAorkRFJtxvwCuAJMzsWqAB+\\nACwExgMnZKluIoUjX8Pqb3+LuhYiQPpD118GjsDPVvEIMBo/uOIo59xr2aueSAFwLj/DSuesJEaG\\nslLwJuDfs1gXkcK0ezd0d+ffAAt1A0qMpB1WZjYWOBKYQlKLTCsFi6SQb7NXhKqqfMvKufy6PkwK\\nUroXBZ8G/Df+OqtkWilYJJV8DivnfMswnH5JJCLpjgb8L+BhYIZzriTppqASSSVfw0rLhEiMpBtW\\ns4BvOec2ZLEuIoUpX8NKM69LjKQbVsuAedmsiEjByrflQUIKK4mRdAdY/BS4xswOBF4EuhJ3Ouee\\nzXTFRApGvraswm5ADV+XGEg3rH4V3N/czz4NsBBJpanJj6YbPz7qmgyNWlYSI+mG1eys1kKkkDU1\\n+aAqSbfXPSYUVhIjaYWVc+6NbFdEpGDl4+wVoLCSWEn3OquLBtjl8LOu/805tzJjtRIpJE1N+Te4\\nAnTOSmIl3W7AG4FyYBTQG2wroW+gxSgzWwmc6ZzbmtkqiuS55ub8bFnpOiuJkXQ70f8JWImfYX10\\ncDsBWAG8HzgKMPwy9yKSKF+7AcvKYMwYhZXEQrotqx8Clzrnnk7Y1mBm/wrc4ZxbYGafBxZnvIYi\\n+S5fwwr65gcUiVi6Las5wO5+tu/Gz24BsAbI099IkSzK57CqrFTLSmIh3bD6C/BDM5sabggeXwOE\\nra25wLrMVk8kz7W3+1s+DrAALRMisZFuWP0/4EBgrZm9bmavA2uDbf8vKDMO+HbGayiSz8Kplp5+\\nGhoaoq3LcCisJCbSvc7q/8zscOAM+uYIXA086pxzQZn/yU4VRfLY44/7+4cegkcfhcceg9raaOs0\\nFJWVsH171LUQGdJKwQ5YGtxEJB1hWPX2Qmcn1NfnV1hVVcHrr0ddC5EhrRS8P3AWMBN/zdUezrlv\\nZrheIoXhwAP9fWkplJdDXV2k1RkydQNKTKQ7g8Vx+MUXO4DJwHpgWvD8dUBhJdKf0aP9/VVXwRln\\n5FerChRWEhvptqy+D9wNfBbYCbwTaMUvdX9bdqomUgAaG/2w9X//96hrMjyVlf46K+f8zPEiEUl3\\nNOBbgRuC81Y9QIVzbjPwJeDrWaqbSP5rbISDDoq6FsNXVeXPt7W1RV0TKXLphlVnwuPNwMHB4xb8\\n8HUR6U8hhBWoK1Ail25YPQscGzyuB75tZhcD1wEvZKFeIoWhUMJKUy5JxNINqyuBDcHjrwJbgevx\\n0ystykK9RPLf7t3+GqV8DivNvC4xke5FwcsTHm/FD2EXkVTWBbOP5XNYqRtQYiKn62yb2TQzu9PM\\ntppZu5m9bGYnJ+w3M/u6mW0wszYzqzezhUnHqDCz681sm5m1mtkDZjYjqcz+ZrbYzHYEt8VmNiGp\\nzEwzezA4xjYzu87M9rp+TGREGhv9vcJKZMRStqzM7IF0DuKce89gZYKwWAb8CTgb35U4B9iSUOwK\\n4PPAJcArwNeAR81snnMu/G35EfBe4MPAdvzyJQ+Z2THOuZ6gzD34i5fPDJ7fil++5NygLqX468a2\\nAycBE4E78WtyfTqd9ywyqEIIK60WLDExWDfgOcAb+EEVI3UFsNE5d1HCtjXhAzMz4F+A7zrn7gu2\\nXYwPswuAm8xsPHAZ8DHn3KNBmQuDOp4GLDWzBfiQOtE51xCUuRx4Mgi9V/BzHC4EDnbONQZlrgBu\\nNbMrnXM7M/B+pdiFYTVjRupycaaWlcTEYN2A3wcqgHcArwFXOec+lnxL87XeBzxtZkvMbIuZPWdm\\nnwpCCmA2MBV4JPwC51wb8L/A8cGmY4BRSWUagVUJZWrxQ+qfSnjtZfiLmBPLrAqDKrA0eK/HpPl+\\nRFJrbIQpU6CiIuqaDJ/CSmIiZcvKOfclM/sKvtvuUuBKM6vHz1rxG+dc1xBeaw7wCeBa4LvAkfgR\\nhQA34IMK/HVciTYD04PHU/EXJW/rp8zUhDJbw9ngg/fhzGxLUpnk19kWHHsq/TCzRQQjH6urq6mv\\nrx/gbRavlpYWfS4Jjnj+econTGBFhj6TKD5f6+7mZGDNCy/wRoF/b/XzG2+DjgYMzgM9ADwQLLh4\\nEX7dqh+b2RznXLqd2SXAcufcl4PnK81sLvBJfFjFmnPuZuBmgJqaGleXbxOS5kB9fT36XBK0tsJb\\n3pKxzySyz7eigtmTJzO7wL+3+vmNt6GOBhwHTAAq8V1tLnXxvWwEXk7atgo/EAJgU3BfnVSmOmHf\\nJqAUmDRImckJ3Yvh+bApSWWSX2dScOxNiGRCvl8QHNJkthIDg4aVmY0xs4vN7H+BF/FTLV3snJvj\\nnGsdwmsto2/hxtBh+MER4AdbbAJOT3jt0fjReuH5pxVAV1KZGcCChDIN+DBNnN66Fh+0iWUWJA15\\nPx0/i/yKIbwnkf7t3OlvCiuRjBhs6PotwHnA/+HPU73HOdc8zNe6FnjKzK4ElgBHAZ8BvgJ7ziv9\\nCPiKma0GXsXPltGCH4qOc26Hmd0GfC84BxUOXX8B+ENQZpWZ/R4/ejCcXeMm4KFgJCD4ARovAXeZ\\n2efxQ9e/D9yikYCSEYUwbD1UVaWh6xK5wc5ZXQasxXfhnQWcZf0sE5DOdVbOuWfM7H3AfwBXBce9\\nCvhxQrHvAWOAG/FTOT0NnJFwjRX44e3d+MAbAzwGXJRwjRX4oe7X07eq8QPApxLq0mNmZwevvQxo\\nwy+B8sXB3odIWgoprCor1bKSyA0WVncxtPNSKTnnHsZfjDvQfodfcuTrKcp04C/cHfDiXedcE/DR\\nQeqyFn8dmUjmFVJYVVVBU1PUtZAiN9jQ9UtyVA+RwtLYCCUlfcva57OqKli7NupaSJHL6dyAIkWj\\nsRGmTYOydBfjjrFwtWCRCCmsRLKhUIatg0YDSiworESyoRDDymXs9LXIkCmsRDLNucILq54eaG+P\\nuiZSxBRWIpn25pvQ1lY4YaVlQiQGFFYimVZIw9ZBM69LLCisRDJNYSWScQorkUwrtLBSN6DEgMJK\\nJNMaG2HUKKhOntg/T6llJTGgsBLJtMZGmD7dz2BRCBRWEgMF8tskEiOFNGwdFFYSCworkUwrtLDS\\nOSuJAYWVSCb19sK6dYUVVmpZSQworEQyacsW6OoqrLAqL/c3hZVESGElkkmFNmw9pMlsJWIKK5FM\\nKtSw0jIhEjGFlUgmhWE1c2a09cg0tawkYgorkUxqbIQxY+CAA6KuSWYprCRiCiuRTFq71ncBmkVd\\nk8xSN6BETGElkkmFdo1VSC0riZjCSiSTFFYiWaGwEsmU7m7YuFFhJZIFCiuRTNmwwc9gUYhhpXNW\\nEjGFlUimFOo1VuBbVl1d0NERdU2kSCmsRDKl0MMK1BUokVFYiWSKwkokaxRWIpnS2Aj77edvhUbL\\nhEjEFFYimVKow9ZBLSuJnMJKJFMUViJZo7ASyZRCDit1A0rEFFYimdDR4RdeLNSwUstKIqawEsmE\\ndev8vcJKJCsUViKZUMjD1kFhJZFTWIlkQqGHVXk5lJXpnJVERmElkglhWM2YEW09ssVMk9lKpBRW\\nIpnQ2AgTJ8LYsVHXJHsUVhIhhZVIJhTysPWQwkoipLASyYRiCCstEyIRUliJZEIxhJVaVhIhhZXI\\nSLW2QlOTwkokixRWIiNV6MPWQ+oGlAgprERGqljCSi0riZDCSmSkFFYiWaewEhmpxkZ/0ez06VHX\\nJLuqqqCz099EckxhJTJSjY1QXe2nJCpkWiZEIqSwEhmpYhi2DprMViKlsBIZKYWVSNYprERGwjmF\\nlUgOKKxERmLHDn8OpxjCSuesJEIKK5GRKJZh66CWlURKYSUyEgorkZxQWImMRDGFVdgNqLCSCCis\\nREaisRFKS2HatKhrkn1hy0rnrCQCCiuRkWhshAMP9IFV6EaP9u9TLSuJQM7Cysy+bmYu6bYpYX/y\\nvvB2Y0KZ+n7235v0Ovub2WIz2xHcFpvZhKQyM83sQTNrNbNtZnadmRX49AOSFcUybB38lFKaH1Ai\\nUpbj13sFqEt43pPwOLkfpQZ4EPhF0vY7gK8kPG9L2n8PMBM4M3h+K7AYOBfAzEqBh4HtwEnAROBO\\nwIBPp/1ORMCH1THHRF2L3NEyIRKRXIdVt3NuU387kreb2XuBV51zTyQV3T3QMcxsAT6kTnTONQTb\\nLgeeNLN5zrlXgDOAhcDBzrnGoMwVwK1mdqVzbucI3p8UE+dg3Tp43/uirknuqGUlEcn1Oas5ZrbB\\nzNaY2b1mNqe/QmZWCXwIuKWf3R8Kuu5eMrNrzKwqYV8t0AI8lbBtGdAKHJ9QZlUYVIGlQAVQRP8i\\ny4ht2wbt7cXTDQgKK4lMLltWTwOXAKuBKcBXgafMbKFzbntS2QuAcnz3XKJ7gDeADfjW0XeAt+Jb\\nSwBTga3OORd+gXPOmdmWYF9YZnPScbfhuySnMgAzWwQsAqiurqa+vj71uy1CLS0tRfW5VL76KjXA\\nX3fsYFsO3nccPt+3dXdTsm4dKwvw+xyHz1cGlrOwcs79LvG5mTUAa4CLgR8mFf848Bvn3NakY9yc\\n8PRFM3sN+IuZHe2cezYL1U5+7ZsBampqXF1dXTZfLi/V19dTVJ/Ljh0AHH7WWVBTk/WXi8Xne9BB\\nsGZN9PXIglh8vjKgyIauO+dagZeAuYnbzexI/OCK/roAk63At4jCY2wCJpuZJRzP8C25TQllqpOO\\nMwkoTSgjMrhiuiA4pG5AiUhkYWVmo4H5wMakXYvwLa4/pHGYI/AhEx6jAajEn5cK1QLj6DuP1QAs\\nMLMZCWVOBzrw4SeSnsZGv+Di5MlR1yR3FFYSkZx1A5rZNfih6GvxLZ2r8CFyZ0KZscBHgO8lnncK\\n9h0S7Pst/hzTW4AfACvxgyhwzq0ys98DNwXnmABuAh4KRgICPIJv0d1lZp/HD13/PnCLRgLKkDQ2\\nwowZUFJE19ZXViqsJBK5/C2bAfw3/lqr+/EtmeOcc28klDkfH2B39PP1ncCp+JF7rwDX4YPnNOdc\\n4vVaFwDPB+WWBo8vDHcGZc8GduNDbglwH/CFEb9DKS7FdEFwqKoKOjqgqyvqmkiRyeUAiw+lUeYO\\n+g8qgqHmJ6dxjCbgo4OUWQucM9ixRFJqbISTToq6FrmVOD/g/vtHWxcpKkXUfyGSQT09sH59cbas\\nQF2BknMKK5Hh2LwZuruLL6y0WrBERGElMhxr1/r7YgsrtawkIgorkeEoxmusQGElkVFYiQxHsYaV\\nVguWiCisRIajsRHGji2+EXFaLVgiorASGY7wGqu+mb2Kg7oBJSIKK5HhKMYLgkFhJZFRWIkMR7GG\\n1ZgxfnophZXkmMJKZKg6O2HTpuIMKzMtbS+RUFiJDNWGDX5J+5kzo65JNDTzukRAYSUyVMU6bD2k\\nsJIIKKxEhqrYw0rdgBIBhZXIUBV7WKllJRFQWIkMVWMjTJjQN5tDsVFYSQQUViJDVazD1kNaLVgi\\noLASGapiD6uqKp2zkpxTWIkMlcJKLSvJOYWVyFC0tcG2bQqrtja/+KRIjiisRIZi3Tp/X8xhtW2b\\nv//jH6OthxQVhZXIUBT7sPWGBvjpT/3j977XPxfJAYWVyFAUe1jV10NPj3/c1eWfi+SAwkpkKMKw\\nmjEj2npEpa4ORo3yj0tL/XORHFBYiQxFYyNMngyjR0ddk2jU1sLvfucfX3SRfy6SAworkaEo9mHr\\nAKecAgcfDLt3R10TKSIKK5GhUFh58+bBK69EXQspIgorkaFQWHnz58Pq1X5dL5EcUFiJpGvXLtix\\nQ2EFPqxaW2H9+qhrIkVCYSWSrmIftp5o/nx/v3p1tPWQoqGwEkmXwqrPvHn+XuetJEcUViLpUlj1\\nmTbNzxGolpXkiMJKJF2NjWAGBx4YdU2iZ9Y3yEIkBxRWIulqbPQtinAGh2KnsJIcUliJpEvD1vc2\\nb56fhV4LMUoOKKxE0qWw2ls4IvDVV6OthxQFhZVIOpxTWCXT8HXJIYWVSDqamvxceAqrPoceCiUl\\nCivJCYWVSDo0bH1fFRUwe7autZKcUFiJpENh1T+NCJQcUViJpENh1b/58/0Ai3D1YJEsUViJpKOx\\nEcrKoLo66prEy/z50N4Oa9dGXRMpcAorkXQ0NsL06X4pd+kTjgjUeSvJMoWVSDo0bL1/4YS2Om8l\\nWaawEkmHwqp/kybBAQcorCTrFFYig+nt9dMKKaz2pQltJUcUViKD2boVOjsVVgOZP1/nrCTrFFYi\\ng9Gw9dTmzYNNm6C5OeqaSAFTWIkMRmGVmkYESg4orEQGo7BKTRPaSg4orEQG09gIo0f7kW+yr9mz\\n/YKUallJFimsRAbT2AgzZviRb7KvUaPgkEPUspKsUliJDGbtWnUBDkbD1yXLFFYig9EFwYObPx/+\\n9jfo7o66JlKgFFYiqXR3w4YNCqvBzJ8PXV2wZk3UNZECpbASSWXjRj+DhcIqNc0RKFmWs7Ays6+b\\nmUu6bUrY/7N+9v856RgVZna9mW0zs1Yze8DMZiSV2d/MFpvZjuC22MwmJJWZaWYPBsfYZmbXmVl5\\ndj8ByUsatp4ehZVkWVmOX+8VoC7hefKKbX8ALkx43pm0/0fAe4EPA9uBHwIPmdkxzrnwWPcAM4Ez\\ng+e3AouBcwHMrBR4OPj6k4CJwJ2AAZ8e5vuSQqWwSs/++/u1vhRWkiW5Dqtu59ymFPs7BtpvZuOB\\ny4CPOeceDbZdCLwBnAYsNbMF+JA60TnXEJS5HHjSzOY5514BzgAWAgc75xqDMlcAt5rZlc65nRl5\\np1IYFFbp0xyBkkW5Pmc1x8w2mNkaM7vXzOYk7T/RzLaY2atmdouZTUnYdwwwCngk3BCEzSrg+GBT\\nLdACPJXwdcuA1qQyq8KgCiwFKoLXEOnT2AiVlTB+fNQ1ib9589SykqzJZcvqaeASYDUwBfgq8JSZ\\nLXTObQd+D9wPrAFmAd8G/hh08XUAU/HdhtuSjrs52Edwv9U558KdzjlnZluSymxOOsa24NhTGYCZ\\nLQIWAVRXV1NfX5/u+y4aLS0tBfe5LFy5krETJ/LME09EXZXYf74zyso4dPt2lv3mN3TlYbjH/fMt\\ndjkLK+fc7xKfm1kDPpguBn7onLs3YfeLZrYC38V3Nj7EIuWcuxm4GaCmpsbV1dVFW6EYqq+vp+A+\\nl7Y2mDcvFu8r9p9vWxv8+MecMHEinHhi1LUZsth/vkUusqHrzrlW4CVg7gD7NwDrEvZvAkqB5Ana\\nqoN9YZnJZn3z4gSPpySVqU46xqTg2KnOp0kx0gXB6dPs65JFkYWVmY0G5gMbB9g/GZiesH8F0AWc\\nnlBmBrCAvnNUDUAl/rxUqBYYl1RmQdKQ99OBjuA1RLyODti8WWGVrpkzoaJC560kK3J5ndU1Znay\\nmc02s7cDv8KHyJ1mVhnsrzWzWWZWBzwAbAF+DeCc2wHcBnzPzE4zs6PwQ9JfwA95xzm3Cn/u66bg\\nWLXATcBDwUhA8AM0XgLuMrOjzOw04PvALRoJKHtZv97fK6zSU1oKhx2Wdlg1NMB3vuPvRQaTywEW\\nM4D/xne5bQX+DBznnHvDzMYARwAXARPwranHgfOcc7sSjvEvQDewBBgDPAZclHCNFcAFwPX4EX7g\\nQ+9T4U7nXI+ZnQ38GD9SsA24G/hiRt+t5D8NWx+6+fNh5coBd/f0wNNPw803w113+W2jR8Njj0Ft\\n7YBfJpLTARYfSrGvDXhXGsfowF+4O+DFu865JuCjgxxnLXDOYK8nRU5hNXTz58P99/PnJzp4/KkK\\n6urg0ENh6VL47W/9/Ztv+tVWwjG7nZ1QX6+wktRyfVGwSP5QWA3dvHnQ08M/n/Eaz3e9BTM/tSLA\\nlClw7rnw7nf7y9be/W6/r7wcNAhPBqOwEhlIY6OfRmjcuKhrkje6Dp3PKGB252qe4y04B6ed5s9N\\nHX00lCScJa+p8fMEL1miVpUMTrOuiwzkhRf86DaNAEjLk0/C8Zf4CW0X2GpKS2HMGPjmN30wlST9\\ntZkwAaZPV1BJehRWIv257TZYtgw2bYJTT1VgpbBtG1x6KbzjHbBldyVtE2fw2TNf4Vvf0sAJyRyF\\nlUii3l74wQ9g0aK+beEIANlLby/ceqs/TbV4MXzpS/DyyzDmyHlM2b6aL39ZQSWZo7ASCW3dCuec\\nA1/4gp8uaMwYf+2QRgDspaEBPvtZOPJI+PjHYeFCeO45+O53g9N78+f7a636pugUGTENsBiOTZv8\\nb6z+bSwcf/wjfPSjflz1jTfCP/8z/PnPvkVVV1dU3+uGhr63fdhhfvak1av9fUMD/OlPfTl05ZXw\\nrW/5oeh7zJ8PO3f635Np0yJ4BxI7DQ1MTzFReDoUVsOxfj29J72Dkg+dD4cc4q9qHDPG34e3FM9f\\n/sWLbPvdM+x/3ukccfkJw65G4h+V4f4tzcQxwuPcffdMKipGfpycvqfubvjGN+Dqq/1f5t/9Dt72\\nNn8caqmnljr2nr8rq/VJcYx0Pt/eXujq8j2X/d2eecYfa/58PyK/pQV27fL3LS3wf/8H99/vL95N\\nVl7uB0WEQVVa6ltSewUV7D1HoMKqMDkHu3dDa+vet5aWfbetWkXvrbdR7afPGzaF1TBZTzfd9yyh\\nzHUP+WvfEj744zdo/+fRtJWPp72scq9bR9Lz9rJKOkb1Pd7SVsnOF95grlvN9+2ddJ18OpXV/f3l\\nGNi2bfD44/4PU2kpnHIKTEqeJnhIx5nNHXfAySf3HSf8w5bYIzTQtu3b/ZiGsD4nneSPU1Li39ZA\\nt8T9W7f6vOnt9dvPOcf/vezv6w5oWctFSy9gzoZl/GXhx/ifU6+n6+fjsLthwwY/pDqsywc/6BfC\\n7e31t56evsepnm/d6kfJ9fT4+tTW+muMnPP7k+/727ZzJ6xaBb29s7ntNh8yZWX9h1H30H8c9ygt\\nhVGj+oLKDM46Cz75SX9eatYs+Mtf/HiTzs4UvaOJS9wXWffpcP8xcc5/7uEt/BkayfNN9z9FyR8f\\npeQfaph00lsoaWvd+7a7hZK2VkrbWylpb6V0r8ctlLa3Utbut5V2+PuyjlbK2lso69g9pM/FgttI\\nKKyGwQFtjOGDEx6jcfpxlLsOKlw75b3te+5Hu7Y9zxO3nbjlPs7q+DWlOHowniurYe3YhYztbWFM\\nbwtj21sY29vMxN51jO1tYVzvLsb2tlDuOgesz2fcDVAPnYxiR+kB7Cg9gObSiewoOYDm4PmOknB7\\n3+M3dx1AXc/fOJZnqO85heeeq+WAA4b+ebz5ZvgHzujp8SO+E0MvzM/EHO1v29atfX8oe3r8yfqJ\\nE/f+4z3QLdy/c+fex3jsMd+oTS5/Vsf/8I22SylzXVxW8XOWvP4R3K19+7u6+o7T3Q2/+pVvGJeW\\n+tApKdn78UDPt2/vO05vL6xZ48MzDNjE+8TH4bHCAPYX1hrO+bB729t8WAzl9vDDPoDDIP/Up+Bz\\nn/NrS1ZW+lH6f/7z3mH01a/u/Ue3ttZ/pin/IE+f7ptcRTah7e23+3N4vb3++zZpkv+nIp1wGapR\\ndHIgG5jOeqazfq/H01nPIbzG21nvA2IF8JPBj9lNKa2M2+fWwnhaObDffX1lKgfcdzgv8jvejaNt\\n6G80gTmdBB2yaTbDzSv/Jd+prx1yt86LNzdwyOWnMopOuijntZse44hFaRyks7Ovmd3Swsav3sCU\\n+39KKb30UMLOt5/B/nVv88nR3621dcBDO8BhtM1ewLij5vs/NtOnw4EH7v24qqrfr29o8H/gOjp6\\nqagoGfZw5fA44R/K4Rxn0GO0t8MXvwg33ADHHAP33uvnA8pCXTL9nnL1+Waka3jePJ/6d9454EHe\\n9S7/z0VcrgoY7npWr7/uz93dc0/fNjN/EfRRR/X98xHeUj4vcVR2bGe/XesZ37Keql3rqdq5gcqd\\n66ncsZ7K5vWM3bGBMbu27lOPnlEVtE+cTvvE6bRu2MGMphcpwdFDCStn/SNjLj6f3jHj6B0zDjd2\\nXN/jcZX0jhkH5eWUlFrKnovhbH/2WfjR+Q280vlPbHTrh93AUlgNw4wZNe6Xv1w+7F/kF29uYPt9\\n9Uz8QF16QdWfhgZ6Tun7y1P6+CB/wTo6oKlp7wC76y7c/fdjzuEw7JA5/q/Yhg2wY8e+x6iq6j/E\\npk/ntWfe5JXfreCgT1zIEYuOH957IsvnrFavhg99CJ5/Hv71X/20CuXlWa1Lpo7T0AC33/53Lr10\\nTqyFk2UAAB9OSURBVOR1SetFTjrJNxnGjBkwFfM9rJqb/Y/Qf/2X/6P8wQ/C2iUNnNBVz7JRdfv+\\nM9vW5n+31q/3t8THids6++lFmTKl73euv38mp0/3s60EXRXD/qc4Sxoa4PjjZ6x3bt2MwUv3T2E1\\nDDU1NW758uVRV2Pkf3lS/avd0tL3yzTQL9WGDf2fJDnkEN9Pdeihe9+mT993GoNcCP/D/+QnYexY\\n+NnP4Oyzc1+PEcqblWy/8x3f1HDOf7+//W348pf3KZavYdXZCT/9qZ+Z48034cIL/Vs86OWl9J77\\nXujqhNJSSs460/cnh78vb76578HGjh08hKZOTflP1UAy8k9xBpnZCudczXC/Xues8llt7cj+PU51\\nAqKy0o+OO+ywgb8+HEHwrW/BT37S11lfVgYvvQQPPuh/WUMVFT7IkkPs0EP7Rg1k+l//XbvgE5+A\\nn//cH/PnP/d/ACR76ur8Cb62Nv8zUSATATvnR0r+27/Bpr/t4uNHP8vnL1rO9A3PwCnL4bXX+i5c\\n7emGJ57w3aGHHOJbmv2F0vjxQxoUNRRHLKqFGIRUpiisit1IAq+kxA+R+8hH4Pbb6e3ooKSiAu64\\nwx+zp8dPBvu3v8Frr/n78PbII/78UWjUKP8f5Pr1/q9CaakfAXDccf41qqt9V8gBB6T/y71ihe/2\\n+/vf/b/BX/mKP65kV/hP0EMP+SbIf/wH/OM/5u+EwO3tvLj4Of7wnWc4YM1yfl/xDHNsNfasg2fx\\nKyQfeyycfrr/2e/u9i2hpUuL6vq8bFNYycgFf5xev/125lx6ad8vaGmpH+88a5afejtRb6+fcjsx\\nwB56qG9Zju5u+NGP9n2tsjIfWmF4hUGW+HzTJj/sbelSP/Suvt7/Zyu5E/4T9M53+j/in/mMn28x\\nrhoamHn33f5ntrLSX5C2fDkdf3qG0tV/5QjXzRHA7v2qGX3Ssdix5/uAqqnxP3ehiy4qygvJc0Fh\\nJZlRW8vajg7mpPsLWlLS1x1y8sl+23ves/c5tF/9Cg4+GDZv9rctW/Z9vGqVv+/o6P81brlFQRWl\\nU0/1Ldqrr/aPL7hgz67mZv//SqSTwXR2+mWLP/c5Znd3+8kOA60V+/NUZw0rS6/g4A/UcM43jmXc\\nYdNTt+xH2jUvA1JYSXwMdA5t4cLUX+ecPze1eTNcc43/gxOeP1u5Es48M9s1l1S+/nX/Pb38cviH\\nf4BDD6WhAZYv99+mE06AI47wp3YmT/a3KVP8/datfhBnba3vER4zpu82erT/f2Sw05x7DTT4+HG+\\nFb90qb89/vieyzoMcGasfut5XPD3q3mhZQ6XXmZ885uaiCMOFFYSL8P5z9QM9tvP3y65xE8BnnKK\\nBcmpsjJ/EdKRR8L558NTT1FfX7Fnd/i/xquv+nkHt2/vW1049JMBLmodNapvDI8ZzJnjg27sWH+b\\ntbGB7y4/lbfQQe8jJTR/bjITdm8EoGXqITSfejFu5sFMu+nr0NVJlyvn0uc/y7SzDmHx9+Dww7Pw\\neciwKKyksKQ1xYLk3MyZfvDB+94H//Zv1J13LRUVff9T3H1337eqt9eP8r76arjuur4ZNz7wAX/6\\nq63Nj81pa/PzDz/5ZN/UXeXl/pTTqOatHP3qg3x4/TWMoQ0DSuhlw+7xXMmVLOVdvLbpUHjAf91x\\nnEQd9TxBHR/+r1r+f3t3Hl1Vee9//PPNPBhkDopCUmSScMMgePMTJcXUWaFQpCWrGtGfv2XrVKcC\\nXq+giwUWbRW0rVYBbVPBhfa2UqwFbdV6HbhypYAmFGRQMAgEMQmBDOf5/bHPwRBJCCHkPAnv11pn\\n4dl7n2d/szn4yd772c9z661ROUpoBGGF9of7Bn4aO1a65Rbp0UeVM2aMXnvtyiP+ThETEwxVdPXV\\n0pNPfh1oP/nJN/9aL7pImpYbPIj7SVxfzc7bpowP/0v64G0pFFJVp3TV7I2TKaQqJapy/gL958Qc\\n/aQseMarrCzo91FYmKN3QzmKjZWubHiwF0QRYQWg9cydG1zrKyhQzocfKmdaw89gHfUkuapKOR8+\\no9drb5W5Glm1pPkKHki/7z5p7FglDBmitb9599A9q+Hh547S079uJtKX5+DBkBISYrhy7CnCCkDr\\nSUwMHisYNizo1p6ZKX3ve4fPzFzHYSfJzgWjG69YIa1cGaRYRcXXD+LGxATDaM2de1gbR3s4NhKK\\nCxZsOe7hrHDiEFYAWlffvsFAegsXBj3zVqyQ/vSn4PQp0lEm8tq4MRguvrw8GNPx86BzhPr1k669\\nNhgd44EHvr5WOH58s0rKyZEOHtymnJxvtdzPiRZFWAFofdu3H/7+z38OXo3JywsG4cvLCzpsRIwe\\nTYeak0AURhUFcNKbMOHw97/+ddDj4bPPgge933tPmjLl64GPY2ODy4ZTphweVFIQUNOmEVTtHGdW\\nAFpf5B7Viy8GwRV5X3fOtNpa6fnneWYOkggrANFy440NdqyQxDNzOAxhBcBfPDOHMO5ZAQC8R1gB\\nALxHWAEAvEdYAQC8R1gBALxHWAEAvEdYAQC8R1gBALxHWAEAvEdYAQC8R1gBALxHWAEAvEdYAQC8\\nR1gBALxHWAEAvEdYAQC8R1gBALxHWAEAvGfOuWjX0OaY2S5JW6Ndh4e6Stod7SLaMY7vicXxPbH6\\nO+fSmvvhuJas5GThnOsW7Rp8ZGb/45w7J9p1tFcc3xOL43timdn/HM/nuQwIAPAeYQUA8B5hhZb0\\nVLQLaOc4vicWx/fEOq7jSwcLAID3OLMCAHiPsAIAeI+wwnExsxlm5uq9SqJdV1tlZheY2Z/MbHv4\\nWBbUW2/hY77DzCrN7O9mNihK5bY5TTi+i47wfX43SuW2OWY2zcxWmdlXZrbLzF42s6x62zTrO0xY\\noSUUSzqtzmtwdMtp006RtE7SbZIqj7D+Hkl3SrpF0ghJX0haYWbNftjyJHO04ytJK3X49/my1imt\\nXciV9EtJ/0fSGEk1klaaWec62zTrO0wHCxwXM5sh6XvOuayjbYtjY2blkm52zi0KvzdJOyQ97pyb\\nFV6WrOAf+13OuSejVWtbVP/4hpctktTVOXdFtOpqT8zsFEn7JI1zzr18PN9hzqzQEr4VPqXfbGaL\\nzexb0S6oncqU1EPSXyMLnHOVkt5U8JssWsYoM/vCzDaY2W/MrHu0C2rD0hTkzN7w+2Z/hwkrHK/3\\nJBVIukTS/1XwRfxvM+sSzaLaqR7hP3fWW76zzjocn79IukbShQouVY2U9LqZJUa1qrbrMUkfSnon\\n/L7Z32HGBsRxcc69Uve9mb0jabOkayX9PCpFAc3knFtc5+1aM/tAwaDVl0t6KTpVtU1m9nNJoySN\\ncs7VHm97nFmhRTnnKiStl9Q32rW0Q5Felun1lqfXWYcW5JzbIekz8X0+Jmb2C0k/kDTGOfdJnVXN\\n/g4TVmhRZpYkaYCkz6NdSzu0WcE/6O9EFoSP9/mS/jtaRbVnZtZNUk/xfW4yM3tMXwdVUb3Vzf4O\\ncxkQx8XMHpb0sqRtkrpLuk9SqqRno1lXWxXuPXVW+G2MpF5mNkRSqXNum5k9Kmm6mRVJ2iDpPySV\\nS/p9VApuYxo7vuHXDEkvKginDEmzFfRU+0Nr19oWmdkTkn4oaZykvWYWuQ9V7pwrd8655n6H6bqO\\n42JmiyVdoGDiul2S3pV0n3Puo6gW1kaZWa6kvx1h1bPOuYJw19/7Jf0/SZ0UdHD5sXNuXetV2XY1\\ndnwl3STpvyQNldRRQWD9TcH3+dPWqrEtM7OGAmWmc25GeJtmfYcJKwCA97hnBQDwHmEFAPAeYQUA\\n8B5hBQDwHmEFAPAeYQUA8B5hBbSQ8CRyj0e7jhPFzDqZ2U4z63Oc7cw1s/ktVRdODjxnBTQiPL/R\\nteG3NQqmOlgvaamkp5xz1XW27Syp2jlX1oR2Z6iNzQNmZnMVzPV03XG2003SJklD6o0bBzSIMyvg\\n6CIzx2ZIukjB8FIzJb1lZqmRjZxzpU0JqrbIzFIk3SDpmeNtyzm3S8F8Rjcdb1s4eRBWwNEddM6V\\nOOe2O+c+dM79XMH03cMUTNEt6ZuXAc1svJn908wqzazUzN4ws3QzK1Aw3MwgM3PhV0H4M3eEP1Nh\\nZtvN7Gkz61inzQIzKzezC81sXXi7v5lZZt2CzewyM3svvO89ZvZyeMBQmVmCmT1kZp+Z2X4zW2Vm\\nFx/lGFwmyUl6u84+csO1X2pmH4T39ZaZnWFmo81sTbjWZUeY3+xPCgY7BZqEsAKaITyO2V8kTTjS\\n+vAAnosVjDk3UMH4ib8Nr14i6RFJxQrO2E4LL5OkkKTbJQ2SNFnB5H/17+8kSpomaYqkHAXj2P26\\nzr4vURAGKyQNlzRawRh3kX/vC8PLJkvKCtf4spllN/Ijny/pA3fk+wYzwzWfq2CstyWS/lPSjQpC\\nfZCCAWLrel9Sz+O9/4WTB6OuA833kaS8BtadLile0lLn3NbwskMDdZpZuaQa59xhc/g45x6t83aL\\nmd0j6Y9mdq1zLhReHqdg4M/icFsPS1pgZhYOk/vC+/2POm2tC2/bR8EZTYZzblt43eNmlqdgYNEf\\nNfDz9Ja0o4F19znn3gq3/2sF4TrcObc6vOxZSd+r95lIWxkK7l8BjeLMCmg+U3Bp7EjWKLjXtc7M\\nXjSzm8IdCxpv0GyMma0IX6IrUzA7bYIOn/L7YCSownaEt+kUfj9U0msN7GJYuO6PwpfoysPBebmk\\nxs5ykiUdaGDdP+v8d2S68rX1lnWv95nKOu0CR0VYAc13tqQj9mYLT+N9Ufj1T0nXS/pXY5fazKy3\\npD9L+ljSRAWX8KaEVyfU2bSm/u7Cfzbl33NMePsRkobUeQ2ss68j2a2vw7C+6jr/7SSpbi/J8LL6\\ntXUO/7mrCTUDhBXQHGaWJekSBV3Yj8gF3nHOzVQQDjskTQqvrpIUW+8j5ygIpZ+EP7dBweXEY/W/\\nki5sZJ1J6uGc21jvtf0obZ7djFoakqUg5NYebUNA4p4V0BSJ4Q4TMZK6KQiC6ZI+kPTwkT5gZv+u\\n4H7Wqwougw2VdKaC+1yStEVSbzMbpmCW5TJJ/wrv43Yze0nSvyvouHCsZinoMLFRweyrpuAM70nn\\n3AYzK5S0yMzulLRawVlOrqRPnHMvNdDmq5IeMrMuzrk9zaipvvMlveWc298CbeEkwJkVcHR5CmaN\\n3abgXtBVCnq3XeCcq2jgM/sknSdpmYIQekTSg86534XXvyhpebi9XZJ+4Jz7p6TbJN2hINRukHTX\\nsRbrnFsu6buSLlVwRvSGpG8r6GkoSdcp6BH4M0lF4RovkLT1G4193eZaBT34vn+s9TTgB5J+00Jt\\n4STACBYAmiTcJf4xSWeH78k1t53LJc2V9G/Oufr334Aj4swKQJM45/4i6QlJZxxnU6mSriOocCw4\\nswIAeI8zKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgr\\nAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA\\n9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcI\\nKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsA\\ngPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3\\nCCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgr\\nAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA\\n9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcI\\nKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsA\\ngPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3CCsAgPcIKwCA9wgrAID3\\nCCsAgPcIKwCA9+KiXQBa3gcffJAQExNzU2xs7HXOuVMlWbRrwnFzZravtrZ2YSgU+tXw4cOrol0Q\\n0JoIq3YoLi7uNx06dDjv9NNPr0hISNhjRla1dc45VVVVxe/YseOWr776apika6NdE9CauAzYPo3q\\n3bv3vsTExGqCqn0wMyUmJlb37t17n6RR0a4HaG2EVfsUGxMT46JdBFpe+O81Ntp1AK2NsAIAeI+w\\nAgB4j7ACAHiPsEK7VVtbq5qammiXAaAFEFbwyiuvvHJKdnb2gJSUlKFpaWlDBg8ePHDVqlVJ8+bN\\n65KSkjK07rbLli1LM7Phn3/+eZwkRbZZsmTJqX379h2UmJg4fM6cOd3j4+OHlZSUHNYp4eabb+7Z\\nr1+/syPvV6xYkTpixIj+ycnJQ7t37/5v+fn5vUpLS2Mk6fHHH+/SsWPHIZWVlYd1rbzqqqsyx4wZ\\nc9aJOxoAIggrNGrlSqVOm6YeK1cq9UTvq7q6WpMmTTrr3HPPLV+1atVHb775ZtGPf/zjnbGxTe/8\\nVlVVFTN79uzTnnjiiS2rV69ed9NNN+3p1KlTzXPPPdc5sk0oFNIf/vCHzldfffUeSXr//feTx44d\\n2++yyy778v333/9o8eLFm9avX58yefLkDEkqKCgoDYVCKiws7BhpY8+ePbErVqzoOGXKlN0tdwQA\\nNISHgk8SU6bozHXrlHIsnykrU0xxsVKckx56SOrfX/vT0hRq6uezsrR/wQJ92tTtS0tLY8vKymLH\\njh375aBBgw5K0tChQw9I0j/+8Y8mhWVtba3mz5+/7fzzz98fWXbVVVeVLlmypPM999yzS5JWrFhx\\nSklJScJ1111XKkmzZ89Ov+KKK0pnzpy5M/yRg7/85S+3nnfeeWdv3749rmfPnjXjxo0rffbZZ7ve\\ncMMNeyXp6aef7pyamhqaNGnSl039+QA0H2GFBpWVKc6Fn9ZyLniflqYTNsxPenp67YQJE/aMHz++\\nX05Ozle5ubll+fn5e/v27dvkfcbGxrqcnJz9dZcVFBSULliwIH3Dhg0J/fr1q3ruuec6jxgxoqxP\\nnz7VkrR27drUbdu2JaakpBw6+3LhH/zjjz9O7NmzZ81NN920a9SoUWdv2rQpvk+fPtW//e1vu06c\\nOHF3fHx8C/30ABpDWJ0kjuUMJ2LlSqVecYX61dQoJi5OoUWL9ElenipORH0RS5cu3fLOO+/sXLZs\\n2anLly/vOGfOnJ6FhYUbY2JiDgVIRHV19TeG50hISHBxcYd/rUeNGrU/MzPzwMKFCzvPmDFj5/Ll\\nyzvdf//9n0XWh0IhTZo0afdPf/rTnfXby8jIqJKknJycyoEDB+5/8sknu06cOHHv+vXrUwoLCz9p\\nqZ8bQOMIKzQoL08Vy5Zpw2uvKe3CC1V2ooMqIicnpzInJ6dy1qxZJRdccEHfRYsWdfnhD3+458CB\\nAzGlpaUxnTt3DknS6tWrk5va5sSJE/csXbq0y+DBgysrKytjr7nmmr2RdVlZWfuLi4uTs7KyDjbW\\nRkFBwa558+b12L17d9ywYcPKs7OzG90eQMuhgwUalZenitmzVdIaQVVUVJTwox/9qOeKFStSN2zY\\nkPDyyy+nFRUVJQ8cOPDA6NGjK5KTk0O33XbbGevWrUtctGhRxwULFnRvattTpkwp3bRpU9IDDzzQ\\nc8yYMV9GAk+S7r333pK1a9emTJ48udfbb7+dvG7dusTnn3/+1MmTJ/eu28b1119funv37vjf/e53\\n3a655ho6VgCtiLCCN1JTU0MbN25Mys/P75OVlZV14403ZowfP770wQcfLElPT6996qmnNr/11lsd\\nzjnnnEFPP/10t3vvvXd7U9vu169f1bBhw8qLi4uT8/Pz99Rdd+6551a++uqrxZ9++mnixRdfPGDE\\niBFn33///T27d+9eXXe7Tp06hS6//PK9CQkJ7rrrrtsrAK3G6t8HQNu3Zs2aLdnZ2fzmfwJccMEF\\nfU8//fSqxYsXb41WDWvWrOmanZ2dEa39A9HAPSugCXbt2hX717/+9ZS33367w7vvvrs+2vUAJxvC\\nCmiCIUOGnL1v3764qVOnbh8xYsSBaNcDnGwIK6AJtm/fvjbaNQAnMzpYAAC8R1gBALxHWAEAvEdY\\nAQC8R1gBALxHWAEAvEdYoU2oPyvwiTRhwoSMb3/721GbATglJWXovHnzukRr/4CPCCu0CXl5eeVb\\nt25dk56eXhPtWuorLi5OMLPhb7755jFNbgmg6XgoGG1CUlKS69Wrl3dBBaB1cGYFr7zyyiunZGdn\\nD0hJSRmalpY2ZPDgwQNXrVqVVP8y4Lx587qkpKQMfeGFFzpkZmYOSk5OHjpmzJiz9uzZE7tw4cJO\\nvXv3zkpLSxsybty4zPLy8kOTNI4cObL/Nddc06vuPo922W/p0qUdhg8f3r9Dhw5DTj311CGjRo3q\\nu3r16qTI+gEDBgyWpNGjRw80s+EjR47sH1n32GOPdenTp8+gxMTEYRkZGVkzZ87sXltbe6jtdevW\\nJY4cObJ/ZP3zzz9/aoscSKCd4cwKjVu5MlWvvZamCy8sU17eCZ3Tqrq6WpMmTTrr+9///u7f//73\\nm6uqquy9995LiY2NPeL2VVVV9uijj/Z47rnnNh88eNAmT57c58orr+yTlJQUeuGFFzZ98cUXcfn5\\n+X3mzp3bfebMmd+YBbipysvLY2655Zadw4cPr9y/f3/MzJkzTxs3btxZGzZsWJ+UlOT+/ve/f5yb\\nmztw6dKl/xoxYsT+xMREJ0mPPPJI1zlz5pz+s5/97NOcnJyK1atXJ996660Z8fHxbvr06btqa2s1\\nfvz4Ph06dKh9/fXXP66oqIi54447elVVVX1jBmTgZEdYnSymTDlT69Yd2z2VsrIYFRenyDnpoYek\\n/v33Ky0tdPQPhmVl7deCBZ82dfPS0tLYsrKy2LFjx345aNCgg5I0dOjQA5K0Y8eO+Prb19bW2q9+\\n9autkRl7x40bV/rMM8+kf/bZZ2tOO+20Gkn6zne+8+Wbb76ZJqnZYVVQUPBl3feLFy/e0qlTp6Fv\\nvPFG6sUXX1zeo0ePGknq1q1bTd1LlQ8//PBpM2bM+Cwy99WAAQOqNm7c+PkzzzzTffr06bv++Mc/\\ndti0aVNyUVHR2r59+1ZJ0iOPPPLpJZdc0l8ADkNYoWFlZXGKzHfmXPA+La3qRO0uPT29dsKECXvG\\njx/fLycn56vc3Nyy/Pz8vZH/kdeXkJDg6k4tn56eXt2lS5fqSFBJUvfu3as3bNiQfDx1rV+/PnHq\\n1Kmnf/jhh6l79+6ND4VCCoVC2rx5c0JDn9mxY0dcSUlJwl133dX77rvvPjTjcG1t7aE55NavX5/U\\nvXv3qro/X25ubkVMDFfngfoIq5PFMZzhHLJyZaquuKKfampiFBcX0qJFn5zoS4FLly7d8s477+xc\\ntmzZqcuXL+84Z86cnoWFhRsjl9bqio2NPWyZmSk+Pv4by+pOMBoTE+PqTzhaXV3d6GW3K6+88qwe\\nPXpUzZ8/f2uvXr2q4+Pj3dChQwc1drkucl9q7ty523Jzc8sbax/A0fErHBqWl1ehZcs26O67t2vZ\\nsg0nOqgicnJyKmfNmlXy/vvvF48cObJs0aJFLfbMUZcuXWp27tx52CXFjz/+uMHLoyUlJbGbN29O\\nmjZtWsm4cePKhg0bdmDfvn2xtbW1h4IqEqQ1NTWHlp155pk13bp1q960aVNiVlbWwfovSRo0aNCB\\nL774ImHjxo2H6nnjjTdSQqGmX2kFThacWaFxeXkVrRVSRUVFCfPmzev23e9+98vevXtXFxcXJxYV\\nFSUXFBTsaql95ObmfnXffff1KiwsPDUrK+vA/Pnzu5WUlMSfccYZB4+0fbdu3Wo7duxY89RTT3XN\\nzMys2rp1a/zUqVPPrHtW17Nnz+qkpKTQ8uXLO/Tt2/dgSkqK69KlS+3UqVN3TJ8+vVfHjh1rxo0b\\nty/cYSR1+/bt8bNnzy4ZO3bsV5mZmQfy8/Mzf/GLX3y6f//+mDvvvLNX/TNGAJxZwSOpqamhjRs3\\nJuXn5/fJysrKuvHGGzPGjx9f+uCDD5a01D5uvfXWPRMnTtx98803Z+Tm5g5IS0sLXXTRRV82tH1s\\nbKyeffbZT4qKilKGDx8+6Pbbb+89Y8aM7QkJCYcCJT4+XrNmzfq0sLCwa0ZGRvall156liTdcccd\\nux977LEtS5Ys6TJy5MhBF1544YCFCxd2zczMPBhp+6WXXtoYCoUsNzd34PXXX585derUHXXbBhCw\\n+tfv0fatWbNmS3Z29u5o14ETY82aNV2zs7Mzol0H0Jo4swIAeI+wAgB4j7ACAHiPsAIAeI+wAgB4\\nj7Bqn0KhUIjBUNuh8N8rTw3jpENYtUNmVlJZWZl09C3R1lRWViaZWYs9dwa0FYRVO1RTUzNzy5Yt\\nCRUVFcmcYbUPoVDIKioqkrds2ZJQU1MzM9r1AK2Nh4LbqdWrV18cFxd3v3Ouh/ilpD0ImVlJTU3N\\nzGHDhr0a7WKA1kZYAQC8x2/cAADvEVYAAO8RVgAA7xFWAADvEVYAAO/9f7CTWeg+hu5/AAAAAElF\\nTkSuQmCC\\n\",\n+ \"text/plain\": [\n+ \"<matplotlib.figure.Figure at 0x16a190c0dd8>\"\n+ ]\n+ },\n+ \"metadata\": {},\n+ \"output_type\": \"display_data\"\n+ },\n+ {\n+ \"data\": {\n+ \"text/plain\": [\n+ \"True\"\n+ ]\n+ },\n+ \"metadata\": {},\n+ \"output_type\": \"display_data\"\n+ }\n+ ],\n \"source\": [\n- \"Q = Mag.fitline(Box)\\n\",\n+ \"Q = Simulator.fitline(model,survey)\\n\",","path":"Notebooks/FitMagProfile.ipynb","position":115,"original_position":115,"commit_id":"4cb37bb3643588a0a1f15619f42b763bfb9930dc","original_commit_id":"4cb37bb3643588a0a1f15619f42b763bfb9930dc","user":{"login":"thast","id":13682747,"avatar_url":"https://avatars3.githubusercontent.com/u/13682747?v=3","gravatar_id":"","url":"https://api.github.com/users/thast","html_url":"https://github.com/thast","followers_url":"https://api.github.com/users/thast/followers","following_url":"https://api.github.com/users/thast/following{/other_user}","gists_url":"https://api.github.com/users/thast/gists{/gist_id}","starred_url":"https://api.github.com/users/thast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thast/subscriptions","organizations_url":"https://api.github.com/users/thast/orgs","repos_url":"https://api.github.com/users/thast/repos","events_url":"https://api.github.com/users/thast/events{/privacy}","received_events_url":"https://api.github.com/users/thast/received_events","type":"User","site_admin":false},"body":"\r\n\r\nThe legend is far from the actual plot","created_at":"2017-06-28T19:25:36Z","updated_at":"2017-06-28T19:33:12Z","html_url":"https://github.com/geoscixyz/gpgLabs/pull/54#discussion_r124633283","pull_request_url":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/comments/124633283"},"html":{"href":"https://github.com/geoscixyz/gpgLabs/pull/54#discussion_r124633283"},"pull_request":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/54","id":127991870,"html_url":"https://github.com/geoscixyz/gpgLabs/pull/54","diff_url":"https://github.com/geoscixyz/gpgLabs/pull/54.diff","patch_url":"https://github.com/geoscixyz/gpgLabs/pull/54.patch","issue_url":"https://api.github.com/repos/geoscixyz/gpgLabs/issues/54","number":54,"state":"open","locked":false,"title":"Ref/mag","user":{"login":"yangdikun","id":5066933,"avatar_url":"https://avatars2.githubusercontent.com/u/5066933?v=3","gravatar_id":"","url":"https://api.github.com/users/yangdikun","html_url":"https://github.com/yangdikun","followers_url":"https://api.github.com/users/yangdikun/followers","following_url":"https://api.github.com/users/yangdikun/following{/other_user}","gists_url":"https://api.github.com/users/yangdikun/gists{/gist_id}","starred_url":"https://api.github.com/users/yangdikun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangdikun/subscriptions","organizations_url":"https://api.github.com/users/yangdikun/orgs","repos_url":"https://api.github.com/users/yangdikun/repos","events_url":"https://api.github.com/users/yangdikun/events{/privacy}","received_events_url":"https://api.github.com/users/yangdikun/received_events","type":"User","site_admin":false},"body":"Bug fix (Dom, Thibaut), runs on Python 3, tested locally","created_at":"2017-06-28T18:41:43Z","updated_at":"2017-06-28T19:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bee929e83a75c7b309b8b03df22c9d3f984882fc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/54/commits","review_comments_url":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/54/comments","review_comment_url":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoscixyz/gpgLabs/issues/54/comments","statuses_url":"https://api.github.com/repos/geoscixyz/gpgLabs/statuses/4cb37bb3643588a0a1f15619f42b763bfb9930dc","head":{"label":"geoscixyz:ref/Mag","ref":"ref/Mag","sha":"4cb37bb3643588a0a1f15619f42b763bfb9930dc","user":{"login":"geoscixyz","id":18147672,"avatar_url":"https://avatars0.githubusercontent.com/u/18147672?v=3","gravatar_id":"","url":"https://api.github.com/users/geoscixyz","html_url":"https://github.com/geoscixyz","followers_url":"https://api.github.com/users/geoscixyz/followers","following_url":"https://api.github.com/users/geoscixyz/following{/other_user}","gists_url":"https://api.github.com/users/geoscixyz/gists{/gist_id}","starred_url":"https://api.github.com/users/geoscixyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoscixyz/subscriptions","organizations_url":"https://api.github.com/users/geoscixyz/orgs","repos_url":"https://api.github.com/users/geoscixyz/repos","events_url":"https://api.github.com/users/geoscixyz/events{/privacy}","received_events_url":"https://api.github.com/users/geoscixyz/received_events","type":"Organization","site_admin":false},"repo":{"id":30127850,"name":"gpgLabs","full_name":"geoscixyz/gpgLabs","owner":{"login":"geoscixyz","id":18147672,"avatar_url":"https://avatars0.githubusercontent.com/u/18147672?v=3","gravatar_id":"","url":"https://api.github.com/users/geoscixyz","html_url":"https://github.com/geoscixyz","followers_url":"https://api.github.com/users/geoscixyz/followers","following_url":"https://api.github.com/users/geoscixyz/following{/other_user}","gists_url":"https://api.github.com/users/geoscixyz/gists{/gist_id}","starred_url":"https://api.github.com/users/geoscixyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoscixyz/subscriptions","organizations_url":"https://api.github.com/users/geoscixyz/orgs","repos_url":"https://api.github.com/users/geoscixyz/repos","events_url":"https://api.github.com/users/geoscixyz/events{/privacy}","received_events_url":"https://api.github.com/users/geoscixyz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoscixyz/gpgLabs","description":"Tutorials and examples for applied geophysics!","fork":false,"url":"https://api.github.com/repos/geoscixyz/gpgLabs","forks_url":"https://api.github.com/repos/geoscixyz/gpgLabs/forks","keys_url":"https://api.github.com/repos/geoscixyz/gpgLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoscixyz/gpgLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoscixyz/gpgLabs/teams","hooks_url":"https://api.github.com/repos/geoscixyz/gpgLabs/hooks","issue_events_url":"https://api.github.com/repos/geoscixyz/gpgLabs/issues/events{/number}","events_url":"https://api.github.com/repos/geoscixyz/gpgLabs/events","assignees_url":"https://api.github.com/repos/geoscixyz/gpgLabs/assignees{/user}","branches_url":"https://api.github.com/repos/geoscixyz/gpgLabs/branches{/branch}","tags_url":"https://api.github.com/repos/geoscixyz/gpgLabs/tags","blobs_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoscixyz/gpgLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/geoscixyz/gpgLabs/languages","stargazers_url":"https://api.github.com/repos/geoscixyz/gpgLabs/stargazers","contributors_url":"https://api.github.com/repos/geoscixyz/gpgLabs/contributors","subscribers_url":"https://api.github.com/repos/geoscixyz/gpgLabs/subscribers","subscription_url":"https://api.github.com/repos/geoscixyz/gpgLabs/subscription","commits_url":"https://api.github.com/repos/geoscixyz/gpgLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoscixyz/gpgLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoscixyz/gpgLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoscixyz/gpgLabs/contents/{+path}","compare_url":"https://api.github.com/repos/geoscixyz/gpgLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoscixyz/gpgLabs/merges","archive_url":"https://api.github.com/repos/geoscixyz/gpgLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoscixyz/gpgLabs/downloads","issues_url":"https://api.github.com/repos/geoscixyz/gpgLabs/issues{/number}","pulls_url":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/geoscixyz/gpgLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/geoscixyz/gpgLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoscixyz/gpgLabs/labels{/name}","releases_url":"https://api.github.com/repos/geoscixyz/gpgLabs/releases{/id}","deployments_url":"https://api.github.com/repos/geoscixyz/gpgLabs/deployments","created_at":"2015-01-31T21:59:43Z","updated_at":"2017-06-21T19:01:28Z","pushed_at":"2017-06-28T19:28:08Z","git_url":"git://github.com/geoscixyz/gpgLabs.git","ssh_url":"[email protected]:geoscixyz/gpgLabs.git","clone_url":"https://github.com/geoscixyz/gpgLabs.git","svn_url":"https://github.com/geoscixyz/gpgLabs","homepage":null,"size":70557,"stargazers_count":8,"watchers_count":8,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":8,"default_branch":"master"}},"base":{"label":"geoscixyz:master","ref":"master","sha":"fcfb41b93336a6eeea02186482d34f989f8232de","user":{"login":"geoscixyz","id":18147672,"avatar_url":"https://avatars0.githubusercontent.com/u/18147672?v=3","gravatar_id":"","url":"https://api.github.com/users/geoscixyz","html_url":"https://github.com/geoscixyz","followers_url":"https://api.github.com/users/geoscixyz/followers","following_url":"https://api.github.com/users/geoscixyz/following{/other_user}","gists_url":"https://api.github.com/users/geoscixyz/gists{/gist_id}","starred_url":"https://api.github.com/users/geoscixyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoscixyz/subscriptions","organizations_url":"https://api.github.com/users/geoscixyz/orgs","repos_url":"https://api.github.com/users/geoscixyz/repos","events_url":"https://api.github.com/users/geoscixyz/events{/privacy}","received_events_url":"https://api.github.com/users/geoscixyz/received_events","type":"Organization","site_admin":false},"repo":{"id":30127850,"name":"gpgLabs","full_name":"geoscixyz/gpgLabs","owner":{"login":"geoscixyz","id":18147672,"avatar_url":"https://avatars0.githubusercontent.com/u/18147672?v=3","gravatar_id":"","url":"https://api.github.com/users/geoscixyz","html_url":"https://github.com/geoscixyz","followers_url":"https://api.github.com/users/geoscixyz/followers","following_url":"https://api.github.com/users/geoscixyz/following{/other_user}","gists_url":"https://api.github.com/users/geoscixyz/gists{/gist_id}","starred_url":"https://api.github.com/users/geoscixyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoscixyz/subscriptions","organizations_url":"https://api.github.com/users/geoscixyz/orgs","repos_url":"https://api.github.com/users/geoscixyz/repos","events_url":"https://api.github.com/users/geoscixyz/events{/privacy}","received_events_url":"https://api.github.com/users/geoscixyz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoscixyz/gpgLabs","description":"Tutorials and examples for applied geophysics!","fork":false,"url":"https://api.github.com/repos/geoscixyz/gpgLabs","forks_url":"https://api.github.com/repos/geoscixyz/gpgLabs/forks","keys_url":"https://api.github.com/repos/geoscixyz/gpgLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoscixyz/gpgLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoscixyz/gpgLabs/teams","hooks_url":"https://api.github.com/repos/geoscixyz/gpgLabs/hooks","issue_events_url":"https://api.github.com/repos/geoscixyz/gpgLabs/issues/events{/number}","events_url":"https://api.github.com/repos/geoscixyz/gpgLabs/events","assignees_url":"https://api.github.com/repos/geoscixyz/gpgLabs/assignees{/user}","branches_url":"https://api.github.com/repos/geoscixyz/gpgLabs/branches{/branch}","tags_url":"https://api.github.com/repos/geoscixyz/gpgLabs/tags","blobs_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoscixyz/gpgLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/geoscixyz/gpgLabs/languages","stargazers_url":"https://api.github.com/repos/geoscixyz/gpgLabs/stargazers","contributors_url":"https://api.github.com/repos/geoscixyz/gpgLabs/contributors","subscribers_url":"https://api.github.com/repos/geoscixyz/gpgLabs/subscribers","subscription_url":"https://api.github.com/repos/geoscixyz/gpgLabs/subscription","commits_url":"https://api.github.com/repos/geoscixyz/gpgLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoscixyz/gpgLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoscixyz/gpgLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoscixyz/gpgLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoscixyz/gpgLabs/contents/{+path}","compare_url":"https://api.github.com/repos/geoscixyz/gpgLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoscixyz/gpgLabs/merges","archive_url":"https://api.github.com/repos/geoscixyz/gpgLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoscixyz/gpgLabs/downloads","issues_url":"https://api.github.com/repos/geoscixyz/gpgLabs/issues{/number}","pulls_url":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/geoscixyz/gpgLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/geoscixyz/gpgLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoscixyz/gpgLabs/labels{/name}","releases_url":"https://api.github.com/repos/geoscixyz/gpgLabs/releases{/id}","deployments_url":"https://api.github.com/repos/geoscixyz/gpgLabs/deployments","created_at":"2015-01-31T21:59:43Z","updated_at":"2017-06-21T19:01:28Z","pushed_at":"2017-06-28T19:28:08Z","git_url":"git://github.com/geoscixyz/gpgLabs.git","ssh_url":"[email protected]:geoscixyz/gpgLabs.git","clone_url":"https://github.com/geoscixyz/gpgLabs.git","svn_url":"https://github.com/geoscixyz/gpgLabs","homepage":null,"size":70557,"stargazers_count":8,"watchers_count":8,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/54"},"html":{"href":"https://github.com/geoscixyz/gpgLabs/pull/54"},"issue":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/issues/54"},"comments":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/geoscixyz/gpgLabs/statuses/4cb37bb3643588a0a1f15619f42b763bfb9930dc"}}}} | {
"id": 30127850,
"name": "geoscixyz/gpgLabs",
"url": "https://api.github.com/repos/geoscixyz/gpgLabs"
} | {
"id": 13682747,
"login": "thast",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13682747?",
"url": "https://api.github.com/users/thast"
} | {
"id": 18147672,
"login": "geoscixyz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18147672?",
"url": "https://api.github.com/orgs/geoscixyz"
} | 2017-06-28T19:25:36 | 6157701129 | {"actor":{"display_login":"thast"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/comments/119286299","pull_request_review_id":41149986,"id":119286299,"diff_hunk":"@@ -7,17 +7,6 @@ the [Kotlin documentation].\n \n # Classes and Inheritance\n \n-## Constructors\n-\n-As often as possible we should specify if the constructor properties are mutable\n-(`var`) or read-only (`val`):\n-\n-```kotlin\n-class Person(val firstName: String, val lastName: String, var age: Int) {","path":"kotlin-code-style.md","position":10,"original_position":10,"commit_id":"a58b6267f4599399571235b1d088bb5ced5a4920","original_commit_id":"a58b6267f4599399571235b1d088bb5ced5a4920","user":{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars2.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},"body":"What's not right about this @sindrenm ?","created_at":"2017-05-31T07:21:49Z","updated_at":"2017-05-31T07:21:49Z","html_url":"https://github.com/hyperoslo/android-playbook/pull/28#discussion_r119286299","pull_request_url":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/comments/119286299"},"html":{"href":"https://github.com/hyperoslo/android-playbook/pull/28#discussion_r119286299"},"pull_request":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/28","id":93585530,"html_url":"https://github.com/hyperoslo/android-playbook/pull/28","diff_url":"https://github.com/hyperoslo/android-playbook/pull/28.diff","patch_url":"https://github.com/hyperoslo/android-playbook/pull/28.patch","issue_url":"https://api.github.com/repos/hyperoslo/android-playbook/issues/28","number":28,"state":"closed","locked":false,"title":"Update kotlin-code-style.md","user":{"login":"jeantuffier","id":1524348,"avatar_url":"https://avatars2.githubusercontent.com/u/1524348?v=3","gravatar_id":"","url":"https://api.github.com/users/jeantuffier","html_url":"https://github.com/jeantuffier","followers_url":"https://api.github.com/users/jeantuffier/followers","following_url":"https://api.github.com/users/jeantuffier/following{/other_user}","gists_url":"https://api.github.com/users/jeantuffier/gists{/gist_id}","starred_url":"https://api.github.com/users/jeantuffier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeantuffier/subscriptions","organizations_url":"https://api.github.com/users/jeantuffier/orgs","repos_url":"https://api.github.com/users/jeantuffier/repos","events_url":"https://api.github.com/users/jeantuffier/events{/privacy}","received_events_url":"https://api.github.com/users/jeantuffier/received_events","type":"User","site_admin":false},"body":"I think Sindre was right from the beginning, the externalisation and constuctor stuff were too dependent on context. \r\nI place the companion part before, since we say it should be first in the call. \r\nAfter some experiments on the extension stuff, I think it's not useful to have `Extension` in the file name.\r\nFor the Unit part, what do you think","created_at":"2016-11-14T15:20:34Z","updated_at":"2017-05-31T07:21:49Z","closed_at":"2017-05-31T06:32:32Z","merged_at":"2017-05-31T06:32:32Z","merge_commit_sha":"3be9f4e3b43a2de949e604a86ce2076f25dda63d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/28/commits","review_comments_url":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/28/comments","review_comment_url":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperoslo/android-playbook/issues/28/comments","statuses_url":"https://api.github.com/repos/hyperoslo/android-playbook/statuses/a58b6267f4599399571235b1d088bb5ced5a4920","head":{"label":"hyperoslo:improve/remove-and-add-some-rules","ref":"improve/remove-and-add-some-rules","sha":"a58b6267f4599399571235b1d088bb5ced5a4920","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars0.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":31943930,"name":"android-playbook","full_name":"hyperoslo/android-playbook","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars0.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/android-playbook","description":null,"fork":false,"url":"https://api.github.com/repos/hyperoslo/android-playbook","forks_url":"https://api.github.com/repos/hyperoslo/android-playbook/forks","keys_url":"https://api.github.com/repos/hyperoslo/android-playbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/android-playbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/android-playbook/teams","hooks_url":"https://api.github.com/repos/hyperoslo/android-playbook/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/android-playbook/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/android-playbook/events","assignees_url":"https://api.github.com/repos/hyperoslo/android-playbook/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/android-playbook/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/android-playbook/tags","blobs_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/android-playbook/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/android-playbook/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/android-playbook/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/android-playbook/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/android-playbook/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/android-playbook/subscription","commits_url":"https://api.github.com/repos/hyperoslo/android-playbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/android-playbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/android-playbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/android-playbook/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/android-playbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/android-playbook/merges","archive_url":"https://api.github.com/repos/hyperoslo/android-playbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/android-playbook/downloads","issues_url":"https://api.github.com/repos/hyperoslo/android-playbook/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/android-playbook/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/android-playbook/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/android-playbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/android-playbook/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/android-playbook/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/android-playbook/deployments","created_at":"2015-03-10T07:28:20Z","updated_at":"2017-01-29T12:47:29Z","pushed_at":"2017-05-31T06:52:40Z","git_url":"git://github.com/hyperoslo/android-playbook.git","ssh_url":"[email protected]:hyperoslo/android-playbook.git","clone_url":"https://github.com/hyperoslo/android-playbook.git","svn_url":"https://github.com/hyperoslo/android-playbook","homepage":null,"size":12,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":6,"default_branch":"master"}},"base":{"label":"hyperoslo:master","ref":"master","sha":"387b4546552a5f6545dc93d3f6d47d5fbd4f7d9c","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars0.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":31943930,"name":"android-playbook","full_name":"hyperoslo/android-playbook","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars0.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/android-playbook","description":null,"fork":false,"url":"https://api.github.com/repos/hyperoslo/android-playbook","forks_url":"https://api.github.com/repos/hyperoslo/android-playbook/forks","keys_url":"https://api.github.com/repos/hyperoslo/android-playbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/android-playbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/android-playbook/teams","hooks_url":"https://api.github.com/repos/hyperoslo/android-playbook/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/android-playbook/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/android-playbook/events","assignees_url":"https://api.github.com/repos/hyperoslo/android-playbook/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/android-playbook/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/android-playbook/tags","blobs_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/android-playbook/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/android-playbook/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/android-playbook/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/android-playbook/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/android-playbook/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/android-playbook/subscription","commits_url":"https://api.github.com/repos/hyperoslo/android-playbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/android-playbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/android-playbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/android-playbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/android-playbook/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/android-playbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/android-playbook/merges","archive_url":"https://api.github.com/repos/hyperoslo/android-playbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/android-playbook/downloads","issues_url":"https://api.github.com/repos/hyperoslo/android-playbook/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/android-playbook/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/android-playbook/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/android-playbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/android-playbook/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/android-playbook/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/android-playbook/deployments","created_at":"2015-03-10T07:28:20Z","updated_at":"2017-01-29T12:47:29Z","pushed_at":"2017-05-31T06:52:40Z","git_url":"git://github.com/hyperoslo/android-playbook.git","ssh_url":"[email protected]:hyperoslo/android-playbook.git","clone_url":"https://github.com/hyperoslo/android-playbook.git","svn_url":"https://github.com/hyperoslo/android-playbook","homepage":null,"size":12,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/28"},"html":{"href":"https://github.com/hyperoslo/android-playbook/pull/28"},"issue":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/issues/28"},"comments":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/hyperoslo/android-playbook/statuses/a58b6267f4599399571235b1d088bb5ced5a4920"}}}} | {
"id": 31943930,
"name": "hyperoslo/android-playbook",
"url": "https://api.github.com/repos/hyperoslo/android-playbook"
} | {
"id": 2284279,
"login": "onmyway133",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2284279?",
"url": "https://api.github.com/users/onmyway133"
} | {
"id": 1340892,
"login": "hyperoslo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1340892?",
"url": "https://api.github.com/orgs/hyperoslo"
} | 2017-05-31T07:21:49 | 5972488538 | {"actor":{"display_login":"onmyway133"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/comments/121068490","pull_request_review_id":43088831,"id":121068490,"diff_hunk":"@@ -19,16 +19,12 @@\n # deprecated parameter (will have no effect if set)\n #\n define jenkins::job::present(\n- $config = undef,\n- $config_file = undef,\n- $jobname = $title,\n- $enabled = undef,\n- $difftool = '/usr/bin/diff -b -q',\n+ Optional[String] $config = undef,\n+ Optional[String] $config_file = undef,\n+ String $jobname = $title,\n+ $enabled = undef,","path":"manifests/job/present.pp","position":12,"original_position":12,"commit_id":"22fa1ad60fe40e80304d426578f2edc5dedbb023","original_commit_id":"22fa1ad60fe40e80304d426578f2edc5dedbb023","user":{"login":"vStone","id":356719,"avatar_url":"https://avatars1.githubusercontent.com/u/356719?v=3","gravatar_id":"","url":"https://api.github.com/users/vStone","html_url":"https://github.com/vStone","followers_url":"https://api.github.com/users/vStone/followers","following_url":"https://api.github.com/users/vStone/following{/other_user}","gists_url":"https://api.github.com/users/vStone/gists{/gist_id}","starred_url":"https://api.github.com/users/vStone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vStone/subscriptions","organizations_url":"https://api.github.com/users/vStone/orgs","repos_url":"https://api.github.com/users/vStone/repos","events_url":"https://api.github.com/users/vStone/events{/privacy}","received_events_url":"https://api.github.com/users/vStone/received_events","type":"User","site_admin":false},"body":"I prefer `Any`","created_at":"2017-06-09T07:57:11Z","updated_at":"2017-06-09T07:58:31Z","html_url":"https://github.com/jenkinsci/puppet-jenkins/pull/742#discussion_r121068490","pull_request_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/742","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/comments/121068490"},"html":{"href":"https://github.com/jenkinsci/puppet-jenkins/pull/742#discussion_r121068490"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/742"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/742","id":113219471,"html_url":"https://github.com/jenkinsci/puppet-jenkins/pull/742","diff_url":"https://github.com/jenkinsci/puppet-jenkins/pull/742.diff","patch_url":"https://github.com/jenkinsci/puppet-jenkins/pull/742.patch","issue_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/issues/742","number":742,"state":"open","locked":false,"title":"Replace legacy validate_* calls with puppet4 datatypes","user":{"login":"bastelfreak","id":341866,"avatar_url":"https://avatars3.githubusercontent.com/u/341866?v=3","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"body":"So Puppet 3 is end of life since december 2016. Also Puppetlabs deprecated all the validate_* functions in stdlib. This Pull Requests replaces all the legacy code with datatypes.","created_at":"2017-03-29T15:00:10Z","updated_at":"2017-06-09T07:58:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75512440303f61e2477f825d2254d33a2222c8b3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/742/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/742/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/issues/742/comments","statuses_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/statuses/22fa1ad60fe40e80304d426578f2edc5dedbb023","head":{"label":"bastelfreak:puppet4","ref":"puppet4","sha":"22fa1ad60fe40e80304d426578f2edc5dedbb023","user":{"login":"bastelfreak","id":341866,"avatar_url":"https://avatars3.githubusercontent.com/u/341866?v=3","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"repo":{"id":86574152,"name":"puppet-jenkins","full_name":"bastelfreak/puppet-jenkins","owner":{"login":"bastelfreak","id":341866,"avatar_url":"https://avatars3.githubusercontent.com/u/341866?v=3","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bastelfreak/puppet-jenkins","description":"Puppet module for Jenkins","fork":true,"url":"https://api.github.com/repos/bastelfreak/puppet-jenkins","forks_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/forks","keys_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/teams","hooks_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/hooks","issue_events_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/events","assignees_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/tags","blobs_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/languages","stargazers_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/stargazers","contributors_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/contributors","subscribers_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/subscribers","subscription_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/subscription","commits_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/merges","archive_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/downloads","issues_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/labels{/name}","releases_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/bastelfreak/puppet-jenkins/deployments","created_at":"2017-03-29T11:28:27Z","updated_at":"2017-03-29T11:28:29Z","pushed_at":"2017-06-07T13:11:06Z","git_url":"git://github.com/bastelfreak/puppet-jenkins.git","ssh_url":"[email protected]:bastelfreak/puppet-jenkins.git","clone_url":"https://github.com/bastelfreak/puppet-jenkins.git","svn_url":"https://github.com/bastelfreak/puppet-jenkins","homepage":"http://forge.puppetlabs.com/rtyler/jenkins","size":1578,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"5b86f741105aba973917741874c55d17cec27674","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":9735844,"name":"puppet-jenkins","full_name":"jenkinsci/puppet-jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/puppet-jenkins","description":"Puppet module for Jenkins","fork":false,"url":"https://api.github.com/repos/jenkinsci/puppet-jenkins","forks_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/puppet-jenkins/deployments","created_at":"2013-04-28T20:34:40Z","updated_at":"2017-06-06T17:37:09Z","pushed_at":"2017-06-08T16:18:31Z","git_url":"git://github.com/jenkinsci/puppet-jenkins.git","ssh_url":"[email protected]:jenkinsci/puppet-jenkins.git","clone_url":"https://github.com/jenkinsci/puppet-jenkins.git","svn_url":"https://github.com/jenkinsci/puppet-jenkins","homepage":"http://forge.puppetlabs.com/rtyler/jenkins","size":1559,"stargazers_count":251,"watchers_count":251,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"open_issues_count":124,"forks":503,"open_issues":124,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/742"},"html":{"href":"https://github.com/jenkinsci/puppet-jenkins/pull/742"},"issue":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/issues/742"},"comments":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/issues/742/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/742/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/pulls/742/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/puppet-jenkins/statuses/22fa1ad60fe40e80304d426578f2edc5dedbb023"}}}} | {
"id": 9735844,
"name": "jenkinsci/puppet-jenkins",
"url": "https://api.github.com/repos/jenkinsci/puppet-jenkins"
} | {
"id": 356719,
"login": "vStone",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/356719?",
"url": "https://api.github.com/users/vStone"
} | {
"id": 107424,
"login": "jenkinsci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/107424?",
"url": "https://api.github.com/orgs/jenkinsci"
} | 2017-06-09T07:57:11 | 6033325871 | {"actor":{"display_login":"vStone"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/comments/116826393","pull_request_review_id":38477784,"id":116826393,"diff_hunk":"@@ -64,13 +62,16 @@ public static SettlersFolderInfo checkSettlersFolder(String settlersBaseFolder)\n \n \t\tfor (File f : files) {\n \t\t\tif (f.getName().equalsIgnoreCase(\"snd\")) {\n-\t\t\t\tFile testSndFile = new File(f, \"Siedler3_00.dat\");\n-\t\t\t\tif (testSndFile.exists()) {\n-\t\t\t\t\tsndFolder = f;\n+\t\t\t\tfor (File g : f.listFiles()) {\n+\t\t\t\t\tg.getName();\n+\t\t\t\t\tif (g.getName().equalsIgnoreCase(\"siedler3_00.dat\")) {\n+\t\t\t\t\t\tsndFolder = f;\n+\t\t\t\t\t}\n \t\t\t\t}\n \t\t\t} else if (f.getName().equalsIgnoreCase(\"gfx\")) {\n-\t\t\t\tfor (DatFileType t : DatFileType.values()) {\n-\t\t\t\t\tif (new File(f, \"siedler3_00\" + t.getFileSuffix()).exists()) {\n+\t\t\t\tfor (File g : f.listFiles()) {\n+\t\t\t\t\tString a = g.getName();\n+\t\t\t\t\tif (a.substring(0, a.indexOf('.')).equalsIgnoreCase(\"siedler3_00\")) {","path":"jsettlers.main.swing/src/main/java/jsettlers/main/swing/resources/SettlersFolderChecker.java","position":27,"original_position":27,"commit_id":"abaf72147024f58c9240be9a62006b6ae572fa91","original_commit_id":"abaf72147024f58c9240be9a62006b6ae572fa91","user":{"login":"andreas-eberle","id":9267365,"avatar_url":"https://avatars3.githubusercontent.com/u/9267365?v=3","gravatar_id":"","url":"https://api.github.com/users/andreas-eberle","html_url":"https://github.com/andreas-eberle","followers_url":"https://api.github.com/users/andreas-eberle/followers","following_url":"https://api.github.com/users/andreas-eberle/following{/other_user}","gists_url":"https://api.github.com/users/andreas-eberle/gists{/gist_id}","starred_url":"https://api.github.com/users/andreas-eberle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreas-eberle/subscriptions","organizations_url":"https://api.github.com/users/andreas-eberle/orgs","repos_url":"https://api.github.com/users/andreas-eberle/repos","events_url":"https://api.github.com/users/andreas-eberle/events{/privacy}","received_events_url":"https://api.github.com/users/andreas-eberle/received_events","type":"User","site_admin":false},"body":"Same as above.","created_at":"2017-05-16T18:49:28Z","updated_at":"2017-05-16T18:52:29Z","html_url":"https://github.com/jsettlers/settlers-remake/pull/567#discussion_r116826393","pull_request_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/567","_links":{"self":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/comments/116826393"},"html":{"href":"https://github.com/jsettlers/settlers-remake/pull/567#discussion_r116826393"},"pull_request":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/567"}}},"pull_request":{"url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/567","id":120086530,"html_url":"https://github.com/jsettlers/settlers-remake/pull/567","diff_url":"https://github.com/jsettlers/settlers-remake/pull/567.diff","patch_url":"https://github.com/jsettlers/settlers-remake/pull/567.patch","issue_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues/567","number":567,"state":"open","locked":false,"title":"issue #489 resolved","user":{"login":"rpolzer","id":19792901,"avatar_url":"https://avatars1.githubusercontent.com/u/19792901?v=3","gravatar_id":"","url":"https://api.github.com/users/rpolzer","html_url":"https://github.com/rpolzer","followers_url":"https://api.github.com/users/rpolzer/followers","following_url":"https://api.github.com/users/rpolzer/following{/other_user}","gists_url":"https://api.github.com/users/rpolzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rpolzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpolzer/subscriptions","organizations_url":"https://api.github.com/users/rpolzer/orgs","repos_url":"https://api.github.com/users/rpolzer/repos","events_url":"https://api.github.com/users/rpolzer/events{/privacy}","received_events_url":"https://api.github.com/users/rpolzer/received_events","type":"User","site_admin":false},"body":"resolves issue #489: gfx files may have arbitrary upper or lower case file names","created_at":"2017-05-11T11:45:50Z","updated_at":"2017-05-16T18:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37120b4e264e2c98973f380c73145fa116932de7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/567/commits","review_comments_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/567/comments","review_comment_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues/567/comments","statuses_url":"https://api.github.com/repos/jsettlers/settlers-remake/statuses/abaf72147024f58c9240be9a62006b6ae572fa91","head":{"label":"rpolzer:issue489","ref":"issue489","sha":"abaf72147024f58c9240be9a62006b6ae572fa91","user":{"login":"rpolzer","id":19792901,"avatar_url":"https://avatars1.githubusercontent.com/u/19792901?v=3","gravatar_id":"","url":"https://api.github.com/users/rpolzer","html_url":"https://github.com/rpolzer","followers_url":"https://api.github.com/users/rpolzer/followers","following_url":"https://api.github.com/users/rpolzer/following{/other_user}","gists_url":"https://api.github.com/users/rpolzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rpolzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpolzer/subscriptions","organizations_url":"https://api.github.com/users/rpolzer/orgs","repos_url":"https://api.github.com/users/rpolzer/repos","events_url":"https://api.github.com/users/rpolzer/events{/privacy}","received_events_url":"https://api.github.com/users/rpolzer/received_events","type":"User","site_admin":false},"repo":{"id":73522071,"name":"settlers-remake","full_name":"rpolzer/settlers-remake","owner":{"login":"rpolzer","id":19792901,"avatar_url":"https://avatars1.githubusercontent.com/u/19792901?v=3","gravatar_id":"","url":"https://api.github.com/users/rpolzer","html_url":"https://github.com/rpolzer","followers_url":"https://api.github.com/users/rpolzer/followers","following_url":"https://api.github.com/users/rpolzer/following{/other_user}","gists_url":"https://api.github.com/users/rpolzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rpolzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpolzer/subscriptions","organizations_url":"https://api.github.com/users/rpolzer/orgs","repos_url":"https://api.github.com/users/rpolzer/repos","events_url":"https://api.github.com/users/rpolzer/events{/privacy}","received_events_url":"https://api.github.com/users/rpolzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpolzer/settlers-remake","description":"A Remake of \"The Settlers III\" for Windows, Linux, Mac and Android","fork":true,"url":"https://api.github.com/repos/rpolzer/settlers-remake","forks_url":"https://api.github.com/repos/rpolzer/settlers-remake/forks","keys_url":"https://api.github.com/repos/rpolzer/settlers-remake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpolzer/settlers-remake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpolzer/settlers-remake/teams","hooks_url":"https://api.github.com/repos/rpolzer/settlers-remake/hooks","issue_events_url":"https://api.github.com/repos/rpolzer/settlers-remake/issues/events{/number}","events_url":"https://api.github.com/repos/rpolzer/settlers-remake/events","assignees_url":"https://api.github.com/repos/rpolzer/settlers-remake/assignees{/user}","branches_url":"https://api.github.com/repos/rpolzer/settlers-remake/branches{/branch}","tags_url":"https://api.github.com/repos/rpolzer/settlers-remake/tags","blobs_url":"https://api.github.com/repos/rpolzer/settlers-remake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpolzer/settlers-remake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpolzer/settlers-remake/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpolzer/settlers-remake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpolzer/settlers-remake/statuses/{sha}","languages_url":"https://api.github.com/repos/rpolzer/settlers-remake/languages","stargazers_url":"https://api.github.com/repos/rpolzer/settlers-remake/stargazers","contributors_url":"https://api.github.com/repos/rpolzer/settlers-remake/contributors","subscribers_url":"https://api.github.com/repos/rpolzer/settlers-remake/subscribers","subscription_url":"https://api.github.com/repos/rpolzer/settlers-remake/subscription","commits_url":"https://api.github.com/repos/rpolzer/settlers-remake/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpolzer/settlers-remake/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpolzer/settlers-remake/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpolzer/settlers-remake/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpolzer/settlers-remake/contents/{+path}","compare_url":"https://api.github.com/repos/rpolzer/settlers-remake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpolzer/settlers-remake/merges","archive_url":"https://api.github.com/repos/rpolzer/settlers-remake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpolzer/settlers-remake/downloads","issues_url":"https://api.github.com/repos/rpolzer/settlers-remake/issues{/number}","pulls_url":"https://api.github.com/repos/rpolzer/settlers-remake/pulls{/number}","milestones_url":"https://api.github.com/repos/rpolzer/settlers-remake/milestones{/number}","notifications_url":"https://api.github.com/repos/rpolzer/settlers-remake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpolzer/settlers-remake/labels{/name}","releases_url":"https://api.github.com/repos/rpolzer/settlers-remake/releases{/id}","deployments_url":"https://api.github.com/repos/rpolzer/settlers-remake/deployments","created_at":"2016-11-12T00:34:40Z","updated_at":"2016-11-12T00:34:48Z","pushed_at":"2017-05-16T18:42:07Z","git_url":"git://github.com/rpolzer/settlers-remake.git","ssh_url":"[email protected]:rpolzer/settlers-remake.git","clone_url":"https://github.com/rpolzer/settlers-remake.git","svn_url":"https://github.com/rpolzer/settlers-remake","homepage":"http://www.settlers-android-clone.com","size":428856,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsettlers:master","ref":"master","sha":"8f391e02c644165742de31c067a0aeb57b997dff","user":{"login":"jsettlers","id":10380489,"avatar_url":"https://avatars0.githubusercontent.com/u/10380489?v=3","gravatar_id":"","url":"https://api.github.com/users/jsettlers","html_url":"https://github.com/jsettlers","followers_url":"https://api.github.com/users/jsettlers/followers","following_url":"https://api.github.com/users/jsettlers/following{/other_user}","gists_url":"https://api.github.com/users/jsettlers/gists{/gist_id}","starred_url":"https://api.github.com/users/jsettlers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsettlers/subscriptions","organizations_url":"https://api.github.com/users/jsettlers/orgs","repos_url":"https://api.github.com/users/jsettlers/repos","events_url":"https://api.github.com/users/jsettlers/events{/privacy}","received_events_url":"https://api.github.com/users/jsettlers/received_events","type":"Organization","site_admin":false},"repo":{"id":25301488,"name":"settlers-remake","full_name":"jsettlers/settlers-remake","owner":{"login":"jsettlers","id":10380489,"avatar_url":"https://avatars0.githubusercontent.com/u/10380489?v=3","gravatar_id":"","url":"https://api.github.com/users/jsettlers","html_url":"https://github.com/jsettlers","followers_url":"https://api.github.com/users/jsettlers/followers","following_url":"https://api.github.com/users/jsettlers/following{/other_user}","gists_url":"https://api.github.com/users/jsettlers/gists{/gist_id}","starred_url":"https://api.github.com/users/jsettlers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsettlers/subscriptions","organizations_url":"https://api.github.com/users/jsettlers/orgs","repos_url":"https://api.github.com/users/jsettlers/repos","events_url":"https://api.github.com/users/jsettlers/events{/privacy}","received_events_url":"https://api.github.com/users/jsettlers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsettlers/settlers-remake","description":"A Remake of \"The Settlers III\" for Windows, Linux, Mac and Android","fork":false,"url":"https://api.github.com/repos/jsettlers/settlers-remake","forks_url":"https://api.github.com/repos/jsettlers/settlers-remake/forks","keys_url":"https://api.github.com/repos/jsettlers/settlers-remake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsettlers/settlers-remake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsettlers/settlers-remake/teams","hooks_url":"https://api.github.com/repos/jsettlers/settlers-remake/hooks","issue_events_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues/events{/number}","events_url":"https://api.github.com/repos/jsettlers/settlers-remake/events","assignees_url":"https://api.github.com/repos/jsettlers/settlers-remake/assignees{/user}","branches_url":"https://api.github.com/repos/jsettlers/settlers-remake/branches{/branch}","tags_url":"https://api.github.com/repos/jsettlers/settlers-remake/tags","blobs_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsettlers/settlers-remake/statuses/{sha}","languages_url":"https://api.github.com/repos/jsettlers/settlers-remake/languages","stargazers_url":"https://api.github.com/repos/jsettlers/settlers-remake/stargazers","contributors_url":"https://api.github.com/repos/jsettlers/settlers-remake/contributors","subscribers_url":"https://api.github.com/repos/jsettlers/settlers-remake/subscribers","subscription_url":"https://api.github.com/repos/jsettlers/settlers-remake/subscription","commits_url":"https://api.github.com/repos/jsettlers/settlers-remake/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsettlers/settlers-remake/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsettlers/settlers-remake/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsettlers/settlers-remake/contents/{+path}","compare_url":"https://api.github.com/repos/jsettlers/settlers-remake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsettlers/settlers-remake/merges","archive_url":"https://api.github.com/repos/jsettlers/settlers-remake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsettlers/settlers-remake/downloads","issues_url":"https://api.github.com/repos/jsettlers/settlers-remake/issues{/number}","pulls_url":"https://api.github.com/repos/jsettlers/settlers-remake/pulls{/number}","milestones_url":"https://api.github.com/repos/jsettlers/settlers-remake/milestones{/number}","notifications_url":"https://api.github.com/repos/jsettlers/settlers-remake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsettlers/settlers-remake/labels{/name}","releases_url":"https://api.github.com/repos/jsettlers/settlers-remake/releases{/id}","deployments_url":"https://api.github.com/repos/jsettlers/settlers-remake/deployments","created_at":"2014-10-16T12:41:40Z","updated_at":"2017-05-14T14:13:45Z","pushed_at":"2017-05-16T18:42:08Z","git_url":"git://github.com/jsettlers/settlers-remake.git","ssh_url":"[email protected]:jsettlers/settlers-remake.git","clone_url":"https://github.com/jsettlers/settlers-remake.git","svn_url":"https://github.com/jsettlers/settlers-remake","homepage":"http://www.settlers-android-clone.com","size":427681,"stargazers_count":162,"watchers_count":162,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":115,"forks":64,"open_issues":115,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/567"},"html":{"href":"https://github.com/jsettlers/settlers-remake/pull/567"},"issue":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/issues/567"},"comments":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/issues/567/comments"},"review_comments":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/567/comments"},"review_comment":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/pulls/567/commits"},"statuses":{"href":"https://api.github.com/repos/jsettlers/settlers-remake/statuses/abaf72147024f58c9240be9a62006b6ae572fa91"}}}} | {
"id": 25301488,
"name": "jsettlers/settlers-remake",
"url": "https://api.github.com/repos/jsettlers/settlers-remake"
} | {
"id": 9267365,
"login": "andreas-eberle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9267365?",
"url": "https://api.github.com/users/andreas-eberle"
} | {
"id": 10380489,
"login": "jsettlers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10380489?",
"url": "https://api.github.com/orgs/jsettlers"
} | 2017-05-16T18:49:28 | 5883965695 | {"actor":{"display_login":"andreas-eberle"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kaliberjs/build/pulls/comments/144125714","pull_request_review_id":68737154,"id":144125714,"diff_hunk":"@@ -0,0 +1,5 @@\n+module.exports = `","path":"template/src/robots.txt.js","position":1,"original_position":1,"commit_id":"db5dc4c32e572f50bddddbd79caf1532c6d43de1","original_commit_id":"db5dc4c32e572f50bddddbd79caf1532c6d43de1","user":{"login":"EECOLOR","id":1486362,"avatar_url":"https://avatars2.githubusercontent.com/u/1486362?v=4","gravatar_id":"","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"body":"This can be just the text-file. We could add the `sitemap.xml.js`.","created_at":"2017-10-11T20:24:34Z","updated_at":"2017-10-11T20:31:34Z","html_url":"https://github.com/kaliberjs/build/pull/87#discussion_r144125714","pull_request_url":"https://api.github.com/repos/kaliberjs/build/pulls/87","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kaliberjs/build/pulls/comments/144125714"},"html":{"href":"https://github.com/kaliberjs/build/pull/87#discussion_r144125714"},"pull_request":{"href":"https://api.github.com/repos/kaliberjs/build/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/kaliberjs/build/pulls/87","id":145880169,"html_url":"https://github.com/kaliberjs/build/pull/87","diff_url":"https://github.com/kaliberjs/build/pull/87.diff","patch_url":"https://github.com/kaliberjs/build/pull/87.patch","issue_url":"https://api.github.com/repos/kaliberjs/build/issues/87","number":87,"state":"open","locked":false,"title":"Add scaffold template","user":{"login":"klaasman","id":85814,"avatar_url":"https://avatars0.githubusercontent.com/u/85814?v=4","gravatar_id":"","url":"https://api.github.com/users/klaasman","html_url":"https://github.com/klaasman","followers_url":"https://api.github.com/users/klaasman/followers","following_url":"https://api.github.com/users/klaasman/following{/other_user}","gists_url":"https://api.github.com/users/klaasman/gists{/gist_id}","starred_url":"https://api.github.com/users/klaasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaasman/subscriptions","organizations_url":"https://api.github.com/users/klaasman/orgs","repos_url":"https://api.github.com/users/klaasman/repos","events_url":"https://api.github.com/users/klaasman/events{/privacy}","received_events_url":"https://api.github.com/users/klaasman/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-11T08:02:43Z","updated_at":"2017-10-11T20:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ef266f05f6e3aa47f1dcc9e158ca3f013ebe030","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaliberjs/build/pulls/87/commits","review_comments_url":"https://api.github.com/repos/kaliberjs/build/pulls/87/comments","review_comment_url":"https://api.github.com/repos/kaliberjs/build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaliberjs/build/issues/87/comments","statuses_url":"https://api.github.com/repos/kaliberjs/build/statuses/db5dc4c32e572f50bddddbd79caf1532c6d43de1","head":{"label":"kaliberjs:feature/scaffold","ref":"feature/scaffold","sha":"db5dc4c32e572f50bddddbd79caf1532c6d43de1","user":{"login":"kaliberjs","id":22936857,"avatar_url":"https://avatars2.githubusercontent.com/u/22936857?v=4","gravatar_id":"","url":"https://api.github.com/users/kaliberjs","html_url":"https://github.com/kaliberjs","followers_url":"https://api.github.com/users/kaliberjs/followers","following_url":"https://api.github.com/users/kaliberjs/following{/other_user}","gists_url":"https://api.github.com/users/kaliberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/kaliberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaliberjs/subscriptions","organizations_url":"https://api.github.com/users/kaliberjs/orgs","repos_url":"https://api.github.com/users/kaliberjs/repos","events_url":"https://api.github.com/users/kaliberjs/events{/privacy}","received_events_url":"https://api.github.com/users/kaliberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":88908259,"name":"build","full_name":"kaliberjs/build","owner":{"login":"kaliberjs","id":22936857,"avatar_url":"https://avatars2.githubusercontent.com/u/22936857?v=4","gravatar_id":"","url":"https://api.github.com/users/kaliberjs","html_url":"https://github.com/kaliberjs","followers_url":"https://api.github.com/users/kaliberjs/followers","following_url":"https://api.github.com/users/kaliberjs/following{/other_user}","gists_url":"https://api.github.com/users/kaliberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/kaliberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaliberjs/subscriptions","organizations_url":"https://api.github.com/users/kaliberjs/orgs","repos_url":"https://api.github.com/users/kaliberjs/repos","events_url":"https://api.github.com/users/kaliberjs/events{/privacy}","received_events_url":"https://api.github.com/users/kaliberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaliberjs/build","description":"Zero configuration, modern, opinionated build tools ","fork":false,"url":"https://api.github.com/repos/kaliberjs/build","forks_url":"https://api.github.com/repos/kaliberjs/build/forks","keys_url":"https://api.github.com/repos/kaliberjs/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaliberjs/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaliberjs/build/teams","hooks_url":"https://api.github.com/repos/kaliberjs/build/hooks","issue_events_url":"https://api.github.com/repos/kaliberjs/build/issues/events{/number}","events_url":"https://api.github.com/repos/kaliberjs/build/events","assignees_url":"https://api.github.com/repos/kaliberjs/build/assignees{/user}","branches_url":"https://api.github.com/repos/kaliberjs/build/branches{/branch}","tags_url":"https://api.github.com/repos/kaliberjs/build/tags","blobs_url":"https://api.github.com/repos/kaliberjs/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaliberjs/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaliberjs/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaliberjs/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaliberjs/build/statuses/{sha}","languages_url":"https://api.github.com/repos/kaliberjs/build/languages","stargazers_url":"https://api.github.com/repos/kaliberjs/build/stargazers","contributors_url":"https://api.github.com/repos/kaliberjs/build/contributors","subscribers_url":"https://api.github.com/repos/kaliberjs/build/subscribers","subscription_url":"https://api.github.com/repos/kaliberjs/build/subscription","commits_url":"https://api.github.com/repos/kaliberjs/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaliberjs/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaliberjs/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaliberjs/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaliberjs/build/contents/{+path}","compare_url":"https://api.github.com/repos/kaliberjs/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaliberjs/build/merges","archive_url":"https://api.github.com/repos/kaliberjs/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaliberjs/build/downloads","issues_url":"https://api.github.com/repos/kaliberjs/build/issues{/number}","pulls_url":"https://api.github.com/repos/kaliberjs/build/pulls{/number}","milestones_url":"https://api.github.com/repos/kaliberjs/build/milestones{/number}","notifications_url":"https://api.github.com/repos/kaliberjs/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaliberjs/build/labels{/name}","releases_url":"https://api.github.com/repos/kaliberjs/build/releases{/id}","deployments_url":"https://api.github.com/repos/kaliberjs/build/deployments","created_at":"2017-04-20T20:35:48Z","updated_at":"2017-04-20T20:40:13Z","pushed_at":"2017-10-11T18:31:01Z","git_url":"git://github.com/kaliberjs/build.git","ssh_url":"[email protected]:kaliberjs/build.git","clone_url":"https://github.com/kaliberjs/build.git","svn_url":"https://github.com/kaliberjs/build","homepage":null,"size":884,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":0,"default_branch":"master"}},"base":{"label":"kaliberjs:master","ref":"master","sha":"606d372379ab59c031676f2cfe26d9c69a0edf5b","user":{"login":"kaliberjs","id":22936857,"avatar_url":"https://avatars2.githubusercontent.com/u/22936857?v=4","gravatar_id":"","url":"https://api.github.com/users/kaliberjs","html_url":"https://github.com/kaliberjs","followers_url":"https://api.github.com/users/kaliberjs/followers","following_url":"https://api.github.com/users/kaliberjs/following{/other_user}","gists_url":"https://api.github.com/users/kaliberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/kaliberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaliberjs/subscriptions","organizations_url":"https://api.github.com/users/kaliberjs/orgs","repos_url":"https://api.github.com/users/kaliberjs/repos","events_url":"https://api.github.com/users/kaliberjs/events{/privacy}","received_events_url":"https://api.github.com/users/kaliberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":88908259,"name":"build","full_name":"kaliberjs/build","owner":{"login":"kaliberjs","id":22936857,"avatar_url":"https://avatars2.githubusercontent.com/u/22936857?v=4","gravatar_id":"","url":"https://api.github.com/users/kaliberjs","html_url":"https://github.com/kaliberjs","followers_url":"https://api.github.com/users/kaliberjs/followers","following_url":"https://api.github.com/users/kaliberjs/following{/other_user}","gists_url":"https://api.github.com/users/kaliberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/kaliberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaliberjs/subscriptions","organizations_url":"https://api.github.com/users/kaliberjs/orgs","repos_url":"https://api.github.com/users/kaliberjs/repos","events_url":"https://api.github.com/users/kaliberjs/events{/privacy}","received_events_url":"https://api.github.com/users/kaliberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaliberjs/build","description":"Zero configuration, modern, opinionated build tools ","fork":false,"url":"https://api.github.com/repos/kaliberjs/build","forks_url":"https://api.github.com/repos/kaliberjs/build/forks","keys_url":"https://api.github.com/repos/kaliberjs/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaliberjs/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaliberjs/build/teams","hooks_url":"https://api.github.com/repos/kaliberjs/build/hooks","issue_events_url":"https://api.github.com/repos/kaliberjs/build/issues/events{/number}","events_url":"https://api.github.com/repos/kaliberjs/build/events","assignees_url":"https://api.github.com/repos/kaliberjs/build/assignees{/user}","branches_url":"https://api.github.com/repos/kaliberjs/build/branches{/branch}","tags_url":"https://api.github.com/repos/kaliberjs/build/tags","blobs_url":"https://api.github.com/repos/kaliberjs/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaliberjs/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaliberjs/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaliberjs/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaliberjs/build/statuses/{sha}","languages_url":"https://api.github.com/repos/kaliberjs/build/languages","stargazers_url":"https://api.github.com/repos/kaliberjs/build/stargazers","contributors_url":"https://api.github.com/repos/kaliberjs/build/contributors","subscribers_url":"https://api.github.com/repos/kaliberjs/build/subscribers","subscription_url":"https://api.github.com/repos/kaliberjs/build/subscription","commits_url":"https://api.github.com/repos/kaliberjs/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaliberjs/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaliberjs/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaliberjs/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaliberjs/build/contents/{+path}","compare_url":"https://api.github.com/repos/kaliberjs/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaliberjs/build/merges","archive_url":"https://api.github.com/repos/kaliberjs/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaliberjs/build/downloads","issues_url":"https://api.github.com/repos/kaliberjs/build/issues{/number}","pulls_url":"https://api.github.com/repos/kaliberjs/build/pulls{/number}","milestones_url":"https://api.github.com/repos/kaliberjs/build/milestones{/number}","notifications_url":"https://api.github.com/repos/kaliberjs/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaliberjs/build/labels{/name}","releases_url":"https://api.github.com/repos/kaliberjs/build/releases{/id}","deployments_url":"https://api.github.com/repos/kaliberjs/build/deployments","created_at":"2017-04-20T20:35:48Z","updated_at":"2017-04-20T20:40:13Z","pushed_at":"2017-10-11T18:31:01Z","git_url":"git://github.com/kaliberjs/build.git","ssh_url":"[email protected]:kaliberjs/build.git","clone_url":"https://github.com/kaliberjs/build.git","svn_url":"https://github.com/kaliberjs/build","homepage":null,"size":884,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaliberjs/build/pulls/87"},"html":{"href":"https://github.com/kaliberjs/build/pull/87"},"issue":{"href":"https://api.github.com/repos/kaliberjs/build/issues/87"},"comments":{"href":"https://api.github.com/repos/kaliberjs/build/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/kaliberjs/build/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/kaliberjs/build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaliberjs/build/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/kaliberjs/build/statuses/db5dc4c32e572f50bddddbd79caf1532c6d43de1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 88908259,
"name": "kaliberjs/build",
"url": "https://api.github.com/repos/kaliberjs/build"
} | {
"id": 1486362,
"login": "EECOLOR",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1486362?",
"url": "https://api.github.com/users/EECOLOR"
} | {
"id": 22936857,
"login": "kaliberjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22936857?",
"url": "https://api.github.com/orgs/kaliberjs"
} | 2017-10-11T20:24:34 | 6704656182 | {"actor":{"display_login":"EECOLOR"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/liquidweb/hello-server/pulls/comments/123805602","pull_request_review_id":46047440,"id":123805602,"diff_hunk":"@@ -45,74 +43,233 @@\n *\n * PHP version 5.6-7.1\n *\n- *\n- * @package Hello_Server\n+ * @package Hello_Server\n+ * @version 1.2.1\n * @author Dan Pock <[email protected]>\n * @copyright 2017 Liquid Web\n * @license http://www.gnu.org/licenses/gpl-2.0.txt GPL-2.0\n * @link https://github.com/liquidweb/hello-server\n */\n \n-function hello_server_get_info() {\n-\t$info = get_transient('hello_server_info_cache_'.$_SERVER[\"SERVER_ADDR\"]);\n-\tif (false === $info) {\n-\t\t// It wasn't there, so regenerate the data and save the transient\n-\t\t$info = [\n-\t\t\t'ip' => get_server_ip(),\n-\t\t\t'hostname' => gethostname()\n-\t\t];\n-\t\tset_transient('hello_server_info_cache_'.$_SERVER[\"SERVER_ADDR\"], $info, 24 * HOUR_IN_SECONDS);\n+\n+/**\n+ * Load our textdomain for internationalization support.\n+ *\n+ * @return void\n+ */\n+function lw_load_plugins_textdomain() {\n+\tload_plugin_textdomain( 'hello-server', false, dirname( dirname( plugin_basename( __FILE__ ) ) ) . '/languages/' );\n+}\n+add_action( 'plugins_loaded', 'lw_load_plugins_textdomain' );\n+\n+/**\n+ * Pull our server info for display use.\n+ *\n+ * @return array $info The IP and hostname being displayed.\n+ */\n+function lw_hello_server_get_info() {\n+\n+\t// Bail if we don't have a server address.\n+\tif ( empty( $_SERVER['SERVER_ADDR'] ) ) {\n+\t\treturn false;\n+\t}\n+\n+\t// Set our transient key for use later.\n+\t$cache_key = 'hello_server_info_cache_' . sanitize_text_field( wp_unslash( $_SERVER['SERVER_ADDR'] ) );\n+\n+\t// If we don't want the cache'd version, delete the transient first.\n+\tif ( defined( 'WP_DEBUG' ) && WP_DEBUG ) {\n+\t\twp_cache_delete( $cache_key );\n \t}\n-\treturn $info;\n+\n+\t// It wasn't there, so regenerate the data and save the transient.\n+\tif ( false === $data = wp_cache_get( $cache_key ) ) {\n+\n+\t\t// Get our software name with a fallback.\n+\t\t$svsoft = ! empty( $_SERVER['SERVER_SOFTWARE'] ) ? sanitize_text_field( wp_unslash( $_SERVER['SERVER_SOFTWARE'] ) ) : __( 'unknown', 'hello-server' );\n+\n+\t\t// Build my PHP version string.\n+\t\t$phpver = absint( PHP_MAJOR_VERSION ) . '.' . absint( PHP_MINOR_VERSION ) . '.' . absint( PHP_RELEASE_VERSION );\n+\n+\t\t// Set up our array of info.\n+\t\t$data = array(\n+\t\t\t'address' => lw_get_server_ip(),\n+\t\t\t'software' => $svsoft,\n+\t\t\t'hostname' => gethostname(),\n+\t\t\t'phpvers' => esc_attr( $phpver ),\n+\t\t);\n+\n+\t\t// Store our data in the transient.\n+\t\twp_cache_set( $cache_key, $data, '', DAY_IN_SECONDS );\n+\t}\n+\n+\t// Return our array of data.\n+\treturn $data;\n }\n \n-function get_server_ip() {\n-\t$serverIp = $_SERVER[\"SERVER_ADDR\"];\n-\tif ($serverIp === '127.0.0.1') {\n-\t $resIp = gethostbyname(gethostname());\n-\t if (filter_var($resIp, FILTER_VALIDATE_IP) === true) {\n-\t\t return $resIp;\n-\t }\n+/**\n+ * Get our server IP address by checking various PHP vars.\n+ *\n+ * @return string\n+ */\n+function lw_get_server_ip() {\n+\n+\t// Bail if we don't have a server address.\n+\tif ( empty( $_SERVER['SERVER_ADDR'] ) ) {\n+\t\treturn false;\n \t}\n-\treturn $serverIp;\n+\n+\t// Fetch our server address.\n+\t$server_ip = sanitize_text_field( wp_unslash( $_SERVER['SERVER_ADDR'] ) );\n+\n+\t// If we're on a local, do some additional checks.\n+\tif ( '127.0.0.1' === $server_ip ) {\n+\n+\t\t// Get our hostname data.\n+\t\t$res_ip = gethostbyname( gethostname() );\n+\n+\t\t// Run a validation check on our IP to make sure it's legit.\n+\t\tif ( filter_var( $res_ip, FILTER_VALIDATE_IP ) === true ) {\n+\t\t\treturn $res_ip;\n+\t\t}\n+\t}\n+\n+\t// Return our IP.\n+\treturn $server_ip;\n }\n \n-// This just echoes the chosen line, we'll position it later\n-function hello_server( $wp_admin_bar ) {\n-\t$serverInfo = hello_server_get_info();\n-\t$mainNode = [\n-\t 'id' => 'lw_hello_server',\n-\t 'title' => __(\"Hello, Server\", \"hello-server\"),\n-\t 'meta' => ['title' => __('View the current server info.', \"hello-server\"), 'class' => 'menupop']\n-\n-\t];\n-\t$hostNode = [\n-\t 'id' => 'lw_host_server',\n- 'title' => \"Hello, I'm: <span itemprop='server-name'>\".$serverInfo['hostname'] . \"</span>!\",\n-\t 'meta' => ['title' => 'View the current server hostname.'],\n-\t 'parent' => 'lw_hello_server'\n-\t];\n-\t$ipNode = [\n-\t 'id' => 'lw_server_ip',\n-\t 'title' => 'My IP is: '.$serverInfo['ip'],\n-\t 'meta' => ['title' => 'The current servers IP Address.'],\n-\t 'parent' => 'lw_hello_server'\n-\t];\n-\t$wp_admin_bar->add_node( $mainNode );\n-\t$wp_admin_bar->add_node( $hostNode );\n-\t$wp_admin_bar->add_node( $ipNode );\n+/**\n+ * Include a small bit of CSS to display and position the icon.\n+ *\n+ * @return void\n+ */\n+function lw_add_admin_bar_css() {\n+\n+\t// Bail if current user doesnt have cap.\n+\tif ( ! current_user_can( 'manage_options' ) ) {\n+\t\treturn;\n+\t}\n+\n+\t// Echo out the CSS.\n+\techo '\n+\t<style>\n+\n+\t\tli#wp-admin-bar-lw-hello-server {\n+\t\t\tdisplay: block;\n+\t\t}\n+\n+\t\tli#wp-admin-bar-lw-hello-server .ab-item.ab-empty-item .ab-lw-icon {}\n+\n+\t\tli#wp-admin-bar-lw-hello-server .ab-item.ab-empty-item .ab-lw-icon:before {\n+\t\t\tcontent: \"\\f115\";\n+\t\t\ttop: 2px;\n+\t\t}\n+\n+\t\tli#wp-admin-bar-lw-hello-server .lw-admin-child-menu .ab-item.ab-empty-item span.ab-lw-inner-data {\n+\t\t\tcolor: #fff;\n+\t\t}\n+\n+\t\t@media screen and ( max-width: 782px ) {\n+\n+\t\t\tli#wp-admin-bar-lw-hello-server {\n+\t\t\t\tdisplay: block !important;\n+\t\t\t}\n+\t\t}\n+\n+\t</style>\n+\t';\n }\n+add_action( 'wp_head', 'lw_add_admin_bar_css' );\n+add_action( 'admin_head', 'lw_add_admin_bar_css' );\n \n-// Now we set that function up to execute when the admin_notices action is called\n-add_action( 'admin_bar_menu', 'hello_server', 999 );\n+/**\n+ * Display our server info in the admin bar.\n+ *\n+ * @param WP_Admin_Bar $wp_admin_bar The global WP_Admin_Bar object.\n+ *\n+ * @return void\n+ */\n+function lw_load_hello_server( WP_Admin_Bar $wp_admin_bar ) {\n+\n+\t// Bail if current user doesnt have cap.\n+\tif ( ! current_user_can( 'manage_options' ) ) {\n+\t\treturn;\n+\t}\n+\n+\t// Fetch our server info, and bail if we have none.\n+\tif ( false === $info = lw_hello_server_get_info() ) {\n+\t\treturn;\n+\t}\n+\n+\t// Add a parent item.\n+\t$wp_admin_bar->add_node(\n+\t\tarray(\n+\t\t\t'id' => 'lw-hello-server',\n+\t\t\t'title' => '<span class=\"ab-icon ab-lw-icon\"></span><span class=\"ab-label ab-lw-label\">' . esc_html__( 'Hello Server', 'hello-server' ) . '</span>',\n+\t\t\t'meta' => array(\n+\t\t\t\t'title' => esc_html__( 'View the current server info.', 'hello-server' ),\n+\t\t\t\t'class' => 'lw-admin-parent-menu',\n+\t\t\t),\n+\t\t)\n+\t);\n \n-// Internationalization Support\n-function load_plugins_textdomain()\n-{\n-\tload_plugin_textdomain(\n-\t\t'hello-server',\n-\t\tfalse,\n-\t\tdirname(dirname(plugin_basename(__FILE__))) . '/languages/'\n+\t// Add the host server info.\n+\t$wp_admin_bar->add_node(\n+\t\tarray(\n+\t\t\t'id' => 'lw-host-server',\n+\t\t\t'title' => '<span class=\"ab-lw-inner-label\">' . esc_html__( 'Hostname: ', 'hello-server' ) . '</span><span class=\"ab-lw-inner-data\" itemprop=\"server-name\">' . esc_html( $info['hostname'] ) . '</span>',\n+\t\t\t'position' => 0,\n+\t\t\t'parent' => 'lw-hello-server',\n+\t\t\t'meta' => array(\n+\t\t\t\t'title' => esc_html__( 'View the current server hostname.', 'hello-server' ),\n+\t\t\t\t'class' => 'lw-admin-child-menu',\n+\t\t\t),\n+\t\t)\n+\t);\n+\n+\t// Add the server IP info.\n+\t$wp_admin_bar->add_node(\n+\t\tarray(\n+\t\t\t'id' => 'lw-ip-address',\n+\t\t\t'title' => '<span class=\"ab-lw-inner-label\">' . esc_html__( 'IP Address: ', 'hello-server' ) . '</span><span class=\"ab-lw-inner-data\" itemprop=\"ip-address\">' . esc_html( $info['address'] ) . '</span>',\n+\t\t\t'position' => 1,\n+\t\t\t'parent' => 'lw-hello-server',\n+\t\t\t'meta' => array(\n+\t\t\t\t'title' => esc_html__( 'View the current server IP address.', 'hello-server' ),\n+\t\t\t\t'class' => 'lw-admin-child-menu',\n+\t\t\t),\n+\t\t)\n+\t);\n+\n+\t// Add the PHP software info.\n+\t$wp_admin_bar->add_node(\n+\t\tarray(\n+\t\t\t'id' => 'lw-php-version',\n+\t\t\t'title' => '<span class=\"ab-lw-inner-label\">' . __( 'PHP Version: ', 'hello-server' ) . '</span><span class=\"ab-lw-inner-data\" itemprop=\"php-version\">' . esc_html( $info['phpvers'] ) . '</span>',","path":"hello-server.php","position":296,"original_position":296,"commit_id":"edfc12d48c6153b7456cdb1e6f5612a0b6b67ca4","original_commit_id":"edfc12d48c6153b7456cdb1e6f5612a0b6b67ca4","user":{"login":"bswatson","id":303029,"avatar_url":"https://avatars2.githubusercontent.com/u/303029?v=3","gravatar_id":"","url":"https://api.github.com/users/bswatson","html_url":"https://github.com/bswatson","followers_url":"https://api.github.com/users/bswatson/followers","following_url":"https://api.github.com/users/bswatson/following{/other_user}","gists_url":"https://api.github.com/users/bswatson/gists{/gist_id}","starred_url":"https://api.github.com/users/bswatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bswatson/subscriptions","organizations_url":"https://api.github.com/users/bswatson/orgs","repos_url":"https://api.github.com/users/bswatson/repos","events_url":"https://api.github.com/users/bswatson/events{/privacy}","received_events_url":"https://api.github.com/users/bswatson/received_events","type":"User","site_admin":false},"body":"Recommend using `esc_html__` here to avoid any language injection with html.","created_at":"2017-06-23T17:41:06Z","updated_at":"2017-06-23T17:41:37Z","html_url":"https://github.com/liquidweb/hello-server/pull/1#discussion_r123805602","pull_request_url":"https://api.github.com/repos/liquidweb/hello-server/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/liquidweb/hello-server/pulls/comments/123805602"},"html":{"href":"https://github.com/liquidweb/hello-server/pull/1#discussion_r123805602"},"pull_request":{"href":"https://api.github.com/repos/liquidweb/hello-server/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/liquidweb/hello-server/pulls/1","id":127241664,"html_url":"https://github.com/liquidweb/hello-server/pull/1","diff_url":"https://github.com/liquidweb/hello-server/pull/1.diff","patch_url":"https://github.com/liquidweb/hello-server/pull/1.patch","issue_url":"https://api.github.com/repos/liquidweb/hello-server/issues/1","number":1,"state":"open","locked":false,"title":"general code and file cleanup","user":{"login":"norcross","id":98561,"avatar_url":"https://avatars1.githubusercontent.com/u/98561?v=3","gravatar_id":"","url":"https://api.github.com/users/norcross","html_url":"https://github.com/norcross","followers_url":"https://api.github.com/users/norcross/followers","following_url":"https://api.github.com/users/norcross/following{/other_user}","gists_url":"https://api.github.com/users/norcross/gists{/gist_id}","starred_url":"https://api.github.com/users/norcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norcross/subscriptions","organizations_url":"https://api.github.com/users/norcross/orgs","repos_url":"https://api.github.com/users/norcross/repos","events_url":"https://api.github.com/users/norcross/events{/privacy}","received_events_url":"https://api.github.com/users/norcross/received_events","type":"User","site_admin":false},"body":"added the following:\r\n\r\n* proper escaping and sanitation\r\n* function prefixing\r\n* clarifying language\r\n* adding display icon\r\n* displaying on smaller screens (icon only)\r\n* localizing phrases\r\n* now adheres to WPCS standards","created_at":"2017-06-23T16:17:43Z","updated_at":"2017-06-23T17:41:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"726a3a635cd9d61d49fcd2c5fddfa2007fd8bc76","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/liquidweb/hello-server/pulls/1/commits","review_comments_url":"https://api.github.com/repos/liquidweb/hello-server/pulls/1/comments","review_comment_url":"https://api.github.com/repos/liquidweb/hello-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liquidweb/hello-server/issues/1/comments","statuses_url":"https://api.github.com/repos/liquidweb/hello-server/statuses/edfc12d48c6153b7456cdb1e6f5612a0b6b67ca4","head":{"label":"liquidweb:standards-cleanup","ref":"standards-cleanup","sha":"edfc12d48c6153b7456cdb1e6f5612a0b6b67ca4","user":{"login":"liquidweb","id":216891,"avatar_url":"https://avatars2.githubusercontent.com/u/216891?v=3","gravatar_id":"","url":"https://api.github.com/users/liquidweb","html_url":"https://github.com/liquidweb","followers_url":"https://api.github.com/users/liquidweb/followers","following_url":"https://api.github.com/users/liquidweb/following{/other_user}","gists_url":"https://api.github.com/users/liquidweb/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidweb/subscriptions","organizations_url":"https://api.github.com/users/liquidweb/orgs","repos_url":"https://api.github.com/users/liquidweb/repos","events_url":"https://api.github.com/users/liquidweb/events{/privacy}","received_events_url":"https://api.github.com/users/liquidweb/received_events","type":"Organization","site_admin":false},"repo":{"id":82335812,"name":"hello-server","full_name":"liquidweb/hello-server","owner":{"login":"liquidweb","id":216891,"avatar_url":"https://avatars2.githubusercontent.com/u/216891?v=3","gravatar_id":"","url":"https://api.github.com/users/liquidweb","html_url":"https://github.com/liquidweb","followers_url":"https://api.github.com/users/liquidweb/followers","following_url":"https://api.github.com/users/liquidweb/following{/other_user}","gists_url":"https://api.github.com/users/liquidweb/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidweb/subscriptions","organizations_url":"https://api.github.com/users/liquidweb/orgs","repos_url":"https://api.github.com/users/liquidweb/repos","events_url":"https://api.github.com/users/liquidweb/events{/privacy}","received_events_url":"https://api.github.com/users/liquidweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liquidweb/hello-server","description":"Hello Server adds a node to the Toolbar that tells you what server your request was sent from! In the new Hello Server menu you'll find the current servers hostname and IP!","fork":false,"url":"https://api.github.com/repos/liquidweb/hello-server","forks_url":"https://api.github.com/repos/liquidweb/hello-server/forks","keys_url":"https://api.github.com/repos/liquidweb/hello-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liquidweb/hello-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liquidweb/hello-server/teams","hooks_url":"https://api.github.com/repos/liquidweb/hello-server/hooks","issue_events_url":"https://api.github.com/repos/liquidweb/hello-server/issues/events{/number}","events_url":"https://api.github.com/repos/liquidweb/hello-server/events","assignees_url":"https://api.github.com/repos/liquidweb/hello-server/assignees{/user}","branches_url":"https://api.github.com/repos/liquidweb/hello-server/branches{/branch}","tags_url":"https://api.github.com/repos/liquidweb/hello-server/tags","blobs_url":"https://api.github.com/repos/liquidweb/hello-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liquidweb/hello-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liquidweb/hello-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/liquidweb/hello-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liquidweb/hello-server/statuses/{sha}","languages_url":"https://api.github.com/repos/liquidweb/hello-server/languages","stargazers_url":"https://api.github.com/repos/liquidweb/hello-server/stargazers","contributors_url":"https://api.github.com/repos/liquidweb/hello-server/contributors","subscribers_url":"https://api.github.com/repos/liquidweb/hello-server/subscribers","subscription_url":"https://api.github.com/repos/liquidweb/hello-server/subscription","commits_url":"https://api.github.com/repos/liquidweb/hello-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/liquidweb/hello-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/liquidweb/hello-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/liquidweb/hello-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/liquidweb/hello-server/contents/{+path}","compare_url":"https://api.github.com/repos/liquidweb/hello-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liquidweb/hello-server/merges","archive_url":"https://api.github.com/repos/liquidweb/hello-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liquidweb/hello-server/downloads","issues_url":"https://api.github.com/repos/liquidweb/hello-server/issues{/number}","pulls_url":"https://api.github.com/repos/liquidweb/hello-server/pulls{/number}","milestones_url":"https://api.github.com/repos/liquidweb/hello-server/milestones{/number}","notifications_url":"https://api.github.com/repos/liquidweb/hello-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liquidweb/hello-server/labels{/name}","releases_url":"https://api.github.com/repos/liquidweb/hello-server/releases{/id}","deployments_url":"https://api.github.com/repos/liquidweb/hello-server/deployments","created_at":"2017-02-17T20:35:53Z","updated_at":"2017-06-23T13:44:27Z","pushed_at":"2017-06-23T17:15:48Z","git_url":"git://github.com/liquidweb/hello-server.git","ssh_url":"[email protected]:liquidweb/hello-server.git","clone_url":"https://github.com/liquidweb/hello-server.git","svn_url":"https://github.com/liquidweb/hello-server","homepage":"https://www.liquidweb.com/","size":181,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"liquidweb:master","ref":"master","sha":"f43d596f67b351cc37b91abe3bfeaba730c0dc2d","user":{"login":"liquidweb","id":216891,"avatar_url":"https://avatars2.githubusercontent.com/u/216891?v=3","gravatar_id":"","url":"https://api.github.com/users/liquidweb","html_url":"https://github.com/liquidweb","followers_url":"https://api.github.com/users/liquidweb/followers","following_url":"https://api.github.com/users/liquidweb/following{/other_user}","gists_url":"https://api.github.com/users/liquidweb/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidweb/subscriptions","organizations_url":"https://api.github.com/users/liquidweb/orgs","repos_url":"https://api.github.com/users/liquidweb/repos","events_url":"https://api.github.com/users/liquidweb/events{/privacy}","received_events_url":"https://api.github.com/users/liquidweb/received_events","type":"Organization","site_admin":false},"repo":{"id":82335812,"name":"hello-server","full_name":"liquidweb/hello-server","owner":{"login":"liquidweb","id":216891,"avatar_url":"https://avatars2.githubusercontent.com/u/216891?v=3","gravatar_id":"","url":"https://api.github.com/users/liquidweb","html_url":"https://github.com/liquidweb","followers_url":"https://api.github.com/users/liquidweb/followers","following_url":"https://api.github.com/users/liquidweb/following{/other_user}","gists_url":"https://api.github.com/users/liquidweb/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidweb/subscriptions","organizations_url":"https://api.github.com/users/liquidweb/orgs","repos_url":"https://api.github.com/users/liquidweb/repos","events_url":"https://api.github.com/users/liquidweb/events{/privacy}","received_events_url":"https://api.github.com/users/liquidweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liquidweb/hello-server","description":"Hello Server adds a node to the Toolbar that tells you what server your request was sent from! In the new Hello Server menu you'll find the current servers hostname and IP!","fork":false,"url":"https://api.github.com/repos/liquidweb/hello-server","forks_url":"https://api.github.com/repos/liquidweb/hello-server/forks","keys_url":"https://api.github.com/repos/liquidweb/hello-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liquidweb/hello-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liquidweb/hello-server/teams","hooks_url":"https://api.github.com/repos/liquidweb/hello-server/hooks","issue_events_url":"https://api.github.com/repos/liquidweb/hello-server/issues/events{/number}","events_url":"https://api.github.com/repos/liquidweb/hello-server/events","assignees_url":"https://api.github.com/repos/liquidweb/hello-server/assignees{/user}","branches_url":"https://api.github.com/repos/liquidweb/hello-server/branches{/branch}","tags_url":"https://api.github.com/repos/liquidweb/hello-server/tags","blobs_url":"https://api.github.com/repos/liquidweb/hello-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liquidweb/hello-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liquidweb/hello-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/liquidweb/hello-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liquidweb/hello-server/statuses/{sha}","languages_url":"https://api.github.com/repos/liquidweb/hello-server/languages","stargazers_url":"https://api.github.com/repos/liquidweb/hello-server/stargazers","contributors_url":"https://api.github.com/repos/liquidweb/hello-server/contributors","subscribers_url":"https://api.github.com/repos/liquidweb/hello-server/subscribers","subscription_url":"https://api.github.com/repos/liquidweb/hello-server/subscription","commits_url":"https://api.github.com/repos/liquidweb/hello-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/liquidweb/hello-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/liquidweb/hello-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/liquidweb/hello-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/liquidweb/hello-server/contents/{+path}","compare_url":"https://api.github.com/repos/liquidweb/hello-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liquidweb/hello-server/merges","archive_url":"https://api.github.com/repos/liquidweb/hello-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liquidweb/hello-server/downloads","issues_url":"https://api.github.com/repos/liquidweb/hello-server/issues{/number}","pulls_url":"https://api.github.com/repos/liquidweb/hello-server/pulls{/number}","milestones_url":"https://api.github.com/repos/liquidweb/hello-server/milestones{/number}","notifications_url":"https://api.github.com/repos/liquidweb/hello-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liquidweb/hello-server/labels{/name}","releases_url":"https://api.github.com/repos/liquidweb/hello-server/releases{/id}","deployments_url":"https://api.github.com/repos/liquidweb/hello-server/deployments","created_at":"2017-02-17T20:35:53Z","updated_at":"2017-06-23T13:44:27Z","pushed_at":"2017-06-23T17:15:48Z","git_url":"git://github.com/liquidweb/hello-server.git","ssh_url":"[email protected]:liquidweb/hello-server.git","clone_url":"https://github.com/liquidweb/hello-server.git","svn_url":"https://github.com/liquidweb/hello-server","homepage":"https://www.liquidweb.com/","size":181,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liquidweb/hello-server/pulls/1"},"html":{"href":"https://github.com/liquidweb/hello-server/pull/1"},"issue":{"href":"https://api.github.com/repos/liquidweb/hello-server/issues/1"},"comments":{"href":"https://api.github.com/repos/liquidweb/hello-server/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/liquidweb/hello-server/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/liquidweb/hello-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liquidweb/hello-server/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/liquidweb/hello-server/statuses/edfc12d48c6153b7456cdb1e6f5612a0b6b67ca4"}}}} | {
"id": 82335812,
"name": "liquidweb/hello-server",
"url": "https://api.github.com/repos/liquidweb/hello-server"
} | {
"id": 303029,
"login": "bswatson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/303029?",
"url": "https://api.github.com/users/bswatson"
} | {
"id": 216891,
"login": "liquidweb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/216891?",
"url": "https://api.github.com/orgs/liquidweb"
} | 2017-06-23T17:41:06 | 6127827586 | {"actor":{"display_login":"bswatson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/158899685","pull_request_review_id":85767588,"id":158899685,"diff_hunk":"@@ -43,6 +58,18 @@ type NetworkSettings struct {\n \tGateway string\n \tDNS1 string\n \tDNS2 string\n+\tUseDHCP bool\n+\tDisabled bool\n+}\n+\n+func checkSupportForAddressAssignment() bool {\n+\tif minishiftConfig.InstanceConfig.IsRHELBased &&\n+\t\tminishiftConfig.InstanceConfig.SupportsNetworkAssignment {\n+\t\treturn true\n+\t} else {\n+\t\tatexit.ExitWithMessage(1, configureNetworkNotSupportedMessage)\n+\t}\n+\treturn false","path":"pkg/minishift/network/settings.go","position":55,"original_position":55,"commit_id":"85301e68d385c618889fca5429bee1c3dc3ecce1","original_commit_id":"85301e68d385c618889fca5429bee1c3dc3ecce1","user":{"login":"LalatenduMohanty","id":3125299,"avatar_url":"https://avatars2.githubusercontent.com/u/3125299?v=4","gravatar_id":"","url":"https://api.github.com/users/LalatenduMohanty","html_url":"https://github.com/LalatenduMohanty","followers_url":"https://api.github.com/users/LalatenduMohanty/followers","following_url":"https://api.github.com/users/LalatenduMohanty/following{/other_user}","gists_url":"https://api.github.com/users/LalatenduMohanty/gists{/gist_id}","starred_url":"https://api.github.com/users/LalatenduMohanty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LalatenduMohanty/subscriptions","organizations_url":"https://api.github.com/users/LalatenduMohanty/orgs","repos_url":"https://api.github.com/users/LalatenduMohanty/repos","events_url":"https://api.github.com/users/LalatenduMohanty/events{/privacy}","received_events_url":"https://api.github.com/users/LalatenduMohanty/received_events","type":"User","site_admin":false},"body":"Is this function used anywhere? I can not find any reference?","created_at":"2017-12-28T05:44:41Z","updated_at":"2017-12-28T06:04:51Z","html_url":"https://github.com/minishift/minishift/pull/1849#discussion_r158899685","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/1849","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/158899685"},"html":{"href":"https://github.com/minishift/minishift/pull/1849#discussion_r158899685"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1849"}}},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/1849","id":158827872,"html_url":"https://github.com/minishift/minishift/pull/1849","diff_url":"https://github.com/minishift/minishift/pull/1849.diff","patch_url":"https://github.com/minishift/minishift/pull/1849.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/1849","number":1849,"state":"open","locked":false,"title":"Issue #1513 Static IP assignment improvements","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars0.githubusercontent.com/u/1894?v=4","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"body":"Fixes #1513, #1497, #1492 , #1493, #1496 \r\n\r\nThis allows you to use just `--network-ipaddress` and have the rest of the information like gateway and nameservers being guessed (to some degree).\r\n\r\nNote: some functionality from #1457 is shared: https://github.com/gbraad/minishift/tree/issue-1457\r\n\r\n","created_at":"2017-12-18T04:25:01Z","updated_at":"2017-12-28T06:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3839aa2e7d6bab2a810471ceabba34bfa2f0c28","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/1849/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/1849/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/1849/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/85301e68d385c618889fca5429bee1c3dc3ecce1","head":{"label":"gbraad:staticip","ref":"staticip","sha":"85301e68d385c618889fca5429bee1c3dc3ecce1","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars0.githubusercontent.com/u/1894?v=4","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"repo":{"id":69309326,"name":"minishift","full_name":"gbraad/minishift","owner":{"login":"gbraad","id":1894,"avatar_url":"https://avatars0.githubusercontent.com/u/1894?v=4","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbraad/minishift","description":null,"fork":true,"url":"https://api.github.com/repos/gbraad/minishift","forks_url":"https://api.github.com/repos/gbraad/minishift/forks","keys_url":"https://api.github.com/repos/gbraad/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbraad/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbraad/minishift/teams","hooks_url":"https://api.github.com/repos/gbraad/minishift/hooks","issue_events_url":"https://api.github.com/repos/gbraad/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/gbraad/minishift/events","assignees_url":"https://api.github.com/repos/gbraad/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/gbraad/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/gbraad/minishift/tags","blobs_url":"https://api.github.com/repos/gbraad/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbraad/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbraad/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbraad/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbraad/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/gbraad/minishift/languages","stargazers_url":"https://api.github.com/repos/gbraad/minishift/stargazers","contributors_url":"https://api.github.com/repos/gbraad/minishift/contributors","subscribers_url":"https://api.github.com/repos/gbraad/minishift/subscribers","subscription_url":"https://api.github.com/repos/gbraad/minishift/subscription","commits_url":"https://api.github.com/repos/gbraad/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbraad/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbraad/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbraad/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbraad/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/gbraad/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbraad/minishift/merges","archive_url":"https://api.github.com/repos/gbraad/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbraad/minishift/downloads","issues_url":"https://api.github.com/repos/gbraad/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/gbraad/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/gbraad/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/gbraad/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbraad/minishift/labels{/name}","releases_url":"https://api.github.com/repos/gbraad/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/gbraad/minishift/deployments","created_at":"2016-09-27T01:55:22Z","updated_at":"2017-08-10T04:00:14Z","pushed_at":"2017-12-26T08:52:49Z","git_url":"git://github.com/gbraad/minishift.git","ssh_url":"[email protected]:gbraad/minishift.git","clone_url":"https://github.com/gbraad/minishift.git","svn_url":"https://github.com/gbraad/minishift","homepage":null,"size":157638,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"fork"}},"base":{"label":"minishift:master","ref":"master","sha":"77422c5cea568cfc4912942ba2ff5df37c40e9ae","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-12-27T04:12:06Z","pushed_at":"2017-12-28T05:09:55Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"[email protected]:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":157668,"stargazers_count":791,"watchers_count":791,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":177,"open_issues":226,"watchers":791,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1849"},"html":{"href":"https://github.com/minishift/minishift/pull/1849"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/1849"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/1849/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1849/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1849/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/85301e68d385c618889fca5429bee1c3dc3ecce1"}},"author_association":"OWNER"}} | {
"id": 62728051,
"name": "minishift/minishift",
"url": "https://api.github.com/repos/minishift/minishift"
} | {
"id": 3125299,
"login": "LalatenduMohanty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3125299?",
"url": "https://api.github.com/users/LalatenduMohanty"
} | {
"id": 23212309,
"login": "minishift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23212309?",
"url": "https://api.github.com/orgs/minishift"
} | 2017-12-28T05:44:41 | 7036065613 | {"actor":{"display_login":"LalatenduMohanty"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/132386442","pull_request_review_id":55459091,"id":132386442,"diff_hunk":"@@ -264,12 +267,34 @@ func extractBinary(downloadedArchivePath, archiveDir string) (string, error) {\n \t\t\treturn \"\", err\n \t\t}\n \n-\t\tbinaryPath = filepath.Join(extract, \"minishift\")\n+\t\tbinaryPath, err = minishiftBinaryPath(extract, \"minishift\")\n+\t\tif err != nil {\n+\t\t\treturn \"\", err\n+\t\t}\n \t}\n \n \treturn binaryPath, nil\n }\n \n+// minishitBinaryPath take extracted Path and os specific binary name and return\n+// absolute path of the binary\n+func minishiftBinaryPath(extractPath, binaryName string) (string, error) {\n+\tvar binaryPath string\n+\tvar err error\n+\tfileList := []string{}\n+\terr = filepath.Walk(extractPath, func(path string, f os.FileInfo, err error) error {\n+\t\tfileList = append(fileList, path)\n+\t\treturn nil\n+\t})\n+\tfor _, fileName := range fileList {\n+\t\tif strings.Contains(fileName, binaryName) {","path":"pkg/minishift/update/update.go","position":37,"original_position":37,"commit_id":"e2e817b68cbe5b7db8029a3cb26840d42c8f13ba","original_commit_id":"e2e817b68cbe5b7db8029a3cb26840d42c8f13ba","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars0.githubusercontent.com/u/296354?v=4","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"I am not quite sure what @budhrg means with _login_, but afaict you walk the tree and append everything to a slice. Then you iterate the slice to see whether you got a match. Why not do everything in one go in the anonymous function passed to file path.Walk? Just check each entry whether it is a match. If so record the entry. After file path.Walk you just check whether you found something. \r\n\r\nUp to you what you want to do.","created_at":"2017-08-10T07:56:53Z","updated_at":"2017-08-10T08:04:17Z","html_url":"https://github.com/minishift/minishift/pull/1253#discussion_r132386442","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/1253","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/132386442"},"html":{"href":"https://github.com/minishift/minishift/pull/1253#discussion_r132386442"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1253"}}},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/1253","id":134887817,"html_url":"https://github.com/minishift/minishift/pull/1253","diff_url":"https://github.com/minishift/minishift/pull/1253.diff","patch_url":"https://github.com/minishift/minishift/pull/1253.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/1253","number":1253,"state":"open","locked":false,"title":"Issue #1217 Enable update code resilient towards exact location of minishift binary","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars2.githubusercontent.com/u/410007?v=4","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"body":"Todo\r\n-------\r\n\r\n- Need to update unit test to accommodate all those changes. ","created_at":"2017-08-09T13:05:00Z","updated_at":"2017-08-10T08:04:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b17e4e10201afbf63ba8ea851ad544da3c019de9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/1253/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/1253/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/1253/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/e2e817b68cbe5b7db8029a3cb26840d42c8f13ba","head":{"label":"praveenkumar:issue_1217","ref":"issue_1217","sha":"e2e817b68cbe5b7db8029a3cb26840d42c8f13ba","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars2.githubusercontent.com/u/410007?v=4","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"repo":{"id":74443040,"name":"minishift","full_name":"praveenkumar/minishift","owner":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars2.githubusercontent.com/u/410007?v=4","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/praveenkumar/minishift","description":null,"fork":true,"url":"https://api.github.com/repos/praveenkumar/minishift","forks_url":"https://api.github.com/repos/praveenkumar/minishift/forks","keys_url":"https://api.github.com/repos/praveenkumar/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praveenkumar/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praveenkumar/minishift/teams","hooks_url":"https://api.github.com/repos/praveenkumar/minishift/hooks","issue_events_url":"https://api.github.com/repos/praveenkumar/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/praveenkumar/minishift/events","assignees_url":"https://api.github.com/repos/praveenkumar/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/praveenkumar/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/praveenkumar/minishift/tags","blobs_url":"https://api.github.com/repos/praveenkumar/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praveenkumar/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praveenkumar/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/praveenkumar/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praveenkumar/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/praveenkumar/minishift/languages","stargazers_url":"https://api.github.com/repos/praveenkumar/minishift/stargazers","contributors_url":"https://api.github.com/repos/praveenkumar/minishift/contributors","subscribers_url":"https://api.github.com/repos/praveenkumar/minishift/subscribers","subscription_url":"https://api.github.com/repos/praveenkumar/minishift/subscription","commits_url":"https://api.github.com/repos/praveenkumar/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/praveenkumar/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/praveenkumar/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/praveenkumar/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/praveenkumar/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/praveenkumar/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praveenkumar/minishift/merges","archive_url":"https://api.github.com/repos/praveenkumar/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praveenkumar/minishift/downloads","issues_url":"https://api.github.com/repos/praveenkumar/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/praveenkumar/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/praveenkumar/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/praveenkumar/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praveenkumar/minishift/labels{/name}","releases_url":"https://api.github.com/repos/praveenkumar/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/praveenkumar/minishift/deployments","created_at":"2016-11-22T06:46:12Z","updated_at":"2016-11-22T06:46:15Z","pushed_at":"2017-08-09T13:03:49Z","git_url":"git://github.com/praveenkumar/minishift.git","ssh_url":"[email protected]:praveenkumar/minishift.git","clone_url":"https://github.com/praveenkumar/minishift.git","svn_url":"https://github.com/praveenkumar/minishift","homepage":null,"size":157137,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"e65bd066c9ee5012abbf0cf162e297967bd45342","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-08-08T18:30:35Z","pushed_at":"2017-08-09T18:08:16Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"[email protected]:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":157096,"stargazers_count":567,"watchers_count":567,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":127,"mirror_url":null,"open_issues_count":169,"forks":127,"open_issues":169,"watchers":567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1253"},"html":{"href":"https://github.com/minishift/minishift/pull/1253"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/1253"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/1253/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1253/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1253/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/e2e817b68cbe5b7db8029a3cb26840d42c8f13ba"}}}} | {
"id": 62728051,
"name": "minishift/minishift",
"url": "https://api.github.com/repos/minishift/minishift"
} | {
"id": 296354,
"login": "hferentschik",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/296354?",
"url": "https://api.github.com/users/hferentschik"
} | {
"id": 23212309,
"login": "minishift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23212309?",
"url": "https://api.github.com/orgs/minishift"
} | 2017-08-10T07:56:53 | 6430971566 | {"actor":{"display_login":"hferentschik"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/143884106","pull_request_review_id":68461579,"id":143884106,"diff_hunk":"@@ -566,31 +566,59 @@ def _set_psd_plot_params(info, proj, picks, ax, area_mode):\n ax_list, make_label)\n \n \n-def _convert_psds(psds, dB, scaling, unit, ch_names):\n- \"\"\"Convert PSDs to dB (if necessary) and appropriate units.\"\"\"\n- if dB:\n- where = np.where(psds.min(1) <= 0)[0]\n- if len(where) > 0:\n- raise ValueError(\"Infinite value in PSD for channel(s) %s. \"\n- \"These channels might be dead.\" %\n- ', '.join(ch_names[ii] for ii in where))\n+def _convert_psds(psds, dB, estimate, scaling, unit, ch_names):\n+ \"\"\"Convert PSDs to dB (if necessary) and appropriate units.\n+\n+ The following table summarizes the relationship between the value of\n+ parameters `dB` and `estimate`, and the type of plot and corresponding\n+ units.\n+\n+ | dB | estimate | plot | units |\n+ |-------+-------------+------+-----------------|\n+ | True | 'power' | PSD | u**2/Hz (dB) |\n+ | False | 'amplitude' | ASD | u/sqrt{Hz} |\n+ | True | 'auto' | PSD | u**2/Hz (dB) |\n+ | False | 'power' | PSD | u**2/Hz |\n+ | True | 'amplitude' | ASD | u/sqrt{Hz} (dB) |\n+ | False | 'auto' | ASD | u/sqrt{Hz} |\n+ \"\"\"\n+\n+ where = np.where(psds.min(1) <= 0)[0]\n+ if len(where) > 0:\n+ raise ValueError(\"Infinite value in PSD for channel(s) %s. \"","path":"mne/viz/raw.py","position":null,"original_position":31,"commit_id":"12fac68fe5c2c2dc25ab0ccdc7d5edc652ac3331","original_commit_id":"df13ad9e37a2ae5f198ceaa5a69c067af37468de","user":{"login":"aweinstein","id":123405,"avatar_url":"https://avatars3.githubusercontent.com/u/123405?v=4","gravatar_id":"","url":"https://api.github.com/users/aweinstein","html_url":"https://github.com/aweinstein","followers_url":"https://api.github.com/users/aweinstein/followers","following_url":"https://api.github.com/users/aweinstein/following{/other_user}","gists_url":"https://api.github.com/users/aweinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/aweinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweinstein/subscriptions","organizations_url":"https://api.github.com/users/aweinstein/orgs","repos_url":"https://api.github.com/users/aweinstein/repos","events_url":"https://api.github.com/users/aweinstein/events{/privacy}","received_events_url":"https://api.github.com/users/aweinstein/received_events","type":"User","site_admin":false},"body":"Throwing a warning opens a new can of worms. Now when computing the log10, I get NumPy warnings. Do we just let them there? They look kind of ugly. But disabling these warnings in the code is not nice either. ","created_at":"2017-10-11T00:05:06Z","updated_at":"2017-10-11T00:05:06Z","html_url":"https://github.com/mne-tools/mne-python/pull/4654#discussion_r143884106","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/4654","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/143884106"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/4654#discussion_r143884106"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/4654"}},"in_reply_to_id":143654381},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/4654","id":145577324,"html_url":"https://github.com/mne-tools/mne-python/pull/4654","diff_url":"https://github.com/mne-tools/mne-python/pull/4654.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/4654.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/4654","number":4654,"state":"open","locked":false,"title":"Add `estimate` parameter to `plot_raw_psd` function.","user":{"login":"aweinstein","id":123405,"avatar_url":"https://avatars3.githubusercontent.com/u/123405?v=4","gravatar_id":"","url":"https://api.github.com/users/aweinstein","html_url":"https://github.com/aweinstein","followers_url":"https://api.github.com/users/aweinstein/followers","following_url":"https://api.github.com/users/aweinstein/following{/other_user}","gists_url":"https://api.github.com/users/aweinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/aweinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweinstein/subscriptions","organizations_url":"https://api.github.com/users/aweinstein/orgs","repos_url":"https://api.github.com/users/aweinstein/repos","events_url":"https://api.github.com/users/aweinstein/events{/privacy}","received_events_url":"https://api.github.com/users/aweinstein/received_events","type":"User","site_admin":false},"body":"This new parameter allows choosing between plotting the PSD and the ASD.\r\nIt also fixes an inconsistency of the `dB` parameter.\r\n\r\nSee issue #4642.","created_at":"2017-10-10T00:49:21Z","updated_at":"2017-10-11T00:05:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb641c21df353371d3abe6cca4ed62e166186ab5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/4654/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/4654/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/4654/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/12fac68fe5c2c2dc25ab0ccdc7d5edc652ac3331","head":{"label":"aweinstein:fix_psd","ref":"fix_psd","sha":"12fac68fe5c2c2dc25ab0ccdc7d5edc652ac3331","user":{"login":"aweinstein","id":123405,"avatar_url":"https://avatars3.githubusercontent.com/u/123405?v=4","gravatar_id":"","url":"https://api.github.com/users/aweinstein","html_url":"https://github.com/aweinstein","followers_url":"https://api.github.com/users/aweinstein/followers","following_url":"https://api.github.com/users/aweinstein/following{/other_user}","gists_url":"https://api.github.com/users/aweinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/aweinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweinstein/subscriptions","organizations_url":"https://api.github.com/users/aweinstein/orgs","repos_url":"https://api.github.com/users/aweinstein/repos","events_url":"https://api.github.com/users/aweinstein/events{/privacy}","received_events_url":"https://api.github.com/users/aweinstein/received_events","type":"User","site_admin":false},"repo":{"id":100621128,"name":"mne-python","full_name":"aweinstein/mne-python","owner":{"login":"aweinstein","id":123405,"avatar_url":"https://avatars3.githubusercontent.com/u/123405?v=4","gravatar_id":"","url":"https://api.github.com/users/aweinstein","html_url":"https://github.com/aweinstein","followers_url":"https://api.github.com/users/aweinstein/followers","following_url":"https://api.github.com/users/aweinstein/following{/other_user}","gists_url":"https://api.github.com/users/aweinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/aweinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweinstein/subscriptions","organizations_url":"https://api.github.com/users/aweinstein/orgs","repos_url":"https://api.github.com/users/aweinstein/repos","events_url":"https://api.github.com/users/aweinstein/events{/privacy}","received_events_url":"https://api.github.com/users/aweinstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aweinstein/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/aweinstein/mne-python","forks_url":"https://api.github.com/repos/aweinstein/mne-python/forks","keys_url":"https://api.github.com/repos/aweinstein/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aweinstein/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aweinstein/mne-python/teams","hooks_url":"https://api.github.com/repos/aweinstein/mne-python/hooks","issue_events_url":"https://api.github.com/repos/aweinstein/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/aweinstein/mne-python/events","assignees_url":"https://api.github.com/repos/aweinstein/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/aweinstein/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/aweinstein/mne-python/tags","blobs_url":"https://api.github.com/repos/aweinstein/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aweinstein/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aweinstein/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/aweinstein/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aweinstein/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/aweinstein/mne-python/languages","stargazers_url":"https://api.github.com/repos/aweinstein/mne-python/stargazers","contributors_url":"https://api.github.com/repos/aweinstein/mne-python/contributors","subscribers_url":"https://api.github.com/repos/aweinstein/mne-python/subscribers","subscription_url":"https://api.github.com/repos/aweinstein/mne-python/subscription","commits_url":"https://api.github.com/repos/aweinstein/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/aweinstein/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/aweinstein/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/aweinstein/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/aweinstein/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/aweinstein/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aweinstein/mne-python/merges","archive_url":"https://api.github.com/repos/aweinstein/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aweinstein/mne-python/downloads","issues_url":"https://api.github.com/repos/aweinstein/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/aweinstein/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/aweinstein/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/aweinstein/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aweinstein/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/aweinstein/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/aweinstein/mne-python/deployments","created_at":"2017-08-17T15:55:19Z","updated_at":"2017-08-17T15:55:24Z","pushed_at":"2017-10-10T14:34:14Z","git_url":"git://github.com/aweinstein/mne-python.git","ssh_url":"[email protected]:aweinstein/mne-python.git","clone_url":"https://github.com/aweinstein/mne-python.git","svn_url":"https://github.com/aweinstein/mne-python","homepage":"http://martinos.org/mne/","size":96475,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"2a98e818567ddf0caf7b3e32d1c946f2c61a2727","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2017-10-06T03:50:07Z","pushed_at":"2017-10-10T23:53:10Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"[email protected]:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":96419,"stargazers_count":346,"watchers_count":346,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":308,"mirror_url":null,"open_issues_count":208,"forks":308,"open_issues":208,"watchers":346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/4654"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/4654"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/4654"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/4654/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/4654/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/4654/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/12fac68fe5c2c2dc25ab0ccdc7d5edc652ac3331"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1301584,
"name": "mne-tools/mne-python",
"url": "https://api.github.com/repos/mne-tools/mne-python"
} | {
"id": 123405,
"login": "aweinstein",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/123405?",
"url": "https://api.github.com/users/aweinstein"
} | {
"id": 583875,
"login": "mne-tools",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/583875?",
"url": "https://api.github.com/orgs/mne-tools"
} | 2017-10-11T00:05:06 | 6699767275 | {"actor":{"display_login":"aweinstein"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/123171706","pull_request_review_id":45347290,"id":123171706,"diff_hunk":"@@ -1149,6 +1151,18 @@ void PreferenceDialog::resetShortcutClicked()\n active->setText(1, shortcut->keysToString());\n shortcutsChanged = true;\n }\n+ \n+void PreferenceDialog::saveShortcutListClicked()\n+ {\n+ QString saveFileName = QFileDialog::getSaveFileName(new QWidget(),\"Save Shortcuts\", tr(\"XML Files(*.xml)\"));","path":"mscore/preferences.cpp","position":16,"original_position":16,"commit_id":"a46890d7204b6001c69de773a02da80e79960ae6","original_commit_id":"a46890d7204b6001c69de773a02da80e79960ae6","user":{"login":"lasconic","id":234271,"avatar_url":"https://avatars3.githubusercontent.com/u/234271?v=3","gravatar_id":"","url":"https://api.github.com/users/lasconic","html_url":"https://github.com/lasconic","followers_url":"https://api.github.com/users/lasconic/followers","following_url":"https://api.github.com/users/lasconic/following{/other_user}","gists_url":"https://api.github.com/users/lasconic/gists{/gist_id}","starred_url":"https://api.github.com/users/lasconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasconic/subscriptions","organizations_url":"https://api.github.com/users/lasconic/orgs","repos_url":"https://api.github.com/users/lasconic/repos","events_url":"https://api.github.com/users/lasconic/events{/privacy}","received_events_url":"https://api.github.com/users/lasconic/received_events","type":"User","site_admin":false},"body":"This is a mess, check again the documentation of getSaveFileName. Also see how files are saved all around the MuseScore code.\r\n","created_at":"2017-06-21T07:28:33Z","updated_at":"2017-06-21T07:28:33Z","html_url":"https://github.com/musescore/MuseScore/pull/3210#discussion_r123171706","pull_request_url":"https://api.github.com/repos/musescore/MuseScore/pulls/3210","_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/123171706"},"html":{"href":"https://github.com/musescore/MuseScore/pull/3210#discussion_r123171706"},"pull_request":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/3210"}}},"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/3210","id":125284484,"html_url":"https://github.com/musescore/MuseScore/pull/3210","diff_url":"https://github.com/musescore/MuseScore/pull/3210.diff","patch_url":"https://github.com/musescore/MuseScore/pull/3210.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/3210","number":3210,"state":"open","locked":false,"title":"Detecting user keyboard layout at startup","user":{"login":"aryamanvinchhi","id":23262475,"avatar_url":"https://avatars0.githubusercontent.com/u/23262475?v=3","gravatar_id":"","url":"https://api.github.com/users/aryamanvinchhi","html_url":"https://github.com/aryamanvinchhi","followers_url":"https://api.github.com/users/aryamanvinchhi/followers","following_url":"https://api.github.com/users/aryamanvinchhi/following{/other_user}","gists_url":"https://api.github.com/users/aryamanvinchhi/gists{/gist_id}","starred_url":"https://api.github.com/users/aryamanvinchhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aryamanvinchhi/subscriptions","organizations_url":"https://api.github.com/users/aryamanvinchhi/orgs","repos_url":"https://api.github.com/users/aryamanvinchhi/repos","events_url":"https://api.github.com/users/aryamanvinchhi/events{/privacy}","received_events_url":"https://api.github.com/users/aryamanvinchhi/received_events","type":"User","site_admin":false},"body":"Not ready for merging yet. This PR can be flagged as work in progress.","created_at":"2017-06-13T06:06:12Z","updated_at":"2017-06-21T07:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d913766a4e62591437d7d009dfc02d996b87ebb7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/3210/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/3210/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/3210/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/a46890d7204b6001c69de773a02da80e79960ae6","head":{"label":"aryamanvinchhi:startup-wizard","ref":"startup-wizard","sha":"a46890d7204b6001c69de773a02da80e79960ae6","user":{"login":"aryamanvinchhi","id":23262475,"avatar_url":"https://avatars0.githubusercontent.com/u/23262475?v=3","gravatar_id":"","url":"https://api.github.com/users/aryamanvinchhi","html_url":"https://github.com/aryamanvinchhi","followers_url":"https://api.github.com/users/aryamanvinchhi/followers","following_url":"https://api.github.com/users/aryamanvinchhi/following{/other_user}","gists_url":"https://api.github.com/users/aryamanvinchhi/gists{/gist_id}","starred_url":"https://api.github.com/users/aryamanvinchhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aryamanvinchhi/subscriptions","organizations_url":"https://api.github.com/users/aryamanvinchhi/orgs","repos_url":"https://api.github.com/users/aryamanvinchhi/repos","events_url":"https://api.github.com/users/aryamanvinchhi/events{/privacy}","received_events_url":"https://api.github.com/users/aryamanvinchhi/received_events","type":"User","site_admin":false},"repo":{"id":92037590,"name":"MuseScore","full_name":"aryamanvinchhi/MuseScore","owner":{"login":"aryamanvinchhi","id":23262475,"avatar_url":"https://avatars0.githubusercontent.com/u/23262475?v=3","gravatar_id":"","url":"https://api.github.com/users/aryamanvinchhi","html_url":"https://github.com/aryamanvinchhi","followers_url":"https://api.github.com/users/aryamanvinchhi/followers","following_url":"https://api.github.com/users/aryamanvinchhi/following{/other_user}","gists_url":"https://api.github.com/users/aryamanvinchhi/gists{/gist_id}","starred_url":"https://api.github.com/users/aryamanvinchhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aryamanvinchhi/subscriptions","organizations_url":"https://api.github.com/users/aryamanvinchhi/orgs","repos_url":"https://api.github.com/users/aryamanvinchhi/repos","events_url":"https://api.github.com/users/aryamanvinchhi/events{/privacy}","received_events_url":"https://api.github.com/users/aryamanvinchhi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aryamanvinchhi/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/aryamanvinchhi/MuseScore","forks_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/forks","keys_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/teams","hooks_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/events","assignees_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/tags","blobs_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/languages","stargazers_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/subscription","commits_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/merges","archive_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/downloads","issues_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/aryamanvinchhi/MuseScore/deployments","created_at":"2017-05-22T09:47:02Z","updated_at":"2017-05-22T09:47:16Z","pushed_at":"2017-06-21T07:22:00Z","git_url":"git://github.com/aryamanvinchhi/MuseScore.git","ssh_url":"[email protected]:aryamanvinchhi/MuseScore.git","clone_url":"https://github.com/aryamanvinchhi/MuseScore.git","svn_url":"https://github.com/aryamanvinchhi/MuseScore","homepage":"https://musescore.org","size":265526,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"821b10082c76bfcfec99271cf85e3ea0bb59c772","user":{"login":"musescore","id":380563,"avatar_url":"https://avatars1.githubusercontent.com/u/380563?v=3","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"name":"MuseScore","full_name":"musescore/MuseScore","owner":{"login":"musescore","id":380563,"avatar_url":"https://avatars1.githubusercontent.com/u/380563?v=3","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/musescore/MuseScore/deployments","created_at":"2012-05-26T12:46:33Z","updated_at":"2017-06-20T15:23:22Z","pushed_at":"2017-06-21T07:22:03Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"[email protected]:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"https://musescore.org","size":265659,"stargazers_count":1586,"watchers_count":1586,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":744,"mirror_url":null,"open_issues_count":87,"forks":744,"open_issues":87,"watchers":1586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/3210"},"html":{"href":"https://github.com/musescore/MuseScore/pull/3210"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/3210"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/3210/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/3210/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/3210/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/a46890d7204b6001c69de773a02da80e79960ae6"}}}} | {
"id": 4454793,
"name": "musescore/MuseScore",
"url": "https://api.github.com/repos/musescore/MuseScore"
} | {
"id": 234271,
"login": "lasconic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234271?",
"url": "https://api.github.com/users/lasconic"
} | {
"id": 380563,
"login": "musescore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/380563?",
"url": "https://api.github.com/orgs/musescore"
} | 2017-06-21T07:28:33 | 6107218409 | {"actor":{"display_login":"lasconic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments/141024231","pull_request_review_id":65176974,"id":141024231,"diff_hunk":"@@ -903,6 +903,28 @@ sub report_edit : Path('report_edit') : Args(1) {\n \n if ( $problem->state ne $old_state ) {\n $c->forward( 'log_edit', [ $id, 'problem', 'state_change' ] );\n+\n+ unless (\n+ $problem->state eq 'unconfirmed' || $old_state eq 'unconfirmed' ||\n+ $problem->state eq 'hidden' || $old_state eq 'hidden'","path":"perllib/FixMyStreet/App/Controller/Admin.pm","position":7,"original_position":7,"commit_id":"bd201c8ab9017c29ec26fc002e5d49569d4959be","original_commit_id":"45062052c03925c5522003c03271a5318830ff27","user":{"login":"dracos","id":154364,"avatar_url":"https://avatars0.githubusercontent.com/u/154364?v=4","gravatar_id":"","url":"https://api.github.com/users/dracos","html_url":"https://github.com/dracos","followers_url":"https://api.github.com/users/dracos/followers","following_url":"https://api.github.com/users/dracos/following{/other_user}","gists_url":"https://api.github.com/users/dracos/gists{/gist_id}","starred_url":"https://api.github.com/users/dracos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dracos/subscriptions","organizations_url":"https://api.github.com/users/dracos/orgs","repos_url":"https://api.github.com/users/dracos/repos","events_url":"https://api.github.com/users/dracos/events{/privacy}","received_events_url":"https://api.github.com/users/dracos/received_events","type":"User","site_admin":false},"body":"I think I lean towards recording all state changes for consistency and so we can always recreate the full history, and if we don't want to display ones, do that on display as you say.","created_at":"2017-09-26T11:05:13Z","updated_at":"2017-09-26T11:05:14Z","html_url":"https://github.com/mysociety/fixmystreet/pull/1847#discussion_r141024231","pull_request_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1847","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments/141024231"},"html":{"href":"https://github.com/mysociety/fixmystreet/pull/1847#discussion_r141024231"},"pull_request":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1847"}},"in_reply_to_id":139915885},"pull_request":{"url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1847","id":141638162,"html_url":"https://github.com/mysociety/fixmystreet/pull/1847","diff_url":"https://github.com/mysociety/fixmystreet/pull/1847.diff","patch_url":"https://github.com/mysociety/fixmystreet/pull/1847.patch","issue_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/1847","number":1847,"state":"open","locked":false,"title":"Create a comment with blank text when the report state is updated in admin","user":{"login":"struan","id":5310,"avatar_url":"https://avatars1.githubusercontent.com/u/5310?v=4","gravatar_id":"","url":"https://api.github.com/users/struan","html_url":"https://github.com/struan","followers_url":"https://api.github.com/users/struan/followers","following_url":"https://api.github.com/users/struan/following{/other_user}","gists_url":"https://api.github.com/users/struan/gists{/gist_id}","starred_url":"https://api.github.com/users/struan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/struan/subscriptions","organizations_url":"https://api.github.com/users/struan/orgs","repos_url":"https://api.github.com/users/struan/repos","events_url":"https://api.github.com/users/struan/events{/privacy}","received_events_url":"https://api.github.com/users/struan/received_events","type":"User","site_admin":false},"body":"Fixes #1846","created_at":"2017-09-18T15:47:55Z","updated_at":"2017-09-26T11:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9968ea76fa532751fafd8f9e0601b2d95157435","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1847/commits","review_comments_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1847/comments","review_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/1847/comments","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/bd201c8ab9017c29ec26fc002e5d49569d4959be","head":{"label":"mysociety:issues/1846-admin-report-status-adds-comment","ref":"issues/1846-admin-report-status-adds-comment","sha":"bd201c8ab9017c29ec26fc002e5d49569d4959be","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":487492,"name":"fixmystreet","full_name":"mysociety/fixmystreet","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/fixmystreet","description":"This is mySociety's popular map-based reporting platform: easy to install in new countries and regions","fork":false,"url":"https://api.github.com/repos/mysociety/fixmystreet","forks_url":"https://api.github.com/repos/mysociety/fixmystreet/forks","keys_url":"https://api.github.com/repos/mysociety/fixmystreet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/fixmystreet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/fixmystreet/teams","hooks_url":"https://api.github.com/repos/mysociety/fixmystreet/hooks","issue_events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/fixmystreet/events","assignees_url":"https://api.github.com/repos/mysociety/fixmystreet/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/fixmystreet/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/fixmystreet/tags","blobs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/fixmystreet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/fixmystreet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/fixmystreet/languages","stargazers_url":"https://api.github.com/repos/mysociety/fixmystreet/stargazers","contributors_url":"https://api.github.com/repos/mysociety/fixmystreet/contributors","subscribers_url":"https://api.github.com/repos/mysociety/fixmystreet/subscribers","subscription_url":"https://api.github.com/repos/mysociety/fixmystreet/subscription","commits_url":"https://api.github.com/repos/mysociety/fixmystreet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/fixmystreet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysociety/fixmystreet/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/fixmystreet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/fixmystreet/merges","archive_url":"https://api.github.com/repos/mysociety/fixmystreet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/fixmystreet/downloads","issues_url":"https://api.github.com/repos/mysociety/fixmystreet/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/fixmystreet/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/fixmystreet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/fixmystreet/releases{/id}","deployments_url":"https://api.github.com/repos/mysociety/fixmystreet/deployments","created_at":"2010-01-25T11:54:20Z","updated_at":"2017-09-24T14:22:28Z","pushed_at":"2017-09-26T09:07:23Z","git_url":"git://github.com/mysociety/fixmystreet.git","ssh_url":"[email protected]:mysociety/fixmystreet.git","clone_url":"https://github.com/mysociety/fixmystreet.git","svn_url":"https://github.com/mysociety/fixmystreet","homepage":"http://fixmystreet.org/","size":101058,"stargazers_count":322,"watchers_count":322,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":167,"mirror_url":null,"open_issues_count":209,"forks":167,"open_issues":209,"watchers":322,"default_branch":"master"}},"base":{"label":"mysociety:master","ref":"master","sha":"4481488cb83b89dce51933efb64606fb779e5d60","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":487492,"name":"fixmystreet","full_name":"mysociety/fixmystreet","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/fixmystreet","description":"This is mySociety's popular map-based reporting platform: easy to install in new countries and regions","fork":false,"url":"https://api.github.com/repos/mysociety/fixmystreet","forks_url":"https://api.github.com/repos/mysociety/fixmystreet/forks","keys_url":"https://api.github.com/repos/mysociety/fixmystreet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/fixmystreet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/fixmystreet/teams","hooks_url":"https://api.github.com/repos/mysociety/fixmystreet/hooks","issue_events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/fixmystreet/events","assignees_url":"https://api.github.com/repos/mysociety/fixmystreet/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/fixmystreet/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/fixmystreet/tags","blobs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/fixmystreet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/fixmystreet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/fixmystreet/languages","stargazers_url":"https://api.github.com/repos/mysociety/fixmystreet/stargazers","contributors_url":"https://api.github.com/repos/mysociety/fixmystreet/contributors","subscribers_url":"https://api.github.com/repos/mysociety/fixmystreet/subscribers","subscription_url":"https://api.github.com/repos/mysociety/fixmystreet/subscription","commits_url":"https://api.github.com/repos/mysociety/fixmystreet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/fixmystreet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysociety/fixmystreet/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/fixmystreet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/fixmystreet/merges","archive_url":"https://api.github.com/repos/mysociety/fixmystreet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/fixmystreet/downloads","issues_url":"https://api.github.com/repos/mysociety/fixmystreet/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/fixmystreet/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/fixmystreet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/fixmystreet/releases{/id}","deployments_url":"https://api.github.com/repos/mysociety/fixmystreet/deployments","created_at":"2010-01-25T11:54:20Z","updated_at":"2017-09-24T14:22:28Z","pushed_at":"2017-09-26T09:07:23Z","git_url":"git://github.com/mysociety/fixmystreet.git","ssh_url":"[email protected]:mysociety/fixmystreet.git","clone_url":"https://github.com/mysociety/fixmystreet.git","svn_url":"https://github.com/mysociety/fixmystreet","homepage":"http://fixmystreet.org/","size":101058,"stargazers_count":322,"watchers_count":322,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":167,"mirror_url":null,"open_issues_count":209,"forks":167,"open_issues":209,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1847"},"html":{"href":"https://github.com/mysociety/fixmystreet/pull/1847"},"issue":{"href":"https://api.github.com/repos/mysociety/fixmystreet/issues/1847"},"comments":{"href":"https://api.github.com/repos/mysociety/fixmystreet/issues/1847/comments"},"review_comments":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1847/comments"},"review_comment":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1847/commits"},"statuses":{"href":"https://api.github.com/repos/mysociety/fixmystreet/statuses/bd201c8ab9017c29ec26fc002e5d49569d4959be"}},"author_association":"OWNER"}} | {
"id": 487492,
"name": "mysociety/fixmystreet",
"url": "https://api.github.com/repos/mysociety/fixmystreet"
} | {
"id": 154364,
"login": "dracos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/154364?",
"url": "https://api.github.com/users/dracos"
} | {
"id": 141338,
"login": "mysociety",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/141338?",
"url": "https://api.github.com/orgs/mysociety"
} | 2017-09-26T11:05:13 | 6637746336 | {"actor":{"display_login":"dracos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/noggalito/porttare-backend/pulls/comments/98107587","pull_request_review_id":18740390,"id":98107587,"diff_hunk":"@@ -1,9 +1,11 @@\n class AssignDefaultPlaceToShippingRequests < ActiveRecord::Migration\n def up\n say_with_time \"making all shipping requests belong to first place\" do\n- place_id = Place.first.id\n- ShippingRequest.find_each do |shipping_request|\n- shipping_request.update!(place_id: place_id)\n+ if Place.first\n+ place_id = Place.first.id\n+ ShippingRequest.find_each do |shipping_request|","path":"db/migrate/20170120045725_assign_default_place_to_shipping_requests.rb","position":9,"original_position":9,"commit_id":"82bdd2defa854f8769c7e4d357c325e122f225b8","original_commit_id":"82bdd2defa854f8769c7e4d357c325e122f225b8","user":{"login":"macool","id":1407000,"avatar_url":"https://avatars.githubusercontent.com/u/1407000?v=3","gravatar_id":"","url":"https://api.github.com/users/macool","html_url":"https://github.com/macool","followers_url":"https://api.github.com/users/macool/followers","following_url":"https://api.github.com/users/macool/following{/other_user}","gists_url":"https://api.github.com/users/macool/gists{/gist_id}","starred_url":"https://api.github.com/users/macool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macool/subscriptions","organizations_url":"https://api.github.com/users/macool/orgs","repos_url":"https://api.github.com/users/macool/repos","events_url":"https://api.github.com/users/macool/events{/privacy}","received_events_url":"https://api.github.com/users/macool/received_events","type":"User","site_admin":false},"body":"grax","created_at":"2017-01-26T22:27:49Z","updated_at":"2017-01-26T22:27:49Z","html_url":"https://github.com/noggalito/porttare-backend/pull/108#discussion_r98107587","pull_request_url":"https://api.github.com/repos/noggalito/porttare-backend/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/noggalito/porttare-backend/pulls/comments/98107587"},"html":{"href":"https://github.com/noggalito/porttare-backend/pull/108#discussion_r98107587"},"pull_request":{"href":"https://api.github.com/repos/noggalito/porttare-backend/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/noggalito/porttare-backend/pulls/108","id":103373350,"html_url":"https://github.com/noggalito/porttare-backend/pull/108","diff_url":"https://github.com/noggalito/porttare-backend/pull/108.diff","patch_url":"https://github.com/noggalito/porttare-backend/pull/108.patch","issue_url":"https://api.github.com/repos/noggalito/porttare-backend/issues/108","number":108,"state":"closed","locked":false,"title":"Add fallback when no places in db","user":{"login":"fabricioflores","id":3495122,"avatar_url":"https://avatars.githubusercontent.com/u/3495122?v=3","gravatar_id":"","url":"https://api.github.com/users/fabricioflores","html_url":"https://github.com/fabricioflores","followers_url":"https://api.github.com/users/fabricioflores/followers","following_url":"https://api.github.com/users/fabricioflores/following{/other_user}","gists_url":"https://api.github.com/users/fabricioflores/gists{/gist_id}","starred_url":"https://api.github.com/users/fabricioflores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabricioflores/subscriptions","organizations_url":"https://api.github.com/users/fabricioflores/orgs","repos_url":"https://api.github.com/users/fabricioflores/repos","events_url":"https://api.github.com/users/fabricioflores/events{/privacy}","received_events_url":"https://api.github.com/users/fabricioflores/received_events","type":"User","site_admin":false},"body":"@macool se estaban cayendo las migraciones cuando no habían places en la base de datos","created_at":"2017-01-26T19:33:14Z","updated_at":"2017-01-26T22:27:49Z","closed_at":"2017-01-26T22:23:04Z","merged_at":null,"merge_commit_sha":"c6c5f4ddd0d87fa3f47670d1e74d6923091211d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/noggalito/porttare-backend/pulls/108/commits","review_comments_url":"https://api.github.com/repos/noggalito/porttare-backend/pulls/108/comments","review_comment_url":"https://api.github.com/repos/noggalito/porttare-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/noggalito/porttare-backend/issues/108/comments","statuses_url":"https://api.github.com/repos/noggalito/porttare-backend/statuses/82bdd2defa854f8769c7e4d357c325e122f225b8","head":{"label":"noggalito:hotfix-migrations","ref":"hotfix-migrations","sha":"82bdd2defa854f8769c7e4d357c325e122f225b8","user":{"login":"noggalito","id":13799443,"avatar_url":"https://avatars.githubusercontent.com/u/13799443?v=3","gravatar_id":"","url":"https://api.github.com/users/noggalito","html_url":"https://github.com/noggalito","followers_url":"https://api.github.com/users/noggalito/followers","following_url":"https://api.github.com/users/noggalito/following{/other_user}","gists_url":"https://api.github.com/users/noggalito/gists{/gist_id}","starred_url":"https://api.github.com/users/noggalito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noggalito/subscriptions","organizations_url":"https://api.github.com/users/noggalito/orgs","repos_url":"https://api.github.com/users/noggalito/repos","events_url":"https://api.github.com/users/noggalito/events{/privacy}","received_events_url":"https://api.github.com/users/noggalito/received_events","type":"Organization","site_admin":false},"repo":{"id":60016168,"name":"porttare-backend","full_name":"noggalito/porttare-backend","owner":{"login":"noggalito","id":13799443,"avatar_url":"https://avatars.githubusercontent.com/u/13799443?v=3","gravatar_id":"","url":"https://api.github.com/users/noggalito","html_url":"https://github.com/noggalito","followers_url":"https://api.github.com/users/noggalito/followers","following_url":"https://api.github.com/users/noggalito/following{/other_user}","gists_url":"https://api.github.com/users/noggalito/gists{/gist_id}","starred_url":"https://api.github.com/users/noggalito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noggalito/subscriptions","organizations_url":"https://api.github.com/users/noggalito/orgs","repos_url":"https://api.github.com/users/noggalito/repos","events_url":"https://api.github.com/users/noggalito/events{/privacy}","received_events_url":"https://api.github.com/users/noggalito/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/noggalito/porttare-backend","description":null,"fork":false,"url":"https://api.github.com/repos/noggalito/porttare-backend","forks_url":"https://api.github.com/repos/noggalito/porttare-backend/forks","keys_url":"https://api.github.com/repos/noggalito/porttare-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noggalito/porttare-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noggalito/porttare-backend/teams","hooks_url":"https://api.github.com/repos/noggalito/porttare-backend/hooks","issue_events_url":"https://api.github.com/repos/noggalito/porttare-backend/issues/events{/number}","events_url":"https://api.github.com/repos/noggalito/porttare-backend/events","assignees_url":"https://api.github.com/repos/noggalito/porttare-backend/assignees{/user}","branches_url":"https://api.github.com/repos/noggalito/porttare-backend/branches{/branch}","tags_url":"https://api.github.com/repos/noggalito/porttare-backend/tags","blobs_url":"https://api.github.com/repos/noggalito/porttare-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noggalito/porttare-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noggalito/porttare-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/noggalito/porttare-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noggalito/porttare-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/noggalito/porttare-backend/languages","stargazers_url":"https://api.github.com/repos/noggalito/porttare-backend/stargazers","contributors_url":"https://api.github.com/repos/noggalito/porttare-backend/contributors","subscribers_url":"https://api.github.com/repos/noggalito/porttare-backend/subscribers","subscription_url":"https://api.github.com/repos/noggalito/porttare-backend/subscription","commits_url":"https://api.github.com/repos/noggalito/porttare-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/noggalito/porttare-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/noggalito/porttare-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/noggalito/porttare-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/noggalito/porttare-backend/contents/{+path}","compare_url":"https://api.github.com/repos/noggalito/porttare-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noggalito/porttare-backend/merges","archive_url":"https://api.github.com/repos/noggalito/porttare-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noggalito/porttare-backend/downloads","issues_url":"https://api.github.com/repos/noggalito/porttare-backend/issues{/number}","pulls_url":"https://api.github.com/repos/noggalito/porttare-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/noggalito/porttare-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/noggalito/porttare-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noggalito/porttare-backend/labels{/name}","releases_url":"https://api.github.com/repos/noggalito/porttare-backend/releases{/id}","deployments_url":"https://api.github.com/repos/noggalito/porttare-backend/deployments","created_at":"2016-05-30T14:27:23Z","updated_at":"2016-10-23T23:17:18Z","pushed_at":"2017-01-26T22:23:29Z","git_url":"git://github.com/noggalito/porttare-backend.git","ssh_url":"[email protected]:noggalito/porttare-backend.git","clone_url":"https://github.com/noggalito/porttare-backend.git","svn_url":"https://github.com/noggalito/porttare-backend","homepage":"https://porttare-backend.herokuapp.com","size":2383,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"noggalito:master","ref":"master","sha":"a1e170f80de29c31549262af974ebcfb519dbef0","user":{"login":"noggalito","id":13799443,"avatar_url":"https://avatars.githubusercontent.com/u/13799443?v=3","gravatar_id":"","url":"https://api.github.com/users/noggalito","html_url":"https://github.com/noggalito","followers_url":"https://api.github.com/users/noggalito/followers","following_url":"https://api.github.com/users/noggalito/following{/other_user}","gists_url":"https://api.github.com/users/noggalito/gists{/gist_id}","starred_url":"https://api.github.com/users/noggalito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noggalito/subscriptions","organizations_url":"https://api.github.com/users/noggalito/orgs","repos_url":"https://api.github.com/users/noggalito/repos","events_url":"https://api.github.com/users/noggalito/events{/privacy}","received_events_url":"https://api.github.com/users/noggalito/received_events","type":"Organization","site_admin":false},"repo":{"id":60016168,"name":"porttare-backend","full_name":"noggalito/porttare-backend","owner":{"login":"noggalito","id":13799443,"avatar_url":"https://avatars.githubusercontent.com/u/13799443?v=3","gravatar_id":"","url":"https://api.github.com/users/noggalito","html_url":"https://github.com/noggalito","followers_url":"https://api.github.com/users/noggalito/followers","following_url":"https://api.github.com/users/noggalito/following{/other_user}","gists_url":"https://api.github.com/users/noggalito/gists{/gist_id}","starred_url":"https://api.github.com/users/noggalito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noggalito/subscriptions","organizations_url":"https://api.github.com/users/noggalito/orgs","repos_url":"https://api.github.com/users/noggalito/repos","events_url":"https://api.github.com/users/noggalito/events{/privacy}","received_events_url":"https://api.github.com/users/noggalito/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/noggalito/porttare-backend","description":null,"fork":false,"url":"https://api.github.com/repos/noggalito/porttare-backend","forks_url":"https://api.github.com/repos/noggalito/porttare-backend/forks","keys_url":"https://api.github.com/repos/noggalito/porttare-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noggalito/porttare-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noggalito/porttare-backend/teams","hooks_url":"https://api.github.com/repos/noggalito/porttare-backend/hooks","issue_events_url":"https://api.github.com/repos/noggalito/porttare-backend/issues/events{/number}","events_url":"https://api.github.com/repos/noggalito/porttare-backend/events","assignees_url":"https://api.github.com/repos/noggalito/porttare-backend/assignees{/user}","branches_url":"https://api.github.com/repos/noggalito/porttare-backend/branches{/branch}","tags_url":"https://api.github.com/repos/noggalito/porttare-backend/tags","blobs_url":"https://api.github.com/repos/noggalito/porttare-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noggalito/porttare-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noggalito/porttare-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/noggalito/porttare-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noggalito/porttare-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/noggalito/porttare-backend/languages","stargazers_url":"https://api.github.com/repos/noggalito/porttare-backend/stargazers","contributors_url":"https://api.github.com/repos/noggalito/porttare-backend/contributors","subscribers_url":"https://api.github.com/repos/noggalito/porttare-backend/subscribers","subscription_url":"https://api.github.com/repos/noggalito/porttare-backend/subscription","commits_url":"https://api.github.com/repos/noggalito/porttare-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/noggalito/porttare-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/noggalito/porttare-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/noggalito/porttare-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/noggalito/porttare-backend/contents/{+path}","compare_url":"https://api.github.com/repos/noggalito/porttare-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noggalito/porttare-backend/merges","archive_url":"https://api.github.com/repos/noggalito/porttare-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noggalito/porttare-backend/downloads","issues_url":"https://api.github.com/repos/noggalito/porttare-backend/issues{/number}","pulls_url":"https://api.github.com/repos/noggalito/porttare-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/noggalito/porttare-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/noggalito/porttare-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noggalito/porttare-backend/labels{/name}","releases_url":"https://api.github.com/repos/noggalito/porttare-backend/releases{/id}","deployments_url":"https://api.github.com/repos/noggalito/porttare-backend/deployments","created_at":"2016-05-30T14:27:23Z","updated_at":"2016-10-23T23:17:18Z","pushed_at":"2017-01-26T22:23:29Z","git_url":"git://github.com/noggalito/porttare-backend.git","ssh_url":"[email protected]:noggalito/porttare-backend.git","clone_url":"https://github.com/noggalito/porttare-backend.git","svn_url":"https://github.com/noggalito/porttare-backend","homepage":"https://porttare-backend.herokuapp.com","size":2383,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/noggalito/porttare-backend/pulls/108"},"html":{"href":"https://github.com/noggalito/porttare-backend/pull/108"},"issue":{"href":"https://api.github.com/repos/noggalito/porttare-backend/issues/108"},"comments":{"href":"https://api.github.com/repos/noggalito/porttare-backend/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/noggalito/porttare-backend/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/noggalito/porttare-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/noggalito/porttare-backend/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/noggalito/porttare-backend/statuses/82bdd2defa854f8769c7e4d357c325e122f225b8"}}}} | {
"id": 60016168,
"name": "noggalito/porttare-backend",
"url": "https://api.github.com/repos/noggalito/porttare-backend"
} | {
"id": 1407000,
"login": "macool",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1407000?",
"url": "https://api.github.com/users/macool"
} | {
"id": 13799443,
"login": "noggalito",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13799443?",
"url": "https://api.github.com/orgs/noggalito"
} | 2017-01-26T22:27:49 | 5220644745 | {"actor":{"display_login":"macool"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openscope/openscope/pulls/comments/99481561","pull_request_review_id":20162512,"id":99481561,"diff_hunk":"@@ -0,0 +1,44 @@\n+import _get from 'lodash/get';\n+\n+/**\n+ *\n+ * @class WaypointModel\n+ */\n+export default class WaypointModel {\n+ /**\n+ *\n+ * @constructor\n+ * @param waypointProps {object}\n+ */\n+ constructor(waypointProps) {\n+ this.name = '';\n+ this.position = null;\n+ this.speedRestriction = -1;\n+ this.altitudeRestriction = -1;\n+\n+ // this.hold = {\n+ // dirTurns: null,\n+ // fixName: null,\n+ // fixPos: null,\n+ // inboundHd: null,\n+ // legLength: null,\n+ // timer: 0\n+ // };","path":"src/assets/scripts/client/aircraft/FlightManagementSystem/WaypointModel.js","position":26,"original_position":26,"commit_id":"c15de5ca697ff9a646d0e1ffa82ed846422a0180","original_commit_id":"c15de5ca697ff9a646d0e1ffa82ed846422a0180","user":{"login":"n8rzz","id":3325985,"avatar_url":"https://avatars.githubusercontent.com/u/3325985?v=3","gravatar_id":"","url":"https://api.github.com/users/n8rzz","html_url":"https://github.com/n8rzz","followers_url":"https://api.github.com/users/n8rzz/followers","following_url":"https://api.github.com/users/n8rzz/following{/other_user}","gists_url":"https://api.github.com/users/n8rzz/gists{/gist_id}","starred_url":"https://api.github.com/users/n8rzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n8rzz/subscriptions","organizations_url":"https://api.github.com/users/n8rzz/orgs","repos_url":"https://api.github.com/users/n8rzz/repos","events_url":"https://api.github.com/users/n8rzz/events{/privacy}","received_events_url":"https://api.github.com/users/n8rzz/received_events","type":"User","site_admin":false},"body":"ha! well, not yet. I'm not sure this is really a poor implementation, I mean it works doesn't it? Once I get the main methods for the Fms and a basic Mcp up and running, holds are going to be the first thing I tackle. So we'll know soon.","created_at":"2017-02-05T05:14:36Z","updated_at":"2017-02-05T05:14:36Z","html_url":"https://github.com/openscope/openscope/pull/193#discussion_r99481561","pull_request_url":"https://api.github.com/repos/openscope/openscope/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/openscope/openscope/pulls/comments/99481561"},"html":{"href":"https://github.com/openscope/openscope/pull/193#discussion_r99481561"},"pull_request":{"href":"https://api.github.com/repos/openscope/openscope/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/openscope/openscope/pulls/193","id":103684905,"html_url":"https://github.com/openscope/openscope/pull/193","diff_url":"https://github.com/openscope/openscope/pull/193.diff","patch_url":"https://github.com/openscope/openscope/pull/193.patch","issue_url":"https://api.github.com/repos/openscope/openscope/issues/193","number":193,"state":"open","locked":false,"title":"[WIP] feature/139","user":{"login":"n8rzz","id":3325985,"avatar_url":"https://avatars.githubusercontent.com/u/3325985?v=3","gravatar_id":"","url":"https://api.github.com/users/n8rzz","html_url":"https://github.com/n8rzz","followers_url":"https://api.github.com/users/n8rzz/followers","following_url":"https://api.github.com/users/n8rzz/following{/other_user}","gists_url":"https://api.github.com/users/n8rzz/gists{/gist_id}","starred_url":"https://api.github.com/users/n8rzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n8rzz/subscriptions","organizations_url":"https://api.github.com/users/n8rzz/orgs","repos_url":"https://api.github.com/users/n8rzz/repos","events_url":"https://api.github.com/users/n8rzz/events{/privacy}","received_events_url":"https://api.github.com/users/n8rzz/received_events","type":"User","site_admin":false},"body":"[will] completes #139 \r\n\r\nI have added you all to this one because there will be a lot of change involved with this PR and the more eyes on it the better. Feel free to open up the review app to view current progress.\r\n\r\nIf you see something, say something!","created_at":"2017-01-30T06:32:09Z","updated_at":"2017-02-05T05:14:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebe28f6775854d55b8e9b8168a22dd2b2843b38f","assignee":{"login":"erikquinn","id":5103735,"avatar_url":"https://avatars.githubusercontent.com/u/5103735?v=3","gravatar_id":"","url":"https://api.github.com/users/erikquinn","html_url":"https://github.com/erikquinn","followers_url":"https://api.github.com/users/erikquinn/followers","following_url":"https://api.github.com/users/erikquinn/following{/other_user}","gists_url":"https://api.github.com/users/erikquinn/gists{/gist_id}","starred_url":"https://api.github.com/users/erikquinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikquinn/subscriptions","organizations_url":"https://api.github.com/users/erikquinn/orgs","repos_url":"https://api.github.com/users/erikquinn/repos","events_url":"https://api.github.com/users/erikquinn/events{/privacy}","received_events_url":"https://api.github.com/users/erikquinn/received_events","type":"User","site_admin":false},"assignees":[{"login":"erikquinn","id":5103735,"avatar_url":"https://avatars.githubusercontent.com/u/5103735?v=3","gravatar_id":"","url":"https://api.github.com/users/erikquinn","html_url":"https://github.com/erikquinn","followers_url":"https://api.github.com/users/erikquinn/followers","following_url":"https://api.github.com/users/erikquinn/following{/other_user}","gists_url":"https://api.github.com/users/erikquinn/gists{/gist_id}","starred_url":"https://api.github.com/users/erikquinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikquinn/subscriptions","organizations_url":"https://api.github.com/users/erikquinn/orgs","repos_url":"https://api.github.com/users/erikquinn/repos","events_url":"https://api.github.com/users/erikquinn/events{/privacy}","received_events_url":"https://api.github.com/users/erikquinn/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openscope/openscope/milestones/1","html_url":"https://github.com/openscope/openscope/milestone/1","labels_url":"https://api.github.com/repos/openscope/openscope/milestones/1/labels","id":2260308,"number":1,"title":"v4.1.0","description":"","creator":{"login":"n8rzz","id":3325985,"avatar_url":"https://avatars.githubusercontent.com/u/3325985?v=3","gravatar_id":"","url":"https://api.github.com/users/n8rzz","html_url":"https://github.com/n8rzz","followers_url":"https://api.github.com/users/n8rzz/followers","following_url":"https://api.github.com/users/n8rzz/following{/other_user}","gists_url":"https://api.github.com/users/n8rzz/gists{/gist_id}","starred_url":"https://api.github.com/users/n8rzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n8rzz/subscriptions","organizations_url":"https://api.github.com/users/n8rzz/orgs","repos_url":"https://api.github.com/users/n8rzz/repos","events_url":"https://api.github.com/users/n8rzz/events{/privacy}","received_events_url":"https://api.github.com/users/n8rzz/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":16,"state":"open","created_at":"2017-01-18T02:53:15Z","updated_at":"2017-02-04T21:06:17Z","due_on":"2017-02-19T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/openscope/openscope/pulls/193/commits","review_comments_url":"https://api.github.com/repos/openscope/openscope/pulls/193/comments","review_comment_url":"https://api.github.com/repos/openscope/openscope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openscope/openscope/issues/193/comments","statuses_url":"https://api.github.com/repos/openscope/openscope/statuses/c15de5ca697ff9a646d0e1ffa82ed846422a0180","head":{"label":"openscope:feature/139","ref":"feature/139","sha":"c15de5ca697ff9a646d0e1ffa82ed846422a0180","user":{"login":"openscope","id":19348939,"avatar_url":"https://avatars.githubusercontent.com/u/19348939?v=3","gravatar_id":"","url":"https://api.github.com/users/openscope","html_url":"https://github.com/openscope","followers_url":"https://api.github.com/users/openscope/followers","following_url":"https://api.github.com/users/openscope/following{/other_user}","gists_url":"https://api.github.com/users/openscope/gists{/gist_id}","starred_url":"https://api.github.com/users/openscope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscope/subscriptions","organizations_url":"https://api.github.com/users/openscope/orgs","repos_url":"https://api.github.com/users/openscope/repos","events_url":"https://api.github.com/users/openscope/events{/privacy}","received_events_url":"https://api.github.com/users/openscope/received_events","type":"Organization","site_admin":false},"repo":{"id":77648370,"name":"openscope","full_name":"openscope/openscope","owner":{"login":"openscope","id":19348939,"avatar_url":"https://avatars.githubusercontent.com/u/19348939?v=3","gravatar_id":"","url":"https://api.github.com/users/openscope","html_url":"https://github.com/openscope","followers_url":"https://api.github.com/users/openscope/followers","following_url":"https://api.github.com/users/openscope/following{/other_user}","gists_url":"https://api.github.com/users/openscope/gists{/gist_id}","starred_url":"https://api.github.com/users/openscope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscope/subscriptions","organizations_url":"https://api.github.com/users/openscope/orgs","repos_url":"https://api.github.com/users/openscope/repos","events_url":"https://api.github.com/users/openscope/events{/privacy}","received_events_url":"https://api.github.com/users/openscope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openscope/openscope","description":null,"fork":false,"url":"https://api.github.com/repos/openscope/openscope","forks_url":"https://api.github.com/repos/openscope/openscope/forks","keys_url":"https://api.github.com/repos/openscope/openscope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openscope/openscope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openscope/openscope/teams","hooks_url":"https://api.github.com/repos/openscope/openscope/hooks","issue_events_url":"https://api.github.com/repos/openscope/openscope/issues/events{/number}","events_url":"https://api.github.com/repos/openscope/openscope/events","assignees_url":"https://api.github.com/repos/openscope/openscope/assignees{/user}","branches_url":"https://api.github.com/repos/openscope/openscope/branches{/branch}","tags_url":"https://api.github.com/repos/openscope/openscope/tags","blobs_url":"https://api.github.com/repos/openscope/openscope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openscope/openscope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openscope/openscope/git/refs{/sha}","trees_url":"https://api.github.com/repos/openscope/openscope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openscope/openscope/statuses/{sha}","languages_url":"https://api.github.com/repos/openscope/openscope/languages","stargazers_url":"https://api.github.com/repos/openscope/openscope/stargazers","contributors_url":"https://api.github.com/repos/openscope/openscope/contributors","subscribers_url":"https://api.github.com/repos/openscope/openscope/subscribers","subscription_url":"https://api.github.com/repos/openscope/openscope/subscription","commits_url":"https://api.github.com/repos/openscope/openscope/commits{/sha}","git_commits_url":"https://api.github.com/repos/openscope/openscope/git/commits{/sha}","comments_url":"https://api.github.com/repos/openscope/openscope/comments{/number}","issue_comment_url":"https://api.github.com/repos/openscope/openscope/issues/comments{/number}","contents_url":"https://api.github.com/repos/openscope/openscope/contents/{+path}","compare_url":"https://api.github.com/repos/openscope/openscope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openscope/openscope/merges","archive_url":"https://api.github.com/repos/openscope/openscope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openscope/openscope/downloads","issues_url":"https://api.github.com/repos/openscope/openscope/issues{/number}","pulls_url":"https://api.github.com/repos/openscope/openscope/pulls{/number}","milestones_url":"https://api.github.com/repos/openscope/openscope/milestones{/number}","notifications_url":"https://api.github.com/repos/openscope/openscope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openscope/openscope/labels{/name}","releases_url":"https://api.github.com/repos/openscope/openscope/releases{/id}","deployments_url":"https://api.github.com/repos/openscope/openscope/deployments","created_at":"2016-12-30T00:32:13Z","updated_at":"2017-02-03T13:18:54Z","pushed_at":"2017-02-05T00:00:35Z","git_url":"git://github.com/openscope/openscope.git","ssh_url":"[email protected]:openscope/openscope.git","clone_url":"https://github.com/openscope/openscope.git","svn_url":"https://github.com/openscope/openscope","homepage":null,"size":10229,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":166,"forks":4,"open_issues":166,"watchers":5,"default_branch":"develop"}},"base":{"label":"openscope:develop","ref":"develop","sha":"715f4f5cc5288ac1bdab62c1a088081085f11284","user":{"login":"openscope","id":19348939,"avatar_url":"https://avatars.githubusercontent.com/u/19348939?v=3","gravatar_id":"","url":"https://api.github.com/users/openscope","html_url":"https://github.com/openscope","followers_url":"https://api.github.com/users/openscope/followers","following_url":"https://api.github.com/users/openscope/following{/other_user}","gists_url":"https://api.github.com/users/openscope/gists{/gist_id}","starred_url":"https://api.github.com/users/openscope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscope/subscriptions","organizations_url":"https://api.github.com/users/openscope/orgs","repos_url":"https://api.github.com/users/openscope/repos","events_url":"https://api.github.com/users/openscope/events{/privacy}","received_events_url":"https://api.github.com/users/openscope/received_events","type":"Organization","site_admin":false},"repo":{"id":77648370,"name":"openscope","full_name":"openscope/openscope","owner":{"login":"openscope","id":19348939,"avatar_url":"https://avatars.githubusercontent.com/u/19348939?v=3","gravatar_id":"","url":"https://api.github.com/users/openscope","html_url":"https://github.com/openscope","followers_url":"https://api.github.com/users/openscope/followers","following_url":"https://api.github.com/users/openscope/following{/other_user}","gists_url":"https://api.github.com/users/openscope/gists{/gist_id}","starred_url":"https://api.github.com/users/openscope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscope/subscriptions","organizations_url":"https://api.github.com/users/openscope/orgs","repos_url":"https://api.github.com/users/openscope/repos","events_url":"https://api.github.com/users/openscope/events{/privacy}","received_events_url":"https://api.github.com/users/openscope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openscope/openscope","description":null,"fork":false,"url":"https://api.github.com/repos/openscope/openscope","forks_url":"https://api.github.com/repos/openscope/openscope/forks","keys_url":"https://api.github.com/repos/openscope/openscope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openscope/openscope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openscope/openscope/teams","hooks_url":"https://api.github.com/repos/openscope/openscope/hooks","issue_events_url":"https://api.github.com/repos/openscope/openscope/issues/events{/number}","events_url":"https://api.github.com/repos/openscope/openscope/events","assignees_url":"https://api.github.com/repos/openscope/openscope/assignees{/user}","branches_url":"https://api.github.com/repos/openscope/openscope/branches{/branch}","tags_url":"https://api.github.com/repos/openscope/openscope/tags","blobs_url":"https://api.github.com/repos/openscope/openscope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openscope/openscope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openscope/openscope/git/refs{/sha}","trees_url":"https://api.github.com/repos/openscope/openscope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openscope/openscope/statuses/{sha}","languages_url":"https://api.github.com/repos/openscope/openscope/languages","stargazers_url":"https://api.github.com/repos/openscope/openscope/stargazers","contributors_url":"https://api.github.com/repos/openscope/openscope/contributors","subscribers_url":"https://api.github.com/repos/openscope/openscope/subscribers","subscription_url":"https://api.github.com/repos/openscope/openscope/subscription","commits_url":"https://api.github.com/repos/openscope/openscope/commits{/sha}","git_commits_url":"https://api.github.com/repos/openscope/openscope/git/commits{/sha}","comments_url":"https://api.github.com/repos/openscope/openscope/comments{/number}","issue_comment_url":"https://api.github.com/repos/openscope/openscope/issues/comments{/number}","contents_url":"https://api.github.com/repos/openscope/openscope/contents/{+path}","compare_url":"https://api.github.com/repos/openscope/openscope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openscope/openscope/merges","archive_url":"https://api.github.com/repos/openscope/openscope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openscope/openscope/downloads","issues_url":"https://api.github.com/repos/openscope/openscope/issues{/number}","pulls_url":"https://api.github.com/repos/openscope/openscope/pulls{/number}","milestones_url":"https://api.github.com/repos/openscope/openscope/milestones{/number}","notifications_url":"https://api.github.com/repos/openscope/openscope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openscope/openscope/labels{/name}","releases_url":"https://api.github.com/repos/openscope/openscope/releases{/id}","deployments_url":"https://api.github.com/repos/openscope/openscope/deployments","created_at":"2016-12-30T00:32:13Z","updated_at":"2017-02-03T13:18:54Z","pushed_at":"2017-02-05T00:00:35Z","git_url":"git://github.com/openscope/openscope.git","ssh_url":"[email protected]:openscope/openscope.git","clone_url":"https://github.com/openscope/openscope.git","svn_url":"https://github.com/openscope/openscope","homepage":null,"size":10229,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":166,"forks":4,"open_issues":166,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openscope/openscope/pulls/193"},"html":{"href":"https://github.com/openscope/openscope/pull/193"},"issue":{"href":"https://api.github.com/repos/openscope/openscope/issues/193"},"comments":{"href":"https://api.github.com/repos/openscope/openscope/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/openscope/openscope/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/openscope/openscope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openscope/openscope/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/openscope/openscope/statuses/c15de5ca697ff9a646d0e1ffa82ed846422a0180"}}}} | {
"id": 77648370,
"name": "openscope/openscope",
"url": "https://api.github.com/repos/openscope/openscope"
} | {
"id": 3325985,
"login": "n8rzz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3325985?",
"url": "https://api.github.com/users/n8rzz"
} | {
"id": 19348939,
"login": "openscope",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19348939?",
"url": "https://api.github.com/orgs/openscope"
} | 2017-02-05T05:14:36 | 5267974221 | {"actor":{"display_login":"n8rzz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/102252115","pull_request_review_id":23003472,"id":102252115,"diff_hunk":"@@ -243,7 +266,10 @@ def openshift_cmd(self, cmd, oadm=False, output=False, output_type='json', input\n if self.verbose:\n print(' '.join(cmds))\n \n- returncode, stdout, stderr = self._run(cmds, input_data)\n+ try:\n+ returncode, stdout, stderr = self._run(cmds, input_data)","path":"roles/lib_openshift/src/lib/base.py","position":59,"original_position":59,"commit_id":"b96ff044de99e1dd85c70cd10329134e6613ed38","original_commit_id":"b96ff044de99e1dd85c70cd10329134e6613ed38","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"@detiber the discussion you linked to seems to be related to changing the env of the current process. Here the case is different, we are setting up the env for a process we are about to spawn.","created_at":"2017-02-21T16:30:44Z","updated_at":"2017-02-21T16:30:44Z","html_url":"https://github.com/openshift/openshift-ansible/pull/3416#discussion_r102252115","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3416","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/102252115"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/3416#discussion_r102252115"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3416"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3416","id":106890248,"html_url":"https://github.com/openshift/openshift-ansible/pull/3416","diff_url":"https://github.com/openshift/openshift-ansible/pull/3416.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/3416.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/3416","number":3416,"state":"open","locked":false,"title":"lib_openshift - handle cases where oc binary is not in path","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"Handle cases where the oc binary is not in the user path\r\n\r\n- Move binary file search to separate method called from constructor\r\n- Use six.PY3 instaed of sys.version_info\r\n- Combine `/usr/local/bin` and `~/bin` with the paths from the environment\r\n - For py3 pass the combined paths to shutil.which\r\n - For py2 explictly search for existance of file from combined paths\r\n instead of using distutils.spawn.find_executable and falling back\r\n- Use 'oc adm' instead of 'oadm'\r\n- Fix generate_validation test issue\r\n- fix tests for oc binary location\r\n- add tests for file lookup\r\n\r\nCloses: #3413 \r\nCloses: #3410 ","created_at":"2017-02-19T06:17:29Z","updated_at":"2017-02-21T16:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"223f49a0968a06ccb5be4322d1a387b79098068f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3416/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3416/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/3416/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/b96ff044de99e1dd85c70cd10329134e6613ed38","head":{"label":"detiber:combinedTest","ref":"combinedTest","sha":"b96ff044de99e1dd85c70cd10329134e6613ed38","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"repo":{"id":29140945,"name":"openshift-ansible","full_name":"detiber/openshift-ansible","owner":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/detiber/openshift-ansible","description":"OpenShift Online's Ansible Code","fork":true,"url":"https://api.github.com/repos/detiber/openshift-ansible","forks_url":"https://api.github.com/repos/detiber/openshift-ansible/forks","keys_url":"https://api.github.com/repos/detiber/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/detiber/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/detiber/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/detiber/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/detiber/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/detiber/openshift-ansible/events","assignees_url":"https://api.github.com/repos/detiber/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/detiber/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/detiber/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/detiber/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/detiber/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/detiber/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/detiber/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/detiber/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/detiber/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/detiber/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/detiber/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/detiber/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/detiber/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/detiber/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/detiber/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/detiber/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/detiber/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/detiber/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/detiber/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/detiber/openshift-ansible/merges","archive_url":"https://api.github.com/repos/detiber/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/detiber/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/detiber/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/detiber/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/detiber/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/detiber/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/detiber/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/detiber/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/detiber/openshift-ansible/deployments","created_at":"2015-01-12T15:09:30Z","updated_at":"2016-11-22T19:02:24Z","pushed_at":"2017-02-21T06:09:27Z","git_url":"git://github.com/detiber/openshift-ansible.git","ssh_url":"[email protected]:detiber/openshift-ansible.git","clone_url":"https://github.com/detiber/openshift-ansible.git","svn_url":"https://github.com/detiber/openshift-ansible","homepage":"","size":9516,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c9563d87c6de11503c5e8fe29a794b8c2846afcc","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2017-02-21T03:04:08Z","pushed_at":"2017-02-21T16:18:00Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"[email protected]:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":9568,"stargazers_count":344,"watchers_count":344,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":558,"mirror_url":null,"open_issues_count":312,"forks":558,"open_issues":312,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3416"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/3416"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/3416"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/3416/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3416/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3416/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/b96ff044de99e1dd85c70cd10329134e6613ed38"}}}} | {
"id": 24109199,
"name": "openshift/openshift-ansible",
"url": "https://api.github.com/repos/openshift/openshift-ansible"
} | {
"id": 88819,
"login": "rhcarvalho",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/88819?",
"url": "https://api.github.com/users/rhcarvalho"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-02-21T16:30:44 | 5363520829 | {"actor":{"display_login":"rhcarvalho"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/comments/157245434","pull_request_review_id":83861817,"id":157245434,"diff_hunk":"@@ -0,0 +1,69 @@\n+#!/bin/bash\n+\n+#https://updates.jenkins-ci.org/download/war/2.73.1/jenkins.war\n+\n+JENKINS_DIST_GIT=jenkins\n+\n+usage() {\n+ echo >&2\n+ echo \"Usage `basename $0` <jenkins-war-version> <branch>\" >&2\n+ echo >&2\n+ echo \" Example: ./bump-jenkins.sh 2.73.1 rhaos-3.7-rhel-7\" >&2\n+ exit 1\n+}\n+\n+# clone jenkins distgit\n+# switch to latest branch \n+setup_dist_git() {\n+ container=\"jenkins\"\n+ workingdir=$(dirname $(realpath $0))/working\n+\n+ if ! klist &>${workingdir}/logs/${container}.output ; then\n+ echo \"Error: Kerberos token not found.\" ; popd &>${workingdir}/logs/${container}.output ; exit 1\n+ fi\n+\n+ cd ${workingdir}\n+ rhpkg ${USER_USERNAME} clone \"${container}\" &>${workingdir}/logs/${container}.output\n+ if [ -d ${container} ] ; then\n+ pushd ${container} >${workingdir}/logs/${container}.output\n+ rhpkg switch-branch \"${BRANCH}\" &>${workingdir}/logs/${container}.output\n+ popd >${workingdir}/logs/${container}.output\n+ else\n+ echo \" Failed to clone container: ${container}\"\n+ fi\n+}\n+\n+# download jenkins war\n+prep_jenkins_war() {\n+ wget https://updates.jenkins-ci.org/download/war/${VERSION}/jenkins.war\n+ mv jenkins.war jenkins.${VERSION}.war\n+}\n+\n+# update changelog\n+update_dist_git () {\n+ rhpkg new-sources jenkins.${VERSION}.war\n+ tito tag --offline --use-version=\"${VERSION}\" --changelog=\"Update to ${VERSION}\"\n+}\n+\n+# rhpkg commit\n+# rhpkg push\n+commit_and_push() {\n+ rhpkg commit -p -m \"Update Jenkins war to ${VERSION}\"\n+}\n+\n+# rhpkg build\n+build_jenkins() {\n+ rhpkg build\n+}\n+\n+# Make sure they passed something in for us\n+if [ \"$#\" -lt 2 ] ; then\n+ usage\n+fi","path":"hacks/bump-jenkins-version/bump-jenkins.sh","position":62,"original_position":62,"commit_id":"761d201af44c388c1d1609fdc52294d5e2daea65","original_commit_id":"761d201af44c388c1d1609fdc52294d5e2daea65","user":{"login":"smunilla","id":873968,"avatar_url":"https://avatars2.githubusercontent.com/u/873968?v=4","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"body":"✔️ ","created_at":"2017-12-15T16:41:42Z","updated_at":"2017-12-15T16:41:42Z","html_url":"https://github.com/openshift/aos-cd-jobs/pull/941#discussion_r157245434","pull_request_url":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/941","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/comments/157245434"},"html":{"href":"https://github.com/openshift/aos-cd-jobs/pull/941#discussion_r157245434"},"pull_request":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/941"}},"in_reply_to_id":157238960},"pull_request":{"url":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/941","id":157930817,"html_url":"https://github.com/openshift/aos-cd-jobs/pull/941","diff_url":"https://github.com/openshift/aos-cd-jobs/pull/941.diff","patch_url":"https://github.com/openshift/aos-cd-jobs/pull/941.patch","issue_url":"https://api.github.com/repos/openshift/aos-cd-jobs/issues/941","number":941,"state":"open","locked":false,"title":" Add a job to bump the jenkins rpm version and build it","user":{"login":"smunilla","id":873968,"avatar_url":"https://avatars2.githubusercontent.com/u/873968?v=4","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-12T20:28:18Z","updated_at":"2017-12-15T16:41:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1005088f792c08ef4a71d65741e61cd4838e3a7a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/941/commits","review_comments_url":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/941/comments","review_comment_url":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/aos-cd-jobs/issues/941/comments","statuses_url":"https://api.github.com/repos/openshift/aos-cd-jobs/statuses/761d201af44c388c1d1609fdc52294d5e2daea65","head":{"label":"smunilla:bump-jenkins-version","ref":"bump-jenkins-version","sha":"761d201af44c388c1d1609fdc52294d5e2daea65","user":{"login":"smunilla","id":873968,"avatar_url":"https://avatars2.githubusercontent.com/u/873968?v=4","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"repo":{"id":80128709,"name":"aos-cd-jobs","full_name":"smunilla/aos-cd-jobs","owner":{"login":"smunilla","id":873968,"avatar_url":"https://avatars2.githubusercontent.com/u/873968?v=4","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smunilla/aos-cd-jobs","description":null,"fork":true,"url":"https://api.github.com/repos/smunilla/aos-cd-jobs","forks_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/forks","keys_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/teams","hooks_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/hooks","issue_events_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/issues/events{/number}","events_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/events","assignees_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/assignees{/user}","branches_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/branches{/branch}","tags_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/tags","blobs_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/statuses/{sha}","languages_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/languages","stargazers_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/stargazers","contributors_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/contributors","subscribers_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/subscribers","subscription_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/subscription","commits_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/contents/{+path}","compare_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/merges","archive_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/downloads","issues_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/issues{/number}","pulls_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/pulls{/number}","milestones_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/milestones{/number}","notifications_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/labels{/name}","releases_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/releases{/id}","deployments_url":"https://api.github.com/repos/smunilla/aos-cd-jobs/deployments","created_at":"2017-01-26T15:49:39Z","updated_at":"2017-06-12T18:10:31Z","pushed_at":"2017-12-15T15:45:54Z","git_url":"git://github.com/smunilla/aos-cd-jobs.git","ssh_url":"[email protected]:smunilla/aos-cd-jobs.git","clone_url":"https://github.com/smunilla/aos-cd-jobs.git","svn_url":"https://github.com/smunilla/aos-cd-jobs","homepage":null,"size":6229,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"378c518cc16f90aebec930d91b3fdf690a6a8c1e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":78675769,"name":"aos-cd-jobs","full_name":"openshift/aos-cd-jobs","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/aos-cd-jobs","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/aos-cd-jobs","forks_url":"https://api.github.com/repos/openshift/aos-cd-jobs/forks","keys_url":"https://api.github.com/repos/openshift/aos-cd-jobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/aos-cd-jobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/aos-cd-jobs/teams","hooks_url":"https://api.github.com/repos/openshift/aos-cd-jobs/hooks","issue_events_url":"https://api.github.com/repos/openshift/aos-cd-jobs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/aos-cd-jobs/events","assignees_url":"https://api.github.com/repos/openshift/aos-cd-jobs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/aos-cd-jobs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/aos-cd-jobs/tags","blobs_url":"https://api.github.com/repos/openshift/aos-cd-jobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/aos-cd-jobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/aos-cd-jobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/aos-cd-jobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/aos-cd-jobs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/aos-cd-jobs/languages","stargazers_url":"https://api.github.com/repos/openshift/aos-cd-jobs/stargazers","contributors_url":"https://api.github.com/repos/openshift/aos-cd-jobs/contributors","subscribers_url":"https://api.github.com/repos/openshift/aos-cd-jobs/subscribers","subscription_url":"https://api.github.com/repos/openshift/aos-cd-jobs/subscription","commits_url":"https://api.github.com/repos/openshift/aos-cd-jobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/aos-cd-jobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/aos-cd-jobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/aos-cd-jobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/aos-cd-jobs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/aos-cd-jobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/aos-cd-jobs/merges","archive_url":"https://api.github.com/repos/openshift/aos-cd-jobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/aos-cd-jobs/downloads","issues_url":"https://api.github.com/repos/openshift/aos-cd-jobs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/aos-cd-jobs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/aos-cd-jobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/aos-cd-jobs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/aos-cd-jobs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/aos-cd-jobs/deployments","created_at":"2017-01-11T20:14:22Z","updated_at":"2017-12-04T22:02:34Z","pushed_at":"2017-12-15T15:50:33Z","git_url":"git://github.com/openshift/aos-cd-jobs.git","ssh_url":"[email protected]:openshift/aos-cd-jobs.git","clone_url":"https://github.com/openshift/aos-cd-jobs.git","svn_url":"https://github.com/openshift/aos-cd-jobs","homepage":null,"size":8157,"stargazers_count":10,"watchers_count":10,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":62,"open_issues":40,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/941"},"html":{"href":"https://github.com/openshift/aos-cd-jobs/pull/941"},"issue":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/issues/941"},"comments":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/aos-cd-jobs/statuses/761d201af44c388c1d1609fdc52294d5e2daea65"}},"author_association":"CONTRIBUTOR"}} | {
"id": 78675769,
"name": "openshift/aos-cd-jobs",
"url": "https://api.github.com/repos/openshift/aos-cd-jobs"
} | {
"id": 873968,
"login": "smunilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/873968?",
"url": "https://api.github.com/users/smunilla"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-12-15T16:41:42 | 6994812423 | {"actor":{"display_login":"smunilla"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/157272905","pull_request_review_id":83894248,"id":157272905,"diff_hunk":"@@ -0,0 +1,60 @@\n+package glide\n+\n+import (\n+\t\"bytes\"\n+\t\"fmt\"\n+\t\"time\"\n+\n+\tyaml \"gopkg.in/yaml.v2\"\n+)\n+\n+type LockFile struct {\n+\tHash string `yaml:\"hash\"`\n+\tUpdated time.Time `yaml:\"updated\"`\n+\n+\tImports []*LockFileImport `yaml:\"imports\"`\n+}\n+\n+func (l *LockFile) Decode(b []byte) error {\n+\treturn yaml.Unmarshal(b, l)\n+}\n+\n+type YamlFile struct {\n+\traw []byte","path":"tools/glide-pindeps/glide/glide.go","position":23,"original_position":23,"commit_id":"3ee9bb2e9d974546c78def6e0802a1bd4209d763","original_commit_id":"3ee9bb2e9d974546c78def6e0802a1bd4209d763","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"This doesn't look like `raw`. This looks like `DecodedBytes`","created_at":"2017-12-15T18:51:36Z","updated_at":"2017-12-15T18:51:36Z","html_url":"https://github.com/openshift/origin/pull/17806#discussion_r157272905","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/17806","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/157272905"},"html":{"href":"https://github.com/openshift/origin/pull/17806#discussion_r157272905"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/17806"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/17806","id":158422661,"html_url":"https://github.com/openshift/origin/pull/17806","diff_url":"https://github.com/openshift/origin/pull/17806.diff","patch_url":"https://github.com/openshift/origin/pull/17806.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/17806","number":17806,"state":"open","locked":false,"title":"add glide tool for pinning deps from a lock file","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"body":"cc @deads2k ","created_at":"2017-12-14T17:50:53Z","updated_at":"2017-12-15T18:51:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a261c9892281fe555043ec761de58df39ebbeb8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/17806/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/17806/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/17806/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/3ee9bb2e9d974546c78def6e0802a1bd4209d763","head":{"label":"juanvallejo:jvallejo/add-script-for-glide-deps","ref":"jvallejo/add-script-for-glide-deps","sha":"3ee9bb2e9d974546c78def6e0802a1bd4209d763","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"repo":{"id":50698131,"name":"origin","full_name":"juanvallejo/origin","owner":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanvallejo/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/juanvallejo/origin","forks_url":"https://api.github.com/repos/juanvallejo/origin/forks","keys_url":"https://api.github.com/repos/juanvallejo/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanvallejo/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanvallejo/origin/teams","hooks_url":"https://api.github.com/repos/juanvallejo/origin/hooks","issue_events_url":"https://api.github.com/repos/juanvallejo/origin/issues/events{/number}","events_url":"https://api.github.com/repos/juanvallejo/origin/events","assignees_url":"https://api.github.com/repos/juanvallejo/origin/assignees{/user}","branches_url":"https://api.github.com/repos/juanvallejo/origin/branches{/branch}","tags_url":"https://api.github.com/repos/juanvallejo/origin/tags","blobs_url":"https://api.github.com/repos/juanvallejo/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanvallejo/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanvallejo/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanvallejo/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanvallejo/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/juanvallejo/origin/languages","stargazers_url":"https://api.github.com/repos/juanvallejo/origin/stargazers","contributors_url":"https://api.github.com/repos/juanvallejo/origin/contributors","subscribers_url":"https://api.github.com/repos/juanvallejo/origin/subscribers","subscription_url":"https://api.github.com/repos/juanvallejo/origin/subscription","commits_url":"https://api.github.com/repos/juanvallejo/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanvallejo/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanvallejo/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanvallejo/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanvallejo/origin/contents/{+path}","compare_url":"https://api.github.com/repos/juanvallejo/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanvallejo/origin/merges","archive_url":"https://api.github.com/repos/juanvallejo/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanvallejo/origin/downloads","issues_url":"https://api.github.com/repos/juanvallejo/origin/issues{/number}","pulls_url":"https://api.github.com/repos/juanvallejo/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/juanvallejo/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/juanvallejo/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanvallejo/origin/labels{/name}","releases_url":"https://api.github.com/repos/juanvallejo/origin/releases{/id}","deployments_url":"https://api.github.com/repos/juanvallejo/origin/deployments","created_at":"2016-01-29T23:22:53Z","updated_at":"2016-01-29T23:22:58Z","pushed_at":"2017-12-15T18:34:07Z","git_url":"git://github.com/juanvallejo/origin.git","ssh_url":"[email protected]:juanvallejo/origin.git","clone_url":"https://github.com/juanvallejo/origin.git","svn_url":"https://github.com/juanvallejo/origin","homepage":"http://www.openshift.org","size":892940,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"0c37d868246c7399ff38d6141767abceb10a32ba","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2017-12-15T18:10:51Z","pushed_at":"2017-12-15T18:43:33Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"[email protected]:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":937440,"stargazers_count":3776,"watchers_count":3776,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2435,"mirror_url":null,"archived":false,"open_issues_count":1682,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2435,"open_issues":1682,"watchers":3776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/17806"},"html":{"href":"https://github.com/openshift/origin/pull/17806"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/17806"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/17806/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/17806/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/17806/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/3ee9bb2e9d974546c78def6e0802a1bd4209d763"}},"author_association":"MEMBER"}} | {
"id": 22442668,
"name": "openshift/origin",
"url": "https://api.github.com/repos/openshift/origin"
} | {
"id": 8225098,
"login": "deads2k",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8225098?",
"url": "https://api.github.com/users/deads2k"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-12-15T18:51:36 | 6995336401 | {"actor":{"display_login":"deads2k"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/100164325","pull_request_review_id":20862654,"id":100164325,"diff_hunk":"@@ -10,6 +10,9 @@\n remote_user: root","path":"playbooks/adhoc/s3_registry/s3_registry.yml","position":1,"original_position":1,"commit_id":"d3daebceddf27c67384c7af5dc9255a92b843fbe","original_commit_id":"d3daebceddf27c67384c7af5dc9255a92b843fbe","user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"body":"@sdodson do you agree as well? If so I'll be happy to ``git rm`` this file instead of porting it.","created_at":"2017-02-08T20:39:23Z","updated_at":"2017-02-08T20:39:24Z","html_url":"https://github.com/openshift/openshift-ansible/pull/3295#discussion_r100164325","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3295","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/100164325"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/3295#discussion_r100164325"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3295"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3295","id":105283492,"html_url":"https://github.com/openshift/openshift-ansible/pull/3295","diff_url":"https://github.com/openshift/openshift-ansible/pull/3295.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/3295.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/3295","number":3295,"state":"open","locked":false,"title":"WIP: oc scale now done via oc_scale module","user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-08T19:09:42Z","updated_at":"2017-02-08T20:39:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5116d74999ae954dfc44dd54ca00ff63ad5fce44","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3295/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3295/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/3295/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/d3daebceddf27c67384c7af5dc9255a92b843fbe","head":{"label":"ashcrow:oc-scale-module","ref":"oc-scale-module","sha":"d3daebceddf27c67384c7af5dc9255a92b843fbe","user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"repo":{"id":53355614,"name":"openshift-ansible","full_name":"ashcrow/openshift-ansible","owner":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashcrow/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/ashcrow/openshift-ansible","forks_url":"https://api.github.com/repos/ashcrow/openshift-ansible/forks","keys_url":"https://api.github.com/repos/ashcrow/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashcrow/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashcrow/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/ashcrow/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/ashcrow/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ashcrow/openshift-ansible/events","assignees_url":"https://api.github.com/repos/ashcrow/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ashcrow/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ashcrow/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/ashcrow/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashcrow/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashcrow/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashcrow/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashcrow/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ashcrow/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/ashcrow/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/ashcrow/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/ashcrow/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/ashcrow/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/ashcrow/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashcrow/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashcrow/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashcrow/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashcrow/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ashcrow/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashcrow/openshift-ansible/merges","archive_url":"https://api.github.com/repos/ashcrow/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashcrow/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/ashcrow/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ashcrow/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ashcrow/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ashcrow/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashcrow/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ashcrow/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ashcrow/openshift-ansible/deployments","created_at":"2016-03-07T20:12:04Z","updated_at":"2016-03-07T20:12:09Z","pushed_at":"2017-02-08T20:37:38Z","git_url":"git://github.com/ashcrow/openshift-ansible.git","ssh_url":"[email protected]:ashcrow/openshift-ansible.git","clone_url":"https://github.com/ashcrow/openshift-ansible.git","svn_url":"https://github.com/ashcrow/openshift-ansible","homepage":"install.openshift.com","size":8292,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5c6dc36dda1e2ef87f4e43c77e682d829a6bbd3c","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2017-02-08T15:15:10Z","pushed_at":"2017-02-08T20:37:39Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"[email protected]:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":9206,"stargazers_count":331,"watchers_count":331,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":536,"mirror_url":null,"open_issues_count":282,"forks":536,"open_issues":282,"watchers":331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3295"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/3295"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/3295"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/3295/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3295/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3295/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/d3daebceddf27c67384c7af5dc9255a92b843fbe"}}}} | {
"id": 24109199,
"name": "openshift/openshift-ansible",
"url": "https://api.github.com/repos/openshift/openshift-ansible"
} | {
"id": 22706,
"login": "ashcrow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22706?",
"url": "https://api.github.com/users/ashcrow"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-02-08T20:39:23 | 5290731519 | {"actor":{"display_login":"ashcrow"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/123834101","pull_request_review_id":46078412,"id":123834101,"diff_hunk":"@@ -7,52 +7,31 @@ import (\n \t\"io/ioutil\"\n \t\"net/http\"\n \t\"strings\"\n-\t\"time\"\n \n \t\"github.com/coreos/etcd/client\"\n \t\"github.com/coreos/etcd/version\"\n \tlogging \"github.com/op/go-logging\"\n \t\"github.com/openshift/ansible-service-broker/pkg/apb\"\n+\t\"github.com/openshift/ansible-service-broker/pkg/clients\"\n \t\"github.com/pborman/uuid\"\n )\n \n-// Config - confg holds etcd host and port.\n-type Config struct {\n-\tEtcdHost string `yaml:\"etcd_host\"`\n-\tEtcdPort string `yaml:\"etcd_port\"`\n-}\n-\n-// Dao - retreive, create, and update objects from etcd\n type Dao struct {\n-\tconfig Config\n-\tlog *logging.Logger\n-\tendpoints []string\n-\tclient client.Client\n-\tkapi client.KeysAPI // Used to interact with kvp API over HTTP\n+\tconfig clients.EtcdConfig","path":"pkg/dao/dao.go","position":27,"original_position":27,"commit_id":"fe5a7c1ee999858d4d30bd55bfc1761f7357b26f","original_commit_id":"fe5a7c1ee999858d4d30bd55bfc1761f7357b26f","user":{"login":"jmrodri","id":17137,"avatar_url":"https://avatars1.githubusercontent.com/u/17137?v=3","gravatar_id":"","url":"https://api.github.com/users/jmrodri","html_url":"https://github.com/jmrodri","followers_url":"https://api.github.com/users/jmrodri/followers","following_url":"https://api.github.com/users/jmrodri/following{/other_user}","gists_url":"https://api.github.com/users/jmrodri/gists{/gist_id}","starred_url":"https://api.github.com/users/jmrodri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmrodri/subscriptions","organizations_url":"https://api.github.com/users/jmrodri/orgs","repos_url":"https://api.github.com/users/jmrodri/repos","events_url":"https://api.github.com/users/jmrodri/events{/privacy}","received_events_url":"https://api.github.com/users/jmrodri/received_events","type":"User","site_admin":false},"body":"should be dao.Config","created_at":"2017-06-23T20:06:52Z","updated_at":"2017-06-23T20:07:58Z","html_url":"https://github.com/openshift/ansible-service-broker/pull/222#discussion_r123834101","pull_request_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/222","_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/123834101"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/222#discussion_r123834101"},"pull_request":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/222"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/222","id":127069968,"html_url":"https://github.com/openshift/ansible-service-broker/pull/222","diff_url":"https://github.com/openshift/ansible-service-broker/pull/222.diff","patch_url":"https://github.com/openshift/ansible-service-broker/pull/222.patch","issue_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/222","number":222,"state":"open","locked":false,"title":"Breakup dao client","user":{"login":"rthallisey","id":6795213,"avatar_url":"https://avatars1.githubusercontent.com/u/6795213?v=3","gravatar_id":"","url":"https://api.github.com/users/rthallisey","html_url":"https://github.com/rthallisey","followers_url":"https://api.github.com/users/rthallisey/followers","following_url":"https://api.github.com/users/rthallisey/following{/other_user}","gists_url":"https://api.github.com/users/rthallisey/gists{/gist_id}","starred_url":"https://api.github.com/users/rthallisey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthallisey/subscriptions","organizations_url":"https://api.github.com/users/rthallisey/orgs","repos_url":"https://api.github.com/users/rthallisey/repos","events_url":"https://api.github.com/users/rthallisey/events{/privacy}","received_events_url":"https://api.github.com/users/rthallisey/received_events","type":"User","site_admin":false},"body":"The Etcd Client is a little trickier because it requires a config file. Later when we unify all the clients we will use individual functions just like etcd.\r\n\r\nPartially-fixes: #213 \r\nDepends-on: #215 ","created_at":"2017-06-22T19:32:09Z","updated_at":"2017-06-23T20:07:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84dbf44055782a93c5a2afb6ed57ea7d70daafb0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/222/commits","review_comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/222/comments","review_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/222/comments","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/fe5a7c1ee999858d4d30bd55bfc1761f7357b26f","head":{"label":"rthallisey:breakup-dao-client","ref":"breakup-dao-client","sha":"fe5a7c1ee999858d4d30bd55bfc1761f7357b26f","user":{"login":"rthallisey","id":6795213,"avatar_url":"https://avatars1.githubusercontent.com/u/6795213?v=3","gravatar_id":"","url":"https://api.github.com/users/rthallisey","html_url":"https://github.com/rthallisey","followers_url":"https://api.github.com/users/rthallisey/followers","following_url":"https://api.github.com/users/rthallisey/following{/other_user}","gists_url":"https://api.github.com/users/rthallisey/gists{/gist_id}","starred_url":"https://api.github.com/users/rthallisey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthallisey/subscriptions","organizations_url":"https://api.github.com/users/rthallisey/orgs","repos_url":"https://api.github.com/users/rthallisey/repos","events_url":"https://api.github.com/users/rthallisey/events{/privacy}","received_events_url":"https://api.github.com/users/rthallisey/received_events","type":"User","site_admin":false},"repo":{"id":85976157,"name":"ansible-service-broker","full_name":"rthallisey/ansible-service-broker","owner":{"login":"rthallisey","id":6795213,"avatar_url":"https://avatars1.githubusercontent.com/u/6795213?v=3","gravatar_id":"","url":"https://api.github.com/users/rthallisey","html_url":"https://github.com/rthallisey","followers_url":"https://api.github.com/users/rthallisey/followers","following_url":"https://api.github.com/users/rthallisey/following{/other_user}","gists_url":"https://api.github.com/users/rthallisey/gists{/gist_id}","starred_url":"https://api.github.com/users/rthallisey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthallisey/subscriptions","organizations_url":"https://api.github.com/users/rthallisey/orgs","repos_url":"https://api.github.com/users/rthallisey/repos","events_url":"https://api.github.com/users/rthallisey/events{/privacy}","received_events_url":"https://api.github.com/users/rthallisey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rthallisey/ansible-service-broker","description":"Ansible Service Broker","fork":true,"url":"https://api.github.com/repos/rthallisey/ansible-service-broker","forks_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/rthallisey/ansible-service-broker/deployments","created_at":"2017-03-23T17:08:28Z","updated_at":"2017-03-23T17:08:30Z","pushed_at":"2017-06-23T12:29:11Z","git_url":"git://github.com/rthallisey/ansible-service-broker.git","ssh_url":"[email protected]:rthallisey/ansible-service-broker.git","clone_url":"https://github.com/rthallisey/ansible-service-broker.git","svn_url":"https://github.com/rthallisey/ansible-service-broker","homepage":null,"size":41123,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a7598671a50d3be41bc4acbf704190ea73460b3d","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":79371528,"name":"ansible-service-broker","full_name":"openshift/ansible-service-broker","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/ansible-service-broker","description":"Ansible Service Broker","fork":false,"url":"https://api.github.com/repos/openshift/ansible-service-broker","forks_url":"https://api.github.com/repos/openshift/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/openshift/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/openshift/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/openshift/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/openshift/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/openshift/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/openshift/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/openshift/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/ansible-service-broker/deployments","created_at":"2017-01-18T18:40:49Z","updated_at":"2017-06-22T00:16:54Z","pushed_at":"2017-06-23T19:59:41Z","git_url":"git://github.com/openshift/ansible-service-broker.git","ssh_url":"[email protected]:openshift/ansible-service-broker.git","clone_url":"https://github.com/openshift/ansible-service-broker.git","svn_url":"https://github.com/openshift/ansible-service-broker","homepage":null,"size":41141,"stargazers_count":26,"watchers_count":26,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":26,"forks":18,"open_issues":26,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/222"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/222"},"issue":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/222"},"comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/fe5a7c1ee999858d4d30bd55bfc1761f7357b26f"}}}} | {
"id": 79371528,
"name": "openshift/ansible-service-broker",
"url": "https://api.github.com/repos/openshift/ansible-service-broker"
} | {
"id": 17137,
"login": "jmrodri",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17137?",
"url": "https://api.github.com/users/jmrodri"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-06-23T20:06:52 | 6128746418 | {"actor":{"display_login":"jmrodri"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/154107618","pull_request_review_id":80220240,"id":154107618,"diff_hunk":"@@ -162,6 +165,7 @@ func NewCmdPruneImages(f *clientcmd.Factory, parentName, name string, out io.Wri\n \tcmd.Flags().StringVar(&opts.CABundle, \"certificate-authority\", opts.CABundle, \"The path to a certificate authority bundle to use when communicating with the managed Docker registries. Defaults to the certificate authority data from the current user's config file. It cannot be used together with --force-insecure.\")\n \tcmd.Flags().StringVar(&opts.RegistryUrlOverride, \"registry-url\", opts.RegistryUrlOverride, \"The address to use when contacting the registry, instead of using the default value. This is useful if you can't resolve or reach the registry (e.g.; the default is a cluster-internal URL) but you do have an alternative route that works. Particular transport protocol can be enforced using '<scheme>://' prefix.\")\n \tcmd.Flags().BoolVar(&opts.ForceInsecure, \"force-insecure\", opts.ForceInsecure, \"If true, allow an insecure connection to the docker registry that is hosted via HTTP or has an invalid HTTPS certificate. Whenever possible, use --certificate-authority instead of this dangerous option.\")\n+\tcmd.Flags().BoolVar(opts.SkipRegistry, \"skip-registry\", *opts.SkipRegistry, \"If true, the prune operation will clean up image API objects, but the none of the associated content in the registry is removed.\")","path":"pkg/oc/admin/prune/images.go","position":28,"original_position":28,"commit_id":"3e0e580ad96d354b069720f6b7ee0045e773f060","original_commit_id":"3e0e580ad96d354b069720f6b7ee0045e773f060","user":{"login":"miminar","id":1478803,"avatar_url":"https://avatars2.githubusercontent.com/u/1478803?v=4","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"body":"My ingliš is not perfect, so I may be easily wrong, but the **the** between *but* and *none* seems superfluous to me.","created_at":"2017-11-30T15:27:08Z","updated_at":"2017-11-30T15:36:02Z","html_url":"https://github.com/openshift/origin/pull/17480#discussion_r154107618","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/17480","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/154107618"},"html":{"href":"https://github.com/openshift/origin/pull/17480#discussion_r154107618"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/17480"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/17480","id":154888293,"html_url":"https://github.com/openshift/origin/pull/17480","diff_url":"https://github.com/openshift/origin/pull/17480.diff","patch_url":"https://github.com/openshift/origin/pull/17480.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/17480","number":17480,"state":"open","locked":false,"title":"add image soft prune (api object yes, registry no)","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"https://trello.com/c/V1anqimn/1418-5-image-soft-prune-imagestreams\r\n\r\n@openshift/sig-developer-experience ptal","created_at":"2017-11-27T18:53:06Z","updated_at":"2017-11-30T15:36:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4407f2e0b7f6f32b8c83f748929c2dc0d881fb07","assignee":{"login":"miminar","id":1478803,"avatar_url":"https://avatars2.githubusercontent.com/u/1478803?v=4","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"assignees":[{"login":"miminar","id":1478803,"avatar_url":"https://avatars2.githubusercontent.com/u/1478803?v=4","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/17480/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/17480/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/17480/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/3e0e580ad96d354b069720f6b7ee0045e773f060","head":{"label":"gabemontero:prune-img-api-obj-only","ref":"prune-img-api-obj-only","sha":"3e0e580ad96d354b069720f6b7ee0045e773f060","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":36941154,"name":"origin","full_name":"gabemontero/origin","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/gabemontero/origin","forks_url":"https://api.github.com/repos/gabemontero/origin/forks","keys_url":"https://api.github.com/repos/gabemontero/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/origin/teams","hooks_url":"https://api.github.com/repos/gabemontero/origin/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/origin/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/origin/events","assignees_url":"https://api.github.com/repos/gabemontero/origin/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/origin/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/origin/tags","blobs_url":"https://api.github.com/repos/gabemontero/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/origin/languages","stargazers_url":"https://api.github.com/repos/gabemontero/origin/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/origin/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/origin/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/origin/subscription","commits_url":"https://api.github.com/repos/gabemontero/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/origin/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/origin/merges","archive_url":"https://api.github.com/repos/gabemontero/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/origin/downloads","issues_url":"https://api.github.com/repos/gabemontero/origin/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/origin/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/origin/releases{/id}","deployments_url":"https://api.github.com/repos/gabemontero/origin/deployments","created_at":"2015-06-05T15:48:08Z","updated_at":"2017-03-13T17:37:13Z","pushed_at":"2017-11-29T19:49:16Z","git_url":"git://github.com/gabemontero/origin.git","ssh_url":"[email protected]:gabemontero/origin.git","clone_url":"https://github.com/gabemontero/origin.git","svn_url":"https://github.com/gabemontero/origin","homepage":"http://www.openshift.org","size":945954,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"2463543ac975224daf67c64d50a3d6f76fdc9c21","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2017-11-30T13:10:59Z","pushed_at":"2017-11-30T15:33:40Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"[email protected]:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":923993,"stargazers_count":3707,"watchers_count":3707,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2395,"mirror_url":null,"archived":false,"open_issues_count":1567,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2395,"open_issues":1567,"watchers":3707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/17480"},"html":{"href":"https://github.com/openshift/origin/pull/17480"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/17480"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/17480/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/17480/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/17480/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/3e0e580ad96d354b069720f6b7ee0045e773f060"}},"author_association":"CONTRIBUTOR"}} | {
"id": 22442668,
"name": "openshift/origin",
"url": "https://api.github.com/repos/openshift/origin"
} | {
"id": 1478803,
"login": "miminar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1478803?",
"url": "https://api.github.com/users/miminar"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-11-30T15:27:08 | 6925318064 | {"actor":{"display_login":"miminar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/101953544","pull_request_review_id":22694084,"id":101953544,"diff_hunk":"@@ -29,4 +31,9 @@ responsibile for:\n \n Each *flanneld* agent provides this infomation to a centralized *etcd* store so\n other agents on hosts can create an overlay network and route packets to\n-any container within the *flannel* network.\n\\ No newline at end of file\n+any container within the *flannel* network.\n+\n+The following diagram illustrates the architecture and data flow from one\n+container to another using a *flannel* network:\n+\n+image::flannel.png[Flannel Communication]","path":"architecture/additional_concepts/flannel.adoc","position":22,"original_position":22,"commit_id":"3fd973883ac5848200f28377efece18c1decf287","original_commit_id":"45557b58806da40422d6e9d413ce554d2108c3f9","user":{"login":"danmacpherson","id":1260665,"avatar_url":"https://avatars.githubusercontent.com/u/1260665?v=3","gravatar_id":"","url":"https://api.github.com/users/danmacpherson","html_url":"https://github.com/danmacpherson","followers_url":"https://api.github.com/users/danmacpherson/followers","following_url":"https://api.github.com/users/danmacpherson/following{/other_user}","gists_url":"https://api.github.com/users/danmacpherson/gists{/gist_id}","starred_url":"https://api.github.com/users/danmacpherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmacpherson/subscriptions","organizations_url":"https://api.github.com/users/danmacpherson/orgs","repos_url":"https://api.github.com/users/danmacpherson/repos","events_url":"https://api.github.com/users/danmacpherson/events{/privacy}","received_events_url":"https://api.github.com/users/danmacpherson/received_events","type":"User","site_admin":false},"body":"@sferich888 Any chance you could take a look at the diagram?\r\n\r\nAlso @danwinship I checked my OCP w/flannel lab I'm using to test. When I run an `ip addr`, I can confirm it lists docker0 and veth devices. Not sure about flannel0, but judging by the IP, it seems more like a descriptor for the network range rather than a device. Having said that, I'm okay with removing it.","created_at":"2017-02-20T06:20:35Z","updated_at":"2017-02-20T06:20:36Z","html_url":"https://github.com/openshift/openshift-docs/pull/3743#discussion_r101953544","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/3743","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/101953544"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/3743#discussion_r101953544"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/3743"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/3743","id":106028892,"html_url":"https://github.com/openshift/openshift-docs/pull/3743","diff_url":"https://github.com/openshift/openshift-docs/pull/3743.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/3743.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/3743","number":3743,"state":"open","locked":false,"title":"Adding flannel arch diagram","user":{"login":"danmacpherson","id":1260665,"avatar_url":"https://avatars.githubusercontent.com/u/1260665?v=3","gravatar_id":"","url":"https://api.github.com/users/danmacpherson","html_url":"https://github.com/danmacpherson","followers_url":"https://api.github.com/users/danmacpherson/followers","following_url":"https://api.github.com/users/danmacpherson/following{/other_user}","gists_url":"https://api.github.com/users/danmacpherson/gists{/gist_id}","starred_url":"https://api.github.com/users/danmacpherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmacpherson/subscriptions","organizations_url":"https://api.github.com/users/danmacpherson/orgs","repos_url":"https://api.github.com/users/danmacpherson/repos","events_url":"https://api.github.com/users/danmacpherson/events{/privacy}","received_events_url":"https://api.github.com/users/danmacpherson/received_events","type":"User","site_admin":false},"body":"Also adding variable for flannel nic config\r\n","created_at":"2017-02-14T03:35:40Z","updated_at":"2017-02-20T06:20:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f85299a02003331cff0d1f4f189331c79d8f5be0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/3743/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/3743/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/3743/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/3fd973883ac5848200f28377efece18c1decf287","head":{"label":"danmacpherson:flannel-documentation-2","ref":"flannel-documentation-2","sha":"3fd973883ac5848200f28377efece18c1decf287","user":{"login":"danmacpherson","id":1260665,"avatar_url":"https://avatars.githubusercontent.com/u/1260665?v=3","gravatar_id":"","url":"https://api.github.com/users/danmacpherson","html_url":"https://github.com/danmacpherson","followers_url":"https://api.github.com/users/danmacpherson/followers","following_url":"https://api.github.com/users/danmacpherson/following{/other_user}","gists_url":"https://api.github.com/users/danmacpherson/gists{/gist_id}","starred_url":"https://api.github.com/users/danmacpherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmacpherson/subscriptions","organizations_url":"https://api.github.com/users/danmacpherson/orgs","repos_url":"https://api.github.com/users/danmacpherson/repos","events_url":"https://api.github.com/users/danmacpherson/events{/privacy}","received_events_url":"https://api.github.com/users/danmacpherson/received_events","type":"User","site_admin":false},"repo":{"id":73685202,"name":"openshift-docs","full_name":"danmacpherson/openshift-docs","owner":{"login":"danmacpherson","id":1260665,"avatar_url":"https://avatars.githubusercontent.com/u/1260665?v=3","gravatar_id":"","url":"https://api.github.com/users/danmacpherson","html_url":"https://github.com/danmacpherson","followers_url":"https://api.github.com/users/danmacpherson/followers","following_url":"https://api.github.com/users/danmacpherson/following{/other_user}","gists_url":"https://api.github.com/users/danmacpherson/gists{/gist_id}","starred_url":"https://api.github.com/users/danmacpherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmacpherson/subscriptions","organizations_url":"https://api.github.com/users/danmacpherson/orgs","repos_url":"https://api.github.com/users/danmacpherson/repos","events_url":"https://api.github.com/users/danmacpherson/events{/privacy}","received_events_url":"https://api.github.com/users/danmacpherson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danmacpherson/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/danmacpherson/openshift-docs","forks_url":"https://api.github.com/repos/danmacpherson/openshift-docs/forks","keys_url":"https://api.github.com/repos/danmacpherson/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danmacpherson/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danmacpherson/openshift-docs/teams","hooks_url":"https://api.github.com/repos/danmacpherson/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/danmacpherson/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/danmacpherson/openshift-docs/events","assignees_url":"https://api.github.com/repos/danmacpherson/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/danmacpherson/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/danmacpherson/openshift-docs/tags","blobs_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danmacpherson/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/danmacpherson/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/danmacpherson/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/danmacpherson/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/danmacpherson/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/danmacpherson/openshift-docs/subscription","commits_url":"https://api.github.com/repos/danmacpherson/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/danmacpherson/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/danmacpherson/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/danmacpherson/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/danmacpherson/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danmacpherson/openshift-docs/merges","archive_url":"https://api.github.com/repos/danmacpherson/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danmacpherson/openshift-docs/downloads","issues_url":"https://api.github.com/repos/danmacpherson/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/danmacpherson/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/danmacpherson/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/danmacpherson/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danmacpherson/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/danmacpherson/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/danmacpherson/openshift-docs/deployments","created_at":"2016-11-14T08:50:46Z","updated_at":"2016-11-14T08:50:48Z","pushed_at":"2017-02-17T01:11:03Z","git_url":"git://github.com/danmacpherson/openshift-docs.git","ssh_url":"[email protected]:danmacpherson/openshift-docs.git","clone_url":"https://github.com/danmacpherson/openshift-docs.git","svn_url":"https://github.com/danmacpherson/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":31941,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"934d0c206cf6ad4dabac079d8d98dff66ce2018f","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"name":"openshift-docs","full_name":"openshift/openshift-docs","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2017-02-09T02:18:38Z","pushed_at":"2017-02-20T05:43:03Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"[email protected]:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":33343,"stargazers_count":71,"watchers_count":71,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":316,"mirror_url":null,"open_issues_count":237,"forks":316,"open_issues":237,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/3743"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/3743"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/3743"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/3743/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/3743/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/3743/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/3fd973883ac5848200f28377efece18c1decf287"}}}} | {
"id": 21740844,
"name": "openshift/openshift-docs",
"url": "https://api.github.com/repos/openshift/openshift-docs"
} | {
"id": 1260665,
"login": "danmacpherson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1260665?",
"url": "https://api.github.com/users/danmacpherson"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-02-20T06:20:35 | 5353539709 | {"actor":{"display_login":"danmacpherson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/95729299","pull_request_review_id":16293118,"id":95729299,"diff_hunk":"@@ -316,6 +316,11 @@ host; for example, given the default 10.128.0.0/14 cluster network, this will\n allocate 10.128.0.0/23, 10.128.2.0/23, 10.128.4.0/23, and so on. This *cannot* be\n re-configured after deployment.\n \n+|`*openshift_use_flannel*`\n+|This varaible enables *flannel* as an alternative networking layer instead of","path":"install_config/install/advanced_install.adoc","position":5,"original_position":5,"commit_id":"c827c870e3b29413c40a5370abc352d023116dff","original_commit_id":"c827c870e3b29413c40a5370abc352d023116dff","user":{"login":"bfallonf","id":5474938,"avatar_url":"https://avatars.githubusercontent.com/u/5474938?v=3","gravatar_id":"","url":"https://api.github.com/users/bfallonf","html_url":"https://github.com/bfallonf","followers_url":"https://api.github.com/users/bfallonf/followers","following_url":"https://api.github.com/users/bfallonf/following{/other_user}","gists_url":"https://api.github.com/users/bfallonf/gists{/gist_id}","starred_url":"https://api.github.com/users/bfallonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfallonf/subscriptions","organizations_url":"https://api.github.com/users/bfallonf/orgs","repos_url":"https://api.github.com/users/bfallonf/repos","events_url":"https://api.github.com/users/bfallonf/events{/privacy}","received_events_url":"https://api.github.com/users/bfallonf/received_events","type":"User","site_admin":false},"body":"s/varaible/variable","created_at":"2017-01-12T05:51:54Z","updated_at":"2017-01-12T05:51:54Z","html_url":"https://github.com/openshift/openshift-docs/pull/3477#discussion_r95729299","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/3477","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/95729299"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/3477#discussion_r95729299"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/3477"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/3477","id":101090400,"html_url":"https://github.com/openshift/openshift-docs/pull/3477","diff_url":"https://github.com/openshift/openshift-docs/pull/3477.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/3477.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/3477","number":3477,"state":"open","locked":false,"title":"Adding Flannel documentation","user":{"login":"danmacpherson","id":1260665,"avatar_url":"https://avatars.githubusercontent.com/u/1260665?v=3","gravatar_id":"","url":"https://api.github.com/users/danmacpherson","html_url":"https://github.com/danmacpherson","followers_url":"https://api.github.com/users/danmacpherson/followers","following_url":"https://api.github.com/users/danmacpherson/following{/other_user}","gists_url":"https://api.github.com/users/danmacpherson/gists{/gist_id}","starred_url":"https://api.github.com/users/danmacpherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmacpherson/subscriptions","organizations_url":"https://api.github.com/users/danmacpherson/orgs","repos_url":"https://api.github.com/users/danmacpherson/repos","events_url":"https://api.github.com/users/danmacpherson/events{/privacy}","received_events_url":"https://api.github.com/users/danmacpherson/received_events","type":"User","site_admin":false},"body":"This is some initial documentation for flannel within OpenShift. This includes:\r\n\r\n- Adding the openshift_use_flannel variable to the cluster variables table in the Advanced Installation section\r\n- Adding some more detailed info in the SDN section of the Installation and Configuration guide\r\n- Adding a new section in the Arch Guide about flannel","created_at":"2017-01-11T15:41:45Z","updated_at":"2017-01-12T05:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e001d0cce34b43e8eef89a4eef0f85a14a6b5af","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openshift/openshift-docs/milestones/6","html_url":"https://github.com/openshift/openshift-docs/milestone/6","labels_url":"https://api.github.com/repos/openshift/openshift-docs/milestones/6/labels","id":1435997,"number":6,"title":"Future Release","description":"Tracker for content relevant to latest Origin code, but still targeting a future release of Enterprise, Dedicated, and/or Online.","creator":{"login":"adellape","id":3442316,"avatar_url":"https://avatars.githubusercontent.com/u/3442316?v=3","gravatar_id":"","url":"https://api.github.com/users/adellape","html_url":"https://github.com/adellape","followers_url":"https://api.github.com/users/adellape/followers","following_url":"https://api.github.com/users/adellape/following{/other_user}","gists_url":"https://api.github.com/users/adellape/gists{/gist_id}","starred_url":"https://api.github.com/users/adellape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adellape/subscriptions","organizations_url":"https://api.github.com/users/adellape/orgs","repos_url":"https://api.github.com/users/adellape/repos","events_url":"https://api.github.com/users/adellape/events{/privacy}","received_events_url":"https://api.github.com/users/adellape/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":110,"state":"open","created_at":"2015-11-30T20:14:06Z","updated_at":"2017-01-12T02:21:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/3477/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/3477/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/3477/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/c827c870e3b29413c40a5370abc352d023116dff","head":{"label":"danmacpherson:flannel-documentation","ref":"flannel-documentation","sha":"c827c870e3b29413c40a5370abc352d023116dff","user":{"login":"danmacpherson","id":1260665,"avatar_url":"https://avatars.githubusercontent.com/u/1260665?v=3","gravatar_id":"","url":"https://api.github.com/users/danmacpherson","html_url":"https://github.com/danmacpherson","followers_url":"https://api.github.com/users/danmacpherson/followers","following_url":"https://api.github.com/users/danmacpherson/following{/other_user}","gists_url":"https://api.github.com/users/danmacpherson/gists{/gist_id}","starred_url":"https://api.github.com/users/danmacpherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmacpherson/subscriptions","organizations_url":"https://api.github.com/users/danmacpherson/orgs","repos_url":"https://api.github.com/users/danmacpherson/repos","events_url":"https://api.github.com/users/danmacpherson/events{/privacy}","received_events_url":"https://api.github.com/users/danmacpherson/received_events","type":"User","site_admin":false},"repo":{"id":73685202,"name":"openshift-docs","full_name":"danmacpherson/openshift-docs","owner":{"login":"danmacpherson","id":1260665,"avatar_url":"https://avatars.githubusercontent.com/u/1260665?v=3","gravatar_id":"","url":"https://api.github.com/users/danmacpherson","html_url":"https://github.com/danmacpherson","followers_url":"https://api.github.com/users/danmacpherson/followers","following_url":"https://api.github.com/users/danmacpherson/following{/other_user}","gists_url":"https://api.github.com/users/danmacpherson/gists{/gist_id}","starred_url":"https://api.github.com/users/danmacpherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmacpherson/subscriptions","organizations_url":"https://api.github.com/users/danmacpherson/orgs","repos_url":"https://api.github.com/users/danmacpherson/repos","events_url":"https://api.github.com/users/danmacpherson/events{/privacy}","received_events_url":"https://api.github.com/users/danmacpherson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danmacpherson/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/danmacpherson/openshift-docs","forks_url":"https://api.github.com/repos/danmacpherson/openshift-docs/forks","keys_url":"https://api.github.com/repos/danmacpherson/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danmacpherson/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danmacpherson/openshift-docs/teams","hooks_url":"https://api.github.com/repos/danmacpherson/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/danmacpherson/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/danmacpherson/openshift-docs/events","assignees_url":"https://api.github.com/repos/danmacpherson/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/danmacpherson/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/danmacpherson/openshift-docs/tags","blobs_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danmacpherson/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/danmacpherson/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/danmacpherson/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/danmacpherson/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/danmacpherson/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/danmacpherson/openshift-docs/subscription","commits_url":"https://api.github.com/repos/danmacpherson/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/danmacpherson/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/danmacpherson/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/danmacpherson/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/danmacpherson/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/danmacpherson/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danmacpherson/openshift-docs/merges","archive_url":"https://api.github.com/repos/danmacpherson/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danmacpherson/openshift-docs/downloads","issues_url":"https://api.github.com/repos/danmacpherson/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/danmacpherson/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/danmacpherson/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/danmacpherson/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danmacpherson/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/danmacpherson/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/danmacpherson/openshift-docs/deployments","created_at":"2016-11-14T08:50:46Z","updated_at":"2016-11-14T08:50:48Z","pushed_at":"2017-01-11T15:39:24Z","git_url":"git://github.com/danmacpherson/openshift-docs.git","ssh_url":"[email protected]:danmacpherson/openshift-docs.git","clone_url":"https://github.com/danmacpherson/openshift-docs.git","svn_url":"https://github.com/danmacpherson/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":23626,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6d86816dba7d458e0e8fe57df3d0b6324ae7edff","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"name":"openshift-docs","full_name":"openshift/openshift-docs","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2017-01-02T09:07:33Z","pushed_at":"2017-01-12T02:12:05Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"[email protected]:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":23997,"stargazers_count":66,"watchers_count":66,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":294,"mirror_url":null,"open_issues_count":208,"forks":294,"open_issues":208,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/3477"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/3477"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/3477"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/3477/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/3477/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/3477/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/c827c870e3b29413c40a5370abc352d023116dff"}}}} | {
"id": 21740844,
"name": "openshift/openshift-docs",
"url": "https://api.github.com/repos/openshift/openshift-docs"
} | {
"id": 5474938,
"login": "bfallonf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5474938?",
"url": "https://api.github.com/users/bfallonf"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-01-12T05:51:54 | 5140549940 | {"actor":{"display_login":"bfallonf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/157489776","pull_request_review_id":84138855,"id":157489776,"diff_hunk":"@@ -7,6 +7,56 @@ set -o pipefail\n cd \"$(dirname \"${BASH_SOURCE}\")/..\"\n source \"$(dirname \"${BASH_SOURCE}\")/lib/init.sh\"\n \n+if [[ -z \"${KUBE_BRANCH:-}\" ]]; then\n+ echo \"KUBE_BRANCH must be set to the branch of openshift/kubernetes to build staging repos from (e.g. release-1.8.5)\"\n+ exit 1\n+fi\n+\n+if [[ -z \"${KUBE_TAG:-}\" ]]; then\n+ echo \"KUBE_TAG must be set to the tag of kubernetes/* staging repos to use as a base (e.g. kubernetes-1.8.5)\"\n+ exit 1\n+fi\n+\n+# Set up mirrors for kubernetes staging repos with carries from openshift/kubernetes\n+mirror=${TMPDIR:-/tmp}/openshift-glide-staging-repos\n+mkdir -p $mirror || true\n+pushd $mirror\n+ # Checkout openshift/kubernetes\n+ git clone https://github.com/openshift/kubernetes.git kubernetes || true\n+ pushd kubernetes\n+ git fetch origin --tags\n+ git reset --hard\n+ git clean -fdx\n+ git checkout master\n+ git branch -D \"${KUBE_BRANCH}\" || true\n+ git checkout -b \"${KUBE_BRANCH}\" \"origin/${KUBE_BRANCH}\"\n+ popd\n+\n+ # Make a repo for each staging dir\n+ for pkg in kubernetes/staging/src/k8s.io/*; do\n+ dir=$(basename $pkg)\n+ echo === $dir\n+ # Check out the corresponding kubernetes/* repo\n+ git clone https://github.com/kubernetes/$dir.git $dir || true\n+ glide mirror set [email protected]:openshift/kubernetes-$dir file://$mirror/$dir --vcs git","path":"hack/update-deps.sh","position":35,"original_position":35,"commit_id":"1ae3029d5265062257d1be1caad8a0aea318ad75","original_commit_id":"14c9781be2cb2faef7aee5851414e0e969909d75","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"The mirrors are stored in a mirrors.yaml file in your GLIDE_HOME.","created_at":"2017-12-18T13:56:19Z","updated_at":"2017-12-18T13:56:19Z","html_url":"https://github.com/openshift/origin/pull/17849#discussion_r157489776","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/17849","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/157489776"},"html":{"href":"https://github.com/openshift/origin/pull/17849#discussion_r157489776"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/17849"}},"in_reply_to_id":157476759},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/17849","id":158824145,"html_url":"https://github.com/openshift/origin/pull/17849","diff_url":"https://github.com/openshift/origin/pull/17849.diff","patch_url":"https://github.com/openshift/origin/pull/17849.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/17849","number":17849,"state":"open","locked":false,"title":"WIP - 1.8.5 rebase","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"Based on https://github.com/openshift/kubernetes/commits/release-1.8.5\r\n\r\nThe staging repo forks are not actually useful for anything other than glide dependency resolution (update-deps.sh deletes them and relinks staging dirs after `glide update` completes). This PR includes updates to update-deps.sh which let us run glide update without needing to fan out the staging forks. Mostly proof-of-concept, can clean up (and isolate the glide mirror settings) if we like the direction.","created_at":"2017-12-18T03:35:27Z","updated_at":"2017-12-18T13:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b7a833843fd3d4c1c1d6cf763c40e6d2201c2f0","assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"assignees":[{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/17849/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/17849/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/17849/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/1ae3029d5265062257d1be1caad8a0aea318ad75","head":{"label":"liggitt:rebase-1.8.5","ref":"rebase-1.8.5","sha":"1ae3029d5265062257d1be1caad8a0aea318ad75","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"repo":{"id":23198153,"name":"origin","full_name":"liggitt/origin","owner":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liggitt/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/liggitt/origin","forks_url":"https://api.github.com/repos/liggitt/origin/forks","keys_url":"https://api.github.com/repos/liggitt/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liggitt/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liggitt/origin/teams","hooks_url":"https://api.github.com/repos/liggitt/origin/hooks","issue_events_url":"https://api.github.com/repos/liggitt/origin/issues/events{/number}","events_url":"https://api.github.com/repos/liggitt/origin/events","assignees_url":"https://api.github.com/repos/liggitt/origin/assignees{/user}","branches_url":"https://api.github.com/repos/liggitt/origin/branches{/branch}","tags_url":"https://api.github.com/repos/liggitt/origin/tags","blobs_url":"https://api.github.com/repos/liggitt/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liggitt/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liggitt/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/liggitt/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liggitt/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/liggitt/origin/languages","stargazers_url":"https://api.github.com/repos/liggitt/origin/stargazers","contributors_url":"https://api.github.com/repos/liggitt/origin/contributors","subscribers_url":"https://api.github.com/repos/liggitt/origin/subscribers","subscription_url":"https://api.github.com/repos/liggitt/origin/subscription","commits_url":"https://api.github.com/repos/liggitt/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/liggitt/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/liggitt/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/liggitt/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/liggitt/origin/contents/{+path}","compare_url":"https://api.github.com/repos/liggitt/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liggitt/origin/merges","archive_url":"https://api.github.com/repos/liggitt/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liggitt/origin/downloads","issues_url":"https://api.github.com/repos/liggitt/origin/issues{/number}","pulls_url":"https://api.github.com/repos/liggitt/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/liggitt/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/liggitt/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liggitt/origin/labels{/name}","releases_url":"https://api.github.com/repos/liggitt/origin/releases{/id}","deployments_url":"https://api.github.com/repos/liggitt/origin/deployments","created_at":"2014-08-21T18:23:05Z","updated_at":"2017-07-17T05:35:11Z","pushed_at":"2017-12-18T04:23:41Z","git_url":"git://github.com/liggitt/origin.git","ssh_url":"[email protected]:liggitt/origin.git","clone_url":"https://github.com/liggitt/origin.git","svn_url":"https://github.com/liggitt/origin","homepage":"https://openshift.github.io","size":897720,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:release-3.8","ref":"release-3.8","sha":"cc39bcd5de50efbf0548a78f520834469f54d362","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2017-12-18T13:25:04Z","pushed_at":"2017-12-18T13:51:34Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"[email protected]:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":937660,"stargazers_count":3784,"watchers_count":3784,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2434,"mirror_url":null,"archived":false,"open_issues_count":1685,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2434,"open_issues":1685,"watchers":3784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/17849"},"html":{"href":"https://github.com/openshift/origin/pull/17849"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/17849"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/17849/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/17849/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/17849/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/1ae3029d5265062257d1be1caad8a0aea318ad75"}},"author_association":"MEMBER"}} | {
"id": 22442668,
"name": "openshift/origin",
"url": "https://api.github.com/repos/openshift/origin"
} | {
"id": 44136,
"login": "mfojtik",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44136?",
"url": "https://api.github.com/users/mfojtik"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2017-12-18T13:56:19 | 7002391494 | {"actor":{"display_login":"mfojtik"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/opentable/otj-logging/pulls/comments/126039292","pull_request_review_id":48488308,"id":126039292,"diff_hunk":"@@ -86,18 +76,24 @@ default String getOtEnvFlavor() {\n @JsonProperty(\"severity\")\n String getSeverity();\n \n- @JsonProperty(\"logmessage\")\n+ @JsonProperty(\"message\")\n String getMessage();\n \n- @JsonProperty(\"threadname\")\n+ @JsonProperty(\"thread-name\")\n String getThreadName();\n \n- @JsonProperty(\"throwable\")\n+ @JsonProperty(\"exception\")\n String getThrowable();\n \n /** Written by the encoder, value is ignored for serialization. */\n- @JsonProperty(\"sequencenumber\")\n+ @JsonProperty(\"sequence-number\")\n default long getSequenceNumber() {\n return Long.MIN_VALUE;\n }\n+\n+ /** Declare the OTL type for selectorless processing. */\n+ @JsonProperty(\"@loglov3-otl\")\n+ default String getLoglov3Otl() {","path":"core/src/main/java/com/opentable/logging/CommonLogFields.java","position":54,"original_position":54,"commit_id":"f71ca45c534c5d6d2c424ace31771f4f0dd68ab3","original_commit_id":"f71ca45c534c5d6d2c424ace31771f4f0dd68ab3","user":{"login":"adamzr","id":455518,"avatar_url":"https://avatars2.githubusercontent.com/u/455518?v=3","gravatar_id":"","url":"https://api.github.com/users/adamzr","html_url":"https://github.com/adamzr","followers_url":"https://api.github.com/users/adamzr/followers","following_url":"https://api.github.com/users/adamzr/following{/other_user}","gists_url":"https://api.github.com/users/adamzr/gists{/gist_id}","starred_url":"https://api.github.com/users/adamzr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamzr/subscriptions","organizations_url":"https://api.github.com/users/adamzr/orgs","repos_url":"https://api.github.com/users/adamzr/repos","events_url":"https://api.github.com/users/adamzr/events{/privacy}","received_events_url":"https://api.github.com/users/adamzr/received_events","type":"User","site_admin":false},"body":"I suggest just defining the field here and moving the `return \"msg-v1\";` to the implementing class `ApplicationLogEvent`.\r\n\r\nIf someone implements this interface and then adds their own fields, then they should ideally create a new OTL defining those fields. With the default method like this they would be be getting the `msg-v1` OTL. Masking the implementor choose the OTL is a subtle hint that they should create one.","created_at":"2017-07-06T23:15:29Z","updated_at":"2017-07-06T23:33:09Z","html_url":"https://github.com/opentable/otj-logging/pull/36#discussion_r126039292","pull_request_url":"https://api.github.com/repos/opentable/otj-logging/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/opentable/otj-logging/pulls/comments/126039292"},"html":{"href":"https://github.com/opentable/otj-logging/pull/36#discussion_r126039292"},"pull_request":{"href":"https://api.github.com/repos/opentable/otj-logging/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/opentable/otj-logging/pulls/36","id":128214734,"html_url":"https://github.com/opentable/otj-logging/pull/36","diff_url":"https://github.com/opentable/otj-logging/pull/36.diff","patch_url":"https://github.com/opentable/otj-logging/pull/36.patch","issue_url":"https://api.github.com/repos/opentable/otj-logging/issues/36","number":36,"state":"open","locked":false,"title":"loglov3 selectorless: update json wire format","user":{"login":"stevenschlansker","id":129097,"avatar_url":"https://avatars3.githubusercontent.com/u/129097?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenschlansker","html_url":"https://github.com/stevenschlansker","followers_url":"https://api.github.com/users/stevenschlansker/followers","following_url":"https://api.github.com/users/stevenschlansker/following{/other_user}","gists_url":"https://api.github.com/users/stevenschlansker/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenschlansker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenschlansker/subscriptions","organizations_url":"https://api.github.com/users/stevenschlansker/orgs","repos_url":"https://api.github.com/users/stevenschlansker/repos","events_url":"https://api.github.com/users/stevenschlansker/events{/privacy}","received_events_url":"https://api.github.com/users/stevenschlansker/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-06-29T18:15:24Z","updated_at":"2017-07-06T23:33:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cbc5a06821c31fa38921e09d7a40b0b8d232525","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SegFaultAX","id":87773,"avatar_url":"https://avatars2.githubusercontent.com/u/87773?v=3","gravatar_id":"","url":"https://api.github.com/users/SegFaultAX","html_url":"https://github.com/SegFaultAX","followers_url":"https://api.github.com/users/SegFaultAX/followers","following_url":"https://api.github.com/users/SegFaultAX/following{/other_user}","gists_url":"https://api.github.com/users/SegFaultAX/gists{/gist_id}","starred_url":"https://api.github.com/users/SegFaultAX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SegFaultAX/subscriptions","organizations_url":"https://api.github.com/users/SegFaultAX/orgs","repos_url":"https://api.github.com/users/SegFaultAX/repos","events_url":"https://api.github.com/users/SegFaultAX/events{/privacy}","received_events_url":"https://api.github.com/users/SegFaultAX/received_events","type":"User","site_admin":false},{"login":"scottjohnson","id":213386,"avatar_url":"https://avatars1.githubusercontent.com/u/213386?v=3","gravatar_id":"","url":"https://api.github.com/users/scottjohnson","html_url":"https://github.com/scottjohnson","followers_url":"https://api.github.com/users/scottjohnson/followers","following_url":"https://api.github.com/users/scottjohnson/following{/other_user}","gists_url":"https://api.github.com/users/scottjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/scottjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottjohnson/subscriptions","organizations_url":"https://api.github.com/users/scottjohnson/orgs","repos_url":"https://api.github.com/users/scottjohnson/repos","events_url":"https://api.github.com/users/scottjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/scottjohnson/received_events","type":"User","site_admin":false},{"login":"strykerd","id":1839425,"avatar_url":"https://avatars2.githubusercontent.com/u/1839425?v=3","gravatar_id":"","url":"https://api.github.com/users/strykerd","html_url":"https://github.com/strykerd","followers_url":"https://api.github.com/users/strykerd/followers","following_url":"https://api.github.com/users/strykerd/following{/other_user}","gists_url":"https://api.github.com/users/strykerd/gists{/gist_id}","starred_url":"https://api.github.com/users/strykerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strykerd/subscriptions","organizations_url":"https://api.github.com/users/strykerd/orgs","repos_url":"https://api.github.com/users/strykerd/repos","events_url":"https://api.github.com/users/strykerd/events{/privacy}","received_events_url":"https://api.github.com/users/strykerd/received_events","type":"User","site_admin":false},{"login":"pennello","id":5225759,"avatar_url":"https://avatars1.githubusercontent.com/u/5225759?v=3","gravatar_id":"","url":"https://api.github.com/users/pennello","html_url":"https://github.com/pennello","followers_url":"https://api.github.com/users/pennello/followers","following_url":"https://api.github.com/users/pennello/following{/other_user}","gists_url":"https://api.github.com/users/pennello/gists{/gist_id}","starred_url":"https://api.github.com/users/pennello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pennello/subscriptions","organizations_url":"https://api.github.com/users/pennello/orgs","repos_url":"https://api.github.com/users/pennello/repos","events_url":"https://api.github.com/users/pennello/events{/privacy}","received_events_url":"https://api.github.com/users/pennello/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/opentable/otj-logging/pulls/36/commits","review_comments_url":"https://api.github.com/repos/opentable/otj-logging/pulls/36/comments","review_comment_url":"https://api.github.com/repos/opentable/otj-logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentable/otj-logging/issues/36/comments","statuses_url":"https://api.github.com/repos/opentable/otj-logging/statuses/f71ca45c534c5d6d2c424ace31771f4f0dd68ab3","head":{"label":"opentable:otpl-1610-loglov3-selectorless","ref":"otpl-1610-loglov3-selectorless","sha":"f71ca45c534c5d6d2c424ace31771f4f0dd68ab3","user":{"login":"opentable","id":2653541,"avatar_url":"https://avatars3.githubusercontent.com/u/2653541?v=3","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"repo":{"id":17919790,"name":"otj-logging","full_name":"opentable/otj-logging","owner":{"login":"opentable","id":2653541,"avatar_url":"https://avatars3.githubusercontent.com/u/2653541?v=3","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentable/otj-logging","description":"OpenTable Java logging configuration component","fork":false,"url":"https://api.github.com/repos/opentable/otj-logging","forks_url":"https://api.github.com/repos/opentable/otj-logging/forks","keys_url":"https://api.github.com/repos/opentable/otj-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentable/otj-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentable/otj-logging/teams","hooks_url":"https://api.github.com/repos/opentable/otj-logging/hooks","issue_events_url":"https://api.github.com/repos/opentable/otj-logging/issues/events{/number}","events_url":"https://api.github.com/repos/opentable/otj-logging/events","assignees_url":"https://api.github.com/repos/opentable/otj-logging/assignees{/user}","branches_url":"https://api.github.com/repos/opentable/otj-logging/branches{/branch}","tags_url":"https://api.github.com/repos/opentable/otj-logging/tags","blobs_url":"https://api.github.com/repos/opentable/otj-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentable/otj-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentable/otj-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentable/otj-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentable/otj-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/opentable/otj-logging/languages","stargazers_url":"https://api.github.com/repos/opentable/otj-logging/stargazers","contributors_url":"https://api.github.com/repos/opentable/otj-logging/contributors","subscribers_url":"https://api.github.com/repos/opentable/otj-logging/subscribers","subscription_url":"https://api.github.com/repos/opentable/otj-logging/subscription","commits_url":"https://api.github.com/repos/opentable/otj-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentable/otj-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentable/otj-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentable/otj-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentable/otj-logging/contents/{+path}","compare_url":"https://api.github.com/repos/opentable/otj-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentable/otj-logging/merges","archive_url":"https://api.github.com/repos/opentable/otj-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentable/otj-logging/downloads","issues_url":"https://api.github.com/repos/opentable/otj-logging/issues{/number}","pulls_url":"https://api.github.com/repos/opentable/otj-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/opentable/otj-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/opentable/otj-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentable/otj-logging/labels{/name}","releases_url":"https://api.github.com/repos/opentable/otj-logging/releases{/id}","deployments_url":"https://api.github.com/repos/opentable/otj-logging/deployments","created_at":"2014-03-19T20:47:45Z","updated_at":"2017-02-13T21:47:33Z","pushed_at":"2017-07-06T18:07:31Z","git_url":"git://github.com/opentable/otj-logging.git","ssh_url":"[email protected]:opentable/otj-logging.git","clone_url":"https://github.com/opentable/otj-logging.git","svn_url":"https://github.com/opentable/otj-logging","homepage":null,"size":332,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"opentable:master","ref":"master","sha":"db25580d38a56a007ac694889e578b902d16bfea","user":{"login":"opentable","id":2653541,"avatar_url":"https://avatars3.githubusercontent.com/u/2653541?v=3","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"repo":{"id":17919790,"name":"otj-logging","full_name":"opentable/otj-logging","owner":{"login":"opentable","id":2653541,"avatar_url":"https://avatars3.githubusercontent.com/u/2653541?v=3","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentable/otj-logging","description":"OpenTable Java logging configuration component","fork":false,"url":"https://api.github.com/repos/opentable/otj-logging","forks_url":"https://api.github.com/repos/opentable/otj-logging/forks","keys_url":"https://api.github.com/repos/opentable/otj-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentable/otj-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentable/otj-logging/teams","hooks_url":"https://api.github.com/repos/opentable/otj-logging/hooks","issue_events_url":"https://api.github.com/repos/opentable/otj-logging/issues/events{/number}","events_url":"https://api.github.com/repos/opentable/otj-logging/events","assignees_url":"https://api.github.com/repos/opentable/otj-logging/assignees{/user}","branches_url":"https://api.github.com/repos/opentable/otj-logging/branches{/branch}","tags_url":"https://api.github.com/repos/opentable/otj-logging/tags","blobs_url":"https://api.github.com/repos/opentable/otj-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentable/otj-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentable/otj-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentable/otj-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentable/otj-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/opentable/otj-logging/languages","stargazers_url":"https://api.github.com/repos/opentable/otj-logging/stargazers","contributors_url":"https://api.github.com/repos/opentable/otj-logging/contributors","subscribers_url":"https://api.github.com/repos/opentable/otj-logging/subscribers","subscription_url":"https://api.github.com/repos/opentable/otj-logging/subscription","commits_url":"https://api.github.com/repos/opentable/otj-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentable/otj-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentable/otj-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentable/otj-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentable/otj-logging/contents/{+path}","compare_url":"https://api.github.com/repos/opentable/otj-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentable/otj-logging/merges","archive_url":"https://api.github.com/repos/opentable/otj-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentable/otj-logging/downloads","issues_url":"https://api.github.com/repos/opentable/otj-logging/issues{/number}","pulls_url":"https://api.github.com/repos/opentable/otj-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/opentable/otj-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/opentable/otj-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentable/otj-logging/labels{/name}","releases_url":"https://api.github.com/repos/opentable/otj-logging/releases{/id}","deployments_url":"https://api.github.com/repos/opentable/otj-logging/deployments","created_at":"2014-03-19T20:47:45Z","updated_at":"2017-02-13T21:47:33Z","pushed_at":"2017-07-06T18:07:31Z","git_url":"git://github.com/opentable/otj-logging.git","ssh_url":"[email protected]:opentable/otj-logging.git","clone_url":"https://github.com/opentable/otj-logging.git","svn_url":"https://github.com/opentable/otj-logging","homepage":null,"size":332,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentable/otj-logging/pulls/36"},"html":{"href":"https://github.com/opentable/otj-logging/pull/36"},"issue":{"href":"https://api.github.com/repos/opentable/otj-logging/issues/36"},"comments":{"href":"https://api.github.com/repos/opentable/otj-logging/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/opentable/otj-logging/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/opentable/otj-logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentable/otj-logging/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/opentable/otj-logging/statuses/f71ca45c534c5d6d2c424ace31771f4f0dd68ab3"}}}} | {
"id": 17919790,
"name": "opentable/otj-logging",
"url": "https://api.github.com/repos/opentable/otj-logging"
} | {
"id": 455518,
"login": "adamzr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/455518?",
"url": "https://api.github.com/users/adamzr"
} | {
"id": 2653541,
"login": "opentable",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2653541?",
"url": "https://api.github.com/orgs/opentable"
} | 2017-07-06T23:15:29 | 6208396225 | {"actor":{"display_login":"adamzr"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/opstalent/crud/pulls/comments/146482014","pull_request_review_id":71428102,"id":146482014,"diff_hunk":"@@ -0,0 +1,29 @@\n+<?php\n+\n+namespace Opstalent\\CrudBundle\\DependencyInjection;\n+\n+use Symfony\\Component\\Config\\FileLocator;\n+use Symfony\\Component\\DependencyInjection\\ContainerBuilder;\n+use Symfony\\Component\\DependencyInjection\\Loader\\YamlFileLoader;\n+use Symfony\\Component\\DependencyInjection\\Extension\\Extension;\n+\n+/**\n+ * Class OpstalentCrudExtension\n+ * @author Szyon Kunowski <[email protected]>\n+ * @package Opstalent\\CrudBundle\n+ */\n+class OpstalentCrudExtension extends Extension\n+{\n+ /**\n+ * @param array $configs\n+ * @param ContainerBuilder $container","path":"src/DependencyInjection/OpstalentCrudExtension.php","position":19,"original_position":19,"commit_id":"b8f52c55c838f3be596fcf7d6503f7338dd6be34","original_commit_id":"b8f52c55c838f3be596fcf7d6503f7338dd6be34","user":{"login":"patgrudniewski","id":6398253,"avatar_url":"https://avatars3.githubusercontent.com/u/6398253?v=4","gravatar_id":"","url":"https://api.github.com/users/patgrudniewski","html_url":"https://github.com/patgrudniewski","followers_url":"https://api.github.com/users/patgrudniewski/followers","following_url":"https://api.github.com/users/patgrudniewski/following{/other_user}","gists_url":"https://api.github.com/users/patgrudniewski/gists{/gist_id}","starred_url":"https://api.github.com/users/patgrudniewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patgrudniewski/subscriptions","organizations_url":"https://api.github.com/users/patgrudniewski/orgs","repos_url":"https://api.github.com/users/patgrudniewski/repos","events_url":"https://api.github.com/users/patgrudniewski/events{/privacy}","received_events_url":"https://api.github.com/users/patgrudniewski/received_events","type":"User","site_admin":false},"body":"`@inheritdoc`?","created_at":"2017-10-24T08:14:01Z","updated_at":"2017-10-24T08:14:29Z","html_url":"https://github.com/opstalent/crud/pull/5#discussion_r146482014","pull_request_url":"https://api.github.com/repos/opstalent/crud/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opstalent/crud/pulls/comments/146482014"},"html":{"href":"https://github.com/opstalent/crud/pull/5#discussion_r146482014"},"pull_request":{"href":"https://api.github.com/repos/opstalent/crud/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/opstalent/crud/pulls/5","id":147802615,"html_url":"https://github.com/opstalent/crud/pull/5","diff_url":"https://github.com/opstalent/crud/pull/5.diff","patch_url":"https://github.com/opstalent/crud/pull/5.patch","issue_url":"https://api.github.com/repos/opstalent/crud/issues/5","number":5,"state":"open","locked":false,"title":"dependencyInjection created","user":{"login":"auamarto","id":5755086,"avatar_url":"https://avatars2.githubusercontent.com/u/5755086?v=4","gravatar_id":"","url":"https://api.github.com/users/auamarto","html_url":"https://github.com/auamarto","followers_url":"https://api.github.com/users/auamarto/followers","following_url":"https://api.github.com/users/auamarto/following{/other_user}","gists_url":"https://api.github.com/users/auamarto/gists{/gist_id}","starred_url":"https://api.github.com/users/auamarto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auamarto/subscriptions","organizations_url":"https://api.github.com/users/auamarto/orgs","repos_url":"https://api.github.com/users/auamarto/repos","events_url":"https://api.github.com/users/auamarto/events{/privacy}","received_events_url":"https://api.github.com/users/auamarto/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-20T13:39:24Z","updated_at":"2017-10-24T08:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d92432c2a1589f6a03b70027407690bc9371780b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opstalent/crud/pulls/5/commits","review_comments_url":"https://api.github.com/repos/opstalent/crud/pulls/5/comments","review_comment_url":"https://api.github.com/repos/opstalent/crud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opstalent/crud/issues/5/comments","statuses_url":"https://api.github.com/repos/opstalent/crud/statuses/b8f52c55c838f3be596fcf7d6503f7338dd6be34","head":{"label":"opstalent:dependencyInjection","ref":"dependencyInjection","sha":"b8f52c55c838f3be596fcf7d6503f7338dd6be34","user":{"login":"opstalent","id":18002910,"avatar_url":"https://avatars1.githubusercontent.com/u/18002910?v=4","gravatar_id":"","url":"https://api.github.com/users/opstalent","html_url":"https://github.com/opstalent","followers_url":"https://api.github.com/users/opstalent/followers","following_url":"https://api.github.com/users/opstalent/following{/other_user}","gists_url":"https://api.github.com/users/opstalent/gists{/gist_id}","starred_url":"https://api.github.com/users/opstalent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opstalent/subscriptions","organizations_url":"https://api.github.com/users/opstalent/orgs","repos_url":"https://api.github.com/users/opstalent/repos","events_url":"https://api.github.com/users/opstalent/events{/privacy}","received_events_url":"https://api.github.com/users/opstalent/received_events","type":"Organization","site_admin":false},"repo":{"id":105739431,"name":"crud","full_name":"opstalent/crud","owner":{"login":"opstalent","id":18002910,"avatar_url":"https://avatars1.githubusercontent.com/u/18002910?v=4","gravatar_id":"","url":"https://api.github.com/users/opstalent","html_url":"https://github.com/opstalent","followers_url":"https://api.github.com/users/opstalent/followers","following_url":"https://api.github.com/users/opstalent/following{/other_user}","gists_url":"https://api.github.com/users/opstalent/gists{/gist_id}","starred_url":"https://api.github.com/users/opstalent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opstalent/subscriptions","organizations_url":"https://api.github.com/users/opstalent/orgs","repos_url":"https://api.github.com/users/opstalent/repos","events_url":"https://api.github.com/users/opstalent/events{/privacy}","received_events_url":"https://api.github.com/users/opstalent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opstalent/crud","description":null,"fork":false,"url":"https://api.github.com/repos/opstalent/crud","forks_url":"https://api.github.com/repos/opstalent/crud/forks","keys_url":"https://api.github.com/repos/opstalent/crud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opstalent/crud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opstalent/crud/teams","hooks_url":"https://api.github.com/repos/opstalent/crud/hooks","issue_events_url":"https://api.github.com/repos/opstalent/crud/issues/events{/number}","events_url":"https://api.github.com/repos/opstalent/crud/events","assignees_url":"https://api.github.com/repos/opstalent/crud/assignees{/user}","branches_url":"https://api.github.com/repos/opstalent/crud/branches{/branch}","tags_url":"https://api.github.com/repos/opstalent/crud/tags","blobs_url":"https://api.github.com/repos/opstalent/crud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opstalent/crud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opstalent/crud/git/refs{/sha}","trees_url":"https://api.github.com/repos/opstalent/crud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opstalent/crud/statuses/{sha}","languages_url":"https://api.github.com/repos/opstalent/crud/languages","stargazers_url":"https://api.github.com/repos/opstalent/crud/stargazers","contributors_url":"https://api.github.com/repos/opstalent/crud/contributors","subscribers_url":"https://api.github.com/repos/opstalent/crud/subscribers","subscription_url":"https://api.github.com/repos/opstalent/crud/subscription","commits_url":"https://api.github.com/repos/opstalent/crud/commits{/sha}","git_commits_url":"https://api.github.com/repos/opstalent/crud/git/commits{/sha}","comments_url":"https://api.github.com/repos/opstalent/crud/comments{/number}","issue_comment_url":"https://api.github.com/repos/opstalent/crud/issues/comments{/number}","contents_url":"https://api.github.com/repos/opstalent/crud/contents/{+path}","compare_url":"https://api.github.com/repos/opstalent/crud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opstalent/crud/merges","archive_url":"https://api.github.com/repos/opstalent/crud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opstalent/crud/downloads","issues_url":"https://api.github.com/repos/opstalent/crud/issues{/number}","pulls_url":"https://api.github.com/repos/opstalent/crud/pulls{/number}","milestones_url":"https://api.github.com/repos/opstalent/crud/milestones{/number}","notifications_url":"https://api.github.com/repos/opstalent/crud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opstalent/crud/labels{/name}","releases_url":"https://api.github.com/repos/opstalent/crud/releases{/id}","deployments_url":"https://api.github.com/repos/opstalent/crud/deployments","created_at":"2017-10-04T06:49:48Z","updated_at":"2017-10-05T08:35:45Z","pushed_at":"2017-10-23T11:01:21Z","git_url":"git://github.com/opstalent/crud.git","ssh_url":"[email protected]:opstalent/crud.git","clone_url":"https://github.com/opstalent/crud.git","svn_url":"https://github.com/opstalent/crud","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"opstalent:master","ref":"master","sha":"ac866609acc5cb3f9fbab74b061c5c8ab4145b5d","user":{"login":"opstalent","id":18002910,"avatar_url":"https://avatars1.githubusercontent.com/u/18002910?v=4","gravatar_id":"","url":"https://api.github.com/users/opstalent","html_url":"https://github.com/opstalent","followers_url":"https://api.github.com/users/opstalent/followers","following_url":"https://api.github.com/users/opstalent/following{/other_user}","gists_url":"https://api.github.com/users/opstalent/gists{/gist_id}","starred_url":"https://api.github.com/users/opstalent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opstalent/subscriptions","organizations_url":"https://api.github.com/users/opstalent/orgs","repos_url":"https://api.github.com/users/opstalent/repos","events_url":"https://api.github.com/users/opstalent/events{/privacy}","received_events_url":"https://api.github.com/users/opstalent/received_events","type":"Organization","site_admin":false},"repo":{"id":105739431,"name":"crud","full_name":"opstalent/crud","owner":{"login":"opstalent","id":18002910,"avatar_url":"https://avatars1.githubusercontent.com/u/18002910?v=4","gravatar_id":"","url":"https://api.github.com/users/opstalent","html_url":"https://github.com/opstalent","followers_url":"https://api.github.com/users/opstalent/followers","following_url":"https://api.github.com/users/opstalent/following{/other_user}","gists_url":"https://api.github.com/users/opstalent/gists{/gist_id}","starred_url":"https://api.github.com/users/opstalent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opstalent/subscriptions","organizations_url":"https://api.github.com/users/opstalent/orgs","repos_url":"https://api.github.com/users/opstalent/repos","events_url":"https://api.github.com/users/opstalent/events{/privacy}","received_events_url":"https://api.github.com/users/opstalent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opstalent/crud","description":null,"fork":false,"url":"https://api.github.com/repos/opstalent/crud","forks_url":"https://api.github.com/repos/opstalent/crud/forks","keys_url":"https://api.github.com/repos/opstalent/crud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opstalent/crud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opstalent/crud/teams","hooks_url":"https://api.github.com/repos/opstalent/crud/hooks","issue_events_url":"https://api.github.com/repos/opstalent/crud/issues/events{/number}","events_url":"https://api.github.com/repos/opstalent/crud/events","assignees_url":"https://api.github.com/repos/opstalent/crud/assignees{/user}","branches_url":"https://api.github.com/repos/opstalent/crud/branches{/branch}","tags_url":"https://api.github.com/repos/opstalent/crud/tags","blobs_url":"https://api.github.com/repos/opstalent/crud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opstalent/crud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opstalent/crud/git/refs{/sha}","trees_url":"https://api.github.com/repos/opstalent/crud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opstalent/crud/statuses/{sha}","languages_url":"https://api.github.com/repos/opstalent/crud/languages","stargazers_url":"https://api.github.com/repos/opstalent/crud/stargazers","contributors_url":"https://api.github.com/repos/opstalent/crud/contributors","subscribers_url":"https://api.github.com/repos/opstalent/crud/subscribers","subscription_url":"https://api.github.com/repos/opstalent/crud/subscription","commits_url":"https://api.github.com/repos/opstalent/crud/commits{/sha}","git_commits_url":"https://api.github.com/repos/opstalent/crud/git/commits{/sha}","comments_url":"https://api.github.com/repos/opstalent/crud/comments{/number}","issue_comment_url":"https://api.github.com/repos/opstalent/crud/issues/comments{/number}","contents_url":"https://api.github.com/repos/opstalent/crud/contents/{+path}","compare_url":"https://api.github.com/repos/opstalent/crud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opstalent/crud/merges","archive_url":"https://api.github.com/repos/opstalent/crud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opstalent/crud/downloads","issues_url":"https://api.github.com/repos/opstalent/crud/issues{/number}","pulls_url":"https://api.github.com/repos/opstalent/crud/pulls{/number}","milestones_url":"https://api.github.com/repos/opstalent/crud/milestones{/number}","notifications_url":"https://api.github.com/repos/opstalent/crud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opstalent/crud/labels{/name}","releases_url":"https://api.github.com/repos/opstalent/crud/releases{/id}","deployments_url":"https://api.github.com/repos/opstalent/crud/deployments","created_at":"2017-10-04T06:49:48Z","updated_at":"2017-10-05T08:35:45Z","pushed_at":"2017-10-23T11:01:21Z","git_url":"git://github.com/opstalent/crud.git","ssh_url":"[email protected]:opstalent/crud.git","clone_url":"https://github.com/opstalent/crud.git","svn_url":"https://github.com/opstalent/crud","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opstalent/crud/pulls/5"},"html":{"href":"https://github.com/opstalent/crud/pull/5"},"issue":{"href":"https://api.github.com/repos/opstalent/crud/issues/5"},"comments":{"href":"https://api.github.com/repos/opstalent/crud/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/opstalent/crud/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/opstalent/crud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opstalent/crud/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/opstalent/crud/statuses/b8f52c55c838f3be596fcf7d6503f7338dd6be34"}},"author_association":"CONTRIBUTOR"}} | {
"id": 105739431,
"name": "opstalent/crud",
"url": "https://api.github.com/repos/opstalent/crud"
} | {
"id": 6398253,
"login": "patgrudniewski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6398253?",
"url": "https://api.github.com/users/patgrudniewski"
} | {
"id": 18002910,
"login": "opstalent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18002910?",
"url": "https://api.github.com/orgs/opstalent"
} | 2017-10-24T08:14:01 | 6756715608 | {"actor":{"display_login":"patgrudniewski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/crates.io/pulls/comments/122599565","pull_request_review_id":44729078,"id":122599565,"diff_hunk":"@@ -0,0 +1,221 @@\n+use std::fmt;\n+\n+use diesel;\n+use diesel::prelude::*;\n+use diesel::pg::PgConnection;\n+use conduit::{Request, Response};\n+use time::Timespec;\n+use conduit_router::RequestParams;\n+use rustc_serialize::json;\n+\n+use db::RequestTransaction;\n+use user::{RequestUser, AuthenticationSource};\n+use util::{RequestUtils, CargoError, CargoResult, ChainError, human, read_fill};\n+use schema::api_tokens;\n+\n+/// The model representing a row in the `api_tokens` database table.\n+#[derive(Clone, Debug, PartialEq, Eq, Identifiable, Queryable)]\n+pub struct ApiToken {\n+ pub id: i32,\n+ pub user_id: i32,\n+ pub token: String,\n+ pub name: String,\n+ pub created_at: Timespec,\n+ pub last_used_at: Option<Timespec>,\n+}\n+\n+/// The serialization format for the `ApiToken` model.\n+#[derive(RustcDecodable, RustcEncodable)]\n+pub struct EncodableApiToken {\n+ pub id: i32,\n+ pub name: String,\n+ pub token: Option<String>,\n+ pub created_at: String,\n+ pub last_used_at: Option<String>,\n+}\n+\n+impl ApiToken {\n+ /// Generates a new named API token for a user\n+ pub fn insert(conn: &PgConnection, user_id: i32, name: &str) -> CargoResult<ApiToken> {\n+ #[table_name = \"api_tokens\"]\n+ #[derive(Insertable, AsChangeset)]\n+ struct NewApiToken<'a> {\n+ user_id: i32,\n+ name: &'a str,\n+ }\n+\n+ diesel::insert(&NewApiToken {\n+ user_id: user_id,\n+ name: name,\n+ }).into(api_tokens::table)\n+ .get_result::<ApiToken>(conn)\n+ .map_err(From::from)\n+ }\n+\n+ /// Deletes the provided API token if it belongs to the provided user\n+ pub fn delete(conn: &PgConnection, user_id: i32, id: i32) -> CargoResult<()> {\n+ diesel::delete(api_tokens::table.find(id).filter(\n+ api_tokens::user_id.eq(user_id),\n+ )).execute(conn)?;\n+ Ok(())\n+ }\n+\n+ pub fn find_for_user(conn: &PgConnection, user_id: i32) -> CargoResult<Vec<ApiToken>> {\n+ api_tokens::table\n+ .filter(api_tokens::user_id.eq(user_id))\n+ .order(api_tokens::created_at.desc())\n+ .load::<ApiToken>(conn)\n+ .map_err(From::from)\n+ }\n+\n+ pub fn count_for_user(conn: &PgConnection, user_id: i32) -> CargoResult<u64> {\n+ api_tokens::table\n+ .filter(api_tokens::user_id.eq(user_id))\n+ .count()\n+ .get_result::<i64>(conn)\n+ .map(|count| count as u64)\n+ .map_err(From::from)\n+ }\n+\n+ /// Converts this `ApiToken` model into an `EncodableApiToken` for JSON\n+ /// serialization.\n+ pub fn encodable(self) -> EncodableApiToken {\n+ EncodableApiToken {\n+ id: self.id,\n+ name: self.name,\n+ token: None,\n+ created_at: ::encode_time(self.created_at),\n+ last_used_at: self.last_used_at.map(::encode_time),\n+ }\n+ }\n+\n+ /// Converts this `ApiToken` model into an `EncodableApiToken` including\n+ /// the actual token value for JSON serialization.\n+ pub fn encodable_with_token(self) -> EncodableApiToken {\n+ EncodableApiToken {\n+ id: self.id,\n+ name: self.name,\n+ token: Some(self.token),\n+ created_at: ::encode_time(self.created_at),\n+ last_used_at: self.last_used_at.map(::encode_time),\n+ }\n+ }\n+}\n+\n+struct BadRequest<T: CargoError>(T);\n+\n+impl<T: CargoError> CargoError for BadRequest<T> {\n+ fn description(&self) -> &str {\n+ self.0.description()\n+ }\n+ fn response(&self) -> Option<Response> {\n+ self.0.response().map(|mut response| {\n+ response.status = (400, \"Bad Request\");\n+ response\n+ })\n+ }\n+}\n+\n+impl<T: CargoError> fmt::Display for BadRequest<T> {\n+ fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {\n+ write!(f, \"Bad Request: {}\", self.0)\n+ }\n+}\n+\n+fn bad_request<T: CargoError>(error: T) -> Box<CargoError> {\n+ Box::new(BadRequest(error))\n+}\n+\n+/// Handles the `GET /me/tokens` route.\n+pub fn list(req: &mut Request) -> CargoResult<Response> {\n+ let tokens = ApiToken::find_for_user(&*req.db_conn()?, req.user()?.id)?","path":"src/token.rs","position":131,"original_position":131,"commit_id":"1ede604003ac904efec2471a1f9b2fe7151daa94","original_commit_id":"1ede604003ac904efec2471a1f9b2fe7151daa94","user":{"login":"sgrif","id":1529387,"avatar_url":"https://avatars1.githubusercontent.com/u/1529387?v=3","gravatar_id":"","url":"https://api.github.com/users/sgrif","html_url":"https://github.com/sgrif","followers_url":"https://api.github.com/users/sgrif/followers","following_url":"https://api.github.com/users/sgrif/following{/other_user}","gists_url":"https://api.github.com/users/sgrif/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrif/subscriptions","organizations_url":"https://api.github.com/users/sgrif/orgs","repos_url":"https://api.github.com/users/sgrif/repos","events_url":"https://api.github.com/users/sgrif/events{/privacy}","received_events_url":"https://api.github.com/users/sgrif/received_events","type":"User","site_admin":false},"body":"What do you think about pulling these out into local variables? I personally find the condensed punctuation hard to read","created_at":"2017-06-18T19:59:39Z","updated_at":"2017-06-18T19:59:39Z","html_url":"https://github.com/rust-lang/crates.io/pull/697#discussion_r122599565","pull_request_url":"https://api.github.com/repos/rust-lang/crates.io/pulls/697","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/crates.io/pulls/comments/122599565"},"html":{"href":"https://github.com/rust-lang/crates.io/pull/697#discussion_r122599565"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/crates.io/pulls/697"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/crates.io/pulls/697","id":118379931,"html_url":"https://github.com/rust-lang/crates.io/pull/697","diff_url":"https://github.com/rust-lang/crates.io/pull/697.diff","patch_url":"https://github.com/rust-lang/crates.io/pull/697.patch","issue_url":"https://api.github.com/repos/rust-lang/crates.io/issues/697","number":697,"state":"open","locked":false,"title":"Allow users to create multiple API tokens","user":{"login":"Nemo157","id":81079,"avatar_url":"https://avatars2.githubusercontent.com/u/81079?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"body":"Fixes #688\r\n\r\nSummary of changes:\r\n\r\n * Database:\r\n * Add new `api_tokens` table that stores the named tokens, their creation date and last used date\r\n\r\n * API:\r\n * Remove singular `api_token` field from `User`, it is still in the database for easy rollback, but should be removed from there as well soon.\r\n * Remove existing `/me/reset_token` endpoint.\r\n * Update user middleware to search incoming tokens via the `api_tokens` table, updating the last used date as it does so, and to record whether the current request was authenticated via an API token or a session cookie\r\n * This also changes this search to function via `diesel` where it was previously using `pg`\r\n * Add new set of endpoints at `/me/tokens` allowing creating, listing and revoking API tokens\r\n * Listing tokens doesn't return the tokens value, that's only available once in the response from creating the token.\r\n * Tests\r\n\r\n * Frontend:\r\n * Remove the special support for an `api_token` parameter coming back from the `/me` endpoint\r\n * Add new `api-token` model\r\n * Has a special `adapter` as the endpoints are namespaced under `/me/tokens` instead of the default `/api/v1/api_tokens`\r\n * Has a special `serializer` to set the key used when creating a new API token\r\n * Update `/me/index` controller and template\r\n * Render a sorted list of all API tokens in the data store instead of the single token\r\n * Remove button to reset the token\r\n * Add button to start creating a new API token\r\n * Add new `api-token-row` component for rendering the API tokens in\r\n the list on `/me/index`\r\n * Has three major states:\r\n * New token that has yet to be saved to the API, shows a text box to enter a name and button to save the token\r\n * Newly saved token, shows the normal token data + the actual token value and details on how to save it with cargo\r\n * Normal token, shows the name, creation date and last used date along with a button to revoke\r\n * In any of those states can have an error message shown below the token data if creating or revoking the token failed\r\n * Some small general CSS changes:\r\n * A small variant for buttons that reduces the padding\r\n * Support for disabled state on buttons making them a little lighter than the specified color\r\n\r\n<details><summary>old description</summary>\r\nWIP for #688, still has a bit of work to go, but it's currently working and stylish enough that feedback would be useful.\r\n\r\nI took inspiration from GitHub's \"Personal Access Tokens\" around showing the token value only once along with the last usage of the token. \r\n\r\n**TODOs**\r\n - ~Put one of the existing api tokens back in when reverting the SQL migration (not really sure if this is worth doing)~\r\n - [x] Remove deletion of `user.api_token` column\r\n - [x] Limit length of body read during POSTs (potential DOS)\r\n - [x] Limit the number of tokens a single user can have\r\n - [x] Make the name required ~(need something to set as the name of the original token)~\r\n - [x] Put spinner in place of 'Revoke' button during revocation (not sure how to store the metadata needed for this with Ember, maybe the rows of the table need to be components so they have their own controller that knows when it's being revoked)\r\n - [x] Test with non-instantaneous API (need to inject some delays as localhost is too quick for the creating token spinner to even appear)\r\n - [x] *Maybe* add a small permissions model so that API tokens don't have permission to create a new API token.\r\n - [x] Re-add error handling on actions\r\n - ~Warning before revocation~\r\n - [x] Resurrect user tests, add new token tests\r\n - [x] test `last_used_at` changes when using token\r\n</details>\r\n\r\n<details><summary><b>Screenshots</b></summary>\r\n\r\nThe settings page\r\n\r\n\r\nCreating a new token\r\n\r\n\r\nShowing the newly created token\r\n\r\n\r\n</details>","created_at":"2017-05-01T14:03:33Z","updated_at":"2017-06-18T19:59:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c897c73a6d7125395db901d9dc10413b7cdd259b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/crates.io/pulls/697/commits","review_comments_url":"https://api.github.com/repos/rust-lang/crates.io/pulls/697/comments","review_comment_url":"https://api.github.com/repos/rust-lang/crates.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/crates.io/issues/697/comments","statuses_url":"https://api.github.com/repos/rust-lang/crates.io/statuses/1ede604003ac904efec2471a1f9b2fe7151daa94","head":{"label":"Nemo157:multi-token","ref":"multi-token","sha":"1ede604003ac904efec2471a1f9b2fe7151daa94","user":{"login":"Nemo157","id":81079,"avatar_url":"https://avatars2.githubusercontent.com/u/81079?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"repo":{"id":80983669,"name":"crates.io","full_name":"Nemo157/crates.io","owner":{"login":"Nemo157","id":81079,"avatar_url":"https://avatars2.githubusercontent.com/u/81079?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nemo157/crates.io","description":"Source code for crates.io","fork":true,"url":"https://api.github.com/repos/Nemo157/crates.io","forks_url":"https://api.github.com/repos/Nemo157/crates.io/forks","keys_url":"https://api.github.com/repos/Nemo157/crates.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nemo157/crates.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nemo157/crates.io/teams","hooks_url":"https://api.github.com/repos/Nemo157/crates.io/hooks","issue_events_url":"https://api.github.com/repos/Nemo157/crates.io/issues/events{/number}","events_url":"https://api.github.com/repos/Nemo157/crates.io/events","assignees_url":"https://api.github.com/repos/Nemo157/crates.io/assignees{/user}","branches_url":"https://api.github.com/repos/Nemo157/crates.io/branches{/branch}","tags_url":"https://api.github.com/repos/Nemo157/crates.io/tags","blobs_url":"https://api.github.com/repos/Nemo157/crates.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nemo157/crates.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nemo157/crates.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nemo157/crates.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nemo157/crates.io/statuses/{sha}","languages_url":"https://api.github.com/repos/Nemo157/crates.io/languages","stargazers_url":"https://api.github.com/repos/Nemo157/crates.io/stargazers","contributors_url":"https://api.github.com/repos/Nemo157/crates.io/contributors","subscribers_url":"https://api.github.com/repos/Nemo157/crates.io/subscribers","subscription_url":"https://api.github.com/repos/Nemo157/crates.io/subscription","commits_url":"https://api.github.com/repos/Nemo157/crates.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nemo157/crates.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nemo157/crates.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nemo157/crates.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nemo157/crates.io/contents/{+path}","compare_url":"https://api.github.com/repos/Nemo157/crates.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nemo157/crates.io/merges","archive_url":"https://api.github.com/repos/Nemo157/crates.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nemo157/crates.io/downloads","issues_url":"https://api.github.com/repos/Nemo157/crates.io/issues{/number}","pulls_url":"https://api.github.com/repos/Nemo157/crates.io/pulls{/number}","milestones_url":"https://api.github.com/repos/Nemo157/crates.io/milestones{/number}","notifications_url":"https://api.github.com/repos/Nemo157/crates.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nemo157/crates.io/labels{/name}","releases_url":"https://api.github.com/repos/Nemo157/crates.io/releases{/id}","deployments_url":"https://api.github.com/repos/Nemo157/crates.io/deployments","created_at":"2017-02-05T09:48:12Z","updated_at":"2017-02-05T09:48:14Z","pushed_at":"2017-06-18T16:49:28Z","git_url":"git://github.com/Nemo157/crates.io.git","ssh_url":"[email protected]:Nemo157/crates.io.git","clone_url":"https://github.com/Nemo157/crates.io.git","svn_url":"https://github.com/Nemo157/crates.io","homepage":"https://crates.io","size":3164,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"0e04d1d665a15855933b6e877f644f3770980632","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars2.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21365581,"name":"crates.io","full_name":"rust-lang/crates.io","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars2.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/crates.io","description":"Source code for crates.io","fork":false,"url":"https://api.github.com/repos/rust-lang/crates.io","forks_url":"https://api.github.com/repos/rust-lang/crates.io/forks","keys_url":"https://api.github.com/repos/rust-lang/crates.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/crates.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/crates.io/teams","hooks_url":"https://api.github.com/repos/rust-lang/crates.io/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/crates.io/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/crates.io/events","assignees_url":"https://api.github.com/repos/rust-lang/crates.io/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/crates.io/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/crates.io/tags","blobs_url":"https://api.github.com/repos/rust-lang/crates.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/crates.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/crates.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/crates.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/crates.io/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/crates.io/languages","stargazers_url":"https://api.github.com/repos/rust-lang/crates.io/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/crates.io/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/crates.io/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/crates.io/subscription","commits_url":"https://api.github.com/repos/rust-lang/crates.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/crates.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/crates.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/crates.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/crates.io/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/crates.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/crates.io/merges","archive_url":"https://api.github.com/repos/rust-lang/crates.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/crates.io/downloads","issues_url":"https://api.github.com/repos/rust-lang/crates.io/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/crates.io/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/crates.io/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/crates.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/crates.io/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/crates.io/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/crates.io/deployments","created_at":"2014-06-30T20:53:49Z","updated_at":"2017-06-14T16:09:00Z","pushed_at":"2017-06-18T16:49:29Z","git_url":"git://github.com/rust-lang/crates.io.git","ssh_url":"[email protected]:rust-lang/crates.io.git","clone_url":"https://github.com/rust-lang/crates.io.git","svn_url":"https://github.com/rust-lang/crates.io","homepage":"https://crates.io","size":3250,"stargazers_count":541,"watchers_count":541,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":148,"forks":151,"open_issues":148,"watchers":541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/crates.io/pulls/697"},"html":{"href":"https://github.com/rust-lang/crates.io/pull/697"},"issue":{"href":"https://api.github.com/repos/rust-lang/crates.io/issues/697"},"comments":{"href":"https://api.github.com/repos/rust-lang/crates.io/issues/697/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/crates.io/pulls/697/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/crates.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/crates.io/pulls/697/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/crates.io/statuses/1ede604003ac904efec2471a1f9b2fe7151daa94"}}}} | {
"id": 21365581,
"name": "rust-lang/crates.io",
"url": "https://api.github.com/repos/rust-lang/crates.io"
} | {
"id": 1529387,
"login": "sgrif",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1529387?",
"url": "https://api.github.com/users/sgrif"
} | {
"id": 5430905,
"login": "rust-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5430905?",
"url": "https://api.github.com/orgs/rust-lang"
} | 2017-06-18T19:59:39 | 6088238375 | {"actor":{"display_login":"sgrif"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/118567539","pull_request_review_id":40372711,"id":118567539,"diff_hunk":"@@ -177,9 +177,22 @@ pub fn lookup_host(host: &str) -> io::Result<LookupHost> {\n };\n let mut res = ptr::null_mut();\n unsafe {\n- cvt_gai(c::getaddrinfo(c_host.as_ptr(), ptr::null(), &hints,\n- &mut res))?;\n- Ok(LookupHost { original: res, cur: res })\n+ match cvt_gai(c::getaddrinfo(c_host.as_ptr(), ptr::null(), &hints, &mut res)) {\n+ Ok(_) => {\n+ Ok(LookupHost { original: res, cur: res })\n+ },\n+ #[cfg(unix)]\n+ Err(e) => {\n+ // The lookup failure could be caused by using a stale /etc/resolv.conf.\n+ // See https://github.com/rust-lang/rust/issues/41570.\n+ // We therefore force a reload of the nameserver information.\n+ c::res_init();","path":"src/libstd/sys_common/net.rs","position":16,"original_position":16,"commit_id":"68ae6173fea7411a5d9e5bde6624f5606caf8fe8","original_commit_id":"68ae6173fea7411a5d9e5bde6624f5606caf8fe8","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars3.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"> Though if the resolution happens successfully, what is the problem?\r\n\r\nPlaying devil's advocate, \"successful\" doesn't imply \"correct\".\r\n\r\n> We could always call res_init, but that seems a little wasteful.\r\n\r\nHow wasteful? Perhaps this is worth measuring.\r\n\r\n> The real solution to this is to fix libc (most libcs do not have this problem — glibc is the major exception).\r\n\r\nWhat do you mean? What would \"fixing\" libc look like? What do other libcs do in contrast to glibc?","created_at":"2017-05-25T19:40:42Z","updated_at":"2017-05-25T19:40:43Z","html_url":"https://github.com/rust-lang/rust/pull/41582#discussion_r118567539","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/41582","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/118567539"},"html":{"href":"https://github.com/rust-lang/rust/pull/41582#discussion_r118567539"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/41582"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/41582","id":117986734,"html_url":"https://github.com/rust-lang/rust/pull/41582","diff_url":"https://github.com/rust-lang/rust/pull/41582.diff","patch_url":"https://github.com/rust-lang/rust/pull/41582.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/41582","number":41582,"state":"closed","locked":false,"title":"Reload nameserver information on lookup failure","user":{"login":"jonhoo","id":176295,"avatar_url":"https://avatars1.githubusercontent.com/u/176295?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"body":"As discussed in #41570, UNIX systems often cache the contents of `/etc/resolv.conf`, which can cause lookup failures to persist even after a network connection becomes available. This patch modifies lookup_host to force a reload of the nameserver entries following a lookup failure. This is in line with what many C programs already do (see #41570 for details). On systems with nscd, this should not be necessary, but not all systems run nscd.\r\n\r\nFixes #41570.\r\nDepends on rust-lang/libc#585.\r\n\r\nr? @alexcrichton","created_at":"2017-04-27T17:03:44Z","updated_at":"2017-05-25T19:40:43Z","closed_at":"2017-05-06T01:46:43Z","merged_at":"2017-05-06T01:46:43Z","merge_commit_sha":"68ae6173fea7411a5d9e5bde6624f5606caf8fe8","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars2.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars2.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/41582/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/41582/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/41582/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/68ae6173fea7411a5d9e5bde6624f5606caf8fe8","head":{"label":"jonhoo:reread-nameservers-on-lookup-fail","ref":"reread-nameservers-on-lookup-fail","sha":"68ae6173fea7411a5d9e5bde6624f5606caf8fe8","user":{"login":"jonhoo","id":176295,"avatar_url":"https://avatars1.githubusercontent.com/u/176295?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"repo":{"id":76220079,"name":"rust","full_name":"jonhoo/rust","owner":{"login":"jonhoo","id":176295,"avatar_url":"https://avatars1.githubusercontent.com/u/176295?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonhoo/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/jonhoo/rust","forks_url":"https://api.github.com/repos/jonhoo/rust/forks","keys_url":"https://api.github.com/repos/jonhoo/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonhoo/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonhoo/rust/teams","hooks_url":"https://api.github.com/repos/jonhoo/rust/hooks","issue_events_url":"https://api.github.com/repos/jonhoo/rust/issues/events{/number}","events_url":"https://api.github.com/repos/jonhoo/rust/events","assignees_url":"https://api.github.com/repos/jonhoo/rust/assignees{/user}","branches_url":"https://api.github.com/repos/jonhoo/rust/branches{/branch}","tags_url":"https://api.github.com/repos/jonhoo/rust/tags","blobs_url":"https://api.github.com/repos/jonhoo/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonhoo/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonhoo/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonhoo/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonhoo/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/jonhoo/rust/languages","stargazers_url":"https://api.github.com/repos/jonhoo/rust/stargazers","contributors_url":"https://api.github.com/repos/jonhoo/rust/contributors","subscribers_url":"https://api.github.com/repos/jonhoo/rust/subscribers","subscription_url":"https://api.github.com/repos/jonhoo/rust/subscription","commits_url":"https://api.github.com/repos/jonhoo/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonhoo/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonhoo/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonhoo/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonhoo/rust/contents/{+path}","compare_url":"https://api.github.com/repos/jonhoo/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonhoo/rust/merges","archive_url":"https://api.github.com/repos/jonhoo/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonhoo/rust/downloads","issues_url":"https://api.github.com/repos/jonhoo/rust/issues{/number}","pulls_url":"https://api.github.com/repos/jonhoo/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/jonhoo/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/jonhoo/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonhoo/rust/labels{/name}","releases_url":"https://api.github.com/repos/jonhoo/rust/releases{/id}","deployments_url":"https://api.github.com/repos/jonhoo/rust/deployments","created_at":"2016-12-12T03:49:06Z","updated_at":"2016-12-12T03:49:25Z","pushed_at":"2017-05-09T16:16:00Z","git_url":"git://github.com/jonhoo/rust.git","ssh_url":"[email protected]:jonhoo/rust.git","clone_url":"https://github.com/jonhoo/rust.git","svn_url":"https://github.com/jonhoo/rust","homepage":"https://www.rust-lang.org","size":308685,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"50b98587180a44782b22cbde1f638b61193ef7a3","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars2.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars2.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-05-25T18:10:20Z","pushed_at":"2017-05-25T18:56:08Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"[email protected]:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":311079,"stargazers_count":21944,"watchers_count":21944,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4077,"mirror_url":null,"open_issues_count":2800,"forks":4077,"open_issues":2800,"watchers":21944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/41582"},"html":{"href":"https://github.com/rust-lang/rust/pull/41582"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/41582"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/41582/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/41582/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/41582/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/68ae6173fea7411a5d9e5bde6624f5606caf8fe8"}}}} | {
"id": 724712,
"name": "rust-lang/rust",
"url": "https://api.github.com/repos/rust-lang/rust"
} | {
"id": 1535036,
"login": "tamird",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1535036?",
"url": "https://api.github.com/users/tamird"
} | {
"id": 5430905,
"login": "rust-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5430905?",
"url": "https://api.github.com/orgs/rust-lang"
} | 2017-05-25T19:40:42 | 5944268304 | {"actor":{"display_login":"tamird"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/138245138","pull_request_review_id":62012727,"id":138245138,"diff_hunk":"@@ -786,9 +786,11 @@ impl<'tcx> CommonTypes<'tcx> {\n }\n }\n \n-/// The data structure to keep track of all the information that typechecker\n-/// generates so that so that it can be reused and doesn't have to be redone\n-/// later on.\n+/// The central data structure of the compiler. Keeps track of all the\n+/// information that typechecker generates so that so that it can be\n+/// reused and doesn't have to be redone later on.","path":"src/librustc/ty/context.rs","position":9,"original_position":9,"commit_id":"9443a19538b36a91e477fd9b5836816058bbb459","original_commit_id":"9443a19538b36a91e477fd9b5836816058bbb459","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars1.githubusercontent.com/u/5076964?v=4","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"body":"nit: nothing after \"reused\" seems to add anything.","created_at":"2017-09-12T03:34:32Z","updated_at":"2017-09-12T03:35:50Z","html_url":"https://github.com/rust-lang/rust/pull/44505#discussion_r138245138","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/44505","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/138245138"},"html":{"href":"https://github.com/rust-lang/rust/pull/44505#discussion_r138245138"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44505"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/44505","id":140428066,"html_url":"https://github.com/rust-lang/rust/pull/44505","diff_url":"https://github.com/rust-lang/rust/pull/44505.diff","patch_url":"https://github.com/rust-lang/rust/pull/44505.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/44505","number":44505,"state":"open","locked":false,"title":"[WIP] rework the README.md for rustc and add other readmes","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"OK, so, long ago I committed to the idea of trying to write some high-level documentation for rustc. This has proved to be much harder for me to get done than I thought it would! This PR is far from as complete as I had hoped, but I wanted to open it so that people can give me feedback on the conventions that it establishes. If this seems like a good way forward, we can land it and I will open an issue with a good check-list of things to write (and try to take down some of them myself).\r\n\r\nHere are the conventions I established on which I would like feedback.\r\n\r\n**Use README.md files**. First off, I'm aiming to keep most of the high-level docs in `README.md` files, rather than entries on forge. My thought is that such files are (a) more discoverable than forge and (b) closer to the code, and hence can be edited in a single PR. However, since they are not *in the code*, they will naturally get out of date, so the intention is to focus on the highest-level details, which are least likely to bitrot. I've included a few examples of common functions and so forth, but never tried to (e.g.) exhaustively list the names of functions and so forth.\r\n - I would like to use the tidy scripts to try and check that these do not go out of date. Future work.\r\n\r\n**librustc/README.md as the main entrypoint.** This seems like the most natural place people will look first. It lays out how the crates are structured and **is intended** to give pointers to the main data structures of the compiler (I didn't update that yet; the existing material is terribly dated).\r\n\r\n**A glossary listing abbreviations and things.** It's much harder to read code if you don't know what some obscure set of letters like `infcx` stands for.\r\n\r\n**Major modules each have their own README.md that documents the high-level idea.** For example, I wrote some stuff about `hir` and `ty`. Both of them have many missing topics, but I think that is roughly the level of depth that would be good. The idea is to give people a \"feeling\" for what the code does.\r\n\r\nWhat is missing primarily here is lots of content. =) Here are some things I'd like to see:\r\n\r\n- A description of what a QUERY is and how to define one\r\n - Some comments for `librustc/ty/maps.rs`\r\n- An overview of how compilation proceeds now (i.e., the hybrid demand-driven and forward model) and how we would like to see it going in the future (all demand-driven)\r\n- Some coverage of how incremental will work under red-green\r\n- An updated list of the major IRs in use of the compiler (AST, HIR, TypeckTables, MIR) and major bits of interesting code (typeck, borrowck, etc)\r\n- More advice on how to use `x.py`, or at least pointers to that\r\n- Good choice for `config.toml`\r\n- How to use `RUST_LOG` and other debugging flags (e.g., `-Zverbose`, `-Ztreat-err-as-bug`)\r\n- Helpful conventions for `debug!` statement formatting\r\n\r\ncc @rust-lang/compiler @mgattozzi ","created_at":"2017-09-11T20:29:32Z","updated_at":"2017-09-12T03:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"358d008e6192d48297a205769d0ba43fe289438d","assignee":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars2.githubusercontent.com/u/27786?v=4","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"assignees":[{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars2.githubusercontent.com/u/27786?v=4","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/44505/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/44505/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/44505/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/9443a19538b36a91e477fd9b5836816058bbb459","head":{"label":"nikomatsakis:lotsa-comments","ref":"lotsa-comments","sha":"9443a19538b36a91e477fd9b5836816058bbb459","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"repo":{"id":1672543,"name":"rust","full_name":"nikomatsakis/rust","owner":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikomatsakis/rust","description":"A work-in-progress programming language; not yet suitable for users","fork":true,"url":"https://api.github.com/repos/nikomatsakis/rust","forks_url":"https://api.github.com/repos/nikomatsakis/rust/forks","keys_url":"https://api.github.com/repos/nikomatsakis/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikomatsakis/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikomatsakis/rust/teams","hooks_url":"https://api.github.com/repos/nikomatsakis/rust/hooks","issue_events_url":"https://api.github.com/repos/nikomatsakis/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nikomatsakis/rust/events","assignees_url":"https://api.github.com/repos/nikomatsakis/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nikomatsakis/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nikomatsakis/rust/tags","blobs_url":"https://api.github.com/repos/nikomatsakis/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikomatsakis/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikomatsakis/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikomatsakis/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikomatsakis/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nikomatsakis/rust/languages","stargazers_url":"https://api.github.com/repos/nikomatsakis/rust/stargazers","contributors_url":"https://api.github.com/repos/nikomatsakis/rust/contributors","subscribers_url":"https://api.github.com/repos/nikomatsakis/rust/subscribers","subscription_url":"https://api.github.com/repos/nikomatsakis/rust/subscription","commits_url":"https://api.github.com/repos/nikomatsakis/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikomatsakis/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikomatsakis/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikomatsakis/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikomatsakis/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nikomatsakis/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikomatsakis/rust/merges","archive_url":"https://api.github.com/repos/nikomatsakis/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikomatsakis/rust/downloads","issues_url":"https://api.github.com/repos/nikomatsakis/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nikomatsakis/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nikomatsakis/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nikomatsakis/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikomatsakis/rust/labels{/name}","releases_url":"https://api.github.com/repos/nikomatsakis/rust/releases{/id}","deployments_url":"https://api.github.com/repos/nikomatsakis/rust/deployments","created_at":"2011-04-27T20:20:29Z","updated_at":"2016-09-25T02:52:19Z","pushed_at":"2017-09-11T23:03:48Z","git_url":"git://github.com/nikomatsakis/rust.git","ssh_url":"[email protected]:nikomatsakis/rust.git","clone_url":"https://github.com/nikomatsakis/rust.git","svn_url":"https://github.com/nikomatsakis/rust","homepage":"","size":335232,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"efa3ec67e28ab8a4c3377a039095cd464713cdfd","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-09-11T23:31:17Z","pushed_at":"2017-09-12T01:46:24Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"[email protected]:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":325167,"stargazers_count":23394,"watchers_count":23394,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4286,"mirror_url":null,"open_issues_count":2852,"forks":4286,"open_issues":2852,"watchers":23394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44505"},"html":{"href":"https://github.com/rust-lang/rust/pull/44505"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/44505"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/44505/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44505/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44505/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/9443a19538b36a91e477fd9b5836816058bbb459"}},"author_association":"CONTRIBUTOR"}} | {
"id": 724712,
"name": "rust-lang/rust",
"url": "https://api.github.com/repos/rust-lang/rust"
} | {
"id": 5076964,
"login": "tschottdorf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5076964?",
"url": "https://api.github.com/users/tschottdorf"
} | {
"id": 5430905,
"login": "rust-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5430905?",
"url": "https://api.github.com/orgs/rust-lang"
} | 2017-09-12T03:34:32 | 6577830261 | {"actor":{"display_login":"tschottdorf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/155234227","pull_request_review_id":81518358,"id":155234227,"diff_hunk":"@@ -346,11 +339,93 @@ where\n comment(tcx, data.terminator().source_info),\n A = ALIGN,\n )?;\n+\n+ write_extra(tcx, w, |visitor| {\n+ visitor.visit_terminator(current_location.block, data.terminator(), current_location);\n+ })?;\n+\n extra_data(PassWhere::AfterLocation(current_location), w)?;\n \n writeln!(w, \"{}}}\", INDENT)\n }\n \n+/// After we print the main statement, we sometimes dump extra\n+/// information. There's often a lot of little things \"nuzzled up\" in\n+/// a statement.\n+fn write_extra<'cx, 'gcx, 'tcx, F>(\n+ tcx: TyCtxt<'cx, 'gcx, 'tcx>,\n+ write: &mut Write,\n+ mut visit_op: F,\n+) -> io::Result<()>\n+where F: FnMut(&mut ExtraComments<'cx, 'gcx, 'tcx>)\n+{\n+ let mut extra_comments = ExtraComments {\n+ _tcx: tcx,\n+ comments: vec![],\n+ };\n+ visit_op(&mut extra_comments);\n+ for comment in extra_comments.comments {\n+ writeln!(write, \"{:A$} // {}\", \"\", comment, A = ALIGN)?;\n+ }\n+ Ok(())\n+}\n+\n+struct ExtraComments<'cx, 'gcx: 'tcx, 'tcx: 'cx> {\n+ _tcx: TyCtxt<'cx, 'gcx, 'tcx>, // don't need it now, but bet we will soon\n+ comments: Vec<String>,\n+}\n+\n+impl<'cx, 'gcx, 'tcx> ExtraComments<'cx, 'gcx, 'tcx> {\n+ fn push(&mut self, lines: &str) {\n+ for line in lines.split(\"\\n\") {\n+ self.comments.push(line.to_string());\n+ }\n+ }\n+}\n+\n+impl<'cx, 'gcx, 'tcx> Visitor<'tcx> for ExtraComments<'cx, 'gcx, 'tcx> {\n+ fn visit_constant(&mut self, constant: &Constant<'tcx>, location: Location) {\n+ self.super_constant(constant, location);\n+ let Constant { span, ty, literal } = constant;\n+ self.push(&format!(\"mir::Constant\"));\n+ self.push(&format!(\"└ span: {:?}\", span));","path":"src/librustc_mir/util/pretty.rs","position":161,"original_position":124,"commit_id":"896ff93c2f58fad7e4affb946f5a0cb31e2b7a48","original_commit_id":"34864f79983c98a83ff71827582cebc9fa806418","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars0.githubusercontent.com/u/173127?v=4","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"body":"box characters! 😒 ","created_at":"2017-12-06T13:22:42Z","updated_at":"2017-12-06T13:22:42Z","html_url":"https://github.com/rust-lang/rust/pull/46509#discussion_r155234227","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/46509","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/155234227"},"html":{"href":"https://github.com/rust-lang/rust/pull/46509#discussion_r155234227"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/46509"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/46509","id":156348569,"html_url":"https://github.com/rust-lang/rust/pull/46509","diff_url":"https://github.com/rust-lang/rust/pull/46509.diff","patch_url":"https://github.com/rust-lang/rust/pull/46509.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/46509","number":46509,"state":"open","locked":false,"title":"closure handling for NLL","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"This branch overhauls how we handle closures and universally quantified regions in the NLL code. The goal is to lay the groundwork for \"region erasure\" by the HIR-based type checker, as well as to avoid \"crazy hacks\" when it comes to closures. This means that when we type-check a closure, we cannot make use of *any* of the precise values of free regions in its signature, since those are inferred by the HIR type-checker. Therefore, the new code handles closures by:\r\n\r\n- Creating fresh regions for every free region that appears in the closure's type, which now includes both its signature and the types of all upvars.\r\n - This means that the closure is type-checked without knowing about the connections.\r\n- When we encounter some region relationship that we can't locally verify, we propagate it to the closure's creator.\r\n- During MIR typeck, the closure creators then validates those relationships.\r\n\r\nFor a good example and explanation, see e.g. the test `src/test/nll/closure-requirements/propagate-despite-same-free-region.rs`.\r\n\r\nUpcoming changes in the next NLL PR (not included in this PR in order to keep it manageable):\r\n\r\n- Improvements to the MIR type checker so that it handles a lot of stuff presently overlooked\r\n- Refactor how we store region values to make it more efficient, better encapsulated\r\n- Propagate \"type-outlives\" relationships like `T: 'a` in a similar fashion to the one covered in this PR (still in the works, but close)\r\n- Improvements to error reporting (still in the works) \r\n\r\nr? @arielb1 or @pnkfelix ","created_at":"2017-12-05T01:14:06Z","updated_at":"2017-12-06T13:22:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51385326aadafd44654947ddaf7c94bb5f68dfc7","assignee":{"login":"arielb1","id":1830974,"avatar_url":"https://avatars1.githubusercontent.com/u/1830974?v=4","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false},"assignees":[{"login":"arielb1","id":1830974,"avatar_url":"https://avatars1.githubusercontent.com/u/1830974?v=4","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/46509/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/46509/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/46509/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/896ff93c2f58fad7e4affb946f5a0cb31e2b7a48","head":{"label":"nikomatsakis:nll-master-to-rust-master-3","ref":"nll-master-to-rust-master-3","sha":"896ff93c2f58fad7e4affb946f5a0cb31e2b7a48","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"repo":{"id":1672543,"name":"rust","full_name":"nikomatsakis/rust","owner":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikomatsakis/rust","description":"A work-in-progress programming language; not yet suitable for users","fork":true,"url":"https://api.github.com/repos/nikomatsakis/rust","forks_url":"https://api.github.com/repos/nikomatsakis/rust/forks","keys_url":"https://api.github.com/repos/nikomatsakis/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikomatsakis/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikomatsakis/rust/teams","hooks_url":"https://api.github.com/repos/nikomatsakis/rust/hooks","issue_events_url":"https://api.github.com/repos/nikomatsakis/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nikomatsakis/rust/events","assignees_url":"https://api.github.com/repos/nikomatsakis/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nikomatsakis/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nikomatsakis/rust/tags","blobs_url":"https://api.github.com/repos/nikomatsakis/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikomatsakis/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikomatsakis/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikomatsakis/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikomatsakis/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nikomatsakis/rust/languages","stargazers_url":"https://api.github.com/repos/nikomatsakis/rust/stargazers","contributors_url":"https://api.github.com/repos/nikomatsakis/rust/contributors","subscribers_url":"https://api.github.com/repos/nikomatsakis/rust/subscribers","subscription_url":"https://api.github.com/repos/nikomatsakis/rust/subscription","commits_url":"https://api.github.com/repos/nikomatsakis/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikomatsakis/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikomatsakis/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikomatsakis/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikomatsakis/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nikomatsakis/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikomatsakis/rust/merges","archive_url":"https://api.github.com/repos/nikomatsakis/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikomatsakis/rust/downloads","issues_url":"https://api.github.com/repos/nikomatsakis/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nikomatsakis/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nikomatsakis/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nikomatsakis/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikomatsakis/rust/labels{/name}","releases_url":"https://api.github.com/repos/nikomatsakis/rust/releases{/id}","deployments_url":"https://api.github.com/repos/nikomatsakis/rust/deployments","created_at":"2011-04-27T20:20:29Z","updated_at":"2017-11-11T20:34:33Z","pushed_at":"2017-12-06T11:31:28Z","git_url":"git://github.com/nikomatsakis/rust.git","ssh_url":"[email protected]:nikomatsakis/rust.git","clone_url":"https://github.com/nikomatsakis/rust.git","svn_url":"https://github.com/nikomatsakis/rust","homepage":"","size":347183,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"cd8a35299572c7d246cd9ab13d0d5c962aba053c","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-12-06T12:05:11Z","pushed_at":"2017-12-06T13:11:29Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"[email protected]:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":335953,"stargazers_count":25119,"watchers_count":25119,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4562,"mirror_url":null,"archived":false,"open_issues_count":3098,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4562,"open_issues":3098,"watchers":25119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/46509"},"html":{"href":"https://github.com/rust-lang/rust/pull/46509"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/46509"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/46509/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/46509/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/46509/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/896ff93c2f58fad7e4affb946f5a0cb31e2b7a48"}},"author_association":"CONTRIBUTOR"}} | {
"id": 724712,
"name": "rust-lang/rust",
"url": "https://api.github.com/repos/rust-lang/rust"
} | {
"id": 173127,
"login": "pnkfelix",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/173127?",
"url": "https://api.github.com/users/pnkfelix"
} | {
"id": 5430905,
"login": "rust-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5430905?",
"url": "https://api.github.com/orgs/rust-lang"
} | 2017-12-06T13:22:42 | 6951105893 | {"actor":{"display_login":"pnkfelix"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/146677300","pull_request_review_id":71654880,"id":146677300,"diff_hunk":"@@ -678,6 +715,23 @@ impl<'a, 'gcx, 'tcx> Builder<'a, 'gcx, 'tcx> {\n \n let arm_block = arm_blocks.blocks[candidate.arm_index];\n \n+ // link previously generated false edge to the enter block\n+ let dummy_source_info = self.source_info(DUMMY_SP);\n+ if let Some(imaginary_target) = opt_imaginary_target_block.take() {","path":"src/librustc_mir/build/matches/mod.rs","position":138,"original_position":138,"commit_id":"29c15d2d3f1402f8b655b64a4b233fe0667557cf","original_commit_id":"29c15d2d3f1402f8b655b64a4b233fe0667557cf","user":{"login":"arielb1","id":1830974,"avatar_url":"https://avatars1.githubusercontent.com/u/1830974?v=4","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false},"body":"~~I think it would be cleaner to use `mem::replace(opt_imaginary_target_block, Some(imaginary_target_block))` here","created_at":"2017-10-24T20:07:46Z","updated_at":"2017-10-24T20:07:46Z","html_url":"https://github.com/rust-lang/rust/pull/45384#discussion_r146677300","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/45384","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/146677300"},"html":{"href":"https://github.com/rust-lang/rust/pull/45384#discussion_r146677300"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/45384"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/45384","id":147578700,"html_url":"https://github.com/rust-lang/rust/pull/45384","diff_url":"https://github.com/rust-lang/rust/pull/45384.diff","patch_url":"https://github.com/rust-lang/rust/pull/45384.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/45384","number":45384,"state":"open","locked":false,"title":"add TerminatorKind::FalseEdges and use it in matches","user":{"login":"mikhail-m1","id":5663581,"avatar_url":"https://avatars1.githubusercontent.com/u/5663581?v=4","gravatar_id":"","url":"https://api.github.com/users/mikhail-m1","html_url":"https://github.com/mikhail-m1","followers_url":"https://api.github.com/users/mikhail-m1/followers","following_url":"https://api.github.com/users/mikhail-m1/following{/other_user}","gists_url":"https://api.github.com/users/mikhail-m1/gists{/gist_id}","starred_url":"https://api.github.com/users/mikhail-m1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikhail-m1/subscriptions","organizations_url":"https://api.github.com/users/mikhail-m1/orgs","repos_url":"https://api.github.com/users/mikhail-m1/repos","events_url":"https://api.github.com/users/mikhail-m1/events{/privacy}","received_events_url":"https://api.github.com/users/mikhail-m1/received_events","type":"User","site_admin":false},"body":"impl #45184 and fixes #45043 right way.\r\n\r\nFalse edges unexpectedly affects uninitialized variables analysis in MIR borrowck.\r\n\r\n","created_at":"2017-10-19T14:51:36Z","updated_at":"2017-10-24T20:07:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9293b1c166dde45a8dc8495eafa88437a3d454fb","assignee":{"login":"arielb1","id":1830974,"avatar_url":"https://avatars1.githubusercontent.com/u/1830974?v=4","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false},"assignees":[{"login":"arielb1","id":1830974,"avatar_url":"https://avatars1.githubusercontent.com/u/1830974?v=4","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/45384/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/45384/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/45384/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/29c15d2d3f1402f8b655b64a4b233fe0667557cf","head":{"label":"mikhail-m1:mir_add_false_edges_terminator_kind","ref":"mir_add_false_edges_terminator_kind","sha":"29c15d2d3f1402f8b655b64a4b233fe0667557cf","user":{"login":"mikhail-m1","id":5663581,"avatar_url":"https://avatars1.githubusercontent.com/u/5663581?v=4","gravatar_id":"","url":"https://api.github.com/users/mikhail-m1","html_url":"https://github.com/mikhail-m1","followers_url":"https://api.github.com/users/mikhail-m1/followers","following_url":"https://api.github.com/users/mikhail-m1/following{/other_user}","gists_url":"https://api.github.com/users/mikhail-m1/gists{/gist_id}","starred_url":"https://api.github.com/users/mikhail-m1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikhail-m1/subscriptions","organizations_url":"https://api.github.com/users/mikhail-m1/orgs","repos_url":"https://api.github.com/users/mikhail-m1/repos","events_url":"https://api.github.com/users/mikhail-m1/events{/privacy}","received_events_url":"https://api.github.com/users/mikhail-m1/received_events","type":"User","site_admin":false},"repo":{"id":65030333,"name":"rust","full_name":"mikhail-m1/rust","owner":{"login":"mikhail-m1","id":5663581,"avatar_url":"https://avatars1.githubusercontent.com/u/5663581?v=4","gravatar_id":"","url":"https://api.github.com/users/mikhail-m1","html_url":"https://github.com/mikhail-m1","followers_url":"https://api.github.com/users/mikhail-m1/followers","following_url":"https://api.github.com/users/mikhail-m1/following{/other_user}","gists_url":"https://api.github.com/users/mikhail-m1/gists{/gist_id}","starred_url":"https://api.github.com/users/mikhail-m1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikhail-m1/subscriptions","organizations_url":"https://api.github.com/users/mikhail-m1/orgs","repos_url":"https://api.github.com/users/mikhail-m1/repos","events_url":"https://api.github.com/users/mikhail-m1/events{/privacy}","received_events_url":"https://api.github.com/users/mikhail-m1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikhail-m1/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/mikhail-m1/rust","forks_url":"https://api.github.com/repos/mikhail-m1/rust/forks","keys_url":"https://api.github.com/repos/mikhail-m1/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikhail-m1/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikhail-m1/rust/teams","hooks_url":"https://api.github.com/repos/mikhail-m1/rust/hooks","issue_events_url":"https://api.github.com/repos/mikhail-m1/rust/issues/events{/number}","events_url":"https://api.github.com/repos/mikhail-m1/rust/events","assignees_url":"https://api.github.com/repos/mikhail-m1/rust/assignees{/user}","branches_url":"https://api.github.com/repos/mikhail-m1/rust/branches{/branch}","tags_url":"https://api.github.com/repos/mikhail-m1/rust/tags","blobs_url":"https://api.github.com/repos/mikhail-m1/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikhail-m1/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikhail-m1/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikhail-m1/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikhail-m1/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/mikhail-m1/rust/languages","stargazers_url":"https://api.github.com/repos/mikhail-m1/rust/stargazers","contributors_url":"https://api.github.com/repos/mikhail-m1/rust/contributors","subscribers_url":"https://api.github.com/repos/mikhail-m1/rust/subscribers","subscription_url":"https://api.github.com/repos/mikhail-m1/rust/subscription","commits_url":"https://api.github.com/repos/mikhail-m1/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikhail-m1/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikhail-m1/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikhail-m1/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikhail-m1/rust/contents/{+path}","compare_url":"https://api.github.com/repos/mikhail-m1/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikhail-m1/rust/merges","archive_url":"https://api.github.com/repos/mikhail-m1/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikhail-m1/rust/downloads","issues_url":"https://api.github.com/repos/mikhail-m1/rust/issues{/number}","pulls_url":"https://api.github.com/repos/mikhail-m1/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/mikhail-m1/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/mikhail-m1/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikhail-m1/rust/labels{/name}","releases_url":"https://api.github.com/repos/mikhail-m1/rust/releases{/id}","deployments_url":"https://api.github.com/repos/mikhail-m1/rust/deployments","created_at":"2016-08-05T15:44:28Z","updated_at":"2016-08-05T15:44:47Z","pushed_at":"2017-10-24T16:35:51Z","git_url":"git://github.com/mikhail-m1/rust.git","ssh_url":"[email protected]:mikhail-m1/rust.git","clone_url":"https://github.com/mikhail-m1/rust.git","svn_url":"https://github.com/mikhail-m1/rust","homepage":"https://www.rust-lang.org","size":327936,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"1babcd03934c9299b44f6a51a719434dae224e9d","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-10-24T19:35:14Z","pushed_at":"2017-10-24T20:02:46Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"[email protected]:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":330089,"stargazers_count":24118,"watchers_count":24118,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4434,"mirror_url":null,"archived":false,"open_issues_count":2992,"forks":4434,"open_issues":2992,"watchers":24118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/45384"},"html":{"href":"https://github.com/rust-lang/rust/pull/45384"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/45384"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/45384/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/45384/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/45384/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/29c15d2d3f1402f8b655b64a4b233fe0667557cf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 724712,
"name": "rust-lang/rust",
"url": "https://api.github.com/repos/rust-lang/rust"
} | {
"id": 1830974,
"login": "arielb1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1830974?",
"url": "https://api.github.com/users/arielb1"
} | {
"id": 5430905,
"login": "rust-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5430905?",
"url": "https://api.github.com/orgs/rust-lang"
} | 2017-10-24T20:07:46 | 6760298983 | {"actor":{"display_login":"arielb1"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/113776755","pull_request_review_id":35195179,"id":113776755,"diff_hunk":"@@ -177,9 +177,20 @@ pub fn lookup_host(host: &str) -> io::Result<LookupHost> {\n };\n let mut res = ptr::null_mut();\n unsafe {\n- cvt_gai(c::getaddrinfo(c_host.as_ptr(), ptr::null(), &hints,\n- &mut res))?;\n- Ok(LookupHost { original: res, cur: res })\n+ match cvt_gai(c::getaddrinfo(c_host.as_ptr(), ptr::null(), &hints, &mut res)) {\n+ Ok(_) => {\n+ Ok(LookupHost { original: res, cur: res })\n+ },\n+ Err(e) => {\n+ if cfg!(unix) {\n+ // The lookup failure could be caused by using a stale /etc/resolv.conf.\n+ // See https://github.com/rust-lang/rust/issues/41570.\n+ // We therefore force a reload of the nameserver information.\n+ c::res_init();","path":"src/libstd/sys_common/net.rs","position":16,"original_position":16,"commit_id":"14403ad1bac3fbc6c4d213c79f5b9bcd3bbc6a5c","original_commit_id":"14403ad1bac3fbc6c4d213c79f5b9bcd3bbc6a5c","user":{"login":"jonhoo","id":176295,"avatar_url":"https://avatars1.githubusercontent.com/u/176295?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"body":"That's what the `if cfg!(unix)` above was intended for?","created_at":"2017-04-27T19:01:33Z","updated_at":"2017-04-27T19:01:34Z","html_url":"https://github.com/rust-lang/rust/pull/41582#discussion_r113776755","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/41582","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/113776755"},"html":{"href":"https://github.com/rust-lang/rust/pull/41582#discussion_r113776755"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/41582"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/41582","id":117986734,"html_url":"https://github.com/rust-lang/rust/pull/41582","diff_url":"https://github.com/rust-lang/rust/pull/41582.diff","patch_url":"https://github.com/rust-lang/rust/pull/41582.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/41582","number":41582,"state":"open","locked":false,"title":"Reload nameserver information on lookup failure","user":{"login":"jonhoo","id":176295,"avatar_url":"https://avatars1.githubusercontent.com/u/176295?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"body":"As discussed in #41570, UNIX systems often cache the contents of `/etc/resolv.conf`, which can cause lookup failures to persist even after a network connection becomes available. This patch modifies lookup_host to force a reload of the nameserver entries following a lookup failure. This is in line with what many C programs already do (see #41570 for details). On systems with nscd, this should not be necessary, but not all systems run nscd.\r\n\r\nFixes #41570.\r\nDepends on rust-lang/libc#585.\r\n\r\nr? @alexcrichton","created_at":"2017-04-27T17:03:44Z","updated_at":"2017-04-27T19:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e570034861b516e3af6f07007a503ebb28648228","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars2.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars2.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/41582/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/41582/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/41582/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/14403ad1bac3fbc6c4d213c79f5b9bcd3bbc6a5c","head":{"label":"jonhoo:reread-nameservers-on-lookup-fail","ref":"reread-nameservers-on-lookup-fail","sha":"14403ad1bac3fbc6c4d213c79f5b9bcd3bbc6a5c","user":{"login":"jonhoo","id":176295,"avatar_url":"https://avatars1.githubusercontent.com/u/176295?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"repo":{"id":76220079,"name":"rust","full_name":"jonhoo/rust","owner":{"login":"jonhoo","id":176295,"avatar_url":"https://avatars1.githubusercontent.com/u/176295?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonhoo/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/jonhoo/rust","forks_url":"https://api.github.com/repos/jonhoo/rust/forks","keys_url":"https://api.github.com/repos/jonhoo/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonhoo/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonhoo/rust/teams","hooks_url":"https://api.github.com/repos/jonhoo/rust/hooks","issue_events_url":"https://api.github.com/repos/jonhoo/rust/issues/events{/number}","events_url":"https://api.github.com/repos/jonhoo/rust/events","assignees_url":"https://api.github.com/repos/jonhoo/rust/assignees{/user}","branches_url":"https://api.github.com/repos/jonhoo/rust/branches{/branch}","tags_url":"https://api.github.com/repos/jonhoo/rust/tags","blobs_url":"https://api.github.com/repos/jonhoo/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonhoo/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonhoo/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonhoo/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonhoo/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/jonhoo/rust/languages","stargazers_url":"https://api.github.com/repos/jonhoo/rust/stargazers","contributors_url":"https://api.github.com/repos/jonhoo/rust/contributors","subscribers_url":"https://api.github.com/repos/jonhoo/rust/subscribers","subscription_url":"https://api.github.com/repos/jonhoo/rust/subscription","commits_url":"https://api.github.com/repos/jonhoo/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonhoo/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonhoo/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonhoo/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonhoo/rust/contents/{+path}","compare_url":"https://api.github.com/repos/jonhoo/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonhoo/rust/merges","archive_url":"https://api.github.com/repos/jonhoo/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonhoo/rust/downloads","issues_url":"https://api.github.com/repos/jonhoo/rust/issues{/number}","pulls_url":"https://api.github.com/repos/jonhoo/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/jonhoo/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/jonhoo/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonhoo/rust/labels{/name}","releases_url":"https://api.github.com/repos/jonhoo/rust/releases{/id}","deployments_url":"https://api.github.com/repos/jonhoo/rust/deployments","created_at":"2016-12-12T03:49:06Z","updated_at":"2016-12-12T03:49:25Z","pushed_at":"2017-04-27T17:03:00Z","git_url":"git://github.com/jonhoo/rust.git","ssh_url":"[email protected]:jonhoo/rust.git","clone_url":"https://github.com/jonhoo/rust.git","svn_url":"https://github.com/jonhoo/rust","homepage":"https://www.rust-lang.org","size":307613,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"4961d724f8d02870087c1912a55378458b0d6a90","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars2.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars2.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-04-27T17:50:38Z","pushed_at":"2017-04-27T19:00:46Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"[email protected]:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":308361,"stargazers_count":21510,"watchers_count":21510,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4019,"mirror_url":null,"open_issues_count":3107,"forks":4019,"open_issues":3107,"watchers":21510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/41582"},"html":{"href":"https://github.com/rust-lang/rust/pull/41582"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/41582"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/41582/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/41582/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/41582/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/14403ad1bac3fbc6c4d213c79f5b9bcd3bbc6a5c"}}}} | {
"id": 724712,
"name": "rust-lang/rust",
"url": "https://api.github.com/repos/rust-lang/rust"
} | {
"id": 176295,
"login": "jonhoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/176295?",
"url": "https://api.github.com/users/jonhoo"
} | {
"id": 5430905,
"login": "rust-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5430905?",
"url": "https://api.github.com/orgs/rust-lang"
} | 2017-04-27T19:01:33 | 5771210398 | {"actor":{"display_login":"jonhoo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scalameta/language-server/pulls/comments/150389951","pull_request_review_id":75938452,"id":150389951,"diff_hunk":"@@ -0,0 +1,48 @@\n+package scala.meta.languageserver\n+\n+import org.langmeta.inputs.Input\n+\n+object Positions {\n+ def positionToOffset(\n+ input: Input.VirtualFile,\n+ line: Int,\n+ column: Int\n+ ): Int =\n+ positionToOffset(input.path, input.value, line, column)\n+\n+ def positionToOffset(\n+ filename: String,\n+ contents: String,\n+ line: Int,\n+ column: Int\n+ ): Int = {\n+ def peek(idx: Int): Int =\n+ if (idx < contents.length) contents.charAt(idx) else -1\n+ var i, l = 0\n+ while (i < contents.length && l < line) {\n+ contents.charAt(i) match {\n+ case '\\r' =>\n+ l += 1\n+ if (peek(i + 1) == '\\n') i += 1\n+\n+ case '\\n' =>\n+ l += 1\n+\n+ case _ =>\n+ }\n+ i += 1\n+ }\n+\n+ if (l < line)\n+ throw new IllegalArgumentException(\n+ s\"$filename: Can't find position $line:$column in contents of only $l lines long.\"\n+ )\n+ if (i + column < contents.length)\n+ i + column\n+ else\n+ throw new IllegalArgumentException(\n+ s\"$filename: Invalid column. Position $line:$column in line '${contents.slice(i, contents.length).mkString}'\"\n+ )\n+ }\n+\n+}","path":"metaserver/src/main/scala/scala/meta/languageserver/Positions.scala","position":48,"original_position":48,"commit_id":"01f51b33fbfbdb698ccbbf4c8bf5972121fad8b1","original_commit_id":"01f51b33fbfbdb698ccbbf4c8bf5972121fad8b1","user":{"login":"ShaneDelmore","id":4604933,"avatar_url":"https://avatars1.githubusercontent.com/u/4604933?v=4","gravatar_id":"","url":"https://api.github.com/users/ShaneDelmore","html_url":"https://github.com/ShaneDelmore","followers_url":"https://api.github.com/users/ShaneDelmore/followers","following_url":"https://api.github.com/users/ShaneDelmore/following{/other_user}","gists_url":"https://api.github.com/users/ShaneDelmore/gists{/gist_id}","starred_url":"https://api.github.com/users/ShaneDelmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShaneDelmore/subscriptions","organizations_url":"https://api.github.com/users/ShaneDelmore/orgs","repos_url":"https://api.github.com/users/ShaneDelmore/repos","events_url":"https://api.github.com/users/ShaneDelmore/events{/privacy}","received_events_url":"https://api.github.com/users/ShaneDelmore/received_events","type":"User","site_admin":false},"body":"An alternative suggestion in a completely different style. Nothing wrong with this one though if you want to keep it. Ignore my lack of filename in the IllegalArgumentExceptions, I just whipped this up in a worksheet.\r\n\r\n```scala\r\ndef pos(content: String, line: Int, col: Int): Int = {\r\n val (lineCount, pos) = content\r\n .linesWithSeparators\r\n .take(line + 1)\r\n .foldLeft((0, 0)){ (accum, str) =>\r\n val (lineNum, charCount) = accum\r\n if (lineNum < line) {\r\n (lineNum + 1, charCount + str.length)\r\n } else {\r\n require(str.length >= col, \"Line is not long enough\")\r\n (lineNum + 1, charCount + col)\r\n }\r\n }\r\n require(lineCount == line + 1, \"Not enough lines\")\r\n pos\r\n}\r\n```","created_at":"2017-11-11T18:22:49Z","updated_at":"2017-11-11T18:22:49Z","html_url":"https://github.com/scalameta/language-server/pull/23#discussion_r150389951","pull_request_url":"https://api.github.com/repos/scalameta/language-server/pulls/23","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/scalameta/language-server/pulls/comments/150389951"},"html":{"href":"https://github.com/scalameta/language-server/pull/23#discussion_r150389951"},"pull_request":{"href":"https://api.github.com/repos/scalameta/language-server/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/scalameta/language-server/pulls/23","id":151799266,"html_url":"https://github.com/scalameta/language-server/pull/23","diff_url":"https://github.com/scalameta/language-server/pull/23.diff","patch_url":"https://github.com/scalameta/language-server/pull/23.patch","issue_url":"https://api.github.com/repos/scalameta/language-server/issues/23","number":23,"state":"open","locked":false,"title":"Go to definition in classpath","user":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"body":"This PR implements a `Ctags` module that is able to build semanticdbs in source files in the classpath, without any compilation or analyzing classfiles. The ctags indexer uses the scalameta parser to find definitions of global symbols and record the positions. The ctags indexer is able to index ~30k lines/s from my informal benchmarks, which is totally bottlenecked by the parser (see https://github.com/scalameta/scalameta/issues/1130 for idea how to speed parsing by up to 40%). \r\n\r\nThere is still a lot of work to be done to polish the experience, in particular\r\n\r\n- we re-index the same jars over and over for every project/config in your build\r\n- I couldn't figure out how to jump to entries in jar files so I just write the files in `target/source/*.scala`, which is a total hack. Ideally we can open them in a readonly buffer.\r\n- we store the full file contents of all source files in the classpath in-memory. This goes against one the the core goals of this project, which is to keep memory usage as low as possible. \r\n\r\nI propose we leave these challenges for future PRs, since the changes in this PR are already quite big and these challenges can be parallelized.\r\n\r\n\r\n\r\n","created_at":"2017-11-10T00:32:02Z","updated_at":"2017-11-11T18:22:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0624bd0f2bcbb4fae58301779d3e010e51a764b2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gabro","id":691940,"avatar_url":"https://avatars0.githubusercontent.com/u/691940?v=4","gravatar_id":"","url":"https://api.github.com/users/gabro","html_url":"https://github.com/gabro","followers_url":"https://api.github.com/users/gabro/followers","following_url":"https://api.github.com/users/gabro/following{/other_user}","gists_url":"https://api.github.com/users/gabro/gists{/gist_id}","starred_url":"https://api.github.com/users/gabro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabro/subscriptions","organizations_url":"https://api.github.com/users/gabro/orgs","repos_url":"https://api.github.com/users/gabro/repos","events_url":"https://api.github.com/users/gabro/events{/privacy}","received_events_url":"https://api.github.com/users/gabro/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scalameta/language-server/pulls/23/commits","review_comments_url":"https://api.github.com/repos/scalameta/language-server/pulls/23/comments","review_comment_url":"https://api.github.com/repos/scalameta/language-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalameta/language-server/issues/23/comments","statuses_url":"https://api.github.com/repos/scalameta/language-server/statuses/01f51b33fbfbdb698ccbbf4c8bf5972121fad8b1","head":{"label":"olafurpg:classpath","ref":"classpath","sha":"01f51b33fbfbdb698ccbbf4c8bf5972121fad8b1","user":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"repo":{"id":109478459,"name":"language-server","full_name":"olafurpg/language-server","owner":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olafurpg/language-server","description":"WIP - Language Server Protocol for SemanticDB","fork":true,"url":"https://api.github.com/repos/olafurpg/language-server","forks_url":"https://api.github.com/repos/olafurpg/language-server/forks","keys_url":"https://api.github.com/repos/olafurpg/language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olafurpg/language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olafurpg/language-server/teams","hooks_url":"https://api.github.com/repos/olafurpg/language-server/hooks","issue_events_url":"https://api.github.com/repos/olafurpg/language-server/issues/events{/number}","events_url":"https://api.github.com/repos/olafurpg/language-server/events","assignees_url":"https://api.github.com/repos/olafurpg/language-server/assignees{/user}","branches_url":"https://api.github.com/repos/olafurpg/language-server/branches{/branch}","tags_url":"https://api.github.com/repos/olafurpg/language-server/tags","blobs_url":"https://api.github.com/repos/olafurpg/language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olafurpg/language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olafurpg/language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/olafurpg/language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olafurpg/language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/olafurpg/language-server/languages","stargazers_url":"https://api.github.com/repos/olafurpg/language-server/stargazers","contributors_url":"https://api.github.com/repos/olafurpg/language-server/contributors","subscribers_url":"https://api.github.com/repos/olafurpg/language-server/subscribers","subscription_url":"https://api.github.com/repos/olafurpg/language-server/subscription","commits_url":"https://api.github.com/repos/olafurpg/language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/olafurpg/language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/olafurpg/language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/olafurpg/language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/olafurpg/language-server/contents/{+path}","compare_url":"https://api.github.com/repos/olafurpg/language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olafurpg/language-server/merges","archive_url":"https://api.github.com/repos/olafurpg/language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olafurpg/language-server/downloads","issues_url":"https://api.github.com/repos/olafurpg/language-server/issues{/number}","pulls_url":"https://api.github.com/repos/olafurpg/language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/olafurpg/language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/olafurpg/language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olafurpg/language-server/labels{/name}","releases_url":"https://api.github.com/repos/olafurpg/language-server/releases{/id}","deployments_url":"https://api.github.com/repos/olafurpg/language-server/deployments","created_at":"2017-11-04T08:16:54Z","updated_at":"2017-11-05T17:19:42Z","pushed_at":"2017-11-11T18:12:52Z","git_url":"git://github.com/olafurpg/language-server.git","ssh_url":"[email protected]:olafurpg/language-server.git","clone_url":"https://github.com/olafurpg/language-server.git","svn_url":"https://github.com/olafurpg/language-server","homepage":"","size":287,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalameta:master","ref":"master","sha":"04ff21002da48ea293dbed9ad99efbb366198d0e","user":{"login":"scalameta","id":7526438,"avatar_url":"https://avatars1.githubusercontent.com/u/7526438?v=4","gravatar_id":"","url":"https://api.github.com/users/scalameta","html_url":"https://github.com/scalameta","followers_url":"https://api.github.com/users/scalameta/followers","following_url":"https://api.github.com/users/scalameta/following{/other_user}","gists_url":"https://api.github.com/users/scalameta/gists{/gist_id}","starred_url":"https://api.github.com/users/scalameta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalameta/subscriptions","organizations_url":"https://api.github.com/users/scalameta/orgs","repos_url":"https://api.github.com/users/scalameta/repos","events_url":"https://api.github.com/users/scalameta/events{/privacy}","received_events_url":"https://api.github.com/users/scalameta/received_events","type":"Organization","site_admin":false},"repo":{"id":109404123,"name":"language-server","full_name":"scalameta/language-server","owner":{"login":"scalameta","id":7526438,"avatar_url":"https://avatars1.githubusercontent.com/u/7526438?v=4","gravatar_id":"","url":"https://api.github.com/users/scalameta","html_url":"https://github.com/scalameta","followers_url":"https://api.github.com/users/scalameta/followers","following_url":"https://api.github.com/users/scalameta/following{/other_user}","gists_url":"https://api.github.com/users/scalameta/gists{/gist_id}","starred_url":"https://api.github.com/users/scalameta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalameta/subscriptions","organizations_url":"https://api.github.com/users/scalameta/orgs","repos_url":"https://api.github.com/users/scalameta/repos","events_url":"https://api.github.com/users/scalameta/events{/privacy}","received_events_url":"https://api.github.com/users/scalameta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalameta/language-server","description":"WIP - Language Server Protocol for SemanticDB","fork":false,"url":"https://api.github.com/repos/scalameta/language-server","forks_url":"https://api.github.com/repos/scalameta/language-server/forks","keys_url":"https://api.github.com/repos/scalameta/language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalameta/language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalameta/language-server/teams","hooks_url":"https://api.github.com/repos/scalameta/language-server/hooks","issue_events_url":"https://api.github.com/repos/scalameta/language-server/issues/events{/number}","events_url":"https://api.github.com/repos/scalameta/language-server/events","assignees_url":"https://api.github.com/repos/scalameta/language-server/assignees{/user}","branches_url":"https://api.github.com/repos/scalameta/language-server/branches{/branch}","tags_url":"https://api.github.com/repos/scalameta/language-server/tags","blobs_url":"https://api.github.com/repos/scalameta/language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalameta/language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalameta/language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalameta/language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalameta/language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/scalameta/language-server/languages","stargazers_url":"https://api.github.com/repos/scalameta/language-server/stargazers","contributors_url":"https://api.github.com/repos/scalameta/language-server/contributors","subscribers_url":"https://api.github.com/repos/scalameta/language-server/subscribers","subscription_url":"https://api.github.com/repos/scalameta/language-server/subscription","commits_url":"https://api.github.com/repos/scalameta/language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalameta/language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalameta/language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalameta/language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalameta/language-server/contents/{+path}","compare_url":"https://api.github.com/repos/scalameta/language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalameta/language-server/merges","archive_url":"https://api.github.com/repos/scalameta/language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalameta/language-server/downloads","issues_url":"https://api.github.com/repos/scalameta/language-server/issues{/number}","pulls_url":"https://api.github.com/repos/scalameta/language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/scalameta/language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/scalameta/language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalameta/language-server/labels{/name}","releases_url":"https://api.github.com/repos/scalameta/language-server/releases{/id}","deployments_url":"https://api.github.com/repos/scalameta/language-server/deployments","created_at":"2017-11-03T14:18:53Z","updated_at":"2017-11-10T20:35:38Z","pushed_at":"2017-11-11T18:12:54Z","git_url":"git://github.com/scalameta/language-server.git","ssh_url":"[email protected]:scalameta/language-server.git","clone_url":"https://github.com/scalameta/language-server.git","svn_url":"https://github.com/scalameta/language-server","homepage":"","size":253,"stargazers_count":8,"watchers_count":8,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalameta/language-server/pulls/23"},"html":{"href":"https://github.com/scalameta/language-server/pull/23"},"issue":{"href":"https://api.github.com/repos/scalameta/language-server/issues/23"},"comments":{"href":"https://api.github.com/repos/scalameta/language-server/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/scalameta/language-server/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/scalameta/language-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalameta/language-server/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/scalameta/language-server/statuses/01f51b33fbfbdb698ccbbf4c8bf5972121fad8b1"}},"author_association":"OWNER"}} | {
"id": 109404123,
"name": "scalameta/language-server",
"url": "https://api.github.com/repos/scalameta/language-server"
} | {
"id": 4604933,
"login": "ShaneDelmore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4604933?",
"url": "https://api.github.com/users/ShaneDelmore"
} | {
"id": 7526438,
"login": "scalameta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7526438?",
"url": "https://api.github.com/orgs/scalameta"
} | 2017-11-11T18:22:49 | 6841852948 | {"actor":{"display_login":"ShaneDelmore"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/comments/112544516","pull_request_review_id":33868715,"id":112544516,"diff_hunk":"@@ -197,7 +197,7 @@ public Stage preceding(String type) {\n * Maps the stage's context to a typed object at a provided pointer. Uses\n * <a href=\"https://tools.ietf.org/html/rfc6901\">JSON Pointer</a> notation for determining the pointer's position\n */\n- <O> O mapTo(String pointer, Class<O> type) {\n+ public <O> O mapTo(String pointer, Class<O> type) {","path":"orca-core/src/main/groovy/com/netflix/spinnaker/orca/pipeline/model/Stage.java","position":5,"original_position":5,"commit_id":"a2474a34e5f3b4e6ea40c725889e1c8602590754","original_commit_id":"a2474a34e5f3b4e6ea40c725889e1c8602590754","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars3.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"@robfletcher We have a number of callers to this ... they were still working \"because groovy\"","created_at":"2017-04-20T19:47:53Z","updated_at":"2017-04-20T19:50:22Z","html_url":"https://github.com/spinnaker/orca/pull/1290#discussion_r112544516","pull_request_url":"https://api.github.com/repos/spinnaker/orca/pulls/1290","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments/112544516"},"html":{"href":"https://github.com/spinnaker/orca/pull/1290#discussion_r112544516"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1290"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/1290","id":116850008,"html_url":"https://github.com/spinnaker/orca/pull/1290","diff_url":"https://github.com/spinnaker/orca/pull/1290.diff","patch_url":"https://github.com/spinnaker/orca/pull/1290.patch","issue_url":"https://api.github.com/repos/spinnaker/orca/issues/1290","number":1290,"state":"open","locked":false,"title":"Pin `min` capacity to `desired` capacity when rolling back","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars3.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"This prevents the target server group from unnecessarily scaling down\r\nand causing the rollback to timeout / take far longer than expected.\r\n\r\n`min` capacity is restored when the rollback is complete.","created_at":"2017-04-20T19:47:26Z","updated_at":"2017-04-20T19:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96b51c478d960a64f2d111624a8dc0c31d789255","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/orca/pulls/1290/commits","review_comments_url":"https://api.github.com/repos/spinnaker/orca/pulls/1290/comments","review_comment_url":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/orca/issues/1290/comments","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/a2474a34e5f3b4e6ea40c725889e1c8602590754","head":{"label":"ajordens:pin-capacity-for-rollback","ref":"pin-capacity-for-rollback","sha":"a2474a34e5f3b4e6ea40c725889e1c8602590754","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars3.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"repo":{"id":68033071,"name":"orca","full_name":"ajordens/orca","owner":{"login":"ajordens","id":388652,"avatar_url":"https://avatars3.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajordens/orca","description":"orchestration engine","fork":true,"url":"https://api.github.com/repos/ajordens/orca","forks_url":"https://api.github.com/repos/ajordens/orca/forks","keys_url":"https://api.github.com/repos/ajordens/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajordens/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajordens/orca/teams","hooks_url":"https://api.github.com/repos/ajordens/orca/hooks","issue_events_url":"https://api.github.com/repos/ajordens/orca/issues/events{/number}","events_url":"https://api.github.com/repos/ajordens/orca/events","assignees_url":"https://api.github.com/repos/ajordens/orca/assignees{/user}","branches_url":"https://api.github.com/repos/ajordens/orca/branches{/branch}","tags_url":"https://api.github.com/repos/ajordens/orca/tags","blobs_url":"https://api.github.com/repos/ajordens/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajordens/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajordens/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajordens/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajordens/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/ajordens/orca/languages","stargazers_url":"https://api.github.com/repos/ajordens/orca/stargazers","contributors_url":"https://api.github.com/repos/ajordens/orca/contributors","subscribers_url":"https://api.github.com/repos/ajordens/orca/subscribers","subscription_url":"https://api.github.com/repos/ajordens/orca/subscription","commits_url":"https://api.github.com/repos/ajordens/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajordens/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajordens/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajordens/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajordens/orca/contents/{+path}","compare_url":"https://api.github.com/repos/ajordens/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajordens/orca/merges","archive_url":"https://api.github.com/repos/ajordens/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajordens/orca/downloads","issues_url":"https://api.github.com/repos/ajordens/orca/issues{/number}","pulls_url":"https://api.github.com/repos/ajordens/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/ajordens/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/ajordens/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajordens/orca/labels{/name}","releases_url":"https://api.github.com/repos/ajordens/orca/releases{/id}","deployments_url":"https://api.github.com/repos/ajordens/orca/deployments","created_at":"2016-09-12T17:49:08Z","updated_at":"2016-09-12T17:49:14Z","pushed_at":"2017-04-20T19:45:40Z","git_url":"git://github.com/ajordens/orca.git","ssh_url":"[email protected]:ajordens/orca.git","clone_url":"https://github.com/ajordens/orca.git","svn_url":"https://github.com/ajordens/orca","homepage":"","size":7408,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"acf03f4308f2afb343c038c1cf2fe448420730f7","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars2.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":19834314,"name":"orca","full_name":"spinnaker/orca","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars2.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/orca","description":"orchestration engine","fork":false,"url":"https://api.github.com/repos/spinnaker/orca","forks_url":"https://api.github.com/repos/spinnaker/orca/forks","keys_url":"https://api.github.com/repos/spinnaker/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/orca/teams","hooks_url":"https://api.github.com/repos/spinnaker/orca/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/orca/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/orca/events","assignees_url":"https://api.github.com/repos/spinnaker/orca/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/orca/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/orca/tags","blobs_url":"https://api.github.com/repos/spinnaker/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/orca/languages","stargazers_url":"https://api.github.com/repos/spinnaker/orca/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/orca/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/orca/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/orca/subscription","commits_url":"https://api.github.com/repos/spinnaker/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/orca/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/orca/merges","archive_url":"https://api.github.com/repos/spinnaker/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/orca/downloads","issues_url":"https://api.github.com/repos/spinnaker/orca/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/orca/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/orca/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/orca/deployments","created_at":"2014-05-15T20:33:00Z","updated_at":"2017-04-18T16:53:35Z","pushed_at":"2017-04-20T19:47:27Z","git_url":"git://github.com/spinnaker/orca.git","ssh_url":"[email protected]:spinnaker/orca.git","clone_url":"https://github.com/spinnaker/orca.git","svn_url":"https://github.com/spinnaker/orca","homepage":"","size":8295,"stargazers_count":44,"watchers_count":44,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":50,"forks":90,"open_issues":50,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1290"},"html":{"href":"https://github.com/spinnaker/orca/pull/1290"},"issue":{"href":"https://api.github.com/repos/spinnaker/orca/issues/1290"},"comments":{"href":"https://api.github.com/repos/spinnaker/orca/issues/1290/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1290/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1290/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/orca/statuses/a2474a34e5f3b4e6ea40c725889e1c8602590754"}}}} | {
"id": 19834314,
"name": "spinnaker/orca",
"url": "https://api.github.com/repos/spinnaker/orca"
} | {
"id": 388652,
"login": "ajordens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/388652?",
"url": "https://api.github.com/users/ajordens"
} | {
"id": 7634182,
"login": "spinnaker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7634182?",
"url": "https://api.github.com/orgs/spinnaker"
} | 2017-04-20T19:47:53 | 5726803511 | {"actor":{"display_login":"ajordens"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/comments/98845012","pull_request_review_id":19499073,"id":98845012,"diff_hunk":"@@ -35,12 +36,23 @@ class CreateServerGroupStage extends AbstractDeployStrategyStage {\n \n @Override\n protected List<TaskNode.TaskDefinition> basicTasks(Stage stage) {\n- return [\n+ def tasks = [\n new TaskNode.TaskDefinition(\"createServerGroup\", CreateServerGroupTask),\n new TaskNode.TaskDefinition(\"monitorDeploy\", MonitorKatoTask),\n new TaskNode.TaskDefinition(\"forceCacheRefresh\", ServerGroupCacheForceRefreshTask),\n+ ]\n+\n+ if (true) {","path":"orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/pipeline/servergroup/CreateServerGroupStage.groovy","position":19,"original_position":19,"commit_id":"209dae9fde14932b6fef620132191c1fca4f92f4","original_commit_id":"209dae9fde14932b6fef620132191c1fca4f92f4","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"@anotherchrisberry This should check the `/features/stages` endpoint in clouddriver and only add the `tagServerGroup` task if the `upsertEntityTags` stage is enabled.\r\n\r\nThe `if (true)` was just a quick hack used to test.","created_at":"2017-02-01T08:23:19Z","updated_at":"2017-02-01T08:25:29Z","html_url":"https://github.com/spinnaker/orca/pull/1151#discussion_r98845012","pull_request_url":"https://api.github.com/repos/spinnaker/orca/pulls/1151","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments/98845012"},"html":{"href":"https://github.com/spinnaker/orca/pull/1151#discussion_r98845012"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1151"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/1151","id":104091699,"html_url":"https://github.com/spinnaker/orca/pull/1151","diff_url":"https://github.com/spinnaker/orca/pull/1151.diff","patch_url":"https://github.com/spinnaker/orca/pull/1151.patch","issue_url":"https://api.github.com/repos/spinnaker/orca/issues/1151","number":1151,"state":"open","locked":false,"title":"Support tagging of server groups when created / cloned","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"- requires that the 'upsertEntityTags' operation is available in clouddriver","created_at":"2017-02-01T08:20:05Z","updated_at":"2017-02-01T08:25:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f89c86f0215137d8d38c52330d45b56d15923f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/orca/pulls/1151/commits","review_comments_url":"https://api.github.com/repos/spinnaker/orca/pulls/1151/comments","review_comment_url":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/orca/issues/1151/comments","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/209dae9fde14932b6fef620132191c1fca4f92f4","head":{"label":"ajordens:tag-server-groups-with-metadata","ref":"tag-server-groups-with-metadata","sha":"209dae9fde14932b6fef620132191c1fca4f92f4","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"repo":{"id":68033071,"name":"orca","full_name":"ajordens/orca","owner":{"login":"ajordens","id":388652,"avatar_url":"https://avatars.githubusercontent.com/u/388652?v=3","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajordens/orca","description":"orchestration engine","fork":true,"url":"https://api.github.com/repos/ajordens/orca","forks_url":"https://api.github.com/repos/ajordens/orca/forks","keys_url":"https://api.github.com/repos/ajordens/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajordens/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajordens/orca/teams","hooks_url":"https://api.github.com/repos/ajordens/orca/hooks","issue_events_url":"https://api.github.com/repos/ajordens/orca/issues/events{/number}","events_url":"https://api.github.com/repos/ajordens/orca/events","assignees_url":"https://api.github.com/repos/ajordens/orca/assignees{/user}","branches_url":"https://api.github.com/repos/ajordens/orca/branches{/branch}","tags_url":"https://api.github.com/repos/ajordens/orca/tags","blobs_url":"https://api.github.com/repos/ajordens/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajordens/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajordens/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajordens/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajordens/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/ajordens/orca/languages","stargazers_url":"https://api.github.com/repos/ajordens/orca/stargazers","contributors_url":"https://api.github.com/repos/ajordens/orca/contributors","subscribers_url":"https://api.github.com/repos/ajordens/orca/subscribers","subscription_url":"https://api.github.com/repos/ajordens/orca/subscription","commits_url":"https://api.github.com/repos/ajordens/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajordens/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajordens/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajordens/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajordens/orca/contents/{+path}","compare_url":"https://api.github.com/repos/ajordens/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajordens/orca/merges","archive_url":"https://api.github.com/repos/ajordens/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajordens/orca/downloads","issues_url":"https://api.github.com/repos/ajordens/orca/issues{/number}","pulls_url":"https://api.github.com/repos/ajordens/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/ajordens/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/ajordens/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajordens/orca/labels{/name}","releases_url":"https://api.github.com/repos/ajordens/orca/releases{/id}","deployments_url":"https://api.github.com/repos/ajordens/orca/deployments","created_at":"2016-09-12T17:49:08Z","updated_at":"2016-09-12T17:49:14Z","pushed_at":"2017-02-01T08:19:51Z","git_url":"git://github.com/ajordens/orca.git","ssh_url":"[email protected]:ajordens/orca.git","clone_url":"https://github.com/ajordens/orca.git","svn_url":"https://github.com/ajordens/orca","homepage":"","size":7358,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"cd45cef6903f3ee7cc07a8cef8f12bfd743ccbf7","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":19834314,"name":"orca","full_name":"spinnaker/orca","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/orca","description":"orchestration engine","fork":false,"url":"https://api.github.com/repos/spinnaker/orca","forks_url":"https://api.github.com/repos/spinnaker/orca/forks","keys_url":"https://api.github.com/repos/spinnaker/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/orca/teams","hooks_url":"https://api.github.com/repos/spinnaker/orca/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/orca/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/orca/events","assignees_url":"https://api.github.com/repos/spinnaker/orca/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/orca/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/orca/tags","blobs_url":"https://api.github.com/repos/spinnaker/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/orca/languages","stargazers_url":"https://api.github.com/repos/spinnaker/orca/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/orca/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/orca/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/orca/subscription","commits_url":"https://api.github.com/repos/spinnaker/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/orca/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/orca/merges","archive_url":"https://api.github.com/repos/spinnaker/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/orca/downloads","issues_url":"https://api.github.com/repos/spinnaker/orca/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/orca/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/orca/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/orca/deployments","created_at":"2014-05-15T20:33:00Z","updated_at":"2016-12-22T22:45:41Z","pushed_at":"2017-02-01T08:20:06Z","git_url":"git://github.com/spinnaker/orca.git","ssh_url":"[email protected]:spinnaker/orca.git","clone_url":"https://github.com/spinnaker/orca.git","svn_url":"https://github.com/spinnaker/orca","homepage":"","size":7248,"stargazers_count":42,"watchers_count":42,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":52,"forks":76,"open_issues":52,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1151"},"html":{"href":"https://github.com/spinnaker/orca/pull/1151"},"issue":{"href":"https://api.github.com/repos/spinnaker/orca/issues/1151"},"comments":{"href":"https://api.github.com/repos/spinnaker/orca/issues/1151/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1151/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1151/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/orca/statuses/209dae9fde14932b6fef620132191c1fca4f92f4"}}}} | {
"id": 19834314,
"name": "spinnaker/orca",
"url": "https://api.github.com/repos/spinnaker/orca"
} | {
"id": 388652,
"login": "ajordens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/388652?",
"url": "https://api.github.com/users/ajordens"
} | {
"id": 7634182,
"login": "spinnaker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7634182?",
"url": "https://api.github.com/orgs/spinnaker"
} | 2017-02-01T08:23:19 | 5246129854 | {"actor":{"display_login":"ajordens"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/comments/147753596","pull_request_review_id":72894039,"id":147753596,"diff_hunk":"@@ -0,0 +1,35 @@\n+import * as React from 'react';\n+import { get } from 'lodash';\n+\n+import { StageFailureMessage } from 'core/delivery/details';\n+import { ExecutionDetailsSection, IExecutionDetailsSectionProps } from '../core';\n+import { robotToHuman } from 'core/presentation/robotToHumanFilter/robotToHuman.filter';\n+\n+export function CheckPreconditionsExecutionDetails(props: IExecutionDetailsSectionProps) {\n+ const context = get(props.stage, 'context.context', {} as any);\n+ return (\n+ <ExecutionDetailsSection name={props.name} current={props.current}>\n+ <div className=\"row\">\n+ <div className=\"col-md-12\">\n+ <dl className=\"dl-horizontal\">\n+ {Object.keys(context).filter((key) => key !== 'expression' && context[key] !== null).map((key) => (","path":"app/scripts/modules/core/src/pipeline/config/stages/checkPreconditions/CheckPreconditionsExecutionDetails.tsx","position":15,"original_position":15,"commit_id":"2c8a8b8c964587676b860b161be1d12ddf48a8e4","original_commit_id":"2c8a8b8c964587676b860b161be1d12ddf48a8e4","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars0.githubusercontent.com/u/73450?v=4","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"body":"might be worth `.sort`ing the keys (might not be, what do I know)","created_at":"2017-10-30T16:14:20Z","updated_at":"2017-10-30T16:14:20Z","html_url":"https://github.com/spinnaker/deck/pull/4339#discussion_r147753596","pull_request_url":"https://api.github.com/repos/spinnaker/deck/pulls/4339","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments/147753596"},"html":{"href":"https://github.com/spinnaker/deck/pull/4339#discussion_r147753596"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/4339"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/4339","id":149561098,"html_url":"https://github.com/spinnaker/deck/pull/4339","diff_url":"https://github.com/spinnaker/deck/pull/4339.diff","patch_url":"https://github.com/spinnaker/deck/pull/4339.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/4339","number":4339,"state":"open","locked":false,"title":"refactor(core/pipeline): Convert a few execution source details to react","user":{"login":"jrsquared","id":56971,"avatar_url":"https://avatars1.githubusercontent.com/u/56971?v=4","gravatar_id":"","url":"https://api.github.com/users/jrsquared","html_url":"https://github.com/jrsquared","followers_url":"https://api.github.com/users/jrsquared/followers","following_url":"https://api.github.com/users/jrsquared/following{/other_user}","gists_url":"https://api.github.com/users/jrsquared/gists{/gist_id}","starred_url":"https://api.github.com/users/jrsquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrsquared/subscriptions","organizations_url":"https://api.github.com/users/jrsquared/orgs","repos_url":"https://api.github.com/users/jrsquared/repos","events_url":"https://api.github.com/users/jrsquared/events{/privacy}","received_events_url":"https://api.github.com/users/jrsquared/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-30T15:51:08Z","updated_at":"2017-10-30T16:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99e2585bb510356ac8e6e2ecfaf1e9e96a4eea5d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/4339/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/4339/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/4339/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/2c8a8b8c964587676b860b161be1d12ddf48a8e4","head":{"label":"jrsquared:more-ed-conversion","ref":"more-ed-conversion","sha":"2c8a8b8c964587676b860b161be1d12ddf48a8e4","user":{"login":"jrsquared","id":56971,"avatar_url":"https://avatars1.githubusercontent.com/u/56971?v=4","gravatar_id":"","url":"https://api.github.com/users/jrsquared","html_url":"https://github.com/jrsquared","followers_url":"https://api.github.com/users/jrsquared/followers","following_url":"https://api.github.com/users/jrsquared/following{/other_user}","gists_url":"https://api.github.com/users/jrsquared/gists{/gist_id}","starred_url":"https://api.github.com/users/jrsquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrsquared/subscriptions","organizations_url":"https://api.github.com/users/jrsquared/orgs","repos_url":"https://api.github.com/users/jrsquared/repos","events_url":"https://api.github.com/users/jrsquared/events{/privacy}","received_events_url":"https://api.github.com/users/jrsquared/received_events","type":"User","site_admin":false},"repo":{"id":79277027,"name":"deck","full_name":"jrsquared/deck","owner":{"login":"jrsquared","id":56971,"avatar_url":"https://avatars1.githubusercontent.com/u/56971?v=4","gravatar_id":"","url":"https://api.github.com/users/jrsquared","html_url":"https://github.com/jrsquared","followers_url":"https://api.github.com/users/jrsquared/followers","following_url":"https://api.github.com/users/jrsquared/following{/other_user}","gists_url":"https://api.github.com/users/jrsquared/gists{/gist_id}","starred_url":"https://api.github.com/users/jrsquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrsquared/subscriptions","organizations_url":"https://api.github.com/users/jrsquared/orgs","repos_url":"https://api.github.com/users/jrsquared/repos","events_url":"https://api.github.com/users/jrsquared/events{/privacy}","received_events_url":"https://api.github.com/users/jrsquared/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrsquared/deck","description":"Management UI for Spinnaker","fork":true,"url":"https://api.github.com/repos/jrsquared/deck","forks_url":"https://api.github.com/repos/jrsquared/deck/forks","keys_url":"https://api.github.com/repos/jrsquared/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrsquared/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrsquared/deck/teams","hooks_url":"https://api.github.com/repos/jrsquared/deck/hooks","issue_events_url":"https://api.github.com/repos/jrsquared/deck/issues/events{/number}","events_url":"https://api.github.com/repos/jrsquared/deck/events","assignees_url":"https://api.github.com/repos/jrsquared/deck/assignees{/user}","branches_url":"https://api.github.com/repos/jrsquared/deck/branches{/branch}","tags_url":"https://api.github.com/repos/jrsquared/deck/tags","blobs_url":"https://api.github.com/repos/jrsquared/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrsquared/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrsquared/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrsquared/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrsquared/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/jrsquared/deck/languages","stargazers_url":"https://api.github.com/repos/jrsquared/deck/stargazers","contributors_url":"https://api.github.com/repos/jrsquared/deck/contributors","subscribers_url":"https://api.github.com/repos/jrsquared/deck/subscribers","subscription_url":"https://api.github.com/repos/jrsquared/deck/subscription","commits_url":"https://api.github.com/repos/jrsquared/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrsquared/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrsquared/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrsquared/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrsquared/deck/contents/{+path}","compare_url":"https://api.github.com/repos/jrsquared/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrsquared/deck/merges","archive_url":"https://api.github.com/repos/jrsquared/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrsquared/deck/downloads","issues_url":"https://api.github.com/repos/jrsquared/deck/issues{/number}","pulls_url":"https://api.github.com/repos/jrsquared/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/jrsquared/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/jrsquared/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrsquared/deck/labels{/name}","releases_url":"https://api.github.com/repos/jrsquared/deck/releases{/id}","deployments_url":"https://api.github.com/repos/jrsquared/deck/deployments","created_at":"2017-01-17T22:08:52Z","updated_at":"2017-01-17T22:09:00Z","pushed_at":"2017-10-30T15:49:57Z","git_url":"git://github.com/jrsquared/deck.git","ssh_url":"[email protected]:jrsquared/deck.git","clone_url":"https://github.com/jrsquared/deck.git","svn_url":"https://github.com/jrsquared/deck","homepage":"","size":26868,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"d67066610cd85bce243f1adea61834451a8a463f","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/deck/deployments","created_at":"2014-07-17T18:51:00Z","updated_at":"2017-10-27T08:14:05Z","pushed_at":"2017-10-30T15:51:08Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"[email protected]:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":26828,"stargazers_count":107,"watchers_count":107,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":170,"open_issues":4,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/4339"},"html":{"href":"https://github.com/spinnaker/deck/pull/4339"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/4339"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/4339/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/4339/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/4339/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/2c8a8b8c964587676b860b161be1d12ddf48a8e4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 21953642,
"name": "spinnaker/deck",
"url": "https://api.github.com/repos/spinnaker/deck"
} | {
"id": 73450,
"login": "anotherchrisberry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/73450?",
"url": "https://api.github.com/users/anotherchrisberry"
} | {
"id": 7634182,
"login": "spinnaker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7634182?",
"url": "https://api.github.com/orgs/spinnaker"
} | 2017-10-30T16:14:20 | 6784777081 | {"actor":{"display_login":"anotherchrisberry"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/158938173","pull_request_review_id":85814015,"id":158938173,"diff_hunk":"@@ -103,9 +107,381 @@ func TestVerifyAccountPasswordWithAccountBeforeEIP55(t *testing.T) {\n \terr = common.ImportTestAccount(keyStoreDir, \"test-account3-before-eip55.pk\")\n \trequire.NoError(t, err)\n \n-\tacctManager := account.NewManager(nil)\n+\taccManager := NewManager(nil)\n \n \taddress := gethcommon.HexToAddress(TestConfig.Account3.Address)\n-\t_, err = acctManager.VerifyAccountPassword(keyStoreDir, address.Hex(), TestConfig.Account3.Password)\n+\t_, err = accManager.VerifyAccountPassword(keyStoreDir, address.Hex(), TestConfig.Account3.Password)\n \trequire.NoError(t, err)\n }\n+\n+var (\n+\ttestErrWhisper = errors.New(\"Can't return a whisper service\")\n+\ttestErrKeyStore = errors.New(\"Can't return a key store\")\n+)\n+\n+func TestManagerTestSuite(t *testing.T) {\n+\tnodeManager := newMockNodeManager(t)\n+\taccManager := NewManager(nodeManager)\n+\n+\tkeyStoreDir, err := ioutil.TempDir(os.TempDir(), \"accounts\")\n+\trequire.NoError(t, err)\n+\tkeyStore := keystore.NewKeyStore(keyStoreDir, keystore.LightScryptN, keystore.LightScryptP)\n+\tdefer os.RemoveAll(keyStoreDir) //nolint: errcheck\n+\n+\ttestPassword := \"test-password\"\n+\n+\t// Initial test - create test account\n+\tnodeManager.EXPECT().AccountKeyStore().Return(keyStore, nil)\n+\taddr, pubKey, mnemonic, err := accManager.CreateAccount(testPassword)\n+\trequire.NoError(t, err)\n+\trequire.NotNil(t, addr)\n+\trequire.NotNil(t, pubKey)\n+\trequire.NotNil(t, mnemonic)\n+\n+\ts := &ManagerTestSuite{\n+\t\ttestAccount: testAccount{\n+\t\t\t\"test-password\",\n+\t\t\taddr,\n+\t\t\tpubKey,\n+\t\t\tmnemonic,\n+\t\t},\n+\t\tnodeManager: nodeManager,\n+\t\taccManager: accManager,\n+\t\tkeyStore: keyStore,\n+\t\tshh: whisper.New(nil),\n+\t\tgethAccManager: accounts.NewManager(),\n+\t}\n+\n+\tsuite.Run(t, s)\n+}\n+\n+func newMockNodeManager(t *testing.T) *common.MockNodeManager {\n+\tctrl := gomock.NewController(t)\n+\treturn common.NewMockNodeManager(ctrl)\n+}\n+\n+type ManagerTestSuite struct {\n+\tsuite.Suite\n+\ttestAccount\n+\tnodeManager *common.MockNodeManager\n+\taccManager *Manager\n+\tkeyStore *keystore.KeyStore\n+\tshh *whisper.Whisper\n+\tgethAccManager *accounts.Manager\n+}\n+\n+type testAccount struct {\n+\tpassword string\n+\taddress string\n+\tpubKey string\n+\tmnemonic string\n+}\n+\n+// reinitMock is for reassigning a new mock node manager to account manager.\n+// Stating the amount of times for mock calls kills the flexibility for\n+// development so this is a good workaround to use with EXPECT().AnyTimes()\n+func (s *ManagerTestSuite) reinitMock() {\n+\ts.nodeManager = newMockNodeManager(s.T())\n+\ts.accManager.nodeManager = s.nodeManager\n+}\n+\n+func (s *ManagerTestSuite) TestCreateAndRecoverAccount() {\n+\ts.reinitMock()\n+\n+\t// Don't fail on empty password","path":"geth/account/accounts_test.go","position":124,"original_position":124,"commit_id":"e6a41a924a7c997fdeb1ea6ff55aa4002ee8525e","original_commit_id":"e6a41a924a7c997fdeb1ea6ff55aa4002ee8525e","user":{"login":"adambabik","id":277870,"avatar_url":"https://avatars1.githubusercontent.com/u/277870?v=4","gravatar_id":"","url":"https://api.github.com/users/adambabik","html_url":"https://github.com/adambabik","followers_url":"https://api.github.com/users/adambabik/followers","following_url":"https://api.github.com/users/adambabik/following{/other_user}","gists_url":"https://api.github.com/users/adambabik/gists{/gist_id}","starred_url":"https://api.github.com/users/adambabik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambabik/subscriptions","organizations_url":"https://api.github.com/users/adambabik/orgs","repos_url":"https://api.github.com/users/adambabik/repos","events_url":"https://api.github.com/users/adambabik/events{/privacy}","received_events_url":"https://api.github.com/users/adambabik/received_events","type":"User","site_admin":false},"body":"The thing is that this test case has nothing to do with recovering an account. Maybe let's split it into `TestCreateAccount` and `TestRecoverAccount`? \r\n\r\nIn `TestCreateAccount` we can have an empty password case and failed `CreateAccount()` call:\r\n```go\r\ns.nodeManager.EXPECT().AccountKeyStore().Return(nil, testErrKeyStore)\r\n_, _, _, err = s.accManager.CreateAccount(s.password)\r\ns.Equal(err, testErrKeyStore)\r\n```\r\n\r\nIn `TestRecoverAccount`, we will just test recovering an account, so only `accManager.RecoverAccount()` calls. Does it sound ok? ","created_at":"2017-12-28T12:42:34Z","updated_at":"2017-12-28T12:42:34Z","html_url":"https://github.com/status-im/status-go/pull/511#discussion_r158938173","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/511","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/158938173"},"html":{"href":"https://github.com/status-im/status-go/pull/511#discussion_r158938173"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/511"}},"in_reply_to_id":158699090},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/511","id":158253105,"html_url":"https://github.com/status-im/status-go/pull/511","diff_url":"https://github.com/status-im/status-go/pull/511.diff","patch_url":"https://github.com/status-im/status-go/pull/511.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/511","number":511,"state":"open","locked":false,"title":"Add unit tests for CreateAccount and RecoverAccount methods #510","user":{"login":"canercidam","id":14118507,"avatar_url":"https://avatars2.githubusercontent.com/u/14118507?v=4","gravatar_id":"","url":"https://api.github.com/users/canercidam","html_url":"https://github.com/canercidam","followers_url":"https://api.github.com/users/canercidam/followers","following_url":"https://api.github.com/users/canercidam/following{/other_user}","gists_url":"https://api.github.com/users/canercidam/gists{/gist_id}","starred_url":"https://api.github.com/users/canercidam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canercidam/subscriptions","organizations_url":"https://api.github.com/users/canercidam/orgs","repos_url":"https://api.github.com/users/canercidam/repos","events_url":"https://api.github.com/users/canercidam/events{/privacy}","received_events_url":"https://api.github.com/users/canercidam/received_events","type":"User","site_admin":false},"body":"Unit tests for account creation and recovery using `common.MockNodeManager`\r\n\r\nImportant changes:\r\n- [x] No race conditions.\r\n- [x] Coverage for `Manager.CreateAccount` and `Manager.RecoverAccount` is over 80%.\r\n- [x] ~~All functions which are independent from `common.NodeManager` are included. (?)~~\r\n- [x] Overall test coverage is over 80%.\r\n\r\nCloses #510 \r\n","created_at":"2017-12-14T02:16:54Z","updated_at":"2017-12-28T12:42:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92bc89ee7ad3541aba563d3266c3b33904f81e5f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/511/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/511/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/511/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/e6a41a924a7c997fdeb1ea6ff55aa4002ee8525e","head":{"label":"canercidam:issue-510","ref":"issue-510","sha":"e6a41a924a7c997fdeb1ea6ff55aa4002ee8525e","user":{"login":"canercidam","id":14118507,"avatar_url":"https://avatars2.githubusercontent.com/u/14118507?v=4","gravatar_id":"","url":"https://api.github.com/users/canercidam","html_url":"https://github.com/canercidam","followers_url":"https://api.github.com/users/canercidam/followers","following_url":"https://api.github.com/users/canercidam/following{/other_user}","gists_url":"https://api.github.com/users/canercidam/gists{/gist_id}","starred_url":"https://api.github.com/users/canercidam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canercidam/subscriptions","organizations_url":"https://api.github.com/users/canercidam/orgs","repos_url":"https://api.github.com/users/canercidam/repos","events_url":"https://api.github.com/users/canercidam/events{/privacy}","received_events_url":"https://api.github.com/users/canercidam/received_events","type":"User","site_admin":false},"repo":{"id":112765801,"name":"status-go","full_name":"canercidam/status-go","owner":{"login":"canercidam","id":14118507,"avatar_url":"https://avatars2.githubusercontent.com/u/14118507?v=4","gravatar_id":"","url":"https://api.github.com/users/canercidam","html_url":"https://github.com/canercidam","followers_url":"https://api.github.com/users/canercidam/followers","following_url":"https://api.github.com/users/canercidam/following{/other_user}","gists_url":"https://api.github.com/users/canercidam/gists{/gist_id}","starred_url":"https://api.github.com/users/canercidam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canercidam/subscriptions","organizations_url":"https://api.github.com/users/canercidam/orgs","repos_url":"https://api.github.com/users/canercidam/repos","events_url":"https://api.github.com/users/canercidam/events{/privacy}","received_events_url":"https://api.github.com/users/canercidam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/canercidam/status-go","description":"The Status module that consumes go-ethereum","fork":true,"url":"https://api.github.com/repos/canercidam/status-go","forks_url":"https://api.github.com/repos/canercidam/status-go/forks","keys_url":"https://api.github.com/repos/canercidam/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canercidam/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canercidam/status-go/teams","hooks_url":"https://api.github.com/repos/canercidam/status-go/hooks","issue_events_url":"https://api.github.com/repos/canercidam/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/canercidam/status-go/events","assignees_url":"https://api.github.com/repos/canercidam/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/canercidam/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/canercidam/status-go/tags","blobs_url":"https://api.github.com/repos/canercidam/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canercidam/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canercidam/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/canercidam/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canercidam/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/canercidam/status-go/languages","stargazers_url":"https://api.github.com/repos/canercidam/status-go/stargazers","contributors_url":"https://api.github.com/repos/canercidam/status-go/contributors","subscribers_url":"https://api.github.com/repos/canercidam/status-go/subscribers","subscription_url":"https://api.github.com/repos/canercidam/status-go/subscription","commits_url":"https://api.github.com/repos/canercidam/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/canercidam/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/canercidam/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/canercidam/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/canercidam/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/canercidam/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canercidam/status-go/merges","archive_url":"https://api.github.com/repos/canercidam/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canercidam/status-go/downloads","issues_url":"https://api.github.com/repos/canercidam/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/canercidam/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/canercidam/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/canercidam/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canercidam/status-go/labels{/name}","releases_url":"https://api.github.com/repos/canercidam/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/canercidam/status-go/deployments","created_at":"2017-12-01T17:10:29Z","updated_at":"2017-12-01T17:10:32Z","pushed_at":"2017-12-21T17:07:20Z","git_url":"git://github.com/canercidam/status-go.git","ssh_url":"[email protected]:canercidam/status-go.git","clone_url":"https://github.com/canercidam/status-go.git","svn_url":"https://github.com/canercidam/status-go","homepage":"https://status.im","size":25711,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"ba6c96532bfdfcc1bc95d5535d3d6b04ee7de49e","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2017-12-28T03:37:02Z","pushed_at":"2017-12-27T20:44:32Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"[email protected]:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":26743,"stargazers_count":260,"watchers_count":260,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":83,"open_issues":80,"watchers":260,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/511"},"html":{"href":"https://github.com/status-im/status-go/pull/511"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/511"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/511/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/511/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/511/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/e6a41a924a7c997fdeb1ea6ff55aa4002ee8525e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 61047867,
"name": "status-im/status-go",
"url": "https://api.github.com/repos/status-im/status-go"
} | {
"id": 277870,
"login": "adambabik",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/277870?",
"url": "https://api.github.com/users/adambabik"
} | {
"id": 11767950,
"login": "status-im",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11767950?",
"url": "https://api.github.com/orgs/status-im"
} | 2017-12-28T12:42:34 | 7037072455 | {"actor":{"display_login":"adambabik"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/symengine/symengine.py/pulls/comments/116360547","pull_request_review_id":37981648,"id":116360547,"diff_hunk":"@@ -43,6 +67,137 @@ def __new__(cls, i):\n return symengine.Integer(i)\n \n \n+class Float(Number):\n+ _classes = (symengine.RealDouble, symengine.RealMPFR)\n+\n+ def __new__(cls, num, dps=None, prec=None, precision=None):\n+\n+ if dps is not None and precision is not None:\n+ raise ValueError('Both decimal and binary precision supplied. '\n+ 'Supply only one. ')\n+\n+ if isinstance(num, (str, unicode)):\n+ num = num.replace(' ', '')\n+ if num.startswith('.') and len(num) > 1:\n+ num = '0' + num\n+ elif num.startswith('-.') and len(num) > 2:\n+ num = '-0.' + num[2:]\n+ elif isinstance(num, float) and num == 0:\n+ num = '0'\n+ elif isinstance(num, (int, long, Integer)):\n+ num = str(num)\n+ elif isinstance(num, (sympy.Infinity, sympy.NegativeInfinity)):\n+ raise NotImplementedError\n+ '''\n+ elif isinstance(num, mpmath.mpf):\n+ if precision is None:\n+ if dps is None:\n+ precision = num.context.prec\n+ num = num._mpf_\n+ '''\n+ \n+ if dps is None and precision is None:\n+ dps = 15\n+ if isinstance(num, Float):\n+ return num\n+ if isinstance(num, str) and _literal_float(num):\n+ try:\n+ Num = decimal.Decimal(num)\n+ except decimal.InvalidOperation:\n+ pass\n+ else:\n+ isint = '.' not in num\n+ num, dps = _decimal_to_Rational_prec(Num)\n+ if num.is_Integer and isint:\n+ dps = max(dps, len(str(num).lstrip('-'))) \n+ dps = max(15, dps)\n+ '''\n+ precision = mlib.libmpf.dps_to_prec(dps)","path":"symengine/sympy_compat.py","position":86,"original_position":86,"commit_id":"f12b8c8cde153e6a509a8a5596ed1b54bcb98110","original_commit_id":"f12b8c8cde153e6a509a8a5596ed1b54bcb98110","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars0.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"body":"I think `dps_to_prec` is a one liner and that's fine","created_at":"2017-05-13T15:28:23Z","updated_at":"2017-05-13T15:28:23Z","html_url":"https://github.com/symengine/symengine.py/pull/140#discussion_r116360547","pull_request_url":"https://api.github.com/repos/symengine/symengine.py/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine.py/pulls/comments/116360547"},"html":{"href":"https://github.com/symengine/symengine.py/pull/140#discussion_r116360547"},"pull_request":{"href":"https://api.github.com/repos/symengine/symengine.py/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/symengine/symengine.py/pulls/140","id":119678271,"html_url":"https://github.com/symengine/symengine.py/pull/140","diff_url":"https://github.com/symengine/symengine.py/pull/140.diff","patch_url":"https://github.com/symengine/symengine.py/pull/140.patch","issue_url":"https://api.github.com/repos/symengine/symengine.py/issues/140","number":140,"state":"open","locked":false,"title":"[WIP] Additions to symengine/sympy_compat.py","user":{"login":"ShikharJ","id":19722966,"avatar_url":"https://avatars1.githubusercontent.com/u/19722966?v=3","gravatar_id":"","url":"https://api.github.com/users/ShikharJ","html_url":"https://github.com/ShikharJ","followers_url":"https://api.github.com/users/ShikharJ/followers","following_url":"https://api.github.com/users/ShikharJ/following{/other_user}","gists_url":"https://api.github.com/users/ShikharJ/gists{/gist_id}","starred_url":"https://api.github.com/users/ShikharJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShikharJ/subscriptions","organizations_url":"https://api.github.com/users/ShikharJ/orgs","repos_url":"https://api.github.com/users/ShikharJ/repos","events_url":"https://api.github.com/users/ShikharJ/events{/privacy}","received_events_url":"https://api.github.com/users/ShikharJ/received_events","type":"User","site_admin":false},"body":"Relevant: #136 \r\n@isuruf The constructor for `Float` is itself quite complex and many of the functionalities used are currently unavailable. I have commented the specific parts as of now. What should be done here?","created_at":"2017-05-09T14:52:03Z","updated_at":"2017-05-13T15:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a80fc5eb69b5001e677cf1c795a70c5d9f22ba5d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/symengine/symengine.py/milestones/1","html_url":"https://github.com/symengine/symengine.py/milestone/1","labels_url":"https://api.github.com/repos/symengine/symengine.py/milestones/1/labels","id":2515241,"number":1,"title":"0.3.0","description":"","creator":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars0.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":0,"state":"open","created_at":"2017-05-11T13:58:13Z","updated_at":"2017-05-11T16:49:10Z","due_on":"2017-05-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symengine/symengine.py/pulls/140/commits","review_comments_url":"https://api.github.com/repos/symengine/symengine.py/pulls/140/comments","review_comment_url":"https://api.github.com/repos/symengine/symengine.py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symengine/symengine.py/issues/140/comments","statuses_url":"https://api.github.com/repos/symengine/symengine.py/statuses/f12b8c8cde153e6a509a8a5596ed1b54bcb98110","head":{"label":"ShikharJ:SympyCompat","ref":"SympyCompat","sha":"f12b8c8cde153e6a509a8a5596ed1b54bcb98110","user":{"login":"ShikharJ","id":19722966,"avatar_url":"https://avatars1.githubusercontent.com/u/19722966?v=3","gravatar_id":"","url":"https://api.github.com/users/ShikharJ","html_url":"https://github.com/ShikharJ","followers_url":"https://api.github.com/users/ShikharJ/followers","following_url":"https://api.github.com/users/ShikharJ/following{/other_user}","gists_url":"https://api.github.com/users/ShikharJ/gists{/gist_id}","starred_url":"https://api.github.com/users/ShikharJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShikharJ/subscriptions","organizations_url":"https://api.github.com/users/ShikharJ/orgs","repos_url":"https://api.github.com/users/ShikharJ/repos","events_url":"https://api.github.com/users/ShikharJ/events{/privacy}","received_events_url":"https://api.github.com/users/ShikharJ/received_events","type":"User","site_admin":false},"repo":{"id":81672411,"name":"symengine.py","full_name":"ShikharJ/symengine.py","owner":{"login":"ShikharJ","id":19722966,"avatar_url":"https://avatars1.githubusercontent.com/u/19722966?v=3","gravatar_id":"","url":"https://api.github.com/users/ShikharJ","html_url":"https://github.com/ShikharJ","followers_url":"https://api.github.com/users/ShikharJ/followers","following_url":"https://api.github.com/users/ShikharJ/following{/other_user}","gists_url":"https://api.github.com/users/ShikharJ/gists{/gist_id}","starred_url":"https://api.github.com/users/ShikharJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShikharJ/subscriptions","organizations_url":"https://api.github.com/users/ShikharJ/orgs","repos_url":"https://api.github.com/users/ShikharJ/repos","events_url":"https://api.github.com/users/ShikharJ/events{/privacy}","received_events_url":"https://api.github.com/users/ShikharJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShikharJ/symengine.py","description":"Python wrappers for SymEngine","fork":true,"url":"https://api.github.com/repos/ShikharJ/symengine.py","forks_url":"https://api.github.com/repos/ShikharJ/symengine.py/forks","keys_url":"https://api.github.com/repos/ShikharJ/symengine.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShikharJ/symengine.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShikharJ/symengine.py/teams","hooks_url":"https://api.github.com/repos/ShikharJ/symengine.py/hooks","issue_events_url":"https://api.github.com/repos/ShikharJ/symengine.py/issues/events{/number}","events_url":"https://api.github.com/repos/ShikharJ/symengine.py/events","assignees_url":"https://api.github.com/repos/ShikharJ/symengine.py/assignees{/user}","branches_url":"https://api.github.com/repos/ShikharJ/symengine.py/branches{/branch}","tags_url":"https://api.github.com/repos/ShikharJ/symengine.py/tags","blobs_url":"https://api.github.com/repos/ShikharJ/symengine.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShikharJ/symengine.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShikharJ/symengine.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShikharJ/symengine.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShikharJ/symengine.py/statuses/{sha}","languages_url":"https://api.github.com/repos/ShikharJ/symengine.py/languages","stargazers_url":"https://api.github.com/repos/ShikharJ/symengine.py/stargazers","contributors_url":"https://api.github.com/repos/ShikharJ/symengine.py/contributors","subscribers_url":"https://api.github.com/repos/ShikharJ/symengine.py/subscribers","subscription_url":"https://api.github.com/repos/ShikharJ/symengine.py/subscription","commits_url":"https://api.github.com/repos/ShikharJ/symengine.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShikharJ/symengine.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShikharJ/symengine.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShikharJ/symengine.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShikharJ/symengine.py/contents/{+path}","compare_url":"https://api.github.com/repos/ShikharJ/symengine.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShikharJ/symengine.py/merges","archive_url":"https://api.github.com/repos/ShikharJ/symengine.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShikharJ/symengine.py/downloads","issues_url":"https://api.github.com/repos/ShikharJ/symengine.py/issues{/number}","pulls_url":"https://api.github.com/repos/ShikharJ/symengine.py/pulls{/number}","milestones_url":"https://api.github.com/repos/ShikharJ/symengine.py/milestones{/number}","notifications_url":"https://api.github.com/repos/ShikharJ/symengine.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShikharJ/symengine.py/labels{/name}","releases_url":"https://api.github.com/repos/ShikharJ/symengine.py/releases{/id}","deployments_url":"https://api.github.com/repos/ShikharJ/symengine.py/deployments","created_at":"2017-02-11T18:18:48Z","updated_at":"2017-02-11T18:18:50Z","pushed_at":"2017-05-13T07:10:21Z","git_url":"git://github.com/ShikharJ/symengine.py.git","ssh_url":"[email protected]:ShikharJ/symengine.py.git","clone_url":"https://github.com/ShikharJ/symengine.py.git","svn_url":"https://github.com/ShikharJ/symengine.py","homepage":null,"size":884,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symengine:master","ref":"master","sha":"3095abc25ae327f3e6a1402adb9cf53fd63dfdbf","user":{"login":"symengine","id":11509221,"avatar_url":"https://avatars1.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"repo":{"id":41312700,"name":"symengine.py","full_name":"symengine/symengine.py","owner":{"login":"symengine","id":11509221,"avatar_url":"https://avatars1.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symengine/symengine.py","description":"Python wrappers for SymEngine","fork":false,"url":"https://api.github.com/repos/symengine/symengine.py","forks_url":"https://api.github.com/repos/symengine/symengine.py/forks","keys_url":"https://api.github.com/repos/symengine/symengine.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symengine/symengine.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symengine/symengine.py/teams","hooks_url":"https://api.github.com/repos/symengine/symengine.py/hooks","issue_events_url":"https://api.github.com/repos/symengine/symengine.py/issues/events{/number}","events_url":"https://api.github.com/repos/symengine/symengine.py/events","assignees_url":"https://api.github.com/repos/symengine/symengine.py/assignees{/user}","branches_url":"https://api.github.com/repos/symengine/symengine.py/branches{/branch}","tags_url":"https://api.github.com/repos/symengine/symengine.py/tags","blobs_url":"https://api.github.com/repos/symengine/symengine.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symengine/symengine.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symengine/symengine.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/symengine/symengine.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symengine/symengine.py/statuses/{sha}","languages_url":"https://api.github.com/repos/symengine/symengine.py/languages","stargazers_url":"https://api.github.com/repos/symengine/symengine.py/stargazers","contributors_url":"https://api.github.com/repos/symengine/symengine.py/contributors","subscribers_url":"https://api.github.com/repos/symengine/symengine.py/subscribers","subscription_url":"https://api.github.com/repos/symengine/symengine.py/subscription","commits_url":"https://api.github.com/repos/symengine/symengine.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/symengine/symengine.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/symengine/symengine.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/symengine/symengine.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/symengine/symengine.py/contents/{+path}","compare_url":"https://api.github.com/repos/symengine/symengine.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symengine/symengine.py/merges","archive_url":"https://api.github.com/repos/symengine/symengine.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symengine/symengine.py/downloads","issues_url":"https://api.github.com/repos/symengine/symengine.py/issues{/number}","pulls_url":"https://api.github.com/repos/symengine/symengine.py/pulls{/number}","milestones_url":"https://api.github.com/repos/symengine/symengine.py/milestones{/number}","notifications_url":"https://api.github.com/repos/symengine/symengine.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symengine/symengine.py/labels{/name}","releases_url":"https://api.github.com/repos/symengine/symengine.py/releases{/id}","deployments_url":"https://api.github.com/repos/symengine/symengine.py/deployments","created_at":"2015-08-24T15:56:54Z","updated_at":"2017-04-27T20:18:10Z","pushed_at":"2017-05-13T07:10:23Z","git_url":"git://github.com/symengine/symengine.py.git","ssh_url":"[email protected]:symengine/symengine.py.git","clone_url":"https://github.com/symengine/symengine.py.git","svn_url":"https://github.com/symengine/symengine.py","homepage":null,"size":865,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":25,"forks":24,"open_issues":25,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine.py/pulls/140"},"html":{"href":"https://github.com/symengine/symengine.py/pull/140"},"issue":{"href":"https://api.github.com/repos/symengine/symengine.py/issues/140"},"comments":{"href":"https://api.github.com/repos/symengine/symengine.py/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/symengine/symengine.py/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/symengine/symengine.py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symengine/symengine.py/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/symengine/symengine.py/statuses/f12b8c8cde153e6a509a8a5596ed1b54bcb98110"}}}} | {
"id": 41312700,
"name": "symengine/symengine.py",
"url": "https://api.github.com/repos/symengine/symengine.py"
} | {
"id": 5234427,
"login": "isuruf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5234427?",
"url": "https://api.github.com/users/isuruf"
} | {
"id": 11509221,
"login": "symengine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11509221?",
"url": "https://api.github.com/orgs/symengine"
} | 2017-05-13T15:28:23 | 5866496242 | {"actor":{"display_login":"isuruf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/151876021","pull_request_review_id":77653446,"id":151876021,"diff_hunk":"@@ -129,8 +129,12 @@\n \tif(hit_area)\r\n \t\tmessage_hit_area = \" in the [hit_area]\"\r\n \tvar/attack_message = \"[src] has been [message_verb][message_hit_area] with [I].\"\r\n+\tvar/agnosia_message = \"Someone has been [message_verb][message_hit_area] with [I].\"\r","path":"code/_onclick/item_attack.dm","position":4,"original_position":4,"commit_id":"d8cda9b9b7a568c469f48856b5e6a22e9b03f910","original_commit_id":"d8cda9b9b7a568c469f48856b5e6a22e9b03f910","user":{"login":"JJRcop","id":5211576,"avatar_url":"https://avatars2.githubusercontent.com/u/5211576?v=4","gravatar_id":"","url":"https://api.github.com/users/JJRcop","html_url":"https://github.com/JJRcop","followers_url":"https://api.github.com/users/JJRcop/followers","following_url":"https://api.github.com/users/JJRcop/following{/other_user}","gists_url":"https://api.github.com/users/JJRcop/gists{/gist_id}","starred_url":"https://api.github.com/users/JJRcop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JJRcop/subscriptions","organizations_url":"https://api.github.com/users/JJRcop/orgs","repos_url":"https://api.github.com/users/JJRcop/repos","events_url":"https://api.github.com/users/JJRcop/events{/privacy}","received_events_url":"https://api.github.com/users/JJRcop/received_events","type":"User","site_admin":false},"body":"It's a little weird to have a message in item attack code for one trauma","created_at":"2017-11-19T20:06:04Z","updated_at":"2017-11-19T20:31:32Z","html_url":"https://github.com/tgstation/tgstation/pull/31727#discussion_r151876021","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/31727","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/151876021"},"html":{"href":"https://github.com/tgstation/tgstation/pull/31727#discussion_r151876021"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/31727"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/31727","id":146621432,"html_url":"https://github.com/tgstation/tgstation/pull/31727","diff_url":"https://github.com/tgstation/tgstation/pull/31727.diff","patch_url":"https://github.com/tgstation/tgstation/pull/31727.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/31727","number":31727,"state":"open","locked":false,"title":"[Pls No Forget] Complete rework of brain damage","user":{"login":"XDTM","id":18611020,"avatar_url":"https://avatars3.githubusercontent.com/u/18611020?v=4","gravatar_id":"","url":"https://api.github.com/users/XDTM","html_url":"https://github.com/XDTM","followers_url":"https://api.github.com/users/XDTM/followers","following_url":"https://api.github.com/users/XDTM/following{/other_user}","gists_url":"https://api.github.com/users/XDTM/gists{/gist_id}","starred_url":"https://api.github.com/users/XDTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDTM/subscriptions","organizations_url":"https://api.github.com/users/XDTM/orgs","repos_url":"https://api.github.com/users/XDTM/repos","events_url":"https://api.github.com/users/XDTM/events{/privacy}","received_events_url":"https://api.github.com/users/XDTM/received_events","type":"User","site_admin":false},"body":":cl: XDTM\r\nadd: Brain damage has been completely reworked!\r\nremove: Brain damage now no longer simply makes you dumb. Although most of its effects have been shifted into a brain trauma.\r\nadd: Every time you take brain damage, there's a chance you'll suffer a brain trauma. There are many variations of brain traumas, split in mild, severe, and special.\r\nadd: Mild brain traumas are the easiest to get, can be lightly to moderately annoying, and can be cured with mannitol and time.\r\nadd: Severe brain traumas are much rarer and require extensive brain damage before you have a chance to get them; they are usually very debilitating. Unlike mild traumas, they require surgery to cure. A new surgery procedure has been added for this, the aptly named Brain Surgery. It can also heal minor traumas.\r\nadd: Special brain traumas are rarely gained in place of Severe traumas: they are either complex or beneficial.\r\nHowever, they are also even easier to cure than mild traumas, which means that keeping these will usually mean keeping a mild trauma along with it.\r\nadd: Mobs can only naturally have one mild trauma and one severe or special trauma.\r\nbalance: Brain damage will now kill and ruin the brain if it goes above 200. If it somehow goes above 400, the brain will melt and be destroyed completely.\r\nbalance: Many brain-damaging effects have been given a damage cap, making them non-lethal.\r\ndel: The Unintelligible mutation has been removed and made into a brain trauma.\r\ndel: Brain damage no longer makes using machines a living hell.\r\nadd: Abductors give minor traumas to people they experiment on.\r\n/:cl:\r\n\r\nWIP because i need to flesh out more traumas in the list, but the mechanics are in place.\r\n\r\nAs always i'm open to suggestions for changes and, obviously, more trauma ideas.\r\n\r\nCloses #27330\r\n","created_at":"2017-10-14T21:06:44Z","updated_at":"2017-11-19T20:31:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecc124789856df3f3400cc636a7b3c056d954820","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/31727/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/31727/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/31727/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/d8cda9b9b7a568c469f48856b5e6a22e9b03f910","head":{"label":"XDTM:RealBrainDamage","ref":"RealBrainDamage","sha":"d8cda9b9b7a568c469f48856b5e6a22e9b03f910","user":{"login":"XDTM","id":18611020,"avatar_url":"https://avatars3.githubusercontent.com/u/18611020?v=4","gravatar_id":"","url":"https://api.github.com/users/XDTM","html_url":"https://github.com/XDTM","followers_url":"https://api.github.com/users/XDTM/followers","following_url":"https://api.github.com/users/XDTM/following{/other_user}","gists_url":"https://api.github.com/users/XDTM/gists{/gist_id}","starred_url":"https://api.github.com/users/XDTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDTM/subscriptions","organizations_url":"https://api.github.com/users/XDTM/orgs","repos_url":"https://api.github.com/users/XDTM/repos","events_url":"https://api.github.com/users/XDTM/events{/privacy}","received_events_url":"https://api.github.com/users/XDTM/received_events","type":"User","site_admin":false},"repo":{"id":64059556,"name":"tgstation","full_name":"XDTM/tgstation","owner":{"login":"XDTM","id":18611020,"avatar_url":"https://avatars3.githubusercontent.com/u/18611020?v=4","gravatar_id":"","url":"https://api.github.com/users/XDTM","html_url":"https://github.com/XDTM","followers_url":"https://api.github.com/users/XDTM/followers","following_url":"https://api.github.com/users/XDTM/following{/other_user}","gists_url":"https://api.github.com/users/XDTM/gists{/gist_id}","starred_url":"https://api.github.com/users/XDTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDTM/subscriptions","organizations_url":"https://api.github.com/users/XDTM/orgs","repos_url":"https://api.github.com/users/XDTM/repos","events_url":"https://api.github.com/users/XDTM/events{/privacy}","received_events_url":"https://api.github.com/users/XDTM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/XDTM/tgstation","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/XDTM/tgstation","forks_url":"https://api.github.com/repos/XDTM/tgstation/forks","keys_url":"https://api.github.com/repos/XDTM/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XDTM/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XDTM/tgstation/teams","hooks_url":"https://api.github.com/repos/XDTM/tgstation/hooks","issue_events_url":"https://api.github.com/repos/XDTM/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/XDTM/tgstation/events","assignees_url":"https://api.github.com/repos/XDTM/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/XDTM/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/XDTM/tgstation/tags","blobs_url":"https://api.github.com/repos/XDTM/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XDTM/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XDTM/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/XDTM/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XDTM/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/XDTM/tgstation/languages","stargazers_url":"https://api.github.com/repos/XDTM/tgstation/stargazers","contributors_url":"https://api.github.com/repos/XDTM/tgstation/contributors","subscribers_url":"https://api.github.com/repos/XDTM/tgstation/subscribers","subscription_url":"https://api.github.com/repos/XDTM/tgstation/subscription","commits_url":"https://api.github.com/repos/XDTM/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/XDTM/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/XDTM/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/XDTM/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/XDTM/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/XDTM/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XDTM/tgstation/merges","archive_url":"https://api.github.com/repos/XDTM/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XDTM/tgstation/downloads","issues_url":"https://api.github.com/repos/XDTM/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/XDTM/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/XDTM/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/XDTM/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XDTM/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/XDTM/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/XDTM/tgstation/deployments","created_at":"2016-07-24T10:07:29Z","updated_at":"2016-07-24T10:07:50Z","pushed_at":"2017-11-19T19:27:03Z","git_url":"git://github.com/XDTM/tgstation.git","ssh_url":"[email protected]:XDTM/tgstation.git","clone_url":"https://github.com/XDTM/tgstation.git","svn_url":"https://github.com/XDTM/tgstation","homepage":"http://www.tgstation13.org/","size":1004317,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"5941e802ee8090684c0e1ff336b496859702c73f","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2017-11-19T08:23:03Z","pushed_at":"2017-11-19T19:47:56Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"[email protected]:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":1002754,"stargazers_count":427,"watchers_count":427,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1609,"mirror_url":null,"archived":false,"open_issues_count":972,"forks":1609,"open_issues":972,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/31727"},"html":{"href":"https://github.com/tgstation/tgstation/pull/31727"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/31727"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/31727/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/31727/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/31727/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/d8cda9b9b7a568c469f48856b5e6a22e9b03f910"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3234987,
"name": "tgstation/tgstation",
"url": "https://api.github.com/repos/tgstation/tgstation"
} | {
"id": 5211576,
"login": "JJRcop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5211576?",
"url": "https://api.github.com/users/JJRcop"
} | {
"id": 1363778,
"login": "tgstation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1363778?",
"url": "https://api.github.com/orgs/tgstation"
} | 2017-11-19T20:06:04 | 6876056774 | {"actor":{"display_login":"JJRcop"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/113272654","pull_request_review_id":34646852,"id":113272654,"diff_hunk":"@@ -28,9 +28,14 @@ MASS SPECTROMETER\n \t\tSTART_PROCESSING(SSobj, src)\r\n \r\n /obj/item/device/t_scanner/proc/flick_sonar(obj/pipe)\r\n-\tvar/image/I = image('icons/effects/effects.dmi', pipe, \"blip\", pipe.layer+1)\r","path":"code/game/objects/items/devices/scanners.dm","position":4,"original_position":4,"commit_id":"945ffc96f15bc3c66b0c11172bc903ea7d3c7619","original_commit_id":"945ffc96f15bc3c66b0c11172bc903ea7d3c7619","user":{"login":"lzimann","id":6282424,"avatar_url":"https://avatars3.githubusercontent.com/u/6282424?v=3","gravatar_id":"","url":"https://api.github.com/users/lzimann","html_url":"https://github.com/lzimann","followers_url":"https://api.github.com/users/lzimann/followers","following_url":"https://api.github.com/users/lzimann/following{/other_user}","gists_url":"https://api.github.com/users/lzimann/gists{/gist_id}","starred_url":"https://api.github.com/users/lzimann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzimann/subscriptions","organizations_url":"https://api.github.com/users/lzimann/orgs","repos_url":"https://api.github.com/users/lzimann/repos","events_url":"https://api.github.com/users/lzimann/events{/privacy}","received_events_url":"https://api.github.com/users/lzimann/received_events","type":"User","site_admin":false},"body":"Hmm, won't this stop working if the x-ray is in a backpack or dropped on the floor? That would be a problem imo.","created_at":"2017-04-25T18:22:15Z","updated_at":"2017-04-25T18:22:16Z","html_url":"https://github.com/tgstation/tgstation/pull/25093#discussion_r113272654","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/25093","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/113272654"},"html":{"href":"https://github.com/tgstation/tgstation/pull/25093#discussion_r113272654"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/25093"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/25093","id":110624335,"html_url":"https://github.com/tgstation/tgstation/pull/25093","diff_url":"https://github.com/tgstation/tgstation/pull/25093.diff","patch_url":"https://github.com/tgstation/tgstation/pull/25093.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/25093","number":25093,"state":"open","locked":false,"title":"Refactors T-Ray Scanners","user":{"login":"XDTM","id":18611020,"avatar_url":"https://avatars0.githubusercontent.com/u/18611020?v=3","gravatar_id":"","url":"https://api.github.com/users/XDTM","html_url":"https://github.com/XDTM","followers_url":"https://api.github.com/users/XDTM/followers","following_url":"https://api.github.com/users/XDTM/following{/other_user}","gists_url":"https://api.github.com/users/XDTM/gists{/gist_id}","starred_url":"https://api.github.com/users/XDTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDTM/subscriptions","organizations_url":"https://api.github.com/users/XDTM/orgs","repos_url":"https://api.github.com/users/XDTM/repos","events_url":"https://api.github.com/users/XDTM/events{/privacy}","received_events_url":"https://api.github.com/users/XDTM/received_events","type":"User","site_admin":false},"body":":cl: XDTM\r\nfix: T-Ray scans are no longer visible to bystanders.\r\nfix: T-Ray scans no longer allow viewers to interact with underfloor objects.\r\n/:cl:\r\n\r\nPipes no longer get un-invisibilized by t-rays and instead show an overlay on top of the floor, only to the scanner holder/glasses wearer.\r\n\r\nFixes #22601\r\n","created_at":"2017-03-14T13:48:02Z","updated_at":"2017-04-25T18:22:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d799250f3efde69552dee8da5b5309757fdb9067","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/25093/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/25093/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/25093/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/945ffc96f15bc3c66b0c11172bc903ea7d3c7619","head":{"label":"XDTM:tray","ref":"tray","sha":"945ffc96f15bc3c66b0c11172bc903ea7d3c7619","user":{"login":"XDTM","id":18611020,"avatar_url":"https://avatars0.githubusercontent.com/u/18611020?v=3","gravatar_id":"","url":"https://api.github.com/users/XDTM","html_url":"https://github.com/XDTM","followers_url":"https://api.github.com/users/XDTM/followers","following_url":"https://api.github.com/users/XDTM/following{/other_user}","gists_url":"https://api.github.com/users/XDTM/gists{/gist_id}","starred_url":"https://api.github.com/users/XDTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDTM/subscriptions","organizations_url":"https://api.github.com/users/XDTM/orgs","repos_url":"https://api.github.com/users/XDTM/repos","events_url":"https://api.github.com/users/XDTM/events{/privacy}","received_events_url":"https://api.github.com/users/XDTM/received_events","type":"User","site_admin":false},"repo":{"id":64059556,"name":"tgstation","full_name":"XDTM/tgstation","owner":{"login":"XDTM","id":18611020,"avatar_url":"https://avatars0.githubusercontent.com/u/18611020?v=3","gravatar_id":"","url":"https://api.github.com/users/XDTM","html_url":"https://github.com/XDTM","followers_url":"https://api.github.com/users/XDTM/followers","following_url":"https://api.github.com/users/XDTM/following{/other_user}","gists_url":"https://api.github.com/users/XDTM/gists{/gist_id}","starred_url":"https://api.github.com/users/XDTM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDTM/subscriptions","organizations_url":"https://api.github.com/users/XDTM/orgs","repos_url":"https://api.github.com/users/XDTM/repos","events_url":"https://api.github.com/users/XDTM/events{/privacy}","received_events_url":"https://api.github.com/users/XDTM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/XDTM/tgstation","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/XDTM/tgstation","forks_url":"https://api.github.com/repos/XDTM/tgstation/forks","keys_url":"https://api.github.com/repos/XDTM/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XDTM/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XDTM/tgstation/teams","hooks_url":"https://api.github.com/repos/XDTM/tgstation/hooks","issue_events_url":"https://api.github.com/repos/XDTM/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/XDTM/tgstation/events","assignees_url":"https://api.github.com/repos/XDTM/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/XDTM/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/XDTM/tgstation/tags","blobs_url":"https://api.github.com/repos/XDTM/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XDTM/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XDTM/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/XDTM/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XDTM/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/XDTM/tgstation/languages","stargazers_url":"https://api.github.com/repos/XDTM/tgstation/stargazers","contributors_url":"https://api.github.com/repos/XDTM/tgstation/contributors","subscribers_url":"https://api.github.com/repos/XDTM/tgstation/subscribers","subscription_url":"https://api.github.com/repos/XDTM/tgstation/subscription","commits_url":"https://api.github.com/repos/XDTM/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/XDTM/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/XDTM/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/XDTM/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/XDTM/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/XDTM/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XDTM/tgstation/merges","archive_url":"https://api.github.com/repos/XDTM/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XDTM/tgstation/downloads","issues_url":"https://api.github.com/repos/XDTM/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/XDTM/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/XDTM/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/XDTM/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XDTM/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/XDTM/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/XDTM/tgstation/deployments","created_at":"2016-07-24T10:07:29Z","updated_at":"2016-07-24T10:07:50Z","pushed_at":"2017-04-24T21:43:28Z","git_url":"git://github.com/XDTM/tgstation.git","ssh_url":"[email protected]:XDTM/tgstation.git","clone_url":"https://github.com/XDTM/tgstation.git","svn_url":"https://github.com/XDTM/tgstation","homepage":"http://www.tgstation13.org/","size":821111,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"b2c16dca419e08cac0064b69f644e693a0b4bcaa","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars1.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars1.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2017-04-25T00:58:16Z","pushed_at":"2017-04-25T17:54:43Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"[email protected]:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":821101,"stargazers_count":372,"watchers_count":372,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1365,"mirror_url":null,"open_issues_count":856,"forks":1365,"open_issues":856,"watchers":372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/25093"},"html":{"href":"https://github.com/tgstation/tgstation/pull/25093"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/25093"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/25093/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/25093/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/25093/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/945ffc96f15bc3c66b0c11172bc903ea7d3c7619"}}}} | {
"id": 3234987,
"name": "tgstation/tgstation",
"url": "https://api.github.com/repos/tgstation/tgstation"
} | {
"id": 6282424,
"login": "lzimann",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6282424?",
"url": "https://api.github.com/users/lzimann"
} | {
"id": 1363778,
"login": "tgstation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1363778?",
"url": "https://api.github.com/orgs/tgstation"
} | 2017-04-25T18:22:15 | 5754404821 | {"actor":{"display_login":"lzimann"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/117571725","pull_request_review_id":39294670,"id":117571725,"diff_hunk":"@@ -275,35 +279,53 @@\n \t\treturn\n \n /obj/item/weapon/gun/attackby(obj/item/I, mob/user, params)\n-\tif(can_flashlight)\n-\t\tif(istype(I, /obj/item/device/flashlight/seclite))\n-\t\t\tvar/obj/item/device/flashlight/seclite/S = I\n-\t\t\tif(!gun_light)\n-\t\t\t\tif(!user.transferItemToLoc(I, src))\n-\t\t\t\t\treturn\n-\t\t\t\tto_chat(user, \"<span class='notice'>You click [S] into place on [src].</span>\")\n-\t\t\t\tif(S.on)\n-\t\t\t\t\tset_light(0)\n-\t\t\t\tgun_light = S\n-\t\t\t\tupdate_icon()\n+\tif(istype(I, /obj/item/device/flashlight/seclite))\n+\t\tif(!can_flashlight)\n+\t\t\treturn ..()\n+\t\tvar/obj/item/device/flashlight/seclite/S = I\n+\t\tif(!gun_light)\n+\t\t\tif(!user.transferItemToLoc(I, src))\n+\t\t\t\treturn\n+\t\t\tto_chat(user, \"<span class='notice'>You click [S] into place on [src].</span>\")\n+\t\t\tif(S.on)\n+\t\t\t\tset_light(0)\n+\t\t\tgun_light = S\n+\t\t\tupdate_icon()\n+\t\t\tupdate_gunlight(user)\n+\t\t\tverbs += /obj/item/weapon/gun/proc/toggle_gunlight\n+\t\t\tvar/datum/action/A = new /datum/action/item_action/toggle_gunlight(src)\n+\t\t\tif(loc == user)\n+\t\t\t\tA.Grant(user)\n+\tif(istype(I, /obj/item/weapon/kitchen/knife))\n+\t\tif(!can_knife)\n+\t\t\treturn ..()\n+\t\tvar/obj/item/weapon/kitchen/knife/K = I\n+\t\tif(!bayonet)\n+\t\t\tif(!user.transferItemToLoc(I, src))\n+\t\t\t\treturn\n+\t\t\tto_chat(user, \"<span class='notice'>You attach [K] to the front of [src].</span>\")\n+\t\t\tforce = K.force\n+\t\t\tsharpness = K.sharpness\n+\t\t\tupdate_icon()\n+\tif(istype(I, /obj/item/weapon/screwdriver))\n+\t\tif(gun_light)\n+\t\t\tfor(var/obj/item/device/flashlight/seclite/S in src)\n+\t\t\t\tto_chat(user, \"<span class='notice'>You unscrew the seclite from [src].</span>\")","path":"code/modules/projectiles/gun.dm","position":64,"original_position":64,"commit_id":"a0eaea6e2ea59e58fb38694b37867fcde940df99","original_commit_id":"a0eaea6e2ea59e58fb38694b37867fcde940df99","user":{"login":"Cyberboss","id":8171642,"avatar_url":"https://avatars0.githubusercontent.com/u/8171642?v=3","gravatar_id":"","url":"https://api.github.com/users/Cyberboss","html_url":"https://github.com/Cyberboss","followers_url":"https://api.github.com/users/Cyberboss/followers","following_url":"https://api.github.com/users/Cyberboss/following{/other_user}","gists_url":"https://api.github.com/users/Cyberboss/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyberboss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyberboss/subscriptions","organizations_url":"https://api.github.com/users/Cyberboss/orgs","repos_url":"https://api.github.com/users/Cyberboss/repos","events_url":"https://api.github.com/users/Cyberboss/events{/privacy}","received_events_url":"https://api.github.com/users/Cyberboss/received_events","type":"User","site_admin":false},"body":"\\the [S] from \\the [src]","created_at":"2017-05-19T20:46:15Z","updated_at":"2017-05-19T20:49:03Z","html_url":"https://github.com/tgstation/tgstation/pull/27416#discussion_r117571725","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/27416","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/117571725"},"html":{"href":"https://github.com/tgstation/tgstation/pull/27416#discussion_r117571725"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/27416"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/27416","id":121423341,"html_url":"https://github.com/tgstation/tgstation/pull/27416","diff_url":"https://github.com/tgstation/tgstation/pull/27416.diff","patch_url":"https://github.com/tgstation/tgstation/pull/27416.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/27416","number":27416,"state":"open","locked":false,"title":"[WIP] Adds ability to add bayonets to weapons - Only enabled on kinetic accelerators","user":{"login":"kevinz000","id":2003111,"avatar_url":"https://avatars3.githubusercontent.com/u/2003111?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinz000","html_url":"https://github.com/kevinz000","followers_url":"https://api.github.com/users/kevinz000/followers","following_url":"https://api.github.com/users/kevinz000/following{/other_user}","gists_url":"https://api.github.com/users/kevinz000/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinz000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinz000/subscriptions","organizations_url":"https://api.github.com/users/kevinz000/orgs","repos_url":"https://api.github.com/users/kevinz000/repos","events_url":"https://api.github.com/users/kevinz000/events{/privacy}","received_events_url":"https://api.github.com/users/kevinz000/received_events","type":"User","site_admin":false},"body":"adds code for adding bayonets to weapons, codersprites included etc etc.\r\ncurrently only enabled on KAs, and only usable bayonets are combat knives and survival knives\r\njust slap it onto the gun and remove with screwdriver if needed.","created_at":"2017-05-19T04:26:47Z","updated_at":"2017-05-19T20:49:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12e4aa2e78e87486a0aacfb53d001fa50b881d05","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/27416/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/27416/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/27416/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/a0eaea6e2ea59e58fb38694b37867fcde940df99","head":{"label":"kevinz000:_qualityoflife","ref":"_qualityoflife","sha":"a0eaea6e2ea59e58fb38694b37867fcde940df99","user":{"login":"kevinz000","id":2003111,"avatar_url":"https://avatars3.githubusercontent.com/u/2003111?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinz000","html_url":"https://github.com/kevinz000","followers_url":"https://api.github.com/users/kevinz000/followers","following_url":"https://api.github.com/users/kevinz000/following{/other_user}","gists_url":"https://api.github.com/users/kevinz000/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinz000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinz000/subscriptions","organizations_url":"https://api.github.com/users/kevinz000/orgs","repos_url":"https://api.github.com/users/kevinz000/repos","events_url":"https://api.github.com/users/kevinz000/events{/privacy}","received_events_url":"https://api.github.com/users/kevinz000/received_events","type":"User","site_admin":false},"repo":{"id":56410265,"name":"-tg-station","full_name":"kevinz000/-tg-station","owner":{"login":"kevinz000","id":2003111,"avatar_url":"https://avatars3.githubusercontent.com/u/2003111?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinz000","html_url":"https://github.com/kevinz000","followers_url":"https://api.github.com/users/kevinz000/followers","following_url":"https://api.github.com/users/kevinz000/following{/other_user}","gists_url":"https://api.github.com/users/kevinz000/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinz000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinz000/subscriptions","organizations_url":"https://api.github.com/users/kevinz000/orgs","repos_url":"https://api.github.com/users/kevinz000/repos","events_url":"https://api.github.com/users/kevinz000/events{/privacy}","received_events_url":"https://api.github.com/users/kevinz000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinz000/-tg-station","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/kevinz000/-tg-station","forks_url":"https://api.github.com/repos/kevinz000/-tg-station/forks","keys_url":"https://api.github.com/repos/kevinz000/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinz000/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinz000/-tg-station/teams","hooks_url":"https://api.github.com/repos/kevinz000/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/kevinz000/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/kevinz000/-tg-station/events","assignees_url":"https://api.github.com/repos/kevinz000/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/kevinz000/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/kevinz000/-tg-station/tags","blobs_url":"https://api.github.com/repos/kevinz000/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinz000/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinz000/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinz000/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinz000/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinz000/-tg-station/languages","stargazers_url":"https://api.github.com/repos/kevinz000/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/kevinz000/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/kevinz000/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/kevinz000/-tg-station/subscription","commits_url":"https://api.github.com/repos/kevinz000/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinz000/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinz000/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinz000/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevinz000/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/kevinz000/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinz000/-tg-station/merges","archive_url":"https://api.github.com/repos/kevinz000/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinz000/-tg-station/downloads","issues_url":"https://api.github.com/repos/kevinz000/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/kevinz000/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinz000/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinz000/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinz000/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/kevinz000/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/kevinz000/-tg-station/deployments","created_at":"2016-04-16T23:29:34Z","updated_at":"2017-02-12T01:51:10Z","pushed_at":"2017-05-19T10:49:53Z","git_url":"git://github.com/kevinz000/-tg-station.git","ssh_url":"[email protected]:kevinz000/-tg-station.git","clone_url":"https://github.com/kevinz000/-tg-station.git","svn_url":"https://github.com/kevinz000/-tg-station","homepage":"http://www.tgstation13.org/","size":851666,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"6e92cd7e07d535739056b670cdd6e3c9851a4783","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars1.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars1.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2017-05-14T22:33:42Z","pushed_at":"2017-05-19T19:06:19Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"[email protected]:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":845043,"stargazers_count":381,"watchers_count":381,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1391,"mirror_url":null,"open_issues_count":898,"forks":1391,"open_issues":898,"watchers":381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/27416"},"html":{"href":"https://github.com/tgstation/tgstation/pull/27416"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/27416"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/27416/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/27416/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/27416/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/a0eaea6e2ea59e58fb38694b37867fcde940df99"}}}} | {
"id": 3234987,
"name": "tgstation/tgstation",
"url": "https://api.github.com/repos/tgstation/tgstation"
} | {
"id": 8171642,
"login": "Cyberboss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8171642?",
"url": "https://api.github.com/users/Cyberboss"
} | {
"id": 1363778,
"login": "tgstation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1363778?",
"url": "https://api.github.com/orgs/tgstation"
} | 2017-05-19T20:46:15 | 5908579199 | {"actor":{"display_login":"Cyberboss"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/119374520","pull_request_review_id":41249005,"id":119374520,"diff_hunk":"@@ -28,5 +34,15 @@ module.exports = require(\"../../config/webpack/webpack.config\")(__dirname, {\n port: process.env.PORT\n }, plugins: [\n new webpack.HotModuleReplacementPlugin()\n- ]\n-});\n\\ No newline at end of file\n+ ],\n+ resolve: {\n+\t// These shims are needed for bunyan\n+\talias: {\n+ 'dtrace-provider': path.resolve(__dirname, './webpack_empty.js'),\n+ fs: path.resolve(__dirname, './webpack_empty.js'),","path":"examples/browser/webpack.config.js","position":30,"original_position":30,"commit_id":"86a17f35060829e0161d3a5f3b1ba2a1dd5ef10b","original_commit_id":"86a17f35060829e0161d3a5f3b1ba2a1dd5ef10b","user":{"login":"kittaakos","id":1405703,"avatar_url":"https://avatars0.githubusercontent.com/u/1405703?v=3","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false},"body":"`fs` has to be mocked for the browser and it is already mocked. I would expect that if you remove the above-referenced line, it will still works.","created_at":"2017-05-31T14:41:55Z","updated_at":"2017-05-31T14:41:55Z","html_url":"https://github.com/theia-ide/theia/pull/167#discussion_r119374520","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/119374520"},"html":{"href":"https://github.com/theia-ide/theia/pull/167#discussion_r119374520"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/167","id":123268503,"html_url":"https://github.com/theia-ide/theia/pull/167","diff_url":"https://github.com/theia-ide/theia/pull/167.diff","patch_url":"https://github.com/theia-ide/theia/pull/167.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/167","number":167,"state":"open","locked":false,"title":"Debug Logging","user":{"login":"hexa00","id":698076,"avatar_url":"https://avatars1.githubusercontent.com/u/698076?v=3","gravatar_id":"","url":"https://api.github.com/users/hexa00","html_url":"https://github.com/hexa00","followers_url":"https://api.github.com/users/hexa00/followers","following_url":"https://api.github.com/users/hexa00/following{/other_user}","gists_url":"https://api.github.com/users/hexa00/gists{/gist_id}","starred_url":"https://api.github.com/users/hexa00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexa00/subscriptions","organizations_url":"https://api.github.com/users/hexa00/orgs","repos_url":"https://api.github.com/users/hexa00/repos","events_url":"https://api.github.com/users/hexa00/events{/privacy}","received_events_url":"https://api.github.com/users/hexa00/received_events","type":"User","site_admin":false},"body":"This adds debug log support, see the patches commit log for more info\r\n\r\nThe only thing missing is to be able to call logging outside of an injectable context.\r\n\r\nLike to be able to replace the ConsoleLog used in connection.ts for example, I don't know how to manage that if anyone has ideas ?","created_at":"2017-05-31T13:07:46Z","updated_at":"2017-05-31T14:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cf89fe3b9ef522fd1afa5a2d9185327e2b9a439","assignee":null,"assignees":[],"requested_reviewers":[{"login":"svenefftinge","id":372735,"avatar_url":"https://avatars3.githubusercontent.com/u/372735?v=3","gravatar_id":"","url":"https://api.github.com/users/svenefftinge","html_url":"https://github.com/svenefftinge","followers_url":"https://api.github.com/users/svenefftinge/followers","following_url":"https://api.github.com/users/svenefftinge/following{/other_user}","gists_url":"https://api.github.com/users/svenefftinge/gists{/gist_id}","starred_url":"https://api.github.com/users/svenefftinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenefftinge/subscriptions","organizations_url":"https://api.github.com/users/svenefftinge/orgs","repos_url":"https://api.github.com/users/svenefftinge/repos","events_url":"https://api.github.com/users/svenefftinge/events{/privacy}","received_events_url":"https://api.github.com/users/svenefftinge/received_events","type":"User","site_admin":false},{"login":"akosyakov","id":3082655,"avatar_url":"https://avatars1.githubusercontent.com/u/3082655?v=3","gravatar_id":"","url":"https://api.github.com/users/akosyakov","html_url":"https://github.com/akosyakov","followers_url":"https://api.github.com/users/akosyakov/followers","following_url":"https://api.github.com/users/akosyakov/following{/other_user}","gists_url":"https://api.github.com/users/akosyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akosyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akosyakov/subscriptions","organizations_url":"https://api.github.com/users/akosyakov/orgs","repos_url":"https://api.github.com/users/akosyakov/repos","events_url":"https://api.github.com/users/akosyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akosyakov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/167/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/167/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/167/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/86a17f35060829e0161d3a5f3b1ba2a1dd5ef10b","head":{"label":"hexa00:logging","ref":"logging","sha":"86a17f35060829e0161d3a5f3b1ba2a1dd5ef10b","user":{"login":"hexa00","id":698076,"avatar_url":"https://avatars1.githubusercontent.com/u/698076?v=3","gravatar_id":"","url":"https://api.github.com/users/hexa00","html_url":"https://github.com/hexa00","followers_url":"https://api.github.com/users/hexa00/followers","following_url":"https://api.github.com/users/hexa00/following{/other_user}","gists_url":"https://api.github.com/users/hexa00/gists{/gist_id}","starred_url":"https://api.github.com/users/hexa00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexa00/subscriptions","organizations_url":"https://api.github.com/users/hexa00/orgs","repos_url":"https://api.github.com/users/hexa00/repos","events_url":"https://api.github.com/users/hexa00/events{/privacy}","received_events_url":"https://api.github.com/users/hexa00/received_events","type":"User","site_admin":false},"repo":{"id":91334397,"name":"theia","full_name":"hexa00/theia","owner":{"login":"hexa00","id":698076,"avatar_url":"https://avatars1.githubusercontent.com/u/698076?v=3","gravatar_id":"","url":"https://api.github.com/users/hexa00","html_url":"https://github.com/hexa00","followers_url":"https://api.github.com/users/hexa00/followers","following_url":"https://api.github.com/users/hexa00/following{/other_user}","gists_url":"https://api.github.com/users/hexa00/gists{/gist_id}","starred_url":"https://api.github.com/users/hexa00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexa00/subscriptions","organizations_url":"https://api.github.com/users/hexa00/orgs","repos_url":"https://api.github.com/users/hexa00/repos","events_url":"https://api.github.com/users/hexa00/events{/privacy}","received_events_url":"https://api.github.com/users/hexa00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hexa00/theia","description":"Theia is a cloud & desktop IDE implemented in TypeScript.","fork":true,"url":"https://api.github.com/repos/hexa00/theia","forks_url":"https://api.github.com/repos/hexa00/theia/forks","keys_url":"https://api.github.com/repos/hexa00/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hexa00/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hexa00/theia/teams","hooks_url":"https://api.github.com/repos/hexa00/theia/hooks","issue_events_url":"https://api.github.com/repos/hexa00/theia/issues/events{/number}","events_url":"https://api.github.com/repos/hexa00/theia/events","assignees_url":"https://api.github.com/repos/hexa00/theia/assignees{/user}","branches_url":"https://api.github.com/repos/hexa00/theia/branches{/branch}","tags_url":"https://api.github.com/repos/hexa00/theia/tags","blobs_url":"https://api.github.com/repos/hexa00/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hexa00/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hexa00/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/hexa00/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hexa00/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/hexa00/theia/languages","stargazers_url":"https://api.github.com/repos/hexa00/theia/stargazers","contributors_url":"https://api.github.com/repos/hexa00/theia/contributors","subscribers_url":"https://api.github.com/repos/hexa00/theia/subscribers","subscription_url":"https://api.github.com/repos/hexa00/theia/subscription","commits_url":"https://api.github.com/repos/hexa00/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/hexa00/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/hexa00/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/hexa00/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/hexa00/theia/contents/{+path}","compare_url":"https://api.github.com/repos/hexa00/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hexa00/theia/merges","archive_url":"https://api.github.com/repos/hexa00/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hexa00/theia/downloads","issues_url":"https://api.github.com/repos/hexa00/theia/issues{/number}","pulls_url":"https://api.github.com/repos/hexa00/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/hexa00/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/hexa00/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hexa00/theia/labels{/name}","releases_url":"https://api.github.com/repos/hexa00/theia/releases{/id}","deployments_url":"https://api.github.com/repos/hexa00/theia/deployments","created_at":"2017-05-15T12:19:09Z","updated_at":"2017-05-15T12:19:11Z","pushed_at":"2017-05-31T13:02:07Z","git_url":"git://github.com/hexa00/theia.git","ssh_url":"[email protected]:hexa00/theia.git","clone_url":"https://github.com/hexa00/theia.git","svn_url":"https://github.com/hexa00/theia","homepage":"","size":851,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"375428e7625d47505df08b1022a1bcb2c0bdbc5a","user":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars2.githubusercontent.com/u/28530323?v=3","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars2.githubusercontent.com/u/28530323?v=3","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2017-05-31T13:06:07Z","pushed_at":"2017-05-31T14:11:04Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"[email protected]:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"","size":849,"stargazers_count":37,"watchers_count":37,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":59,"forks":14,"open_issues":59,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/167"},"html":{"href":"https://github.com/theia-ide/theia/pull/167"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/167"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/86a17f35060829e0161d3a5f3b1ba2a1dd5ef10b"}}}} | {
"id": 83050680,
"name": "theia-ide/theia",
"url": "https://api.github.com/repos/theia-ide/theia"
} | {
"id": 1405703,
"login": "kittaakos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1405703?",
"url": "https://api.github.com/users/kittaakos"
} | {
"id": 28530323,
"login": "theia-ide",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28530323?",
"url": "https://api.github.com/orgs/theia-ide"
} | 2017-05-31T14:41:55 | 5975286710 | {"actor":{"display_login":"kittaakos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/116386896","pull_request_review_id":38005080,"id":116386896,"diff_hunk":"@@ -14,17 +14,25 @@\n \"theia\": \"file:../../../Theia\"\n },\n \"scripts\": {\n- \"install:theia\": \"cd ../ && npm link && cd examples && npm link theia\",\n- \"clean\": \"./node_modules/.bin/rimraf lib\",\n- \"lint\": \"./node_modules/.bin/tslint -c ../../config/tslint/tslint.json --project ./tsconfig.json\",\n- \"build\": \"npm run build:app && npm run build:web\",\n- \"build:app\": \"./node_modules/.bin/tsc && npm run lint\",\n- \"build:electron\": \"./node_modules/.bin/electron-rebuild && npm run build:app && ./node_modules/.bin/webpack --target electron && cp src/client/index.html lib/client\",\n- \"start:app\": \"./node_modules/.bin/node ./lib/app.js\",\n- \"start:electron\": \"./node_modules/.bin/electron ./lib/client/electron-main.js\",\n- \"cold:start:electron\": \"cd ../../ && npm run clean && npm run build && cd examples/electron && npm run clean && npm run build:app && npm run build:electron && npm run start:electron\",\n- \"watch:app\": \"./node_modules/.bin/tsc --watch\",\n- \"test:ui\": \"./node_modules/.bin/wdio wdio.conf.js\"\n+ \"clean\": \"rimraf lib\",\n+\n+ \"postinstall\": \"electron-rebuild\",\n+ \"prepare\": \"npm run build\",\n+\n+ \"build\": \"npm run build:app && npm run build:electron\",\n+ \"build:app\": \"tsc && npm run lint\",\n+ \"build:electron\": \"npm run build:app && webpack --target electron && cp src/client/index.html lib/client\",\n+ \"lint\": \"tslint -c ../../config/tslint/tslint.json --project ./tsconfig.json\",\n+\n+ \"start\": \"npm run start:electron\",\n+ \"start:app\": \"node ./lib/app.js\",\n+ \"start:electron\": \"electron ./lib/client/electron-main.js\",\n+\n+ \"cold:start:electron\": \"cd ../../ && npm run clean && npm run build && cd examples/electron && npm run clean && npm run build && npm start\",","path":"examples/electron/package.json","position":29,"original_position":29,"commit_id":"0b31b8d8f47a3f433ac5e18d5dc1095ac361c18b","original_commit_id":"0b31b8d8f47a3f433ac5e18d5dc1095ac361c18b","user":{"login":"svenefftinge","id":372735,"avatar_url":"https://avatars3.githubusercontent.com/u/372735?v=3","gravatar_id":"","url":"https://api.github.com/users/svenefftinge","html_url":"https://github.com/svenefftinge","followers_url":"https://api.github.com/users/svenefftinge/followers","following_url":"https://api.github.com/users/svenefftinge/following{/other_user}","gists_url":"https://api.github.com/users/svenefftinge/gists{/gist_id}","starred_url":"https://api.github.com/users/svenefftinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenefftinge/subscriptions","organizations_url":"https://api.github.com/users/svenefftinge/orgs","repos_url":"https://api.github.com/users/svenefftinge/repos","events_url":"https://api.github.com/users/svenefftinge/events{/privacy}","received_events_url":"https://api.github.com/users/svenefftinge/received_events","type":"User","site_admin":false},"body":"since we are in the context of electron, we should remove the `electron` suffix to any scripts. Same for the browser example","created_at":"2017-05-14T18:03:32Z","updated_at":"2017-05-14T18:05:14Z","html_url":"https://github.com/theia-ide/theia/pull/111#discussion_r116386896","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/116386896"},"html":{"href":"https://github.com/theia-ide/theia/pull/111#discussion_r116386896"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/111","id":120463586,"html_url":"https://github.com/theia-ide/theia/pull/111","diff_url":"https://github.com/theia-ide/theia/pull/111.diff","patch_url":"https://github.com/theia-ide/theia/pull/111.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/111","number":111,"state":"open","locked":false,"title":"Package json fixes + developer doc","user":{"login":"simark","id":1758287,"avatar_url":"https://avatars3.githubusercontent.com/u/1758287?v=3","gravatar_id":"","url":"https://api.github.com/users/simark","html_url":"https://github.com/simark","followers_url":"https://api.github.com/users/simark/followers","following_url":"https://api.github.com/users/simark/following{/other_user}","gists_url":"https://api.github.com/users/simark/gists{/gist_id}","starred_url":"https://api.github.com/users/simark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simark/subscriptions","organizations_url":"https://api.github.com/users/simark/orgs","repos_url":"https://api.github.com/users/simark/repos","events_url":"https://api.github.com/users/simark/events{/privacy}","received_events_url":"https://api.github.com/users/simark/received_events","type":"User","site_admin":false},"body":"I did some fixes and improvements to the examples package.json and started writing some developer doc.","created_at":"2017-05-13T21:17:03Z","updated_at":"2017-05-14T18:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d9ab4cf091e44c8e2609513cb68208236bb6502","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/111/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/111/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/111/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/0b31b8d8f47a3f433ac5e18d5dc1095ac361c18b","head":{"label":"simark:package-json-fixes","ref":"package-json-fixes","sha":"0b31b8d8f47a3f433ac5e18d5dc1095ac361c18b","user":{"login":"simark","id":1758287,"avatar_url":"https://avatars3.githubusercontent.com/u/1758287?v=3","gravatar_id":"","url":"https://api.github.com/users/simark","html_url":"https://github.com/simark","followers_url":"https://api.github.com/users/simark/followers","following_url":"https://api.github.com/users/simark/following{/other_user}","gists_url":"https://api.github.com/users/simark/gists{/gist_id}","starred_url":"https://api.github.com/users/simark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simark/subscriptions","organizations_url":"https://api.github.com/users/simark/orgs","repos_url":"https://api.github.com/users/simark/repos","events_url":"https://api.github.com/users/simark/events{/privacy}","received_events_url":"https://api.github.com/users/simark/received_events","type":"User","site_admin":false},"repo":{"id":91202034,"name":"theia","full_name":"simark/theia","owner":{"login":"simark","id":1758287,"avatar_url":"https://avatars3.githubusercontent.com/u/1758287?v=3","gravatar_id":"","url":"https://api.github.com/users/simark","html_url":"https://github.com/simark","followers_url":"https://api.github.com/users/simark/followers","following_url":"https://api.github.com/users/simark/following{/other_user}","gists_url":"https://api.github.com/users/simark/gists{/gist_id}","starred_url":"https://api.github.com/users/simark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simark/subscriptions","organizations_url":"https://api.github.com/users/simark/orgs","repos_url":"https://api.github.com/users/simark/repos","events_url":"https://api.github.com/users/simark/events{/privacy}","received_events_url":"https://api.github.com/users/simark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simark/theia","description":"Theia is a cloud & desktop IDE implemented in TypeScript.","fork":true,"url":"https://api.github.com/repos/simark/theia","forks_url":"https://api.github.com/repos/simark/theia/forks","keys_url":"https://api.github.com/repos/simark/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simark/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simark/theia/teams","hooks_url":"https://api.github.com/repos/simark/theia/hooks","issue_events_url":"https://api.github.com/repos/simark/theia/issues/events{/number}","events_url":"https://api.github.com/repos/simark/theia/events","assignees_url":"https://api.github.com/repos/simark/theia/assignees{/user}","branches_url":"https://api.github.com/repos/simark/theia/branches{/branch}","tags_url":"https://api.github.com/repos/simark/theia/tags","blobs_url":"https://api.github.com/repos/simark/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simark/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simark/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/simark/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simark/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/simark/theia/languages","stargazers_url":"https://api.github.com/repos/simark/theia/stargazers","contributors_url":"https://api.github.com/repos/simark/theia/contributors","subscribers_url":"https://api.github.com/repos/simark/theia/subscribers","subscription_url":"https://api.github.com/repos/simark/theia/subscription","commits_url":"https://api.github.com/repos/simark/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/simark/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/simark/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/simark/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/simark/theia/contents/{+path}","compare_url":"https://api.github.com/repos/simark/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simark/theia/merges","archive_url":"https://api.github.com/repos/simark/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simark/theia/downloads","issues_url":"https://api.github.com/repos/simark/theia/issues{/number}","pulls_url":"https://api.github.com/repos/simark/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/simark/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/simark/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simark/theia/labels{/name}","releases_url":"https://api.github.com/repos/simark/theia/releases{/id}","deployments_url":"https://api.github.com/repos/simark/theia/deployments","created_at":"2017-05-13T20:50:49Z","updated_at":"2017-05-13T20:50:50Z","pushed_at":"2017-05-13T21:17:30Z","git_url":"git://github.com/simark/theia.git","ssh_url":"[email protected]:simark/theia.git","clone_url":"https://github.com/simark/theia.git","svn_url":"https://github.com/simark/theia","homepage":"","size":657,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"974a0da35a4f6c061db30e74ad64ad36669a927c","user":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars2.githubusercontent.com/u/28530323?v=3","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars2.githubusercontent.com/u/28530323?v=3","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2017-05-14T06:45:03Z","pushed_at":"2017-05-14T06:46:09Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"[email protected]:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"","size":650,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":47,"forks":2,"open_issues":47,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/111"},"html":{"href":"https://github.com/theia-ide/theia/pull/111"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/111"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/0b31b8d8f47a3f433ac5e18d5dc1095ac361c18b"}}}} | {
"id": 83050680,
"name": "theia-ide/theia",
"url": "https://api.github.com/repos/theia-ide/theia"
} | {
"id": 372735,
"login": "svenefftinge",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/372735?",
"url": "https://api.github.com/users/svenefftinge"
} | {
"id": 28530323,
"login": "theia-ide",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28530323?",
"url": "https://api.github.com/orgs/theia-ide"
} | 2017-05-14T18:03:32 | 5869055134 | {"actor":{"display_login":"svenefftinge"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/comments/144573119","pull_request_review_id":69242578,"id":144573119,"diff_hunk":"@@ -124,30 +131,63 @@ angular.module(\"summonApp.directives\")\n return template;\n };\n \n- return {\n- link: function(scope, element, attributes) {\n- if(!shouldEnhance(scope)) {\n- return;\n+ function documentSummary(scope, element) {\n+ if(!shouldEnhance(scope)) {\n+ return;\n+ }\n+\n+ var endpoint = getEndpoint(scope);\n+\n+ $.getJSON(endpoint, function(response) {\n+ var data = getData(response);\n+ var browzineWebLink = getBrowZineWebLink(data);\n+ var coverImageUrl = getCoverImageUrl(data, response);\n+\n+ if(browzineWebLink) {\n+ var template = buildTemplate(data, browzineWebLink, bookIcon);\n+ $(element).find(\".docFooter .row:first\").append(template);\n }\n \n- var endpoint = getEndpoint(scope);\n+ if(coverImageUrl) {\n+ $(element).find(\".coverImage img\").attr(\"src\", coverImageUrl);\n+ }\n+ });\n+ };\n \n- http.get(sce.trustAsResourceUrl(endpoint)).then(function(response) {\n- var data = getData(response);\n- var browzineWebLink = getBrowZineWebLink(data);\n- var coverImageUrl = getCoverImageUrl(data, response);\n+ function browZineEnhance(element) {","path":"src/browzine-summon-adapter.js","position":96,"original_position":96,"commit_id":"b800802c3d8a65d1efeb69d8b0b534b5645d16e1","original_commit_id":"b800802c3d8a65d1efeb69d8b0b534b5645d16e1","user":{"login":"karlbecker","id":1091559,"avatar_url":"https://avatars3.githubusercontent.com/u/1091559?v=4","gravatar_id":"","url":"https://api.github.com/users/karlbecker","html_url":"https://github.com/karlbecker","followers_url":"https://api.github.com/users/karlbecker/followers","following_url":"https://api.github.com/users/karlbecker/following{/other_user}","gists_url":"https://api.github.com/users/karlbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/karlbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlbecker/subscriptions","organizations_url":"https://api.github.com/users/karlbecker/orgs","repos_url":"https://api.github.com/users/karlbecker/repos","events_url":"https://api.github.com/users/karlbecker/events{/privacy}","received_events_url":"https://api.github.com/users/karlbecker/received_events","type":"User","site_admin":false},"body":"Total nit, but since \"browzine\" is kind of its own thing, the camel case of `browzineEnhance` might be a little clearer here - otherwise, I read it as \"brow zine enhance\" in my head 😊 ","created_at":"2017-10-13T14:42:27Z","updated_at":"2017-10-13T14:50:05Z","html_url":"https://github.com/thirdiron/browzine-summon-adapter/pull/13#discussion_r144573119","pull_request_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/13","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/comments/144573119"},"html":{"href":"https://github.com/thirdiron/browzine-summon-adapter/pull/13#discussion_r144573119"},"pull_request":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/13","id":146463231,"html_url":"https://github.com/thirdiron/browzine-summon-adapter/pull/13","diff_url":"https://github.com/thirdiron/browzine-summon-adapter/pull/13.diff","patch_url":"https://github.com/thirdiron/browzine-summon-adapter/pull/13.patch","issue_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues/13","number":13,"state":"open","locked":false,"title":"feature/browzine-summon-adapter-rework-BZ-4161","user":{"login":"tiandavis","id":376230,"avatar_url":"https://avatars1.githubusercontent.com/u/376230?v=4","gravatar_id":"","url":"https://api.github.com/users/tiandavis","html_url":"https://github.com/tiandavis","followers_url":"https://api.github.com/users/tiandavis/followers","following_url":"https://api.github.com/users/tiandavis/following{/other_user}","gists_url":"https://api.github.com/users/tiandavis/gists{/gist_id}","starred_url":"https://api.github.com/users/tiandavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiandavis/subscriptions","organizations_url":"https://api.github.com/users/tiandavis/orgs","repos_url":"https://api.github.com/users/tiandavis/repos","events_url":"https://api.github.com/users/tiandavis/events{/privacy}","received_events_url":"https://api.github.com/users/tiandavis/received_events","type":"User","site_admin":false},"body":"Refactors to a MutationObserver and jQuery data sniffing to reduce reliance on Summon loading 3rd party scripts effectively. See, https://thirdiron.atlassian.net/browse/BZ-4161\r\n\r\nProposed Usage? We ask library developers to use this code snippet in their Summon 2.0 External Script:\r\n```\r\nvar browzine = {\r\n api: \"https://api.thirdiron.com/public/v1/libraries/XXX\",\r\n apiKey: \"ENTER API KEY\"\r\n};\r\n\r\nbrowzine.script = document.createElement(\"script\");\r\nbrowzine.script.src = \"https://s3.amazonaws.com/browzine-adapters/summon/browzine-summon-adapter.js\";\r\ndocument.head.appendChild(browzine.script);\r\n```\r\n\r\nThen we can push out enhancement of all sorts without the library ever having to touch the code again. :) Also, less code for the library to handle.\r\n","created_at":"2017-10-13T13:53:28Z","updated_at":"2017-10-13T14:50:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e7be4ef25a3b5a03a49e8e775ae5489967fabe1","assignee":{"login":"tiandavis","id":376230,"avatar_url":"https://avatars1.githubusercontent.com/u/376230?v=4","gravatar_id":"","url":"https://api.github.com/users/tiandavis","html_url":"https://github.com/tiandavis","followers_url":"https://api.github.com/users/tiandavis/followers","following_url":"https://api.github.com/users/tiandavis/following{/other_user}","gists_url":"https://api.github.com/users/tiandavis/gists{/gist_id}","starred_url":"https://api.github.com/users/tiandavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiandavis/subscriptions","organizations_url":"https://api.github.com/users/tiandavis/orgs","repos_url":"https://api.github.com/users/tiandavis/repos","events_url":"https://api.github.com/users/tiandavis/events{/privacy}","received_events_url":"https://api.github.com/users/tiandavis/received_events","type":"User","site_admin":false},"assignees":[{"login":"tiandavis","id":376230,"avatar_url":"https://avatars1.githubusercontent.com/u/376230?v=4","gravatar_id":"","url":"https://api.github.com/users/tiandavis","html_url":"https://github.com/tiandavis","followers_url":"https://api.github.com/users/tiandavis/followers","following_url":"https://api.github.com/users/tiandavis/following{/other_user}","gists_url":"https://api.github.com/users/tiandavis/gists{/gist_id}","starred_url":"https://api.github.com/users/tiandavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiandavis/subscriptions","organizations_url":"https://api.github.com/users/tiandavis/orgs","repos_url":"https://api.github.com/users/tiandavis/repos","events_url":"https://api.github.com/users/tiandavis/events{/privacy}","received_events_url":"https://api.github.com/users/tiandavis/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mike-lang","id":614939,"avatar_url":"https://avatars1.githubusercontent.com/u/614939?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-lang","html_url":"https://github.com/mike-lang","followers_url":"https://api.github.com/users/mike-lang/followers","following_url":"https://api.github.com/users/mike-lang/following{/other_user}","gists_url":"https://api.github.com/users/mike-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-lang/subscriptions","organizations_url":"https://api.github.com/users/mike-lang/orgs","repos_url":"https://api.github.com/users/mike-lang/repos","events_url":"https://api.github.com/users/mike-lang/events{/privacy}","received_events_url":"https://api.github.com/users/mike-lang/received_events","type":"User","site_admin":false},{"login":"KeeganJ","id":1531215,"avatar_url":"https://avatars0.githubusercontent.com/u/1531215?v=4","gravatar_id":"","url":"https://api.github.com/users/KeeganJ","html_url":"https://github.com/KeeganJ","followers_url":"https://api.github.com/users/KeeganJ/followers","following_url":"https://api.github.com/users/KeeganJ/following{/other_user}","gists_url":"https://api.github.com/users/KeeganJ/gists{/gist_id}","starred_url":"https://api.github.com/users/KeeganJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeeganJ/subscriptions","organizations_url":"https://api.github.com/users/KeeganJ/orgs","repos_url":"https://api.github.com/users/KeeganJ/repos","events_url":"https://api.github.com/users/KeeganJ/events{/privacy}","received_events_url":"https://api.github.com/users/KeeganJ/received_events","type":"User","site_admin":false},{"login":"johnseguin","id":1850626,"avatar_url":"https://avatars1.githubusercontent.com/u/1850626?v=4","gravatar_id":"","url":"https://api.github.com/users/johnseguin","html_url":"https://github.com/johnseguin","followers_url":"https://api.github.com/users/johnseguin/followers","following_url":"https://api.github.com/users/johnseguin/following{/other_user}","gists_url":"https://api.github.com/users/johnseguin/gists{/gist_id}","starred_url":"https://api.github.com/users/johnseguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnseguin/subscriptions","organizations_url":"https://api.github.com/users/johnseguin/orgs","repos_url":"https://api.github.com/users/johnseguin/repos","events_url":"https://api.github.com/users/johnseguin/events{/privacy}","received_events_url":"https://api.github.com/users/johnseguin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/13/commits","review_comments_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/13/comments","review_comment_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues/13/comments","statuses_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/statuses/b800802c3d8a65d1efeb69d8b0b534b5645d16e1","head":{"label":"thirdiron:feature/browzine-summon-adapter-rework-BZ-4161","ref":"feature/browzine-summon-adapter-rework-BZ-4161","sha":"b800802c3d8a65d1efeb69d8b0b534b5645d16e1","user":{"login":"thirdiron","id":5099608,"avatar_url":"https://avatars2.githubusercontent.com/u/5099608?v=4","gravatar_id":"","url":"https://api.github.com/users/thirdiron","html_url":"https://github.com/thirdiron","followers_url":"https://api.github.com/users/thirdiron/followers","following_url":"https://api.github.com/users/thirdiron/following{/other_user}","gists_url":"https://api.github.com/users/thirdiron/gists{/gist_id}","starred_url":"https://api.github.com/users/thirdiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirdiron/subscriptions","organizations_url":"https://api.github.com/users/thirdiron/orgs","repos_url":"https://api.github.com/users/thirdiron/repos","events_url":"https://api.github.com/users/thirdiron/events{/privacy}","received_events_url":"https://api.github.com/users/thirdiron/received_events","type":"Organization","site_admin":false},"repo":{"id":101715116,"name":"browzine-summon-adapter","full_name":"thirdiron/browzine-summon-adapter","owner":{"login":"thirdiron","id":5099608,"avatar_url":"https://avatars2.githubusercontent.com/u/5099608?v=4","gravatar_id":"","url":"https://api.github.com/users/thirdiron","html_url":"https://github.com/thirdiron","followers_url":"https://api.github.com/users/thirdiron/followers","following_url":"https://api.github.com/users/thirdiron/following{/other_user}","gists_url":"https://api.github.com/users/thirdiron/gists{/gist_id}","starred_url":"https://api.github.com/users/thirdiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirdiron/subscriptions","organizations_url":"https://api.github.com/users/thirdiron/orgs","repos_url":"https://api.github.com/users/thirdiron/repos","events_url":"https://api.github.com/users/thirdiron/events{/privacy}","received_events_url":"https://api.github.com/users/thirdiron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thirdiron/browzine-summon-adapter","description":"Summon adapter to enhance journal search results with custom BrowZine API data.","fork":false,"url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter","forks_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/forks","keys_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/teams","hooks_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/hooks","issue_events_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/events","assignees_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/tags","blobs_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/languages","stargazers_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/stargazers","contributors_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/contributors","subscribers_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/subscribers","subscription_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/subscription","commits_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/merges","archive_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/downloads","issues_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/labels{/name}","releases_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/deployments","created_at":"2017-08-29T03:31:37Z","updated_at":"2017-10-09T15:53:33Z","pushed_at":"2017-10-13T13:53:29Z","git_url":"git://github.com/thirdiron/browzine-summon-adapter.git","ssh_url":"[email protected]:thirdiron/browzine-summon-adapter.git","clone_url":"https://github.com/thirdiron/browzine-summon-adapter.git","svn_url":"https://github.com/thirdiron/browzine-summon-adapter","homepage":"","size":48,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"thirdiron:develop","ref":"develop","sha":"a61d4814b7cc429e432da3d46881614c4cea5568","user":{"login":"thirdiron","id":5099608,"avatar_url":"https://avatars2.githubusercontent.com/u/5099608?v=4","gravatar_id":"","url":"https://api.github.com/users/thirdiron","html_url":"https://github.com/thirdiron","followers_url":"https://api.github.com/users/thirdiron/followers","following_url":"https://api.github.com/users/thirdiron/following{/other_user}","gists_url":"https://api.github.com/users/thirdiron/gists{/gist_id}","starred_url":"https://api.github.com/users/thirdiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirdiron/subscriptions","organizations_url":"https://api.github.com/users/thirdiron/orgs","repos_url":"https://api.github.com/users/thirdiron/repos","events_url":"https://api.github.com/users/thirdiron/events{/privacy}","received_events_url":"https://api.github.com/users/thirdiron/received_events","type":"Organization","site_admin":false},"repo":{"id":101715116,"name":"browzine-summon-adapter","full_name":"thirdiron/browzine-summon-adapter","owner":{"login":"thirdiron","id":5099608,"avatar_url":"https://avatars2.githubusercontent.com/u/5099608?v=4","gravatar_id":"","url":"https://api.github.com/users/thirdiron","html_url":"https://github.com/thirdiron","followers_url":"https://api.github.com/users/thirdiron/followers","following_url":"https://api.github.com/users/thirdiron/following{/other_user}","gists_url":"https://api.github.com/users/thirdiron/gists{/gist_id}","starred_url":"https://api.github.com/users/thirdiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirdiron/subscriptions","organizations_url":"https://api.github.com/users/thirdiron/orgs","repos_url":"https://api.github.com/users/thirdiron/repos","events_url":"https://api.github.com/users/thirdiron/events{/privacy}","received_events_url":"https://api.github.com/users/thirdiron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thirdiron/browzine-summon-adapter","description":"Summon adapter to enhance journal search results with custom BrowZine API data.","fork":false,"url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter","forks_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/forks","keys_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/teams","hooks_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/hooks","issue_events_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/events","assignees_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/tags","blobs_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/languages","stargazers_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/stargazers","contributors_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/contributors","subscribers_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/subscribers","subscription_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/subscription","commits_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/merges","archive_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/downloads","issues_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/labels{/name}","releases_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/deployments","created_at":"2017-08-29T03:31:37Z","updated_at":"2017-10-09T15:53:33Z","pushed_at":"2017-10-13T13:53:29Z","git_url":"git://github.com/thirdiron/browzine-summon-adapter.git","ssh_url":"[email protected]:thirdiron/browzine-summon-adapter.git","clone_url":"https://github.com/thirdiron/browzine-summon-adapter.git","svn_url":"https://github.com/thirdiron/browzine-summon-adapter","homepage":"","size":48,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/13"},"html":{"href":"https://github.com/thirdiron/browzine-summon-adapter/pull/13"},"issue":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues/13"},"comments":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/thirdiron/browzine-summon-adapter/statuses/b800802c3d8a65d1efeb69d8b0b534b5645d16e1"}},"author_association":"COLLABORATOR"}} | {
"id": 101715116,
"name": "thirdiron/browzine-summon-adapter",
"url": "https://api.github.com/repos/thirdiron/browzine-summon-adapter"
} | {
"id": 1091559,
"login": "karlbecker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1091559?",
"url": "https://api.github.com/users/karlbecker"
} | {
"id": 5099608,
"login": "thirdiron",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5099608?",
"url": "https://api.github.com/orgs/thirdiron"
} | 2017-10-13T14:42:27 | 6713852592 | {"actor":{"display_login":"karlbecker"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tootsuite/mastodon/pulls/comments/112311322","pull_request_review_id":33617048,"id":112311322,"diff_hunk":"@@ -106,13 +106,18 @@ def set_shortcode\n end\n \n def set_type_and_extension\n- if file.blank?\n- self.type = :unknown\n- else\n- self.type = VIDEO_MIME_TYPES.include?(file_content_type) ? :video : :image\n- extension = Paperclip::Interpolations.content_type_extension(file, :original)\n- basename = Paperclip::Interpolations.basename(file, :original)\n- file.instance_write :file_name, [basename, extension].delete_if(&:empty?).join('.')\n- end\n+ self.type = VIDEO_MIME_TYPES.include?(file_content_type) ? :video : :image\n+ extension = appropriate_extension\n+ basename = Paperclip::Interpolations.basename(file, :original)\n+ file.instance_write :file_name, [basename, extension].delete_if(&:empty?).join('.')\n+ end\n+\n+ def appropriate_extension\n+ mime_type = MIME::Types[file.content_type]\n+\n+ extensions_for_mime_type = mime_type.empty? ? [] : mime_type.first.extensions\n+ original_extension = Paperclip::Interpolations.extension(file, :original)\n+\n+ extensions_for_mime_type.include?(original_extension) ? original_extension : extensions_for_mime_type.first","path":"app/models/media_attachment.rb","position":24,"original_position":24,"commit_id":"c8baa6e6d6918bdab5cb16a6f3492426a1f42c47","original_commit_id":"e1bd71e0680445599b52e4d07fd3f14d9324caa0","user":{"login":"saper","id":248374,"avatar_url":"https://avatars1.githubusercontent.com/u/248374?v=3","gravatar_id":"","url":"https://api.github.com/users/saper","html_url":"https://github.com/saper","followers_url":"https://api.github.com/users/saper/followers","following_url":"https://api.github.com/users/saper/following{/other_user}","gists_url":"https://api.github.com/users/saper/gists{/gist_id}","starred_url":"https://api.github.com/users/saper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saper/subscriptions","organizations_url":"https://api.github.com/users/saper/orgs","repos_url":"https://api.github.com/users/saper/repos","events_url":"https://api.github.com/users/saper/events{/privacy}","received_events_url":"https://api.github.com/users/saper/received_events","type":"User","site_admin":false},"body":"So maybe the style definition is wrong here? I thought the intention was here if the number of frames is 1 we leave the file alone? ","created_at":"2017-04-19T20:54:46Z","updated_at":"2017-04-19T20:54:46Z","html_url":"https://github.com/tootsuite/mastodon/pull/2171#discussion_r112311322","pull_request_url":"https://api.github.com/repos/tootsuite/mastodon/pulls/2171","_links":{"self":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/comments/112311322"},"html":{"href":"https://github.com/tootsuite/mastodon/pull/2171#discussion_r112311322"},"pull_request":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/2171"}}},"pull_request":{"url":"https://api.github.com/repos/tootsuite/mastodon/pulls/2171","id":116632126,"html_url":"https://github.com/tootsuite/mastodon/pull/2171","diff_url":"https://github.com/tootsuite/mastodon/pull/2171.diff","patch_url":"https://github.com/tootsuite/mastodon/pull/2171.patch","issue_url":"https://api.github.com/repos/tootsuite/mastodon/issues/2171","number":2171,"state":"open","locked":false,"title":"Fix #2108 - Fix gif uploads","user":{"login":"Gargron","id":184731,"avatar_url":"https://avatars0.githubusercontent.com/u/184731?v=3","gravatar_id":"","url":"https://api.github.com/users/Gargron","html_url":"https://github.com/Gargron","followers_url":"https://api.github.com/users/Gargron/followers","following_url":"https://api.github.com/users/Gargron/following{/other_user}","gists_url":"https://api.github.com/users/Gargron/gists{/gist_id}","starred_url":"https://api.github.com/users/Gargron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gargron/subscriptions","organizations_url":"https://api.github.com/users/Gargron/orgs","repos_url":"https://api.github.com/users/Gargron/repos","events_url":"https://api.github.com/users/Gargron/events{/privacy}","received_events_url":"https://api.github.com/users/Gargron/received_events","type":"User","site_admin":false},"body":"Add specs for media attachment gifv conversion","created_at":"2017-04-19T20:14:25Z","updated_at":"2017-04-19T20:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f393abae429c68f999e04ef71ff43253594d7cb8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tootsuite/mastodon/pulls/2171/commits","review_comments_url":"https://api.github.com/repos/tootsuite/mastodon/pulls/2171/comments","review_comment_url":"https://api.github.com/repos/tootsuite/mastodon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tootsuite/mastodon/issues/2171/comments","statuses_url":"https://api.github.com/repos/tootsuite/mastodon/statuses/c8baa6e6d6918bdab5cb16a6f3492426a1f42c47","head":{"label":"tootsuite:fix-gif-uploads","ref":"fix-gif-uploads","sha":"c8baa6e6d6918bdab5cb16a6f3492426a1f42c47","user":{"login":"tootsuite","id":24979032,"avatar_url":"https://avatars0.githubusercontent.com/u/24979032?v=3","gravatar_id":"","url":"https://api.github.com/users/tootsuite","html_url":"https://github.com/tootsuite","followers_url":"https://api.github.com/users/tootsuite/followers","following_url":"https://api.github.com/users/tootsuite/following{/other_user}","gists_url":"https://api.github.com/users/tootsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/tootsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tootsuite/subscriptions","organizations_url":"https://api.github.com/users/tootsuite/orgs","repos_url":"https://api.github.com/users/tootsuite/repos","events_url":"https://api.github.com/users/tootsuite/events{/privacy}","received_events_url":"https://api.github.com/users/tootsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":52281283,"name":"mastodon","full_name":"tootsuite/mastodon","owner":{"login":"tootsuite","id":24979032,"avatar_url":"https://avatars0.githubusercontent.com/u/24979032?v=3","gravatar_id":"","url":"https://api.github.com/users/tootsuite","html_url":"https://github.com/tootsuite","followers_url":"https://api.github.com/users/tootsuite/followers","following_url":"https://api.github.com/users/tootsuite/following{/other_user}","gists_url":"https://api.github.com/users/tootsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/tootsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tootsuite/subscriptions","organizations_url":"https://api.github.com/users/tootsuite/orgs","repos_url":"https://api.github.com/users/tootsuite/repos","events_url":"https://api.github.com/users/tootsuite/events{/privacy}","received_events_url":"https://api.github.com/users/tootsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tootsuite/mastodon","description":"A GNU Social-compatible microblogging server","fork":false,"url":"https://api.github.com/repos/tootsuite/mastodon","forks_url":"https://api.github.com/repos/tootsuite/mastodon/forks","keys_url":"https://api.github.com/repos/tootsuite/mastodon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tootsuite/mastodon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tootsuite/mastodon/teams","hooks_url":"https://api.github.com/repos/tootsuite/mastodon/hooks","issue_events_url":"https://api.github.com/repos/tootsuite/mastodon/issues/events{/number}","events_url":"https://api.github.com/repos/tootsuite/mastodon/events","assignees_url":"https://api.github.com/repos/tootsuite/mastodon/assignees{/user}","branches_url":"https://api.github.com/repos/tootsuite/mastodon/branches{/branch}","tags_url":"https://api.github.com/repos/tootsuite/mastodon/tags","blobs_url":"https://api.github.com/repos/tootsuite/mastodon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tootsuite/mastodon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tootsuite/mastodon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tootsuite/mastodon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tootsuite/mastodon/statuses/{sha}","languages_url":"https://api.github.com/repos/tootsuite/mastodon/languages","stargazers_url":"https://api.github.com/repos/tootsuite/mastodon/stargazers","contributors_url":"https://api.github.com/repos/tootsuite/mastodon/contributors","subscribers_url":"https://api.github.com/repos/tootsuite/mastodon/subscribers","subscription_url":"https://api.github.com/repos/tootsuite/mastodon/subscription","commits_url":"https://api.github.com/repos/tootsuite/mastodon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tootsuite/mastodon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tootsuite/mastodon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tootsuite/mastodon/issues/comments{/number}","contents_url":"https://api.github.com/repos/tootsuite/mastodon/contents/{+path}","compare_url":"https://api.github.com/repos/tootsuite/mastodon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tootsuite/mastodon/merges","archive_url":"https://api.github.com/repos/tootsuite/mastodon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tootsuite/mastodon/downloads","issues_url":"https://api.github.com/repos/tootsuite/mastodon/issues{/number}","pulls_url":"https://api.github.com/repos/tootsuite/mastodon/pulls{/number}","milestones_url":"https://api.github.com/repos/tootsuite/mastodon/milestones{/number}","notifications_url":"https://api.github.com/repos/tootsuite/mastodon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tootsuite/mastodon/labels{/name}","releases_url":"https://api.github.com/repos/tootsuite/mastodon/releases{/id}","deployments_url":"https://api.github.com/repos/tootsuite/mastodon/deployments","created_at":"2016-02-22T15:01:25Z","updated_at":"2017-04-19T20:26:23Z","pushed_at":"2017-04-19T20:53:59Z","git_url":"git://github.com/tootsuite/mastodon.git","ssh_url":"[email protected]:tootsuite/mastodon.git","clone_url":"https://github.com/tootsuite/mastodon.git","svn_url":"https://github.com/tootsuite/mastodon","homepage":"https://mastodon.social","size":35397,"stargazers_count":7541,"watchers_count":7541,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1204,"mirror_url":null,"open_issues_count":641,"forks":1204,"open_issues":641,"watchers":7541,"default_branch":"master"}},"base":{"label":"tootsuite:master","ref":"master","sha":"09dad88853966ca1f2de96881393da65f55340d7","user":{"login":"tootsuite","id":24979032,"avatar_url":"https://avatars0.githubusercontent.com/u/24979032?v=3","gravatar_id":"","url":"https://api.github.com/users/tootsuite","html_url":"https://github.com/tootsuite","followers_url":"https://api.github.com/users/tootsuite/followers","following_url":"https://api.github.com/users/tootsuite/following{/other_user}","gists_url":"https://api.github.com/users/tootsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/tootsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tootsuite/subscriptions","organizations_url":"https://api.github.com/users/tootsuite/orgs","repos_url":"https://api.github.com/users/tootsuite/repos","events_url":"https://api.github.com/users/tootsuite/events{/privacy}","received_events_url":"https://api.github.com/users/tootsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":52281283,"name":"mastodon","full_name":"tootsuite/mastodon","owner":{"login":"tootsuite","id":24979032,"avatar_url":"https://avatars0.githubusercontent.com/u/24979032?v=3","gravatar_id":"","url":"https://api.github.com/users/tootsuite","html_url":"https://github.com/tootsuite","followers_url":"https://api.github.com/users/tootsuite/followers","following_url":"https://api.github.com/users/tootsuite/following{/other_user}","gists_url":"https://api.github.com/users/tootsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/tootsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tootsuite/subscriptions","organizations_url":"https://api.github.com/users/tootsuite/orgs","repos_url":"https://api.github.com/users/tootsuite/repos","events_url":"https://api.github.com/users/tootsuite/events{/privacy}","received_events_url":"https://api.github.com/users/tootsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tootsuite/mastodon","description":"A GNU Social-compatible microblogging server","fork":false,"url":"https://api.github.com/repos/tootsuite/mastodon","forks_url":"https://api.github.com/repos/tootsuite/mastodon/forks","keys_url":"https://api.github.com/repos/tootsuite/mastodon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tootsuite/mastodon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tootsuite/mastodon/teams","hooks_url":"https://api.github.com/repos/tootsuite/mastodon/hooks","issue_events_url":"https://api.github.com/repos/tootsuite/mastodon/issues/events{/number}","events_url":"https://api.github.com/repos/tootsuite/mastodon/events","assignees_url":"https://api.github.com/repos/tootsuite/mastodon/assignees{/user}","branches_url":"https://api.github.com/repos/tootsuite/mastodon/branches{/branch}","tags_url":"https://api.github.com/repos/tootsuite/mastodon/tags","blobs_url":"https://api.github.com/repos/tootsuite/mastodon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tootsuite/mastodon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tootsuite/mastodon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tootsuite/mastodon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tootsuite/mastodon/statuses/{sha}","languages_url":"https://api.github.com/repos/tootsuite/mastodon/languages","stargazers_url":"https://api.github.com/repos/tootsuite/mastodon/stargazers","contributors_url":"https://api.github.com/repos/tootsuite/mastodon/contributors","subscribers_url":"https://api.github.com/repos/tootsuite/mastodon/subscribers","subscription_url":"https://api.github.com/repos/tootsuite/mastodon/subscription","commits_url":"https://api.github.com/repos/tootsuite/mastodon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tootsuite/mastodon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tootsuite/mastodon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tootsuite/mastodon/issues/comments{/number}","contents_url":"https://api.github.com/repos/tootsuite/mastodon/contents/{+path}","compare_url":"https://api.github.com/repos/tootsuite/mastodon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tootsuite/mastodon/merges","archive_url":"https://api.github.com/repos/tootsuite/mastodon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tootsuite/mastodon/downloads","issues_url":"https://api.github.com/repos/tootsuite/mastodon/issues{/number}","pulls_url":"https://api.github.com/repos/tootsuite/mastodon/pulls{/number}","milestones_url":"https://api.github.com/repos/tootsuite/mastodon/milestones{/number}","notifications_url":"https://api.github.com/repos/tootsuite/mastodon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tootsuite/mastodon/labels{/name}","releases_url":"https://api.github.com/repos/tootsuite/mastodon/releases{/id}","deployments_url":"https://api.github.com/repos/tootsuite/mastodon/deployments","created_at":"2016-02-22T15:01:25Z","updated_at":"2017-04-19T20:26:23Z","pushed_at":"2017-04-19T20:53:59Z","git_url":"git://github.com/tootsuite/mastodon.git","ssh_url":"[email protected]:tootsuite/mastodon.git","clone_url":"https://github.com/tootsuite/mastodon.git","svn_url":"https://github.com/tootsuite/mastodon","homepage":"https://mastodon.social","size":35397,"stargazers_count":7541,"watchers_count":7541,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1204,"mirror_url":null,"open_issues_count":641,"forks":1204,"open_issues":641,"watchers":7541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/2171"},"html":{"href":"https://github.com/tootsuite/mastodon/pull/2171"},"issue":{"href":"https://api.github.com/repos/tootsuite/mastodon/issues/2171"},"comments":{"href":"https://api.github.com/repos/tootsuite/mastodon/issues/2171/comments"},"review_comments":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/2171/comments"},"review_comment":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/2171/commits"},"statuses":{"href":"https://api.github.com/repos/tootsuite/mastodon/statuses/c8baa6e6d6918bdab5cb16a6f3492426a1f42c47"}}}} | {
"id": 52281283,
"name": "tootsuite/mastodon",
"url": "https://api.github.com/repos/tootsuite/mastodon"
} | {
"id": 248374,
"login": "saper",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/248374?",
"url": "https://api.github.com/users/saper"
} | {
"id": 24979032,
"login": "tootsuite",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24979032?",
"url": "https://api.github.com/orgs/tootsuite"
} | 2017-04-19T20:54:46 | 5719011264 | {"actor":{"display_login":"saper"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/typelevel/cats/pulls/comments/136133665","pull_request_review_id":59629017,"id":136133665,"diff_hunk":"@@ -407,6 +407,31 @@ import simulacrum.typeclass\n }.toList\n \n /**\n+ * Separate this Foldable into a Tuple by a separating function `A => Either[B, C]`\n+ * Equivalent to `Functor#map` and then `Alternative#separate`.","path":"core/src/main/scala/cats/Foldable.scala","position":5,"original_position":5,"commit_id":"c7f3b69adf99a54df0250e0f1f6b376feb0c6289","original_commit_id":"c7f3b69adf99a54df0250e0f1f6b376feb0c6289","user":{"login":"peterneyens","id":6407606,"avatar_url":"https://avatars1.githubusercontent.com/u/6407606?v=4","gravatar_id":"","url":"https://api.github.com/users/peterneyens","html_url":"https://github.com/peterneyens","followers_url":"https://api.github.com/users/peterneyens/followers","following_url":"https://api.github.com/users/peterneyens/following{/other_user}","gists_url":"https://api.github.com/users/peterneyens/gists{/gist_id}","starred_url":"https://api.github.com/users/peterneyens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterneyens/subscriptions","organizations_url":"https://api.github.com/users/peterneyens/orgs","repos_url":"https://api.github.com/users/peterneyens/repos","events_url":"https://api.github.com/users/peterneyens/events{/privacy}","received_events_url":"https://api.github.com/users/peterneyens/received_events","type":"User","site_admin":false},"body":"If we did define it in `Alternative`, we could add a consistency law checking this equality, but hey ... you can't always get what you want :smiley: \r\n ","created_at":"2017-08-30T17:16:26Z","updated_at":"2017-08-30T17:16:36Z","html_url":"https://github.com/typelevel/cats/pull/1858#discussion_r136133665","pull_request_url":"https://api.github.com/repos/typelevel/cats/pulls/1858","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/typelevel/cats/pulls/comments/136133665"},"html":{"href":"https://github.com/typelevel/cats/pull/1858#discussion_r136133665"},"pull_request":{"href":"https://api.github.com/repos/typelevel/cats/pulls/1858"}}},"pull_request":{"url":"https://api.github.com/repos/typelevel/cats/pulls/1858","id":137793538,"html_url":"https://github.com/typelevel/cats/pull/1858","diff_url":"https://github.com/typelevel/cats/pull/1858.diff","patch_url":"https://github.com/typelevel/cats/pull/1858.patch","issue_url":"https://api.github.com/repos/typelevel/cats/issues/1858","number":1858,"state":"open","locked":false,"title":"Add NonEmptyList#partitionE","user":{"login":"LukaJCB","id":9531747,"avatar_url":"https://avatars1.githubusercontent.com/u/9531747?v=4","gravatar_id":"","url":"https://api.github.com/users/LukaJCB","html_url":"https://github.com/LukaJCB","followers_url":"https://api.github.com/users/LukaJCB/followers","following_url":"https://api.github.com/users/LukaJCB/following{/other_user}","gists_url":"https://api.github.com/users/LukaJCB/gists{/gist_id}","starred_url":"https://api.github.com/users/LukaJCB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukaJCB/subscriptions","organizations_url":"https://api.github.com/users/LukaJCB/orgs","repos_url":"https://api.github.com/users/LukaJCB/repos","events_url":"https://api.github.com/users/LukaJCB/events{/privacy}","received_events_url":"https://api.github.com/users/LukaJCB/received_events","type":"User","site_admin":false},"body":"As per #1743 (now closed). Also open for alternative names (`partitionIor` maybe?)","created_at":"2017-08-26T10:21:38Z","updated_at":"2017-08-30T17:16:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24868d1f8f918dd82a204e4d7d871a1d5b1857a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/typelevel/cats/pulls/1858/commits","review_comments_url":"https://api.github.com/repos/typelevel/cats/pulls/1858/comments","review_comment_url":"https://api.github.com/repos/typelevel/cats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typelevel/cats/issues/1858/comments","statuses_url":"https://api.github.com/repos/typelevel/cats/statuses/c7f3b69adf99a54df0250e0f1f6b376feb0c6289","head":{"label":"LukaJCB:add-partitione-nel","ref":"add-partitione-nel","sha":"c7f3b69adf99a54df0250e0f1f6b376feb0c6289","user":{"login":"LukaJCB","id":9531747,"avatar_url":"https://avatars1.githubusercontent.com/u/9531747?v=4","gravatar_id":"","url":"https://api.github.com/users/LukaJCB","html_url":"https://github.com/LukaJCB","followers_url":"https://api.github.com/users/LukaJCB/followers","following_url":"https://api.github.com/users/LukaJCB/following{/other_user}","gists_url":"https://api.github.com/users/LukaJCB/gists{/gist_id}","starred_url":"https://api.github.com/users/LukaJCB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukaJCB/subscriptions","organizations_url":"https://api.github.com/users/LukaJCB/orgs","repos_url":"https://api.github.com/users/LukaJCB/repos","events_url":"https://api.github.com/users/LukaJCB/events{/privacy}","received_events_url":"https://api.github.com/users/LukaJCB/received_events","type":"User","site_admin":false},"repo":{"id":85697442,"name":"cats","full_name":"LukaJCB/cats","owner":{"login":"LukaJCB","id":9531747,"avatar_url":"https://avatars1.githubusercontent.com/u/9531747?v=4","gravatar_id":"","url":"https://api.github.com/users/LukaJCB","html_url":"https://github.com/LukaJCB","followers_url":"https://api.github.com/users/LukaJCB/followers","following_url":"https://api.github.com/users/LukaJCB/following{/other_user}","gists_url":"https://api.github.com/users/LukaJCB/gists{/gist_id}","starred_url":"https://api.github.com/users/LukaJCB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukaJCB/subscriptions","organizations_url":"https://api.github.com/users/LukaJCB/orgs","repos_url":"https://api.github.com/users/LukaJCB/repos","events_url":"https://api.github.com/users/LukaJCB/events{/privacy}","received_events_url":"https://api.github.com/users/LukaJCB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LukaJCB/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":true,"url":"https://api.github.com/repos/LukaJCB/cats","forks_url":"https://api.github.com/repos/LukaJCB/cats/forks","keys_url":"https://api.github.com/repos/LukaJCB/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LukaJCB/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LukaJCB/cats/teams","hooks_url":"https://api.github.com/repos/LukaJCB/cats/hooks","issue_events_url":"https://api.github.com/repos/LukaJCB/cats/issues/events{/number}","events_url":"https://api.github.com/repos/LukaJCB/cats/events","assignees_url":"https://api.github.com/repos/LukaJCB/cats/assignees{/user}","branches_url":"https://api.github.com/repos/LukaJCB/cats/branches{/branch}","tags_url":"https://api.github.com/repos/LukaJCB/cats/tags","blobs_url":"https://api.github.com/repos/LukaJCB/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LukaJCB/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LukaJCB/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/LukaJCB/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LukaJCB/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/LukaJCB/cats/languages","stargazers_url":"https://api.github.com/repos/LukaJCB/cats/stargazers","contributors_url":"https://api.github.com/repos/LukaJCB/cats/contributors","subscribers_url":"https://api.github.com/repos/LukaJCB/cats/subscribers","subscription_url":"https://api.github.com/repos/LukaJCB/cats/subscription","commits_url":"https://api.github.com/repos/LukaJCB/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/LukaJCB/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/LukaJCB/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/LukaJCB/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/LukaJCB/cats/contents/{+path}","compare_url":"https://api.github.com/repos/LukaJCB/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LukaJCB/cats/merges","archive_url":"https://api.github.com/repos/LukaJCB/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LukaJCB/cats/downloads","issues_url":"https://api.github.com/repos/LukaJCB/cats/issues{/number}","pulls_url":"https://api.github.com/repos/LukaJCB/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/LukaJCB/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/LukaJCB/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LukaJCB/cats/labels{/name}","releases_url":"https://api.github.com/repos/LukaJCB/cats/releases{/id}","deployments_url":"https://api.github.com/repos/LukaJCB/cats/deployments","created_at":"2017-03-21T12:09:55Z","updated_at":"2017-03-21T12:09:57Z","pushed_at":"2017-08-30T15:31:29Z","git_url":"git://github.com/LukaJCB/cats.git","ssh_url":"[email protected]:LukaJCB/cats.git","clone_url":"https://github.com/LukaJCB/cats.git","svn_url":"https://github.com/LukaJCB/cats","homepage":"http://typelevel.org/cats/","size":16537,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typelevel:master","ref":"master","sha":"14d9c10499e3ef63349d8f90c0dea2a06dcb46aa","user":{"login":"typelevel","id":3731824,"avatar_url":"https://avatars0.githubusercontent.com/u/3731824?v=4","gravatar_id":"","url":"https://api.github.com/users/typelevel","html_url":"https://github.com/typelevel","followers_url":"https://api.github.com/users/typelevel/followers","following_url":"https://api.github.com/users/typelevel/following{/other_user}","gists_url":"https://api.github.com/users/typelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/typelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typelevel/subscriptions","organizations_url":"https://api.github.com/users/typelevel/orgs","repos_url":"https://api.github.com/users/typelevel/repos","events_url":"https://api.github.com/users/typelevel/events{/privacy}","received_events_url":"https://api.github.com/users/typelevel/received_events","type":"Organization","site_admin":false},"repo":{"id":29986727,"name":"cats","full_name":"typelevel/cats","owner":{"login":"typelevel","id":3731824,"avatar_url":"https://avatars0.githubusercontent.com/u/3731824?v=4","gravatar_id":"","url":"https://api.github.com/users/typelevel","html_url":"https://github.com/typelevel","followers_url":"https://api.github.com/users/typelevel/followers","following_url":"https://api.github.com/users/typelevel/following{/other_user}","gists_url":"https://api.github.com/users/typelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/typelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typelevel/subscriptions","organizations_url":"https://api.github.com/users/typelevel/orgs","repos_url":"https://api.github.com/users/typelevel/repos","events_url":"https://api.github.com/users/typelevel/events{/privacy}","received_events_url":"https://api.github.com/users/typelevel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typelevel/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":false,"url":"https://api.github.com/repos/typelevel/cats","forks_url":"https://api.github.com/repos/typelevel/cats/forks","keys_url":"https://api.github.com/repos/typelevel/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typelevel/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typelevel/cats/teams","hooks_url":"https://api.github.com/repos/typelevel/cats/hooks","issue_events_url":"https://api.github.com/repos/typelevel/cats/issues/events{/number}","events_url":"https://api.github.com/repos/typelevel/cats/events","assignees_url":"https://api.github.com/repos/typelevel/cats/assignees{/user}","branches_url":"https://api.github.com/repos/typelevel/cats/branches{/branch}","tags_url":"https://api.github.com/repos/typelevel/cats/tags","blobs_url":"https://api.github.com/repos/typelevel/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typelevel/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typelevel/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/typelevel/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typelevel/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/typelevel/cats/languages","stargazers_url":"https://api.github.com/repos/typelevel/cats/stargazers","contributors_url":"https://api.github.com/repos/typelevel/cats/contributors","subscribers_url":"https://api.github.com/repos/typelevel/cats/subscribers","subscription_url":"https://api.github.com/repos/typelevel/cats/subscription","commits_url":"https://api.github.com/repos/typelevel/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/typelevel/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/typelevel/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/typelevel/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/typelevel/cats/contents/{+path}","compare_url":"https://api.github.com/repos/typelevel/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typelevel/cats/merges","archive_url":"https://api.github.com/repos/typelevel/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typelevel/cats/downloads","issues_url":"https://api.github.com/repos/typelevel/cats/issues{/number}","pulls_url":"https://api.github.com/repos/typelevel/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/typelevel/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/typelevel/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typelevel/cats/labels{/name}","releases_url":"https://api.github.com/repos/typelevel/cats/releases{/id}","deployments_url":"https://api.github.com/repos/typelevel/cats/deployments","created_at":"2015-01-28T20:26:48Z","updated_at":"2017-08-30T11:06:23Z","pushed_at":"2017-08-30T15:54:06Z","git_url":"git://github.com/typelevel/cats.git","ssh_url":"[email protected]:typelevel/cats.git","clone_url":"https://github.com/typelevel/cats.git","svn_url":"https://github.com/typelevel/cats","homepage":"http://typelevel.org/cats/","size":18037,"stargazers_count":1973,"watchers_count":1973,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":458,"mirror_url":null,"open_issues_count":245,"forks":458,"open_issues":245,"watchers":1973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typelevel/cats/pulls/1858"},"html":{"href":"https://github.com/typelevel/cats/pull/1858"},"issue":{"href":"https://api.github.com/repos/typelevel/cats/issues/1858"},"comments":{"href":"https://api.github.com/repos/typelevel/cats/issues/1858/comments"},"review_comments":{"href":"https://api.github.com/repos/typelevel/cats/pulls/1858/comments"},"review_comment":{"href":"https://api.github.com/repos/typelevel/cats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typelevel/cats/pulls/1858/commits"},"statuses":{"href":"https://api.github.com/repos/typelevel/cats/statuses/c7f3b69adf99a54df0250e0f1f6b376feb0c6289"}},"author_association":"CONTRIBUTOR"}} | {
"id": 29986727,
"name": "typelevel/cats",
"url": "https://api.github.com/repos/typelevel/cats"
} | {
"id": 6407606,
"login": "peterneyens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6407606?",
"url": "https://api.github.com/users/peterneyens"
} | {
"id": 3731824,
"login": "typelevel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3731824?",
"url": "https://api.github.com/orgs/typelevel"
} | 2017-08-30T17:16:26 | 6531062373 | {"actor":{"display_login":"peterneyens"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/comments/148757132","pull_request_review_id":74049442,"id":148757132,"diff_hunk":"@@ -1,9 +1,502 @@\n <!DOCTYPE html>\n-<html lang=\"ru\">\n+<html lang=\"en\">\n <head>\n <meta charset=\"utf-8\">\n+ <link href=\"index.css\" rel=\"stylesheet\">\n <title>Задача «Мяндекс.Муррркет»</title>\n </head>\n <body>\n+<input id=\"tile-layout-switch\" class=\"tile-layout-switch\" type=\"radio\" name=\"switch\" checked>\n+<input id=\"card-layout-switch\" class=\"card-layout-switch\" type=\"radio\" name=\"switch\">\n+<header class=\"main-header\">\n+ <h1>\n+ Catdex.Market\n+ </h1>\n+ <div class=\"layout-switches\">\n+ <label for=\"card-layout-switch\">Карточки</label>\n+ <label for=\"tile-layout-switch\">Плитки</label>\n+ </div>\n+</header>\n+<main>\n+ <article class=\"market-item\">\n+ <div class=\"item-picture\">\n+ <img src=\"pictures/longcatislong.jpg\" alt=\"Cat longcat\">\n+ </div>\n+ <section class=\"item-info\">\n+ <h2><a href=\"http://knowyourmeme.com/memes/longcat\" title=\"Longcat info\">\n+ Loooooooooooooooooooooooooooongcat\n+ </a></h2>\n+ <p class=\"item-info-price\">\n+ $100000000000000000000000000000000000000\n+ </p>\n+ <p class=\"item-cat-egory\">\n+ <em>Category:</em> <a href=\"real\" title=\"See category\">Real cats</a>\n+ </p>\n+ <p class=\"item-info-descr\">\n+ Longcat is one of the most recognized cats on the Internet. He is known for his epic\n+ length, spawning photoshops and even an entire mythology around his magnitude.\n+ </p>\n+ <fieldset class=\"rating\">\n+ <input type=\"radio\" id=\"rate-1-10\" name=\"rate-1\" value=\"10\" checked>\n+ <label for=\"rate-1-10\"></label>\n+ <input type=\"radio\" id=\"rate-1-9\" name=\"rate-1\" value=\"9\">\n+ <label for=\"rate-1-9\"></label>\n+ <input type=\"radio\" id=\"rate-1-8\" name=\"rate-1\" value=\"8\">\n+ <label for=\"rate-1-8\"></label>\n+ <input type=\"radio\" id=\"rate-1-7\" name=\"rate-1\" value=\"7\">\n+ <label for=\"rate-1-7\"></label>\n+ <input type=\"radio\" id=\"rate-1-6\" name=\"rate-1\" value=\"6\">\n+ <label for=\"rate-1-6\"></label>\n+ <input type=\"radio\" id=\"rate-1-5\" name=\"rate-1\" value=\"5\">\n+ <label for=\"rate-1-5\"></label>\n+ <input type=\"radio\" id=\"rate-1-4\" name=\"rate-1\" value=\"4\">\n+ <label for=\"rate-1-4\"></label>\n+ <input type=\"radio\" id=\"rate-1-3\" name=\"rate-1\" value=\"3\">\n+ <label for=\"rate-1-3\"></label>\n+ <input type=\"radio\" id=\"rate-1-2\" name=\"rate-1\" value=\"2\">\n+ <label for=\"rate-1-2\"></label>\n+ <input type=\"radio\" id=\"rate-1-1\" name=\"rate-1\" value=\"1\">\n+ <label for=\"rate-1-1\"></label>\n+ </fieldset>\n+ </section>\n+ </article>\n+ <article class=\"market-item\">\n+ <div class=\"item-picture\">\n+ <img src=\"pictures/seriouscat.jpg\" alt=\"Cat serious cat\">\n+ </div>\n+ <section class=\"item-info\">\n+ <h2><a href=\"http://knowyourmeme.com/memes/serious-cat\" title=\"Serious cat info\">\n+ Serious cat\n+ </a></h2>\n+ <p class=\"item-info-price\">\n+ <span class=\"item-old-price\">$25.13</span>\n+ <span>$25.12</span>\n+ </p>\n+ <p class=\"item-cat-egory\">\n+ <em>Category:</em> <a href=\"real\" title=\"See category\">Real cats</a>\n+ </p>\n+ <p class=\"item-info-descr\">\n+ Serious Cat is a popular image macro featuring a picture of a white cat …looking\n+ srsly serious. The image is typically accompanied by a caption that reads:\n+ </p>\n+ <blockquote><q>I Are Serious Cat. This is Serious Thread.</q></blockquote>\n+ <fieldset class=\"rating\">\n+ <input type=\"radio\" id=\"rate-2-10\" name=\"rate-2\" value=\"10\">\n+ <label for=\"rate-2-10\"></label>\n+ <input type=\"radio\" id=\"rate-2-9\" name=\"rate-2\" value=\"9\">\n+ <label for=\"rate-2-9\"></label>\n+ <input type=\"radio\" id=\"rate-2-8\" name=\"rate-2\" value=\"8\" checked>\n+ <label for=\"rate-2-8\"></label>\n+ <input type=\"radio\" id=\"rate-2-7\" name=\"rate-2\" value=\"7\">\n+ <label for=\"rate-2-7\"></label>\n+ <input type=\"radio\" id=\"rate-2-6\" name=\"rate-2\" value=\"6\">\n+ <label for=\"rate-2-6\"></label>\n+ <input type=\"radio\" id=\"rate-2-5\" name=\"rate-2\" value=\"5\">\n+ <label for=\"rate-2-5\"></label>\n+ <input type=\"radio\" id=\"rate-2-4\" name=\"rate-2\" value=\"4\">\n+ <label for=\"rate-2-4\"></label>\n+ <input type=\"radio\" id=\"rate-2-3\" name=\"rate-2\" value=\"3\">\n+ <label for=\"rate-2-3\"></label>\n+ <input type=\"radio\" id=\"rate-2-2\" name=\"rate-2\" value=\"2\">\n+ <label for=\"rate-2-2\"></label>\n+ <input type=\"radio\" id=\"rate-2-1\" name=\"rate-2\" value=\"1\">\n+ <label for=\"rate-2-1\"></label>\n+ </fieldset>\n+ </section>\n+ </article>\n+ <article class=\"market-item\">\n+ <div class=\"item-picture\">\n+ <img src=\"pictures/schrodingercat.jpg\" alt=\"Cat or not cat\">\n+ </div>\n+ <section class=\"item-info\">\n+ <h2><a href=\"https://en.wikipedia.org/wiki/Schr%C3%B6dinger%27s_cat\"\n+ title=\"Schrodinger cat info\">\n+ Schrödinger's cat\n+ </a></h2>\n+ <p class=\"item-info-price\">\n+ $????\n+ </p>\n+ <p class=\"item-cat-egory\">\n+ <em>Category:</em> <a href=\"sceince\" title=\"See category\">Science cats</a>\n+ </p>\n+ <p class=\"item-info-descr\">\n+ Schrödinger's cat is a thought experiment, sometimes described as a paradox, devised\n+ by Austrian physicist Erwin Schrödinger in 1935. It illustrates what he saw as\n+ the problem of the Copenhagen interpretation of quantum mechanics applied to\n+ everyday objects. The scenario presents a cat that may be simultaneously both alive\n+ and dead, a state known as a quantum superposition, as a result\n+ of being linked to a random subatomic event that may or may not occur.\n+ </p>\n+ <fieldset class=\"rating\">\n+ <input type=\"radio\" id=\"rate-3-10\" name=\"rate-3\" value=\"10\">\n+ <label for=\"rate-3-1\"></label>\n+ <input type=\"radio\" id=\"rate-3-9\" name=\"rate-3\" value=\"9\">\n+ <label for=\"rate-3-2\"></label>\n+ <input type=\"radio\" id=\"rate-3-8\" name=\"rate-3\" value=\"8\">\n+ <label for=\"rate-3-3\"></label>\n+ <input type=\"radio\" id=\"rate-3-7\" name=\"rate-3\" value=\"7\">\n+ <label for=\"rate-3-4\"></label>\n+ <input type=\"radio\" id=\"rate-3-6\" name=\"rate-3\" value=\"6\">\n+ <label for=\"rate-3-5\"></label>\n+ <input type=\"radio\" id=\"rate-3-5\" name=\"rate-3\" value=\"5\" checked>\n+ <label for=\"rate-3-6\"></label>\n+ <input type=\"radio\" id=\"rate-3-4\" name=\"rate-3\" value=\"4\">\n+ <label for=\"rate-3-7\"></label>\n+ <input type=\"radio\" id=\"rate-3-3\" name=\"rate-3\" value=\"3\">\n+ <label for=\"rate-3-8\"></label>\n+ <input type=\"radio\" id=\"rate-3-2\" name=\"rate-3\" value=\"2\">\n+ <label for=\"rate-3-9\"></label>\n+ <input type=\"radio\" id=\"rate-3-1\" name=\"rate-3\" value=\"1\">\n+ <label for=\"rate-3-10\"></label>\n+ </fieldset>\n+ </section>\n+ </article>\n+ <article class=\"market-item\">\n+ <div class=\"item-picture\">\n+ <img src=\"pictures/kitler.jpg\" alt=\"Kat kitler\">\n+ </div>\n+ <section class=\"item-info\">\n+ <h2><a href=\"https://www.reddit.com/r/Kitler/\" title=\"Kitler reddit\">\n+ Kitler\n+ </a></h2>\n+ <p class=\"item-info-price\">\n+ $1488\n+ </p>\n+ <p class=\"item-cat-egory\">\n+ <em>Category:</em> <a href=\"evil\" title=\"See category\">Evil cats</a>\n+ </p>\n+ <p class=\"item-info-descr\">\n+ Does your cat look like Adolf Hitler? Do you wake up in a cold sweat every night\n+ wondering if he's going to up and invade Poland? Does he keep putting his right paw\n+ in the air while making a noise that sounds suspiciously like \"Sieg Miaow\"?\n+ </p>\n+ <fieldset class=\"rating\">\n+ <input type=\"radio\" id=\"rate-4-10\" name=\"rate-4\" value=\"10\">\n+ <label for=\"rate-4-10\"></label>\n+ <input type=\"radio\" id=\"rate-4-9\" name=\"rate-4\" value=\"9\">\n+ <label for=\"rate-4-9\"></label>\n+ <input type=\"radio\" id=\"rate-4-8\" name=\"rate-4\" value=\"8\">\n+ <label for=\"rate-4-8\"></label>\n+ <input type=\"radio\" id=\"rate-4-7\" name=\"rate-4\" value=\"7\">\n+ <label for=\"rate-4-7\"></label>\n+ <input type=\"radio\" id=\"rate-4-6\" name=\"rate-4\" value=\"6\" checked>\n+ <label for=\"rate-4-6\"></label>\n+ <input type=\"radio\" id=\"rate-4-5\" name=\"rate-4\" value=\"5\">\n+ <label for=\"rate-4-5\"></label>\n+ <input type=\"radio\" id=\"rate-4-4\" name=\"rate-4\" value=\"4\">\n+ <label for=\"rate-4-4\"></label>\n+ <input type=\"radio\" id=\"rate-4-3\" name=\"rate-4\" value=\"3\">\n+ <label for=\"rate-4-3\"></label>\n+ <input type=\"radio\" id=\"rate-4-2\" name=\"rate-4\" value=\"2\">\n+ <label for=\"rate-4-2\"></label>\n+ <input type=\"radio\" id=\"rate-4-1\" name=\"rate-4\" value=\"1\">\n+ <label for=\"rate-4-1\"></label>\n+ </fieldset>\n+ </section>\n+ </article>\n+ <article class=\"market-item\">\n+ <div class=\"item-picture\">\n+ <img src=\"pictures/monorailcat.jpg\" alt=\"Cat monorail cat\">\n+ </div>\n+ <section class=\"item-info\">\n+ <h2><a href=\"http://knowyourmeme.com/memes/monorail-cat\" title=\"Monorail cat\">\n+ Monorail cat\n+ </a></h2>\n+ <p class=\"item-info-price\">\n+ $2/ride\n+ </p>\n+ <p class=\"item-cat-egory\">\n+ <em>Category:</em> <a href=\"transport\" title=\"See category\">Transport cats</a>\n+ </p>\n+ <p class=\"item-info-descr\">","path":"index.html","position":null,"original_position":212,"commit_id":"596154419705b43267a202ef1a88a97b170b184a","original_commit_id":"54d294f06965a96dbea0f35d07e2902dfbbbc7ba","user":{"login":"bazhenova","id":12410663,"avatar_url":"https://avatars0.githubusercontent.com/u/12410663?v=4","gravatar_id":"","url":"https://api.github.com/users/bazhenova","html_url":"https://github.com/bazhenova","followers_url":"https://api.github.com/users/bazhenova/followers","following_url":"https://api.github.com/users/bazhenova/following{/other_user}","gists_url":"https://api.github.com/users/bazhenova/gists{/gist_id}","starred_url":"https://api.github.com/users/bazhenova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazhenova/subscriptions","organizations_url":"https://api.github.com/users/bazhenova/orgs","repos_url":"https://api.github.com/users/bazhenova/repos","events_url":"https://api.github.com/users/bazhenova/events{/privacy}","received_events_url":"https://api.github.com/users/bazhenova/received_events","type":"User","site_admin":false},"body":">Селекторы вида .market-item .description вам, похоже, не нравятся, поэтому такие вот неймспейсы через дефис.\r\n\r\nПочему не нравятся? Оо","created_at":"2017-11-03T11:16:00Z","updated_at":"2017-11-03T11:16:00Z","html_url":"https://github.com/urfu-2017/markup-task-4/pull/23#discussion_r148757132","pull_request_url":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/23","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/comments/148757132"},"html":{"href":"https://github.com/urfu-2017/markup-task-4/pull/23#discussion_r148757132"},"pull_request":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/23"}},"in_reply_to_id":148736915},"pull_request":{"url":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/23","id":149399643,"html_url":"https://github.com/urfu-2017/markup-task-4/pull/23","diff_url":"https://github.com/urfu-2017/markup-task-4/pull/23.diff","patch_url":"https://github.com/urfu-2017/markup-task-4/pull/23.patch","issue_url":"https://api.github.com/repos/urfu-2017/markup-task-4/issues/23","number":23,"state":"open","locked":false,"title":"Тощев Иван","user":{"login":"ToshchevIvan","id":29313153,"avatar_url":"https://avatars2.githubusercontent.com/u/29313153?v=4","gravatar_id":"","url":"https://api.github.com/users/ToshchevIvan","html_url":"https://github.com/ToshchevIvan","followers_url":"https://api.github.com/users/ToshchevIvan/followers","following_url":"https://api.github.com/users/ToshchevIvan/following{/other_user}","gists_url":"https://api.github.com/users/ToshchevIvan/gists{/gist_id}","starred_url":"https://api.github.com/users/ToshchevIvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToshchevIvan/subscriptions","organizations_url":"https://api.github.com/users/ToshchevIvan/orgs","repos_url":"https://api.github.com/users/ToshchevIvan/repos","events_url":"https://api.github.com/users/ToshchevIvan/events{/privacy}","received_events_url":"https://api.github.com/users/ToshchevIvan/received_events","type":"User","site_admin":false},"body":"[Посмотреть решение](https://rawgit.com/ToshchevIvan/markup-task-4/master/index.html)","created_at":"2017-10-29T18:35:23Z","updated_at":"2017-11-03T11:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec769bb7f318233ffc1da7c2e94f7a752f5a2257","assignee":{"login":"bazhenova","id":12410663,"avatar_url":"https://avatars0.githubusercontent.com/u/12410663?v=4","gravatar_id":"","url":"https://api.github.com/users/bazhenova","html_url":"https://github.com/bazhenova","followers_url":"https://api.github.com/users/bazhenova/followers","following_url":"https://api.github.com/users/bazhenova/following{/other_user}","gists_url":"https://api.github.com/users/bazhenova/gists{/gist_id}","starred_url":"https://api.github.com/users/bazhenova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazhenova/subscriptions","organizations_url":"https://api.github.com/users/bazhenova/orgs","repos_url":"https://api.github.com/users/bazhenova/repos","events_url":"https://api.github.com/users/bazhenova/events{/privacy}","received_events_url":"https://api.github.com/users/bazhenova/received_events","type":"User","site_admin":false},"assignees":[{"login":"bazhenova","id":12410663,"avatar_url":"https://avatars0.githubusercontent.com/u/12410663?v=4","gravatar_id":"","url":"https://api.github.com/users/bazhenova","html_url":"https://github.com/bazhenova","followers_url":"https://api.github.com/users/bazhenova/followers","following_url":"https://api.github.com/users/bazhenova/following{/other_user}","gists_url":"https://api.github.com/users/bazhenova/gists{/gist_id}","starred_url":"https://api.github.com/users/bazhenova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazhenova/subscriptions","organizations_url":"https://api.github.com/users/bazhenova/orgs","repos_url":"https://api.github.com/users/bazhenova/repos","events_url":"https://api.github.com/users/bazhenova/events{/privacy}","received_events_url":"https://api.github.com/users/bazhenova/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/23/commits","review_comments_url":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/23/comments","review_comment_url":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urfu-2017/markup-task-4/issues/23/comments","statuses_url":"https://api.github.com/repos/urfu-2017/markup-task-4/statuses/596154419705b43267a202ef1a88a97b170b184a","head":{"label":"ToshchevIvan:master","ref":"master","sha":"596154419705b43267a202ef1a88a97b170b184a","user":{"login":"ToshchevIvan","id":29313153,"avatar_url":"https://avatars2.githubusercontent.com/u/29313153?v=4","gravatar_id":"","url":"https://api.github.com/users/ToshchevIvan","html_url":"https://github.com/ToshchevIvan","followers_url":"https://api.github.com/users/ToshchevIvan/followers","following_url":"https://api.github.com/users/ToshchevIvan/following{/other_user}","gists_url":"https://api.github.com/users/ToshchevIvan/gists{/gist_id}","starred_url":"https://api.github.com/users/ToshchevIvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToshchevIvan/subscriptions","organizations_url":"https://api.github.com/users/ToshchevIvan/orgs","repos_url":"https://api.github.com/users/ToshchevIvan/repos","events_url":"https://api.github.com/users/ToshchevIvan/events{/privacy}","received_events_url":"https://api.github.com/users/ToshchevIvan/received_events","type":"User","site_admin":false},"repo":{"id":108431397,"name":"markup-task-4","full_name":"ToshchevIvan/markup-task-4","owner":{"login":"ToshchevIvan","id":29313153,"avatar_url":"https://avatars2.githubusercontent.com/u/29313153?v=4","gravatar_id":"","url":"https://api.github.com/users/ToshchevIvan","html_url":"https://github.com/ToshchevIvan","followers_url":"https://api.github.com/users/ToshchevIvan/followers","following_url":"https://api.github.com/users/ToshchevIvan/following{/other_user}","gists_url":"https://api.github.com/users/ToshchevIvan/gists{/gist_id}","starred_url":"https://api.github.com/users/ToshchevIvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ToshchevIvan/subscriptions","organizations_url":"https://api.github.com/users/ToshchevIvan/orgs","repos_url":"https://api.github.com/users/ToshchevIvan/repos","events_url":"https://api.github.com/users/ToshchevIvan/events{/privacy}","received_events_url":"https://api.github.com/users/ToshchevIvan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ToshchevIvan/markup-task-4","description":"Задача «Мяндекс.Муррркет»","fork":true,"url":"https://api.github.com/repos/ToshchevIvan/markup-task-4","forks_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/forks","keys_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/teams","hooks_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/hooks","issue_events_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/issues/events{/number}","events_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/events","assignees_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/assignees{/user}","branches_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/branches{/branch}","tags_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/tags","blobs_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/git/refs{/sha}","trees_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/statuses/{sha}","languages_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/languages","stargazers_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/stargazers","contributors_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/contributors","subscribers_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/subscribers","subscription_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/subscription","commits_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/commits{/sha}","git_commits_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/git/commits{/sha}","comments_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/comments{/number}","issue_comment_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/issues/comments{/number}","contents_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/contents/{+path}","compare_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/merges","archive_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/downloads","issues_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/issues{/number}","pulls_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/pulls{/number}","milestones_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/milestones{/number}","notifications_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/labels{/name}","releases_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/releases{/id}","deployments_url":"https://api.github.com/repos/ToshchevIvan/markup-task-4/deployments","created_at":"2017-10-26T15:38:05Z","updated_at":"2017-10-26T15:38:07Z","pushed_at":"2017-11-03T11:00:42Z","git_url":"git://github.com/ToshchevIvan/markup-task-4.git","ssh_url":"[email protected]:ToshchevIvan/markup-task-4.git","clone_url":"https://github.com/ToshchevIvan/markup-task-4.git","svn_url":"https://github.com/ToshchevIvan/markup-task-4","homepage":"","size":462,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urfu-2017:master","ref":"master","sha":"bbf2ef149e9642682424414ead29a6fd63b54129","user":{"login":"urfu-2017","id":31925391,"avatar_url":"https://avatars1.githubusercontent.com/u/31925391?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2017","html_url":"https://github.com/urfu-2017","followers_url":"https://api.github.com/users/urfu-2017/followers","following_url":"https://api.github.com/users/urfu-2017/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2017/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2017/subscriptions","organizations_url":"https://api.github.com/users/urfu-2017/orgs","repos_url":"https://api.github.com/users/urfu-2017/repos","events_url":"https://api.github.com/users/urfu-2017/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2017/received_events","type":"Organization","site_admin":false},"repo":{"id":108135082,"name":"markup-task-4","full_name":"urfu-2017/markup-task-4","owner":{"login":"urfu-2017","id":31925391,"avatar_url":"https://avatars1.githubusercontent.com/u/31925391?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2017","html_url":"https://github.com/urfu-2017","followers_url":"https://api.github.com/users/urfu-2017/followers","following_url":"https://api.github.com/users/urfu-2017/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2017/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2017/subscriptions","organizations_url":"https://api.github.com/users/urfu-2017/orgs","repos_url":"https://api.github.com/users/urfu-2017/repos","events_url":"https://api.github.com/users/urfu-2017/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2017/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urfu-2017/markup-task-4","description":"Задача «Мяндекс.Муррркет»","fork":false,"url":"https://api.github.com/repos/urfu-2017/markup-task-4","forks_url":"https://api.github.com/repos/urfu-2017/markup-task-4/forks","keys_url":"https://api.github.com/repos/urfu-2017/markup-task-4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urfu-2017/markup-task-4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urfu-2017/markup-task-4/teams","hooks_url":"https://api.github.com/repos/urfu-2017/markup-task-4/hooks","issue_events_url":"https://api.github.com/repos/urfu-2017/markup-task-4/issues/events{/number}","events_url":"https://api.github.com/repos/urfu-2017/markup-task-4/events","assignees_url":"https://api.github.com/repos/urfu-2017/markup-task-4/assignees{/user}","branches_url":"https://api.github.com/repos/urfu-2017/markup-task-4/branches{/branch}","tags_url":"https://api.github.com/repos/urfu-2017/markup-task-4/tags","blobs_url":"https://api.github.com/repos/urfu-2017/markup-task-4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urfu-2017/markup-task-4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urfu-2017/markup-task-4/git/refs{/sha}","trees_url":"https://api.github.com/repos/urfu-2017/markup-task-4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urfu-2017/markup-task-4/statuses/{sha}","languages_url":"https://api.github.com/repos/urfu-2017/markup-task-4/languages","stargazers_url":"https://api.github.com/repos/urfu-2017/markup-task-4/stargazers","contributors_url":"https://api.github.com/repos/urfu-2017/markup-task-4/contributors","subscribers_url":"https://api.github.com/repos/urfu-2017/markup-task-4/subscribers","subscription_url":"https://api.github.com/repos/urfu-2017/markup-task-4/subscription","commits_url":"https://api.github.com/repos/urfu-2017/markup-task-4/commits{/sha}","git_commits_url":"https://api.github.com/repos/urfu-2017/markup-task-4/git/commits{/sha}","comments_url":"https://api.github.com/repos/urfu-2017/markup-task-4/comments{/number}","issue_comment_url":"https://api.github.com/repos/urfu-2017/markup-task-4/issues/comments{/number}","contents_url":"https://api.github.com/repos/urfu-2017/markup-task-4/contents/{+path}","compare_url":"https://api.github.com/repos/urfu-2017/markup-task-4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urfu-2017/markup-task-4/merges","archive_url":"https://api.github.com/repos/urfu-2017/markup-task-4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urfu-2017/markup-task-4/downloads","issues_url":"https://api.github.com/repos/urfu-2017/markup-task-4/issues{/number}","pulls_url":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls{/number}","milestones_url":"https://api.github.com/repos/urfu-2017/markup-task-4/milestones{/number}","notifications_url":"https://api.github.com/repos/urfu-2017/markup-task-4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urfu-2017/markup-task-4/labels{/name}","releases_url":"https://api.github.com/repos/urfu-2017/markup-task-4/releases{/id}","deployments_url":"https://api.github.com/repos/urfu-2017/markup-task-4/deployments","created_at":"2017-10-24T14:02:17Z","updated_at":"2017-10-24T14:10:54Z","pushed_at":"2017-11-03T11:00:43Z","git_url":"git://github.com/urfu-2017/markup-task-4.git","ssh_url":"[email protected]:urfu-2017/markup-task-4.git","clone_url":"https://github.com/urfu-2017/markup-task-4.git","svn_url":"https://github.com/urfu-2017/markup-task-4","homepage":"","size":4,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":55,"forks":88,"open_issues":55,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/23"},"html":{"href":"https://github.com/urfu-2017/markup-task-4/pull/23"},"issue":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/issues/23"},"comments":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/urfu-2017/markup-task-4/statuses/596154419705b43267a202ef1a88a97b170b184a"}},"author_association":"NONE"}} | {
"id": 108135082,
"name": "urfu-2017/markup-task-4",
"url": "https://api.github.com/repos/urfu-2017/markup-task-4"
} | {
"id": 12410663,
"login": "bazhenova",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12410663?",
"url": "https://api.github.com/users/bazhenova"
} | {
"id": 31925391,
"login": "urfu-2017",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31925391?",
"url": "https://api.github.com/orgs/urfu-2017"
} | 2017-11-03T11:16:00 | 6805054522 | {"actor":{"display_login":"bazhenova"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/comments/146380315","pull_request_review_id":71311341,"id":146380315,"diff_hunk":"@@ -44,7 +71,223 @@ exports.getAppropriateMoment = function (schedule, duration, workingHours) {\n * @returns {Boolean}\n */\n tryLater: function () {\n- return false;\n+ let next = startTimesGenerator.next();\n+ if (!next.done) {\n+ startTime = next.value;\n+ }\n+\n+ return !next.done;\n }\n };\n };\n+\n+\n+function* startTimeGenerator(startTimes) {\n+ for (let i = 0; i < startTimes.length; i++) {\n+ yield startTimes[i];\n+ }\n+}\n+\n+\n+function getStartTimes(availableTime, robberyDays) {\n+ return robberyDays.reduce((acc, day) => {\n+ if (availableTime.hasOwnProperty(day)) {\n+ availableTime[day].forEach(time => {\n+ acc.push({\n+ day: day,\n+ startHours: String(time.from.getHours()),\n+ startMinutes: String(time.from.getMinutes())\n+ });\n+ });\n+ }\n+\n+ return acc;\n+ }, []);\n+}\n+\n+function findRobberyTime(scheduleOfDay, duration, workingHours) {\n+ let availableTime = [];\n+ availableTime.push({\n+ from: new Date(0, 0, 0, getHours(workingHours.from),\n+ getMinutes(workingHours.from)),\n+ to: new Date(0, 0, 0, getHours(workingHours.to), getMinutes(workingHours.to))\n+ });\n+\n+ scheduleOfDay.map(segment => {\n+ return {\n+ from: new Date(0, 0, 0, getHours(segment.from), getMinutes(segment.from)),\n+ to: new Date(0, 0, 0, getHours(segment.to), getMinutes(segment.to))\n+ };\n+ }).forEach(busyTime => {\n+ availableTime = availableTime.reduce((acc, time) => {\n+ return [...acc, ...intersectAvailableAndBusyTime(time, busyTime)];\n+ }, []);\n+ });\n+\n+ return availableTime.filter(time => {\n+ return new Date(time.from.getTime() + duration * 60000).getTime() <=\n+ time.to.getTime();\n+ }).reduce((acc, time) => {\n+ return [...acc, ...findLater(time, duration)];\n+ }, []);\n+}\n+\n+function findLater(time, duration) {\n+ let laterTime = new Date(time.from.getTime() + 30 * 60000);\n+ let laterTimes = [];","path":"robbery.js","position":129,"original_position":129,"commit_id":"0c1b9765068dd2f3b96a0cfe707397218f221f13","original_commit_id":"0c1b9765068dd2f3b96a0cfe707397218f221f13","user":{"login":"YuuKohaku","id":5787961,"avatar_url":"https://avatars3.githubusercontent.com/u/5787961?v=4","gravatar_id":"","url":"https://api.github.com/users/YuuKohaku","html_url":"https://github.com/YuuKohaku","followers_url":"https://api.github.com/users/YuuKohaku/followers","following_url":"https://api.github.com/users/YuuKohaku/following{/other_user}","gists_url":"https://api.github.com/users/YuuKohaku/gists{/gist_id}","starred_url":"https://api.github.com/users/YuuKohaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuuKohaku/subscriptions","organizations_url":"https://api.github.com/users/YuuKohaku/orgs","repos_url":"https://api.github.com/users/YuuKohaku/repos","events_url":"https://api.github.com/users/YuuKohaku/events{/privacy}","received_events_url":"https://api.github.com/users/YuuKohaku/received_events","type":"User","site_admin":false},"body":"(Опционально)\r\nВнутри функций тоже можно переставиться на const. Если ты делаешь const arr = [], ты все еще можешь пушить в массив. )","created_at":"2017-10-23T20:13:29Z","updated_at":"2017-10-23T20:18:54Z","html_url":"https://github.com/urfu-2017/javascript-task-3/pull/30#discussion_r146380315","pull_request_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/30","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/comments/146380315"},"html":{"href":"https://github.com/urfu-2017/javascript-task-3/pull/30#discussion_r146380315"},"pull_request":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/30","id":146871760,"html_url":"https://github.com/urfu-2017/javascript-task-3/pull/30","diff_url":"https://github.com/urfu-2017/javascript-task-3/pull/30.diff","patch_url":"https://github.com/urfu-2017/javascript-task-3/pull/30.patch","issue_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/issues/30","number":30,"state":"open","locked":false,"title":"Рыженко Роман","user":{"login":"WBDiamond","id":19361522,"avatar_url":"https://avatars1.githubusercontent.com/u/19361522?v=4","gravatar_id":"","url":"https://api.github.com/users/WBDiamond","html_url":"https://github.com/WBDiamond","followers_url":"https://api.github.com/users/WBDiamond/followers","following_url":"https://api.github.com/users/WBDiamond/following{/other_user}","gists_url":"https://api.github.com/users/WBDiamond/gists{/gist_id}","starred_url":"https://api.github.com/users/WBDiamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WBDiamond/subscriptions","organizations_url":"https://api.github.com/users/WBDiamond/orgs","repos_url":"https://api.github.com/users/WBDiamond/repos","events_url":"https://api.github.com/users/WBDiamond/events{/privacy}","received_events_url":"https://api.github.com/users/WBDiamond/received_events","type":"User","site_admin":false},"body":"Роман Рыженко","created_at":"2017-10-16T19:47:06Z","updated_at":"2017-10-23T20:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f86426e4bfac914bf8a68a0ff634529d37119df1","assignee":{"login":"YuuKohaku","id":5787961,"avatar_url":"https://avatars3.githubusercontent.com/u/5787961?v=4","gravatar_id":"","url":"https://api.github.com/users/YuuKohaku","html_url":"https://github.com/YuuKohaku","followers_url":"https://api.github.com/users/YuuKohaku/followers","following_url":"https://api.github.com/users/YuuKohaku/following{/other_user}","gists_url":"https://api.github.com/users/YuuKohaku/gists{/gist_id}","starred_url":"https://api.github.com/users/YuuKohaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuuKohaku/subscriptions","organizations_url":"https://api.github.com/users/YuuKohaku/orgs","repos_url":"https://api.github.com/users/YuuKohaku/repos","events_url":"https://api.github.com/users/YuuKohaku/events{/privacy}","received_events_url":"https://api.github.com/users/YuuKohaku/received_events","type":"User","site_admin":false},"assignees":[{"login":"YuuKohaku","id":5787961,"avatar_url":"https://avatars3.githubusercontent.com/u/5787961?v=4","gravatar_id":"","url":"https://api.github.com/users/YuuKohaku","html_url":"https://github.com/YuuKohaku","followers_url":"https://api.github.com/users/YuuKohaku/followers","following_url":"https://api.github.com/users/YuuKohaku/following{/other_user}","gists_url":"https://api.github.com/users/YuuKohaku/gists{/gist_id}","starred_url":"https://api.github.com/users/YuuKohaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuuKohaku/subscriptions","organizations_url":"https://api.github.com/users/YuuKohaku/orgs","repos_url":"https://api.github.com/users/YuuKohaku/repos","events_url":"https://api.github.com/users/YuuKohaku/events{/privacy}","received_events_url":"https://api.github.com/users/YuuKohaku/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/30/commits","review_comments_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/30/comments","review_comment_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/issues/30/comments","statuses_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/statuses/0c1b9765068dd2f3b96a0cfe707397218f221f13","head":{"label":"WBDiamond:master","ref":"master","sha":"0c1b9765068dd2f3b96a0cfe707397218f221f13","user":{"login":"WBDiamond","id":19361522,"avatar_url":"https://avatars1.githubusercontent.com/u/19361522?v=4","gravatar_id":"","url":"https://api.github.com/users/WBDiamond","html_url":"https://github.com/WBDiamond","followers_url":"https://api.github.com/users/WBDiamond/followers","following_url":"https://api.github.com/users/WBDiamond/following{/other_user}","gists_url":"https://api.github.com/users/WBDiamond/gists{/gist_id}","starred_url":"https://api.github.com/users/WBDiamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WBDiamond/subscriptions","organizations_url":"https://api.github.com/users/WBDiamond/orgs","repos_url":"https://api.github.com/users/WBDiamond/repos","events_url":"https://api.github.com/users/WBDiamond/events{/privacy}","received_events_url":"https://api.github.com/users/WBDiamond/received_events","type":"User","site_admin":false},"repo":{"id":106929692,"name":"javascript-task-3","full_name":"WBDiamond/javascript-task-3","owner":{"login":"WBDiamond","id":19361522,"avatar_url":"https://avatars1.githubusercontent.com/u/19361522?v=4","gravatar_id":"","url":"https://api.github.com/users/WBDiamond","html_url":"https://github.com/WBDiamond","followers_url":"https://api.github.com/users/WBDiamond/followers","following_url":"https://api.github.com/users/WBDiamond/following{/other_user}","gists_url":"https://api.github.com/users/WBDiamond/gists{/gist_id}","starred_url":"https://api.github.com/users/WBDiamond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WBDiamond/subscriptions","organizations_url":"https://api.github.com/users/WBDiamond/orgs","repos_url":"https://api.github.com/users/WBDiamond/repos","events_url":"https://api.github.com/users/WBDiamond/events{/privacy}","received_events_url":"https://api.github.com/users/WBDiamond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WBDiamond/javascript-task-3","description":"Задача «0b11 друзей Оушена»","fork":true,"url":"https://api.github.com/repos/WBDiamond/javascript-task-3","forks_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/forks","keys_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/teams","hooks_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/hooks","issue_events_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/issues/events{/number}","events_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/events","assignees_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/assignees{/user}","branches_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/branches{/branch}","tags_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/tags","blobs_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/statuses/{sha}","languages_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/languages","stargazers_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/stargazers","contributors_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/contributors","subscribers_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/subscribers","subscription_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/subscription","commits_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/contents/{+path}","compare_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/merges","archive_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/downloads","issues_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/issues{/number}","pulls_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/pulls{/number}","milestones_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/milestones{/number}","notifications_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/labels{/name}","releases_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/releases{/id}","deployments_url":"https://api.github.com/repos/WBDiamond/javascript-task-3/deployments","created_at":"2017-10-14T13:24:34Z","updated_at":"2017-10-14T13:24:36Z","pushed_at":"2017-10-21T22:38:19Z","git_url":"git://github.com/WBDiamond/javascript-task-3.git","ssh_url":"[email protected]:WBDiamond/javascript-task-3.git","clone_url":"https://github.com/WBDiamond/javascript-task-3.git","svn_url":"https://github.com/WBDiamond/javascript-task-3","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urfu-2017:master","ref":"master","sha":"88ade5e7397f7070f10e80917d200a7d1517253c","user":{"login":"urfu-2017","id":31925391,"avatar_url":"https://avatars1.githubusercontent.com/u/31925391?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2017","html_url":"https://github.com/urfu-2017","followers_url":"https://api.github.com/users/urfu-2017/followers","following_url":"https://api.github.com/users/urfu-2017/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2017/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2017/subscriptions","organizations_url":"https://api.github.com/users/urfu-2017/orgs","repos_url":"https://api.github.com/users/urfu-2017/repos","events_url":"https://api.github.com/users/urfu-2017/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2017/received_events","type":"Organization","site_admin":false},"repo":{"id":106695607,"name":"javascript-task-3","full_name":"urfu-2017/javascript-task-3","owner":{"login":"urfu-2017","id":31925391,"avatar_url":"https://avatars1.githubusercontent.com/u/31925391?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2017","html_url":"https://github.com/urfu-2017","followers_url":"https://api.github.com/users/urfu-2017/followers","following_url":"https://api.github.com/users/urfu-2017/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2017/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2017/subscriptions","organizations_url":"https://api.github.com/users/urfu-2017/orgs","repos_url":"https://api.github.com/users/urfu-2017/repos","events_url":"https://api.github.com/users/urfu-2017/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2017/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urfu-2017/javascript-task-3","description":"Задача «0b11 друзей Оушена»","fork":false,"url":"https://api.github.com/repos/urfu-2017/javascript-task-3","forks_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/forks","keys_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/teams","hooks_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/hooks","issue_events_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/issues/events{/number}","events_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/events","assignees_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/assignees{/user}","branches_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/branches{/branch}","tags_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/tags","blobs_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/statuses/{sha}","languages_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/languages","stargazers_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/stargazers","contributors_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/contributors","subscribers_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/subscribers","subscription_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/subscription","commits_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/contents/{+path}","compare_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/merges","archive_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/downloads","issues_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/issues{/number}","pulls_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls{/number}","milestones_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/milestones{/number}","notifications_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/labels{/name}","releases_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/releases{/id}","deployments_url":"https://api.github.com/repos/urfu-2017/javascript-task-3/deployments","created_at":"2017-10-12T13:20:33Z","updated_at":"2017-10-12T14:04:22Z","pushed_at":"2017-10-23T19:43:46Z","git_url":"git://github.com/urfu-2017/javascript-task-3.git","ssh_url":"[email protected]:urfu-2017/javascript-task-3.git","clone_url":"https://github.com/urfu-2017/javascript-task-3.git","svn_url":"https://github.com/urfu-2017/javascript-task-3","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":41,"forks":97,"open_issues":41,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/30"},"html":{"href":"https://github.com/urfu-2017/javascript-task-3/pull/30"},"issue":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/issues/30"},"comments":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/urfu-2017/javascript-task-3/statuses/0c1b9765068dd2f3b96a0cfe707397218f221f13"}},"author_association":"NONE"}} | {
"id": 106695607,
"name": "urfu-2017/javascript-task-3",
"url": "https://api.github.com/repos/urfu-2017/javascript-task-3"
} | {
"id": 5787961,
"login": "YuuKohaku",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5787961?",
"url": "https://api.github.com/users/YuuKohaku"
} | {
"id": 31925391,
"login": "urfu-2017",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31925391?",
"url": "https://api.github.com/orgs/urfu-2017"
} | 2017-10-23T20:13:29 | 6754545278 | {"actor":{"display_login":"YuuKohaku"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/voidlinux/void-packages/pulls/comments/154424768","pull_request_review_id":80592591,"id":154424768,"diff_hunk":"@@ -0,0 +1,31 @@\n+# Template file for 'loksh'\n+pkgname=loksh\n+version=6.1\n+revision=1\n+build_style=gnu-makefile\n+make_build_args=\"HAVE_LIBBSD=1\"\n+make_install_args=\"BIN_NAME=loksh\"\n+hostmakedepends=\"pkg-config\"\n+makedepends=\"libbsd-devel\"\n+short_desc=\"A Linux port of OpenBSD's ksh\"\n+maintainer=\"Renato Aguiar <[email protected]>\"\n+license=\"Public Domain\"\n+homepage=\"https://github.com/dimkr/loksh\"\n+distfiles=\"https://github.com/dimkr/loksh/archive/${version}.tar.gz\"\n+checksum=988a9ae4c33aa8ff9e9dbc42ad22678ce7bd46892b9150c37b0e656f8a6ee7f1\n+nopie=true","path":"srcpkgs/loksh/template","position":null,"original_position":16,"commit_id":"74cb0f3f6582fb717c7b1c0c90a4916f416a31a8","original_commit_id":"fbbcd99d433162b13a1ffaae59479b3e952df840","user":{"login":"Johnnynator","id":7373356,"avatar_url":"https://avatars3.githubusercontent.com/u/7373356?v=4","gravatar_id":"","url":"https://api.github.com/users/Johnnynator","html_url":"https://github.com/Johnnynator","followers_url":"https://api.github.com/users/Johnnynator/followers","following_url":"https://api.github.com/users/Johnnynator/following{/other_user}","gists_url":"https://api.github.com/users/Johnnynator/gists{/gist_id}","starred_url":"https://api.github.com/users/Johnnynator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Johnnynator/subscriptions","organizations_url":"https://api.github.com/users/Johnnynator/orgs","repos_url":"https://api.github.com/users/Johnnynator/repos","events_url":"https://api.github.com/users/Johnnynator/events{/privacy}","received_events_url":"https://api.github.com/users/Johnnynator/received_events","type":"User","site_admin":false},"body":"@renatoaguiar is it possible that you chroot isn't up to date? For updating it run `./xbps bootstrap-update`. For me loksh complies fine as pie without the additional flags","created_at":"2017-12-01T19:13:43Z","updated_at":"2017-12-01T19:13:43Z","html_url":"https://github.com/voidlinux/void-packages/pull/9662#discussion_r154424768","pull_request_url":"https://api.github.com/repos/voidlinux/void-packages/pulls/9662","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/comments/154424768"},"html":{"href":"https://github.com/voidlinux/void-packages/pull/9662#discussion_r154424768"},"pull_request":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/9662"}},"in_reply_to_id":154263837},"pull_request":{"url":"https://api.github.com/repos/voidlinux/void-packages/pulls/9662","id":155761752,"html_url":"https://github.com/voidlinux/void-packages/pull/9662","diff_url":"https://github.com/voidlinux/void-packages/pull/9662.diff","patch_url":"https://github.com/voidlinux/void-packages/pull/9662.patch","issue_url":"https://api.github.com/repos/voidlinux/void-packages/issues/9662","number":9662,"state":"closed","locked":false,"title":"New package: loksh-6.1","user":{"login":"renatoaguiar","id":61402,"avatar_url":"https://avatars1.githubusercontent.com/u/61402?v=4","gravatar_id":"","url":"https://api.github.com/users/renatoaguiar","html_url":"https://github.com/renatoaguiar","followers_url":"https://api.github.com/users/renatoaguiar/followers","following_url":"https://api.github.com/users/renatoaguiar/following{/other_user}","gists_url":"https://api.github.com/users/renatoaguiar/gists{/gist_id}","starred_url":"https://api.github.com/users/renatoaguiar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatoaguiar/subscriptions","organizations_url":"https://api.github.com/users/renatoaguiar/orgs","repos_url":"https://api.github.com/users/renatoaguiar/repos","events_url":"https://api.github.com/users/renatoaguiar/events{/privacy}","received_events_url":"https://api.github.com/users/renatoaguiar/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-01T01:23:43Z","updated_at":"2017-12-01T19:13:43Z","closed_at":"2017-12-01T18:53:08Z","merged_at":"2017-12-01T18:53:08Z","merge_commit_sha":"7bb7fa39cb707138038b536517a8dc6233f0e7f5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/voidlinux/void-packages/pulls/9662/commits","review_comments_url":"https://api.github.com/repos/voidlinux/void-packages/pulls/9662/comments","review_comment_url":"https://api.github.com/repos/voidlinux/void-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voidlinux/void-packages/issues/9662/comments","statuses_url":"https://api.github.com/repos/voidlinux/void-packages/statuses/74cb0f3f6582fb717c7b1c0c90a4916f416a31a8","head":{"label":"renatoaguiar:loksh","ref":"loksh","sha":"74cb0f3f6582fb717c7b1c0c90a4916f416a31a8","user":{"login":"renatoaguiar","id":61402,"avatar_url":"https://avatars1.githubusercontent.com/u/61402?v=4","gravatar_id":"","url":"https://api.github.com/users/renatoaguiar","html_url":"https://github.com/renatoaguiar","followers_url":"https://api.github.com/users/renatoaguiar/followers","following_url":"https://api.github.com/users/renatoaguiar/following{/other_user}","gists_url":"https://api.github.com/users/renatoaguiar/gists{/gist_id}","starred_url":"https://api.github.com/users/renatoaguiar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatoaguiar/subscriptions","organizations_url":"https://api.github.com/users/renatoaguiar/orgs","repos_url":"https://api.github.com/users/renatoaguiar/repos","events_url":"https://api.github.com/users/renatoaguiar/events{/privacy}","received_events_url":"https://api.github.com/users/renatoaguiar/received_events","type":"User","site_admin":false},"repo":{"id":50885479,"name":"void-packages","full_name":"renatoaguiar/void-packages","owner":{"login":"renatoaguiar","id":61402,"avatar_url":"https://avatars1.githubusercontent.com/u/61402?v=4","gravatar_id":"","url":"https://api.github.com/users/renatoaguiar","html_url":"https://github.com/renatoaguiar","followers_url":"https://api.github.com/users/renatoaguiar/followers","following_url":"https://api.github.com/users/renatoaguiar/following{/other_user}","gists_url":"https://api.github.com/users/renatoaguiar/gists{/gist_id}","starred_url":"https://api.github.com/users/renatoaguiar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatoaguiar/subscriptions","organizations_url":"https://api.github.com/users/renatoaguiar/orgs","repos_url":"https://api.github.com/users/renatoaguiar/repos","events_url":"https://api.github.com/users/renatoaguiar/events{/privacy}","received_events_url":"https://api.github.com/users/renatoaguiar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renatoaguiar/void-packages","description":"The XBPS source packages collection","fork":true,"url":"https://api.github.com/repos/renatoaguiar/void-packages","forks_url":"https://api.github.com/repos/renatoaguiar/void-packages/forks","keys_url":"https://api.github.com/repos/renatoaguiar/void-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renatoaguiar/void-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renatoaguiar/void-packages/teams","hooks_url":"https://api.github.com/repos/renatoaguiar/void-packages/hooks","issue_events_url":"https://api.github.com/repos/renatoaguiar/void-packages/issues/events{/number}","events_url":"https://api.github.com/repos/renatoaguiar/void-packages/events","assignees_url":"https://api.github.com/repos/renatoaguiar/void-packages/assignees{/user}","branches_url":"https://api.github.com/repos/renatoaguiar/void-packages/branches{/branch}","tags_url":"https://api.github.com/repos/renatoaguiar/void-packages/tags","blobs_url":"https://api.github.com/repos/renatoaguiar/void-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renatoaguiar/void-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renatoaguiar/void-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/renatoaguiar/void-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renatoaguiar/void-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/renatoaguiar/void-packages/languages","stargazers_url":"https://api.github.com/repos/renatoaguiar/void-packages/stargazers","contributors_url":"https://api.github.com/repos/renatoaguiar/void-packages/contributors","subscribers_url":"https://api.github.com/repos/renatoaguiar/void-packages/subscribers","subscription_url":"https://api.github.com/repos/renatoaguiar/void-packages/subscription","commits_url":"https://api.github.com/repos/renatoaguiar/void-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/renatoaguiar/void-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/renatoaguiar/void-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/renatoaguiar/void-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/renatoaguiar/void-packages/contents/{+path}","compare_url":"https://api.github.com/repos/renatoaguiar/void-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renatoaguiar/void-packages/merges","archive_url":"https://api.github.com/repos/renatoaguiar/void-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renatoaguiar/void-packages/downloads","issues_url":"https://api.github.com/repos/renatoaguiar/void-packages/issues{/number}","pulls_url":"https://api.github.com/repos/renatoaguiar/void-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/renatoaguiar/void-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/renatoaguiar/void-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renatoaguiar/void-packages/labels{/name}","releases_url":"https://api.github.com/repos/renatoaguiar/void-packages/releases{/id}","deployments_url":"https://api.github.com/repos/renatoaguiar/void-packages/deployments","created_at":"2016-02-02T01:39:47Z","updated_at":"2016-02-02T01:40:03Z","pushed_at":"2017-12-01T18:25:10Z","git_url":"git://github.com/renatoaguiar/void-packages.git","ssh_url":"[email protected]:renatoaguiar/void-packages.git","clone_url":"https://github.com/renatoaguiar/void-packages.git","svn_url":"https://github.com/renatoaguiar/void-packages","homepage":"http://www.voidlinux.eu","size":183010,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voidlinux:master","ref":"master","sha":"ff5aed974b3e5b492910878eadf7b90546956a7f","user":{"login":"voidlinux","id":1512782,"avatar_url":"https://avatars2.githubusercontent.com/u/1512782?v=4","gravatar_id":"","url":"https://api.github.com/users/voidlinux","html_url":"https://github.com/voidlinux","followers_url":"https://api.github.com/users/voidlinux/followers","following_url":"https://api.github.com/users/voidlinux/following{/other_user}","gists_url":"https://api.github.com/users/voidlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/voidlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidlinux/subscriptions","organizations_url":"https://api.github.com/users/voidlinux/orgs","repos_url":"https://api.github.com/users/voidlinux/repos","events_url":"https://api.github.com/users/voidlinux/events{/privacy}","received_events_url":"https://api.github.com/users/voidlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":2060910,"name":"void-packages","full_name":"voidlinux/void-packages","owner":{"login":"voidlinux","id":1512782,"avatar_url":"https://avatars2.githubusercontent.com/u/1512782?v=4","gravatar_id":"","url":"https://api.github.com/users/voidlinux","html_url":"https://github.com/voidlinux","followers_url":"https://api.github.com/users/voidlinux/followers","following_url":"https://api.github.com/users/voidlinux/following{/other_user}","gists_url":"https://api.github.com/users/voidlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/voidlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidlinux/subscriptions","organizations_url":"https://api.github.com/users/voidlinux/orgs","repos_url":"https://api.github.com/users/voidlinux/repos","events_url":"https://api.github.com/users/voidlinux/events{/privacy}","received_events_url":"https://api.github.com/users/voidlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voidlinux/void-packages","description":"The XBPS source packages collection","fork":false,"url":"https://api.github.com/repos/voidlinux/void-packages","forks_url":"https://api.github.com/repos/voidlinux/void-packages/forks","keys_url":"https://api.github.com/repos/voidlinux/void-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voidlinux/void-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voidlinux/void-packages/teams","hooks_url":"https://api.github.com/repos/voidlinux/void-packages/hooks","issue_events_url":"https://api.github.com/repos/voidlinux/void-packages/issues/events{/number}","events_url":"https://api.github.com/repos/voidlinux/void-packages/events","assignees_url":"https://api.github.com/repos/voidlinux/void-packages/assignees{/user}","branches_url":"https://api.github.com/repos/voidlinux/void-packages/branches{/branch}","tags_url":"https://api.github.com/repos/voidlinux/void-packages/tags","blobs_url":"https://api.github.com/repos/voidlinux/void-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voidlinux/void-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voidlinux/void-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/voidlinux/void-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voidlinux/void-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/voidlinux/void-packages/languages","stargazers_url":"https://api.github.com/repos/voidlinux/void-packages/stargazers","contributors_url":"https://api.github.com/repos/voidlinux/void-packages/contributors","subscribers_url":"https://api.github.com/repos/voidlinux/void-packages/subscribers","subscription_url":"https://api.github.com/repos/voidlinux/void-packages/subscription","commits_url":"https://api.github.com/repos/voidlinux/void-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/voidlinux/void-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/voidlinux/void-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/voidlinux/void-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/voidlinux/void-packages/contents/{+path}","compare_url":"https://api.github.com/repos/voidlinux/void-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voidlinux/void-packages/merges","archive_url":"https://api.github.com/repos/voidlinux/void-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voidlinux/void-packages/downloads","issues_url":"https://api.github.com/repos/voidlinux/void-packages/issues{/number}","pulls_url":"https://api.github.com/repos/voidlinux/void-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/voidlinux/void-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/voidlinux/void-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voidlinux/void-packages/labels{/name}","releases_url":"https://api.github.com/repos/voidlinux/void-packages/releases{/id}","deployments_url":"https://api.github.com/repos/voidlinux/void-packages/deployments","created_at":"2011-07-17T07:26:35Z","updated_at":"2017-12-01T15:57:06Z","pushed_at":"2017-12-01T18:53:08Z","git_url":"git://github.com/voidlinux/void-packages.git","ssh_url":"[email protected]:voidlinux/void-packages.git","clone_url":"https://github.com/voidlinux/void-packages.git","svn_url":"https://github.com/voidlinux/void-packages","homepage":"http://www.voidlinux.eu","size":183006,"stargazers_count":378,"watchers_count":378,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":553,"mirror_url":null,"archived":false,"open_issues_count":725,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":553,"open_issues":725,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/9662"},"html":{"href":"https://github.com/voidlinux/void-packages/pull/9662"},"issue":{"href":"https://api.github.com/repos/voidlinux/void-packages/issues/9662"},"comments":{"href":"https://api.github.com/repos/voidlinux/void-packages/issues/9662/comments"},"review_comments":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/9662/comments"},"review_comment":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/9662/commits"},"statuses":{"href":"https://api.github.com/repos/voidlinux/void-packages/statuses/74cb0f3f6582fb717c7b1c0c90a4916f416a31a8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2060910,
"name": "voidlinux/void-packages",
"url": "https://api.github.com/repos/voidlinux/void-packages"
} | {
"id": 7373356,
"login": "Johnnynator",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7373356?",
"url": "https://api.github.com/users/Johnnynator"
} | {
"id": 1512782,
"login": "voidlinux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1512782?",
"url": "https://api.github.com/orgs/voidlinux"
} | 2017-12-01T19:13:43 | 6931812741 | {"actor":{"display_login":"Johnnynator"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/xshellinc/iotit/pulls/comments/110812034","pull_request_review_id":32010075,"id":110812034,"diff_hunk":"@@ -0,0 +1,150 @@\n+package repo\n+\n+import (\n+\t\"encoding/json\"\n+\t\"errors\"\n+\t\"io/ioutil\"\n+\t\"os\"\n+\t\"path/filepath\"\n+)\n+\n+const missingRepo = \"Device repo is missing\"\n+\n+var path string\n+\n+func init() {\n+\t//p, err := os.Executable()\n+\t//if err != nil {\n+\t//\tlogrus.Error(err)\n+\t//}\n+\n+\tpath = filepath.Join(baseDir, file)\n+}\n+\n+// DeviceImage contains url, title, username and password which are used after flashing\n+type DeviceImage struct {\n+\tUrl string `json`","path":"lib/repo/mapping.go","position":26,"original_position":26,"commit_id":"9bb96250e87997a63391c0ace54b9b659e9ca8b9","original_commit_id":"9bb96250e87997a63391c0ace54b9b659e9ca8b9","user":{"login":"dbsparkle","id":417757,"avatar_url":"https://avatars1.githubusercontent.com/u/417757?v=3","gravatar_id":"","url":"https://api.github.com/users/dbsparkle","html_url":"https://github.com/dbsparkle","followers_url":"https://api.github.com/users/dbsparkle/followers","following_url":"https://api.github.com/users/dbsparkle/following{/other_user}","gists_url":"https://api.github.com/users/dbsparkle/gists{/gist_id}","starred_url":"https://api.github.com/users/dbsparkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbsparkle/subscriptions","organizations_url":"https://api.github.com/users/dbsparkle/orgs","repos_url":"https://api.github.com/users/dbsparkle/repos","events_url":"https://api.github.com/users/dbsparkle/events{/privacy}","received_events_url":"https://api.github.com/users/dbsparkle/received_events","type":"User","site_admin":false},"body":"__[gometalinter]__\n* [vet] struct field tag `json` not compatible with reflect.StructTag.Get: bad syntax for struct tag pair\n\n<!-- Comment by [SideCI](https://sideci.com) -->","created_at":"2017-04-11T04:07:47Z","updated_at":"2017-04-11T04:07:47Z","html_url":"https://github.com/xshellinc/iotit/pull/55#discussion_r110812034","pull_request_url":"https://api.github.com/repos/xshellinc/iotit/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/xshellinc/iotit/pulls/comments/110812034"},"html":{"href":"https://github.com/xshellinc/iotit/pull/55#discussion_r110812034"},"pull_request":{"href":"https://api.github.com/repos/xshellinc/iotit/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/xshellinc/iotit/pulls/55","id":115237368,"html_url":"https://github.com/xshellinc/iotit/pull/55","diff_url":"https://github.com/xshellinc/iotit/pull/55.diff","patch_url":"https://github.com/xshellinc/iotit/pull/55.patch","issue_url":"https://api.github.com/repos/xshellinc/iotit/issues/55","number":55,"state":"open","locked":false,"title":"Feature/adapt new vbox","user":{"login":"larenso","id":4501130,"avatar_url":"https://avatars2.githubusercontent.com/u/4501130?v=3","gravatar_id":"","url":"https://api.github.com/users/larenso","html_url":"https://github.com/larenso","followers_url":"https://api.github.com/users/larenso/followers","following_url":"https://api.github.com/users/larenso/following{/other_user}","gists_url":"https://api.github.com/users/larenso/gists{/gist_id}","starred_url":"https://api.github.com/users/larenso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larenso/subscriptions","organizations_url":"https://api.github.com/users/larenso/orgs","repos_url":"https://api.github.com/users/larenso/repos","events_url":"https://api.github.com/users/larenso/events{/privacy}","received_events_url":"https://api.github.com/users/larenso/received_events","type":"User","site_admin":false},"body":"Merge Feature/adapt new vbox into develop","created_at":"2017-04-11T04:07:19Z","updated_at":"2017-04-11T04:07:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b5277362f1c27ffc2d66b08398ab1beffc03118","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xshellinc/iotit/pulls/55/commits","review_comments_url":"https://api.github.com/repos/xshellinc/iotit/pulls/55/comments","review_comment_url":"https://api.github.com/repos/xshellinc/iotit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xshellinc/iotit/issues/55/comments","statuses_url":"https://api.github.com/repos/xshellinc/iotit/statuses/9bb96250e87997a63391c0ace54b9b659e9ca8b9","head":{"label":"xshellinc:feature/adapt-new-vbox","ref":"feature/adapt-new-vbox","sha":"9bb96250e87997a63391c0ace54b9b659e9ca8b9","user":{"login":"xshellinc","id":11662364,"avatar_url":"https://avatars0.githubusercontent.com/u/11662364?v=3","gravatar_id":"","url":"https://api.github.com/users/xshellinc","html_url":"https://github.com/xshellinc","followers_url":"https://api.github.com/users/xshellinc/followers","following_url":"https://api.github.com/users/xshellinc/following{/other_user}","gists_url":"https://api.github.com/users/xshellinc/gists{/gist_id}","starred_url":"https://api.github.com/users/xshellinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xshellinc/subscriptions","organizations_url":"https://api.github.com/users/xshellinc/orgs","repos_url":"https://api.github.com/users/xshellinc/repos","events_url":"https://api.github.com/users/xshellinc/events{/privacy}","received_events_url":"https://api.github.com/users/xshellinc/received_events","type":"Organization","site_admin":false},"repo":{"id":81157911,"name":"iotit","full_name":"xshellinc/iotit","owner":{"login":"xshellinc","id":11662364,"avatar_url":"https://avatars0.githubusercontent.com/u/11662364?v=3","gravatar_id":"","url":"https://api.github.com/users/xshellinc","html_url":"https://github.com/xshellinc","followers_url":"https://api.github.com/users/xshellinc/followers","following_url":"https://api.github.com/users/xshellinc/following{/other_user}","gists_url":"https://api.github.com/users/xshellinc/gists{/gist_id}","starred_url":"https://api.github.com/users/xshellinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xshellinc/subscriptions","organizations_url":"https://api.github.com/users/xshellinc/orgs","repos_url":"https://api.github.com/users/xshellinc/repos","events_url":"https://api.github.com/users/xshellinc/events{/privacy}","received_events_url":"https://api.github.com/users/xshellinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xshellinc/iotit","description":"Flashing Tool for SBCs","fork":false,"url":"https://api.github.com/repos/xshellinc/iotit","forks_url":"https://api.github.com/repos/xshellinc/iotit/forks","keys_url":"https://api.github.com/repos/xshellinc/iotit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xshellinc/iotit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xshellinc/iotit/teams","hooks_url":"https://api.github.com/repos/xshellinc/iotit/hooks","issue_events_url":"https://api.github.com/repos/xshellinc/iotit/issues/events{/number}","events_url":"https://api.github.com/repos/xshellinc/iotit/events","assignees_url":"https://api.github.com/repos/xshellinc/iotit/assignees{/user}","branches_url":"https://api.github.com/repos/xshellinc/iotit/branches{/branch}","tags_url":"https://api.github.com/repos/xshellinc/iotit/tags","blobs_url":"https://api.github.com/repos/xshellinc/iotit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xshellinc/iotit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xshellinc/iotit/git/refs{/sha}","trees_url":"https://api.github.com/repos/xshellinc/iotit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xshellinc/iotit/statuses/{sha}","languages_url":"https://api.github.com/repos/xshellinc/iotit/languages","stargazers_url":"https://api.github.com/repos/xshellinc/iotit/stargazers","contributors_url":"https://api.github.com/repos/xshellinc/iotit/contributors","subscribers_url":"https://api.github.com/repos/xshellinc/iotit/subscribers","subscription_url":"https://api.github.com/repos/xshellinc/iotit/subscription","commits_url":"https://api.github.com/repos/xshellinc/iotit/commits{/sha}","git_commits_url":"https://api.github.com/repos/xshellinc/iotit/git/commits{/sha}","comments_url":"https://api.github.com/repos/xshellinc/iotit/comments{/number}","issue_comment_url":"https://api.github.com/repos/xshellinc/iotit/issues/comments{/number}","contents_url":"https://api.github.com/repos/xshellinc/iotit/contents/{+path}","compare_url":"https://api.github.com/repos/xshellinc/iotit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xshellinc/iotit/merges","archive_url":"https://api.github.com/repos/xshellinc/iotit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xshellinc/iotit/downloads","issues_url":"https://api.github.com/repos/xshellinc/iotit/issues{/number}","pulls_url":"https://api.github.com/repos/xshellinc/iotit/pulls{/number}","milestones_url":"https://api.github.com/repos/xshellinc/iotit/milestones{/number}","notifications_url":"https://api.github.com/repos/xshellinc/iotit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xshellinc/iotit/labels{/name}","releases_url":"https://api.github.com/repos/xshellinc/iotit/releases{/id}","deployments_url":"https://api.github.com/repos/xshellinc/iotit/deployments","created_at":"2017-02-07T02:40:32Z","updated_at":"2017-03-25T03:18:02Z","pushed_at":"2017-04-11T04:07:20Z","git_url":"git://github.com/xshellinc/iotit.git","ssh_url":"[email protected]:xshellinc/iotit.git","clone_url":"https://github.com/xshellinc/iotit.git","svn_url":"https://github.com/xshellinc/iotit","homepage":null,"size":180,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":15,"default_branch":"master"}},"base":{"label":"xshellinc:develop","ref":"develop","sha":"1bb96a887e3ce1d499290c3625abb457b829416e","user":{"login":"xshellinc","id":11662364,"avatar_url":"https://avatars0.githubusercontent.com/u/11662364?v=3","gravatar_id":"","url":"https://api.github.com/users/xshellinc","html_url":"https://github.com/xshellinc","followers_url":"https://api.github.com/users/xshellinc/followers","following_url":"https://api.github.com/users/xshellinc/following{/other_user}","gists_url":"https://api.github.com/users/xshellinc/gists{/gist_id}","starred_url":"https://api.github.com/users/xshellinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xshellinc/subscriptions","organizations_url":"https://api.github.com/users/xshellinc/orgs","repos_url":"https://api.github.com/users/xshellinc/repos","events_url":"https://api.github.com/users/xshellinc/events{/privacy}","received_events_url":"https://api.github.com/users/xshellinc/received_events","type":"Organization","site_admin":false},"repo":{"id":81157911,"name":"iotit","full_name":"xshellinc/iotit","owner":{"login":"xshellinc","id":11662364,"avatar_url":"https://avatars0.githubusercontent.com/u/11662364?v=3","gravatar_id":"","url":"https://api.github.com/users/xshellinc","html_url":"https://github.com/xshellinc","followers_url":"https://api.github.com/users/xshellinc/followers","following_url":"https://api.github.com/users/xshellinc/following{/other_user}","gists_url":"https://api.github.com/users/xshellinc/gists{/gist_id}","starred_url":"https://api.github.com/users/xshellinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xshellinc/subscriptions","organizations_url":"https://api.github.com/users/xshellinc/orgs","repos_url":"https://api.github.com/users/xshellinc/repos","events_url":"https://api.github.com/users/xshellinc/events{/privacy}","received_events_url":"https://api.github.com/users/xshellinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xshellinc/iotit","description":"Flashing Tool for SBCs","fork":false,"url":"https://api.github.com/repos/xshellinc/iotit","forks_url":"https://api.github.com/repos/xshellinc/iotit/forks","keys_url":"https://api.github.com/repos/xshellinc/iotit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xshellinc/iotit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xshellinc/iotit/teams","hooks_url":"https://api.github.com/repos/xshellinc/iotit/hooks","issue_events_url":"https://api.github.com/repos/xshellinc/iotit/issues/events{/number}","events_url":"https://api.github.com/repos/xshellinc/iotit/events","assignees_url":"https://api.github.com/repos/xshellinc/iotit/assignees{/user}","branches_url":"https://api.github.com/repos/xshellinc/iotit/branches{/branch}","tags_url":"https://api.github.com/repos/xshellinc/iotit/tags","blobs_url":"https://api.github.com/repos/xshellinc/iotit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xshellinc/iotit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xshellinc/iotit/git/refs{/sha}","trees_url":"https://api.github.com/repos/xshellinc/iotit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xshellinc/iotit/statuses/{sha}","languages_url":"https://api.github.com/repos/xshellinc/iotit/languages","stargazers_url":"https://api.github.com/repos/xshellinc/iotit/stargazers","contributors_url":"https://api.github.com/repos/xshellinc/iotit/contributors","subscribers_url":"https://api.github.com/repos/xshellinc/iotit/subscribers","subscription_url":"https://api.github.com/repos/xshellinc/iotit/subscription","commits_url":"https://api.github.com/repos/xshellinc/iotit/commits{/sha}","git_commits_url":"https://api.github.com/repos/xshellinc/iotit/git/commits{/sha}","comments_url":"https://api.github.com/repos/xshellinc/iotit/comments{/number}","issue_comment_url":"https://api.github.com/repos/xshellinc/iotit/issues/comments{/number}","contents_url":"https://api.github.com/repos/xshellinc/iotit/contents/{+path}","compare_url":"https://api.github.com/repos/xshellinc/iotit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xshellinc/iotit/merges","archive_url":"https://api.github.com/repos/xshellinc/iotit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xshellinc/iotit/downloads","issues_url":"https://api.github.com/repos/xshellinc/iotit/issues{/number}","pulls_url":"https://api.github.com/repos/xshellinc/iotit/pulls{/number}","milestones_url":"https://api.github.com/repos/xshellinc/iotit/milestones{/number}","notifications_url":"https://api.github.com/repos/xshellinc/iotit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xshellinc/iotit/labels{/name}","releases_url":"https://api.github.com/repos/xshellinc/iotit/releases{/id}","deployments_url":"https://api.github.com/repos/xshellinc/iotit/deployments","created_at":"2017-02-07T02:40:32Z","updated_at":"2017-03-25T03:18:02Z","pushed_at":"2017-04-11T04:07:20Z","git_url":"git://github.com/xshellinc/iotit.git","ssh_url":"[email protected]:xshellinc/iotit.git","clone_url":"https://github.com/xshellinc/iotit.git","svn_url":"https://github.com/xshellinc/iotit","homepage":null,"size":180,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xshellinc/iotit/pulls/55"},"html":{"href":"https://github.com/xshellinc/iotit/pull/55"},"issue":{"href":"https://api.github.com/repos/xshellinc/iotit/issues/55"},"comments":{"href":"https://api.github.com/repos/xshellinc/iotit/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/xshellinc/iotit/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/xshellinc/iotit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xshellinc/iotit/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/xshellinc/iotit/statuses/9bb96250e87997a63391c0ace54b9b659e9ca8b9"}}}} | {
"id": 81157911,
"name": "xshellinc/iotit",
"url": "https://api.github.com/repos/xshellinc/iotit"
} | {
"id": 417757,
"login": "dbsparkle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/417757?",
"url": "https://api.github.com/users/dbsparkle"
} | {
"id": 11662364,
"login": "xshellinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11662364?",
"url": "https://api.github.com/orgs/xshellinc"
} | 2017-04-11T04:07:47 | 5664794350 | {"actor":{"display_login":"dbsparkle"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yabar-dev/yabar/pulls/comments/95863731","pull_request_review_id":16433247,"id":95863731,"diff_hunk":"@@ -517,6 +517,21 @@ internal-option2: \" \";\n internal-suffix: \"%\";\n internal-spacing: true;\n \n+.fi\n+.RE\n+.IP \\(bu 2\n+Volume: It uses ALSA to display sound volume in percentage. Example:\n+.PP\n+.RS\n+\n+.nf\n+exec: \"YABAR_VOLUME\";\n+interval: 1;\n+internal-option1 : \"default\"; # device\n+internal-option2 : \"Master 0\"; # Mixer index (separated by a space)\n+internal-option3 : \" \"; # characters to display when sound is on or off (separated by a space)","path":"doc/yabar.1","position":16,"original_position":16,"commit_id":"852619b0f761586027e77e2b258c20e3640c5d1a","original_commit_id":"852619b0f761586027e77e2b258c20e3640c5d1a","user":{"login":"NBonaparte","id":12215509,"avatar_url":"https://avatars.githubusercontent.com/u/12215509?v=3","gravatar_id":"","url":"https://api.github.com/users/NBonaparte","html_url":"https://github.com/NBonaparte","followers_url":"https://api.github.com/users/NBonaparte/followers","following_url":"https://api.github.com/users/NBonaparte/following{/other_user}","gists_url":"https://api.github.com/users/NBonaparte/gists{/gist_id}","starred_url":"https://api.github.com/users/NBonaparte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBonaparte/subscriptions","organizations_url":"https://api.github.com/users/NBonaparte/orgs","repos_url":"https://api.github.com/users/NBonaparte/repos","events_url":"https://api.github.com/users/NBonaparte/events{/privacy}","received_events_url":"https://api.github.com/users/NBonaparte/received_events","type":"User","site_admin":false},"body":"We recently changed the delimiter to a semicolon, could you change it here too? (Just put one between the two characters)","created_at":"2017-01-12T19:16:54Z","updated_at":"2017-01-12T19:17:44Z","html_url":"https://github.com/yabar-dev/yabar/pull/2#discussion_r95863731","pull_request_url":"https://api.github.com/repos/yabar-dev/yabar/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/yabar-dev/yabar/pulls/comments/95863731"},"html":{"href":"https://github.com/yabar-dev/yabar/pull/2#discussion_r95863731"},"pull_request":{"href":"https://api.github.com/repos/yabar-dev/yabar/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/yabar-dev/yabar/pulls/2","id":101298427,"html_url":"https://github.com/yabar-dev/yabar/pull/2","diff_url":"https://github.com/yabar-dev/yabar/pull/2.diff","patch_url":"https://github.com/yabar-dev/yabar/pull/2.patch","issue_url":"https://api.github.com/repos/yabar-dev/yabar/issues/2","number":2,"state":"open","locked":false,"title":"add volume internal block","user":{"login":"losynix","id":12864323,"avatar_url":"https://avatars.githubusercontent.com/u/12864323?v=3","gravatar_id":"","url":"https://api.github.com/users/losynix","html_url":"https://github.com/losynix","followers_url":"https://api.github.com/users/losynix/followers","following_url":"https://api.github.com/users/losynix/following{/other_user}","gists_url":"https://api.github.com/users/losynix/gists{/gist_id}","starred_url":"https://api.github.com/users/losynix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losynix/subscriptions","organizations_url":"https://api.github.com/users/losynix/orgs","repos_url":"https://api.github.com/users/losynix/repos","events_url":"https://api.github.com/users/losynix/events{/privacy}","received_events_url":"https://api.github.com/users/losynix/received_events","type":"User","site_admin":false},"body":"Volume internal block:\r\n\r\nexec: \"YABAR_VOLUME\";\r\ninterval: 1;\r\ninternal-option1 : \"default\"; # device\r\ninternal-option2 : \"Master 0\"; # Mixer index (separated by a space)\r\ninternal-option3 : \" \"; # characters to display when sound is on or off (separated by a space)\r\ninternal-suffix: \"%\";","created_at":"2017-01-12T16:54:53Z","updated_at":"2017-01-12T19:17:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bdb3de764d31acedf151d91f502e3d42874b335","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yabar-dev/yabar/pulls/2/commits","review_comments_url":"https://api.github.com/repos/yabar-dev/yabar/pulls/2/comments","review_comment_url":"https://api.github.com/repos/yabar-dev/yabar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yabar-dev/yabar/issues/2/comments","statuses_url":"https://api.github.com/repos/yabar-dev/yabar/statuses/852619b0f761586027e77e2b258c20e3640c5d1a","head":{"label":"losynix:blk-volume","ref":"blk-volume","sha":"852619b0f761586027e77e2b258c20e3640c5d1a","user":{"login":"losynix","id":12864323,"avatar_url":"https://avatars.githubusercontent.com/u/12864323?v=3","gravatar_id":"","url":"https://api.github.com/users/losynix","html_url":"https://github.com/losynix","followers_url":"https://api.github.com/users/losynix/followers","following_url":"https://api.github.com/users/losynix/following{/other_user}","gists_url":"https://api.github.com/users/losynix/gists{/gist_id}","starred_url":"https://api.github.com/users/losynix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losynix/subscriptions","organizations_url":"https://api.github.com/users/losynix/orgs","repos_url":"https://api.github.com/users/losynix/repos","events_url":"https://api.github.com/users/losynix/events{/privacy}","received_events_url":"https://api.github.com/users/losynix/received_events","type":"User","site_admin":false},"repo":{"id":78763152,"name":"yabar-dev","full_name":"losynix/yabar-dev","owner":{"login":"losynix","id":12864323,"avatar_url":"https://avatars.githubusercontent.com/u/12864323?v=3","gravatar_id":"","url":"https://api.github.com/users/losynix","html_url":"https://github.com/losynix","followers_url":"https://api.github.com/users/losynix/followers","following_url":"https://api.github.com/users/losynix/following{/other_user}","gists_url":"https://api.github.com/users/losynix/gists{/gist_id}","starred_url":"https://api.github.com/users/losynix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losynix/subscriptions","organizations_url":"https://api.github.com/users/losynix/orgs","repos_url":"https://api.github.com/users/losynix/repos","events_url":"https://api.github.com/users/losynix/events{/privacy}","received_events_url":"https://api.github.com/users/losynix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/losynix/yabar-dev","description":"A modern and lightweight status bar for X window managers. ","fork":true,"url":"https://api.github.com/repos/losynix/yabar-dev","forks_url":"https://api.github.com/repos/losynix/yabar-dev/forks","keys_url":"https://api.github.com/repos/losynix/yabar-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/losynix/yabar-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/losynix/yabar-dev/teams","hooks_url":"https://api.github.com/repos/losynix/yabar-dev/hooks","issue_events_url":"https://api.github.com/repos/losynix/yabar-dev/issues/events{/number}","events_url":"https://api.github.com/repos/losynix/yabar-dev/events","assignees_url":"https://api.github.com/repos/losynix/yabar-dev/assignees{/user}","branches_url":"https://api.github.com/repos/losynix/yabar-dev/branches{/branch}","tags_url":"https://api.github.com/repos/losynix/yabar-dev/tags","blobs_url":"https://api.github.com/repos/losynix/yabar-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/losynix/yabar-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/losynix/yabar-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/losynix/yabar-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/losynix/yabar-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/losynix/yabar-dev/languages","stargazers_url":"https://api.github.com/repos/losynix/yabar-dev/stargazers","contributors_url":"https://api.github.com/repos/losynix/yabar-dev/contributors","subscribers_url":"https://api.github.com/repos/losynix/yabar-dev/subscribers","subscription_url":"https://api.github.com/repos/losynix/yabar-dev/subscription","commits_url":"https://api.github.com/repos/losynix/yabar-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/losynix/yabar-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/losynix/yabar-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/losynix/yabar-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/losynix/yabar-dev/contents/{+path}","compare_url":"https://api.github.com/repos/losynix/yabar-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/losynix/yabar-dev/merges","archive_url":"https://api.github.com/repos/losynix/yabar-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/losynix/yabar-dev/downloads","issues_url":"https://api.github.com/repos/losynix/yabar-dev/issues{/number}","pulls_url":"https://api.github.com/repos/losynix/yabar-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/losynix/yabar-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/losynix/yabar-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/losynix/yabar-dev/labels{/name}","releases_url":"https://api.github.com/repos/losynix/yabar-dev/releases{/id}","deployments_url":"https://api.github.com/repos/losynix/yabar-dev/deployments","created_at":"2017-01-12T16:14:19Z","updated_at":"2017-01-12T16:14:46Z","pushed_at":"2017-01-12T16:53:43Z","git_url":"git://github.com/losynix/yabar-dev.git","ssh_url":"[email protected]:losynix/yabar-dev.git","clone_url":"https://github.com/losynix/yabar-dev.git","svn_url":"https://github.com/losynix/yabar-dev","homepage":"","size":1078,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yabar-dev:master","ref":"master","sha":"136a713b4f547f711fdcc00c3b73bee0a8383887","user":{"login":"yabar-dev","id":24965273,"avatar_url":"https://avatars.githubusercontent.com/u/24965273?v=3","gravatar_id":"","url":"https://api.github.com/users/yabar-dev","html_url":"https://github.com/yabar-dev","followers_url":"https://api.github.com/users/yabar-dev/followers","following_url":"https://api.github.com/users/yabar-dev/following{/other_user}","gists_url":"https://api.github.com/users/yabar-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/yabar-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yabar-dev/subscriptions","organizations_url":"https://api.github.com/users/yabar-dev/orgs","repos_url":"https://api.github.com/users/yabar-dev/repos","events_url":"https://api.github.com/users/yabar-dev/events{/privacy}","received_events_url":"https://api.github.com/users/yabar-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":78429936,"name":"yabar","full_name":"yabar-dev/yabar","owner":{"login":"yabar-dev","id":24965273,"avatar_url":"https://avatars.githubusercontent.com/u/24965273?v=3","gravatar_id":"","url":"https://api.github.com/users/yabar-dev","html_url":"https://github.com/yabar-dev","followers_url":"https://api.github.com/users/yabar-dev/followers","following_url":"https://api.github.com/users/yabar-dev/following{/other_user}","gists_url":"https://api.github.com/users/yabar-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/yabar-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yabar-dev/subscriptions","organizations_url":"https://api.github.com/users/yabar-dev/orgs","repos_url":"https://api.github.com/users/yabar-dev/repos","events_url":"https://api.github.com/users/yabar-dev/events{/privacy}","received_events_url":"https://api.github.com/users/yabar-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yabar-dev/yabar","description":"A modern and lightweight status bar for X window managers. ","fork":false,"url":"https://api.github.com/repos/yabar-dev/yabar","forks_url":"https://api.github.com/repos/yabar-dev/yabar/forks","keys_url":"https://api.github.com/repos/yabar-dev/yabar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yabar-dev/yabar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yabar-dev/yabar/teams","hooks_url":"https://api.github.com/repos/yabar-dev/yabar/hooks","issue_events_url":"https://api.github.com/repos/yabar-dev/yabar/issues/events{/number}","events_url":"https://api.github.com/repos/yabar-dev/yabar/events","assignees_url":"https://api.github.com/repos/yabar-dev/yabar/assignees{/user}","branches_url":"https://api.github.com/repos/yabar-dev/yabar/branches{/branch}","tags_url":"https://api.github.com/repos/yabar-dev/yabar/tags","blobs_url":"https://api.github.com/repos/yabar-dev/yabar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yabar-dev/yabar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yabar-dev/yabar/git/refs{/sha}","trees_url":"https://api.github.com/repos/yabar-dev/yabar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yabar-dev/yabar/statuses/{sha}","languages_url":"https://api.github.com/repos/yabar-dev/yabar/languages","stargazers_url":"https://api.github.com/repos/yabar-dev/yabar/stargazers","contributors_url":"https://api.github.com/repos/yabar-dev/yabar/contributors","subscribers_url":"https://api.github.com/repos/yabar-dev/yabar/subscribers","subscription_url":"https://api.github.com/repos/yabar-dev/yabar/subscription","commits_url":"https://api.github.com/repos/yabar-dev/yabar/commits{/sha}","git_commits_url":"https://api.github.com/repos/yabar-dev/yabar/git/commits{/sha}","comments_url":"https://api.github.com/repos/yabar-dev/yabar/comments{/number}","issue_comment_url":"https://api.github.com/repos/yabar-dev/yabar/issues/comments{/number}","contents_url":"https://api.github.com/repos/yabar-dev/yabar/contents/{+path}","compare_url":"https://api.github.com/repos/yabar-dev/yabar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yabar-dev/yabar/merges","archive_url":"https://api.github.com/repos/yabar-dev/yabar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yabar-dev/yabar/downloads","issues_url":"https://api.github.com/repos/yabar-dev/yabar/issues{/number}","pulls_url":"https://api.github.com/repos/yabar-dev/yabar/pulls{/number}","milestones_url":"https://api.github.com/repos/yabar-dev/yabar/milestones{/number}","notifications_url":"https://api.github.com/repos/yabar-dev/yabar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yabar-dev/yabar/labels{/name}","releases_url":"https://api.github.com/repos/yabar-dev/yabar/releases{/id}","deployments_url":"https://api.github.com/repos/yabar-dev/yabar/deployments","created_at":"2017-01-09T13:11:37Z","updated_at":"2017-01-12T12:04:46Z","pushed_at":"2017-01-12T19:07:17Z","git_url":"git://github.com/yabar-dev/yabar.git","ssh_url":"[email protected]:yabar-dev/yabar.git","clone_url":"https://github.com/yabar-dev/yabar.git","svn_url":"https://github.com/yabar-dev/yabar","homepage":"","size":1075,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yabar-dev/yabar/pulls/2"},"html":{"href":"https://github.com/yabar-dev/yabar/pull/2"},"issue":{"href":"https://api.github.com/repos/yabar-dev/yabar/issues/2"},"comments":{"href":"https://api.github.com/repos/yabar-dev/yabar/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/yabar-dev/yabar/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/yabar-dev/yabar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yabar-dev/yabar/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/yabar-dev/yabar/statuses/852619b0f761586027e77e2b258c20e3640c5d1a"}}}} | {
"id": 78429936,
"name": "yabar-dev/yabar",
"url": "https://api.github.com/repos/yabar-dev/yabar"
} | {
"id": 12215509,
"login": "NBonaparte",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12215509?",
"url": "https://api.github.com/users/NBonaparte"
} | {
"id": 24965273,
"login": "yabar-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24965273?",
"url": "https://api.github.com/orgs/yabar-dev"
} | 2017-01-12T19:16:54 | 5144656258 | {"actor":{"display_login":"NBonaparte"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/comments/137929258","pull_request_review_id":61665387,"id":137929258,"diff_hunk":"@@ -50,13 +50,12 @@ function copyFileToDir(fileToCopyPath, destinationDir) {\n */\n // eslint-disable-next-line import/prefer-default-export\n export function copyFileToTempDir(fileToCopyPath) {","path":"spec/linter-eslint-spec.js","position":3,"original_position":3,"commit_id":"856fa22aad77ea682ea6885423a946538b96886d","original_commit_id":"856fa22aad77ea682ea6885423a946538b96886d","user":{"login":"skylize","id":844400,"avatar_url":"https://avatars2.githubusercontent.com/u/844400?v=4","gravatar_id":"","url":"https://api.github.com/users/skylize","html_url":"https://github.com/skylize","followers_url":"https://api.github.com/users/skylize/followers","following_url":"https://api.github.com/users/skylize/following{/other_user}","gists_url":"https://api.github.com/users/skylize/gists{/gist_id}","starred_url":"https://api.github.com/users/skylize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylize/subscriptions","organizations_url":"https://api.github.com/users/skylize/orgs","repos_url":"https://api.github.com/users/skylize/repos","events_url":"https://api.github.com/users/skylize/events{/privacy}","received_events_url":"https://api.github.com/users/skylize/received_events","type":"User","site_admin":false},"body":"Looking at this change, seems you are already thinking along same lines as what I said in response to the request for deleting the comment. So I will 🔥 the comment and mark this func as `async` and update the pull.","created_at":"2017-09-09T15:52:48Z","updated_at":"2017-09-09T15:52:48Z","html_url":"https://github.com/AtomLinter/linter-eslint/pull/1007#discussion_r137929258","pull_request_url":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/1007","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/comments/137929258"},"html":{"href":"https://github.com/AtomLinter/linter-eslint/pull/1007#discussion_r137929258"},"pull_request":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/1007"}},"in_reply_to_id":137916092},"pull_request":{"url":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/1007","id":140148427,"html_url":"https://github.com/AtomLinter/linter-eslint/pull/1007","diff_url":"https://github.com/AtomLinter/linter-eslint/pull/1007.diff","patch_url":"https://github.com/AtomLinter/linter-eslint/pull/1007.patch","issue_url":"https://api.github.com/repos/AtomLinter/linter-eslint/issues/1007","number":1007,"state":"open","locked":false,"title":"remove superfluous async & Promise from some specs","user":{"login":"skylize","id":844400,"avatar_url":"https://avatars2.githubusercontent.com/u/844400?v=4","gravatar_id":"","url":"https://api.github.com/users/skylize","html_url":"https://github.com/skylize","followers_url":"https://api.github.com/users/skylize/followers","following_url":"https://api.github.com/users/skylize/following{/other_user}","gists_url":"https://api.github.com/users/skylize/gists{/gist_id}","starred_url":"https://api.github.com/users/skylize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylize/subscriptions","organizations_url":"https://api.github.com/users/skylize/orgs","repos_url":"https://api.github.com/users/skylize/repos","events_url":"https://api.github.com/users/skylize/events{/privacy}","received_events_url":"https://api.github.com/users/skylize/received_events","type":"User","site_admin":false},"body":"Removes some uses of -new Promise- and -async/await- that do not serve any real purpose because underlying function calls already return promise","created_at":"2017-09-09T00:41:52Z","updated_at":"2017-09-09T15:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdb6289da9ed08a2b2bd58cd507417d8d64fd2bd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"IanVS","id":4616705,"avatar_url":"https://avatars0.githubusercontent.com/u/4616705?v=4","gravatar_id":"","url":"https://api.github.com/users/IanVS","html_url":"https://github.com/IanVS","followers_url":"https://api.github.com/users/IanVS/followers","following_url":"https://api.github.com/users/IanVS/following{/other_user}","gists_url":"https://api.github.com/users/IanVS/gists{/gist_id}","starred_url":"https://api.github.com/users/IanVS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanVS/subscriptions","organizations_url":"https://api.github.com/users/IanVS/orgs","repos_url":"https://api.github.com/users/IanVS/repos","events_url":"https://api.github.com/users/IanVS/events{/privacy}","received_events_url":"https://api.github.com/users/IanVS/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/1007/commits","review_comments_url":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/1007/comments","review_comment_url":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AtomLinter/linter-eslint/issues/1007/comments","statuses_url":"https://api.github.com/repos/AtomLinter/linter-eslint/statuses/856fa22aad77ea682ea6885423a946538b96886d","head":{"label":"skylize:testCleanup2","ref":"testCleanup2","sha":"856fa22aad77ea682ea6885423a946538b96886d","user":{"login":"skylize","id":844400,"avatar_url":"https://avatars2.githubusercontent.com/u/844400?v=4","gravatar_id":"","url":"https://api.github.com/users/skylize","html_url":"https://github.com/skylize","followers_url":"https://api.github.com/users/skylize/followers","following_url":"https://api.github.com/users/skylize/following{/other_user}","gists_url":"https://api.github.com/users/skylize/gists{/gist_id}","starred_url":"https://api.github.com/users/skylize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylize/subscriptions","organizations_url":"https://api.github.com/users/skylize/orgs","repos_url":"https://api.github.com/users/skylize/repos","events_url":"https://api.github.com/users/skylize/events{/privacy}","received_events_url":"https://api.github.com/users/skylize/received_events","type":"User","site_admin":false},"repo":{"id":102798208,"name":"linter-eslint","full_name":"skylize/linter-eslint","owner":{"login":"skylize","id":844400,"avatar_url":"https://avatars2.githubusercontent.com/u/844400?v=4","gravatar_id":"","url":"https://api.github.com/users/skylize","html_url":"https://github.com/skylize","followers_url":"https://api.github.com/users/skylize/followers","following_url":"https://api.github.com/users/skylize/following{/other_user}","gists_url":"https://api.github.com/users/skylize/gists{/gist_id}","starred_url":"https://api.github.com/users/skylize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylize/subscriptions","organizations_url":"https://api.github.com/users/skylize/orgs","repos_url":"https://api.github.com/users/skylize/repos","events_url":"https://api.github.com/users/skylize/events{/privacy}","received_events_url":"https://api.github.com/users/skylize/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skylize/linter-eslint","description":"ESLint plugin for Atom Linter","fork":true,"url":"https://api.github.com/repos/skylize/linter-eslint","forks_url":"https://api.github.com/repos/skylize/linter-eslint/forks","keys_url":"https://api.github.com/repos/skylize/linter-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skylize/linter-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skylize/linter-eslint/teams","hooks_url":"https://api.github.com/repos/skylize/linter-eslint/hooks","issue_events_url":"https://api.github.com/repos/skylize/linter-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/skylize/linter-eslint/events","assignees_url":"https://api.github.com/repos/skylize/linter-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/skylize/linter-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/skylize/linter-eslint/tags","blobs_url":"https://api.github.com/repos/skylize/linter-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skylize/linter-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skylize/linter-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/skylize/linter-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skylize/linter-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/skylize/linter-eslint/languages","stargazers_url":"https://api.github.com/repos/skylize/linter-eslint/stargazers","contributors_url":"https://api.github.com/repos/skylize/linter-eslint/contributors","subscribers_url":"https://api.github.com/repos/skylize/linter-eslint/subscribers","subscription_url":"https://api.github.com/repos/skylize/linter-eslint/subscription","commits_url":"https://api.github.com/repos/skylize/linter-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/skylize/linter-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/skylize/linter-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/skylize/linter-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/skylize/linter-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/skylize/linter-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skylize/linter-eslint/merges","archive_url":"https://api.github.com/repos/skylize/linter-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skylize/linter-eslint/downloads","issues_url":"https://api.github.com/repos/skylize/linter-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/skylize/linter-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/skylize/linter-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/skylize/linter-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skylize/linter-eslint/labels{/name}","releases_url":"https://api.github.com/repos/skylize/linter-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/skylize/linter-eslint/deployments","created_at":"2017-09-08T00:17:16Z","updated_at":"2017-09-08T00:17:17Z","pushed_at":"2017-09-09T04:57:38Z","git_url":"git://github.com/skylize/linter-eslint.git","ssh_url":"[email protected]:skylize/linter-eslint.git","clone_url":"https://github.com/skylize/linter-eslint.git","svn_url":"https://github.com/skylize/linter-eslint","homepage":null,"size":948,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AtomLinter:master","ref":"master","sha":"c49397c2577541b47b67572bf7f7264f4adf067d","user":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars0.githubusercontent.com/u/7242824?v=4","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"repo":{"id":21243212,"name":"linter-eslint","full_name":"AtomLinter/linter-eslint","owner":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars0.githubusercontent.com/u/7242824?v=4","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomLinter/linter-eslint","description":"ESLint plugin for Atom Linter","fork":false,"url":"https://api.github.com/repos/AtomLinter/linter-eslint","forks_url":"https://api.github.com/repos/AtomLinter/linter-eslint/forks","keys_url":"https://api.github.com/repos/AtomLinter/linter-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomLinter/linter-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomLinter/linter-eslint/teams","hooks_url":"https://api.github.com/repos/AtomLinter/linter-eslint/hooks","issue_events_url":"https://api.github.com/repos/AtomLinter/linter-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/AtomLinter/linter-eslint/events","assignees_url":"https://api.github.com/repos/AtomLinter/linter-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/AtomLinter/linter-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/AtomLinter/linter-eslint/tags","blobs_url":"https://api.github.com/repos/AtomLinter/linter-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomLinter/linter-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomLinter/linter-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomLinter/linter-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomLinter/linter-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomLinter/linter-eslint/languages","stargazers_url":"https://api.github.com/repos/AtomLinter/linter-eslint/stargazers","contributors_url":"https://api.github.com/repos/AtomLinter/linter-eslint/contributors","subscribers_url":"https://api.github.com/repos/AtomLinter/linter-eslint/subscribers","subscription_url":"https://api.github.com/repos/AtomLinter/linter-eslint/subscription","commits_url":"https://api.github.com/repos/AtomLinter/linter-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomLinter/linter-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomLinter/linter-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomLinter/linter-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomLinter/linter-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/AtomLinter/linter-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomLinter/linter-eslint/merges","archive_url":"https://api.github.com/repos/AtomLinter/linter-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomLinter/linter-eslint/downloads","issues_url":"https://api.github.com/repos/AtomLinter/linter-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomLinter/linter-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomLinter/linter-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomLinter/linter-eslint/labels{/name}","releases_url":"https://api.github.com/repos/AtomLinter/linter-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/AtomLinter/linter-eslint/deployments","created_at":"2014-06-26T14:19:58Z","updated_at":"2017-09-08T17:06:53Z","pushed_at":"2017-09-09T05:03:38Z","git_url":"git://github.com/AtomLinter/linter-eslint.git","ssh_url":"[email protected]:AtomLinter/linter-eslint.git","clone_url":"https://github.com/AtomLinter/linter-eslint.git","svn_url":"https://github.com/AtomLinter/linter-eslint","homepage":null,"size":989,"stargazers_count":443,"watchers_count":443,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":45,"forks":121,"open_issues":45,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/1007"},"html":{"href":"https://github.com/AtomLinter/linter-eslint/pull/1007"},"issue":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/issues/1007"},"comments":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/issues/1007/comments"},"review_comments":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/1007/comments"},"review_comment":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/pulls/1007/commits"},"statuses":{"href":"https://api.github.com/repos/AtomLinter/linter-eslint/statuses/856fa22aad77ea682ea6885423a946538b96886d"}},"author_association":"NONE"}} | {
"id": 21243212,
"name": "AtomLinter/linter-eslint",
"url": "https://api.github.com/repos/AtomLinter/linter-eslint"
} | {
"id": 844400,
"login": "skylize",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/844400?",
"url": "https://api.github.com/users/skylize"
} | {
"id": 7242824,
"login": "AtomLinter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7242824?",
"url": "https://api.github.com/orgs/AtomLinter"
} | 2017-09-09T15:52:48 | 6569971619 | {"actor":{"display_login":"skylize"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/129321163","pull_request_review_id":52081579,"id":129321163,"diff_hunk":"@@ -169,6 +240,13 @@ class PostCommentList extends React.Component {\n \t\t);\n \t};\n \n+\tscrollToComment = () => {\n+\t\tconst comment = window.document.getElementsByName( window.location.hash.substring( 1 ) )[ 0 ];\n+\t\tcomment.scrollIntoView();","path":"client/blocks/comments/post-comment-list.jsx","position":null,"original_position":172,"commit_id":"be6650ba37df1d5c9d5eb717449755151f9d4557","original_commit_id":"e602f4bab011e10d35ba8dd451258cb3c3377552","user":{"login":"blowery","id":14350,"avatar_url":"https://avatars1.githubusercontent.com/u/14350?v=4","gravatar_id":"","url":"https://api.github.com/users/blowery","html_url":"https://github.com/blowery","followers_url":"https://api.github.com/users/blowery/followers","following_url":"https://api.github.com/users/blowery/following{/other_user}","gists_url":"https://api.github.com/users/blowery/gists{/gist_id}","starred_url":"https://api.github.com/users/blowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowery/subscriptions","organizations_url":"https://api.github.com/users/blowery/orgs","repos_url":"https://api.github.com/users/blowery/repos","events_url":"https://api.github.com/users/blowery/events{/privacy}","received_events_url":"https://api.github.com/users/blowery/received_events","type":"User","site_admin":false},"body":"https://readable-email.org/list/whatwg/topic/scrollintoview","created_at":"2017-07-25T14:28:15Z","updated_at":"2017-07-25T14:28:15Z","html_url":"https://github.com/Automattic/wp-calypso/pull/15882#discussion_r129321163","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15882","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/129321163"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/15882#discussion_r129321163"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15882"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15882","id":129046900,"html_url":"https://github.com/Automattic/wp-calypso/pull/15882","diff_url":"https://github.com/Automattic/wp-calypso/pull/15882.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/15882.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/15882","number":15882,"state":"open","locked":false,"title":"Reader: Comment Deep Linking (Permalinks)","user":{"login":"samouri","id":4656974,"avatar_url":"https://avatars1.githubusercontent.com/u/4656974?v=4","gravatar_id":"","url":"https://api.github.com/users/samouri","html_url":"https://github.com/samouri","followers_url":"https://api.github.com/users/samouri/followers","following_url":"https://api.github.com/users/samouri/following{/other_user}","gists_url":"https://api.github.com/users/samouri/gists{/gist_id}","starred_url":"https://api.github.com/users/samouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samouri/subscriptions","organizations_url":"https://api.github.com/users/samouri/orgs","repos_url":"https://api.github.com/users/samouri/repos","events_url":"https://api.github.com/users/samouri/events{/privacy}","received_events_url":"https://api.github.com/users/samouri/received_events","type":"User","site_admin":false},"body":"Currently the Reader doesn't support linking directly to a comment. \r\nThis in particular is a blocker for https://github.com/Automattic/wp-calypso/pull/14396, as well as other improvements we have planned down the line.\r\n\r\nIn order to get us all the way to being capable of linking directly to comments there are a few steps:\r\n1. [x] enable bidirectional paging from any comment to earlier/later comments\r\n2. [x] enable loading a specific comment directly. https://github.com/Automattic/wp-calypso/pull/16006\r\n3. [x] make full-post pay attention to anchors in the url and start from the specified comment\r\n\r\n\r\nTo Test:\r\n- [ ] comments in My Sites still render properly. \r\n- [ ] comments in Reader still render properly when not deep linking\r\n- [ ] going to a Reader full-post url that ends in #comment-${id} renders / scrolls you to that specific comment with the ability to paginate if necessary in either direction. I recommend testing multiple posts with different number of comments: 100s, < 10, and 1.\r\n- [ ] works with invalid commentIds (doesnt break calypso)\r\n- [ ] works with valid commentId but for the wrong site.","created_at":"2017-07-05T20:22:26Z","updated_at":"2017-07-25T14:28:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c58b8116174e2c7d3da5c9f7e80096850e2d75ef","assignee":{"login":"samouri","id":4656974,"avatar_url":"https://avatars1.githubusercontent.com/u/4656974?v=4","gravatar_id":"","url":"https://api.github.com/users/samouri","html_url":"https://github.com/samouri","followers_url":"https://api.github.com/users/samouri/followers","following_url":"https://api.github.com/users/samouri/following{/other_user}","gists_url":"https://api.github.com/users/samouri/gists{/gist_id}","starred_url":"https://api.github.com/users/samouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samouri/subscriptions","organizations_url":"https://api.github.com/users/samouri/orgs","repos_url":"https://api.github.com/users/samouri/repos","events_url":"https://api.github.com/users/samouri/events{/privacy}","received_events_url":"https://api.github.com/users/samouri/received_events","type":"User","site_admin":false},"assignees":[{"login":"samouri","id":4656974,"avatar_url":"https://avatars1.githubusercontent.com/u/4656974?v=4","gravatar_id":"","url":"https://api.github.com/users/samouri","html_url":"https://github.com/samouri","followers_url":"https://api.github.com/users/samouri/followers","following_url":"https://api.github.com/users/samouri/following{/other_user}","gists_url":"https://api.github.com/users/samouri/gists{/gist_id}","starred_url":"https://api.github.com/users/samouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samouri/subscriptions","organizations_url":"https://api.github.com/users/samouri/orgs","repos_url":"https://api.github.com/users/samouri/repos","events_url":"https://api.github.com/users/samouri/events{/privacy}","received_events_url":"https://api.github.com/users/samouri/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15882/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15882/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/15882/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/be6650ba37df1d5c9d5eb717449755151f9d4557","head":{"label":"Automattic:add/reader/bidirectional-paging-comments","ref":"add/reader/bidirectional-paging-comments","sha":"be6650ba37df1d5c9d5eb717449755151f9d4557","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-07-25T12:55:44Z","pushed_at":"2017-07-25T14:21:29Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"[email protected]:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":69591,"stargazers_count":8964,"watchers_count":8964,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1191,"mirror_url":null,"open_issues_count":2167,"forks":1191,"open_issues":2167,"watchers":8964,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"e8ac97ffc08c386afa3fce511800a1a827574bd0","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-07-25T12:55:44Z","pushed_at":"2017-07-25T14:21:29Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"[email protected]:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":69591,"stargazers_count":8964,"watchers_count":8964,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1191,"mirror_url":null,"open_issues_count":2167,"forks":1191,"open_issues":2167,"watchers":8964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15882"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/15882"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/15882"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/15882/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15882/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15882/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/be6650ba37df1d5c9d5eb717449755151f9d4557"}}}} | {
"id": 45936895,
"name": "Automattic/wp-calypso",
"url": "https://api.github.com/repos/Automattic/wp-calypso"
} | {
"id": 14350,
"login": "blowery",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14350?",
"url": "https://api.github.com/users/blowery"
} | {
"id": 887802,
"login": "Automattic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/887802?",
"url": "https://api.github.com/orgs/Automattic"
} | 2017-07-25T14:28:15 | 6324596667 | {"actor":{"display_login":"blowery"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/156154022","pull_request_review_id":82583658,"id":156154022,"diff_hunk":"@@ -14,23 +14,23 @@ import { isMainSiteOf } from 'state/selectors';\n import { getSite, isJetpackSiteMainNetworkSite } from 'state/sites/selectors';\n \n /**\n- * Returns the secondary sites of a given site\n- * Returns null if main site is not found or if the site is not a main site\n+ * Returns the member sites (main or secondary) of given network site\n+ * Returns null if main site is not found or if the site is not a main site of a network\n *\n- * @param {Object} state Global state tree\n- * @param {Number} siteId The ID of the main site for which we're retrieving the secondary sites\n- * @return {?Array} Array of secondary sites\n+ * @param {Object} state Global state tree\n+ * @param {Number} mainSiteId The ID of the main site for which we're retrieving the network sites\n+ * @return {?Array} Array of network sites (the main one and the secondary ones)\n */\n export default createSelector(\n-\t( state, siteId ) => {\n-\t\tconst isMainNetworkSite = isJetpackSiteMainNetworkSite( state, siteId );\n-\t\tif ( ! isMainNetworkSite ) {\n+\t( state, mainSiteId ) => {\n+\t\tif ( ! isJetpackSiteMainNetworkSite( state, mainSiteId ) ) {\n \t\t\treturn null;\n \t\t}\n-\t\tconst siteIds = Object.keys( get( state, 'sites.items', {} ) );\n-\t\treturn siteIds\n-\t\t\t.filter( secondarySiteId => isMainSiteOf( state, siteId, secondarySiteId ) )\n-\t\t\t.map( secondarySiteId => getSite( state, secondarySiteId ) );\n+\n+\t\treturn filter(\n+\t\t\tstate.sites.items,","path":"client/state/selectors/get-network-sites.js","position":39,"original_position":39,"commit_id":"c8ed38cd588bfca113b8ea2851a26dfcd550920d","original_commit_id":"723d40295d05d39992484c4234f39d7450580415","user":{"login":"lamosty","id":4988512,"avatar_url":"https://avatars0.githubusercontent.com/u/4988512?v=4","gravatar_id":"","url":"https://api.github.com/users/lamosty","html_url":"https://github.com/lamosty","followers_url":"https://api.github.com/users/lamosty/followers","following_url":"https://api.github.com/users/lamosty/following{/other_user}","gists_url":"https://api.github.com/users/lamosty/gists{/gist_id}","starred_url":"https://api.github.com/users/lamosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamosty/subscriptions","organizations_url":"https://api.github.com/users/lamosty/orgs","repos_url":"https://api.github.com/users/lamosty/repos","events_url":"https://api.github.com/users/lamosty/events{/privacy}","received_events_url":"https://api.github.com/users/lamosty/received_events","type":"User","site_admin":false},"body":"Are `state.sites` always defined? Wouldn't it be safer using `get` here?","created_at":"2017-12-11T18:13:51Z","updated_at":"2017-12-11T18:22:36Z","html_url":"https://github.com/Automattic/wp-calypso/pull/20514#discussion_r156154022","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20514","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/156154022"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/20514#discussion_r156154022"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20514"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20514","id":156521237,"html_url":"https://github.com/Automattic/wp-calypso/pull/20514","diff_url":"https://github.com/Automattic/wp-calypso/pull/20514.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/20514.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20514","number":20514,"state":"open","locked":false,"title":" Plugins: remove sites-list and lib/site from plugins Flux store","user":{"login":"jsnajdr","id":664258,"avatar_url":"https://avatars3.githubusercontent.com/u/664258?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnajdr","html_url":"https://github.com/jsnajdr","followers_url":"https://api.github.com/users/jsnajdr/followers","following_url":"https://api.github.com/users/jsnajdr/following{/other_user}","gists_url":"https://api.github.com/users/jsnajdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnajdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnajdr/subscriptions","organizations_url":"https://api.github.com/users/jsnajdr/orgs","repos_url":"https://api.github.com/users/jsnajdr/repos","events_url":"https://api.github.com/users/jsnajdr/events{/privacy}","received_events_url":"https://api.github.com/users/jsnajdr/received_events","type":"User","site_admin":false},"body":"Removes `sites-list` (namely the `getNetworkSites` method) and replaces it with equivalent Redux selectors.\r\n\r\nAlso removes usage of `lib/site` (the `Site` and `JetpackSite` classes) and leaves just the plain site objects returned by the `getSite` selector. These object have all the computed attributes that are equivalent to `JetpackSite` methods like `canManage`.\r\n\r\nSee commit messages of individual commits for more.\r\n\r\n**How to test:**\r\nRequires an account with multiple Jetpack sites. Install various plugins on them and check that the UI for displaying the plugin info and the sites it's installed on still works correctly.\r\n\r\nSome changes are related to network sites. It would be nice to test on a network site -- are the main and secondary sites displayed correctly? I admit that I didn't test on a network yet. Some useful links on how to create a testing network site I got from @lamosty:\r\n- https://codex.wordpress.org/Create_A_Network\r\n- https://github.com/hootsuite/wordpress-multisite-vagrant\r\n","created_at":"2017-12-05T17:09:18Z","updated_at":"2017-12-11T18:22:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14c0fb1451d503073454c79b1123062836fa2103","assignee":{"login":"jsnajdr","id":664258,"avatar_url":"https://avatars3.githubusercontent.com/u/664258?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnajdr","html_url":"https://github.com/jsnajdr","followers_url":"https://api.github.com/users/jsnajdr/followers","following_url":"https://api.github.com/users/jsnajdr/following{/other_user}","gists_url":"https://api.github.com/users/jsnajdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnajdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnajdr/subscriptions","organizations_url":"https://api.github.com/users/jsnajdr/orgs","repos_url":"https://api.github.com/users/jsnajdr/repos","events_url":"https://api.github.com/users/jsnajdr/events{/privacy}","received_events_url":"https://api.github.com/users/jsnajdr/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsnajdr","id":664258,"avatar_url":"https://avatars3.githubusercontent.com/u/664258?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnajdr","html_url":"https://github.com/jsnajdr","followers_url":"https://api.github.com/users/jsnajdr/followers","following_url":"https://api.github.com/users/jsnajdr/following{/other_user}","gists_url":"https://api.github.com/users/jsnajdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnajdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnajdr/subscriptions","organizations_url":"https://api.github.com/users/jsnajdr/orgs","repos_url":"https://api.github.com/users/jsnajdr/repos","events_url":"https://api.github.com/users/jsnajdr/events{/privacy}","received_events_url":"https://api.github.com/users/jsnajdr/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ockham","id":96308,"avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},{"login":"enejb","id":115071,"avatar_url":"https://avatars2.githubusercontent.com/u/115071?v=4","gravatar_id":"","url":"https://api.github.com/users/enejb","html_url":"https://github.com/enejb","followers_url":"https://api.github.com/users/enejb/followers","following_url":"https://api.github.com/users/enejb/following{/other_user}","gists_url":"https://api.github.com/users/enejb/gists{/gist_id}","starred_url":"https://api.github.com/users/enejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enejb/subscriptions","organizations_url":"https://api.github.com/users/enejb/orgs","repos_url":"https://api.github.com/users/enejb/repos","events_url":"https://api.github.com/users/enejb/events{/privacy}","received_events_url":"https://api.github.com/users/enejb/received_events","type":"User","site_admin":false},{"login":"Tug","id":230230,"avatar_url":"https://avatars0.githubusercontent.com/u/230230?v=4","gravatar_id":"","url":"https://api.github.com/users/Tug","html_url":"https://github.com/Tug","followers_url":"https://api.github.com/users/Tug/followers","following_url":"https://api.github.com/users/Tug/following{/other_user}","gists_url":"https://api.github.com/users/Tug/gists{/gist_id}","starred_url":"https://api.github.com/users/Tug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tug/subscriptions","organizations_url":"https://api.github.com/users/Tug/orgs","repos_url":"https://api.github.com/users/Tug/repos","events_url":"https://api.github.com/users/Tug/events{/privacy}","received_events_url":"https://api.github.com/users/Tug/received_events","type":"User","site_admin":false},{"login":"apeatling","id":1464705,"avatar_url":"https://avatars3.githubusercontent.com/u/1464705?v=4","gravatar_id":"","url":"https://api.github.com/users/apeatling","html_url":"https://github.com/apeatling","followers_url":"https://api.github.com/users/apeatling/followers","following_url":"https://api.github.com/users/apeatling/following{/other_user}","gists_url":"https://api.github.com/users/apeatling/gists{/gist_id}","starred_url":"https://api.github.com/users/apeatling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apeatling/subscriptions","organizations_url":"https://api.github.com/users/apeatling/orgs","repos_url":"https://api.github.com/users/apeatling/repos","events_url":"https://api.github.com/users/apeatling/events{/privacy}","received_events_url":"https://api.github.com/users/apeatling/received_events","type":"User","site_admin":false},{"login":"sirbrillig","id":2036909,"avatar_url":"https://avatars2.githubusercontent.com/u/2036909?v=4","gravatar_id":"","url":"https://api.github.com/users/sirbrillig","html_url":"https://github.com/sirbrillig","followers_url":"https://api.github.com/users/sirbrillig/followers","following_url":"https://api.github.com/users/sirbrillig/following{/other_user}","gists_url":"https://api.github.com/users/sirbrillig/gists{/gist_id}","starred_url":"https://api.github.com/users/sirbrillig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirbrillig/subscriptions","organizations_url":"https://api.github.com/users/sirbrillig/orgs","repos_url":"https://api.github.com/users/sirbrillig/repos","events_url":"https://api.github.com/users/sirbrillig/events{/privacy}","received_events_url":"https://api.github.com/users/sirbrillig/received_events","type":"User","site_admin":false},{"login":"jorgefilipecosta","id":11271197,"avatar_url":"https://avatars1.githubusercontent.com/u/11271197?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgefilipecosta","html_url":"https://github.com/jorgefilipecosta","followers_url":"https://api.github.com/users/jorgefilipecosta/followers","following_url":"https://api.github.com/users/jorgefilipecosta/following{/other_user}","gists_url":"https://api.github.com/users/jorgefilipecosta/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgefilipecosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgefilipecosta/subscriptions","organizations_url":"https://api.github.com/users/jorgefilipecosta/orgs","repos_url":"https://api.github.com/users/jorgefilipecosta/repos","events_url":"https://api.github.com/users/jorgefilipecosta/events{/privacy}","received_events_url":"https://api.github.com/users/jorgefilipecosta/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20514/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20514/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20514/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/c8ed38cd588bfca113b8ea2851a26dfcd550920d","head":{"label":"Automattic:sites-list/remove-from-plugins","ref":"sites-list/remove-from-plugins","sha":"c8ed38cd588bfca113b8ea2851a26dfcd550920d","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-12-11T14:14:01Z","pushed_at":"2017-12-11T17:59:20Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"[email protected]:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":72519,"stargazers_count":9510,"watchers_count":9510,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1318,"mirror_url":null,"archived":false,"open_issues_count":2285,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1318,"open_issues":2285,"watchers":9510,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"ed922855c0c734a7ce7411c9f2cd0d59c7241b9e","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-12-11T14:14:01Z","pushed_at":"2017-12-11T17:59:20Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"[email protected]:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":72519,"stargazers_count":9510,"watchers_count":9510,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1318,"mirror_url":null,"archived":false,"open_issues_count":2285,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1318,"open_issues":2285,"watchers":9510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20514"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/20514"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/20514"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/20514/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20514/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20514/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/c8ed38cd588bfca113b8ea2851a26dfcd550920d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 45936895,
"name": "Automattic/wp-calypso",
"url": "https://api.github.com/repos/Automattic/wp-calypso"
} | {
"id": 4988512,
"login": "lamosty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4988512?",
"url": "https://api.github.com/users/lamosty"
} | {
"id": 887802,
"login": "Automattic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/887802?",
"url": "https://api.github.com/orgs/Automattic"
} | 2017-12-11T18:13:51 | 6972837431 | {"actor":{"display_login":"lamosty"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/112681455","pull_request_review_id":34016140,"id":112681455,"diff_hunk":"@@ -1,212 +1,179 @@\n /**\n * External dependencies\n */\n-var React = require( 'react' ),\n-\tdebug = require( 'debug' )( 'calypso:my-sites:site-settings:security:monitor' );\n+import React, { Component } from 'react';\n+import { connect } from 'react-redux';\n+import { localize } from 'i18n-calypso';\n+import { isEmpty, partial } from 'lodash';\n \n /**\n * Internal dependencies\n */\n-var config = require( 'config' ),\n-\tCard = require( 'components/card' ),\n-\tFormCheckbox = require( 'components/forms/form-checkbox' ),\n-\tFormLabel = require( 'components/forms/form-label' ),\n-\tformBase = require( './form-base' ),\n-\tnotices = require( 'notices' ),\n-\tdirtyLinkedState = require( 'lib/mixins/dirty-linked-state' ),\n-\tSectionHeader = require( 'components/section-header' ),\n-\tButton = require( 'components/button' );\n-import { protectForm } from 'lib/protect-form';\n-\n-module.exports = protectForm( React.createClass( {\n-\n-\tdisplayName: 'SiteSettingsFormJetpackMonitor',\n-\n-\tmixins: [ dirtyLinkedState, formBase ],\n-\n-\tgetSettingsFromSite: function( site ) {\n-\t\tvar settings = {};\n-\n-\t\tsite = site || this.props.site;\n-\t\tsettings.fetchingSettings = site.fetchingSettings;\n-\n-\t\treturn settings;\n-\t},\n-\n-\tresetState: function() {\n-\t\tthis.replaceState( {\n-\t\t\ttogglingModule: false,\n-\t\t\temailNotifications: false,\n-\t\t\twpNoteNotifications: false\n-\t\t} );\n-\t},\n-\n-\tgetModuleStatus: function( site ) {\n-\t\tsite = site || this.props.site;\n+import config from 'config';\n+import Card from 'components/card';\n+import CompactFormToggle from 'components/forms/form-toggle/compact';\n+import JetpackModuleToggle from 'my-sites/site-settings/jetpack-module-toggle';\n+import SectionHeader from 'components/section-header';\n+import InfoPopover from 'components/info-popover';\n+import ExternalLink from 'components/external-link';\n+import QueryJetpackModules from 'components/data/query-jetpack-modules';\n+import QuerySiteMonitorSettings from 'components/data/query-site-monitor-settings';\n+import { getSelectedSiteId } from 'state/ui/selectors';\n+import { updateSiteMonitorSettings } from 'state/sites/monitor/actions';\n+import { recordGoogleEvent } from 'state/analytics/actions';\n+import {\n+\tgetSiteMonitorSettings,\n+\tisActivatingJetpackModule,\n+\tisDeactivatingJetpackModule,\n+\tisFetchingJetpackModules,\n+\tisJetpackModuleActive,\n+\tisRequestingSiteMonitorSettings,\n+\tisUpdatingSiteMonitorSettings\n+} from 'state/selectors';\n+\n+class SiteSettingsFormJetpackMonitor extends Component {\n+\tstate = {};\n+\n+\tcomponentWillReceiveProps( nextProps ) {\n+\t\tif ( isEmpty( this.state ) && nextProps.monitorSettings ) {\n+\t\t\tthis.setState( nextProps.monitorSettings );\n+\t\t}\n+\t}\n \n-\t\tsite.fetchMonitorSettings( ( function( error, data ) {\n-\t\t\tif ( ! error ) {\n-\t\t\t\tthis.setState( {\n-\t\t\t\t\temailNotifications: data.settings.email_notifications,\n-\t\t\t\t\twpNoteNotifications: data.settings.wp_note_notifications\n-\t\t\t\t} );\n-\t\t\t} else {\n-\t\t\t\tdebug( 'error getting Monitor settings', error );\n-\t\t\t}\n-\t\t} ).bind( this ) );\n+\trecordEvent = ( event ) => {\n+\t\treturn () => {\n+\t\t\tthis.props.trackEvent( event );\n+\t\t};\n+\t}\n \n+\thandleToggle = name => () => {\n+\t\tthis.props.trackEvent( `Toggled ${ name }` );\n \t\tthis.setState( {\n-\t\t\tenabled: site.isModuleActive( 'monitor' )\n-\t\t} );\n-\t},\n+\t\t\t...this.state,\n+\t\t\t[ name ]: ! this.state[ name ],\n+\t\t}, this.saveSettings );\n+\t}\n \n-\tprompt: function() {\n-\t\treturn (\n-\t\t\t<div className=\"site-settings__jetpack-prompt\">\n-\t\t\t\t<img src=\"/calypso/images/jetpack/illustration-jetpack-monitor.svg\" width=\"128\" height=\"128\" />\n-\n-\t\t\t\t<div className=\"site-settings__jetpack-prompt-text\">\n-\t\t\t\t\t<p>{ this.translate( \"Automatically monitor your website and make sure it's online.\" ) }</p>\n-\t\t\t\t\t<p>\n-\t\t\t\t\t\t{ this.translate(\n-\t\t\t\t\t\t\t\"We'll periodically check your site from our global network of servers to make sure it's online, and email you if it looks like your site is not responding for any reason.\"\n-\t\t\t\t\t\t) }\n-\t\t\t\t\t</p>\n-\t\t\t\t</div>\n+\tsaveSettings = () => {\n+\t\tconst { siteId } = this.props;\n \n-\t\t\t</div>\n-\t\t);\n-\t},\n+\t\tthis.props.updateSiteMonitorSettings( siteId, this.state );\n+\t}\n \n-\tsaveSettings: function() {\n-\t\tthis.setState( { submitingForm: true } );\n-\t\tnotices.clearNotices( 'notices' );\n-\t\tthis.props.site.updateMonitorSettings( this.state.emailNotifications, this.state.wpNoteNotifications, ( function( error ) {\n-\t\t\tif ( error ) {\n-\t\t\t\tthis.handleError();\n-\t\t\t\tnotices.error( this.translate( 'There was a problem saving your changes. Please, try again.' ) );\n-\t\t\t\treturn;\n-\t\t\t}\n-\t\t\tnotices.success( this.translate( 'Settings saved successfully!' ) );\n-\t\t\tthis.props.markSaved();\n-\t\t\tthis.setState( { submittingForm: false } );\n-\t\t} ).bind( this ) );\n-\t},\n+\tsettingsMonitorEmailCheckbox() {\n+\t\tconst { monitorActive, translate } = this.props;\n \n-\tsettings: function() {\n \t\treturn (\n-\t\t\t<div>\n-\t\t\t\t<p>{ this.translate( \"Jetpack is currently monitoring your site's uptime.\" ) }</p>\n-\t\t\t\t{ this.settingsMonitorEmailCheckbox() }\n-\t\t\t\t{ config.isEnabled( 'settings/security/monitor/wp-note' ) ? this.settingsMonitorWpNoteCheckbox() : '' }\n-\t\t\t</div>\n+\t\t\t<CompactFormToggle\n+\t\t\t\tdisabled={ this.disableForm() || ! monitorActive }\n+\t\t\t\tonChange={ this.handleToggle( 'email_notifications' ) }\n+\t\t\t\tchecked={ !! this.state.email_notifications }\n+\t\t\t>\n+\t\t\t\t{ translate( 'Send notifications to your {{a}}WordPress.com email address{{/a}}', {","path":"client/my-sites/site-settings/form-jetpack-monitor.jsx","position":159,"original_position":159,"commit_id":"d55005f4fe8802a8d1de2c131a5d8764a1faa3e6","original_commit_id":"d55005f4fe8802a8d1de2c131a5d8764a1faa3e6","user":{"login":"tyxla","id":8436925,"avatar_url":"https://avatars1.githubusercontent.com/u/8436925?v=3","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false},"body":"@yoavf maybe it makes sense to update this one if it's not used anywhere else?","created_at":"2017-04-21T12:59:41Z","updated_at":"2017-04-21T12:59:41Z","html_url":"https://github.com/Automattic/wp-calypso/pull/13281#discussion_r112681455","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13281","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/112681455"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/13281#discussion_r112681455"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13281"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13281","id":116806210,"html_url":"https://github.com/Automattic/wp-calypso/pull/13281","diff_url":"https://github.com/Automattic/wp-calypso/pull/13281.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/13281.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/13281","number":13281,"state":"open","locked":false,"title":"Site Settings: Reduxify Monitor card and cleanup","user":{"login":"tyxla","id":8436925,"avatar_url":"https://avatars1.githubusercontent.com/u/8436925?v=3","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false},"body":"This PR creates a new Monitor card under Security site settings. The old card was not consistent with the new settings design, and was behaving oddly and inconsistently.\r\n\r\nThe new version looks and functions much alike the rest of the settings cards:\r\n\r\n\r\nThe new card uses Redux, which also allows us to clean up a bunch of legacy code. This PR suggests:\r\n\r\n* Updated the card code, ES6ified and altered to use Redux.\r\n* Changed the settings fields to toggles instead of checkboxes.\r\n* Removed the Save Changes button and made the toggles save immediately.\r\n* Replaced the activate/deactivate buttons with a module toggle.\r\n* Updated the layout of the settings to fit the other cards.\r\n* Converted notices to use Redux.\r\n* Deleted and cleaned up:\r\n * Unused methods from `JetpackSite`\r\n * Unused `form-base` helper\r\n * Obsolete `dirty-linked-state` mixin\r\n * Obsolete site-settings README portion\r\n\r\nI'm open to move anything to a separate PR, please let me know if that's necessary.\r\n\r\nTo test:\r\n* Checkout this branch\r\n* Go to `/settings/security/$site`, where `$site` is a Jetpack site.\r\n* Play with the new monitor card - the main toggle and the settings.\r\n* Verify all works as expected.\r\n* Verify I'm not deleting anything that's still used :laughing: ","created_at":"2017-04-20T15:56:28Z","updated_at":"2017-04-21T12:59:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5e4736ee77b79e0d9f41f8bca7ac901e749bad2","assignee":{"login":"tyxla","id":8436925,"avatar_url":"https://avatars1.githubusercontent.com/u/8436925?v=3","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false},"assignees":[{"login":"tyxla","id":8436925,"avatar_url":"https://avatars1.githubusercontent.com/u/8436925?v=3","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13281/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13281/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/13281/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/d55005f4fe8802a8d1de2c131a5d8764a1faa3e6","head":{"label":"Automattic:update/reduxify-security-monitor-card","ref":"update/reduxify-security-monitor-card","sha":"d55005f4fe8802a8d1de2c131a5d8764a1faa3e6","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars2.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars2.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-04-21T05:48:26Z","pushed_at":"2017-04-21T12:55:29Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"[email protected]:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":59725,"stargazers_count":8673,"watchers_count":8673,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1118,"mirror_url":null,"open_issues_count":1884,"forks":1118,"open_issues":1884,"watchers":8673,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"98e54e3375e1b1b5e4d92a2256818aab63ad48de","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars2.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars2.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-04-21T05:48:26Z","pushed_at":"2017-04-21T12:55:29Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"[email protected]:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":59725,"stargazers_count":8673,"watchers_count":8673,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1118,"mirror_url":null,"open_issues_count":1884,"forks":1118,"open_issues":1884,"watchers":8673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13281"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/13281"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/13281"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/13281/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13281/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13281/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/d55005f4fe8802a8d1de2c131a5d8764a1faa3e6"}}}} | {
"id": 45936895,
"name": "Automattic/wp-calypso",
"url": "https://api.github.com/repos/Automattic/wp-calypso"
} | {
"id": 8436925,
"login": "tyxla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8436925?",
"url": "https://api.github.com/users/tyxla"
} | {
"id": 887802,
"login": "Automattic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/887802?",
"url": "https://api.github.com/orgs/Automattic"
} | 2017-04-21T12:59:41 | 5731642475 | {"actor":{"display_login":"tyxla"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/138956506","pull_request_review_id":62823143,"id":138956506,"diff_hunk":"@@ -126,81 +119,83 @@ var Posts = React.createClass( {\n \t\t\treturn true;\n \t\t}\n \t\treturn false;\n-\t},\n+\t}\n \n-\tafterResize: function() {\n-\t\tvar arePostsAtFullWidth = window.innerWidth >= 960;\n+\tafterResize = () => {\n+\t\tconst arePostsAtFullWidth = window.innerWidth >= 960;\n \n \t\tif ( this.state.postsAtFullWidth !== arePostsAtFullWidth ) {\n \t\t\tthis.setState( {\n \t\t\t\tpostsAtFullWidth: arePostsAtFullWidth\n \t\t\t} );\n \t\t}\n-\t},\n+\t};\n \n-\tfetchPosts: function( options ) {\n+\tfetchPosts = options => {\n \t\tif ( this.props.loading || this.props.lastPage || this.props.hasRecentError ) {\n \t\t\treturn;\n \t\t}\n \t\tif ( options.triggeredByScroll ) {\n \t\t\tthis.props.trackScrollPage( this.props.page + 1 );\n \t\t}\n \t\tactions.fetchNextPage();\n-\t},\n+\t};\n \n-\tgetNoContentMessage: function() {\n-\t\tvar attributes, newPostLink;\n+\tgetNoContentMessage = () => {","path":"client/my-sites/posts/post-list.jsx","position":205,"original_position":205,"commit_id":"b42ed91395d404a742ad22cc5b4853f2367f6b9e","original_commit_id":"34504a3c43ebd659b729a9851e06eaa30c5f1769","user":{"login":"ockham","id":96308,"avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"body":"I'll do some more, e.g. `siteId`.","created_at":"2017-09-14T17:16:43Z","updated_at":"2017-09-14T17:16:44Z","html_url":"https://github.com/Automattic/wp-calypso/pull/18036#discussion_r138956506","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18036","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/138956506"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/18036#discussion_r138956506"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18036"}},"in_reply_to_id":138937728},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18036","id":140984534,"html_url":"https://github.com/Automattic/wp-calypso/pull/18036","diff_url":"https://github.com/Automattic/wp-calypso/pull/18036.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/18036.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/18036","number":18036,"state":"open","locked":false,"title":"PostList: Run Codemods","user":{"login":"ockham","id":96308,"avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"body":"Preparatory work for reduxification. To test: Verify `/posts` still works as before (single-page and multi-page mode, queries, etc).","created_at":"2017-09-14T05:15:25Z","updated_at":"2017-09-14T17:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"021aa656c14b6c40b02cf7eff1f6c47d50b73f5e","assignee":{"login":"markryall","id":1926,"avatar_url":"https://avatars3.githubusercontent.com/u/1926?v=4","gravatar_id":"","url":"https://api.github.com/users/markryall","html_url":"https://github.com/markryall","followers_url":"https://api.github.com/users/markryall/followers","following_url":"https://api.github.com/users/markryall/following{/other_user}","gists_url":"https://api.github.com/users/markryall/gists{/gist_id}","starred_url":"https://api.github.com/users/markryall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markryall/subscriptions","organizations_url":"https://api.github.com/users/markryall/orgs","repos_url":"https://api.github.com/users/markryall/repos","events_url":"https://api.github.com/users/markryall/events{/privacy}","received_events_url":"https://api.github.com/users/markryall/received_events","type":"User","site_admin":false},"assignees":[{"login":"markryall","id":1926,"avatar_url":"https://avatars3.githubusercontent.com/u/1926?v=4","gravatar_id":"","url":"https://api.github.com/users/markryall","html_url":"https://github.com/markryall","followers_url":"https://api.github.com/users/markryall/followers","following_url":"https://api.github.com/users/markryall/following{/other_user}","gists_url":"https://api.github.com/users/markryall/gists{/gist_id}","starred_url":"https://api.github.com/users/markryall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markryall/subscriptions","organizations_url":"https://api.github.com/users/markryall/orgs","repos_url":"https://api.github.com/users/markryall/repos","events_url":"https://api.github.com/users/markryall/events{/privacy}","received_events_url":"https://api.github.com/users/markryall/received_events","type":"User","site_admin":false},{"login":"ockham","id":96308,"avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"blowery","id":14350,"avatar_url":"https://avatars1.githubusercontent.com/u/14350?v=4","gravatar_id":"","url":"https://api.github.com/users/blowery","html_url":"https://github.com/blowery","followers_url":"https://api.github.com/users/blowery/followers","following_url":"https://api.github.com/users/blowery/following{/other_user}","gists_url":"https://api.github.com/users/blowery/gists{/gist_id}","starred_url":"https://api.github.com/users/blowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowery/subscriptions","organizations_url":"https://api.github.com/users/blowery/orgs","repos_url":"https://api.github.com/users/blowery/repos","events_url":"https://api.github.com/users/blowery/events{/privacy}","received_events_url":"https://api.github.com/users/blowery/received_events","type":"User","site_admin":false},{"login":"mcsf","id":150562,"avatar_url":"https://avatars0.githubusercontent.com/u/150562?v=4","gravatar_id":"","url":"https://api.github.com/users/mcsf","html_url":"https://github.com/mcsf","followers_url":"https://api.github.com/users/mcsf/followers","following_url":"https://api.github.com/users/mcsf/following{/other_user}","gists_url":"https://api.github.com/users/mcsf/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsf/subscriptions","organizations_url":"https://api.github.com/users/mcsf/orgs","repos_url":"https://api.github.com/users/mcsf/repos","events_url":"https://api.github.com/users/mcsf/events{/privacy}","received_events_url":"https://api.github.com/users/mcsf/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18036/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18036/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/18036/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/b42ed91395d404a742ad22cc5b4853f2367f6b9e","head":{"label":"Automattic:codemod/post-list","ref":"codemod/post-list","sha":"b42ed91395d404a742ad22cc5b4853f2367f6b9e","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-09-14T12:00:57Z","pushed_at":"2017-09-14T17:14:56Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"[email protected]:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":73690,"stargazers_count":9088,"watchers_count":9088,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1228,"mirror_url":null,"open_issues_count":2289,"forks":1228,"open_issues":2289,"watchers":9088,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"0995e27badd1e02304743eecb885fa280e192ec9","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-09-14T12:00:57Z","pushed_at":"2017-09-14T17:14:56Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"[email protected]:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":73690,"stargazers_count":9088,"watchers_count":9088,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1228,"mirror_url":null,"open_issues_count":2289,"forks":1228,"open_issues":2289,"watchers":9088,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18036"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/18036"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/18036"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/18036/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18036/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18036/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/b42ed91395d404a742ad22cc5b4853f2367f6b9e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 45936895,
"name": "Automattic/wp-calypso",
"url": "https://api.github.com/repos/Automattic/wp-calypso"
} | {
"id": 96308,
"login": "ockham",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/96308?",
"url": "https://api.github.com/users/ockham"
} | {
"id": 887802,
"login": "Automattic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/887802?",
"url": "https://api.github.com/orgs/Automattic"
} | 2017-09-14T17:16:43 | 6591777079 | {"actor":{"display_login":"ockham"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments/96097975","pull_request_review_id":16676854,"id":96097975,"diff_hunk":"@@ -44,7 +44,10 @@ private void HandleBookSettings(ApiRequest request)\n \t\t\t\t\tsettings = DynamicJson.Parse(request.RequiredPostJson());\n \t\t\t\t\t_bookSelection.CurrentSelection.TemporarilyUnlocked = settings[\"unlockShellBook\"];\n \t\t\t\t\t_pageRefreshEvent.Raise(PageRefreshEvent.SaveBehavior.SaveBeforeRefresh);\n-\t\t\t\t\tUpdateBookTemplateMode(settings.isTemplateBook);\n+\t\t\t\t\tif(((DynamicJson)settings).IsDefined(\"isTemplateBook\"))","path":"src/BloomExe/web/controllers/BookSettingsApi.cs","position":5,"original_position":5,"commit_id":"100224d00139d2f703ec9d7ace6ba08e86cc2206","original_commit_id":"100224d00139d2f703ec9d7ace6ba08e86cc2206","user":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"body":"When I commented out this feature for 3.8 in the UI, this property became unavailable","created_at":"2017-01-14T00:06:31Z","updated_at":"2017-01-14T00:06:31Z","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1403#discussion_r96097975","pull_request_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1403","_links":{"self":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments/96097975"},"html":{"href":"https://github.com/BloomBooks/BloomDesktop/pull/1403#discussion_r96097975"},"pull_request":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1403"}}},"pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1403","id":101538550,"html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1403","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/1403.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/1403.patch","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1403","number":1403,"state":"open","locked":false,"title":"Fix \"allow changes to this shellbook\" BL-3621","user":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/bloombooks/bloomdesktop/1403)\n<!-- Reviewable:end -->\n","created_at":"2017-01-14T00:04:54Z","updated_at":"2017-01-14T00:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af1be7f57566caca4318a628a55b31d6fe36a4df","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1403/commits","review_comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1403/comments","review_comment_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1403/comments","statuses_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/100224d00139d2f703ec9d7ace6ba08e86cc2206","head":{"label":"hatton:BL-3621FixAllowChanges","ref":"BL-3621FixAllowChanges","sha":"100224d00139d2f703ec9d7ace6ba08e86cc2206","user":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"repo":{"id":33460049,"name":"BloomDesktop","full_name":"hatton/BloomDesktop","owner":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hatton/BloomDesktop","description":"Bloom Desktop is a hybrid c#/javascript/html/css Windows application that dramatically \"lowers the bar\" for language communities who want books in their own languages. Bloom delivers a low-training, high-output system where mother tongue speakers and their advocates work together to foster both community authorship and access to external material in the vernacular.","fork":true,"url":"https://api.github.com/repos/hatton/BloomDesktop","forks_url":"https://api.github.com/repos/hatton/BloomDesktop/forks","keys_url":"https://api.github.com/repos/hatton/BloomDesktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatton/BloomDesktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatton/BloomDesktop/teams","hooks_url":"https://api.github.com/repos/hatton/BloomDesktop/hooks","issue_events_url":"https://api.github.com/repos/hatton/BloomDesktop/issues/events{/number}","events_url":"https://api.github.com/repos/hatton/BloomDesktop/events","assignees_url":"https://api.github.com/repos/hatton/BloomDesktop/assignees{/user}","branches_url":"https://api.github.com/repos/hatton/BloomDesktop/branches{/branch}","tags_url":"https://api.github.com/repos/hatton/BloomDesktop/tags","blobs_url":"https://api.github.com/repos/hatton/BloomDesktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatton/BloomDesktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatton/BloomDesktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatton/BloomDesktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatton/BloomDesktop/statuses/{sha}","languages_url":"https://api.github.com/repos/hatton/BloomDesktop/languages","stargazers_url":"https://api.github.com/repos/hatton/BloomDesktop/stargazers","contributors_url":"https://api.github.com/repos/hatton/BloomDesktop/contributors","subscribers_url":"https://api.github.com/repos/hatton/BloomDesktop/subscribers","subscription_url":"https://api.github.com/repos/hatton/BloomDesktop/subscription","commits_url":"https://api.github.com/repos/hatton/BloomDesktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatton/BloomDesktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatton/BloomDesktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatton/BloomDesktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/hatton/BloomDesktop/contents/{+path}","compare_url":"https://api.github.com/repos/hatton/BloomDesktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatton/BloomDesktop/merges","archive_url":"https://api.github.com/repos/hatton/BloomDesktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatton/BloomDesktop/downloads","issues_url":"https://api.github.com/repos/hatton/BloomDesktop/issues{/number}","pulls_url":"https://api.github.com/repos/hatton/BloomDesktop/pulls{/number}","milestones_url":"https://api.github.com/repos/hatton/BloomDesktop/milestones{/number}","notifications_url":"https://api.github.com/repos/hatton/BloomDesktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatton/BloomDesktop/labels{/name}","releases_url":"https://api.github.com/repos/hatton/BloomDesktop/releases{/id}","deployments_url":"https://api.github.com/repos/hatton/BloomDesktop/deployments","created_at":"2015-04-06T00:29:28Z","updated_at":"2016-01-12T22:49:53Z","pushed_at":"2017-01-14T00:04:36Z","git_url":"git://github.com/hatton/BloomDesktop.git","ssh_url":"[email protected]:hatton/BloomDesktop.git","clone_url":"https://github.com/hatton/BloomDesktop.git","svn_url":"https://github.com/hatton/BloomDesktop","homepage":"http://bloomlibrary.org/","size":89660,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BloomBooks:Version3.8","ref":"Version3.8","sha":"25e5354859f6f4ba527ef56f773d96a4e715fd4e","user":{"login":"BloomBooks","id":5853716,"avatar_url":"https://avatars.githubusercontent.com/u/5853716?v=3","gravatar_id":"","url":"https://api.github.com/users/BloomBooks","html_url":"https://github.com/BloomBooks","followers_url":"https://api.github.com/users/BloomBooks/followers","following_url":"https://api.github.com/users/BloomBooks/following{/other_user}","gists_url":"https://api.github.com/users/BloomBooks/gists{/gist_id}","starred_url":"https://api.github.com/users/BloomBooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BloomBooks/subscriptions","organizations_url":"https://api.github.com/users/BloomBooks/orgs","repos_url":"https://api.github.com/users/BloomBooks/repos","events_url":"https://api.github.com/users/BloomBooks/events{/privacy}","received_events_url":"https://api.github.com/users/BloomBooks/received_events","type":"Organization","site_admin":false},"repo":{"id":14133680,"name":"BloomDesktop","full_name":"BloomBooks/BloomDesktop","owner":{"login":"BloomBooks","id":5853716,"avatar_url":"https://avatars.githubusercontent.com/u/5853716?v=3","gravatar_id":"","url":"https://api.github.com/users/BloomBooks","html_url":"https://github.com/BloomBooks","followers_url":"https://api.github.com/users/BloomBooks/followers","following_url":"https://api.github.com/users/BloomBooks/following{/other_user}","gists_url":"https://api.github.com/users/BloomBooks/gists{/gist_id}","starred_url":"https://api.github.com/users/BloomBooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BloomBooks/subscriptions","organizations_url":"https://api.github.com/users/BloomBooks/orgs","repos_url":"https://api.github.com/users/BloomBooks/repos","events_url":"https://api.github.com/users/BloomBooks/events{/privacy}","received_events_url":"https://api.github.com/users/BloomBooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BloomBooks/BloomDesktop","description":"Let's Grow a Library","fork":false,"url":"https://api.github.com/repos/BloomBooks/BloomDesktop","forks_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/forks","keys_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/teams","hooks_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/hooks","issue_events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/events{/number}","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/events","assignees_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/assignees{/user}","branches_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/branches{/branch}","tags_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/tags","blobs_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/{sha}","languages_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/languages","stargazers_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/stargazers","contributors_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/contributors","subscribers_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/subscribers","subscription_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/subscription","commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/contents/{+path}","compare_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/merges","archive_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/downloads","issues_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues{/number}","pulls_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls{/number}","milestones_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/milestones{/number}","notifications_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/labels{/name}","releases_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/releases{/id}","deployments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/deployments","created_at":"2013-11-05T06:12:57Z","updated_at":"2016-12-20T16:35:32Z","pushed_at":"2017-01-14T00:05:00Z","git_url":"git://github.com/BloomBooks/BloomDesktop.git","ssh_url":"[email protected]:BloomBooks/BloomDesktop.git","clone_url":"https://github.com/BloomBooks/BloomDesktop.git","svn_url":"https://github.com/BloomBooks/BloomDesktop","homepage":"http://bloomlibrary.org/","size":97290,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1403"},"html":{"href":"https://github.com/BloomBooks/BloomDesktop/pull/1403"},"issue":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1403"},"comments":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1403/comments"},"review_comments":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1403/comments"},"review_comment":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1403/commits"},"statuses":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/100224d00139d2f703ec9d7ace6ba08e86cc2206"}}}} | {
"id": 14133680,
"name": "BloomBooks/BloomDesktop",
"url": "https://api.github.com/repos/BloomBooks/BloomDesktop"
} | {
"id": 8448,
"login": "hatton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8448?",
"url": "https://api.github.com/users/hatton"
} | {
"id": 5853716,
"login": "BloomBooks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5853716?",
"url": "https://api.github.com/orgs/BloomBooks"
} | 2017-01-14T00:06:31 | 5152207587 | {"actor":{"display_login":"hatton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Commonjava/indy/pulls/comments/114186152","pull_request_review_id":35625236,"id":114186152,"diff_hunk":"@@ -0,0 +1,176 @@\n+package org.commonjava.indy.metrics.zabbix.sender;\n+\n+import com.fasterxml.jackson.databind.JsonNode;\n+import com.fasterxml.jackson.databind.ObjectMapper;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.io.OutputStream;\n+import java.net.InetSocketAddress;\n+import java.net.Socket;\n+import java.nio.charset.Charset;\n+import java.util.Collections;\n+import java.util.List;\n+import java.util.regex.Pattern;\n+\n+/**\n+ * Created by xiabai on 4/7/17.\n+ * Copy from\n+ */\n+public class ZabbixSender\n+{\n+ private static final Pattern PATTERN = Pattern.compile( \"[^0-9\\\\.]+\");\n+ private static final Logger logger = LoggerFactory.getLogger( ZabbixSender.class );\n+ String host;\n+ int port;\n+ int connectTimeout = 3 * 1000;\n+ int socketTimeout = 3 * 1000;\n+\n+ public ZabbixSender(String host, int port) {\n+ this.host = host;\n+ this.port = port;\n+ }\n+\n+ public ZabbixSender(String host, int port, int connectTimeout, int socketTimeout) {\n+ this(host, port);\n+ this.connectTimeout = connectTimeout;\n+ this.socketTimeout = socketTimeout;\n+ }\n+\n+ public SenderResult send(DataObject dataObject) throws IOException\n+ {\n+ return send(dataObject, System.currentTimeMillis() / 1000);\n+ }\n+\n+ /**\n+ *\n+ * @param dataObject\n+ * @param clock\n+ * TimeUnit is SECONDS.\n+ * @return\n+ * @throws IOException\n+ */\n+ public SenderResult send(DataObject dataObject, long clock) throws IOException {\n+ return send( Collections.singletonList( dataObject), clock);\n+ }\n+\n+ public SenderResult send(List<DataObject> dataObjectList) throws IOException {\n+ return send(dataObjectList, System.currentTimeMillis() / 1000);\n+ }\n+\n+ /**\n+ *\n+ * @param dataObjectList\n+ * @param clock\n+ * TimeUnit is SECONDS.\n+ * @return\n+ * @throws IOException\n+ */\n+ public SenderResult send(List<DataObject> dataObjectList, long clock) throws IOException {","path":"subsys/metrics/src/main/java/org/commonjava/indy/metrics/zabbix/sender/ZabbixSender.java","position":71,"original_position":71,"commit_id":"19f29768677869ceffdd1b661994d3d0863f6146","original_commit_id":"19f29768677869ceffdd1b661994d3d0863f6146","user":{"login":"jdcasey","id":65614,"avatar_url":"https://avatars0.githubusercontent.com/u/65614?v=3","gravatar_id":"","url":"https://api.github.com/users/jdcasey","html_url":"https://github.com/jdcasey","followers_url":"https://api.github.com/users/jdcasey/followers","following_url":"https://api.github.com/users/jdcasey/following{/other_user}","gists_url":"https://api.github.com/users/jdcasey/gists{/gist_id}","starred_url":"https://api.github.com/users/jdcasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdcasey/subscriptions","organizations_url":"https://api.github.com/users/jdcasey/orgs","repos_url":"https://api.github.com/users/jdcasey/repos","events_url":"https://api.github.com/users/jdcasey/events{/privacy}","received_events_url":"https://api.github.com/users/jdcasey/received_events","type":"User","site_admin":false},"body":"Depending on how many concurrent requests we need to make to the Zabbix server, we might need to port this Socket implementation over to XNIO, which is a much higher-performing library doing non-blocking socket I/O. I don't think we need to do it for now, but we should put in a //TODO for this method to explore XNIO.","created_at":"2017-05-01T19:43:45Z","updated_at":"2017-05-01T19:56:45Z","html_url":"https://github.com/Commonjava/indy/pull/661#discussion_r114186152","pull_request_url":"https://api.github.com/repos/Commonjava/indy/pulls/661","_links":{"self":{"href":"https://api.github.com/repos/Commonjava/indy/pulls/comments/114186152"},"html":{"href":"https://github.com/Commonjava/indy/pull/661#discussion_r114186152"},"pull_request":{"href":"https://api.github.com/repos/Commonjava/indy/pulls/661"}}},"pull_request":{"url":"https://api.github.com/repos/Commonjava/indy/pulls/661","id":118298704,"html_url":"https://github.com/Commonjava/indy/pull/661","diff_url":"https://github.com/Commonjava/indy/pull/661.diff","patch_url":"https://github.com/Commonjava/indy/pull/661.patch","issue_url":"https://api.github.com/repos/Commonjava/indy/issues/661","number":661,"state":"open","locked":false,"title":"refactor Zabbix API and Zabbix sender using jackson and fix some bug.…","user":{"login":"bxf12315","id":209745,"avatar_url":"https://avatars2.githubusercontent.com/u/209745?v=3","gravatar_id":"","url":"https://api.github.com/users/bxf12315","html_url":"https://github.com/bxf12315","followers_url":"https://api.github.com/users/bxf12315/followers","following_url":"https://api.github.com/users/bxf12315/following{/other_user}","gists_url":"https://api.github.com/users/bxf12315/gists{/gist_id}","starred_url":"https://api.github.com/users/bxf12315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bxf12315/subscriptions","organizations_url":"https://api.github.com/users/bxf12315/orgs","repos_url":"https://api.github.com/users/bxf12315/repos","events_url":"https://api.github.com/users/bxf12315/events{/privacy}","received_events_url":"https://api.github.com/users/bxf12315/received_events","type":"User","site_admin":false},"body":"… 1 can not create text type item of zabbix 2 can not create host","created_at":"2017-04-30T03:09:02Z","updated_at":"2017-05-01T19:56:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d193dfa5a706903004ae97b07f7d78a68c93f58","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Commonjava/indy/pulls/661/commits","review_comments_url":"https://api.github.com/repos/Commonjava/indy/pulls/661/comments","review_comment_url":"https://api.github.com/repos/Commonjava/indy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Commonjava/indy/issues/661/comments","statuses_url":"https://api.github.com/repos/Commonjava/indy/statuses/19f29768677869ceffdd1b661994d3d0863f6146","head":{"label":"bxf12315:refacing-with-jackson","ref":"refacing-with-jackson","sha":"19f29768677869ceffdd1b661994d3d0863f6146","user":{"login":"bxf12315","id":209745,"avatar_url":"https://avatars2.githubusercontent.com/u/209745?v=3","gravatar_id":"","url":"https://api.github.com/users/bxf12315","html_url":"https://github.com/bxf12315","followers_url":"https://api.github.com/users/bxf12315/followers","following_url":"https://api.github.com/users/bxf12315/following{/other_user}","gists_url":"https://api.github.com/users/bxf12315/gists{/gist_id}","starred_url":"https://api.github.com/users/bxf12315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bxf12315/subscriptions","organizations_url":"https://api.github.com/users/bxf12315/orgs","repos_url":"https://api.github.com/users/bxf12315/repos","events_url":"https://api.github.com/users/bxf12315/events{/privacy}","received_events_url":"https://api.github.com/users/bxf12315/received_events","type":"User","site_admin":false},"repo":{"id":82521437,"name":"indy","full_name":"bxf12315/indy","owner":{"login":"bxf12315","id":209745,"avatar_url":"https://avatars2.githubusercontent.com/u/209745?v=3","gravatar_id":"","url":"https://api.github.com/users/bxf12315","html_url":"https://github.com/bxf12315","followers_url":"https://api.github.com/users/bxf12315/followers","following_url":"https://api.github.com/users/bxf12315/following{/other_user}","gists_url":"https://api.github.com/users/bxf12315/gists{/gist_id}","starred_url":"https://api.github.com/users/bxf12315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bxf12315/subscriptions","organizations_url":"https://api.github.com/users/bxf12315/orgs","repos_url":"https://api.github.com/users/bxf12315/repos","events_url":"https://api.github.com/users/bxf12315/events{/privacy}","received_events_url":"https://api.github.com/users/bxf12315/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bxf12315/indy","description":"Simple artifact proxy for maven and similar build tools","fork":true,"url":"https://api.github.com/repos/bxf12315/indy","forks_url":"https://api.github.com/repos/bxf12315/indy/forks","keys_url":"https://api.github.com/repos/bxf12315/indy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bxf12315/indy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bxf12315/indy/teams","hooks_url":"https://api.github.com/repos/bxf12315/indy/hooks","issue_events_url":"https://api.github.com/repos/bxf12315/indy/issues/events{/number}","events_url":"https://api.github.com/repos/bxf12315/indy/events","assignees_url":"https://api.github.com/repos/bxf12315/indy/assignees{/user}","branches_url":"https://api.github.com/repos/bxf12315/indy/branches{/branch}","tags_url":"https://api.github.com/repos/bxf12315/indy/tags","blobs_url":"https://api.github.com/repos/bxf12315/indy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bxf12315/indy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bxf12315/indy/git/refs{/sha}","trees_url":"https://api.github.com/repos/bxf12315/indy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bxf12315/indy/statuses/{sha}","languages_url":"https://api.github.com/repos/bxf12315/indy/languages","stargazers_url":"https://api.github.com/repos/bxf12315/indy/stargazers","contributors_url":"https://api.github.com/repos/bxf12315/indy/contributors","subscribers_url":"https://api.github.com/repos/bxf12315/indy/subscribers","subscription_url":"https://api.github.com/repos/bxf12315/indy/subscription","commits_url":"https://api.github.com/repos/bxf12315/indy/commits{/sha}","git_commits_url":"https://api.github.com/repos/bxf12315/indy/git/commits{/sha}","comments_url":"https://api.github.com/repos/bxf12315/indy/comments{/number}","issue_comment_url":"https://api.github.com/repos/bxf12315/indy/issues/comments{/number}","contents_url":"https://api.github.com/repos/bxf12315/indy/contents/{+path}","compare_url":"https://api.github.com/repos/bxf12315/indy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bxf12315/indy/merges","archive_url":"https://api.github.com/repos/bxf12315/indy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bxf12315/indy/downloads","issues_url":"https://api.github.com/repos/bxf12315/indy/issues{/number}","pulls_url":"https://api.github.com/repos/bxf12315/indy/pulls{/number}","milestones_url":"https://api.github.com/repos/bxf12315/indy/milestones{/number}","notifications_url":"https://api.github.com/repos/bxf12315/indy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bxf12315/indy/labels{/name}","releases_url":"https://api.github.com/repos/bxf12315/indy/releases{/id}","deployments_url":"https://api.github.com/repos/bxf12315/indy/deployments","created_at":"2017-02-20T05:47:31Z","updated_at":"2017-02-20T05:47:35Z","pushed_at":"2017-04-30T07:39:34Z","git_url":"git://github.com/bxf12315/indy.git","ssh_url":"[email protected]:bxf12315/indy.git","clone_url":"https://github.com/bxf12315/indy.git","svn_url":"https://github.com/bxf12315/indy","homepage":"","size":19772,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Commonjava:master","ref":"master","sha":"fbec67fe05b1f179697a2cb1696058dc204f7da9","user":{"login":"Commonjava","id":12036517,"avatar_url":"https://avatars1.githubusercontent.com/u/12036517?v=3","gravatar_id":"","url":"https://api.github.com/users/Commonjava","html_url":"https://github.com/Commonjava","followers_url":"https://api.github.com/users/Commonjava/followers","following_url":"https://api.github.com/users/Commonjava/following{/other_user}","gists_url":"https://api.github.com/users/Commonjava/gists{/gist_id}","starred_url":"https://api.github.com/users/Commonjava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Commonjava/subscriptions","organizations_url":"https://api.github.com/users/Commonjava/orgs","repos_url":"https://api.github.com/users/Commonjava/repos","events_url":"https://api.github.com/users/Commonjava/events{/privacy}","received_events_url":"https://api.github.com/users/Commonjava/received_events","type":"Organization","site_admin":false},"repo":{"id":2431562,"name":"indy","full_name":"Commonjava/indy","owner":{"login":"Commonjava","id":12036517,"avatar_url":"https://avatars1.githubusercontent.com/u/12036517?v=3","gravatar_id":"","url":"https://api.github.com/users/Commonjava","html_url":"https://github.com/Commonjava","followers_url":"https://api.github.com/users/Commonjava/followers","following_url":"https://api.github.com/users/Commonjava/following{/other_user}","gists_url":"https://api.github.com/users/Commonjava/gists{/gist_id}","starred_url":"https://api.github.com/users/Commonjava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Commonjava/subscriptions","organizations_url":"https://api.github.com/users/Commonjava/orgs","repos_url":"https://api.github.com/users/Commonjava/repos","events_url":"https://api.github.com/users/Commonjava/events{/privacy}","received_events_url":"https://api.github.com/users/Commonjava/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Commonjava/indy","description":"Simple artifact proxy for maven and similar build tools","fork":false,"url":"https://api.github.com/repos/Commonjava/indy","forks_url":"https://api.github.com/repos/Commonjava/indy/forks","keys_url":"https://api.github.com/repos/Commonjava/indy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Commonjava/indy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Commonjava/indy/teams","hooks_url":"https://api.github.com/repos/Commonjava/indy/hooks","issue_events_url":"https://api.github.com/repos/Commonjava/indy/issues/events{/number}","events_url":"https://api.github.com/repos/Commonjava/indy/events","assignees_url":"https://api.github.com/repos/Commonjava/indy/assignees{/user}","branches_url":"https://api.github.com/repos/Commonjava/indy/branches{/branch}","tags_url":"https://api.github.com/repos/Commonjava/indy/tags","blobs_url":"https://api.github.com/repos/Commonjava/indy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Commonjava/indy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Commonjava/indy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Commonjava/indy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Commonjava/indy/statuses/{sha}","languages_url":"https://api.github.com/repos/Commonjava/indy/languages","stargazers_url":"https://api.github.com/repos/Commonjava/indy/stargazers","contributors_url":"https://api.github.com/repos/Commonjava/indy/contributors","subscribers_url":"https://api.github.com/repos/Commonjava/indy/subscribers","subscription_url":"https://api.github.com/repos/Commonjava/indy/subscription","commits_url":"https://api.github.com/repos/Commonjava/indy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Commonjava/indy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Commonjava/indy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Commonjava/indy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Commonjava/indy/contents/{+path}","compare_url":"https://api.github.com/repos/Commonjava/indy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Commonjava/indy/merges","archive_url":"https://api.github.com/repos/Commonjava/indy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Commonjava/indy/downloads","issues_url":"https://api.github.com/repos/Commonjava/indy/issues{/number}","pulls_url":"https://api.github.com/repos/Commonjava/indy/pulls{/number}","milestones_url":"https://api.github.com/repos/Commonjava/indy/milestones{/number}","notifications_url":"https://api.github.com/repos/Commonjava/indy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Commonjava/indy/labels{/name}","releases_url":"https://api.github.com/repos/Commonjava/indy/releases{/id}","deployments_url":"https://api.github.com/repos/Commonjava/indy/deployments","created_at":"2011-09-21T17:55:24Z","updated_at":"2017-04-26T02:39:37Z","pushed_at":"2017-04-30T07:39:35Z","git_url":"git://github.com/Commonjava/indy.git","ssh_url":"[email protected]:Commonjava/indy.git","clone_url":"https://github.com/Commonjava/indy.git","svn_url":"https://github.com/Commonjava/indy","homepage":"","size":19913,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":17,"forks":16,"open_issues":17,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Commonjava/indy/pulls/661"},"html":{"href":"https://github.com/Commonjava/indy/pull/661"},"issue":{"href":"https://api.github.com/repos/Commonjava/indy/issues/661"},"comments":{"href":"https://api.github.com/repos/Commonjava/indy/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/Commonjava/indy/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/Commonjava/indy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Commonjava/indy/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/Commonjava/indy/statuses/19f29768677869ceffdd1b661994d3d0863f6146"}}}} | {
"id": 2431562,
"name": "Commonjava/indy",
"url": "https://api.github.com/repos/Commonjava/indy"
} | {
"id": 65614,
"login": "jdcasey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/65614?",
"url": "https://api.github.com/users/jdcasey"
} | {
"id": 12036517,
"login": "Commonjava",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12036517?",
"url": "https://api.github.com/orgs/Commonjava"
} | 2017-05-01T19:43:45 | 5789004119 | {"actor":{"display_login":"jdcasey"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments/129542773","pull_request_review_id":52298815,"id":129542773,"diff_hunk":"@@ -50,35 +77,335 @@ treeListCore.registerModule(\"selection\", extend(true, {}, selectionModule, {\n keys.push(node.key);\n }\n \n- return component.isRowExpanded(node.key);\n+ return onlyRootChildren ? false : component.isRowExpanded(node.key);\n });\n \n return keys;\n },\n \n isSelectAll: function() {\n var component = this.component,\n+ isIndeterminateLeastOne,\n visibleKeys = this._getVisibleNodeKeys();\n \n var selectedVisibleKeys = visibleKeys.filter(function(key) {\n- return component.isRowSelected(key);\n+ var state = component.isRowSelected(key);\n+\n+ if(!isIndeterminateLeastOne) {\n+ isIndeterminateLeastOne = state === undefined;\n+ }\n+\n+ return state;\n });\n \n if(!selectedVisibleKeys.length) {\n- return false;\n+ return isIndeterminateLeastOne ? undefined : false;\n } else if(selectedVisibleKeys.length === visibleKeys.length) {\n return true;\n }\n },\n \n selectAll: function() {\n- var visibleKeys = this._getVisibleNodeKeys();\n+ var isRecursiveSelection = this.isRecursiveSelection(),\n+ visibleKeys = this._getVisibleNodeKeys(isRecursiveSelection);\n+\n return this.selectRows(visibleKeys, true);\n },\n \n deselectAll: function() {\n- var visibleKeys = this._getVisibleNodeKeys();\n+ var isRecursiveSelection = this.isRecursiveSelection(),\n+ visibleKeys = this._getVisibleNodeKeys(isRecursiveSelection);\n+\n return this.deselectRows(visibleKeys);\n+ },\n+\n+ _updateParentSelectionState: function(node, isSelected) {\n+ var that = this,\n+ state = isSelected,\n+ parentNode = node.parent,\n+ isUnselectedLeastOne,\n+ isSelectedLeastOne;\n+\n+ if(parentNode.children.length > 1) {\n+ if(isSelected === false) {\n+ isSelectedLeastOne = parentNode.children.some(function(childNode, index, children) {\n+ return that._selectionStateMap[childNode.key];\n+ });\n+\n+ if(isSelectedLeastOne) {\n+ state = undefined;\n+ } else {\n+ state = false;\n+ }\n+ } else if(isSelected === true) {\n+ isUnselectedLeastOne = parentNode.children.some(function(childNode) {\n+ return !that._selectionStateMap[childNode.key];\n+ });\n+\n+ if(!isUnselectedLeastOne) {\n+ state = true;\n+ } else {\n+ state = undefined;\n+ }\n+ }\n+ }\n+\n+ this._selectionStateMap[parentNode.key] = state;\n+\n+ if(parentNode.parent && parentNode.parent.level >= 0) {\n+ this._updateParentSelectionState(parentNode, state);\n+ }\n+ },\n+\n+ _updateChildrenSelectionState: function(node, isSelected) {\n+ var that = this,\n+ children = node.children;\n+\n+ children.forEach(function(childNode) {\n+ that._selectionStateMap[childNode.key] = isSelected;\n+\n+ if(childNode.children.length > 0) {\n+ that._updateChildrenSelectionState(childNode, isSelected);\n+ }\n+ });\n+ },\n+\n+ _updateSelectionCore: function(keys, isSelected) {\n+ var node,\n+ dataController = this._dataController;\n+\n+ for(var i = 0; i < keys.length; i++) {\n+ this._selectionStateMap[keys[i]] = isSelected;\n+ node = dataController.getNodeByKey(keys[i]);\n+\n+ if(node) {\n+ this._updateParentSelectionState(node, isSelected);\n+ this._updateChildrenSelectionState(node, isSelected);\n+ }\n+ }\n+ },\n+\n+ _processParentKeys: function(key, result) {\n+ var that = this,\n+ index = -1,\n+ parentIndex,\n+ childKeys = [],\n+ ignoreKeys = [key],\n+ node = that._dataController.getNodeByKey(key),\n+ parentNode = node && node.parent;\n+\n+ while(parentNode) {\n+ parentIndex = result.selectedItemKeys.indexOf(parentNode.key);\n+\n+ if(parentIndex < 0) {\n+ ignoreKeys.push(parentNode.key);\n+ parentNode = parentNode.parent;\n+ } else {\n+ break;\n+ }\n+ }\n+\n+ if(parentIndex >= 0) {\n+ result.removedItemKeys.push(parentNode.key);\n+ result.selectedItemKeys.splice(parentIndex, 1);\n+\n+ index = result.selectedItemKeys.indexOf(key);\n+ if(index >= 0) {\n+ result.removedItemKeys.push(key);\n+ result.selectedItemKeys.splice(index, 1);\n+ }\n+\n+ foreachNodes(parentNode.children, function(childNode) {\n+ var ignoreKeyIndex = ignoreKeys.indexOf(childNode.key);\n+\n+ if(ignoreKeyIndex < 0) {\n+ childKeys.push(childNode.key);\n+ }\n+\n+ return ignoreKeyIndex > 0 || ignoreKeyIndex < 0 && that._selectionStateMap[childNode.key] === undefined;\n+ });","path":"js/ui/tree_list/ui.tree_list.selection.js","position":213,"original_position":213,"commit_id":"bf47cbd2e545290c008d085c06281f104a9cbdfa","original_commit_id":"bf47cbd2e545290c008d085c06281f104a9cbdfa","user":{"login":"vconst","id":15967379,"avatar_url":"https://avatars0.githubusercontent.com/u/15967379?v=4","gravatar_id":"","url":"https://api.github.com/users/vconst","html_url":"https://github.com/vconst","followers_url":"https://api.github.com/users/vconst/followers","following_url":"https://api.github.com/users/vconst/following{/other_user}","gists_url":"https://api.github.com/users/vconst/gists{/gist_id}","starred_url":"https://api.github.com/users/vconst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vconst/subscriptions","organizations_url":"https://api.github.com/users/vconst/orgs","repos_url":"https://api.github.com/users/vconst/repos","events_url":"https://api.github.com/users/vconst/events{/privacy}","received_events_url":"https://api.github.com/users/vconst/received_events","type":"User","site_admin":false},"body":"Extract to separate method","created_at":"2017-07-26T11:07:37Z","updated_at":"2017-07-26T11:18:31Z","html_url":"https://github.com/DevExpress/DevExtreme/pull/888#discussion_r129542773","pull_request_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/888","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments/129542773"},"html":{"href":"https://github.com/DevExpress/DevExtreme/pull/888#discussion_r129542773"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/888"}}},"pull_request":{"url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/888","id":132331567,"html_url":"https://github.com/DevExpress/DevExtreme/pull/888","diff_url":"https://github.com/DevExpress/DevExtreme/pull/888.diff","patch_url":"https://github.com/DevExpress/DevExtreme/pull/888.patch","issue_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/888","number":888,"state":"open","locked":false,"title":"dxTreeList - Implementation of the recursive selection","user":{"login":"Alyar666","id":23191430,"avatar_url":"https://avatars0.githubusercontent.com/u/23191430?v=4","gravatar_id":"","url":"https://api.github.com/users/Alyar666","html_url":"https://github.com/Alyar666","followers_url":"https://api.github.com/users/Alyar666/followers","following_url":"https://api.github.com/users/Alyar666/following{/other_user}","gists_url":"https://api.github.com/users/Alyar666/gists{/gist_id}","starred_url":"https://api.github.com/users/Alyar666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alyar666/subscriptions","organizations_url":"https://api.github.com/users/Alyar666/orgs","repos_url":"https://api.github.com/users/Alyar666/repos","events_url":"https://api.github.com/users/Alyar666/events{/privacy}","received_events_url":"https://api.github.com/users/Alyar666/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-25T17:00:31Z","updated_at":"2017-07-26T11:18:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4728bbca715aa96318d04f19323d8e9db78a517","assignee":{"login":"Alyar666","id":23191430,"avatar_url":"https://avatars0.githubusercontent.com/u/23191430?v=4","gravatar_id":"","url":"https://api.github.com/users/Alyar666","html_url":"https://github.com/Alyar666","followers_url":"https://api.github.com/users/Alyar666/followers","following_url":"https://api.github.com/users/Alyar666/following{/other_user}","gists_url":"https://api.github.com/users/Alyar666/gists{/gist_id}","starred_url":"https://api.github.com/users/Alyar666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alyar666/subscriptions","organizations_url":"https://api.github.com/users/Alyar666/orgs","repos_url":"https://api.github.com/users/Alyar666/repos","events_url":"https://api.github.com/users/Alyar666/events{/privacy}","received_events_url":"https://api.github.com/users/Alyar666/received_events","type":"User","site_admin":false},"assignees":[{"login":"Alyar666","id":23191430,"avatar_url":"https://avatars0.githubusercontent.com/u/23191430?v=4","gravatar_id":"","url":"https://api.github.com/users/Alyar666","html_url":"https://github.com/Alyar666","followers_url":"https://api.github.com/users/Alyar666/followers","following_url":"https://api.github.com/users/Alyar666/following{/other_user}","gists_url":"https://api.github.com/users/Alyar666/gists{/gist_id}","starred_url":"https://api.github.com/users/Alyar666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alyar666/subscriptions","organizations_url":"https://api.github.com/users/Alyar666/orgs","repos_url":"https://api.github.com/users/Alyar666/repos","events_url":"https://api.github.com/users/Alyar666/events{/privacy}","received_events_url":"https://api.github.com/users/Alyar666/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/888/commits","review_comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/888/comments","review_comment_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/888/comments","statuses_url":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/bf47cbd2e545290c008d085c06281f104a9cbdfa","head":{"label":"Alyar666:dxTreeList_implementation_recursive_selection","ref":"dxTreeList_implementation_recursive_selection","sha":"bf47cbd2e545290c008d085c06281f104a9cbdfa","user":{"login":"Alyar666","id":23191430,"avatar_url":"https://avatars0.githubusercontent.com/u/23191430?v=4","gravatar_id":"","url":"https://api.github.com/users/Alyar666","html_url":"https://github.com/Alyar666","followers_url":"https://api.github.com/users/Alyar666/followers","following_url":"https://api.github.com/users/Alyar666/following{/other_user}","gists_url":"https://api.github.com/users/Alyar666/gists{/gist_id}","starred_url":"https://api.github.com/users/Alyar666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alyar666/subscriptions","organizations_url":"https://api.github.com/users/Alyar666/orgs","repos_url":"https://api.github.com/users/Alyar666/repos","events_url":"https://api.github.com/users/Alyar666/events{/privacy}","received_events_url":"https://api.github.com/users/Alyar666/received_events","type":"User","site_admin":false},"repo":{"id":89453494,"name":"DevExtreme","full_name":"Alyar666/DevExtreme","owner":{"login":"Alyar666","id":23191430,"avatar_url":"https://avatars0.githubusercontent.com/u/23191430?v=4","gravatar_id":"","url":"https://api.github.com/users/Alyar666","html_url":"https://github.com/Alyar666","followers_url":"https://api.github.com/users/Alyar666/followers","following_url":"https://api.github.com/users/Alyar666/following{/other_user}","gists_url":"https://api.github.com/users/Alyar666/gists{/gist_id}","starred_url":"https://api.github.com/users/Alyar666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alyar666/subscriptions","organizations_url":"https://api.github.com/users/Alyar666/orgs","repos_url":"https://api.github.com/users/Alyar666/repos","events_url":"https://api.github.com/users/Alyar666/events{/privacy}","received_events_url":"https://api.github.com/users/Alyar666/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alyar666/DevExtreme","description":"HTML5 JavaScript Component Suite for Responsive Web Development","fork":true,"url":"https://api.github.com/repos/Alyar666/DevExtreme","forks_url":"https://api.github.com/repos/Alyar666/DevExtreme/forks","keys_url":"https://api.github.com/repos/Alyar666/DevExtreme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alyar666/DevExtreme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alyar666/DevExtreme/teams","hooks_url":"https://api.github.com/repos/Alyar666/DevExtreme/hooks","issue_events_url":"https://api.github.com/repos/Alyar666/DevExtreme/issues/events{/number}","events_url":"https://api.github.com/repos/Alyar666/DevExtreme/events","assignees_url":"https://api.github.com/repos/Alyar666/DevExtreme/assignees{/user}","branches_url":"https://api.github.com/repos/Alyar666/DevExtreme/branches{/branch}","tags_url":"https://api.github.com/repos/Alyar666/DevExtreme/tags","blobs_url":"https://api.github.com/repos/Alyar666/DevExtreme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alyar666/DevExtreme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alyar666/DevExtreme/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alyar666/DevExtreme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alyar666/DevExtreme/statuses/{sha}","languages_url":"https://api.github.com/repos/Alyar666/DevExtreme/languages","stargazers_url":"https://api.github.com/repos/Alyar666/DevExtreme/stargazers","contributors_url":"https://api.github.com/repos/Alyar666/DevExtreme/contributors","subscribers_url":"https://api.github.com/repos/Alyar666/DevExtreme/subscribers","subscription_url":"https://api.github.com/repos/Alyar666/DevExtreme/subscription","commits_url":"https://api.github.com/repos/Alyar666/DevExtreme/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alyar666/DevExtreme/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alyar666/DevExtreme/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alyar666/DevExtreme/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alyar666/DevExtreme/contents/{+path}","compare_url":"https://api.github.com/repos/Alyar666/DevExtreme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alyar666/DevExtreme/merges","archive_url":"https://api.github.com/repos/Alyar666/DevExtreme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alyar666/DevExtreme/downloads","issues_url":"https://api.github.com/repos/Alyar666/DevExtreme/issues{/number}","pulls_url":"https://api.github.com/repos/Alyar666/DevExtreme/pulls{/number}","milestones_url":"https://api.github.com/repos/Alyar666/DevExtreme/milestones{/number}","notifications_url":"https://api.github.com/repos/Alyar666/DevExtreme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alyar666/DevExtreme/labels{/name}","releases_url":"https://api.github.com/repos/Alyar666/DevExtreme/releases{/id}","deployments_url":"https://api.github.com/repos/Alyar666/DevExtreme/deployments","created_at":"2017-04-26T07:50:07Z","updated_at":"2017-04-26T07:50:14Z","pushed_at":"2017-07-26T08:46:38Z","git_url":"git://github.com/Alyar666/DevExtreme.git","ssh_url":"[email protected]:Alyar666/DevExtreme.git","clone_url":"https://github.com/Alyar666/DevExtreme.git","svn_url":"https://github.com/Alyar666/DevExtreme","homepage":"https://js.devexpress.com/","size":9344,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"16_2"}},"base":{"label":"DevExpress:17_2","ref":"17_2","sha":"3fe144acab0122df6eb27609ba57980f476472e1","user":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":88523356,"name":"DevExtreme","full_name":"DevExpress/DevExtreme","owner":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevExpress/DevExtreme","description":"HTML5 JavaScript Component Suite for Responsive Web Development","fork":false,"url":"https://api.github.com/repos/DevExpress/DevExtreme","forks_url":"https://api.github.com/repos/DevExpress/DevExtreme/forks","keys_url":"https://api.github.com/repos/DevExpress/DevExtreme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/DevExtreme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/DevExtreme/teams","hooks_url":"https://api.github.com/repos/DevExpress/DevExtreme/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/DevExtreme/events","assignees_url":"https://api.github.com/repos/DevExpress/DevExtreme/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/DevExtreme/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/DevExtreme/tags","blobs_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/DevExtreme/languages","stargazers_url":"https://api.github.com/repos/DevExpress/DevExtreme/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/DevExtreme/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/DevExtreme/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/DevExtreme/subscription","commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/DevExtreme/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/DevExtreme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/DevExtreme/merges","archive_url":"https://api.github.com/repos/DevExpress/DevExtreme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/DevExtreme/downloads","issues_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/DevExtreme/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/DevExtreme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/DevExtreme/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/DevExtreme/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/DevExtreme/deployments","created_at":"2017-04-17T15:43:34Z","updated_at":"2017-07-24T12:21:54Z","pushed_at":"2017-07-26T11:11:46Z","git_url":"git://github.com/DevExpress/DevExtreme.git","ssh_url":"[email protected]:DevExpress/DevExtreme.git","clone_url":"https://github.com/DevExpress/DevExtreme.git","svn_url":"https://github.com/DevExpress/DevExtreme","homepage":"https://js.devexpress.com/","size":9415,"stargazers_count":684,"watchers_count":684,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":8,"forks":93,"open_issues":8,"watchers":684,"default_branch":"17_2"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/888"},"html":{"href":"https://github.com/DevExpress/DevExtreme/pull/888"},"issue":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/issues/888"},"comments":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/issues/888/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/888/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/888/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/bf47cbd2e545290c008d085c06281f104a9cbdfa"}}}} | {
"id": 88523356,
"name": "DevExpress/DevExtreme",
"url": "https://api.github.com/repos/DevExpress/DevExtreme"
} | {
"id": 15967379,
"login": "vconst",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15967379?",
"url": "https://api.github.com/users/vconst"
} | {
"id": 4243232,
"login": "DevExpress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4243232?",
"url": "https://api.github.com/orgs/DevExpress"
} | 2017-07-26T11:07:37 | 6331938471 | {"actor":{"display_login":"vconst"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/94310983","pull_request_review_id":14838017,"id":94310983,"diff_hunk":"@@ -151568,4 +151725,103 @@ item_db: (\n \tLoc: 1023\n \tScript: <\" bonus2 bExpAddRace, RC_All, 2; \">\n },\n+{\n+\tId: 31016\n+\tAegisName: \"Decorated_Evil_Tree_Card\"\n+\tName: \"Decorated Tree Matilda Card\"\n+\tType: 6\n+\tWeight: 10\n+\tLoc: 16\n+\tScript: <\"\n+\t\tbonus bMaxHP, 1000;\n+\t\tbonus bMaxSP, 150;\n+\t\tbonus bFlee, -25;\n+\t\">\n+},\n+{\n+\tId: 31017\n+\tAegisName: \"Brutal_Tattered_Cookie_Card\"\n+\tName: \"Terrifying Cookie Card\"\n+\tType: 6\n+\tWeight: 10\n+\tLoc: 64\n+\tScript: <\"\n+\t\t.@r = getrefine();","path":"db/re/item_db.conf","position":224,"original_position":224,"commit_id":"0a0fefb4ed292b6170a126f74ab5e545377f64e0","original_commit_id":"0a0fefb4ed292b6170a126f74ab5e545377f64e0","user":{"login":"Asheraf","id":14294215,"avatar_url":"https://avatars.githubusercontent.com/u/14294215?v=3","gravatar_id":"","url":"https://api.github.com/users/Asheraf","html_url":"https://github.com/Asheraf","followers_url":"https://api.github.com/users/Asheraf/followers","following_url":"https://api.github.com/users/Asheraf/following{/other_user}","gists_url":"https://api.github.com/users/Asheraf/gists{/gist_id}","starred_url":"https://api.github.com/users/Asheraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asheraf/subscriptions","organizations_url":"https://api.github.com/users/Asheraf/orgs","repos_url":"https://api.github.com/users/Asheraf/repos","events_url":"https://api.github.com/users/Asheraf/events{/privacy}","received_events_url":"https://api.github.com/users/Asheraf/received_events","type":"User","site_admin":false},"body":"no need to use a variable here check https://github.com/HerculesWS/Hercules/pull/1441","created_at":"2017-01-02T11:31:48Z","updated_at":"2017-01-02T11:33:12Z","html_url":"https://github.com/HerculesWS/Hercules/pull/1539#discussion_r94310983","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1539","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/94310983"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1539#discussion_r94310983"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1539"}}},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1539","id":99841943,"html_url":"https://github.com/HerculesWS/Hercules/pull/1539","diff_url":"https://github.com/HerculesWS/Hercules/pull/1539.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/1539.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1539","number":1539,"state":"open","locked":false,"title":"Horror Toy Factory Instance implementation based on official conversion.","user":{"login":"AtlantisRO","id":17774111,"avatar_url":"https://avatars.githubusercontent.com/u/17774111?v=3","gravatar_id":"","url":"https://api.github.com/users/AtlantisRO","html_url":"https://github.com/AtlantisRO","followers_url":"https://api.github.com/users/AtlantisRO/followers","following_url":"https://api.github.com/users/AtlantisRO/following{/other_user}","gists_url":"https://api.github.com/users/AtlantisRO/gists{/gist_id}","starred_url":"https://api.github.com/users/AtlantisRO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtlantisRO/subscriptions","organizations_url":"https://api.github.com/users/AtlantisRO/orgs","repos_url":"https://api.github.com/users/AtlantisRO/repos","events_url":"https://api.github.com/users/AtlantisRO/events{/privacy}","received_events_url":"https://api.github.com/users/AtlantisRO/received_events","type":"User","site_admin":false},"body":"This is a conversion from the script provided by _esu1214_ in a collaboration with @Ridley8819 and @AtlantisRO, with the translation from Chinese language by Steph.\r\n\r\nHowever it still lacks:\r\n - setmobdata and getmobdata commands\r\n - Skills 716 and 719 for Spectrum Celine and Hidden Mob monsters\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/herculesws/hercules/1539)\r\n<!-- Reviewable:end -->\r\n","created_at":"2017-01-02T07:25:02Z","updated_at":"2017-01-02T11:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46e0121d4d57b3c6dc72b48a1f67180ec625f928","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1539/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1539/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1539/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/0a0fefb4ed292b6170a126f74ab5e545377f64e0","head":{"label":"AtlantisRO:Local","ref":"Local","sha":"0a0fefb4ed292b6170a126f74ab5e545377f64e0","user":{"login":"AtlantisRO","id":17774111,"avatar_url":"https://avatars.githubusercontent.com/u/17774111?v=3","gravatar_id":"","url":"https://api.github.com/users/AtlantisRO","html_url":"https://github.com/AtlantisRO","followers_url":"https://api.github.com/users/AtlantisRO/followers","following_url":"https://api.github.com/users/AtlantisRO/following{/other_user}","gists_url":"https://api.github.com/users/AtlantisRO/gists{/gist_id}","starred_url":"https://api.github.com/users/AtlantisRO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtlantisRO/subscriptions","organizations_url":"https://api.github.com/users/AtlantisRO/orgs","repos_url":"https://api.github.com/users/AtlantisRO/repos","events_url":"https://api.github.com/users/AtlantisRO/events{/privacy}","received_events_url":"https://api.github.com/users/AtlantisRO/received_events","type":"User","site_admin":false},"repo":{"id":70005905,"name":"Hercules","full_name":"AtlantisRO/Hercules","owner":{"login":"AtlantisRO","id":17774111,"avatar_url":"https://avatars.githubusercontent.com/u/17774111?v=3","gravatar_id":"","url":"https://api.github.com/users/AtlantisRO","html_url":"https://github.com/AtlantisRO","followers_url":"https://api.github.com/users/AtlantisRO/followers","following_url":"https://api.github.com/users/AtlantisRO/following{/other_user}","gists_url":"https://api.github.com/users/AtlantisRO/gists{/gist_id}","starred_url":"https://api.github.com/users/AtlantisRO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtlantisRO/subscriptions","organizations_url":"https://api.github.com/users/AtlantisRO/orgs","repos_url":"https://api.github.com/users/AtlantisRO/repos","events_url":"https://api.github.com/users/AtlantisRO/events{/privacy}","received_events_url":"https://api.github.com/users/AtlantisRO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AtlantisRO/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/AtlantisRO/Hercules","forks_url":"https://api.github.com/repos/AtlantisRO/Hercules/forks","keys_url":"https://api.github.com/repos/AtlantisRO/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtlantisRO/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtlantisRO/Hercules/teams","hooks_url":"https://api.github.com/repos/AtlantisRO/Hercules/hooks","issue_events_url":"https://api.github.com/repos/AtlantisRO/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/AtlantisRO/Hercules/events","assignees_url":"https://api.github.com/repos/AtlantisRO/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/AtlantisRO/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/AtlantisRO/Hercules/tags","blobs_url":"https://api.github.com/repos/AtlantisRO/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtlantisRO/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtlantisRO/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtlantisRO/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtlantisRO/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/AtlantisRO/Hercules/languages","stargazers_url":"https://api.github.com/repos/AtlantisRO/Hercules/stargazers","contributors_url":"https://api.github.com/repos/AtlantisRO/Hercules/contributors","subscribers_url":"https://api.github.com/repos/AtlantisRO/Hercules/subscribers","subscription_url":"https://api.github.com/repos/AtlantisRO/Hercules/subscription","commits_url":"https://api.github.com/repos/AtlantisRO/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtlantisRO/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtlantisRO/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtlantisRO/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtlantisRO/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/AtlantisRO/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtlantisRO/Hercules/merges","archive_url":"https://api.github.com/repos/AtlantisRO/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtlantisRO/Hercules/downloads","issues_url":"https://api.github.com/repos/AtlantisRO/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/AtlantisRO/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/AtlantisRO/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/AtlantisRO/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtlantisRO/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/AtlantisRO/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/AtlantisRO/Hercules/deployments","created_at":"2016-10-04T21:00:36Z","updated_at":"2016-10-04T21:00:46Z","pushed_at":"2017-01-02T07:13:23Z","git_url":"git://github.com/AtlantisRO/Hercules.git","ssh_url":"[email protected]:AtlantisRO/Hercules.git","clone_url":"https://github.com/AtlantisRO/Hercules.git","svn_url":"https://github.com/AtlantisRO/Hercules","homepage":"http://herc.ws","size":131490,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"2ff43cdd13d40a0494f3da2adca90b510bcc22ca","user":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars.githubusercontent.com/u/3220669?v=3","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars.githubusercontent.com/u/3220669?v=3","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2016-12-27T14:50:46Z","pushed_at":"2017-01-02T07:25:07Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"[email protected]:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":136438,"stargazers_count":310,"watchers_count":310,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":455,"mirror_url":null,"open_issues_count":364,"forks":455,"open_issues":364,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1539"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1539"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1539"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1539/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1539/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1539/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/0a0fefb4ed292b6170a126f74ab5e545377f64e0"}}}} | {
"id": 7551429,
"name": "HerculesWS/Hercules",
"url": "https://api.github.com/repos/HerculesWS/Hercules"
} | {
"id": 14294215,
"login": "Asheraf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14294215?",
"url": "https://api.github.com/users/Asheraf"
} | {
"id": 3220669,
"login": "HerculesWS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3220669?",
"url": "https://api.github.com/orgs/HerculesWS"
} | 2017-01-02T11:31:48 | 5090966640 | {"actor":{"display_login":"Asheraf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/comments/144134413","pull_request_review_id":68747986,"id":144134413,"diff_hunk":"@@ -0,0 +1,23 @@\n+class Jaden\n+ def initialize(sentence)\n+ @sentence = sentence\n+ end\n+\n+ def to_jaden_case\n+ if is_valid_input?\n+ return \"Invalid format.\"\n+ end\n+ jaden_case = \"\"\n+ words_in_sentence = @sentence.split(\" \")\n+ words_in_sentence.each { |word|","path":"exercises_Ian/03/jaden/jaden.rb","position":12,"original_position":12,"commit_id":"22acc65348a027380e229092842fcd698abcfbc6","original_commit_id":"22acc65348a027380e229092842fcd698abcfbc6","user":{"login":"kurenn","id":236312,"avatar_url":"https://avatars0.githubusercontent.com/u/236312?v=4","gravatar_id":"","url":"https://api.github.com/users/kurenn","html_url":"https://github.com/kurenn","followers_url":"https://api.github.com/users/kurenn/followers","following_url":"https://api.github.com/users/kurenn/following{/other_user}","gists_url":"https://api.github.com/users/kurenn/gists{/gist_id}","starred_url":"https://api.github.com/users/kurenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurenn/subscriptions","organizations_url":"https://api.github.com/users/kurenn/orgs","repos_url":"https://api.github.com/users/kurenn/repos","events_url":"https://api.github.com/users/kurenn/events{/privacy}","received_events_url":"https://api.github.com/users/kurenn/received_events","type":"User","site_admin":false},"body":"I think you can make a `map` instead of an `each`, and also check out the `join` method for the arrays","created_at":"2017-10-11T20:59:20Z","updated_at":"2017-10-11T20:59:25Z","html_url":"https://github.com/IcaliaLabs/cdmx-testing/pull/5#discussion_r144134413","pull_request_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/comments/144134413"},"html":{"href":"https://github.com/IcaliaLabs/cdmx-testing/pull/5#discussion_r144134413"},"pull_request":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/5","id":146058471,"html_url":"https://github.com/IcaliaLabs/cdmx-testing/pull/5","diff_url":"https://github.com/IcaliaLabs/cdmx-testing/pull/5.diff","patch_url":"https://github.com/IcaliaLabs/cdmx-testing/pull/5.patch","issue_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues/5","number":5,"state":"open","locked":false,"title":"added exercises 02 and 03","user":{"login":"IanBravo","id":7003523,"avatar_url":"https://avatars3.githubusercontent.com/u/7003523?v=4","gravatar_id":"","url":"https://api.github.com/users/IanBravo","html_url":"https://github.com/IanBravo","followers_url":"https://api.github.com/users/IanBravo/followers","following_url":"https://api.github.com/users/IanBravo/following{/other_user}","gists_url":"https://api.github.com/users/IanBravo/gists{/gist_id}","starred_url":"https://api.github.com/users/IanBravo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanBravo/subscriptions","organizations_url":"https://api.github.com/users/IanBravo/orgs","repos_url":"https://api.github.com/users/IanBravo/repos","events_url":"https://api.github.com/users/IanBravo/events{/privacy}","received_events_url":"https://api.github.com/users/IanBravo/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-11T20:50:01Z","updated_at":"2017-10-11T20:59:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c78f09a7e1ba26a09ae6c5950dfbe66996b51941","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/5/commits","review_comments_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/5/comments","review_comment_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues/5/comments","statuses_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/statuses/22acc65348a027380e229092842fcd698abcfbc6","head":{"label":"IcaliaLabs:Ian_exercises","ref":"Ian_exercises","sha":"22acc65348a027380e229092842fcd698abcfbc6","user":{"login":"IcaliaLabs","id":2523244,"avatar_url":"https://avatars0.githubusercontent.com/u/2523244?v=4","gravatar_id":"","url":"https://api.github.com/users/IcaliaLabs","html_url":"https://github.com/IcaliaLabs","followers_url":"https://api.github.com/users/IcaliaLabs/followers","following_url":"https://api.github.com/users/IcaliaLabs/following{/other_user}","gists_url":"https://api.github.com/users/IcaliaLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IcaliaLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IcaliaLabs/subscriptions","organizations_url":"https://api.github.com/users/IcaliaLabs/orgs","repos_url":"https://api.github.com/users/IcaliaLabs/repos","events_url":"https://api.github.com/users/IcaliaLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IcaliaLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":106571618,"name":"cdmx-testing","full_name":"IcaliaLabs/cdmx-testing","owner":{"login":"IcaliaLabs","id":2523244,"avatar_url":"https://avatars0.githubusercontent.com/u/2523244?v=4","gravatar_id":"","url":"https://api.github.com/users/IcaliaLabs","html_url":"https://github.com/IcaliaLabs","followers_url":"https://api.github.com/users/IcaliaLabs/followers","following_url":"https://api.github.com/users/IcaliaLabs/following{/other_user}","gists_url":"https://api.github.com/users/IcaliaLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IcaliaLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IcaliaLabs/subscriptions","organizations_url":"https://api.github.com/users/IcaliaLabs/orgs","repos_url":"https://api.github.com/users/IcaliaLabs/repos","events_url":"https://api.github.com/users/IcaliaLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IcaliaLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IcaliaLabs/cdmx-testing","description":null,"fork":false,"url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing","forks_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/forks","keys_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/teams","hooks_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/hooks","issue_events_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues/events{/number}","events_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/events","assignees_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/assignees{/user}","branches_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/branches{/branch}","tags_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/tags","blobs_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/languages","stargazers_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/stargazers","contributors_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/contributors","subscribers_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/subscribers","subscription_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/subscription","commits_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/contents/{+path}","compare_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/merges","archive_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/downloads","issues_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues{/number}","pulls_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/labels{/name}","releases_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/releases{/id}","deployments_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/deployments","created_at":"2017-10-11T15:20:00Z","updated_at":"2017-10-11T15:26:02Z","pushed_at":"2017-10-11T20:50:02Z","git_url":"git://github.com/IcaliaLabs/cdmx-testing.git","ssh_url":"[email protected]:IcaliaLabs/cdmx-testing.git","clone_url":"https://github.com/IcaliaLabs/cdmx-testing.git","svn_url":"https://github.com/IcaliaLabs/cdmx-testing","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"IcaliaLabs:master","ref":"master","sha":"d477d925fc72c5881f1b5ad6711f2e047de91129","user":{"login":"IcaliaLabs","id":2523244,"avatar_url":"https://avatars0.githubusercontent.com/u/2523244?v=4","gravatar_id":"","url":"https://api.github.com/users/IcaliaLabs","html_url":"https://github.com/IcaliaLabs","followers_url":"https://api.github.com/users/IcaliaLabs/followers","following_url":"https://api.github.com/users/IcaliaLabs/following{/other_user}","gists_url":"https://api.github.com/users/IcaliaLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IcaliaLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IcaliaLabs/subscriptions","organizations_url":"https://api.github.com/users/IcaliaLabs/orgs","repos_url":"https://api.github.com/users/IcaliaLabs/repos","events_url":"https://api.github.com/users/IcaliaLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IcaliaLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":106571618,"name":"cdmx-testing","full_name":"IcaliaLabs/cdmx-testing","owner":{"login":"IcaliaLabs","id":2523244,"avatar_url":"https://avatars0.githubusercontent.com/u/2523244?v=4","gravatar_id":"","url":"https://api.github.com/users/IcaliaLabs","html_url":"https://github.com/IcaliaLabs","followers_url":"https://api.github.com/users/IcaliaLabs/followers","following_url":"https://api.github.com/users/IcaliaLabs/following{/other_user}","gists_url":"https://api.github.com/users/IcaliaLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IcaliaLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IcaliaLabs/subscriptions","organizations_url":"https://api.github.com/users/IcaliaLabs/orgs","repos_url":"https://api.github.com/users/IcaliaLabs/repos","events_url":"https://api.github.com/users/IcaliaLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IcaliaLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IcaliaLabs/cdmx-testing","description":null,"fork":false,"url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing","forks_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/forks","keys_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/teams","hooks_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/hooks","issue_events_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues/events{/number}","events_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/events","assignees_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/assignees{/user}","branches_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/branches{/branch}","tags_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/tags","blobs_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/languages","stargazers_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/stargazers","contributors_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/contributors","subscribers_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/subscribers","subscription_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/subscription","commits_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/contents/{+path}","compare_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/merges","archive_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/downloads","issues_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues{/number}","pulls_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/labels{/name}","releases_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/releases{/id}","deployments_url":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/deployments","created_at":"2017-10-11T15:20:00Z","updated_at":"2017-10-11T15:26:02Z","pushed_at":"2017-10-11T20:50:02Z","git_url":"git://github.com/IcaliaLabs/cdmx-testing.git","ssh_url":"[email protected]:IcaliaLabs/cdmx-testing.git","clone_url":"https://github.com/IcaliaLabs/cdmx-testing.git","svn_url":"https://github.com/IcaliaLabs/cdmx-testing","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/5"},"html":{"href":"https://github.com/IcaliaLabs/cdmx-testing/pull/5"},"issue":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues/5"},"comments":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/IcaliaLabs/cdmx-testing/statuses/22acc65348a027380e229092842fcd698abcfbc6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 106571618,
"name": "IcaliaLabs/cdmx-testing",
"url": "https://api.github.com/repos/IcaliaLabs/cdmx-testing"
} | {
"id": 236312,
"login": "kurenn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/236312?",
"url": "https://api.github.com/users/kurenn"
} | {
"id": 2523244,
"login": "IcaliaLabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2523244?",
"url": "https://api.github.com/orgs/IcaliaLabs"
} | 2017-10-11T20:59:20 | 6704785569 | {"actor":{"display_login":"kurenn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments/143760954","pull_request_review_id":68320091,"id":143760954,"diff_hunk":"@@ -35,7 +35,10 @@ export const mapMutateToProps = ({ ownProps, mutate }) => ({\n return mutate({\n variables: { input: page },\n update\n- }).then(redirectToNewPage(ownProps));\n+ }).then(result => {\n+ redirectToNewPage(ownProps)(result);\n+ return result.data.createQuestionPage;","path":"src/containers/enhancers/withCreatePage.js","position":7,"original_position":7,"commit_id":"434325cdae487bbbd604b2ba158034370667e34c","original_commit_id":"e4b5c7b80db54dc94a48b628a09a46dc66e1a16f","user":{"login":"hamishtaplin","id":930398,"avatar_url":"https://avatars0.githubusercontent.com/u/930398?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishtaplin","html_url":"https://github.com/hamishtaplin","followers_url":"https://api.github.com/users/hamishtaplin/followers","following_url":"https://api.github.com/users/hamishtaplin/following{/other_user}","gists_url":"https://api.github.com/users/hamishtaplin/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishtaplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishtaplin/subscriptions","organizations_url":"https://api.github.com/users/hamishtaplin/orgs","repos_url":"https://api.github.com/users/hamishtaplin/repos","events_url":"https://api.github.com/users/hamishtaplin/events{/privacy}","received_events_url":"https://api.github.com/users/hamishtaplin/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-10-10T15:17:53Z","updated_at":"2017-10-10T15:17:53Z","html_url":"https://github.com/ONSdigital/eq-author/pull/228#discussion_r143760954","pull_request_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/228","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments/143760954"},"html":{"href":"https://github.com/ONSdigital/eq-author/pull/228#discussion_r143760954"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/228"}},"in_reply_to_id":143493960},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/228","id":145170891,"html_url":"https://github.com/ONSdigital/eq-author/pull/228","diff_url":"https://github.com/ONSdigital/eq-author/pull/228.diff","patch_url":"https://github.com/ONSdigital/eq-author/pull/228.patch","issue_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/228","number":228,"state":"open","locked":false,"title":"Focus on new section when created","user":{"login":"hamishtaplin","id":930398,"avatar_url":"https://avatars0.githubusercontent.com/u/930398?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishtaplin","html_url":"https://github.com/hamishtaplin","followers_url":"https://api.github.com/users/hamishtaplin/followers","following_url":"https://api.github.com/users/hamishtaplin/following{/other_user}","gists_url":"https://api.github.com/users/hamishtaplin/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishtaplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishtaplin/subscriptions","organizations_url":"https://api.github.com/users/hamishtaplin/orgs","repos_url":"https://api.github.com/users/hamishtaplin/repos","events_url":"https://api.github.com/users/hamishtaplin/events{/privacy}","received_events_url":"https://api.github.com/users/hamishtaplin/received_events","type":"User","site_admin":false},"body":"### What is the context of this PR?\r\n\r\n[Trello](https://trello.com/c/FkGCN5EE/254-focus-on-new-section-when-created-2)\r\n\r\nUses [`scrollIntoView`](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView) to ensure any new items (section or pages) are scrolled into view of the questionnaire nav when added.\r\n\r\n### How to review \r\n\r\nAdd a variety of sections and pages from different starting scroll positions.\r\n","created_at":"2017-10-06T14:43:08Z","updated_at":"2017-10-10T15:17:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72fbbcf990361bab6c2c3fb41d3315a3dac516ca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"WickyNilliams","id":1091390,"avatar_url":"https://avatars3.githubusercontent.com/u/1091390?v=4","gravatar_id":"","url":"https://api.github.com/users/WickyNilliams","html_url":"https://github.com/WickyNilliams","followers_url":"https://api.github.com/users/WickyNilliams/followers","following_url":"https://api.github.com/users/WickyNilliams/following{/other_user}","gists_url":"https://api.github.com/users/WickyNilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/WickyNilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WickyNilliams/subscriptions","organizations_url":"https://api.github.com/users/WickyNilliams/orgs","repos_url":"https://api.github.com/users/WickyNilliams/repos","events_url":"https://api.github.com/users/WickyNilliams/events{/privacy}","received_events_url":"https://api.github.com/users/WickyNilliams/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/228/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/228/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/228/comments","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/434325cdae487bbbd604b2ba158034370667e34c","head":{"label":"ONSdigital:254-focus-on-new-section-when-created","ref":"254-focus-on-new-section-when-created","sha":"434325cdae487bbbd604b2ba158034370667e34c","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":82051674,"name":"eq-author","full_name":"ONSdigital/eq-author","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/eq-author","description":"Author application","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-author","forks_url":"https://api.github.com/repos/ONSdigital/eq-author/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-author/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-author/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-author/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-author/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-author/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-author/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-author/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-author/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-author/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-author/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-author/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-author/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-author/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-author/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-author/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-author/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-author/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-author/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-author/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-author/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-author/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-author/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-author/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-author/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-author/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-author/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-author/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-author/deployments","created_at":"2017-02-15T11:06:14Z","updated_at":"2017-09-28T02:59:48Z","pushed_at":"2017-10-10T15:15:34Z","git_url":"git://github.com/ONSdigital/eq-author.git","ssh_url":"[email protected]:ONSdigital/eq-author.git","clone_url":"https://github.com/ONSdigital/eq-author.git","svn_url":"https://github.com/ONSdigital/eq-author","homepage":"http://eq-author.apps.devtest.onsclofo.uk","size":2273,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":4,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"6c5250f27573c953eabcfed41dc53148c2d840bd","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":82051674,"name":"eq-author","full_name":"ONSdigital/eq-author","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/eq-author","description":"Author application","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-author","forks_url":"https://api.github.com/repos/ONSdigital/eq-author/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-author/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-author/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-author/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-author/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-author/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-author/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-author/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-author/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-author/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-author/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-author/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-author/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-author/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-author/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-author/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-author/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-author/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-author/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-author/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-author/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-author/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-author/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-author/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-author/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-author/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-author/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-author/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-author/deployments","created_at":"2017-02-15T11:06:14Z","updated_at":"2017-09-28T02:59:48Z","pushed_at":"2017-10-10T15:15:34Z","git_url":"git://github.com/ONSdigital/eq-author.git","ssh_url":"[email protected]:ONSdigital/eq-author.git","clone_url":"https://github.com/ONSdigital/eq-author.git","svn_url":"https://github.com/ONSdigital/eq-author","homepage":"http://eq-author.apps.devtest.onsclofo.uk","size":2273,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/228"},"html":{"href":"https://github.com/ONSdigital/eq-author/pull/228"},"issue":{"href":"https://api.github.com/repos/ONSdigital/eq-author/issues/228"},"comments":{"href":"https://api.github.com/repos/ONSdigital/eq-author/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/eq-author/statuses/434325cdae487bbbd604b2ba158034370667e34c"}},"author_association":"COLLABORATOR"}} | {
"id": 82051674,
"name": "ONSdigital/eq-author",
"url": "https://api.github.com/repos/ONSdigital/eq-author"
} | {
"id": 930398,
"login": "hamishtaplin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/930398?",
"url": "https://api.github.com/users/hamishtaplin"
} | {
"id": 6865137,
"login": "ONSdigital",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6865137?",
"url": "https://api.github.com/orgs/ONSdigital"
} | 2017-10-10T15:17:53 | 6697502502 | {"actor":{"display_login":"hamishtaplin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpusCapita/onboarding/pulls/comments/109410678","pull_request_review_id":30507755,"id":109410678,"diff_hunk":"@@ -84,30 +58,64 @@ module.exports = function(app, db) {\n .catch(() => res.status(500).json({ message: 'Not able to start campaign.' }));\n });\n \n- // API to send campaign emails.\n+ //Get list of possible transitions.\n+ const getTransitions = (campaignType, currentState) => getPossibleTransitions(campaignType, currentState);\n+\n+ \n+ //Update campaign contact's transition state.\n+ const updateTransitionState = (campaignId, id, transitionState) => {\n+ return db.models.CampaignContact.find({ where: {id: id} })\n+ .then((contact) => {\n+ if(contact && getTransitions('SupplierOnboarding', contact.dataValues.status).indexOf(transitionState)!== -1){\n+ return contact.updateAttributes({\n+ status: transitionState,\n+ lastStatusChange: new Date()\n+ }).then((contact) => {","path":"src/server/workflow/workflow.js","position":69,"original_position":69,"commit_id":"c37ec244339ac310e5b67e98793fe9a9f9e0d2bd","original_commit_id":"c37ec244339ac310e5b67e98793fe9a9f9e0d2bd","user":{"login":"patrykkopycinski","id":5188868,"avatar_url":"https://avatars2.githubusercontent.com/u/5188868?v=3","gravatar_id":"","url":"https://api.github.com/users/patrykkopycinski","html_url":"https://github.com/patrykkopycinski","followers_url":"https://api.github.com/users/patrykkopycinski/followers","following_url":"https://api.github.com/users/patrykkopycinski/following{/other_user}","gists_url":"https://api.github.com/users/patrykkopycinski/gists{/gist_id}","starred_url":"https://api.github.com/users/patrykkopycinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrykkopycinski/subscriptions","organizations_url":"https://api.github.com/users/patrykkopycinski/orgs","repos_url":"https://api.github.com/users/patrykkopycinski/repos","events_url":"https://api.github.com/users/patrykkopycinski/events{/privacy}","received_events_url":"https://api.github.com/users/patrykkopycinski/received_events","type":"User","site_admin":false},"body":"`.then((contact) => return contact` isn't necessary","created_at":"2017-04-03T13:02:56Z","updated_at":"2017-04-03T13:08:38Z","html_url":"https://github.com/OpusCapita/onboarding/pull/70#discussion_r109410678","pull_request_url":"https://api.github.com/repos/OpusCapita/onboarding/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/OpusCapita/onboarding/pulls/comments/109410678"},"html":{"href":"https://github.com/OpusCapita/onboarding/pull/70#discussion_r109410678"},"pull_request":{"href":"https://api.github.com/repos/OpusCapita/onboarding/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/OpusCapita/onboarding/pulls/70","id":113914390,"html_url":"https://github.com/OpusCapita/onboarding/pull/70","diff_url":"https://github.com/OpusCapita/onboarding/pull/70.diff","patch_url":"https://github.com/OpusCapita/onboarding/pull/70.patch","issue_url":"https://api.github.com/repos/OpusCapita/onboarding/issues/70","number":70,"state":"open","locked":false,"title":"Redis integration","user":{"login":"kpatyal","id":9672525,"avatar_url":"https://avatars2.githubusercontent.com/u/9672525?v=3","gravatar_id":"","url":"https://api.github.com/users/kpatyal","html_url":"https://github.com/kpatyal","followers_url":"https://api.github.com/users/kpatyal/followers","following_url":"https://api.github.com/users/kpatyal/following{/other_user}","gists_url":"https://api.github.com/users/kpatyal/gists{/gist_id}","starred_url":"https://api.github.com/users/kpatyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpatyal/subscriptions","organizations_url":"https://api.github.com/users/kpatyal/orgs","repos_url":"https://api.github.com/users/kpatyal/repos","events_url":"https://api.github.com/users/kpatyal/events{/privacy}","received_events_url":"https://api.github.com/users/kpatyal/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-03T11:59:54Z","updated_at":"2017-04-03T13:08:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e9f9f4d01fb696019bc3d5fa92634567baecac7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpusCapita/onboarding/pulls/70/commits","review_comments_url":"https://api.github.com/repos/OpusCapita/onboarding/pulls/70/comments","review_comment_url":"https://api.github.com/repos/OpusCapita/onboarding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpusCapita/onboarding/issues/70/comments","statuses_url":"https://api.github.com/repos/OpusCapita/onboarding/statuses/c37ec244339ac310e5b67e98793fe9a9f9e0d2bd","head":{"label":"OpusCapita:redis-integration","ref":"redis-integration","sha":"c37ec244339ac310e5b67e98793fe9a9f9e0d2bd","user":{"login":"OpusCapita","id":23256480,"avatar_url":"https://avatars2.githubusercontent.com/u/23256480?v=3","gravatar_id":"","url":"https://api.github.com/users/OpusCapita","html_url":"https://github.com/OpusCapita","followers_url":"https://api.github.com/users/OpusCapita/followers","following_url":"https://api.github.com/users/OpusCapita/following{/other_user}","gists_url":"https://api.github.com/users/OpusCapita/gists{/gist_id}","starred_url":"https://api.github.com/users/OpusCapita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpusCapita/subscriptions","organizations_url":"https://api.github.com/users/OpusCapita/orgs","repos_url":"https://api.github.com/users/OpusCapita/repos","events_url":"https://api.github.com/users/OpusCapita/events{/privacy}","received_events_url":"https://api.github.com/users/OpusCapita/received_events","type":"Organization","site_admin":false},"repo":{"id":73171252,"name":"onboarding","full_name":"OpusCapita/onboarding","owner":{"login":"OpusCapita","id":23256480,"avatar_url":"https://avatars2.githubusercontent.com/u/23256480?v=3","gravatar_id":"","url":"https://api.github.com/users/OpusCapita","html_url":"https://github.com/OpusCapita","followers_url":"https://api.github.com/users/OpusCapita/followers","following_url":"https://api.github.com/users/OpusCapita/following{/other_user}","gists_url":"https://api.github.com/users/OpusCapita/gists{/gist_id}","starred_url":"https://api.github.com/users/OpusCapita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpusCapita/subscriptions","organizations_url":"https://api.github.com/users/OpusCapita/orgs","repos_url":"https://api.github.com/users/OpusCapita/repos","events_url":"https://api.github.com/users/OpusCapita/events{/privacy}","received_events_url":"https://api.github.com/users/OpusCapita/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpusCapita/onboarding","description":"Microservice for Campaigns","fork":false,"url":"https://api.github.com/repos/OpusCapita/onboarding","forks_url":"https://api.github.com/repos/OpusCapita/onboarding/forks","keys_url":"https://api.github.com/repos/OpusCapita/onboarding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpusCapita/onboarding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpusCapita/onboarding/teams","hooks_url":"https://api.github.com/repos/OpusCapita/onboarding/hooks","issue_events_url":"https://api.github.com/repos/OpusCapita/onboarding/issues/events{/number}","events_url":"https://api.github.com/repos/OpusCapita/onboarding/events","assignees_url":"https://api.github.com/repos/OpusCapita/onboarding/assignees{/user}","branches_url":"https://api.github.com/repos/OpusCapita/onboarding/branches{/branch}","tags_url":"https://api.github.com/repos/OpusCapita/onboarding/tags","blobs_url":"https://api.github.com/repos/OpusCapita/onboarding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpusCapita/onboarding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpusCapita/onboarding/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpusCapita/onboarding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpusCapita/onboarding/statuses/{sha}","languages_url":"https://api.github.com/repos/OpusCapita/onboarding/languages","stargazers_url":"https://api.github.com/repos/OpusCapita/onboarding/stargazers","contributors_url":"https://api.github.com/repos/OpusCapita/onboarding/contributors","subscribers_url":"https://api.github.com/repos/OpusCapita/onboarding/subscribers","subscription_url":"https://api.github.com/repos/OpusCapita/onboarding/subscription","commits_url":"https://api.github.com/repos/OpusCapita/onboarding/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpusCapita/onboarding/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpusCapita/onboarding/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpusCapita/onboarding/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpusCapita/onboarding/contents/{+path}","compare_url":"https://api.github.com/repos/OpusCapita/onboarding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpusCapita/onboarding/merges","archive_url":"https://api.github.com/repos/OpusCapita/onboarding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpusCapita/onboarding/downloads","issues_url":"https://api.github.com/repos/OpusCapita/onboarding/issues{/number}","pulls_url":"https://api.github.com/repos/OpusCapita/onboarding/pulls{/number}","milestones_url":"https://api.github.com/repos/OpusCapita/onboarding/milestones{/number}","notifications_url":"https://api.github.com/repos/OpusCapita/onboarding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpusCapita/onboarding/labels{/name}","releases_url":"https://api.github.com/repos/OpusCapita/onboarding/releases{/id}","deployments_url":"https://api.github.com/repos/OpusCapita/onboarding/deployments","created_at":"2016-11-08T09:41:42Z","updated_at":"2017-03-24T09:19:57Z","pushed_at":"2017-04-03T11:59:55Z","git_url":"git://github.com/OpusCapita/onboarding.git","ssh_url":"[email protected]:OpusCapita/onboarding.git","clone_url":"https://github.com/OpusCapita/onboarding.git","svn_url":"https://github.com/OpusCapita/onboarding","homepage":"","size":50428,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"OpusCapita:develop","ref":"develop","sha":"e18272925e918996fdc9bd8fa0e85b9df461c484","user":{"login":"OpusCapita","id":23256480,"avatar_url":"https://avatars2.githubusercontent.com/u/23256480?v=3","gravatar_id":"","url":"https://api.github.com/users/OpusCapita","html_url":"https://github.com/OpusCapita","followers_url":"https://api.github.com/users/OpusCapita/followers","following_url":"https://api.github.com/users/OpusCapita/following{/other_user}","gists_url":"https://api.github.com/users/OpusCapita/gists{/gist_id}","starred_url":"https://api.github.com/users/OpusCapita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpusCapita/subscriptions","organizations_url":"https://api.github.com/users/OpusCapita/orgs","repos_url":"https://api.github.com/users/OpusCapita/repos","events_url":"https://api.github.com/users/OpusCapita/events{/privacy}","received_events_url":"https://api.github.com/users/OpusCapita/received_events","type":"Organization","site_admin":false},"repo":{"id":73171252,"name":"onboarding","full_name":"OpusCapita/onboarding","owner":{"login":"OpusCapita","id":23256480,"avatar_url":"https://avatars2.githubusercontent.com/u/23256480?v=3","gravatar_id":"","url":"https://api.github.com/users/OpusCapita","html_url":"https://github.com/OpusCapita","followers_url":"https://api.github.com/users/OpusCapita/followers","following_url":"https://api.github.com/users/OpusCapita/following{/other_user}","gists_url":"https://api.github.com/users/OpusCapita/gists{/gist_id}","starred_url":"https://api.github.com/users/OpusCapita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpusCapita/subscriptions","organizations_url":"https://api.github.com/users/OpusCapita/orgs","repos_url":"https://api.github.com/users/OpusCapita/repos","events_url":"https://api.github.com/users/OpusCapita/events{/privacy}","received_events_url":"https://api.github.com/users/OpusCapita/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpusCapita/onboarding","description":"Microservice for Campaigns","fork":false,"url":"https://api.github.com/repos/OpusCapita/onboarding","forks_url":"https://api.github.com/repos/OpusCapita/onboarding/forks","keys_url":"https://api.github.com/repos/OpusCapita/onboarding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpusCapita/onboarding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpusCapita/onboarding/teams","hooks_url":"https://api.github.com/repos/OpusCapita/onboarding/hooks","issue_events_url":"https://api.github.com/repos/OpusCapita/onboarding/issues/events{/number}","events_url":"https://api.github.com/repos/OpusCapita/onboarding/events","assignees_url":"https://api.github.com/repos/OpusCapita/onboarding/assignees{/user}","branches_url":"https://api.github.com/repos/OpusCapita/onboarding/branches{/branch}","tags_url":"https://api.github.com/repos/OpusCapita/onboarding/tags","blobs_url":"https://api.github.com/repos/OpusCapita/onboarding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpusCapita/onboarding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpusCapita/onboarding/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpusCapita/onboarding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpusCapita/onboarding/statuses/{sha}","languages_url":"https://api.github.com/repos/OpusCapita/onboarding/languages","stargazers_url":"https://api.github.com/repos/OpusCapita/onboarding/stargazers","contributors_url":"https://api.github.com/repos/OpusCapita/onboarding/contributors","subscribers_url":"https://api.github.com/repos/OpusCapita/onboarding/subscribers","subscription_url":"https://api.github.com/repos/OpusCapita/onboarding/subscription","commits_url":"https://api.github.com/repos/OpusCapita/onboarding/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpusCapita/onboarding/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpusCapita/onboarding/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpusCapita/onboarding/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpusCapita/onboarding/contents/{+path}","compare_url":"https://api.github.com/repos/OpusCapita/onboarding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpusCapita/onboarding/merges","archive_url":"https://api.github.com/repos/OpusCapita/onboarding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpusCapita/onboarding/downloads","issues_url":"https://api.github.com/repos/OpusCapita/onboarding/issues{/number}","pulls_url":"https://api.github.com/repos/OpusCapita/onboarding/pulls{/number}","milestones_url":"https://api.github.com/repos/OpusCapita/onboarding/milestones{/number}","notifications_url":"https://api.github.com/repos/OpusCapita/onboarding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpusCapita/onboarding/labels{/name}","releases_url":"https://api.github.com/repos/OpusCapita/onboarding/releases{/id}","deployments_url":"https://api.github.com/repos/OpusCapita/onboarding/deployments","created_at":"2016-11-08T09:41:42Z","updated_at":"2017-03-24T09:19:57Z","pushed_at":"2017-04-03T11:59:55Z","git_url":"git://github.com/OpusCapita/onboarding.git","ssh_url":"[email protected]:OpusCapita/onboarding.git","clone_url":"https://github.com/OpusCapita/onboarding.git","svn_url":"https://github.com/OpusCapita/onboarding","homepage":"","size":50428,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpusCapita/onboarding/pulls/70"},"html":{"href":"https://github.com/OpusCapita/onboarding/pull/70"},"issue":{"href":"https://api.github.com/repos/OpusCapita/onboarding/issues/70"},"comments":{"href":"https://api.github.com/repos/OpusCapita/onboarding/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/OpusCapita/onboarding/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/OpusCapita/onboarding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpusCapita/onboarding/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/OpusCapita/onboarding/statuses/c37ec244339ac310e5b67e98793fe9a9f9e0d2bd"}}}} | {
"id": 73171252,
"name": "OpusCapita/onboarding",
"url": "https://api.github.com/repos/OpusCapita/onboarding"
} | {
"id": 5188868,
"login": "patrykkopycinski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5188868?",
"url": "https://api.github.com/users/patrykkopycinski"
} | {
"id": 23256480,
"login": "OpusCapita",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23256480?",
"url": "https://api.github.com/orgs/OpusCapita"
} | 2017-04-03T13:02:56 | 5614750086 | {"actor":{"display_login":"patrykkopycinski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/comments/135829108","pull_request_review_id":59284142,"id":135829108,"diff_hunk":"@@ -0,0 +1,50 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Reflection;\n+using NServiceBus.AcceptanceTesting.Support;\n+using NServiceBus.Hosting.Helpers;\n+\n+public static class EndpointCustomizationConfigurationExtensions\n+{\n+ public static IEnumerable<Type> GetTypesScopedByTestClass(this EndpointCustomizationConfiguration endpointConfiguration)\n+ {\n+ var assemblies = new AssemblyScanner().GetScannableAssemblies();\n+\n+ var types = assemblies.Assemblies\n+ //exclude all test types by default\n+ .Where(a =>\n+ {\n+ var references = a.GetReferencedAssemblies();\n+\n+ return references.All(an => an.Name != \"nunit.framework\");","path":"src/NServiceBus.Wcf.AcceptanceTests/EndpointCustomizationConfigurationExtensions.cs","position":20,"original_position":20,"commit_id":"6fefadd78d1aa5249525c72f838ede5aaa5c5643","original_commit_id":"6fefadd78d1aa5249525c72f838ede5aaa5c5643","user":{"login":"timbussmann","id":3524870,"avatar_url":"https://avatars1.githubusercontent.com/u/3524870?v=4","gravatar_id":"","url":"https://api.github.com/users/timbussmann","html_url":"https://github.com/timbussmann","followers_url":"https://api.github.com/users/timbussmann/followers","following_url":"https://api.github.com/users/timbussmann/following{/other_user}","gists_url":"https://api.github.com/users/timbussmann/gists{/gist_id}","starred_url":"https://api.github.com/users/timbussmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timbussmann/subscriptions","organizations_url":"https://api.github.com/users/timbussmann/orgs","repos_url":"https://api.github.com/users/timbussmann/repos","events_url":"https://api.github.com/users/timbussmann/events{/privacy}","received_events_url":"https://api.github.com/users/timbussmann/received_events","type":"User","site_admin":false},"body":"that should no longer be filtered that way as it excludes the testing library now (as it references Nunit). ","created_at":"2017-08-29T15:38:52Z","updated_at":"2017-08-29T16:00:18Z","html_url":"https://github.com/Particular/NServiceBus.Wcf/pull/6#discussion_r135829108","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/comments/135829108"},"html":{"href":"https://github.com/Particular/NServiceBus.Wcf/pull/6#discussion_r135829108"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/6","id":138078086,"html_url":"https://github.com/Particular/NServiceBus.Wcf/pull/6","diff_url":"https://github.com/Particular/NServiceBus.Wcf/pull/6.diff","patch_url":"https://github.com/Particular/NServiceBus.Wcf/pull/6.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues/6","number":6,"state":"open","locked":false,"title":"update to NSB v7","user":{"login":"SimonCropp","id":122666,"avatar_url":"https://avatars1.githubusercontent.com/u/122666?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonCropp","html_url":"https://github.com/SimonCropp","followers_url":"https://api.github.com/users/SimonCropp/followers","following_url":"https://api.github.com/users/SimonCropp/following{/other_user}","gists_url":"https://api.github.com/users/SimonCropp/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonCropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonCropp/subscriptions","organizations_url":"https://api.github.com/users/SimonCropp/orgs","repos_url":"https://api.github.com/users/SimonCropp/repos","events_url":"https://api.github.com/users/SimonCropp/events{/privacy}","received_events_url":"https://api.github.com/users/SimonCropp/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-29T02:32:09Z","updated_at":"2017-08-29T16:00:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca1294dc64d9314ffc8b62950845cd2c00d6d4b1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues/6/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/statuses/6fefadd78d1aa5249525c72f838ede5aaa5c5643","head":{"label":"Particular:NsbV7","ref":"NsbV7","sha":"6fefadd78d1aa5249525c72f838ede5aaa5c5643","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":68010723,"name":"NServiceBus.Wcf","full_name":"Particular/NServiceBus.Wcf","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.Wcf","description":null,"fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.Wcf","forks_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/deployments","created_at":"2016-09-12T13:20:06Z","updated_at":"2017-06-26T05:27:22Z","pushed_at":"2017-08-29T02:32:09Z","git_url":"git://github.com/Particular/NServiceBus.Wcf.git","ssh_url":"[email protected]:Particular/NServiceBus.Wcf.git","clone_url":"https://github.com/Particular/NServiceBus.Wcf.git","svn_url":"https://github.com/Particular/NServiceBus.Wcf","homepage":"https://docs.particular.net/nservicebus/wcf/","size":73,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"a90bd987b65eb6b91945333c17a49b24722962e2","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":68010723,"name":"NServiceBus.Wcf","full_name":"Particular/NServiceBus.Wcf","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.Wcf","description":null,"fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.Wcf","forks_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.Wcf/deployments","created_at":"2016-09-12T13:20:06Z","updated_at":"2017-06-26T05:27:22Z","pushed_at":"2017-08-29T02:32:09Z","git_url":"git://github.com/Particular/NServiceBus.Wcf.git","ssh_url":"[email protected]:Particular/NServiceBus.Wcf.git","clone_url":"https://github.com/Particular/NServiceBus.Wcf.git","svn_url":"https://github.com/Particular/NServiceBus.Wcf","homepage":"https://docs.particular.net/nservicebus/wcf/","size":73,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/6"},"html":{"href":"https://github.com/Particular/NServiceBus.Wcf/pull/6"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues/6"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.Wcf/statuses/6fefadd78d1aa5249525c72f838ede5aaa5c5643"}}}} | {
"id": 68010723,
"name": "Particular/NServiceBus.Wcf",
"url": "https://api.github.com/repos/Particular/NServiceBus.Wcf"
} | {
"id": 3524870,
"login": "timbussmann",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3524870?",
"url": "https://api.github.com/users/timbussmann"
} | {
"id": 5038441,
"login": "Particular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5038441?",
"url": "https://api.github.com/orgs/Particular"
} | 2017-08-29T15:38:52 | 6525473350 | {"actor":{"display_login":"timbussmann"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/comments/127133068","pull_request_review_id":49684260,"id":127133068,"diff_hunk":"@@ -0,0 +1,50 @@\n+namespace ServiceControl.Monitoring.Timings\n+{\n+ using System;\n+ using System.Threading.Tasks;\n+ using Metrics.Raw;\n+ using Metrics.Snapshot;\n+ using NServiceBus;\n+\n+ class TimingsReportHandler : IHandleMessages<LongValueOccurrences>\n+ {\n+ readonly TimingsStore processingTimeStore;\n+ readonly CriticalTimeStore criticalTimeStore;\n+\n+ const string ProcessingTimeMessageType = \"NServiceBus.Metrics.ProcessingTime\";\n+ const string CriticalTimeMessageType = \"NServiceBus.Metrics.CriticalTime\";\n+\n+ public TimingsReportHandler(ProcessingTimeStore processingTimeStore, CriticalTimeStore criticalTimeStore)\n+ {\n+ this.processingTimeStore = processingTimeStore;\n+ this.criticalTimeStore = criticalTimeStore;\n+ }\n+\n+ public Task Handle(LongValueOccurrences message, IMessageHandlerContext context)\n+ {\n+ var messageType = context.MessageHeaders[Headers.EnclosedMessageTypes];\n+ var endpointName = context.MessageHeaders.GetOriginatingEndpoint();\n+\n+ switch (messageType)\n+ {\n+ case ProcessingTimeMessageType:\n+ processingTimeStore.Store(endpointName, message, DateTime.UtcNow);\n+ break;\n+ case CriticalTimeMessageType:\n+ criticalTimeStore.Store(endpointName, message, DateTime.UtcNow);\n+ break;\n+ default:\n+ throw new UnknownLongValueOccurrenceMessageType(messageType);\n+\n+ }\n+ if (messageType == ProcessingTimeMessageType)","path":"src/ServiceControl.Monitoring/Timings/LongValueOccurrenceHandler.cs","position":40,"original_position":40,"commit_id":"820a04b8d189c71d380dfe99304e82cac3b697c2","original_commit_id":"820a04b8d189c71d380dfe99304e82cac3b697c2","user":{"login":"mikeminutillo","id":124014,"avatar_url":"https://avatars3.githubusercontent.com/u/124014?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeminutillo","html_url":"https://github.com/mikeminutillo","followers_url":"https://api.github.com/users/mikeminutillo/followers","following_url":"https://api.github.com/users/mikeminutillo/following{/other_user}","gists_url":"https://api.github.com/users/mikeminutillo/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeminutillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeminutillo/subscriptions","organizations_url":"https://api.github.com/users/mikeminutillo/orgs","repos_url":"https://api.github.com/users/mikeminutillo/repos","events_url":"https://api.github.com/users/mikeminutillo/events{/privacy}","received_events_url":"https://api.github.com/users/mikeminutillo/received_events","type":"User","site_admin":false},"body":"I presume this can just be deleted","created_at":"2017-07-13T05:50:25Z","updated_at":"2017-07-13T06:00:02Z","html_url":"https://github.com/Particular/ServiceControl.Monitoring/pull/21#discussion_r127133068","pull_request_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/comments/127133068"},"html":{"href":"https://github.com/Particular/ServiceControl.Monitoring/pull/21#discussion_r127133068"},"pull_request":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/21","id":124615698,"html_url":"https://github.com/Particular/ServiceControl.Monitoring/pull/21","diff_url":"https://github.com/Particular/ServiceControl.Monitoring/pull/21.diff","patch_url":"https://github.com/Particular/ServiceControl.Monitoring/pull/21.patch","issue_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/21","number":21,"state":"open","locked":false,"title":"Timing Data Aggregation and API for SP Endpoint Overview Page","user":{"login":"WojcikMike","id":604826,"avatar_url":"https://avatars1.githubusercontent.com/u/604826?v=3","gravatar_id":"","url":"https://api.github.com/users/WojcikMike","html_url":"https://github.com/WojcikMike","followers_url":"https://api.github.com/users/WojcikMike/followers","following_url":"https://api.github.com/users/WojcikMike/following{/other_user}","gists_url":"https://api.github.com/users/WojcikMike/gists{/gist_id}","starred_url":"https://api.github.com/users/WojcikMike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojcikMike/subscriptions","organizations_url":"https://api.github.com/users/WojcikMike/orgs","repos_url":"https://api.github.com/users/WojcikMike/repos","events_url":"https://api.github.com/users/WojcikMike/events{/privacy}","received_events_url":"https://api.github.com/users/WojcikMike/received_events","type":"User","site_admin":false},"body":"Connects to Particular/LaunchWave.DevOpsAdvancedMonitoring#52\r\n\r\n### Description\r\nThis PR is adding storage of historical data (last 5 min) for ProcessingTime and CriticalTime metrics. In particular it introduces\r\n * Deserializer for `LongValueOccurence` content type \r\n * API module to enable querying for that data `DiagramsApiModule`\r\n * For each logical endpoint it stores metrics data in 15s intervals\r\n * It removes `IDataProvider`, `IDataConsumer` interfaces as those can replaced with multiple NSB handlers for the same message type e.g. `MetricsReport`","created_at":"2017-06-08T10:20:51Z","updated_at":"2017-07-13T06:00:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b726b7f93454011f6b7d3a391caa7edd73d63bd6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/21/comments","statuses_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/statuses/820a04b8d189c71d380dfe99304e82cac3b697c2","head":{"label":"Particular:tf-metrics-wave-diagram-api","ref":"tf-metrics-wave-diagram-api","sha":"820a04b8d189c71d380dfe99304e82cac3b697c2","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars3.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":87170155,"name":"ServiceControl.Monitoring","full_name":"Particular/ServiceControl.Monitoring","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars3.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl.Monitoring","description":"A standalone service gathering metrics from endpoints and providing them with an http endpoint","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring","forks_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/deployments","created_at":"2017-04-04T09:42:31Z","updated_at":"2017-06-26T05:25:39Z","pushed_at":"2017-07-12T14:46:13Z","git_url":"git://github.com/Particular/ServiceControl.Monitoring.git","ssh_url":"[email protected]:Particular/ServiceControl.Monitoring.git","clone_url":"https://github.com/Particular/ServiceControl.Monitoring.git","svn_url":"https://github.com/Particular/ServiceControl.Monitoring","homepage":null,"size":743,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"develop"}},"base":{"label":"Particular:tf-metrics-wave","ref":"tf-metrics-wave","sha":"584a8ce35ac3957aa08151097673f886cadc7950","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars3.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":87170155,"name":"ServiceControl.Monitoring","full_name":"Particular/ServiceControl.Monitoring","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars3.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl.Monitoring","description":"A standalone service gathering metrics from endpoints and providing them with an http endpoint","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring","forks_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/deployments","created_at":"2017-04-04T09:42:31Z","updated_at":"2017-06-26T05:25:39Z","pushed_at":"2017-07-12T14:46:13Z","git_url":"git://github.com/Particular/ServiceControl.Monitoring.git","ssh_url":"[email protected]:Particular/ServiceControl.Monitoring.git","clone_url":"https://github.com/Particular/ServiceControl.Monitoring.git","svn_url":"https://github.com/Particular/ServiceControl.Monitoring","homepage":null,"size":743,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/21"},"html":{"href":"https://github.com/Particular/ServiceControl.Monitoring/pull/21"},"issue":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/21"},"comments":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/statuses/820a04b8d189c71d380dfe99304e82cac3b697c2"}}}} | {
"id": 87170155,
"name": "Particular/ServiceControl.Monitoring",
"url": "https://api.github.com/repos/Particular/ServiceControl.Monitoring"
} | {
"id": 124014,
"login": "mikeminutillo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/124014?",
"url": "https://api.github.com/users/mikeminutillo"
} | {
"id": 5038441,
"login": "Particular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5038441?",
"url": "https://api.github.com/orgs/Particular"
} | 2017-07-13T05:50:25 | 6246794904 | {"actor":{"display_login":"mikeminutillo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/comments/99131096","pull_request_review_id":19796465,"id":99131096,"diff_hunk":"@@ -1,29 +1,14 @@\n <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n <manifest>\n \n+ <include name=\"pelux-base.xml\"/>\n+\n <!-- Settings -->\n <default sync-j=\"4\" revision=\"krogoth\" />\n \n- <!-- Remotes -->\n- <remote fetch=\"git://git.openembedded.org\" name=\"oe\"/>\n- <remote fetch=\"git://git.yoctoproject.org\" name=\"yocto\"/>\n- <remote fetch=\"git://github.com/\" name=\"github\"/>\n-\n- <!-- Base stuff -->\n- <project remote=\"oe\" revision=\"krogoth\" name=\"meta-openembedded\" path=\"sources/meta-openembedded\"/>\n- <project remote=\"yocto\" revision=\"krogoth\" name=\"poky\" path=\"sources/poky\"/>\n- <project remote=\"github\" revision=\"master\" name=\"Pelagicore/meta-bistro\" path=\"sources/meta-bistro\" />\n- <project remote=\"yocto\" revision=\"krogoth\" name=\"meta-virtualization\" path=\"sources/meta-virtualization\"/>\n-\n <!-- Target stuff -->\n- <project remote=\"yocto\" revision=\"krogoth\" name=\"meta-intel\" path=\"sources/meta-intel\"/>\n+ <project remote=\"yocto\" revision=\"krogoth\" name=\"meta-intel\" path=\"sources/meta-intel\"/>\n <project remote=\"github\" revision=\"master\" name=\"Pelagicore/meta-pelux-bsp-intel\" path=\"sources/meta-pelux-bsp-intel\" />\n <project remote=\"github\" revision=\"master\" name=\"Pelagicore/meta-pelux\" path=\"sources/meta-pelux\" />","path":"pelux-intel.xml","position":24,"original_position":24,"commit_id":"abc571e227f179ece6d0683871d59dedd8cf2beb","original_commit_id":"abc571e227f179ece6d0683871d59dedd8cf2beb","user":{"login":"DunderRoffe","id":5956077,"avatar_url":"https://avatars.githubusercontent.com/u/5956077?v=3","gravatar_id":"","url":"https://api.github.com/users/DunderRoffe","html_url":"https://github.com/DunderRoffe","followers_url":"https://api.github.com/users/DunderRoffe/followers","following_url":"https://api.github.com/users/DunderRoffe/following{/other_user}","gists_url":"https://api.github.com/users/DunderRoffe/gists{/gist_id}","starred_url":"https://api.github.com/users/DunderRoffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DunderRoffe/subscriptions","organizations_url":"https://api.github.com/users/DunderRoffe/orgs","repos_url":"https://api.github.com/users/DunderRoffe/repos","events_url":"https://api.github.com/users/DunderRoffe/events{/privacy}","received_events_url":"https://api.github.com/users/DunderRoffe/received_events","type":"User","site_admin":false},"body":"Yes you are right. My bad","created_at":"2017-02-02T14:34:34Z","updated_at":"2017-02-02T14:34:34Z","html_url":"https://github.com/Pelagicore/pelux-manifests/pull/6#discussion_r99131096","pull_request_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/comments/99131096"},"html":{"href":"https://github.com/Pelagicore/pelux-manifests/pull/6#discussion_r99131096"},"pull_request":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/6","id":104289380,"html_url":"https://github.com/Pelagicore/pelux-manifests/pull/6","diff_url":"https://github.com/Pelagicore/pelux-manifests/pull/6.diff","patch_url":"https://github.com/Pelagicore/pelux-manifests/pull/6.patch","issue_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/6","number":6,"state":"open","locked":false,"title":"Refactor manifests into base and bsp","user":{"login":"DunderRoffe","id":5956077,"avatar_url":"https://avatars.githubusercontent.com/u/5956077?v=3","gravatar_id":"","url":"https://api.github.com/users/DunderRoffe","html_url":"https://github.com/DunderRoffe","followers_url":"https://api.github.com/users/DunderRoffe/followers","following_url":"https://api.github.com/users/DunderRoffe/following{/other_user}","gists_url":"https://api.github.com/users/DunderRoffe/gists{/gist_id}","starred_url":"https://api.github.com/users/DunderRoffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DunderRoffe/subscriptions","organizations_url":"https://api.github.com/users/DunderRoffe/orgs","repos_url":"https://api.github.com/users/DunderRoffe/repos","events_url":"https://api.github.com/users/DunderRoffe/events{/privacy}","received_events_url":"https://api.github.com/users/DunderRoffe/received_events","type":"User","site_admin":false},"body":"Separate pelux-intel.xml into pelux-base.xml and pelux-intel.xml. Where\r\n\"pelux-base.xml\" speicifies things that will be included in every pelux build\r\nand \"pelux-intel.xml\" includes \"pelux-base.xml\" and adds bsp specifics.\r\n\r\nSigned-off-by: Viktor Sjölind <[email protected]>","created_at":"2017-02-02T07:52:16Z","updated_at":"2017-02-02T14:34:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"845681b9815373628020fc0648a9938384b0e84e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/6/comments","statuses_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/statuses/abc571e227f179ece6d0683871d59dedd8cf2beb","head":{"label":"DunderRoffe:refactorManifests","ref":"refactorManifests","sha":"abc571e227f179ece6d0683871d59dedd8cf2beb","user":{"login":"DunderRoffe","id":5956077,"avatar_url":"https://avatars.githubusercontent.com/u/5956077?v=3","gravatar_id":"","url":"https://api.github.com/users/DunderRoffe","html_url":"https://github.com/DunderRoffe","followers_url":"https://api.github.com/users/DunderRoffe/followers","following_url":"https://api.github.com/users/DunderRoffe/following{/other_user}","gists_url":"https://api.github.com/users/DunderRoffe/gists{/gist_id}","starred_url":"https://api.github.com/users/DunderRoffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DunderRoffe/subscriptions","organizations_url":"https://api.github.com/users/DunderRoffe/orgs","repos_url":"https://api.github.com/users/DunderRoffe/repos","events_url":"https://api.github.com/users/DunderRoffe/events{/privacy}","received_events_url":"https://api.github.com/users/DunderRoffe/received_events","type":"User","site_admin":false},"repo":{"id":76356740,"name":"pelux-manifests","full_name":"DunderRoffe/pelux-manifests","owner":{"login":"DunderRoffe","id":5956077,"avatar_url":"https://avatars.githubusercontent.com/u/5956077?v=3","gravatar_id":"","url":"https://api.github.com/users/DunderRoffe","html_url":"https://github.com/DunderRoffe","followers_url":"https://api.github.com/users/DunderRoffe/followers","following_url":"https://api.github.com/users/DunderRoffe/following{/other_user}","gists_url":"https://api.github.com/users/DunderRoffe/gists{/gist_id}","starred_url":"https://api.github.com/users/DunderRoffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DunderRoffe/subscriptions","organizations_url":"https://api.github.com/users/DunderRoffe/orgs","repos_url":"https://api.github.com/users/DunderRoffe/repos","events_url":"https://api.github.com/users/DunderRoffe/events{/privacy}","received_events_url":"https://api.github.com/users/DunderRoffe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DunderRoffe/pelux-manifests","description":null,"fork":true,"url":"https://api.github.com/repos/DunderRoffe/pelux-manifests","forks_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/forks","keys_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/teams","hooks_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/hooks","issue_events_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/issues/events{/number}","events_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/events","assignees_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/assignees{/user}","branches_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/branches{/branch}","tags_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/tags","blobs_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/git/refs{/sha}","trees_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/statuses/{sha}","languages_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/languages","stargazers_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/stargazers","contributors_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/contributors","subscribers_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/subscribers","subscription_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/subscription","commits_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/commits{/sha}","git_commits_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/git/commits{/sha}","comments_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/comments{/number}","issue_comment_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/issues/comments{/number}","contents_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/contents/{+path}","compare_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/merges","archive_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/downloads","issues_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/issues{/number}","pulls_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/pulls{/number}","milestones_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/milestones{/number}","notifications_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/labels{/name}","releases_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/releases{/id}","deployments_url":"https://api.github.com/repos/DunderRoffe/pelux-manifests/deployments","created_at":"2016-12-13T12:28:09Z","updated_at":"2016-12-09T14:19:46Z","pushed_at":"2017-02-02T10:01:07Z","git_url":"git://github.com/DunderRoffe/pelux-manifests.git","ssh_url":"[email protected]:DunderRoffe/pelux-manifests.git","clone_url":"https://github.com/DunderRoffe/pelux-manifests.git","svn_url":"https://github.com/DunderRoffe/pelux-manifests","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Pelagicore:master","ref":"master","sha":"e61f8288caf27adb3b1b63f20155bef494acaa0b","user":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars.githubusercontent.com/u/4661080?v=3","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"repo":{"id":76041595,"name":"pelux-manifests","full_name":"Pelagicore/pelux-manifests","owner":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars.githubusercontent.com/u/4661080?v=3","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pelagicore/pelux-manifests","description":null,"fork":false,"url":"https://api.github.com/repos/Pelagicore/pelux-manifests","forks_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/forks","keys_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/teams","hooks_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/hooks","issue_events_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/events{/number}","events_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/events","assignees_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/assignees{/user}","branches_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/branches{/branch}","tags_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/tags","blobs_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/statuses/{sha}","languages_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/languages","stargazers_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/stargazers","contributors_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/contributors","subscribers_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/subscribers","subscription_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/subscription","commits_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/contents/{+path}","compare_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/merges","archive_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/downloads","issues_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues{/number}","pulls_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls{/number}","milestones_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/milestones{/number}","notifications_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/labels{/name}","releases_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/releases{/id}","deployments_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/deployments","created_at":"2016-12-09T14:19:46Z","updated_at":"2016-12-13T12:36:11Z","pushed_at":"2017-02-02T10:01:08Z","git_url":"git://github.com/Pelagicore/pelux-manifests.git","ssh_url":"[email protected]:Pelagicore/pelux-manifests.git","clone_url":"https://github.com/Pelagicore/pelux-manifests.git","svn_url":"https://github.com/Pelagicore/pelux-manifests","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/6"},"html":{"href":"https://github.com/Pelagicore/pelux-manifests/pull/6"},"issue":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/6"},"comments":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/statuses/abc571e227f179ece6d0683871d59dedd8cf2beb"}}}} | {
"id": 76041595,
"name": "Pelagicore/pelux-manifests",
"url": "https://api.github.com/repos/Pelagicore/pelux-manifests"
} | {
"id": 5956077,
"login": "DunderRoffe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5956077?",
"url": "https://api.github.com/users/DunderRoffe"
} | {
"id": 4661080,
"login": "Pelagicore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4661080?",
"url": "https://api.github.com/orgs/Pelagicore"
} | 2017-02-02T14:34:34 | 5255017030 | {"actor":{"display_login":"DunderRoffe"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/106776983","pull_request_review_id":27720376,"id":106776983,"diff_hunk":"@@ -27,4 +27,13 @@ Describe \"Tab completion bug fix\" -Tags \"CI\" {\n $result.CompletionMatches.Count | Should Be 1\n $result.CompletionMatches[0].CompletionText | Should Be \"pscustomobject\"\n }\n+ It \"Issue#1345 - 'Import-Module -n<tab>' should work\" {\n+ $cmd = \"Import-Module -n\"\n+ $result = TabExpansion2 -inputScript $cmd -cursorColumn $cmd.Length\n+ $result | Should Not BeNullOrEmpty","path":"test/powershell/Host/TabCompletion/BugFix.Tests.ps1","position":7,"original_position":7,"commit_id":"bb1b9064ccc6d88e702d653bf81391be3f9d2da6","original_commit_id":"bb1b9064ccc6d88e702d653bf81391be3f9d2da6","user":{"login":"iSazonov","id":22290914,"avatar_url":"https://avatars1.githubusercontent.com/u/22290914?v=3","gravatar_id":"","url":"https://api.github.com/users/iSazonov","html_url":"https://github.com/iSazonov","followers_url":"https://api.github.com/users/iSazonov/followers","following_url":"https://api.github.com/users/iSazonov/following{/other_user}","gists_url":"https://api.github.com/users/iSazonov/gists{/gist_id}","starred_url":"https://api.github.com/users/iSazonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSazonov/subscriptions","organizations_url":"https://api.github.com/users/iSazonov/orgs","repos_url":"https://api.github.com/users/iSazonov/repos","events_url":"https://api.github.com/users/iSazonov/events{/privacy}","received_events_url":"https://api.github.com/users/iSazonov/received_events","type":"User","site_admin":false},"body":"If below we check `count` we should remove the line.","created_at":"2017-03-18T09:05:07Z","updated_at":"2017-03-18T09:05:07Z","html_url":"https://github.com/PowerShell/PowerShell/pull/3364#discussion_r106776983","pull_request_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3364","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/106776983"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/3364#discussion_r106776983"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3364"}}},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3364","id":111386401,"html_url":"https://github.com/PowerShell/PowerShell/pull/3364","diff_url":"https://github.com/PowerShell/PowerShell/pull/3364.diff","patch_url":"https://github.com/PowerShell/PowerShell/pull/3364.patch","issue_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/3364","number":3364,"state":"open","locked":false,"title":"tab expansion not working correctly for some parameters","user":{"login":"SteveL-MSFT","id":11859881,"avatar_url":"https://avatars2.githubusercontent.com/u/11859881?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveL-MSFT","html_url":"https://github.com/SteveL-MSFT","followers_url":"https://api.github.com/users/SteveL-MSFT/followers","following_url":"https://api.github.com/users/SteveL-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/SteveL-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveL-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveL-MSFT/subscriptions","organizations_url":"https://api.github.com/users/SteveL-MSFT/orgs","repos_url":"https://api.github.com/users/SteveL-MSFT/repos","events_url":"https://api.github.com/users/SteveL-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/SteveL-MSFT/received_events","type":"User","site_admin":false},"body":"code was indexing outside of it's range for the last element causing an exception which fails the whole discovery operation\r\n\r\naddresses #1345 \r\n\r\nneed some pointers on how to add a test for this","created_at":"2017-03-18T00:07:45Z","updated_at":"2017-03-18T09:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cad61269bc2631c2826d627b3e8de531e18e30f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3364/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3364/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/3364/comments","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/bb1b9064ccc6d88e702d653bf81391be3f9d2da6","head":{"label":"SteveL-MSFT:tabcomplete","ref":"tabcomplete","sha":"bb1b9064ccc6d88e702d653bf81391be3f9d2da6","user":{"login":"SteveL-MSFT","id":11859881,"avatar_url":"https://avatars2.githubusercontent.com/u/11859881?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveL-MSFT","html_url":"https://github.com/SteveL-MSFT","followers_url":"https://api.github.com/users/SteveL-MSFT/followers","following_url":"https://api.github.com/users/SteveL-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/SteveL-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveL-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveL-MSFT/subscriptions","organizations_url":"https://api.github.com/users/SteveL-MSFT/orgs","repos_url":"https://api.github.com/users/SteveL-MSFT/repos","events_url":"https://api.github.com/users/SteveL-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/SteveL-MSFT/received_events","type":"User","site_admin":false},"repo":{"id":80881740,"name":"PowerShell","full_name":"SteveL-MSFT/PowerShell","owner":{"login":"SteveL-MSFT","id":11859881,"avatar_url":"https://avatars2.githubusercontent.com/u/11859881?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveL-MSFT","html_url":"https://github.com/SteveL-MSFT","followers_url":"https://api.github.com/users/SteveL-MSFT/followers","following_url":"https://api.github.com/users/SteveL-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/SteveL-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveL-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveL-MSFT/subscriptions","organizations_url":"https://api.github.com/users/SteveL-MSFT/orgs","repos_url":"https://api.github.com/users/SteveL-MSFT/repos","events_url":"https://api.github.com/users/SteveL-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/SteveL-MSFT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SteveL-MSFT/PowerShell","description":"PowerShell for every system!","fork":true,"url":"https://api.github.com/repos/SteveL-MSFT/PowerShell","forks_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/forks","keys_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/teams","hooks_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/events","assignees_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/tags","blobs_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/languages","stargazers_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/subscription","commits_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/merges","archive_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/downloads","issues_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/SteveL-MSFT/PowerShell/deployments","created_at":"2017-02-04T00:41:57Z","updated_at":"2017-02-04T00:42:07Z","pushed_at":"2017-03-18T04:43:54Z","git_url":"git://github.com/SteveL-MSFT/PowerShell.git","ssh_url":"[email protected]:SteveL-MSFT/PowerShell.git","clone_url":"https://github.com/SteveL-MSFT/PowerShell.git","svn_url":"https://github.com/SteveL-MSFT/PowerShell","homepage":"https://microsoft.com/powershell","size":24230,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"bbba61c1f5ae1250bdfb8ecf0bc8e6dc5230be6f","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars0.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":49609581,"name":"PowerShell","full_name":"PowerShell/PowerShell","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars0.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/PowerShell","description":"PowerShell for every system!","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShell","forks_url":"https://api.github.com/repos/PowerShell/PowerShell/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShell/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShell/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShell/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShell/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShell/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShell/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShell/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShell/deployments","created_at":"2016-01-13T23:41:35Z","updated_at":"2017-03-18T06:31:50Z","pushed_at":"2017-03-18T04:43:56Z","git_url":"git://github.com/PowerShell/PowerShell.git","ssh_url":"[email protected]:PowerShell/PowerShell.git","clone_url":"https://github.com/PowerShell/PowerShell.git","svn_url":"https://github.com/PowerShell/PowerShell","homepage":"https://microsoft.com/powershell","size":25175,"stargazers_count":6448,"watchers_count":6448,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":804,"mirror_url":null,"open_issues_count":659,"forks":804,"open_issues":659,"watchers":6448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3364"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/3364"},"issue":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/3364"},"comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/3364/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3364/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3364/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PowerShell/statuses/bb1b9064ccc6d88e702d653bf81391be3f9d2da6"}}}} | {
"id": 49609581,
"name": "PowerShell/PowerShell",
"url": "https://api.github.com/repos/PowerShell/PowerShell"
} | {
"id": 22290914,
"login": "iSazonov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22290914?",
"url": "https://api.github.com/users/iSazonov"
} | {
"id": 11524380,
"login": "PowerShell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11524380?",
"url": "https://api.github.com/orgs/PowerShell"
} | 2017-03-18T09:05:07 | 5518426880 | {"actor":{"display_login":"iSazonov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SquareHook/2Mean/pulls/comments/98741676","pull_request_review_id":19389041,"id":98741676,"diff_hunk":"@@ -31,191 +47,255 @@ function roleModule(logger, userModule) {\n \n \n /*\n- * Roles can be added to the role tree at any level other than root.\n- * When a role is added, the tree is traversed, and for each 'parent'\n- * the role has, any users with role equal to that parent role will \n- * get the new role in their subroles array.\n- * \n- * @param {req} The Express HTTP request with the role in the body\n- * @param {res} The Express HTTP response object\n- * @param {next} The Express HTTP next function\n- *\n- * @return {bool} whether or not the role was added\n- */\n- function addRole(req, res, next) \n+ * Roles can be added to the role tree at any level other than root.\n+ * When a role is added, the tree is traversed, and for each 'parent'\n+ * the role has, any users with role equal to that parent role will \n+ * get the new role in their subroles array.\n+ * \n+ * @param {req} The Express HTTP request with the role in the body\n+ * @param {res} The Express HTTP response object\n+ * @param {next} The Express HTTP next function\n+ *\n+ * @return {bool} whether or not the role was added\n+ */\n+ function addRole(req, res, next)\n {\n- var role = req.body;\n- //make sure the role is valid\n- if(role._id != null)\n+ //validation check\n+ if (!req.body._id || !req.body.parent)\n {\n- var addedRole = new Roles();\n- addedRole._id = role._id;\n- addedRole.parent = role.parent || null;\n- role.canModify = role.canModify || false;\n- role.parentForDescendants = role.parentForDescendants || [];\n-\n- //check to make sure the parent exists\n- if(addedRole.parent === null || !roleExists(addedRole.parent))\n- {\n- res.status(500).send(\"Parent must be a valid role\");\n- return;\n- }\n-\n-\n- //save will fail if _id isn't unique\n- addedRole.save((err, data) => {\n- if(err)\n+ return sendServerError(res, \"required role fields not set\");\n+ }\n+ //map request body params to a role\n+ var role = new Roles();\n+ role._id = req.body._id;\n+ role.parent = req.body.parent;\n+ role.canModify = req.body.canModify || false;\n+ role.parentForDescendants = req.body.parentForDescendants || [];\n+\n+ \n+ Roles.count({_id: req.body.parent}).exec()\n+ .then( count =>\n+ {\n+ if(count < 1)\n {\n- res.status(500).send(\"There is already a role with that name\");\n- return;\n+ return new Promise((resolve, reject) =>\n+ {\n+ reject(\"parent not found\");\n+ });\n }\n else\n {\n- //the role was inserted into the roles collection\n- //now we need to update the parent of the direct descendants\n- //if there are any\n- if(role.parentForDescendants && role.parentForDescendants.length > 0)\n- {\n- //in this case we are inserting a role above one or more existing roles\n- _.forEach(role.parentForDescendants, function(node)\n- {\n- //we set that descendant's parent to this role._id\n- updateParentForRole(node, role._id);\n- });\n- }\n+ return new Promise((resolve, reject) => {\n+ resolve(\"ok\");\n+ });\n+ }\n+ })\n+ .then(ok => {\n+ return role.save();\n+ })\n+ .then(data =>\n+ {\n+ return updateDirectDescendants(role);\n+ })\n+ .then(ok =>\n+ {\n+ return getAllRoles();\n+ })\n+ .then(data =>\n+ {\n+ return updateSubroles(data, role)\n+ })\n+ .then(data =>\n+ {\n+ res.status(201).send(\n+ {\n+ success: true,\n+ data: data\n+ });\n+ })\n+ .catch(error =>\n+ {\n+ sendServerError(res, error);\n+ })\n+ }\n \n- Roles.find({}).then((data) => {\n+ function updateDirectDescendants(role)\n+ {\n+ //in this case we are inserting a role above one or more existing roles\n+ //update the parent of any direct descendants\n+ return new Promise((resolve, reject) =>","path":"modules/roles/server/controllers/roles.controller.js","position":182,"original_position":182,"commit_id":"8be641402d0b4df807ef0a1b4fb8a7ee83074178","original_commit_id":"8be641402d0b4df807ef0a1b4fb8a7ee83074178","user":{"login":"JasonSHD","id":16883874,"avatar_url":"https://avatars.githubusercontent.com/u/16883874?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonSHD","html_url":"https://github.com/JasonSHD","followers_url":"https://api.github.com/users/JasonSHD/followers","following_url":"https://api.github.com/users/JasonSHD/following{/other_user}","gists_url":"https://api.github.com/users/JasonSHD/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonSHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonSHD/subscriptions","organizations_url":"https://api.github.com/users/JasonSHD/orgs","repos_url":"https://api.github.com/users/JasonSHD/repos","events_url":"https://api.github.com/users/JasonSHD/events{/privacy}","received_events_url":"https://api.github.com/users/JasonSHD/received_events","type":"User","site_admin":false},"body":"Same as above.","created_at":"2017-01-31T18:51:06Z","updated_at":"2017-01-31T18:54:32Z","html_url":"https://github.com/SquareHook/2Mean/pull/62#discussion_r98741676","pull_request_url":"https://api.github.com/repos/SquareHook/2Mean/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/SquareHook/2Mean/pulls/comments/98741676"},"html":{"href":"https://github.com/SquareHook/2Mean/pull/62#discussion_r98741676"},"pull_request":{"href":"https://api.github.com/repos/SquareHook/2Mean/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/SquareHook/2Mean/pulls/62","id":103788275,"html_url":"https://github.com/SquareHook/2Mean/pull/62","diff_url":"https://github.com/SquareHook/2Mean/pull/62.diff","patch_url":"https://github.com/SquareHook/2Mean/pull/62.patch","issue_url":"https://api.github.com/repos/SquareHook/2Mean/issues/62","number":62,"state":"open","locked":false,"title":"Advanced Roles","user":{"login":"hshelton","id":6633378,"avatar_url":"https://avatars.githubusercontent.com/u/6633378?v=3","gravatar_id":"","url":"https://api.github.com/users/hshelton","html_url":"https://github.com/hshelton","followers_url":"https://api.github.com/users/hshelton/followers","following_url":"https://api.github.com/users/hshelton/following{/other_user}","gists_url":"https://api.github.com/users/hshelton/gists{/gist_id}","starred_url":"https://api.github.com/users/hshelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshelton/subscriptions","organizations_url":"https://api.github.com/users/hshelton/orgs","repos_url":"https://api.github.com/users/hshelton/repos","events_url":"https://api.github.com/users/hshelton/events{/privacy}","received_events_url":"https://api.github.com/users/hshelton/received_events","type":"User","site_admin":false},"body":"The server side roles controller is pretty much done. I focused on getting the add role method to work and the role tree.\r\n\r\nTo test go to ~/roles/new. You can add roles to an existing parent like Then you can view the roles tree by going to ~/api/roles/tree, or if you want to see the role tree from a certain node down ~/roles/tree/[targetRoot]\r\n\r\nBetter client side validation is on my to do list.\r\nFlushing out new subroles to users was working but needs debugging.","created_at":"2017-01-30T18:02:05Z","updated_at":"2017-01-31T18:54:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"938631fdf810f5a4267f2fe630de3408074c015f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SquareHook/2Mean/pulls/62/commits","review_comments_url":"https://api.github.com/repos/SquareHook/2Mean/pulls/62/comments","review_comment_url":"https://api.github.com/repos/SquareHook/2Mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SquareHook/2Mean/issues/62/comments","statuses_url":"https://api.github.com/repos/SquareHook/2Mean/statuses/8be641402d0b4df807ef0a1b4fb8a7ee83074178","head":{"label":"hshelton:roles","ref":"roles","sha":"8be641402d0b4df807ef0a1b4fb8a7ee83074178","user":{"login":"hshelton","id":6633378,"avatar_url":"https://avatars.githubusercontent.com/u/6633378?v=3","gravatar_id":"","url":"https://api.github.com/users/hshelton","html_url":"https://github.com/hshelton","followers_url":"https://api.github.com/users/hshelton/followers","following_url":"https://api.github.com/users/hshelton/following{/other_user}","gists_url":"https://api.github.com/users/hshelton/gists{/gist_id}","starred_url":"https://api.github.com/users/hshelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshelton/subscriptions","organizations_url":"https://api.github.com/users/hshelton/orgs","repos_url":"https://api.github.com/users/hshelton/repos","events_url":"https://api.github.com/users/hshelton/events{/privacy}","received_events_url":"https://api.github.com/users/hshelton/received_events","type":"User","site_admin":false},"repo":{"id":80155765,"name":"2Mean","full_name":"hshelton/2Mean","owner":{"login":"hshelton","id":6633378,"avatar_url":"https://avatars.githubusercontent.com/u/6633378?v=3","gravatar_id":"","url":"https://api.github.com/users/hshelton","html_url":"https://github.com/hshelton","followers_url":"https://api.github.com/users/hshelton/followers","following_url":"https://api.github.com/users/hshelton/following{/other_user}","gists_url":"https://api.github.com/users/hshelton/gists{/gist_id}","starred_url":"https://api.github.com/users/hshelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hshelton/subscriptions","organizations_url":"https://api.github.com/users/hshelton/orgs","repos_url":"https://api.github.com/users/hshelton/repos","events_url":"https://api.github.com/users/hshelton/events{/privacy}","received_events_url":"https://api.github.com/users/hshelton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hshelton/2Mean","description":null,"fork":true,"url":"https://api.github.com/repos/hshelton/2Mean","forks_url":"https://api.github.com/repos/hshelton/2Mean/forks","keys_url":"https://api.github.com/repos/hshelton/2Mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hshelton/2Mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hshelton/2Mean/teams","hooks_url":"https://api.github.com/repos/hshelton/2Mean/hooks","issue_events_url":"https://api.github.com/repos/hshelton/2Mean/issues/events{/number}","events_url":"https://api.github.com/repos/hshelton/2Mean/events","assignees_url":"https://api.github.com/repos/hshelton/2Mean/assignees{/user}","branches_url":"https://api.github.com/repos/hshelton/2Mean/branches{/branch}","tags_url":"https://api.github.com/repos/hshelton/2Mean/tags","blobs_url":"https://api.github.com/repos/hshelton/2Mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hshelton/2Mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hshelton/2Mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/hshelton/2Mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hshelton/2Mean/statuses/{sha}","languages_url":"https://api.github.com/repos/hshelton/2Mean/languages","stargazers_url":"https://api.github.com/repos/hshelton/2Mean/stargazers","contributors_url":"https://api.github.com/repos/hshelton/2Mean/contributors","subscribers_url":"https://api.github.com/repos/hshelton/2Mean/subscribers","subscription_url":"https://api.github.com/repos/hshelton/2Mean/subscription","commits_url":"https://api.github.com/repos/hshelton/2Mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/hshelton/2Mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/hshelton/2Mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/hshelton/2Mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/hshelton/2Mean/contents/{+path}","compare_url":"https://api.github.com/repos/hshelton/2Mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hshelton/2Mean/merges","archive_url":"https://api.github.com/repos/hshelton/2Mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hshelton/2Mean/downloads","issues_url":"https://api.github.com/repos/hshelton/2Mean/issues{/number}","pulls_url":"https://api.github.com/repos/hshelton/2Mean/pulls{/number}","milestones_url":"https://api.github.com/repos/hshelton/2Mean/milestones{/number}","notifications_url":"https://api.github.com/repos/hshelton/2Mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hshelton/2Mean/labels{/name}","releases_url":"https://api.github.com/repos/hshelton/2Mean/releases{/id}","deployments_url":"https://api.github.com/repos/hshelton/2Mean/deployments","created_at":"2017-01-26T21:08:02Z","updated_at":"2017-01-27T22:15:21Z","pushed_at":"2017-01-31T18:41:26Z","git_url":"git://github.com/hshelton/2Mean.git","ssh_url":"[email protected]:hshelton/2Mean.git","clone_url":"https://github.com/hshelton/2Mean.git","svn_url":"https://github.com/hshelton/2Mean","homepage":null,"size":364,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SquareHook:roles","ref":"roles","sha":"3ff292c3eb272669f1c3f6f120e73b672d8c5375","user":{"login":"SquareHook","id":4520109,"avatar_url":"https://avatars.githubusercontent.com/u/4520109?v=3","gravatar_id":"","url":"https://api.github.com/users/SquareHook","html_url":"https://github.com/SquareHook","followers_url":"https://api.github.com/users/SquareHook/followers","following_url":"https://api.github.com/users/SquareHook/following{/other_user}","gists_url":"https://api.github.com/users/SquareHook/gists{/gist_id}","starred_url":"https://api.github.com/users/SquareHook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SquareHook/subscriptions","organizations_url":"https://api.github.com/users/SquareHook/orgs","repos_url":"https://api.github.com/users/SquareHook/repos","events_url":"https://api.github.com/users/SquareHook/events{/privacy}","received_events_url":"https://api.github.com/users/SquareHook/received_events","type":"Organization","site_admin":false},"repo":{"id":77167265,"name":"2Mean","full_name":"SquareHook/2Mean","owner":{"login":"SquareHook","id":4520109,"avatar_url":"https://avatars.githubusercontent.com/u/4520109?v=3","gravatar_id":"","url":"https://api.github.com/users/SquareHook","html_url":"https://github.com/SquareHook","followers_url":"https://api.github.com/users/SquareHook/followers","following_url":"https://api.github.com/users/SquareHook/following{/other_user}","gists_url":"https://api.github.com/users/SquareHook/gists{/gist_id}","starred_url":"https://api.github.com/users/SquareHook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SquareHook/subscriptions","organizations_url":"https://api.github.com/users/SquareHook/orgs","repos_url":"https://api.github.com/users/SquareHook/repos","events_url":"https://api.github.com/users/SquareHook/events{/privacy}","received_events_url":"https://api.github.com/users/SquareHook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SquareHook/2Mean","description":null,"fork":false,"url":"https://api.github.com/repos/SquareHook/2Mean","forks_url":"https://api.github.com/repos/SquareHook/2Mean/forks","keys_url":"https://api.github.com/repos/SquareHook/2Mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SquareHook/2Mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SquareHook/2Mean/teams","hooks_url":"https://api.github.com/repos/SquareHook/2Mean/hooks","issue_events_url":"https://api.github.com/repos/SquareHook/2Mean/issues/events{/number}","events_url":"https://api.github.com/repos/SquareHook/2Mean/events","assignees_url":"https://api.github.com/repos/SquareHook/2Mean/assignees{/user}","branches_url":"https://api.github.com/repos/SquareHook/2Mean/branches{/branch}","tags_url":"https://api.github.com/repos/SquareHook/2Mean/tags","blobs_url":"https://api.github.com/repos/SquareHook/2Mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SquareHook/2Mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SquareHook/2Mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/SquareHook/2Mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SquareHook/2Mean/statuses/{sha}","languages_url":"https://api.github.com/repos/SquareHook/2Mean/languages","stargazers_url":"https://api.github.com/repos/SquareHook/2Mean/stargazers","contributors_url":"https://api.github.com/repos/SquareHook/2Mean/contributors","subscribers_url":"https://api.github.com/repos/SquareHook/2Mean/subscribers","subscription_url":"https://api.github.com/repos/SquareHook/2Mean/subscription","commits_url":"https://api.github.com/repos/SquareHook/2Mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/SquareHook/2Mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/SquareHook/2Mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/SquareHook/2Mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/SquareHook/2Mean/contents/{+path}","compare_url":"https://api.github.com/repos/SquareHook/2Mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SquareHook/2Mean/merges","archive_url":"https://api.github.com/repos/SquareHook/2Mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SquareHook/2Mean/downloads","issues_url":"https://api.github.com/repos/SquareHook/2Mean/issues{/number}","pulls_url":"https://api.github.com/repos/SquareHook/2Mean/pulls{/number}","milestones_url":"https://api.github.com/repos/SquareHook/2Mean/milestones{/number}","notifications_url":"https://api.github.com/repos/SquareHook/2Mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SquareHook/2Mean/labels{/name}","releases_url":"https://api.github.com/repos/SquareHook/2Mean/releases{/id}","deployments_url":"https://api.github.com/repos/SquareHook/2Mean/deployments","created_at":"2016-12-22T18:31:39Z","updated_at":"2017-01-25T19:06:10Z","pushed_at":"2017-01-31T18:41:26Z","git_url":"git://github.com/SquareHook/2Mean.git","ssh_url":"[email protected]:SquareHook/2Mean.git","clone_url":"https://github.com/SquareHook/2Mean.git","svn_url":"https://github.com/SquareHook/2Mean","homepage":null,"size":333,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SquareHook/2Mean/pulls/62"},"html":{"href":"https://github.com/SquareHook/2Mean/pull/62"},"issue":{"href":"https://api.github.com/repos/SquareHook/2Mean/issues/62"},"comments":{"href":"https://api.github.com/repos/SquareHook/2Mean/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/SquareHook/2Mean/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/SquareHook/2Mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SquareHook/2Mean/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/SquareHook/2Mean/statuses/8be641402d0b4df807ef0a1b4fb8a7ee83074178"}}}} | {
"id": 77167265,
"name": "SquareHook/2Mean",
"url": "https://api.github.com/repos/SquareHook/2Mean"
} | {
"id": 16883874,
"login": "JasonSHD",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16883874?",
"url": "https://api.github.com/users/JasonSHD"
} | {
"id": 4520109,
"login": "SquareHook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4520109?",
"url": "https://api.github.com/orgs/SquareHook"
} | 2017-01-31T18:51:06 | 5242757616 | {"actor":{"display_login":"JasonSHD"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/StackStorm/st2docs/pulls/comments/96455494","pull_request_review_id":17037595,"id":96455494,"diff_hunk":"@@ -2,6 +2,6 @@\n \n sudo st2ctl start\n \n-* Register sensors and actions ::\n+* Register sensors, rules and actions ::","path":"docs/source/install/common/start_services.rst","position":5,"original_position":5,"commit_id":"97687ceb307adc478b6a6cdda9c561e118325ab6","original_commit_id":"97687ceb307adc478b6a6cdda9c561e118325ab6","user":{"login":"sidkrishna","id":19888129,"avatar_url":"https://avatars.githubusercontent.com/u/19888129?v=3","gravatar_id":"","url":"https://api.github.com/users/sidkrishna","html_url":"https://github.com/sidkrishna","followers_url":"https://api.github.com/users/sidkrishna/followers","following_url":"https://api.github.com/users/sidkrishna/following{/other_user}","gists_url":"https://api.github.com/users/sidkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/sidkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidkrishna/subscriptions","organizations_url":"https://api.github.com/users/sidkrishna/orgs","repos_url":"https://api.github.com/users/sidkrishna/repos","events_url":"https://api.github.com/users/sidkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/sidkrishna/received_events","type":"User","site_admin":false},"body":"@Kami thanks for pointing out. If I check the \"sudo st2ctl reload\" output on st2 2.1.0, it says:\r\n\r\n2017-01-17 08:47:25,560 INFO [-] =========================================================\r\n2017-01-17 08:47:25,560 INFO [-] ############## Registering rules ########################\r\n2017-01-17 08:47:25,560 INFO [-] =========================================================\r\n2017-01-17 08:47:26,122 INFO [-] Registered 17 rules.\r\n\r\nAm I missing something else?","created_at":"2017-01-17T16:48:48Z","updated_at":"2017-01-17T16:48:48Z","html_url":"https://github.com/StackStorm/st2docs/pull/365#discussion_r96455494","pull_request_url":"https://api.github.com/repos/StackStorm/st2docs/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2docs/pulls/comments/96455494"},"html":{"href":"https://github.com/StackStorm/st2docs/pull/365#discussion_r96455494"},"pull_request":{"href":"https://api.github.com/repos/StackStorm/st2docs/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/StackStorm/st2docs/pulls/365","id":101248432,"html_url":"https://github.com/StackStorm/st2docs/pull/365","diff_url":"https://github.com/StackStorm/st2docs/pull/365.diff","patch_url":"https://github.com/StackStorm/st2docs/pull/365.patch","issue_url":"https://api.github.com/repos/StackStorm/st2docs/issues/365","number":365,"state":"closed","locked":false,"title":"fixing install docs - start services section","user":{"login":"sidkrishna","id":19888129,"avatar_url":"https://avatars.githubusercontent.com/u/19888129?v=3","gravatar_id":"","url":"https://api.github.com/users/sidkrishna","html_url":"https://github.com/sidkrishna","followers_url":"https://api.github.com/users/sidkrishna/followers","following_url":"https://api.github.com/users/sidkrishna/following{/other_user}","gists_url":"https://api.github.com/users/sidkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/sidkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidkrishna/subscriptions","organizations_url":"https://api.github.com/users/sidkrishna/orgs","repos_url":"https://api.github.com/users/sidkrishna/repos","events_url":"https://api.github.com/users/sidkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/sidkrishna/received_events","type":"User","site_admin":false},"body":"Start services commands come up in the docs twice - once is explicit mention and the other comes from common/start_services.rst. Using the later only for consistency.","created_at":"2017-01-12T12:16:51Z","updated_at":"2017-01-17T16:48:48Z","closed_at":"2017-01-12T17:47:05Z","merged_at":"2017-01-12T17:47:05Z","merge_commit_sha":"755167da45a61784192061f3308bd5e5e34864a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/StackStorm/st2docs/pulls/365/commits","review_comments_url":"https://api.github.com/repos/StackStorm/st2docs/pulls/365/comments","review_comment_url":"https://api.github.com/repos/StackStorm/st2docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackStorm/st2docs/issues/365/comments","statuses_url":"https://api.github.com/repos/StackStorm/st2docs/statuses/97687ceb307adc478b6a6cdda9c561e118325ab6","head":{"label":"StackStorm:SK/install_doc_corrections","ref":"SK/install_doc_corrections","sha":"97687ceb307adc478b6a6cdda9c561e118325ab6","user":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":49105003,"name":"st2docs","full_name":"StackStorm/st2docs","owner":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2docs","description":"StackStorm Docs","fork":false,"url":"https://api.github.com/repos/StackStorm/st2docs","forks_url":"https://api.github.com/repos/StackStorm/st2docs/forks","keys_url":"https://api.github.com/repos/StackStorm/st2docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2docs/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2docs/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2docs/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2docs/events","assignees_url":"https://api.github.com/repos/StackStorm/st2docs/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2docs/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2docs/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2docs/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2docs/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2docs/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2docs/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2docs/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2docs/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2docs/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2docs/merges","archive_url":"https://api.github.com/repos/StackStorm/st2docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2docs/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2docs/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2docs/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2docs/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2docs/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2docs/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/st2docs/deployments","created_at":"2016-01-06T01:54:55Z","updated_at":"2016-12-08T04:56:09Z","pushed_at":"2017-01-13T14:52:41Z","git_url":"git://github.com/StackStorm/st2docs.git","ssh_url":"[email protected]:StackStorm/st2docs.git","clone_url":"https://github.com/StackStorm/st2docs.git","svn_url":"https://github.com/StackStorm/st2docs","homepage":null,"size":5490,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":13,"forks":46,"open_issues":13,"watchers":8,"default_branch":"master"}},"base":{"label":"StackStorm:master","ref":"master","sha":"7bdd2a2159119867b6756501eb12de29864ee43c","user":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":49105003,"name":"st2docs","full_name":"StackStorm/st2docs","owner":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2docs","description":"StackStorm Docs","fork":false,"url":"https://api.github.com/repos/StackStorm/st2docs","forks_url":"https://api.github.com/repos/StackStorm/st2docs/forks","keys_url":"https://api.github.com/repos/StackStorm/st2docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2docs/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2docs/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2docs/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2docs/events","assignees_url":"https://api.github.com/repos/StackStorm/st2docs/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2docs/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2docs/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2docs/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2docs/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2docs/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2docs/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2docs/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2docs/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2docs/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2docs/merges","archive_url":"https://api.github.com/repos/StackStorm/st2docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2docs/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2docs/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2docs/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2docs/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2docs/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2docs/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/st2docs/deployments","created_at":"2016-01-06T01:54:55Z","updated_at":"2016-12-08T04:56:09Z","pushed_at":"2017-01-13T14:52:41Z","git_url":"git://github.com/StackStorm/st2docs.git","ssh_url":"[email protected]:StackStorm/st2docs.git","clone_url":"https://github.com/StackStorm/st2docs.git","svn_url":"https://github.com/StackStorm/st2docs","homepage":null,"size":5490,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":13,"forks":46,"open_issues":13,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2docs/pulls/365"},"html":{"href":"https://github.com/StackStorm/st2docs/pull/365"},"issue":{"href":"https://api.github.com/repos/StackStorm/st2docs/issues/365"},"comments":{"href":"https://api.github.com/repos/StackStorm/st2docs/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/StackStorm/st2docs/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/StackStorm/st2docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackStorm/st2docs/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/StackStorm/st2docs/statuses/97687ceb307adc478b6a6cdda9c561e118325ab6"}}}} | {
"id": 49105003,
"name": "StackStorm/st2docs",
"url": "https://api.github.com/repos/StackStorm/st2docs"
} | {
"id": 19888129,
"login": "sidkrishna",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19888129?",
"url": "https://api.github.com/users/sidkrishna"
} | {
"id": 4969009,
"login": "StackStorm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4969009?",
"url": "https://api.github.com/orgs/StackStorm"
} | 2017-01-17T16:48:48 | 5166686453 | {"actor":{"display_login":"sidkrishna"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/comments/95996213","pull_request_review_id":16569303,"id":95996213,"diff_hunk":"@@ -0,0 +1,34 @@\n+---\n+- name: yum | Initialize postgresql\n+ become: yes\n+ yum:\n+ name: \"{{ item }}\"\n+ state: installed\n+ update_cache: yes\n+ with_items:\n+ - postgresql-server\n+ - postgresql-contrib\n+ - postgresql-devel\n+ tags: [db, postgresql]\n+\n+- name: yum | Initialize Postgresql\n+ become: yes\n+ command: postgresql-setup initdb","path":"roles/postgresql/tasks/postgresql_yum7.yml","position":15,"original_position":16,"commit_id":"697e31dd5c5e71693ac7abe51c52ba60f073206b","original_commit_id":"c76230dd62888543a24cf264f13ab8ded4a144ec","user":{"login":"armab","id":1533818,"avatar_url":"https://avatars.githubusercontent.com/u/1533818?v=3","gravatar_id":"","url":"https://api.github.com/users/armab","html_url":"https://github.com/armab","followers_url":"https://api.github.com/users/armab/followers","following_url":"https://api.github.com/users/armab/following{/other_user}","gists_url":"https://api.github.com/users/armab/gists{/gist_id}","starred_url":"https://api.github.com/users/armab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armab/subscriptions","organizations_url":"https://api.github.com/users/armab/orgs","repos_url":"https://api.github.com/users/armab/repos","events_url":"https://api.github.com/users/armab/events{/privacy}","received_events_url":"https://api.github.com/users/armab/received_events","type":"User","site_admin":false},"body":"See another comment: https://github.com/StackStorm/ansible-st2/pull/78/files#r95995753 about executing an action only when another command is changed","created_at":"2017-01-13T13:39:29Z","updated_at":"2017-01-13T13:39:29Z","html_url":"https://github.com/StackStorm/ansible-st2/pull/78#discussion_r95996213","pull_request_url":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/comments/95996213"},"html":{"href":"https://github.com/StackStorm/ansible-st2/pull/78#discussion_r95996213"},"pull_request":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/78","id":101169601,"html_url":"https://github.com/StackStorm/ansible-st2/pull/78","diff_url":"https://github.com/StackStorm/ansible-st2/pull/78.diff","patch_url":"https://github.com/StackStorm/ansible-st2/pull/78.patch","issue_url":"https://api.github.com/repos/StackStorm/ansible-st2/issues/78","number":78,"state":"open","locked":false,"title":"Rhel support for mistral and create postgresql role (remove AXNS.postgresql dependency)","user":{"login":"humblearner","id":11877841,"avatar_url":"https://avatars.githubusercontent.com/u/11877841?v=3","gravatar_id":"","url":"https://api.github.com/users/humblearner","html_url":"https://github.com/humblearner","followers_url":"https://api.github.com/users/humblearner/followers","following_url":"https://api.github.com/users/humblearner/following{/other_user}","gists_url":"https://api.github.com/users/humblearner/gists{/gist_id}","starred_url":"https://api.github.com/users/humblearner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblearner/subscriptions","organizations_url":"https://api.github.com/users/humblearner/orgs","repos_url":"https://api.github.com/users/humblearner/repos","events_url":"https://api.github.com/users/humblearner/events{/privacy}","received_events_url":"https://api.github.com/users/humblearner/received_events","type":"User","site_admin":false},"body":"- [x] Xenial\r\n- [x] Trusty\r\n- [x] Centos6\r\n- [x] Centos7\r\n- [x] Rhel6\r\n- [ ] Rhel7\r\n\r\nCovers https://github.com/StackStorm/ansible-st2/issues/76 and https://github.com/StackStorm/ansible-st2/issues/11","created_at":"2017-01-11T23:37:30Z","updated_at":"2017-01-13T13:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da8b1ad30fe44034c11a502f508fe8068661cd8a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/78/commits","review_comments_url":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/78/comments","review_comment_url":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackStorm/ansible-st2/issues/78/comments","statuses_url":"https://api.github.com/repos/StackStorm/ansible-st2/statuses/697e31dd5c5e71693ac7abe51c52ba60f073206b","head":{"label":"StackStorm:rhel_mistral_support","ref":"rhel_mistral_support","sha":"697e31dd5c5e71693ac7abe51c52ba60f073206b","user":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":35403824,"name":"ansible-st2","full_name":"StackStorm/ansible-st2","owner":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/ansible-st2","description":"Ansible playbooks to deploy StackStorm","fork":false,"url":"https://api.github.com/repos/StackStorm/ansible-st2","forks_url":"https://api.github.com/repos/StackStorm/ansible-st2/forks","keys_url":"https://api.github.com/repos/StackStorm/ansible-st2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/ansible-st2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/ansible-st2/teams","hooks_url":"https://api.github.com/repos/StackStorm/ansible-st2/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/ansible-st2/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/ansible-st2/events","assignees_url":"https://api.github.com/repos/StackStorm/ansible-st2/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/ansible-st2/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/ansible-st2/tags","blobs_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/ansible-st2/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/ansible-st2/languages","stargazers_url":"https://api.github.com/repos/StackStorm/ansible-st2/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/ansible-st2/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/ansible-st2/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/ansible-st2/subscription","commits_url":"https://api.github.com/repos/StackStorm/ansible-st2/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/ansible-st2/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/ansible-st2/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/ansible-st2/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/ansible-st2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/ansible-st2/merges","archive_url":"https://api.github.com/repos/StackStorm/ansible-st2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/ansible-st2/downloads","issues_url":"https://api.github.com/repos/StackStorm/ansible-st2/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/ansible-st2/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/ansible-st2/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/ansible-st2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/ansible-st2/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/ansible-st2/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/ansible-st2/deployments","created_at":"2015-05-11T05:22:48Z","updated_at":"2016-12-15T21:31:00Z","pushed_at":"2017-01-13T00:06:13Z","git_url":"git://github.com/StackStorm/ansible-st2.git","ssh_url":"[email protected]:StackStorm/ansible-st2.git","clone_url":"https://github.com/StackStorm/ansible-st2.git","svn_url":"https://github.com/StackStorm/ansible-st2","homepage":null,"size":157,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":21,"forks":16,"open_issues":21,"watchers":21,"default_branch":"master"}},"base":{"label":"StackStorm:master","ref":"master","sha":"436930a2ec51bba316c18f8ba2a5843c0774a3f1","user":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":35403824,"name":"ansible-st2","full_name":"StackStorm/ansible-st2","owner":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/ansible-st2","description":"Ansible playbooks to deploy StackStorm","fork":false,"url":"https://api.github.com/repos/StackStorm/ansible-st2","forks_url":"https://api.github.com/repos/StackStorm/ansible-st2/forks","keys_url":"https://api.github.com/repos/StackStorm/ansible-st2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/ansible-st2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/ansible-st2/teams","hooks_url":"https://api.github.com/repos/StackStorm/ansible-st2/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/ansible-st2/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/ansible-st2/events","assignees_url":"https://api.github.com/repos/StackStorm/ansible-st2/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/ansible-st2/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/ansible-st2/tags","blobs_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/ansible-st2/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/ansible-st2/languages","stargazers_url":"https://api.github.com/repos/StackStorm/ansible-st2/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/ansible-st2/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/ansible-st2/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/ansible-st2/subscription","commits_url":"https://api.github.com/repos/StackStorm/ansible-st2/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/ansible-st2/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/ansible-st2/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/ansible-st2/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/ansible-st2/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/ansible-st2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/ansible-st2/merges","archive_url":"https://api.github.com/repos/StackStorm/ansible-st2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/ansible-st2/downloads","issues_url":"https://api.github.com/repos/StackStorm/ansible-st2/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/ansible-st2/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/ansible-st2/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/ansible-st2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/ansible-st2/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/ansible-st2/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/ansible-st2/deployments","created_at":"2015-05-11T05:22:48Z","updated_at":"2016-12-15T21:31:00Z","pushed_at":"2017-01-13T00:06:13Z","git_url":"git://github.com/StackStorm/ansible-st2.git","ssh_url":"[email protected]:StackStorm/ansible-st2.git","clone_url":"https://github.com/StackStorm/ansible-st2.git","svn_url":"https://github.com/StackStorm/ansible-st2","homepage":null,"size":157,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":21,"forks":16,"open_issues":21,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/78"},"html":{"href":"https://github.com/StackStorm/ansible-st2/pull/78"},"issue":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/issues/78"},"comments":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/StackStorm/ansible-st2/statuses/697e31dd5c5e71693ac7abe51c52ba60f073206b"}}}} | {
"id": 35403824,
"name": "StackStorm/ansible-st2",
"url": "https://api.github.com/repos/StackStorm/ansible-st2"
} | {
"id": 1533818,
"login": "armab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1533818?",
"url": "https://api.github.com/users/armab"
} | {
"id": 4969009,
"login": "StackStorm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4969009?",
"url": "https://api.github.com/orgs/StackStorm"
} | 2017-01-13T13:39:29 | 5149071083 | {"actor":{"display_login":"armab"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/comments/100511845","pull_request_review_id":21221561,"id":100511845,"diff_hunk":"@@ -351,7 +351,15 @@ private function addNewItem($itemType, $itemUid, $indexingConfiguration, $rootPa\n $additionalRecordFields = ', doktype, uid';\n }\n \n- $record = BackendUtility::getRecord($itemType, $itemUid, 'pid' . $additionalRecordFields);\n+ $cache = GeneralUtility::makeInstance(TwoLevelCache::class, 'cache_runtime');","path":"Classes/IndexQueue/Queue.php","position":15,"original_position":15,"commit_id":"aa2d5bed42b2e169d95c297c2fc38b573fa91d94","original_commit_id":"aa2d5bed42b2e169d95c297c2fc38b573fa91d94","user":{"login":"timohund","id":964675,"avatar_url":"https://avatars.githubusercontent.com/u/964675?v=3","gravatar_id":"","url":"https://api.github.com/users/timohund","html_url":"https://github.com/timohund","followers_url":"https://api.github.com/users/timohund/followers","following_url":"https://api.github.com/users/timohund/following{/other_user}","gists_url":"https://api.github.com/users/timohund/gists{/gist_id}","starred_url":"https://api.github.com/users/timohund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timohund/subscriptions","organizations_url":"https://api.github.com/users/timohund/orgs","repos_url":"https://api.github.com/users/timohund/repos","events_url":"https://api.github.com/users/timohund/events{/privacy}","received_events_url":"https://api.github.com/users/timohund/received_events","type":"User","site_admin":false},"body":"I would propose to move the code into a protected method \"getRecordCached\" not enhance the lengh of the original method.","created_at":"2017-02-10T10:52:19Z","updated_at":"2017-02-10T10:52:31Z","html_url":"https://github.com/TYPO3-Solr/ext-solr/pull/960#discussion_r100511845","pull_request_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/960","_links":{"self":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/comments/100511845"},"html":{"href":"https://github.com/TYPO3-Solr/ext-solr/pull/960#discussion_r100511845"},"pull_request":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/960"}}},"pull_request":{"url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/960","id":105599921,"html_url":"https://github.com/TYPO3-Solr/ext-solr/pull/960","diff_url":"https://github.com/TYPO3-Solr/ext-solr/pull/960.diff","patch_url":"https://github.com/TYPO3-Solr/ext-solr/pull/960.patch","issue_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/issues/960","number":960,"state":"open","locked":false,"title":"[TASK] Added run-time cache to addNewItem","user":{"login":"thomashohn","id":3414869,"avatar_url":"https://avatars.githubusercontent.com/u/3414869?v=3","gravatar_id":"","url":"https://api.github.com/users/thomashohn","html_url":"https://github.com/thomashohn","followers_url":"https://api.github.com/users/thomashohn/followers","following_url":"https://api.github.com/users/thomashohn/following{/other_user}","gists_url":"https://api.github.com/users/thomashohn/gists{/gist_id}","starred_url":"https://api.github.com/users/thomashohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomashohn/subscriptions","organizations_url":"https://api.github.com/users/thomashohn/orgs","repos_url":"https://api.github.com/users/thomashohn/repos","events_url":"https://api.github.com/users/thomashohn/events{/privacy}","received_events_url":"https://api.github.com/users/thomashohn/received_events","type":"User","site_admin":false},"body":"This so gain some performance when copying trees - should solve #942 ","created_at":"2017-02-10T10:15:32Z","updated_at":"2017-02-10T10:52:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25e799a5dff4a8dbe327d03f17b6d339a032c7fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/960/commits","review_comments_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/960/comments","review_comment_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/issues/960/comments","statuses_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/statuses/aa2d5bed42b2e169d95c297c2fc38b573fa91d94","head":{"label":"thomashohn:task/master/add-runtimecache-addNewItem","ref":"task/master/add-runtimecache-addNewItem","sha":"aa2d5bed42b2e169d95c297c2fc38b573fa91d94","user":{"login":"thomashohn","id":3414869,"avatar_url":"https://avatars.githubusercontent.com/u/3414869?v=3","gravatar_id":"","url":"https://api.github.com/users/thomashohn","html_url":"https://github.com/thomashohn","followers_url":"https://api.github.com/users/thomashohn/followers","following_url":"https://api.github.com/users/thomashohn/following{/other_user}","gists_url":"https://api.github.com/users/thomashohn/gists{/gist_id}","starred_url":"https://api.github.com/users/thomashohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomashohn/subscriptions","organizations_url":"https://api.github.com/users/thomashohn/orgs","repos_url":"https://api.github.com/users/thomashohn/repos","events_url":"https://api.github.com/users/thomashohn/events{/privacy}","received_events_url":"https://api.github.com/users/thomashohn/received_events","type":"User","site_admin":false},"repo":{"id":65452173,"name":"ext-solr","full_name":"thomashohn/ext-solr","owner":{"login":"thomashohn","id":3414869,"avatar_url":"https://avatars.githubusercontent.com/u/3414869?v=3","gravatar_id":"","url":"https://api.github.com/users/thomashohn","html_url":"https://github.com/thomashohn","followers_url":"https://api.github.com/users/thomashohn/followers","following_url":"https://api.github.com/users/thomashohn/following{/other_user}","gists_url":"https://api.github.com/users/thomashohn/gists{/gist_id}","starred_url":"https://api.github.com/users/thomashohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomashohn/subscriptions","organizations_url":"https://api.github.com/users/thomashohn/orgs","repos_url":"https://api.github.com/users/thomashohn/repos","events_url":"https://api.github.com/users/thomashohn/events{/privacy}","received_events_url":"https://api.github.com/users/thomashohn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomashohn/ext-solr","description":"An extension that integrates the Apache Solr enterprise search server with TYPO3 CMS. The extension has initially been developed by dkd Internet Service GmbH and is now being continued as a community project.","fork":true,"url":"https://api.github.com/repos/thomashohn/ext-solr","forks_url":"https://api.github.com/repos/thomashohn/ext-solr/forks","keys_url":"https://api.github.com/repos/thomashohn/ext-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomashohn/ext-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomashohn/ext-solr/teams","hooks_url":"https://api.github.com/repos/thomashohn/ext-solr/hooks","issue_events_url":"https://api.github.com/repos/thomashohn/ext-solr/issues/events{/number}","events_url":"https://api.github.com/repos/thomashohn/ext-solr/events","assignees_url":"https://api.github.com/repos/thomashohn/ext-solr/assignees{/user}","branches_url":"https://api.github.com/repos/thomashohn/ext-solr/branches{/branch}","tags_url":"https://api.github.com/repos/thomashohn/ext-solr/tags","blobs_url":"https://api.github.com/repos/thomashohn/ext-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomashohn/ext-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomashohn/ext-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomashohn/ext-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomashohn/ext-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/thomashohn/ext-solr/languages","stargazers_url":"https://api.github.com/repos/thomashohn/ext-solr/stargazers","contributors_url":"https://api.github.com/repos/thomashohn/ext-solr/contributors","subscribers_url":"https://api.github.com/repos/thomashohn/ext-solr/subscribers","subscription_url":"https://api.github.com/repos/thomashohn/ext-solr/subscription","commits_url":"https://api.github.com/repos/thomashohn/ext-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomashohn/ext-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomashohn/ext-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomashohn/ext-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomashohn/ext-solr/contents/{+path}","compare_url":"https://api.github.com/repos/thomashohn/ext-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomashohn/ext-solr/merges","archive_url":"https://api.github.com/repos/thomashohn/ext-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomashohn/ext-solr/downloads","issues_url":"https://api.github.com/repos/thomashohn/ext-solr/issues{/number}","pulls_url":"https://api.github.com/repos/thomashohn/ext-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/thomashohn/ext-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/thomashohn/ext-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomashohn/ext-solr/labels{/name}","releases_url":"https://api.github.com/repos/thomashohn/ext-solr/releases{/id}","deployments_url":"https://api.github.com/repos/thomashohn/ext-solr/deployments","created_at":"2016-08-11T08:24:09Z","updated_at":"2016-08-11T08:24:11Z","pushed_at":"2017-02-10T10:15:59Z","git_url":"git://github.com/thomashohn/ext-solr.git","ssh_url":"[email protected]:thomashohn/ext-solr.git","clone_url":"https://github.com/thomashohn/ext-solr.git","svn_url":"https://github.com/thomashohn/ext-solr","homepage":"","size":9048,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TYPO3-Solr:master","ref":"master","sha":"c1816dfc1d98e3d36ead8c66636190db3b88b6ca","user":{"login":"TYPO3-Solr","id":11461794,"avatar_url":"https://avatars.githubusercontent.com/u/11461794?v=3","gravatar_id":"","url":"https://api.github.com/users/TYPO3-Solr","html_url":"https://github.com/TYPO3-Solr","followers_url":"https://api.github.com/users/TYPO3-Solr/followers","following_url":"https://api.github.com/users/TYPO3-Solr/following{/other_user}","gists_url":"https://api.github.com/users/TYPO3-Solr/gists{/gist_id}","starred_url":"https://api.github.com/users/TYPO3-Solr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYPO3-Solr/subscriptions","organizations_url":"https://api.github.com/users/TYPO3-Solr/orgs","repos_url":"https://api.github.com/users/TYPO3-Solr/repos","events_url":"https://api.github.com/users/TYPO3-Solr/events{/privacy}","received_events_url":"https://api.github.com/users/TYPO3-Solr/received_events","type":"Organization","site_admin":false},"repo":{"id":32169668,"name":"ext-solr","full_name":"TYPO3-Solr/ext-solr","owner":{"login":"TYPO3-Solr","id":11461794,"avatar_url":"https://avatars.githubusercontent.com/u/11461794?v=3","gravatar_id":"","url":"https://api.github.com/users/TYPO3-Solr","html_url":"https://github.com/TYPO3-Solr","followers_url":"https://api.github.com/users/TYPO3-Solr/followers","following_url":"https://api.github.com/users/TYPO3-Solr/following{/other_user}","gists_url":"https://api.github.com/users/TYPO3-Solr/gists{/gist_id}","starred_url":"https://api.github.com/users/TYPO3-Solr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYPO3-Solr/subscriptions","organizations_url":"https://api.github.com/users/TYPO3-Solr/orgs","repos_url":"https://api.github.com/users/TYPO3-Solr/repos","events_url":"https://api.github.com/users/TYPO3-Solr/events{/privacy}","received_events_url":"https://api.github.com/users/TYPO3-Solr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TYPO3-Solr/ext-solr","description":"An extension that integrates the Apache Solr enterprise search server with TYPO3 CMS. The extension has initially been developed by dkd Internet Service GmbH and is now being continued as a community project.","fork":false,"url":"https://api.github.com/repos/TYPO3-Solr/ext-solr","forks_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/forks","keys_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/teams","hooks_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/hooks","issue_events_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/issues/events{/number}","events_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/events","assignees_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/assignees{/user}","branches_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/branches{/branch}","tags_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/tags","blobs_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/languages","stargazers_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/stargazers","contributors_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/contributors","subscribers_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/subscribers","subscription_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/subscription","commits_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/contents/{+path}","compare_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/merges","archive_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/downloads","issues_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/issues{/number}","pulls_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/labels{/name}","releases_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/releases{/id}","deployments_url":"https://api.github.com/repos/TYPO3-Solr/ext-solr/deployments","created_at":"2015-03-13T17:14:09Z","updated_at":"2017-02-01T09:23:27Z","pushed_at":"2017-02-10T10:49:06Z","git_url":"git://github.com/TYPO3-Solr/ext-solr.git","ssh_url":"[email protected]:TYPO3-Solr/ext-solr.git","clone_url":"https://github.com/TYPO3-Solr/ext-solr.git","svn_url":"https://github.com/TYPO3-Solr/ext-solr","homepage":"","size":9051,"stargazers_count":67,"watchers_count":67,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":132,"forks":75,"open_issues":132,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/960"},"html":{"href":"https://github.com/TYPO3-Solr/ext-solr/pull/960"},"issue":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/issues/960"},"comments":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/issues/960/comments"},"review_comments":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/960/comments"},"review_comment":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/pulls/960/commits"},"statuses":{"href":"https://api.github.com/repos/TYPO3-Solr/ext-solr/statuses/aa2d5bed42b2e169d95c297c2fc38b573fa91d94"}}}} | {
"id": 32169668,
"name": "TYPO3-Solr/ext-solr",
"url": "https://api.github.com/repos/TYPO3-Solr/ext-solr"
} | {
"id": 964675,
"login": "timohund",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/964675?",
"url": "https://api.github.com/users/timohund"
} | {
"id": 11461794,
"login": "TYPO3-Solr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11461794?",
"url": "https://api.github.com/orgs/TYPO3-Solr"
} | 2017-02-10T10:52:19 | 5301829537 | {"actor":{"display_login":"timohund"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/comments/128045399","pull_request_review_id":50686546,"id":128045399,"diff_hunk":"@@ -287,8 +248,69 @@ public void SplitTenderExample_LevelUp_Then_Cash_With_Adjusted_Exemption_And_Adj\n exemptionAmount: 400);\n \n AdjustedCheckValues completedOrderValues = ProposedOrderCalculator.CalculateCompleteOrderValues(\n- totalOutstandingAmount,\n- taxAmountDue,\n+ check.TotalOutstandingAmount,\n+ check.TotalTaxAmount,\n+ exemptionAmount,\n+ spendAmount,\n+ availableDiscountAmount);\n+\n+ completedOrderValues.ShouldBeEquivalentTo(expectedCompletedOrderValues,\n+ $\"Expected: {expectedCompletedOrderValues}\" + Environment.NewLine +\n+ $\"Actual: {completedOrderValues}\");\n+ }\n+ \n+ /// <summary>\n+ /// In this example, cash is applied first. The remaining balance can be covered in full by the LevelUp \n+ /// discount credit available.\n+ /// </summary>\n+ /// <remarks>\n+ /// In this example, the second payment will still be responsible for some tax.\n+ /// </remarks>\n+ [TestMethod]\n+ public void SplitTenderExample_LevelUp_Second_Discount_Remaining_Balance()\n+ {\n+ // $22.00 is owed, $2.00 of that is tax. $0.00 of that is tobacco/alcohol, and the customer wants to pay\n+ // $12.00 towards the check all of which is discountable.\n+ Check check = new Check(total: 2200, tax: 200);\n+ int exemptionAmount = 0;\n+ int spendAmount = 1200;\n+\n+ // Apply a non-LevelUp tender\n+ check.ApplyTender(1000);\n+\n+ // Create proposed order: expected values\n+ AdjustedCheckValues expectedProposedOrderValues =\n+ new AdjustedCheckValues(\n+ spendAmount: 1200,\n+ taxAmount: 200,\n+ exemptionAmount: 0);\n+\n+ AdjustedCheckValues proposedOrderValues = ProposedOrderCalculator.CalculateCreateProposedOrderValues(\n+ check.TotalOutstandingAmount,\n+ check.TotalTaxAmount,\n+ exemptionAmount,\n+ spendAmount);\n+\n+ proposedOrderValues.ShouldBeEquivalentTo(expectedProposedOrderValues,\n+ $\"Expected: {expectedProposedOrderValues}\" + Environment.NewLine +\n+ $\"Actual: {proposedOrderValues}\");\n+\n+ // available discount amount $10.00\n+ int availableDiscountAmount = 1000;\n+\n+ // POS applies $10.00 pretax discount to check and updates subtotal and tax\n+ check.ApplyDiscount(availableDiscountAmount);\n+\n+ // Create completed order: expected values\n+ AdjustedCheckValues expectedCompletedOrderValues =\n+ new AdjustedCheckValues(\n+ spendAmount: 1100, // spendAmount will include appliedDiscount and remaining tax","path":"LevelUp.Pos.ProposedOrders.Tests/SplitTenderTests.cs","position":null,"original_position":306,"commit_id":"ba155176cfc22a63e2f2923466c73ed99bc4de52","original_commit_id":"04151757363e2e4487d2f5a23b7e1703275fcc91","user":{"login":"forestb","id":4983812,"avatar_url":"https://avatars2.githubusercontent.com/u/4983812?v=4","gravatar_id":"","url":"https://api.github.com/users/forestb","html_url":"https://github.com/forestb","followers_url":"https://api.github.com/users/forestb/followers","following_url":"https://api.github.com/users/forestb/following{/other_user}","gists_url":"https://api.github.com/users/forestb/gists{/gist_id}","starred_url":"https://api.github.com/users/forestb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forestb/subscriptions","organizations_url":"https://api.github.com/users/forestb/orgs","repos_url":"https://api.github.com/users/forestb/repos","events_url":"https://api.github.com/users/forestb/events{/privacy}","received_events_url":"https://api.github.com/users/forestb/received_events","type":"User","site_admin":false},"body":"✔️ ","created_at":"2017-07-18T17:42:43Z","updated_at":"2017-07-18T17:44:36Z","html_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp/pull/13#discussion_r128045399","pull_request_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/comments/128045399"},"html":{"href":"https://github.com/TheLevelUp/pos-proposed-orders-csharp/pull/13#discussion_r128045399"},"pull_request":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/13","id":125920308,"html_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp/pull/13","diff_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp/pull/13.diff","patch_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp/pull/13.patch","issue_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues/13","number":13,"state":"open","locked":false,"title":"Partial payment test","user":{"login":"forestb","id":4983812,"avatar_url":"https://avatars2.githubusercontent.com/u/4983812?v=4","gravatar_id":"","url":"https://api.github.com/users/forestb","html_url":"https://github.com/forestb","followers_url":"https://api.github.com/users/forestb/followers","following_url":"https://api.github.com/users/forestb/following{/other_user}","gists_url":"https://api.github.com/users/forestb/gists{/gist_id}","starred_url":"https://api.github.com/users/forestb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forestb/subscriptions","organizations_url":"https://api.github.com/users/forestb/orgs","repos_url":"https://api.github.com/users/forestb/repos","events_url":"https://api.github.com/users/forestb/events{/privacy}","received_events_url":"https://api.github.com/users/forestb/received_events","type":"User","site_admin":false},"body":"Added an additional test where LevelUp was the second payment and the discount amount available covered the balance in full.","created_at":"2017-06-15T21:53:28Z","updated_at":"2017-07-18T17:44:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49a4c08e04968796c5f3cc27df15b4ebb8e5378f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"agbaber","id":2523525,"avatar_url":"https://avatars3.githubusercontent.com/u/2523525?v=4","gravatar_id":"","url":"https://api.github.com/users/agbaber","html_url":"https://github.com/agbaber","followers_url":"https://api.github.com/users/agbaber/followers","following_url":"https://api.github.com/users/agbaber/following{/other_user}","gists_url":"https://api.github.com/users/agbaber/gists{/gist_id}","starred_url":"https://api.github.com/users/agbaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agbaber/subscriptions","organizations_url":"https://api.github.com/users/agbaber/orgs","repos_url":"https://api.github.com/users/agbaber/repos","events_url":"https://api.github.com/users/agbaber/events{/privacy}","received_events_url":"https://api.github.com/users/agbaber/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/13/commits","review_comments_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/13/comments","review_comment_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues/13/comments","statuses_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/statuses/ba155176cfc22a63e2f2923466c73ed99bc4de52","head":{"label":"TheLevelUp:partial-payment-test","ref":"partial-payment-test","sha":"ba155176cfc22a63e2f2923466c73ed99bc4de52","user":{"login":"TheLevelUp","id":1521628,"avatar_url":"https://avatars3.githubusercontent.com/u/1521628?v=4","gravatar_id":"","url":"https://api.github.com/users/TheLevelUp","html_url":"https://github.com/TheLevelUp","followers_url":"https://api.github.com/users/TheLevelUp/followers","following_url":"https://api.github.com/users/TheLevelUp/following{/other_user}","gists_url":"https://api.github.com/users/TheLevelUp/gists{/gist_id}","starred_url":"https://api.github.com/users/TheLevelUp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheLevelUp/subscriptions","organizations_url":"https://api.github.com/users/TheLevelUp/orgs","repos_url":"https://api.github.com/users/TheLevelUp/repos","events_url":"https://api.github.com/users/TheLevelUp/events{/privacy}","received_events_url":"https://api.github.com/users/TheLevelUp/received_events","type":"Organization","site_admin":false},"repo":{"id":87986721,"name":"pos-proposed-orders-csharp","full_name":"TheLevelUp/pos-proposed-orders-csharp","owner":{"login":"TheLevelUp","id":1521628,"avatar_url":"https://avatars3.githubusercontent.com/u/1521628?v=4","gravatar_id":"","url":"https://api.github.com/users/TheLevelUp","html_url":"https://github.com/TheLevelUp","followers_url":"https://api.github.com/users/TheLevelUp/followers","following_url":"https://api.github.com/users/TheLevelUp/following{/other_user}","gists_url":"https://api.github.com/users/TheLevelUp/gists{/gist_id}","starred_url":"https://api.github.com/users/TheLevelUp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheLevelUp/subscriptions","organizations_url":"https://api.github.com/users/TheLevelUp/orgs","repos_url":"https://api.github.com/users/TheLevelUp/repos","events_url":"https://api.github.com/users/TheLevelUp/events{/privacy}","received_events_url":"https://api.github.com/users/TheLevelUp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp","description":null,"fork":false,"url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp","forks_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/forks","keys_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/teams","hooks_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/hooks","issue_events_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/events","assignees_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/tags","blobs_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/languages","stargazers_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/stargazers","contributors_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/contributors","subscribers_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/subscribers","subscription_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/subscription","commits_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/merges","archive_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/downloads","issues_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/labels{/name}","releases_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/deployments","created_at":"2017-04-11T22:59:00Z","updated_at":"2017-05-12T19:38:30Z","pushed_at":"2017-07-18T17:44:01Z","git_url":"git://github.com/TheLevelUp/pos-proposed-orders-csharp.git","ssh_url":"[email protected]:TheLevelUp/pos-proposed-orders-csharp.git","clone_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp.git","svn_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp","homepage":null,"size":49,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"TheLevelUp:master","ref":"master","sha":"ef77abcc3bacf9b3ae4d7ab4106a8e65c3279d49","user":{"login":"TheLevelUp","id":1521628,"avatar_url":"https://avatars3.githubusercontent.com/u/1521628?v=4","gravatar_id":"","url":"https://api.github.com/users/TheLevelUp","html_url":"https://github.com/TheLevelUp","followers_url":"https://api.github.com/users/TheLevelUp/followers","following_url":"https://api.github.com/users/TheLevelUp/following{/other_user}","gists_url":"https://api.github.com/users/TheLevelUp/gists{/gist_id}","starred_url":"https://api.github.com/users/TheLevelUp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheLevelUp/subscriptions","organizations_url":"https://api.github.com/users/TheLevelUp/orgs","repos_url":"https://api.github.com/users/TheLevelUp/repos","events_url":"https://api.github.com/users/TheLevelUp/events{/privacy}","received_events_url":"https://api.github.com/users/TheLevelUp/received_events","type":"Organization","site_admin":false},"repo":{"id":87986721,"name":"pos-proposed-orders-csharp","full_name":"TheLevelUp/pos-proposed-orders-csharp","owner":{"login":"TheLevelUp","id":1521628,"avatar_url":"https://avatars3.githubusercontent.com/u/1521628?v=4","gravatar_id":"","url":"https://api.github.com/users/TheLevelUp","html_url":"https://github.com/TheLevelUp","followers_url":"https://api.github.com/users/TheLevelUp/followers","following_url":"https://api.github.com/users/TheLevelUp/following{/other_user}","gists_url":"https://api.github.com/users/TheLevelUp/gists{/gist_id}","starred_url":"https://api.github.com/users/TheLevelUp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheLevelUp/subscriptions","organizations_url":"https://api.github.com/users/TheLevelUp/orgs","repos_url":"https://api.github.com/users/TheLevelUp/repos","events_url":"https://api.github.com/users/TheLevelUp/events{/privacy}","received_events_url":"https://api.github.com/users/TheLevelUp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp","description":null,"fork":false,"url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp","forks_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/forks","keys_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/teams","hooks_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/hooks","issue_events_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/events","assignees_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/tags","blobs_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/languages","stargazers_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/stargazers","contributors_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/contributors","subscribers_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/subscribers","subscription_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/subscription","commits_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/merges","archive_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/downloads","issues_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/labels{/name}","releases_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/deployments","created_at":"2017-04-11T22:59:00Z","updated_at":"2017-05-12T19:38:30Z","pushed_at":"2017-07-18T17:44:01Z","git_url":"git://github.com/TheLevelUp/pos-proposed-orders-csharp.git","ssh_url":"[email protected]:TheLevelUp/pos-proposed-orders-csharp.git","clone_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp.git","svn_url":"https://github.com/TheLevelUp/pos-proposed-orders-csharp","homepage":null,"size":49,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/13"},"html":{"href":"https://github.com/TheLevelUp/pos-proposed-orders-csharp/pull/13"},"issue":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues/13"},"comments":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp/statuses/ba155176cfc22a63e2f2923466c73ed99bc4de52"}}}} | {
"id": 87986721,
"name": "TheLevelUp/pos-proposed-orders-csharp",
"url": "https://api.github.com/repos/TheLevelUp/pos-proposed-orders-csharp"
} | {
"id": 4983812,
"login": "forestb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4983812?",
"url": "https://api.github.com/users/forestb"
} | {
"id": 1521628,
"login": "TheLevelUp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1521628?",
"url": "https://api.github.com/orgs/TheLevelUp"
} | 2017-07-18T17:42:43 | 6280126975 | {"actor":{"display_login":"forestb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/comments/152076528","pull_request_review_id":77882596,"id":152076528,"diff_hunk":"@@ -166,44 +145,16 @@ const GoogleSheetInput = function () {\n var self = {};\n \n self.build = function () {\n- var domainName = DomainName(window.location.search.substring(1));\n- var queryParams = QueryParams(window.location.search.substring(1));\n-\n- if (domainName && queryParams.sheetId.endsWith('csv')) {\n- var sheet = CSVDocument(queryParams.sheetId);\n- sheet.init().build();\n- }\n- else if (domainName && domainName.endsWith('google.com') && queryParams.sheetId) {\n- var sheet = GoogleSheet(queryParams.sheetId, queryParams.sheetName);\n- console.log(queryParams.sheetName)\n-\n- sheet.init().build();\n- } else {\n- var content = d3.select('body')\n- .append('div')\n- .attr('class', 'input-sheet');\n-\n- set_document_title();\n-\n- plotLogo(content);\n-\n- var bannerText = '<div><h1>Build your own radar</h1><p>Once you\\'ve <a href =\"https://info.thoughtworks.com/visualize-your-tech-strategy.html\">created your Radar</a>, you can use this service' +\n- ' to generate an <br />interactive version of your Technology Radar. Not sure how? <a href =\"https://info.thoughtworks.com/visualize-your-tech-strategy-guide.html\">Read this first.</a></p></div>';\n+ var sheet = GoogleSheet(process.env.GOOGLE_SHEET_ID, null);\n \n- plotBanner(content, bannerText);\n-\n- plotForm(content);\n-\n- plotFooter(content);\n-\n- }\n+ sheet.init().build();\n };\n \n return self;\n };\n \n function set_document_title() {\n- document.title = \"Build your own Radar\";\n+ document.title = \"Build Vermonster's Radar\";","path":"src/util/factory.js","position":72,"original_position":72,"commit_id":"e8db1e624a745d3d6e0aaaf9449bdea0df5162fb","original_commit_id":"e8db1e624a745d3d6e0aaaf9449bdea0df5162fb","user":{"login":"jordan-king","id":10099320,"avatar_url":"https://avatars1.githubusercontent.com/u/10099320?v=4","gravatar_id":"","url":"https://api.github.com/users/jordan-king","html_url":"https://github.com/jordan-king","followers_url":"https://api.github.com/users/jordan-king/followers","following_url":"https://api.github.com/users/jordan-king/following{/other_user}","gists_url":"https://api.github.com/users/jordan-king/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-king/subscriptions","organizations_url":"https://api.github.com/users/jordan-king/orgs","repos_url":"https://api.github.com/users/jordan-king/repos","events_url":"https://api.github.com/users/jordan-king/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-king/received_events","type":"User","site_admin":false},"body":"Vermonster Tech Radar","created_at":"2017-11-20T18:44:16Z","updated_at":"2017-11-20T18:44:16Z","html_url":"https://github.com/Vermonster/build-your-own-radar/pull/1#discussion_r152076528","pull_request_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/comments/152076528"},"html":{"href":"https://github.com/Vermonster/build-your-own-radar/pull/1#discussion_r152076528"},"pull_request":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/1","id":153701674,"html_url":"https://github.com/Vermonster/build-your-own-radar/pull/1","diff_url":"https://github.com/Vermonster/build-your-own-radar/pull/1.diff","patch_url":"https://github.com/Vermonster/build-your-own-radar/pull/1.patch","issue_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues/1","number":1,"state":"open","locked":false,"title":"Vermonsterify","user":{"login":"jordan-king","id":10099320,"avatar_url":"https://avatars1.githubusercontent.com/u/10099320?v=4","gravatar_id":"","url":"https://api.github.com/users/jordan-king","html_url":"https://github.com/jordan-king","followers_url":"https://api.github.com/users/jordan-king/followers","following_url":"https://api.github.com/users/jordan-king/following{/other_user}","gists_url":"https://api.github.com/users/jordan-king/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-king/subscriptions","organizations_url":"https://api.github.com/users/jordan-king/orgs","repos_url":"https://api.github.com/users/jordan-king/repos","events_url":"https://api.github.com/users/jordan-king/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-king/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-20T18:26:17Z","updated_at":"2017-11-20T18:44:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8e8e35680777bf0b9f452da296fc2d10d1d7af7","assignee":{"login":"jordan-king","id":10099320,"avatar_url":"https://avatars1.githubusercontent.com/u/10099320?v=4","gravatar_id":"","url":"https://api.github.com/users/jordan-king","html_url":"https://github.com/jordan-king","followers_url":"https://api.github.com/users/jordan-king/followers","following_url":"https://api.github.com/users/jordan-king/following{/other_user}","gists_url":"https://api.github.com/users/jordan-king/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-king/subscriptions","organizations_url":"https://api.github.com/users/jordan-king/orgs","repos_url":"https://api.github.com/users/jordan-king/repos","events_url":"https://api.github.com/users/jordan-king/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-king/received_events","type":"User","site_admin":false},"assignees":[{"login":"jordan-king","id":10099320,"avatar_url":"https://avatars1.githubusercontent.com/u/10099320?v=4","gravatar_id":"","url":"https://api.github.com/users/jordan-king","html_url":"https://github.com/jordan-king","followers_url":"https://api.github.com/users/jordan-king/followers","following_url":"https://api.github.com/users/jordan-king/following{/other_user}","gists_url":"https://api.github.com/users/jordan-king/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-king/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-king/subscriptions","organizations_url":"https://api.github.com/users/jordan-king/orgs","repos_url":"https://api.github.com/users/jordan-king/repos","events_url":"https://api.github.com/users/jordan-king/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-king/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues/1/comments","statuses_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/statuses/e8db1e624a745d3d6e0aaaf9449bdea0df5162fb","head":{"label":"Vermonster:vermonsterify","ref":"vermonsterify","sha":"e8db1e624a745d3d6e0aaaf9449bdea0df5162fb","user":{"login":"Vermonster","id":345748,"avatar_url":"https://avatars1.githubusercontent.com/u/345748?v=4","gravatar_id":"","url":"https://api.github.com/users/Vermonster","html_url":"https://github.com/Vermonster","followers_url":"https://api.github.com/users/Vermonster/followers","following_url":"https://api.github.com/users/Vermonster/following{/other_user}","gists_url":"https://api.github.com/users/Vermonster/gists{/gist_id}","starred_url":"https://api.github.com/users/Vermonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vermonster/subscriptions","organizations_url":"https://api.github.com/users/Vermonster/orgs","repos_url":"https://api.github.com/users/Vermonster/repos","events_url":"https://api.github.com/users/Vermonster/events{/privacy}","received_events_url":"https://api.github.com/users/Vermonster/received_events","type":"Organization","site_admin":false},"repo":{"id":111131607,"name":"build-your-own-radar","full_name":"Vermonster/build-your-own-radar","owner":{"login":"Vermonster","id":345748,"avatar_url":"https://avatars1.githubusercontent.com/u/345748?v=4","gravatar_id":"","url":"https://api.github.com/users/Vermonster","html_url":"https://github.com/Vermonster","followers_url":"https://api.github.com/users/Vermonster/followers","following_url":"https://api.github.com/users/Vermonster/following{/other_user}","gists_url":"https://api.github.com/users/Vermonster/gists{/gist_id}","starred_url":"https://api.github.com/users/Vermonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vermonster/subscriptions","organizations_url":"https://api.github.com/users/Vermonster/orgs","repos_url":"https://api.github.com/users/Vermonster/repos","events_url":"https://api.github.com/users/Vermonster/events{/privacy}","received_events_url":"https://api.github.com/users/Vermonster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vermonster/build-your-own-radar","description":"A library that generates an interactive radar, inspired by http://thoughtworks.com/radar/","fork":true,"url":"https://api.github.com/repos/Vermonster/build-your-own-radar","forks_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/forks","keys_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/teams","hooks_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/hooks","issue_events_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues/events{/number}","events_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/events","assignees_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/assignees{/user}","branches_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/branches{/branch}","tags_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/tags","blobs_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/statuses/{sha}","languages_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/languages","stargazers_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/stargazers","contributors_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/contributors","subscribers_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/subscribers","subscription_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/subscription","commits_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/contents/{+path}","compare_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/merges","archive_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/downloads","issues_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues{/number}","pulls_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls{/number}","milestones_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/milestones{/number}","notifications_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/labels{/name}","releases_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/releases{/id}","deployments_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/deployments","created_at":"2017-11-17T17:25:28Z","updated_at":"2017-11-17T21:29:37Z","pushed_at":"2017-11-20T18:26:17Z","git_url":"git://github.com/Vermonster/build-your-own-radar.git","ssh_url":"[email protected]:Vermonster/build-your-own-radar.git","clone_url":"https://github.com/Vermonster/build-your-own-radar.git","svn_url":"https://github.com/Vermonster/build-your-own-radar","homepage":"","size":1315,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Vermonster:master","ref":"master","sha":"517836213ebefb60dfa4cfeb42ba355d476662cd","user":{"login":"Vermonster","id":345748,"avatar_url":"https://avatars1.githubusercontent.com/u/345748?v=4","gravatar_id":"","url":"https://api.github.com/users/Vermonster","html_url":"https://github.com/Vermonster","followers_url":"https://api.github.com/users/Vermonster/followers","following_url":"https://api.github.com/users/Vermonster/following{/other_user}","gists_url":"https://api.github.com/users/Vermonster/gists{/gist_id}","starred_url":"https://api.github.com/users/Vermonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vermonster/subscriptions","organizations_url":"https://api.github.com/users/Vermonster/orgs","repos_url":"https://api.github.com/users/Vermonster/repos","events_url":"https://api.github.com/users/Vermonster/events{/privacy}","received_events_url":"https://api.github.com/users/Vermonster/received_events","type":"Organization","site_admin":false},"repo":{"id":111131607,"name":"build-your-own-radar","full_name":"Vermonster/build-your-own-radar","owner":{"login":"Vermonster","id":345748,"avatar_url":"https://avatars1.githubusercontent.com/u/345748?v=4","gravatar_id":"","url":"https://api.github.com/users/Vermonster","html_url":"https://github.com/Vermonster","followers_url":"https://api.github.com/users/Vermonster/followers","following_url":"https://api.github.com/users/Vermonster/following{/other_user}","gists_url":"https://api.github.com/users/Vermonster/gists{/gist_id}","starred_url":"https://api.github.com/users/Vermonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vermonster/subscriptions","organizations_url":"https://api.github.com/users/Vermonster/orgs","repos_url":"https://api.github.com/users/Vermonster/repos","events_url":"https://api.github.com/users/Vermonster/events{/privacy}","received_events_url":"https://api.github.com/users/Vermonster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vermonster/build-your-own-radar","description":"A library that generates an interactive radar, inspired by http://thoughtworks.com/radar/","fork":true,"url":"https://api.github.com/repos/Vermonster/build-your-own-radar","forks_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/forks","keys_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/teams","hooks_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/hooks","issue_events_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues/events{/number}","events_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/events","assignees_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/assignees{/user}","branches_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/branches{/branch}","tags_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/tags","blobs_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/statuses/{sha}","languages_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/languages","stargazers_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/stargazers","contributors_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/contributors","subscribers_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/subscribers","subscription_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/subscription","commits_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/contents/{+path}","compare_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/merges","archive_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/downloads","issues_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues{/number}","pulls_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls{/number}","milestones_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/milestones{/number}","notifications_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/labels{/name}","releases_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/releases{/id}","deployments_url":"https://api.github.com/repos/Vermonster/build-your-own-radar/deployments","created_at":"2017-11-17T17:25:28Z","updated_at":"2017-11-17T21:29:37Z","pushed_at":"2017-11-20T18:26:17Z","git_url":"git://github.com/Vermonster/build-your-own-radar.git","ssh_url":"[email protected]:Vermonster/build-your-own-radar.git","clone_url":"https://github.com/Vermonster/build-your-own-radar.git","svn_url":"https://github.com/Vermonster/build-your-own-radar","homepage":"","size":1315,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/1"},"html":{"href":"https://github.com/Vermonster/build-your-own-radar/pull/1"},"issue":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues/1"},"comments":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Vermonster/build-your-own-radar/statuses/e8db1e624a745d3d6e0aaaf9449bdea0df5162fb"}},"author_association":"COLLABORATOR"}} | {
"id": 111131607,
"name": "Vermonster/build-your-own-radar",
"url": "https://api.github.com/repos/Vermonster/build-your-own-radar"
} | {
"id": 10099320,
"login": "jordan-king",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10099320?",
"url": "https://api.github.com/users/jordan-king"
} | {
"id": 345748,
"login": "Vermonster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/345748?",
"url": "https://api.github.com/orgs/Vermonster"
} | 2017-11-20T18:44:16 | 6880471067 | {"actor":{"display_login":"jordan-king"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/134889424","pull_request_review_id":58236318,"id":134889424,"diff_hunk":"@@ -125,3 +125,16 @@ Refresh is currently not supported for SRA enabled slots. If a slot is enabled f\n #### AMP Ad Container Compatibility\n \n The only AMP ad containers in which refresh is currently supported are amp-sticky-ad and amp-carousel container types.\n+\n+\n+### SRA: Single Request Architecture (alpha)\n+Enabling SRA allows a publisher to make a single request for all ad slots on the AMP page which gives a publisher the ability to do roadblocking and competitive exclusions. This very similar to the behavior acheived on non-AMP pages when using [this](https://developers.google.com/doubleclick-gpt/reference#googletag.PubAdsService_enableSingleRequest) method in GPT.\n+\n+In order to use this feature, add the following meta tag to the head of the AMP page:\n+`<meta name=”amp-ad-doubleclick-sra”/>`","path":"extensions/amp-ad-network-doubleclick-impl/amp-ad-network-doubleclick-impl-internal.md","position":10,"original_position":10,"commit_id":"0c938dd2174843a62cfda0ee3e51b63758081db9","original_commit_id":"0c938dd2174843a62cfda0ee3e51b63758081db9","user":{"login":"lannka","id":8496897,"avatar_url":"https://avatars3.githubusercontent.com/u/8496897?v=4","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"body":"just to confirm that we have validator support for this. @Gregable ","created_at":"2017-08-23T22:42:47Z","updated_at":"2017-08-23T22:43:50Z","html_url":"https://github.com/ampproject/amphtml/pull/11075#discussion_r134889424","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/11075","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/134889424"},"html":{"href":"https://github.com/ampproject/amphtml/pull/11075#discussion_r134889424"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/11075"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/11075","id":137333968,"html_url":"https://github.com/ampproject/amphtml/pull/11075","diff_url":"https://github.com/ampproject/amphtml/pull/11075.diff","patch_url":"https://github.com/ampproject/amphtml/pull/11075.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/11075","number":11075,"state":"open","locked":false,"title":"Add documentation for using SRA","user":{"login":"jasti","id":2366341,"avatar_url":"https://avatars3.githubusercontent.com/u/2366341?v=4","gravatar_id":"","url":"https://api.github.com/users/jasti","html_url":"https://github.com/jasti","followers_url":"https://api.github.com/users/jasti/followers","following_url":"https://api.github.com/users/jasti/following{/other_user}","gists_url":"https://api.github.com/users/jasti/gists{/gist_id}","starred_url":"https://api.github.com/users/jasti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasti/subscriptions","organizations_url":"https://api.github.com/users/jasti/orgs","repos_url":"https://api.github.com/users/jasti/repos","events_url":"https://api.github.com/users/jasti/events{/privacy}","received_events_url":"https://api.github.com/users/jasti/received_events","type":"User","site_admin":false},"body":"Doc update to use SRA. ","created_at":"2017-08-23T22:40:37Z","updated_at":"2017-08-23T22:43:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74b554375fbd0c6fc1a14f3094ab39e13f0a0c50","assignee":{"login":"keithwrightbos","id":1766447,"avatar_url":"https://avatars2.githubusercontent.com/u/1766447?v=4","gravatar_id":"","url":"https://api.github.com/users/keithwrightbos","html_url":"https://github.com/keithwrightbos","followers_url":"https://api.github.com/users/keithwrightbos/followers","following_url":"https://api.github.com/users/keithwrightbos/following{/other_user}","gists_url":"https://api.github.com/users/keithwrightbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keithwrightbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithwrightbos/subscriptions","organizations_url":"https://api.github.com/users/keithwrightbos/orgs","repos_url":"https://api.github.com/users/keithwrightbos/repos","events_url":"https://api.github.com/users/keithwrightbos/events{/privacy}","received_events_url":"https://api.github.com/users/keithwrightbos/received_events","type":"User","site_admin":false},"assignees":[{"login":"keithwrightbos","id":1766447,"avatar_url":"https://avatars2.githubusercontent.com/u/1766447?v=4","gravatar_id":"","url":"https://api.github.com/users/keithwrightbos","html_url":"https://github.com/keithwrightbos","followers_url":"https://api.github.com/users/keithwrightbos/followers","following_url":"https://api.github.com/users/keithwrightbos/following{/other_user}","gists_url":"https://api.github.com/users/keithwrightbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keithwrightbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithwrightbos/subscriptions","organizations_url":"https://api.github.com/users/keithwrightbos/orgs","repos_url":"https://api.github.com/users/keithwrightbos/repos","events_url":"https://api.github.com/users/keithwrightbos/events{/privacy}","received_events_url":"https://api.github.com/users/keithwrightbos/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"keithwrightbos","id":1766447,"avatar_url":"https://avatars2.githubusercontent.com/u/1766447?v=4","gravatar_id":"","url":"https://api.github.com/users/keithwrightbos","html_url":"https://github.com/keithwrightbos","followers_url":"https://api.github.com/users/keithwrightbos/followers","following_url":"https://api.github.com/users/keithwrightbos/following{/other_user}","gists_url":"https://api.github.com/users/keithwrightbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keithwrightbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithwrightbos/subscriptions","organizations_url":"https://api.github.com/users/keithwrightbos/orgs","repos_url":"https://api.github.com/users/keithwrightbos/repos","events_url":"https://api.github.com/users/keithwrightbos/events{/privacy}","received_events_url":"https://api.github.com/users/keithwrightbos/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/11075/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/11075/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/11075/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/0c938dd2174843a62cfda0ee3e51b63758081db9","head":{"label":"ampproject:jasti-patch-4","ref":"jasti-patch-4","sha":"0c938dd2174843a62cfda0ee3e51b63758081db9","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation. See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-08-23T14:48:48Z","pushed_at":"2017-08-23T22:40:38Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"[email protected]:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":243756,"stargazers_count":10395,"watchers_count":10395,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1893,"mirror_url":null,"open_issues_count":920,"forks":1893,"open_issues":920,"watchers":10395,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"8145657e0eadc3381b68f287eba206b84c8239cf","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation. See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-08-23T14:48:48Z","pushed_at":"2017-08-23T22:40:38Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"[email protected]:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":243756,"stargazers_count":10395,"watchers_count":10395,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1893,"mirror_url":null,"open_issues_count":920,"forks":1893,"open_issues":920,"watchers":10395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/11075"},"html":{"href":"https://github.com/ampproject/amphtml/pull/11075"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/11075"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/11075/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/11075/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/11075/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/0c938dd2174843a62cfda0ee3e51b63758081db9"}}}} | {
"id": 41766002,
"name": "ampproject/amphtml",
"url": "https://api.github.com/repos/ampproject/amphtml"
} | {
"id": 8496897,
"login": "lannka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8496897?",
"url": "https://api.github.com/users/lannka"
} | {
"id": 14114390,
"login": "ampproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14114390?",
"url": "https://api.github.com/orgs/ampproject"
} | 2017-08-23T22:42:47 | 6504839856 | {"actor":{"display_login":"lannka"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/103827988","pull_request_review_id":24630234,"id":103827988,"diff_hunk":"@@ -241,40 +363,100 @@ const cachePromise = self.caches.open('cdn-js').then(result => {\n * @param {!Cache} cache\n * @param {!Request} request\n * @param {string} requestPath the pathname of the request\n- * @param {RtvVersion} requestVersion the version of the request\n+ * @param {!RtvVersion} requestVersion the version of the request\n * @return {!Promise<!Response>}\n * @visibleForTesting\n */\n-export function fetchAndCache(cache, request, requestPath, requestVersion) {\n+export function fetchJsFile(cache, request, requestPath, requestVersion) {\n // TODO(jridgewell): we should also fetch this requestVersion for all files\n // we know about.\n- return fetch(request).then(response => {\n- // Did we receive a valid response (200 <= status < 300)?\n- if (response && response.ok) {\n- // You must clone to prevent double reading the body.\n- cache.put(request, response.clone());\n-\n- // Prune old versions of this file from the cache.\n- // This intentionally does not block the request resolution to speed\n- // things up. This is likely fine since you don't have multiple\n- // `<script>`s with the same `src` on a page.\n- cache.keys().then(requests => {\n- for (let i = 0; i < requests.length; i++) {\n- const request = requests[i];\n- const url = request.url;\n- if (requestPath !== pathname(url)) {\n- continue;\n- }\n- if (requestVersion === rtvVersion(url)) {\n- continue;\n- }\n+ return fetchAndCache(cache, request).then(response => {\n+ // Fetch all diversions of this file.\n+ // This intentionally does not block the request resolution to speed\n+ // things up.\n+ diversions(cache).then(diversions => {","path":"src/service-worker/core.js","position":323,"original_position":317,"commit_id":"7521d41d4667531d365988a3ccaf7bd228418984","original_commit_id":"8b1caaa7e6346a0cfc51ede75a3f160506e25646","user":{"login":"cramforce","id":89679,"avatar_url":"https://avatars1.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"body":"Not in the critical path, but I'm seeing us bandwidth constraint downloading JS a lot!","created_at":"2017-03-02T00:51:53Z","updated_at":"2017-03-02T00:51:53Z","html_url":"https://github.com/ampproject/amphtml/pull/7914#discussion_r103827988","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7914","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/103827988"},"html":{"href":"https://github.com/ampproject/amphtml/pull/7914#discussion_r103827988"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7914"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/7914","id":108647760,"html_url":"https://github.com/ampproject/amphtml/pull/7914","diff_url":"https://github.com/ampproject/amphtml/pull/7914.diff","patch_url":"https://github.com/ampproject/amphtml/pull/7914.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/7914","number":7914,"state":"open","locked":false,"title":"Cache SW: Support Precent Diversions","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars2.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"This introduces the concept of RTV environments and the `/diversions` endpoint to the Cache SW.\r\n\r\nThe Cache SW now understands the \"production\" environment, and arbitrary diversion environments. The production env is whatever the env of the SW's version (the RTV is part of the Sw's bundled code). Any other env is considered a diversion.\r\n\r\nDiversions are treated specially inside the stale-while-revalidate logic. Firstly, a diversion will never be served in place of (a \"stale\" serve) a request to a production env. Only cached scripts in the production environment can be stale served for a production request. Secondly, any request for a diversion will _always_ be served with that version (hopefully from cache). That is, diversion requests are never stale served an older version. This is because stale serving a 3 week old diversion is useless for our data collection.\r\n\r\nNow for the `/diversions` endpoint. The SW will maintain a cached request to the endpoint, and the endpoint returns a JSON encoded array of diversion RTVs (note, they must not be production ENV). Whenever the SW \"revalidates\" (grabs a newer copy of a production script in the background), we will issue requests for the current diversions of the script as well. This allows us to eagerly cache our diversions, making sure they will be served as speedily as our normal production scripts (and we don't see any false-negative stats).\r\n\r\nThe `/diversions` endpoint will be live soon. 🤞","created_at":"2017-03-01T22:51:49Z","updated_at":"2017-03-02T00:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4611eea6544f4e554b79a55f792574683f0bd8f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7914/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7914/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/7914/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/7521d41d4667531d365988a3ccaf7bd228418984","head":{"label":"jridgewell:cache-sw-diversions","ref":"cache-sw-diversions","sha":"7521d41d4667531d365988a3ccaf7bd228418984","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars2.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":48198933,"name":"amphtml","full_name":"jridgewell/amphtml","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars2.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/amphtml","description":"AMP HTML source code, samples, and documentation. See below for more info.","fork":true,"url":"https://api.github.com/repos/jridgewell/amphtml","forks_url":"https://api.github.com/repos/jridgewell/amphtml/forks","keys_url":"https://api.github.com/repos/jridgewell/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/amphtml/teams","hooks_url":"https://api.github.com/repos/jridgewell/amphtml/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/amphtml/events","assignees_url":"https://api.github.com/repos/jridgewell/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/amphtml/tags","blobs_url":"https://api.github.com/repos/jridgewell/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/amphtml/languages","stargazers_url":"https://api.github.com/repos/jridgewell/amphtml/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/amphtml/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/amphtml/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/amphtml/subscription","commits_url":"https://api.github.com/repos/jridgewell/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/amphtml/merges","archive_url":"https://api.github.com/repos/jridgewell/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/amphtml/downloads","issues_url":"https://api.github.com/repos/jridgewell/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/jridgewell/amphtml/deployments","created_at":"2015-12-17T21:21:35Z","updated_at":"2016-11-03T19:21:35Z","pushed_at":"2017-03-02T00:46:47Z","git_url":"git://github.com/jridgewell/amphtml.git","ssh_url":"[email protected]:jridgewell/amphtml.git","clone_url":"https://github.com/jridgewell/amphtml.git","svn_url":"https://github.com/jridgewell/amphtml","homepage":"http://justin.ridgewell.name/amphtml/","size":230800,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"694af90df1ebb54f268a890d5b3ed8513d137d37","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars0.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars0.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation. See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-03-02T00:50:43Z","pushed_at":"2017-03-02T00:46:49Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"[email protected]:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":229600,"stargazers_count":9669,"watchers_count":9669,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1597,"mirror_url":null,"open_issues_count":667,"forks":1597,"open_issues":667,"watchers":9669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7914"},"html":{"href":"https://github.com/ampproject/amphtml/pull/7914"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/7914"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/7914/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7914/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7914/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/7521d41d4667531d365988a3ccaf7bd228418984"}}}} | {
"id": 41766002,
"name": "ampproject/amphtml",
"url": "https://api.github.com/repos/ampproject/amphtml"
} | {
"id": 89679,
"login": "cramforce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/89679?",
"url": "https://api.github.com/users/cramforce"
} | {
"id": 14114390,
"login": "ampproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14114390?",
"url": "https://api.github.com/orgs/ampproject"
} | 2017-03-02T00:51:53 | 5416535019 | {"actor":{"display_login":"cramforce"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/comments/99432832","pull_request_review_id":20114656,"id":99432832,"diff_hunk":"@@ -1,238 +1,261 @@\n-.c-answers{\n+.c-answers {\n padding: 0 3rem;\n }\n \n-.o-grid{\n+.o-grid {\n @include display-flex;\n @include justify-content(space-between);\n @include align-items(stretch);\n }\n \n- .c-answer-container{\n- @include flex(0 0 49%);\n- @include answer-styling;\n- border-radius: $radius;\n- min-height: 3.5rem;\n- position: relative;\n- padding: 0.8rem 0.8rem 0;\n- margin-bottom: 1.5rem;\n- cursor: pointer;\n- @include transition(all 0.1s ease);\n-\n- &:hover{\n- @include answer-hover;\n- }\n+.c-answer-container {\n+ @include flex(0 0 49%);\n+ @include answer-styling;\n+ border-radius: $radius;\n+ min-height: 3.5rem;\n+ position: relative;\n+ padding: 0.8rem 0.8rem 0;\n+ margin-bottom: 1.5rem;\n+ cursor: pointer;\n+ @include transition(all 0.1s ease);\n+\n+ &:hover {\n+ @include answer-hover;\n+ }\n \n- &.is-clicked{\n- @include answer-clicked;\n+ &.is-clicked {\n+ @include answer-clicked;\n \n- .c-answer-container__content{\n- p{\n- color: $answer-text-clicked;\n- }\n+ .c-answer-container__content {\n+ p {\n+ color: $answer-text-clicked;\n }\n+ }\n \n- .c-feedback{\n- background: $answer-result-background-clicked;\n- }\n+ .c-feedback {\n+ background: $answer-result-background-clicked;\n }\n }\n+}\n+\n+.c-answer-container__radio {\n+ width: 2rem;\n+ position: absolute;\n+ left: 0.8rem;\n+ top: 0.8rem;\n+}\n \n- .c-answer-container__radio{\n- width: 2rem;\n+.c-radio-button {\n+\n+ .c-radio-button__border {\n+ display: inline-block;\n+ cursor: pointer;\n+ position: relative;\n+ height: 1.5rem;\n+ width: 1.5rem;\n+ border-radius: 50%;\n+ border: 0.2rem solid $radio-color;\n+ margin: 0.2rem;\n+ }\n+\n+ input[type=\"radio\"]:checked + .c-radio-button__border::before {\n+ content: \"\";\n+ width: .7rem;\n+ height: .7rem;\n+ background: $radio-selected;\n+ border-radius: 50%;\n position: absolute;\n- left: 0.8rem;\n- top: 0.8rem;\n+ top: 0.2rem;\n+ left: 0.2rem;\n }\n \n- .c-radio-button{\n+ input[type=\"radio\"]:checked + .c-radio-button__border {\n+ border-color: $radio-selected;\n+ }\n \n- .c-radio-button__border{\n- display: inline-block;\n- cursor: pointer;\n- position: relative;\n- height: 1.5rem;\n- width: 1.5rem;\n- border-radius: 50%;\n- border: 0.2rem solid $radio-color;\n- margin: 0.2rem;\n- }\n+ input {\n+ display: none;\n+ margin: 0;\n+ height: 0.01rem;\n+ width: 0.01rem;\n+ }\n+}\n \n- input[type=\"radio\"]:checked + .c-radio-button__border:before{\n- content: '';\n- width: .7rem;\n- height: .7rem;\n- background: $radio-selected;\n- border-radius: 50%;\n- position: absolute;\n- top: 0.2rem;\n- left: 0.2rem;\n- }\n+.c-checkbox {\n \n- input[type=\"radio\"]:checked + .c-radio-button__border{\n- border-color: $radio-selected;\n- }\n+ .c-checkbox__border {\n+ display: inline-block;\n+ cursor: pointer;\n+ position: relative;\n+ height: 1.5rem;\n+ width: 1.5rem;\n+ border-radius: 0.3rem;\n+ border: 0.2rem solid $radio-color;\n+ margin: 0.2rem;\n+ }\n \n- input{\n- display: none;\n- margin: 0;\n- height: 0.01rem;\n- width: 0.01rem;\n- }\n+ input[type=\"checkbox\"]:checked + .c-checkbox__border::before {\n+ content: '';\n+ width: 0.3rem;\n+ height: 0.8rem;\n+ border: solid $primary;\n+ border-width: 0 0.2rem 0.2rem 0;\n+ position: absolute;\n+ transform: rotate(45deg);\n+ top: 0;\n+ left: 0.3rem;\n }\n \n- .c-checkbox{\n-\n- .c-checkbox__border{\n- display: inline-block;\n- cursor: pointer;\n- position: relative;\n- height: 1.5rem;\n- width: 1.5rem;\n- border-radius: 0.3rem;\n- border: 0.2rem solid $radio-color;\n- margin: 0.2rem;\n- }\n+ input[type=\"checkbox\"]:checked + .c-checkbox__border {\n+ border-color: $radio-selected;\n+ background: $radio-selected;\n+ }\n \n- input[type=\"checkbox\"]:checked + .c-checkbox__border:before{\n- content: '';\n- width: 0.3rem;\n- height: 0.8rem;\n- border: solid $primary;\n- border-width: 0 0.2rem 0.2rem 0;\n- position: absolute;\n- transform: rotate(45deg);\n- top: 0;\n- left: 0.3rem;\n- }\n+ input {\n+ display: none;\n+ margin: 0;\n+ height: 0.01rem;\n+ width: 0.01rem;\n+ }\n+}\n \n- input[type=\"checkbox\"]:checked + .c-checkbox__border{\n- border-color: $radio-selected;\n- background: $radio-selected;\n- }\n+.c-answer-container__content {\n+ width: 100%;\n+ padding-left: 3rem;\n+ @include regular;\n+ font-size: 1.4rem;\n+ color: $answer-text;\n \n- input{\n- display: none;\n- margin: 0;\n- height: 0.01rem;\n- width: 0.01rem;\n- }\n+ & > * {\n+ margin-bottom: 1rem;\n+ }\n+\n+ img {\n+ display: inline-block;\n+ max-width: 20rem;\n }\n \n- .c-answer-container__content{\n+ audio {\n width: 100%;\n- padding-left: 3rem;\n- @include regular;\n- font-size: 1.4rem;\n- color: $answer-text;\n+ }\n+}\n \n- & > * {\n- margin-bottom: 1rem;\n- }\n+.c-record {\n+ padding: 2rem 3rem 1rem;\n+ @include display-flex;\n+ @include align-items(center);\n+}\n \n- img{\n- display: inline-block;\n- max-width: 20rem;\n- }\n+.c-audio-holder {\n+ padding: .5rem 1.14rem .65rem 0;\n+ @include flex(1);\n+ margin-left: 1rem;\n \n- audio{\n- width: 100%;\n- }\n+ audio {\n+ width: 100%;\n }\n+}\n \n- .c-record{\n- padding: 2rem 3rem 1rem;\n- @include display-flex;\n- @include align-items(center);\n+.c-audio-timer {\n+ padding: .08rem 1.14rem .1rem 0;\n+ @include light;\n+ color: #5a5a5a;\n+ font-size: 2.2rem;\n \n- audio{\n- @include flex(1);\n- margin-left: 1rem;\n- }\n+ small {\n+ @include regular;\n+ font-size: 1.3rem;\n }\n+}\n \n- .c-btn--record{\n- border-color: $incorrect;\n- width: 10.5rem;\n- @include transition(all 0.1s ease);\n+.c-btn--record {\n+ @include transition(all 0.1s ease);\n+ border-color: $incorrect;\n+ width: 10.5rem;\n \n- &:hover{\n- background: $incorrect;\n+ &:hover {\n+ background: $incorrect;\n \n- span{\n- color: $white;\n- &:before{\n- background: $white;\n- }\n- }\n- }\n+ span {\n+ color: $white;\n \n- span{\n- padding-left: 1.7rem;\n- color: $incorrect;\n- position: relative;\n- @include transition(all 0.1s ease);\n-\n- &:before{\n- content: '';\n- position: absolute;\n- left: -0.5rem;\n- top: 0.9rem;\n- width: 1.2rem;\n- height: 1.2rem;\n- border-radius: 50%;\n- background: $incorrect;\n+ &::before {\n+ background: $white;\n }\n }\n+ }\n \n- &.c-btn--stop{\n- span{\n- color: $white;\n- &:before{\n- background: $white;\n- }\n- }\n+ span {\n+ padding-left: 1.7rem;\n+ color: $incorrect;\n+ position: relative;\n+ @include transition(all 0.1s ease);\n+\n+ &::before {\n+ content: \"\";\n+ position: absolute;\n+ left: -0.5rem;\n+ top: 0.9rem;\n+ width: 1.2rem;\n+ height: 1.2rem;\n+ border-radius: 50%;\n background: $incorrect;\n- span:before{\n- animation: blink 2s linear infinite;\n- -webkit-animation: blink 2s linear infinite;\n- }\n- }\n- &.c-btn--stop:active{\n- background: darken($incorrect, 15%);\n- border-color: darken($incorrect, 15%);\n }\n }\n \n- @keyframes blink {\n- 0%{\n- opacity: 1;\n- }\n- 50%{\n- opacity: 0;\n+ &.c-btn--stop {\n+ span {\n+ color: $white;\n+\n+ &::before {\n+ background: $white;\n+ }\n }\n- 100%{\n- opacity: 1;\n+ background: $incorrect;\n+\n+ span::before {\n+ animation: blink 2s linear infinite;\n+ -webkit-animation: blink 2s linear infinite;","path":"client/styles/components/_components.answers.scss","position":384,"original_position":384,"commit_id":"9de4cf0b940ad4cda79a8fd93b6d614553cf2b0d","original_commit_id":"9de4cf0b940ad4cda79a8fd93b6d614553cf2b0d","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Avoid vendor prefixes.","created_at":"2017-02-03T22:08:24Z","updated_at":"2017-02-03T22:08:24Z","html_url":"https://github.com/atomicjolt/open_assessments/pull/113#discussion_r99432832","pull_request_url":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/comments/99432832"},"html":{"href":"https://github.com/atomicjolt/open_assessments/pull/113#discussion_r99432832"},"pull_request":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/113","id":104621165,"html_url":"https://github.com/atomicjolt/open_assessments/pull/113","diff_url":"https://github.com/atomicjolt/open_assessments/pull/113.diff","patch_url":"https://github.com/atomicjolt/open_assessments/pull/113.patch","issue_url":"https://api.github.com/repos/atomicjolt/open_assessments/issues/113","number":113,"state":"open","locked":false,"title":"Feature/km/add recorder timer","user":{"login":"resource11","id":11621935,"avatar_url":"https://avatars.githubusercontent.com/u/11621935?v=3","gravatar_id":"","url":"https://api.github.com/users/resource11","html_url":"https://github.com/resource11","followers_url":"https://api.github.com/users/resource11/followers","following_url":"https://api.github.com/users/resource11/following{/other_user}","gists_url":"https://api.github.com/users/resource11/gists{/gist_id}","starred_url":"https://api.github.com/users/resource11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resource11/subscriptions","organizations_url":"https://api.github.com/users/resource11/orgs","repos_url":"https://api.github.com/users/resource11/repos","events_url":"https://api.github.com/users/resource11/events{/privacy}","received_events_url":"https://api.github.com/users/resource11/received_events","type":"User","site_admin":false},"body":"# Code-review checklist #\r\n\r\n * Documentation\r\n * [ ] Interfaces describe how other programmers would use them.\r\n * [ ] Code that is not obvious has documentation describing why\r\n that code is the way it is.\r\n","created_at":"2017-02-03T22:08:12Z","updated_at":"2017-02-03T22:08:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f38a1ba30056b79f1cb29f5088307d9b53711fc6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/113/commits","review_comments_url":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/113/comments","review_comment_url":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atomicjolt/open_assessments/issues/113/comments","statuses_url":"https://api.github.com/repos/atomicjolt/open_assessments/statuses/9de4cf0b940ad4cda79a8fd93b6d614553cf2b0d","head":{"label":"CLIxIndia-Dev:feature/km/add-recorder-timer","ref":"feature/km/add-recorder-timer","sha":"9de4cf0b940ad4cda79a8fd93b6d614553cf2b0d","user":{"login":"CLIxIndia-Dev","id":20460497,"avatar_url":"https://avatars.githubusercontent.com/u/20460497?v=3","gravatar_id":"","url":"https://api.github.com/users/CLIxIndia-Dev","html_url":"https://github.com/CLIxIndia-Dev","followers_url":"https://api.github.com/users/CLIxIndia-Dev/followers","following_url":"https://api.github.com/users/CLIxIndia-Dev/following{/other_user}","gists_url":"https://api.github.com/users/CLIxIndia-Dev/gists{/gist_id}","starred_url":"https://api.github.com/users/CLIxIndia-Dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLIxIndia-Dev/subscriptions","organizations_url":"https://api.github.com/users/CLIxIndia-Dev/orgs","repos_url":"https://api.github.com/users/CLIxIndia-Dev/repos","events_url":"https://api.github.com/users/CLIxIndia-Dev/events{/privacy}","received_events_url":"https://api.github.com/users/CLIxIndia-Dev/received_events","type":"Organization","site_admin":false},"repo":{"id":76967939,"name":"OpenAssessmentsClient","full_name":"CLIxIndia-Dev/OpenAssessmentsClient","owner":{"login":"CLIxIndia-Dev","id":20460497,"avatar_url":"https://avatars.githubusercontent.com/u/20460497?v=3","gravatar_id":"","url":"https://api.github.com/users/CLIxIndia-Dev","html_url":"https://github.com/CLIxIndia-Dev","followers_url":"https://api.github.com/users/CLIxIndia-Dev/followers","following_url":"https://api.github.com/users/CLIxIndia-Dev/following{/other_user}","gists_url":"https://api.github.com/users/CLIxIndia-Dev/gists{/gist_id}","starred_url":"https://api.github.com/users/CLIxIndia-Dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLIxIndia-Dev/subscriptions","organizations_url":"https://api.github.com/users/CLIxIndia-Dev/orgs","repos_url":"https://api.github.com/users/CLIxIndia-Dev/repos","events_url":"https://api.github.com/users/CLIxIndia-Dev/events{/privacy}","received_events_url":"https://api.github.com/users/CLIxIndia-Dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CLIxIndia-Dev/OpenAssessmentsClient","description":"Client only version of Open Assessments","fork":true,"url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient","forks_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/forks","keys_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/teams","hooks_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/hooks","issue_events_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/issues/events{/number}","events_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/events","assignees_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/assignees{/user}","branches_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/branches{/branch}","tags_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/tags","blobs_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/statuses/{sha}","languages_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/languages","stargazers_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/stargazers","contributors_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/contributors","subscribers_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/subscribers","subscription_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/subscription","commits_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/contents/{+path}","compare_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/merges","archive_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/downloads","issues_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/issues{/number}","pulls_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/pulls{/number}","milestones_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/milestones{/number}","notifications_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/labels{/name}","releases_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/releases{/id}","deployments_url":"https://api.github.com/repos/CLIxIndia-Dev/OpenAssessmentsClient/deployments","created_at":"2016-12-20T15:27:10Z","updated_at":"2016-12-20T15:27:16Z","pushed_at":"2017-02-03T22:04:38Z","git_url":"git://github.com/CLIxIndia-Dev/OpenAssessmentsClient.git","ssh_url":"[email protected]:CLIxIndia-Dev/OpenAssessmentsClient.git","clone_url":"https://github.com/CLIxIndia-Dev/OpenAssessmentsClient.git","svn_url":"https://github.com/CLIxIndia-Dev/OpenAssessmentsClient","homepage":null,"size":30041,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atomicjolt:master","ref":"master","sha":"c1a08dd06ed3a0f4b59757c5a89c736395c7bcae","user":{"login":"atomicjolt","id":7516397,"avatar_url":"https://avatars.githubusercontent.com/u/7516397?v=3","gravatar_id":"","url":"https://api.github.com/users/atomicjolt","html_url":"https://github.com/atomicjolt","followers_url":"https://api.github.com/users/atomicjolt/followers","following_url":"https://api.github.com/users/atomicjolt/following{/other_user}","gists_url":"https://api.github.com/users/atomicjolt/gists{/gist_id}","starred_url":"https://api.github.com/users/atomicjolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomicjolt/subscriptions","organizations_url":"https://api.github.com/users/atomicjolt/orgs","repos_url":"https://api.github.com/users/atomicjolt/repos","events_url":"https://api.github.com/users/atomicjolt/events{/privacy}","received_events_url":"https://api.github.com/users/atomicjolt/received_events","type":"Organization","site_admin":false},"repo":{"id":60113762,"name":"open_assessments","full_name":"atomicjolt/open_assessments","owner":{"login":"atomicjolt","id":7516397,"avatar_url":"https://avatars.githubusercontent.com/u/7516397?v=3","gravatar_id":"","url":"https://api.github.com/users/atomicjolt","html_url":"https://github.com/atomicjolt","followers_url":"https://api.github.com/users/atomicjolt/followers","following_url":"https://api.github.com/users/atomicjolt/following{/other_user}","gists_url":"https://api.github.com/users/atomicjolt/gists{/gist_id}","starred_url":"https://api.github.com/users/atomicjolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomicjolt/subscriptions","organizations_url":"https://api.github.com/users/atomicjolt/orgs","repos_url":"https://api.github.com/users/atomicjolt/repos","events_url":"https://api.github.com/users/atomicjolt/events{/privacy}","received_events_url":"https://api.github.com/users/atomicjolt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atomicjolt/open_assessments","description":"Open Assessments client and Authoring","fork":false,"url":"https://api.github.com/repos/atomicjolt/open_assessments","forks_url":"https://api.github.com/repos/atomicjolt/open_assessments/forks","keys_url":"https://api.github.com/repos/atomicjolt/open_assessments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomicjolt/open_assessments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomicjolt/open_assessments/teams","hooks_url":"https://api.github.com/repos/atomicjolt/open_assessments/hooks","issue_events_url":"https://api.github.com/repos/atomicjolt/open_assessments/issues/events{/number}","events_url":"https://api.github.com/repos/atomicjolt/open_assessments/events","assignees_url":"https://api.github.com/repos/atomicjolt/open_assessments/assignees{/user}","branches_url":"https://api.github.com/repos/atomicjolt/open_assessments/branches{/branch}","tags_url":"https://api.github.com/repos/atomicjolt/open_assessments/tags","blobs_url":"https://api.github.com/repos/atomicjolt/open_assessments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomicjolt/open_assessments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomicjolt/open_assessments/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomicjolt/open_assessments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomicjolt/open_assessments/statuses/{sha}","languages_url":"https://api.github.com/repos/atomicjolt/open_assessments/languages","stargazers_url":"https://api.github.com/repos/atomicjolt/open_assessments/stargazers","contributors_url":"https://api.github.com/repos/atomicjolt/open_assessments/contributors","subscribers_url":"https://api.github.com/repos/atomicjolt/open_assessments/subscribers","subscription_url":"https://api.github.com/repos/atomicjolt/open_assessments/subscription","commits_url":"https://api.github.com/repos/atomicjolt/open_assessments/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomicjolt/open_assessments/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomicjolt/open_assessments/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomicjolt/open_assessments/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomicjolt/open_assessments/contents/{+path}","compare_url":"https://api.github.com/repos/atomicjolt/open_assessments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomicjolt/open_assessments/merges","archive_url":"https://api.github.com/repos/atomicjolt/open_assessments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomicjolt/open_assessments/downloads","issues_url":"https://api.github.com/repos/atomicjolt/open_assessments/issues{/number}","pulls_url":"https://api.github.com/repos/atomicjolt/open_assessments/pulls{/number}","milestones_url":"https://api.github.com/repos/atomicjolt/open_assessments/milestones{/number}","notifications_url":"https://api.github.com/repos/atomicjolt/open_assessments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomicjolt/open_assessments/labels{/name}","releases_url":"https://api.github.com/repos/atomicjolt/open_assessments/releases{/id}","deployments_url":"https://api.github.com/repos/atomicjolt/open_assessments/deployments","created_at":"2016-05-31T18:31:54Z","updated_at":"2017-01-24T21:46:22Z","pushed_at":"2017-02-03T22:08:13Z","git_url":"git://github.com/atomicjolt/open_assessments.git","ssh_url":"[email protected]:atomicjolt/open_assessments.git","clone_url":"https://github.com/atomicjolt/open_assessments.git","svn_url":"https://github.com/atomicjolt/open_assessments","homepage":"","size":30038,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/113"},"html":{"href":"https://github.com/atomicjolt/open_assessments/pull/113"},"issue":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/issues/113"},"comments":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/atomicjolt/open_assessments/statuses/9de4cf0b940ad4cda79a8fd93b6d614553cf2b0d"}}}} | {
"id": 60113762,
"name": "atomicjolt/open_assessments",
"url": "https://api.github.com/repos/atomicjolt/open_assessments"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 7516397,
"login": "atomicjolt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7516397?",
"url": "https://api.github.com/orgs/atomicjolt"
} | 2017-02-03T22:08:24 | 5264666982 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/comments/155932508","pull_request_review_id":82335538,"id":155932508,"diff_hunk":"@@ -72,18 +59,44 @@ function getPlatforms(includeChromeOs) {\n return platforms;\n }\n \n-function getRunDebugAppCommand() {\n+// Gets the default platform to be used\n+function getDefaultPlatform() {\n+ var defaultPlatform;\n switch (os.platform()) {\n case 'darwin':\n- return 'open ' + path.join(debugDir, pkg.name, 'osx64', pkg.name + '.app');\n+ defaultPlatform = 'osx64';\n \n break;\n case 'linux':\n- return path.join(debugDir, pkg.name, 'linux64', pkg.name);\n+ defaultPlatform = 'linux64';\n+\n+ break;\n+ case 'win32':\n+ defaultPlatform = 'win32';\n+\n+ break;\n+ \n+ default:\n+ defaultPlatform = os.platform();","path":"gulpfile.js","position":60,"original_position":60,"commit_id":"9ae5780fc993159da8165a7978d81a5170190971","original_commit_id":"9ae5780fc993159da8165a7978d81a5170190971","user":{"login":"mikeller","id":4742747,"avatar_url":"https://avatars1.githubusercontent.com/u/4742747?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeller","html_url":"https://github.com/mikeller","followers_url":"https://api.github.com/users/mikeller/followers","following_url":"https://api.github.com/users/mikeller/following{/other_user}","gists_url":"https://api.github.com/users/mikeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeller/subscriptions","organizations_url":"https://api.github.com/users/mikeller/orgs","repos_url":"https://api.github.com/users/mikeller/repos","events_url":"https://api.github.com/users/mikeller/events{/privacy}","received_events_url":"https://api.github.com/users/mikeller/received_events","type":"User","site_admin":false},"body":"I suspect that this will break for most cases. Do you have any examples where this actually works? If not, this should just return null.","created_at":"2017-12-09T21:16:56Z","updated_at":"2017-12-09T21:19:32Z","html_url":"https://github.com/betaflight/betaflight-configurator/pull/775#discussion_r155932508","pull_request_url":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/775","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/comments/155932508"},"html":{"href":"https://github.com/betaflight/betaflight-configurator/pull/775#discussion_r155932508"},"pull_request":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/775"}}},"pull_request":{"url":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/775","id":157018641,"html_url":"https://github.com/betaflight/betaflight-configurator/pull/775","diff_url":"https://github.com/betaflight/betaflight-configurator/pull/775.diff","patch_url":"https://github.com/betaflight/betaflight-configurator/pull/775.patch","issue_url":"https://api.github.com/repos/betaflight/betaflight-configurator/issues/775","number":775,"state":"open","locked":false,"title":"Add support for win64 platform","user":{"login":"McGiverGim","id":2673520,"avatar_url":"https://avatars3.githubusercontent.com/u/2673520?v=4","gravatar_id":"","url":"https://api.github.com/users/McGiverGim","html_url":"https://github.com/McGiverGim","followers_url":"https://api.github.com/users/McGiverGim/followers","following_url":"https://api.github.com/users/McGiverGim/following{/other_user}","gists_url":"https://api.github.com/users/McGiverGim/gists{/gist_id}","starred_url":"https://api.github.com/users/McGiverGim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McGiverGim/subscriptions","organizations_url":"https://api.github.com/users/McGiverGim/orgs","repos_url":"https://api.github.com/users/McGiverGim/repos","events_url":"https://api.github.com/users/McGiverGim/events{/privacy}","received_events_url":"https://api.github.com/users/McGiverGim/received_events","type":"User","site_admin":false},"body":"Added support to create and execute native win64 platforms.","created_at":"2017-12-07T15:07:37Z","updated_at":"2017-12-09T21:19:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9eb051ab85a83a941871ae0d43dfa8f5756d914","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/775/commits","review_comments_url":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/775/comments","review_comment_url":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betaflight/betaflight-configurator/issues/775/comments","statuses_url":"https://api.github.com/repos/betaflight/betaflight-configurator/statuses/9ae5780fc993159da8165a7978d81a5170190971","head":{"label":"McGiverGim:bf-gulp_win64_support","ref":"bf-gulp_win64_support","sha":"9ae5780fc993159da8165a7978d81a5170190971","user":{"login":"McGiverGim","id":2673520,"avatar_url":"https://avatars3.githubusercontent.com/u/2673520?v=4","gravatar_id":"","url":"https://api.github.com/users/McGiverGim","html_url":"https://github.com/McGiverGim","followers_url":"https://api.github.com/users/McGiverGim/followers","following_url":"https://api.github.com/users/McGiverGim/following{/other_user}","gists_url":"https://api.github.com/users/McGiverGim/gists{/gist_id}","starred_url":"https://api.github.com/users/McGiverGim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McGiverGim/subscriptions","organizations_url":"https://api.github.com/users/McGiverGim/orgs","repos_url":"https://api.github.com/users/McGiverGim/repos","events_url":"https://api.github.com/users/McGiverGim/events{/privacy}","received_events_url":"https://api.github.com/users/McGiverGim/received_events","type":"User","site_admin":false},"repo":{"id":87694386,"name":"cleanflight-configurator","full_name":"McGiverGim/cleanflight-configurator","owner":{"login":"McGiverGim","id":2673520,"avatar_url":"https://avatars3.githubusercontent.com/u/2673520?v=4","gravatar_id":"","url":"https://api.github.com/users/McGiverGim","html_url":"https://github.com/McGiverGim","followers_url":"https://api.github.com/users/McGiverGim/followers","following_url":"https://api.github.com/users/McGiverGim/following{/other_user}","gists_url":"https://api.github.com/users/McGiverGim/gists{/gist_id}","starred_url":"https://api.github.com/users/McGiverGim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McGiverGim/subscriptions","organizations_url":"https://api.github.com/users/McGiverGim/orgs","repos_url":"https://api.github.com/users/McGiverGim/repos","events_url":"https://api.github.com/users/McGiverGim/events{/privacy}","received_events_url":"https://api.github.com/users/McGiverGim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/McGiverGim/cleanflight-configurator","description":"Google chrome/chromium based configuration tool for the cleanflight firmware","fork":true,"url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator","forks_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/forks","keys_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/teams","hooks_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/hooks","issue_events_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/issues/events{/number}","events_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/events","assignees_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/assignees{/user}","branches_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/branches{/branch}","tags_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/tags","blobs_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/git/refs{/sha}","trees_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/statuses/{sha}","languages_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/languages","stargazers_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/stargazers","contributors_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/contributors","subscribers_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/subscribers","subscription_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/subscription","commits_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/commits{/sha}","git_commits_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/git/commits{/sha}","comments_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/comments{/number}","issue_comment_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/issues/comments{/number}","contents_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/contents/{+path}","compare_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/merges","archive_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/downloads","issues_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/issues{/number}","pulls_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/pulls{/number}","milestones_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/milestones{/number}","notifications_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/labels{/name}","releases_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/releases{/id}","deployments_url":"https://api.github.com/repos/McGiverGim/cleanflight-configurator/deployments","created_at":"2017-04-09T08:37:35Z","updated_at":"2017-04-09T08:37:38Z","pushed_at":"2017-12-08T08:25:22Z","git_url":"git://github.com/McGiverGim/cleanflight-configurator.git","ssh_url":"[email protected]:McGiverGim/cleanflight-configurator.git","clone_url":"https://github.com/McGiverGim/cleanflight-configurator.git","svn_url":"https://github.com/McGiverGim/cleanflight-configurator","homepage":"","size":23878,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"betaflight:master","ref":"master","sha":"c3422fc7f559ed1f1cb00696a09fadc1d8a8ee69","user":{"login":"betaflight","id":19597933,"avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"repo":{"id":60735171,"name":"betaflight-configurator","full_name":"betaflight/betaflight-configurator","owner":{"login":"betaflight","id":19597933,"avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/betaflight/betaflight-configurator","description":"Google chrome/chromium based configuration tool for the cleanflight firmware","fork":true,"url":"https://api.github.com/repos/betaflight/betaflight-configurator","forks_url":"https://api.github.com/repos/betaflight/betaflight-configurator/forks","keys_url":"https://api.github.com/repos/betaflight/betaflight-configurator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betaflight/betaflight-configurator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betaflight/betaflight-configurator/teams","hooks_url":"https://api.github.com/repos/betaflight/betaflight-configurator/hooks","issue_events_url":"https://api.github.com/repos/betaflight/betaflight-configurator/issues/events{/number}","events_url":"https://api.github.com/repos/betaflight/betaflight-configurator/events","assignees_url":"https://api.github.com/repos/betaflight/betaflight-configurator/assignees{/user}","branches_url":"https://api.github.com/repos/betaflight/betaflight-configurator/branches{/branch}","tags_url":"https://api.github.com/repos/betaflight/betaflight-configurator/tags","blobs_url":"https://api.github.com/repos/betaflight/betaflight-configurator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betaflight/betaflight-configurator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betaflight/betaflight-configurator/git/refs{/sha}","trees_url":"https://api.github.com/repos/betaflight/betaflight-configurator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betaflight/betaflight-configurator/statuses/{sha}","languages_url":"https://api.github.com/repos/betaflight/betaflight-configurator/languages","stargazers_url":"https://api.github.com/repos/betaflight/betaflight-configurator/stargazers","contributors_url":"https://api.github.com/repos/betaflight/betaflight-configurator/contributors","subscribers_url":"https://api.github.com/repos/betaflight/betaflight-configurator/subscribers","subscription_url":"https://api.github.com/repos/betaflight/betaflight-configurator/subscription","commits_url":"https://api.github.com/repos/betaflight/betaflight-configurator/commits{/sha}","git_commits_url":"https://api.github.com/repos/betaflight/betaflight-configurator/git/commits{/sha}","comments_url":"https://api.github.com/repos/betaflight/betaflight-configurator/comments{/number}","issue_comment_url":"https://api.github.com/repos/betaflight/betaflight-configurator/issues/comments{/number}","contents_url":"https://api.github.com/repos/betaflight/betaflight-configurator/contents/{+path}","compare_url":"https://api.github.com/repos/betaflight/betaflight-configurator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betaflight/betaflight-configurator/merges","archive_url":"https://api.github.com/repos/betaflight/betaflight-configurator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betaflight/betaflight-configurator/downloads","issues_url":"https://api.github.com/repos/betaflight/betaflight-configurator/issues{/number}","pulls_url":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls{/number}","milestones_url":"https://api.github.com/repos/betaflight/betaflight-configurator/milestones{/number}","notifications_url":"https://api.github.com/repos/betaflight/betaflight-configurator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betaflight/betaflight-configurator/labels{/name}","releases_url":"https://api.github.com/repos/betaflight/betaflight-configurator/releases{/id}","deployments_url":"https://api.github.com/repos/betaflight/betaflight-configurator/deployments","created_at":"2016-06-08T22:32:34Z","updated_at":"2017-12-08T16:18:25Z","pushed_at":"2017-12-08T16:25:15Z","git_url":"git://github.com/betaflight/betaflight-configurator.git","ssh_url":"[email protected]:betaflight/betaflight-configurator.git","clone_url":"https://github.com/betaflight/betaflight-configurator.git","svn_url":"https://github.com/betaflight/betaflight-configurator","homepage":"","size":23159,"stargazers_count":146,"watchers_count":146,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":131,"open_issues":100,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/775"},"html":{"href":"https://github.com/betaflight/betaflight-configurator/pull/775"},"issue":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/issues/775"},"comments":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/issues/775/comments"},"review_comments":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/775/comments"},"review_comment":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/pulls/775/commits"},"statuses":{"href":"https://api.github.com/repos/betaflight/betaflight-configurator/statuses/9ae5780fc993159da8165a7978d81a5170190971"}},"author_association":"NONE"}} | {
"id": 60735171,
"name": "betaflight/betaflight-configurator",
"url": "https://api.github.com/repos/betaflight/betaflight-configurator"
} | {
"id": 4742747,
"login": "mikeller",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4742747?",
"url": "https://api.github.com/users/mikeller"
} | {
"id": 19597933,
"login": "betaflight",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19597933?",
"url": "https://api.github.com/orgs/betaflight"
} | 2017-12-09T21:16:56 | 6966672126 | {"actor":{"display_login":"mikeller"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/104626082","pull_request_review_id":25468277,"id":104626082,"diff_hunk":"@@ -7,85 +7,98 @@ class ConfigurationError(BigchainDBError):\n \"\"\"Raised when there is a problem with server configuration\"\"\"\n \n \n-class OperationError(BigchainDBError):\n- \"\"\"Raised when an operation cannot go through\"\"\"\n-\n-\n-class TransactionDoesNotExist(BigchainDBError):\n- \"\"\"Raised if the transaction is not in the database\"\"\"\n+class DatabaseAlreadyExists(BigchainDBError):\n+ \"\"\"Raised when trying to create the database but the db is already there\"\"\"\n \n \n-class TransactionOwnerError(BigchainDBError):\n- \"\"\"Raised if a user tries to transfer a transaction they don't own\"\"\"\n+class DatabaseDoesNotExist(BigchainDBError):\n+ \"\"\"Raised when trying to delete the database but the db is not there\"\"\"\n \n \n-class DoubleSpend(BigchainDBError):\n- \"\"\"Raised if a double spend is found\"\"\"\n+class StartupError(BigchainDBError):\n+ \"\"\"Raised when there is an error starting up the system\"\"\"\n \n \n-class ValidationError(BigchainDBError):\n- \"\"\"Raised if there was an error in validation\"\"\"\n+class GenesisBlockAlreadyExistsError(BigchainDBError):\n+ \"\"\"Raised when trying to create the already existing genesis block\"\"\"\n \n \n-class InvalidHash(ValidationError):\n- \"\"\"Raised if there was an error checking the hash for a particular\n- operation\"\"\"\n+class CyclicBlockchainError(BigchainDBError):\n+ \"\"\"Raised when there is a cycle in the blockchain\"\"\"\n \n \n-class SchemaValidationError(ValidationError):\n- \"\"\"Raised if there was any error validating an object's schema\"\"\"\n+class KeypairNotFoundException(BigchainDBError):\n+ \"\"\"Raised if operation cannot proceed because the keypair was not given\"\"\"\n \n \n-class InvalidSignature(BigchainDBError):\n- \"\"\"Raised if there was an error checking the signature for a particular\n- operation\"\"\"\n+class KeypairMismatchException(BigchainDBError):\n+ \"\"\"Raised if the private key(s) provided for signing don't match any of the\n+ current owner(s)\"\"\"\n \n \n-class DatabaseAlreadyExists(BigchainDBError):\n- \"\"\"Raised when trying to create the database but the db is already there\"\"\"\n+class OperationError(BigchainDBError):\n+ \"\"\"Raised when an operation cannot go through\"\"\"\n \n \n-class DatabaseDoesNotExist(BigchainDBError):\n- \"\"\"Raised when trying to delete the database but the db is not there\"\"\"\n+################################################################################\n+# Validation errors\n+#\n+# All validation errors (which are handleable errors, not faults) should\n+# subclass ValidationError. However, where possible they should also have their\n+# own distinct type to differentiate them from other validation errors,\n+# especially for the purposes of testing.\n \n \n-class KeypairNotFoundException(BigchainDBError):\n- \"\"\"Raised if operation cannot proceed because the keypair was not given\"\"\"\n+class ValidationError(BigchainDBError):\n+ \"\"\"Raised if there was an error in validation\"\"\"\n \n \n-class KeypairMismatchException(BigchainDBError):\n- \"\"\"Raised if the private key(s) provided for signing don't match any of the\n- current owner(s)\"\"\"\n+class DoubleSpend(ValidationError):\n+ \"\"\"Raised if a double spend is found\"\"\"\n \n \n-class StartupError(BigchainDBError):\n- \"\"\"Raised when there is an error starting up the system\"\"\"\n+class InvalidHash(ValidationError):\n+ \"\"\"Raised if there was an error checking the hash for a particular\n+ operation\"\"\"\n \n \n-class ImproperVoteError(BigchainDBError):\n- \"\"\"Raised if a vote is not constructed correctly, or signed incorrectly\"\"\"\n+class SchemaValidationError(ValidationError):\n+ \"\"\"Raised if there was any error validating an object's schema\"\"\"\n \n \n-class MultipleVotesError(BigchainDBError):\n- \"\"\"Raised if a voter has voted more than once\"\"\"\n+class InvalidSignature(ValidationError):\n+ \"\"\"Raised if there was an error checking the signature for a particular\n+ operation\"\"\"\n \n \n-class GenesisBlockAlreadyExistsError(BigchainDBError):\n- \"\"\"Raised when trying to create the already existing genesis block\"\"\"\n+class ImproperVoteError(ValidationError):\n+ \"\"\"Raised if a vote is not constructed correctly, or signed incorrectly\"\"\"\n \n \n-class CyclicBlockchainError(BigchainDBError):\n- \"\"\"Raised when there is a cycle in the blockchain\"\"\"\n+class MultipleVotesError(ValidationError):\n+ \"\"\"Raised if a voter has voted more than once\"\"\"\n \n \n-class TransactionNotInValidBlock(BigchainDBError):\n+class TransactionNotInValidBlock(ValidationError):\n \"\"\"Raised when a transfer transaction is attempting to fulfill the\n outputs of a transaction that is in an invalid or undecided block\"\"\"\n \n \n-class AssetIdMismatch(BigchainDBError):\n+class AssetIdMismatch(ValidationError):\n \"\"\"Raised when multiple transaction inputs related to different assets\"\"\"\n \n \n-class AmountError(BigchainDBError):\n+class AmountError(ValidationError):\n \"\"\"Raised when there is a problem with a transaction's output amounts\"\"\"\n+\n+\n+class TransactionDoesNotExist(ValidationError):","path":"bigchaindb/common/exceptions.py","position":131,"original_position":131,"commit_id":"352627b83ab6549e5951ab6934440b59fe9721e4","original_commit_id":"352627b83ab6549e5951ab6934440b59fe9721e4","user":{"login":"vrde","id":134680,"avatar_url":"https://avatars2.githubusercontent.com/u/134680?v=3","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"body":"Why this is a `ValidationError`?","created_at":"2017-03-07T09:45:41Z","updated_at":"2017-03-07T09:56:55Z","html_url":"https://github.com/bigchaindb/bigchaindb/pull/1243#discussion_r104626082","pull_request_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1243","_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/104626082"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/1243#discussion_r104626082"},"pull_request":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1243"}}},"pull_request":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1243","id":108947853,"html_url":"https://github.com/bigchaindb/bigchaindb/pull/1243","diff_url":"https://github.com/bigchaindb/bigchaindb/pull/1243.diff","patch_url":"https://github.com/bigchaindb/bigchaindb/pull/1243.patch","issue_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/1243","number":1243,"state":"open","locked":false,"title":"Make ValidationError a superclass of all validation errors and use it","user":{"login":"libscott","id":125019,"avatar_url":"https://avatars0.githubusercontent.com/u/125019?v=3","gravatar_id":"","url":"https://api.github.com/users/libscott","html_url":"https://github.com/libscott","followers_url":"https://api.github.com/users/libscott/followers","following_url":"https://api.github.com/users/libscott/following{/other_user}","gists_url":"https://api.github.com/users/libscott/gists{/gist_id}","starred_url":"https://api.github.com/users/libscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libscott/subscriptions","organizations_url":"https://api.github.com/users/libscott/orgs","repos_url":"https://api.github.com/users/libscott/repos","events_url":"https://api.github.com/users/libscott/events{/privacy}","received_events_url":"https://api.github.com/users/libscott/received_events","type":"User","site_admin":false},"body":"Fixes #1232.\r\n\r\nScope:\r\n\r\n* Make all validation errors subclasses of ValidationError and catch that when validating transactions and blocks.\r\n* Don't use DoubleSpend if there's a problem with the chain, it's a validation error not a critical error\r\n* Don't use OperationError in validation, it's vague\r\n* Don't use TypeError and ValueError in validation\r\n* Remove is_valid_transaction, catch ValidationError in block / vote pipelines.\r\n* Log invalid transactions in block and vote pipeline","created_at":"2017-03-03T10:41:56Z","updated_at":"2017-03-07T09:56:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4156dae90abb72abff384992331ee64722613bb3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1243/commits","review_comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1243/comments","review_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/1243/comments","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/352627b83ab6549e5951ab6934440b59fe9721e4","head":{"label":"bigchaindb:validationerror-refactor","ref":"validationerror-refactor","sha":"352627b83ab6549e5951ab6934440b59fe9721e4","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars3.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars3.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"BigchainDB is a scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2017-03-06T23:38:22Z","pushed_at":"2017-03-07T09:56:36Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"[email protected]:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":6965,"stargazers_count":987,"watchers_count":987,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":203,"forks":202,"open_issues":203,"watchers":987,"default_branch":"master"}},"base":{"label":"bigchaindb:master","ref":"master","sha":"77fc3fbc4e437ff593aeb97535b72f9640a4b400","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars3.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars3.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"BigchainDB is a scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2017-03-06T23:38:22Z","pushed_at":"2017-03-07T09:56:36Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"[email protected]:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":6965,"stargazers_count":987,"watchers_count":987,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":203,"forks":202,"open_issues":203,"watchers":987,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1243"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/1243"},"issue":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/1243"},"comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/1243/comments"},"review_comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1243/comments"},"review_comment":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1243/commits"},"statuses":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/352627b83ab6549e5951ab6934440b59fe9721e4"}}}} | {
"id": 51290852,
"name": "bigchaindb/bigchaindb",
"url": "https://api.github.com/repos/bigchaindb/bigchaindb"
} | {
"id": 134680,
"login": "vrde",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/134680?",
"url": "https://api.github.com/users/vrde"
} | {
"id": 17097586,
"login": "bigchaindb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17097586?",
"url": "https://api.github.com/orgs/bigchaindb"
} | 2017-03-07T09:45:41 | 5446186313 | {"actor":{"display_login":"vrde"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/comments/123109035","pull_request_review_id":45282038,"id":123109035,"diff_hunk":"@@ -203,6 +203,20 @@ def detect_libb2(prefixes):\n long_description = re.compile(r'^\\.\\. highlight:: \\w+$', re.M).sub('', long_description)\n \n \n+def format_metavar(option):\n+ if option.nargs in ('*', '...'):\n+ if option.required:","path":"setup.py","position":6,"original_position":6,"commit_id":"f1900db0b223284452ef342dd06445fa6788a6c0","original_commit_id":"f1900db0b223284452ef342dd06445fa6788a6c0","user":{"login":"enkore","id":1330164,"avatar_url":"https://avatars3.githubusercontent.com/u/1330164?v=3","gravatar_id":"","url":"https://api.github.com/users/enkore","html_url":"https://github.com/enkore","followers_url":"https://api.github.com/users/enkore/followers","following_url":"https://api.github.com/users/enkore/following{/other_user}","gists_url":"https://api.github.com/users/enkore/gists{/gist_id}","starred_url":"https://api.github.com/users/enkore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enkore/subscriptions","organizations_url":"https://api.github.com/users/enkore/orgs","repos_url":"https://api.github.com/users/enkore/repos","events_url":"https://api.github.com/users/enkore/events{/privacy}","received_events_url":"https://api.github.com/users/enkore/received_events","type":"User","site_admin":false},"body":"That's a bit of a strange one ... \"zero or more arguments but at least one\". These instances should probably be replaced by nargs=+.","created_at":"2017-06-20T22:07:54Z","updated_at":"2017-06-20T22:07:54Z","html_url":"https://github.com/borgbackup/borg/pull/2716#discussion_r123109035","pull_request_url":"https://api.github.com/repos/borgbackup/borg/pulls/2716","_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments/123109035"},"html":{"href":"https://github.com/borgbackup/borg/pull/2716#discussion_r123109035"},"pull_request":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/2716"}}},"pull_request":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/2716","id":126640491,"html_url":"https://github.com/borgbackup/borg/pull/2716","diff_url":"https://github.com/borgbackup/borg/pull/2716.diff","patch_url":"https://github.com/borgbackup/borg/pull/2716.patch","issue_url":"https://api.github.com/repos/borgbackup/borg/issues/2716","number":2716,"state":"open","locked":false,"title":"docs: format metavars more accurately","user":{"login":"enkore","id":1330164,"avatar_url":"https://avatars3.githubusercontent.com/u/1330164?v=3","gravatar_id":"","url":"https://api.github.com/users/enkore","html_url":"https://github.com/enkore","followers_url":"https://api.github.com/users/enkore/followers","following_url":"https://api.github.com/users/enkore/following{/other_user}","gists_url":"https://api.github.com/users/enkore/gists{/gist_id}","starred_url":"https://api.github.com/users/enkore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enkore/subscriptions","organizations_url":"https://api.github.com/users/enkore/orgs","repos_url":"https://api.github.com/users/enkore/repos","events_url":"https://api.github.com/users/enkore/events{/privacy}","received_events_url":"https://api.github.com/users/enkore/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-20T22:05:59Z","updated_at":"2017-06-20T22:07:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abcd3f23bbe8fca511997ca6231b6c7d9abd4def","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/borgbackup/borg/pulls/2716/commits","review_comments_url":"https://api.github.com/repos/borgbackup/borg/pulls/2716/comments","review_comment_url":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borgbackup/borg/issues/2716/comments","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/f1900db0b223284452ef342dd06445fa6788a6c0","head":{"label":"enkore:docs/metavar","ref":"docs/metavar","sha":"f1900db0b223284452ef342dd06445fa6788a6c0","user":{"login":"enkore","id":1330164,"avatar_url":"https://avatars3.githubusercontent.com/u/1330164?v=3","gravatar_id":"","url":"https://api.github.com/users/enkore","html_url":"https://github.com/enkore","followers_url":"https://api.github.com/users/enkore/followers","following_url":"https://api.github.com/users/enkore/following{/other_user}","gists_url":"https://api.github.com/users/enkore/gists{/gist_id}","starred_url":"https://api.github.com/users/enkore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enkore/subscriptions","organizations_url":"https://api.github.com/users/enkore/orgs","repos_url":"https://api.github.com/users/enkore/repos","events_url":"https://api.github.com/users/enkore/events{/privacy}","received_events_url":"https://api.github.com/users/enkore/received_events","type":"User","site_admin":false},"repo":{"id":53583744,"name":"borg","full_name":"enkore/borg","owner":{"login":"enkore","id":1330164,"avatar_url":"https://avatars3.githubusercontent.com/u/1330164?v=3","gravatar_id":"","url":"https://api.github.com/users/enkore","html_url":"https://github.com/enkore","followers_url":"https://api.github.com/users/enkore/followers","following_url":"https://api.github.com/users/enkore/following{/other_user}","gists_url":"https://api.github.com/users/enkore/gists{/gist_id}","starred_url":"https://api.github.com/users/enkore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enkore/subscriptions","organizations_url":"https://api.github.com/users/enkore/orgs","repos_url":"https://api.github.com/users/enkore/repos","events_url":"https://api.github.com/users/enkore/events{/privacy}","received_events_url":"https://api.github.com/users/enkore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enkore/borg","description":"Dev fork","fork":true,"url":"https://api.github.com/repos/enkore/borg","forks_url":"https://api.github.com/repos/enkore/borg/forks","keys_url":"https://api.github.com/repos/enkore/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enkore/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enkore/borg/teams","hooks_url":"https://api.github.com/repos/enkore/borg/hooks","issue_events_url":"https://api.github.com/repos/enkore/borg/issues/events{/number}","events_url":"https://api.github.com/repos/enkore/borg/events","assignees_url":"https://api.github.com/repos/enkore/borg/assignees{/user}","branches_url":"https://api.github.com/repos/enkore/borg/branches{/branch}","tags_url":"https://api.github.com/repos/enkore/borg/tags","blobs_url":"https://api.github.com/repos/enkore/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enkore/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enkore/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/enkore/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enkore/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/enkore/borg/languages","stargazers_url":"https://api.github.com/repos/enkore/borg/stargazers","contributors_url":"https://api.github.com/repos/enkore/borg/contributors","subscribers_url":"https://api.github.com/repos/enkore/borg/subscribers","subscription_url":"https://api.github.com/repos/enkore/borg/subscription","commits_url":"https://api.github.com/repos/enkore/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/enkore/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/enkore/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/enkore/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/enkore/borg/contents/{+path}","compare_url":"https://api.github.com/repos/enkore/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enkore/borg/merges","archive_url":"https://api.github.com/repos/enkore/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enkore/borg/downloads","issues_url":"https://api.github.com/repos/enkore/borg/issues{/number}","pulls_url":"https://api.github.com/repos/enkore/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/enkore/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/enkore/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enkore/borg/labels{/name}","releases_url":"https://api.github.com/repos/enkore/borg/releases{/id}","deployments_url":"https://api.github.com/repos/enkore/borg/deployments","created_at":"2016-03-10T12:45:08Z","updated_at":"2016-11-11T01:24:12Z","pushed_at":"2017-06-20T22:06:54Z","git_url":"git://github.com/enkore/borg.git","ssh_url":"[email protected]:enkore/borg.git","clone_url":"https://github.com/enkore/borg.git","svn_url":"https://github.com/enkore/borg","homepage":"","size":11128,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"borgbackup:master","ref":"master","sha":"710ca196d8e21a7d60b5a0947bae0227c922d68d","user":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars0.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"repo":{"id":35517126,"name":"borg","full_name":"borgbackup/borg","owner":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars0.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/borgbackup/borg","description":"Deduplicating archiver with compression and authenticated encryption.","fork":false,"url":"https://api.github.com/repos/borgbackup/borg","forks_url":"https://api.github.com/repos/borgbackup/borg/forks","keys_url":"https://api.github.com/repos/borgbackup/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borgbackup/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borgbackup/borg/teams","hooks_url":"https://api.github.com/repos/borgbackup/borg/hooks","issue_events_url":"https://api.github.com/repos/borgbackup/borg/issues/events{/number}","events_url":"https://api.github.com/repos/borgbackup/borg/events","assignees_url":"https://api.github.com/repos/borgbackup/borg/assignees{/user}","branches_url":"https://api.github.com/repos/borgbackup/borg/branches{/branch}","tags_url":"https://api.github.com/repos/borgbackup/borg/tags","blobs_url":"https://api.github.com/repos/borgbackup/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borgbackup/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borgbackup/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/borgbackup/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/borgbackup/borg/languages","stargazers_url":"https://api.github.com/repos/borgbackup/borg/stargazers","contributors_url":"https://api.github.com/repos/borgbackup/borg/contributors","subscribers_url":"https://api.github.com/repos/borgbackup/borg/subscribers","subscription_url":"https://api.github.com/repos/borgbackup/borg/subscription","commits_url":"https://api.github.com/repos/borgbackup/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/borgbackup/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/borgbackup/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/borgbackup/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/borgbackup/borg/contents/{+path}","compare_url":"https://api.github.com/repos/borgbackup/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borgbackup/borg/merges","archive_url":"https://api.github.com/repos/borgbackup/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borgbackup/borg/downloads","issues_url":"https://api.github.com/repos/borgbackup/borg/issues{/number}","pulls_url":"https://api.github.com/repos/borgbackup/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/borgbackup/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/borgbackup/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borgbackup/borg/labels{/name}","releases_url":"https://api.github.com/repos/borgbackup/borg/releases{/id}","deployments_url":"https://api.github.com/repos/borgbackup/borg/deployments","created_at":"2015-05-12T23:10:47Z","updated_at":"2017-06-20T21:42:49Z","pushed_at":"2017-06-20T22:06:55Z","git_url":"git://github.com/borgbackup/borg.git","ssh_url":"[email protected]:borgbackup/borg.git","clone_url":"https://github.com/borgbackup/borg.git","svn_url":"https://github.com/borgbackup/borg","homepage":"https://borgbackup.readthedocs.io/","size":11463,"stargazers_count":2431,"watchers_count":2431,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":284,"forks":220,"open_issues":284,"watchers":2431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/2716"},"html":{"href":"https://github.com/borgbackup/borg/pull/2716"},"issue":{"href":"https://api.github.com/repos/borgbackup/borg/issues/2716"},"comments":{"href":"https://api.github.com/repos/borgbackup/borg/issues/2716/comments"},"review_comments":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/2716/comments"},"review_comment":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/2716/commits"},"statuses":{"href":"https://api.github.com/repos/borgbackup/borg/statuses/f1900db0b223284452ef342dd06445fa6788a6c0"}}}} | {
"id": 35517126,
"name": "borgbackup/borg",
"url": "https://api.github.com/repos/borgbackup/borg"
} | {
"id": 1330164,
"login": "enkore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1330164?",
"url": "https://api.github.com/users/enkore"
} | {
"id": 12418060,
"login": "borgbackup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12418060?",
"url": "https://api.github.com/orgs/borgbackup"
} | 2017-06-20T22:07:54 | 6104921020 | {"actor":{"display_login":"enkore"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/comments/125666813","pull_request_review_id":48078723,"id":125666813,"diff_hunk":"@@ -0,0 +1,68 @@\n+import * as React from 'react';\n+import { Modal } from 'react-bootstrap';\n+import browser from 'detect-browser';\n+\n+\n+interface IBrowserState {\n+ show: boolean;\n+ name: string;\n+ version: string;\n+}\n+\n+export default class UnsupportedBrowserModal extends React.Component<{}, IBrowserState> {\n+\n+ constructor() {\n+ super();\n+\n+ if (!browser) {\n+ this.state = {\n+ name: \"Unsupported\",\n+ show: true,\n+ version: \"\"\n+ };\n+ } else {\n+ this.state = {\n+ name: browser.name,\n+ show: false,\n+ version: browser.version\n+ };\n+ }\n+ }\n+\n+ componentDidMount() {\n+ this.handleUnsupportedBrowsers(this.state.name, this.state.version);\n+ }\n+\n+ handleUnsupportedBrowsers(name:string, version: string) {\n+ name = name.toLowerCase();\n+ const localStorage = window.localStorage.browserError || false;\n+ if (localStorage === true) {\n+ this.setState({show: false});\n+ } else if (String(name) === 'unsupported') {","path":"src/shared/components/unsupportedBrowserModal/UnsupportedBrowserModal.tsx","position":41,"original_position":41,"commit_id":"54698faef3741a87e39fa5956df4dffb1e388a1d","original_commit_id":"54698faef3741a87e39fa5956df4dffb1e388a1d","user":{"login":"Tamba32","id":15708264,"avatar_url":"https://avatars2.githubusercontent.com/u/15708264?v=3","gravatar_id":"","url":"https://api.github.com/users/Tamba32","html_url":"https://github.com/Tamba32","followers_url":"https://api.github.com/users/Tamba32/followers","following_url":"https://api.github.com/users/Tamba32/following{/other_user}","gists_url":"https://api.github.com/users/Tamba32/gists{/gist_id}","starred_url":"https://api.github.com/users/Tamba32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tamba32/subscriptions","organizations_url":"https://api.github.com/users/Tamba32/orgs","repos_url":"https://api.github.com/users/Tamba32/repos","events_url":"https://api.github.com/users/Tamba32/events{/privacy}","received_events_url":"https://api.github.com/users/Tamba32/received_events","type":"User","site_admin":false},"body":"Ino told me to add it in the case that `detect-browser` could not detect the browser. Up in the constructor, if `browser` is undefined, I set the browser state to be `unsupported`.","created_at":"2017-07-05T14:56:31Z","updated_at":"2017-07-05T14:56:31Z","html_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/442#discussion_r125666813","pull_request_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/442","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/comments/125666813"},"html":{"href":"https://github.com/cBioPortal/cbioportal-frontend/pull/442#discussion_r125666813"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/442"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/442","id":128669289,"html_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/442","diff_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/442.diff","patch_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/442.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/442","number":442,"state":"open","locked":false,"title":"Add UnsupportedBrowserModal.","user":{"login":"Tamba32","id":15708264,"avatar_url":"https://avatars2.githubusercontent.com/u/15708264?v=3","gravatar_id":"","url":"https://api.github.com/users/Tamba32","html_url":"https://github.com/Tamba32","followers_url":"https://api.github.com/users/Tamba32/followers","following_url":"https://api.github.com/users/Tamba32/following{/other_user}","gists_url":"https://api.github.com/users/Tamba32/gists{/gist_id}","starred_url":"https://api.github.com/users/Tamba32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tamba32/subscriptions","organizations_url":"https://api.github.com/users/Tamba32/orgs","repos_url":"https://api.github.com/users/Tamba32/repos","events_url":"https://api.github.com/users/Tamba32/events{/privacy}","received_events_url":"https://api.github.com/users/Tamba32/received_events","type":"User","site_admin":false},"body":"# What? Why?\r\n\r\nAdd browser/browser version detection so error message can be provided if the browser being used is not IE11, Chrome, or Firefox.\r\n\r\n","created_at":"2017-07-03T17:21:12Z","updated_at":"2017-07-05T14:56:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a5daf26a0f44a3fb7143d477600f9b8a2e7875b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/442/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/442/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/442/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/statuses/54698faef3741a87e39fa5956df4dffb1e388a1d","head":{"label":"Tamba32:upstreamRC","ref":"upstreamRC","sha":"54698faef3741a87e39fa5956df4dffb1e388a1d","user":{"login":"Tamba32","id":15708264,"avatar_url":"https://avatars2.githubusercontent.com/u/15708264?v=3","gravatar_id":"","url":"https://api.github.com/users/Tamba32","html_url":"https://github.com/Tamba32","followers_url":"https://api.github.com/users/Tamba32/followers","following_url":"https://api.github.com/users/Tamba32/following{/other_user}","gists_url":"https://api.github.com/users/Tamba32/gists{/gist_id}","starred_url":"https://api.github.com/users/Tamba32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tamba32/subscriptions","organizations_url":"https://api.github.com/users/Tamba32/orgs","repos_url":"https://api.github.com/users/Tamba32/repos","events_url":"https://api.github.com/users/Tamba32/events{/privacy}","received_events_url":"https://api.github.com/users/Tamba32/received_events","type":"User","site_admin":false},"repo":{"id":88993370,"name":"cbioportal-frontend","full_name":"Tamba32/cbioportal-frontend","owner":{"login":"Tamba32","id":15708264,"avatar_url":"https://avatars2.githubusercontent.com/u/15708264?v=3","gravatar_id":"","url":"https://api.github.com/users/Tamba32","html_url":"https://github.com/Tamba32","followers_url":"https://api.github.com/users/Tamba32/followers","following_url":"https://api.github.com/users/Tamba32/following{/other_user}","gists_url":"https://api.github.com/users/Tamba32/gists{/gist_id}","starred_url":"https://api.github.com/users/Tamba32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tamba32/subscriptions","organizations_url":"https://api.github.com/users/Tamba32/orgs","repos_url":"https://api.github.com/users/Tamba32/repos","events_url":"https://api.github.com/users/Tamba32/events{/privacy}","received_events_url":"https://api.github.com/users/Tamba32/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tamba32/cbioportal-frontend","description":"React Frontend of cBioPortal :tada:","fork":true,"url":"https://api.github.com/repos/Tamba32/cbioportal-frontend","forks_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/forks","keys_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/teams","hooks_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/hooks","issue_events_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/events","assignees_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/tags","blobs_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/languages","stargazers_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/stargazers","contributors_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/contributors","subscribers_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/subscribers","subscription_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/subscription","commits_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/merges","archive_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/downloads","issues_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/labels{/name}","releases_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/Tamba32/cbioportal-frontend/deployments","created_at":"2017-04-21T14:39:54Z","updated_at":"2017-04-21T14:39:56Z","pushed_at":"2017-07-05T14:32:55Z","git_url":"git://github.com/Tamba32/cbioportal-frontend.git","ssh_url":"[email protected]:Tamba32/cbioportal-frontend.git","clone_url":"https://github.com/Tamba32/cbioportal-frontend.git","svn_url":"https://github.com/Tamba32/cbioportal-frontend","homepage":"http://cbioportal.org","size":9065,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:rc","ref":"rc","sha":"a1064b8bcebef20268a2baa667a69cac03bda714","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars1.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":66571349,"name":"cbioportal-frontend","full_name":"cBioPortal/cbioportal-frontend","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars1.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/cbioportal-frontend","description":"React Frontend of cBioPortal :tada:","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/deployments","created_at":"2016-08-25T15:41:44Z","updated_at":"2017-04-18T15:54:56Z","pushed_at":"2017-07-05T14:32:57Z","git_url":"git://github.com/cBioPortal/cbioportal-frontend.git","ssh_url":"[email protected]:cBioPortal/cbioportal-frontend.git","clone_url":"https://github.com/cBioPortal/cbioportal-frontend.git","svn_url":"https://github.com/cBioPortal/cbioportal-frontend","homepage":"http://cbioportal.org","size":9344,"stargazers_count":9,"watchers_count":9,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":15,"forks":24,"open_issues":15,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/442"},"html":{"href":"https://github.com/cBioPortal/cbioportal-frontend/pull/442"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/442"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/442/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/442/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/442/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/statuses/54698faef3741a87e39fa5956df4dffb1e388a1d"}}}} | {
"id": 66571349,
"name": "cBioPortal/cbioportal-frontend",
"url": "https://api.github.com/repos/cBioPortal/cbioportal-frontend"
} | {
"id": 15708264,
"login": "Tamba32",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15708264?",
"url": "https://api.github.com/users/Tamba32"
} | {
"id": 9876251,
"login": "cBioPortal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9876251?",
"url": "https://api.github.com/orgs/cBioPortal"
} | 2017-07-05T14:56:31 | 6196537624 | {"actor":{"display_login":"Tamba32"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/comments/122052004","pull_request_review_id":44134147,"id":122052004,"diff_hunk":"@@ -110,7 +110,7 @@ Set an empty file next to the executable (or where it will be downloaded/unpacke\n ### How can I ensure a GUI shim?\n Chocolatey 0.9.10+ will automatically detect GUI applications and adjust the shim accordingly. The detection may not always be accurate, and older versions of Chocolatey don't handle this, so it's best to create a \"*.gui\" file to direct the shim creation to be for a GUI application.\n \n-If you are creating a package and want the shim to exit immediately after calling the application, create an empty \"*.gui\" file next to where the exe file is (or where it will be downloaded/unpacked to), sharing the same name with the executable and appending \".gui\". For example, if your file is named \"`bob.exe`\", you need a file named \"`bob.exe.gui`\" (pay attention to case - \"`BOB.exe.gui`\" may not work with all versions of Chocolatey).\n+If you are creating a package and want the shim to exit immediately after calling the application, create an empty \"\\*.gui\" file next to where the exe file is (or where it will be downloaded/unpacked to), sharing the same name with the executable and appending \".gui\". For example, if your file is named \"`bob.exe`\", you need a file named \"`bob.exe.gui`\" (pay attention to case - \"`BOB.exe.gui`\" may not work with all versions of Chocolatey).","path":"FeaturesShim.md","position":23,"original_position":23,"commit_id":"589f3b9ed6e4cbb2f8dea1f8bf960fbb3cbe89ec","original_commit_id":"589f3b9ed6e4cbb2f8dea1f8bf960fbb3cbe89ec","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars3.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"That's wild that a `*` would need to be escaped.","created_at":"2017-06-14T20:12:07Z","updated_at":"2017-06-14T20:12:07Z","html_url":"https://github.com/chocolatey/choco-wiki/pull/62#discussion_r122052004","pull_request_url":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/comments/122052004"},"html":{"href":"https://github.com/chocolatey/choco-wiki/pull/62#discussion_r122052004"},"pull_request":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/62","id":125570450,"html_url":"https://github.com/chocolatey/choco-wiki/pull/62","diff_url":"https://github.com/chocolatey/choco-wiki/pull/62.diff","patch_url":"https://github.com/chocolatey/choco-wiki/pull/62.patch","issue_url":"https://api.github.com/repos/chocolatey/choco-wiki/issues/62","number":62,"state":"closed","locked":false,"title":"Correct formatting issues","user":{"login":"ChrisMaddock","id":4837132,"avatar_url":"https://avatars0.githubusercontent.com/u/4837132?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisMaddock","html_url":"https://github.com/ChrisMaddock","followers_url":"https://api.github.com/users/ChrisMaddock/followers","following_url":"https://api.github.com/users/ChrisMaddock/following{/other_user}","gists_url":"https://api.github.com/users/ChrisMaddock/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisMaddock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisMaddock/subscriptions","organizations_url":"https://api.github.com/users/ChrisMaddock/orgs","repos_url":"https://api.github.com/users/ChrisMaddock/repos","events_url":"https://api.github.com/users/ChrisMaddock/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisMaddock/received_events","type":"User","site_admin":false},"body":"This corrects the formatting for the asterisks in this file.\r\n\r\nThe asterisks weren't rendering on the website or markdown. This fixes them for the markdown - I assume the same will work for the website, but I'm not sure.\r\n\r\nThis also wasn't the issue I was intending to solve! Opened this file as there are broken characters by many of the quote marks on the website - although I can't see anything in the source that would cause that. Maybe those will go away when the site is rebuilt? \r\n\r\nhttps://chocolatey.org/docs/features-shim\r\n\r\n","created_at":"2017-06-14T11:17:03Z","updated_at":"2017-06-14T20:12:08Z","closed_at":"2017-06-14T11:25:16Z","merged_at":null,"merge_commit_sha":"194a1d238849bf1be093cb49c7266783f1e19779","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/62/commits","review_comments_url":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/62/comments","review_comment_url":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chocolatey/choco-wiki/issues/62/comments","statuses_url":"https://api.github.com/repos/chocolatey/choco-wiki/statuses/589f3b9ed6e4cbb2f8dea1f8bf960fbb3cbe89ec","head":{"label":"ChrisMaddock:patch-2","ref":"patch-2","sha":"589f3b9ed6e4cbb2f8dea1f8bf960fbb3cbe89ec","user":{"login":"ChrisMaddock","id":4837132,"avatar_url":"https://avatars0.githubusercontent.com/u/4837132?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisMaddock","html_url":"https://github.com/ChrisMaddock","followers_url":"https://api.github.com/users/ChrisMaddock/followers","following_url":"https://api.github.com/users/ChrisMaddock/following{/other_user}","gists_url":"https://api.github.com/users/ChrisMaddock/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisMaddock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisMaddock/subscriptions","organizations_url":"https://api.github.com/users/ChrisMaddock/orgs","repos_url":"https://api.github.com/users/ChrisMaddock/repos","events_url":"https://api.github.com/users/ChrisMaddock/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisMaddock/received_events","type":"User","site_admin":false},"repo":{"id":65008698,"name":"choco-wiki","full_name":"ChrisMaddock/choco-wiki","owner":{"login":"ChrisMaddock","id":4837132,"avatar_url":"https://avatars0.githubusercontent.com/u/4837132?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisMaddock","html_url":"https://github.com/ChrisMaddock","followers_url":"https://api.github.com/users/ChrisMaddock/followers","following_url":"https://api.github.com/users/ChrisMaddock/following{/other_user}","gists_url":"https://api.github.com/users/ChrisMaddock/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisMaddock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisMaddock/subscriptions","organizations_url":"https://api.github.com/users/ChrisMaddock/orgs","repos_url":"https://api.github.com/users/ChrisMaddock/repos","events_url":"https://api.github.com/users/ChrisMaddock/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisMaddock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChrisMaddock/choco-wiki","description":"For updating https://github.com/chocolatey/choco/wiki","fork":true,"url":"https://api.github.com/repos/ChrisMaddock/choco-wiki","forks_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/forks","keys_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/teams","hooks_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/hooks","issue_events_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/events","assignees_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/tags","blobs_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/languages","stargazers_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/stargazers","contributors_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/contributors","subscribers_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/subscribers","subscription_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/subscription","commits_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/merges","archive_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/downloads","issues_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/labels{/name}","releases_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/ChrisMaddock/choco-wiki/deployments","created_at":"2016-08-05T09:57:30Z","updated_at":"2016-07-28T10:58:53Z","pushed_at":"2017-06-14T11:16:04Z","git_url":"git://github.com/ChrisMaddock/choco-wiki.git","ssh_url":"[email protected]:ChrisMaddock/choco-wiki.git","clone_url":"https://github.com/ChrisMaddock/choco-wiki.git","svn_url":"https://github.com/ChrisMaddock/choco-wiki","homepage":null,"size":20636,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"chocolatey:master","ref":"master","sha":"aa48d2b19cf46db1d9c9c23f93b5d95b46000257","user":{"login":"chocolatey","id":811025,"avatar_url":"https://avatars2.githubusercontent.com/u/811025?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"repo":{"id":32540815,"name":"choco-wiki","full_name":"chocolatey/choco-wiki","owner":{"login":"chocolatey","id":811025,"avatar_url":"https://avatars2.githubusercontent.com/u/811025?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chocolatey/choco-wiki","description":"For updating https://github.com/chocolatey/choco/wiki","fork":false,"url":"https://api.github.com/repos/chocolatey/choco-wiki","forks_url":"https://api.github.com/repos/chocolatey/choco-wiki/forks","keys_url":"https://api.github.com/repos/chocolatey/choco-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chocolatey/choco-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chocolatey/choco-wiki/teams","hooks_url":"https://api.github.com/repos/chocolatey/choco-wiki/hooks","issue_events_url":"https://api.github.com/repos/chocolatey/choco-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/chocolatey/choco-wiki/events","assignees_url":"https://api.github.com/repos/chocolatey/choco-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/chocolatey/choco-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/chocolatey/choco-wiki/tags","blobs_url":"https://api.github.com/repos/chocolatey/choco-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chocolatey/choco-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chocolatey/choco-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/chocolatey/choco-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chocolatey/choco-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/chocolatey/choco-wiki/languages","stargazers_url":"https://api.github.com/repos/chocolatey/choco-wiki/stargazers","contributors_url":"https://api.github.com/repos/chocolatey/choco-wiki/contributors","subscribers_url":"https://api.github.com/repos/chocolatey/choco-wiki/subscribers","subscription_url":"https://api.github.com/repos/chocolatey/choco-wiki/subscription","commits_url":"https://api.github.com/repos/chocolatey/choco-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/chocolatey/choco-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/chocolatey/choco-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/chocolatey/choco-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/chocolatey/choco-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/chocolatey/choco-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chocolatey/choco-wiki/merges","archive_url":"https://api.github.com/repos/chocolatey/choco-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chocolatey/choco-wiki/downloads","issues_url":"https://api.github.com/repos/chocolatey/choco-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/chocolatey/choco-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/chocolatey/choco-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/chocolatey/choco-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chocolatey/choco-wiki/labels{/name}","releases_url":"https://api.github.com/repos/chocolatey/choco-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/chocolatey/choco-wiki/deployments","created_at":"2015-03-19T19:03:57Z","updated_at":"2017-05-24T20:20:13Z","pushed_at":"2017-06-14T11:17:04Z","git_url":"git://github.com/chocolatey/choco-wiki.git","ssh_url":"[email protected]:chocolatey/choco-wiki.git","clone_url":"https://github.com/chocolatey/choco-wiki.git","svn_url":"https://github.com/chocolatey/choco-wiki","homepage":null,"size":20635,"stargazers_count":24,"watchers_count":24,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":8,"forks":52,"open_issues":8,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/62"},"html":{"href":"https://github.com/chocolatey/choco-wiki/pull/62"},"issue":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/issues/62"},"comments":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/chocolatey/choco-wiki/statuses/589f3b9ed6e4cbb2f8dea1f8bf960fbb3cbe89ec"}}}} | {
"id": 32540815,
"name": "chocolatey/choco-wiki",
"url": "https://api.github.com/repos/chocolatey/choco-wiki"
} | {
"id": 63502,
"login": "ferventcoder",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/63502?",
"url": "https://api.github.com/users/ferventcoder"
} | {
"id": 811025,
"login": "chocolatey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/811025?",
"url": "https://api.github.com/orgs/chocolatey"
} | 2017-06-14T20:12:07 | 6067157971 | {"actor":{"display_login":"ferventcoder"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/comments/157250713","pull_request_review_id":83867769,"id":157250713,"diff_hunk":"@@ -0,0 +1,50 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import {FormattedMessage} from 'react-intl';\n+\n+import messages from './messages';\n+import {parseActivityCallData} from './helpers';\n+\n+const propTypes = {\n+ actor: PropTypes.shape({\n+ entryUUID: PropTypes.string\n+ }).isRequired,\n+ duration: PropTypes.number.isRequired,\n+ isGroupCall: PropTypes.bool,","path":"packages/node_modules/@ciscospark/react-component-call-data-activity/src/index.js","position":13,"original_position":13,"commit_id":"829c0889e1c44b196ecba59e744102588efd0bac","original_commit_id":"829c0889e1c44b196ecba59e744102588efd0bac","user":{"login":"adamweeks","id":190647,"avatar_url":"https://avatars2.githubusercontent.com/u/190647?v=4","gravatar_id":"","url":"https://api.github.com/users/adamweeks","html_url":"https://github.com/adamweeks","followers_url":"https://api.github.com/users/adamweeks/followers","following_url":"https://api.github.com/users/adamweeks/following{/other_user}","gists_url":"https://api.github.com/users/adamweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/adamweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamweeks/subscriptions","organizations_url":"https://api.github.com/users/adamweeks/orgs","repos_url":"https://api.github.com/users/adamweeks/repos","events_url":"https://api.github.com/users/adamweeks/events{/privacy}","received_events_url":"https://api.github.com/users/adamweeks/received_events","type":"User","site_admin":false},"body":"Fixed. made it required 😆 ","created_at":"2017-12-15T17:03:10Z","updated_at":"2017-12-15T17:03:10Z","html_url":"https://github.com/ciscospark/react-ciscospark/pull/592#discussion_r157250713","pull_request_url":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/592","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/comments/157250713"},"html":{"href":"https://github.com/ciscospark/react-ciscospark/pull/592#discussion_r157250713"},"pull_request":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/592"}},"in_reply_to_id":157052239},"pull_request":{"url":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/592","id":157694235,"html_url":"https://github.com/ciscospark/react-ciscospark/pull/592","diff_url":"https://github.com/ciscospark/react-ciscospark/pull/592.diff","patch_url":"https://github.com/ciscospark/react-ciscospark/pull/592.patch","issue_url":"https://api.github.com/repos/ciscospark/react-ciscospark/issues/592","number":592,"state":"open","locked":false,"title":"Fix recents call data and use shared component","user":{"login":"adamweeks","id":190647,"avatar_url":"https://avatars2.githubusercontent.com/u/190647?v=4","gravatar_id":"","url":"https://api.github.com/users/adamweeks","html_url":"https://github.com/adamweeks","followers_url":"https://api.github.com/users/adamweeks/followers","following_url":"https://api.github.com/users/adamweeks/following{/other_user}","gists_url":"https://api.github.com/users/adamweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/adamweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamweeks/subscriptions","organizations_url":"https://api.github.com/users/adamweeks/orgs","repos_url":"https://api.github.com/users/adamweeks/repos","events_url":"https://api.github.com/users/adamweeks/events{/privacy}","received_events_url":"https://api.github.com/users/adamweeks/received_events","type":"User","site_admin":false},"body":"Still todo: \r\n\r\n- [x] Add jest tests for new component\r\n- [x] Use component in activity list system message\r\n- [x] Fix message names","created_at":"2017-12-11T22:59:30Z","updated_at":"2017-12-15T17:03:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b6fee4056dffdf25bdce1a572967aa3ce1c3104","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/592/commits","review_comments_url":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/592/comments","review_comment_url":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciscospark/react-ciscospark/issues/592/comments","statuses_url":"https://api.github.com/repos/ciscospark/react-ciscospark/statuses/829c0889e1c44b196ecba59e744102588efd0bac","head":{"label":"adamweeks:fix-recents-call-data","ref":"fix-recents-call-data","sha":"829c0889e1c44b196ecba59e744102588efd0bac","user":{"login":"adamweeks","id":190647,"avatar_url":"https://avatars2.githubusercontent.com/u/190647?v=4","gravatar_id":"","url":"https://api.github.com/users/adamweeks","html_url":"https://github.com/adamweeks","followers_url":"https://api.github.com/users/adamweeks/followers","following_url":"https://api.github.com/users/adamweeks/following{/other_user}","gists_url":"https://api.github.com/users/adamweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/adamweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamweeks/subscriptions","organizations_url":"https://api.github.com/users/adamweeks/orgs","repos_url":"https://api.github.com/users/adamweeks/repos","events_url":"https://api.github.com/users/adamweeks/events{/privacy}","received_events_url":"https://api.github.com/users/adamweeks/received_events","type":"User","site_admin":false},"repo":{"id":82597048,"name":"react-ciscospark-1","full_name":"adamweeks/react-ciscospark-1","owner":{"login":"adamweeks","id":190647,"avatar_url":"https://avatars2.githubusercontent.com/u/190647?v=4","gravatar_id":"","url":"https://api.github.com/users/adamweeks","html_url":"https://github.com/adamweeks","followers_url":"https://api.github.com/users/adamweeks/followers","following_url":"https://api.github.com/users/adamweeks/following{/other_user}","gists_url":"https://api.github.com/users/adamweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/adamweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamweeks/subscriptions","organizations_url":"https://api.github.com/users/adamweeks/orgs","repos_url":"https://api.github.com/users/adamweeks/repos","events_url":"https://api.github.com/users/adamweeks/events{/privacy}","received_events_url":"https://api.github.com/users/adamweeks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamweeks/react-ciscospark-1","description":null,"fork":true,"url":"https://api.github.com/repos/adamweeks/react-ciscospark-1","forks_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/forks","keys_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/teams","hooks_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/hooks","issue_events_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/issues/events{/number}","events_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/events","assignees_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/assignees{/user}","branches_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/branches{/branch}","tags_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/tags","blobs_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/statuses/{sha}","languages_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/languages","stargazers_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/stargazers","contributors_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/contributors","subscribers_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/subscribers","subscription_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/subscription","commits_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/contents/{+path}","compare_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/merges","archive_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/downloads","issues_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/issues{/number}","pulls_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/pulls{/number}","milestones_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/milestones{/number}","notifications_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/labels{/name}","releases_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/releases{/id}","deployments_url":"https://api.github.com/repos/adamweeks/react-ciscospark-1/deployments","created_at":"2017-02-20T19:58:53Z","updated_at":"2017-02-20T19:58:54Z","pushed_at":"2017-12-15T16:46:36Z","git_url":"git://github.com/adamweeks/react-ciscospark-1.git","ssh_url":"[email protected]:adamweeks/react-ciscospark-1.git","clone_url":"https://github.com/adamweeks/react-ciscospark-1.git","svn_url":"https://github.com/adamweeks/react-ciscospark-1","homepage":null,"size":15183,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciscospark:master","ref":"master","sha":"0225d9a70dccb84625e63679f26740a002d80629","user":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars0.githubusercontent.com/u/15900782?v=4","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"repo":{"id":76988408,"name":"react-ciscospark","full_name":"ciscospark/react-ciscospark","owner":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars0.githubusercontent.com/u/15900782?v=4","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciscospark/react-ciscospark","description":null,"fork":false,"url":"https://api.github.com/repos/ciscospark/react-ciscospark","forks_url":"https://api.github.com/repos/ciscospark/react-ciscospark/forks","keys_url":"https://api.github.com/repos/ciscospark/react-ciscospark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciscospark/react-ciscospark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciscospark/react-ciscospark/teams","hooks_url":"https://api.github.com/repos/ciscospark/react-ciscospark/hooks","issue_events_url":"https://api.github.com/repos/ciscospark/react-ciscospark/issues/events{/number}","events_url":"https://api.github.com/repos/ciscospark/react-ciscospark/events","assignees_url":"https://api.github.com/repos/ciscospark/react-ciscospark/assignees{/user}","branches_url":"https://api.github.com/repos/ciscospark/react-ciscospark/branches{/branch}","tags_url":"https://api.github.com/repos/ciscospark/react-ciscospark/tags","blobs_url":"https://api.github.com/repos/ciscospark/react-ciscospark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciscospark/react-ciscospark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciscospark/react-ciscospark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciscospark/react-ciscospark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciscospark/react-ciscospark/statuses/{sha}","languages_url":"https://api.github.com/repos/ciscospark/react-ciscospark/languages","stargazers_url":"https://api.github.com/repos/ciscospark/react-ciscospark/stargazers","contributors_url":"https://api.github.com/repos/ciscospark/react-ciscospark/contributors","subscribers_url":"https://api.github.com/repos/ciscospark/react-ciscospark/subscribers","subscription_url":"https://api.github.com/repos/ciscospark/react-ciscospark/subscription","commits_url":"https://api.github.com/repos/ciscospark/react-ciscospark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciscospark/react-ciscospark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciscospark/react-ciscospark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciscospark/react-ciscospark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciscospark/react-ciscospark/contents/{+path}","compare_url":"https://api.github.com/repos/ciscospark/react-ciscospark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciscospark/react-ciscospark/merges","archive_url":"https://api.github.com/repos/ciscospark/react-ciscospark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciscospark/react-ciscospark/downloads","issues_url":"https://api.github.com/repos/ciscospark/react-ciscospark/issues{/number}","pulls_url":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls{/number}","milestones_url":"https://api.github.com/repos/ciscospark/react-ciscospark/milestones{/number}","notifications_url":"https://api.github.com/repos/ciscospark/react-ciscospark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciscospark/react-ciscospark/labels{/name}","releases_url":"https://api.github.com/repos/ciscospark/react-ciscospark/releases{/id}","deployments_url":"https://api.github.com/repos/ciscospark/react-ciscospark/deployments","created_at":"2016-12-20T20:13:07Z","updated_at":"2017-12-04T10:46:16Z","pushed_at":"2017-12-15T16:46:38Z","git_url":"git://github.com/ciscospark/react-ciscospark.git","ssh_url":"[email protected]:ciscospark/react-ciscospark.git","clone_url":"https://github.com/ciscospark/react-ciscospark.git","svn_url":"https://github.com/ciscospark/react-ciscospark","homepage":null,"size":15213,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":22,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/592"},"html":{"href":"https://github.com/ciscospark/react-ciscospark/pull/592"},"issue":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/issues/592"},"comments":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/issues/592/comments"},"review_comments":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/592/comments"},"review_comment":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/pulls/592/commits"},"statuses":{"href":"https://api.github.com/repos/ciscospark/react-ciscospark/statuses/829c0889e1c44b196ecba59e744102588efd0bac"}},"author_association":"COLLABORATOR"}} | {
"id": 76988408,
"name": "ciscospark/react-ciscospark",
"url": "https://api.github.com/repos/ciscospark/react-ciscospark"
} | {
"id": 190647,
"login": "adamweeks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/190647?",
"url": "https://api.github.com/users/adamweeks"
} | {
"id": 15900782,
"login": "ciscospark",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15900782?",
"url": "https://api.github.com/orgs/ciscospark"
} | 2017-12-15T17:03:10 | 6994908768 | {"actor":{"display_login":"adamweeks"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/autospec/pulls/comments/151481560","pull_request_review_id":77187131,"id":151481560,"diff_hunk":"@@ -0,0 +1,121 @@\n+#!/usr/bin/true\n+#\n+# infile_parser.py - part of autospec\n+# Copyright (C) 2017 Intel Corporation\n+#\n+# This program is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, either version 3 of the License, or\n+# (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with this program. If not, see <http://www.gnu.org/licenses/>.\n+#\n+\n+import os\n+import requests\n+import tempfile\n+from urllib.request import urlretrieve\n+\n+import util\n+import infile_bb_parser\n+\n+\n+# filetypes and their parse order (lower parsed first)\n+parsable_filetypes = {'.inc': 1, '.bb': 2}\n+\n+\n+def parse_ext(path):\n+ ext = os.path.splitext(path)[1]\n+ if ext not in parsable_filetypes:\n+ util.print_warning(\"Cannot parse infile \\\"{}\\\" type. \"\n+ \"from input: {}\".format(ext, path))\n+ return\n+\n+ if ext.startswith('.'):\n+ ext = ext[1:]\n+\n+ return ext\n+\n+\n+def check_url_content(url):\n+ if \"text/html\" in requests.head(url).headers['content-type']:\n+ if 'git' in url and \"/tree/\" in url:\n+ url = url.replace(\"/tree/\", \"/plain/\", 1)\n+ else:\n+ util.print_fatal(\"infile url has an html content-type, \"\n+ \"please use plaintext.\")\n+ return None\n+ return url\n+\n+\n+def sort_files(x):\n+ return parsable_filetypes.get(os.path.splitext(x)[1])\n+\n+\n+def parser_type(bb_fp, output_dict, parse_type):\n+ if parse_type == \"bb\":\n+ return infile_bb_parser.bb_scraper(bb_fp, output_dict)\n+ elif parse_type == \"inc\":\n+ return infile_bb_parser.bb_scraper(bb_fp, output_dict)\n+\n+\n+def file_handler(indata, output_dict):\n+ \"\"\"\n+ This function determines whether the input is a file or a url. If it is a\n+ url it checks that it is in the correct format (plaintext), downloads the\n+ url to a temporary file and passes the file handler to be scraped.\n+ If the input is a file, then it opens the file and passes the handler to\n+ be scraped.\n+\n+ The type of parsing bitbake, inc, deb, etc is based on the file extension.\n+ \"\"\"\n+\n+ parse_type = parse_ext(indata)\n+\n+ if output_dict.get('filename'):\n+ output_dict['filename'].append(indata)\n+ else:\n+ output_dict['filename'] = [indata]\n+\n+ if not os.path.isfile(indata):\n+ # check that input is plain or raw text and not html\n+ indata = check_url_content(indata)\n+ with tempfile.NamedTemporaryFile() as tmpfile:\n+ try:\n+ tmp, _ = urlretrieve(indata, tmpfile.name)\n+ with open(tmp, 'r') as bb_fp:\n+ output_dict = parser_type(bb_fp, output_dict, parse_type)\n+ except Exception as e:\n+ util.print_warning(\"Error downloading url: {}\".format(e))","path":"autospec/infile_handler.py","position":95,"original_position":95,"commit_id":"49b2ac0bbbea45b64948f2a9d63c44cb0c68caa1","original_commit_id":"49b2ac0bbbea45b64948f2a9d63c44cb0c68caa1","user":{"login":"matthewrsj","id":12090084,"avatar_url":"https://avatars0.githubusercontent.com/u/12090084?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrsj","html_url":"https://github.com/matthewrsj","followers_url":"https://api.github.com/users/matthewrsj/followers","following_url":"https://api.github.com/users/matthewrsj/following{/other_user}","gists_url":"https://api.github.com/users/matthewrsj/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrsj/subscriptions","organizations_url":"https://api.github.com/users/matthewrsj/orgs","repos_url":"https://api.github.com/users/matthewrsj/repos","events_url":"https://api.github.com/users/matthewrsj/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrsj/received_events","type":"User","site_admin":false},"body":"Ah, this is what happens. Is this designed to continue the autospec run if the `infile` is invalid?","created_at":"2017-11-16T17:21:22Z","updated_at":"2017-11-16T17:32:41Z","html_url":"https://github.com/clearlinux/autospec/pull/68#discussion_r151481560","pull_request_url":"https://api.github.com/repos/clearlinux/autospec/pulls/68","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/autospec/pulls/comments/151481560"},"html":{"href":"https://github.com/clearlinux/autospec/pull/68#discussion_r151481560"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/autospec/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/clearlinux/autospec/pulls/68","id":152856913,"html_url":"https://github.com/clearlinux/autospec/pull/68","diff_url":"https://github.com/clearlinux/autospec/pull/68.diff","patch_url":"https://github.com/clearlinux/autospec/pull/68.patch","issue_url":"https://api.github.com/repos/clearlinux/autospec/issues/68","number":68,"state":"open","locked":false,"title":"Infile parser to use bitbake files","user":{"login":"Gabib32","id":8284020,"avatar_url":"https://avatars2.githubusercontent.com/u/8284020?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabib32","html_url":"https://github.com/Gabib32","followers_url":"https://api.github.com/users/Gabib32/followers","following_url":"https://api.github.com/users/Gabib32/following{/other_user}","gists_url":"https://api.github.com/users/Gabib32/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabib32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabib32/subscriptions","organizations_url":"https://api.github.com/users/Gabib32/orgs","repos_url":"https://api.github.com/users/Gabib32/repos","events_url":"https://api.github.com/users/Gabib32/events{/privacy}","received_events_url":"https://api.github.com/users/Gabib32/received_events","type":"User","site_admin":false},"body":"The first phase of the infile parser is complete. When the --infile arg is passed with a url, file, or directory of files that is a recipe file it scrapes the information and stores it to update the specfile. If the infile arg is passed a url is not needed, and if one is not present the scraped tarball from the .bb file will be used. Additionally, any licenses taken from the recipe file will be added to the licenses list, thus preventing autospec failures that cannot find a .license file. The summary and build deps are added to the specfile after the initial creation of the specfile by autospec.","created_at":"2017-11-15T18:56:24Z","updated_at":"2017-11-16T17:32:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f5a960b331d5209fe7b8a9dc4c252fdddd15f94","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/autospec/pulls/68/commits","review_comments_url":"https://api.github.com/repos/clearlinux/autospec/pulls/68/comments","review_comment_url":"https://api.github.com/repos/clearlinux/autospec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/autospec/issues/68/comments","statuses_url":"https://api.github.com/repos/clearlinux/autospec/statuses/49b2ac0bbbea45b64948f2a9d63c44cb0c68caa1","head":{"label":"clearlinux:infile-parser","ref":"infile-parser","sha":"49b2ac0bbbea45b64948f2a9d63c44cb0c68caa1","user":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":45694952,"name":"autospec","full_name":"clearlinux/autospec","owner":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/autospec","description":"RPM packaging automation tool","fork":false,"url":"https://api.github.com/repos/clearlinux/autospec","forks_url":"https://api.github.com/repos/clearlinux/autospec/forks","keys_url":"https://api.github.com/repos/clearlinux/autospec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/autospec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/autospec/teams","hooks_url":"https://api.github.com/repos/clearlinux/autospec/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/autospec/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/autospec/events","assignees_url":"https://api.github.com/repos/clearlinux/autospec/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/autospec/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/autospec/tags","blobs_url":"https://api.github.com/repos/clearlinux/autospec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/autospec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/autospec/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/autospec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/autospec/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/autospec/languages","stargazers_url":"https://api.github.com/repos/clearlinux/autospec/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/autospec/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/autospec/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/autospec/subscription","commits_url":"https://api.github.com/repos/clearlinux/autospec/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/autospec/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/autospec/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/autospec/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/autospec/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/autospec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/autospec/merges","archive_url":"https://api.github.com/repos/clearlinux/autospec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/autospec/downloads","issues_url":"https://api.github.com/repos/clearlinux/autospec/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/autospec/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/autospec/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/autospec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/autospec/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/autospec/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/autospec/deployments","created_at":"2015-11-06T16:58:26Z","updated_at":"2017-11-01T20:14:56Z","pushed_at":"2017-11-16T00:56:07Z","git_url":"git://github.com/clearlinux/autospec.git","ssh_url":"[email protected]:clearlinux/autospec.git","clone_url":"https://github.com/clearlinux/autospec.git","svn_url":"https://github.com/clearlinux/autospec","homepage":"","size":17994,"stargazers_count":23,"watchers_count":23,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":12,"forks":13,"open_issues":12,"watchers":23,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"0c74c918c18151d6e0290b75896cd52045337669","user":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":45694952,"name":"autospec","full_name":"clearlinux/autospec","owner":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/autospec","description":"RPM packaging automation tool","fork":false,"url":"https://api.github.com/repos/clearlinux/autospec","forks_url":"https://api.github.com/repos/clearlinux/autospec/forks","keys_url":"https://api.github.com/repos/clearlinux/autospec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/autospec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/autospec/teams","hooks_url":"https://api.github.com/repos/clearlinux/autospec/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/autospec/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/autospec/events","assignees_url":"https://api.github.com/repos/clearlinux/autospec/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/autospec/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/autospec/tags","blobs_url":"https://api.github.com/repos/clearlinux/autospec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/autospec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/autospec/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/autospec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/autospec/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/autospec/languages","stargazers_url":"https://api.github.com/repos/clearlinux/autospec/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/autospec/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/autospec/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/autospec/subscription","commits_url":"https://api.github.com/repos/clearlinux/autospec/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/autospec/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/autospec/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/autospec/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/autospec/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/autospec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/autospec/merges","archive_url":"https://api.github.com/repos/clearlinux/autospec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/autospec/downloads","issues_url":"https://api.github.com/repos/clearlinux/autospec/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/autospec/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/autospec/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/autospec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/autospec/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/autospec/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/autospec/deployments","created_at":"2015-11-06T16:58:26Z","updated_at":"2017-11-01T20:14:56Z","pushed_at":"2017-11-16T00:56:07Z","git_url":"git://github.com/clearlinux/autospec.git","ssh_url":"[email protected]:clearlinux/autospec.git","clone_url":"https://github.com/clearlinux/autospec.git","svn_url":"https://github.com/clearlinux/autospec","homepage":"","size":17994,"stargazers_count":23,"watchers_count":23,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":12,"forks":13,"open_issues":12,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/autospec/pulls/68"},"html":{"href":"https://github.com/clearlinux/autospec/pull/68"},"issue":{"href":"https://api.github.com/repos/clearlinux/autospec/issues/68"},"comments":{"href":"https://api.github.com/repos/clearlinux/autospec/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/autospec/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/autospec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/autospec/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/autospec/statuses/49b2ac0bbbea45b64948f2a9d63c44cb0c68caa1"}},"author_association":"COLLABORATOR"}} | {
"id": 45694952,
"name": "clearlinux/autospec",
"url": "https://api.github.com/repos/clearlinux/autospec"
} | {
"id": 12090084,
"login": "matthewrsj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12090084?",
"url": "https://api.github.com/users/matthewrsj"
} | {
"id": 12545216,
"login": "clearlinux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12545216?",
"url": "https://api.github.com/orgs/clearlinux"
} | 2017-11-16T17:21:22 | 6865669281 | {"actor":{"display_login":"matthewrsj"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments/153692045","pull_request_review_id":79734854,"id":153692045,"diff_hunk":"@@ -0,0 +1,13 @@\n+//\n+// ResultMessage.swift\n+// CoordinateCalculator\n+//\n+// Created by YOUTH on 2017. 11. 28..\n+// Copyright © 2017년 Codesquad Inc. All rights reserved.\n+//\n+\n+import Foundation\n+\n+protocol Result {\n+ func messageByShape() -> String \n+}","path":"CoordinateCalculator/CoordinateCalculator/ResultMessage.swift","position":13,"original_position":13,"commit_id":"4431b1fabe35be0aca57a6d7a828229576440531","original_commit_id":"4431b1fabe35be0aca57a6d7a828229576440531","user":{"login":"godrm","id":278988,"avatar_url":"https://avatars1.githubusercontent.com/u/278988?v=4","gravatar_id":"","url":"https://api.github.com/users/godrm","html_url":"https://github.com/godrm","followers_url":"https://api.github.com/users/godrm/followers","following_url":"https://api.github.com/users/godrm/following{/other_user}","gists_url":"https://api.github.com/users/godrm/gists{/gist_id}","starred_url":"https://api.github.com/users/godrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godrm/subscriptions","organizations_url":"https://api.github.com/users/godrm/orgs","repos_url":"https://api.github.com/users/godrm/repos","events_url":"https://api.github.com/users/godrm/events{/privacy}","received_events_url":"https://api.github.com/users/godrm/received_events","type":"User","site_admin":false},"body":"프로토콜 이름을 좀 더 구체적으로 쓰세요. 항상 파일명과 동일하게 만드는 것도 방법입니다.","created_at":"2017-11-29T04:34:07Z","updated_at":"2017-11-29T04:34:07Z","html_url":"https://github.com/code-squad/swift-coordinate/pull/50#discussion_r153692045","pull_request_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/50","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments/153692045"},"html":{"href":"https://github.com/code-squad/swift-coordinate/pull/50#discussion_r153692045"},"pull_request":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/50","id":155002540,"html_url":"https://github.com/code-squad/swift-coordinate/pull/50","diff_url":"https://github.com/code-squad/swift-coordinate/pull/50.diff","patch_url":"https://github.com/code-squad/swift-coordinate/pull/50.patch","issue_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/50","number":50,"state":"open","locked":false,"title":"Coordinate step4 2nd","user":{"login":"youth27","id":29678855,"avatar_url":"https://avatars1.githubusercontent.com/u/29678855?v=4","gravatar_id":"","url":"https://api.github.com/users/youth27","html_url":"https://github.com/youth27","followers_url":"https://api.github.com/users/youth27/followers","following_url":"https://api.github.com/users/youth27/following{/other_user}","gists_url":"https://api.github.com/users/youth27/gists{/gist_id}","starred_url":"https://api.github.com/users/youth27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youth27/subscriptions","organizations_url":"https://api.github.com/users/youth27/orgs","repos_url":"https://api.github.com/users/youth27/repos","events_url":"https://api.github.com/users/youth27/events{/privacy}","received_events_url":"https://api.github.com/users/youth27/received_events","type":"User","site_admin":false},"body":"- MyTriangle을 MyShape프로토콜을 준수하게 설계했습니다. \r\n- 결과값을 표시하는 ResultMessage 프로토콜을 만들어서 도형마다 출력되는 메시지를 다르게 설정했습니다. \r\n- OutPutView에서 printByLine이나 printByPoint를 없애고 drawPoint로 결과 좌표점 출력기능을 통합했습니다.\r\n","created_at":"2017-11-28T08:04:33Z","updated_at":"2017-11-29T04:34:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4bb8c5567928e1e1644de4cb94ce0e689f1ccf3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/50/commits","review_comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/50/comments","review_comment_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/50/comments","statuses_url":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/4431b1fabe35be0aca57a6d7a828229576440531","head":{"label":"youth27:coordinate-step4-2nd","ref":"coordinate-step4-2nd","sha":"4431b1fabe35be0aca57a6d7a828229576440531","user":{"login":"youth27","id":29678855,"avatar_url":"https://avatars1.githubusercontent.com/u/29678855?v=4","gravatar_id":"","url":"https://api.github.com/users/youth27","html_url":"https://github.com/youth27","followers_url":"https://api.github.com/users/youth27/followers","following_url":"https://api.github.com/users/youth27/following{/other_user}","gists_url":"https://api.github.com/users/youth27/gists{/gist_id}","starred_url":"https://api.github.com/users/youth27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youth27/subscriptions","organizations_url":"https://api.github.com/users/youth27/orgs","repos_url":"https://api.github.com/users/youth27/repos","events_url":"https://api.github.com/users/youth27/events{/privacy}","received_events_url":"https://api.github.com/users/youth27/received_events","type":"User","site_admin":false},"repo":{"id":110937015,"name":"swift-coordinate","full_name":"youth27/swift-coordinate","owner":{"login":"youth27","id":29678855,"avatar_url":"https://avatars1.githubusercontent.com/u/29678855?v=4","gravatar_id":"","url":"https://api.github.com/users/youth27","html_url":"https://github.com/youth27","followers_url":"https://api.github.com/users/youth27/followers","following_url":"https://api.github.com/users/youth27/following{/other_user}","gists_url":"https://api.github.com/users/youth27/gists{/gist_id}","starred_url":"https://api.github.com/users/youth27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youth27/subscriptions","organizations_url":"https://api.github.com/users/youth27/orgs","repos_url":"https://api.github.com/users/youth27/repos","events_url":"https://api.github.com/users/youth27/events{/privacy}","received_events_url":"https://api.github.com/users/youth27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/youth27/swift-coordinate","description":"좌표계산기_저장소","fork":true,"url":"https://api.github.com/repos/youth27/swift-coordinate","forks_url":"https://api.github.com/repos/youth27/swift-coordinate/forks","keys_url":"https://api.github.com/repos/youth27/swift-coordinate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youth27/swift-coordinate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youth27/swift-coordinate/teams","hooks_url":"https://api.github.com/repos/youth27/swift-coordinate/hooks","issue_events_url":"https://api.github.com/repos/youth27/swift-coordinate/issues/events{/number}","events_url":"https://api.github.com/repos/youth27/swift-coordinate/events","assignees_url":"https://api.github.com/repos/youth27/swift-coordinate/assignees{/user}","branches_url":"https://api.github.com/repos/youth27/swift-coordinate/branches{/branch}","tags_url":"https://api.github.com/repos/youth27/swift-coordinate/tags","blobs_url":"https://api.github.com/repos/youth27/swift-coordinate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youth27/swift-coordinate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youth27/swift-coordinate/git/refs{/sha}","trees_url":"https://api.github.com/repos/youth27/swift-coordinate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youth27/swift-coordinate/statuses/{sha}","languages_url":"https://api.github.com/repos/youth27/swift-coordinate/languages","stargazers_url":"https://api.github.com/repos/youth27/swift-coordinate/stargazers","contributors_url":"https://api.github.com/repos/youth27/swift-coordinate/contributors","subscribers_url":"https://api.github.com/repos/youth27/swift-coordinate/subscribers","subscription_url":"https://api.github.com/repos/youth27/swift-coordinate/subscription","commits_url":"https://api.github.com/repos/youth27/swift-coordinate/commits{/sha}","git_commits_url":"https://api.github.com/repos/youth27/swift-coordinate/git/commits{/sha}","comments_url":"https://api.github.com/repos/youth27/swift-coordinate/comments{/number}","issue_comment_url":"https://api.github.com/repos/youth27/swift-coordinate/issues/comments{/number}","contents_url":"https://api.github.com/repos/youth27/swift-coordinate/contents/{+path}","compare_url":"https://api.github.com/repos/youth27/swift-coordinate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youth27/swift-coordinate/merges","archive_url":"https://api.github.com/repos/youth27/swift-coordinate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youth27/swift-coordinate/downloads","issues_url":"https://api.github.com/repos/youth27/swift-coordinate/issues{/number}","pulls_url":"https://api.github.com/repos/youth27/swift-coordinate/pulls{/number}","milestones_url":"https://api.github.com/repos/youth27/swift-coordinate/milestones{/number}","notifications_url":"https://api.github.com/repos/youth27/swift-coordinate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youth27/swift-coordinate/labels{/name}","releases_url":"https://api.github.com/repos/youth27/swift-coordinate/releases{/id}","deployments_url":"https://api.github.com/repos/youth27/swift-coordinate/deployments","created_at":"2017-11-16T07:16:04Z","updated_at":"2017-11-16T07:16:05Z","pushed_at":"2017-11-28T09:51:14Z","git_url":"git://github.com/youth27/swift-coordinate.git","ssh_url":"[email protected]:youth27/swift-coordinate.git","clone_url":"https://github.com/youth27/swift-coordinate.git","svn_url":"https://github.com/youth27/swift-coordinate","homepage":null,"size":3039,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"youth27"}},"base":{"label":"code-squad:youth27","ref":"youth27","sha":"af45ace4b424c3f4c68c2eea2c22988170186935","user":{"login":"code-squad","id":22832280,"avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":106258411,"name":"swift-coordinate","full_name":"code-squad/swift-coordinate","owner":{"login":"code-squad","id":22832280,"avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-squad/swift-coordinate","description":"좌표계산기_저장소","fork":false,"url":"https://api.github.com/repos/code-squad/swift-coordinate","forks_url":"https://api.github.com/repos/code-squad/swift-coordinate/forks","keys_url":"https://api.github.com/repos/code-squad/swift-coordinate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-squad/swift-coordinate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-squad/swift-coordinate/teams","hooks_url":"https://api.github.com/repos/code-squad/swift-coordinate/hooks","issue_events_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/events{/number}","events_url":"https://api.github.com/repos/code-squad/swift-coordinate/events","assignees_url":"https://api.github.com/repos/code-squad/swift-coordinate/assignees{/user}","branches_url":"https://api.github.com/repos/code-squad/swift-coordinate/branches{/branch}","tags_url":"https://api.github.com/repos/code-squad/swift-coordinate/tags","blobs_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/{sha}","languages_url":"https://api.github.com/repos/code-squad/swift-coordinate/languages","stargazers_url":"https://api.github.com/repos/code-squad/swift-coordinate/stargazers","contributors_url":"https://api.github.com/repos/code-squad/swift-coordinate/contributors","subscribers_url":"https://api.github.com/repos/code-squad/swift-coordinate/subscribers","subscription_url":"https://api.github.com/repos/code-squad/swift-coordinate/subscription","commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-squad/swift-coordinate/contents/{+path}","compare_url":"https://api.github.com/repos/code-squad/swift-coordinate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-squad/swift-coordinate/merges","archive_url":"https://api.github.com/repos/code-squad/swift-coordinate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-squad/swift-coordinate/downloads","issues_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues{/number}","pulls_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls{/number}","milestones_url":"https://api.github.com/repos/code-squad/swift-coordinate/milestones{/number}","notifications_url":"https://api.github.com/repos/code-squad/swift-coordinate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-squad/swift-coordinate/labels{/name}","releases_url":"https://api.github.com/repos/code-squad/swift-coordinate/releases{/id}","deployments_url":"https://api.github.com/repos/code-squad/swift-coordinate/deployments","created_at":"2017-10-09T08:45:05Z","updated_at":"2017-10-09T08:49:44Z","pushed_at":"2017-11-28T10:03:36Z","git_url":"git://github.com/code-squad/swift-coordinate.git","ssh_url":"[email protected]:code-squad/swift-coordinate.git","clone_url":"https://github.com/code-squad/swift-coordinate.git","svn_url":"https://github.com/code-squad/swift-coordinate","homepage":null,"size":3060,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":8,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/50"},"html":{"href":"https://github.com/code-squad/swift-coordinate/pull/50"},"issue":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/issues/50"},"comments":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/4431b1fabe35be0aca57a6d7a828229576440531"}},"author_association":"NONE"}} | {
"id": 106258411,
"name": "code-squad/swift-coordinate",
"url": "https://api.github.com/repos/code-squad/swift-coordinate"
} | {
"id": 278988,
"login": "godrm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/278988?",
"url": "https://api.github.com/users/godrm"
} | {
"id": 22832280,
"login": "code-squad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22832280?",
"url": "https://api.github.com/orgs/code-squad"
} | 2017-11-29T04:34:07 | 6916749808 | {"actor":{"display_login":"godrm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/codex-team/codex/pulls/comments/156757150","pull_request_review_id":83286342,"id":156757150,"diff_hunk":"@@ -0,0 +1,31 @@\n+msgid \"\"","path":"locale/ru_RU/LC_MESSAGES/ifmo.su.po","position":1,"original_position":1,"commit_id":"9854d20f1c1c085c906f9f9e05236a5100308337","original_commit_id":"9854d20f1c1c085c906f9f9e05236a5100308337","user":{"login":"neSpecc","id":3684889,"avatar_url":"https://avatars0.githubusercontent.com/u/3684889?v=4","gravatar_id":"","url":"https://api.github.com/users/neSpecc","html_url":"https://github.com/neSpecc","followers_url":"https://api.github.com/users/neSpecc/followers","following_url":"https://api.github.com/users/neSpecc/following{/other_user}","gists_url":"https://api.github.com/users/neSpecc/gists{/gist_id}","starred_url":"https://api.github.com/users/neSpecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neSpecc/subscriptions","organizations_url":"https://api.github.com/users/neSpecc/orgs","repos_url":"https://api.github.com/users/neSpecc/repos","events_url":"https://api.github.com/users/neSpecc/events{/privacy}","received_events_url":"https://api.github.com/users/neSpecc/received_events","type":"User","site_admin":false},"body":"надо написать инструкцию по обновлению словаря и приложить ее куда-то","created_at":"2017-12-13T19:24:41Z","updated_at":"2017-12-13T19:24:44Z","html_url":"https://github.com/codex-team/codex/pull/404#discussion_r156757150","pull_request_url":"https://api.github.com/repos/codex-team/codex/pulls/404","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/codex-team/codex/pulls/comments/156757150"},"html":{"href":"https://github.com/codex-team/codex/pull/404#discussion_r156757150"},"pull_request":{"href":"https://api.github.com/repos/codex-team/codex/pulls/404"}}},"pull_request":{"url":"https://api.github.com/repos/codex-team/codex/pulls/404","id":156712240,"html_url":"https://github.com/codex-team/codex/pull/404","diff_url":"https://github.com/codex-team/codex/pull/404.diff","patch_url":"https://github.com/codex-team/codex/pull/404.patch","issue_url":"https://api.github.com/repos/codex-team/codex/issues/404","number":404,"state":"open","locked":false,"title":"internationalization","user":{"login":"dankunis","id":32678968,"avatar_url":"https://avatars1.githubusercontent.com/u/32678968?v=4","gravatar_id":"","url":"https://api.github.com/users/dankunis","html_url":"https://github.com/dankunis","followers_url":"https://api.github.com/users/dankunis/followers","following_url":"https://api.github.com/users/dankunis/following{/other_user}","gists_url":"https://api.github.com/users/dankunis/gists{/gist_id}","starred_url":"https://api.github.com/users/dankunis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankunis/subscriptions","organizations_url":"https://api.github.com/users/dankunis/orgs","repos_url":"https://api.github.com/users/dankunis/repos","events_url":"https://api.github.com/users/dankunis/events{/privacy}","received_events_url":"https://api.github.com/users/dankunis/received_events","type":"User","site_admin":false},"body":"- default language is English. The other one available is only Russian\r\n- a form is provided to switch between languages\r\n- uses cookies to remember the user's chosen language","created_at":"2017-12-06T12:04:22Z","updated_at":"2017-12-13T19:24:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77363a27b3f361820c7375bbd7248bf29f14cacc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/codex-team/codex/pulls/404/commits","review_comments_url":"https://api.github.com/repos/codex-team/codex/pulls/404/comments","review_comment_url":"https://api.github.com/repos/codex-team/codex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codex-team/codex/issues/404/comments","statuses_url":"https://api.github.com/repos/codex-team/codex/statuses/9854d20f1c1c085c906f9f9e05236a5100308337","head":{"label":"codex-team:i18n","ref":"i18n","sha":"9854d20f1c1c085c906f9f9e05236a5100308337","user":{"login":"codex-team","id":16060815,"avatar_url":"https://avatars0.githubusercontent.com/u/16060815?v=4","gravatar_id":"","url":"https://api.github.com/users/codex-team","html_url":"https://github.com/codex-team","followers_url":"https://api.github.com/users/codex-team/followers","following_url":"https://api.github.com/users/codex-team/following{/other_user}","gists_url":"https://api.github.com/users/codex-team/gists{/gist_id}","starred_url":"https://api.github.com/users/codex-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codex-team/subscriptions","organizations_url":"https://api.github.com/users/codex-team/orgs","repos_url":"https://api.github.com/users/codex-team/repos","events_url":"https://api.github.com/users/codex-team/events{/privacy}","received_events_url":"https://api.github.com/users/codex-team/received_events","type":"Organization","site_admin":false},"repo":{"id":44992775,"name":"codex","full_name":"codex-team/codex","owner":{"login":"codex-team","id":16060815,"avatar_url":"https://avatars0.githubusercontent.com/u/16060815?v=4","gravatar_id":"","url":"https://api.github.com/users/codex-team","html_url":"https://github.com/codex-team","followers_url":"https://api.github.com/users/codex-team/followers","following_url":"https://api.github.com/users/codex-team/following{/other_user}","gists_url":"https://api.github.com/users/codex-team/gists{/gist_id}","starred_url":"https://api.github.com/users/codex-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codex-team/subscriptions","organizations_url":"https://api.github.com/users/codex-team/orgs","repos_url":"https://api.github.com/users/codex-team/repos","events_url":"https://api.github.com/users/codex-team/events{/privacy}","received_events_url":"https://api.github.com/users/codex-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codex-team/codex","description":"Codex Team development","fork":false,"url":"https://api.github.com/repos/codex-team/codex","forks_url":"https://api.github.com/repos/codex-team/codex/forks","keys_url":"https://api.github.com/repos/codex-team/codex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codex-team/codex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codex-team/codex/teams","hooks_url":"https://api.github.com/repos/codex-team/codex/hooks","issue_events_url":"https://api.github.com/repos/codex-team/codex/issues/events{/number}","events_url":"https://api.github.com/repos/codex-team/codex/events","assignees_url":"https://api.github.com/repos/codex-team/codex/assignees{/user}","branches_url":"https://api.github.com/repos/codex-team/codex/branches{/branch}","tags_url":"https://api.github.com/repos/codex-team/codex/tags","blobs_url":"https://api.github.com/repos/codex-team/codex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codex-team/codex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codex-team/codex/git/refs{/sha}","trees_url":"https://api.github.com/repos/codex-team/codex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codex-team/codex/statuses/{sha}","languages_url":"https://api.github.com/repos/codex-team/codex/languages","stargazers_url":"https://api.github.com/repos/codex-team/codex/stargazers","contributors_url":"https://api.github.com/repos/codex-team/codex/contributors","subscribers_url":"https://api.github.com/repos/codex-team/codex/subscribers","subscription_url":"https://api.github.com/repos/codex-team/codex/subscription","commits_url":"https://api.github.com/repos/codex-team/codex/commits{/sha}","git_commits_url":"https://api.github.com/repos/codex-team/codex/git/commits{/sha}","comments_url":"https://api.github.com/repos/codex-team/codex/comments{/number}","issue_comment_url":"https://api.github.com/repos/codex-team/codex/issues/comments{/number}","contents_url":"https://api.github.com/repos/codex-team/codex/contents/{+path}","compare_url":"https://api.github.com/repos/codex-team/codex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codex-team/codex/merges","archive_url":"https://api.github.com/repos/codex-team/codex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codex-team/codex/downloads","issues_url":"https://api.github.com/repos/codex-team/codex/issues{/number}","pulls_url":"https://api.github.com/repos/codex-team/codex/pulls{/number}","milestones_url":"https://api.github.com/repos/codex-team/codex/milestones{/number}","notifications_url":"https://api.github.com/repos/codex-team/codex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codex-team/codex/labels{/name}","releases_url":"https://api.github.com/repos/codex-team/codex/releases{/id}","deployments_url":"https://api.github.com/repos/codex-team/codex/deployments","created_at":"2015-10-26T19:41:35Z","updated_at":"2017-01-16T20:25:47Z","pushed_at":"2017-12-13T19:18:45Z","git_url":"git://github.com/codex-team/codex.git","ssh_url":"[email protected]:codex-team/codex.git","clone_url":"https://github.com/codex-team/codex.git","svn_url":"https://github.com/codex-team/codex","homepage":"https://ifmo.su","size":51374,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":7,"open_issues":29,"watchers":5,"default_branch":"master"}},"base":{"label":"codex-team:master","ref":"master","sha":"3ca082194bb14919f9d071b724ee2a075047426d","user":{"login":"codex-team","id":16060815,"avatar_url":"https://avatars0.githubusercontent.com/u/16060815?v=4","gravatar_id":"","url":"https://api.github.com/users/codex-team","html_url":"https://github.com/codex-team","followers_url":"https://api.github.com/users/codex-team/followers","following_url":"https://api.github.com/users/codex-team/following{/other_user}","gists_url":"https://api.github.com/users/codex-team/gists{/gist_id}","starred_url":"https://api.github.com/users/codex-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codex-team/subscriptions","organizations_url":"https://api.github.com/users/codex-team/orgs","repos_url":"https://api.github.com/users/codex-team/repos","events_url":"https://api.github.com/users/codex-team/events{/privacy}","received_events_url":"https://api.github.com/users/codex-team/received_events","type":"Organization","site_admin":false},"repo":{"id":44992775,"name":"codex","full_name":"codex-team/codex","owner":{"login":"codex-team","id":16060815,"avatar_url":"https://avatars0.githubusercontent.com/u/16060815?v=4","gravatar_id":"","url":"https://api.github.com/users/codex-team","html_url":"https://github.com/codex-team","followers_url":"https://api.github.com/users/codex-team/followers","following_url":"https://api.github.com/users/codex-team/following{/other_user}","gists_url":"https://api.github.com/users/codex-team/gists{/gist_id}","starred_url":"https://api.github.com/users/codex-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codex-team/subscriptions","organizations_url":"https://api.github.com/users/codex-team/orgs","repos_url":"https://api.github.com/users/codex-team/repos","events_url":"https://api.github.com/users/codex-team/events{/privacy}","received_events_url":"https://api.github.com/users/codex-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codex-team/codex","description":"Codex Team development","fork":false,"url":"https://api.github.com/repos/codex-team/codex","forks_url":"https://api.github.com/repos/codex-team/codex/forks","keys_url":"https://api.github.com/repos/codex-team/codex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codex-team/codex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codex-team/codex/teams","hooks_url":"https://api.github.com/repos/codex-team/codex/hooks","issue_events_url":"https://api.github.com/repos/codex-team/codex/issues/events{/number}","events_url":"https://api.github.com/repos/codex-team/codex/events","assignees_url":"https://api.github.com/repos/codex-team/codex/assignees{/user}","branches_url":"https://api.github.com/repos/codex-team/codex/branches{/branch}","tags_url":"https://api.github.com/repos/codex-team/codex/tags","blobs_url":"https://api.github.com/repos/codex-team/codex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codex-team/codex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codex-team/codex/git/refs{/sha}","trees_url":"https://api.github.com/repos/codex-team/codex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codex-team/codex/statuses/{sha}","languages_url":"https://api.github.com/repos/codex-team/codex/languages","stargazers_url":"https://api.github.com/repos/codex-team/codex/stargazers","contributors_url":"https://api.github.com/repos/codex-team/codex/contributors","subscribers_url":"https://api.github.com/repos/codex-team/codex/subscribers","subscription_url":"https://api.github.com/repos/codex-team/codex/subscription","commits_url":"https://api.github.com/repos/codex-team/codex/commits{/sha}","git_commits_url":"https://api.github.com/repos/codex-team/codex/git/commits{/sha}","comments_url":"https://api.github.com/repos/codex-team/codex/comments{/number}","issue_comment_url":"https://api.github.com/repos/codex-team/codex/issues/comments{/number}","contents_url":"https://api.github.com/repos/codex-team/codex/contents/{+path}","compare_url":"https://api.github.com/repos/codex-team/codex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codex-team/codex/merges","archive_url":"https://api.github.com/repos/codex-team/codex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codex-team/codex/downloads","issues_url":"https://api.github.com/repos/codex-team/codex/issues{/number}","pulls_url":"https://api.github.com/repos/codex-team/codex/pulls{/number}","milestones_url":"https://api.github.com/repos/codex-team/codex/milestones{/number}","notifications_url":"https://api.github.com/repos/codex-team/codex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codex-team/codex/labels{/name}","releases_url":"https://api.github.com/repos/codex-team/codex/releases{/id}","deployments_url":"https://api.github.com/repos/codex-team/codex/deployments","created_at":"2015-10-26T19:41:35Z","updated_at":"2017-01-16T20:25:47Z","pushed_at":"2017-12-13T19:18:45Z","git_url":"git://github.com/codex-team/codex.git","ssh_url":"[email protected]:codex-team/codex.git","clone_url":"https://github.com/codex-team/codex.git","svn_url":"https://github.com/codex-team/codex","homepage":"https://ifmo.su","size":51374,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":7,"open_issues":29,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codex-team/codex/pulls/404"},"html":{"href":"https://github.com/codex-team/codex/pull/404"},"issue":{"href":"https://api.github.com/repos/codex-team/codex/issues/404"},"comments":{"href":"https://api.github.com/repos/codex-team/codex/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/codex-team/codex/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/codex-team/codex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codex-team/codex/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/codex-team/codex/statuses/9854d20f1c1c085c906f9f9e05236a5100308337"}},"author_association":"CONTRIBUTOR"}} | {
"id": 44992775,
"name": "codex-team/codex",
"url": "https://api.github.com/repos/codex-team/codex"
} | {
"id": 3684889,
"login": "neSpecc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3684889?",
"url": "https://api.github.com/users/neSpecc"
} | {
"id": 16060815,
"login": "codex-team",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16060815?",
"url": "https://api.github.com/orgs/codex-team"
} | 2017-12-13T19:24:41 | 6984724478 | {"actor":{"display_login":"neSpecc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/codingteam/loglist/pulls/comments/125178739","pull_request_review_id":47546231,"id":125178739,"diff_hunk":"@@ -42,6 +42,28 @@ API Methods\n \n ### Quote access\n \n+#### Post the quote\n+\n+Send `POST` request to `/api/quote/new`. Quote should have the following form:\n+\n+```json\n+{\n+ \"text\": \"quote test\",","path":"docs/API.md","position":10,"original_position":10,"commit_id":"5ef68fe1812345bb443b5615c2310f53bf909b2e","original_commit_id":"5ef68fe1812345bb443b5615c2310f53bf909b2e","user":{"login":"Minoru","id":118875,"avatar_url":"https://avatars3.githubusercontent.com/u/118875?v=3","gravatar_id":"","url":"https://api.github.com/users/Minoru","html_url":"https://github.com/Minoru","followers_url":"https://api.github.com/users/Minoru/followers","following_url":"https://api.github.com/users/Minoru/following{/other_user}","gists_url":"https://api.github.com/users/Minoru/gists{/gist_id}","starred_url":"https://api.github.com/users/Minoru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minoru/subscriptions","organizations_url":"https://api.github.com/users/Minoru/orgs","repos_url":"https://api.github.com/users/Minoru/repos","events_url":"https://api.github.com/users/Minoru/events{/privacy}","received_events_url":"https://api.github.com/users/Minoru/received_events","type":"User","site_admin":false},"body":"This should say \"quote te**x**t\", shouldn't it?","created_at":"2017-07-02T09:52:04Z","updated_at":"2017-07-02T10:04:26Z","html_url":"https://github.com/codingteam/loglist/pull/208#discussion_r125178739","pull_request_url":"https://api.github.com/repos/codingteam/loglist/pulls/208","_links":{"self":{"href":"https://api.github.com/repos/codingteam/loglist/pulls/comments/125178739"},"html":{"href":"https://github.com/codingteam/loglist/pull/208#discussion_r125178739"},"pull_request":{"href":"https://api.github.com/repos/codingteam/loglist/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/codingteam/loglist/pulls/208","id":128513272,"html_url":"https://github.com/codingteam/loglist/pull/208","diff_url":"https://github.com/codingteam/loglist/pull/208.diff","patch_url":"https://github.com/codingteam/loglist/pull/208.patch","issue_url":"https://api.github.com/repos/codingteam/loglist/issues/208","number":208,"state":"open","locked":false,"title":"Quote post API","user":{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars1.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false},"body":"Closes #207.\r\n\r\nThe main page now looks like this:\r\n\r\n\r\n\r\n\r\n","created_at":"2017-07-02T08:25:14Z","updated_at":"2017-07-02T10:04:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e457da4352d29bcda2fb7deda8b025a8fdf7044","assignee":{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars1.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false},"assignees":[{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars1.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/codingteam/loglist/pulls/208/commits","review_comments_url":"https://api.github.com/repos/codingteam/loglist/pulls/208/comments","review_comment_url":"https://api.github.com/repos/codingteam/loglist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codingteam/loglist/issues/208/comments","statuses_url":"https://api.github.com/repos/codingteam/loglist/statuses/5ef68fe1812345bb443b5615c2310f53bf909b2e","head":{"label":"codingteam:feature/207-posting-api","ref":"feature/207-posting-api","sha":"5ef68fe1812345bb443b5615c2310f53bf909b2e","user":{"login":"codingteam","id":6565747,"avatar_url":"https://avatars1.githubusercontent.com/u/6565747?v=3","gravatar_id":"","url":"https://api.github.com/users/codingteam","html_url":"https://github.com/codingteam","followers_url":"https://api.github.com/users/codingteam/followers","following_url":"https://api.github.com/users/codingteam/following{/other_user}","gists_url":"https://api.github.com/users/codingteam/gists{/gist_id}","starred_url":"https://api.github.com/users/codingteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingteam/subscriptions","organizations_url":"https://api.github.com/users/codingteam/orgs","repos_url":"https://api.github.com/users/codingteam/repos","events_url":"https://api.github.com/users/codingteam/events{/privacy}","received_events_url":"https://api.github.com/users/codingteam/received_events","type":"Organization","site_admin":false},"repo":{"id":24348500,"name":"loglist","full_name":"codingteam/loglist","owner":{"login":"codingteam","id":6565747,"avatar_url":"https://avatars1.githubusercontent.com/u/6565747?v=3","gravatar_id":"","url":"https://api.github.com/users/codingteam","html_url":"https://github.com/codingteam","followers_url":"https://api.github.com/users/codingteam/followers","following_url":"https://api.github.com/users/codingteam/following{/other_user}","gists_url":"https://api.github.com/users/codingteam/gists{/gist_id}","starred_url":"https://api.github.com/users/codingteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingteam/subscriptions","organizations_url":"https://api.github.com/users/codingteam/orgs","repos_url":"https://api.github.com/users/codingteam/repos","events_url":"https://api.github.com/users/codingteam/events{/privacy}","received_events_url":"https://api.github.com/users/codingteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codingteam/loglist","description":"Reincarnation of the famous service","fork":false,"url":"https://api.github.com/repos/codingteam/loglist","forks_url":"https://api.github.com/repos/codingteam/loglist/forks","keys_url":"https://api.github.com/repos/codingteam/loglist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codingteam/loglist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codingteam/loglist/teams","hooks_url":"https://api.github.com/repos/codingteam/loglist/hooks","issue_events_url":"https://api.github.com/repos/codingteam/loglist/issues/events{/number}","events_url":"https://api.github.com/repos/codingteam/loglist/events","assignees_url":"https://api.github.com/repos/codingteam/loglist/assignees{/user}","branches_url":"https://api.github.com/repos/codingteam/loglist/branches{/branch}","tags_url":"https://api.github.com/repos/codingteam/loglist/tags","blobs_url":"https://api.github.com/repos/codingteam/loglist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codingteam/loglist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codingteam/loglist/git/refs{/sha}","trees_url":"https://api.github.com/repos/codingteam/loglist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codingteam/loglist/statuses/{sha}","languages_url":"https://api.github.com/repos/codingteam/loglist/languages","stargazers_url":"https://api.github.com/repos/codingteam/loglist/stargazers","contributors_url":"https://api.github.com/repos/codingteam/loglist/contributors","subscribers_url":"https://api.github.com/repos/codingteam/loglist/subscribers","subscription_url":"https://api.github.com/repos/codingteam/loglist/subscription","commits_url":"https://api.github.com/repos/codingteam/loglist/commits{/sha}","git_commits_url":"https://api.github.com/repos/codingteam/loglist/git/commits{/sha}","comments_url":"https://api.github.com/repos/codingteam/loglist/comments{/number}","issue_comment_url":"https://api.github.com/repos/codingteam/loglist/issues/comments{/number}","contents_url":"https://api.github.com/repos/codingteam/loglist/contents/{+path}","compare_url":"https://api.github.com/repos/codingteam/loglist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codingteam/loglist/merges","archive_url":"https://api.github.com/repos/codingteam/loglist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codingteam/loglist/downloads","issues_url":"https://api.github.com/repos/codingteam/loglist/issues{/number}","pulls_url":"https://api.github.com/repos/codingteam/loglist/pulls{/number}","milestones_url":"https://api.github.com/repos/codingteam/loglist/milestones{/number}","notifications_url":"https://api.github.com/repos/codingteam/loglist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codingteam/loglist/labels{/name}","releases_url":"https://api.github.com/repos/codingteam/loglist/releases{/id}","deployments_url":"https://api.github.com/repos/codingteam/loglist/deployments","created_at":"2014-09-22T22:52:15Z","updated_at":"2017-06-16T12:03:22Z","pushed_at":"2017-07-02T09:01:54Z","git_url":"git://github.com/codingteam/loglist.git","ssh_url":"[email protected]:codingteam/loglist.git","clone_url":"https://github.com/codingteam/loglist.git","svn_url":"https://github.com/codingteam/loglist","homepage":"https://loglist.net/","size":1216,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":62,"forks":3,"open_issues":62,"watchers":6,"default_branch":"master"}},"base":{"label":"codingteam:master","ref":"master","sha":"ba3f7c2c7418470aca37df45376365233b117527","user":{"login":"codingteam","id":6565747,"avatar_url":"https://avatars1.githubusercontent.com/u/6565747?v=3","gravatar_id":"","url":"https://api.github.com/users/codingteam","html_url":"https://github.com/codingteam","followers_url":"https://api.github.com/users/codingteam/followers","following_url":"https://api.github.com/users/codingteam/following{/other_user}","gists_url":"https://api.github.com/users/codingteam/gists{/gist_id}","starred_url":"https://api.github.com/users/codingteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingteam/subscriptions","organizations_url":"https://api.github.com/users/codingteam/orgs","repos_url":"https://api.github.com/users/codingteam/repos","events_url":"https://api.github.com/users/codingteam/events{/privacy}","received_events_url":"https://api.github.com/users/codingteam/received_events","type":"Organization","site_admin":false},"repo":{"id":24348500,"name":"loglist","full_name":"codingteam/loglist","owner":{"login":"codingteam","id":6565747,"avatar_url":"https://avatars1.githubusercontent.com/u/6565747?v=3","gravatar_id":"","url":"https://api.github.com/users/codingteam","html_url":"https://github.com/codingteam","followers_url":"https://api.github.com/users/codingteam/followers","following_url":"https://api.github.com/users/codingteam/following{/other_user}","gists_url":"https://api.github.com/users/codingteam/gists{/gist_id}","starred_url":"https://api.github.com/users/codingteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingteam/subscriptions","organizations_url":"https://api.github.com/users/codingteam/orgs","repos_url":"https://api.github.com/users/codingteam/repos","events_url":"https://api.github.com/users/codingteam/events{/privacy}","received_events_url":"https://api.github.com/users/codingteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codingteam/loglist","description":"Reincarnation of the famous service","fork":false,"url":"https://api.github.com/repos/codingteam/loglist","forks_url":"https://api.github.com/repos/codingteam/loglist/forks","keys_url":"https://api.github.com/repos/codingteam/loglist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codingteam/loglist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codingteam/loglist/teams","hooks_url":"https://api.github.com/repos/codingteam/loglist/hooks","issue_events_url":"https://api.github.com/repos/codingteam/loglist/issues/events{/number}","events_url":"https://api.github.com/repos/codingteam/loglist/events","assignees_url":"https://api.github.com/repos/codingteam/loglist/assignees{/user}","branches_url":"https://api.github.com/repos/codingteam/loglist/branches{/branch}","tags_url":"https://api.github.com/repos/codingteam/loglist/tags","blobs_url":"https://api.github.com/repos/codingteam/loglist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codingteam/loglist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codingteam/loglist/git/refs{/sha}","trees_url":"https://api.github.com/repos/codingteam/loglist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codingteam/loglist/statuses/{sha}","languages_url":"https://api.github.com/repos/codingteam/loglist/languages","stargazers_url":"https://api.github.com/repos/codingteam/loglist/stargazers","contributors_url":"https://api.github.com/repos/codingteam/loglist/contributors","subscribers_url":"https://api.github.com/repos/codingteam/loglist/subscribers","subscription_url":"https://api.github.com/repos/codingteam/loglist/subscription","commits_url":"https://api.github.com/repos/codingteam/loglist/commits{/sha}","git_commits_url":"https://api.github.com/repos/codingteam/loglist/git/commits{/sha}","comments_url":"https://api.github.com/repos/codingteam/loglist/comments{/number}","issue_comment_url":"https://api.github.com/repos/codingteam/loglist/issues/comments{/number}","contents_url":"https://api.github.com/repos/codingteam/loglist/contents/{+path}","compare_url":"https://api.github.com/repos/codingteam/loglist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codingteam/loglist/merges","archive_url":"https://api.github.com/repos/codingteam/loglist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codingteam/loglist/downloads","issues_url":"https://api.github.com/repos/codingteam/loglist/issues{/number}","pulls_url":"https://api.github.com/repos/codingteam/loglist/pulls{/number}","milestones_url":"https://api.github.com/repos/codingteam/loglist/milestones{/number}","notifications_url":"https://api.github.com/repos/codingteam/loglist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codingteam/loglist/labels{/name}","releases_url":"https://api.github.com/repos/codingteam/loglist/releases{/id}","deployments_url":"https://api.github.com/repos/codingteam/loglist/deployments","created_at":"2014-09-22T22:52:15Z","updated_at":"2017-06-16T12:03:22Z","pushed_at":"2017-07-02T09:01:54Z","git_url":"git://github.com/codingteam/loglist.git","ssh_url":"[email protected]:codingteam/loglist.git","clone_url":"https://github.com/codingteam/loglist.git","svn_url":"https://github.com/codingteam/loglist","homepage":"https://loglist.net/","size":1216,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":62,"forks":3,"open_issues":62,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codingteam/loglist/pulls/208"},"html":{"href":"https://github.com/codingteam/loglist/pull/208"},"issue":{"href":"https://api.github.com/repos/codingteam/loglist/issues/208"},"comments":{"href":"https://api.github.com/repos/codingteam/loglist/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/codingteam/loglist/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/codingteam/loglist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codingteam/loglist/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/codingteam/loglist/statuses/5ef68fe1812345bb443b5615c2310f53bf909b2e"}}}} | {
"id": 24348500,
"name": "codingteam/loglist",
"url": "https://api.github.com/repos/codingteam/loglist"
} | {
"id": 118875,
"login": "Minoru",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/118875?",
"url": "https://api.github.com/users/Minoru"
} | {
"id": 6565747,
"login": "codingteam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6565747?",
"url": "https://api.github.com/orgs/codingteam"
} | 2017-07-02T09:52:04 | 6178175490 | {"actor":{"display_login":"Minoru"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/crossroads/api.goodcity/pulls/comments/112168666","pull_request_review_id":33461382,"id":112168666,"diff_hunk":"@@ -14,84 +14,150 @@ namespace :demo do\n task load: :environment do\n puts \"This will generate #{count} record of Users, Offers, Packages, OrdersPackages, Orders, Contacts & Organisations\"\n create_offers\n- create_package\n- create_orders_packages\n create_orders\n create_contacts\n create_organizations\n end\n \n def create_offers\n- puts \"Offers:\\t\\t\\tCreating #{count} draft offers, #{count} submitted, #{count} under_review, #{count} reviewed, #{count} scheduled (with_transport), #{count} closed(with_transport)\"\n+ puts \"Offers:\\tCreating #{count} submitted, #{count} under_review, #{count} reviewed, #{count} scheduled , #{count} closed, #{count} receiving, #{count} received Offers\"\n count.times do\n- FactoryGirl.create(:offer, :with_demo_items, :with_messages, created_by: donor)\n- FactoryGirl.create(:offer, :submitted, :with_demo_items, :with_messages, created_by: donor)\n- FactoryGirl.create(:offer, :under_review, :with_demo_items, :with_messages, created_by: donor)\n- FactoryGirl.create(:offer, :reviewed, :with_demo_items, :with_messages, created_by: donor)\n- FactoryGirl.create(:offer, :scheduled, :with_transport, :with_demo_items, :with_messages, created_by: donor)\n- offer = FactoryGirl.create(:offer, :closed, :with_transport, :with_demo_items, :with_messages, created_by: donor)\n- Package.joins(item: :offer).where(\"offers.id = ?\", offer.id).each do |package|\n- package.allow_web_publish = true\n- end\n+ offer = create_submitted_offer\n+ puts \"\\t\\tCreated Offer #{offer.id} in 'submitted' state\"\n+ offer = create_reviewing_offer\n+ puts \"\\t\\tCreated Offer #{offer.id} in 'under_review' state\"\n+ offer = create_reviewed_offer\n+ puts \"\\t\\tCreated Offer #{offer.id} in 'reviewed' state\"\n+ offer = create_scheduled_offer\n+ puts \"\\t\\tCreated Offer #{offer.id} in 'scheduled' state\"\n+ offer = create_closed_offer\n+ puts \"\\t\\tCreated Offer #{offer.id} in 'closed' state\"\n+ offer = create_inactive_offer\n+ puts \"\\t\\tCreated Offer #{offer.id} in 'inactive' state\"\n+ offer = create_receiving_offer\n+ puts \"\\t\\tCreated Offer #{offer.id} in 'receiving' state\"\n+ offer = create_recieved_offer\n+ puts \"\\t\\tCreated Offer #{offer.id} in 'received' state\"\n end\n end\n \n- def create_package\n- # Create Packages for Goodcity and Items for Stockit\n- puts \"Package:\\t\\tCreating #{count} Packages for Goodcity and Items for Stockit(with_item, with_set_item, received(published and unpublished) & stockit_package\"\n-\n- count.times do\n- FactoryGirl.create(:package, :with_item, :package_with_locations, :with_inventory_number)\n- end\n- count.times do\n- FactoryGirl.create(:package, :stockit_package, :with_inventory_number , :package_with_locations)\n- end\n- count.times do\n- FactoryGirl.create(:package, :with_set_item, :package_with_locations)\n- end\n+ def create_orders\n+ puts \"Orders:\\tCreating #{count} designated and #{count} dispatached order with orders_packages \"\n count.times do\n- FactoryGirl.create(:package, :received, :with_inventory_number)\n+ create_designated_packages\n+ puts \"Orders:\\t\\t#{Order.last.id} Created #{count} Orders in Designated State\"\n+ create_dispatched_packages\n+ puts \"Orders:\\t\\t#{Order.last.id} Created #{count} Orders in Designated State\"\n end\n- count.times do\n- FactoryGirl.create(:package, :received, :with_inventory_number, :published)\n+ end\n+\n+ def create_submitted_offer\n+ offer = FactoryGirl.create(:offer, :with_demo_items, :with_messages, created_by: donor)\n+ offer.submit\n+ offer\n+ end\n+\n+ def create_reviewing_offer\n+ offer = create_submitted_offer\n+ reviewer = FactoryGirl.create(:user, :reviewer)\n+ User.current_user = reviewer\n+ offer.start_review\n+ offer\n+ end\n+\n+ def create_reviewed_offer\n+ offer = create_reviewing_offer\n+ offer.finish_review\n+ offer\n+ end\n+\n+ def create_scheduled_offer\n+ offer = create_reviewed_offer\n+ offer.schedule\n+ offer\n+ end\n+\n+ def create_inactive_offer\n+ offer = create_reviewing_offer\n+ offer.mark_inactive\n+ offer\n+ end\n+\n+ def create_closed_offer\n+ offer = create_reviewed_offer\n+ offer.mark_unwanted\n+ offer\n+ end\n+\n+ def create_receiving_offer\n+ offer = create_reviewed_offer\n+ offer.start_receiving\n+ offer\n+ end\n+\n+ def create_recieved_offer\n+ offer = create_receiving_offer\n+ offer = inventory_offer_packages (offer)","path":"lib/tasks/demo.rake","position":124,"original_position":124,"commit_id":"42aeb5943edf550674548aa9573bdac62c862ee4","original_commit_id":"42aeb5943edf550674548aa9573bdac62c862ee4","user":{"login":"namrataukirde","id":8424592,"avatar_url":"https://avatars0.githubusercontent.com/u/8424592?v=3","gravatar_id":"","url":"https://api.github.com/users/namrataukirde","html_url":"https://github.com/namrataukirde","followers_url":"https://api.github.com/users/namrataukirde/followers","following_url":"https://api.github.com/users/namrataukirde/following{/other_user}","gists_url":"https://api.github.com/users/namrataukirde/gists{/gist_id}","starred_url":"https://api.github.com/users/namrataukirde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namrataukirde/subscriptions","organizations_url":"https://api.github.com/users/namrataukirde/orgs","repos_url":"https://api.github.com/users/namrataukirde/repos","events_url":"https://api.github.com/users/namrataukirde/events{/privacy}","received_events_url":"https://api.github.com/users/namrataukirde/received_events","type":"User","site_admin":false},"body":"remove space before ()","created_at":"2017-04-19T10:36:31Z","updated_at":"2017-04-19T10:36:31Z","html_url":"https://github.com/crossroads/api.goodcity/pull/283#discussion_r112168666","pull_request_url":"https://api.github.com/repos/crossroads/api.goodcity/pulls/283","_links":{"self":{"href":"https://api.github.com/repos/crossroads/api.goodcity/pulls/comments/112168666"},"html":{"href":"https://github.com/crossroads/api.goodcity/pull/283#discussion_r112168666"},"pull_request":{"href":"https://api.github.com/repos/crossroads/api.goodcity/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/crossroads/api.goodcity/pulls/283","id":116494895,"html_url":"https://github.com/crossroads/api.goodcity/pull/283","diff_url":"https://github.com/crossroads/api.goodcity/pull/283.diff","patch_url":"https://github.com/crossroads/api.goodcity/pull/283.patch","issue_url":"https://api.github.com/repos/crossroads/api.goodcity/issues/283","number":283,"state":"open","locked":false,"title":"Gcw 1405 correct demo data to sync with stockit and follow lifecycle","user":{"login":"trojanh","id":22974490,"avatar_url":"https://avatars3.githubusercontent.com/u/22974490?v=3","gravatar_id":"","url":"https://api.github.com/users/trojanh","html_url":"https://github.com/trojanh","followers_url":"https://api.github.com/users/trojanh/followers","following_url":"https://api.github.com/users/trojanh/following{/other_user}","gists_url":"https://api.github.com/users/trojanh/gists{/gist_id}","starred_url":"https://api.github.com/users/trojanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trojanh/subscriptions","organizations_url":"https://api.github.com/users/trojanh/orgs","repos_url":"https://api.github.com/users/trojanh/repos","events_url":"https://api.github.com/users/trojanh/events{/privacy}","received_events_url":"https://api.github.com/users/trojanh/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-19T08:35:03Z","updated_at":"2017-04-19T10:36:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1370517b43e4faa6cd603d11a55f1a7b701224c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crossroads/api.goodcity/pulls/283/commits","review_comments_url":"https://api.github.com/repos/crossroads/api.goodcity/pulls/283/comments","review_comment_url":"https://api.github.com/repos/crossroads/api.goodcity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crossroads/api.goodcity/issues/283/comments","statuses_url":"https://api.github.com/repos/crossroads/api.goodcity/statuses/42aeb5943edf550674548aa9573bdac62c862ee4","head":{"label":"crossroads:GCW-1405-Correct-demo-data-to-sync-with-stockit-and-follow-lifecycle","ref":"GCW-1405-Correct-demo-data-to-sync-with-stockit-and-follow-lifecycle","sha":"42aeb5943edf550674548aa9573bdac62c862ee4","user":{"login":"crossroads","id":141971,"avatar_url":"https://avatars3.githubusercontent.com/u/141971?v=3","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"repo":{"id":21196107,"name":"api.goodcity","full_name":"crossroads/api.goodcity","owner":{"login":"crossroads","id":141971,"avatar_url":"https://avatars3.githubusercontent.com/u/141971?v=3","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crossroads/api.goodcity","description":"Good City API server","fork":false,"url":"https://api.github.com/repos/crossroads/api.goodcity","forks_url":"https://api.github.com/repos/crossroads/api.goodcity/forks","keys_url":"https://api.github.com/repos/crossroads/api.goodcity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossroads/api.goodcity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossroads/api.goodcity/teams","hooks_url":"https://api.github.com/repos/crossroads/api.goodcity/hooks","issue_events_url":"https://api.github.com/repos/crossroads/api.goodcity/issues/events{/number}","events_url":"https://api.github.com/repos/crossroads/api.goodcity/events","assignees_url":"https://api.github.com/repos/crossroads/api.goodcity/assignees{/user}","branches_url":"https://api.github.com/repos/crossroads/api.goodcity/branches{/branch}","tags_url":"https://api.github.com/repos/crossroads/api.goodcity/tags","blobs_url":"https://api.github.com/repos/crossroads/api.goodcity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossroads/api.goodcity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossroads/api.goodcity/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossroads/api.goodcity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossroads/api.goodcity/statuses/{sha}","languages_url":"https://api.github.com/repos/crossroads/api.goodcity/languages","stargazers_url":"https://api.github.com/repos/crossroads/api.goodcity/stargazers","contributors_url":"https://api.github.com/repos/crossroads/api.goodcity/contributors","subscribers_url":"https://api.github.com/repos/crossroads/api.goodcity/subscribers","subscription_url":"https://api.github.com/repos/crossroads/api.goodcity/subscription","commits_url":"https://api.github.com/repos/crossroads/api.goodcity/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossroads/api.goodcity/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossroads/api.goodcity/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossroads/api.goodcity/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossroads/api.goodcity/contents/{+path}","compare_url":"https://api.github.com/repos/crossroads/api.goodcity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossroads/api.goodcity/merges","archive_url":"https://api.github.com/repos/crossroads/api.goodcity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossroads/api.goodcity/downloads","issues_url":"https://api.github.com/repos/crossroads/api.goodcity/issues{/number}","pulls_url":"https://api.github.com/repos/crossroads/api.goodcity/pulls{/number}","milestones_url":"https://api.github.com/repos/crossroads/api.goodcity/milestones{/number}","notifications_url":"https://api.github.com/repos/crossroads/api.goodcity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossroads/api.goodcity/labels{/name}","releases_url":"https://api.github.com/repos/crossroads/api.goodcity/releases{/id}","deployments_url":"https://api.github.com/repos/crossroads/api.goodcity/deployments","created_at":"2014-06-25T08:40:40Z","updated_at":"2017-02-14T17:53:05Z","pushed_at":"2017-04-19T10:33:06Z","git_url":"git://github.com/crossroads/api.goodcity.git","ssh_url":"[email protected]:crossroads/api.goodcity.git","clone_url":"https://github.com/crossroads/api.goodcity.git","svn_url":"https://github.com/crossroads/api.goodcity","homepage":"http://api.goodcity.hk","size":3949,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"crossroads:master","ref":"master","sha":"45c802e90d6fbe0a203ef6db23e14f2c2bcf8806","user":{"login":"crossroads","id":141971,"avatar_url":"https://avatars3.githubusercontent.com/u/141971?v=3","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"repo":{"id":21196107,"name":"api.goodcity","full_name":"crossroads/api.goodcity","owner":{"login":"crossroads","id":141971,"avatar_url":"https://avatars3.githubusercontent.com/u/141971?v=3","gravatar_id":"","url":"https://api.github.com/users/crossroads","html_url":"https://github.com/crossroads","followers_url":"https://api.github.com/users/crossroads/followers","following_url":"https://api.github.com/users/crossroads/following{/other_user}","gists_url":"https://api.github.com/users/crossroads/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads/subscriptions","organizations_url":"https://api.github.com/users/crossroads/orgs","repos_url":"https://api.github.com/users/crossroads/repos","events_url":"https://api.github.com/users/crossroads/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crossroads/api.goodcity","description":"Good City API server","fork":false,"url":"https://api.github.com/repos/crossroads/api.goodcity","forks_url":"https://api.github.com/repos/crossroads/api.goodcity/forks","keys_url":"https://api.github.com/repos/crossroads/api.goodcity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossroads/api.goodcity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossroads/api.goodcity/teams","hooks_url":"https://api.github.com/repos/crossroads/api.goodcity/hooks","issue_events_url":"https://api.github.com/repos/crossroads/api.goodcity/issues/events{/number}","events_url":"https://api.github.com/repos/crossroads/api.goodcity/events","assignees_url":"https://api.github.com/repos/crossroads/api.goodcity/assignees{/user}","branches_url":"https://api.github.com/repos/crossroads/api.goodcity/branches{/branch}","tags_url":"https://api.github.com/repos/crossroads/api.goodcity/tags","blobs_url":"https://api.github.com/repos/crossroads/api.goodcity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossroads/api.goodcity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossroads/api.goodcity/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossroads/api.goodcity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossroads/api.goodcity/statuses/{sha}","languages_url":"https://api.github.com/repos/crossroads/api.goodcity/languages","stargazers_url":"https://api.github.com/repos/crossroads/api.goodcity/stargazers","contributors_url":"https://api.github.com/repos/crossroads/api.goodcity/contributors","subscribers_url":"https://api.github.com/repos/crossroads/api.goodcity/subscribers","subscription_url":"https://api.github.com/repos/crossroads/api.goodcity/subscription","commits_url":"https://api.github.com/repos/crossroads/api.goodcity/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossroads/api.goodcity/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossroads/api.goodcity/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossroads/api.goodcity/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossroads/api.goodcity/contents/{+path}","compare_url":"https://api.github.com/repos/crossroads/api.goodcity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossroads/api.goodcity/merges","archive_url":"https://api.github.com/repos/crossroads/api.goodcity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossroads/api.goodcity/downloads","issues_url":"https://api.github.com/repos/crossroads/api.goodcity/issues{/number}","pulls_url":"https://api.github.com/repos/crossroads/api.goodcity/pulls{/number}","milestones_url":"https://api.github.com/repos/crossroads/api.goodcity/milestones{/number}","notifications_url":"https://api.github.com/repos/crossroads/api.goodcity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossroads/api.goodcity/labels{/name}","releases_url":"https://api.github.com/repos/crossroads/api.goodcity/releases{/id}","deployments_url":"https://api.github.com/repos/crossroads/api.goodcity/deployments","created_at":"2014-06-25T08:40:40Z","updated_at":"2017-02-14T17:53:05Z","pushed_at":"2017-04-19T10:33:06Z","git_url":"git://github.com/crossroads/api.goodcity.git","ssh_url":"[email protected]:crossroads/api.goodcity.git","clone_url":"https://github.com/crossroads/api.goodcity.git","svn_url":"https://github.com/crossroads/api.goodcity","homepage":"http://api.goodcity.hk","size":3949,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crossroads/api.goodcity/pulls/283"},"html":{"href":"https://github.com/crossroads/api.goodcity/pull/283"},"issue":{"href":"https://api.github.com/repos/crossroads/api.goodcity/issues/283"},"comments":{"href":"https://api.github.com/repos/crossroads/api.goodcity/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/crossroads/api.goodcity/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/crossroads/api.goodcity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crossroads/api.goodcity/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/crossroads/api.goodcity/statuses/42aeb5943edf550674548aa9573bdac62c862ee4"}}}} | {
"id": 21196107,
"name": "crossroads/api.goodcity",
"url": "https://api.github.com/repos/crossroads/api.goodcity"
} | {
"id": 8424592,
"login": "namrataukirde",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8424592?",
"url": "https://api.github.com/users/namrataukirde"
} | {
"id": 141971,
"login": "crossroads",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/141971?",
"url": "https://api.github.com/orgs/crossroads"
} | 2017-04-19T10:36:31 | 5714516076 | {"actor":{"display_login":"namrataukirde"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cyverse-de/ui/pulls/comments/118112802","pull_request_review_id":39875281,"id":118112802,"diff_hunk":"@@ -0,0 +1,144 @@\n+package org.iplantc.de.apps.client.views.tools;\n+\n+import org.iplantc.de.admin.desktop.client.toolAdmin.model.ToolProperties;\n+import org.iplantc.de.apps.client.views.ManageToolsToolbarView;\n+import org.iplantc.de.apps.client.views.ManageToolsView;\n+import org.iplantc.de.client.models.IsMaskable;\n+import org.iplantc.de.client.models.apps.App;\n+import org.iplantc.de.client.models.tool.Tool;\n+\n+import com.google.gwt.core.client.GWT;\n+import com.google.gwt.uibinder.client.UiBinder;\n+import com.google.gwt.uibinder.client.UiFactory;\n+import com.google.gwt.uibinder.client.UiField;\n+import com.google.gwt.uibinder.client.UiTemplate;\n+import com.google.gwt.user.client.ui.Widget;\n+import com.google.inject.Inject;\n+\n+import com.sencha.gxt.core.client.ValueProvider;\n+import com.sencha.gxt.data.shared.ListStore;\n+import com.sencha.gxt.data.shared.ModelKeyProvider;\n+import com.sencha.gxt.widget.core.client.container.VerticalLayoutContainer;\n+import com.sencha.gxt.widget.core.client.grid.ColumnConfig;\n+import com.sencha.gxt.widget.core.client.grid.ColumnModel;\n+import com.sencha.gxt.widget.core.client.grid.Grid;\n+import com.sencha.gxt.widget.core.client.grid.GridView;\n+\n+import java.util.Arrays;\n+import java.util.List;\n+\n+/**\n+ * Created by sriram on 4/21/17.\n+ */\n+public class ManageToolsViewImpl implements ManageToolsView {\n+\n+\n+ private final ManageToolsViewAppearance appearance;\n+\n+ @UiTemplate(\"ManageToolsView.ui.xml\")\n+ interface ManageToolsViewUiBinder extends UiBinder<Widget, ManageToolsViewImpl> {\n+ }\n+\n+ @UiField\n+ ListStore<Tool> listStore;\n+\n+ @UiField\n+ ColumnModel cm;\n+\n+ @UiField\n+ Grid<App> grid;\n+\n+ @UiField\n+ GridView<Tool> gridView;\n+\n+ @UiField\n+ VerticalLayoutContainer container;\n+\n+ @UiField(provided = true)\n+ ManageToolsToolbarView toolbar;\n+\n+ private static final ManageToolsViewUiBinder uiBinder = GWT.create(ManageToolsViewUiBinder.class);\n+\n+ @Inject\n+ public ManageToolsViewImpl(ManageToolsView.ManageToolsViewAppearance appearance,\n+ ManageToolsToolbarView toolbar) {\n+ this.appearance = appearance;\n+ this.toolbar = toolbar;\n+ uiBinder.createAndBindUi(this);\n+ }\n+\n+ @Override\n+ public Widget asWidget() {\n+ return container;\n+ }\n+\n+ @UiFactory\n+ ListStore<Tool> buildListStore() {\n+ return new ListStore<>(new ModelKeyProvider<Tool>() {\n+ @Override\n+ public String getKey(Tool item) {\n+ return item.getId();\n+ }\n+ });\n+ }\n+\n+ @UiFactory\n+ ColumnModel<Tool> buildColumnModel() {\n+ ToolProperties tp = GWT.create(ToolProperties.class);\n+ ColumnConfig<Tool, String> nameCol =\n+ new ColumnConfig<Tool, String>(tp.name(), 150, appearance.name());\n+\n+ ColumnConfig<Tool, String> imgName = new ColumnConfig<Tool, String>(new ValueProvider<Tool, String>() {\n+ @Override\n+ public String getValue(Tool object) {\n+ return object.getContainer()!=null ? object.getContainer().getImage().getName() : \"\";\n+ }\n+\n+ @Override\n+ public void setValue(Tool object, String value) {\n+\n+ }\n+\n+ @Override\n+ public String getPath() {\n+ return null;\n+ }\n+ }, 200,appearance.imaName());\n+\n+ ColumnConfig<Tool, String> tag = new ColumnConfig<Tool, String>(new ValueProvider<Tool, String>() {\n+ @Override\n+ public String getValue(Tool object) {\n+ return object.getContainer()!=null ? object.getContainer().getImage().getTag() : \"\";\n+ }\n+\n+ @Override\n+ public void setValue(Tool object, String value) {\n+\n+ }\n+\n+ @Override\n+ public String getPath() {\n+ return null;\n+ }\n+ },50, appearance.version());\n+ return new ColumnModel<>(Arrays.asList(nameCol, imgName, tag));\n+ }\n+\n+ @Override\n+ public void loadTools(List<Tool> tools) {\n+ listStore.addAll(tools);\n+ }\n+\n+\n+ @Override\n+ public void mask(String loadingMask) {\n+ container.mask(loadingMask);","path":"de-lib/src/main/java/org/iplantc/de/apps/client/views/tools/ManageToolsViewImpl.java","position":135,"original_position":135,"commit_id":"ff048cc77d1f16589172ad625dbe9f7fb22fbaa5","original_commit_id":"ff048cc77d1f16589172ad625dbe9f7fb22fbaa5","user":{"login":"ash3rz","id":8909156,"avatar_url":"https://avatars3.githubusercontent.com/u/8909156?v=3","gravatar_id":"","url":"https://api.github.com/users/ash3rz","html_url":"https://github.com/ash3rz","followers_url":"https://api.github.com/users/ash3rz/followers","following_url":"https://api.github.com/users/ash3rz/following{/other_user}","gists_url":"https://api.github.com/users/ash3rz/gists{/gist_id}","starred_url":"https://api.github.com/users/ash3rz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ash3rz/subscriptions","organizations_url":"https://api.github.com/users/ash3rz/orgs","repos_url":"https://api.github.com/users/ash3rz/repos","events_url":"https://api.github.com/users/ash3rz/events{/privacy}","received_events_url":"https://api.github.com/users/ash3rz/received_events","type":"User","site_admin":false},"body":"Spacing looks different starting here compared to the rest of the file.","created_at":"2017-05-23T21:36:11Z","updated_at":"2017-05-23T21:50:22Z","html_url":"https://github.com/cyverse-de/ui/pull/132#discussion_r118112802","pull_request_url":"https://api.github.com/repos/cyverse-de/ui/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/cyverse-de/ui/pulls/comments/118112802"},"html":{"href":"https://github.com/cyverse-de/ui/pull/132#discussion_r118112802"},"pull_request":{"href":"https://api.github.com/repos/cyverse-de/ui/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/cyverse-de/ui/pulls/132","id":122097299,"html_url":"https://github.com/cyverse-de/ui/pull/132","diff_url":"https://github.com/cyverse-de/ui/pull/132.diff","patch_url":"https://github.com/cyverse-de/ui/pull/132.patch","issue_url":"https://api.github.com/repos/cyverse-de/ui/issues/132","number":132,"state":"open","locked":false,"title":"Core-8736 Create private tools UI","user":{"login":"sri2k1us","id":1250790,"avatar_url":"https://avatars0.githubusercontent.com/u/1250790?v=3","gravatar_id":"","url":"https://api.github.com/users/sri2k1us","html_url":"https://github.com/sri2k1us","followers_url":"https://api.github.com/users/sri2k1us/followers","following_url":"https://api.github.com/users/sri2k1us/following{/other_user}","gists_url":"https://api.github.com/users/sri2k1us/gists{/gist_id}","starred_url":"https://api.github.com/users/sri2k1us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri2k1us/subscriptions","organizations_url":"https://api.github.com/users/sri2k1us/orgs","repos_url":"https://api.github.com/users/sri2k1us/repos","events_url":"https://api.github.com/users/sri2k1us/events{/privacy}","received_events_url":"https://api.github.com/users/sri2k1us/received_events","type":"User","site_admin":false},"body":"This is first in the series of several PR's (#132-#140) for the new private tools UI. \r\n\r\nThis PR includes but not limited to:\r\n- Add `Manage Tools` button\r\n- Launch `Manage Tools` UI\r\n- Load tools\r\n\r\nTo Do's:\r\n- Unit tests\r\n- Belphegor part of the changes\r\n- Sharing with group\r\n- Apps used by a tool information in the `info` dialog\r\n","created_at":"2017-05-23T21:16:01Z","updated_at":"2017-05-23T21:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25ea30e3088d8f15505f8b684109b27f9a934966","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cyverse-de/ui/pulls/132/commits","review_comments_url":"https://api.github.com/repos/cyverse-de/ui/pulls/132/comments","review_comment_url":"https://api.github.com/repos/cyverse-de/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyverse-de/ui/issues/132/comments","statuses_url":"https://api.github.com/repos/cyverse-de/ui/statuses/ff048cc77d1f16589172ad625dbe9f7fb22fbaa5","head":{"label":"sri2k1us:core-8736","ref":"core-8736","sha":"ff048cc77d1f16589172ad625dbe9f7fb22fbaa5","user":{"login":"sri2k1us","id":1250790,"avatar_url":"https://avatars0.githubusercontent.com/u/1250790?v=3","gravatar_id":"","url":"https://api.github.com/users/sri2k1us","html_url":"https://github.com/sri2k1us","followers_url":"https://api.github.com/users/sri2k1us/followers","following_url":"https://api.github.com/users/sri2k1us/following{/other_user}","gists_url":"https://api.github.com/users/sri2k1us/gists{/gist_id}","starred_url":"https://api.github.com/users/sri2k1us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri2k1us/subscriptions","organizations_url":"https://api.github.com/users/sri2k1us/orgs","repos_url":"https://api.github.com/users/sri2k1us/repos","events_url":"https://api.github.com/users/sri2k1us/events{/privacy}","received_events_url":"https://api.github.com/users/sri2k1us/received_events","type":"User","site_admin":false},"repo":{"id":67555676,"name":"ui","full_name":"sri2k1us/ui","owner":{"login":"sri2k1us","id":1250790,"avatar_url":"https://avatars0.githubusercontent.com/u/1250790?v=3","gravatar_id":"","url":"https://api.github.com/users/sri2k1us","html_url":"https://github.com/sri2k1us","followers_url":"https://api.github.com/users/sri2k1us/followers","following_url":"https://api.github.com/users/sri2k1us/following{/other_user}","gists_url":"https://api.github.com/users/sri2k1us/gists{/gist_id}","starred_url":"https://api.github.com/users/sri2k1us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri2k1us/subscriptions","organizations_url":"https://api.github.com/users/sri2k1us/orgs","repos_url":"https://api.github.com/users/sri2k1us/repos","events_url":"https://api.github.com/users/sri2k1us/events{/privacy}","received_events_url":"https://api.github.com/users/sri2k1us/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sri2k1us/ui","description":null,"fork":true,"url":"https://api.github.com/repos/sri2k1us/ui","forks_url":"https://api.github.com/repos/sri2k1us/ui/forks","keys_url":"https://api.github.com/repos/sri2k1us/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sri2k1us/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sri2k1us/ui/teams","hooks_url":"https://api.github.com/repos/sri2k1us/ui/hooks","issue_events_url":"https://api.github.com/repos/sri2k1us/ui/issues/events{/number}","events_url":"https://api.github.com/repos/sri2k1us/ui/events","assignees_url":"https://api.github.com/repos/sri2k1us/ui/assignees{/user}","branches_url":"https://api.github.com/repos/sri2k1us/ui/branches{/branch}","tags_url":"https://api.github.com/repos/sri2k1us/ui/tags","blobs_url":"https://api.github.com/repos/sri2k1us/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sri2k1us/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sri2k1us/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sri2k1us/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sri2k1us/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sri2k1us/ui/languages","stargazers_url":"https://api.github.com/repos/sri2k1us/ui/stargazers","contributors_url":"https://api.github.com/repos/sri2k1us/ui/contributors","subscribers_url":"https://api.github.com/repos/sri2k1us/ui/subscribers","subscription_url":"https://api.github.com/repos/sri2k1us/ui/subscription","commits_url":"https://api.github.com/repos/sri2k1us/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sri2k1us/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sri2k1us/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sri2k1us/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sri2k1us/ui/contents/{+path}","compare_url":"https://api.github.com/repos/sri2k1us/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sri2k1us/ui/merges","archive_url":"https://api.github.com/repos/sri2k1us/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sri2k1us/ui/downloads","issues_url":"https://api.github.com/repos/sri2k1us/ui/issues{/number}","pulls_url":"https://api.github.com/repos/sri2k1us/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sri2k1us/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sri2k1us/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sri2k1us/ui/labels{/name}","releases_url":"https://api.github.com/repos/sri2k1us/ui/releases{/id}","deployments_url":"https://api.github.com/repos/sri2k1us/ui/deployments","created_at":"2016-09-06T23:57:58Z","updated_at":"2016-09-06T23:58:04Z","pushed_at":"2017-05-23T21:22:18Z","git_url":"git://github.com/sri2k1us/ui.git","ssh_url":"[email protected]:sri2k1us/ui.git","clone_url":"https://github.com/sri2k1us/ui.git","svn_url":"https://github.com/sri2k1us/ui","homepage":null,"size":36114,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cyverse-de:private-tools","ref":"private-tools","sha":"46b6c22ae140480c58e0a91b498410b0e621eda2","user":{"login":"cyverse-de","id":20466326,"avatar_url":"https://avatars1.githubusercontent.com/u/20466326?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse-de","html_url":"https://github.com/cyverse-de","followers_url":"https://api.github.com/users/cyverse-de/followers","following_url":"https://api.github.com/users/cyverse-de/following{/other_user}","gists_url":"https://api.github.com/users/cyverse-de/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse-de/subscriptions","organizations_url":"https://api.github.com/users/cyverse-de/orgs","repos_url":"https://api.github.com/users/cyverse-de/repos","events_url":"https://api.github.com/users/cyverse-de/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse-de/received_events","type":"Organization","site_admin":false},"repo":{"id":66952656,"name":"ui","full_name":"cyverse-de/ui","owner":{"login":"cyverse-de","id":20466326,"avatar_url":"https://avatars1.githubusercontent.com/u/20466326?v=3","gravatar_id":"","url":"https://api.github.com/users/cyverse-de","html_url":"https://github.com/cyverse-de","followers_url":"https://api.github.com/users/cyverse-de/followers","following_url":"https://api.github.com/users/cyverse-de/following{/other_user}","gists_url":"https://api.github.com/users/cyverse-de/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse-de/subscriptions","organizations_url":"https://api.github.com/users/cyverse-de/orgs","repos_url":"https://api.github.com/users/cyverse-de/repos","events_url":"https://api.github.com/users/cyverse-de/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse-de/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyverse-de/ui","description":"The Discovery Environment frontend UI","fork":false,"url":"https://api.github.com/repos/cyverse-de/ui","forks_url":"https://api.github.com/repos/cyverse-de/ui/forks","keys_url":"https://api.github.com/repos/cyverse-de/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyverse-de/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyverse-de/ui/teams","hooks_url":"https://api.github.com/repos/cyverse-de/ui/hooks","issue_events_url":"https://api.github.com/repos/cyverse-de/ui/issues/events{/number}","events_url":"https://api.github.com/repos/cyverse-de/ui/events","assignees_url":"https://api.github.com/repos/cyverse-de/ui/assignees{/user}","branches_url":"https://api.github.com/repos/cyverse-de/ui/branches{/branch}","tags_url":"https://api.github.com/repos/cyverse-de/ui/tags","blobs_url":"https://api.github.com/repos/cyverse-de/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyverse-de/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyverse-de/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyverse-de/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyverse-de/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/cyverse-de/ui/languages","stargazers_url":"https://api.github.com/repos/cyverse-de/ui/stargazers","contributors_url":"https://api.github.com/repos/cyverse-de/ui/contributors","subscribers_url":"https://api.github.com/repos/cyverse-de/ui/subscribers","subscription_url":"https://api.github.com/repos/cyverse-de/ui/subscription","commits_url":"https://api.github.com/repos/cyverse-de/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyverse-de/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyverse-de/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyverse-de/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyverse-de/ui/contents/{+path}","compare_url":"https://api.github.com/repos/cyverse-de/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyverse-de/ui/merges","archive_url":"https://api.github.com/repos/cyverse-de/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyverse-de/ui/downloads","issues_url":"https://api.github.com/repos/cyverse-de/ui/issues{/number}","pulls_url":"https://api.github.com/repos/cyverse-de/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/cyverse-de/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/cyverse-de/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyverse-de/ui/labels{/name}","releases_url":"https://api.github.com/repos/cyverse-de/ui/releases{/id}","deployments_url":"https://api.github.com/repos/cyverse-de/ui/deployments","created_at":"2016-08-30T15:17:05Z","updated_at":"2017-02-27T19:05:34Z","pushed_at":"2017-05-23T21:43:13Z","git_url":"git://github.com/cyverse-de/ui.git","ssh_url":"[email protected]:cyverse-de/ui.git","clone_url":"https://github.com/cyverse-de/ui.git","svn_url":"https://github.com/cyverse-de/ui","homepage":"https://de.cyverse.org/de/","size":21012,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyverse-de/ui/pulls/132"},"html":{"href":"https://github.com/cyverse-de/ui/pull/132"},"issue":{"href":"https://api.github.com/repos/cyverse-de/ui/issues/132"},"comments":{"href":"https://api.github.com/repos/cyverse-de/ui/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/cyverse-de/ui/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/cyverse-de/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyverse-de/ui/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/cyverse-de/ui/statuses/ff048cc77d1f16589172ad625dbe9f7fb22fbaa5"}}}} | {
"id": 66952656,
"name": "cyverse-de/ui",
"url": "https://api.github.com/repos/cyverse-de/ui"
} | {
"id": 8909156,
"login": "ash3rz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8909156?",
"url": "https://api.github.com/users/ash3rz"
} | {
"id": 20466326,
"login": "cyverse-de",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20466326?",
"url": "https://api.github.com/orgs/cyverse-de"
} | 2017-05-23T21:36:11 | 5929439550 | {"actor":{"display_login":"ash3rz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/datacratic/pymldb/pulls/comments/95897444","pull_request_review_id":16468842,"id":95897444,"diff_hunk":"@@ -0,0 +1,93 @@\n+#sad\n+# progress_monitor.py\n+# Mich, 2017-01-12\n+# Copyright (c) 2017 Datacratic. All rights reserved.\n+#\n+from __future__ import absolute_import, division, print_function\n+import threading\n+import requests\n+from IPython.display import display, HTML","path":"pymldb/progress_monitor.py","position":14,"original_position":9,"commit_id":"dab78bbdd39fe1d6c2c419a7d8b359c26a93029b","original_commit_id":"be24d16aa1a9139d78febecd328a25d7ac1741f8","user":{"login":"FinchPowers","id":607566,"avatar_url":"https://avatars.githubusercontent.com/u/607566?v=3","gravatar_id":"","url":"https://api.github.com/users/FinchPowers","html_url":"https://github.com/FinchPowers","followers_url":"https://api.github.com/users/FinchPowers/followers","following_url":"https://api.github.com/users/FinchPowers/following{/other_user}","gists_url":"https://api.github.com/users/FinchPowers/gists{/gist_id}","starred_url":"https://api.github.com/users/FinchPowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinchPowers/subscriptions","organizations_url":"https://api.github.com/users/FinchPowers/orgs","repos_url":"https://api.github.com/users/FinchPowers/repos","events_url":"https://api.github.com/users/FinchPowers/events{/privacy}","received_events_url":"https://api.github.com/users/FinchPowers/received_events","type":"User","site_admin":false},"body":"will fix","created_at":"2017-01-12T22:16:16Z","updated_at":"2017-01-12T22:16:16Z","html_url":"https://github.com/datacratic/pymldb/pull/7#discussion_r95897444","pull_request_url":"https://api.github.com/repos/datacratic/pymldb/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/datacratic/pymldb/pulls/comments/95897444"},"html":{"href":"https://github.com/datacratic/pymldb/pull/7#discussion_r95897444"},"pull_request":{"href":"https://api.github.com/repos/datacratic/pymldb/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/datacratic/pymldb/pulls/7","id":100942334,"html_url":"https://github.com/datacratic/pymldb/pull/7","diff_url":"https://github.com/datacratic/pymldb/pull/7.diff","patch_url":"https://github.com/datacratic/pymldb/pull/7.patch","issue_url":"https://api.github.com/repos/datacratic/pymldb/issues/7","number":7,"state":"open","locked":false,"title":"Progress and cancel","user":{"login":"FinchPowers","id":607566,"avatar_url":"https://avatars.githubusercontent.com/u/607566?v=3","gravatar_id":"","url":"https://api.github.com/users/FinchPowers","html_url":"https://github.com/FinchPowers","followers_url":"https://api.github.com/users/FinchPowers/followers","following_url":"https://api.github.com/users/FinchPowers/following{/other_user}","gists_url":"https://api.github.com/users/FinchPowers/gists{/gist_id}","starred_url":"https://api.github.com/users/FinchPowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinchPowers/subscriptions","organizations_url":"https://api.github.com/users/FinchPowers/orgs","repos_url":"https://api.github.com/users/FinchPowers/repos","events_url":"https://api.github.com/users/FinchPowers/events{/privacy}","received_events_url":"https://api.github.com/users/FinchPowers/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-10T19:55:23Z","updated_at":"2017-01-12T22:16:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e884b26a9ca4d7bdd63c6e27111eab6205364854","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/datacratic/pymldb/pulls/7/commits","review_comments_url":"https://api.github.com/repos/datacratic/pymldb/pulls/7/comments","review_comment_url":"https://api.github.com/repos/datacratic/pymldb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datacratic/pymldb/issues/7/comments","statuses_url":"https://api.github.com/repos/datacratic/pymldb/statuses/dab78bbdd39fe1d6c2c419a7d8b359c26a93029b","head":{"label":"datacratic:progress_and_cancel","ref":"progress_and_cancel","sha":"dab78bbdd39fe1d6c2c419a7d8b359c26a93029b","user":{"login":"datacratic","id":121150,"avatar_url":"https://avatars.githubusercontent.com/u/121150?v=3","gravatar_id":"","url":"https://api.github.com/users/datacratic","html_url":"https://github.com/datacratic","followers_url":"https://api.github.com/users/datacratic/followers","following_url":"https://api.github.com/users/datacratic/following{/other_user}","gists_url":"https://api.github.com/users/datacratic/gists{/gist_id}","starred_url":"https://api.github.com/users/datacratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacratic/subscriptions","organizations_url":"https://api.github.com/users/datacratic/orgs","repos_url":"https://api.github.com/users/datacratic/repos","events_url":"https://api.github.com/users/datacratic/events{/privacy}","received_events_url":"https://api.github.com/users/datacratic/received_events","type":"Organization","site_admin":false},"repo":{"id":32468319,"name":"pymldb","full_name":"datacratic/pymldb","owner":{"login":"datacratic","id":121150,"avatar_url":"https://avatars.githubusercontent.com/u/121150?v=3","gravatar_id":"","url":"https://api.github.com/users/datacratic","html_url":"https://github.com/datacratic","followers_url":"https://api.github.com/users/datacratic/followers","following_url":"https://api.github.com/users/datacratic/following{/other_user}","gists_url":"https://api.github.com/users/datacratic/gists{/gist_id}","starred_url":"https://api.github.com/users/datacratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacratic/subscriptions","organizations_url":"https://api.github.com/users/datacratic/orgs","repos_url":"https://api.github.com/users/datacratic/repos","events_url":"https://api.github.com/users/datacratic/events{/privacy}","received_events_url":"https://api.github.com/users/datacratic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacratic/pymldb","description":"Python interface to the Machine Learning Database (MLDB).","fork":false,"url":"https://api.github.com/repos/datacratic/pymldb","forks_url":"https://api.github.com/repos/datacratic/pymldb/forks","keys_url":"https://api.github.com/repos/datacratic/pymldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacratic/pymldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacratic/pymldb/teams","hooks_url":"https://api.github.com/repos/datacratic/pymldb/hooks","issue_events_url":"https://api.github.com/repos/datacratic/pymldb/issues/events{/number}","events_url":"https://api.github.com/repos/datacratic/pymldb/events","assignees_url":"https://api.github.com/repos/datacratic/pymldb/assignees{/user}","branches_url":"https://api.github.com/repos/datacratic/pymldb/branches{/branch}","tags_url":"https://api.github.com/repos/datacratic/pymldb/tags","blobs_url":"https://api.github.com/repos/datacratic/pymldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacratic/pymldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacratic/pymldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacratic/pymldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacratic/pymldb/statuses/{sha}","languages_url":"https://api.github.com/repos/datacratic/pymldb/languages","stargazers_url":"https://api.github.com/repos/datacratic/pymldb/stargazers","contributors_url":"https://api.github.com/repos/datacratic/pymldb/contributors","subscribers_url":"https://api.github.com/repos/datacratic/pymldb/subscribers","subscription_url":"https://api.github.com/repos/datacratic/pymldb/subscription","commits_url":"https://api.github.com/repos/datacratic/pymldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacratic/pymldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacratic/pymldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacratic/pymldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacratic/pymldb/contents/{+path}","compare_url":"https://api.github.com/repos/datacratic/pymldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacratic/pymldb/merges","archive_url":"https://api.github.com/repos/datacratic/pymldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacratic/pymldb/downloads","issues_url":"https://api.github.com/repos/datacratic/pymldb/issues{/number}","pulls_url":"https://api.github.com/repos/datacratic/pymldb/pulls{/number}","milestones_url":"https://api.github.com/repos/datacratic/pymldb/milestones{/number}","notifications_url":"https://api.github.com/repos/datacratic/pymldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacratic/pymldb/labels{/name}","releases_url":"https://api.github.com/repos/datacratic/pymldb/releases{/id}","deployments_url":"https://api.github.com/repos/datacratic/pymldb/deployments","created_at":"2015-03-18T15:48:14Z","updated_at":"2016-10-25T06:14:27Z","pushed_at":"2017-01-12T22:11:18Z","git_url":"git://github.com/datacratic/pymldb.git","ssh_url":"[email protected]:datacratic/pymldb.git","clone_url":"https://github.com/datacratic/pymldb.git","svn_url":"https://github.com/datacratic/pymldb","homepage":"http://mldb.ai/","size":85,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"datacratic:master","ref":"master","sha":"2631cadfdfb9aaec5c3573b7fc13664359ee7690","user":{"login":"datacratic","id":121150,"avatar_url":"https://avatars.githubusercontent.com/u/121150?v=3","gravatar_id":"","url":"https://api.github.com/users/datacratic","html_url":"https://github.com/datacratic","followers_url":"https://api.github.com/users/datacratic/followers","following_url":"https://api.github.com/users/datacratic/following{/other_user}","gists_url":"https://api.github.com/users/datacratic/gists{/gist_id}","starred_url":"https://api.github.com/users/datacratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacratic/subscriptions","organizations_url":"https://api.github.com/users/datacratic/orgs","repos_url":"https://api.github.com/users/datacratic/repos","events_url":"https://api.github.com/users/datacratic/events{/privacy}","received_events_url":"https://api.github.com/users/datacratic/received_events","type":"Organization","site_admin":false},"repo":{"id":32468319,"name":"pymldb","full_name":"datacratic/pymldb","owner":{"login":"datacratic","id":121150,"avatar_url":"https://avatars.githubusercontent.com/u/121150?v=3","gravatar_id":"","url":"https://api.github.com/users/datacratic","html_url":"https://github.com/datacratic","followers_url":"https://api.github.com/users/datacratic/followers","following_url":"https://api.github.com/users/datacratic/following{/other_user}","gists_url":"https://api.github.com/users/datacratic/gists{/gist_id}","starred_url":"https://api.github.com/users/datacratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacratic/subscriptions","organizations_url":"https://api.github.com/users/datacratic/orgs","repos_url":"https://api.github.com/users/datacratic/repos","events_url":"https://api.github.com/users/datacratic/events{/privacy}","received_events_url":"https://api.github.com/users/datacratic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacratic/pymldb","description":"Python interface to the Machine Learning Database (MLDB).","fork":false,"url":"https://api.github.com/repos/datacratic/pymldb","forks_url":"https://api.github.com/repos/datacratic/pymldb/forks","keys_url":"https://api.github.com/repos/datacratic/pymldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacratic/pymldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacratic/pymldb/teams","hooks_url":"https://api.github.com/repos/datacratic/pymldb/hooks","issue_events_url":"https://api.github.com/repos/datacratic/pymldb/issues/events{/number}","events_url":"https://api.github.com/repos/datacratic/pymldb/events","assignees_url":"https://api.github.com/repos/datacratic/pymldb/assignees{/user}","branches_url":"https://api.github.com/repos/datacratic/pymldb/branches{/branch}","tags_url":"https://api.github.com/repos/datacratic/pymldb/tags","blobs_url":"https://api.github.com/repos/datacratic/pymldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacratic/pymldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacratic/pymldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacratic/pymldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacratic/pymldb/statuses/{sha}","languages_url":"https://api.github.com/repos/datacratic/pymldb/languages","stargazers_url":"https://api.github.com/repos/datacratic/pymldb/stargazers","contributors_url":"https://api.github.com/repos/datacratic/pymldb/contributors","subscribers_url":"https://api.github.com/repos/datacratic/pymldb/subscribers","subscription_url":"https://api.github.com/repos/datacratic/pymldb/subscription","commits_url":"https://api.github.com/repos/datacratic/pymldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacratic/pymldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacratic/pymldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacratic/pymldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacratic/pymldb/contents/{+path}","compare_url":"https://api.github.com/repos/datacratic/pymldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacratic/pymldb/merges","archive_url":"https://api.github.com/repos/datacratic/pymldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacratic/pymldb/downloads","issues_url":"https://api.github.com/repos/datacratic/pymldb/issues{/number}","pulls_url":"https://api.github.com/repos/datacratic/pymldb/pulls{/number}","milestones_url":"https://api.github.com/repos/datacratic/pymldb/milestones{/number}","notifications_url":"https://api.github.com/repos/datacratic/pymldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacratic/pymldb/labels{/name}","releases_url":"https://api.github.com/repos/datacratic/pymldb/releases{/id}","deployments_url":"https://api.github.com/repos/datacratic/pymldb/deployments","created_at":"2015-03-18T15:48:14Z","updated_at":"2016-10-25T06:14:27Z","pushed_at":"2017-01-12T22:11:18Z","git_url":"git://github.com/datacratic/pymldb.git","ssh_url":"[email protected]:datacratic/pymldb.git","clone_url":"https://github.com/datacratic/pymldb.git","svn_url":"https://github.com/datacratic/pymldb","homepage":"http://mldb.ai/","size":85,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datacratic/pymldb/pulls/7"},"html":{"href":"https://github.com/datacratic/pymldb/pull/7"},"issue":{"href":"https://api.github.com/repos/datacratic/pymldb/issues/7"},"comments":{"href":"https://api.github.com/repos/datacratic/pymldb/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/datacratic/pymldb/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/datacratic/pymldb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datacratic/pymldb/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/datacratic/pymldb/statuses/dab78bbdd39fe1d6c2c419a7d8b359c26a93029b"}}}} | {
"id": 32468319,
"name": "datacratic/pymldb",
"url": "https://api.github.com/repos/datacratic/pymldb"
} | {
"id": 607566,
"login": "FinchPowers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/607566?",
"url": "https://api.github.com/users/FinchPowers"
} | {
"id": 121150,
"login": "datacratic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/121150?",
"url": "https://api.github.com/orgs/datacratic"
} | 2017-01-12T22:16:16 | 5145672779 | {"actor":{"display_login":"FinchPowers"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.