sha
stringlengths
1
40
author
stringlengths
1
63
committer
stringlengths
1
41
message
stringlengths
1
65.5k
subject
stringlengths
1
5.64k
subject_length
float64
1
5.64k
is_chore
bool
2 classes
is_bot
bool
2 classes
subject_word_count
float64
1
806
verb_object_spacy
bool
2 classes
verb_object_stanza
bool
2 classes
fits_requirements
bool
2 classes
owner
stringlengths
2
15
repo
stringlengths
2
21
__index_level_0__
int64
0
85.4k
033bf9e00dc54568d03f525f81e6420f15bf3a03
Godfrey Chan
GitHub
Merge pull request #19380 from eramod/deprecate-input-attributes [FEATURE modernized-built-in-components] Implement input attrs deprecations
merge pull request from eramod/deprecate-input-attributes
58
true
false
5
true
false
false
emberjs
ember.js
1,500
ce8c28ba49149776be182ba03f23cfa592e86203
Dianne Eramo
Godfrey Chan
[FEATURE modernized-built-in-components] Implement input attrs deprecation Tracking issue: https://github.com/emberjs/ember.js/issues/19270 More specifically, it enables the <Input> attribute deprecations introduced in https://github.com/emberjs/ember.js/pull/19218, fixes broken tests, and updates all test {{input}} invocations to use <Input> instead.
[feature modernized-built-in-components] implement input attrs deprecation
74
false
false
6
false
false
false
emberjs
ember.js
1,501
bb607647f107a5046a19e67042bab33ba75f6e62
Chris Garrett
Chris Garrett
add more cases and tests
add more cases and tests
24
false
false
5
true
true
true
emberjs
ember.js
1,502
10f2f9bd23a614e3d6c68e6f522e0ed1f6d5c39b
Chris Garrett
GitHub
Merge pull request #19381 from emberjs/deprecate-array-observers [DEPRECATION] Add Array Observers deprecation
merge pull request from emberjs/deprecate-array-observers
58
true
false
5
true
false
false
emberjs
ember.js
1,503
e924821746b65237fbb6a775b503298094334453
Chris Garrett
Chris Garrett
address feedback
address feedback
16
false
false
2
true
true
false
emberjs
ember.js
1,504
79698e4c2a82abbff30110816cd28b0224ba9ac1
Chris Garrett
Chris Garrett
polish and address feedback
polish and address feedback
27
false
false
4
false
false
false
emberjs
ember.js
1,505
b06d98a118b3a49fd4ac200c37c2bc67d3a40296
Scott Newcomer
Chris Garrett
Address some feedback
address some feedback
21
false
false
3
true
true
true
emberjs
ember.js
1,506
a5ea5f969ceea31b98d51cdeca9705d75894eb14
Chris Garrett
Chris Garrett
RFC: 680 - Deprecate Implicit Injection on arbitrary Ember Framework objects
680 - deprecate implicit injection on arbitrary ember framework objects
71
false
false
10
false
false
false
emberjs
ember.js
1,507
71f9cd0c2212cbce988a6056bac08bf2c6c9db6c
Chris Garrett
Chris Garrett
[DEPRECATION] Add Array Observers deprecation Adds the array observers deprecation specified in RFC 692: https://github.com/emberjs/rfcs/blob/master/text/0692-deprecate-array-observers.md
[deprecation] add array observers deprecation
45
false
false
5
false
false
false
emberjs
ember.js
1,508
a5e6f090552fc1edfcbeac005f214bbacc4ad4fe
Robert Jackson
GitHub
Merge pull request #19365 from simonihmig/helper-blueprint [BUGFIX release] Remove non-existing re-export from helper-addon blueprint
merge pull request from simonihmig/helper-blueprint
52
true
false
5
true
false
false
emberjs
ember.js
1,509
e856dd20d97c8dee3393304a49297e8c20beb079
Robert Jackson
GitHub
Merge pull request #19379 from emberjs/refactor-data-adapter [CLEANUP] Refactor DataAdapter to not use observers or array observers
merge pull request from emberjs/refactor-data-adapter
54
true
false
5
true
true
false
emberjs
ember.js
1,510
c43bd612d1b8c001389b68b4d4aef1b4a08de727
Chris Garrett
Chris Garrett
[CLEANUP] Refactor DataAdapter to not use observers or array observers The DataAdapter class is exposed specifically for the Ember Inspector to support Ember Data. Currently, the adapter relies on both array observers and standard observers. This PR refactors the adapter to use autotracking-based methods for tracking changes instead, with minimal API churn. The main change is to introduce a regular poll that checks for changes after each backburner runloop. There are two types of polling done: 1. `TypeWatcher`, which checks to see if a record array has changed at all (e.g. contents have changed) 2. `RecordsWatcher`, which watches the array as a whole _and_ the individual records within it. Whenever any changes occur, it reiterates the records array, and looks for new records, updated records, and removed records, and notifies of any changes. This removes the need for both array observers _and_ standard observers. Standard observers were previously used to detect changes on the model instances, but now we autotrack _serializing_ them, and that autotracking is used to detect if they've been updated. \## Breaking Changes - The `recordsRemoved` callback from `watchRecords` has changed. It now receives an array of removed records, _not_ an index and count. On the consuming side in Ember Inspector, we'll have to update the code to remove the items passed via id explicitly. - The `observeRecord` method has been removed. Because serializing the object _is_ observing it (via autotracking) there is no need to manually observe it. Users who are still implementing this method (e.g. Ember Data) can still keep it, and it shouldn't cause issues, it just will no longer be called.
[cleanup] refactor dataadapter to not use observers or array observers
70
false
false
10
false
false
false
emberjs
ember.js
1,511
2aa6395d68c4ad3565676e71ceaa3b57d1d0ecfc
Robert Jackson
GitHub
Merge pull request #19378 from emberjs/rwjblue-patch-1 Fix typo in template-only-glimmer-components feature detection
merge pull request from emberjs/rwjblue-patch-1
48
true
false
5
true
false
false
emberjs
ember.js
1,512
bf78b4e18cf407aa323375f32d4514c283f25fda
Robert Jackson
GitHub
Fix typo in template-only-glimmer-components feature detection Fixes #19377
fix typo in template-only-glimmer-components feature detection
62
false
false
6
true
true
false
emberjs
ember.js
1,513
c1f73903a9b0e14e08445a7be2c401b0cf11dfe5
Robert Jackson
GitHub
Merge pull request #19376 from sandstrom/patch-7 ES6 property syntax in Location example
merge pull request from sandstrom/patch-7
42
true
false
5
true
false
false
emberjs
ember.js
1,514
bd7833770f03dc3be95ec945013e3d2976d2317f
sandstrom
GitHub
ES6 property syntax in Location example
es6 property syntax in location example
39
false
false
6
true
false
true
emberjs
ember.js
1,515
38f174252a051468bb12b9becd89a1600a24eec9
Robert Jackson
GitHub
Merge pull request #19298 from snewcomer/sn/router-serialize-proxy
merge pull request from snewcomer/sn/router-serialize-proxy
60
true
false
5
true
false
false
emberjs
ember.js
1,516
905ea775ebd8e3a52278d7b93be83a56338e1b40
Robert Jackson
GitHub
Merge pull request #19375 from emberjs/deprecate-template-transforms [DEPRECATION] Deprecate old class binding syntax and {{attrs}}
merge pull request from emberjs/deprecate-template-transforms
62
true
false
5
true
false
false
emberjs
ember.js
1,517
68a1c4f22aaace05846281c3249b1c7652f77a67
Robert Jackson
GitHub
Merge pull request #19373 from emberjs/deprecate-old-manager-capabilities [DEPRECATION] Deprecate Old Manager capabilities
merge pull request from emberjs/deprecate-old-manager-capabilities
67
true
false
5
true
false
false
emberjs
ember.js
1,518
b480c96ebcab31e6ae4256595188cd623a4a0bf5
Chris Garrett
GitHub
Merge pull request #19374 from patocallaghan/patoc/has-block-deprecation Add hasBlock and hasBlockParams deprecation messages
merge pull request from patocallaghan/patoc/has-block-deprecation
66
true
false
5
true
false
false
emberjs
ember.js
1,519
b9e19460ea30e5e214863aa8edf27194dda0865a
Pat O'Callaghan
Pat O'Callaghan
Add hasBlock and hasBlockParams deprecation messages
add hasblock and hasblockparams deprecation messages
52
false
false
6
true
false
false
emberjs
ember.js
1,520
65cceb36e1f95ff89311900c06fdd52ea4364b47
Chris Garrett
Chris Garrett
[DEPRECATION] Deprecate old class binding syntax and {{attrs}} Adds deprecations for the old class binding syntax, and accessing args via {{attrs}}.
[deprecation] deprecate old class binding syntax and {{attrs}}
62
false
false
8
false
false
false
emberjs
ember.js
1,521
002e4e86a763c6814e8035b411d41e384d76f61f
Katie Gengler
Katie Gengler
Add v3.25.0-beta.5 to CHANGELOG (cherry picked from commit fc823791afc3d0e4b4508a751efe127ce46330b5)
add v3.25.0-beta.5 to changelog
31
false
false
4
true
true
true
emberjs
ember.js
1,522
af63f53863451aa5fd469755cc36b046901bbec5
Chris Garrett
GitHub
Merge pull request #19372 from emberjs/deprecate-optional-features [DEPRECATION] Adds deprecations for Classic edition and optional features
merge pull request from emberjs/deprecate-optional-features
60
true
false
5
true
false
false
emberjs
ember.js
1,523
44b4d359a080c544e7fe59a53ab4389af4175149
Chris Garrett
Chris Garrett
Adds deprecations for Classic edition and optional features Adds the deprecations outlined in [RFC 704](https://github.com/emberjs/rfcs/blob/master/text/0704-deprecate-octane-optional-features.md) and [RFC 705](https://github.com/emberjs/rfcs/blob/master/text/0705-deprecate-jquery-optional-feature.md)
adds deprecations for classic edition and optional features
59
false
false
8
false
false
false
emberjs
ember.js
1,524
8e9d375b2da27e04dce1fa931419fb3e0da62ece
Chris Garrett
Chris Garrett
[DEPRECATION] Deprecate Old Manager capabilities Adds the deprecations for older manager capabilities versions.
[deprecation] deprecate old manager capabilities
48
false
false
5
false
false
false
emberjs
ember.js
1,525
182a25709d5f4739b1263392c98fdbbaee75e5f1
Robert Jackson
GitHub
Merge pull request #19370 from emberjs/prevent-inline-compilation-errors-for-older-htmlbars-precompile [BUGFIX beta] Update glimmer-vm to prevent errors for older inline precompilation
merge pull request from emberjs/prevent-inline-compilation-errors-for-older-htmlbars-precompile
96
true
false
5
true
false
false
emberjs
ember.js
1,526
9bc0b49e94374456c8433c37109a7cd3b42d561e
Robert Jackson
Robert Jackson
Update glimmer-vm to prevent errors for older inline precompilation This updates glimmer-vm to avoid emitting the `scope` property on precompiled template blocks when not using strict mode (when using strict mode `scope` will either be `null` or a function). This is specifically to work around a bug in older versions of babel-plugin-htmlbars-inline-precompile (versions from v2.0.0 through v4.0.1) where they would (incorrectly) attempt to build an `ObjectExpression` when a `null` value is found in the template precompilation result (D'oh!). Note: those versions of babel-plugin-htmlbars-inline-precompile should still be migrated away from (they are quite old, and will definitely not work for newer features like strict mode).
update glimmer-vm to prevent errors for older inline precompilation
67
false
false
9
true
true
false
emberjs
ember.js
1,527
77d8f7b99b84fe5d1404893b5320e2cbc26bb690
Robert Jackson
GitHub
Merge pull request #19371 from emberjs/deprecate-this-fallback Deprecate implicit `this` property lookup fallback
merge pull request from emberjs/deprecate-this-fallback
56
true
false
5
true
false
false
emberjs
ember.js
1,528
7b628fc857b5e04fc977e2f4ba00206581b50c02
Robert Jackson
Robert Jackson
Deprecate implicit `this` property lookup fallback Lands the deprecation proposed in [emberjs/rfcs#308](https://github.com/emberjs/rfcs/blob/master/text/0308-deprecate-property-lookup-fallback.md): The [no-implicit-this](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-implicit-this.md) template linting rule has been enabled for Ember applications by default since around Ember 3.16 (included in the `octane` preset). This PR will take that a step further and issue a deprecation for templates that are still using `{{foo}}` to mean `{{this.foo}}`. Note: It does provide for an easy way to temporarily disable the deprecation messages (e.g. to reduce console output to hone in on other issues). This is intended for sporadic usage while debugging **not** as a way to mitigate the deprecation (the fallback behavior will be removed in 4.0.0).
deprecate implicit `this` property lookup fallback
50
false
false
6
false
true
false
emberjs
ember.js
1,529
40d519547ee7ff43df9ea1c75d793a1fee1d5ad9
Scott Newcomer
Scott Newcomer
[Bug]: route serialize does not extract param off proxy
route serialize does not extract param off proxy
48
false
false
8
false
false
false
emberjs
ember.js
1,530
8959f88b8678fe03660eba203af9b58220a4c053
Katie Gengler
Katie Gengler
Add v3.25.0-beta.4 to CHANGELOG (cherry picked from commit 2dc1242d4ff7ba70cdcc1c4abebb4325e9bc973f)
add v3.25.0-beta.4 to changelog
31
false
false
4
true
true
true
emberjs
ember.js
1,531
ed45944d41ca67c9886562a6a2b871658707347d
Robert Jackson
GitHub
Merge pull request #19363 from emberjs/update-glimmer-vm-fix-rename-bug
merge pull request from emberjs/update-glimmer-vm-fix-rename-bug
65
true
false
5
true
false
false
emberjs
ember.js
1,532
d635e024a360c0fa676c8e633613ce5af5f7c767
Chris Garrett
Chris Garrett
[BUGFIX] Update VM, fix component name preprocessing
[bugfix] update vm, fix component name preprocessing
52
false
false
7
false
false
false
emberjs
ember.js
1,533
9c45519077261d76ce4bd31bbce5697004aa1eb4
dependabot-preview[bot]
GitHub
Merge pull request #19368 from emberjs/dependabot/npm_and_yarn/broccoli-babel-transpiler-7.8.0
merge pull request from emberjs/dependabot/npm_and_yarn/broccoli-babel-transpiler-7.8.0
88
true
true
5
true
false
false
emberjs
ember.js
1,534
e77cf5a643198cc602ab73b28061306ace8e5346
dependabot-preview[bot]
GitHub
Bump broccoli-babel-transpiler from 7.4.0 to 7.8.0 Bumps [broccoli-babel-transpiler](https://github.com/babel/broccoli-babel-transpiler) from 7.4.0 to 7.8.0. - [Release notes](https://github.com/babel/broccoli-babel-transpiler/releases) - [Changelog](https://github.com/babel/broccoli-babel-transpiler/blob/v7.8.0/CHANGELOG.md) - [Commits](https://github.com/babel/broccoli-babel-transpiler/compare/v7.4.0...v7.8.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
bump broccoli-babel-transpiler from 7.4.0 to 7.8.0
50
true
true
6
true
true
false
emberjs
ember.js
1,535
f5a60e9ad57f79380e5aa49c1cc42e760799fa38
dependabot-preview[bot]
GitHub
Merge pull request #19366 from emberjs/dependabot/npm_and_yarn/jquery-3.5.1
merge pull request from emberjs/dependabot/npm_and_yarn/jquery-3.5.1
69
true
true
5
true
false
false
emberjs
ember.js
1,536
9e51960a0e0126f5007ef2e1af06dceac9699bcd
dependabot-preview[bot]
GitHub
Bump jquery from 3.5.0 to 3.5.1 Bumps [jquery](https://github.com/jquery/jquery) from 3.5.0 to 3.5.1. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.5.0...3.5.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
bump jquery from 3.5.0 to 3.5.1
31
true
true
6
true
true
false
emberjs
ember.js
1,537
7aa82336dca3dbee789cf54115e31d797fc51809
simonihmig
simonihmig
Remove non-existing re-export from helper-addon blueprint The blueprint for an addon's `app/helpers/foo.js` contains a re-export of a named export of `addon/helpers/foo.js` which does not exist, as it only has a default export. FWIW, Embroider is constantly complaining about this (rightly).
remove non-existing re-export from helper-addon blueprint
57
false
false
6
true
true
false
emberjs
ember.js
1,538
ae836ec460d2b08fd9e38086f0f60aef14849706
Robert Jackson
GitHub
Merge pull request #19362 from emberjs/with-deprecation-url Add url for with helper deprecation
merge pull request from emberjs/with-deprecation-url
53
true
false
5
true
false
false
emberjs
ember.js
1,539
74e0f60d573a6981ccf5aed2f36372ff46035ad6
Ricardo Mendes
Ricardo Mendes
add url for with helper deprecation
add url for with helper deprecation
35
false
false
6
true
true
true
emberjs
ember.js
1,540
a7e016cd0227e3e09b211e750deb6ebf5260918d
Robert Jackson
GitHub
Merge pull request #19361 from emberjs/cleanup/update-tests-remove-property-fallback-usages
merge pull request from emberjs/cleanup/update-tests-remove-property-fallback-usages
85
true
false
5
true
false
false
emberjs
ember.js
1,541
7252371c0b2d5145a88d907c38d31f09e8495eb3
Chris Garrett
Chris Garrett
fix lint
fix lint
8
false
false
2
true
true
false
emberjs
ember.js
1,542
9a01c4e8f468dea57dad9dba074a01515e38caf4
Chris Garrett
Chris Garrett
[CLEANUP] Remove usages of property fallback lookup from tests Removes all usages of property fallback from tests, except where the tests are actually testing fallback lookup.
[cleanup] remove usages of property fallback lookup from tests
62
false
false
9
false
false
false
emberjs
ember.js
1,543
0f49c4e064ab6fc1a6aeaed63c5a421abf7f26d6
Chris Garrett
GitHub
Merge pull request #19218 from emberjs/refactor-input-component [FEATURE modernized-built-in-components] First-pass implementation
merge pull request from emberjs/refactor-input-component
57
true
false
5
true
false
false
emberjs
ember.js
1,544
82f3089f485b3a456788b7561199c4a822e6ea43
Robert Jackson
GitHub
Merge pull request #19359 from emberjs/deprecate-ie11 [DEPRECATION] Deprecates old browser support policy
merge pull request from emberjs/deprecate-ie11
47
true
false
5
true
false
false
emberjs
ember.js
1,545
07357ed691575a70be9b0d23fc3891c65d156efa
Chris Garrett
Robert Jackson
[DEPRECATION] Deprecates old browser support policy * Adds the deprecation specified in https://github.com/emberjs/rfcs/blob/master/text/0685-new-browser-support-policy.md * Updates the test harness to avoid failing CI for deprecations issued on IE11
[deprecation] deprecates old browser support policy
51
false
false
6
false
false
false
emberjs
ember.js
1,546
e1e2b4dacd922d3e071fd28c63a616e19003a75b
Ricardo Mendes
GitHub
Merge pull request #19355 from lifeart/patch-3 update license to 2021
merge pull request from lifeart/patch-3
40
true
false
5
true
false
false
emberjs
ember.js
1,547
3ad915e5cf1f622e51d186b8ae910ed3b4fedca0
Alex Kanunnikov
GitHub
update license to 2021
update license to 2021
22
false
false
4
true
false
true
emberjs
ember.js
1,548
f2be19507f0742a9471fa4fe0ce22ccf3104967d
Katie Gengler
Katie Gengler
Add v3.25.0-beta.3 to CHANGELOG (cherry picked from commit 25e17f0ea31c01239fc8b4fd8bdb52f003f2dea0)
add v3.25.0-beta.3 to changelog
31
false
false
4
true
true
true
emberjs
ember.js
1,549
7ad44a6733b4d637bd9cb6adb70034bb05ca2f6d
Robert Jackson
GitHub
Merge pull request #19351 from emberjs/fix-block-param-symbol-collision [BUGFIX beta] Ensure locals do not clobber components of the same name
merge pull request from emberjs/fix-block-param-symbol-collision
65
true
false
5
true
false
false
emberjs
ember.js
1,550
a1b70d10cdc47302b6a59c4926169147476a9b9e
Robert Jackson
Robert Jackson
[BUGFIX beta] Ensure locals do not clobber components of the same name Updates glimmer-vm to include https://github.com/glimmerjs/glimmer-vm/pull/1253.
[bugfix beta] ensure locals do not clobber components of the same name
70
false
false
12
false
false
false
emberjs
ember.js
1,551
c4c53c7b06a88541d0781de2925da055552f45be
Bert De Block
Bert De Block
[DOC] Correctly mark public link-to component named arguments
[doc] correctly mark public link-to component named arguments
61
false
false
8
false
false
false
emberjs
ember.js
1,552
27a413f6006fc9eba8f92e7960a57f889e1b56a4
Godfrey Chan
Godfrey Chan
Skip strict mode input test for now
skip strict mode input test for now
35
false
false
7
false
false
false
emberjs
ember.js
1,553
e6cf1766f8e02ddb24bf67833c148e7d7c93182f
Godfrey Chan
Godfrey Chan
[FEATURE modernized-built-in-components] First-pass implementation First-pass implementation for converting the `<Input>` component into an internal (not classic) component compatibly. This passes all the existing tests. Some follow-up work before this is ready for prime time: - Implement any remaining classic component features not covered by the existing tests. - Detect any unimplementable classic component features and deopt into the previous implementation. - Write the second deprecation RFC and get the proposal merged.
[feature modernized-built-in-components] first-pass implementation
66
false
false
4
false
false
false
emberjs
ember.js
1,554
10c258847d51175d8928f94e8201273674ba1f78
Godfrey Chan
GitHub
Merge pull request #19352 from emberjs/internal-cleanup [CLEANUP] Some misc cleanup for the internal classes
merge pull request from emberjs/internal-cleanup
49
true
false
5
true
false
false
emberjs
ember.js
1,555
432c2ec8e1e248ec9137fc830fda767ae6d593a4
Godfrey Chan
Godfrey Chan
[CLEANUP] Some misc cleanup for the internal classes
[cleanup] some misc cleanup for the internal classes
52
false
false
8
false
false
false
emberjs
ember.js
1,556
9b25abdbdaeddbf755d8db525f298094da9ec40a
Robert Jackson
GitHub
Merge pull request #19255 from emberjs/deprecatee-route-controller-transitions
merge pull request from emberjs/deprecatee-route-controller-transitions
72
true
false
5
true
false
false
emberjs
ember.js
1,557
c495d407a6300bc4acb44d1b89d477bfe8628247
Robert Jackson
GitHub
Merge pull request #19349 from bertdeblock/doc/call-super-in-glimmer-component-will-destroy-example [DOC] Call super in Glimmer component willDestroy hook example
merge pull request from bertdeblock/doc/call-super-in-glimmer-component-will-destroy-example
93
true
false
5
true
false
false
emberjs
ember.js
1,558
f2ff13b2793e3790726454f70ad6a181f1a046b8
Bert De Block
Bert De Block
[DOC] Call super in Glimmer component willDestroy hook example
[doc] call super in glimmer component willdestroy hook example
62
false
false
9
false
false
false
emberjs
ember.js
1,559
ec15f73ca51a83661811917ee4ca231fb454274f
dependabot-preview[bot]
GitHub
Merge pull request #19347 from emberjs/dependabot/npm_and_yarn/socket.io-2.4.1
merge pull request from emberjs/dependabot/npm_and_yarn/socket.io-2.4.1
72
true
true
5
true
false
false
emberjs
ember.js
1,560
99804d0217144bf0a1cd0b9a486515857ac9f60f
dependabot-preview[bot]
GitHub
[Security] Bump socket.io from 2.1.0 to 2.4.1 Bumps [socket.io](https://github.com/socketio/socket.io) from 2.1.0 to 2.4.1. **This update includes a security fix.** - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/2.1.0...2.4.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
[security] bump socket.io from 2.1.0 to 2.4.1
45
false
true
7
false
false
false
emberjs
ember.js
1,561
8c4504e8f70d96b1fb26bbf858e52e1e60642a36
Robert Jackson
GitHub
Merge pull request #19346 from emberjs/deprecate-with
merge pull request from emberjs/deprecate-with
47
true
false
5
true
false
false
emberjs
ember.js
1,562
446267c8d217741af34740730c2aef7a7d009b87
Godfrey Chan
Godfrey Chan
[RFC 445] Deprecate `{{#with}}` Also transforms `{{#with}}` into the equivalent combination of `{{#let}}` and/or `{{#if}}` to allow removing the legacy upstream code on the Glimmer VM side. See [RFC 445](https://github.com/emberjs/rfcs/blob/master/text/0445-deprecate-with.md).
[rfc 445] deprecate `{{#with}}`
31
false
false
4
false
false
false
emberjs
ember.js
1,563
ce0b37a81fb7eb0b4f43f8728a8ea4288ff5be57
Katie Gengler
Katie Gengler
Add v3.25.0-beta.2 to CHANGELOG (cherry picked from commit 761580686c2c2b6e812f5fc0893c305bcf9b95d2)
add v3.25.0-beta.2 to changelog
31
false
false
4
true
true
true
emberjs
ember.js
1,564
6488cb3ba75739d08a9e896d72f9c63647791c31
Ricardo Mendes
GitHub
update deprecation enabled target to 3.26.0
update deprecation enabled target to 3.26.0
43
false
false
6
false
true
false
emberjs
ember.js
1,565
82f6c10187c94d58154634a1b489e6cf329c4c0c
Robert Jackson
GitHub
Merge pull request #19339 from jamescdavis/deprecate_htmlSafe_from_ember_string
merge pull request from jamescdavis/deprecate_htmlsafe_from_ember_string
73
true
false
5
true
false
false
emberjs
ember.js
1,566
d9ec17a07aaa34fe4942929b0e3072f5a965785d
James C. Davis
James C. Davis
update tests for htmlSafe/isHTMLSafe Ember.String deprecation
update tests for htmlsafe/ishtmlsafe ember.string deprecation
61
false
false
6
false
true
false
emberjs
ember.js
1,567
cd603738478cd76f68bb559b787d646ebf6f091d
James C. Davis
James C. Davis
deprecate htmlSafe/isHTMLSafe reexports on Ember.String
deprecate htmlsafe/ishtmlsafe reexports on ember.string
55
false
false
5
false
false
false
emberjs
ember.js
1,568
20647ee0e42912ef3153811750bb9fe5fa80d21f
Robert Jackson
GitHub
Merge pull request #19342 from emberjs/link-to-error
merge pull request from emberjs/link-to-error
46
true
false
5
true
false
false
emberjs
ember.js
1,569
e49285a34d634c297ebac2d88ad4b1e82e0020c5
Edward Faulkner
Edward Faulkner
Fix misleading LinkTo error message This fixes #18640.
fix misleading linkto error message
35
false
false
5
false
true
false
emberjs
ember.js
1,570
26f4affe636bfacd517418252b0867ed6962ce6c
dependabot-preview[bot]
GitHub
Merge pull request #19327 from emberjs/dependabot/npm_and_yarn/semver-7.3.4
merge pull request from emberjs/dependabot/npm_and_yarn/semver-7.3.4
69
true
true
5
true
false
false
emberjs
ember.js
1,571
a4fb9fcdc56a58ac8f76c977b42f00c3029328d3
Robert Jackson
GitHub
Merge pull request #19314 from romance939913/docs-show-on-input-component
merge pull request from romance939913/docs-show-on-input-component
67
true
false
5
true
false
false
emberjs
ember.js
1,572
ce750104d0f4d2fac6dd7a9ee66a12a9411c3f5d
Robert Jackson
GitHub
Merge pull request #19338 from emberjs/add-missing-deprecate-options [BUGFIX release] Add missing `deprecate` options (`for` + `since`)
merge pull request from emberjs/add-missing-deprecate-options
62
true
false
5
true
false
false
emberjs
ember.js
1,573
f79f226b778b10372216e4693106d1375970eff4
Robert Jackson
Robert Jackson
[BUGFIX release] Add missing `deprecate` options (`for` + `since`)
[bugfix release] add missing `deprecate` options (`for` + `since`)
66
false
false
9
false
false
false
emberjs
ember.js
1,574
8f26b61353620b824bfb6ce139e02e3dd47ddb66
Chad Hietala
GitHub
Merge pull request #19336 from emberjs/throw-on-invalid-lookup-syntax [BUGFIX lts] Ensure Component Lookup Is Well Formed
merge pull request from emberjs/throw-on-invalid-lookup-syntax
63
true
false
5
true
false
false
emberjs
ember.js
1,575
c874f1599045e2ac6e6cccd1701a02e66ae4d43b
Chad Hietala
Chad Hietala
Update packages/ember-template-compiler/lib/system/compile-options.ts Co-authored-by: Godfrey Chan <[email protected]>
update packages/ember-template-compiler/lib/system/compile-options.ts
69
false
false
2
false
false
false
emberjs
ember.js
1,576
b18f67eb526108f328df624f1f8c51994ef556d3
Robert Jackson
Robert Jackson
Add v3.24.1 to CHANGELOG.md.
add v3.24.1 to changelog.md
27
false
false
4
true
true
true
emberjs
ember.js
1,577
ea5ef9418814ddd443101386e2cdb745b881b004
Robert Jackson
GitHub
Merge pull request #19337 from emberjs/ensure-query-param-only-transitions-work-in-engines
merge pull request from emberjs/ensure-query-param-only-transitions-work-in-engines
84
true
false
5
true
false
false
emberjs
ember.js
1,578
a0580d2d382b8c790e90059adcc44ce9671faa40
Robert Jackson
Robert Jackson
[BUGFIX release] Ensure query param only <LinkTo /> are properly scoped in engines. Prior to this change, the test would fail with the following: ``` Assertion Failed: You attempted to generate a link for the "UNDEFINED" route, but did not pass the models required for generating its dynamic segments. There is no route named blog.blog.category at assert (http://localhost:7020/tests/ember.js:32996:15) at Class.computeLinkToComponentHref (http://localhost:7020/tests/ember.js:5808:50) at http://localhost:7020/tests/ember.js:11860:25 at untrack (http://localhost:7020/tests/ember.js:54650:14) at ComputedProperty.get (http://localhost:7020/tests/ember.js:11859:32) at Class.getter [as href] (http://localhost:7020/tests/ember.js:10949:25) at getPossibleMandatoryProxyValue (http://localhost:7020/tests/ember.js:11250:19) at _getProp (http://localhost:7020/tests/ember.js:11315:17) at http://localhost:7020/tests/ember.js:45192:45 at http://localhost:7020/tests/ember.js:45140:37 ``` This is because inside a QP only transition we always use `_currentRoute` which has **already been namespaced**.
[bugfix release] ensure query param only <linkto /> are properly scoped in engines
82
false
false
13
false
false
false
emberjs
ember.js
1,579
c96143be34c7db8326d1619b286f913e61663281
Robert Jackson
GitHub
Merge pull request #19322 from cincodenada/patch-1
merge pull request from cincodenada/patch-1
44
true
false
5
true
false
false
emberjs
ember.js
1,580
8816a25365be148c994a58f3643933d31fe8ece7
Robert Jackson
GitHub
Merge pull request #19326 from xg-wang/link-to-router-fix
merge pull request from xg-wang/link-to-router-fix
51
true
false
5
true
false
false
emberjs
ember.js
1,581
9966d3b53ca3518b1750b7240208774a4abd7d23
Robert Jackson
GitHub
Merge pull request #19330 from emberjs/link-to-tag-name-docs [DOC lts] Remove mention on `transition-to` helper
merge pull request from emberjs/link-to-tag-name-docs
54
true
false
5
true
false
false
emberjs
ember.js
1,582
ba57d78d1b655097cba9e7437dd051269ee82419
Chad Hietala
Chad Hietala
bugfix: Ensure Component Lookup Is Well Formed This PR introduces an assertion during the component name refinement to assert that the lookup syntax is well formed. If a developer accidentally types ":" instead of "::" you will end up with a runtime erorr that looks like: ``` Uncaught Error: Assertion Failed: fullName must be a proper full name at assert (vendor.js:52729) at Container.lookup (vendor.js:16581) at Class.lookup (vendor.js:43950) at layoutFor (vendor.js:28680) at lookupComponentPair (vendor.js:28697) at lookupComponent (vendor.js:28711) at RuntimeResolver._lookupComponentDefinition (vendor.js:28992) at RuntimeResolver.lookupComponentHandle (vendor.js:28837) at CompileTimeLookup.lookupComponentDefinition (vendor.js:25065) at LazyCompiler.resolveLayoutForTag (vendor.js:60366) ``` This message is not actionable for developers. This PR will causes a compile time error to occur with the following information: ``` Malformed component lookup in "test.js". Got <Foo:Bar \/> but you must use \"::\" to indicate a lookup ```
ensure component lookup is well formed
38
false
false
6
false
false
false
emberjs
ember.js
1,583
c5a0a594d6586f0ea4a4bae1fa97af7626c3c569
Godfrey Chan
GitHub
[DOC lts] Remove mention on `transition-to` helper The `transition-to` helper does not exists. I suppose we could mention how to do this with the `{{on}}` modifier along with a custom action, but that would still be inappropiate for accessibility reasons in most cases. We should probably just deprecate this functionality, but in the mean time, we can probably just leave it at this.
[doc lts] remove mention on `transition-to` helper
50
false
false
7
false
false
false
emberjs
ember.js
1,584
9825d231d4ca51542011baccdf7b4a39af59d580
dependabot-preview[bot]
GitHub
Bump semver from 6.3.0 to 7.3.4 Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 7.3.4. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/master/CHANGELOG.md) - [Commits](https://github.com/npm/node-semver/compare/v6.3.0...v7.3.4) Signed-off-by: dependabot-preview[bot] <[email protected]>
bump semver from 6.3.0 to 7.3.4
31
true
true
6
true
true
false
emberjs
ember.js
1,585
a2dbcd444d6cf55353fbfe161fa301d7e6a1a1b9
Thomas Wang
Thomas Wang
fix async get handler test
fix async get handler test
26
false
false
5
false
true
false
emberjs
ember.js
1,586
763e756362c7cdc48d6bd91b0ef4920af225a93e
Thomas Wang
Thomas Wang
fix injection test
fix injection test
18
false
false
3
false
true
false
emberjs
ember.js
1,587
52e62350d46e852f85c2eadf15069d54a7bd70eb
Thomas Wang
Thomas Wang
fix linting
fix linting
11
false
false
2
false
true
false
emberjs
ember.js
1,588
e751cb0090aa7eae96ca92bbd43ded745fc040d6
Thomas Wang
Thomas Wang
Lazily setup the router in non-application tests for <LinkTo> component PR #19080 fixed the issue where accessing public router service throwing error, however, the PR did not support LinkTo component which uses the internal -routing service. This PR adds similar lazy setup to -routing.router.
lazily setup the router in non-application tests for <linkto> component
71
false
false
10
false
false
false
emberjs
ember.js
1,589
2bb644532d407d4b4700a81f510c5aed4caf5d84
Katie Gengler
Katie Gengler
Add v3.25.0-beta.1 to CHANGELOG (cherry picked from commit 54830f5c35364a3001d469e9bf741725342d9f3d)
add v3.25.0-beta.1 to changelog
31
false
false
4
true
true
true
emberjs
ember.js
1,590
df3c7a65d14822155c9876f50849fa123edc1219
Katie Gengler
Katie Gengler
Add v3.24.0 to CHANGELOG (cherry picked from commit 5f70d5518b3a8b9107abfaf38408c0c51e7f998d)
add v3.24.0 to changelog
24
false
false
4
true
true
true
emberjs
ember.js
1,591
5364bed35d44777a9c671906619f0cda1d5b75cd
Katie Gengler
Katie Gengler
Add v3.24.0-beta.3 to CHANGELOG (cherry picked from commit f803ecabd09786f6035c13f49695686c78495153)
add v3.24.0-beta.3 to changelog
31
false
false
4
true
true
true
emberjs
ember.js
1,592
c1087f50d69593cfc84b737ec4e4f03586fa5bbe
Joel Bradshaw
GitHub
Fix whitespace
fix whitespace
14
false
false
2
true
true
false
emberjs
ember.js
1,593
9f3f74f230cde0526080cb7726ec347a91bf4903
Joel Bradshaw
GitHub
Scratch that, I don't think that works at all
scratch that, i don't think that works at all
45
false
false
9
false
true
false
emberjs
ember.js
1,594
6bd1e1025afc3ab944961e868485f557649e5a31
Joel Bradshaw
GitHub
Add option to specify a boolean default value
add option to specify a boolean default value
45
false
false
8
true
true
true
emberjs
ember.js
1,595
57bd58f46c42afdedfd3cce7f1675b080d7fac55
Joel Bradshaw
GitHub
More copyediting
more copyediting
16
false
false
2
false
false
false
emberjs
ember.js
1,596
f4bd2ef61b00f36e486892a58fa8d219a8eac1fd
Joel Bradshaw
GitHub
Remove unnecessary words
remove unnecessary words
24
false
false
3
true
true
true
emberjs
ember.js
1,597
f7888670d31ad69df2f7fb50947e4c76896c4e89
Joel Bradshaw
GitHub
Fix description of issue around toggleProperty The original description was unclear, but implied a totally different problem was at hand.
fix description of issue around toggleproperty
46
false
false
6
true
true
true
emberjs
ember.js
1,598
635799d425f1abfa0d4bdf6704b8a08bb1a741c5
Robert Jackson
GitHub
Merge pull request #19320 from emberjs/update-vm Ensure `{{component.name}}` works with implicit this fallback
merge pull request from emberjs/update-vm
42
true
false
5
true
true
false
emberjs
ember.js
1,599