sha
stringlengths 1
40
| author
stringlengths 1
63
⌀ | committer
stringlengths 1
41
⌀ | message
stringlengths 1
65.5k
⌀ | subject
stringlengths 1
5.64k
⌀ | subject_length
float64 1
5.64k
⌀ | is_chore
bool 2
classes | is_bot
bool 2
classes | subject_word_count
float64 1
806
⌀ | verb_object_spacy
bool 2
classes | verb_object_stanza
bool 2
classes | fits_requirements
bool 2
classes | owner
stringlengths 2
15
| repo
stringlengths 2
21
| __index_level_0__
int64 0
85.4k
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
eff0aefa398e578abffe91b074f70bbc55535a6d | Thomas Wang | Thomas Wang | Improve internal router type | improve internal router type | 28 | false | false | 4 | false | true | false | emberjs | ember.js | 1,700 |
cb5b67edf8827afa2efd0b9f21e601efccfa1ecb | Robert Jackson | GitHub | Merge pull request #19253 from jamescdavis/align_getComponentTemplate_return_with_rfc
[RFC #481] change return of getComponentTemplate from null to undefined to align with RFC | merge pull request from jamescdavis/align_getcomponenttemplate_return_with_rfc | 79 | true | false | 5 | true | false | false | emberjs | ember.js | 1,701 |
e98322a67751fadafb2afaaef396b2cfd5f94f48 | Robert Jackson | GitHub | Merge pull request #19250 from emberjs/bugfix/prevent-infinite-rerenders-on-error
[BUGFIX lts] Prevents infinite rerenders when errors occur during render | merge pull request from emberjs/bugfix/prevent-infinite-rerenders-on-error | 75 | true | false | 5 | true | false | false | emberjs | ember.js | 1,702 |
7a68241e53fc1d1b09789186ba2ae9522e037ffc | Katie Gengler | GitHub | Merge pull request #19247 from pgengler/fix-changelog-script
Improvements to changelog generation script | merge pull request from pgengler/fix-changelog-script | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 1,703 |
70fffeaa6320cc84455a1367fd1c84f89d30151b | Katie Gengler | Katie Gengler | Add v3.23.0-beta.5 to CHANGELOG
(cherry picked from commit f757e5722048843b6f37a48514aec9eddbf27f79) | add v3.23.0-beta.5 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,704 |
58daefff26862e567f8a40d6e87df5a5dd828475 | Robert Jackson | GitHub | Merge pull request #19236 from rreckonerr/fix/active-transition-qp-serialization | merge pull request from rreckonerr/fix/active-transition-qp-serialization | 74 | true | false | 5 | true | false | false | emberjs | ember.js | 1,705 |
2f8cde9f4ed8b131b0c2e282df79ae3bc0721b0c | Chris Garrett | Chris Garrett | [BUGFIX] Prevents infinite rerenders when errors occur during render
This adds a preventative measure against infinite rerenders that happen
due to an unrecoverable error during rendering. This type of error is
really annoying from a DX perspective and can really throw developers
for a loop. The most common cases appear to be caused by the Ember
Inspector, which polls after a render has occured whether on not it was
succesful, and in doing so also dirties state, causing a rerender.
An example of this is seen in this [example reproduction](https://github.com/xg-wang/getter-error)
with the following steps:
1. Load the app
2. Click the To View link to enter the page with the error
3. Open up the Ember Inspector to activate it
4. Reload the page | [bugfix] prevents infinite rerenders when errors occur during render | 68 | false | false | 9 | false | false | false | emberjs | ember.js | 1,706 |
1e09e2662e2fda8c969292061a9bdbbf22bf46e1 | James C. Davis | James C. Davis | change return of getComponentTemplate from null to undefined | change return of getcomponenttemplate from null to undefined | 60 | false | false | 8 | true | true | false | emberjs | ember.js | 1,707 |
14b7c33757540611e0e2332d94805c927d83b883 | Robert Jackson | GitHub | Merge pull request #19249 from rreckonerr/tests/query-params-bug-with-loading-substances | merge pull request from rreckonerr/tests/query-params-bug-with-loading-substances | 82 | true | false | 5 | true | false | false | emberjs | ember.js | 1,708 |
4f4e69a285cb7a47a33b6fbf12ae5eac6a5b50e3 | Volodymyr Radchenko | Volodymyr Radchenko | CHORE: upgrade router_js | upgrade router_js | 17 | false | false | 2 | true | true | false | emberjs | ember.js | 1,709 |
e66ae7df2a8bbc45847f7e150af28862b9c7b1ef | Volodymyr Radchenko | Volodymyr Radchenko | [REPRODUCTION] Updating single qp resets others
Refs: Based off reproduction in #14438 | [reproduction] updating single qp resets others | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 1,710 |
c8cc5450b7b101313cdb1d02ab129155fa7326bf | Volodymyr Radchenko | Volodymyr Radchenko | [REPRODUCTION] dynamic qp's bug in link-to
Refs: Based off reproduction in https://github.com/emberjs/ember.js/pull/16986 | [reproduction] dynamic qp's bug in link-to | 42 | false | false | 6 | false | false | false | emberjs | ember.js | 1,711 |
66c56e44b85f315bd0a5ed11787d563a11ebe835 | Robert Jackson | GitHub | Merge pull request #19248 from jamescdavis/document_RouteInfo.metadata
[DOC] add metadata property for RouteInfo | merge pull request from jamescdavis/document_routeinfo.metadata | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 1,712 |
61faaffe7d5a22c6079a8f272d3217346a07ae8c | James C. Davis | James C. Davis | doc: RouteInfo.metadata | routeinfo.metadata | 18 | false | false | 1 | false | false | false | emberjs | ember.js | 1,713 |
51059e9db8c19c343e95b9174ab835eb0ed57f9d | Phil Gengler | Phil Gengler | Refactor changelog script and grab PR titles when they're needed
Makes a few improvements to the changelog generation script:
* handles cases where PR-merge commits don't include PR title
(this led to 'undefined' in the output instead of a title)
* fixes sorting so PRs are ordered correctly, and non-PR-associated
commits appear after PRs (and are also sorted)
* ensures that a PR will only appear once in the output | refactor changelog script and grab pr titles when they're needed | 64 | false | false | 10 | false | false | false | emberjs | ember.js | 1,714 |
ec49e0eee542791ca6916a71096988acab9c2ec0 | Katie Gengler | Katie Gengler | Add v3.23.0-beta.4 to CHANGELOG
(cherry picked from commit 09ecf1cd3be31b0320e400d7172de0f13352d027) | add v3.23.0-beta.4 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,715 |
fd51a3bb2099f3f325b1290008df61b6f485b468 | dependabot-preview[bot] | GitHub | Merge pull request #19242 from emberjs/dependabot/npm_and_yarn/fs-extra-9.0.1 | merge pull request from emberjs/dependabot/npm_and_yarn/fs-extra-9.0.1 | 71 | true | true | 5 | true | false | false | emberjs | ember.js | 1,716 |
6bd6d15a684412d10360b024901c8dff8ddbc99f | dependabot-preview[bot] | GitHub | Bump fs-extra from 9.0.0 to 9.0.1
Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 9.0.0 to 9.0.1.
- [Release notes](https://github.com/jprichardson/node-fs-extra/releases)
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jprichardson/node-fs-extra/compare/9.0.0...9.0.1)
Signed-off-by: dependabot-preview[bot] <[email protected]> | bump fs-extra from 9.0.0 to 9.0.1 | 33 | true | true | 6 | true | true | false | emberjs | ember.js | 1,717 |
20da5b22c9afc287dd4fef206ce7a9b3de0933d6 | Volodymyr Radchenko | Volodymyr Radchenko | [BUGFIX beta] Prevent multiple QP serialization
We're using serialized query parameters for active transition instead of deserialized ones. This results in multiple serialization of QP's. | [bugfix beta] prevent multiple qp serialization | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 1,718 |
ed203b2995b11738b6a3a86bb9ce6484f374fbf2 | Volodymyr Radchenko | Volodymyr Radchenko | [REPRODUCTION] Multiple QP serialization...
...on activeTransition in `_doTransition`.
`_processActiveTransitionQueryParams` returns serialized values and we serialize them again in `_prepareQueryParams`, which expects deserialized values.
Refs: #14174 | [reproduction] multiple qp serialization.. | 42 | false | false | 4 | false | false | false | emberjs | ember.js | 1,719 |
8f56dc80620a47aecb602e9f1ca18a1c85d83b9a | Chris Garrett | GitHub | Merge pull request #19238 from emberjs/cleanup/remove-local-lookup
[CLEANUP] Removes the `expandLocalLookup` API | merge pull request from emberjs/cleanup/remove-local-lookup | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 1,720 |
3727d0cb7056081ba82e8cd344a51da8e8757021 | Robert Jackson | Robert Jackson | Merge pull request #19237 from branch 'sclaxton/patch-2' | merge pull request from branch 'sclaxton/patch-2' | 50 | true | false | 6 | true | false | false | emberjs | ember.js | 1,721 |
7d160a83e38672e7290deeaf860efc4fa17dca21 | Spencer Claxton | Robert Jackson | [DOC release] Document UUID for HistoryLocation.
UUIDs on history location states is a longstanding feature that has been maintained for years and is backed up by the RFC process in [RFC0816](https://github.com/emberjs/rfcs/blob/master/text/0186-track-unique-history-location-state.md). I propose we document this feature in the official docs alongside the API docs for the `HistoryLocation` class (where this feature is implemented). | [doc release] document uuid for historylocation | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 1,722 |
8482098b10d1068ffe90fadd7343cf24d00f88d2 | Robert Jackson | GitHub | Merge pull request #19223 from emberjs/engine-link-to
[BUGFIX] `<LinkTo>` should link within the engine when used inside one | merge pull request from emberjs/engine-link-to | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 1,723 |
473d15ae6e6f94ff2b2ba40b2fb89389b26664fd | Chris Garrett | Chris Garrett | [CLEANUP] Removes the `expandLocalLookup` API
`expandLocalLookup` was a experimental API that was tied
closely to Module Unification. The API was shipped, but was never fully
released. It was primarily used for experimentation in general.
Currently, 3 addons use it, all of which are experimental addons that
try to establish MU like file structures.
This PR removes the API to simplify resolution as a whole, so we can
continue the work toward strict mode. | [cleanup] removes the `expandlocallookup` api | 45 | false | false | 5 | false | false | false | emberjs | ember.js | 1,724 |
56af48bb413f89766e0b355ca94c029e62695667 | Godfrey Chan | Godfrey Chan | [BUGFIX] `<LinkTo>` should link within the engine when used inside one | [bugfix] `<linkto>` should link within the engine when used inside one | 70 | false | false | 11 | false | false | false | emberjs | ember.js | 1,725 |
1af2d49188183ca87be79901acd2b51dcd5cc2ef | Ricardo Mendes | Ricardo Mendes | annotated String.prototype extensions as deprecated | annotated string.prototype extensions as deprecated | 51 | false | false | 5 | false | false | false | emberjs | ember.js | 1,726 |
68402014daabd7da0261ea149cae17bb50d10c63 | Robert Jackson | GitHub | Merge pull request #19233 from emberjs/fix-multiple-deprecations
Ensure multiple deprecations (warnings, etc) are tracked correctly | merge pull request from emberjs/fix-multiple-deprecations | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 1,727 |
8635659a0e8e75a93562e73053720becbb881a55 | Chris Garrett | GitHub | Merge pull request #19232 from emberjs/bugfix/restore-previous-set-behavior
[BUGFIX beta] Restores the shadowed property set behavior | merge pull request from emberjs/bugfix/restore-previous-set-behavior | 69 | true | false | 5 | true | true | false | emberjs | ember.js | 1,728 |
b6c8a37635cc0264f58e5681fecdbdbd3eda3e7d | Robert Jackson | GitHub | Merge pull request #19142 from rreckonerr/bugfix/app-booted-before-dom-ready-without-jquery | merge pull request from rreckonerr/bugfix/app-booted-before-dom-ready-without-jquery | 85 | true | false | 5 | true | false | false | emberjs | ember.js | 1,729 |
6e1c963c805ceb41470f56933c509322ebc7e5d4 | Ricardo Mendes | Ricardo Mendes | expect prototype extension deprecation in tests | expect prototype extension deprecation in tests | 47 | false | false | 6 | false | true | false | emberjs | ember.js | 1,730 |
591be249b6fd8500051d722732e3e14dde90e29b | Ricardo Mendes | Ricardo Mendes | point deprecation to ember-source | point deprecation to ember-source | 33 | false | false | 4 | false | false | false | emberjs | ember.js | 1,731 |
ec07cdc356b0082870b3bbe654fd137984130bcf | Ricardo Mendes | Ricardo Mendes | deprecate String prototype extensions | deprecate string prototype extensions | 37 | false | false | 4 | false | true | false | emberjs | ember.js | 1,732 |
1f92f8d6d238df1820771f37227a3cc9d6dd2acd | Godfrey Chan | Godfrey Chan | Ensure multiple deprecations (warnings, etc) are tracked correctly
This fixes the tracker to fail the tests when multiple deprecations
are raised within the callback and not all of them are matched by
the given expectations (either by passin a regex that matches all
the messages, or by calling `expectDeprecation` multiple times).
This found some possible bugs that were masked by the fact that the
current tracker code does not really care about unmatched messages
as long as all the expectations matched *something*. | ensure multiple deprecations (warnings, etc) are tracked correctly | 66 | false | false | 8 | false | false | false | emberjs | ember.js | 1,733 |
05e278a573a07f40177f75a5ab3daa41ea738d44 | Katie Gengler | Katie Gengler | Add v3.23.0-beta.3 to CHANGELOG
(cherry picked from commit a8aff10265bcfdbc1dafbe4d01669d8e5107328e) | add v3.23.0-beta.3 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,734 |
5e7e54347488a7c2f25c3bc39256affb0ba52048 | Chris Garrett | Chris Garrett | [BUGFIX lts] Restores the shadowed property set behavior
Restores the previous behavior that would happen when setting a shadowed
property. | [bugfix lts] restores the shadowed property set behavior | 56 | false | false | 8 | false | false | false | emberjs | ember.js | 1,735 |
dce6d62fd82133e72969e384f0800a95c4854c9a | Chris Garrett | GitHub | Merge pull request #19229 from sanji11/issue-18060
[CLEANUP] Remove the EMBER_GLIMMER_SET_COMPONENT_TEMPLATE flag | merge pull request from sanji11/issue-18060 | 44 | true | false | 5 | true | true | false | emberjs | ember.js | 1,736 |
1b08b25d0ecb23f35781343d5ab0223955f02166 | Robert Jackson | GitHub | Merge pull request #19230 from Nelias/fix-typescript-linting-warnings | merge pull request from nelias/fix-typescript-linting-warnings | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 1,737 |
93ee2242fb3c04f507efe7b17003707fdc5734e1 | Sanjida Afrin | Sanjida Afrin | Fixed more linter related issues | fixed more linter related issues | 32 | false | false | 5 | false | false | false | emberjs | ember.js | 1,738 |
9ff6ce7d4f4259b9b949d487a2c87597c6088592 | Michał Antropik | Michał Antropik | properly format on.ts file | properly format on.ts file | 26 | false | false | 4 | false | false | false | emberjs | ember.js | 1,739 |
a492ffedd7db6b641fd7e8e10fb9483d619995f7 | Michał Antropik | Michał Antropik | fix linter warnings in 14 files | fix linter warnings in 14 files | 31 | false | false | 6 | true | true | true | emberjs | ember.js | 1,740 |
3f9e7079913586f06e57bde2cfa9a735e149d9fa | Sanjida Afrin | Sanjida Afrin | Fixed lint reported issue | fixed lint reported issue | 25 | false | false | 4 | false | false | false | emberjs | ember.js | 1,741 |
29b096bdceb31a6afabb9955e4f67a10b4e7e621 | Michał Antropik | Michał Antropik | fix linitng warnings in run.ts file | fix linitng warnings in run.ts file | 35 | false | false | 6 | true | true | true | emberjs | ember.js | 1,742 |
245631c972cad2162ba2329a70cd7f77331b385a | Sanjida Afrin | Sanjida Afrin | [CLEANUP] Remove the EMBER_GLIMMER_SET_COMPONENT_TEMPLATE flag | [cleanup] remove the ember_glimmer_set_component_template flag | 62 | false | false | 5 | false | false | false | emberjs | ember.js | 1,743 |
7b951559f51f12bef52649368a56bb8ac060e99c | Robert Jackson | GitHub | Merge pull request #19224 from raido/add-ember-page-title
Add {{page-title}} to route templates | merge pull request from raido/add-ember-page-title | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 1,744 |
59e3440ee0405f2bc73ee51f0bbc4afc32d915df | Robert Jackson | GitHub | Merge pull request #19226 from bekzod/remove-tags | merge pull request from bekzod/remove-tags | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 1,745 |
1377c9d0a898c47fbd52d7bc7e23338b2e493d40 | bekzod | bekzod | remove obsolete _tags in meta | remove obsolete _tags in meta | 29 | false | false | 5 | false | true | false | emberjs | ember.js | 1,746 |
ed56eeb2b1b32694cc95bd49af144d0623b1239b | Raido Kuli | Raido Kuli | Add {{page-title}} to route templates | add {{page-title}} to route templates | 37 | false | false | 5 | false | true | false | emberjs | ember.js | 1,747 |
5ec738cb36998f9f975afc4611efb1d234a988cb | Robert Jackson | GitHub | Merge pull request #19225 from emberjs/revert-19200-bugfix/prevent-infinite-rerenders-on-error | merge pull request from emberjs/revert-19200-bugfix/prevent-infinite-rerenders-on-error | 88 | true | false | 5 | true | false | false | emberjs | ember.js | 1,748 |
b21f22f1e5f2923c949dc2be5a4c204c3d77ed0d | Robert Jackson | GitHub | Revert "[BUGFIX lts] Prevents infinite rerenders when errors occur during render" | revert "[bugfix lts] prevents infinite rerenders when errors occur during render" | 81 | false | false | 11 | false | false | false | emberjs | ember.js | 1,749 |
7c226cc6bbd13443130711743e98bb5d2b176e50 | Robert Jackson | GitHub | Merge pull request #19200 from emberjs/bugfix/prevent-infinite-rerenders-on-error | merge pull request from emberjs/bugfix/prevent-infinite-rerenders-on-error | 75 | true | false | 5 | true | false | false | emberjs | ember.js | 1,750 |
4c494c1716d1f043647fc21c9a01cf0cea89330f | Robert Jackson | GitHub | Merge pull request #19199 from emberjs/bugfix/clean-up-debug-render-tree-more-thoroughly
[BUGFIX lts] Cleans up the DebugRenderTree more thoroughly on errors | merge pull request from emberjs/bugfix/clean-up-debug-render-tree-more-thoroughly | 82 | true | false | 5 | true | false | false | emberjs | ember.js | 1,751 |
05ca4488940b6f7662b9073decefefc24da6432c | Robert Jackson | GitHub | Merge pull request #19214 from Nelias/util-test
[FEATURE test-framework-detector] Add constants with versions | merge pull request from nelias/util-test | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 1,752 |
4102477987bf60773dd4f5a2f8de91b33282a48d | Robert Jackson | GitHub | Merge pull request #19221 from emberjs/bugfix/ensure-mut-works-with-falsy-values
[BUGFIX release] Ensure fn and (mut) work with falsy values | merge pull request from emberjs/bugfix/ensure-mut-works-with-falsy-values | 74 | true | false | 5 | true | false | false | emberjs | ember.js | 1,753 |
09589f40e26ee64baf51d52b5ca96c91dc1151af | Chris Garrett | Chris Garrett | [BUGFIX release] Ensure fn and (mut) work with falsy values | [bugfix release] ensure fn and (mut) work with falsy values | 59 | false | false | 10 | false | false | false | emberjs | ember.js | 1,754 |
3a866f974b6605db8a9a2b32355a7388de6ed536 | Katie Gengler | Katie Gengler | Add v3.23.0-beta.2 to CHANGELOG
(cherry picked from commit 4bfc97e683e623174263471e71e9ddf9b8a739b8) | add v3.23.0-beta.2 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,755 |
6c4407f47791e0c738385a6d6d92689bac338b71 | Chris Garrett | GitHub | Merge pull request #19206 from andreisebastianc/clean-ember-routing-model-arg-feature-flag-18060
[CLEANUP] Remove EMBER_ROUTING_MODEL_ARG feature flag | merge pull request from andreisebastianc/clean-ember-routing-model-arg-feature-flag-18060 | 90 | true | false | 5 | true | false | false | emberjs | ember.js | 1,756 |
fb1f3e665cd9690784b8112434cc44e1ffd71b71 | Michał Antropik | Michał Antropik | add constants to test-framework-detector | add constants to test-framework-detector | 40 | false | false | 4 | true | true | true | emberjs | ember.js | 1,757 |
53d5d0bbd85f686725998efdb9170316171475ad | Robert Jackson | GitHub | Merge pull request #19213 from emberjs/update-glimmer
[BUGFIX beta] Update rendering engine to improve error ergonomics. | merge pull request from emberjs/update-glimmer | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 1,758 |
e8cfd08a835a3e4cf9503113cc64ed67c2bfd61b | Robert Jackson | Robert Jackson | [BUGFIX beta] Update rendering engine to improve error ergonomics.
Fixes two major issues:
* Ensure "pause on uncaught" exceptions pauses in correct location
(https://github.com/glimmerjs/glimmer-vm/pull/1172)
* Log template heirarchy to the console for any errors thrown during
rendering (https://github.com/glimmerjs/glimmer-vm/pull/1169) | [bugfix beta] update rendering engine to improve error ergonomics | 65 | false | false | 9 | false | false | false | emberjs | ember.js | 1,759 |
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c | Andrei Sebastian Cîmpean | Andrei Sebastian Cîmpean | Fix linting issues | fix linting issues | 18 | false | false | 3 | true | true | true | emberjs | ember.js | 1,760 |
619f902437ff9cd8f36ab999fef0576c4f0705ba | Andrei Sebastian Cîmpean | Andrei Sebastian Cîmpean | [CLEANUP] Remove EMBER_ROUTING_MODEL_ARG feature flag | [cleanup] remove ember_routing_model_arg feature flag | 53 | false | false | 5 | false | false | false | emberjs | ember.js | 1,761 |
ab785b81b9b3de771e05c4034e49d0e54795b189 | Robert Jackson | GitHub | Merge pull request #19080 from xg-wang/non-application-router-test | merge pull request from xg-wang/non-application-router-test | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 1,762 |
a4f4b911d1f7351830647c243e081bc9b11bc359 | Robert Jackson | GitHub | Merge pull request #19209 from kategengler/kg-remove-deprecated-gh-action-api
Remove use of deprecated set-env github action API | merge pull request from kategengler/kg-remove-deprecated-gh-action-api | 71 | true | false | 5 | true | false | false | emberjs | ember.js | 1,763 |
c4e1cd1e572ae4efb1296ef664c6462b71ab2089 | Katie Gengler | Katie Gengler | Remove use of deprecated set-env github action API
See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ | remove use of deprecated set-env github action api | 50 | false | false | 8 | true | true | true | emberjs | ember.js | 1,764 |
e8d15e8ab77c5fa5407277cc100c6cfebb4f08e5 | Robert Jackson | GitHub | Merge pull request #19198 from emberjs/bugfix/assert-when-setting-shadowed-property | merge pull request from emberjs/bugfix/assert-when-setting-shadowed-property | 77 | true | false | 5 | true | false | false | emberjs | ember.js | 1,765 |
75119b5c8a5d9f0fddff24c99e769cce1a09bbee | Michał Staśkiewicz | Robert Jackson | [CLEANUP] Remove EMBER_DESTROYABLES feature flag from documentation | [cleanup] remove ember_destroyables feature flag from documentation | 67 | false | false | 7 | false | false | false | emberjs | ember.js | 1,766 |
6f3283237a47678988a32c0445cbde847a9605b6 | Michał Staśkiewicz | Robert Jackson | [CLEANUP] Remove EMBER_DESTROYABLES feature flag | [cleanup] remove ember_destroyables feature flag | 48 | false | false | 5 | false | false | false | emberjs | ember.js | 1,767 |
b4465f3e27a397ac7d30b40799e1e797bfdb6f7a | Robert Jackson | GitHub | Merge pull request #19204 from andreisebastianc/clean-ember-cache-api-feature-flag-18060 | merge pull request from andreisebastianc/clean-ember-cache-api-feature-flag-18060 | 82 | true | false | 5 | true | false | false | emberjs | ember.js | 1,768 |
019ae7b69bfa83edceab2b2a7045b815068966f3 | Andrei Sebastian Cîmpean | Andrei Sebastian Cîmpean | [CLEANUP] Remove EMBER_CACHE_API feature flag from documentation | [cleanup] remove ember_cache_api feature flag from documentation | 64 | false | false | 7 | false | false | false | emberjs | ember.js | 1,769 |
28684dc36b3015ce943435b7e1403c80c69f729c | Andrei Sebastian Cîmpean | Andrei Sebastian Cîmpean | [CLEANUP] Remove EMBER_CACHE_API feature flag | [cleanup] remove ember_cache_api feature flag | 45 | false | false | 5 | false | false | false | emberjs | ember.js | 1,770 |
41b68b7ccb0720e08ab7011be8809bb929b7664c | Chris Garrett | Chris Garrett | [BUGFIX] Asserts when users attempt to set a shadowed value with Ember.set | [bugfix] asserts when users attempt to set a shadowed value with ember.set | 74 | false | false | 12 | false | false | false | emberjs | ember.js | 1,771 |
fdb0be062aabc61a67d9f9cd4af457e3bddb0f83 | Chris Garrett | Chris Garrett | [BUGFIX] Prevents infinite rerenders when errors occur during render
This adds a preventative measure against infinite rerenders that happen
due to an unrecoverable error during rendering. This type of error is
really annoying from a DX perspective and can really throw developers
for a loop. The most common cases appear to be caused by the Ember
Inspector, which polls after a render has occured whether on not it was
succesful, and in doing so also dirties state, causing a rerender.
An example of this is seen in this [example reproduction](https://github.com/xg-wang/getter-error)
with the following steps:
1. Load the app
2. Click the To View link to enter the page with the error
3. Open up the Ember Inspector to activate it
4. Reload the page | [bugfix] prevents infinite rerenders when errors occur during render | 68 | false | false | 9 | false | false | false | emberjs | ember.js | 1,772 |
e1b803e74103065ee73df997e02297df7cef699e | Chris Garrett | Chris Garrett | [BUGFIX lts] Cleans up the DebugRenderTree more thoroughly on errors
The DebugRenderTree is currently left in a bad state after an error
occurs during render. Specifically, if an error occurs and we call
`capture` on the tree, it will throw errors because the state hasn't
been setup correctly. In real world development, this can happen
whenever the Ember Inspector is open and an app has errored, as the
inspector polls regardless of the state of the app and doesn't take
error state into account. This results in a follow on error to the
original error, which is confusing and can make it more difficult to
debug.
This fixes the issue by removing the affected root altogether, so that
it will not attempt to capture in the first place. | [bugfix lts] cleans up the debugrendertree more thoroughly on errors | 68 | false | false | 10 | false | false | false | emberjs | ember.js | 1,773 |
da458dfc26a85f9550d6061a226e0d170c757382 | Robert Jackson | GitHub | Merge pull request #19196 from NoneOfMaster/clean-glimmer-in-element-feature-flag-18060 | merge pull request from noneofmaster/clean-glimmer-in-element-feature-flag-18060 | 81 | true | false | 5 | true | false | false | emberjs | ember.js | 1,774 |
ae672e5f5cb346ca86def82e957a193a98c521eb | Chris Garrett | GitHub | Merge pull request #19193 from emberjs/bugfix/ensure-user-lifecycle-hooks-are-untracked
[BUGFIX release] Ensure user lifecycle hooks are untracked | merge pull request from emberjs/bugfix/ensure-user-lifecycle-hooks-are-untracked | 81 | true | false | 5 | true | true | false | emberjs | ember.js | 1,775 |
b8502c03a57fee90fe7e0159c959657dc183e059 | Robert Jackson | GitHub | Merge pull request #19195 from emberjs/bugfix/check-fn-refs-eagerly
[BUGFIX] Asserts that fn is passed a function eagerly | merge pull request from emberjs/bugfix/check-fn-refs-eagerly | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 1,776 |
952a4fbf5394c02df7bbcbb24d1ff5dde8fcf531 | Russell Tepper | Russell Tepper | [CLEANUP beta] Remove in-element feature flag | [cleanup beta] remove in-element feature flag | 45 | false | false | 6 | false | false | false | emberjs | ember.js | 1,777 |
8fc0f9b2b3220e44940e79493f7e101a958c6aa0 | Chris Garrett | Chris Garrett | [BUGFIX] Asserts that fn is passed a function eagerly | [bugfix] asserts that fn is passed a function eagerly | 53 | false | false | 9 | false | false | false | emberjs | ember.js | 1,778 |
35ca78132f93481a4127b5f5cad48b7107bd86a8 | Chris Garrett | Chris Garrett | [BUGFIX release] Ensure user lifecycle hooks are untracked
When we refactored the VM to use autotracking internally, some lifecycle
hooks were tracked that previously weren't on classic components. This
PR ensures those hooks are no longer tracked, maintaining their previous
behavior. | [bugfix release] ensure user lifecycle hooks are untracked | 58 | false | false | 8 | false | false | false | emberjs | ember.js | 1,779 |
04c112105ce715ade6fcfd1669d9d0c76154c559 | Robert Jackson | GitHub | Merge pull request #19194 from NoneOfMaster/update-docs-19181
[DOC beta] Add return types to Controller docs | merge pull request from noneofmaster/update-docs-19181 | 55 | true | false | 5 | true | true | false | emberjs | ember.js | 1,780 |
40ae052f97cc111419333281eac848c1a6491571 | Russell Tepper | Russell Tepper | [DOC beta] Add return types to Controller docs | [doc beta] add return types to controller docs | 46 | false | false | 8 | false | false | false | emberjs | ember.js | 1,781 |
57543c9834047c8834921765b34c3a41c4b5f145 | Robert Jackson | GitHub | Merge pull request #19184 from emberjs/refactor-input-component | merge pull request from emberjs/refactor-input-component | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 1,782 |
a3ae1d125c6515e944d4bdfbe29791c3167450c5 | Robert Jackson | GitHub | Merge pull request #19126 from mydea/mydea-patch-1
Update documentation for `runInDebug` | merge pull request from mydea/mydea-patch-1 | 44 | true | false | 5 | true | false | false | emberjs | ember.js | 1,783 |
cba48c512ce5426d6f6527a93e5366c3de5b9796 | Thomas Wang | Thomas Wang | Trim RouterNonApplicationTestCase to minimum | trim routernonapplicationtestcase to minimum | 44 | false | false | 4 | false | true | false | emberjs | ember.js | 1,784 |
517927b594e0534dc04fa07f6d7f487c30dc5ec7 | Thomas Wang | Thomas Wang | Copy RenderingTestCase to a separate RouterNonApplicationTestCase | copy renderingtestcase to a separate routernonapplicationtestcase | 65 | false | false | 6 | false | true | false | emberjs | ember.js | 1,785 |
b713a3b6c3fafaddcf5972abbef39bd4a6ed8b63 | Thomas Wang | Thomas Wang | cast correct type | cast correct type | 17 | false | false | 3 | false | true | false | emberjs | ember.js | 1,786 |
009b51abde39bd1cb76d8ebd8ad0d2fe524d27b7 | Thomas Wang | Thomas Wang | use constructor instead of init | use constructor instead of init | 31 | false | false | 5 | true | true | true | emberjs | ember.js | 1,787 |
c9116a8edd6702846ddef9ea392850c217439a18 | Thomas Wang | Thomas Wang | avoid RouterService's own router access triggers setup | avoid routerservice's own router access triggers setup | 54 | false | false | 7 | false | false | false | emberjs | ember.js | 1,788 |
99d998c6c48ab8e5b55e9c6772d90992b31331bb | Thomas Wang | Thomas Wang | Lazy router setup in non-application tests
During non setupApplicationTests type tests, the Router being injected
into service:router and service:routing does not setup automatically,
during which it initializes its _routerMicrolib, etc. Public API on
service:router will throw in those tests. This commit will trigger
setupRouter when accessing EmberRouter via router service to avoid those
errors. | lazy router setup in non-application tests | 42 | false | false | 6 | false | false | false | emberjs | ember.js | 1,789 |
88c59a4be85d0b83cc1ac807ea14a95a8f315a54 | Volodymyr Radchenko | Volodymyr Radchenko | [BUGFIX beta] reimplement $.ready() | [bugfix beta] reimplement $.ready() | 35 | false | false | 4 | false | false | false | emberjs | ember.js | 1,790 |
56a1da5b3b56ed84f6de2193a4fb0c01c0c7d4f2 | Volodymyr Radchenko | Volodymyr Radchenko | CHORE: combine two test cases into one
Since `jQuery.isReady = false;` is set before each test case. | combine two test cases into one | 31 | false | false | 6 | true | true | true | emberjs | ember.js | 1,791 |
72728e413b7e69f98ea47ced6ff1533c4ef87bde | Robert Jackson | GitHub | Merge pull request #19191 from rohitpaulk/fix-router-docs
replace this.get('router') with this.router in RoutingService docs | merge pull request from rohitpaulk/fix-router-docs | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 1,792 |
9916fc6856386a49e16568fe9f052e03d94bf904 | Paul Kuruvilla | Paul Kuruvilla | [DOC] replace this.get('router') with this.router in RoutingService docs | [doc] replace this.get('router') with this.router in routingservice docs | 72 | false | false | 8 | false | false | false | emberjs | ember.js | 1,793 |
ba1f82440d3273388ef23dbb1649c0157acfa1b9 | Robert Jackson | GitHub | Merge pull request #19185 from emberjs/key-instead-of-key-code
Stop using deprecated `keyCode` on `KeyboardEvent` | merge pull request from emberjs/key-instead-of-key-code | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 1,794 |
c5bbf863af7cd8f6f92a97f2b777ff857bf9a9f4 | Robert Jackson | GitHub | Merge pull request #19133 from mehulkar/mk/deprecate
New options for deprecate() function | merge pull request from mehulkar/mk/deprecate | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 1,795 |
1f420ce8857276a1ba4bce976fc5a1321bec3490 | Mehul Kar | Mehul Kar | Add `for` and `since` options to depreacte() function
This implements the first stage of the Deprecation Staging RFC
https://github.com/emberjs/rfcs/pull/649
This commit also:
- deprecates the usage of deprecate() function without passing
these options
- Updates all the usages of deprecate() in the repo to pass
these options. | add `for` and `since` options to depreacte() function | 53 | false | false | 8 | false | true | false | emberjs | ember.js | 1,796 |
81c80483391dfefa138018dff841d809cab449ff | Godfrey Chan | Godfrey Chan | Stop using deprecated `keyCode` on `KeyboardEvent`
Use `key` instead, which works in all supported browsers. | stop using deprecated `keycode` on `keyboardevent` | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 1,797 |
8c3c1d7a1012ea7a04e1f05302e3c9abe7c7f044 | Godfrey Chan | Godfrey Chan | [FEATURE modernized-built-in-components] Start adding deprecations
This implements some of the deprecations proposed in [RFC #671][1].
The deprecations are gated behind the feature flag so they won't be
visible until the RFC is merged and the feature is enabled.
[1]: https://github.com/emberjs/rfcs/pull/671 | [feature modernized-built-in-components] start adding deprecations | 66 | false | false | 5 | false | false | false | emberjs | ember.js | 1,798 |
4b58d27918cfa3d02794674b077699aed56239be | Godfrey Chan | Godfrey Chan | [FEATURE modernized-built-in-components] Add feature flag | [feature modernized-built-in-components] add feature flag | 57 | false | false | 5 | false | false | false | emberjs | ember.js | 1,799 |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.