sha
stringlengths 1
40
| author
stringlengths 1
63
⌀ | committer
stringlengths 1
41
⌀ | message
stringlengths 1
65.5k
⌀ | subject
stringlengths 1
5.64k
⌀ | subject_length
float64 1
5.64k
⌀ | is_chore
bool 2
classes | is_bot
bool 2
classes | subject_word_count
float64 1
806
⌀ | verb_object_spacy
bool 2
classes | verb_object_stanza
bool 2
classes | fits_requirements
bool 2
classes | owner
stringlengths 2
15
| repo
stringlengths 2
21
| __index_level_0__
int64 0
85.4k
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
7f8146bf6c152f291a4070fbbdfd1342b9ff7607 | Katie Gengler | Katie Gengler | Post-release version bump | post-release version bump | 25 | false | false | 3 | false | false | false | emberjs | ember.js | 1,800 |
c79a57ae3732d461aba234b2bd78d9fb4e90f862 | Katie Gengler | Katie Gengler | Add v3.23.0-beta.1 to CHANGELOG
(cherry picked from commit dd71cbb7d8b895979e93cdcb3ac1cba3ddc3bab3) | add v3.23.0-beta.1 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,801 |
fb295a9e6a5800b070b62d26c980ea709fd7069c | Robert Jackson | GitHub | Merge pull request #19178 from emberjs/bugfix/allow-cycles-in-computed-deps | merge pull request from emberjs/bugfix/allow-cycles-in-computed-deps | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 1,802 |
e2a6babc5fcca17f58343997854c558b5b5f1dd5 | Katie Gengler | Katie Gengler | Add v3.22.0 to CHANGELOG
(cherry picked from commit 388d5c381a48c409ace0ac38f4dd35109fe8f0a2) | add v3.22.0 to changelog | 24 | false | false | 4 | true | true | true | emberjs | ember.js | 1,803 |
ec74ab4300e9f8057cf4d9ef38787fb98b07c457 | Ricardo Mendes | GitHub | Merge pull request #19176 from rishikesh7355/master
Update README.md | merge pull request from rishikesh7355/master | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 1,804 |
ed4e02ed7e97dca6fdaf5ffc0ac88f87991f8a82 | Ricardo Mendes | GitHub | Update README.md | update readme.md | 16 | false | false | 2 | false | false | false | emberjs | ember.js | 1,805 |
575f479543eed3e2a680d2f454da595d5db6d580 | Chris Garrett | GitHub | Merge pull request #19182 from emberjs/enable-helper-managers-invoke-helper
[FEAT] Enables Helper Managers and `invokeHelper` | merge pull request from emberjs/enable-helper-managers-invoke-helper | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 1,806 |
efd895f493ca1f3984cec6e0c37061c177c3903a | Chris Garrett | Chris Garrett | [FEAT] Enables Helper Managers and `invokeHelper`
Enables the Helper Manager and `invokeHelper` feature flags, and adds
API documentation for them. | [feat] enables helper managers and `invokehelper` | 49 | false | false | 6 | false | false | false | emberjs | ember.js | 1,807 |
5becf8846a00a1be254cb777c31258f5f8b86c54 | Edward Faulkner | GitHub | Keep browserstack key in plaintext
It turns out this was intentional. The key has no privileged access to anything in our case, and it needs to be in plaintext if we want to run browserstack against PRs. | keep browserstack key in plaintext | 34 | false | false | 5 | true | true | true | emberjs | ember.js | 1,808 |
b3d075fa0324b506d4debbd3accf38b24234a559 | Edward Faulkner | GitHub | Rotated browserstack access key
The old key was in plain text in the repo, the new key is stored via GitHub Secrets. | rotated browserstack access key | 31 | false | false | 4 | false | false | false | emberjs | ember.js | 1,809 |
ed459609cb6b79036949755f0c0d2ff001efc270 | Rishikesh Yadav | GitHub | Update README.md | update readme.md | 16 | false | false | 2 | false | false | false | emberjs | ember.js | 1,810 |
17b01c91dc5309639f3e6d961e42858aaaeff3a2 | Robert Jackson | GitHub | Merge pull request #19174 from kategengler/ignore-changelog
Don't trigger the CI build when only CHANGELOG is modified | merge pull request from kategengler/ignore-changelog | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 1,811 |
6e5e2d3fbb44978a80b2ec48c177396f822f4786 | Robert Jackson | GitHub | Merge pull request #19175 from BarryThePenguin/upgrade-typescript-eslint | merge pull request from barrythepenguin/upgrade-typescript-eslint | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 1,812 |
b612d47c2138f9b430f1ea5550301359f8ff3ed1 | Chris Garrett | Chris Garrett | [BUGFIX lts] Allow computeds to have cycles in their deps
The bugfix for disallowed cycles in tracked props in #19138 attempted
to also narrow the number of cycles that are allowed in general. Cycles
should only be allowed for computed property deps, for legacy support
reasons. The logic to allow cycles for these tags in particular was
mistakenly added to `setup`, which runs on the _prototype_ of the class.
This meant that _instance_ computed props were not allowed to have
cycles, and this was causing failures in the ecosystem.
Added a test that failed and is fixed with this change. I also attempted
to create a cycle with `@alias` since it uses a different
implementation, but I wasn't able to create one which didn't result in
a Maximum Callstack style recursion error, so I think it's just not
possible at all anyways, since `@alias` is eager always and never
caches. | [bugfix lts] allow computeds to have cycles in their deps | 57 | false | false | 10 | false | false | false | emberjs | ember.js | 1,813 |
9a0d9a73ca82faea20ee18950c0b07cd4b71e859 | Robert Jackson | GitHub | Apply suggestions from code review
Co-authored-by: Jonathan Haines <[email protected]> | apply suggestions from code review | 34 | false | false | 5 | true | true | true | emberjs | ember.js | 1,814 |
b0bc40f3c2ea3333b7c525f0fc9849e95412d241 | Robert Jackson | GitHub | Merge pull request #19171 from emberjs/invoke-helper
[FEAT] Implements invokeHelper | merge pull request from emberjs/invoke-helper | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 1,815 |
fb7022b8f4af64534470b002fe91a4da9b9d96b5 | Rishikesh Yadav | GitHub | Update README.md | update readme.md | 16 | false | false | 2 | false | false | false | emberjs | ember.js | 1,816 |
f6a5c78144504c763afd0937552944b509cef9b0 | Jonathan Haines | Jonathan Haines | Enable 'import/export' with fix for multiple default exports | enable 'import/export' with fix for multiple default exports | 60 | false | false | 8 | true | false | false | emberjs | ember.js | 1,817 |
083927cee1743908dbc588eb4acf3e0271156537 | Jonathan Haines | Jonathan Haines | Replace babel-eslint with @typescript-eslint/parser | replace babel-eslint with @typescript-eslint/parser | 51 | false | false | 4 | true | true | false | emberjs | ember.js | 1,818 |
fc2157b122665977e50734112063d695ec622d81 | NullVoxPopuli | Chris Garrett | [FEAT] Implements invokeHelper | [feat] implements invokehelper | 30 | false | false | 3 | false | false | false | emberjs | ember.js | 1,819 |
66fb044408d44649989902e9f85933cdf86f8cc8 | Robert Jackson | GitHub | Merge pull request #19173 from emberjs/force-capabilities-usage | merge pull request from emberjs/force-capabilities-usage | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 1,820 |
7fd407c2f80feb14d24a22ec762521bad563a746 | Katie Gengler | Katie Gengler | Add v3.22.0-beta.5 to CHANGELOG
(cherry picked from commit ae3c065f7c3416f6c497b2a5b5d9e6dd4d549662) | add v3.22.0-beta.5 to changelog | 31 | false | false | 4 | true | false | true | emberjs | ember.js | 1,821 |
04071f0688b75c8af30d51ba98890c1c03f90aa5 | Katie Gengler | Katie Gengler | Don't trigger the CI build when only CHANGELOG is modified | don't trigger the ci build when only changelog is modified | 58 | false | false | 10 | false | false | false | emberjs | ember.js | 1,822 |
984c9adaa2e863fd2f8dd919600f364e84c6a9a4 | Katie Gengler | Katie Gengler | Add v3.22.0-beta.4 to CHANGELOG
(cherry picked from commit 3010b89abd5fd15e65414b1654222498eb6607bf) | add v3.22.0-beta.4 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,823 |
389486714360f972eb44638c6874791d442c4216 | Robert Jackson | Robert Jackson | Add v3.21.3 to CHANGELOG.md. | add v3.21.3 to changelog.md | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 1,824 |
f776ac84baa67ae29fb2c13a94f2ca55a967b2b3 | Robert Jackson | Robert Jackson | Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager). | enforce usage of `capabilities` generation | 42 | false | false | 5 | true | true | true | emberjs | ember.js | 1,825 |
62a9b84b29a77bac107700804667f77e3c904589 | Robert Jackson | GitHub | Merge pull request #19172 from emberjs/bugfix/ensure-tracked-props-init
[BUGFIX lts] Ensures that tracked properties initialize property | merge pull request from emberjs/bugfix/ensure-tracked-props-init | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 1,826 |
c1488b517ae06704626b9cc092d455eb04d309d0 | Chris Garrett | Chris Garrett | [BUGFIX lts] Ensures that tracked properties initialize property
Fixes tracked property initialization for classic classes. | [bugfix lts] ensures that tracked properties initialize property | 64 | false | false | 8 | false | false | false | emberjs | ember.js | 1,827 |
15217a3ab36a35c8b26361c3155a30efe4a0f8ae | Robert Jackson | Robert Jackson | Add v3.21.2 to CHANGELOG.md. | add v3.21.2 to changelog.md | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 1,828 |
3c9af8f9bf0650684260a8ce6a586f91b26ad31d | Robert Jackson | GitHub | Merge pull request #19121 from emberjs/dependabot/npm_and_yarn/bl-4.0.3
Bump bl from 4.0.2 to 4.0.3 | merge pull request from emberjs/dependabot/npm_and_yarn/bl-4.0.3 | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 1,829 |
06af1df1bc48f883e48d0e2cababa4fee8b89f90 | Robert Jackson | GitHub | Merge pull request #19138 from emberjs/bugfix/fix-tag-cycles-in-query-params
[BUGFIX lts] Fix tag cycles in query parameters | merge pull request from emberjs/bugfix/fix-tag-cycles-in-query-params | 70 | true | false | 5 | true | false | false | emberjs | ember.js | 1,830 |
57a204444d044e7e25e23b3a468d97bb33f4651c | Chris Garrett | Robert Jackson | [BUGFIX lts] Fix tag cycles in query parameters
Currently, we wrap query parameters with @dependentKeyCompat manually
to ensure they work with the legacy router setup, which watches QPs
using observers. When a QP value is labeled as @tracked, we don't need
to replace it with @dependentKeyCompat, but since it's just a plain
native getter (from the decorator) we do anyways. This results in a tag
cycle being created, which can result in a negative performance impact,
as every render pass will be invalidated by the cycle and require a
subsequent full revalidation.
This bug would have been caught by our ALLOW_CYCLES logic, but that
logic was faulty - it was allowing too many cycles, anything that was
accessed via get. It should only have allowed cycles from computeds
themselves.
This PR fixes the bug with ALLOW_CYCLES, and the subsequent bug with
@tracked by only wrapping with @dependentKeyCompat if the value is
not @tracked. It also adds an assertion to prevent users from using
@dependentKeyCompat with @computed or @tracked.
Verified that the test failed after fixing ALLOW_CYCLES, and passed
again after the fix. | [bugfix lts] fix tag cycles in query parameters | 47 | false | false | 8 | false | false | false | emberjs | ember.js | 1,831 |
1248d18cd9591b62eb228cbdf21bb38420eb6fef | dependabot[bot] | GitHub | Bump bl from 4.0.2 to 4.0.3
Bumps [bl](https://github.com/rvagg/bl) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](https://github.com/rvagg/bl/compare/v4.0.2...v4.0.3)
Signed-off-by: dependabot[bot] <[email protected]> | bump bl from 4.0.2 to 4.0.3 | 27 | true | true | 6 | false | true | false | emberjs | ember.js | 1,832 |
8d21e488fcc1d76369628f7775a603d3d79f584e | Robert Jackson | GitHub | Merge pull request #19156 from BarryThePenguin/upgrade-eslint | merge pull request from barrythepenguin/upgrade-eslint | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 1,833 |
0145e9bf9f6e6fa0497c00cc96af14f6cc4c4185 | Robert Jackson | Robert Jackson | Manually fixup linting.
* Fix a bunch of tests that failed the no-dupe-class-members rule
* Remove a couple duplicated tests
* Add an `eslint-disable-next-line` for `no-setter-return` when
**explicitly** testing `@computed` setters with a return statement | manually fixup linting | 22 | false | false | 3 | false | false | false | emberjs | ember.js | 1,834 |
9fcbf5327c9116c446c9cc7b519066acc7cddb74 | Jonathan Haines | Robert Jackson | Upgrade to eslint 7
* Upgrade eslint and typescript-eslint packages to latest versions
* Add `@typescript-eslint/eslint-recommended` (and remove rules that are
no longer required). | upgrade to eslint 7 | 19 | false | false | 4 | false | false | false | emberjs | ember.js | 1,835 |
058787de09963bb5fe499e0bb3acd33d3849802b | Robert Jackson | Robert Jackson | Merge branch 'BarryThePenguin/upgrade-prettier' into master
Manually merging #19154. | merge branch 'barrythepenguin/upgrade-prettier' into master | 59 | true | false | 5 | true | true | false | emberjs | ember.js | 1,836 |
8e3a18a026d599b3a7aee17e0750f5c8db5aaede | Robert Jackson | Robert Jackson | eslint . --ext=js,ts --fix | eslint . --ext=js,ts --fix | 26 | false | false | 4 | false | false | false | emberjs | ember.js | 1,837 |
817a904bb83e6bfdd06461cee83849483ea4c83c | Jonathan Haines | Robert Jackson | Upgrade to prettier 2 | upgrade to prettier 2 | 21 | false | false | 4 | false | false | false | emberjs | ember.js | 1,838 |
14bd52f2d6ac6d73beba56bd2b4394aa4e290c48 | Robert Jackson | GitHub | Merge pull request #19170 from emberjs/make-modifier-3-22-use-definition
[BUGFIX beta] Make modifier manager 3.22 accept the resolved value directly. | merge pull request from emberjs/make-modifier-3-22-use-definition | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 1,839 |
1acd6d2c24a55b1376e8d46472d1a3c83b637004 | Robert Jackson | Robert Jackson | [BUGFIX beta] Make modifier manager 3.22 accept the resolved value directly.
When using `modifierCapabilities('3.13')` (the only allowed value in all
released Ember versions) you receive the result of `owner.factoryFor`
directly. If you want the raw value, you have to grab it off of the
first argument to `createModifier` like:
```js
class CustomModifierManager {
capabilities = modifierCapabilities('3.13');
constructor(owner) {
this.owner = owner;
}
createModifier(factory, args) {
let Modifier = factory.class;
return new Modifier(owner, args)
}
// ...snip...
}
```
In order to align the modifier world with the way helpers and component
managers work, this commit changes to passing the
`owner.factoryFor(...).class` directly to `createModifier` instead.
So the above snippet would be rewritten to:
```js
class CustomModifierManager {
capabilities = modifierCapabilities('3.22');
constructor(owner) {
this.owner = owner;
}
createModifier(Modifier, args) {
return new Modifier(owner, args)
}
// ...snip...
}
``` | [bugfix beta] make modifier manager 3.22 accept the resolved value directly | 75 | false | false | 11 | false | false | false | emberjs | ember.js | 1,840 |
bd15e2d1d76278712dc3051b766149e31eefe26a | Robert Jackson | GitHub | Merge pull request #19160 from emberjs/feat/implement-helper-managers
[FEAT] Implements Helper Managers | merge pull request from emberjs/feat/implement-helper-managers | 63 | true | false | 5 | true | true | false | emberjs | ember.js | 1,841 |
2dc6e9e7f45948f0b9a3cf93dfb7ea974ebdb654 | Robert Jackson | GitHub | Merge pull request #19148 from emberjs/update-glimmer-vm-0.62
[BUGFIX] Update Glimmer VM to 0.62.1 | merge pull request from emberjs/update-glimmer-vm-0.62 | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 1,842 |
098b0d92f4969e656a14afd2c6f8014037a8b6f0 | Chris Garrett | Chris Garrett | [BUGFIX] Update Glimmer VM to 0.62.1 | [bugfix] update glimmer vm to 0.62.1 | 36 | false | false | 6 | false | false | false | emberjs | ember.js | 1,843 |
be954758e7e66ad0c1c2a94772817c1771cb2193 | Chris Garrett | Chris Garrett | [FEAT] Implements Helper Managers
Implements the helper manager feature specified in RFC 625. Highlights:
1. Adds `getDebugName` to the interface for helper managers. This is an
optional hook that is used for better logging purposes, and matches
other internal APIs we've added recently.
2. `hasScheduledEffect` has not yet been implemented, and attempting to
use it will cause an assertion to be thrown.
Helper managers are not exposed with this PR, and the version passed to
`helperCapabilities` is optimistic, but can be changed when we do expose
them (along with an appropriate feature flag).
Co-authored-by: Robert Jackson <[email protected]> | [feat] implements helper managers | 33 | false | false | 4 | false | false | false | emberjs | ember.js | 1,844 |
de4c425ebc6b761f7db560d63e4edd54fde3719b | Chris Garrett | GitHub | Merge pull request #19166 from emberjs/upgrade-typescript-4.0
Update TypeScript to v4.0.0 | merge pull request from emberjs/upgrade-typescript-4.0 | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 1,845 |
26ef075c85688d26b1b12921bb4b5d4073507d83 | Chris Garrett | Chris Garrett | Update TypeScript to v4.0.0 | update typescript to v4.0.0 | 27 | false | false | 4 | true | true | true | emberjs | ember.js | 1,846 |
225a82d202020d931ca8ead4024e285006241618 | Chris Garrett | GitHub | Merge pull request #19164 from emberjs/bugfix/entangle-ember-arrays-in-get
[BUGFIX lts] Entangles custom EmberArray implementations when accessed | merge pull request from emberjs/bugfix/entangle-ember-arrays-in-get | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 1,847 |
ef26b1fa43edcce2bd04a78ef087ff5615683af2 | Chris Garrett | Chris Garrett | [BUGFIX lts] Entangles custom EmberArray implementations when accessed
Restores the previous logic that existed for entangling custom
EmberArray implementations when they are accessed, along with a test
for the functionality. | [bugfix lts] entangles custom emberarray implementations when accessed | 70 | false | false | 8 | false | false | false | emberjs | ember.js | 1,848 |
aeef923e9f5f7dde2bc43fcdddabc4a3b98769ec | Robert Jackson | GitHub | Merge pull request #19163 from emberjs/modifier-args-proxy | merge pull request from emberjs/modifier-args-proxy | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 1,849 |
d7f56c44e4d5ec1d0e18449451419ecb045458ea | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure custom modifiers use args proxy.
Prior to this change, all custom modifiers **always** consumed every
argument on install/update/destroy. This was because `reifyArgs`
specifically reads all of them, and the actual usage was not
consumption based.
After this change, any modifiers using `modifierCapabilities('3.22')`
will only consume the arguments that are actually used (named and
positional). All modifiers that use `modifierCapabilities('3.13')` are
unchanged (preserving backwards compatibility). | [bugfix beta] ensure custom modifiers use args proxy | 52 | false | false | 8 | false | false | false | emberjs | ember.js | 1,850 |
b49f91dabe3738c939337689f8bb422c08727f24 | Chris Garret | Robert Jackson | [BUGFIX beta] Generalize args proxy.
Generalizes the args proxy for use in both components and helpers.
This does change the semantics slightly of `positional` arguments for
component managers, notably it would make it so using computed
properties with them would require a bit more work from custom
component managers. The new semantics are more inline with the future
of Ember, but if there many custom managers that use positional args we
may want to reconsider this change.
Co-authored-by: Robert Jackson <[email protected]> | [bugfix beta] generalize args proxy | 35 | false | false | 5 | false | false | false | emberjs | ember.js | 1,851 |
984e69c2be41acc243805aae339cb7499fa2d9cc | Robert Jackson | GitHub | Merge pull request #19159 from emberjs/refactor/split-managers-into-multiple-maps
[REFACTOR] Split managers into multiple maps | merge pull request from emberjs/refactor/split-managers-into-multiple-maps | 75 | true | false | 5 | true | false | false | emberjs | ember.js | 1,852 |
cce03c210034e58406c35baae135c1d11d1e76e4 | Chris Garrett | Chris Garrett | [REFACTOR] Split managers into multiple maps
This refactors managers to split different types of managers into
different maps per-type. This allows more than one type of manager to
be associated with a given definition. For instance, this is a useful
capability for helper and modifier managers to have, since helpers and
modifiers have a lot in common and may end up being able to share
implementations.
This also upstreams the deduplication logic from Glimmer.js, which was
more stringent than in Ember. In Ember, we currently create one instance
of a given manager _per-component-definition_, whereas in Glimmer.js, we
create one _per-factory/owner combination_. Given that managers are
generally encouraged to be mostly-stateless in general, this change
shouldn't be a problem, and should be slightly more performant in apps
with many component definitions. | [refactor] split managers into multiple maps | 44 | false | false | 6 | false | false | false | emberjs | ember.js | 1,853 |
74a99a2971d327783b23a1093cf9564265db1a9d | Godfrey Chan | GitHub | Merge pull request #19155 from emberjs/refactor-input-component
Refactor internal `<Input>` component implementation | merge pull request from emberjs/refactor-input-component | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 1,854 |
4789dc57e4491ab97830129feb0d6e4495bd5782 | Godfrey Chan | Godfrey Chan | Workaround for strange TS bug | workaround for strange ts bug | 29 | false | false | 5 | false | false | false | emberjs | ember.js | 1,855 |
85d2418bcd6ad491cb08bc50da17daff0c3a157b | Godfrey Chan | Godfrey Chan | Refactor internal `<Input>` component implementation
- Add `InternalComponent` super class with a Glimmer-ish API
- Remove `InputComponentManager` and merge with `InternalManager`
- Rewrite internal `<Input>` component implementation to subclass
from the new `InternalComponent` instead of `Ember.Object` | refactor internal `<input>` component implementation | 52 | false | false | 5 | false | false | false | emberjs | ember.js | 1,856 |
931ac4ee1a83c96ed1e8d3189a6d4b9a0c1acd77 | Godfrey Chan | GitHub | Merge pull request #19151 from emberjs/upgrade-typescript
Upgrade to TypeScript 3.7 | merge pull request from emberjs/upgrade-typescript | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 1,857 |
68f4483df86c7a2e42739c3d99c87d34fa445edd | Godfrey Chan | Godfrey Chan | Apply new prettier autofix | apply new prettier autofix | 26 | false | false | 4 | true | true | true | emberjs | ember.js | 1,858 |
d46bbf9a4ff3cf4a5a36044dc98dd924f76350a1 | Godfrey Chan | Godfrey Chan | Upgrade prettier to fix parse error | upgrade prettier to fix parse error | 35 | false | false | 6 | true | false | true | emberjs | ember.js | 1,859 |
eb2152148139838d22f1b1cbaf004abba4530323 | Godfrey Chan | Godfrey Chan | Change assert signature to try TS 3.7 features | change assert signature to try ts 3.7 features | 46 | false | false | 8 | false | false | false | emberjs | ember.js | 1,860 |
eb28eb4bd995d09694a64d0b21967da4c25f77dc | Godfrey Chan | GitHub | Merge pull request #19094 from NullVoxPopuli/gh-19004-make-isActive-consume-tracked-properties
Resolves #19004: RouterService#isActive() now consumes currentURL and… | merge pull request from nullvoxpopuli/gh-19004-make-isactive-consume-tracked-properties | 88 | true | false | 5 | true | false | false | emberjs | ember.js | 1,861 |
566b04d21af210d15f699b9c6ec3da0017695355 | Robert Jackson | GitHub | Merge pull request #19150 from emberjs/refactor-input-component
[CLEANUP] Remove EMBER_CUSTOM_COMPONENT_ARG_PROXY feature | merge pull request from emberjs/refactor-input-component | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 1,862 |
4f6d0d5cbf58a43b8060d9d7b7acb11a0355ba01 | Godfrey Chan | Godfrey Chan | Upgrade to TypeScript 3.7
This seems to have Just Worked™? We can probably try upgrading to
4.0 with broccoli-typescript-compiler 6.0 after this. | upgrade to typescript 3.7 | 25 | false | false | 4 | false | false | false | emberjs | ember.js | 1,863 |
61e246d4074122a5aef72869cf7cfdd534f0d930 | Godfrey Chan | Godfrey Chan | [CLEANUP] Remove EMBER_CUSTOM_COMPONENT_ARG_PROXY feature
Also extract named args proxy logic into a function. | [cleanup] remove ember_custom_component_arg_proxy feature | 57 | false | false | 4 | false | false | false | emberjs | ember.js | 1,864 |
270d1e4a8181a432905914a168ff7505291a0743 | Godfrey Chan | GitHub | Merge pull request #19149 from emberjs/chancancode-patch-1
[DOC lts] Fix incorrect @action import | merge pull request from emberjs/chancancode-patch-1 | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 1,865 |
b768a127fe5442ed801e373d55a8e7694f11bd79 | Godfrey Chan | GitHub | [DOC lts] Fix incorrect @action import | [doc lts] fix incorrect @action import | 38 | false | false | 6 | false | false | false | emberjs | ember.js | 1,866 |
27d547de76b5c19b530cae6b0798075890188d18 | Robert Jackson | GitHub | Merge pull request #19136 from emberjs/update-router-js | merge pull request from emberjs/update-router-js | 49 | true | false | 5 | true | false | false | emberjs | ember.js | 1,867 |
af4253ea667a0e91805c0778d8871289bc8d12bf | Robert Jackson | GitHub | Merge pull request #19135 from lifeart/remove-module-unification-usages | merge pull request from lifeart/remove-module-unification-usages | 65 | true | false | 5 | true | false | false | emberjs | ember.js | 1,868 |
d654a6e588451503f8b2518d6d31ed264f95f634 | Katie Gengler | Katie Gengler | Add v3.22.0-beta.3 to CHANGELOG
(cherry picked from commit 676f728fbe9a5300a7c3d0fcd24f5b23af1ca7d9) | add v3.22.0-beta.3 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,869 |
ab4dcea20d68d0823f0245f133d015afe791bb76 | Robert Jackson | Robert Jackson | Update router microlib to improve Transition related debugging. | update router microlib to improve transition related debugging | 62 | false | false | 8 | false | true | false | emberjs | ember.js | 1,870 |
39ed2bbc2328f5efc3b32f783c744376f8cd6e38 | Aleksandr Kanunnikov | Aleksandr Kanunnikov | remove unused namespace asserts | remove unused namespace asserts | 31 | false | false | 4 | false | true | false | emberjs | ember.js | 1,871 |
442fbea2708c770b32d0328a088bde15cb5fb0ac | Aleksandr Kanunnikov | Aleksandr Kanunnikov | fix ts lag | fix ts lag | 10 | false | false | 3 | false | true | false | emberjs | ember.js | 1,872 |
4286b7be981ce7a0a66e098fe884867bf9bcc800 | Aleksandr Kanunnikov | Aleksandr Kanunnikov | remove lint issues and experiment itself | remove lint issues and experiment itself | 40 | false | false | 6 | true | true | true | emberjs | ember.js | 1,873 |
cba436fe343c51b7ec4012eaddf9aacef7971eef | Aleksandr Kanunnikov | Aleksandr Kanunnikov | removed module unification usages | removed module unification usages | 33 | false | false | 4 | false | false | false | emberjs | ember.js | 1,874 |
b049c37e66587718cef38cde63b59b0789505d43 | dependabot-preview[bot] | GitHub | Merge pull request #19128 from emberjs/dependabot/npm_and_yarn/http-proxy-1.18.1 | merge pull request from emberjs/dependabot/npm_and_yarn/http-proxy-1.18.1 | 74 | true | true | 5 | true | false | false | emberjs | ember.js | 1,875 |
97967d8cb2ab1e28144e1e1fcb142580c19a001d | dependabot-preview[bot] | GitHub | [Security] Bump http-proxy from 1.17.0 to 1.18.1
Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. **This update includes a security fix.**
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.17.0...1.18.1)
Signed-off-by: dependabot-preview[bot] <[email protected]> | [security] bump http-proxy from 1.17.0 to 1.18.1 | 48 | false | true | 7 | false | false | false | emberjs | ember.js | 1,876 |
84141355406d8abab328c3ad680ac27f9730eda3 | NullVoxPopuli | NullVoxPopuli | consume only currentURL on the private router instead of computed aliases | consume only currenturl on the private router instead of computed aliases | 73 | false | false | 11 | true | true | false | emberjs | ember.js | 1,877 |
1da222a1d3095ea2211fda5440542edd20ec243b | Francesco Novy | Francesco Novy | [DOC] Update documentation for `runInDebug`
The documentation was incorrect, see:
https://github.com/emberjs/ember.js/issues/18912 | [doc] update documentation for `runindebug` | 43 | false | false | 5 | false | false | false | emberjs | ember.js | 1,878 |
cdb0862b339ec52a7ad9c4de46caa05a856cbcd7 | Robert Jackson | GitHub | Merge pull request #19125 from emberjs/fix-fastboot-canary | merge pull request from emberjs/fix-fastboot-canary | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 1,879 |
3f2501382f7cd4c4b8b5ac894c163d99c7d3afeb | Robert Jackson | Robert Jackson | Fix rendering engine usage within a `fastboot` sandbox | fix rendering engine usage within a `fastboot` sandbox | 54 | false | false | 8 | false | true | false | emberjs | ember.js | 1,880 |
4ed58f179f205e5377e0f2cdfb227aa1efe90d3f | Robert Jackson | Robert Jackson | Add testing harness that replicates FastBoot environment.
Prior to this we were simulating FastBoot in a non-isolated VM context.
That meant that the running Node context was available within rendering
attempts. However, when ran with "real" FastBoot that is **not** the
case. In the real FastBoot environment, we create an isolated `vm`
context and evaluate both Ember and the application within that context.
This ensures that the running context does not have access to arbitrary
Node-land APIs (e.g. `require`).
(cherry picked from commit f9ef7dcca312148832894259713ca350de1c8085) | add testing harness that replicates fastboot environment | 56 | false | false | 7 | true | true | false | emberjs | ember.js | 1,881 |
a9188a9855a3a87609af093e9732a0504fc2ac1d | Robert Jackson | GitHub | Merge pull request #19122 from emberjs/bugfix/prevent-dynamic-invocation
[BUGFIX] Prevent dynamic invocations | merge pull request from emberjs/bugfix/prevent-dynamic-invocation | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 1,882 |
3f5b8f02bde4c2cd1bb8ff8126cf351086625c15 | Chris Garrett | Chris Garrett | [BUGFIX] Prevent dynamic invocations
Prevents dynamic invocations of string values when referenced directly in
angle brackets | [bugfix] prevent dynamic invocations | 36 | false | false | 4 | false | false | false | emberjs | ember.js | 1,883 |
e6c38ecbbc1162e600e2058b8fa3bc93993e13aa | Robert Jackson | GitHub | Merge pull request #19119 from emberjs/remove-aot-mode | merge pull request from emberjs/remove-aot-mode | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 1,884 |
a5e721ee7cc7938e24838a4ae913608579f528de | Chris Garrett | Chris Garrett | [REFACTOR] Removes AoT mode
Integrates Glimmer VM 0.61 | [refactor] removes aot mode | 27 | false | false | 4 | false | false | false | emberjs | ember.js | 1,885 |
40cf9739132f87ebe848c88a3ba422191ed37ca9 | dependabot-preview[bot] | GitHub | Merge pull request #19117 from emberjs/dependabot/npm_and_yarn/lodash-4.17.20 | merge pull request from emberjs/dependabot/npm_and_yarn/lodash-4.17.20 | 71 | true | true | 5 | true | false | false | emberjs | ember.js | 1,886 |
e7c3268f700245232e74c984e57b8bd86305e3b2 | dependabot-preview[bot] | GitHub | Merge pull request #19116 from emberjs/dependabot/npm_and_yarn/dot-prop-4.2.1 | merge pull request from emberjs/dependabot/npm_and_yarn/dot-prop-4.2.1 | 71 | true | true | 5 | true | false | false | emberjs | ember.js | 1,887 |
391cd5044d27341214d0fa25497e844058bd9fbe | dependabot-preview[bot] | GitHub | [Security] Bump lodash from 4.17.15 to 4.17.20
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20. **This update includes security fixes.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20)
Signed-off-by: dependabot-preview[bot] <[email protected]> | [security] bump lodash from 4.17.15 to 4.17.20 | 46 | false | true | 7 | false | false | false | emberjs | ember.js | 1,888 |
94f31716f157317989c95517aba81d9ae071df1c | dependabot-preview[bot] | GitHub | [Security] Bump dot-prop from 4.2.0 to 4.2.1
Bumps [dot-prop](https://github.com/sindresorhus/dot-prop) from 4.2.0 to 4.2.1. **This update includes a security fix.**
- [Release notes](https://github.com/sindresorhus/dot-prop/releases)
- [Commits](https://github.com/sindresorhus/dot-prop/compare/v4.2.0...v4.2.1)
Signed-off-by: dependabot-preview[bot] <[email protected]> | [security] bump dot-prop from 4.2.0 to 4.2.1 | 44 | false | true | 7 | false | false | false | emberjs | ember.js | 1,889 |
269d59062c3cbdce847fff6639c08c10375c97b3 | Robert Jackson | GitHub | Merge pull request #19107 from emberjs/refactor/monomorphic-reference | merge pull request from emberjs/refactor/monomorphic-reference | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 1,890 |
3caa6f8cff24cd80bccc7d3835ab5b7e9d1a8855 | Chris Garrett | Chris Garrett | [REFACTOR] Monomorphic Reference
Integrates https://github.com/glimmerjs/glimmer-vm/pull/1142 | [refactor] monomorphic reference | 32 | false | false | 3 | false | false | false | emberjs | ember.js | 1,891 |
6b4f58971096decca38849b7081a56178b83d2b1 | Katie Gengler | Katie Gengler | Add v3.22.0-beta.2 to CHANGELOG
(cherry picked from commit a409f1de8396d11faf0e78b7b662370379417eb8) | add v3.22.0-beta.2 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,892 |
37f8d9fa5d361dd756c4afc1b86d5a4e13cd62a4 | Robert Jackson | Robert Jackson | Add v3.20.5 and v3.21.1 to CHANGELOG.md.
[ci skip] | add v3.20.5 and v3.21.1 to changelog.md | 39 | false | false | 6 | true | true | true | emberjs | ember.js | 1,893 |
052253940061d4fe0ef7497eb33a8159b265fc54 | Robert Jackson | GitHub | Merge pull request #19111 from emberjs/bugfix/fix-proxy-tags | merge pull request from emberjs/bugfix/fix-proxy-tags | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 1,894 |
f43dce615808e8d732e2e36595daf72117bc53d2 | Chris Garrett | Chris Garrett | [BUGFIX lts] Fixes ArrayProxy length reactivity
Recent refactors for performance left a gap in the reactivity model,
specifically for the `length` property of ArrayProxy. We now only use
the `CUSTOM_TAG_FOR` API when getting chain tags, which is much better
for most `get()` usages since we don't have to do an extra brand check
that is not very commonly used. However, the `length` property of
ArrayProxy does not have a normal property tag, and it is a native
getter which does not entangle the value naturally when accessed via
autotracking.
This PR sets up the `length` tag eagerly whenever the content of the
ArrayProxy changes, and consumes it when the `length` property is
accessed. It also does the same thing for the `arrTag`, though that is
only used for chain tags. Normally, when the array tag is accessed, it
tracks things properly through the `objectAt` API. | [bugfix lts] fixes arrayproxy length reactivity | 47 | false | false | 6 | false | false | false | emberjs | ember.js | 1,895 |
5187b7fb27a4a3c248ea4d6a20828dca0764985e | Robert Jackson | GitHub | Merge pull request #19106 from emberjs/core-object-with-destroy
[BUGFIX lts] Ensure `destroy` methods on `CoreObject` are invoked. | merge pull request from emberjs/core-object-with-destroy | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 1,896 |
4d55dae3a7ebe2d9ba5b2181179c587c69c33fc7 | Robert Jackson | Robert Jackson | [BUGFIX lts] Ensure `destroy` methods on `CoreObject` are invoked.
When an instance of `CoreObject` is destroyed with `@ember/destroyable`
(or the polyfill when using Ember 3.20+), the instances own `destroy`
method is never called. In _general_ "this is fine" because the majority
of consumers are using `willDestroy` for their custom object teardown
needs. Unfortunately, this isn't _quite_ good enough and any consumers
that are directly relying on extending from `CoreObject` and having a
custom `destroy` method called will no longer function.
The prime example of this is the `Owner` instance itself. Currently,
running `destroy(owner)` **does not** actually destroy any instantiated
objects in the container. This is because `ContainerProxyMixin`
implements `destroy` in order to call `this.__container__.destroy()`
which is where the actual cleanup happens. That whole system should be
refactored to leveraging `@ember/destroyable` system directly, but in
the meantime this case (and any others where folks have implemented a
destroy method in Mixins or other subclasses of Ember.CoreObject) should
**absolutely** be fixed.
This fix ensures that any `destroy(someInstance)` calls on a
`CoreObject` directly invoke the `destroy` method on the instance in the
same manner as Ember < 3.20 (`.destroy()` is called eagerly, before
`willDestroy`). | [bugfix lts] ensure `destroy` methods on `coreobject` are invoked | 65 | false | false | 9 | false | false | false | emberjs | ember.js | 1,897 |
180e9b7488a94ac00b91aee3c7a530f8ae1a89cf | Katie Gengler | Katie Gengler | Post-release version bump | post-release version bump | 25 | false | false | 3 | false | false | false | emberjs | ember.js | 1,898 |
1a17a61a4d4e7e89a0fd51ac39d6acf7dbbc9991 | Katie Gengler | Katie Gengler | Add v3.22.0-beta.1 to CHANGELOG
(cherry picked from commit a429dda8555b812afaed5dd1874ef19bc37e1b02) | add v3.22.0-beta.1 to changelog | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 1,899 |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.