url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/11904 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11904/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11904/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11904/events | https://github.com/NVIDIA/NeMo/pull/11904 | 2,800,382,613 | PR_kwDOC_bI7s6IanOx | 11,904 | remove nemo.collection.nlp imports from nemo2 | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.bert.data.core\nnemo/collections/llm/bert/data/core.py:59:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:60:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:61:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:65:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:66:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:68:0: C0301: Line too long (247/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:499:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:553:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:561:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:614:0: C0301: Line too long (183/119) (line-too-long)\nnemo/collections/llm/bert/data/core.py:38:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/bert/data/core.py:17:0: W0611: Unused multiprocessing imported as mp (unused-import)\nnemo/collections/llm/bert/data/core.py:18:0: W0611: Unused import os (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.66/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.base\nnemo/collections/llm/gpt/model/base.py:245:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/llm/gpt/model/base.py:422:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/llm/gpt/model/base.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:99:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:131:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:147:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:157:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:167:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:192:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:271:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:283:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:295:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:307:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:319:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:331:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:345:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:363:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:367:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:390:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:393:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:396:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:400:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:405:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:436:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:443:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:450:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:544:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:576:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:698:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:730:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:758:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:48:4: W0611: Unused import fused_weight_gradient_mlp_cuda (unused-import)\n************* Module nemo.collections.llm.gpt.model.gemma\nnemo/collections/llm/gpt/model/gemma.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:79:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:83:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:87:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:107:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:127:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:140:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:146:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:178:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:197:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:214:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.gemma2\nnemo/collections/llm/gpt/model/gemma2.py:192:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/gpt/model/gemma2.py:193:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/llm/gpt/model/gemma2.py:269:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/gpt/model/gemma2.py:270:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/llm/gpt/model/gemma2.py:54:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:85:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:112:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:122:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:132:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:141:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:164:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:185:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:200:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:243:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:262:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:277:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma2.py:281:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:392:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:393:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:394:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:399:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:620:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:621:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:622:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:627:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:42:4: W0611: Unused import transformer_engine (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.44/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-20T22:57:26 | 2025-01-20T23:33:20 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11904",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11904",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11904.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11904.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11904/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11904/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11903 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11903/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11903/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11903/events | https://github.com/NVIDIA/NeMo/pull/11903 | 2,800,138,071 | PR_kwDOC_bI7s6IZx-P | 11,903 | nemo ux expert tensor parallel | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning._strategy_lib\nnemo/lightning/_strategy_lib.py:577:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/_strategy_lib.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/_strategy_lib.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:143:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:170:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:206:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:519:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:602:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:615:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.megatron_init\nnemo/lightning/megatron_init.py:267:0: C0301: Line too long (122/119) (line-too-long)\nnemo/lightning/megatron_init.py:268:0: C0301: Line too long (133/119) (line-too-long)\nnemo/lightning/megatron_init.py:269:0: C0301: Line too long (121/119) (line-too-long)\nnemo/lightning/megatron_init.py:372:0: C0301: Line too long (166/119) (line-too-long)\nnemo/lightning/megatron_init.py:88:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.utils.app_state\nnemo/utils/app_state.py:458:0: C0301: Line too long (138/119) (line-too-long)\nnemo/utils/app_state.py:466:0: C0301: Line too long (135/119) (line-too-long)\nnemo/utils/app_state.py:23:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/app_state.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/app_state.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:726:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:736:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:745:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:750:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:756:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:764:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:772:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.79/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12879657991) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-20T19:19:02 | 2025-01-20T19:30:35 | null | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11903",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11903",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11903.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11903.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11903/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11903/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11902 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11902/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11902/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11902/events | https://github.com/NVIDIA/NeMo/pull/11902 | 2,800,091,555 | PR_kwDOC_bI7s6IZn7u | 11,902 | LinearAdapter: propagate args to _init_adapter | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.peft.lora\nnemo/collections/llm/peft/lora.py:158:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.90/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12874116340) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-20T18:43:01 | 2025-01-20T23:17:31 | 2025-01-20T23:17:30 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11902",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11902",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11902.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11902.patch",
"merged_at": "2025-01-20T23:17:30"
} | # What does this PR do ?
Changes:
1. pass params from `LinearAdapter`'s constructor to `LinearAdapter._init_adapter` -> previously was using `_init_adapter`'s default values
2. switch from dropout 0 to 0.1
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11902/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11902/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11901 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11901/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11901/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11901/events | https://github.com/NVIDIA/NeMo/pull/11901 | 2,799,516,337 | PR_kwDOC_bI7s6IXlg4 | 11,901 | fix(huggingface-hub): allow offline mode | {
"login": "maxstrobel",
"id": 34747372,
"node_id": "MDQ6VXNlcjM0NzQ3Mzcy",
"avatar_url": "https://avatars.githubusercontent.com/u/34747372?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maxstrobel",
"html_url": "https://github.com/maxstrobel",
"followers_url": "https://api.github.com/users/maxstrobel/followers",
"following_url": "https://api.github.com/users/maxstrobel/following{/other_user}",
"gists_url": "https://api.github.com/users/maxstrobel/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maxstrobel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxstrobel/subscriptions",
"organizations_url": "https://api.github.com/users/maxstrobel/orgs",
"repos_url": "https://api.github.com/users/maxstrobel/repos",
"events_url": "https://api.github.com/users/maxstrobel/events{/privacy}",
"received_events_url": "https://api.github.com/users/maxstrobel/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.core.classes.common\nnemo/core/classes/common.py:688:0: C0301: Line too long (120/119) (line-too-long)\nnemo/core/classes/common.py:814:0: C0301: Line too long (124/119) (line-too-long)\nnemo/core/classes/common.py:471:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/classes/common.py:567:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/classes/common.py:642:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/classes/common.py:1023:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/common.py:1138:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/common.py:29:0: W0611: Unused Iterable imported from typing (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.81/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-20T15:07:36 | 2025-01-20T15:08:40 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11901",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11901",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11901.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11901.patch",
"merged_at": null
} | Allow to reuse already cached models without the need for a connection to the internet or to the HuggingFace model hub.
# What does this PR do ?
Allows to use cached models without internet connection
**Collection**: [Note which collection this PR will affect]
# Changelog
- Allow to reuse already cached models without the need for a connection to the internet or to the HuggingFace model hub.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
@ericharper, @titu1994, @blisc @okuchaiev
# Additional Information
* Fixes #11899
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11901/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11901/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11900 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11900/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11900/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11900/events | https://github.com/NVIDIA/NeMo/issues/11900 | 2,799,450,978 | I_kwDOC_bI7s6m3Dti | 11,900 | max_steps and time calculation are not working as expected. | {
"login": "Shahad-Mohammed",
"id": 74230739,
"node_id": "MDQ6VXNlcjc0MjMwNzM5",
"avatar_url": "https://avatars.githubusercontent.com/u/74230739?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Shahad-Mohammed",
"html_url": "https://github.com/Shahad-Mohammed",
"followers_url": "https://api.github.com/users/Shahad-Mohammed/followers",
"following_url": "https://api.github.com/users/Shahad-Mohammed/following{/other_user}",
"gists_url": "https://api.github.com/users/Shahad-Mohammed/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Shahad-Mohammed/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Shahad-Mohammed/subscriptions",
"organizations_url": "https://api.github.com/users/Shahad-Mohammed/orgs",
"repos_url": "https://api.github.com/users/Shahad-Mohammed/repos",
"events_url": "https://api.github.com/users/Shahad-Mohammed/events{/privacy}",
"received_events_url": "https://api.github.com/users/Shahad-Mohammed/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-20T14:43:31 | 2025-01-20T14:43:31 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I'm encountering this issue where it shows `?` instead of the max steps and the time for the training process is not being calculated, this is my configuration:
```
trainer.max_steps=-1 \
trainer.max_epochs=1 \
```
`Epoch 0: : 0%| | 614/? [23:53<00:00, v_num=, reduced_train_loss=, global_step=, consumed_samples=, train_step_timing in s=, val_loss=]` | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11900/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11900/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11899 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11899/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11899/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11899/events | https://github.com/NVIDIA/NeMo/issues/11899 | 2,799,445,058 | I_kwDOC_bI7s6m3CRC | 11,899 | Broken offline mode of NeMo | {
"login": "maxstrobel",
"id": 34747372,
"node_id": "MDQ6VXNlcjM0NzQ3Mzcy",
"avatar_url": "https://avatars.githubusercontent.com/u/34747372?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maxstrobel",
"html_url": "https://github.com/maxstrobel",
"followers_url": "https://api.github.com/users/maxstrobel/followers",
"following_url": "https://api.github.com/users/maxstrobel/following{/other_user}",
"gists_url": "https://api.github.com/users/maxstrobel/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maxstrobel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxstrobel/subscriptions",
"organizations_url": "https://api.github.com/users/maxstrobel/orgs",
"repos_url": "https://api.github.com/users/maxstrobel/repos",
"events_url": "https://api.github.com/users/maxstrobel/events{/privacy}",
"received_events_url": "https://api.github.com/users/maxstrobel/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [] | 2025-01-20T14:41:00 | 2025-01-20T14:41:00 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
`huggingface_hub` has an offline mode ([`HF_HUB_OFFLINE`](https://huggingface.co/docs/huggingface_hub/package_reference/environment_variables#hfhuboffline)). `huggingface_hub` looks only into local cache if this is activated, and if a model is found, everything can be used offline without internet connection.
In `NeMo` there is a function call (https://github.com/NVIDIA/NeMo/blob/main/nemo/core/classes/common.py#L863) that checks if the model exists on HuggingFace hub. So even if the model is already cached, this call needs to establish a connection to HuggingFace hub.
**Steps/Code to reproduce bug**
1) Run a script while having internet connection to download a model, e.g.
~~~python
from nemo.collections.asr.models import EncDecCTCModelBPE
model = EncDecCTCModelBPE.from_pretrained("nvidia/stt_en_conformer_ctc_large")
~~~
2) Set the environment variable (`HF_HUB_OFFLINE=1`), disable internet connection & rerun script:
~~~python
from nemo.collections.asr.models import EncDecCTCModelBPE
model = EncDecCTCModelBPE.from_pretrained("nvidia/stt_en_conformer_ctc_large")
~~~
Traceback:
~~~
Traceback (most recent call last):
File "test_debug.py", line 21, in <module>
model = EncDecMultiTaskModel.from_pretrained("nvidia/canary-1b")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/nemo/core/classes/common.py", line 747, in from_pretrained
class_, nemo_model_file_in_cache = cls._get_hf_hub_pretrained_model_info(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/nemo/core/classes/common.py", line 873, in _get_hf_hub_pretrained_model_info
nemo_file_exists = api.file_exists(repo_id=model_name, filename=resolved_model_filename, repo_type="model")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/huggingface_hub/utils/_validators.py", line 114, in _inner_fn
return fn(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/huggingface_hub/hf_api.py", line 2899, in file_exists
get_hf_file_metadata(url, token=token)
File ".venv/lib/python3.11/site-packages/huggingface_hub/utils/_validators.py", line 114, in _inner_fn
return fn(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/huggingface_hub/file_download.py", line 1294, in get_hf_file_metadata
r = _request_wrapper(
^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/huggingface_hub/file_download.py", line 278, in _request_wrapper
response = _request_wrapper(
^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/huggingface_hub/file_download.py", line 301, in _request_wrapper
response = get_session().request(method=method, url=url, **params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/requests/sessions.py", line 703, in send
r = adapter.send(request, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File ".venv/lib/python3.11/site-packages/huggingface_hub/utils/_http.py", line 104, in send
raise OfflineModeIsEnabled(
huggingface_hub.errors.OfflineModeIsEnabled: Cannot reach https://huggingface.co/nvidia/canary-1b/resolve/main/canary-1b.nemo: offline mode is enabled. To disable it, please unset the `HF_HUB_OFFLINE` environment variable.
~~~
**Expected behavior**
It should take the cached model without relying on an internet connection. | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11899/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11899/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11898 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11898/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11898/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11898/events | https://github.com/NVIDIA/NeMo/pull/11898 | 2,799,316,739 | PR_kwDOC_bI7s6IW5jV | 11,898 | fix: correct signal for Windows | {
"login": "maxstrobel",
"id": 34747372,
"node_id": "MDQ6VXNlcjM0NzQ3Mzcy",
"avatar_url": "https://avatars.githubusercontent.com/u/34747372?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maxstrobel",
"html_url": "https://github.com/maxstrobel",
"followers_url": "https://api.github.com/users/maxstrobel/followers",
"following_url": "https://api.github.com/users/maxstrobel/following{/other_user}",
"gists_url": "https://api.github.com/users/maxstrobel/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maxstrobel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxstrobel/subscriptions",
"organizations_url": "https://api.github.com/users/maxstrobel/orgs",
"repos_url": "https://api.github.com/users/maxstrobel/repos",
"events_url": "https://api.github.com/users/maxstrobel/events{/privacy}",
"received_events_url": "https://api.github.com/users/maxstrobel/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.utils.exp_manager\nnemo/utils/exp_manager.py:353:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:378:0: C0301: Line too long (124/119) (line-too-long)\nnemo/utils/exp_manager.py:382:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:387:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:401:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:408:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:409:0: C0301: Line too long (126/119) (line-too-long)\nnemo/utils/exp_manager.py:411:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:413:0: C0301: Line too long (139/119) (line-too-long)\nnemo/utils/exp_manager.py:423:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:424:0: C0301: Line too long (128/119) (line-too-long)\nnemo/utils/exp_manager.py:425:0: C0301: Line too long (132/119) (line-too-long)\nnemo/utils/exp_manager.py:426:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:514:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:602:0: C0301: Line too long (208/119) (line-too-long)\nnemo/utils/exp_manager.py:603:0: C0301: Line too long (230/119) (line-too-long)\nnemo/utils/exp_manager.py:605:0: C0301: Line too long (178/119) (line-too-long)\nnemo/utils/exp_manager.py:642:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:777:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:785:0: C0301: Line too long (156/119) (line-too-long)\nnemo/utils/exp_manager.py:832:0: C0301: Line too long (141/119) (line-too-long)\nnemo/utils/exp_manager.py:840:0: C0301: Line too long (152/119) (line-too-long)\nnemo/utils/exp_manager.py:1110:0: C0301: Line too long (142/119) (line-too-long)\nnemo/utils/exp_manager.py:1134:0: C0301: Line too long (154/119) (line-too-long)\nnemo/utils/exp_manager.py:1200:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:1219:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:1245:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:91:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:106:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:132:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:141:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:150:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:161:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:277:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:286:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:333:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:336:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:339:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1126:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1227:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1246:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1249:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1265:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.19/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"Sorry for the duplicated PR - I closed the old one by accident (#11883)"
] | 2025-01-20T13:46:34 | 2025-01-20T13:47:09 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11898",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11898",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11898.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11898.patch",
"merged_at": null
} | Windows uses `signal.SIGTERM` instead of `signal.SIGKILL`.
# What does this PR do ?
Fixes wrong signal under Windows.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Fixes wrong signal under Windows.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
@BBC-Esq @titu1994 @blisc @okuchaiev
# Additional Information
* Related to #10275
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11898/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11898/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11897 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11897/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11897/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11897/events | https://github.com/NVIDIA/NeMo/pull/11897 | 2,798,800,219 | PR_kwDOC_bI7s6IVHnJ | 11,897 | ci: Bump Mcore in weekly PR | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-20T10:07:34 | 2025-01-20T10:09:21 | 2025-01-20T10:07:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11897",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11897",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11897.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11897.patch",
"merged_at": "2025-01-20T10:07:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11897/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11897/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11896 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11896/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11896/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11896/events | https://github.com/NVIDIA/NeMo/pull/11896 | 2,798,796,093 | PR_kwDOC_bI7s6IVGtP | 11,896 | Weekly bump | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron.falcon.falcon_decoder_layer\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:70:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:102:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:18:4: W0611: Unused parallel_state imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:19:4: W0611: Unused ShardedObject imported from megatron.core.dist_checkpointing.mapping (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:19:4: W0611: Unused ShardedTensor imported from megatron.core.dist_checkpointing.mapping (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron.gpt_full_te_layer_autocast_spec\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:51:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:147:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:179:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:337:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.megatron.adapters.mcore_mixins\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:141:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:143:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:60:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:69:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:109:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:227:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:335:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:445:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:452:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:476:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:483:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:501:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:508:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.39/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12865629877) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-20T10:06:11 | 2025-01-20T13:23:54 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11896",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11896",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11896.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11896.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11896/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11896/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11895 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11895/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11895/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11895/events | https://github.com/NVIDIA/NeMo/pull/11895 | 2,798,791,558 | PR_kwDOC_bI7s6IVFtr | 11,895 | Introduce evaluation API | {
"login": "Glorf",
"id": 479124,
"node_id": "MDQ6VXNlcjQ3OTEyNA==",
"avatar_url": "https://avatars.githubusercontent.com/u/479124?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Glorf",
"html_url": "https://github.com/Glorf",
"followers_url": "https://api.github.com/users/Glorf/followers",
"following_url": "https://api.github.com/users/Glorf/following{/other_user}",
"gists_url": "https://api.github.com/users/Glorf/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Glorf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Glorf/subscriptions",
"organizations_url": "https://api.github.com/users/Glorf/orgs",
"repos_url": "https://api.github.com/users/Glorf/repos",
"events_url": "https://api.github.com/users/Glorf/events{/privacy}",
"received_events_url": "https://api.github.com/users/Glorf/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:369:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/api.py:370:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/api.py:438:0: C0301: Line too long (178/119) (line-too-long)\nnemo/collections/llm/api.py:568:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.83/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-20T10:04:26 | 2025-01-20T19:36:18 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11895",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11895",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11895.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11895.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: LLM
# Changelog
- Introduce standardized API dataclasses for evals configuration
- Modify the evaluate method to comply with the new format
# Usage
```python
import os
import nemo_run as run
from nemo.collections.llm.api import deploy, evaluate
from nemo.collections.llm.evaluation.api import EvaluationConfig, ApiEndpoint, EvaluationTarget
triton_model_name = "LLama3.1"
nemo_checkpoint = '/models/nemo2/Meta-Llama-3.1-8Bfix'
max_input_len = 4096
url = f"http://0.0.0.0:8000/"
deploy_fn = run.Partial(
deploy,
triton_model_name=triton_model_name,
nemo_checkpoint=nemo_checkpoint,
max_input_len=max_input_len,
)
api_endpoint = run.Config(ApiEndpoint, model_id = triton_model_name, url = url, nemo_checkpoint_path = nemo_checkpoint)
target_cfg = run.Config(EvaluationTarget, api_endpoint = api_endpoint)
eval_cfg = run.Config(EvaluationConfig, type="gsm8k")
eval_fn = run.Partial(
evaluate,
target_cfg=target_cfg,
eval_cfg=
)
local_executor = run.LocalExecutor()
if __name__ == "__main__":
with run.Experiment("deploy_evaluate", log_level="INFO") as exp:
exp.add(deploy_fn, executor=local_executor, name="deploy")
exp.add(eval_fn, executor=local_executor, name="evaluate", tail_logs=True)
exp.run(sequential=False, tail_logs=True)
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11895/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11895/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11894 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11894/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11894/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11894/events | https://github.com/NVIDIA/NeMo/issues/11894 | 2,798,374,845 | I_kwDOC_bI7s6my8-9 | 11,894 | XLarge Fastconformer Long FT does not converge with default parameters | {
"login": "TornikeAm",
"id": 82511782,
"node_id": "MDQ6VXNlcjgyNTExNzgy",
"avatar_url": "https://avatars.githubusercontent.com/u/82511782?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/TornikeAm",
"html_url": "https://github.com/TornikeAm",
"followers_url": "https://api.github.com/users/TornikeAm/followers",
"following_url": "https://api.github.com/users/TornikeAm/following{/other_user}",
"gists_url": "https://api.github.com/users/TornikeAm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/TornikeAm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/TornikeAm/subscriptions",
"organizations_url": "https://api.github.com/users/TornikeAm/orgs",
"repos_url": "https://api.github.com/users/TornikeAm/repos",
"events_url": "https://api.github.com/users/TornikeAm/events{/privacy}",
"received_events_url": "https://api.github.com/users/TornikeAm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-20T07:05:42 | 2025-01-20T07:05:42 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello, Im Trying to fine tune Xlarge model with these parameters:
```
# It contains the default values for training a Fast Conformer-CTC ASR model, large size (~120M) with CTC loss and sub-word encoding.
# This version uses Longformer-style attention in order to handle longer audio
# You may find more detail:
# FastConformer here: https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/asr/models.html#fast-conformer
# FastConformer-CTC's architecture config: NeMo/examples/asr/conf/fastconformer/fast-conformer_ctc_bpe.yaml
# Differences from baseline config are in
# model.encoder.global_tokens
# model.encoder.global_tokens_spacing
# model.encoder.global_attn_separate
name: "FastConformer-Long-CTC-Xlarge_from_pretrain_default"
## initialized from our pretrained checkpoint.
init_from_ptl_ckpt: checkpoints/fastconf_long_xlarge_pretrain--val_loss=12487.7246-epoch=3-last.ckpt
model:
sample_rate: 16000
log_prediction: true # enables logging sample predictions in the output during training
ctc_reduction: 'mean_volume'
skip_nan_grad: false
train_ds:
manifest_filepath: final_ft_data.json
sample_rate: ${model.sample_rate}
batch_size: 25 # you may increase batch_size if your memory allows
shuffle: true
num_workers: 8
pin_memory: true
max_duration: 40 # it is set for LibriSpeech, you may need to update it for your dataset
min_duration: 0.1
# tarred datasets
is_tarred: false
tarred_audio_filepaths: null
shuffle_n: 2048
# bucketing params
bucketing_strategy: "fully_randomized"
bucketing_batch_size: null
validation_ds:
manifest_filepath: ft_eval_data.json
sample_rate: ${model.sample_rate}
batch_size: 25 # you may increase batch_size if your memory allows
shuffle: false
use_start_end_token: false
num_workers: 8
pin_memory: true
test_ds:
manifest_filepath: null
sample_rate: ${model.sample_rate}
batch_size: 16 # you may increase batch_size if your memory allows
shuffle: false
use_start_end_token: false
num_workers: 8
pin_memory: true
# recommend vocab size of 128 or 256 when training on ~1k hr datasets and 1k vocab size on 10+k hr datasets
# you may find more detail on how to train a tokenizer at: /scripts/tokenizers/process_asr_text_tokenizer.py
tokenizer:
dir: fine_tuning/tokenizers/tokenizer_spe_unigram_v128 # path to directory which contains either tokenizer.model (bpe) or vocab.txt (wpe)
type: bpe # Can be either bpe (SentencePiece tokenizer) or wpe (WordPiece tokenizer)
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
sample_rate: ${model.sample_rate}
normalize: "per_feature"
window_size: 0.025
window_stride: 0.01
window: "hann"
features: 80
n_fft: 512
log: true
frame_splicing: 1
dither: 0.00001
pad_to: 0
pad_value: 0.0
spec_augment:
_target_: nemo.collections.asr.modules.SpectrogramAugmentation
freq_masks: 2 # set to zero to disable it
# you may use lower time_masks for smaller models to have a faster convergence
time_masks: 10 # set to zero to disable it
freq_width: 27
time_width: 0.05
encoder:
_target_: nemo.collections.asr.modules.ConformerEncoder
feat_in: ${model.preprocessor.features}
feat_out: -1 # you may set it if you need different output size other than the default d_model
n_layers: 24
d_model: 1024
use_bias: True # whether to apply bias in the feedforward, MHA and convolution modules
# Sub-sampling params
subsampling: dw_striding # vggnet, striding, stacking or stacking_norm, dw_striding
subsampling_factor: 8 # must be power of 2 for striding and vggnet
subsampling_conv_channels: 256 # -1 sets it to d_model
causal_downsampling: false
# Feed forward module's params
ff_expansion_factor: 4
self_attention_model: rel_pos_local_attn # longformer-style attention (sliding window + global tokens)
global_tokens: 1 # number of tokens that attend and are attended to by all tokens (put 0 to disable)
global_tokens_spacing: 1 # how far apart the global tokens are
global_attn_separate: false # whether global tokens should use separate q,k,v layers
n_heads: 8 # may need to be lower for smaller d_models
# [left, right] specifies the number of steps to be seen from left and right of each step in self-attention
att_context_size: [128,128] # -1 means unlimited context
att_context_style: regular # regular or chunked_limited
xscaling: False # scales up the input embeddings by sqrt(d_model)
untie_biases: true # unties the biases of the TransformerXL layers
# Convolution module's params
conv_kernel_size: 9
conv_norm_type: 'batch_norm' # batch_norm or layer_norm or groupnormN (N specifies the number of groups)
# conv_context_size can be"causal" or a list of two integers while conv_context_size[0]+conv_context_size[1]+1==conv_kernel_size
# null means [(kernel_size-1)//2, (kernel_size-1)//2], and 'causal' means [(kernel_size-1), 0]
conv_context_size: null
### regularization
dropout: 0.1 # The dropout used in most of the Conformer Modules
dropout_pre_encoder: 0.1 # The dropout used before the encoder
dropout_emb: 0.0 # The dropout used for embeddings
dropout_att: 0.1 # The dropout for multi-headed attention modules
# set to non-zero to enable stochastic depth
stochastic_depth_drop_prob: 0.0
stochastic_depth_mode: linear # linear or uniform
stochastic_depth_start_layer: 1
decoder:
_target_: nemo.collections.asr.modules.ConvASRDecoder
feat_in: null
num_classes: -1
vocabulary: []
# config for InterCTC loss: https://arxiv.org/abs/2102.03216
# specify loss weights and which layers to use for InterCTC
# e.g., to reproduce the paper results, set loss_weights: [0.3]
# and apply_at_layers: [8] (assuming 18 layers). Note that final
# layer loss coefficient is automatically adjusted (to 0.7 in above example)
interctc:
loss_weights: []
apply_at_layers: []
optim:
name: adamw
lr: 1e-3
# optimizer arguments
betas: [0.9, 0.98]
# less necessity for weight_decay as we already have large augmentations with SpecAug
# you may need weight_decay for large models, stable AMP training, small datasets, or when lower augmentations are used
# weight decay of 0.0 with lr of 2.0 also works fine
weight_decay: 1e-3
# scheduler setup
sched:
name: CosineAnnealing
# scheduler config override
warmup_steps: 15000
warmup_ratio: null
min_lr: 1e-4
trainer:
devices: -1 # number of GPUs, -1 would use all available GPUs
num_nodes: 1
max_epochs: 1000
max_steps: -1 # computed at runtime if not set
val_check_interval: 1.0 # Set to 0.25 to check 4 times per epoch, or an int for number of iterations
accelerator: auto
strategy: ddp
accumulate_grad_batches: 41
gradient_clip_val: 0.0
precision: bf16 # 16, 32, or bf16
log_every_n_steps: 10 # Interval of logging.
enable_progress_bar: True
num_sanity_val_steps: 0 # number of steps to perform validation steps for sanity check the validation process before starting the training, setting to 0 disables it
check_val_every_n_epoch: 1 # number of evaluations on validation every n epochs
sync_batchnorm: true
enable_checkpointing: False # Provided by exp_manager
logger: false # Provided by exp_manager
benchmark: false # needs to be false for models with variable-length speech input as it slows down training
exp_manager:
exp_dir: null
name: ${name}
create_tensorboard_logger: true
create_checkpoint_callback: true
checkpoint_callback_params:
# in case of multiple validation sets, first one is used
monitor: "val_wer"
mode: "min"
save_top_k: 5
always_save_nemo: True # saves the checkpoints as nemo files instead of PTL checkpoints
resume_from_checkpoint: null # The path to a checkpoint file to continue the training, restores the whole state including the epoch, step, LR schedulers, apex, etc.
# you need to set these two to True to continue the training
resume_if_exists: false
resume_ignore_no_checkpoint: false
# You may use this section to create a W&B logger
create_wandb_logger: false
wandb_logger_kwargs:
name: null
project: null
```
but the model does not converge. these are the results:
I tried different learning rates with warmup_steps set to null and a ratio of 0.1, but the loss exploded earlier than it did with the default configuration parameters.
this is how I run fine-tuning:
```python3
import pytorch_lightning as pl
from omegaconf import OmegaConf
from nemo.utils.exp_manager import exp_manager
from nemo.collections.asr.losses.ctc import CTCLoss
import os
cfg = OmegaConf.load('fine_tuning/configs/fastconf_xlrage_long.yaml')
cfg = OmegaConf.to_container(cfg, resolve=True)
cfg = OmegaConf.create(cfg)
from nemo.collections.asr.models import EncDecCTCModelBPE
trainer = pl.Trainer(**cfg.trainer)
exp_manager(trainer, cfg.get("exp_manager", None))
asr_model = EncDecCTCModelBPE(cfg=cfg.model, trainer=trainer)
asr_model.maybe_init_from_pretrained_checkpoint(cfg)
trainer.fit(asr_model)
```
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11894/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11894/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11893 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11893/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11893/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11893/events | https://github.com/NVIDIA/NeMo/pull/11893 | 2,797,494,623 | PR_kwDOC_bI7s6IQxR- | 11,893 | [DRAFT]: Add checkpointing for FSDP2 | {
"login": "yuanzhedong",
"id": 5069709,
"node_id": "MDQ6VXNlcjUwNjk3MDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5069709?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yuanzhedong",
"html_url": "https://github.com/yuanzhedong",
"followers_url": "https://api.github.com/users/yuanzhedong/followers",
"following_url": "https://api.github.com/users/yuanzhedong/following{/other_user}",
"gists_url": "https://api.github.com/users/yuanzhedong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yuanzhedong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yuanzhedong/subscriptions",
"organizations_url": "https://api.github.com/users/yuanzhedong/orgs",
"repos_url": "https://api.github.com/users/yuanzhedong/repos",
"events_url": "https://api.github.com/users/yuanzhedong/events{/privacy}",
"received_events_url": "https://api.github.com/users/yuanzhedong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:60:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/peft/hf.py:95:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/sft/hf.py:71:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/sft/hf.py:137:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/sft/hf.py:67:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.63/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.strategies.fsdp2_strategy\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:98:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:129:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:159:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:168:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:186:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:194:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:215:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.33/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-19T08:16:59 | 2025-01-19T08:18:12 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11893",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11893",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11893.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11893.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11893/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11893/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11892 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11892/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11892/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11892/events | https://github.com/NVIDIA/NeMo/pull/11892 | 2,797,464,040 | PR_kwDOC_bI7s6IQrIK | 11,892 | chore(beep boop 🤖): Bump `MCORE_TAG=7ba0d6d...` (2025-01-19) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12851214361) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-19T06:44:28 | 2025-01-19T09:13:46 | 2025-01-19T09:13:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11892",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11892",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11892.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11892.patch",
"merged_at": "2025-01-19T09:13:45"
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=7ba0d6ddaab1e4d1c587af8fea8a0dfe13b20f13`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11892/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11892/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11891 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11891/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11891/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11891/events | https://github.com/NVIDIA/NeMo/pull/11891 | 2,797,463,769 | PR_kwDOC_bI7s6IQrE5 | 11,891 | chore: Update mcore-tag-bump-bot.yml | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-19T06:43:40 | 2025-01-19T06:43:51 | 2025-01-19T06:43:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11891",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11891",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11891.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11891.patch",
"merged_at": "2025-01-19T06:43:50"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11891/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11891/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11890 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11890/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11890/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11890/events | https://github.com/NVIDIA/NeMo/pull/11890 | 2,797,373,856 | PR_kwDOC_bI7s6IQYiG | 11,890 | check restore_config first | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.resume\nnemo/lightning/resume.py:99:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/resume.py:102:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/resume.py:265:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/resume.py:278:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.77/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12850090296) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-19T02:43:11 | 2025-01-20T19:14:06 | 2025-01-20T19:14:04 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11890",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11890",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11890.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11890.patch",
"merged_at": "2025-01-20T19:14:04"
} | # What does this PR do ?
`_find_trainer_ckpt_path` crashes if it restores from an imported ckpt with a restore config.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11890/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11890/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11889 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11889/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11889/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11889/events | https://github.com/NVIDIA/NeMo/pull/11889 | 2,797,169,075 | PR_kwDOC_bI7s6IPst2 | 11,889 | ci: Set bump-branch to weekly | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-18T20:32:49 | 2025-01-18T20:33:07 | 2025-01-18T20:33:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11889",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11889",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11889.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11889.patch",
"merged_at": "2025-01-18T20:33:06"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11889/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11889/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11888 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11888/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11888/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11888/events | https://github.com/NVIDIA/NeMo/pull/11888 | 2,796,512,170 | PR_kwDOC_bI7s6INie0 | 11,888 | chore(beep boop 🤖): Bump `MCORE_TAG=c7bf403...` (2025-01-18) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12846160709) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12846160709) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-18T00:21:14 | 2025-01-18T21:08:59 | 2025-01-18T21:08:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11888",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11888",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11888.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11888.patch",
"merged_at": "2025-01-18T21:08:58"
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=c7bf403ba37ce7ca739a025accac232c75a38966`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11888/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11888/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11887 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11887/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11887/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11887/events | https://github.com/NVIDIA/NeMo/pull/11887 | 2,796,393,587 | PR_kwDOC_bI7s6INIlw | 11,887 | replaced classification model with EncDecSpeakerLabelModel | {
"login": "Ssofja",
"id": 78349198,
"node_id": "MDQ6VXNlcjc4MzQ5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/78349198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ssofja",
"html_url": "https://github.com/Ssofja",
"followers_url": "https://api.github.com/users/Ssofja/followers",
"following_url": "https://api.github.com/users/Ssofja/following{/other_user}",
"gists_url": "https://api.github.com/users/Ssofja/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ssofja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ssofja/subscriptions",
"organizations_url": "https://api.github.com/users/Ssofja/orgs",
"repos_url": "https://api.github.com/users/Ssofja/repos",
"events_url": "https://api.github.com/users/Ssofja/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ssofja/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.classification_models\nnemo/collections/asr/models/classification_models.py:381:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:516:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:726:0: C0301: Line too long (163/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:727:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:938:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:939:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:940:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:941:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:942:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:1034:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:49:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/models/classification_models.py:57:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/models/classification_models.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:488:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/models/classification_models.py:613:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:631:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:640:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:708:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/models/classification_models.py:818:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:43:0: W0611: Unused deprecated imported from nemo.utils.decorators (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.61/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-17T22:15:58 | 2025-01-17T22:40:10 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11887",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11887",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11887.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11887.patch",
"merged_at": null
} | # What does this PR do ?
This PR Replaced ASR classification model with EncDecSpeakerLabelModel without a need to change a lot of code parts
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
**PR Type**:
- [x] Refactoring
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11887/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11887/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11886 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11886/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11886/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11886/events | https://github.com/NVIDIA/NeMo/pull/11886 | 2,796,250,762 | PR_kwDOC_bI7s6IMozM | 11,886 | Update PyTorch-cuda version in readme | {
"login": "yulianazamora",
"id": 153561129,
"node_id": "U_kgDOCScoKQ",
"avatar_url": "https://avatars.githubusercontent.com/u/153561129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yulianazamora",
"html_url": "https://github.com/yulianazamora",
"followers_url": "https://api.github.com/users/yulianazamora/followers",
"following_url": "https://api.github.com/users/yulianazamora/following{/other_user}",
"gists_url": "https://api.github.com/users/yulianazamora/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yulianazamora/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yulianazamora/subscriptions",
"organizations_url": "https://api.github.com/users/yulianazamora/orgs",
"repos_url": "https://api.github.com/users/yulianazamora/repos",
"events_url": "https://api.github.com/users/yulianazamora/events{/privacy}",
"received_events_url": "https://api.github.com/users/yulianazamora/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-17T20:34:54 | 2025-01-17T20:34:54 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11886",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11886",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11886.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11886.patch",
"merged_at": null
} |
# What does this PR do ?
Updating pytorch-cuda version to 12.1 as shown in https://docs.nvidia.com/nemo-framework/user-guide/latest/installation.html
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [X] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [X] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11886/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11886/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11885 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11885/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11885/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11885/events | https://github.com/NVIDIA/NeMo/pull/11885 | 2,795,589,222 | PR_kwDOC_bI7s6IKYTC | 11,885 | ci: Prune dangling images | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-17T14:17:38 | 2025-01-17T14:17:53 | 2025-01-17T14:17:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11885",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11885",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11885.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11885.patch",
"merged_at": "2025-01-17T14:17:46"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11885/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11885/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11884 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11884/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11884/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11884/events | https://github.com/NVIDIA/NeMo/pull/11884 | 2,795,452,320 | PR_kwDOC_bI7s6IJ6Lu | 11,884 | chore: Weekly bump (2025-cw03) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12830688590) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron.falcon.falcon_decoder_layer\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:70:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:102:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:18:4: W0611: Unused parallel_state imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:19:4: W0611: Unused ShardedObject imported from megatron.core.dist_checkpointing.mapping (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:19:4: W0611: Unused ShardedTensor imported from megatron.core.dist_checkpointing.mapping (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron.gpt_full_te_layer_autocast_spec\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:51:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:147:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:179:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:337:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.megatron.adapters.mcore_mixins\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:141:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:143:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:60:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:69:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:109:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:227:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:335:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:445:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:452:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:476:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:483:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:501:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:508:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.39/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-17T13:12:23 | 2025-01-20T10:06:25 | 2025-01-20T10:06:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11884",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11884",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11884.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11884.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11884/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11884/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11883 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11883/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11883/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11883/events | https://github.com/NVIDIA/NeMo/pull/11883 | 2,795,357,995 | PR_kwDOC_bI7s6IJlbt | 11,883 | fix: correct signal for Windows | {
"login": "maxstrobel",
"id": 34747372,
"node_id": "MDQ6VXNlcjM0NzQ3Mzcy",
"avatar_url": "https://avatars.githubusercontent.com/u/34747372?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maxstrobel",
"html_url": "https://github.com/maxstrobel",
"followers_url": "https://api.github.com/users/maxstrobel/followers",
"following_url": "https://api.github.com/users/maxstrobel/following{/other_user}",
"gists_url": "https://api.github.com/users/maxstrobel/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maxstrobel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxstrobel/subscriptions",
"organizations_url": "https://api.github.com/users/maxstrobel/orgs",
"repos_url": "https://api.github.com/users/maxstrobel/repos",
"events_url": "https://api.github.com/users/maxstrobel/events{/privacy}",
"received_events_url": "https://api.github.com/users/maxstrobel/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.utils.exp_manager\nnemo/utils/exp_manager.py:353:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:378:0: C0301: Line too long (124/119) (line-too-long)\nnemo/utils/exp_manager.py:382:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:387:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:401:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:408:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:409:0: C0301: Line too long (126/119) (line-too-long)\nnemo/utils/exp_manager.py:411:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:413:0: C0301: Line too long (139/119) (line-too-long)\nnemo/utils/exp_manager.py:423:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:424:0: C0301: Line too long (128/119) (line-too-long)\nnemo/utils/exp_manager.py:425:0: C0301: Line too long (132/119) (line-too-long)\nnemo/utils/exp_manager.py:426:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:514:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:602:0: C0301: Line too long (208/119) (line-too-long)\nnemo/utils/exp_manager.py:603:0: C0301: Line too long (230/119) (line-too-long)\nnemo/utils/exp_manager.py:605:0: C0301: Line too long (178/119) (line-too-long)\nnemo/utils/exp_manager.py:642:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:777:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:785:0: C0301: Line too long (156/119) (line-too-long)\nnemo/utils/exp_manager.py:832:0: C0301: Line too long (141/119) (line-too-long)\nnemo/utils/exp_manager.py:840:0: C0301: Line too long (152/119) (line-too-long)\nnemo/utils/exp_manager.py:1110:0: C0301: Line too long (142/119) (line-too-long)\nnemo/utils/exp_manager.py:1134:0: C0301: Line too long (154/119) (line-too-long)\nnemo/utils/exp_manager.py:1200:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:1219:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:1245:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:91:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:106:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:132:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:141:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:150:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:161:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:277:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:286:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:333:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:336:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:339:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1126:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1227:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1246:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1249:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1265:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.19/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-17T12:22:32 | 2025-01-20T13:38:19 | 2025-01-20T13:38:19 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11883",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11883",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11883.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11883.patch",
"merged_at": null
} | Windows uses `signal.SIGTERM` instead of `signal.SIGKILL`.
# What does this PR do ?
Fixes wrong signal under Windows.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Fixes wrong signal under Windows.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
@BBC-Esq @titu1994 @blisc @okuchaiev
# Additional Information
* Related to #10275
| {
"login": "maxstrobel",
"id": 34747372,
"node_id": "MDQ6VXNlcjM0NzQ3Mzcy",
"avatar_url": "https://avatars.githubusercontent.com/u/34747372?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maxstrobel",
"html_url": "https://github.com/maxstrobel",
"followers_url": "https://api.github.com/users/maxstrobel/followers",
"following_url": "https://api.github.com/users/maxstrobel/following{/other_user}",
"gists_url": "https://api.github.com/users/maxstrobel/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maxstrobel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxstrobel/subscriptions",
"organizations_url": "https://api.github.com/users/maxstrobel/orgs",
"repos_url": "https://api.github.com/users/maxstrobel/repos",
"events_url": "https://api.github.com/users/maxstrobel/events{/privacy}",
"received_events_url": "https://api.github.com/users/maxstrobel/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11883/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11883/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11882 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11882/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11882/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11882/events | https://github.com/NVIDIA/NeMo/pull/11882 | 2,795,025,900 | PR_kwDOC_bI7s6IIbJy | 11,882 | build: Add `sox` to SDE | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"@vsl9 @ekmb could you please review and approve this PR? thanks!"
] | 2025-01-17T09:52:50 | 2025-01-17T21:00:38 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11882",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11882",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11882.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11882.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11882/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11882/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11881 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11881/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11881/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11881/events | https://github.com/NVIDIA/NeMo/pull/11881 | 2,794,595,256 | PR_kwDOC_bI7s6IG9cj | 11,881 | KV-cache for T5 model | {
"login": "YK-Fu",
"id": 69422562,
"node_id": "MDQ6VXNlcjY5NDIyNTYy",
"avatar_url": "https://avatars.githubusercontent.com/u/69422562?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/YK-Fu",
"html_url": "https://github.com/YK-Fu",
"followers_url": "https://api.github.com/users/YK-Fu/followers",
"following_url": "https://api.github.com/users/YK-Fu/following{/other_user}",
"gists_url": "https://api.github.com/users/YK-Fu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/YK-Fu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/YK-Fu/subscriptions",
"organizations_url": "https://api.github.com/users/YK-Fu/orgs",
"repos_url": "https://api.github.com/users/YK-Fu/repos",
"events_url": "https://api.github.com/users/YK-Fu/events{/privacy}",
"received_events_url": "https://api.github.com/users/YK-Fu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [] | 2025-01-17T05:15:00 | 2025-01-17T05:16:46 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11881",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11881",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11881.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11881.patch",
"merged_at": null
} | # What does this PR do?
Improve the T5 generation related issues and T5 attention mask bugs. This PR should be used with https://github.com/NVIDIA/Megatron-LM/pull/1358
**Collection**: nlp T5
# Changelog
- Add kv-cache mechanism for Megatron-core T5 model.
- Fix the attention mask bugs for Megatron-core local implementations (when mcore_t5 is true, and transformer_engine is False)
- Improve the generation of T5 to be better aligned with that in GPT
# Usage
* Implement kv-cache in generation of T5, improving its efficiency
* Fix local mcore t5 model attention mask bugs (not from transformer_engine)
* In original T5 decode method, you can only generate fix length sequence, even when the EOS token is generated, it will still generate tokens until the predefined number of tokens are reached, which is very inconvenience and inefficient. This pull request raise enables variable length generation.
```python
python examples/nlp/language_modeling/tuning/megatron_gpt_finetuning.py <datasets and checkpoints override>
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11881/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11881/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11880 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11880/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11880/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11880/events | https://github.com/NVIDIA/NeMo/pull/11880 | 2,794,572,030 | PR_kwDOC_bI7s6IG4bg | 11,880 | [MoE] add expert tensor parallelism support for NeMo2.0 MoE | {
"login": "gdengk",
"id": 160076886,
"node_id": "U_kgDOCYqUVg",
"avatar_url": "https://avatars.githubusercontent.com/u/160076886?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gdengk",
"html_url": "https://github.com/gdengk",
"followers_url": "https://api.github.com/users/gdengk/followers",
"following_url": "https://api.github.com/users/gdengk/following{/other_user}",
"gists_url": "https://api.github.com/users/gdengk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gdengk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gdengk/subscriptions",
"organizations_url": "https://api.github.com/users/gdengk/orgs",
"repos_url": "https://api.github.com/users/gdengk/repos",
"events_url": "https://api.github.com/users/gdengk/events{/privacy}",
"received_events_url": "https://api.github.com/users/gdengk/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.multimodal.models.vision_language_foundation.clip.megatron_clip_models\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:667:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:671:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:723:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:939:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1405:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1420:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1435:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:169:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:281:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:323:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:337:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:382:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:391:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:413:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:422:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:438:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:448:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:468:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:572:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:877:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:881:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:935:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1158:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1192:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1198:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1220:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1310:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1313:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1317:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1444:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py:1480:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_lm_encoder_decoder_model\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:102:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:138:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:231:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:253:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:261:0: C0301: Line too long (180/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:263:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:537:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:562:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:563:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:579:0: C0301: Line too long (180/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:619:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:647:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:648:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:800:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:924:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:992:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:993:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1162:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1228:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1235:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1248:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1351:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1353:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1355:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1356:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1358:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1359:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1396:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1422:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1715:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1743:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:258:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:349:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:519:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:560:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:661:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:904:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1045:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1172:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1202:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.core.optim.optimizer_with_main_params\nnemo/core/optim/optimizer_with_main_params.py:91:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/optim/optimizer_with_main_params.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/core/optim/optimizer_with_main_params.py:195:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/optim/optimizer_with_main_params.py:200:0: C0301: Line too long (149/119) (line-too-long)\nnemo/core/optim/optimizer_with_main_params.py:149:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:403:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:446:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:450:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:471:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:477:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:497:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:513:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:517:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:520:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning._strategy_lib\nnemo/lightning/_strategy_lib.py:577:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/_strategy_lib.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/_strategy_lib.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:143:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:170:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:206:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:519:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:602:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:615:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.megatron_init\nnemo/lightning/megatron_init.py:269:0: C0301: Line too long (122/119) (line-too-long)\nnemo/lightning/megatron_init.py:270:0: C0301: Line too long (133/119) (line-too-long)\nnemo/lightning/megatron_init.py:271:0: C0301: Line too long (121/119) (line-too-long)\nnemo/lightning/megatron_init.py:374:0: C0301: Line too long (166/119) (line-too-long)\nnemo/lightning/megatron_init.py:88:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:290:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.utils.app_state\nnemo/utils/app_state.py:440:0: C0301: Line too long (138/119) (line-too-long)\nnemo/utils/app_state.py:448:0: C0301: Line too long (135/119) (line-too-long)\nnemo/utils/app_state.py:23:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/app_state.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/app_state.py:255:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:708:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:718:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:727:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:732:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:738:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:746:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:754:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.61/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-17T04:52:49 | 2025-01-17T18:50:55 | null | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11880",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11880",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11880.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11880.patch",
"merged_at": null
} | # What does this PR do ?
add expert tensor parallelism support for NeMo2.0 MoE and substitute get_data_modulo_expert_parallel_group with get_expert_data_parallel_group since the former one is going to be deprecated.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11880/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11880/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11879 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11879/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11879/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11879/events | https://github.com/NVIDIA/NeMo/pull/11879 | 2,794,098,369 | PR_kwDOC_bI7s6IFNJg | 11,879 | chore(beep boop 🤖): Bump `MCORE_TAG=e5793c0...` (2025-01-17) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron.falcon.falcon_decoder_layer\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:70:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:102:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:18:4: W0611: Unused parallel_state imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:19:4: W0611: Unused ShardedObject imported from megatron.core.dist_checkpointing.mapping (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:19:4: W0611: Unused ShardedTensor imported from megatron.core.dist_checkpointing.mapping (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron.gpt_full_te_layer_autocast_spec\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:51:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:147:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:179:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:337:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.megatron.adapters.mcore_mixins\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:141:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:143:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:60:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:69:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:109:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:227:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:335:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:445:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:452:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:476:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:483:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:501:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:508:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.39/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12842612778) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-17T00:22:04 | 2025-01-18T17:36:59 | 2025-01-18T17:36:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11879",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11879",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11879.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11879.patch",
"merged_at": "2025-01-18T17:36:57"
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=e5793c07227d346d6c644779005f179be12f6895`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11879/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11879/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11878 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11878/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11878/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11878/events | https://github.com/NVIDIA/NeMo/pull/11878 | 2,794,010,449 | PR_kwDOC_bI7s6IE5UY | 11,878 | Disable tests that download datasets from web | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12823805985) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-16T23:30:19 | 2025-01-17T16:58:15 | 2025-01-17T16:58:13 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11878",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11878",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11878.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11878.patch",
"merged_at": "2025-01-17T16:58:13"
} | # What does this PR do ?
Disable tests that download datasets from the web to avoid unstable tests (e.g. remote host goes down).
TODO: store dataset locally.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11878/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11878/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11877 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11877/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11877/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11877/events | https://github.com/NVIDIA/NeMo/pull/11877 | 2,793,932,229 | PR_kwDOC_bI7s6IEnxp | 11,877 | Turn on trust_remote_code if self.trust_remote_code is True or arg is… | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:63:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:130:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:150:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.02/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:63:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:130:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:150:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.02/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-16T22:45:00 | 2025-01-19T02:07:28 | null | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11877",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11877",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11877.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11877.patch",
"merged_at": null
} | … True
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11877/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11877/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11876 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11876/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11876/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11876/events | https://github.com/NVIDIA/NeMo/pull/11876 | 2,793,723,787 | PR_kwDOC_bI7s6ID5dg | 11,876 | Add sharding for speechlm and vlm | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"I will add SpeechLM fsdp2 ci tesst once the speechlm ci test is ready",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.speechlm.models.hf_auto_model_for_speech_seq2seq\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:82:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:129:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.39/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.strategies.utils\nnemo/lightning/pytorch/strategies/utils.py:40:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/strategies/utils.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:142:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:197:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.61/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @BoxiangW 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12819800988) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-16T20:37:31 | 2025-01-17T22:15:10 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11876",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11876",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11876.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11876.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11876/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11876/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11875 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11875/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11875/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11875/events | https://github.com/NVIDIA/NeMo/pull/11875 | 2,793,711,079 | PR_kwDOC_bI7s6ID2qB | 11,875 | Add SpeechLM and VLM fsdp2 sharding support in nemo automodel | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.gemma\nnemo/collections/llm/gpt/model/gemma.py:40:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:59:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:68:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:76:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:80:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:84:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:104:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:143:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:175:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:194:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:207:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:211:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_base_model\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:103:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:111:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:254:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:272:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:347:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:607:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:662:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:834:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:972:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:991:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1108:0: C0301: Line too long (195/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1165:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1214:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1297:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:331:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:462:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:467:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:700:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:752:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:933:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1037:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1272:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1303:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1311:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_retro_model\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:36:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:142:0: C0301: Line too long (191/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:304:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:335:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:386:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:441:0: C0301: Line too long (206/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:451:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:458:0: C0301: Line too long (210/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:462:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:15:0: W0611: Unused import itertools (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:18:0: W0611: Unused import queue (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:20:0: W0611: Unused import warnings (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:21:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Iterator imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused List imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Union imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:26:0: W0611: Unused CPUAccelerator imported from lightning.pytorch.accelerators (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:38:0: W0611: Unused MegatronBaseModel imported from nemo.collections.nlp.models.language_modeling.megatron_base_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:40:0: W0611: Unused build_model imported from nemo.collections.nlp.modules.common.megatron.build_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:41:0: W0611: Unused Float16Module imported from nemo.collections.nlp.modules.common.megatron.module (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_all_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_ltor_masks_and_position_ids imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:49:0: W0611: Unused TextGenerationStrategy imported from nemo.collections.nlp.modules.common.text_generation_strategy (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_length_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_sampling_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused megatron_gpt_generate imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused LengthParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused OutputType imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused SamplingParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused TextGeneration imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:63:0: W0611: Unused utils_funcs imported from nemo.collections.nlp.parts (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused get_last_rank imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:65:0: W0611: Unused Exportable imported from nemo.core.classes (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:66:0: W0611: Unused PretrainedModelInfo imported from nemo.core.classes.common (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused ChannelType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused NeuralType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:72:4: W0611: Unused InferenceParams imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:80:4: W0611: Unused TransformerConfig imported from megatron.core.transformer.transformer_config (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:81:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:81:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module nemo.lightning.pytorch.strategies.utils\nnemo/lightning/pytorch/strategies/utils.py:40:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/strategies/utils.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:142:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:197:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.checkpoint_converters.convert_bert_hf_to_nemo\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:65:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:79:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.45/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/speechlm/sft/hf.py:29:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.speechlm.models.hf_auto_model_for_speech_seq2seq\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:82:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:129:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.76/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"Closing this in favor of https://github.com/NVIDIA/NeMo/pull/11876"
] | 2025-01-16T20:29:07 | 2025-01-16T20:37:58 | 2025-01-16T20:37:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11875",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11875",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11875.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11875.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11875/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11875/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11874 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11874/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11874/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11874/events | https://github.com/NVIDIA/NeMo/pull/11874 | 2,793,409,413 | PR_kwDOC_bI7s6ICz34 | 11,874 | Fix nemo 1 packed sequence TE version error | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"Is this a safe hacking? wouldn't this impact functionality if you override `cu_seqlens_unpadded`?",
"> Is this a safe hacking? wouldn't this impact functionality if you override `cu_seqlens_unpadded`?\r\n\r\nTested in the case of CP=1 this is fine. Not confident about CP>1. Do you have suggestions on how to tackle CP>1?",
"I am thinking shouldn't we fix `PackedSeqParams` in NeMo2.0 and make it same as NeMo1.0 ?\r\n@tomlifu , I remember you tested `cu_seqlens_unpadded != cu_seqlens` with TE < 1.13?",
"Yes, I tested cu_seqlens_unpadded != cu_seqlens with TE < 1.13 and it works. I don't think I used TE 1.13 at all.",
"> I am thinking shouldn't we fix `PackedSeqParams` in NeMo2.0 and make it same as NeMo1.0 ?\r\n\r\nCertainly. The current PR just fixes a bug in nemo 1. We will propagate the change to nemo 2 in a future PR.\r\n",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron_gpt_model\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:334:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:374:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:420:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:467:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:801:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1116:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1137:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1347:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1398:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1455:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1637:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1638:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1640:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1812:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1832:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1840:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1861:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1931:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1958:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:141:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:154:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:180:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:199:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:252:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:290:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:294:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:314:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:476:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:479:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:711:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:715:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:797:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1187:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1236:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1265:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1468:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1604:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1612:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1621:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1906:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2059:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2066:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2072:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:20:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:28:0: W0611: Unused _DataFetcherWrapper imported from lightning.pytorch.loops.fetchers (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:30:0: W0611: Unused OmegaConf imported from omegaconf (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:72:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:81:4: W0611: Unused megatron.core imported as core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:82:4: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.50/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12838024270) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-16T17:58:44 | 2025-01-18T11:44:07 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11874",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11874",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11874.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11874.patch",
"merged_at": null
} | # What does this PR do ?
Adds a te version guard for packed sequence in NeMo 1 (NeMo 2 is unaffected)
Changes in #10688 should be paired with TE version >1.3
https://github.com/NVIDIA/TransformerEngine/blob/3d63cbb469ace2d1ad7798a956e16dee42bd655b/transformer_engine/pytorch/attention.py#L8179-L8185
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11874/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11874/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11873 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11873/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11873/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11873/events | https://github.com/NVIDIA/NeMo/pull/11873 | 2,793,345,351 | PR_kwDOC_bI7s6ICl1H | 11,873 | surface attn_implementation option | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:136:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:156:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.03/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:136:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:156:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.03/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12841592043) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-16T17:24:24 | 2025-01-19T02:11:42 | 2025-01-19T02:11:40 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11873",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11873",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11873.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11873.patch",
"merged_at": "2025-01-19T02:11:40"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11873/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11873/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11872 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11872/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11872/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11872/events | https://github.com/NVIDIA/NeMo/pull/11872 | 2,793,304,973 | PR_kwDOC_bI7s6ICc9- | 11,872 | [DRAFT] Fix BERT1 Dependency | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [] | 2025-01-16T17:03:59 | 2025-01-16T17:04:11 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11872",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11872",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11872.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11872.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11872/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11872/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11871 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11871/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11871/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11871/events | https://github.com/NVIDIA/NeMo/issues/11871 | 2,792,675,636 | I_kwDOC_bI7s6mdNk0 | 11,871 | megatron version requirement | {
"login": "Cppowboy",
"id": 7080798,
"node_id": "MDQ6VXNlcjcwODA3OTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7080798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Cppowboy",
"html_url": "https://github.com/Cppowboy",
"followers_url": "https://api.github.com/users/Cppowboy/followers",
"following_url": "https://api.github.com/users/Cppowboy/following{/other_user}",
"gists_url": "https://api.github.com/users/Cppowboy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Cppowboy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Cppowboy/subscriptions",
"organizations_url": "https://api.github.com/users/Cppowboy/orgs",
"repos_url": "https://api.github.com/users/Cppowboy/repos",
"events_url": "https://api.github.com/users/Cppowboy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Cppowboy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2025-01-16T12:55:06 | 2025-01-16T13:07:10 | 2025-01-16T13:07:10 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | ```
Traceback (most recent call last):
File "/user/panyinxu/workspace/NeMo-Aligner/examples/nlp/minicpm/train_minicpm3_4b_longrope_dpo.py", line 164, in <module>
main()
File "/user/panyinxu/workspace/NeMo/nemo/core/config/hydra_runner.py", line 129, in wrapper
_run_hydra(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 394, in _run_hydra
_run_app(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 457, in _run_app
run_and_report(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 223, in run_and_report
raise ex
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 220, in run_and_report
return func()
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 458, in <lambda>
lambda: hydra.run(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/hydra.py", line 132, in run
_ = ret.return_value
File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 260, in return_value
raise self._return_value
File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 186, in run_job
ret.return_value = task_function(task_cfg)
File "/user/panyinxu/workspace/NeMo-Aligner/examples/nlp/minicpm/train_minicpm3_4b_longrope_dpo.py", line 56, in main
ptl_model = load_from_nemo(
File "/user/panyinxu/workspace/NeMo-Aligner/nemo_aligner/utils/utils.py", line 118, in load_from_nemo
model = cls.restore_from(
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/models/nlp_model.py", line 493, in restore_from
return super().restore_from(
File "/user/panyinxu/workspace/NeMo/nemo/core/classes/modelPT.py", line 474, in restore_from
instance = cls._save_restore_connector.restore_from(
File "/user/panyinxu/workspace/NeMo-Aligner/nemo_aligner/utils/utils.py", line 56, in restore_from
return super().restore_from(*args, replace_sharded_tensor_key=self.__replace_sharded_tensor_key, **kwargs)
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/parts/nlp_overrides.py", line 1304, in restore_from
loaded_params = super().load_config_and_state_dict(
File "/user/panyinxu/workspace/NeMo/nemo/core/connectors/save_restore_connector.py", line 182, in load_config_and_state_dict
instance = calling_cls.from_config_dict(config=conf, trainer=trainer)
File "/user/panyinxu/workspace/NeMo/nemo/core/classes/common.py", line 530, in from_config_dict
raise e
File "/user/panyinxu/workspace/NeMo/nemo/core/classes/common.py", line 522, in from_config_dict
instance = cls(cfg=config, trainer=trainer)
File "/user/panyinxu/workspace/NeMo-Aligner/nemo_aligner/models/nlp/gpt/megatron_gpt_dpo_model.py", line 54, in __init__
super().__init__(cfg, trainer=trainer)
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py", line 88, in __init__
super().__init__(*args, **kwargs)
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 402, in __init__
self.model = build_model(
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/modules/common/megatron/build_model.py", line 90, in build_model
model = model_provider_func(
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 484, in model_provider_func
transformer_layer_spec=get_specs(
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 172, in get_specs
"modelopt": get_gpt_layer_modelopt_spec(num_experts),
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py", line 50, in get_gpt_layer_modelopt_spec
raise IMPORT_ERROR
File "/user/panyinxu/workspace/NeMo/nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py", line 23, in <module>
from megatron.core.transformer.moe.moe_layer import MoELayer, MoESubmodules
ImportError: cannot import name 'MoESubmodules' from 'megatron.core.transformer.moe.moe_layer' (/user/panyinxu/workspace/Megatron-LM/megatron/core/transformer/moe/moe_layer.py)
```
I am currently using NeMo==2.1.0 and NeMo-Aligner==0.6.0. It appears that there is an issue with Megatron version compatibility. Which version of Megatron do I need? | {
"login": "Cppowboy",
"id": 7080798,
"node_id": "MDQ6VXNlcjcwODA3OTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7080798?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Cppowboy",
"html_url": "https://github.com/Cppowboy",
"followers_url": "https://api.github.com/users/Cppowboy/followers",
"following_url": "https://api.github.com/users/Cppowboy/following{/other_user}",
"gists_url": "https://api.github.com/users/Cppowboy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Cppowboy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Cppowboy/subscriptions",
"organizations_url": "https://api.github.com/users/Cppowboy/orgs",
"repos_url": "https://api.github.com/users/Cppowboy/repos",
"events_url": "https://api.github.com/users/Cppowboy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Cppowboy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11871/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11871/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11870 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11870/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11870/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11870/events | https://github.com/NVIDIA/NeMo/pull/11870 | 2,792,593,825 | PR_kwDOC_bI7s6H__SF | 11,870 | fix convert_llama_hf_to_nemo.py llama31 argument | {
"login": "j40903272",
"id": 15309569,
"node_id": "MDQ6VXNlcjE1MzA5NTY5",
"avatar_url": "https://avatars.githubusercontent.com/u/15309569?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/j40903272",
"html_url": "https://github.com/j40903272",
"followers_url": "https://api.github.com/users/j40903272/followers",
"following_url": "https://api.github.com/users/j40903272/following{/other_user}",
"gists_url": "https://api.github.com/users/j40903272/gists{/gist_id}",
"starred_url": "https://api.github.com/users/j40903272/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j40903272/subscriptions",
"organizations_url": "https://api.github.com/users/j40903272/orgs",
"repos_url": "https://api.github.com/users/j40903272/repos",
"events_url": "https://api.github.com/users/j40903272/events{/privacy}",
"received_events_url": "https://api.github.com/users/j40903272/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_llama_hf_to_nemo\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:63:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:46:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:75:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:129:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.80/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-16T12:24:41 | 2025-01-16T12:33:01 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11870",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11870",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11870.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11870.patch",
"merged_at": null
} | # What does this PR do ?
Fix conversion script arguments. The original script using type=bool convert empty strings to False and non-empty strings to True. Might not be an ideal way of using it.
**Collection**: NLP
# Changelog
- Fix convert_llama_hf_to_nemo script --llama31 arguments.
# Usage
```shell
$ scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --llama31 # when it is llama31
$ scripts/checkpoint_converters/convert_llama_hf_to_nemo.py # when it is not llama31
```
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11870/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11870/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11869 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11869/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11869/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11869/events | https://github.com/NVIDIA/NeMo/pull/11869 | 2,792,296,578 | PR_kwDOC_bI7s6H-9HT | 11,869 | flops callback nemo2 compatible | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.metrics.perf_metrics\nnemo/collections/common/metrics/perf_metrics.py:149:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.utils.exp_manager\nnemo/utils/exp_manager.py:355:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:380:0: C0301: Line too long (124/119) (line-too-long)\nnemo/utils/exp_manager.py:384:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:389:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:403:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:410:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:411:0: C0301: Line too long (126/119) (line-too-long)\nnemo/utils/exp_manager.py:413:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:415:0: C0301: Line too long (139/119) (line-too-long)\nnemo/utils/exp_manager.py:425:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:426:0: C0301: Line too long (128/119) (line-too-long)\nnemo/utils/exp_manager.py:427:0: C0301: Line too long (132/119) (line-too-long)\nnemo/utils/exp_manager.py:428:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:516:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:604:0: C0301: Line too long (208/119) (line-too-long)\nnemo/utils/exp_manager.py:605:0: C0301: Line too long (230/119) (line-too-long)\nnemo/utils/exp_manager.py:607:0: C0301: Line too long (178/119) (line-too-long)\nnemo/utils/exp_manager.py:644:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:779:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:787:0: C0301: Line too long (156/119) (line-too-long)\nnemo/utils/exp_manager.py:834:0: C0301: Line too long (141/119) (line-too-long)\nnemo/utils/exp_manager.py:842:0: C0301: Line too long (152/119) (line-too-long)\nnemo/utils/exp_manager.py:1112:0: C0301: Line too long (142/119) (line-too-long)\nnemo/utils/exp_manager.py:1136:0: C0301: Line too long (154/119) (line-too-long)\nnemo/utils/exp_manager.py:1202:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:1221:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:1247:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:91:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:106:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:132:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:141:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:150:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:161:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:279:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:282:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:285:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:288:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:291:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:294:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:297:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:335:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:338:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:341:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:344:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1128:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1229:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1267:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.30/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-16T10:19:39 | 2025-01-16T11:04:17 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11869",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11869",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11869.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11869.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11869/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11869/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11868 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11868/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11868/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11868/events | https://github.com/NVIDIA/NeMo/pull/11868 | 2,792,245,970 | PR_kwDOC_bI7s6H-yCm | 11,868 | Add function calling SFT NeMo2.0 tutorial | {
"login": "Euynaheh",
"id": 93857693,
"node_id": "U_kgDOBZgnnQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93857693?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Euynaheh",
"html_url": "https://github.com/Euynaheh",
"followers_url": "https://api.github.com/users/Euynaheh/followers",
"following_url": "https://api.github.com/users/Euynaheh/following{/other_user}",
"gists_url": "https://api.github.com/users/Euynaheh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Euynaheh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Euynaheh/subscriptions",
"organizations_url": "https://api.github.com/users/Euynaheh/orgs",
"repos_url": "https://api.github.com/users/Euynaheh/repos",
"events_url": "https://api.github.com/users/Euynaheh/events{/privacy}",
"received_events_url": "https://api.github.com/users/Euynaheh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-16T09:59:33 | 2025-01-20T02:27:09 | null | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11868",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11868",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11868.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11868.patch",
"merged_at": null
} | # What does this PR do ?
Add function calling SFT NeMo2.0 tutorial.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11868/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11868/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11867 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11867/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11867/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11867/events | https://github.com/NVIDIA/NeMo/issues/11867 | 2,792,203,894 | I_kwDOC_bI7s6mbaZ2 | 11,867 | How to load local model using import ckpt function | {
"login": "pugnazhaotianqi",
"id": 37784290,
"node_id": "MDQ6VXNlcjM3Nzg0Mjkw",
"avatar_url": "https://avatars.githubusercontent.com/u/37784290?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pugnazhaotianqi",
"html_url": "https://github.com/pugnazhaotianqi",
"followers_url": "https://api.github.com/users/pugnazhaotianqi/followers",
"following_url": "https://api.github.com/users/pugnazhaotianqi/following{/other_user}",
"gists_url": "https://api.github.com/users/pugnazhaotianqi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pugnazhaotianqi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pugnazhaotianqi/subscriptions",
"organizations_url": "https://api.github.com/users/pugnazhaotianqi/orgs",
"repos_url": "https://api.github.com/users/pugnazhaotianqi/repos",
"events_url": "https://api.github.com/users/pugnazhaotianqi/events{/privacy}",
"received_events_url": "https://api.github.com/users/pugnazhaotianqi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-16T09:45:21 | 2025-01-16T09:45:21 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | null | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11867/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11867/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11866 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11866/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11866/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11866/events | https://github.com/NVIDIA/NeMo/pull/11866 | 2,791,651,352 | PR_kwDOC_bI7s6H8v85 | 11,866 | Use empty dict instead of none to load only metadata from dist ckpt | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"[🤖]: Hi @huvunvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12804396135) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-16T04:16:21 | 2025-01-16T12:33:27 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11866",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11866",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11866.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11866.patch",
"merged_at": null
} | # What does this PR do ?
Use empty dict instead of none to load only metadata from dist ckpt, due to change in mcore commit https://github.com/NVIDIA/Megatron-LM/commit/31e8bfa926ca05a3b70a48d3ed6b86410a85a262.
(Applying the same fixing PR in the release branch: https://github.com/NVIDIA/NeMo/pull/11782)
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11866/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11866/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11865 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11865/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11865/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11865/events | https://github.com/NVIDIA/NeMo/pull/11865 | 2,791,539,613 | PR_kwDOC_bI7s6H8YG1 | 11,865 | Support both Path and str for APIs | {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:583:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.96/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @maanug-nv 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12813976197) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-16T02:22:23 | 2025-01-18T00:47:13 | 2025-01-18T00:47:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11865",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11865",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11865.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11865.patch",
"merged_at": "2025-01-18T00:47:12"
} | # What does this PR do ?
APIs may need to be wrapped in `run.Partial`. `pathlib.Path` cannot be wrapped in `run.Config`, so our APIs should support taking either `pathlib.Path` or `str`.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11865/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11865/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11864 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11864/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11864/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11864/events | https://github.com/NVIDIA/NeMo/pull/11864 | 2,791,321,678 | PR_kwDOC_bI7s6H7muC | 11,864 | chore(beep boop 🤖): Bump `MCORE_TAG=004fbcb...` (2025-01-16) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12813564036) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-16T00:22:15 | 2025-01-17T13:12:00 | 2025-01-17T13:11:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11864",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11864",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11864.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11864.patch",
"merged_at": "2025-01-17T13:11:57"
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=004fbcb30355d6d5336989fcdd6683fa5cd4d1c0`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11864/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11864/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11863 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11863/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11863/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11863/events | https://github.com/NVIDIA/NeMo/pull/11863 | 2,791,194,543 | PR_kwDOC_bI7s6H7Jms | 11,863 | Revert "MCore Partial DistOpt Feature" | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron_base_model\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:103:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:111:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:253:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:271:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:346:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:606:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:661:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:833:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:971:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:990:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1107:0: C0301: Line too long (195/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1164:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1213:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1296:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:330:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:461:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:466:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:699:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:751:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:932:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1036:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1271:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1302:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1310:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_gpt_model\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:333:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:373:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:419:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:466:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:799:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1114:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1135:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1345:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1386:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1443:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1625:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1626:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1628:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1800:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1820:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1828:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1849:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1919:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1946:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:140:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:153:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:179:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:198:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:293:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:313:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:475:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:478:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:709:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:713:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:795:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1185:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1456:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1592:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1600:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1609:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1894:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2047:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2054:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2060:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:20:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:28:0: W0611: Unused _DataFetcherWrapper imported from lightning.pytorch.loops.fetchers (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:30:0: W0611: Unused OmegaConf imported from omegaconf (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:72:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:81:4: W0611: Unused megatron.core imported as core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:82:4: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module nemo.collections.nlp.modules.common.megatron.megatron_init\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:266:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:267:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:268:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:371:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:88:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.parts.nlp_overrides\nnemo/collections/nlp/parts/nlp_overrides.py:212:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:217:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:233:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:424:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:510:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:730:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:735:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1001:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1005:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1009:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1066:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1193:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1775:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:381:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:425:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:602:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:618:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:637:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:878:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:997:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:1686:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:1774:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:18:0: W0611: Unused import re (unused-import)\nnemo/collections/nlp/parts/nlp_overrides.py:106:4: W0611: Unused tensorstore imported from megatron.core.dist_checkpointing.strategies (unused-import)\n************* Module nemo.utils.app_state\nnemo/utils/app_state.py:407:0: C0301: Line too long (138/119) (line-too-long)\nnemo/utils/app_state.py:415:0: C0301: Line too long (135/119) (line-too-long)\nnemo/utils/app_state.py:23:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/app_state.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/app_state.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:675:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:685:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:694:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:699:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:705:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:713:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/app_state.py:721:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-15T23:15:46 | 2025-01-15T23:19:05 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11863",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11863",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11863.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11863.patch",
"merged_at": null
} | Reverts NVIDIA/NeMo#10693
>GPU LLM test failing: It clearly started only today. And that PR 10693 had a really old CI signal (it was a week old). So quite likely that a re-run of the CI would have failed. But since we don’t require up-to-date CI, it got merged | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11863/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11863/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11862 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11862/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11862/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11862/events | https://github.com/NVIDIA/NeMo/pull/11862 | 2,791,157,773 | PR_kwDOC_bI7s6H7BIm | 11,862 | Update cicd-main.yml | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-15T22:58:25 | 2025-01-16T09:06:56 | 2025-01-16T09:06:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11862",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11862",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11862.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11862.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11862/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11862/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11861 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11861/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11861/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11861/events | https://github.com/NVIDIA/NeMo/pull/11861 | 2,790,603,128 | PR_kwDOC_bI7s6H5DQp | 11,861 | Run nsys callback on GBS not on MBS | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12834928205) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-15T18:53:46 | 2025-01-18T03:56:16 | 2025-01-18T03:56:15 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11861",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11861",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11861.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11861.patch",
"merged_at": "2025-01-18T03:56:15"
} | # What does this PR do ?
`get_current_epoch_step` tracks optimizer's current step (since the callback's start/end-step are in GBS).
However, `on_train_batch_start` is called on every batch, therefore it is possible that it enters `if current_step == self._nsys_profile_start_step` and calls `emit_nvtx` multiple times.
This PR adds a boolean variable to prevent it from entering on each MBS.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11861/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11861/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11860 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11860/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11860/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11860/events | https://github.com/NVIDIA/NeMo/pull/11860 | 2,790,554,913 | PR_kwDOC_bI7s6H44r6 | 11,860 | Add nemo1 to nemo2 conversion for neva | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-15T18:25:54 | 2025-01-15T18:29:45 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11860",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11860",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11860.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11860.patch",
"merged_at": null
} | # What does this PR do ?
Update conversion script to handle neva nemo1 to nemo2 conversion for llava 1.5 7b and 13b. It assumes the "vision_model" is frozen (i.e. not trainable) in nemo1.
If vision model is trainable this script won't work correctly.
**Collection**: [multimodal]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11860/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11860/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11859 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11859/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11859/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11859/events | https://github.com/NVIDIA/NeMo/pull/11859 | 2,790,527,237 | PR_kwDOC_bI7s6H4yfn | 11,859 | fix checkpoint load issue | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.ssm\nnemo/collections/llm/gpt/model/ssm.py:190:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/llm/gpt/model/ssm.py:193:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/llm/gpt/model/ssm.py:194:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/llm/gpt/model/ssm.py:195:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/llm/gpt/model/ssm.py:39:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:51:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:89:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:110:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:127:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:131:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:134:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:155:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:203:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:216:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:221:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:235:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:249:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:263:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:277:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:291:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:306:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.multimodal.models.text_to_image.controlnet.controlnet\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:148:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:581:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:597:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:635:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:973:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:988:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:1003:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:1013:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:110:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:164:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:282:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:544:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:605:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:608:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:631:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:660:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:673:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:685:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:811:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:858:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:865:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:944:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:1033:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/controlnet/controlnet.py:1036:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.multimodal.models.text_to_image.imagen.imagen_pipeline\nnemo/collections/multimodal/models/text_to_image/imagen/imagen_pipeline.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/imagen/imagen_pipeline.py:39:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/imagen/imagen_pipeline.py:45:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/imagen/imagen_pipeline.py:61:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/imagen/imagen_pipeline.py:155:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/imagen/imagen_pipeline.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.multimodal.models.text_to_image.instruct_pix2pix.ldm.ddpm_edit\nnemo/collections/multimodal/models/text_to_image/instruct_pix2pix/ldm/ddpm_edit.py:126:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/instruct_pix2pix/ldm/ddpm_edit.py:155:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/instruct_pix2pix/ldm/ddpm_edit.py:205:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/instruct_pix2pix/ldm/ddpm_edit.py:213:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/instruct_pix2pix/ldm/ddpm_edit.py:225:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/instruct_pix2pix/ldm/ddpm_edit.py:42:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/instruct_pix2pix/ldm/ddpm_edit.py:146:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.multimodal.models.text_to_image.stable_diffusion.ldm.autoencoder\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:354:0: C0301: Line too long (214/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:108:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:129:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:136:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:154:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:184:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:227:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:257:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:289:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:310:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:478:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:515:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:522:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:557:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:573:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:586:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:590:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:606:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:615:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:620:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:625:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:628:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:631:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/autoencoder.py:636:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.multimodal.models.text_to_image.stable_diffusion.ldm.ddpm\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1109:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1678:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2072:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2096:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2111:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2121:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2205:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:124:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:172:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:240:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:324:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:330:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:336:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:351:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:364:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:373:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:389:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:396:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:403:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:409:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:424:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:455:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:461:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:472:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:485:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:581:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:588:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:615:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:622:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:654:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:663:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:676:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:697:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:851:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:913:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:975:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1039:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1303:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1498:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1647:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1658:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1716:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1729:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1741:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1865:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1920:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1969:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:1975:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2037:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2141:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2357:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:2378:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:18:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py:73:0: W0611: Unused get_last_rank imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\n************* Module nemo.collections.multimodal.modules.stable_diffusion.diffusionmodules.openaimodel\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:559:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:562:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:566:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:968:0: C0301: Line too long (187/119) (line-too-long)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:1245:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:1344:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:70:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:74:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:78:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:125:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:189:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:221:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:253:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:432:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:490:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:531:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:535:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:540:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:1152:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:1381:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/modules/stable_diffusion/diffusionmodules/openaimodel.py:20:0: W0611: Unused partial imported from functools (unused-import)\n************* Module nemo.collections.multimodal.speech_llm.models.modular_models\nnemo/collections/multimodal/speech_llm/models/modular_models.py:424:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:459:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:715:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:786:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:787:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1151:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1186:0: C0301: Line too long (254/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1220:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1225:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1234:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1241:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1245:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1301:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1347:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1350:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1447:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1466:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1471:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1550:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1695:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1696:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1732:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:97:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:869:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:893:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1072:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_llm/models/modular_models.py:1636:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.multimodal.speech_llm.parts.mixins.adapter_mixin\nnemo/collections/multimodal/speech_llm/parts/mixins/adapter_mixin.py:73:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/multimodal/speech_llm/parts/mixins/adapter_mixin.py:25:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.nlp.parts.mixins.multimodal_adapter_mixins\nnemo/collections/nlp/parts/mixins/multimodal_adapter_mixins.py:34:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/parts/mixins/multimodal_adapter_mixins.py:26:4: W0611: Unused parallel_state imported from megatron.core (unused-import)\n************* Module nemo.collections.nlp.parts.mixins.nlp_adapter_mixins\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:69:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:75:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:86:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:130:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:432:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:448:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:455:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:388:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:396:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:446:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:458:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py:465:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.56/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @dimapihtar 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12830171803) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-15T18:13:51 | 2025-01-17T18:04:08 | 2025-01-17T18:04:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11859",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11859",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11859.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11859.patch",
"merged_at": "2025-01-17T18:04:07"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11859/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11859/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11858 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11858/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11858/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11858/events | https://github.com/NVIDIA/NeMo/pull/11858 | 2,790,233,203 | PR_kwDOC_bI7s6H3yQO | 11,858 | Removes tensorstore 0.1.45 pin from requirements_deploy.txt | {
"login": "pstjohn",
"id": 2576846,
"node_id": "MDQ6VXNlcjI1NzY4NDY=",
"avatar_url": "https://avatars.githubusercontent.com/u/2576846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pstjohn",
"html_url": "https://github.com/pstjohn",
"followers_url": "https://api.github.com/users/pstjohn/followers",
"following_url": "https://api.github.com/users/pstjohn/following{/other_user}",
"gists_url": "https://api.github.com/users/pstjohn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pstjohn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pstjohn/subscriptions",
"organizations_url": "https://api.github.com/users/pstjohn/orgs",
"repos_url": "https://api.github.com/users/pstjohn/repos",
"events_url": "https://api.github.com/users/pstjohn/events{/privacy}",
"received_events_url": "https://api.github.com/users/pstjohn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-15T16:00:02 | 2025-01-16T19:00:32 | 2025-01-16T19:00:32 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11858",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11858",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11858.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11858.patch",
"merged_at": "2025-01-16T19:00:32"
} | # What does this PR do ?
Removes the pin from tensorstore 0.1.45 from requirements_deploy.txt, since the issue was fixed in 0.1.47.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11858/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11858/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11857 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11857/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11857/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11857/events | https://github.com/NVIDIA/NeMo/pull/11857 | 2,790,079,283 | PR_kwDOC_bI7s6H3QWy | 11,857 | Chore: Update requirements.txt | {
"login": "LukasM937",
"id": 46906556,
"node_id": "MDQ6VXNlcjQ2OTA2NTU2",
"avatar_url": "https://avatars.githubusercontent.com/u/46906556?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LukasM937",
"html_url": "https://github.com/LukasM937",
"followers_url": "https://api.github.com/users/LukasM937/followers",
"following_url": "https://api.github.com/users/LukasM937/following{/other_user}",
"gists_url": "https://api.github.com/users/LukasM937/gists{/gist_id}",
"starred_url": "https://api.github.com/users/LukasM937/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/LukasM937/subscriptions",
"organizations_url": "https://api.github.com/users/LukasM937/orgs",
"repos_url": "https://api.github.com/users/LukasM937/repos",
"events_url": "https://api.github.com/users/LukasM937/events{/privacy}",
"received_events_url": "https://api.github.com/users/LukasM937/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-15T14:59:16 | 2025-01-15T15:13:45 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11857",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11857",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11857.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11857.patch",
"merged_at": null
} | When only using/installing the speech data explorer, pandas is not installed but needed to execute the tool. To stream line the process I edited the requirements.txt
# What does this PR do ?
It should help to streamline the process of installing the requirements, since pandas is used but not installed with the original file.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Added: "pandas" to line 11
# Usage
* When only using the Speech data explorer, in a new python enviroment.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11857/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11857/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11856 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11856/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11856/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11856/events | https://github.com/NVIDIA/NeMo/pull/11856 | 2,789,260,170 | PR_kwDOC_bI7s6H0atW | 11,856 | Fix typo ASR tutorial. | {
"login": "createOne999",
"id": 122151081,
"node_id": "U_kgDOB0fgqQ",
"avatar_url": "https://avatars.githubusercontent.com/u/122151081?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/createOne999",
"html_url": "https://github.com/createOne999",
"followers_url": "https://api.github.com/users/createOne999/followers",
"following_url": "https://api.github.com/users/createOne999/following{/other_user}",
"gists_url": "https://api.github.com/users/createOne999/gists{/gist_id}",
"starred_url": "https://api.github.com/users/createOne999/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/createOne999/subscriptions",
"organizations_url": "https://api.github.com/users/createOne999/orgs",
"repos_url": "https://api.github.com/users/createOne999/repos",
"events_url": "https://api.github.com/users/createOne999/events{/privacy}",
"received_events_url": "https://api.github.com/users/createOne999/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [] | 2025-01-15T09:19:40 | 2025-01-16T04:29:00 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11856",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11856",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11856.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11856.patch",
"merged_at": null
} | # What does this PR do ?
Fix tutorial typo
**Collection**: None
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11856/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11856/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11855 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11855/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11855/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11855/events | https://github.com/NVIDIA/NeMo/pull/11855 | 2,788,997,761 | PR_kwDOC_bI7s6HzhhW | 11,855 | Fix Qwen2 importer | {
"login": "james77777778",
"id": 20734616,
"node_id": "MDQ6VXNlcjIwNzM0NjE2",
"avatar_url": "https://avatars.githubusercontent.com/u/20734616?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/james77777778",
"html_url": "https://github.com/james77777778",
"followers_url": "https://api.github.com/users/james77777778/followers",
"following_url": "https://api.github.com/users/james77777778/following{/other_user}",
"gists_url": "https://api.github.com/users/james77777778/gists{/gist_id}",
"starred_url": "https://api.github.com/users/james77777778/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/james77777778/subscriptions",
"organizations_url": "https://api.github.com/users/james77777778/orgs",
"repos_url": "https://api.github.com/users/james77777778/repos",
"events_url": "https://api.github.com/users/james77777778/events{/privacy}",
"received_events_url": "https://api.github.com/users/james77777778/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.qwen2\nnemo/collections/llm/gpt/model/qwen2.py:38:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:56:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:65:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:74:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:84:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:95:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:107:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:127:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:143:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:149:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:176:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:195:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:212:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/qwen2.py:216:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.27/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-15T07:03:35 | 2025-01-17T00:35:59 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11855",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11855",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11855.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11855.patch",
"merged_at": null
} | # What does this PR do ?
A simple fix for the Qwen2 importer:
Qwen2 7B and larger require `vocab_size=152064` instead of default `vocab_size=151936`. The `HFQwen2Importer.config` missed this setting.
**Collection**: `llm`
# Usage
* You can potentially add a usage example below
```python
# This usage will fail without this PR
nemo llm import model=qwen2_7b source="hf://Qwen/Qwen2-7B"
python3 ./scripts/llm/generate.py --model_path /root/.cache/nemo/models/Qwen/Qwen2-7B --num_tokens_to_generate 64
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
## Who can review?
@suiyoubi , since you added Qwen2 to NeMo2 | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11855/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11855/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11854 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11854/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11854/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11854/events | https://github.com/NVIDIA/NeMo/pull/11854 | 2,788,540,582 | PR_kwDOC_bI7s6Hx97f | 11,854 | chore(beep boop 🤖): Bump `MCORE_TAG=c1cafa1...` (2025-01-15) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-15T00:22:26 | 2025-01-16T20:29:10 | 2025-01-16T20:29:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11854",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11854",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11854.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11854.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=c1cafa1c19f9b7a014a0bc11c1ddbc13f739f086`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11854/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11854/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11853 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11853/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11853/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11853/events | https://github.com/NVIDIA/NeMo/issues/11853 | 2,788,360,138 | I_kwDOC_bI7s6mMv_K | 11,853 | `prepare_energon_dataset.py` is supposed to save encoded latents but reconstructed videos are saved instead. | {
"login": "Sy-Zhang",
"id": 6948633,
"node_id": "MDQ6VXNlcjY5NDg2MzM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6948633?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sy-Zhang",
"html_url": "https://github.com/Sy-Zhang",
"followers_url": "https://api.github.com/users/Sy-Zhang/followers",
"following_url": "https://api.github.com/users/Sy-Zhang/following{/other_user}",
"gists_url": "https://api.github.com/users/Sy-Zhang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Sy-Zhang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sy-Zhang/subscriptions",
"organizations_url": "https://api.github.com/users/Sy-Zhang/orgs",
"repos_url": "https://api.github.com/users/Sy-Zhang/repos",
"events_url": "https://api.github.com/users/Sy-Zhang/events{/privacy}",
"received_events_url": "https://api.github.com/users/Sy-Zhang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | {
"login": "zpx01",
"id": 51731412,
"node_id": "MDQ6VXNlcjUxNzMxNDEy",
"avatar_url": "https://avatars.githubusercontent.com/u/51731412?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zpx01",
"html_url": "https://github.com/zpx01",
"followers_url": "https://api.github.com/users/zpx01/followers",
"following_url": "https://api.github.com/users/zpx01/following{/other_user}",
"gists_url": "https://api.github.com/users/zpx01/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zpx01/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zpx01/subscriptions",
"organizations_url": "https://api.github.com/users/zpx01/orgs",
"repos_url": "https://api.github.com/users/zpx01/repos",
"events_url": "https://api.github.com/users/zpx01/events{/privacy}",
"received_events_url": "https://api.github.com/users/zpx01/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "zpx01",
"id": 51731412,
"node_id": "MDQ6VXNlcjUxNzMxNDEy",
"avatar_url": "https://avatars.githubusercontent.com/u/51731412?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zpx01",
"html_url": "https://github.com/zpx01",
"followers_url": "https://api.github.com/users/zpx01/followers",
"following_url": "https://api.github.com/users/zpx01/following{/other_user}",
"gists_url": "https://api.github.com/users/zpx01/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zpx01/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zpx01/subscriptions",
"organizations_url": "https://api.github.com/users/zpx01/orgs",
"repos_url": "https://api.github.com/users/zpx01/repos",
"events_url": "https://api.github.com/users/zpx01/events{/privacy}",
"received_events_url": "https://api.github.com/users/zpx01/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@zpx01 can you take a look?",
"@Sy-Zhang can you try changing the following line:\nhttps://github.com/NVIDIA/NeMo/blob/1626ddded63af1fe82b0bee482fba44c57b8203d/nemo/collections/common/video_tokenizers/cosmos_tokenizer.py#L205\n\nto this:\n\n`output_tensor = self.encode(input_tensor)`\n\nI think this will temporarily fix your issue. We are going to have a large revision of the code soon, so this will not be an issue moving forward. "
] | 2025-01-14T22:01:10 | 2025-01-16T05:51:21 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
According to https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/diffusion/data/readme.rst, `prepare_energon_dataset.py` is supposed to save encoded latents. However, it save the reconstructed videos instead.
**Steps/Code to reproduce bug**
`torchrun --nproc_per_node=8 nemo/collections/diffusion/data/prepare_energon_dataset.py`
** Reason **
Autoencoder's forward function is called [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/diffusion/data/prepare_energon_dataset.py#L219), which first encode the latents and then decode the latents, as shown [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/common/video_tokenizers/cosmos_tokenizer.py#L205).
`autoencoder.encode` should be called instead.
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11853/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11853/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11852 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11852/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11852/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11852/events | https://github.com/NVIDIA/NeMo/pull/11852 | 2,788,334,833 | PR_kwDOC_bI7s6HxQXE | 11,852 | Removing qk layernorms for DiT diffusion attention modules as qk layernorm is not supported for CrossAttention | {
"login": "Sy-Zhang",
"id": 6948633,
"node_id": "MDQ6VXNlcjY5NDg2MzM=",
"avatar_url": "https://avatars.githubusercontent.com/u/6948633?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sy-Zhang",
"html_url": "https://github.com/Sy-Zhang",
"followers_url": "https://api.github.com/users/Sy-Zhang/followers",
"following_url": "https://api.github.com/users/Sy-Zhang/following{/other_user}",
"gists_url": "https://api.github.com/users/Sy-Zhang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Sy-Zhang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sy-Zhang/subscriptions",
"organizations_url": "https://api.github.com/users/Sy-Zhang/orgs",
"repos_url": "https://api.github.com/users/Sy-Zhang/repos",
"events_url": "https://api.github.com/users/Sy-Zhang/events{/privacy}",
"received_events_url": "https://api.github.com/users/Sy-Zhang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.diffusion.models.dit.dit_layer_spec\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:194:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:234:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:249:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:268:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:288:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:306:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:362:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:396:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:416:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:549:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:552:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:53:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:59:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:65:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:108:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:132:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:138:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:221:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:383:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:482:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:623:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:643:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:675:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:734:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:771:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:796:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:822:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:841:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:21:0: W0611: Unused rearrange imported from einops (unused-import)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:22:0: W0611: Unused jit_fuser imported from megatron.core.jit (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.46/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"hi @Sy-Zhang we have a change to add qk LN to cross attention. it hasn't been merged to megatron-lm yet. you can try the container nvcr.io/nvidia/nemo:cosmos.01"
] | 2025-01-14T21:42:57 | 2025-01-15T07:01:33 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11852",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11852",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11852.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11852.patch",
"merged_at": null
} | * Docker Image: `nvcr.io/nvidia/nemo:24.12`
* Command: `torchrun --nproc-per-node 8 nemo/collections/diffusion/train.py --yes --factory pretrain_xl`
* Error: `CrossAttentionSubmodules.__init__() got an unexpected keyword argument q_layernorm`
* Reason: `megatron.core.transformer.attention.CrossAttentionSubmodules` does not have argument `q_layernorm` and `k_layernorm`.
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11852/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11852/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11851 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11851/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11851/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11851/events | https://github.com/NVIDIA/NeMo/pull/11851 | 2,788,170,977 | PR_kwDOC_bI7s6Hwsba | 11,851 | Refactor VLM modules / Add InternVit submodule support | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.vision.base\nnemo/collections/vlm/vision/base.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/base.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/base.py:136:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/base.py:148:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/base.py:175:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/base.py:198:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.vision.clip_vit\nnemo/collections/vlm/vision/clip_vit.py:73:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/vision/clip_vit.py:74:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/vlm/vision/clip_vit.py:75:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/vision/clip_vit.py:76:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/vision/clip_vit.py:81:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/vlm/vision/clip_vit.py:12:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/clip_vit.py:17:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/clip_vit.py:23:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/clip_vit.py:45:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/clip_vit.py:63:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/clip_vit.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/clip_vit.py:5:0: W0611: Unused CLIPVisionModel imported from transformers (unused-import)\n************* Module nemo.collections.vlm.vision.intern_vit\nnemo/collections/vlm/vision/intern_vit.py:47:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/intern_vit.py:140:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/intern_vit.py:182:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/intern_vit.py:193:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/intern_vit.py:255:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/intern_vit.py:287:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/intern_vit.py:316:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/intern_vit.py:321:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/intern_vit.py:341:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/intern_vit.py:346:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/intern_vit.py:352:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/vision/intern_vit.py:375:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/intern_vit.py:409:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/vision/intern_vit.py:446:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.47/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.neva.model.base\nnemo/collections/vlm/neva/model/base.py:321:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:324:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:349:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:101:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:147:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:164:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:195:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:229:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:736:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:753:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:757:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:789:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:792:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:795:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:799:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:805:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:812:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:35:0: W0611: Unused get_batch_on_this_context_parallel_rank imported from nemo.collections.llm.gpt.model.base (unused-import)\nnemo/collections/vlm/neva/model/base.py:35:0: W0611: Unused get_packed_seq_params imported from nemo.collections.llm.gpt.model.base (unused-import)\n************* Module nemo.collections.vlm.neva.model.llava\nnemo/collections/vlm/neva/model/llava.py:110:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:111:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:112:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:113:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:151:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:152:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:153:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:154:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:155:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:156:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:157:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:158:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:159:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:160:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:161:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:42:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:48:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:61:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:73:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:85:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/llava.py:182:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/llava.py:188:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/llava.py:228:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.08/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-14T19:57:35 | 2025-01-15T21:28:42 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11851",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11851",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11851.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11851.patch",
"merged_at": null
} | # What does this PR do ?
Refactor VLM modules / Add InternVit submodule support
**Collection**: [multimodal / vlm]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11851/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11851/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11850 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11850/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11850/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11850/events | https://github.com/NVIDIA/NeMo/pull/11850 | 2,788,167,973 | PR_kwDOC_bI7s6HwrwV | 11,850 | Add CP support to Neva in NeMo2 | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"[🤖]: Hi @yaoyu-33 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12779228320) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.neva.model.base\nnemo/collections/vlm/neva/model/base.py:539:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:542:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:567:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:93:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:144:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:160:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:181:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:260:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:308:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:339:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:376:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:399:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:423:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:442:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:1002:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:1019:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1023:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1055:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1058:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1061:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1065:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1071:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1078:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:48:0: W0611: Unused get_batch_on_this_context_parallel_rank imported from nemo.collections.llm.gpt.model.base (unused-import)\nnemo/collections/vlm/neva/model/base.py:48:0: W0611: Unused get_packed_seq_params imported from nemo.collections.llm.gpt.model.base (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.45/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @yaoyu-33 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12815382650) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-14T19:55:41 | 2025-01-17T23:17:34 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11850",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11850",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11850.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11850.patch",
"merged_at": null
} | # What does this PR do ?
Add CP support to Neva in NeMo2.
**Collection**: [multimodal]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11850/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11850/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11848 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11848/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11848/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11848/events | https://github.com/NVIDIA/NeMo/pull/11848 | 2,787,967,630 | PR_kwDOC_bI7s6Hv_nA | 11,848 | Add Minitron pruning example for NeMo 2.0 | {
"login": "kevalmorabia97",
"id": 28916987,
"node_id": "MDQ6VXNlcjI4OTE2OTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/28916987?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevalmorabia97",
"html_url": "https://github.com/kevalmorabia97",
"followers_url": "https://api.github.com/users/kevalmorabia97/followers",
"following_url": "https://api.github.com/users/kevalmorabia97/following{/other_user}",
"gists_url": "https://api.github.com/users/kevalmorabia97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevalmorabia97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevalmorabia97/subscriptions",
"organizations_url": "https://api.github.com/users/kevalmorabia97/orgs",
"repos_url": "https://api.github.com/users/kevalmorabia97/repos",
"events_url": "https://api.github.com/users/kevalmorabia97/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevalmorabia97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-14T18:11:07 | 2025-01-16T20:45:42 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11848",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11848",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11848.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11848.patch",
"merged_at": null
} | # What does this PR do ?
Add Minitron pruning example for NeMo 2.0
**Collection**: N/A
# Changelog
- Add Minitron pruning example for NeMo 2.0
# Usage
* You can potentially add a usage example below
```python
torchrun --nproc_per_node 8 prune.py \
--devices 8 \
--tp_size 1 \
--pp_size 8 \
--restore_path <path/to/llama3.1-8b-nemo2> \
--seq_length 8192 \
--data_paths 30 path/to/dataset_1_prefix 70 path/to/dataset_2_prefix \
--prune_ffn_hidden_size 9216 \
--prune_hidden_size 3072 \
--prune_num_attention_heads 32 \
--prune_num_query_groups 8 \
--save_path llama3.1-8b-width-pruned
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11848/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11848/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11847 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11847/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11847/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11847/events | https://github.com/NVIDIA/NeMo/issues/11847 | 2,787,754,708 | I_kwDOC_bI7s6mKcLU | 11,847 | Optical Flow classifier | {
"login": "Free4ky",
"id": 51875349,
"node_id": "MDQ6VXNlcjUxODc1MzQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/51875349?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Free4ky",
"html_url": "https://github.com/Free4ky",
"followers_url": "https://api.github.com/users/Free4ky/followers",
"following_url": "https://api.github.com/users/Free4ky/following{/other_user}",
"gists_url": "https://api.github.com/users/Free4ky/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Free4ky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Free4ky/subscriptions",
"organizations_url": "https://api.github.com/users/Free4ky/orgs",
"repos_url": "https://api.github.com/users/Free4ky/repos",
"events_url": "https://api.github.com/users/Free4ky/events{/privacy}",
"received_events_url": "https://api.github.com/users/Free4ky/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2025-01-14T16:51:25 | 2025-01-14T16:51:25 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello, NVIDIA team!
In the [Cosmos paper](https://research.nvidia.com/publication/2025-01_cosmos-world-foundation-model-platform-physical-ai) specifically in Section 3.3.1 "Motion Filtering" ViT-based optical flow classifier is mentioned. I was wondering if the weights for this model are publicly available or if there are plans to release them as part of data curation pipeline.
Thank you for your time and assistance!
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11847/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11847/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11846 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11846/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11846/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11846/events | https://github.com/NVIDIA/NeMo/pull/11846 | 2,787,391,602 | PR_kwDOC_bI7s6Ht-b0 | 11,846 | Adding serialization to all Auto* obj by following #11645 PR | {
"login": "eagle705",
"id": 7252598,
"node_id": "MDQ6VXNlcjcyNTI1OTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7252598?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/eagle705",
"html_url": "https://github.com/eagle705",
"followers_url": "https://api.github.com/users/eagle705/followers",
"following_url": "https://api.github.com/users/eagle705/following{/other_user}",
"gists_url": "https://api.github.com/users/eagle705/gists{/gist_id}",
"starred_url": "https://api.github.com/users/eagle705/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eagle705/subscriptions",
"organizations_url": "https://api.github.com/users/eagle705/orgs",
"repos_url": "https://api.github.com/users/eagle705/repos",
"events_url": "https://api.github.com/users/eagle705/events{/privacy}",
"received_events_url": "https://api.github.com/users/eagle705/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.io.artifact.hf_auto\nnemo/lightning/io/artifact/hf_auto.py:92:0: C0301: Line too long (139/119) (line-too-long)\n\n-----------------------------------\nYour code has been rated at 9.74/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-14T14:55:41 | 2025-01-16T13:46:52 | null | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11846",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11846",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11846.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11846.patch",
"merged_at": null
} | # What does this PR do ?
A draft based on PR version #11645, built on top of the latest code from GitHub.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #11645
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11846/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11846/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11845 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11845/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11845/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11845/events | https://github.com/NVIDIA/NeMo/pull/11845 | 2,787,242,186 | PR_kwDOC_bI7s6Htc7N | 11,845 | NeMo 2.0 fp8 conversion | {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:164:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:196:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:207:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:211:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:238:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:249:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:270:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:365:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:505:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:589:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:593:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:604:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:616:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:656:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:693:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:706:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:25:0: W0611: Unused import tensorstore (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.66/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @Laplasjan107 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12864860636) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-14T14:11:08 | 2025-01-20T11:29:00 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11845",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11845",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11845.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11845.patch",
"merged_at": null
} | # What does this PR do ?
1) Handles trt-llm export for fp8 NeMo 2.0 checkpoints, trained with TransformerEngine
2) Handles fp8 parameters for NeMo 1.0 -> NeMo 2.0 conversion
**Collection**: nlp/llm
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11845/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11845/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11844 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11844/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11844/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11844/events | https://github.com/NVIDIA/NeMo/issues/11844 | 2,786,591,228 | I_kwDOC_bI7s6mGAH8 | 11,844 | Cosmos support | {
"login": "zzzzzero",
"id": 12083809,
"node_id": "MDQ6VXNlcjEyMDgzODA5",
"avatar_url": "https://avatars.githubusercontent.com/u/12083809?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zzzzzero",
"html_url": "https://github.com/zzzzzero",
"followers_url": "https://api.github.com/users/zzzzzero/followers",
"following_url": "https://api.github.com/users/zzzzzero/following{/other_user}",
"gists_url": "https://api.github.com/users/zzzzzero/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zzzzzero/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zzzzzero/subscriptions",
"organizations_url": "https://api.github.com/users/zzzzzero/orgs",
"repos_url": "https://api.github.com/users/zzzzzero/repos",
"events_url": "https://api.github.com/users/zzzzzero/events{/privacy}",
"received_events_url": "https://api.github.com/users/zzzzzero/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"We are currently in the process of merging Cosmos related changes to the main branch in the NeMo repository.\nETA: ~2 weeks "
] | 2025-01-14T08:54:43 | 2025-01-16T05:04:41 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | It seems that the fine-tuning training for Cosmos can only be done in the nvcr.io/nvidia/nemo:cosmos.1.0 image environment. I couldn't find the relevant code on Nemo's GitHub. I would prefer not to download an extra image again. When will this Cosmos code be updated on GitHub? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11844/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11844/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11843 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11843/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11843/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11843/events | https://github.com/NVIDIA/NeMo/pull/11843 | 2,786,392,449 | PR_kwDOC_bI7s6HqkmS | 11,843 | Create test_phi3.py | {
"login": "mayani-nv",
"id": 67936769,
"node_id": "MDQ6VXNlcjY3OTM2NzY5",
"avatar_url": "https://avatars.githubusercontent.com/u/67936769?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mayani-nv",
"html_url": "https://github.com/mayani-nv",
"followers_url": "https://api.github.com/users/mayani-nv/followers",
"following_url": "https://api.github.com/users/mayani-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/mayani-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mayani-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mayani-nv/subscriptions",
"organizations_url": "https://api.github.com/users/mayani-nv/orgs",
"repos_url": "https://api.github.com/users/mayani-nv/repos",
"events_url": "https://api.github.com/users/mayani-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/mayani-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [] | 2025-01-14T06:48:30 | 2025-01-17T19:09:01 | null | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11843",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11843",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11843.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11843.patch",
"merged_at": null
} | Creating unit tests for the Phi3 model | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11843/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11843/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11842 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11842/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11842/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11842/events | https://github.com/NVIDIA/NeMo/pull/11842 | 2,785,791,089 | PR_kwDOC_bI7s6Hoc1I | 11,842 | chore(beep boop 🤖): Bump `MCORE_TAG=6486203...` (2025-01-14) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-14T00:21:44 | 2025-01-16T20:29:13 | 2025-01-16T20:29:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11842",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11842",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11842.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11842.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=64862035dbb9b03f40b09cfe26b82306609f7153`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11842/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11842/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11841 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11841/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11841/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11841/events | https://github.com/NVIDIA/NeMo/pull/11841 | 2,785,485,729 | PR_kwDOC_bI7s6HnXFD | 11,841 | Add qwen trtllm | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-13T21:36:25 | 2025-01-13T21:36:36 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11841",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11841",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11841.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11841.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11841/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11841/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11840 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11840/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11840/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11840/events | https://github.com/NVIDIA/NeMo/issues/11840 | 2,785,211,774 | I_kwDOC_bI7s6mAvV- | 11,840 | Failing convert_llama_hf_to_nemo.py | {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [] | 2025-01-13T19:53:52 | 2025-01-13T19:53:52 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Failing convert_llama_hf_to_nemo.py**
Running `convert_llama_hf_to_nemo.py` fails with an error `TypeError: expected string or bytes-like object` when trying to execute `python /home/ubuntu/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --input_name_or_path meta-llama/Llama-3.2-1B-Instruct --output_path Llama-3.2-1B.nemo`
**Steps/Code to reproduce bug**
When running `python /home/ubuntu/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --input_name_or_path meta-llama/Llama-3.2-1B-Instruct --output_path Llama-3.2-1B.nemo` I get the following error.
```bash
Traceback (most recent call last):
File "/home/ubuntu/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py", line 344, in <module>
convert(args)
File "/home/ubuntu/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py", line 310, in convert
model = load_state_dict_helper(MegatronGPTModel, nemo_config, trainer, checkpoint['state_dict'])
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/nlp/parts/utils_funcs.py", line 220, in load_state_dict_helper
model = cls(cfg, trainer)
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 331, in __init__
super().__init__(cfg, trainer=trainer, no_lm_init=True)
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/nlp/models/language_modeling/megatron_base_model.py", line 153, in __init__
self._enable_nvidia_optimizations()
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/nlp/models/language_modeling/megatron_base_model.py", line 393, in _enable_nvidia_optimizations
if not is_official_release_version(nvidia_torch_version):
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/nlp/models/language_modeling/megatron_base_model.py", line 390, in is_official_release_version
return re.fullmatch("[0-9][0-9]\.[0-9][0-9].*", nvidia_torch_version) # "YY.MM.*"
File "/home/ubuntu/miniconda3/envs/nemo/lib/python3.10/re.py", line 195, in fullmatch
return _compile(pattern, flags).fullmatch(string)
TypeError: expected string or bytes-like object
```
**Environment overview **
- Environment location: Cloud(Lambdalabs)
- Method of NeMo install: from srouce using `python -m pip install git+https://github.com/NVIDIA/[email protected]#egg=nemo_toolkit[all]`
**Environment details**
- OS version: Debian
- PyTorch version: 2.4.1+cu124
- Python version: Python 3.10
**Additional context**
GPU model: `A100`
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11840/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11840/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11839 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11839/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11839/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11839/events | https://github.com/NVIDIA/NeMo/pull/11839 | 2,784,864,213 | PR_kwDOC_bI7s6HlIfc | 11,839 | handle mistralai/Mistral-7B-Instruct-v0.3 tokenizer correctly | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_mistral_7b_hf_to_nemo\nscripts/checkpoint_converters/convert_mistral_7b_hf_to_nemo.py:436:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.97/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12754892366) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-13T18:13:30 | 2025-01-13T23:34:47 | 2025-01-13T23:34:46 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11839",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11839",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11839.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11839.patch",
"merged_at": "2025-01-13T23:34:46"
} | # What does this PR do ?
Uses sentence-piece legacy to handle special tokens as part of text, this change only affects mistralai/Mistral-7B-Instruct-v0.3
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11839/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11839/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11838 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11838/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11838/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11838/events | https://github.com/NVIDIA/NeMo/issues/11838 | 2,784,751,187 | I_kwDOC_bI7s6l--5T | 11,838 | ModuleNotFoundError: No module named 'megatron.core.dist_checkpointing' | {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"I found the issue. Instead of installing from `main` branch, it wokred when I reinstall from `r2.*`"
] | 2025-01-13T17:40:33 | 2025-01-13T18:07:30 | 2025-01-13T18:07:29 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **ModuleNotFoundError: No module named 'megatron.core.dist_checkpointing'**
I am getting `ModuleNotFoundError: No module named 'megatron.core.dist_checkpointing'`
**Steps/Code to reproduce bug**
```bash
python /home/ubuntu/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --input_name_or_path meta-llama/Llama-3.2-1B-Instruct --output_path Llama-3.2-1B-Instruct.nemo --precision=bf16
Traceback (most recent call last):
File "/home/ubuntu/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py", line 34, in <module>
from nemo.collections.nlp.models.language_modeling.megatron_gpt_model import MegatronGPTModel
File "/home/ubuntu/NeMo/nemo/collections/nlp/__init__.py", line 15, in <module>
from nemo.collections.nlp import data, losses, models, modules
File "/home/ubuntu/NeMo/nemo/collections/nlp/models/__init__.py", line 16, in <module>
from nemo.collections.nlp.models.duplex_text_normalization import (
File "/home/ubuntu/NeMo/nemo/collections/nlp/models/duplex_text_normalization/__init__.py", line 15, in <module>
from nemo.collections.nlp.models.duplex_text_normalization.duplex_decoder import DuplexDecoderModel
File "/home/ubuntu/NeMo/nemo/collections/nlp/models/duplex_text_normalization/duplex_decoder.py", line 34, in <module>
from nemo.collections.nlp.models.nlp_model import NLPModel
File "/home/ubuntu/NeMo/nemo/collections/nlp/models/nlp_model.py", line 40, in <module>
from nemo.collections.nlp.parts.nlp_overrides import NLPSaveRestoreConnector
File "/home/ubuntu/NeMo/nemo/collections/nlp/parts/nlp_overrides.py", line 68, in <module>
from nemo.collections.nlp.modules.common.megatron.transformer import AutocastTransformerLayer, ParallelTransformerLayer
File "/home/ubuntu/NeMo/nemo/collections/nlp/modules/common/megatron/transformer.py", line 28, in <module>
from nemo.collections.nlp.modules.common.megatron.adapters.parallel_adapters import (
File "/home/ubuntu/NeMo/nemo/collections/nlp/modules/common/megatron/adapters/parallel_adapters.py", line 27, in <module>
from megatron.core.dist_checkpointing.mapping import ShardedStateDict
ModuleNotFoundError: No module named 'megatron.core.dist_checkpointing'
```
**Expected behavior**
A clear and concise description of what you expected to happen.
**Environment overview (please complete the following information)**
- Environment location: Cloud(LambdaLabs)
- Method of NeMo install: from source
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version: debian
- PyTorch version: 2.4.1+cu124
- Python version: Python 3.10.16
**Additional context**
GPU model: A100 SXM4
| {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11838/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11838/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11837 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11837/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11837/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11837/events | https://github.com/NVIDIA/NeMo/pull/11837 | 2,784,489,613 | PR_kwDOC_bI7s6Hj0Tp | 11,837 | add dataset_root to SpecterDataModule | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12769533435) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12830798905) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-13T16:13:48 | 2025-01-17T22:09:15 | 2025-01-17T22:09:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11837",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11837",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11837.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11837.patch",
"merged_at": "2025-01-17T22:09:14"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11837/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11837/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11836 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11836/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11836/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11836/events | https://github.com/NVIDIA/NeMo/issues/11836 | 2,784,367,262 | I_kwDOC_bI7s6l9hKe | 11,836 | Creating a hf to nemo converter for phi 3 mini instruct | {
"login": "LopezGG",
"id": 1724189,
"node_id": "MDQ6VXNlcjE3MjQxODk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1724189?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LopezGG",
"html_url": "https://github.com/LopezGG",
"followers_url": "https://api.github.com/users/LopezGG/followers",
"following_url": "https://api.github.com/users/LopezGG/following{/other_user}",
"gists_url": "https://api.github.com/users/LopezGG/gists{/gist_id}",
"starred_url": "https://api.github.com/users/LopezGG/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/LopezGG/subscriptions",
"organizations_url": "https://api.github.com/users/LopezGG/orgs",
"repos_url": "https://api.github.com/users/LopezGG/repos",
"events_url": "https://api.github.com/users/LopezGG/events{/privacy}",
"received_events_url": "https://api.github.com/users/LopezGG/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"@LopezGG the Phi3 mini has already been added [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/gpt/model/phi3mini.py). The steps to do the fine-tuning with Phi3 are also described in the recipe as [well](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/recipes/phi3_mini_4k_instruct.py). If you look at the first link, the qkv reshaping is performed to load Phi model into the megatron_gpt_model.",
"@LopezGG To add on to what @mayani-nv has said: Phi 3 mini is supported in NeMo 2.0, and we recommend you switch to 2.0 for new explorations with NeMo. You can find quick start instructions [here](https://docs.nvidia.com/nemo-framework/user-guide/latest/nemo-2.0/quickstart.html). ",
"@LopezGG a dummy example to use this Phi3 model can be run as following steps\n\n```\n# start the NeMo container interactively\ndocker run -it --rm --gpus all nvcr.io/nvidia/nemo:24.12\n\n# download the ckpt \npython3 download_phi3ckpt.py\n\n# set the NEMO_HOME path\nexport NEMO_HOME=/root/.cache/nemo\n\n# run the inference to ensure parity with the HF format\npython3 phi3_generate.py\n```\nThe scripts used above are [download_phi3ckpkt.py](https://github.com/mayani-nv/NeMo/blob/phi3mini4k/scripts/llm/download_phi3ckpt.py) and [phi3_generate.py](https://github.com/mayani-nv/NeMo/blob/phi3mini4k/scripts/llm/phi3_generate.py)",
"amazing. Thank you @mayani-nv. I was just trying to get this done by toying around with HFPhi3Importer & HFPhi3Exporter. This is straightforward",
"@mayani-nv : I got my checkpoint but when I finetune I see that is missing some metadata\n\n<img width=\"635\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/584941fb-f1a3-4546-b2be-6f56401a0492\" />\n\nWhat would be a good way to debug this. I am attaching all the files except weights in case that might be helpful\n\n[nemo_phi_instruct.zip](https://github.com/user-attachments/files/18411032/nemo_phi_instruct.zip)",
"Can you share the command how were you doing the finetuning? Are you using the [recipe](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/recipes/phi3_mini_4k_instruct.py)? The way I do it is using the following cli command inside the container\n\n```\nnemo llm finetune --factory phi3_mini_4k_instruct\n[NeMo W 2025-01-14 06:01:30 nemo_logging:361] /usr/local/lib/python3.10/dist-packages/pyannote/core/notebook.py:134: MatplotlibDeprecationWarning: The get_cmap function was deprecated in Matplotlib 3.7 and will be removed in 3.11. Use ``matplotlib.colormaps[name]`` or ``matplotlib.colormaps.get_cmap()`` or ``pyplot.get_cmap()`` instead.\n cm = get_cmap(\"Set1\")\n.......\n.......\nTraining epoch 0, iteration 110/999 | lr: 9.902e-05 | global_batch_size: 128 | global_step: 110 | reduced_train_loss: 0.1471 | consumed_samples: 14208 | val_loss: 0.2043\nTraining epoch 0, iteration 111/999 | lr: 9.899e-05 | global_batch_size: 128 | global_step: 111 | reduced_train_loss: 0.2019 | consumed_samples: 14336 | val_loss: 0.2043\nTraining epoch 0, iteration 112/999 | lr: 9.895e-05 | global_batch_size: 128 | global_step: 112 | reduced_train_loss: 0.1712 | consumed_samples: 14464 | val_loss: 0.2043\nTraining epoch 0, iteration 113/999 | lr: 9.892e-05 | global_batch_size: 128 | global_step: 113 | reduced_train_loss: 0.2207 | consumed_samples: 14592 | val_loss: 0.2043\nTraining epoch 0, iteration 114/999 | lr: 9.888e-05 | global_batch_size: 128 | global_step: 114 | reduced_train_loss: 0.2231 | consumed_samples: 14720 | val_loss: 0.2043\nTraining epoch 0, iteration 115/999 | lr: 9.885e-05 | global_batch_size: 128 | global_step: 115 | reduced_train_loss: 0.2529 | consumed_samples: 14848 | val_loss: 0.2043\nTraining epoch 0, iteration 116/999 | lr: 9.881e-05 | global_batch_size: 128 | global_step: 116 | reduced_train_loss: 0.209 | consumed_samples: 14976 | val_loss: 0.2043\nTraining epoch 0, iteration 117/999 | lr: 9.878e-05 | global_batch_size: 128 | global_step: 117 | reduced_train_loss: 0.2174 | consumed_samples: 15104 | val_loss: 0.2043\nTraining epoch 0, iteration 118/999 | lr: 9.874e-05 | global_batch_size: 128 | global_step: 118 | reduced_train_loss: 0.2147 | consumed_samples: 15232 | val_loss: 0.2043\nTraining epoch 0, iteration 119/999 | lr: 9.87e-05 | global_batch_size: 128 | global_step: 119 | reduced_train_loss: 0.167 | consumed_samples: 15360 | val_loss: 0.2043\n[NeMo I 2025-01-14 07:18:56 model_checkpoint:497] Scheduled async checkpoint save for /workspace/nemo_experiments/default/2025-01-14_06-01-34/checkpoints/model_name=0--val_loss=0.20-step=119-consumed_samples=15360.0-last.ckpt\n```\nAlso, I have only added support for the 4k context length so are you using the other variant?\n@cuichenx do you happen to know the error cause?",
"Extending to 8k could be an issue. I am calling on your recipe to increase the context length (for starters, I left cp=1)\n[phi3_mini_4k_instruct_4k_8k_recipe](https://github.com/user-attachments/files/18414100/phi3_mini_4k_instruct_4k_8k.txt) (a variation of https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/recipes/llama3_8b_16k.py)\n\n<img width=\"\n631\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/25aebfcf-4488-4cf0-97d5-e4e129760559\" />"
] | 2025-01-13T15:36:11 | 2025-01-14T17:42:46 | 2025-01-14T06:08:53 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi ,
I am following the guidelines https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/checkpoints/dev_guide.html to create a converter. It looks like in addition to qkv reshaping and layer name mapping we need to load phi model into megatron_gpt_model. @cuichenx and @mayani-nv I noticed you have some PRs with phi 3 mini. Would you by any chance have a sample code. I've added code for "_create_rename_keys_" and "_adjust_tensor_shapes_" based on your code. I am struggling to load it into megatron_gpt_model.
and I suspect its because I need something like https://github.com/NVIDIA/NeMo/blob/7f3ac6b88289048643d445ec752a4d21547f2788/nemo/collections/nlp/models/language_modeling/megatron/gemma2/gemma2_spec.py#L28
Is there someone I could work with to improve the documentation or to simplify the process for this conversion ?
thanks! | {
"login": "LopezGG",
"id": 1724189,
"node_id": "MDQ6VXNlcjE3MjQxODk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1724189?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LopezGG",
"html_url": "https://github.com/LopezGG",
"followers_url": "https://api.github.com/users/LopezGG/followers",
"following_url": "https://api.github.com/users/LopezGG/following{/other_user}",
"gists_url": "https://api.github.com/users/LopezGG/gists{/gist_id}",
"starred_url": "https://api.github.com/users/LopezGG/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/LopezGG/subscriptions",
"organizations_url": "https://api.github.com/users/LopezGG/orgs",
"repos_url": "https://api.github.com/users/LopezGG/repos",
"events_url": "https://api.github.com/users/LopezGG/events{/privacy}",
"received_events_url": "https://api.github.com/users/LopezGG/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11836/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11836/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11835 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11835/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11835/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11835/events | https://github.com/NVIDIA/NeMo/issues/11835 | 2,783,947,625 | I_kwDOC_bI7s6l76tp | 11,835 | Annoyed NeMo User Rant | {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2025-01-13T13:21:18 | 2025-01-13T14:46:23 | 2025-01-13T14:46:23 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I have been using NeMo for the last 3 years mainly for speech. While the speech part is okay to use, the NLP/LLM side is an absolute hell. There has never been a single time that I was able to install without an issue.
You try to install NeMo then mamba-ssm fails, you spend another 3 hrs trying to resolve it, you give up and delete your server for a fresh installation to end up with the same issue. Even if you solve this with the grace of God, next you need to figure out the issue with Megatron, then transformer-engine then apex. Endless non stop horrible experience. :(
| {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11835/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11835/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11834 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11834/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11834/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11834/events | https://github.com/NVIDIA/NeMo/pull/11834 | 2,783,621,833 | PR_kwDOC_bI7s6Hg0sZ | 11,834 | Use _get_mlp_module_spec from Megatron Core rather than redefine locally | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-13T10:51:24 | 2025-01-13T15:35:18 | 2025-01-13T15:35:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11834",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11834",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11834.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11834.patch",
"merged_at": "2025-01-13T15:35:16"
} | # What does this PR do ?
Reuse `_get_mlp_module_spec ` from Megatron Core to improve stability. This also fixes Mixtral loading bug as the current implementation fails with:
```
File "/opt/megatron-lm/megatron/core/transformer/moe/moe_layer.py", line 109, in __init__
self.experts = build_module(self.submodules.experts, self.num_local_experts, self.config)
File "/opt/megatron-lm/megatron/core/transformer/spec_utils.py", line 82, in build_module
module = import_module(spec_or_module.module)
AttributeError: 'MLPSubmodules' object has no attribute 'module' when instantiating MoELayer when instantiating TransformerLayer
```
due to recent refactoring in Megatron https://github.com/NVIDIA/Megatron-LM/commit/aa2a45dd44516925ba5c0579eb262caf48a81a1b.
**Collection**: NLP / LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11834/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11834/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11833 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11833/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11833/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11833/events | https://github.com/NVIDIA/NeMo/pull/11833 | 2,783,486,311 | PR_kwDOC_bI7s6HgWvj | 11,833 | Bugfix for output_generation_logits in tensorrtllm (#11820) | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2025-01-13T09:50:39 | 2025-01-13T15:35:34 | 2025-01-13T15:35:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11833",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11833",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11833.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11833.patch",
"merged_at": "2025-01-13T15:35:31"
} | # What does this PR do ?
See https://github.com/NVIDIA/NeMo/pull/11820
**Collection**: NLP / LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11833/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11833/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11832 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11832/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11832/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11832/events | https://github.com/NVIDIA/NeMo/pull/11832 | 2,782,836,562 | PR_kwDOC_bI7s6HeG03 | 11,832 | update nemo2sftpeft tutorial container verison | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2025-01-13T01:43:10 | 2025-01-14T21:58:07 | 2025-01-14T21:58:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11832",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11832",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11832.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11832.patch",
"merged_at": "2025-01-14T21:58:06"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11832/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11832/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11831 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11831/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11831/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11831/events | https://github.com/NVIDIA/NeMo/pull/11831 | 2,782,780,446 | PR_kwDOC_bI7s6Hd6hY | 11,831 | chore(beep boop 🤖): Bump `MCORE_TAG=c76410a...` (2025-01-13) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-13T00:24:49 | 2025-01-16T20:29:16 | 2025-01-16T20:29:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11831",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11831",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11831.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11831.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=c76410adec0eb1f81544344fcc2c404166e9913d`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11831/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11831/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11830 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11830/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11830/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11830/events | https://github.com/NVIDIA/NeMo/pull/11830 | 2,782,662,357 | PR_kwDOC_bI7s6Hdijd | 11,830 | Fix calculating num_available_samples | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.data.language_modeling.megatron.megatron_batch_samplers\nnemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py:216:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py:217:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py:217:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py:139:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py:140:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py:176:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.31/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @huvunvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12736585203) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-12T19:48:51 | 2025-01-13T18:14:16 | 2025-01-13T18:14:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11830",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11830",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11830.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11830.patch",
"merged_at": "2025-01-13T18:14:14"
} | # What does this PR do ?
Fix how we calculate the num_available_samples for the case of training more than one epoch on the line:
https://github.com/NVIDIA/NeMo/blob/7f3ac6b88289048643d445ec752a4d21547f2788/nemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py#L129
When interrupting the training job after one epoch and relaunching, `self.consumed_samples` will larger than `self.total_samples`, the calculation will result in negative value.
=> Fix: Similar to the fix on line: line:https://github.com/NVIDIA/NeMo/blob/7f3ac6b88289048643d445ec752a4d21547f2788/nemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py#L226
We also set:
`num_available_samples: int = self.total_samples - self.consumed_samples % self.total_samples`
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11830/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11830/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11829 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11829/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11829/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11829/events | https://github.com/NVIDIA/NeMo/pull/11829 | 2,782,659,925 | PR_kwDOC_bI7s6HdiE9 | 11,829 | Fix running peft with nemo2 local job | {
"login": "guyueh1",
"id": 140554423,
"node_id": "U_kgDOCGCwtw",
"avatar_url": "https://avatars.githubusercontent.com/u/140554423?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guyueh1",
"html_url": "https://github.com/guyueh1",
"followers_url": "https://api.github.com/users/guyueh1/followers",
"following_url": "https://api.github.com/users/guyueh1/following{/other_user}",
"gists_url": "https://api.github.com/users/guyueh1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guyueh1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guyueh1/subscriptions",
"organizations_url": "https://api.github.com/users/guyueh1/orgs",
"repos_url": "https://api.github.com/users/guyueh1/repos",
"events_url": "https://api.github.com/users/guyueh1/events{/privacy}",
"received_events_url": "https://api.github.com/users/guyueh1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"closing this"
] | 2025-01-12T19:42:20 | 2025-01-13T16:32:09 | 2025-01-13T16:32:09 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11829",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11829",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11829.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11829.patch",
"merged_at": null
} | # What does this PR do ?
Fix the error when running llama3 and llama31 peft with nemo2 local job.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "guyueh1",
"id": 140554423,
"node_id": "U_kgDOCGCwtw",
"avatar_url": "https://avatars.githubusercontent.com/u/140554423?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guyueh1",
"html_url": "https://github.com/guyueh1",
"followers_url": "https://api.github.com/users/guyueh1/followers",
"following_url": "https://api.github.com/users/guyueh1/following{/other_user}",
"gists_url": "https://api.github.com/users/guyueh1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guyueh1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guyueh1/subscriptions",
"organizations_url": "https://api.github.com/users/guyueh1/orgs",
"repos_url": "https://api.github.com/users/guyueh1/repos",
"events_url": "https://api.github.com/users/guyueh1/events{/privacy}",
"received_events_url": "https://api.github.com/users/guyueh1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11829/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11829/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11828 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11828/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11828/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11828/events | https://github.com/NVIDIA/NeMo/issues/11828 | 2,782,536,637 | I_kwDOC_bI7s6l2iO9 | 11,828 | can't load saved fp8 checkpoint when resume training (MOE model) | {
"login": "switiz",
"id": 12544231,
"node_id": "MDQ6VXNlcjEyNTQ0MjMx",
"avatar_url": "https://avatars.githubusercontent.com/u/12544231?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/switiz",
"html_url": "https://github.com/switiz",
"followers_url": "https://api.github.com/users/switiz/followers",
"following_url": "https://api.github.com/users/switiz/following{/other_user}",
"gists_url": "https://api.github.com/users/switiz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/switiz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/switiz/subscriptions",
"organizations_url": "https://api.github.com/users/switiz/orgs",
"repos_url": "https://api.github.com/users/switiz/repos",
"events_url": "https://api.github.com/users/switiz/events{/privacy}",
"received_events_url": "https://api.github.com/users/switiz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [] | 2025-01-12T15:13:59 | 2025-01-12T15:13:59 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | The reproduction steps and detailed information have been documented on the Megatron-LM side.
I will open the same issue on the NeMo side.
https://github.com/NVIDIA/Megatron-LM/issues/1350
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11828/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11828/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11827 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11827/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11827/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11827/events | https://github.com/NVIDIA/NeMo/pull/11827 | 2,782,206,166 | PR_kwDOC_bI7s6HcLg8 | 11,827 | chore(beep boop 🤖): Bump `MCORE_TAG=726da58...` (2025-01-12) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-12T00:25:25 | 2025-01-16T20:29:19 | 2025-01-16T20:29:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11827",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11827",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11827.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11827.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=726da588ead74ac7f5e62324dea478c1dabb4150`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11827/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11827/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11826 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11826/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11826/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11826/events | https://github.com/NVIDIA/NeMo/issues/11826 | 2,782,047,331 | I_kwDOC_bI7s6l0qxj | 11,826 | Canary ouputs English for Arabic Speech | {
"login": "BenoitWang",
"id": 41187612,
"node_id": "MDQ6VXNlcjQxMTg3NjEy",
"avatar_url": "https://avatars.githubusercontent.com/u/41187612?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BenoitWang",
"html_url": "https://github.com/BenoitWang",
"followers_url": "https://api.github.com/users/BenoitWang/followers",
"following_url": "https://api.github.com/users/BenoitWang/following{/other_user}",
"gists_url": "https://api.github.com/users/BenoitWang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BenoitWang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BenoitWang/subscriptions",
"organizations_url": "https://api.github.com/users/BenoitWang/orgs",
"repos_url": "https://api.github.com/users/BenoitWang/repos",
"events_url": "https://api.github.com/users/BenoitWang/events{/privacy}",
"received_events_url": "https://api.github.com/users/BenoitWang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"@BenoitWang Can you try `ar-SA`? We may have just assigned Arabic language under a Saudi dialect tag for that round.",
"Hi @tbartley94, just tried but still got English outputs.",
"hmm, okay will look into it",
"@BenoitWang It looks like you're using Riva client to run Canary-1b model. If so, you need to pass language code in the client side. For example, `riva_asr_client --language_code=ar-AR --audio_file=ar-AR_sample.wav`. Could you try with `--language_code` param? ",
"Hi @myungjongk, thank you that works much better. However when I looked into its transcriptions, compared with parakeet-ctc-1.1b-concat (the 1st image), it still generates very often the English tokens (the 2nd image), which degrades both the WER and CER quite a lot. The 20 samples are from CommonVoice 18.0. Am I still missing something please?\n\n<img width=\"645\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/c753bae8-6338-4164-b3eb-dfd0de6fa9b2\" />\n\n<img width=\"645\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/4950a925-07ba-48bd-9839-282ca13cf4d1\" />\n\nIn fact we're running this [Arabic ASR leaderboard](https://huggingface.co/spaces/elmresearchcenter/open_universal_arabic_asr_leaderboard), and we find that it performs badly compared to the other models, but we do wish to include Canary if this get fixed, thanks for your help @tbartley94 @myungjongk .",
"Another observation is that both Canary 1b and 0.6b-turbo hallucinate quite often on Arabic speech, generating repeated tokens, which significantly increases CER.\n\n<img width=\"885\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/017e9162-8729-46a8-a647-4ea31595eb53\" />",
"Ooh, this is a good catch. Thanks for catching this. \n\n@myungjongk This may be a deployment issue, I'll evaluate with the NeMo model on my end to see if there's something that didn't pop up in our evaluations."
] | 2025-01-11T18:05:15 | 2025-01-16T18:54:09 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Hello, I am trying to infer [Canary 1b](https://catalog.ngc.nvidia.com/orgs/nvidia/teams/riva/models/canary-riva-1b) for Arabic ASR with Riva quick start 2.18.0. According to the description it has already supported Arabic, but it outputs English instead of Arabic tokens.
Here's a partial extract of my config.sh
```
service_enabled_asr=true
service_enabled_nlp=false
service_enabled_tts=false
service_enabled_nmt=false
asr_language_code=("ar-AR")
asr_acoustic_model=("canary")
asr_acoustic_model_variant=("1b")
use_existing_rmirs=false
```
When I used the same config to infer Parakeet 1.1b_unified_ml_cs_concat and Parakeet 1.1b_unified_ml_cs_universal, they do output Arabic tokens, so I guess the issue is within the Canary model.
Any idea please? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11826/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11826/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11825 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11825/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11825/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11825/events | https://github.com/NVIDIA/NeMo/issues/11825 | 2,781,946,312 | I_kwDOC_bI7s6l0SHI | 11,825 | when i use container to do sft for any model, it has context not found error | {
"login": "munger1985",
"id": 29350280,
"node_id": "MDQ6VXNlcjI5MzUwMjgw",
"avatar_url": "https://avatars.githubusercontent.com/u/29350280?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/munger1985",
"html_url": "https://github.com/munger1985",
"followers_url": "https://api.github.com/users/munger1985/followers",
"following_url": "https://api.github.com/users/munger1985/following{/other_user}",
"gists_url": "https://api.github.com/users/munger1985/gists{/gist_id}",
"starred_url": "https://api.github.com/users/munger1985/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/munger1985/subscriptions",
"organizations_url": "https://api.github.com/users/munger1985/orgs",
"repos_url": "https://api.github.com/users/munger1985/repos",
"events_url": "https://api.github.com/users/munger1985/events{/privacy}",
"received_events_url": "https://api.github.com/users/munger1985/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"09-53\ni.finetune/0 GPU available: True (cuda), used: True\ni.finetune/0 TPU available: False, using: 0 TPU cores\ni.finetune/0 HPU available: False, using: 0 HPUs\ni.finetune/0 [NeMo W 2025-01-11 15:09:53 nemo_logger:173] \"update_logger_directory\" is True. Overwriting tensorboard logger \"save_dir\" to tb_logs\ni.finetune/0 [NeMo W 2025-01-11 15:09:53 nemo_logger:189] The Trainer already contains a ModelCheckpoint callback. This will be overwritten.\ni.finetune/0 [NeMo W 2025-01-11 15:09:53 nemo_logger:212] The checkpoint callback was told to monitor a validation value and trainer's max_steps was set to 1000. Please ensure that max_steps will run for at least 1 epochs to ensure that checkpointing will not error out.\ni.finetune/0 Traceback (most recent call last):\ni.finetune/0 File \"/opt/NeMo/nemo/lightning/io/api.py\", line 57, in load_context\ni.finetune/0 return load(path, output_type=TrainerContext, subpath=subpath, build=build)\ni.finetune/0 File \"/opt/NeMo/nemo/lightning/io/mixin.py\", line 720, in load\ni.finetune/0 raise FileNotFoundError(f\"No such file: '{_path}'\")\ni.finetune/0 FileNotFoundError: No such file: '/root/.cache/nemo/models/baichuan-inc/Baichuan2-7B-Base'\ni.finetune/0\ni.finetune/0 During handling of the above exception, another exception occurred:\ni.finetune/0\ni.finetune/0 Traceback (most recent call last):\ni.finetune/0 File \"/usr/lib/python3.10/runpy.py\", line 196, in _run_module_as_main\ni.finetune/0 return _run_code(code, main_globals, None,\ni.finetune/0 File \"/usr/lib/python3.10/runpy.py\", line 86, in _run_code\ni.finetune/0 exec(code, run_globals)\ni.finetune/0 File \"/opt/NeMo-Run/src/nemo_run/core/runners/fdl_runner.py\", line 66, in <module>\ni.finetune/0 fdl_runner_app()\ni.finetune/0 File \"/usr/local/lib/python3.10/dist-packages/typer/main.py\", line 338, in __call__\ni.finetune/0 raise e\ni.finetune/0 File \"/usr/local/lib/python3.10/dist-packages/typer/main.py\", line 321, in __call__\ni.finetune/0 return get_command(self)(*args, **kwargs)\ni.finetune/0 File \"/usr/local/lib/python3.10/dist-packages/click/core.py\", line 1157, in __call__\ni.finetune/0 return self.main(*args, **kwargs)\ni.finetune/0 File \"/usr/local/lib/python3.10/dist-packages/typer/core.py\", line 665, in main\ni.finetune/0 return _main(\ni.finetune/0 File \"/usr/local/lib/python3.10/dist-packages/typer/core.py\", line 197, in _main\ni.finetune/0 rv = self.invoke(ctx)\ni.finetune/0 File \"/usr/local/lib/python3.10/dist-packages/click/core.py\", line 1434, in invoke\ni.finetune/0 return ctx.invoke(self.callback, **ctx.params)\ni.finetune/0 File \"/usr/local/lib/python3.10/dist-packages/click/core.py\", line 783, in invoke\ni.finetune/0 return __callback(*args, **kwargs)\ni.finetune/0 File \"/usr/local/lib/python3.10/dist-packages/typer/main.py\", line 703, in wrapper\ni.finetune/0 return callback(**use_params)\ni.finetune/0 File \"/opt/NeMo-Run/src/nemo_run/core/runners/fdl_runner.py\", line 62, in fdl_direct_run\ni.finetune/0 fdl_fn()\ni.finetune/0 File \"/opt/NeMo/nemo/collections/llm/api.py\", line 201, in finetune\ni.finetune/0 return train(\ni.finetune/0 File \"/opt/NeMo/nemo/collections/llm/api.py\", line 96, in train\ni.finetune/0 app_state = _setup(\ni.finetune/0 File \"/opt/NeMo/nemo/collections/llm/api.py\", line 858, in _setup\ni.finetune/0 resume.setup(trainer, model)\ni.finetune/0 File \"/opt/NeMo/nemo/lightning/resume.py\", line 140, in setup\ni.finetune/0 _try_restore_tokenizer(model, context_path)\ni.finetune/0 File \"/opt/NeMo/nemo/lightning/resume.py\", line 44, in _try_restore_tokenizer\ni.finetune/0 tokenizer = load_context(ckpt_path, \"model.tokenizer\")\ni.finetune/0 File \"/opt/NeMo/nemo/lightning/io/api.py\", line 64, in load_context\ni.finetune/0 return load(path, output_type=TrainerContext, subpath=subpath, build=build)\ni.finetune/0 File \"/opt/NeMo/nemo/lightning/io/mixin.py\", line 720, in load\ni.finetune/0 raise FileNotFoundError(f\"No such file: '{_path}'\")\ni.finetune/0 FileNotFoundError: No such file: '/root/.cache/nemo/models/baichuan-inc/Baichuan2-7B-Base/context'\n[15:09:55] INFO Job nemo.collections.llm.api.finetune-v1xxmknq0xfmmc finished: FAILED ",
"nothing did i succeed"
] | 2025-01-11T15:05:52 | 2025-01-11T15:10:54 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | container docker pull nvcr.io/nvidia/nemo:24.12
nemo llm finetune -f llama32_1b peft=lora # acceptable values are lora/dora/none
it has error like No such file: '/root/.cache/nemo/models/meta-llama/Llama-3.2-1B/context'
the document i followed
https://docs.nvidia.com/nemo-framework/user-guide/latest/sft_peft/peft_nemo2.html
dir="/checkpoints/llama3.2_1b", #
here, what is the dir , isn't it the dir for hugginface model downloaded? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11825/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11825/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11824 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11824/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11824/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11824/events | https://github.com/NVIDIA/NeMo/issues/11824 | 2,781,772,516 | I_kwDOC_bI7s6lznrk | 11,824 | How to use nemo docker container as base image | {
"login": "famda",
"id": 26621392,
"node_id": "MDQ6VXNlcjI2NjIxMzky",
"avatar_url": "https://avatars.githubusercontent.com/u/26621392?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/famda",
"html_url": "https://github.com/famda",
"followers_url": "https://api.github.com/users/famda/followers",
"following_url": "https://api.github.com/users/famda/following{/other_user}",
"gists_url": "https://api.github.com/users/famda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/famda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/famda/subscriptions",
"organizations_url": "https://api.github.com/users/famda/orgs",
"repos_url": "https://api.github.com/users/famda/repos",
"events_url": "https://api.github.com/users/famda/events{/privacy}",
"received_events_url": "https://api.github.com/users/famda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"Hi, you can use this as the start of your dockerfile\n\n```\nARG NEMOFW_VERSION=24.09\nFROM nvcr.io/nvidia/nemo:$NEMOFW_VERSION\n```",
"@wheynelau thanks for your reply.\nThat is what I'm doing. Here is my dockerfile:\n\n```dorckerfile\nFROM nvcr.io/nvidia/nemo:24.12 AS base\nEXPOSE 8080\n\n# Install PowerShell Core\nRUN apt-get update && apt-get install -y wget \\\n && wget -q https://packages.microsoft.com/config/ubuntu/24.04/packages-microsoft-prod.deb \\\n && dpkg -i packages-microsoft-prod.deb \\\n && apt-get update \\\n && apt-get install -y powershell \\\n && rm packages-microsoft-prod.deb \\\n && rm -rf /var/lib/apt/lists/*\n\n# Install PowerShell Core\nRUN apt-get update && apt-get install -y wget \\\n && wget -q https://packages.microsoft.com/config/ubuntu/24.04/packages-microsoft-prod.deb \\\n && dpkg -i packages-microsoft-prod.deb \\\n && apt-get update \\\n && apt-get install -y powershell \\\n && rm packages-microsoft-prod.deb \\\n && rm -rf /var/lib/apt/lists/*\n\n# Install dependencies aspnetcore\nRUN apt-get update && apt-get install -y \\\n apt-transport-https \\\n software-properties-common\n\n# Download and run the Microsoft installation script\nRUN wget https://dot.net/v1/dotnet-install.sh -O dotnet-install.sh \\\n && chmod +x dotnet-install.sh \\\n && ./dotnet-install.sh --runtime aspnetcore --version 9.0.0\n\n# Set the environment variables \nENV DOTNET_ROOT=/root/.dotnet \nENV PATH=$PATH:/root/.dotnet\n\nWORKDIR /app\nCOPY ../Diarization/requirements.txt .\nRUN pip install --no-cache-dir -r requirements.txt\nCOPY ../Diarization/audio ./audio\n\nFROM mcr.microsoft.com/dotnet/sdk:9.0 AS build\nARG BUILD_CONFIGURATION=Release\nWORKDIR /src\nCOPY [\"Worker/Worker.csproj\", \"Worker/\"]\nRUN dotnet restore \"./Worker/Worker.csproj\"\nCOPY . .\nWORKDIR \"/src/Worker\"\nRUN dotnet build \"./Worker.csproj\" -c $BUILD_CONFIGURATION -o /app/build\n\nFROM build AS publish\nARG BUILD_CONFIGURATION=Release\nRUN dotnet publish \"./Worker.csproj\" -c $BUILD_CONFIGURATION -o /app/publish /p:UseAppHost=false\n\nFROM base AS final\nWORKDIR /app\nCOPY --from=publish /app/publish .\nENTRYPOINT [\"dotnet\", \"Worker.dll\"]\n\n```\n\nAnd here is my requirements.txt file:\n\n```\nfaster-whisper\npydub\ndemucs\nsoundfile\nCython\npackaging\n```\n\nThis image has 97.35GB and this is the issue. :)\n\n\n\n\n\n\n\n"
] | 2025-01-11T11:27:30 | 2025-01-13T08:55:22 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I'm trying to create a docker image that uses nemo as the base image.
I have a python project with some scripts (including a requirements.txt file with some additional dependencies) that I'm containerizing on that same image.
The Nemo base image is around 29GB in size but when I run pip install on the requirements file the output is around 100GB because it reinstalls everything and it takes ages to complete.
I'm trying to learn how to use this and make some cool examples with ASR and TTS for research/personal training.
I'm pretty sure I'm doing something wrong on this dependency hell. 😀
It would be nice to have a simple dockerfile that uses nvidia/nemo as base image and a simple python project in it.
Can someone help, please?
Thanks in advance. | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11824/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11824/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11823 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11823/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11823/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11823/events | https://github.com/NVIDIA/NeMo/pull/11823 | 2,781,503,723 | PR_kwDOC_bI7s6HZ3yQ | 11,823 | fix: add back in missing config values of hf export for llama3.1 and 3.2 | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.llama\nnemo/collections/llm/gpt/model/llama.py:455:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:456:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:467:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:468:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:469:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:470:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:471:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:472:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:474:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:475:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:476:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:477:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:688:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:47:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:67:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:76:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:85:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:94:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:116:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:137:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:147:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:159:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:169:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:180:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:191:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:204:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:217:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:223:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:229:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:240:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:244:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:256:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:293:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:337:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:359:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:379:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:383:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:419:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:530:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:680:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 8.73/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-11T01:39:33 | 2025-01-16T16:50:56 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11823",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11823",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11823.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11823.patch",
"merged_at": null
} | # What does this PR do ?
The only config not preserved is max_position_embeddings since we lose that information b/c nemo uses `seq_length`. Even though the original value would be lost during an `export(import(ckpt))` conversion, it's probably a confusing UX if we allow this to be configurable upon export since most will just use the value that the model has been trained on.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11823/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11823/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11822 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11822/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11822/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11822/events | https://github.com/NVIDIA/NeMo/pull/11822 | 2,781,460,852 | PR_kwDOC_bI7s6HZuj3 | 11,822 | chore(beep boop 🤖): Bump `MCORE_TAG=726da58...` (2025-01-11) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-11T00:22:39 | 2025-01-16T20:29:22 | 2025-01-16T20:29:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11822",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11822",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11822.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11822.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=726da588ead74ac7f5e62324dea478c1dabb4150`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11822/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11822/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11821 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11821/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11821/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11821/events | https://github.com/NVIDIA/NeMo/pull/11821 | 2,781,338,700 | PR_kwDOC_bI7s6HZSpx | 11,821 | [WIP] Use FSDP2 for nemo-lite | {
"login": "yuanzhedong",
"id": 5069709,
"node_id": "MDQ6VXNlcjUwNjk3MDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5069709?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yuanzhedong",
"html_url": "https://github.com/yuanzhedong",
"followers_url": "https://api.github.com/users/yuanzhedong/followers",
"following_url": "https://api.github.com/users/yuanzhedong/following{/other_user}",
"gists_url": "https://api.github.com/users/yuanzhedong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yuanzhedong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yuanzhedong/subscriptions",
"organizations_url": "https://api.github.com/users/yuanzhedong/orgs",
"repos_url": "https://api.github.com/users/yuanzhedong/repos",
"events_url": "https://api.github.com/users/yuanzhedong/events{/privacy}",
"received_events_url": "https://api.github.com/users/yuanzhedong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:60:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/peft/hf.py:95:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/sft/hf.py:71:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/sft/hf.py:137:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/sft/hf.py:67:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.63/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-10T22:42:28 | 2025-01-13T19:51:17 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11821",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11821",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11821.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11821.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11821/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11821/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11820 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11820/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11820/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11820/events | https://github.com/NVIDIA/NeMo/pull/11820 | 2,781,331,697 | PR_kwDOC_bI7s6HZRCz | 11,820 | Bugfix for output_generation_logits in tensorrtllm | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @athitten 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12718762026) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-10T22:38:04 | 2025-01-11T18:48:28 | 2025-01-11T18:48:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11820",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11820",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11820.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11820.patch",
"merged_at": "2025-01-11T18:48:26"
} | # What does this PR do ?
Gets the value of `generation_logits_available` from `inputs["output_generation_logits"][0][0]` so that it is a bool as opposed to `inputs["output_generation_logits"]` where it's a np array and can give error when the array is len > 1.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11820/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11820/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11819 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11819/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11819/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11819/events | https://github.com/NVIDIA/NeMo/pull/11819 | 2,780,910,409 | PR_kwDOC_bI7s6HXwo_ | 11,819 | Cherry pick `8x22b seq len (11788)` into `r2.1.1` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:158:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:298:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:119:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:133:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:168:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:269:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:316:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.run.plugins\nnemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)\nnemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)\nnemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)\nnemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/run/plugins.py:183:0: C0301: Line too long (174/119) (line-too-long)\nnemo/lightning/run/plugins.py:259:0: C0301: Line too long (150/119) (line-too-long)\nnemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:158:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:298:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:119:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:133:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:168:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:269:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:316:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.run.plugins\nnemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)\nnemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)\nnemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)\nnemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/run/plugins.py:183:0: C0301: Line too long (174/119) (line-too-long)\nnemo/lightning/run/plugins.py:259:0: C0301: Line too long (150/119) (line-too-long)\nnemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:158:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:298:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:119:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:133:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:168:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:269:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:316:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.run.plugins\nnemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)\nnemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)\nnemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)\nnemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/run/plugins.py:183:0: C0301: Line too long (174/119) (line-too-long)\nnemo/lightning/run/plugins.py:259:0: C0301: Line too long (150/119) (line-too-long)\nnemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Closing this. It can be part of 25.02."
] | 2025-01-10T19:09:23 | 2025-01-20T09:37:57 | 2025-01-20T09:37:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11819",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11819",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11819.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11819.patch",
"merged_at": null
} | beep boop [🤖]: Hi @malay-nagda 👋,
we've cherry picked #11788 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11819/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11819/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11818 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11818/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11818/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11818/events | https://github.com/NVIDIA/NeMo/pull/11818 | 2,780,881,633 | PR_kwDOC_bI7s6HXqJ4 | 11,818 | changed asr models outputs to be consistent | {
"login": "Ssofja",
"id": 78349198,
"node_id": "MDQ6VXNlcjc4MzQ5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/78349198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ssofja",
"html_url": "https://github.com/Ssofja",
"followers_url": "https://api.github.com/users/Ssofja/followers",
"following_url": "https://api.github.com/users/Ssofja/following{/other_user}",
"gists_url": "https://api.github.com/users/Ssofja/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ssofja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ssofja/subscriptions",
"organizations_url": "https://api.github.com/users/Ssofja/orgs",
"repos_url": "https://api.github.com/users/Ssofja/repos",
"events_url": "https://api.github.com/users/Ssofja/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ssofja/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.metrics.bleu\nnemo/collections/asr/metrics/bleu.py:37:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/asr/metrics/bleu.py:42:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/metrics/bleu.py:43:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/asr/metrics/bleu.py:67:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/metrics/bleu.py:105:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/metrics/bleu.py:109:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/metrics/bleu.py:115:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/metrics/bleu.py:140:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/metrics/bleu.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.metrics.wer\nnemo/collections/asr/metrics/wer.py:213:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/asr/metrics/wer.py:269:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/metrics/wer.py:273:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/metrics/wer.py:279:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/metrics/wer.py:303:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/metrics/wer.py:30:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/metrics/wer.py:347:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.models.aed_multitask_models\nnemo/collections/asr/models/aed_multitask_models.py:694:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:736:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:787:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:795:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:1064:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:1130:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:46:0: W0611: Unused get_prompt_format_fn imported from nemo.collections.common.data.prompt_fn (unused-import)\nnemo/collections/asr/models/aed_multitask_models.py:63:0: W0611: Unused deprecated imported from nemo.utils.decorators (unused-import)\n************* Module nemo.collections.asr.models.ctc_models\nnemo/collections/asr/models/ctc_models.py:197:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:198:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:809:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:815:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:816:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:822:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:823:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:829:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:830:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:836:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:837:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:843:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:844:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:850:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:851:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:857:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:858:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:864:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:865:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:871:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:872:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:878:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:879:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:885:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:886:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:893:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:894:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:900:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:901:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:550:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:607:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:626:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:668:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:686:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:747:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:912:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:45:0: W0611: Unused deprecated imported from nemo.utils.decorators (unused-import)\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:704:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:705:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:16:0: W0611: Unused import json (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:17:0: W0611: Unused import os (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:18:0: W0611: Unused import tempfile (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:19:0: W0611: Unused Tuple imported from typing (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:24:0: W0611: Unused tqdm imported from tqdm.auto (unused-import)\n************* Module nemo.collections.asr.models.rnnt_models\nnemo/collections/asr/models/rnnt_models.py:1074:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/rnnt_models.py:1075:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_models.py:231:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:710:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:808:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:826:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:894:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:902:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:1051:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:1082:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:18:0: W0611: Unused Tuple imported from typing (unused-import)\nnemo/collections/asr/models/rnnt_models.py:43:0: W0611: Unused NBestHypotheses imported from nemo.collections.asr.parts.utils.rnnt_utils (unused-import)\nnemo/collections/asr/models/rnnt_models.py:51:0: W0611: Unused deprecated imported from nemo.utils.decorators (unused-import)\n************* Module nemo.collections.asr.parts.mixins.mixins\nnemo/collections/asr/parts/mixins/mixins.py:610:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:613:0: C0301: Line too long (200/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:614:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:619:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:620:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:625:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:635:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:672:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:743:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:865:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/mixins/mixins.py:881:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.submodules.ctc_decoding\nnemo/collections/asr/parts/submodules/ctc_decoding.py:370:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:759:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:916:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:33:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:990:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:1001:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:1012:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:1472:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:1519:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:19:0: W0611: Unused Tuple imported from typing (unused-import)\n************* Module nemo.collections.asr.parts.submodules.multitask_decoding\nnemo/collections/asr/parts/submodules/multitask_decoding.py:66:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:89:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:114:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:126:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:430:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:453:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:478:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:599:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:164:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:606:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:15:0: W0611: Unused import re (unused-import)\n************* Module nemo.collections.asr.parts.utils.streaming_utils\nnemo/collections/asr/parts/utils/streaming_utils.py:426:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:429:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:473:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:546:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:569:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:632:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:644:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:658:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:685:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:777:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:783:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:787:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:824:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:842:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1515:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1521:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1525:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1537:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1542:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1549:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1584:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1587:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1597:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1608:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1612:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1683:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1731:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.multimodal.speech_cv.models.visual_ctc_models\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:146:0: C0301: Line too long (240/119) (line-too-long)\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:149:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:240:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:241:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:517:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:571:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:586:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:632:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_ctc_models.py:699:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.multimodal.speech_cv.models.visual_hybrid_rnnt_ctc_models\nnemo/collections/multimodal/speech_cv/models/visual_hybrid_rnnt_ctc_models.py:115:0: C0301: Line too long (266/119) (line-too-long)\nnemo/collections/multimodal/speech_cv/models/visual_hybrid_rnnt_ctc_models.py:217:0: C0301: Line too long (120/119) (line-too-long)\n************* Module nemo.collections.multimodal.speech_cv.models.visual_rnnt_models\nnemo/collections/multimodal/speech_cv/models/visual_rnnt_models.py:239:0: C0301: Line too long (266/119) (line-too-long)\nnemo/collections/multimodal/speech_cv/models/visual_rnnt_models.py:315:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/multimodal/speech_cv/models/visual_rnnt_models.py:625:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_rnnt_models.py:720:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_rnnt_models.py:734:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_rnnt_models.py:799:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_rnnt_models.py:920:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/speech_cv/models/visual_rnnt_models.py:936:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.tts.g2p.models.ctc\nnemo/collections/tts/g2p/models/ctc.py:420:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/tts/g2p/models/ctc.py:49:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/tts/g2p/models/ctc.py:179:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/tts/g2p/models/ctc.py:198:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/tts/g2p/models/ctc.py:211:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/tts/g2p/models/ctc.py:215:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/tts/g2p/models/ctc.py:441:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/tts/g2p/models/ctc.py:449:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/tts/g2p/models/ctc.py:497:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.asr_language_modeling.ngram_lm.eval_beamsearch_ngram_ctc\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py:19:0: C0301: Line too long (125/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py:110:0: C0301: Line too long (128/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py:111:0: C0301: Line too long (140/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py:112:0: C0301: Line too long (137/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py:115:0: C0301: Line too long (135/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py:126:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py:264:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py:59:0: W0611: Unused import contextlib (unused-import)\n************* Module scripts.asr_language_modeling.ngram_lm.eval_beamsearch_ngram_transducer\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:18:0: C0301: Line too long (129/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:108:0: C0301: Line too long (126/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:109:0: C0301: Line too long (140/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:111:0: C0301: Line too long (149/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:112:0: C0301: Line too long (162/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:118:0: C0301: Line too long (139/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:164:0: C0301: Line too long (245/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:227:0: C0301: Line too long (149/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:231:0: C0301: Line too long (132/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:234:0: C0301: Line too long (124/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:371:0: C0301: Line too long (121/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:124:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:242:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py:59:0: W0611: Unused import contextlib (unused-import)\n************* Module scripts.asr_language_modeling.ngram_lm.eval_wfst_decoding_ctc\nscripts/asr_language_modeling/ngram_lm/eval_wfst_decoding_ctc.py:104:0: C0301: Line too long (127/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_wfst_decoding_ctc.py:105:0: C0301: Line too long (148/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/eval_wfst_decoding_ctc.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/asr_language_modeling/ngram_lm/eval_wfst_decoding_ctc.py:256:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/asr_language_modeling/ngram_lm/eval_wfst_decoding_ctc.py:56:0: W0611: Unused import contextlib (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.66/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-10T18:56:03 | 2025-01-17T13:53:09 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11818",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11818",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11818.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11818.patch",
"merged_at": null
} | # What does this PR do ?
This PR is making Some of ASR models outputs consistent
**Collection**: ASR
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] Refactoring
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11818/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11818/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11817 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11817/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11817/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11817/events | https://github.com/NVIDIA/NeMo/issues/11817 | 2,779,988,978 | I_kwDOC_bI7s6ls0Py | 11,817 | [doc] [typo] The performance improvement of sequence packing is claimed to be as higher as 10x. Is it a typo? | {
"login": "shifangx",
"id": 189694891,
"node_id": "U_kgDOC06Dqw",
"avatar_url": "https://avatars.githubusercontent.com/u/189694891?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shifangx",
"html_url": "https://github.com/shifangx",
"followers_url": "https://api.github.com/users/shifangx/followers",
"following_url": "https://api.github.com/users/shifangx/following{/other_user}",
"gists_url": "https://api.github.com/users/shifangx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shifangx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shifangx/subscriptions",
"organizations_url": "https://api.github.com/users/shifangx/orgs",
"repos_url": "https://api.github.com/users/shifangx/repos",
"events_url": "https://api.github.com/users/shifangx/events{/privacy}",
"received_events_url": "https://api.github.com/users/shifangx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [] | 2025-01-10T11:44:26 | 2025-01-10T11:45:21 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Sequence packing is a very useful feature.
There are two places in the document (as shown in the following) that mention the performance improvement of sequence packing, but the data differs greatly.
10x performance improvement is unthinkable. **_Is it a typo?_**
https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/features/optimizations/sequence_packing.html
https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/multimodal/mllm/sequence_packing.html
 | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11817/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11817/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11816 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11816/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11816/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11816/events | https://github.com/NVIDIA/NeMo/pull/11816 | 2,779,583,305 | PR_kwDOC_bI7s6HTOb5 | 11,816 | build: Fix mamba install | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12705954398) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-10T08:30:05 | 2025-01-11T19:35:03 | 2025-01-11T19:35:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11816",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11816",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11816.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11816.patch",
"merged_at": "2025-01-11T19:35:02"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11816/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11816/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11815 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11815/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11815/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11815/events | https://github.com/NVIDIA/NeMo/pull/11815 | 2,779,549,798 | PR_kwDOC_bI7s6HTHZ8 | 11,815 | build: Fix build-arg | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2025-01-10T08:10:57 | 2025-01-10T08:11:11 | 2025-01-10T08:11:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11815",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11815",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11815.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11815.patch",
"merged_at": "2025-01-10T08:11:09"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11815/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11815/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11814 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11814/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11814/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11814/events | https://github.com/NVIDIA/NeMo/pull/11814 | 2,779,525,873 | PR_kwDOC_bI7s6HTCTu | 11,814 | build: Bump PyT and TE | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [] | 2025-01-10T07:55:48 | 2025-01-20T10:20:09 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11814",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11814",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11814.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11814.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11814/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11814/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11813 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11813/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11813/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11813/events | https://github.com/NVIDIA/NeMo/issues/11813 | 2,779,509,479 | I_kwDOC_bI7s6lq_Ln | 11,813 | ASR: Is there any checked and stable way for pretrain? | {
"login": "ican24",
"id": 19214100,
"node_id": "MDQ6VXNlcjE5MjE0MTAw",
"avatar_url": "https://avatars.githubusercontent.com/u/19214100?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ican24",
"html_url": "https://github.com/ican24",
"followers_url": "https://api.github.com/users/ican24/followers",
"following_url": "https://api.github.com/users/ican24/following{/other_user}",
"gists_url": "https://api.github.com/users/ican24/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ican24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ican24/subscriptions",
"organizations_url": "https://api.github.com/users/ican24/orgs",
"repos_url": "https://api.github.com/users/ican24/repos",
"events_url": "https://api.github.com/users/ican24/events{/privacy}",
"received_events_url": "https://api.github.com/users/ican24/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"No one knows pretrain mechanism???\nIt is so-so strange "
] | 2025-01-10T07:45:16 | 2025-01-15T04:27:27 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I am trying to develop ASR tools for 2 custom languages.
I used 3-4 times speech_to_text_ctc_bpe.py for pretrain, but all cases I did not receive reslult. My best results is WER:0.98.
```
python speech_to_text_ctc_bpe.py \
+config-name=../conf/fastconformer/fast-conformer_ctc_bpe \
model.train_ds.manifest_filepath=/nemoasr/train.5 \
model.validation_ds.manifest_filepath=/nemoasr/test.5 \
model.tokenizer.dir=/nemoasr/tokenizer/tokenizer_spe_unigram_v512 \
model.tokenizer.type=bpe \
trainer.devices=-1 \
trainer.accelerator="gpu" \
trainer.strategy="ddp" \
trainer.max_epochs=100 \
model.optim.name="adamw" \
model.optim.lr=0.001 \
model.optim.betas=[0.9,0.999] \
model.optim.weight_decay=0.0001 \
model.optim.sched.warmup_steps=2000 \
```
Meanwhile I can get sufficient resluts (WER:3.5-4.5) using script. which I generated from examples in open sources of Internet (Japanese, Vietnamese).
Actually I would not to know is there any checked way for pretrain?
Thank you advance!
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11813/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11813/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11812 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11812/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11812/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11812/events | https://github.com/NVIDIA/NeMo/issues/11812 | 2,779,158,439 | I_kwDOC_bI7s6lppen | 11,812 | How to set lhotse mixed noise parameters in yaml | {
"login": "johnchienbronci",
"id": 27708347,
"node_id": "MDQ6VXNlcjI3NzA4MzQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/27708347?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/johnchienbronci",
"html_url": "https://github.com/johnchienbronci",
"followers_url": "https://api.github.com/users/johnchienbronci/followers",
"following_url": "https://api.github.com/users/johnchienbronci/following{/other_user}",
"gists_url": "https://api.github.com/users/johnchienbronci/gists{/gist_id}",
"starred_url": "https://api.github.com/users/johnchienbronci/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/johnchienbronci/subscriptions",
"organizations_url": "https://api.github.com/users/johnchienbronci/orgs",
"repos_url": "https://api.github.com/users/johnchienbronci/repos",
"events_url": "https://api.github.com/users/johnchienbronci/events{/privacy}",
"received_events_url": "https://api.github.com/users/johnchienbronci/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-10T02:51:18 | 2025-01-10T02:51:35 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | if use_lhoste set False,
yaml set noise:
```
model:
train_ds:
augmentor:
time_stretch:
.....
gain:
......
noise:
manifest_path: background_noise.json
.....
white_noise:
......
```
How should I set it when use_lhotse set True? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11812/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11812/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11811 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11811/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11811/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11811/events | https://github.com/NVIDIA/NeMo/pull/11811 | 2,779,142,243 | PR_kwDOC_bI7s6HRvDG | 11,811 | fix sentencepiece tokenizer special tokens | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12702283717) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12714345806) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.tokenizers.sentencepiece_tokenizer\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:42:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:43:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:341:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:396:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:405:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:410:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:411:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:412:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:233:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:291:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:315:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:322:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:329:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:336:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:348:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:357:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:358:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.tokenizer_utils\nnemo/collections/nlp/modules/common/tokenizer_utils.py:73:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:131:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:233:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:42:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.tokenizers.sentencepiece_tokenizer\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:42:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:43:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:341:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:396:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:405:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:410:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:411:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:412:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:233:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:291:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:315:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:322:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:329:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:336:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:348:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:357:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:358:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.tokenizer_utils\nnemo/collections/nlp/modules/common/tokenizer_utils.py:73:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:131:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:233:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:42:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12719285984) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-10T02:33:52 | 2025-01-13T18:56:45 | 2025-01-13T18:56:43 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11811",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11811",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11811.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11811.patch",
"merged_at": "2025-01-13T18:56:43"
} | # What does this PR do ?
Changes:
1. previously, it was inserting a space token between the a special token and the first word of the text following the special token.
2. apply the above to text_to_tokens and text_to_ids
3. if a special token is in the vocab, then use its id when marking it as special token.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11811/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11811/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11810 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11810/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11810/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11810/events | https://github.com/NVIDIA/NeMo/pull/11810 | 2,779,020,058 | PR_kwDOC_bI7s6HRV24 | 11,810 | chore(beep boop 🤖): Bump `MCORE_TAG=3046e33...` (2025-01-10) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-10T00:23:21 | 2025-01-16T20:29:27 | 2025-01-16T20:29:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11810",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11810",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11810.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11810.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=3046e33f242d076181436efd4714eae4e40e534e`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11810/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11810/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11809 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11809/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11809/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11809/events | https://github.com/NVIDIA/NeMo/pull/11809 | 2,778,973,655 | PR_kwDOC_bI7s6HRLqU | 11,809 | Fix starcoder2 missing bias in nemo2 config for TRTLLM | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:164:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:196:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:207:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:211:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:238:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:249:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:270:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:365:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:483:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:573:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:577:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:588:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:600:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:640:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:677:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:690:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:25:0: W0611: Unused import tensorstore (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.56/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @meatybobby 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12760091273) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-09T23:38:32 | 2025-01-14T17:57:21 | 2025-01-14T17:57:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11809",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11809",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11809.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11809.patch",
"merged_at": "2025-01-14T17:57:20"
} | # What does this PR do ?
Fix starcoder2 missing bias in nemo2 config for TRTLLM
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11809/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11809/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11808 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11808/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11808/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11808/events | https://github.com/NVIDIA/NeMo/pull/11808 | 2,778,972,927 | PR_kwDOC_bI7s6HRLgD | 11,808 | Add padding in mllama vision encoder to align with HF | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-09T23:37:55 | 2025-01-13T20:41:52 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11808",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11808",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11808.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11808.patch",
"merged_at": null
} | # What does this PR do ?
Add padding in mllama vision encoder to align with HF
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11808/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11808/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11807 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11807/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11807/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11807/events | https://github.com/NVIDIA/NeMo/pull/11807 | 2,778,957,326 | PR_kwDOC_bI7s6HRH-c | 11,807 | Add rope scaling configs for NeMo 1 | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.parts.utils\nnemo/collections/common/parts/utils.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/parts/utils.py:159:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/parts/utils.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/parts/utils.py:191:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/parts/utils.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_gpt_model\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:333:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:373:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:419:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:466:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:799:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1114:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1135:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1345:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1386:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1443:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1624:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1625:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1627:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1799:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1819:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1827:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1848:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1918:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1945:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:140:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:153:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:179:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:198:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:293:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:313:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:475:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:478:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:709:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:713:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:795:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1185:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1456:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1591:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1599:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1608:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1893:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2046:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2053:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2059:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:20:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:28:0: W0611: Unused _DataFetcherWrapper imported from lightning.pytorch.loops.fetchers (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:30:0: W0611: Unused OmegaConf imported from omegaconf (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:72:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:81:4: W0611: Unused megatron.core imported as core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:82:4: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.50/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @BoxiangW 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12700324512) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-09T23:25:07 | 2025-01-10T19:39:38 | 2025-01-10T19:39:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11807",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11807",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11807.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11807.patch",
"merged_at": "2025-01-10T19:39:37"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11807/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11807/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11806 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11806/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11806/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11806/events | https://github.com/NVIDIA/NeMo/pull/11806 | 2,778,718,210 | PR_kwDOC_bI7s6HQS0j | 11,806 | Latest News updated for Cosmos | {
"login": "lbliii",
"id": 25370251,
"node_id": "MDQ6VXNlcjI1MzcwMjUx",
"avatar_url": "https://avatars.githubusercontent.com/u/25370251?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lbliii",
"html_url": "https://github.com/lbliii",
"followers_url": "https://api.github.com/users/lbliii/followers",
"following_url": "https://api.github.com/users/lbliii/following{/other_user}",
"gists_url": "https://api.github.com/users/lbliii/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lbliii/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lbliii/subscriptions",
"organizations_url": "https://api.github.com/users/lbliii/orgs",
"repos_url": "https://api.github.com/users/lbliii/repos",
"events_url": "https://api.github.com/users/lbliii/events{/privacy}",
"received_events_url": "https://api.github.com/users/lbliii/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Reviewed latest updates. LGTM."
] | 2025-01-09T20:42:49 | 2025-01-16T18:26:49 | 2025-01-16T18:26:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11806",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11806",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11806.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11806.patch",
"merged_at": "2025-01-16T18:26:49"
} | # What does this PR do ?
Add news for Cosmos and previous news/cosmos blurb written by jennifer in a previously closed PR
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ethanhe42",
"id": 10027339,
"node_id": "MDQ6VXNlcjEwMDI3MzM5",
"avatar_url": "https://avatars.githubusercontent.com/u/10027339?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ethanhe42",
"html_url": "https://github.com/ethanhe42",
"followers_url": "https://api.github.com/users/ethanhe42/followers",
"following_url": "https://api.github.com/users/ethanhe42/following{/other_user}",
"gists_url": "https://api.github.com/users/ethanhe42/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ethanhe42/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ethanhe42/subscriptions",
"organizations_url": "https://api.github.com/users/ethanhe42/orgs",
"repos_url": "https://api.github.com/users/ethanhe42/repos",
"events_url": "https://api.github.com/users/ethanhe42/events{/privacy}",
"received_events_url": "https://api.github.com/users/ethanhe42/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11806/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11806/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11805 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11805/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11805/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11805/events | https://github.com/NVIDIA/NeMo/pull/11805 | 2,778,698,076 | PR_kwDOC_bI7s6HQObM | 11,805 | News: Cosmos WFMs support | {
"login": "lbliii",
"id": 25370251,
"node_id": "MDQ6VXNlcjI1MzcwMjUx",
"avatar_url": "https://avatars.githubusercontent.com/u/25370251?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lbliii",
"html_url": "https://github.com/lbliii",
"followers_url": "https://api.github.com/users/lbliii/followers",
"following_url": "https://api.github.com/users/lbliii/following{/other_user}",
"gists_url": "https://api.github.com/users/lbliii/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lbliii/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lbliii/subscriptions",
"organizations_url": "https://api.github.com/users/lbliii/orgs",
"repos_url": "https://api.github.com/users/lbliii/repos",
"events_url": "https://api.github.com/users/lbliii/events{/privacy}",
"received_events_url": "https://api.github.com/users/lbliii/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2025-01-09T20:28:34 | 2025-01-09T20:38:38 | 2025-01-09T20:38:37 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11805",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11805",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11805.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11805.patch",
"merged_at": null
} | # What does this PR do ?
Update the readme for news about Cosmos WFMs.
**Collection**: readme
# Changelog
- Added new details element for Cosmos WFMs
- Added subsection for cosmos in "What's new in NeMo 2.0" (content was previously already written by Jennifer)
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "lbliii",
"id": 25370251,
"node_id": "MDQ6VXNlcjI1MzcwMjUx",
"avatar_url": "https://avatars.githubusercontent.com/u/25370251?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lbliii",
"html_url": "https://github.com/lbliii",
"followers_url": "https://api.github.com/users/lbliii/followers",
"following_url": "https://api.github.com/users/lbliii/following{/other_user}",
"gists_url": "https://api.github.com/users/lbliii/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lbliii/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lbliii/subscriptions",
"organizations_url": "https://api.github.com/users/lbliii/orgs",
"repos_url": "https://api.github.com/users/lbliii/repos",
"events_url": "https://api.github.com/users/lbliii/events{/privacy}",
"received_events_url": "https://api.github.com/users/lbliii/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11805/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11805/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11804 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11804/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11804/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11804/events | https://github.com/NVIDIA/NeMo/pull/11804 | 2,778,642,020 | PR_kwDOC_bI7s6HQCOg | 11,804 | News: Cosmos WFMs NeMo Support | {
"login": "lbliii",
"id": 25370251,
"node_id": "MDQ6VXNlcjI1MzcwMjUx",
"avatar_url": "https://avatars.githubusercontent.com/u/25370251?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lbliii",
"html_url": "https://github.com/lbliii",
"followers_url": "https://api.github.com/users/lbliii/followers",
"following_url": "https://api.github.com/users/lbliii/following{/other_user}",
"gists_url": "https://api.github.com/users/lbliii/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lbliii/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lbliii/subscriptions",
"organizations_url": "https://api.github.com/users/lbliii/orgs",
"repos_url": "https://api.github.com/users/lbliii/repos",
"events_url": "https://api.github.com/users/lbliii/events{/privacy}",
"received_events_url": "https://api.github.com/users/lbliii/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.tokenizers.null_tokenizer\nnemo/collections/common/tokenizers/null_tokenizer.py:31:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:34:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:38:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:46:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:50:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:54:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:58:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:62:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:66:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.fsdp2_strategy\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:85:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:91:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:142:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:169:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:198:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.86/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.tokenizers.sentencepiece_tokenizer\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:42:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:43:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:307:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:362:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:371:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:376:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:377:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:378:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:203:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:257:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:265:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:281:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:288:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:302:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:314:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:323:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:324:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:441:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/llm/api.py:571:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:15:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.llm.gpt.data.packed_sequence\nnemo/collections/llm/gpt/data/packed_sequence.py:116:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/llm/gpt/data/packed_sequence.py:111:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:63:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:130:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:150:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:163:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:329:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:125:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:139:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:300:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:323:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:343:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:347:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.peft.lora\nnemo/collections/llm/peft/lora.py:150:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.recipes.hf_auto_model_for_causal_lm\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:100:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:153:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:194:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:20:0: W0611: Unused import torch (unused-import)\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:395:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:396:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:397:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:402:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:623:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:624:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:625:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:630:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:42:4: W0611: Unused import transformer_engine (unused-import)\n************* Module nemo.collections.multimodal.models.multimodal_llm.neva.neva_model\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:191:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:192:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:323:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:852:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:865:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:867:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1259:0: C0301: Line too long (194/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1263:0: C0301: Line too long (245/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1310:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1394:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1573:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1696:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:113:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:133:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:146:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:163:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:184:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:187:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:300:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:310:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:507:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:548:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:581:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:610:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:725:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1179:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1185:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1626:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.data.language_modeling.megatron.gpt_sft_dataset\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:71:0: C0301: Line too long (353/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:73:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:74:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:80:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:83:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:84:0: C0301: Line too long (178/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:85:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:86:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:88:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:91:0: C0301: Line too long (247/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:166:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:175:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:245:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:248:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:273:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:278:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:279:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:301:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:390:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:678:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:527:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.nlp.modules.common.megatron.megatron_init\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:266:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:267:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:268:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:371:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/megatron_init.py:88:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.tokenizer_utils\nnemo/collections/nlp/modules/common/tokenizer_utils.py:73:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:131:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:233:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:42:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:165:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:195:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:206:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:210:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:235:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:246:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:267:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:362:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:480:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:567:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:571:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:582:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:594:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:634:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:684:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:25:0: W0611: Unused import tensorstore (unused-import)\n************* Module nemo.lightning.data\nnemo/lightning/data.py:266:0: C0301: Line too long (120/119) (line-too-long)\nnemo/lightning/data.py:397:0: C0301: Line too long (134/119) (line-too-long)\nnemo/lightning/data.py:398:0: C0301: Line too long (151/119) (line-too-long)\nnemo/lightning/data.py:398:0: C0301: Line too long (151/119) (line-too-long)\nnemo/lightning/data.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/data.py:244:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/data.py:312:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/data.py:339:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/data.py:369:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.megatron_init\nnemo/lightning/megatron_init.py:266:0: C0301: Line too long (122/119) (line-too-long)\nnemo/lightning/megatron_init.py:267:0: C0301: Line too long (133/119) (line-too-long)\nnemo/lightning/megatron_init.py:268:0: C0301: Line too long (121/119) (line-too-long)\nnemo/lightning/megatron_init.py:371:0: C0301: Line too long (166/119) (line-too-long)\nnemo/lightning/megatron_init.py:88:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.callbacks.progress_printer\nnemo/lightning/pytorch/callbacks/progress_printer.py:116:0: C0301: Line too long (124/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/progress_printer.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:86:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:98:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:106:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:145:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:158:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:187:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:202:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:286:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.utils\nnemo/lightning/pytorch/strategies/utils.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/strategies/utils.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:58:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:70:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:121:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:131:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:186:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.checkpoint_converters.convert_mixtral_hf_to_nemo\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:477:0: C0301: Line too long (146/119) (line-too-long)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:175:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:191:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:204:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:399:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:412:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:468:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:520:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.66/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-09T19:50:56 | 2025-01-09T20:29:24 | 2025-01-09T20:26:24 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11804",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11804",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11804.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11804.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: readme
# Changelog
- Added News for Cosmos
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "lbliii",
"id": 25370251,
"node_id": "MDQ6VXNlcjI1MzcwMjUx",
"avatar_url": "https://avatars.githubusercontent.com/u/25370251?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lbliii",
"html_url": "https://github.com/lbliii",
"followers_url": "https://api.github.com/users/lbliii/followers",
"following_url": "https://api.github.com/users/lbliii/following{/other_user}",
"gists_url": "https://api.github.com/users/lbliii/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lbliii/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lbliii/subscriptions",
"organizations_url": "https://api.github.com/users/lbliii/orgs",
"repos_url": "https://api.github.com/users/lbliii/repos",
"events_url": "https://api.github.com/users/lbliii/events{/privacy}",
"received_events_url": "https://api.github.com/users/lbliii/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11804/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11804/timeline | null | null | true |
Subsets and Splits