url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/11803 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11803/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11803/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11803/events | https://github.com/NVIDIA/NeMo/pull/11803 | 2,778,388,912 | PR_kwDOC_bI7s6HPKsF | 11,803 | Revert "Revert Mcore update since it caused regression" | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.gemma\nnemo/collections/llm/gpt/model/gemma.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:79:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:83:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:87:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:107:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:127:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:140:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:146:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:178:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:197:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:214:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.recipes.gemma_2b\nnemo/collections/llm/recipes/gemma_2b.py:14:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.llm.recipes.gemma_7b\nnemo/collections/llm/recipes/gemma_7b.py:14:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_base_model\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:104:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:112:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:254:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:272:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:347:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:611:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:666:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:838:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:976:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:995:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1112:0: C0301: Line too long (195/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1169:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1218:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1301:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:331:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:462:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:467:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:704:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:756:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:937:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1041:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1311:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1315:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_retro_model\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:36:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:143:0: C0301: Line too long (191/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:305:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:336:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:387:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:444:0: C0301: Line too long (206/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:454:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:461:0: C0301: Line too long (210/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:465:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:15:0: W0611: Unused import itertools (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:18:0: W0611: Unused import queue (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:20:0: W0611: Unused import warnings (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:21:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Iterator imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused List imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Union imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:26:0: W0611: Unused CPUAccelerator imported from lightning.pytorch.accelerators (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:38:0: W0611: Unused MegatronBaseModel imported from nemo.collections.nlp.models.language_modeling.megatron_base_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:40:0: W0611: Unused build_model imported from nemo.collections.nlp.modules.common.megatron.build_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:41:0: W0611: Unused Float16Module imported from nemo.collections.nlp.modules.common.megatron.module (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_all_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_ltor_masks_and_position_ids imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:49:0: W0611: Unused TextGenerationStrategy imported from nemo.collections.nlp.modules.common.text_generation_strategy (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_length_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_sampling_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused megatron_gpt_generate imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused LengthParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused OutputType imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused SamplingParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused TextGeneration imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:63:0: W0611: Unused utils_funcs imported from nemo.collections.nlp.parts (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused get_last_rank imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:65:0: W0611: Unused Exportable imported from nemo.core.classes (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:66:0: W0611: Unused PretrainedModelInfo imported from nemo.core.classes.common (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused ChannelType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused NeuralType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:72:4: W0611: Unused InferenceParams imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:81:4: W0611: Unused TransformerConfig imported from megatron.core.transformer.transformer_config (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:82:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:82:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module scripts.checkpoint_converters.convert_bert_hf_to_nemo\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:65:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:79:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.41/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"duplicate of #11799 "
] | 2025-01-09T17:30:44 | 2025-01-09T17:32:14 | 2025-01-09T17:32:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11803",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11803",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11803.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11803.patch",
"merged_at": null
} | Reverts NVIDIA/NeMo#11791 | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11803/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11803/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11802 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11802/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11802/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11802/events | https://github.com/NVIDIA/NeMo/pull/11802 | 2,778,261,703 | PR_kwDOC_bI7s6HOvEb | 11,802 | Cherry pick `Add null tokenizer (11789)` into `r2.1.1` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.modules.common.tokenizer_utils\nnemo/collections/nlp/modules/common/tokenizer_utils.py:73:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:131:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:226:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:42:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.48/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.tokenizers.null_tokenizer\nnemo/collections/common/tokenizers/null_tokenizer.py:31:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:34:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:38:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:46:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:50:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:54:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:58:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:62:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:66:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/null_tokenizer.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 6.67/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.modules.common.tokenizer_utils\nnemo/collections/nlp/modules/common/tokenizer_utils.py:73:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:131:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:226:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:42:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.48/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12699554606) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-09T16:25:23 | 2025-01-10T07:16:35 | 2025-01-10T07:16:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11802",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11802",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11802.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11802.patch",
"merged_at": "2025-01-10T07:16:34"
} | beep boop [🤖]: Hi @erhoo82 👋,
we've cherry picked #11789 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11802/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11802/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11801 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11801/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11801/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11801/events | https://github.com/NVIDIA/NeMo/pull/11801 | 2,778,237,947 | PR_kwDOC_bI7s6HOp25 | 11,801 | Fix DistCP inference issue | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.modules.common.text_generation_strategy\nnemo/collections/nlp/modules/common/text_generation_strategy.py:438:0: C0301: Line too long (182/119) (line-too-long)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:821:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:916:0: C0301: Line too long (190/119) (line-too-long)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:944:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:945:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:958:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:961:0: C0301: Line too long (211/119) (line-too-long)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:1016:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:270:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:344:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:420:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:585:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:747:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:828:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:865:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:1047:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/text_generation_strategy.py:17:0: W0611: Unused import os (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.60/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12697072643) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-09T16:13:25 | 2025-01-10T05:14:00 | 2025-01-10T05:14:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11801",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11801",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11801.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11801.patch",
"merged_at": "2025-01-10T05:14:00"
} | # What does this PR do ?
When training with latest mcore's dist ckpt format. the model.model will sometimes be a list and this breaks the inference. This PR fix this issue.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11801/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11801/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11800 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11800/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11800/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11800/events | https://github.com/NVIDIA/NeMo/issues/11800 | 2,777,511,490 | I_kwDOC_bI7s6ljXZC | 11,800 | Error occurs when i try to pack my training.jsonl | {
"login": "Sun2018421",
"id": 38587877,
"node_id": "MDQ6VXNlcjM4NTg3ODc3",
"avatar_url": "https://avatars.githubusercontent.com/u/38587877?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sun2018421",
"html_url": "https://github.com/Sun2018421",
"followers_url": "https://api.github.com/users/Sun2018421/followers",
"following_url": "https://api.github.com/users/Sun2018421/following{/other_user}",
"gists_url": "https://api.github.com/users/Sun2018421/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Sun2018421/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sun2018421/subscriptions",
"organizations_url": "https://api.github.com/users/Sun2018421/orgs",
"repos_url": "https://api.github.com/users/Sun2018421/repos",
"events_url": "https://api.github.com/users/Sun2018421/events{/privacy}",
"received_events_url": "https://api.github.com/users/Sun2018421/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"Sorry, i make a mistake about the param \"+pack_sizes [2024,...] -> [2048,...]\" "
] | 2025-01-09T11:03:23 | 2025-01-09T11:19:29 | 2025-01-09T11:19:29 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When i follow this tutorial [https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/features/optimizations/sequence_packing.html#](url) with the training.jsonl generated by [https://docs.nvidia.com/nemo-framework/user-guide/24.07/playbooks/llama2sft.html](url) in Step 3.
A clear and concise description of what the bug is.
```shell
root@604d29b05e86:/opt/NeMo# export HYDRA_FULL_ERROR=1
root@604d29b05e86:/opt/NeMo# python scripts/nlp_language_modeling/prepare_packed_ft_dataset.py model.da
ta.train_ds.file_names=[/workspace/data/training.jsonl] model.data.train_ds.max_seq_length=2048 +tokeni
zer_path=/workspace/models/llama2-7b/tokenizer.model +output_dir=/workspace/data +pack_sizes=[2024,4096
,8192] +packing_algorithm=first_fit_shuffle +seed=0
[NeMo W 2025-01-09 11:02:07 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/hydra/_internal/hydra.py:119: UserWarning: Future Hydra versions will no longer change working directory at job runtime by default.
See https://hydra.cc/docs/1.2/upgrades/1.1_to_1.2/changes_to_job_working_dir/ for more information.
ret = run_job(
[NeMo I 2025-01-09 11:02:07 prepare_packed_ft_dataset:82] Tokenizing dataset...
[NeMo I 2025-01-09 11:02:07 tokenizer_utils:196] Getting SentencePiece with model: /workspace/models/llama2-7b/tokenizer.model
[NeMo I 2025-01-09 11:02:07 text_memmap_dataset:116] Building data files
[NeMo I 2025-01-09 11:02:07 text_memmap_dataset:525] Processing 1 data files using 2 workers
[NeMo I 2025-01-09 11:02:07 text_memmap_dataset:535] Time building 0 / 1 mem-mapped files: 0:00:00.121457
[NeMo I 2025-01-09 11:02:07 text_memmap_dataset:158] Loading data files
[NeMo I 2025-01-09 11:02:07 text_memmap_dataset:249] Loading /workspace/data/training.jsonl
[NeMo I 2025-01-09 11:02:07 text_memmap_dataset:161] Time loading 1 mem-mapped files: 0:00:00.003980
[NeMo I 2025-01-09 11:02:07 text_memmap_dataset:165] Computing global indices
[NeMo W 2025-01-09 11:02:08 gpt_sft_dataset:324] input is not long enough to truncate.
[NeMo W 2025-01-09 11:02:09 gpt_sft_dataset:324] input is not long enough to truncate.
[NeMo W 2025-01-09 11:02:09 gpt_sft_dataset:324] input is not long enough to truncate.
[NeMo W 2025-01-09 11:02:10 gpt_sft_dataset:324] input is not long enough to truncate.
[NeMo W 2025-01-09 11:02:12 gpt_sft_dataset:324] input is not long enough to truncate.
[NeMo W 2025-01-09 11:02:13 gpt_sft_dataset:324] input is not long enough to truncate.
[NeMo I 2025-01-09 11:02:14 sequence_packing_utils:115] Creating histogram from tokenized dataset...
[NeMo I 2025-01-09 11:02:14 sequence_packing_utils:155] Packing sequences to length 2024...
[NeMo I 2025-01-09 11:02:15 sequence_packing_utils:168] Packing is 99.79% efficient
[NeMo I 2025-01-09 11:02:15 sequence_packing_utils:169] >>>>> For pack size 2024, average number of sequences per pack is n = 10.168 <<<<<
100%|████████████████████████████████████████████████████████████| 2025/2025 [00:00<00:00, 3751.49it/s]
6%|███▍ | 67/1181 [00:00<00:00, 11882.38it/s]
Error executing job with overrides: ['model.data.train_ds.file_names=[/workspace/data/training.jsonl]', 'model.data.train_ds.max_seq_length=2048', '+tokenizer_path=/workspace/models/llama2-7b/tokenizer.model', '+output_dir=/workspace/data', '+pack_sizes=[2024,4096,8192]', '+packing_algorithm=first_fit_shuffle', '+seed=0']
Traceback (most recent call last):
File "/opt/NeMo/scripts/nlp_language_modeling/prepare_packed_ft_dataset.py", line 174, in <module>
main()
File "/opt/NeMo/nemo/core/config/hydra_runner.py", line 129, in wrapper
_run_hydra(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 394, in _run_hydra
_run_app(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 457, in _run_app
run_and_report(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 223, in run_and_report
raise ex
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 220, in run_and_report
return func()
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 458, in <lambda>
lambda: hydra.run(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/hydra.py", line 132, in run
_ = ret.return_value
File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 260, in return_value
raise self._return_value
File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 186, in run_job
ret.return_value = task_function(task_cfg)
File "/opt/NeMo/scripts/nlp_language_modeling/prepare_packed_ft_dataset.py", line 142, in main
output_data = fill_packing_strategy(assignments, sequences, pack_size)
File "/opt/NeMo/nemo/utils/sequence_packing_utils.py", line 217, in fill_packing_strategy
_input_ids.extend(ifile_handles[seq_length][0].pop())
KeyError: 2047
```
**Steps/Code to reproduce bug**
this is my scripts
```shell
python scripts/nlp_language_modeling/prepare_packed_ft_
dataset.py model.data.train_ds.file_names=[/workspace/data/training.jsonl] model.data.train_ds.max_seq_
length=2048 +tokenizer_path=/workspace/models/llama2-7b/tokenizer.model +output_dir=/workspace/data +pa
ck_sizes=[2024,4096,8192] +packing_algorithm=first_fit_shuffle +seed=0
```
**Environment overview (please complete the following information)**
Docker from here [https://catalog.ngc.nvidia.com/orgs/nvidia/containers/nemo/tags](url) version: nvcr.io/nvidia/nemo:24.05.llama3.1
| {
"login": "Sun2018421",
"id": 38587877,
"node_id": "MDQ6VXNlcjM4NTg3ODc3",
"avatar_url": "https://avatars.githubusercontent.com/u/38587877?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sun2018421",
"html_url": "https://github.com/Sun2018421",
"followers_url": "https://api.github.com/users/Sun2018421/followers",
"following_url": "https://api.github.com/users/Sun2018421/following{/other_user}",
"gists_url": "https://api.github.com/users/Sun2018421/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Sun2018421/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sun2018421/subscriptions",
"organizations_url": "https://api.github.com/users/Sun2018421/orgs",
"repos_url": "https://api.github.com/users/Sun2018421/repos",
"events_url": "https://api.github.com/users/Sun2018421/events{/privacy}",
"received_events_url": "https://api.github.com/users/Sun2018421/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11800/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11800/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11799 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11799/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11799/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11799/events | https://github.com/NVIDIA/NeMo/pull/11799 | 2,777,194,512 | PR_kwDOC_bI7s6HLCv9 | 11,799 | Revert "Revert Mcore update since it caused regression (#11791)" | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Mcore commit `bafab5a54b55f2f7309e6625cd0887756548a44b` is also tested and works: https://github.com/NVIDIA/NeMo/pull/11796 ",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12689963763) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.gemma\nnemo/collections/llm/gpt/model/gemma.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:79:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:83:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:87:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:107:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:127:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:140:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:146:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:178:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:197:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:214:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.recipes.gemma_2b\nnemo/collections/llm/recipes/gemma_2b.py:14:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.llm.recipes.gemma_7b\nnemo/collections/llm/recipes/gemma_7b.py:14:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_base_model\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:104:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:112:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:254:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:272:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:347:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:611:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:666:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:838:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:976:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:995:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1112:0: C0301: Line too long (195/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1169:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1218:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1301:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:331:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:462:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:467:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:704:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:756:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:937:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1041:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1311:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1315:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_retro_model\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:36:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:143:0: C0301: Line too long (191/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:305:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:336:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:387:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:444:0: C0301: Line too long (206/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:454:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:461:0: C0301: Line too long (210/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:465:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:15:0: W0611: Unused import itertools (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:18:0: W0611: Unused import queue (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:20:0: W0611: Unused import warnings (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:21:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Iterator imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused List imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Union imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:26:0: W0611: Unused CPUAccelerator imported from lightning.pytorch.accelerators (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:38:0: W0611: Unused MegatronBaseModel imported from nemo.collections.nlp.models.language_modeling.megatron_base_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:40:0: W0611: Unused build_model imported from nemo.collections.nlp.modules.common.megatron.build_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:41:0: W0611: Unused Float16Module imported from nemo.collections.nlp.modules.common.megatron.module (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_all_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_ltor_masks_and_position_ids imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:49:0: W0611: Unused TextGenerationStrategy imported from nemo.collections.nlp.modules.common.text_generation_strategy (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_length_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_sampling_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused megatron_gpt_generate imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused LengthParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused OutputType imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused SamplingParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused TextGeneration imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:63:0: W0611: Unused utils_funcs imported from nemo.collections.nlp.parts (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused get_last_rank imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:65:0: W0611: Unused Exportable imported from nemo.core.classes (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:66:0: W0611: Unused PretrainedModelInfo imported from nemo.core.classes.common (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused ChannelType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused NeuralType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:72:4: W0611: Unused InferenceParams imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:81:4: W0611: Unused TransformerConfig imported from megatron.core.transformer.transformer_config (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:82:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:82:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module scripts.checkpoint_converters.convert_bert_hf_to_nemo\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:65:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:79:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.43/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12751883429) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-09T08:47:14 | 2025-01-16T15:31:18 | 2025-01-16T15:31:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11799",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11799",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11799.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11799.patch",
"merged_at": "2025-01-16T15:31:16"
} | This reverts commit 84b2bf0989a1cfde0258acb5804cd5bdcd357449.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11799/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11799/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11798 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11798/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11798/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11798/events | https://github.com/NVIDIA/NeMo/pull/11798 | 2,776,744,913 | PR_kwDOC_bI7s6HJg-O | 11,798 | Fix the tokenizer after llama-3 | {
"login": "nike00811",
"id": 12585244,
"node_id": "MDQ6VXNlcjEyNTg1MjQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12585244?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nike00811",
"html_url": "https://github.com/nike00811",
"followers_url": "https://api.github.com/users/nike00811/followers",
"following_url": "https://api.github.com/users/nike00811/following{/other_user}",
"gists_url": "https://api.github.com/users/nike00811/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nike00811/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nike00811/subscriptions",
"organizations_url": "https://api.github.com/users/nike00811/orgs",
"repos_url": "https://api.github.com/users/nike00811/repos",
"events_url": "https://api.github.com/users/nike00811/events{/privacy}",
"received_events_url": "https://api.github.com/users/nike00811/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_llama_nemo_to_hf\nscripts/checkpoint_converters/convert_llama_nemo_to_hf.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_llama_nemo_to_hf.py:241:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.84/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-09T03:18:01 | 2025-01-09T03:41:57 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11798",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11798",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11798.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11798.patch",
"merged_at": null
} | # What does this PR do ?
update 'LlamaTokenizer' → 'AutoTokenizer'
Starting from llama-3, the tokenizer has been switched to use `PreTrainedTokenizerFast` instead of `LlamaTokenizer`.
This PR fixes the tokenizer loading method, enabling it to function correctly with models released after llama-3
# Changelog
- L21: remove unused import `open_dict`
- L22: `import LlamaTokenizer` → `import AutoTokenizer`
- L258: load tokenizer by `LlamaTokenizer` → load by `AutoTokenizer`
- L261: remove `LlamaTokenizer` parameter
- L263~265: the tokenizer load by `AutoTokenizer` is already a "Fast" tokenizer, we don't need to convert it
- L276: remove the unused variable
# Usage
```python
>>> from transformers import LlamaTokenizer
>>> try:
... tokenizer = LlamaTokenizer.from_pretrained("meta-llama/Meta-Llama-3-8B")
... except Exception as e:
... print(e)
The tokenizer class you load from this checkpoint is not the same type as the class this function is called from. It may result in unexpected tokenization.
The tokenizer class you load from this checkpoint is 'PreTrainedTokenizerFast'.
The class this function is called from is 'LlamaTokenizer'.
```
```python
from transformers import AutoTokenizer
tokenizer = AutoTokenizer.from_pretrained("meta-llama/Meta-Llama-3-8B")
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11798/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11798/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11797 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11797/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11797/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11797/events | https://github.com/NVIDIA/NeMo/pull/11797 | 2,776,680,335 | PR_kwDOC_bI7s6HJTPA | 11,797 | fix: fix nemo 1.0 lora merge script for gpt models that error due to missing TE states | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module merge\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:199:0: C0301: Line too long (132/119) (line-too-long)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:200:0: C0301: Line too long (134/119) (line-too-long)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:276:0: C0301: Line too long (121/119) (line-too-long)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:277:0: C0301: Line too long (685/119) (line-too-long)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:61:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:75:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:96:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:128:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:215:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:42:0: W0611: Unused fake_initialize_model_parallel imported from nemo.collections.nlp.modules.common.megatron.megatron_init (unused-import)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:47:0: W0611: Unused AppState imported from nemo.utils.app_state (unused-import)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:48:0: W0611: Unused inject_model_parallel_rank imported from nemo.utils.model_utils (unused-import)\nscripts/nlp_language_modeling/merge_lora_weights/merge.py:51:4: W0611: Unused parallel_state imported from megatron.core (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.09/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-09T02:09:34 | 2025-01-09T02:13:04 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11797",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11797",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11797.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11797.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11797/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11797/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11796 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11796/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11796/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11796/events | https://github.com/NVIDIA/NeMo/pull/11796 | 2,776,590,061 | PR_kwDOC_bI7s6HI_Xr | 11,796 | chore(beep boop 🤖): Bump `MCORE_TAG=bafab5a...` (2025-01-09) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12681430662) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-09T00:22:51 | 2025-01-16T20:29:31 | 2025-01-16T20:29:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11796",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11796",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11796.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11796.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=bafab5a54b55f2f7309e6625cd0887756548a44b`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11796/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11796/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11795 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11795/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11795/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11795/events | https://github.com/NVIDIA/NeMo/pull/11795 | 2,776,537,365 | PR_kwDOC_bI7s6HIzu9 | 11,795 | Huvu/test nemoci t5 alibi | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron.falcon.falcon_decoder_layer\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:70:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:102:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:18:4: W0611: Unused parallel_state imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:19:4: W0611: Unused ShardedObject imported from megatron.core.dist_checkpointing.mapping (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron/falcon/falcon_decoder_layer.py:19:4: W0611: Unused ShardedTensor imported from megatron.core.dist_checkpointing.mapping (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron.gpt_full_te_layer_autocast_spec\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:51:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:147:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:179:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron/gpt_full_te_layer_autocast_spec.py:337:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.megatron.adapters.mcore_mixins\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:140:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:142:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:60:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:69:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:108:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:226:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:338:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:364:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:448:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:455:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:479:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:486:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:504:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:511:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.39/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-08T23:32:49 | 2025-01-08T23:40:19 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11795",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11795",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11795.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11795.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11795/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11795/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11794 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11794/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11794/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11794/events | https://github.com/NVIDIA/NeMo/pull/11794 | 2,776,536,086 | PR_kwDOC_bI7s6HIzcM | 11,794 | Add Flux and Flux Controlnet Support to Diffusion folder | {
"login": "Victor49152",
"id": 111467530,
"node_id": "U_kgDOBqTcCg",
"avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Victor49152",
"html_url": "https://github.com/Victor49152",
"followers_url": "https://api.github.com/users/Victor49152/followers",
"following_url": "https://api.github.com/users/Victor49152/following{/other_user}",
"gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions",
"organizations_url": "https://api.github.com/users/Victor49152/orgs",
"repos_url": "https://api.github.com/users/Victor49152/repos",
"events_url": "https://api.github.com/users/Victor49152/events{/privacy}",
"received_events_url": "https://api.github.com/users/Victor49152/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7189255648,
"node_id": "LA_kwDOC_bI7s8AAAABrINV4A",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/PoR",
"name": "PoR",
"color": "c2e0c6",
"default": false,
"description": "Major feature to be highlighted in release notes"
}
] | open | false | {
"login": "Victor49152",
"id": 111467530,
"node_id": "U_kgDOBqTcCg",
"avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Victor49152",
"html_url": "https://github.com/Victor49152",
"followers_url": "https://api.github.com/users/Victor49152/followers",
"following_url": "https://api.github.com/users/Victor49152/following{/other_user}",
"gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions",
"organizations_url": "https://api.github.com/users/Victor49152/orgs",
"repos_url": "https://api.github.com/users/Victor49152/repos",
"events_url": "https://api.github.com/users/Victor49152/events{/privacy}",
"received_events_url": "https://api.github.com/users/Victor49152/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Victor49152",
"id": 111467530,
"node_id": "U_kgDOBqTcCg",
"avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Victor49152",
"html_url": "https://github.com/Victor49152",
"followers_url": "https://api.github.com/users/Victor49152/followers",
"following_url": "https://api.github.com/users/Victor49152/following{/other_user}",
"gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions",
"organizations_url": "https://api.github.com/users/Victor49152/orgs",
"repos_url": "https://api.github.com/users/Victor49152/repos",
"events_url": "https://api.github.com/users/Victor49152/events{/privacy}",
"received_events_url": "https://api.github.com/users/Victor49152/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@ethanhe42 I have moved the dit scripts into scrips folder as a NeMo 2 convention. Please take a look.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.diffusion.models.flux_controlnet.model\nnemo/collections/diffusion/models/flux_controlnet/model.py:352:0: C0301: Line too long (120/119) (line-too-long)\n************* Module nemo.collections.diffusion.encoders.conditioner\nnemo/collections/diffusion/encoders/conditioner.py:23:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/encoders/conditioner.py:170:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.diffusion.models.dit.dit_attention\nnemo/collections/diffusion/models/dit/dit_attention.py:380:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_attention.py:382:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_attention.py:15:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.diffusion.models.dit.dit_layer_spec\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:54:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:60:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:66:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:632:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:21:0: W0611: Unused rearrange imported from einops (unused-import)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:22:0: W0611: Unused jit_fuser imported from megatron.core.jit (unused-import)\n************* Module nemo.collections.diffusion.models.flux.layers\nnemo/collections/diffusion/models/flux/layers.py:131:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.diffusion.models.flux.model\nnemo/collections/diffusion/models/flux/model.py:720:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/diffusion/models/flux/model.py:74:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/model.py:107:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/model.py:113:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/model.py:120:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.diffusion.models.flux.pipeline\nnemo/collections/diffusion/models/flux/pipeline.py:385:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/diffusion/models/flux/pipeline.py:492:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/diffusion/models/flux/pipeline.py:494:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/diffusion/models/flux/pipeline.py:800:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/diffusion/models/flux/pipeline.py:839:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/diffusion/models/flux/pipeline.py:650:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.diffusion.utils.flux_pipeline_utils\nnemo/collections/diffusion/utils/flux_pipeline_utils.py:15:0: W0611: Unused dataclass imported from dataclasses (unused-import)\nnemo/collections/diffusion/utils/flux_pipeline_utils.py:17:0: W0611: Unused import torch (unused-import)\n************* Module nemo.collections.diffusion.utils.mcore_parallel_utils\nnemo/collections/diffusion/utils/mcore_parallel_utils.py:26:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.diffusion.vae.autoencoder\nnemo/collections/diffusion/vae/autoencoder.py:26:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/vae/autoencoder.py:48:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/vae/autoencoder.py:149:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/vae/autoencoder.py:264:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/vae/autoencoder.py:279:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning._strategy_lib\nnemo/lightning/_strategy_lib.py:586:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/_strategy_lib.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/_strategy_lib.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:141:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:168:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:204:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:517:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:611:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:624:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.megatron_parallel\nnemo/lightning/megatron_parallel.py:245:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:246:0: C0301: Line too long (140/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:247:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:554:0: C0301: Line too long (129/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:561:0: C0301: Line too long (135/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:849:0: C0301: Line too long (137/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1079:0: C0301: Line too long (136/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1652:0: C0301: Line too long (128/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1691:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:109:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:113:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:313:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:337:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:363:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:389:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:525:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:569:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:573:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:639:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:674:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:686:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:693:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:700:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:734:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:742:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:758:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:785:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:797:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:819:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1345:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1520:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1526:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1532:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1536:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1541:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1546:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1574:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1620:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1642:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1715:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1761:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1775:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.optim.base\nnemo/lightning/pytorch/optim/base.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.72/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-08T23:32:07 | 2025-01-18T18:51:28 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11794",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11794",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11794.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11794.patch",
"merged_at": null
} | # What does this PR do ?
Add Flux and Flux Controlnet Support
**Collection**: [DIFFUSION]
```python
torchrun flux_controlnet_infer.py --num_joint_layers 4 --num_single_layers 0 --flux_ckpt /ckpts/nemo_flux_transformer.safetensors --controlnet_ckpt /ckpts/nemo_flux_controlnet_transformer.safetensors --control_image /ckpts/FLUX.1-controlnet-lineart-promeai/images/example-control.jpg
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11794/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11794/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11793 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11793/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11793/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11793/events | https://github.com/NVIDIA/NeMo/pull/11793 | 2,776,469,353 | PR_kwDOC_bI7s6HIkrg | 11,793 | Add "_skipme" option to Lhotse Dataloading | {
"login": "monica-sekoyan",
"id": 166123533,
"node_id": "U_kgDOCebYDQ",
"avatar_url": "https://avatars.githubusercontent.com/u/166123533?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/monica-sekoyan",
"html_url": "https://github.com/monica-sekoyan",
"followers_url": "https://api.github.com/users/monica-sekoyan/followers",
"following_url": "https://api.github.com/users/monica-sekoyan/following{/other_user}",
"gists_url": "https://api.github.com/users/monica-sekoyan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/monica-sekoyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/monica-sekoyan/subscriptions",
"organizations_url": "https://api.github.com/users/monica-sekoyan/orgs",
"repos_url": "https://api.github.com/users/monica-sekoyan/repos",
"events_url": "https://api.github.com/users/monica-sekoyan/events{/privacy}",
"received_events_url": "https://api.github.com/users/monica-sekoyan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.data.lhotse.cutset\nnemo/collections/common/data/lhotse/cutset.py:629:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/common/data/lhotse/cutset.py:65:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/cutset.py:204:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:225:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:240:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:259:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:274:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:290:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:297:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:343:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:440:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:489:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.51/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-08T22:30:38 | 2025-01-10T06:53:10 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11793",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11793",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11793.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11793.patch",
"merged_at": null
} | # What does this PR do ?
Lhotse Dataloading will ignore samples where "_skipme" is set to 1 if not instructed otherwise with `ds.ignore_skipme=True`
**Collection**: [common]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11793/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11793/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11792 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11792/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11792/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11792/events | https://github.com/NVIDIA/NeMo/pull/11792 | 2,776,360,422 | PR_kwDOC_bI7s6HIMdW | 11,792 | Fix Gemma2 Attention Init Args | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12679136145) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-08T21:13:23 | 2025-01-09T14:16:14 | 2025-01-09T14:16:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11792",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11792",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11792.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11792.patch",
"merged_at": "2025-01-09T14:16:11"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11792/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11792/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11791 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11791/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11791/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11791/events | https://github.com/NVIDIA/NeMo/pull/11791 | 2,776,318,727 | PR_kwDOC_bI7s6HIDKW | 11,791 | Revert Mcore update since it caused regression | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.gemma\nnemo/collections/llm/gpt/model/gemma.py:40:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:59:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:68:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:76:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:80:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:84:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:104:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:143:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:175:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:194:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:207:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:211:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_base_model\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:103:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:111:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:253:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:271:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:346:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:606:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:661:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:833:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:971:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:990:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1107:0: C0301: Line too long (195/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1164:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1213:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1296:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:330:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:461:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:466:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:699:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:751:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:932:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1036:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1271:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1302:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1310:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_retro_model\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:36:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:142:0: C0301: Line too long (191/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:304:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:335:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:386:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:441:0: C0301: Line too long (206/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:451:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:458:0: C0301: Line too long (210/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:462:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:15:0: W0611: Unused import itertools (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:18:0: W0611: Unused import queue (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:20:0: W0611: Unused import warnings (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:21:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Iterator imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused List imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Union imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:26:0: W0611: Unused CPUAccelerator imported from lightning.pytorch.accelerators (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:38:0: W0611: Unused MegatronBaseModel imported from nemo.collections.nlp.models.language_modeling.megatron_base_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:40:0: W0611: Unused build_model imported from nemo.collections.nlp.modules.common.megatron.build_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:41:0: W0611: Unused Float16Module imported from nemo.collections.nlp.modules.common.megatron.module (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_all_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_ltor_masks_and_position_ids imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:49:0: W0611: Unused TextGenerationStrategy imported from nemo.collections.nlp.modules.common.text_generation_strategy (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_length_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_sampling_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused megatron_gpt_generate imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused LengthParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused OutputType imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused SamplingParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused TextGeneration imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:63:0: W0611: Unused utils_funcs imported from nemo.collections.nlp.parts (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused get_last_rank imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:65:0: W0611: Unused Exportable imported from nemo.core.classes (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:66:0: W0611: Unused PretrainedModelInfo imported from nemo.core.classes.common (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused ChannelType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused NeuralType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:72:4: W0611: Unused InferenceParams imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:80:4: W0611: Unused TransformerConfig imported from megatron.core.transformer.transformer_config (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:81:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:81:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module scripts.checkpoint_converters.convert_bert_hf_to_nemo\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:65:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:79:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.42/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @pablo-garay 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12678860600) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-08T20:47:06 | 2025-01-09T07:45:40 | 2025-01-09T07:45:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11791",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11791",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11791.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11791.patch",
"merged_at": "2025-01-09T07:45:39"
} | Revert Mcore update since it caused regression | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11791/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11791/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11790 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11790/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11790/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11790/events | https://github.com/NVIDIA/NeMo/pull/11790 | 2,776,152,047 | PR_kwDOC_bI7s6HHd0a | 11,790 | build: Move dependencies | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12705952982) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12812258362) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12819529675) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12837599093) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12847738959) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12857570379) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-08T19:24:35 | 2025-01-20T08:34:14 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11790",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11790",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11790.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11790.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11790/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11790/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11789 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11789/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11789/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11789/events | https://github.com/NVIDIA/NeMo/pull/11789 | 2,776,005,458 | PR_kwDOC_bI7s6HG9Yf | 11,789 | Add null tokenizer | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
},
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @erhoo82 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12684452138) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-08T18:04:18 | 2025-01-09T16:24:52 | 2025-01-09T16:24:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11789",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11789",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11789.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11789.patch",
"merged_at": "2025-01-09T16:24:49"
} | # What does this PR do ?
Add a null tokenizer to ease the runs for performance benchmark and debugging
# Changelog
Add a null tokenizer
# Usage
```python
tokenizer=run.Config(
get_nmt_tokenizer,
library="null",
model_name = "NullTokenizer",
vocab_size = 256000,
)
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11789/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11789/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11788 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11788/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11788/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11788/events | https://github.com/NVIDIA/NeMo/pull/11788 | 2,775,987,624 | PR_kwDOC_bI7s6HG5gg | 11,788 | 8x22b seq len | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:163:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:329:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:125:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:139:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:300:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:323:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:343:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:347:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.run.plugins\nnemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)\nnemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)\nnemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)\nnemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/run/plugins.py:183:0: C0301: Line too long (174/119) (line-too-long)\nnemo/lightning/run/plugins.py:259:0: C0301: Line too long (150/119) (line-too-long)\nnemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.39/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @malay-nagda 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12708958106) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-08T17:54:16 | 2025-01-10T19:08:52 | 2025-01-10T19:08:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11788",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11788",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11788.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11788.patch",
"merged_at": "2025-01-10T19:08:49"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11788/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11788/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11787 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11787/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11787/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11787/events | https://github.com/NVIDIA/NeMo/pull/11787 | 2,775,806,239 | PR_kwDOC_bI7s6HGSPT | 11,787 | Add BERT Embedding Models E5 Recipe | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron_gpt_model\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:327:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:367:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:413:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:460:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:793:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1108:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1129:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1339:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1380:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1437:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1619:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1620:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1622:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1794:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1814:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1822:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1843:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1913:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1940:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:140:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:153:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:179:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:198:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:469:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:472:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:703:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:707:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:789:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1106:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1179:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1228:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1257:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1450:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1586:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1594:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1603:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1888:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2041:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2048:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2054:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:20:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:28:0: W0611: Unused _DataFetcherWrapper imported from lightning.pytorch.loops.fetchers (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:30:0: W0611: Unused OmegaConf imported from omegaconf (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:72:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:81:4: W0611: Unused megatron.core imported as core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:82:4: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.50/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12694848664) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-08T16:23:24 | 2025-01-10T16:56:15 | 2025-01-10T16:56:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11787",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11787",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11787.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11787.patch",
"merged_at": "2025-01-10T16:56:14"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11787/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11787/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11786 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11786/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11786/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11786/events | https://github.com/NVIDIA/NeMo/pull/11786 | 2,775,765,399 | PR_kwDOC_bI7s6HGJXZ | 11,786 | Fix Mistral Conversion Issue | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12678713987) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-08T16:04:23 | 2025-01-14T14:15:03 | 2025-01-09T06:08:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11786",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11786",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11786.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11786.patch",
"merged_at": "2025-01-09T06:08:00"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11786/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11786/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11785 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11785/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11785/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11785/events | https://github.com/NVIDIA/NeMo/pull/11785 | 2,773,980,084 | PR_kwDOC_bI7s6G_8lQ | 11,785 | chore(beep boop 🤖): Bump `MCORE_TAG=4dc8977...` (2025-01-08) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-08T00:22:47 | 2025-01-08T09:27:14 | 2025-01-08T09:27:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11785",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11785",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11785.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11785.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=4dc8977167d71f86bdec47a60a98e85c4cfa0031`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11785/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11785/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11784 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11784/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11784/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11784/events | https://github.com/NVIDIA/NeMo/issues/11784 | 2,773,851,418 | I_kwDOC_bI7s6lVZ0a | 11,784 | NeMo Llama 2 70B Pre-Training 20TB Dataset OOM | {
"login": "shengshiqi-google",
"id": 160179165,
"node_id": "U_kgDOCYwj3Q",
"avatar_url": "https://avatars.githubusercontent.com/u/160179165?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shengshiqi-google",
"html_url": "https://github.com/shengshiqi-google",
"followers_url": "https://api.github.com/users/shengshiqi-google/followers",
"following_url": "https://api.github.com/users/shengshiqi-google/following{/other_user}",
"gists_url": "https://api.github.com/users/shengshiqi-google/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shengshiqi-google/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shengshiqi-google/subscriptions",
"organizations_url": "https://api.github.com/users/shengshiqi-google/orgs",
"repos_url": "https://api.github.com/users/shengshiqi-google/repos",
"events_url": "https://api.github.com/users/shengshiqi-google/events{/privacy}",
"received_events_url": "https://api.github.com/users/shengshiqi-google/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Increasing num_workers can increase the host memory usage. Is my understanding correct that these A3 mega nodes have ~1.8TB of host memory? Do you have data points of how the process mem increase as you increase num_workers?\n\nDoes increasing the shared memory like in [this summary comment](https://github.com/pytorch/pytorch/issues/13246#issuecomment-905703662) help in your case?",
"Also, if you're not using [Nemo 2.0](https://docs.nvidia.com/nemo-framework/user-guide/latest/nemo-2.0/index.html), I think that would be worth a try. I have seen anecdotes of host OOMs going away after switching",
"> Is my understanding correct that these A3 mega nodes have ~1.8TB of host memory?\n\nCorrect, our two-node cluster has a total of 3,760 GB\n\n> Do you have data points of how the process mem increase as you increase num_workers?\n\nWhat would be the most helpful format to share this data?\n\nReducing num_nodes or reducing the dataset size will reduce the total amount of CPU memory used. We will experiment increasing shared memory.",
"> Also, if you're not using [Nemo 2.0](https://docs.nvidia.com/nemo-framework/user-guide/latest/nemo-2.0/index.html), I think that would be worth a try. I have seen anecdotes of host OOMs going away after switching\n\nHi Terry, thank you for your help. We did try NeMo 2.0, and found that it does indeed resolve the OOM issue.\n\nHowever, it appears that NeMo 2.0 does not have Kubernetes support for it yet. Do you have any ideas on when that might happen?",
"> Hi Terry, thank you for your help. We did try NeMo 2.0, and found that it does indeed resolve the OOM issue.\n\nActually there is k8s support via skypilot: https://github.com/NVIDIA/NeMo-Run/blob/main/docs/source/guides/execution.md#execute-nemo-run\n\nPlease give that a try and feel free to leave feedback for the nemo-run team if something is missing.",
"Closing this issue as the original OOM has a resolution. Please open another issue for any issues/requests for k8s."
] | 2025-01-07T22:14:17 | 2025-01-14T21:30:55 | 2025-01-14T21:30:54 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
NeMo Llama 2 70B Pre-Training 20TB Dataset out-of-memory (CPU memory)
**Steps/Code to reproduce bug**
Using the default YAML file here: https://github.com/NVIDIA/NeMo-Framework-Launcher/blob/main/launcher_scripts/conf/training/llama/llama2_70b.yaml
The dataset is the pile dataset replicated 35 times such that its size is 20TB
We run this on a GKE cluster with 2 A3 Mega nodes
**Expected behavior**
We expect the training to run successfully with num_workers=4. But this runs into OOM error. Reducing num_workers to 2 worked. But this is problematic because we are using GCSFuse and the latency is high, so num_workers=2 is not able to saturate the training.
So we want to know if this is a known problem on Nvidia's end.
**Environment overview (please complete the following information)**
- Environment location: GCP GKE
**Environment details**
NeMo 24.07
| {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11784/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11784/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11783 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11783/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11783/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11783/events | https://github.com/NVIDIA/NeMo/pull/11783 | 2,773,847,200 | PR_kwDOC_bI7s6G_f7L | 11,783 | Cherry pick llava next changes that were missed for the release | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @yashaswikarnati 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12669601008) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-07T22:12:08 | 2025-01-08T18:50:12 | 2025-01-08T18:50:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11783",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11783",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11783.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11783.patch",
"merged_at": "2025-01-08T18:50:11"
} | # What does this PR do ?
Cherry pick llava next changes that were missed for the release
**Collection**: [Note which collection this PR will affect]
Multimodal
# Changelog
- Cherry pick following PRs
https://github.com/NVIDIA/NeMo/pull/11563
https://github.com/NVIDIA/NeMo/pull/11661
https://github.com/NVIDIA/NeMo/pull/11424
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11783/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11783/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11782 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11782/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11782/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11782/events | https://github.com/NVIDIA/NeMo/pull/11782 | 2,773,820,227 | PR_kwDOC_bI7s6G_Zyq | 11,782 | Use empty dict instead of none to load only metadata from dist ckpt | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12659990780) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-07T21:57:41 | 2025-01-08T07:26:51 | 2025-01-08T07:26:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11782",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11782",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11782.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11782.patch",
"merged_at": "2025-01-08T07:26:49"
} | due to change in mcore commit https://github.com/NVIDIA/Megatron-LM/commit/31e8bfa926ca05a3b70a48d3ed6b86410a85a262
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11782/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11782/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11781 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11781/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11781/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11781/events | https://github.com/NVIDIA/NeMo/pull/11781 | 2,773,774,377 | PR_kwDOC_bI7s6G_PkV | 11,781 | only install bitsandbytes on x86 | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12659774131) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-07T21:30:58 | 2025-01-08T07:17:02 | 2025-01-08T07:17:00 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11781",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11781",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11781.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11781.patch",
"merged_at": "2025-01-08T07:17:00"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11781/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11781/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11780 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11780/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11780/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11780/events | https://github.com/NVIDIA/NeMo/pull/11780 | 2,773,672,131 | PR_kwDOC_bI7s6G-5IV | 11,780 | Updated preprocess_text.py to fix NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list(). | {
"login": "Adesoji1",
"id": 20457308,
"node_id": "MDQ6VXNlcjIwNDU3MzA4",
"avatar_url": "https://avatars.githubusercontent.com/u/20457308?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Adesoji1",
"html_url": "https://github.com/Adesoji1",
"followers_url": "https://api.github.com/users/Adesoji1/followers",
"following_url": "https://api.github.com/users/Adesoji1/following{/other_user}",
"gists_url": "https://api.github.com/users/Adesoji1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Adesoji1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Adesoji1/subscriptions",
"organizations_url": "https://api.github.com/users/Adesoji1/orgs",
"repos_url": "https://api.github.com/users/Adesoji1/repos",
"events_url": "https://api.github.com/users/Adesoji1/events{/privacy}",
"received_events_url": "https://api.github.com/users/Adesoji1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module preprocess_text\nscripts/dataset_processing/tts/preprocess_text.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/dataset_processing/tts/preprocess_text.py:161:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.75/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"@cuichenx ",
"> @cuichenx\r\n\r\nI don't work on the TTS collection. @titu1994 could you reassign?",
"> > @cuichenx\r\n> \r\n> I don't work on the TTS collection. @titu1994 could you reassign?\r\n\r\nSure i will, @XuesongYang @titu1994 kindly view my PR"
] | 2025-01-07T20:25:03 | 2025-01-14T09:55:21 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11780",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11780",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11780.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11780.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11780/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11780/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11779 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11779/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11779/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11779/events | https://github.com/NVIDIA/NeMo/pull/11779 | 2,773,407,418 | PR_kwDOC_bI7s6G9_ml | 11,779 | make progress printer compatible with PTL v2.5.0 | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.progress_printer\nnemo/lightning/pytorch/callbacks/progress_printer.py:116:0: C0301: Line too long (124/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/progress_printer.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:86:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:98:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:106:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:145:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:158:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:187:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:202:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 7.98/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ashors1 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12660129548) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-07T17:43:08 | 2025-01-08T16:12:26 | 2025-01-08T16:12:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11779",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11779",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11779.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11779.patch",
"merged_at": "2025-01-08T16:12:23"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11779/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11779/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11778 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11778/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11778/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11778/events | https://github.com/NVIDIA/NeMo/pull/11778 | 2,773,321,026 | PR_kwDOC_bI7s6G9s2M | 11,778 | [Bugfix] Skip processing if extra_state loads as None | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:165:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:195:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:206:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:210:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:235:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:246:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:267:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:362:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:480:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:567:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:571:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:582:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:594:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:634:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:684:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:25:0: W0611: Unused import tensorstore (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.55/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12655706950) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-07T16:56:12 | 2025-01-08T07:47:49 | 2025-01-08T07:47:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11778",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11778",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11778.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11778.patch",
"merged_at": "2025-01-08T07:47:47"
} | # What does this PR do ?
Addressing bug on trying to parse scaling factors that load to `None` on exporting a model to TensorRT-LLM:
```
File "/opt/NeMo/nemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py", line 496, in load_nemo_model
model = preprocess_scaling_factors_for_local_export(model)
File "/opt/NeMo/nemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py", line 96, in preprocess_scaling_factors_for_local_export
value.seek(0)
AttributeError: 'NoneType' object has no attribute 'seek'
```
Applies only to `use_mcore_path=False` case as extra states in Megatron-LM is correctly filtered out [here](https://github.com/NVIDIA/Megatron-LM/blob/df28200e53056604cad1829ec55bb9ba7c555f23/megatron/core/export/trtllm/trtllm_helper.py#L211-L212).
**Collection**: NLP / LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11778/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11778/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11777 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11777/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11777/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11777/events | https://github.com/NVIDIA/NeMo/pull/11777 | 2,772,763,861 | PR_kwDOC_bI7s6G70CJ | 11,777 | remove tensorstore pin in requirements*.txt | {
"login": "pstjohn",
"id": 2576846,
"node_id": "MDQ6VXNlcjI1NzY4NDY=",
"avatar_url": "https://avatars.githubusercontent.com/u/2576846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pstjohn",
"html_url": "https://github.com/pstjohn",
"followers_url": "https://api.github.com/users/pstjohn/followers",
"following_url": "https://api.github.com/users/pstjohn/following{/other_user}",
"gists_url": "https://api.github.com/users/pstjohn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pstjohn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pstjohn/subscriptions",
"organizations_url": "https://api.github.com/users/pstjohn/orgs",
"repos_url": "https://api.github.com/users/pstjohn/repos",
"events_url": "https://api.github.com/users/pstjohn/events{/privacy}",
"received_events_url": "https://api.github.com/users/pstjohn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-07T12:46:51 | 2025-01-14T15:55:10 | 2025-01-14T15:55:10 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11777",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11777",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11777.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11777.patch",
"merged_at": "2025-01-14T15:55:10"
} | # What does this PR do ?
Removes an outdated pin to tensorstore 0.1.45
**Collection**: [Note which collection this PR will affect]
# Changelog
- Removes version pins in requirements_infer.txt and requirements_nlp.txt
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11777/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11777/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11776 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11776/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11776/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11776/events | https://github.com/NVIDIA/NeMo/issues/11776 | 2,772,613,911 | I_kwDOC_bI7s6lQrsX | 11,776 | Llama 405B NeMo version | {
"login": "sumanthd17",
"id": 28291870,
"node_id": "MDQ6VXNlcjI4MjkxODcw",
"avatar_url": "https://avatars.githubusercontent.com/u/28291870?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sumanthd17",
"html_url": "https://github.com/sumanthd17",
"followers_url": "https://api.github.com/users/sumanthd17/followers",
"following_url": "https://api.github.com/users/sumanthd17/following{/other_user}",
"gists_url": "https://api.github.com/users/sumanthd17/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sumanthd17/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sumanthd17/subscriptions",
"organizations_url": "https://api.github.com/users/sumanthd17/orgs",
"repos_url": "https://api.github.com/users/sumanthd17/repos",
"events_url": "https://api.github.com/users/sumanthd17/events{/privacy}",
"received_events_url": "https://api.github.com/users/sumanthd17/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-07T11:31:07 | 2025-01-07T11:31:07 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | In the models catalog [here](https://catalog.ngc.nvidia.com/models) I could only find Llama 8B and 70B. Is there a 405B version available somewhere?
I tried converting the HF model to NeMo using the `convert_llama_hf_to_nemo.py` script but the code runs out of memory even on a 1TB system. Is there a workaround for this? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11776/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11776/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11775 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11775/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11775/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11775/events | https://github.com/NVIDIA/NeMo/pull/11775 | 2,772,525,119 | PR_kwDOC_bI7s6G6_c1 | 11,775 | Update preprocess_text.py | {
"login": "Adesoji1",
"id": 20457308,
"node_id": "MDQ6VXNlcjIwNDU3MzA4",
"avatar_url": "https://avatars.githubusercontent.com/u/20457308?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Adesoji1",
"html_url": "https://github.com/Adesoji1",
"followers_url": "https://api.github.com/users/Adesoji1/followers",
"following_url": "https://api.github.com/users/Adesoji1/following{/other_user}",
"gists_url": "https://api.github.com/users/Adesoji1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Adesoji1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Adesoji1/subscriptions",
"organizations_url": "https://api.github.com/users/Adesoji1/orgs",
"repos_url": "https://api.github.com/users/Adesoji1/repos",
"events_url": "https://api.github.com/users/Adesoji1/events{/privacy}",
"received_events_url": "https://api.github.com/users/Adesoji1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module preprocess_text\nscripts/dataset_processing/tts/preprocess_text.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/dataset_processing/tts/preprocess_text.py:163:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/dataset_processing/tts/preprocess_text.py:30:0: W0611: Unused import json (unused-import)\nscripts/dataset_processing/tts/preprocess_text.py:31:0: W0611: Unused import os (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.51/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-07T10:51:47 | 2025-01-07T20:21:37 | 2025-01-07T20:21:37 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11775",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11775",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11775.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11775.patch",
"merged_at": null
} | Fix for this warning: NeMo-text-processing :: INFO :: Creating ClassifyFst grammars.
0%| | 0/8 [00:00<?, ?it/s] NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list().
NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list().
NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list().
NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list(). Solution is seen below in Explanation of changes.
Explanation of Changes:
1. Splitting Long Sentences:
After initially splitting the text into sentences, the script iterates through each sentence to check if it exceeds 500 words. If it does, the sentence is further split into smaller chunks of 500 words each.
2. Logging for Debugging:
The script logs a warning if any sentence still exceeds 500 words after the splitting process. This helps in identifying if the splitting logic needs further refinement.
3. Normalization:
Each split sentence is normalized individually. After normalization, the sentences are concatenated back into a single string.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Adesoji1",
"id": 20457308,
"node_id": "MDQ6VXNlcjIwNDU3MzA4",
"avatar_url": "https://avatars.githubusercontent.com/u/20457308?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Adesoji1",
"html_url": "https://github.com/Adesoji1",
"followers_url": "https://api.github.com/users/Adesoji1/followers",
"following_url": "https://api.github.com/users/Adesoji1/following{/other_user}",
"gists_url": "https://api.github.com/users/Adesoji1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Adesoji1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Adesoji1/subscriptions",
"organizations_url": "https://api.github.com/users/Adesoji1/orgs",
"repos_url": "https://api.github.com/users/Adesoji1/repos",
"events_url": "https://api.github.com/users/Adesoji1/events{/privacy}",
"received_events_url": "https://api.github.com/users/Adesoji1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11775/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11775/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11774 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11774/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11774/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11774/events | https://github.com/NVIDIA/NeMo/pull/11774 | 2,771,982,240 | PR_kwDOC_bI7s6G5Ih7 | 11,774 | fix llama-3.1 hf model_id | {
"login": "AtsunoriFujita",
"id": 40932835,
"node_id": "MDQ6VXNlcjQwOTMyODM1",
"avatar_url": "https://avatars.githubusercontent.com/u/40932835?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AtsunoriFujita",
"html_url": "https://github.com/AtsunoriFujita",
"followers_url": "https://api.github.com/users/AtsunoriFujita/followers",
"following_url": "https://api.github.com/users/AtsunoriFujita/following{/other_user}",
"gists_url": "https://api.github.com/users/AtsunoriFujita/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AtsunoriFujita/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AtsunoriFujita/subscriptions",
"organizations_url": "https://api.github.com/users/AtsunoriFujita/orgs",
"repos_url": "https://api.github.com/users/AtsunoriFujita/repos",
"events_url": "https://api.github.com/users/AtsunoriFujita/events{/privacy}",
"received_events_url": "https://api.github.com/users/AtsunoriFujita/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-07T06:11:17 | 2025-01-07T06:11:17 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11774",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11774",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11774.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11774.patch",
"merged_at": null
} | # What does this PR do ?
fix llama-3.1 hf model_id
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11774/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11774/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11772 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11772/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11772/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11772/events | https://github.com/NVIDIA/NeMo/pull/11772 | 2,771,710,819 | PR_kwDOC_bI7s6G4OmG | 11,772 | draft: alternative packed seq format to prevent memory blow | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.data.language_modeling.megatron.gpt_sft_dataset\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:76:0: C0301: Line too long (353/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:78:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:79:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:85:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:88:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:89:0: C0301: Line too long (178/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:90:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:91:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:93:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:96:0: C0301: Line too long (247/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:171:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:180:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:250:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:253:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:278:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:283:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:284:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:306:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:395:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:723:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:42:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:546:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.39/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2025-01-07T01:21:38 | 2025-01-07T01:22:58 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11772",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11772",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11772.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11772.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11772/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11772/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11771 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11771/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11771/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11771/events | https://github.com/NVIDIA/NeMo/pull/11771 | 2,771,689,815 | PR_kwDOC_bI7s6G4KV- | 11,771 | fix: mcore_ckpt_to_nemo.py broken from load_mlm arg | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.nlp_model\nnemo/collections/nlp/models/nlp_model.py:187:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:191:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:196:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:286:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:421:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/nlp_model.py:452:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.71/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @terrykong 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12643086068) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-07T00:56:09 | 2025-01-15T01:28:03 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11771",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11771",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11771.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11771.patch",
"merged_at": null
} | In examples/nlp/language_modeling/megatron_ckpt_to_nemo.py, the introduction of load_mlm in this invocation
https://github.com/NVIDIA/NeMo/blob/5ed118f24c31ba1e4729ff3fae33dc8482bd1b64/examples/nlp/language_modeling/megatron_ckpt_to_nemo.py#L203
causes an error because load_mlm is not excluded from the model config during the update in nlp_model.py. This change just excludes all keys not in the model config to avoid this kind of error for other kwargs that aren't model config args.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11771/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11771/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11770 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11770/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11770/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11770/events | https://github.com/NVIDIA/NeMo/pull/11770 | 2,771,681,671 | PR_kwDOC_bI7s6G4IoG | 11,770 | Update requirements_lightning.txt | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"Could you also please update **lightning** version here: https://github.com/NVIDIA/NeMo/blob/main/requirements/requirements_vllm.txt#L8\r\n\r\n(It's a separate requirements file used for creating virtual environment for vLLM; for verification we're going to add a vLLM export test to Github Actions soon in https://github.com/NVIDIA/NeMo/pull/11543)"
] | 2025-01-07T00:45:31 | 2025-01-14T08:25:46 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11770",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11770",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11770.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11770.patch",
"merged_at": null
} | PTL to 2.5.0.post0 (used in 24.12 release) | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11770/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11770/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11769 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11769/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11769/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11769/events | https://github.com/NVIDIA/NeMo/pull/11769 | 2,771,668,040 | PR_kwDOC_bI7s6G4Fyx | 11,769 | [pre-commit.ci] pre-commit suggestions | {
"login": "pre-commit-ci[bot]",
"id": 66853113,
"node_id": "MDM6Qm90NjY4NTMxMTM=",
"avatar_url": "https://avatars.githubusercontent.com/in/68672?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D",
"html_url": "https://github.com/apps/pre-commit-ci",
"followers_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/pre-commit-ci%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2025-01-07T00:28:59 | 2025-01-07T00:28:59 | null | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11769",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11769",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11769.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11769.patch",
"merged_at": null
} | <!--pre-commit.ci start-->
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v5.0.0](https://github.com/pre-commit/pre-commit-hooks/compare/v4.3.0...v5.0.0)
- [github.com/psf/black-pre-commit-mirror: 24.3.0 → 24.10.0](https://github.com/psf/black-pre-commit-mirror/compare/24.3.0...24.10.0)
<!--pre-commit.ci end--> | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11769/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11769/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11768 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11768/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11768/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11768/events | https://github.com/NVIDIA/NeMo/pull/11768 | 2,771,663,112 | PR_kwDOC_bI7s6G4Ewi | 11,768 | chore(beep boop 🤖): Bump `MCORE_TAG=4dc8977...` (2025-01-07) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12661151842) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-07T00:23:09 | 2025-01-08T09:59:57 | 2025-01-08T09:59:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11768",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11768",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11768.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11768.patch",
"merged_at": "2025-01-08T09:59:55"
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=4dc8977167d71f86bdec47a60a98e85c4cfa0031`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11768/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11768/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11767 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11767/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11767/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11767/events | https://github.com/NVIDIA/NeMo/pull/11767 | 2,771,536,589 | PR_kwDOC_bI7s6G3pf0 | 11,767 | fix sentencepiece tokenizer special tokens | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.tokenizers.sentencepiece_tokenizer\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:42:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:43:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:307:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:362:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:371:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:376:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:377:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:378:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:203:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:257:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:265:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:281:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:288:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:302:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:314:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:323:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/tokenizers/sentencepiece_tokenizer.py:324:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.tokenizer_utils\nnemo/collections/nlp/modules/common/tokenizer_utils.py:73:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:131:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:232:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:42:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.34/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12641661695) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-06T22:14:42 | 2025-01-07T04:55:00 | 2025-01-07T04:54:58 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11767",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11767",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11767.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11767.patch",
"merged_at": "2025-01-07T04:54:58"
} | # What does this PR do ?
Special tokens were not passed to sentencepiece library.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11767/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11767/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11766 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11766/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11766/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11766/events | https://github.com/NVIDIA/NeMo/pull/11766 | 2,771,439,636 | PR_kwDOC_bI7s6G3UUd | 11,766 | Pipeline-parallel support for Knowledge Distillation (NeMo 2) | {
"login": "AAnoosheh",
"id": 5615503,
"node_id": "MDQ6VXNlcjU2MTU1MDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/5615503?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AAnoosheh",
"html_url": "https://github.com/AAnoosheh",
"followers_url": "https://api.github.com/users/AAnoosheh/followers",
"following_url": "https://api.github.com/users/AAnoosheh/following{/other_user}",
"gists_url": "https://api.github.com/users/AAnoosheh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AAnoosheh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AAnoosheh/subscriptions",
"organizations_url": "https://api.github.com/users/AAnoosheh/orgs",
"repos_url": "https://api.github.com/users/AAnoosheh/repos",
"events_url": "https://api.github.com/users/AAnoosheh/events{/privacy}",
"received_events_url": "https://api.github.com/users/AAnoosheh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-06T21:00:58 | 2025-01-20T21:47:49 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11766",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11766",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11766.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11766.patch",
"merged_at": null
} | # What does this PR do ?
Enable Pipeline-Parallelism in conjunction with student-teacher distillation in NeMo 2
**Collection**: [LLM]
# Changelog
- Create new script to enable KD in NeMo 2
- Modify the `MegatronParallel` forward pass to run teacher in addition to student
# Usage
* TBA
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11766/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11766/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11765 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11765/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11765/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11765/events | https://github.com/NVIDIA/NeMo/pull/11765 | 2,771,427,989 | PR_kwDOC_bI7s6G3RzF | 11,765 | Update requirements_lightning.txt | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"[🤖]: Hi @pablo-garay 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12763746325) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-06T20:53:09 | 2025-01-14T10:57:37 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11765",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11765",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11765.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11765.patch",
"merged_at": null
} | PTL to 2.5.0.post0 (used in 24.12 release) | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11765/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11765/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11764 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11764/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11764/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11764/events | https://github.com/NVIDIA/NeMo/pull/11764 | 2,771,425,748 | PR_kwDOC_bI7s6G3RT5 | 11,764 | Add additional arguments to TransformerLayer subclasses | {
"login": "mathemakitten",
"id": 31600291,
"node_id": "MDQ6VXNlcjMxNjAwMjkx",
"avatar_url": "https://avatars.githubusercontent.com/u/31600291?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mathemakitten",
"html_url": "https://github.com/mathemakitten",
"followers_url": "https://api.github.com/users/mathemakitten/followers",
"following_url": "https://api.github.com/users/mathemakitten/following{/other_user}",
"gists_url": "https://api.github.com/users/mathemakitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mathemakitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mathemakitten/subscriptions",
"organizations_url": "https://api.github.com/users/mathemakitten/orgs",
"repos_url": "https://api.github.com/users/mathemakitten/repos",
"events_url": "https://api.github.com/users/mathemakitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/mathemakitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [] | 2025-01-06T20:51:29 | 2025-01-08T23:11:59 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11764",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11764",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11764.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11764.patch",
"merged_at": null
} | # What does this PR do ?
Add `sequence_len_offset` to the signature of subclasses of TransformerLayer for compatibility with inference updates.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11764/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11764/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11763 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11763/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11763/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11763/events | https://github.com/NVIDIA/NeMo/pull/11763 | 2,771,172,571 | PR_kwDOC_bI7s6G2Z2x | 11,763 | Recipe changes for performance | {
"login": "guyueh1",
"id": 140554423,
"node_id": "U_kgDOCGCwtw",
"avatar_url": "https://avatars.githubusercontent.com/u/140554423?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guyueh1",
"html_url": "https://github.com/guyueh1",
"followers_url": "https://api.github.com/users/guyueh1/followers",
"following_url": "https://api.github.com/users/guyueh1/following{/other_user}",
"gists_url": "https://api.github.com/users/guyueh1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guyueh1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guyueh1/subscriptions",
"organizations_url": "https://api.github.com/users/guyueh1/orgs",
"repos_url": "https://api.github.com/users/guyueh1/repos",
"events_url": "https://api.github.com/users/guyueh1/events{/privacy}",
"received_events_url": "https://api.github.com/users/guyueh1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.recipes.tp_overlap_configs.userbuffers\nnemo/collections/llm/recipes/tp_overlap_configs/userbuffers.py:19:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/recipes/tp_overlap_configs/userbuffers.py:24:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/recipes/tp_overlap_configs/userbuffers.py:34:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/recipes/tp_overlap_configs/userbuffers.py:42:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/recipes/tp_overlap_configs/userbuffers.py:50:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.run.plugins\nnemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)\nnemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)\nnemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)\nnemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/run/plugins.py:183:0: C0301: Line too long (174/119) (line-too-long)\nnemo/lightning/run/plugins.py:259:0: C0301: Line too long (150/119) (line-too-long)\nnemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:206:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:22:0: W0611: Unused import torch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.35/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-06T18:04:49 | 2025-01-15T17:59:02 | null | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11763",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11763",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11763.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11763.patch",
"merged_at": null
} | # What does this PR do ?
Recipe changes for performance in 25.01 release
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11763/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11763/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11762 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11762/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11762/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11762/events | https://github.com/NVIDIA/NeMo/pull/11762 | 2,771,122,791 | PR_kwDOC_bI7s6G2O6F | 11,762 | add nsys profiling to ESM-2 benchmarking and apply rope | {
"login": "sichu2023",
"id": 152360507,
"node_id": "U_kgDOCRTWOw",
"avatar_url": "https://avatars.githubusercontent.com/u/152360507?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sichu2023",
"html_url": "https://github.com/sichu2023",
"followers_url": "https://api.github.com/users/sichu2023/followers",
"following_url": "https://api.github.com/users/sichu2023/following{/other_user}",
"gists_url": "https://api.github.com/users/sichu2023/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sichu2023/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sichu2023/subscriptions",
"organizations_url": "https://api.github.com/users/sichu2023/orgs",
"repos_url": "https://api.github.com/users/sichu2023/repos",
"events_url": "https://api.github.com/users/sichu2023/events{/privacy}",
"received_events_url": "https://api.github.com/users/sichu2023/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.bert.model.esm\nnemo/collections/llm/bert/model/esm.py:7:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/bert/model/esm.py:16:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/bert/model/esm.py:25:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/bert/model/esm.py:3:0: W0611: Unused HuggingFaceBertModel imported from nemo.collections.llm.bert.model.bert (unused-import)\n************* Module nemo2_esm2_tp\nnemo2_esm2_tp.py:52:0: C0301: Line too long (153/119) (line-too-long)\nnemo2_esm2_tp.py:53:0: C0301: Line too long (179/119) (line-too-long)\nnemo2_esm2_tp.py:28:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo2_esm2_tp.py:22:0: W0611: Unused AutoTokenizer imported from nemo.collections.common.tokenizers (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.04/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-06T17:33:18 | 2025-01-08T17:39:22 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11762",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11762",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11762.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11762.patch",
"merged_at": null
} | null | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11762/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11762/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11760 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11760/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11760/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11760/events | https://github.com/NVIDIA/NeMo/pull/11760 | 2,769,960,061 | PR_kwDOC_bI7s6GyUy1 | 11,760 | gpt moe perf scripts | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:163:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:329:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:125:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:139:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:300:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:323:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:343:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:347:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.38/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @malay-nagda 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12635540306) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-06T06:47:17 | 2025-01-07T17:05:26 | 2025-01-07T17:05:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11760",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11760",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11760.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11760.patch",
"merged_at": "2025-01-07T17:05:22"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11760/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11760/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11759 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11759/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11759/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11759/events | https://github.com/NVIDIA/NeMo/pull/11759 | 2,769,755,949 | PR_kwDOC_bI7s6GxoHJ | 11,759 | add chat sft dataset to support agent tool calling | {
"login": "chenrui17",
"id": 33319780,
"node_id": "MDQ6VXNlcjMzMzE5Nzgw",
"avatar_url": "https://avatars.githubusercontent.com/u/33319780?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chenrui17",
"html_url": "https://github.com/chenrui17",
"followers_url": "https://api.github.com/users/chenrui17/followers",
"following_url": "https://api.github.com/users/chenrui17/following{/other_user}",
"gists_url": "https://api.github.com/users/chenrui17/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chenrui17/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chenrui17/subscriptions",
"organizations_url": "https://api.github.com/users/chenrui17/orgs",
"repos_url": "https://api.github.com/users/chenrui17/repos",
"events_url": "https://api.github.com/users/chenrui17/events{/privacy}",
"received_events_url": "https://api.github.com/users/chenrui17/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.data.language_modeling.megatron.gpt_sft_chat_dataset\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:113:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:116:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:147:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:156:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:177:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:240:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:182:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py:311:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.52/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-06T03:46:30 | 2025-01-14T17:23:31 | 2025-01-14T17:23:31 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11759",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11759",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11759.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11759.patch",
"merged_at": "2025-01-14T17:23:31"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11759/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11759/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11758 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11758/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11758/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11758/events | https://github.com/NVIDIA/NeMo/pull/11758 | 2,769,529,240 | PR_kwDOC_bI7s6Gw2H1 | 11,758 | chore(beep boop 🤖): Bump `MCORE_TAG=2d7c521...` (2025-01-06) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-06T00:24:07 | 2025-01-08T09:27:19 | 2025-01-08T09:27:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11758",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11758",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11758.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11758.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=2d7c521de7c5878501cf7e366e7d8e13267c8eb6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11758/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11758/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11757 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11757/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11757/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11757/events | https://github.com/NVIDIA/NeMo/pull/11757 | 2,769,053,306 | PR_kwDOC_bI7s6GvX0s | 11,757 | chore(beep boop 🤖): Bump `MCORE_TAG=30ffe88...` (2025-01-05) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-05T00:25:01 | 2025-01-08T09:27:22 | 2025-01-08T09:27:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11757",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11757",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11757.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11757.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=30ffe880d15df0d72d5d0cb90707283ce977835d`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11757/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11757/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11756 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11756/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11756/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11756/events | https://github.com/NVIDIA/NeMo/issues/11756 | 2,768,367,146 | I_kwDOC_bI7s6lAe4q | 11,756 | llm.import_ckpt cannot run directly | {
"login": "LingxiaoShawn",
"id": 16176421,
"node_id": "MDQ6VXNlcjE2MTc2NDIx",
"avatar_url": "https://avatars.githubusercontent.com/u/16176421?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LingxiaoShawn",
"html_url": "https://github.com/LingxiaoShawn",
"followers_url": "https://api.github.com/users/LingxiaoShawn/followers",
"following_url": "https://api.github.com/users/LingxiaoShawn/following{/other_user}",
"gists_url": "https://api.github.com/users/LingxiaoShawn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/LingxiaoShawn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/LingxiaoShawn/subscriptions",
"organizations_url": "https://api.github.com/users/LingxiaoShawn/orgs",
"repos_url": "https://api.github.com/users/LingxiaoShawn/repos",
"events_url": "https://api.github.com/users/LingxiaoShawn/events{/privacy}",
"received_events_url": "https://api.github.com/users/LingxiaoShawn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [] | 2025-01-04T02:14:13 | 2025-01-04T02:14:13 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | When I run the following code directly, it seems there is a deadlock inside with spawn multiple processes. The follow code is exactly the same as just use llm.import_ckpt directly as a main function.
```
from nemo.collections import llm
import nemo_run as run
ckpt_import = run.Partial(
llm.import_ckpt,
model=run.Config(llm.LlamaModel, config=run.Config(llm.Llama31Config8B)),
source=f'hf://{model_path}',
overwrite=True,
)
local_executor = run.LocalExecutor()
run.run(ckpt_import, executor=local_executor, direct=True)
```
However, if I remove direct=True, and use the local_executor to run the importer, the checkpoint can be successfully transformed.
```
run.run(ckpt_import, executor=local_executor) # can sucess
```
Can you let me know whether this behavior is expected or there is a bug within the ModelConnector?
Thank you!
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11756/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11756/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11755 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11755/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11755/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11755/events | https://github.com/NVIDIA/NeMo/pull/11755 | 2,768,333,515 | PR_kwDOC_bI7s6Gs86x | 11,755 | Allow configuration of PP communication backend to UCC in nemo2 | {
"login": "guyueh1",
"id": 140554423,
"node_id": "U_kgDOCGCwtw",
"avatar_url": "https://avatars.githubusercontent.com/u/140554423?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guyueh1",
"html_url": "https://github.com/guyueh1",
"followers_url": "https://api.github.com/users/guyueh1/followers",
"following_url": "https://api.github.com/users/guyueh1/following{/other_user}",
"gists_url": "https://api.github.com/users/guyueh1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guyueh1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guyueh1/subscriptions",
"organizations_url": "https://api.github.com/users/guyueh1/orgs",
"repos_url": "https://api.github.com/users/guyueh1/repos",
"events_url": "https://api.github.com/users/guyueh1/events{/privacy}",
"received_events_url": "https://api.github.com/users/guyueh1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [] | 2025-01-04T00:52:39 | 2025-01-13T16:34:11 | null | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11755",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11755",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11755.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11755.patch",
"merged_at": null
} | # What does this PR do ?
Allow configuration of PP communication backend to UCC (default NCCL) in nemo2
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11755/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11755/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11754 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11754/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11754/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11754/events | https://github.com/NVIDIA/NeMo/pull/11754 | 2,768,315,814 | PR_kwDOC_bI7s6Gs5Ay | 11,754 | chore(beep boop 🤖): Bump `MCORE_TAG=f682bd0...` (2025-01-04) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-04T00:22:17 | 2025-01-08T09:27:24 | 2025-01-08T09:27:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11754",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11754",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11754.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11754.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=f682bd0ee639b04d3d46a3f8f1881a543c7b653d`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11754/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11754/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11753 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11753/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11753/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11753/events | https://github.com/NVIDIA/NeMo/pull/11753 | 2,768,261,653 | PR_kwDOC_bI7s6Gstm- | 11,753 | Add context_logits for eval accuracy calculation in case of multi token prediction tasks | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @athitten 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12684673872) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"LGTM for `nemo/collections/llm` related changes.",
"> Looks good but can you please run the examples here https://docs.nvidia.com/nemo-framework/user-guide/latest/deployment/llm/optimized/tensorrt_llm.html and make sure nothing is broken?\r\n\r\nHi @oyilmaz-nvidia ran the scripts you pointed with HF llama3-8b converted to nemo2. No errors, everything worked fine. Here's the output\r\n\r\n``` Python\r\npython scripts/deploy/nlp/deploy_triton.py --nemo_check\r\npoint /workspace/hf_llama3_8b_nemo2_new.nemo --model_type 'llama' --triton_model_name 'llama3-8b' -\r\n-tensor_parallelism_size 1\r\n```\r\nOutput of `deploy_triton.py`\r\n\r\n``` Python\r\n| cuda_memory_pool_byte_size{1} | 67108864 |\r\n| min_supported_compute_capability | 6.0 |\r\n| strict_readiness | 1 |\r\n| exit_timeout | 30 |\r\n| cache_enabled | 0 |\r\n+----------------------------------+------------------------------------------+\r\n\r\nI0110 00:42:14.989638 1098739 grpc_server.cc:2558] \"Started GRPCInferenceService at 0.0.0.0:8001\"\r\nI0110 00:42:14.989788 1098739 http_server.cc:4713] \"Started HTTPService at 0.0.0.0:8000\"\r\nI0110 00:42:15.030635 1098739 http_server.cc:362] \"Started Metrics Service at 0.0.0.0:8002\"\r\nE0110 00:42:15.571184 1098739 model_repository_manager.cc:470] \"Failed to set config modification time: model_config_content_name_ is empty\"\r\nI0110 00:42:15.571553 1098739 model_lifecycle.cc:472] \"loading: llama3-8b:1\"\r\nI0110 00:42:17.003485 1098739 python_be.cc:2249] \"TRITONBACKEND_ModelInstanceInitialize: llama3-8b_0_0 (CPU device 0)\"\r\nI0110 00:42:17.484886 1098739 model_lifecycle.cc:839] \"successfully loaded 'llama3-8b'\"\r\n[01/10/2025-00:42:17] Model serving on Triton is will be started.\r\n```\r\nInference request:\r\n\r\npython scripts/deploy/nlp/query.py -mn 'llama3-8b' -p \"Hi, how are you?\" -mol 20\r\n\r\nOutput:\r\n\r\n\r\n\r\n\r\n",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:368:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/api.py:369:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/api.py:445:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/llm/api.py:572:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:15:0: W0611: Unused import os (unused-import)\n************* Module nemo.deploy.nlp.query_llm\nnemo/deploy/nlp/query_llm.py:29:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.export.trt_llm.tensorrt_llm_run\nnemo/export/trt_llm/tensorrt_llm_run.py:506:0: C0301: Line too long (125/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:510:0: C0301: Line too long (136/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:514:0: C0301: Line too long (123/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:557:0: C0301: Line too long (181/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:844:0: C0301: Line too long (153/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:524:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:533:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:591:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:33:0: W0611: Unused Mapping imported from tensorrt_llm.mapping (unused-import)\n************* Module nemo.export.vllm_exporter\nnemo/export/vllm_exporter.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/vllm_exporter.py:430:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.89/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @athitten 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12821354408) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-03T22:45:44 | 2025-01-17T19:49:44 | 2025-01-17T19:49:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11753",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11753",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11753.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11753.patch",
"merged_at": "2025-01-17T19:49:43"
} | # What does this PR do ?
This PR adds the following changes:
1) Uses `context_logits` to compute `logProbs` in case of eval benchmarks that have multiple token prediction. For ex: `arc_challenge`, `arc_easy`, `winogrande`, `copa` etc., (where as `MMLU`, `lambada` are single token prediction benchmarks. Uses `generation_logits` for these benchmarks to avoid large payload from `context_logits` )
2) In order to get `context_logits` for evals, the PR exposes `gather_context_logits` and `output_context` logits in `export` and `deploy` files similar to previously existed `generation_logits`
3) Introduces `requirements_eval.txt` file to install `lm-eval-harness` in NeMo FW containers.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11753/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11753/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11752 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11752/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11752/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11752/events | https://github.com/NVIDIA/NeMo/issues/11752 | 2,768,249,155 | I_kwDOC_bI7s6lACFD | 11,752 | What kind of manifest does NEST require? | {
"login": "RomanLeo2003",
"id": 112813754,
"node_id": "U_kgDOBrlmug",
"avatar_url": "https://avatars.githubusercontent.com/u/112813754?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RomanLeo2003",
"html_url": "https://github.com/RomanLeo2003",
"followers_url": "https://api.github.com/users/RomanLeo2003/followers",
"following_url": "https://api.github.com/users/RomanLeo2003/following{/other_user}",
"gists_url": "https://api.github.com/users/RomanLeo2003/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RomanLeo2003/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RomanLeo2003/subscriptions",
"organizations_url": "https://api.github.com/users/RomanLeo2003/orgs",
"repos_url": "https://api.github.com/users/RomanLeo2003/repos",
"events_url": "https://api.github.com/users/RomanLeo2003/events{/privacy}",
"received_events_url": "https://api.github.com/users/RomanLeo2003/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [] | 2025-01-03T22:27:41 | 2025-01-03T22:27:41 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi! I want to train my own pretrained Fast-Conformer model using the NEST framework, but I'm not sure what structure I need for this script: [masked_token_pred_pretrain.py](https://github.com/NVIDIA/NeMo/blob/main/examples/asr/speech_pretraining/masked_token_pred_pretrain.py). Additionally, I don't know what type of validation dataset (validation_ds) I need if the data is unlabeled. Please help me figure this out! | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11752/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11752/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11751 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11751/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11751/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11751/events | https://github.com/NVIDIA/NeMo/pull/11751 | 2,768,010,540 | PR_kwDOC_bI7s6Gr3JX | 11,751 | Do not load context for model transform in llm inference | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @hemildesai 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12626573102) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @hemildesai 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12765152503) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-03T18:40:43 | 2025-01-14T17:20:43 | 2025-01-14T17:20:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11751",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11751",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11751.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11751.patch",
"merged_at": "2025-01-14T17:20:41"
} | null | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11751/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11751/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11750 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11750/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11750/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11750/events | https://github.com/NVIDIA/NeMo/pull/11750 | 2,767,995,469 | PR_kwDOC_bI7s6Grz4U | 11,750 | Update pre_training.py | {
"login": "moradza",
"id": 15005507,
"node_id": "MDQ6VXNlcjE1MDA1NTA3",
"avatar_url": "https://avatars.githubusercontent.com/u/15005507?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/moradza",
"html_url": "https://github.com/moradza",
"followers_url": "https://api.github.com/users/moradza/followers",
"following_url": "https://api.github.com/users/moradza/following{/other_user}",
"gists_url": "https://api.github.com/users/moradza/gists{/gist_id}",
"starred_url": "https://api.github.com/users/moradza/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/moradza/subscriptions",
"organizations_url": "https://api.github.com/users/moradza/orgs",
"repos_url": "https://api.github.com/users/moradza/repos",
"events_url": "https://api.github.com/users/moradza/events{/privacy}",
"received_events_url": "https://api.github.com/users/moradza/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.data.pre_training\nnemo/collections/llm/gpt/data/pre_training.py:136:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/llm/gpt/data/pre_training.py:137:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/llm/gpt/data/pre_training.py:138:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/llm/gpt/data/pre_training.py:390:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/llm/gpt/data/pre_training.py:397:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/llm/gpt/data/pre_training.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/pre_training.py:60:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/pre_training.py:221:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/pre_training.py:284:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/pre_training.py:313:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/pre_training.py:316:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/pre_training.py:319:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/pre_training.py:337:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/pre_training.py:387:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.28/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2025-01-03T18:26:45 | 2025-01-18T01:54:10 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11750",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11750",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11750.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11750.patch",
"merged_at": null
} | fix typo bug
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11750/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11750/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11749 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11749/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11749/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11749/events | https://github.com/NVIDIA/NeMo/pull/11749 | 2,767,842,201 | PR_kwDOC_bI7s6GrSaU | 11,749 | In-framework deployment NeMo 2.0 nemo_export.py test | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.deploy.nlp.megatronllm_deployable\nnemo/deploy/nlp/megatronllm_deployable.py:53:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/nlp/megatronllm_deployable.py:103:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/nlp/megatronllm_deployable.py:446:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.deploy.nlp.query_llm\nnemo/deploy/nlp/query_llm.py:29:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module setup\nsetup.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)\nsetup.py:131:0: C0115: Missing class docstring (missing-class-docstring)\nsetup.py:20:0: W0611: Unused import codecs (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.83/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12713097491) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-03T16:24:04 | 2025-01-10T20:35:02 | 2025-01-10T20:35:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11749",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11749",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11749.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11749.patch",
"merged_at": "2025-01-10T20:35:02"
} | # What does this PR do ?
Adding `nemo_export.py --in-framework True [...]` test in Github Actions. This also includes:
* adding NeMo 2.0 support in this script
* adding [`generate`](https://github.com/NVIDIA/NeMo/blob/3e5fb000ab55071b0685be9986f25eb7e0a2697e/nemo/deploy/nlp/megatronllm_deployable.py#L182) method for `MegatronLLMDeployableNemo2` for parity with NeMo 1.0 [`generate`](https://github.com/NVIDIA/NeMo/blob/84b2bf0989a1cfde0258acb5804cd5bdcd357449/nemo/deploy/nlp/megatronllm_deployable.py#L396) for `MegatronLLMDeployable`
* script to generate a Lambada-like dataset (5 samples) plus several minor bugfixes
**Collection**: NLP/ LLM
# Usage
See edits in `.github/workflows/cicd-main.yml`.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11749/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11749/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11748 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11748/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11748/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11748/events | https://github.com/NVIDIA/NeMo/pull/11748 | 2,767,805,090 | PR_kwDOC_bI7s6GrKPS | 11,748 | Enable packed seqs for validation | {
"login": "jiemingz",
"id": 133159885,
"node_id": "U_kgDOB-_bzQ",
"avatar_url": "https://avatars.githubusercontent.com/u/133159885?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jiemingz",
"html_url": "https://github.com/jiemingz",
"followers_url": "https://api.github.com/users/jiemingz/followers",
"following_url": "https://api.github.com/users/jiemingz/following{/other_user}",
"gists_url": "https://api.github.com/users/jiemingz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jiemingz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jiemingz/subscriptions",
"organizations_url": "https://api.github.com/users/jiemingz/orgs",
"repos_url": "https://api.github.com/users/jiemingz/repos",
"events_url": "https://api.github.com/users/jiemingz/events{/privacy}",
"received_events_url": "https://api.github.com/users/jiemingz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "jiemingz",
"id": 133159885,
"node_id": "U_kgDOB-_bzQ",
"avatar_url": "https://avatars.githubusercontent.com/u/133159885?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jiemingz",
"html_url": "https://github.com/jiemingz",
"followers_url": "https://api.github.com/users/jiemingz/followers",
"following_url": "https://api.github.com/users/jiemingz/following{/other_user}",
"gists_url": "https://api.github.com/users/jiemingz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jiemingz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jiemingz/subscriptions",
"organizations_url": "https://api.github.com/users/jiemingz/orgs",
"repos_url": "https://api.github.com/users/jiemingz/repos",
"events_url": "https://api.github.com/users/jiemingz/events{/privacy}",
"received_events_url": "https://api.github.com/users/jiemingz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "jiemingz",
"id": 133159885,
"node_id": "U_kgDOB-_bzQ",
"avatar_url": "https://avatars.githubusercontent.com/u/133159885?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jiemingz",
"html_url": "https://github.com/jiemingz",
"followers_url": "https://api.github.com/users/jiemingz/followers",
"following_url": "https://api.github.com/users/jiemingz/following{/other_user}",
"gists_url": "https://api.github.com/users/jiemingz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jiemingz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jiemingz/subscriptions",
"organizations_url": "https://api.github.com/users/jiemingz/orgs",
"repos_url": "https://api.github.com/users/jiemingz/repos",
"events_url": "https://api.github.com/users/jiemingz/events{/privacy}",
"received_events_url": "https://api.github.com/users/jiemingz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@guyueh1 , @cuichenx \r\nWhat is the status of this PR? Ready for merge?",
"LGTM",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.data.packed_sequence\nnemo/collections/llm/gpt/data/packed_sequence.py:116:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/llm/gpt/data/packed_sequence.py:111:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.nlp.data.language_modeling.megatron.gpt_sft_dataset\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:71:0: C0301: Line too long (353/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:73:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:74:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:80:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:83:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:84:0: C0301: Line too long (178/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:85:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:86:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:88:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:91:0: C0301: Line too long (247/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:166:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:175:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:245:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:248:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:273:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:278:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:279:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:301:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:390:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:678:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py:527:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.53/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @jiemingz 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12677460625) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-03T15:57:12 | 2025-01-09T02:17:31 | 2025-01-09T02:17:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11748",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11748",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11748.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11748.patch",
"merged_at": "2025-01-09T02:17:29"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jiemingz",
"id": 133159885,
"node_id": "U_kgDOB-_bzQ",
"avatar_url": "https://avatars.githubusercontent.com/u/133159885?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jiemingz",
"html_url": "https://github.com/jiemingz",
"followers_url": "https://api.github.com/users/jiemingz/followers",
"following_url": "https://api.github.com/users/jiemingz/following{/other_user}",
"gists_url": "https://api.github.com/users/jiemingz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jiemingz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jiemingz/subscriptions",
"organizations_url": "https://api.github.com/users/jiemingz/orgs",
"repos_url": "https://api.github.com/users/jiemingz/repos",
"events_url": "https://api.github.com/users/jiemingz/events{/privacy}",
"received_events_url": "https://api.github.com/users/jiemingz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11748/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11748/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11747 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11747/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11747/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11747/events | https://github.com/NVIDIA/NeMo/pull/11747 | 2,767,393,497 | PR_kwDOC_bI7s6Gpvq0 | 11,747 | Fix 'http_port' parameter name in DeployPyTriton usages and update .qnemo compress=True path | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.deploy.deploy_pytriton\nnemo/deploy/deploy_pytriton.py:53:0: C0301: Line too long (132/119) (line-too-long)\nnemo/deploy/deploy_pytriton.py:84:0: C0301: Line too long (126/119) (line-too-long)\n************* Module scripts.deploy.multimodal.deploy_triton\nscripts/deploy/multimodal/deploy_triton.py:102:0: C0301: Line too long (120/119) (line-too-long)\nscripts/deploy/multimodal/deploy_triton.py:33:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/multimodal/deploy_triton.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/multimodal/deploy_triton.py:198:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.deploy.nlp.deploy_inframework_triton\nscripts/deploy/nlp/deploy_inframework_triton.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_inframework_triton.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_inframework_triton.py:71:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.deploy.nlp.deploy_triton\nscripts/deploy/nlp/deploy_triton.py:393:0: C0301: Line too long (121/119) (line-too-long)\nscripts/deploy/nlp/deploy_triton.py:30:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/deploy/nlp/deploy_triton.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:259:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:370:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:377:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.deploy.nlp.deploy_vllm_triton\nscripts/deploy/nlp/deploy_vllm_triton.py:34:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_vllm_triton.py:106:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_vllm_triton.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.68/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12596826660) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-03T11:10:40 | 2025-01-03T18:38:33 | 2025-01-03T18:38:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11747",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11747",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11747.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11747.patch",
"merged_at": "2025-01-03T18:38:32"
} | # What does this PR do ?
* Update the `port` paramter name to `http_port` when instantiating `DeployPyTriton` class following changes in https://github.com/NVIDIA/NeMo/pull/11643
* Minor change for NeMo 1.0 PTQ to not use any compression method when creating a *.qnemo* tarball as it's not really desired & make sure target directory exists in this case.
**Collection**: NLP / LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to https://github.com/NVIDIA/NeMo/pull/11643
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11747/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11747/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11746 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11746/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11746/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11746/events | https://github.com/NVIDIA/NeMo/pull/11746 | 2,767,231,823 | PR_kwDOC_bI7s6GpMfw | 11,746 | Cherry pick `Update changelog for `r2.1.0` (11745)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-03T09:14:14 | 2025-01-03T09:15:12 | 2025-01-03T09:15:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11746",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11746",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11746.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11746.patch",
"merged_at": "2025-01-03T09:15:10"
} | beep boop [🤖]: Hi @github-actions[bot] 👋,
we've cherry picked #11745 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11746/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11746/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11745 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11745/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11745/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11745/events | https://github.com/NVIDIA/NeMo/pull/11745 | 2,767,223,549 | PR_kwDOC_bI7s6GpKt6 | 11,745 | Update changelog for `r2.1.0` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-03T09:08:11 | 2025-01-03T09:13:43 | 2025-01-03T09:13:41 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11745",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11745",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11745.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11745.patch",
"merged_at": "2025-01-03T09:13:41"
} | Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11745/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11745/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11744 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11744/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11744/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11744/events | https://github.com/NVIDIA/NeMo/pull/11744 | 2,767,212,330 | PR_kwDOC_bI7s6GpILv | 11,744 | ci: Fix changelog generator | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-03T09:02:04 | 2025-01-03T10:34:09 | 2025-01-03T10:34:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11744",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11744",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11744.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11744.patch",
"merged_at": "2025-01-03T10:34:07"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11744/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11744/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11743 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11743/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11743/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11743/events | https://github.com/NVIDIA/NeMo/pull/11743 | 2,767,204,871 | PR_kwDOC_bI7s6GpGiB | 11,743 | Update changelog for `ko3n1g/ci/fix-changelog-generator` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2025-01-03T08:56:05 | 2025-01-03T09:01:50 | 2025-01-03T09:01:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11743",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11743",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11743.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11743.patch",
"merged_at": null
} | Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11743/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11743/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11742 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11742/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11742/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11742/events | https://github.com/NVIDIA/NeMo/issues/11742 | 2,767,055,583 | I_kwDOC_bI7s6k7erf | 11,742 | Want learn with model and optim config variable as float16 but i can't | {
"login": "tolry418",
"id": 20792661,
"node_id": "MDQ6VXNlcjIwNzkyNjYx",
"avatar_url": "https://avatars.githubusercontent.com/u/20792661?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tolry418",
"html_url": "https://github.com/tolry418",
"followers_url": "https://api.github.com/users/tolry418/followers",
"following_url": "https://api.github.com/users/tolry418/following{/other_user}",
"gists_url": "https://api.github.com/users/tolry418/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tolry418/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tolry418/subscriptions",
"organizations_url": "https://api.github.com/users/tolry418/orgs",
"repos_url": "https://api.github.com/users/tolry418/repos",
"events_url": "https://api.github.com/users/tolry418/events{/privacy}",
"received_events_url": "https://api.github.com/users/tolry418/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2025-01-03T06:36:24 | 2025-01-06T07:27:32 | 2025-01-06T07:27:32 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello.
I'm beginner of using NeMo framework.
Following the tutorial_pretraining.py (https://docs.nvidia.com/nemo-framework/user-guide/latest/nemo-2.0/quickstart.html)
I want to make small model (mamba7_780m) be learned with my old gpus ( Geforce RTX 2080 Ti -12GB * 2) .
So i wanted to chang model, optimizer variables like bellow. but bf16, fp16 variables are not changed.
The other variable are changed well (ex - adam_beta1) .
#Add
recipe.model.config.fp16 = True
recipe.model.config.bf16 = False
recipe.**optim.config.fp16 = True**
recipe.**optim.config.bf16 = False**
recipe.optim.config.adam_beta1=0.123
#Error
[NeMo I 2025-01-03 05:50:17 utils:302] Setting up optimizer with config OptimizerConfig(optimizer='adam', lr=0.0003, min_lr=None, decoupled_lr=None, decoupled_min_lr=None, weight_decay=0.1, **fp16=False, bf16=True**, params_dtype=torch.bfloat16, loss_scale=None, initial_loss_scale=4294967296, min_loss_scale=1.0, loss_scale_window=1000, hysteresis=2, adam_beta1=0.123, adam_beta2=0.95, adam_eps=1e-05, sgd_momentum=0.9, use_distributed_optimizer=False, overlap_param_gather_with_optimizer_step=False, clip_grad=1.0, log_num_zeros_in_grad=False, barrier_with_L1_time=False, timers=None, config_logger_dir='')
How can i solve it?
The code i edited
```
def configure_recipe(nodes: int = 1, gpus_per_node: int = 1):
recipe = llm.mamba2_780m.pretrain_recipe(
dir="/checkpoints/nemotron", # Path to store checkpoints
name="mamba_pretraining",
num_nodes=nodes,
num_gpus_per_node=gpus_per_node,
tensor_parallelism = 1
)
recipe.trainer.val_check_interval = 100
recipe.data.global_batch_size = 2
recipe.data.micro_batch_size = 1
recipe.data.seq_length = 256
# recipe.model.config.num_layers = 24
recipe.model.config.num_attention_heads = 2
recipe.model.config.fp16 = True
recipe.model.config.bf16 = False
recipe.optim.config.fp16 = True
recipe.optim.config.bf16 = False
recipe.optim.config.use_distributed_optimizer = False
recipe.optim.config.params_dtype = torch.float16
recipe.optim.config.adam_beta1=0.123
return recipe
def local_executor_torchrun(nodes: int = 1, devices: int = 1) -> run.LocalExecutor:
# Env vars for jobs are configured here
env_vars = {
"TORCH_NCCL_AVOID_RECORD_STREAMS": "1",
"NCCL_NVLS_ENABLE": "0",
"NVTE_DP_AMAX_REDUCE_INTERVAL": "0",
"NVTE_ASYNC_AMAX_REDUCTION": "1",
}
executor = run.LocalExecutor(ntasks_per_node=devices, launcher="torchrun", env_vars=env_vars)
return executor
def run_pretraining():
recipe = configure_recipe()
executor = local_executor_torchrun(nodes=recipe.trainer.num_nodes, devices=recipe.trainer.devices)
run.run(recipe, executor=executor, name="mamba2_780m_pretraining")
# This condition is necessary for the script to be compatible with Python's multiprocessing module.
if __name__ == "__main__":
run_pretraining()
```
Here is the result of code
```
──────────────────────────────── Entering Experiment mamba2_780m_pretraining with id: mamba2_780m_pretraining_1735883405 ─────────────────────────────────
[05:50:05] INFO Log directory is: local_scheduler.py:777
/root/.nemo_run/experiments/mamba2_780m_pretraining/mamba2_780m_pretraining_1735883405/mamba2_780m_pretraining
[05:50:05] Launching job mamba2_780m_pretraining for experiment mamba2_780m_pretraining experiment.py:724
INFO Log directory is: local_scheduler.py:777
/root/.nemo_run/experiments/mamba2_780m_pretraining/mamba2_780m_pretraining_1735883405/mamba2_780m_pretraining
INFO Launched app: local_persistent://nemo_run/mamba2_780m_pretraining-ht7tmrvqhgqrgd launcher.py:111
INFO AppStatus: launcher.py:114
State: RUNNING
Num Restarts: 0
Roles:
Msg: <NONE>
Structured Error Msg: <NONE>
UI URL:
file:///root/.nemo_run/experiments/mamba2_780m_pretraining/mamba2_780m_pretraining_1735883405/mamba2_780m_pretraining/
nemo_run/mamba2_780m_pretraining-ht7tmrvqhgqrgd
────────────────────────────────────────── Waiting for Experiment mamba2_780m_pretraining_1735883405 to finish ───────────────────────────────────────────
Experiment Status for mamba2_780m_pretraining_1735883405
Task 0: mamba2_780m_pretraining
- Status: RUNNING
- Executor: LocalExecutor
- Job id: mamba2_780m_pretraining-ht7tmrvqhgqrgd
- Local Directory: /root/.nemo_run/experiments/mamba2_780m_pretraining/mamba2_780m_pretraining_1735883405/mamba2_780m_pretraining
INFO Waiting for job mamba2_780m_pretraining-ht7tmrvqhgqrgd to finish [log=True]... launcher.py:132
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] Starting elastic_operator with launch configs:
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] entrypoint : nemo_run.core.runners.fdl_runner
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] min_nodes : 1
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] max_nodes : 1
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] nproc_per_node : 1
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] run_id : 868
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] rdzv_backend : c10d
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] rdzv_endpoint : localhost:0
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] rdzv_configs : {'timeout': 900}
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] max_restarts : 0
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] monitor_interval : 0.1
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] log_dir : /root/.nemo_run/experiments/mamba2_780m_pretraining/mamba2_780m_pretraining_1735883405/mamba2_780m_pretraining/nemo_run/mamba2_780m_pretraining-ht7tmrvqhgqrgd/torchelastic/mamba2_780m_pretraining
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194] metrics_cfg : {}
retraining/0 I0103 05:50:06.640000 17575 torch/distributed/launcher/api.py:194]
retraining/0 I0103 05:50:06.642000 17575 torch/distributed/elastic/agent/server/api.py:845] [default] starting workers for entrypoint: python
retraining/0 I0103 05:50:06.642000 17575 torch/distributed/elastic/agent/server/api.py:662] [default] Rendezvous'ing worker group
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] [default] Rendezvous complete for workers. Result:
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] restart_count=0
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] master_addr=localhost
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] master_port=36739
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] group_rank=0
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] group_world_size=1
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] local_ranks=[0]
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] role_ranks=[0]
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] global_ranks=[0]
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] role_world_sizes=[1]
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525] global_world_sizes=[1]
retraining/0 I0103 05:50:06.814000 17575 torch/distributed/elastic/agent/server/api.py:525]
retraining/0 I0103 05:50:06.815000 17575 torch/distributed/elastic/agent/server/api.py:670] [default] Starting worker group
retraining/0 I0103 05:50:06.815000 17575 torch/distributed/elastic/agent/server/local_elastic_agent.py:291] use_agent_store: True
retraining/0 I0103 05:50:06.815000 17575 torch/distributed/elastic/agent/server/local_elastic_agent.py:192] Environment variable 'TORCHELASTIC_ENABLE_FILE_TIMER' not found. Do not start FileTimerServer.
retraining/0 I0103 05:50:06.815000 17575 torch/distributed/elastic/agent/server/local_elastic_agent.py:229] Environment variable 'TORCHELASTIC_HEALTH_CHECK_PORT' not found. Do not start health check.
retraining/0 [default0]:[NeMo W 2025-01-03 05:50:14 nemo_logging:361] /usr/local/lib/python3.10/dist-packages/pyannote/core/notebook.py:134: MatplotlibDeprecationWarning: The get_cmap function was deprecated in Matplotlib 3.7 and will be removed in 3.11. Use ``matplotlib.colormaps[name]`` or ``matplotlib.colormaps.get_cmap()`` or ``pyplot.get_cmap()`` instead.
retraining/0 [default0]: cm = get_cmap("Set1")
retraining/0 [default0]:
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 tokenizer_utils:185] Getting HuggingFace AutoTokenizer with pretrained_model_name: EleutherAI/gpt-neox-20b
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 tokenizer_utils:185] Getting HuggingFace AutoTokenizer with pretrained_model_name: EleutherAI/gpt-neox-20b
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 nemo_logger:145] Experiments will be logged at /checkpoints/nemotron/mamba_pretraining
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:426] Rank 0 has data parallel group : [0]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:432] Rank 0 has combined group of data parallel and context parallel : [0]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:437] All data parallel group ranks with context parallel combined: [[0]]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:440] Ranks 0 has data parallel rank: 0
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:448] Rank 0 has context parallel group: [0]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:451] All context parallel group ranks: [[0]]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:452] Ranks 0 has context parallel rank: 0
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:459] Rank 0 has model parallel group: [0]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:460] All model parallel group ranks: [[0]]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:469] Rank 0 has tensor model parallel group: [0]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:473] All tensor model parallel group ranks: [[0]]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:474] Rank 0 has tensor model parallel rank: 0
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:494] Rank 0 has pipeline model parallel group: [0]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:506] Rank 0 has embedding group: [0]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:512] All pipeline model parallel group ranks: [[0]]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:513] Rank 0 has pipeline model parallel rank 0
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:514] All embedding group ranks: [[0]]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:16 megatron_init:515] Rank 0 has embedding rank: 0
retraining/0 [default0]:GPU available: True (cuda), used: True
retraining/0 [default0]:TPU available: False, using: 0 TPU cores
retraining/0 [default0]:HPU available: False, using: 0 HPUs
retraining/0 [default0]:[NeMo W 2025-01-03 05:50:16 nemo_logger:123] No version folders would be created under the log folder as 'resume_if_exists' is enabled.
retraining/0 [default0]:[NeMo W 2025-01-03 05:50:16 nemo_logger:173] "update_logger_directory" is True. Overwriting tensorboard logger "save_dir" to /checkpoints/nemotron/tb_logs
retraining/0 [default0]:[NeMo W 2025-01-03 05:50:16 nemo_logger:189] The Trainer already contains a ModelCheckpoint callback. This will be overwritten.
retraining/0 [default0]:[NeMo W 2025-01-03 05:50:16 nemo_logger:212] The checkpoint callback was told to monitor a validation value and trainer's max_steps was set to 100. Please ensure that max_steps will run for at least 1 epochs to ensure that checkpointing will not error out.
retraining/0 [default0]:[NeMo W 2025-01-03 05:50:16 resume:228] There were no checkpoints found in checkpoint_dir or no checkpoint folder at checkpoint_dir :/checkpoints/nemotron/mamba_pretraining/checkpoints. Training from scratch.
retraining/0 [default0]:Initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/1
retraining/0 [default0]:----------------------------------------------------------------------------------------------------
retraining/0 [default0]:distributed_backend=nccl
retraining/0 [default0]:All distributed processes registered. Starting with 1 processes
retraining/0 [default0]:----------------------------------------------------------------------------------------------------
retraining/0 [default0]:
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 base:44] Padded vocab_size: 50288, original vocab_size: 50277, dummy tokens: 11.
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] Using hybrid override pattern
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] The override pattern matches the overridden pattern
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] Hybrid allocation (M is mamba, * is attention, - is mlp):
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] 0 attention layers in 48 total layers.
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] Target attention ratio: 0.00. Actual attention ratio: 0.00.
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] 0 mlp layers in 48 total layers.
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] Target mlp ratio: 0.00. Actual mlp ratio: 0.00.
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 megatron_strategy:327] Copying Trainer's 'max_steps' (100) to LR scheduler's 'max_steps'.
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 num_microbatches_calculator:228] setting number of microbatches to constant 2
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 megatron_parallel:549] > number of parameters on (tensor, pipeline) model parallel rank (0, 0): 857403648
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] Setting up DistributedDataParallel with config DistributedDataParallelConfig(grad_reduce_in_fp32=True, overlap_grad_reduce=True, overlap_param_gather=True, align_param_gather=False, use_distributed_optimizer=False, num_distributed_optimizer_instances=1, check_for_nan_in_grad=True, bucket_size=40000000, average_in_collective=False, fp8_param_gather=False)
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:323] Number of buckets for gradient all-reduce / reduce-scatter: 18
[...]
retraining/0 [default0]:[NeMo I 2025-01-03 05:50:17 utils:302] Setting up optimizer with config OptimizerConfig(optimizer='adam', lr=0.0003, min_lr=None, decoupled_lr=None, decoupled_min_lr=None, weight_decay=0.1, fp16=False, bf16=True, params_dtype=torch.bfloat16, loss_scale=None, initial_loss_scale=4294967296, min_loss_scale=1.0, loss_scale_window=1000, hysteresis=2, adam_beta1=0.123, adam_beta2=0.95, adam_eps=1e-05, sgd_momentum=0.9, use_distributed_optimizer=False, overlap_param_gather_with_optimizer_step=False, clip_grad=1.0, log_num_zeros_in_grad=False, barrier_with_L1_time=False, timers=None, config_logger_dir='')
retraining/0 [default0]:LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1]
retraining/0 [default0]:
retraining/0 [default0]: | Name | Type | Params | Mode
retraining/0 [default0]:----------------------------------------
retraining/0 [default0]:0 | module | DDP | 857 M | train
retraining/0 [default0]:----------------------------------------
retraining/0 [default0]:857 M Trainable params
retraining/0 [default0]:0 Non-trainable params
retraining/0 [default0]:857 M Total params
retraining/0 [default0]:3,429.615 Total estimated model params size (MB)
retraining/0 [default0]:394 Modules in train mode
retraining/0 [default0]:0 Modules in eval mode
retraining/0 [default0]:[rank0]: Traceback (most recent call last):
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/backends/nvidia/compiler.py", line 292, in make_cubin
retraining/0 [default0]:[rank0]: subprocess.run(cmd, shell=True, check=True)
retraining/0 [default0]:[rank0]: File "/usr/lib/python3.10/subprocess.py", line 526, in run
retraining/0 [default0]:[rank0]: raise CalledProcessError(retcode, process.args,
retraining/0 [default0]:[rank0]: subprocess.CalledProcessError: Command '/usr/local/lib/python3.10/dist-packages/triton/backends/nvidia/bin/ptxas -lineinfo -v --gpu-name=sm_75 /tmp/tmppa4c09n_.ptx -o /tmp/tmppa4c09n_.ptx.o 2> /tmp/tmp39of6etg.log' returned non-zero exit status 255.
retraining/0 [default0]:
retraining/0 [default0]:[rank0]: During handling of the above exception, another exception occurred:
retraining/0 [default0]:
retraining/0 [default0]:[rank0]: Traceback (most recent call last):
retraining/0 [default0]:[rank0]: File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
retraining/0 [default0]:[rank0]: return _run_code(code, main_globals, None,
retraining/0 [default0]:[rank0]: File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
retraining/0 [default0]:[rank0]: exec(code, run_globals)
retraining/0 [default0]:[rank0]: File "/opt/NeMo-Run/src/nemo_run/core/runners/fdl_runner.py", line 66, in <module>
retraining/0 [default0]:[rank0]: fdl_runner_app()
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/typer/main.py", line 338, in __call__
retraining/0 [default0]:[rank0]: raise e
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/typer/main.py", line 321, in __call__
retraining/0 [default0]:[rank0]: return get_command(self)(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1157, in __call__
retraining/0 [default0]:[rank0]: return self.main(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/typer/core.py", line 665, in main
retraining/0 [default0]:[rank0]: return _main(
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/typer/core.py", line 197, in _main
retraining/0 [default0]:[rank0]: rv = self.invoke(ctx)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1434, in invoke
retraining/0 [default0]:[rank0]: return ctx.invoke(self.callback, **ctx.params)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 783, in invoke
retraining/0 [default0]:[rank0]: return __callback(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/typer/main.py", line 703, in wrapper
retraining/0 [default0]:[rank0]: return callback(**use_params)
retraining/0 [default0]:[rank0]: File "/opt/NeMo-Run/src/nemo_run/core/runners/fdl_runner.py", line 62, in fdl_direct_run
retraining/0 [default0]:[rank0]: fdl_fn()
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/collections/llm/api.py", line 150, in pretrain
retraining/0 [default0]:[rank0]: return train(
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/collections/llm/api.py", line 107, in train
retraining/0 [default0]:[rank0]: trainer.fit(model, data)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/trainer/trainer.py", line 538, in fit
retraining/0 [default0]:[rank0]: call._call_and_handle_interrupt(
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/trainer/call.py", line 46, in _call_and_handle_interrupt
retraining/0 [default0]:[rank0]: return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/strategies/launchers/subprocess_script.py", line 105, in launch
retraining/0 [default0]:[rank0]: return function(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/trainer/trainer.py", line 574, in _fit_impl
retraining/0 [default0]:[rank0]: self._run(model, ckpt_path=ckpt_path)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/trainer/trainer.py", line 981, in _run
retraining/0 [default0]:[rank0]: results = self._run_stage()
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/trainer/trainer.py", line 1023, in _run_stage
retraining/0 [default0]:[rank0]: self._run_sanity_check()
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/trainer/trainer.py", line 1052, in _run_sanity_check
retraining/0 [default0]:[rank0]: val_loop.run()
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/loops/utilities.py", line 178, in _decorator
retraining/0 [default0]:[rank0]: return loop_run(self, *args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/loops/evaluation_loop.py", line 135, in run
retraining/0 [default0]:[rank0]: self._evaluation_step(batch, batch_idx, dataloader_idx, dataloader_iter)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/loops/evaluation_loop.py", line 396, in _evaluation_step
retraining/0 [default0]:[rank0]: output = call._call_strategy_hook(trainer, hook_name, *step_args)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning/pytorch/trainer/call.py", line 319, in _call_strategy_hook
retraining/0 [default0]:[rank0]: output = fn(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/lightning/pytorch/strategies/megatron_strategy.py", line 607, in validation_step
retraining/0 [default0]:[rank0]: out = self.model.validation_step(dataloader_iter, *args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/lightning/megatron_parallel.py", line 342, in validation_step
retraining/0 [default0]:[rank0]: return self._step(
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/lightning/megatron_parallel.py", line 429, in _step
retraining/0 [default0]:[rank0]: return self.forward(
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/lightning/megatron_parallel.py", line 279, in forward
retraining/0 [default0]:[rank0]: microbatch_outputs = step()
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/lightning/megatron_parallel.py", line 1149, in __call__
retraining/0 [default0]:[rank0]: return self.forward_backward_func(
retraining/0 [default0]:[rank0]: File "/opt/megatron-lm/megatron/core/pipeline_parallel/schedules.py", line 452, in forward_backward_no_pipelining
retraining/0 [default0]:[rank0]: output_tensor, num_tokens = forward_step(
retraining/0 [default0]:[rank0]: File "/opt/megatron-lm/megatron/core/pipeline_parallel/schedules.py", line 274, in forward_step
retraining/0 [default0]:[rank0]: output_tensor, loss_func = forward_step_func(data_iterator, model)
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/lightning/megatron_parallel.py", line 492, in wrapped_forward_step_func
retraining/0 [default0]:[rank0]: output_tensor = _forward_step(model, batch)
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/lightning/megatron_parallel.py", line 760, in wrapped
retraining/0 [default0]:[rank0]: return attr(*args)
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/collections/llm/gpt/model/base.py", line 384, in validation_step
retraining/0 [default0]:[rank0]: return self.forward_step(batch)
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/collections/llm/gpt/model/base.py", line 375, in forward_step
retraining/0 [default0]:[rank0]: return self.config.forward_step_fn(self, batch)
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/collections/llm/gpt/model/ssm.py", line 47, in ssm_forward_step
retraining/0 [default0]:[rank0]: return model(**forward_args)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
retraining/0 [default0]:[rank0]: return self._call_impl(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1747, in _call_impl
retraining/0 [default0]:[rank0]: return forward_call(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/NeMo/nemo/collections/llm/gpt/model/base.py", line 359, in forward
retraining/0 [default0]:[rank0]: output_tensor = self.module(
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
retraining/0 [default0]:[rank0]: return self._call_impl(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1747, in _call_impl
retraining/0 [default0]:[rank0]: return forward_call(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/megatron-lm/megatron/core/distributed/data_parallel_base.py", line 22, in forward
retraining/0 [default0]:[rank0]: return self.module(*inputs, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
retraining/0 [default0]:[rank0]: return self._call_impl(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1747, in _call_impl
retraining/0 [default0]:[rank0]: return forward_call(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/megatron-lm/megatron/core/transformer/module.py", line 178, in forward
retraining/0 [default0]:[rank0]: outputs = self.module(*inputs, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
retraining/0 [default0]:[rank0]: return self._call_impl(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1747, in _call_impl
retraining/0 [default0]:[rank0]: return forward_call(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/megatron-lm/megatron/core/models/mamba/mamba_model.py", line 206, in forward
retraining/0 [default0]:[rank0]: hidden_states = self.decoder(
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
retraining/0 [default0]:[rank0]: return self._call_impl(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1747, in _call_impl
retraining/0 [default0]:[rank0]: return forward_call(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/megatron-lm/megatron/core/ssm/mamba_block.py", line 262, in forward
retraining/0 [default0]:[rank0]: hidden_states = layer(
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
retraining/0 [default0]:[rank0]: return self._call_impl(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1747, in _call_impl
retraining/0 [default0]:[rank0]: return forward_call(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/megatron-lm/megatron/core/ssm/mamba_layer.py", line 105, in forward
retraining/0 [default0]:[rank0]: mixer_out_with_bias = self.mixer(hidden_states, inference_params=inference_params)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
retraining/0 [default0]:[rank0]: return self._call_impl(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1747, in _call_impl
retraining/0 [default0]:[rank0]: return forward_call(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/opt/megatron-lm/megatron/core/ssm/mamba_mixer.py", line 299, in forward
retraining/0 [default0]:[rank0]: y = mamba_split_conv1d_scan_combined(
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/triton/ssd_combined.py", line 930, in mamba_split_conv1d_scan_combined
retraining/0 [default0]:[rank0]: return MambaSplitConv1dScanCombinedFn.apply(zxbcdt, conv1d_weight, conv1d_bias, dt_bias, A, D, chunk_size, initial_states, seq_idx, dt_limit, return_final_states, activation, rmsnorm_weight, rmsnorm_eps, outproj_weight, outproj_bias, headdim, ngroups, norm_before_gate)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/autograd/function.py", line 575, in apply
retraining/0 [default0]:[rank0]: return super().apply(*args, **kwargs) # type: ignore[misc]
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/amp/autocast_mode.py", line 456, in decorate_fwd
retraining/0 [default0]:[rank0]: return fwd(*args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/triton/ssd_combined.py", line 789, in forward
retraining/0 [default0]:[rank0]: out, out_x, dt_out, dA_cumsum, states, final_states = _mamba_chunk_scan_combined_fwd(x, dt, A, B, C, chunk_size=chunk_size, D=D, z=z, dt_bias=dt_bias, initial_states=initial_states, seq_idx=seq_idx, dt_softplus=True, dt_limit=dt_limit)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/triton/ssd_combined.py", line 312, in _mamba_chunk_scan_combined_fwd
retraining/0 [default0]:[rank0]: dA_cumsum, dt = _chunk_cumsum_fwd(dt, A, chunk_size, dt_bias=dt_bias, dt_softplus=dt_softplus, dt_limit=dt_limit)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/triton/ssd_chunk_state.py", line 675, in _chunk_cumsum_fwd
retraining/0 [default0]:[rank0]: _chunk_cumsum_fwd_kernel[grid_chunk_cs](
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/runtime/jit.py", line 345, in <lambda>
retraining/0 [default0]:[rank0]: return lambda *args, **kwargs: self.run(grid=grid, warmup=False, *args, **kwargs)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/runtime/autotuner.py", line 156, in run
retraining/0 [default0]:[rank0]: timings = {config: self._bench(*args, config=config, **kwargs) for config in pruned_configs}
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/runtime/autotuner.py", line 156, in <dictcomp>
retraining/0 [default0]:[rank0]: timings = {config: self._bench(*args, config=config, **kwargs) for config in pruned_configs}
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/runtime/autotuner.py", line 133, in _bench
retraining/0 [default0]:[rank0]: return do_bench(kernel_call, warmup=self.num_warmups, rep=self.num_reps, quantiles=(0.5, 0.2, 0.8))
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/testing.py", line 106, in do_bench
retraining/0 [default0]:[rank0]: fn()
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/runtime/autotuner.py", line 114, in kernel_call
retraining/0 [default0]:[rank0]: self.fn.run(
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/runtime/jit.py", line 662, in run
retraining/0 [default0]:[rank0]: kernel = self.compile(
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/compiler/compiler.py", line 282, in compile
retraining/0 [default0]:[rank0]: next_module = compile_ir(module, metadata)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/backends/nvidia/compiler.py", line 320, in <lambda>
retraining/0 [default0]:[rank0]: stages["cubin"] = lambda src, metadata: self.make_cubin(src, metadata, options, self.capability)
retraining/0 [default0]:[rank0]: File "/usr/local/lib/python3.10/dist-packages/triton/backends/nvidia/compiler.py", line 297, in make_cubin
retraining/0 [default0]:[rank0]: raise RuntimeError(f'Internal Triton PTX codegen error: \n{log}')
retraining/0 [default0]:[rank0]: RuntimeError: Internal Triton PTX codegen error:
retraining/0 [default0]:[rank0]: ptxas /tmp/tmppa4c09n_.ptx, line 120; error : Feature '.bf16' requires .target sm_80 or higher
retraining/0 [default0]:[rank0]: ptxas /tmp/tmppa4c09n_.ptx, line 120; error : Feature 'cvt with .f32.bf16' requires .target sm_80 or higher
retraining/0 [default0]:[rank0]: ptxas fatal : Ptx assembly aborted due to errors
retraining/0 [default0]:
retraining/0 E0103 05:50:22.565000 17575 torch/distributed/elastic/multiprocessing/api.py:862] failed (exitcode: 1) local_rank: 0 (pid: 17601) of binary: /usr/bin/python
retraining/0 I0103 05:50:22.579000 17575 torch/distributed/elastic/multiprocessing/errors/__init__.py:368] ('local_rank %s FAILED with no error file. Decorate your entrypoint fn with @record for traceback info. See: https://pytorch.org/docs/stable/elastic/errors.html', 0)
retraining/0 Traceback (most recent call last):
retraining/0 File "/usr/local/bin/torchrun", line 33, in <module>
retraining/0 sys.exit(load_entry_point('torch==2.5.0a0+e000cf0ad9.nv24.10', 'console_scripts', 'torchrun')())
retraining/0 File "/usr/local/lib/python3.10/dist-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 355, in wrapper
retraining/0 return f(*args, **kwargs)
retraining/0 File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 919, in main
retraining/0 run(args)
retraining/0 File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 910, in run
retraining/0 elastic_launch(
retraining/0 File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 138, in __call__
retraining/0 return launch_agent(self._config, self._entrypoint, list(args))
retraining/0 File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 269, in launch_agent
retraining/0 raise ChildFailedError(
retraining/0 torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
retraining/0 ============================================================
retraining/0 nemo_run.core.runners.fdl_runner FAILED
retraining/0 ------------------------------------------------------------
retraining/0 Failures:
retraining/0 <NO_OTHER_FAILURES>
retraining/0 ------------------------------------------------------------
retraining/0 Root Cause (first observed failure):
retraining/0 [0]:
retraining/0 time : 2025-01-03_05:50:22
retraining/0 host : bh-Precision-5820-Tower-X-Series
retraining/0 rank : 0 (local_rank: 0)
retraining/0 exitcode : 1 (pid: 17601)
retraining/0 error_file: <N/A>
retraining/0 traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
retraining/0 ============================================================
[05:50:23] INFO Job mamba2_780m_pretraining-ht7tmrvqhgqrgd finished: FAILED launcher.py:162
# The experiment was run with the following tasks: ['mamba2_780m_pretraining']
# You can inspect and reconstruct this experiment at a later point in time using:
experiment = run.Experiment.from_id("mamba2_780m_pretraining_1735883405")
experiment.status() # Gets the overall status
experiment.logs("mamba2_780m_pretraining") # Gets the log for the provided task
experiment.cancel("mamba2_780m_pretraining") # Cancels the provided task if still running
```
Any tips would be great! Thank you in advance!
| {
"login": "tolry418",
"id": 20792661,
"node_id": "MDQ6VXNlcjIwNzkyNjYx",
"avatar_url": "https://avatars.githubusercontent.com/u/20792661?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tolry418",
"html_url": "https://github.com/tolry418",
"followers_url": "https://api.github.com/users/tolry418/followers",
"following_url": "https://api.github.com/users/tolry418/following{/other_user}",
"gists_url": "https://api.github.com/users/tolry418/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tolry418/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tolry418/subscriptions",
"organizations_url": "https://api.github.com/users/tolry418/orgs",
"repos_url": "https://api.github.com/users/tolry418/repos",
"events_url": "https://api.github.com/users/tolry418/events{/privacy}",
"received_events_url": "https://api.github.com/users/tolry418/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11742/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11742/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11741 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11741/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11741/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11741/events | https://github.com/NVIDIA/NeMo/issues/11741 | 2,766,819,379 | I_kwDOC_bI7s6k6lAz | 11,741 | Not able to run LLaVA-Next pretraining with NeMo 2.0 using container version nemo:24.12 | {
"login": "bernardhan33",
"id": 103850980,
"node_id": "U_kgDOBjCj5A",
"avatar_url": "https://avatars.githubusercontent.com/u/103850980?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bernardhan33",
"html_url": "https://github.com/bernardhan33",
"followers_url": "https://api.github.com/users/bernardhan33/followers",
"following_url": "https://api.github.com/users/bernardhan33/following{/other_user}",
"gists_url": "https://api.github.com/users/bernardhan33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bernardhan33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bernardhan33/subscriptions",
"organizations_url": "https://api.github.com/users/bernardhan33/orgs",
"repos_url": "https://api.github.com/users/bernardhan33/repos",
"events_url": "https://api.github.com/users/bernardhan33/events{/privacy}",
"received_events_url": "https://api.github.com/users/bernardhan33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"At step 7 when we got the error\n\n```\nAttributeError: 'MockDataModule' object has no attribute 'micro_batch_size'\n```\n\ncould this be a similar issue to this [stackoverflow question](https://stackoverflow.com/questions/1250103/attributeerror-module-object-has-no-attribute), where some dependency imports are messed up?",
"Hello, Sorry for the inconvenience. This particular PR [11424](https://github.com/NVIDIA/NeMo/pull/11424/) was missed by our cherrypicking process into release branch. While we are actively working on fixing that, could you try with ToT [main](https://github.com/NVIDIA/NeMo/tree/main). Thank you!",
"https://github.com/NVIDIA/NeMo/pull/11783\n\nWe would be releasing a new container with the fixes soon. "
] | 2025-01-03T00:22:56 | 2025-01-07T23:58:25 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I would love to run LLaVA-Next pretraining with NeMo 2.0 following the [documentation](https://docs.nvidia.com/nemo-framework/user-guide/latest/vlms/llavanext.html) but failed with various errors with either nemo:24.12, nemo:24.09 or nemo:dev.
**Steps/Code to reproduce bug**
1. Pull the latest NeMo container version:
```bash
docker pull nvcr.io/nvidia/nemo:24.12
```
2. Start the docker container:
```bash
docker run --gpus all -it --rm --shm-size=32g -p 8888:8888 -p 6006:6006 --ulimit memlock=-1 --ulimit stack=67108864 nvcr.io/nvidia/nemo:24.12
```
3. Within the docker container, create the Python code `pretrain.py` and fill with the [sample code from the documentation](https://docs.nvidia.com/nemo-framework/user-guide/latest/vlms/llavanext.html):
```python
from nemo.collections import vlm
finetune = vlm.llava_next_7b.pretrain_recipe(
name="llava_next_7b_pretrain",
dir=f"/NeMo/new-ckpts",
num_nodes=1,
num_gpus_per_node=8,
language_model_from_pretrained='/NeMo/neva/checkpoints/llama-3-8b-instruct.nemo', # This is the directory where I transformed the Llama3-8b-Instruct checkpoint to .nemo format
# Can be None or change based on local checkpoint path
)
import nemo_run as run
run.run(finetune, executor=run.LocalExecutor())
```
4. Run the code
```bash
python3 pretrain.py
```
5. Got error
```
TypeError: pretrain_recipe() got an unexpected keyword argument 'language_model_from_pretrained'
```
6. Confirmed from the code path `/opt/NeMo/nemo/collections/vlm/recipes/llava_next_7b.py` that the code does not support `language_model_from_pretrained`.
7. Removed the line that specified `language_model_from_pretrained` and tried again. Got error
```
AttributeError: 'MockDataModule' object has no attribute 'micro_batch_size'
```
8. Also tried container versions `nemo:dev` and `nemo:24.09`. Failed with errors.
```
AttributeError: module 'nemo.collections.vlm' has no attribute 'llava_next_7b'
```
Confirmed from code path that the recipes do not exist yet in those versions.
**Expected behavior**
I should be able to follow the public documentation to get the LLaVA-NEXT pretraining run just fine.
**Environment overview (please complete the following information)**
- Environment location: GCP.
- Method of NeMo install: Docker.
- If method of install is [Docker], provide `docker pull` & `docker run` commands used: see above.
**Environment details**
N/A.
**Additional context**
N/A. | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11741/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11741/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11740 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11740/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11740/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11740/events | https://github.com/NVIDIA/NeMo/pull/11740 | 2,766,819,204 | PR_kwDOC_bI7s6Gny00 | 11,740 | Bump mcore | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.gemma\nnemo/collections/llm/gpt/model/gemma.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:79:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:83:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:87:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:107:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:127:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:140:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:146:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:178:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:197:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:214:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.recipes.gemma_2b\nnemo/collections/llm/recipes/gemma_2b.py:14:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.llm.recipes.gemma_7b\nnemo/collections/llm/recipes/gemma_7b.py:14:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_base_model\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:104:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:112:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:254:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:272:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:347:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:611:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:666:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:838:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:976:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:995:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1112:0: C0301: Line too long (195/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1169:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1218:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1301:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:331:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:462:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:467:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:704:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:756:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:937:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1041:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1311:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1315:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_retro_model\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:36:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:143:0: C0301: Line too long (191/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:305:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:336:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:387:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:444:0: C0301: Line too long (206/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:454:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:461:0: C0301: Line too long (210/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:465:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:15:0: W0611: Unused import itertools (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:18:0: W0611: Unused import queue (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:20:0: W0611: Unused import warnings (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:21:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Iterator imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused List imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Union imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:26:0: W0611: Unused CPUAccelerator imported from lightning.pytorch.accelerators (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:38:0: W0611: Unused MegatronBaseModel imported from nemo.collections.nlp.models.language_modeling.megatron_base_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:40:0: W0611: Unused build_model imported from nemo.collections.nlp.modules.common.megatron.build_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:41:0: W0611: Unused Float16Module imported from nemo.collections.nlp.modules.common.megatron.module (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_all_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_ltor_masks_and_position_ids imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:49:0: W0611: Unused TextGenerationStrategy imported from nemo.collections.nlp.modules.common.text_generation_strategy (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_length_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_sampling_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused megatron_gpt_generate imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused LengthParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused OutputType imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused SamplingParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused TextGeneration imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:63:0: W0611: Unused utils_funcs imported from nemo.collections.nlp.parts (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused get_last_rank imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:65:0: W0611: Unused Exportable imported from nemo.core.classes (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:66:0: W0611: Unused PretrainedModelInfo imported from nemo.core.classes.common (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused ChannelType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused NeuralType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:72:4: W0611: Unused InferenceParams imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:81:4: W0611: Unused TransformerConfig imported from megatron.core.transformer.transformer_config (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:82:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:82:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module scripts.checkpoint_converters.convert_bert_hf_to_nemo\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:65:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:79:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.41/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.gemma\nnemo/collections/llm/gpt/model/gemma.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:79:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:83:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:87:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:107:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:127:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:140:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:146:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:178:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/gemma.py:197:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/gemma.py:214:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.recipes.gemma_2b\nnemo/collections/llm/recipes/gemma_2b.py:14:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.llm.recipes.gemma_7b\nnemo/collections/llm/recipes/gemma_7b.py:14:0: W0611: Unused import os (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_base_model\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:104:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:112:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:254:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:272:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:347:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:611:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:666:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:838:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:976:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:995:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1112:0: C0301: Line too long (195/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1169:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1218:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1301:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:331:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:462:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:467:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:704:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:756:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:937:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1041:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1311:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1315:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_retro_model\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:36:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:143:0: C0301: Line too long (191/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:305:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:336:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:387:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:444:0: C0301: Line too long (206/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:454:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:461:0: C0301: Line too long (210/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:465:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:15:0: W0611: Unused import itertools (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:18:0: W0611: Unused import queue (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:20:0: W0611: Unused import warnings (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:21:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Iterator imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused List imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:23:0: W0611: Unused Union imported from typing (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:26:0: W0611: Unused CPUAccelerator imported from lightning.pytorch.accelerators (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:38:0: W0611: Unused MegatronBaseModel imported from nemo.collections.nlp.models.language_modeling.megatron_base_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:40:0: W0611: Unused build_model imported from nemo.collections.nlp.modules.common.megatron.build_model (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:41:0: W0611: Unused Float16Module imported from nemo.collections.nlp.modules.common.megatron.module (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_all_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_ltor_masks_and_position_ids imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:42:0: W0611: Unused get_params_for_weight_decay_optimization imported from nemo.collections.nlp.modules.common.megatron.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:49:0: W0611: Unused TextGenerationStrategy imported from nemo.collections.nlp.modules.common.text_generation_strategy (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_length_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused get_default_sampling_params imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:50:0: W0611: Unused megatron_gpt_generate imported from nemo.collections.nlp.modules.common.text_generation_utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused LengthParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused OutputType imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused SamplingParam imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:57:0: W0611: Unused TextGeneration imported from nemo.collections.nlp.modules.common.transformer.text_generation (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:63:0: W0611: Unused utils_funcs imported from nemo.collections.nlp.parts (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:64:0: W0611: Unused get_last_rank imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:65:0: W0611: Unused Exportable imported from nemo.core.classes (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:66:0: W0611: Unused PretrainedModelInfo imported from nemo.core.classes.common (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused ChannelType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:67:0: W0611: Unused NeuralType imported from nemo.core.neural_types (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:72:4: W0611: Unused InferenceParams imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:81:4: W0611: Unused TransformerConfig imported from megatron.core.transformer.transformer_config (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:82:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_retro_model.py:82:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module scripts.checkpoint_converters.convert_bert_hf_to_nemo\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:65:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:56:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_bert_hf_to_nemo.py:79:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.41/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12658525787) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-03T00:22:38 | 2025-01-07T23:34:36 | 2025-01-07T23:34:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11740",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11740",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11740.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11740.patch",
"merged_at": "2025-01-07T23:34:34"
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=076972e37420b5325c5fe06e7131be7d96f05b53`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11740/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11740/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11739 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11739/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11739/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11739/events | https://github.com/NVIDIA/NeMo/pull/11739 | 2,766,398,108 | PR_kwDOC_bI7s6GmXQJ | 11,739 | Conversion NeMo and HF checkpoint script for T5 | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @huvunvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12592997561) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @huvunvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12603813340) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:395:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:396:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:397:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:402:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:623:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:624:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:625:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:630:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/t5/model/t5.py:42:4: W0611: Unused import transformer_engine (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.85/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @huvunvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12616117062) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-02T17:37:06 | 2025-01-05T21:13:14 | 2025-01-05T04:48:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11739",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11739",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11739.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11739.patch",
"merged_at": "2025-01-05T04:48:39"
} | # What does this PR do ?
Scripts for converting T5 HF checkpoints from and to NeMo 2.0 checkpoints.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11739/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11739/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11738 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11738/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11738/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11738/events | https://github.com/NVIDIA/NeMo/pull/11738 | 2,766,374,773 | PR_kwDOC_bI7s6GmSLT | 11,738 | TPS-free 2D bucket estimation and filtering | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.data.lhotse.sampling\nnemo/collections/common/data/lhotse/sampling.py:15:0: W0611: Unused import bisect (unused-import)\nnemo/collections/common/data/lhotse/sampling.py:16:0: W0611: Unused import logging (unused-import)\nnemo/collections/common/data/lhotse/sampling.py:18:0: W0611: Unused bisect_right imported from bisect (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.87/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-02T17:17:28 | 2025-01-17T01:29:20 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11738",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11738",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11738.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11738.patch",
"merged_at": null
} | # What does this PR do ?
Improves the UX of estimating 2D buckets and preparing the training configuration. Key changes:
* 2D bucket estimation auto-finds the right max-token-per-second setting for each bucket separately instead of assuming a global constant max-TPS. The per-bucket max-TPS is determined as 4*stddev(bucket_tps).
* Training with 2D bucketing works without setting the max_tps filter.
* The data that doesn't fit the 2D buckets (either 1st or 2nd dim) is filtered out automatically during sampling.
* strict mode (default): first allocate the duration bucket, and then try to allocate to max_tokens sub-bucket. If an example doesn't fit, discard it.
* lenient mode (`model.train_ds.bucketing_2d_strict_mode=False`): find any bucket that will fit a given example. That means token-per-second outliers are pushed to buckets with higher durations increasing the padding but reducing the amount of discarded data. Use at your own risk - for the setups I tested it so far with, it may cause training instability (likely due to inclusion of lower-quality data).
* Fixes some issues with `estimate_duration_bins_2d.py` script.
* For data with complex TPS distributions: max-TPS can be defined as a list with the same length as the list of buckets for fine-grained control. A best-guess setting is suggested by `estimate_duration_bins_2d.py`.
* Renamed `tarred_random_access` to `skip_missing_manifest_entries` and adjusted the logic to reduce CPU memory usage and accelerate loading time.
**Collection**: ASR, TTS, SpeechLLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11738/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11738/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11737 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11737/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11737/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11737/events | https://github.com/NVIDIA/NeMo/pull/11737 | 2,766,307,577 | PR_kwDOC_bI7s6GmDpp | 11,737 | Add BERT Embedding Models | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12616668182) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-02T16:26:45 | 2025-01-06T21:28:51 | 2025-01-06T21:28:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11737",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11737",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11737.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11737.patch",
"merged_at": "2025-01-06T21:28:50"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11737/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11737/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11736 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11736/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11736/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11736/events | https://github.com/NVIDIA/NeMo/pull/11736 | 2,765,680,749 | PR_kwDOC_bI7s6Gj9W4 | 11,736 | llm performance scripts | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"[🤖]: Hi @malay-nagda 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12752166721) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.modules.common.tokenizer_utils\nnemo/collections/nlp/modules/common/tokenizer_utils.py:73:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:131:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:233:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/modules/common/tokenizer_utils.py:42:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.50/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2025-01-02T09:14:15 | 2025-01-18T16:14:33 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11736",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11736",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11736.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11736.patch",
"merged_at": null
} | # What does this PR do ?
Adds scripts for llm pre-training and fine-tuning, optimized for performance
**Collection**: [llm]
# Changelog
Added arg params for HuggingFace Token, NEMO_HOME env var and fine-tuning scheme
```
-hf/--hf_token # needed for downloading checkpoints and tokenizers from HF
-nh/--nemo_home # needed for accessing locally stored checkpoints and tokenizers
-f/--finetuning # 'lora' or 'sft'. default is 'lora'
```
# Usage
```python
python3 scripts/llm/performance/pretrain_llama3_8b.py -a <slurm_account> -p <slurm_partition>
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11736/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11736/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11735 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11735/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11735/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11735/events | https://github.com/NVIDIA/NeMo/pull/11735 | 2,765,557,088 | PR_kwDOC_bI7s6GjjFd | 11,735 | add token_perf_callback | {
"login": "DrownFish19",
"id": 15797489,
"node_id": "MDQ6VXNlcjE1Nzk3NDg5",
"avatar_url": "https://avatars.githubusercontent.com/u/15797489?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/DrownFish19",
"html_url": "https://github.com/DrownFish19",
"followers_url": "https://api.github.com/users/DrownFish19/followers",
"following_url": "https://api.github.com/users/DrownFish19/following{/other_user}",
"gists_url": "https://api.github.com/users/DrownFish19/gists{/gist_id}",
"starred_url": "https://api.github.com/users/DrownFish19/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DrownFish19/subscriptions",
"organizations_url": "https://api.github.com/users/DrownFish19/orgs",
"repos_url": "https://api.github.com/users/DrownFish19/repos",
"events_url": "https://api.github.com/users/DrownFish19/events{/privacy}",
"received_events_url": "https://api.github.com/users/DrownFish19/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.utils.exp_manager\nnemo/utils/exp_manager.py:445:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:470:0: C0301: Line too long (124/119) (line-too-long)\nnemo/utils/exp_manager.py:474:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:479:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:493:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:500:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:501:0: C0301: Line too long (126/119) (line-too-long)\nnemo/utils/exp_manager.py:503:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:505:0: C0301: Line too long (139/119) (line-too-long)\nnemo/utils/exp_manager.py:515:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:516:0: C0301: Line too long (128/119) (line-too-long)\nnemo/utils/exp_manager.py:517:0: C0301: Line too long (132/119) (line-too-long)\nnemo/utils/exp_manager.py:518:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:606:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:698:0: C0301: Line too long (208/119) (line-too-long)\nnemo/utils/exp_manager.py:699:0: C0301: Line too long (230/119) (line-too-long)\nnemo/utils/exp_manager.py:701:0: C0301: Line too long (178/119) (line-too-long)\nnemo/utils/exp_manager.py:738:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:873:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:881:0: C0301: Line too long (156/119) (line-too-long)\nnemo/utils/exp_manager.py:928:0: C0301: Line too long (141/119) (line-too-long)\nnemo/utils/exp_manager.py:936:0: C0301: Line too long (152/119) (line-too-long)\nnemo/utils/exp_manager.py:1206:0: C0301: Line too long (142/119) (line-too-long)\nnemo/utils/exp_manager.py:1230:0: C0301: Line too long (154/119) (line-too-long)\nnemo/utils/exp_manager.py:1296:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:1315:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:1341:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:99:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:114:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:140:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:149:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:158:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:169:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:284:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:290:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:293:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:296:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:302:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:343:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:346:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:349:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:352:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:393:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:396:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1222:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1323:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1345:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1361:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.21/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2025-01-02T07:21:45 | 2025-01-17T01:55:51 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11735",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11735",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11735.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11735.patch",
"merged_at": null
} | # What does this PR do ?
Add performence in token-level in `nemo/utils/exp_manager.py`, in which the manager will log `effective_tokens_per_second_per_device` and `total_tokens_per_second_per_device` for each training step.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
To open the performance output, setting `log_step_token_performance` in `config.yaml`. Note that the output maybe overhead with lightning logger, we suggest using `mlflow` to record the metrics.
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11735/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11735/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11734 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11734/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11734/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11734/events | https://github.com/NVIDIA/NeMo/issues/11734 | 2,765,396,397 | I_kwDOC_bI7s6k1Jmt | 11,734 | NeMo/examples/slu/speech_intent_slot 0 files were filtered totalling 0.00 hours | {
"login": "yangdongdong2000",
"id": 156107697,
"node_id": "U_kgDOCU4DsQ",
"avatar_url": "https://avatars.githubusercontent.com/u/156107697?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yangdongdong2000",
"html_url": "https://github.com/yangdongdong2000",
"followers_url": "https://api.github.com/users/yangdongdong2000/followers",
"following_url": "https://api.github.com/users/yangdongdong2000/following{/other_user}",
"gists_url": "https://api.github.com/users/yangdongdong2000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yangdongdong2000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yangdongdong2000/subscriptions",
"organizations_url": "https://api.github.com/users/yangdongdong2000/orgs",
"repos_url": "https://api.github.com/users/yangdongdong2000/repos",
"events_url": "https://api.github.com/users/yangdongdong2000/events{/privacy}",
"received_events_url": "https://api.github.com/users/yangdongdong2000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [] | 2025-01-02T03:22:55 | 2025-01-02T03:22:55 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am trying to train a model on the SLURP dataset using the NeMo framework by following the steps outlined in the `README.md` file under `NeMo/examples/slu/speech_intent_slot`.
- **Data Preparation** and **Building Tokenizers** completed successfully.
- The `.json` files (ending with `slu.json`) were correctly generated under the `slurp_data` folder.
However, when I run the training script, I encounter the following error:
```
self._train_dl = self._setup_dataloader_from_config(config=train_data_config)
File "/home/ddyang/miniconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/asr/models/slu_models.py", line 420, in _setup_dataloader_from_config
return torch.utils.data.DataLoader(
File "/home/ddyang/miniconda3/envs/nemo/lib/python3.10/site-packages/torch/utils/data/dataloader.py", line 350, in __init__
sampler = RandomSampler(dataset, generator=generator) # type: ignore[arg-type]
File "/home/ddyang/miniconda3/envs/nemo/lib/python3.10/site-packages/torch/utils/data/sampler.py", line 143, in __init__
raise ValueError(f"num_samples should be a positive integer value, but got num_samples={self.num_samples}")
ValueError: num_samples should be a positive integer value, but got num_samples=0
```
It seems like the data was not read correctly. Could you please guide me on how to resolve this issue?
--- | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11734/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11734/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11733 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11733/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11733/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11733/events | https://github.com/NVIDIA/NeMo/pull/11733 | 2,765,327,028 | PR_kwDOC_bI7s6GizG4 | 11,733 | chore(beep boop 🤖): Bump `MCORE_TAG=076972e...` (2025-01-02) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-02T00:22:33 | 2025-01-03T12:54:07 | 2025-01-03T12:54:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11733",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11733",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11733.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11733.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=076972e37420b5325c5fe06e7131be7d96f05b53`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11733/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11733/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11732 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11732/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11732/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11732/events | https://github.com/NVIDIA/NeMo/pull/11732 | 2,764,744,353 | PR_kwDOC_bI7s6Gg5fm | 11,732 | chore(beep boop 🤖): Bump `MCORE_TAG=076972e...` (2025-01-01) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2025-01-01T00:25:18 | 2025-01-03T12:54:10 | 2025-01-03T12:54:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11732",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11732",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11732.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11732.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=076972e37420b5325c5fe06e7131be7d96f05b53`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11732/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11732/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11731 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11731/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11731/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11731/events | https://github.com/NVIDIA/NeMo/pull/11731 | 2,764,743,890 | PR_kwDOC_bI7s6Gg5Zr | 11,731 | Add server ready check before starting evaluation | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:441:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/llm/api.py:571:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:15:0: W0611: Unused import os (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.96/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @athitten 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12643081020) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2025-01-01T00:24:21 | 2025-01-07T19:20:22 | 2025-01-07T19:20:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11731",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11731",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11731.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11731.patch",
"merged_at": "2025-01-07T19:20:20"
} | # What does this PR do ?
Adds method `wait_for_server_ready` to `evaluation/base.py` that waits for the PyTriton server to be ready and the specific model (with name defined in `model_name` arg) to be loaded and ready before starting evaluation.
Adds bool [generation_logits_available](https://github.com/NVIDIA/NeMo/pull/11731/files#diff-3a3bd49eed8a038989253f6f2e0a01cf494d1de391863d4ab2377a1f7d4cf832R1152) to `triton_infer_fn` since check via `if "output_generation_logits" in inputs` is not robust in cases where `output_generation_logits` is popped from inputs dict in the previous line.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11731/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11731/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11730 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11730/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11730/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11730/events | https://github.com/NVIDIA/NeMo/pull/11730 | 2,764,583,913 | PR_kwDOC_bI7s6GgYyQ | 11,730 | WIP support for CP in NeVA | {
"login": "parthmannan",
"id": 38387286,
"node_id": "MDQ6VXNlcjM4Mzg3Mjg2",
"avatar_url": "https://avatars.githubusercontent.com/u/38387286?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/parthmannan",
"html_url": "https://github.com/parthmannan",
"followers_url": "https://api.github.com/users/parthmannan/followers",
"following_url": "https://api.github.com/users/parthmannan/following{/other_user}",
"gists_url": "https://api.github.com/users/parthmannan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/parthmannan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/parthmannan/subscriptions",
"organizations_url": "https://api.github.com/users/parthmannan/orgs",
"repos_url": "https://api.github.com/users/parthmannan/repos",
"events_url": "https://api.github.com/users/parthmannan/events{/privacy}",
"received_events_url": "https://api.github.com/users/parthmannan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.neva.data.mock\nnemo/collections/vlm/neva/data/mock.py:152:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/neva/data/mock.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/mock.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:102:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.model.base\nnemo/collections/vlm/neva/model/base.py:529:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:532:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:557:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:93:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:144:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:160:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:181:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:260:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:308:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:339:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:376:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:393:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:422:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:432:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:977:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:994:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:998:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1030:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1033:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1036:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1040:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1046:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:1053:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:48:0: W0611: Unused get_batch_on_this_context_parallel_rank imported from nemo.collections.llm.gpt.model.base (unused-import)\nnemo/collections/vlm/neva/model/base.py:48:0: W0611: Unused get_packed_seq_params imported from nemo.collections.llm.gpt.model.base (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.42/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-31T18:03:49 | 2025-01-14T19:54:38 | 2025-01-14T19:54:38 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11730",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11730",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11730.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11730.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11730/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11730/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11729 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11729/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11729/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11729/events | https://github.com/NVIDIA/NeMo/pull/11729 | 2,764,542,329 | PR_kwDOC_bI7s6GgQMk | 11,729 | Update model_checkpoint.py to fix issue with loading checkpointing | {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.model_checkpoint\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:635:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:111:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:258:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:262:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:275:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:22:0: W0611: Unused import lightning.pytorch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.77/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-31T16:56:12 | 2025-01-17T01:55:53 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11729",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11729",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11729.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11729.patch",
"merged_at": null
} | Relvant to this MR
https://github.com/NVIDIA/NeMo/pull/9868/files
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11729/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11729/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11728 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11728/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11728/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11728/events | https://github.com/NVIDIA/NeMo/pull/11728 | 2,764,389,744 | PR_kwDOC_bI7s6Gfvoq | 11,728 | Run Flake8 for nemo.export module | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.multimodal.build\nnemo/export/multimodal/build.py:39:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:73:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:89:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:214:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:241:4: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/multimodal/build.py:242:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:250:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:263:4: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/multimodal/build.py:270:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:359:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:377:4: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/multimodal/build.py:384:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:436:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:469:4: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/multimodal/build.py:477:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:506:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/multimodal/build.py:521:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.sentencepiece_tokenizer\nnemo/export/sentencepiece_tokenizer.py:236:0: C0301: Line too long (137/119) (line-too-long)\nnemo/export/sentencepiece_tokenizer.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:138:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:144:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:186:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:194:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:202:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:217:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:224:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:231:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:243:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:253:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:256:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:266:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.converter.model_converter\nnemo/export/trt_llm/converter/model_converter.py:35:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_converter.py:48:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_converter.py:108:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.converter.model_to_trt_llm_ckpt\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:55:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:101:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:130:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:291:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:298:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:305:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:506:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:162:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:192:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:203:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:207:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:232:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:243:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:264:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:359:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:477:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:564:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:568:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:579:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:591:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:631:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:668:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:681:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:25:0: W0611: Unused import tensorstore (unused-import)\n************* Module nemo.export.trt_llm.tensorrt_llm_build\nnemo/export/trt_llm/tensorrt_llm_build.py:31:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.tensorrt_llm_run\nnemo/export/trt_llm/tensorrt_llm_run.py:501:0: C0301: Line too long (124/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:505:0: C0301: Line too long (135/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:509:0: C0301: Line too long (123/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:552:0: C0301: Line too long (181/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:836:0: C0301: Line too long (153/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:519:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:528:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:586:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.utils.lora_converter\nnemo/export/utils/lora_converter.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/utils/lora_converter.py:43:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/utils/lora_converter.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/utils/lora_converter.py:160:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.vllm.model_converters\nnemo/export/vllm/model_converters.py:59:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/vllm/model_converters.py:122:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/vllm/model_converters.py:191:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/vllm/model_converters.py:268:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.export.vllm_exporter\nnemo/export/vllm_exporter.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/vllm_exporter.py:429:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.68/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-31T13:39:58 | 2025-01-13T15:23:18 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11728",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11728",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11728.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11728.patch",
"merged_at": null
} | # What does this PR do ?
Run & apply [Flake8](https://flake8.pycqa.org/en/latest/) suggestions for nemo.export including (most common):
* [F541: f-string without any placeholders](https://docs.astral.sh/ruff/rules/f-string-missing-placeholders)
* [F841 local variable 'x' is assigned to but never used](https://www.flake8rules.com/rules/F841.html)
* [F401 'x' imported but unused](https://www.flake8rules.com/rules/F401.html)
* [E741 ambiguous variable name 'l']( https://www.flake8rules.com/rules/E741.html)
* [F821 undefined name 'x'](https://docs.astral.sh/ruff/rules/undefined-name)
* [E266 too many leading '#' for block comment](https://www.flake8rules.com/rules/E266.html)
**Collection**: NLP / LLM
# Usage
Flake8 command to diagnose issues (skipping selected ones):
```bash
flake8 nemo/export/ --ignore E203,W503,E501 --per-file-ignores="__init__.py:F401"
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11728/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11728/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11727 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11727/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11727/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11727/events | https://github.com/NVIDIA/NeMo/pull/11727 | 2,764,239,381 | PR_kwDOC_bI7s6GfO8_ | 11,727 | Cherry pick `Bug fix minor bug in TRT-LLM deployment (11714)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12667707388) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-31T10:51:14 | 2025-01-08T15:48:54 | 2025-01-08T15:48:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11727",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11727",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11727.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11727.patch",
"merged_at": "2025-01-08T15:48:53"
} | beep boop [🤖]: Hi @oyilmaz-nvidia 👋,
we've cherry picked #11714 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11727/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11727/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11726 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11726/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11726/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11726/events | https://github.com/NVIDIA/NeMo/pull/11726 | 2,763,826,532 | PR_kwDOC_bI7s6Gd23q | 11,726 | chore(beep boop 🤖): Bump `MCORE_TAG=076972e...` (2024-12-31) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-31T00:22:34 | 2025-01-03T12:54:12 | 2025-01-03T12:54:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11726",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11726",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11726.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11726.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=076972e37420b5325c5fe06e7131be7d96f05b53`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11726/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11726/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11725 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11725/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11725/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11725/events | https://github.com/NVIDIA/NeMo/pull/11725 | 2,763,730,818 | PR_kwDOC_bI7s6Gdimx | 11,725 | Fix baseline recipes | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.base\nnemo/collections/llm/gpt/model/base.py:239:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/llm/gpt/model/base.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:94:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:126:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:142:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:152:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:162:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:187:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:265:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:277:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:289:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:301:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:313:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:325:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:339:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:357:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:384:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:387:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:390:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:394:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:399:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:420:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:427:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:434:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:462:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:43:4: W0611: Unused import fused_weight_gradient_mlp_cuda (unused-import)\n************* Module nemo.collections.llm.gpt.model.nemotron\nnemo/collections/llm/gpt/model/nemotron.py:38:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:68:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:80:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:92:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:104:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:116:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:127:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:139:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:184:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:217:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:235:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:253:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:257:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.09/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-30T21:49:07 | 2024-12-31T22:22:34 | 2024-12-31T22:22:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11725",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11725",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11725.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11725.patch",
"merged_at": "2024-12-31T22:22:33"
} | # What does this PR do ?
Fix the model configs for performance
# Changelog
- Enable RoPE fusion in the nemotron baseline config
- Enable `sequence_parallel` in nemotron4 15B config that uses TP>1
- Add `tp_only_amax_red=False` in GPT config
# Usage
n/a
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11725/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11725/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11724 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11724/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11724/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11724/events | https://github.com/NVIDIA/NeMo/issues/11724 | 2,763,527,205 | I_kwDOC_bI7s6kuBQl | 11,724 | NeMo intermittent start-up failure with OMPI temp directory error on k8s | {
"login": "chajath",
"id": 1551907,
"node_id": "MDQ6VXNlcjE1NTE5MDc=",
"avatar_url": "https://avatars.githubusercontent.com/u/1551907?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chajath",
"html_url": "https://github.com/chajath",
"followers_url": "https://api.github.com/users/chajath/followers",
"following_url": "https://api.github.com/users/chajath/following{/other_user}",
"gists_url": "https://api.github.com/users/chajath/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chajath/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chajath/subscriptions",
"organizations_url": "https://api.github.com/users/chajath/orgs",
"repos_url": "https://api.github.com/users/chajath/repos",
"events_url": "https://api.github.com/users/chajath/events{/privacy}",
"received_events_url": "https://api.github.com/users/chajath/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [] | 2024-12-30T17:57:27 | 2024-12-30T17:57:27 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
NeMo intermittent start-up failure with OMPI temp directory error.
**Steps/Code to reproduce bug**
* Launch multinode NeMo training job on k8s with privilege mode without HostPID
* Observe that in about 3~4% of the time, NeMo job fails to launch with error:
```
ERROR 2024-11-13T14:41:01.114829205Z [resource.labels.containerName: megatron] --------------------------------------------------------------------------
ERROR 2024-11-13T14:41:01.114859401Z [resource.labels.containerName: megatron] A call to mkdir was unable to create the desired directory:
ERROR 2024-11-13T14:41:01.114863131Z [resource.labels.containerName: megatron] {}
ERROR 2024-11-13T14:41:01.114865257Z [resource.labels.containerName: megatron] Directory: /tmp/ompi.machine-name-redacted.0/pid.2284793
ERROR 2024-11-13T14:41:01.114867380Z [resource.labels.containerName: megatron] Error: No such file or directory
ERROR 2024-11-13T14:41:01.114871655Z [resource.labels.containerName: megatron] Please check to ensure you have adequate permissions to perform
ERROR 2024-11-13T14:41:01.114874427Z [resource.labels.containerName: megatron] the desired operation.
ERROR 2024-11-13T14:41:01.114876515Z [resource.labels.containerName: megatron] --------------------------------------------------------------------------
ERROR 2024-11-13T14:41:01.114878903Z [resource.labels.containerName: megatron] [machine-name-redacted:2284793] [[47352,0],0] ORTE_ERROR_LOG: Error in file util/session_dir.c at line 107
ERROR 2024-11-13T14:41:01.114895028Z [resource.labels.containerName: megatron] [machine-name-redacted:2284793] [[47352,0],0] ORTE_ERROR_LOG: Error in file util/session_dir.c at line **346**
```
**Expected behavior**
NeMo training job to launch without hiccup
**Environment overview (please complete the following information)**
- Environment location: GKE
- Method of NeMo install: Used pre-built docker image from `nvcr.io/nvidia/nemo:24.07`
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11724/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11724/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11723 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11723/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11723/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11723/events | https://github.com/NVIDIA/NeMo/pull/11723 | 2,763,032,523 | PR_kwDOC_bI7s6GbMOo | 11,723 | Michalm/patch mcore comm overlap | {
"login": "mmarcinkiewicz",
"id": 43240942,
"node_id": "MDQ6VXNlcjQzMjQwOTQy",
"avatar_url": "https://avatars.githubusercontent.com/u/43240942?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mmarcinkiewicz",
"html_url": "https://github.com/mmarcinkiewicz",
"followers_url": "https://api.github.com/users/mmarcinkiewicz/followers",
"following_url": "https://api.github.com/users/mmarcinkiewicz/following{/other_user}",
"gists_url": "https://api.github.com/users/mmarcinkiewicz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mmarcinkiewicz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mmarcinkiewicz/subscriptions",
"organizations_url": "https://api.github.com/users/mmarcinkiewicz/orgs",
"repos_url": "https://api.github.com/users/mmarcinkiewicz/repos",
"events_url": "https://api.github.com/users/mmarcinkiewicz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mmarcinkiewicz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.megatron_comm_overlap\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:81:0: C0301: Line too long (121/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:245:0: C0301: Line too long (124/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:212:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:284:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:288:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.86/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-30T11:00:44 | 2025-01-20T13:07:06 | 2025-01-20T13:07:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11723",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11723",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11723.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11723.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Fixing two issues introduced in https://github.com/NVIDIA/NeMo/commit/fe4f39a4025fac98590182ae639cbce5055fa71d
- Adding a check of `tp_comm_overlap_cfg` before cast to dict
- Adding `use_te_rng_tracker` to docstrings
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mmarcinkiewicz",
"id": 43240942,
"node_id": "MDQ6VXNlcjQzMjQwOTQy",
"avatar_url": "https://avatars.githubusercontent.com/u/43240942?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mmarcinkiewicz",
"html_url": "https://github.com/mmarcinkiewicz",
"followers_url": "https://api.github.com/users/mmarcinkiewicz/followers",
"following_url": "https://api.github.com/users/mmarcinkiewicz/following{/other_user}",
"gists_url": "https://api.github.com/users/mmarcinkiewicz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mmarcinkiewicz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mmarcinkiewicz/subscriptions",
"organizations_url": "https://api.github.com/users/mmarcinkiewicz/orgs",
"repos_url": "https://api.github.com/users/mmarcinkiewicz/repos",
"events_url": "https://api.github.com/users/mmarcinkiewicz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mmarcinkiewicz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11723/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11723/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11722 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11722/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11722/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11722/events | https://github.com/NVIDIA/NeMo/pull/11722 | 2,762,505,980 | PR_kwDOC_bI7s6GZZ7D | 11,722 | chore(beep boop 🤖): Bump `MCORE_TAG=2da43ef...` (2024-12-30) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-30T00:23:45 | 2025-01-03T12:54:14 | 2025-01-03T12:54:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11722",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11722",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11722.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11722.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=2da43ef4c1b9e76f03b7567360cf7390e877f1b6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11722/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11722/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11721 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11721/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11721/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11721/events | https://github.com/NVIDIA/NeMo/pull/11721 | 2,762,050,446 | PR_kwDOC_bI7s6GX-G1 | 11,721 | chore(beep boop 🤖): Bump `MCORE_TAG=2da43ef...` (2024-12-29) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-29T00:25:11 | 2025-01-03T12:54:16 | 2025-01-03T12:54:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11721",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11721",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11721.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11721.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=2da43ef4c1b9e76f03b7567360cf7390e877f1b6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11721/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11721/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11720 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11720/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11720/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11720/events | https://github.com/NVIDIA/NeMo/pull/11720 | 2,761,367,036 | PR_kwDOC_bI7s6GVrjX | 11,720 | chore(beep boop 🤖): Bump `MCORE_TAG=2da43ef...` (2024-12-28) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-28T00:22:13 | 2025-01-03T12:54:19 | 2025-01-03T12:54:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11720",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11720",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11720.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11720.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=2da43ef4c1b9e76f03b7567360cf7390e877f1b6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11720/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11720/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11719 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11719/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11719/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11719/events | https://github.com/NVIDIA/NeMo/pull/11719 | 2,760,245,515 | PR_kwDOC_bI7s6GR6dT | 11,719 | chore(beep boop 🤖): Bump `MCORE_TAG=2da43ef...` (2024-12-27) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-27T00:22:36 | 2025-01-03T12:54:21 | 2025-01-03T12:54:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11719",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11719",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11719.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11719.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=2da43ef4c1b9e76f03b7567360cf7390e877f1b6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11719/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11719/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11718 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11718/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11718/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11718/events | https://github.com/NVIDIA/NeMo/pull/11718 | 2,759,664,123 | PR_kwDOC_bI7s6GP_Fh | 11,718 | Allow using vocab size from config | {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.base\nnemo/collections/llm/gpt/model/base.py:239:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/llm/gpt/model/base.py:416:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/llm/gpt/model/base.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:94:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:126:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:142:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:152:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:162:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:186:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:265:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:277:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:289:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:301:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:313:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:325:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:339:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:357:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:384:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:387:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:390:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:394:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:399:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:430:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:437:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:444:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:472:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:43:4: W0611: Unused import fused_weight_gradient_mlp_cuda (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.89/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @shanmugamr1992 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12555658692) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-26T11:37:41 | 2024-12-31T12:07:49 | 2024-12-31T12:07:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11718",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11718",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11718.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11718.patch",
"merged_at": "2024-12-31T12:07:47"
} | This MR allows the use of vocab size from config. In several cases once the indexed dataset is created, the tokenizer is used only to get vocab size.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11718/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11718/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11717 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11717/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11717/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11717/events | https://github.com/NVIDIA/NeMo/issues/11717 | 2,759,193,484 | I_kwDOC_bI7s6kdfOM | 11,717 | convert_llama_hf_to_nemo.py use llama31 | {
"login": "yangzhipeng1108",
"id": 33448441,
"node_id": "MDQ6VXNlcjMzNDQ4NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/33448441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yangzhipeng1108",
"html_url": "https://github.com/yangzhipeng1108",
"followers_url": "https://api.github.com/users/yangzhipeng1108/followers",
"following_url": "https://api.github.com/users/yangzhipeng1108/following{/other_user}",
"gists_url": "https://api.github.com/users/yangzhipeng1108/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yangzhipeng1108/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yangzhipeng1108/subscriptions",
"organizations_url": "https://api.github.com/users/yangzhipeng1108/orgs",
"repos_url": "https://api.github.com/users/yangzhipeng1108/repos",
"events_url": "https://api.github.com/users/yangzhipeng1108/events{/privacy}",
"received_events_url": "https://api.github.com/users/yangzhipeng1108/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"Hi @yangzhipeng1108, We hit the same problem with the checkpoint conversion, Just wondering if you could leave your contact information in your github, Could we send you a email regarding this. We would love to explore the potential cooperation opportunity"
] | 2024-12-26T02:30:11 | 2025-01-07T06:02:33 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | python /opt/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --input_name_or_path=/workspace/model_ckpts/Meta-Llama-3.1-8B-Instruct/ --output_path=llama3.1-8b-instruct.nemo --llama31 True
Does llama31 not pack embedding into nemo file?
Generated
Downloa
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11717/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11717/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11716 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11716/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11716/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11716/events | https://github.com/NVIDIA/NeMo/pull/11716 | 2,759,137,344 | PR_kwDOC_bI7s6GONnf | 11,716 | chore(beep boop 🤖): Bump `MCORE_TAG=2da43ef...` (2024-12-26) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-26T00:22:32 | 2025-01-03T12:54:24 | 2025-01-03T12:54:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11716",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11716",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11716.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11716.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=2da43ef4c1b9e76f03b7567360cf7390e877f1b6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11716/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11716/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11715 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11715/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11715/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11715/events | https://github.com/NVIDIA/NeMo/pull/11715 | 2,759,094,622 | PR_kwDOC_bI7s6GOFW5 | 11,715 | Cherry pick `removed the line which caused a problem in nfa_tutorial (11710)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:716:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:717:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:16:0: W0611: Unused import json (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:17:0: W0611: Unused import os (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:18:0: W0611: Unused import tempfile (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:24:0: W0611: Unused tqdm imported from tqdm.auto (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.82/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:716:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:717:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:16:0: W0611: Unused import json (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:17:0: W0611: Unused import os (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:18:0: W0611: Unused import tempfile (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:24:0: W0611: Unused tqdm imported from tqdm.auto (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.82/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:716:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:717:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:16:0: W0611: Unused import json (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:17:0: W0611: Unused import os (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:18:0: W0611: Unused import tempfile (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:24:0: W0611: Unused tqdm imported from tqdm.auto (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.82/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12678348248) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-25T21:18:02 | 2025-01-09T07:10:43 | 2025-01-09T07:10:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11715",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11715",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11715.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11715.patch",
"merged_at": "2025-01-09T07:10:41"
} | beep boop [🤖]: Hi @Ssofja 👋,
we've cherry picked #11710 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11715/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11715/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11714 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11714/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11714/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11714/events | https://github.com/NVIDIA/NeMo/pull/11714 | 2,758,425,540 | PR_kwDOC_bI7s6GMYNQ | 11,714 | Bug fix minor bug in TRT-LLM deployment | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @oyilmaz-nvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12488550311) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-25T02:33:42 | 2024-12-31T10:50:51 | 2024-12-31T10:50:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11714",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11714",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11714.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11714.patch",
"merged_at": "2024-12-31T10:50:50"
} | # What does this PR do ?
Fixes a minor bug deploying trt-llm models
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11714/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11714/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11713 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11713/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11713/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11713/events | https://github.com/NVIDIA/NeMo/pull/11713 | 2,758,370,731 | PR_kwDOC_bI7s6GMOTk | 11,713 | chore(beep boop 🤖): Bump `MCORE_TAG=2da43ef...` (2024-12-25) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-25T00:22:23 | 2025-01-03T12:55:19 | 2025-01-03T12:55:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11713",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11713",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11713.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11713.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=2da43ef4c1b9e76f03b7567360cf7390e877f1b6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11713/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11713/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11712 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11712/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11712/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11712/events | https://github.com/NVIDIA/NeMo/pull/11712 | 2,758,356,757 | PR_kwDOC_bI7s6GMLyR | 11,712 | Lora ckpt in HF format for NeMo AutoModel | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:28:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/peft/hf.py:63:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.vllm_hf_exporter\nnemo/export/vllm_hf_exporter.py:62:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/vllm_hf_exporter.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:82:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:58:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:300:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.utils\nnemo/lightning/pytorch/strategies/utils.py:40:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/strategies/utils.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:142:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:197:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.73/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:28:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/peft/hf.py:63:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.vllm_hf_exporter\nnemo/export/vllm_hf_exporter.py:62:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/vllm_hf_exporter.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:82:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:58:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:300:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.utils\nnemo/lightning/pytorch/strategies/utils.py:40:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/strategies/utils.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:142:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:197:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.73/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @oyilmaz-nvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12696149977) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-24T23:45:02 | 2025-01-10T17:25:46 | 2025-01-10T16:51:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11712",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11712",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11712.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11712.patch",
"merged_at": "2025-01-10T16:51:21"
} | # What does this PR do ?
Adds support to save Lora ckpt in HF format for NeMo automodel.
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11712/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11712/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11711 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11711/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11711/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11711/events | https://github.com/NVIDIA/NeMo/pull/11711 | 2,758,136,521 | PR_kwDOC_bI7s6GLgaz | 11,711 | Cherry pick `added required instalation for sox to process mp3 file (11709)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-24T17:04:14 | 2025-01-07T15:20:06 | 2025-01-07T15:20:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11711",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11711",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11711.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11711.patch",
"merged_at": "2025-01-07T15:20:04"
} | beep boop [🤖]: Hi @Ssofja 👋,
we've cherry picked #11709 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11711/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11711/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11710 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11710/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11710/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11710/events | https://github.com/NVIDIA/NeMo/pull/11710 | 2,758,127,502 | PR_kwDOC_bI7s6GLeqf | 11,710 | removed the line which caused a problem in nfa_tutorial | {
"login": "Ssofja",
"id": 78349198,
"node_id": "MDQ6VXNlcjc4MzQ5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/78349198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ssofja",
"html_url": "https://github.com/Ssofja",
"followers_url": "https://api.github.com/users/Ssofja/followers",
"following_url": "https://api.github.com/users/Ssofja/following{/other_user}",
"gists_url": "https://api.github.com/users/Ssofja/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ssofja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ssofja/subscriptions",
"organizations_url": "https://api.github.com/users/Ssofja/orgs",
"repos_url": "https://api.github.com/users/Ssofja/repos",
"events_url": "https://api.github.com/users/Ssofja/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ssofja/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @Ssofja 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12484285474) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:716:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:717:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:16:0: W0611: Unused import json (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:17:0: W0611: Unused import os (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:18:0: W0611: Unused import tempfile (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:24:0: W0611: Unused tqdm imported from tqdm.auto (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.82/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @Ssofja 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12495141516) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-24T16:52:06 | 2024-12-25T21:17:37 | 2024-12-25T21:17:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11710",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11710",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11710.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11710.patch",
"merged_at": "2024-12-25T21:17:36"
} | # What does this PR do ?
This PR fixes the bug which was noticed during the usage of tutorials/tools/NeMo_Forced_Aligner_Tutorial.ipynb
**Collection**: [ASR]
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11710/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11710/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11709 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11709/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11709/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11709/events | https://github.com/NVIDIA/NeMo/pull/11709 | 2,758,118,695 | PR_kwDOC_bI7s6GLc0Y | 11,709 | added required instalation for sox to process mp3 file | {
"login": "Ssofja",
"id": 78349198,
"node_id": "MDQ6VXNlcjc4MzQ5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/78349198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ssofja",
"html_url": "https://github.com/Ssofja",
"followers_url": "https://api.github.com/users/Ssofja/followers",
"following_url": "https://api.github.com/users/Ssofja/following{/other_user}",
"gists_url": "https://api.github.com/users/Ssofja/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ssofja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ssofja/subscriptions",
"organizations_url": "https://api.github.com/users/Ssofja/orgs",
"repos_url": "https://api.github.com/users/Ssofja/repos",
"events_url": "https://api.github.com/users/Ssofja/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ssofja/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-24T16:40:52 | 2024-12-24T17:03:49 | 2024-12-24T17:03:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11709",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11709",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11709.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11709.patch",
"merged_at": "2024-12-24T17:03:46"
} | # What does this PR do ?
This PR fixes the bug which was noticed during the usage of tutorials/tools/CTC_Segmentation_Tutorial.ipynb
**Collection**: [ASR]
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11709/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11709/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11708 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11708/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11708/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11708/events | https://github.com/NVIDIA/NeMo/pull/11708 | 2,757,069,914 | PR_kwDOC_bI7s6GIeJt | 11,708 | [DRAFT_TEST] - Yash/mimo rebased | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-12-24T02:43:35 | 2024-12-29T20:42:46 | 2024-12-29T20:42:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11708",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11708",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11708.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11708.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11708/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11708/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11707 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11707/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11707/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11707/events | https://github.com/NVIDIA/NeMo/pull/11707 | 2,757,068,202 | PR_kwDOC_bI7s6GIdy0 | 11,707 | Sortformer Diarizer 4spk v1 model PR Part 4: Sortformer Documents and Notebook Tutorials | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-24T02:41:04 | 2025-01-06T22:51:18 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11707",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11707",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11707.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11707.patch",
"merged_at": null
} | # What does this PR do ?
This PR adds Sortformer documents and tutorial notebooks.
**Collection**: ASR/speaker_tasks
# Changelog
Speaker Diarization documents.
`tutorial/speaker_tasks/End_to_end_Diarization_Training.ipynb`
`tutorial/speaker_tasks/End_to_end_Diarization_Inference.ipynb`
# Usage
Run tutorial notebooks.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11707/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11707/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11706 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11706/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11706/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11706/events | https://github.com/NVIDIA/NeMo/pull/11706 | 2,756,921,730 | PR_kwDOC_bI7s6GIFbb | 11,706 | chore(beep boop 🤖): Bump `MCORE_TAG=2da43ef...` (2024-12-24) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-24T00:22:46 | 2025-01-03T12:55:22 | 2025-01-03T12:55:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11706",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11706",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11706.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11706.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=2da43ef4c1b9e76f03b7567360cf7390e877f1b6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11706/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11706/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11705 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11705/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11705/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11705/events | https://github.com/NVIDIA/NeMo/pull/11705 | 2,756,249,061 | PR_kwDOC_bI7s6GF3tw | 11,705 | Use explicit imports from megatronllm_deployable.py | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12469072042) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-23T15:08:18 | 2024-12-23T17:53:11 | 2024-12-23T17:53:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11705",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11705",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11705.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11705.patch",
"merged_at": "2024-12-23T17:53:10"
} | # What does this PR do ?
Use explicit imports of from `nemo.deploy.nlp.megatronllm_deployable` module to avoid dependency chain in case of vLLM. This module is not needed for vLLM deployments and the virtualenv `/opt/venv` for vLLM should only contain minimal set of requirements to run it.
Otherwise just importing from `nemo.deploy.nlp` triggers many unnecessary requirements.
**Collection**: NLP/LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to https://github.com/NVIDIA/NeMo/pull/11523
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11705/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11705/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11703 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11703/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11703/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11703/events | https://github.com/NVIDIA/NeMo/pull/11703 | 2,755,768,115 | PR_kwDOC_bI7s6GEVVu | 11,703 | job dir for vboost stdout | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.run.plugins\nnemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)\nnemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)\nnemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)\nnemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/run/plugins.py:181:0: C0301: Line too long (174/119) (line-too-long)\nnemo/lightning/run/plugins.py:257:0: C0301: Line too long (150/119) (line-too-long)\nnemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:159:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:204:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:267:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.19/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @malay-nagda 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12465685265) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-23T10:56:37 | 2024-12-23T17:37:33 | 2024-12-23T17:37:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11703",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11703",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11703.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11703.patch",
"merged_at": "2024-12-23T17:37:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11703/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11703/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11702 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11702/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11702/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11702/events | https://github.com/NVIDIA/NeMo/pull/11702 | 2,755,742,384 | PR_kwDOC_bI7s6GEPwP | 11,702 | NeMo2.0 llama3 perf scripts | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Maybe should set `tensorboard logger` disabled by default and document how to enable it? \r\n`tensorboard logger` causes performance overhead.",
"[🤖]: Hi @malay-nagda 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12469395864) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.run.plugins\nnemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)\nnemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)\nnemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)\nnemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/run/plugins.py:181:0: C0301: Line too long (174/119) (line-too-long)\nnemo/lightning/run/plugins.py:257:0: C0301: Line too long (150/119) (line-too-long)\nnemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:159:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:204:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:267:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.19/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @malay-nagda 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12563010875) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-23T10:41:40 | 2025-01-01T01:45:24 | 2025-01-01T01:45:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11702",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11702",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11702.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11702.patch",
"merged_at": "2025-01-01T01:45:23"
} | # What does this PR do ?
llama3 pre-training recipes with performance optimizations
**Collection**: [llm]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
```python
python3 scripts/llm/performance/llama3_8b.py -a <slurm_account> -p <slurm_partition> -i nvcr.io/nvidia/nemo:24.09
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11702/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11702/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11701 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11701/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11701/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11701/events | https://github.com/NVIDIA/NeMo/pull/11701 | 2,754,926,357 | PR_kwDOC_bI7s6GBrrD | 11,701 | chore(beep boop 🤖): Bump `MCORE_TAG=d3c585e...` (2024-12-23) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-23T00:23:38 | 2025-01-03T12:55:24 | 2025-01-03T12:55:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11701",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11701",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11701.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11701.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=d3c585e90ebd5937243c8d4c9d5d5cf9d61665d6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11701/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11701/timeline | null | null | true |
Subsets and Splits