url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/11600 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11600/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11600/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11600/events | https://github.com/NVIDIA/NeMo/pull/11600 | 2,740,202,964 | PR_kwDOC_bI7s6FPbDj | 11,600 | Some fixes to bump mcore | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-15T00:26:59 | 2025-01-03T10:37:24 | 2025-01-03T10:37:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11600",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11600",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11600.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11600.patch",
"merged_at": "2025-01-03T10:37:08"
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=71c394b172ce4f1b9466e1d728bad5cc6314d15d`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11600/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11600/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11599 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11599/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11599/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11599/events | https://github.com/NVIDIA/NeMo/issues/11599 | 2,740,200,772 | I_kwDOC_bI7s6jVCVE | 11,599 | Memory consumption for Mamba2 8B finetuning (Nemo1) | {
"login": "YasamanJafari",
"id": 30384252,
"node_id": "MDQ6VXNlcjMwMzg0MjUy",
"avatar_url": "https://avatars.githubusercontent.com/u/30384252?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/YasamanJafari",
"html_url": "https://github.com/YasamanJafari",
"followers_url": "https://api.github.com/users/YasamanJafari/followers",
"following_url": "https://api.github.com/users/YasamanJafari/following{/other_user}",
"gists_url": "https://api.github.com/users/YasamanJafari/gists{/gist_id}",
"starred_url": "https://api.github.com/users/YasamanJafari/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/YasamanJafari/subscriptions",
"organizations_url": "https://api.github.com/users/YasamanJafari/orgs",
"repos_url": "https://api.github.com/users/YasamanJafari/repos",
"events_url": "https://api.github.com/users/YasamanJafari/events{/privacy}",
"received_events_url": "https://api.github.com/users/YasamanJafari/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-15T00:20:18 | 2025-01-14T01:55:48 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | In the documentation, it is mentioned that fine-tuning Mamba2 8B should be possible on 2 80GB A100s, which makes sense, and assuming everything to be fp32, the memory consumption is expected to be:
- 32 GB for model params
- 32 GB for gradients
- 32 * 2 GB for optimizer states
This will sum up to 128 GB, however, in practice, it takes around ~240 GB to fine-tune Mamba8B using Nemo1 scripts.
I would appreciate any information or explanation regarding this difference.
Thanks in advance for your assistance! | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11599/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11599/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11598 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11598/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11598/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11598/events | https://github.com/NVIDIA/NeMo/issues/11598 | 2,740,187,871 | I_kwDOC_bI7s6jU_Lf | 11,598 | Nemo1 to Nemo2 checkpoint conversion for Mamba2 | {
"login": "YasamanJafari",
"id": 30384252,
"node_id": "MDQ6VXNlcjMwMzg0MjUy",
"avatar_url": "https://avatars.githubusercontent.com/u/30384252?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/YasamanJafari",
"html_url": "https://github.com/YasamanJafari",
"followers_url": "https://api.github.com/users/YasamanJafari/followers",
"following_url": "https://api.github.com/users/YasamanJafari/following{/other_user}",
"gists_url": "https://api.github.com/users/YasamanJafari/gists{/gist_id}",
"starred_url": "https://api.github.com/users/YasamanJafari/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/YasamanJafari/subscriptions",
"organizations_url": "https://api.github.com/users/YasamanJafari/orgs",
"repos_url": "https://api.github.com/users/YasamanJafari/repos",
"events_url": "https://api.github.com/users/YasamanJafari/events{/privacy}",
"received_events_url": "https://api.github.com/users/YasamanJafari/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-14T23:36:16 | 2025-01-14T01:55:50 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
Even though the Nemo2 finetuning recipes have been released for Mamba2, there is no code for converting the checkpoints from nemo1 to nemo2 for Mamba2 or from Megatron checkpoint to nemo2. Is there an estimate of when this code will be released? It would be greatly appreciated!
Thanks! | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11598/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11598/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11597 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11597/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11597/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11597/events | https://github.com/NVIDIA/NeMo/pull/11597 | 2,740,132,870 | PR_kwDOC_bI7s6FPNn8 | 11,597 | Cherry pick from #11584 | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.t5.data.mock\nnemo/collections/llm/t5/data/mock.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/data/mock.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:89:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.data.pre_training\nnemo/collections/llm/t5/data/pre_training.py:302:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/llm/t5/data/pre_training.py:309:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/llm/t5/data/pre_training.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:226:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:229:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:246:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Already merged cherrypick in different PR"
] | 2024-12-14T20:32:09 | 2024-12-17T16:46:04 | 2024-12-17T16:46:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11597",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11597",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11597.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11597.patch",
"merged_at": null
} | # What does this PR do ?
Cherry pick from https://github.com/NVIDIA/NeMo/pull/11584
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11597/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11597/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11596 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11596/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11596/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11596/events | https://github.com/NVIDIA/NeMo/pull/11596 | 2,740,129,904 | PR_kwDOC_bI7s6FPNCJ | 11,596 | Cherry pick `Update T5 DataModule regarding Pretrain/Finetune validate (11584)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.t5.data.mock\nnemo/collections/llm/t5/data/mock.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/data/mock.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:89:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.data.pre_training\nnemo/collections/llm/t5/data/pre_training.py:302:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/llm/t5/data/pre_training.py:309:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/llm/t5/data/pre_training.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:226:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:229:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:246:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Already merged cherrypick in different PR"
] | 2024-12-14T20:22:58 | 2024-12-17T16:45:50 | 2024-12-17T16:45:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11596",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11596",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11596.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11596.patch",
"merged_at": null
} | beep boop [🤖]: Hi @huvunvidia 👋,
we've cherry picked #11584 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11596/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11596/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11595 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11595/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11595/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11595/events | https://github.com/NVIDIA/NeMo/pull/11595 | 2,739,480,130 | PR_kwDOC_bI7s6FNCPv | 11,595 | Cherry pick `NIM supporting changes for nemo.export for NeMo 2.0 (11488)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.deploy.deploy_pytriton\nnemo/deploy/deploy_pytriton.py:53:0: C0301: Line too long (132/119) (line-too-long)\nnemo/deploy/deploy_pytriton.py:83:0: C0301: Line too long (126/119) (line-too-long)\n************* Module nemo.export.trt_llm.converter.model_to_trt_llm_ckpt\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:55:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:101:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:130:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:294:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:301:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:308:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:509:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:73:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:96:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:104:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:114:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:125:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:136:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:174:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:188:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:192:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:201:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:226:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:237:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:313:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:431:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:515:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:519:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:530:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:542:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:582:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:619:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:632:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:27:0: W0611: Unused import tensorstore (unused-import)\n************* Module scripts.deploy.nlp.deploy_triton\nscripts/deploy/nlp/deploy_triton.py:393:0: C0301: Line too long (121/119) (line-too-long)\nscripts/deploy/nlp/deploy_triton.py:30:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/deploy/nlp/deploy_triton.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:259:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:370:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:377:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module export_to_trt_llm\nscripts/export/export_to_trt_llm.py:25:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/export/export_to_trt_llm.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/export/export_to_trt_llm.py:156:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.69/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.deploy.deploy_pytriton\nnemo/deploy/deploy_pytriton.py:53:0: C0301: Line too long (132/119) (line-too-long)\nnemo/deploy/deploy_pytriton.py:83:0: C0301: Line too long (126/119) (line-too-long)\n************* Module nemo.export.trt_llm.converter.model_to_trt_llm_ckpt\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:55:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:101:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:130:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:294:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:301:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:308:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:509:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:73:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:96:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:104:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:114:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:125:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:136:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:174:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:188:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:192:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:201:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:226:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:237:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:313:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:431:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:515:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:519:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:530:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:542:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:582:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:619:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:632:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:27:0: W0611: Unused import tensorstore (unused-import)\n************* Module scripts.deploy.nlp.deploy_triton\nscripts/deploy/nlp/deploy_triton.py:393:0: C0301: Line too long (121/119) (line-too-long)\nscripts/deploy/nlp/deploy_triton.py:30:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/deploy/nlp/deploy_triton.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:259:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:370:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:377:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module export_to_trt_llm\nscripts/export/export_to_trt_llm.py:25:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/export/export_to_trt_llm.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/export/export_to_trt_llm.py:156:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.69/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Already merged cherrypick in different PR"
] | 2024-12-14T02:27:30 | 2024-12-17T16:45:21 | 2024-12-17T16:45:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11595",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11595",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11595.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11595.patch",
"merged_at": null
} | beep boop [🤖]: Hi @janekl 👋,
we've cherry picked #11488 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11595/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11595/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11594 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11594/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11594/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11594/events | https://github.com/NVIDIA/NeMo/pull/11594 | 2,739,402,011 | PR_kwDOC_bI7s6FMxWo | 11,594 | add documentation for checkpoint averaging | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Thanks for the cleanup !",
"> Looks good. Will we have a script for torch dist conversion ?\r\n\r\nYes, I think we have to reopen this PR https://github.com/NVIDIA/NeMo/pull/10834.",
"[🤖]: Hi @dimapihtar 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12414091626) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-14T00:25:27 | 2024-12-20T01:27:50 | 2024-12-20T01:27:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11594",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11594",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11594.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11594.patch",
"merged_at": "2024-12-20T01:27:49"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11594/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11594/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11593 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11593/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11593/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11593/events | https://github.com/NVIDIA/NeMo/pull/11593 | 2,739,400,845 | PR_kwDOC_bI7s6FMxHR | 11,593 | chore(beep boop 🤖): Bump `MCORE_TAG=3f5d5d4...` (2024-12-14) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-14T00:23:37 | 2025-01-03T12:54:45 | 2025-01-03T12:54:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11593",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11593",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11593.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11593.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=3f5d5d4657fa2467ef578d852cb86bbfe8512309`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11593/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11593/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11592 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11592/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11592/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11592/events | https://github.com/NVIDIA/NeMo/pull/11592 | 2,739,383,028 | PR_kwDOC_bI7s6FMtY9 | 11,592 | vae training and autovae | {
"login": "linnanwang",
"id": 4675611,
"node_id": "MDQ6VXNlcjQ2NzU2MTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4675611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/linnanwang",
"html_url": "https://github.com/linnanwang",
"followers_url": "https://api.github.com/users/linnanwang/followers",
"following_url": "https://api.github.com/users/linnanwang/following{/other_user}",
"gists_url": "https://api.github.com/users/linnanwang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/linnanwang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linnanwang/subscriptions",
"organizations_url": "https://api.github.com/users/linnanwang/orgs",
"repos_url": "https://api.github.com/users/linnanwang/repos",
"events_url": "https://api.github.com/users/linnanwang/events{/privacy}",
"received_events_url": "https://api.github.com/users/linnanwang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/12553124376",
"@pablo-garay @ethanhe42 thanks!"
] | 2024-12-13T23:55:55 | 2024-12-31T19:20:48 | 2024-12-31T19:18:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11592",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11592",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11592.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11592.patch",
"merged_at": "2024-12-31T19:18:18"
} | # What does this PR do ?
this PR introduces VAE training into NeMo that allows users to customize a 16x or 8x reduction VAE on their in house data. Besides, we also introduce a feature that automatically designs VAE based on the GPU memory and latency requirements.
**Collection**: NeMo/Diffusion/VAE
# Changelog
- it is a new feature, no touch of existing codes.
# Usage
* Please follow the readme to setup the training.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [Yes] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [No] Did you write any new necessary tests?
- [Yes] Did you add or update any necessary documentation?
- [No] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [No] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11592/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11592/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11591 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11591/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11591/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11591/events | https://github.com/NVIDIA/NeMo/pull/11591 | 2,739,366,492 | PR_kwDOC_bI7s6FMp7N | 11,591 | add timestamp support | {
"login": "kevinhu-nv",
"id": 184545435,
"node_id": "U_kgDOCv_wmw",
"avatar_url": "https://avatars.githubusercontent.com/u/184545435?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevinhu-nv",
"html_url": "https://github.com/kevinhu-nv",
"followers_url": "https://api.github.com/users/kevinhu-nv/followers",
"following_url": "https://api.github.com/users/kevinhu-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinhu-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevinhu-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinhu-nv/subscriptions",
"organizations_url": "https://api.github.com/users/kevinhu-nv/orgs",
"repos_url": "https://api.github.com/users/kevinhu-nv/repos",
"events_url": "https://api.github.com/users/kevinhu-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevinhu-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"PTAL @pzelasko ",
"@pzelasko Can you approve again? Rebased the repo for the tests.",
"@titu1994 @stevehuang52 Could you take a look to trigger the workflow checks?",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.tokenizers.canary_tokenizer\nnemo/collections/common/tokenizers/canary_tokenizer.py:133:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/common/tokenizers/canary_tokenizer.py:56:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:158:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:164:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.42/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-13T23:31:17 | 2024-12-20T18:05:01 | 2024-12-20T18:05:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11591",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11591",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11591.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11591.patch",
"merged_at": "2024-12-20T18:05:00"
} | # What does this PR do ?
Add support for parsing timestamp data for training.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Filter out transcription with text by regex
- Tokenize word by word and insert start and end timestamps for each word
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "kevinhu-nv",
"id": 184545435,
"node_id": "U_kgDOCv_wmw",
"avatar_url": "https://avatars.githubusercontent.com/u/184545435?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevinhu-nv",
"html_url": "https://github.com/kevinhu-nv",
"followers_url": "https://api.github.com/users/kevinhu-nv/followers",
"following_url": "https://api.github.com/users/kevinhu-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinhu-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevinhu-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinhu-nv/subscriptions",
"organizations_url": "https://api.github.com/users/kevinhu-nv/orgs",
"repos_url": "https://api.github.com/users/kevinhu-nv/repos",
"events_url": "https://api.github.com/users/kevinhu-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevinhu-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11591/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11591/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11590 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11590/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11590/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11590/events | https://github.com/NVIDIA/NeMo/pull/11590 | 2,739,325,126 | PR_kwDOC_bI7s6FMhEM | 11,590 | Cherry pick `Fix example configs (11571)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module pretraining\nscripts/llm/pretraining.py:35:0: C0301: Line too long (151/119) (line-too-long)\nscripts/llm/pretraining.py:144:0: C0301: Line too long (142/119) (line-too-long)\nscripts/llm/pretraining.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:119:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:22:0: W0611: Unused Any imported from typing (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.73/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Already merged cherrypick in different PR"
] | 2024-12-13T22:39:59 | 2024-12-17T16:45:11 | 2024-12-17T16:45:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11590",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11590",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11590.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11590.patch",
"merged_at": null
} | beep boop [🤖]: Hi @BoxiangW 👋,
we've cherry picked #11571 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11590/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11590/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11589 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11589/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11589/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11589/events | https://github.com/NVIDIA/NeMo/pull/11589 | 2,739,302,636 | PR_kwDOC_bI7s6FMdLR | 11,589 | vae training | {
"login": "linnanwang",
"id": 4675611,
"node_id": "MDQ6VXNlcjQ2NzU2MTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4675611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/linnanwang",
"html_url": "https://github.com/linnanwang",
"followers_url": "https://api.github.com/users/linnanwang/followers",
"following_url": "https://api.github.com/users/linnanwang/following{/other_user}",
"gists_url": "https://api.github.com/users/linnanwang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/linnanwang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linnanwang/subscriptions",
"organizations_url": "https://api.github.com/users/linnanwang/orgs",
"repos_url": "https://api.github.com/users/linnanwang/repos",
"events_url": "https://api.github.com/users/linnanwang/events{/privacy}",
"received_events_url": "https://api.github.com/users/linnanwang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-13T22:28:28 | 2024-12-13T23:41:58 | 2024-12-13T23:41:57 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11589",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11589",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11589.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11589.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "linnanwang",
"id": 4675611,
"node_id": "MDQ6VXNlcjQ2NzU2MTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4675611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/linnanwang",
"html_url": "https://github.com/linnanwang",
"followers_url": "https://api.github.com/users/linnanwang/followers",
"following_url": "https://api.github.com/users/linnanwang/following{/other_user}",
"gists_url": "https://api.github.com/users/linnanwang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/linnanwang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linnanwang/subscriptions",
"organizations_url": "https://api.github.com/users/linnanwang/orgs",
"repos_url": "https://api.github.com/users/linnanwang/repos",
"events_url": "https://api.github.com/users/linnanwang/events{/privacy}",
"received_events_url": "https://api.github.com/users/linnanwang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11589/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11589/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11588 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11588/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11588/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11588/events | https://github.com/NVIDIA/NeMo/pull/11588 | 2,739,291,681 | PR_kwDOC_bI7s6FMa5c | 11,588 | test | {
"login": "linnanwang",
"id": 4675611,
"node_id": "MDQ6VXNlcjQ2NzU2MTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4675611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/linnanwang",
"html_url": "https://github.com/linnanwang",
"followers_url": "https://api.github.com/users/linnanwang/followers",
"following_url": "https://api.github.com/users/linnanwang/following{/other_user}",
"gists_url": "https://api.github.com/users/linnanwang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/linnanwang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linnanwang/subscriptions",
"organizations_url": "https://api.github.com/users/linnanwang/orgs",
"repos_url": "https://api.github.com/users/linnanwang/repos",
"events_url": "https://api.github.com/users/linnanwang/events{/privacy}",
"received_events_url": "https://api.github.com/users/linnanwang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-13T22:17:30 | 2024-12-13T22:18:37 | 2024-12-13T22:18:37 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11588",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11588",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11588.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11588.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "linnanwang",
"id": 4675611,
"node_id": "MDQ6VXNlcjQ2NzU2MTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4675611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/linnanwang",
"html_url": "https://github.com/linnanwang",
"followers_url": "https://api.github.com/users/linnanwang/followers",
"following_url": "https://api.github.com/users/linnanwang/following{/other_user}",
"gists_url": "https://api.github.com/users/linnanwang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/linnanwang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linnanwang/subscriptions",
"organizations_url": "https://api.github.com/users/linnanwang/orgs",
"repos_url": "https://api.github.com/users/linnanwang/repos",
"events_url": "https://api.github.com/users/linnanwang/events{/privacy}",
"received_events_url": "https://api.github.com/users/linnanwang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11588/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11588/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11587 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11587/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11587/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11587/events | https://github.com/NVIDIA/NeMo/pull/11587 | 2,739,237,260 | PR_kwDOC_bI7s6FMPPG | 11,587 | Fix Gemma to always disable CuDNN Fused Attention | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12323523695) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T21:28:28 | 2024-12-16T19:27:38 | 2024-12-14T13:12:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11587",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11587",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11587.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11587.patch",
"merged_at": "2024-12-14T13:12:08"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11587/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11587/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11586 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11586/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11586/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11586/events | https://github.com/NVIDIA/NeMo/pull/11586 | 2,739,210,893 | PR_kwDOC_bI7s6FMJou | 11,586 | Jit with peft | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:26:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:22:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/peft/hf.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/sft/hf.py:90:0: C0301: Line too long (162/119) (line-too-long)\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:607:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:34:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:97:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:139:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.68/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12377463901) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T21:06:09 | 2024-12-17T21:26:29 | 2024-12-17T21:26:28 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11586",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11586",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11586.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11586.patch",
"merged_at": "2024-12-17T21:26:28"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11586/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11586/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11585 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11585/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11585/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11585/events | https://github.com/NVIDIA/NeMo/pull/11585 | 2,739,175,324 | PR_kwDOC_bI7s6FMB9b | 11,585 | Cherry-pick `add JitTransform (#11131)` into `r2.1.0` | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.jit_transform\nnemo/lightning/pytorch/callbacks/jit_transform.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:33:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:39:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:67:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:90:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:115:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.17/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Not needed in release branch."
] | 2024-12-13T20:38:12 | 2024-12-16T19:41:19 | 2024-12-16T19:41:18 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11585",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11585",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11585.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11585.patch",
"merged_at": null
} | * add JitTransform
* fixes
* add JiT CB test
* remove stale imports
* typo
* cleanup
* add jit callback test
* Apply isort and black reformatting
* fix param passing
* use sgd in test_nemo_jit_cb
* fix
* fix
* add thunder call
* Apply isort and black reformatting
* Use .compile method to avoid changing module structure
* Apply isort and black reformatting
* Apply isort and black reformatting
* Use JitConfig
* thunder setting
* avoid reentry
* remove optional
* rewrite
* refactor & module_selector
* fix
* Apply isort and black reformatting
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11585/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11585/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11584 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11584/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11584/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11584/events | https://github.com/NVIDIA/NeMo/pull/11584 | 2,738,974,151 | PR_kwDOC_bI7s6FLVfG | 11,584 | Update T5 DataModule regarding Pretrain/Finetune validate | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.t5.data.mock\nnemo/collections/llm/t5/data/mock.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/data/mock.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:89:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.data.pre_training\nnemo/collections/llm/t5/data/pre_training.py:302:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/llm/t5/data/pre_training.py:309:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/llm/t5/data/pre_training.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:226:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:229:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:246:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @huvunvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12321220078) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T18:35:50 | 2024-12-14T20:22:28 | 2024-12-14T20:22:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11584",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11584",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11584.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11584.patch",
"merged_at": "2024-12-14T20:22:27"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11584/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11584/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11583 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11583/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11583/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11583/events | https://github.com/NVIDIA/NeMo/pull/11583 | 2,738,957,744 | PR_kwDOC_bI7s6FLSDr | 11,583 | Cherry pick `Fix SingleDeviceStrategy support in Nsys callback (11574)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Already merged cherrypick in different PR"
] | 2024-12-13T18:24:21 | 2024-12-17T16:45:02 | 2024-12-17T16:45:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11583",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11583",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11583.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11583.patch",
"merged_at": null
} | beep boop [🤖]: Hi @akoumpa 👋,
we've cherry picked #11574 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11583/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11583/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11582 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11582/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11582/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11582/events | https://github.com/NVIDIA/NeMo/pull/11582 | 2,738,916,683 | PR_kwDOC_bI7s6FLJhl | 11,582 | LoRA Export | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.llama\nnemo/collections/llm/gpt/model/llama.py:439:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:440:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:451:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:452:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:453:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:454:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:455:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:456:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:458:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:459:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:460:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:461:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:672:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:47:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:67:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:76:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:85:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:94:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:116:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:137:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:147:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:159:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:169:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:180:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:191:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:204:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:217:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:223:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:229:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:240:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:244:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:256:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:293:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:336:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:358:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:378:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:382:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:403:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:514:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:664:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.peft.api\nnemo/collections/llm/peft/api.py:37:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.io.connector\nnemo/lightning/io/connector.py:148:0: C0301: Line too long (126/119) (line-too-long)\nnemo/lightning/io/connector.py:173:0: C0301: Line too long (152/119) (line-too-long)\nnemo/lightning/io/connector.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:130:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:293:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:18:0: W0611: Unused PurePath imported from pathlib (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.44/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12427292648) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T17:56:43 | 2024-12-21T00:08:32 | 2024-12-21T00:08:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11582",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11582",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11582.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11582.patch",
"merged_at": "2024-12-21T00:08:30"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11582/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11582/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11580 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11580/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11580/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11580/events | https://github.com/NVIDIA/NeMo/pull/11580 | 2,738,514,176 | PR_kwDOC_bI7s6FJyPA | 11,580 | Fix Llama3 rope_type conversion issue | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_llama_hf_to_nemo\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:63:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:46:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:77:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:131:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.80/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12317384602) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T14:22:33 | 2024-12-15T22:25:48 | 2024-12-15T22:25:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11580",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11580",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11580.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11580.patch",
"merged_at": "2024-12-15T22:25:45"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11580/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11580/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11579 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11579/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11579/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11579/events | https://github.com/NVIDIA/NeMo/pull/11579 | 2,738,390,268 | PR_kwDOC_bI7s6FJXKN | 11,579 | Top-level API for setting use_pytorch_sdpa | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.parts.mixins.mixins\nnemo/collections/asr/parts/mixins/mixins.py:624:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:627:0: C0301: Line too long (200/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:628:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:633:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:634:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:639:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:649:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:686:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:758:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/parts/mixins/mixins.py:559:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/mixins/mixins.py:880:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/mixins/mixins.py:896:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.submodules.multi_head_attention\nnemo/collections/asr/parts/submodules/multi_head_attention.py:63:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:185:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:333:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:358:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:590:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:646:0: C0301: Line too long (171/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:658:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:758:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:202:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/multi_head_attention.py:1013:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.72/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-13T13:22:11 | 2025-01-11T01:58:32 | 2025-01-11T01:58:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11579",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11579",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11579.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11579.patch",
"merged_at": null
} | # What does this PR do ?
Top-level API for setting `use_pytorch_sdpa` and selecting the SDPA backend.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11579/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11579/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11578 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11578/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11578/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11578/events | https://github.com/NVIDIA/NeMo/pull/11578 | 2,738,356,141 | PR_kwDOC_bI7s6FJPre | 11,578 | Remove auto-import of lhotse when importing nemo.collections.common.data | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"LGTM",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @pzelasko 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12316502064) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T13:05:11 | 2024-12-13T21:31:52 | 2024-12-13T21:31:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11578",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11578",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11578.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11578.patch",
"merged_at": "2024-12-13T21:31:51"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11578/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11578/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11577 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11577/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11577/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11577/events | https://github.com/NVIDIA/NeMo/pull/11577 | 2,738,316,486 | PR_kwDOC_bI7s6FJG-y | 11,577 | remove dialogue scripts and docs | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @dimapihtar 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12315887464) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T12:43:45 | 2024-12-13T19:36:46 | 2024-12-13T18:57:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11577",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11577",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11577.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11577.patch",
"merged_at": "2024-12-13T18:57:10"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11577/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11577/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11576 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11576/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11576/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11576/events | https://github.com/NVIDIA/NeMo/pull/11576 | 2,738,260,753 | PR_kwDOC_bI7s6FI6hY | 11,576 | Cherry pick `add huggingface-based tokenizer support for mixtral HF -> .nemo (11572)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_mixtral_hf_to_nemo\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:477:0: C0301: Line too long (146/119) (line-too-long)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:175:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:191:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:204:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:399:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:412:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:468:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:520:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_mixtral_hf_to_nemo\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:477:0: C0301: Line too long (146/119) (line-too-long)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:175:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:191:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:204:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:399:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:412:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:468:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:520:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Already merged cherrypick in different PR"
] | 2024-12-13T12:14:54 | 2024-12-17T16:44:37 | 2024-12-17T16:44:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11576",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11576",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11576.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11576.patch",
"merged_at": null
} | beep boop [🤖]: Hi @dimapihtar 👋,
we've cherry picked #11572 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11576/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11576/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11575 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11575/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11575/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11575/events | https://github.com/NVIDIA/NeMo/pull/11575 | 2,738,155,006 | PR_kwDOC_bI7s6FIjLp | 11,575 | ci: switch to single-gpu runner for `--devices 1` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12315025183) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T11:15:55 | 2024-12-13T22:55:41 | 2024-12-13T22:55:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11575",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11575",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11575.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11575.patch",
"merged_at": "2024-12-13T22:55:39"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11575/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11575/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11574 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11574/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11574/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11574/events | https://github.com/NVIDIA/NeMo/pull/11574 | 2,737,797,773 | PR_kwDOC_bI7s6FHaUq | 11,574 | Fix SingleDeviceStrategy support in Nsys callback | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12312755589) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T08:33:11 | 2024-12-13T18:23:53 | 2024-12-13T18:23:51 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11574",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11574",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11574.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11574.patch",
"merged_at": "2024-12-13T18:23:51"
} | # What does this PR do ?
Changes:
- use `get_current_epoch_step` to get the `current_epoch_step` from strategy defined only in NeMo's strategies.
- use `_rank_is_active` to support non-DDP workloads.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11574/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11574/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11573 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11573/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11573/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11573/events | https://github.com/NVIDIA/NeMo/pull/11573 | 2,737,327,380 | PR_kwDOC_bI7s6FGBpF | 11,573 | AED greedy confidence estimation | {
"login": "GNroy",
"id": 16904306,
"node_id": "MDQ6VXNlcjE2OTA0MzA2",
"avatar_url": "https://avatars.githubusercontent.com/u/16904306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GNroy",
"html_url": "https://github.com/GNroy",
"followers_url": "https://api.github.com/users/GNroy/followers",
"following_url": "https://api.github.com/users/GNroy/following{/other_user}",
"gists_url": "https://api.github.com/users/GNroy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GNroy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GNroy/subscriptions",
"organizations_url": "https://api.github.com/users/GNroy/orgs",
"repos_url": "https://api.github.com/users/GNroy/repos",
"events_url": "https://api.github.com/users/GNroy/events{/privacy}",
"received_events_url": "https://api.github.com/users/GNroy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.modules.transformer.transformer_generators\nnemo/collections/asr/modules/transformer/transformer_generators.py:382:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/transformer/transformer_generators.py:508:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/transformer/transformer_generators.py:855:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.submodules.multitask_decoding\nnemo/collections/asr/parts/submodules/multitask_decoding.py:66:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:89:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:114:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:126:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:430:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:453:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:478:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:599:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:164:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:606:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/multitask_decoding.py:15:0: W0611: Unused import re (unused-import)\n************* Module nemo.collections.asr.parts.submodules.multitask_greedy_decoding\nnemo/collections/asr/parts/submodules/multitask_greedy_decoding.py:184:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_greedy_decoding.py:238:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/submodules/multitask_greedy_decoding.py:31:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/multitask_greedy_decoding.py:68:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/multitask_greedy_decoding.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/multitask_greedy_decoding.py:99:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/multitask_greedy_decoding.py:257:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.utils.asr_confidence_utils\nnemo/collections/asr/parts/utils/asr_confidence_utils.py:28:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/asr_confidence_utils.py:34:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/asr_confidence_utils.py:42:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/asr_confidence_utils.py:46:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/asr_confidence_utils.py:25:0: W0611: Unused logging imported from nemo.utils (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.79/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-13T03:52:08 | 2024-12-14T11:54:23 | 2024-12-14T11:54:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11573",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11573",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11573.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11573.patch",
"merged_at": "2024-12-14T11:54:23"
} | # What does this PR do ?
Adds greedy confidence estimation for AED multitask models
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "GNroy",
"id": 16904306,
"node_id": "MDQ6VXNlcjE2OTA0MzA2",
"avatar_url": "https://avatars.githubusercontent.com/u/16904306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GNroy",
"html_url": "https://github.com/GNroy",
"followers_url": "https://api.github.com/users/GNroy/followers",
"following_url": "https://api.github.com/users/GNroy/following{/other_user}",
"gists_url": "https://api.github.com/users/GNroy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GNroy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GNroy/subscriptions",
"organizations_url": "https://api.github.com/users/GNroy/orgs",
"repos_url": "https://api.github.com/users/GNroy/repos",
"events_url": "https://api.github.com/users/GNroy/events{/privacy}",
"received_events_url": "https://api.github.com/users/GNroy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11573/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11573/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11572 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11572/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11572/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11572/events | https://github.com/NVIDIA/NeMo/pull/11572 | 2,737,223,291 | PR_kwDOC_bI7s6FFrek | 11,572 | add huggingface-based tokenizer support for mixtral HF -> .nemo | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_mixtral_hf_to_nemo\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:477:0: C0301: Line too long (146/119) (line-too-long)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:175:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:191:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:204:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:399:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:412:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:468:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:520:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_mixtral_hf_to_nemo\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:477:0: C0301: Line too long (146/119) (line-too-long)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:175:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:191:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:204:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:399:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:412:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:468:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:520:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @dimapihtar 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12312582060) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T02:11:53 | 2024-12-13T12:14:28 | 2024-12-13T12:14:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11572",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11572",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11572.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11572.patch",
"merged_at": "2024-12-13T12:14:27"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11572/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11572/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11571 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11571/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11571/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11571/events | https://github.com/NVIDIA/NeMo/pull/11571 | 2,737,160,727 | PR_kwDOC_bI7s6FFeiC | 11,571 | Fix example configs | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module pretraining\nscripts/llm/pretraining.py:35:0: C0301: Line too long (151/119) (line-too-long)\nscripts/llm/pretraining.py:144:0: C0301: Line too long (142/119) (line-too-long)\nscripts/llm/pretraining.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:119:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:22:0: W0611: Unused Any imported from typing (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.73/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @BoxiangW 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12307695730) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T01:03:26 | 2024-12-13T22:39:31 | 2024-12-13T22:39:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11571",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11571",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11571.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11571.patch",
"merged_at": "2024-12-13T22:39:30"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11571/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11571/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11570 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11570/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11570/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11570/events | https://github.com/NVIDIA/NeMo/pull/11570 | 2,737,157,303 | PR_kwDOC_bI7s6FFdz0 | 11,570 | Cherry pick `Revert \Fix the names of two sets of weight and bias in mcore_to_nemo_mapping\ (11560)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_gpt_nemo_to_mcore\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:153:0: C0301: Line too long (122/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:154:0: C0301: Line too long (131/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:161:0: C0301: Line too long (127/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:162:0: C0301: Line too long (125/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:235:0: C0301: Line too long (133/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:48:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:84:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:109:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:117:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:169:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:192:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:223:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:260:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.23/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_gpt_nemo_to_mcore\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:153:0: C0301: Line too long (122/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:154:0: C0301: Line too long (131/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:161:0: C0301: Line too long (127/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:162:0: C0301: Line too long (125/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:235:0: C0301: Line too long (133/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:48:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:84:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:109:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:117:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:169:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:192:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:223:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:260:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.23/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Already merged cherrypick in different PR"
] | 2024-12-13T00:59:48 | 2024-12-17T16:43:04 | 2024-12-17T16:43:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11570",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11570",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11570.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11570.patch",
"merged_at": null
} | beep boop [🤖]: Hi @ashors1 👋,
we've cherry picked #11560 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11570/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11570/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11569 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11569/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11569/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11569/events | https://github.com/NVIDIA/NeMo/pull/11569 | 2,737,123,813 | PR_kwDOC_bI7s6FFWxP | 11,569 | chore(beep boop 🤖): Bump `MCORE_TAG=99f23d2...` (2024-12-13) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-13T00:24:53 | 2025-01-03T01:58:29 | 2025-01-03T01:58:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11569",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11569",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11569.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11569.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=99f23d2f111d12b73b1fbf386c60517101ff8abe`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11569/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11569/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11568 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11568/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11568/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11568/events | https://github.com/NVIDIA/NeMo/pull/11568 | 2,737,101,853 | PR_kwDOC_bI7s6FFSL5 | 11,568 | Fix peft inference | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12380468563) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12397771373) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-13T00:02:38 | 2024-12-18T21:47:45 | 2024-12-18T21:47:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11568",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11568",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11568.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11568.patch",
"merged_at": "2024-12-18T21:47:44"
} | # What does this PR do ?
1. Fix PEFT inference (bug due to trainer not attached during peft inference)
2. Add CI test for PEFT inference
3. Expose top_k to enable greedy sampling in inference script
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11568/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11568/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11567 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11567/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11567/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11567/events | https://github.com/NVIDIA/NeMo/pull/11567 | 2,737,099,704 | PR_kwDOC_bI7s6FFRuS | 11,567 | add vae training | {
"login": "linnanwang",
"id": 4675611,
"node_id": "MDQ6VXNlcjQ2NzU2MTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4675611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/linnanwang",
"html_url": "https://github.com/linnanwang",
"followers_url": "https://api.github.com/users/linnanwang/followers",
"following_url": "https://api.github.com/users/linnanwang/following{/other_user}",
"gists_url": "https://api.github.com/users/linnanwang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/linnanwang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linnanwang/subscriptions",
"organizations_url": "https://api.github.com/users/linnanwang/orgs",
"repos_url": "https://api.github.com/users/linnanwang/repos",
"events_url": "https://api.github.com/users/linnanwang/events{/privacy}",
"received_events_url": "https://api.github.com/users/linnanwang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-13T00:00:30 | 2024-12-13T22:22:37 | 2024-12-13T22:22:37 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11567",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11567",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11567.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11567.patch",
"merged_at": null
} | # What does this PR do ?
Add VAE training, allowing users to customize VAE compression ratio to 16x or 8x and train the customized VAE with the script.
**Collection**:
NeMo/collections/diffusion/vae
# Changelog
- Add VAE training on customized datasets
- Add autoVAE that automatically searches for a good customized VAE
- examples of VAE usage, reconstructed images V.S. original images
# Usage
Please see readme in NeMo/nemo/collections/diffusion/vae
# Before your PR is "Ready for review"
**Pre checks**:
- [x ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [x] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "linnanwang",
"id": 4675611,
"node_id": "MDQ6VXNlcjQ2NzU2MTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4675611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/linnanwang",
"html_url": "https://github.com/linnanwang",
"followers_url": "https://api.github.com/users/linnanwang/followers",
"following_url": "https://api.github.com/users/linnanwang/following{/other_user}",
"gists_url": "https://api.github.com/users/linnanwang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/linnanwang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/linnanwang/subscriptions",
"organizations_url": "https://api.github.com/users/linnanwang/orgs",
"repos_url": "https://api.github.com/users/linnanwang/repos",
"events_url": "https://api.github.com/users/linnanwang/events{/privacy}",
"received_events_url": "https://api.github.com/users/linnanwang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11567/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11567/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11566 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11566/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11566/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11566/events | https://github.com/NVIDIA/NeMo/pull/11566 | 2,737,061,415 | PR_kwDOC_bI7s6FFJkD | 11,566 | Add Hf nemorun tests | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @HuiyingLi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12312774083) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:275:0: C0301: Line too long (184/119) (line-too-long)\nnemo/collections/llm/gpt/data/hf_dataset.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:208:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:268:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.recipes.hf_auto_model_for_causal_lm\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:100:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:152:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:192:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:20:0: W0611: Unused import torch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:275:0: C0301: Line too long (184/119) (line-too-long)\nnemo/collections/llm/gpt/data/hf_dataset.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:208:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:268:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.recipes.hf_auto_model_for_causal_lm\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:100:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:152:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:192:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:20:0: W0611: Unused import torch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @HuiyingLi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12327085055) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-12T23:23:33 | 2024-12-16T08:00:12 | 2024-12-16T08:00:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11566",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11566",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11566.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11566.patch",
"merged_at": "2024-12-16T08:00:10"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11566/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11566/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11565 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11565/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11565/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11565/events | https://github.com/NVIDIA/NeMo/pull/11565 | 2,736,720,162 | PR_kwDOC_bI7s6FD_hQ | 11,565 | Neva updates to latest mcore and some fixes | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.base\nnemo/collections/llm/gpt/model/base.py:228:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/llm/gpt/model/base.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:94:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:131:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:149:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:159:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:254:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:266:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:278:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:290:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:302:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:314:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:328:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:346:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:350:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:373:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:376:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:379:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:383:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:388:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:409:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:416:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:423:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:451:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:43:4: W0611: Unused import fused_weight_gradient_mlp_cuda (unused-import)\n************* Module nemo.collections.vlm.neva.model.base\nnemo/collections/vlm/neva/model/base.py:476:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:479:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:504:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:93:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:150:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:171:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:250:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:277:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:298:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:329:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:366:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:379:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:866:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:883:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:887:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:919:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:922:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:925:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:929:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:935:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:942:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:48:0: W0611: Unused get_packed_seq_params imported from nemo.collections.llm.gpt.model.base (unused-import)\n************* Module nemo.lightning.megatron_parallel\nnemo/lightning/megatron_parallel.py:238:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:239:0: C0301: Line too long (140/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:240:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:546:0: C0301: Line too long (129/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:553:0: C0301: Line too long (135/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:829:0: C0301: Line too long (137/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1059:0: C0301: Line too long (136/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1632:0: C0301: Line too long (128/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:64:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:102:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:106:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:330:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:356:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:382:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:518:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:561:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:619:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:654:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:660:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:666:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:673:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:714:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:722:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:738:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:765:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:777:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:799:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1325:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1500:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1516:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1521:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1526:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1554:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1600:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1622:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1695:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1738:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1752:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.22/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @yaoyu-33 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12321022849) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-12T19:30:41 | 2024-12-16T18:39:24 | 2024-12-16T18:39:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11565",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11565",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11565.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11565.patch",
"merged_at": "2024-12-16T18:39:22"
} | # What does this PR do ?
Neva updates and bug fixes
**Collection**: [multimodal]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11565/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11565/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11564 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11564/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11564/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11564/events | https://github.com/NVIDIA/NeMo/pull/11564 | 2,736,652,116 | PR_kwDOC_bI7s6FDwjo | 11,564 | Adding documentation for packed dataset preparation with context para… | {
"login": "tomlifu",
"id": 22651648,
"node_id": "MDQ6VXNlcjIyNjUxNjQ4",
"avatar_url": "https://avatars.githubusercontent.com/u/22651648?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tomlifu",
"html_url": "https://github.com/tomlifu",
"followers_url": "https://api.github.com/users/tomlifu/followers",
"following_url": "https://api.github.com/users/tomlifu/following{/other_user}",
"gists_url": "https://api.github.com/users/tomlifu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tomlifu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tomlifu/subscriptions",
"organizations_url": "https://api.github.com/users/tomlifu/orgs",
"repos_url": "https://api.github.com/users/tomlifu/repos",
"events_url": "https://api.github.com/users/tomlifu/events{/privacy}",
"received_events_url": "https://api.github.com/users/tomlifu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module prepare_packed_ft_dataset\nscripts/nlp_language_modeling/prepare_packed_ft_dataset.py:221:0: C0301: Line too long (157/119) (line-too-long)\nscripts/nlp_language_modeling/prepare_packed_ft_dataset.py:184:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/nlp_language_modeling/prepare_packed_ft_dataset.py:190:4: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/prepare_packed_ft_dataset.py:203:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.44/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-12T18:51:43 | 2024-12-12T21:16:50 | 2024-12-12T21:16:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11564",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11564",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11564.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11564.patch",
"merged_at": "2024-12-12T21:16:49"
} | # What does this PR do ?
This PR adds some documentation in the code for packed dataset preparation with context parallel.
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "xrennvidia",
"id": 103958965,
"node_id": "U_kgDOBjJJtQ",
"avatar_url": "https://avatars.githubusercontent.com/u/103958965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xrennvidia",
"html_url": "https://github.com/xrennvidia",
"followers_url": "https://api.github.com/users/xrennvidia/followers",
"following_url": "https://api.github.com/users/xrennvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/xrennvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xrennvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xrennvidia/subscriptions",
"organizations_url": "https://api.github.com/users/xrennvidia/orgs",
"repos_url": "https://api.github.com/users/xrennvidia/repos",
"events_url": "https://api.github.com/users/xrennvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/xrennvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11564/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11564/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11563 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11563/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11563/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11563/events | https://github.com/NVIDIA/NeMo/pull/11563 | 2,736,361,831 | PR_kwDOC_bI7s6FCw0n | 11,563 | micro_batch_size and global_batch_size as class attributes in llava next mock data module | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | closed | false | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"[🤖]: Hi @yashaswikarnati 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12305019475) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-12T16:26:10 | 2025-01-07T21:41:12 | 2024-12-12T23:27:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11563",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11563",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11563.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11563.patch",
"merged_at": "2024-12-12T23:27:59"
} |
# What does this PR do ?
micro_batch_size and global_batch_size as class attributes in llava next mock data module. This is to fix breaking change introduced in this PR (asserts datamodule to have these attributes) = https://github.com/NVIDIA/NeMo/pull/10954
**Collection**:
Multimodal
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11563/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11563/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11562 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11562/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11562/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11562/events | https://github.com/NVIDIA/NeMo/pull/11562 | 2,735,660,566 | PR_kwDOC_bI7s6FAWFV | 11,562 | comments for config knobs | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815558,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU4",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/documentation",
"name": "documentation",
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-12T11:42:30 | 2024-12-21T17:02:58 | 2024-12-21T17:02:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11562",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11562",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11562.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11562.patch",
"merged_at": "2024-12-21T17:02:58"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11562/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11562/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11561 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11561/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11561/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11561/events | https://github.com/NVIDIA/NeMo/pull/11561 | 2,734,341,917 | PR_kwDOC_bI7s6E7wyD | 11,561 | chore(beep boop 🤖): Bump `MCORE_TAG=371feef...` (2024-12-12) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-12T00:24:31 | 2025-01-02T01:57:51 | 2025-01-02T01:57:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11561",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11561",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11561.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11561.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=371feef2b7dd619038bdacb82fe0e195ebad67ee`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11561/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11561/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11560 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11560/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11560/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11560/events | https://github.com/NVIDIA/NeMo/pull/11560 | 2,734,315,273 | PR_kwDOC_bI7s6E7qsa | 11,560 | Revert "Fix the names of two sets of weight and bias in mcore_to_nemo_mapping" | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ashors1 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12287518402) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @ashors1 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12302112906) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_gpt_nemo_to_mcore\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:153:0: C0301: Line too long (122/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:154:0: C0301: Line too long (131/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:161:0: C0301: Line too long (127/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:162:0: C0301: Line too long (125/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:235:0: C0301: Line too long (133/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:48:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:84:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:109:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:117:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:169:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:192:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:223:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:260:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.23/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ashors1 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12306464342) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-12T00:10:15 | 2024-12-13T00:59:24 | 2024-12-13T00:59:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11560",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11560",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11560.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11560.patch",
"merged_at": "2024-12-13T00:59:23"
} | This reverts commit 6784db56a03f19f37bc4f37bdf87dabb3fc1acee.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11560/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11560/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11559 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11559/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11559/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11559/events | https://github.com/NVIDIA/NeMo/pull/11559 | 2,734,176,029 | PR_kwDOC_bI7s6E7MpE | 11,559 | Add from_dict to HFDatasetDataModule | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:181:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:207:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:233:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:237:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:241:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:244:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:247:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:250:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:253:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.17/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12286297330) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-11T22:40:17 | 2024-12-12T03:54:11 | 2024-12-12T03:54:10 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11559",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11559",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11559.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11559.patch",
"merged_at": "2024-12-12T03:54:10"
} | # What does this PR do ?
In HF you can do:
```
from datasets import Dataset
my_data = {"a": [1, 2, 3]}
dataset = Dataset.from_dict(my_data)
```
Adding support for the following:
```
data = {'text': "Below is an instruction that describes a task, paired with an input that "}
datamodule = llm.HFDatasetDataModule.**from_dict(
{"text": [data['text'] for _ in range(101)]},**
split='train',
global_batch_size=4,
micro_batch_size=1,
)
```
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11559/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11559/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11558 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11558/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11558/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11558/events | https://github.com/NVIDIA/NeMo/pull/11558 | 2,734,037,221 | PR_kwDOC_bI7s6E6ti3 | 11,558 | [🤠]: Howdy folks, let's release NeMo `r2.1.0` ! (#11556) | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-11T21:11:46 | 2024-12-11T21:13:00 | 2024-12-11T21:13:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11558",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11558",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11558.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11558.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11558/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11558/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11557 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11557/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11557/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11557/events | https://github.com/NVIDIA/NeMo/pull/11557 | 2,733,976,572 | PR_kwDOC_bI7s6E6fsH | 11,557 | ci: Bump code freeze workflow | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-11T20:47:39 | 2024-12-11T20:47:50 | 2024-12-11T20:47:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11557",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11557",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11557.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11557.patch",
"merged_at": "2024-12-11T20:47:46"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11557/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11557/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11556 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11556/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11556/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11556/events | https://github.com/NVIDIA/NeMo/pull/11556 | 2,733,966,863 | PR_kwDOC_bI7s6E6db0 | 11,556 | Freeze tags in in `r2.1.0` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-11T20:44:22 | 2024-12-11T20:53:18 | 2024-12-11T20:53:17 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11556",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11556",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11556.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11556.patch",
"merged_at": "2024-12-11T20:53:17"
} | 🚀 PR to freeze tags in `r2.1.0`. | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11556/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11556/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11555 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11555/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11555/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11555/events | https://github.com/NVIDIA/NeMo/pull/11555 | 2,733,962,110 | PR_kwDOC_bI7s6E6cVq | 11,555 | Version bump to `2.2.0rc0.dev0` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-11T20:42:39 | 2024-12-16T11:06:56 | 2024-12-16T11:06:54 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11555",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11555",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11555.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11555.patch",
"merged_at": "2024-12-16T11:06:54"
} | 🚀 Version bump NeMo-Toolkit to `2.2.0rc0.dev0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11555/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11555/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11554 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11554/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11554/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11554/events | https://github.com/NVIDIA/NeMo/pull/11554 | 2,733,953,532 | PR_kwDOC_bI7s6E6aWX | 11,554 | ci: Bump code-freeze workflow | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-11T20:39:38 | 2024-12-11T20:39:51 | 2024-12-11T20:39:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11554",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11554",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11554.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11554.patch",
"merged_at": "2024-12-11T20:39:46"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11554/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11554/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11553 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11553/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11553/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11553/events | https://github.com/NVIDIA/NeMo/pull/11553 | 2,733,928,115 | PR_kwDOC_bI7s6E6Uhg | 11,553 | Ko3n1g/ci/commit sha for cutoff | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-11T20:31:13 | 2024-12-11T20:31:25 | 2024-12-11T20:31:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11553",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11553",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11553.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11553.patch",
"merged_at": "2024-12-11T20:31:21"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11553/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11553/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11552 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11552/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11552/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11552/events | https://github.com/NVIDIA/NeMo/pull/11552 | 2,733,904,001 | PR_kwDOC_bI7s6E6O7q | 11,552 | Version bump to `2.2.0rc0` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-11T20:23:13 | 2024-12-11T20:40:02 | 2024-12-11T20:40:02 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11552",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11552",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11552.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11552.patch",
"merged_at": null
} | 🚀 Version bump NeMo-Toolkit to `2.2.0rc0.dev0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11552/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11552/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11551 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11551/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11551/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11551/events | https://github.com/NVIDIA/NeMo/pull/11551 | 2,733,897,246 | PR_kwDOC_bI7s6E6NcT | 11,551 | ci: Bump release freeze | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-11T20:20:54 | 2024-12-11T20:21:06 | 2024-12-11T20:21:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11551",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11551",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11551.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11551.patch",
"merged_at": "2024-12-11T20:21:02"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11551/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11551/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11550 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11550/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11550/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11550/events | https://github.com/NVIDIA/NeMo/pull/11550 | 2,733,860,068 | PR_kwDOC_bI7s6E6FDv | 11,550 | ci: Adjust inputs for code-freeze workflow | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-11T20:02:36 | 2024-12-11T20:03:01 | 2024-12-11T20:02:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11550",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11550",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11550.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11550.patch",
"merged_at": "2024-12-11T20:02:59"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11550/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11550/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11549 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11549/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11549/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11549/events | https://github.com/NVIDIA/NeMo/pull/11549 | 2,733,852,166 | PR_kwDOC_bI7s6E6DZP | 11,549 | Add safetensor option when saving and restoring models | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"I just wanted to chime in that if there is any way to get this pull request merged into the main branch and a release branch that would be hugely helpful. I can hobble along using my clone of this branch, but that's obviously not ideal. Thank you guys for you great work and for this really helpful contribution in particular!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"Reopened. It got stale over the holidays.",
"I just wanted to say I fully endorse this pull request. I tested it and it works well for my use case. It will greatly enable my work if some form of this safetensor PR can make it into the main branch. Thank you!!!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.clustering_diarizer\nnemo/collections/asr/models/clustering_diarizer.py:238:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/asr/models/clustering_diarizer.py:242:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/clustering_diarizer.py:328:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/asr/models/clustering_diarizer.py:549:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.modules.audio_preprocessing\nnemo/collections/asr/modules/audio_preprocessing.py:98:0: C0301: Line too long (667/119) (line-too-long)\nnemo/collections/asr/modules/audio_preprocessing.py:95:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:106:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:545:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:616:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:667:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:724:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:757:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:776:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:792:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/audio_preprocessing.py:798:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.modules.conv_asr\nnemo/collections/asr/modules/conv_asr.py:197:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:239:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:399:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:459:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:503:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:507:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:603:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:677:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:689:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:758:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:858:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:881:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:900:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:945:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:969:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:983:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:992:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.nlp.models.nlp_model\nnemo/collections/nlp/models/nlp_model.py:187:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:191:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:196:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:286:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:423:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/nlp_model.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/nlp_model.py:454:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.parts.nlp_overrides\nnemo/collections/nlp/parts/nlp_overrides.py:212:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:217:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:233:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:424:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:510:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:730:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:735:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1001:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1005:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1009:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1066:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1193:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1778:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:381:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:425:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:602:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:618:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:637:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:878:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:997:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:1689:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:1777:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:18:0: W0611: Unused import re (unused-import)\nnemo/collections/nlp/parts/nlp_overrides.py:106:4: W0611: Unused tensorstore imported from megatron.core.dist_checkpointing.strategies (unused-import)\n************* Module nemo.core.classes.common\nnemo/core/classes/common.py:693:0: C0301: Line too long (120/119) (line-too-long)\nnemo/core/classes/common.py:819:0: C0301: Line too long (124/119) (line-too-long)\nnemo/core/classes/common.py:926:0: C0301: Line too long (120/119) (line-too-long)\nnemo/core/classes/common.py:471:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/classes/common.py:567:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/classes/common.py:647:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/classes/common.py:1026:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/common.py:1141:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/common.py:29:0: W0611: Unused Iterable imported from typing (unused-import)\n************* Module nemo.core.classes.modelPT\nnemo/core/classes/modelPT.py:82:0: C0301: Line too long (130/119) (line-too-long)\nnemo/core/classes/modelPT.py:177:0: C0301: Line too long (121/119) (line-too-long)\nnemo/core/classes/modelPT.py:184:0: C0301: Line too long (154/119) (line-too-long)\nnemo/core/classes/modelPT.py:258:0: C0301: Line too long (131/119) (line-too-long)\nnemo/core/classes/modelPT.py:262:0: C0301: Line too long (132/119) (line-too-long)\nnemo/core/classes/modelPT.py:310:0: C0301: Line too long (160/119) (line-too-long)\nnemo/core/classes/modelPT.py:390:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/classes/modelPT.py:1250:0: C0301: Line too long (123/119) (line-too-long)\nnemo/core/classes/modelPT.py:1487:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/classes/modelPT.py:1698:0: C0301: Line too long (128/119) (line-too-long)\nnemo/core/classes/modelPT.py:1717:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/classes/modelPT.py:1727:0: C0301: Line too long (122/119) (line-too-long)\nnemo/core/classes/modelPT.py:1853:0: C0301: Line too long (166/119) (line-too-long)\nnemo/core/classes/modelPT.py:1922:0: C0301: Line too long (120/119) (line-too-long)\nnemo/core/classes/modelPT.py:2076:0: C0301: Line too long (151/119) (line-too-long)\nnemo/core/classes/modelPT.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:878:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:944:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:948:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:955:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1647:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1765:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.core.connectors.save_restore_connector\nnemo/core/connectors/save_restore_connector.py:51:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:208:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:315:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:430:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:435:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:38:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/connectors/save_restore_connector.py:704:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:712:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:720:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:728:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.75/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-11T19:58:01 | 2025-01-10T02:07:28 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11549",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11549",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11549.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11549.patch",
"merged_at": null
} | # What does this PR do ?
Re-do changes in a previously closed PR https://github.com/NVIDIA/NeMo/pull/7812 to add safetensor options when saving and restoring models. as customers requested.
CC @galv
**Collection**: [core,asr,nlp,common]
# Changelog
- Re-do changes in https://github.com/NVIDIA/NeMo/pull/7812 for current main branch
- add nemo.utils.secure.torch_load and nemo.utils.secure.torch_save
- torch.load and torch.save removed from save_restore_connector and alternates of it
- secure.torch_load and torch_save use safetensors when available, however if safe=False torch.load and torch.save are used to allow for backwards compatability
- safe is a named parameter and passed through from save_to and restore_from. The default is safe=False to preserve backwards compatability
- added unit tests to double check backwards compatability and secure functions work correctly.
# Usage
Following usage is copied from https://github.com/NVIDIA/NeMo/pull/7812
When using nemo with untrusted .nemo files this will greatly reduce the potential for the user to be attacked.
```
# Existing usage should be preserved. although the result will include a .safetensor inside the .nemo now as well
model.save_to(save_path=model_save_path)
model.save_to(save_path=model_save_path, safe=False)
# the .nemo will only include the .safetensor.
model.save_to(save_path=model_save_path, safe=True)
# Existing usage should be preserved. although if the .nemo contains a .safetensor, it will be used instead of the pytorch version
model.restore_from(model_save_path)
model.restore_from(save_path=model_save_path, safe=False)
# The restore will fail if a .safetensor isn't available to prevent an untrusted .nemo file from resulting in an exploit
model.restore_from(save_path=model_save_path, safe=True)
```
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11549/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11549/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11548 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11548/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11548/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11548/events | https://github.com/NVIDIA/NeMo/pull/11548 | 2,733,792,409 | PR_kwDOC_bI7s6E52KW | 11,548 | Prevent llama3.1 from using Linear interpolation | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module convert_llama_hf_to_nemo\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:63:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:46:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:77:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_llama_hf_to_nemo.py:127:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.80/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12297156786) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-11T19:23:53 | 2024-12-12T14:44:11 | 2024-12-12T14:44:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11548",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11548",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11548.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11548.patch",
"merged_at": "2024-12-12T14:44:10"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11548/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11548/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11547 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11547/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11547/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11547/events | https://github.com/NVIDIA/NeMo/pull/11547 | 2,733,782,942 | PR_kwDOC_bI7s6E50CF | 11,547 | Disable CP for running Inference using megatron_gpt_eval | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module megatron_gpt_eval\nexamples/nlp/language_modeling/megatron_gpt_eval.py:198:0: C0301: Line too long (124/119) (line-too-long)\nexamples/nlp/language_modeling/megatron_gpt_eval.py:325:0: C0301: Line too long (134/119) (line-too-long)\nexamples/nlp/language_modeling/megatron_gpt_eval.py:148:0: C0115: Missing class docstring (missing-class-docstring)\nexamples/nlp/language_modeling/megatron_gpt_eval.py:162:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/nlp/language_modeling/megatron_gpt_eval.py:171:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/nlp/language_modeling/megatron_gpt_eval.py:294:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/nlp/language_modeling/megatron_gpt_eval.py:321:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12342787347) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-11T19:18:33 | 2024-12-16T22:52:46 | 2024-12-16T22:52:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11547",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11547",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11547.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11547.patch",
"merged_at": "2024-12-16T22:52:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11547/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11547/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11546 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11546/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11546/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11546/events | https://github.com/NVIDIA/NeMo/pull/11546 | 2,733,730,932 | PR_kwDOC_bI7s6E5oaf | 11,546 | Fix typo: LocalNonpersitentObject -> LocalNonpersistentObject | {
"login": "ananthsub",
"id": 2382532,
"node_id": "MDQ6VXNlcjIzODI1MzI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2382532?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ananthsub",
"html_url": "https://github.com/ananthsub",
"followers_url": "https://api.github.com/users/ananthsub/followers",
"following_url": "https://api.github.com/users/ananthsub/following{/other_user}",
"gists_url": "https://api.github.com/users/ananthsub/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ananthsub/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ananthsub/subscriptions",
"organizations_url": "https://api.github.com/users/ananthsub/orgs",
"repos_url": "https://api.github.com/users/ananthsub/repos",
"events_url": "https://api.github.com/users/ananthsub/events{/privacy}",
"received_events_url": "https://api.github.com/users/ananthsub/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.multimodal.models.multimodal_llm.neva.neva_model\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:191:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:192:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:323:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:852:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:865:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:867:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1257:0: C0301: Line too long (194/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1261:0: C0301: Line too long (245/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1308:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1392:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1571:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1694:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:113:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:133:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:146:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:163:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:184:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:187:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:300:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:310:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:507:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:548:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:581:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:610:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:725:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1179:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1185:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1285:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1624:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_gpt_model\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:327:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:367:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:413:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:460:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:791:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1106:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1127:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1337:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1378:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1435:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1616:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1617:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1619:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1790:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1810:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1818:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1839:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1909:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1936:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:140:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:153:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:179:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:198:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:469:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:472:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:701:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:705:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:787:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1177:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1226:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1255:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1448:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1583:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1591:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1600:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1884:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2037:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2044:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2050:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:20:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:28:0: W0611: Unused _DataFetcherWrapper imported from lightning.pytorch.loops.fetchers (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:30:0: W0611: Unused OmegaConf imported from omegaconf (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:72:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:81:4: W0611: Unused megatron.core imported as core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:82:4: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module nemo.collections.nlp.parts.nlp_overrides\nnemo/collections/nlp/parts/nlp_overrides.py:212:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:217:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:233:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:424:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:510:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:730:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:735:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1001:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1005:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1009:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1066:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1193:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1775:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:381:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:425:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:602:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:618:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:637:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:878:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:997:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:1686:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:1774:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:18:0: W0611: Unused import re (unused-import)\nnemo/collections/nlp/parts/nlp_overrides.py:106:4: W0611: Unused tensorstore imported from megatron.core.dist_checkpointing.strategies (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-11T18:50:46 | 2024-12-12T19:11:04 | 2024-12-12T19:11:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11546",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11546",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11546.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11546.patch",
"merged_at": "2024-12-12T19:11:00"
} | # What does this PR do ?
Cleanup typos in megatron core dist checkpointing imports. This PR introduces no functional changes since Megatron exposes this alias entirely for NeMo at the moment: https://github.com/NVIDIA/Megatron-LM/blob/371feef2b7dd619038bdacb82fe0e195ebad67ee/megatron/core/dist_checkpointing/mapping.py#L518-L519
After this PR, that alias^ can be removed from Megatron
**Collection**: nlp, multimodal
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ananthsub",
"id": 2382532,
"node_id": "MDQ6VXNlcjIzODI1MzI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2382532?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ananthsub",
"html_url": "https://github.com/ananthsub",
"followers_url": "https://api.github.com/users/ananthsub/followers",
"following_url": "https://api.github.com/users/ananthsub/following{/other_user}",
"gists_url": "https://api.github.com/users/ananthsub/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ananthsub/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ananthsub/subscriptions",
"organizations_url": "https://api.github.com/users/ananthsub/orgs",
"repos_url": "https://api.github.com/users/ananthsub/repos",
"events_url": "https://api.github.com/users/ananthsub/events{/privacy}",
"received_events_url": "https://api.github.com/users/ananthsub/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11546/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11546/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11545 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11545/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11545/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11545/events | https://github.com/NVIDIA/NeMo/pull/11545 | 2,733,609,181 | PR_kwDOC_bI7s6E5Nbv | 11,545 | ci: Cmmit sha for cutoff | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-11T17:48:36 | 2024-12-11T17:49:06 | 2024-12-11T17:49:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11545",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11545",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11545.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11545.patch",
"merged_at": "2024-12-11T17:49:05"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11545/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11545/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11544 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11544/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11544/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11544/events | https://github.com/NVIDIA/NeMo/pull/11544 | 2,733,428,542 | PR_kwDOC_bI7s6E4lcl | 11,544 | ci: Bump release workflow | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-11T16:26:31 | 2024-12-11T16:27:09 | 2024-12-11T16:27:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11544",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11544",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11544.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11544.patch",
"merged_at": "2024-12-11T16:27:06"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11544/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11544/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11543 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11543/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11543/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11543/events | https://github.com/NVIDIA/NeMo/pull/11543 | 2,733,317,555 | PR_kwDOC_bI7s6E4M8d | 11,543 | NeMo 2.0 vLLM export | {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"> Were you able to test this with a nemo 2 ckpt?\r\n\r\nYep, that's the very point here. Model types tested are Llama, Mixtral, Gemma, StarCoder2 to keep vLLM supported models parity with 24.07 release https://docs.nvidia.com/nemo-framework/user-guide/24.07/deployment/llm/optimized/index.html",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.sentencepiece_tokenizer\nnemo/export/sentencepiece_tokenizer.py:249:0: C0301: Line too long (137/119) (line-too-long)\nnemo/export/sentencepiece_tokenizer.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:97:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:126:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:132:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:199:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:207:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:215:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:230:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:237:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:244:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:256:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:266:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:279:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:164:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:196:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:207:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:211:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:238:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:249:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:270:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:365:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:483:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:570:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:574:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:585:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:597:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:637:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:674:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:687:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:25:0: W0611: Unused import tensorstore (unused-import)\n************* Module nemo.export.vllm.engine\nnemo/export/vllm/engine.py:38:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/vllm/engine.py:41:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/vllm/engine.py:45:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.vllm.model_converters\nnemo/export/vllm/model_converters.py:61:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/vllm/model_converters.py:124:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/vllm/model_converters.py:193:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/vllm/model_converters.py:274:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.export.vllm.model_loader\nnemo/export/vllm/model_loader.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/vllm/model_loader.py:24:0: W0611: Unused import tensorstore (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.53/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @Laplasjan107 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12751055699) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-11T15:39:39 | 2025-01-13T17:50:56 | 2025-01-13T17:50:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11543",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11543",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11543.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11543.patch",
"merged_at": "2025-01-13T17:50:55"
} | # What does this PR do ?
vLLM export for NeMo 2.0 models
**Collection**: llm
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
The vLLM export needs to be run in the virtual environment, installed inside the NeMo container:
``` bash
source /opt/venv/bin/activate
```
Sample vLLM script for export:
```python
from nemo.export.vllm_exporter import vLLMExporter
import os, os.path
import argparse
def get_args():
parser = argparse.ArgumentParser(
formatter_class=argparse.ArgumentDefaultsHelpFormatter,
description="vLLM export argument parser",
)
parser.add_argument("--nc", type=str)
parser.add_argument("--tps", type=int)
parser.add_argument("--mt", type=str)
args = parser.parse_args()
args.export_path = f"/tmp/vllm_{args.mt}_tps{args.tps}"
return args
args = get_args()
if not os.path.exists(args.export_path):
os.mkdir(args.export_path)
exporter = vLLMExporter()
exporter.export(
nemo_checkpoint=args.nc,
model_dir=args.export_path,
model_type=args.mt,
tensor_parallel_size=args.tps,
)
output = exporter.forward(["What is the best city in the world?"], max_output_len=50, top_k=1, top_p=0.0, temperature=1.0)
print("output: ", output)
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11543/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11543/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11542 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11542/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11542/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11542/events | https://github.com/NVIDIA/NeMo/pull/11542 | 2,733,154,409 | PR_kwDOC_bI7s6E3o0N | 11,542 | Add option to split shards between ranks/workers for transcribe_speech_parallel.py | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module transcribe_speech_parallel\nexamples/asr/transcribe_speech_parallel.py:25:0: C0301: Line too long (161/119) (line-too-long)\nexamples/asr/transcribe_speech_parallel.py:53:0: C0301: Line too long (121/119) (line-too-long)\nexamples/asr/transcribe_speech_parallel.py:102:0: C0301: Line too long (142/119) (line-too-long)\nexamples/asr/transcribe_speech_parallel.py:156:0: C0301: Line too long (126/119) (line-too-long)\nexamples/asr/transcribe_speech_parallel.py:230:0: C0301: Line too long (128/119) (line-too-long)\nexamples/asr/transcribe_speech_parallel.py:95:0: C0115: Missing class docstring (missing-class-docstring)\nexamples/asr/transcribe_speech_parallel.py:118:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/asr/transcribe_speech_parallel.py:147:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/asr/transcribe_speech_parallel.py:88:0: W0611: Unused GreedyBatchedRNNTInferConfig imported from nemo.collections.asr.parts.submodules.rnnt_greedy_decoding (unused-import)\n************* Module nemo.collections.common.data.lhotse.cutset\nnemo/collections/common/data/lhotse/cutset.py:557:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/common/data/lhotse/cutset.py:148:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:186:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:197:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:210:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:216:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:261:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:369:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/cutset.py:417:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.common.data.lhotse.dataloader\nnemo/collections/common/data/lhotse/dataloader.py:112:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:128:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:136:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:233:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:234:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:235:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:579:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:719:0: C0301: Line too long (213/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:726:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:171:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:428:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:479:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:515:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:518:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:521:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:530:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:532:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:535:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:541:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:569:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:584:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:591:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:606:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.common.data.lhotse.nemo_adapters\nnemo/collections/common/data/lhotse/nemo_adapters.py:48:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/common/data/lhotse/nemo_adapters.py:278:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/common/data/lhotse/nemo_adapters.py:279:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/common/data/lhotse/nemo_adapters.py:348:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:495:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:499:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:508:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:513:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:517:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:521:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:543:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:565:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:587:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/nemo_adapters.py:23:0: W0611: Unused import lhotse.serialization (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.36/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-11T14:35:40 | 2025-01-02T01:57:53 | 2025-01-02T01:57:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11542",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11542",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11542.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11542.patch",
"merged_at": null
} | # What does this PR do ?
Should allow `transcribe_speech_parallel.py` to produce results that are not duplicated.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11542/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11542/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11541 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11541/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11541/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11541/events | https://github.com/NVIDIA/NeMo/issues/11541 | 2,732,538,613 | I_kwDOC_bI7s6i3zr1 | 11,541 | FilterbankFeatures may return NaNs on CUDA device - torch autocast problem | {
"login": "yoadsn",
"id": 1684709,
"node_id": "MDQ6VXNlcjE2ODQ3MDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1684709?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yoadsn",
"html_url": "https://github.com/yoadsn",
"followers_url": "https://api.github.com/users/yoadsn/followers",
"following_url": "https://api.github.com/users/yoadsn/following{/other_user}",
"gists_url": "https://api.github.com/users/yoadsn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yoadsn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yoadsn/subscriptions",
"organizations_url": "https://api.github.com/users/yoadsn/orgs",
"repos_url": "https://api.github.com/users/yoadsn/repos",
"events_url": "https://api.github.com/users/yoadsn/events{/privacy}",
"received_events_url": "https://api.github.com/users/yoadsn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"Still a bug, still requires attention."
] | 2024-12-11T10:39:13 | 2025-01-12T02:04:13 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When autocast region is enabled, the FilterbankFeatures featurizer, during the forward pass may generate NaN frames.
**Steps/Code to reproduce bug**
As probably is known, on CUDA devices, matmul operations are cast to half when feature compat allows for this data type.
So the following is expected:
```
device = torch.device("cuda" if torch.cuda.is_available() else "cpu") # Assume "cuda" is available
with torch.amp.autocast(device.type):
f = torch.tensor([0.0], dtype=torch.float32).to(device)
x1 = torch.tensor([65519], dtype=torch.float32).to(device)
r1 = torch.matmul(f, x1)
print(r1) # OK - returns 0 tensor
x2 = torch.tensor([65520], dtype=torch.float32).to(device)
r2 = torch.matmul(f, x2)
print(r2) # Oops - returns NaN tensor
```
This is not a bug, just the behavior of autocast with an F16 capable GPU. The mamul operations is done in f16, 65520 is a NaN with this data type.
Here is a repro of the bug though:
```
import torch
from nemo.collections.asr.parts.utils.vad_utils import init_frame_vad_model
device = torch.device("cuda" if torch.cuda.is_available() else "cpu") # Assume "cuda" is available
if __name__ == "__main__":
vad_model = init_frame_vad_model("vad_multilingual_frame_marblenet")
vad_model = vad_model.to(device)
vad_model.eval()
x = torch.tensor(
[
-0.9058,-0.5946,1.2434,-0.3962,-1.7921,2.4021,-1.4928,-0.0365,0.4774,0.2091,-2.2784,2.6600,
-1.1311,-2.3960,4.6964,-4.2161,0.3519,2.6062,-3.5229,1.2587,1.6692,-4.6367,4.4893,-2.8256,
-0.9259,3.5737,-4.0703,2.4223,-0.2424,-2.2224,1.6835,0.1224,-2.6710,3.6783,-3.3401,0.8552,
1.9303,-4.3002,4.6046,-4.0270,0.7077,2.5835,-4.6308,3.4596,-0.4729,-2.3140,2.9415,-2.1423,
-0.4900,2.3685,-3.8594,2.8201,-0.0154,-2.5574,4.3913,0.0000,
], # chose those numbers since they produce the wanted stft result which would trigger the casting problem
dtype=torch.float32,
)
x = torch.concatenate([x, torch.zeros(257 - x.shape[0])], axis=0) # pad up to minimal input signal size with zeroes
x = x.unsqueeze(0).to(device)
seq_len = torch.tensor([x.shape[1]], dtype=x.dtype).to(device)
with torch.amp.autocast(vad_model.device.type):
r, s = vad_model.preprocessor.featurizer(x, seq_len) # this internally does the matmul
print(torch.isnan(r).cpu().any().item()) # We get a True here - there is a NaN in the result
```
I know the numbers seem arbitrary - I pulled them from an audio sample that had the problem - but on my audio dataset we get 1-2 NaN situations per 10 min segment - so it's not that rare.
Audio comes from MP3 files, perhaps this produces artifacts in the STFT output - still, NaN should not be reasonable output feature in any case.
**Expected behavior**
Non NaN features produced if no NaN audio signal is presented.
**Environment overview (please complete the following information)**
- Environment location: Cloud, AWS EC2 instance, (g4dn.xlarge, T4 GPU) , AMI: NVIDIA GPU Cloud VMI Base 2024.10.1 x86_64-676eed8d-dcf5-4784-87d7-0de463205c17
- Method of NeMo install: pip install using `nemo_toolkit[asr]`
**Environment details**
OS Version: Linux ip-172-31-47-154 6.8.0-1017-aws _18~22.04.1-Ubuntu SMP Thu Oct 3 19:57:42 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Python Version: Python 3.10.12
PyTorch Version: 2.5.1+cu124
CUDA Version: 12.4
**Additional context**
I would like to explain the cause of the bug.
The FilterbankFeatures forward has the following [code](https://github.com/NVIDIA/NeMo/blob/5452848750fc47ff0a055beab8fe4ee3b789fcdf/nemo/collections/asr/parts/preprocessing/features.py#L419C28-L490C26) (removed parts for brevity):
```
def forward(self, x, seq_len, linear_spec=False):
seq_len = self.get_seq_len(seq_len)
# ... parts removed
# disable autocast to get full range of stft values
#=>>
with torch.amp.autocast(x.device.type, enabled=False):
x = self.stft(x)
# torch stft returns complex tensor (of shape [B,N,T]); so convert to magnitude
# guard is needed for sqrt if grads are passed through
guard = 0 if not self.use_grads else CONSTANT
x = torch.view_as_real(x)
x = torch.sqrt(x.pow(2).sum(-1) + guard)
# ... parts removed
# dot with filterbank energies
#=>>
x = torch.matmul(self.fb.to(x.dtype), x)
# ... parts removed
return x, seq_len
```
Note the two highlighted sections.
The first, disabled the autocast - so the stftf can get "the full range" of values. This on my GPU produces a float64.
Later operations until the second marked tow operate in float32.
The second row does a matmul, this, in many cases operates within an *active* autocast region - and will, on my GPU downcast to f16.
When x contains values which are outside f16 range, the matmul produces unexpected results, among them are NaN results.
On such scenario, is the Frame VAD inference, where the vad util activates an autocast region around the inference, and the vad model will internally, before inference featurize the raw audio signal.
Here is the util, as an example that activates the autocast region from the NeMo repo (`generate_vad_frame_pred`) [code](https://github.com/NVIDIA/NeMo/blob/5452848750fc47ff0a055beab8fe4ee3b789fcdf/nemo/collections/asr/parts/utils/vad_utils.py#L1138).
One solution I suggest - and that I locally tested with a patch to NeMo code seems to work is to exclude that matmul itseld from the autocast.
```diff
# dot with filterbank energies
+ with torch.amp.autocast(x.device.type, enabled=False):
x = torch.matmul(self.fb.to(x.dtype), x)
```
And right after that, clip the values or otherwise ensure no downstream downcasting impacts those values.
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11541/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11541/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11540 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11540/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11540/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11540/events | https://github.com/NVIDIA/NeMo/pull/11540 | 2,732,209,130 | PR_kwDOC_bI7s6E0Wp9 | 11,540 | removed pipeline_dtype from MegatronStategy's ctor | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.98/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-11T08:20:00 | 2024-12-11T16:31:54 | 2024-12-11T16:31:54 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11540",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11540",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11540.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11540.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11540/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11540/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11539 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11539/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11539/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11539/events | https://github.com/NVIDIA/NeMo/pull/11539 | 2,731,526,407 | PR_kwDOC_bI7s6EyBxw | 11,539 | chore(beep boop 🤖): Bump `MCORE_TAG=d4e72c0...` (2024-12-11) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-11T00:24:39 | 2025-01-01T02:03:22 | 2025-01-01T02:03:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11539",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11539",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11539.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11539.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=d4e72c0d33edc0c53aeb624f617eb77cebce6ae9`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11539/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11539/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11538 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11538/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11538/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11538/events | https://github.com/NVIDIA/NeMo/pull/11538 | 2,731,397,672 | PR_kwDOC_bI7s6ExlSa | 11,538 | Link to mcore `StrictHandling` documentation | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.98/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ashors1 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12266989931) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-10T22:59:56 | 2024-12-11T18:49:27 | 2024-12-11T18:49:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11538",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11538",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11538.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11538.patch",
"merged_at": "2024-12-11T18:49:25"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11538/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11538/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11537 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11537/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11537/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11537/events | https://github.com/NVIDIA/NeMo/pull/11537 | 2,731,013,755 | PR_kwDOC_bI7s6EwR3B | 11,537 | Update for NEST release | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.ssl_models\nnemo/collections/asr/models/ssl_models.py:64:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/ssl_models.py:65:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/models/ssl_models.py:71:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ssl_models.py:72:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ssl_models.py:618:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/models/ssl_models.py:521:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ssl_models.py:564:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ssl_models.py:597:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ssl_models.py:753:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ssl_models.py:776:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.modules.ssl_modules.multi_layer_feat\nnemo/collections/asr/modules/ssl_modules/multi_layer_feat.py:27:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/ssl_modules/multi_layer_feat.py:84:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/ssl_modules/multi_layer_feat.py:162:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.core.classes.modelPT\nnemo/core/classes/modelPT.py:82:0: C0301: Line too long (130/119) (line-too-long)\nnemo/core/classes/modelPT.py:177:0: C0301: Line too long (121/119) (line-too-long)\nnemo/core/classes/modelPT.py:184:0: C0301: Line too long (154/119) (line-too-long)\nnemo/core/classes/modelPT.py:258:0: C0301: Line too long (131/119) (line-too-long)\nnemo/core/classes/modelPT.py:262:0: C0301: Line too long (132/119) (line-too-long)\nnemo/core/classes/modelPT.py:310:0: C0301: Line too long (160/119) (line-too-long)\nnemo/core/classes/modelPT.py:390:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/classes/modelPT.py:1241:0: C0301: Line too long (123/119) (line-too-long)\nnemo/core/classes/modelPT.py:1478:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/classes/modelPT.py:1689:0: C0301: Line too long (128/119) (line-too-long)\nnemo/core/classes/modelPT.py:1708:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/classes/modelPT.py:1718:0: C0301: Line too long (122/119) (line-too-long)\nnemo/core/classes/modelPT.py:1844:0: C0301: Line too long (166/119) (line-too-long)\nnemo/core/classes/modelPT.py:1913:0: C0301: Line too long (120/119) (line-too-long)\nnemo/core/classes/modelPT.py:2067:0: C0301: Line too long (151/119) (line-too-long)\nnemo/core/classes/modelPT.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:869:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:935:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:939:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:946:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1214:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1638:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1756:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.83/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-10T19:31:55 | 2024-12-12T15:45:48 | 2024-12-12T15:45:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11537",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11537",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11537.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11537.patch",
"merged_at": "2024-12-12T15:45:48"
} | # What does this PR do ?
1. Add script for extracting embeddings from different layers of NEST model (also works for other Conformer-based models).
2. Fixes ModelPT.py when defer_setup is True, since the current code will skip builing validation dataloaders as they are lists and not None.
3. Update ASR manifest processor to allow `duration=None`
4. Minor documentation update.
**Collection**: [asr,core]
| {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11537/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11537/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11536 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11536/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11536/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11536/events | https://github.com/NVIDIA/NeMo/issues/11536 | 2,730,976,284 | I_kwDOC_bI7s6ix2Qc | 11,536 | Does Nemo support soft targets or doing regression? | {
"login": "m-harmonic",
"id": 148120204,
"node_id": "U_kgDOCNQijA",
"avatar_url": "https://avatars.githubusercontent.com/u/148120204?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/m-harmonic",
"html_url": "https://github.com/m-harmonic",
"followers_url": "https://api.github.com/users/m-harmonic/followers",
"following_url": "https://api.github.com/users/m-harmonic/following{/other_user}",
"gists_url": "https://api.github.com/users/m-harmonic/gists{/gist_id}",
"starred_url": "https://api.github.com/users/m-harmonic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/m-harmonic/subscriptions",
"organizations_url": "https://api.github.com/users/m-harmonic/orgs",
"repos_url": "https://api.github.com/users/m-harmonic/repos",
"events_url": "https://api.github.com/users/m-harmonic/events{/privacy}",
"received_events_url": "https://api.github.com/users/m-harmonic/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-10T19:11:39 | 2025-01-18T01:54:16 | 2025-01-18T01:54:15 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
I'm trying to do supervised learning given labeled data of an input token sequence mapping to a probability output. Does Nemo support a simple way to do this? For example, via soft targets (predicting one of two tokens each with a certain probability that sums to 1) as opposed to 1-hot vectors, or otherwise doing regression for a continuous value?
**Describe the solution you'd like**
Some modification to standard SFT training for example.
**Describe alternatives you've considered**
Have tried looking at distillation as a proxy, where the probabilities imitate the logits produced by a teacher model. But this is quite cumbersome.
**Additional context**
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11536/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11536/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11535 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11535/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11535/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11535/events | https://github.com/NVIDIA/NeMo/pull/11535 | 2,730,560,628 | PR_kwDOC_bI7s6EusZc | 11,535 | Add BERT Embedding model | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.bert.data.core\nnemo/collections/llm/bert/data/core.py:25:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/bert/data/core.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.bert.data.specter\nnemo/collections/llm/bert/data/specter.py:34:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/bert/data/specter.py:39:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/llm/bert/data/specter.py:40:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/bert/data/specter.py:101:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/llm/bert/data/specter.py:78:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/bert/data/specter.py:134:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/bert/data/specter.py:16:0: W0611: Unused lru_cache imported from functools (unused-import)\n************* Module nemo.collections.llm.bert.model.embedding\nnemo/collections/llm/bert/model/embedding.py:65:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/bert/model/embedding.py:158:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/bert/model/embedding.py:7:0: W0611: Unused InferenceParams imported from megatron.core (unused-import)\nnemo/collections/llm/bert/model/embedding.py:7:0: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/llm/bert/model/embedding.py:11:0: W0611: Unused BERTLossReduction imported from nemo.collections.llm.bert.loss (unused-import)\nnemo/collections/llm/bert/model/embedding.py:12:0: W0611: Unused HuggingFaceBertModel imported from nemo.collections.llm.bert.model (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.74/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:605:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.io.api\nnemo/lightning/io/api.py:39:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/io/api.py:171:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.95/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-10T16:12:43 | 2025-01-02T01:57:54 | 2025-01-02T01:57:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11535",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11535",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11535.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11535.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11535/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11535/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11534 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11534/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11534/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11534/events | https://github.com/NVIDIA/NeMo/pull/11534 | 2,730,525,486 | PR_kwDOC_bI7s6EukpQ | 11,534 | Add BERT Embedding Model | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.bert.data.core\nnemo/collections/llm/bert/data/core.py:25:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/bert/data/core.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.bert.data.specter\nnemo/collections/llm/bert/data/specter.py:34:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/bert/data/specter.py:39:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/llm/bert/data/specter.py:40:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/llm/bert/data/specter.py:101:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/llm/bert/data/specter.py:78:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/bert/data/specter.py:134:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/bert/data/specter.py:16:0: W0611: Unused lru_cache imported from functools (unused-import)\n************* Module nemo.collections.llm.bert.model.embedding\nnemo/collections/llm/bert/model/embedding.py:65:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/bert/model/embedding.py:158:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/bert/model/embedding.py:7:0: W0611: Unused InferenceParams imported from megatron.core (unused-import)\nnemo/collections/llm/bert/model/embedding.py:7:0: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/llm/bert/model/embedding.py:12:0: W0611: Unused HuggingFaceBertModel imported from nemo.collections.llm.bert.model (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.69/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:605:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.io.api\nnemo/lightning/io/api.py:39:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/io/api.py:171:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.97/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-10T15:57:16 | 2024-12-10T16:12:32 | 2024-12-10T16:12:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11534",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11534",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11534.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11534.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11534/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11534/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11533 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11533/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11533/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11533/events | https://github.com/NVIDIA/NeMo/pull/11533 | 2,730,161,216 | PR_kwDOC_bI7s6EtVDE | 11,533 | Sync validation metrics for ASRModel | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.asr_model\nnemo/collections/asr/models/asr_model.py:280:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/asr_model.py:33:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.core.classes.modelPT\nnemo/core/classes/modelPT.py:82:0: C0301: Line too long (130/119) (line-too-long)\nnemo/core/classes/modelPT.py:177:0: C0301: Line too long (121/119) (line-too-long)\nnemo/core/classes/modelPT.py:184:0: C0301: Line too long (154/119) (line-too-long)\nnemo/core/classes/modelPT.py:258:0: C0301: Line too long (131/119) (line-too-long)\nnemo/core/classes/modelPT.py:262:0: C0301: Line too long (132/119) (line-too-long)\nnemo/core/classes/modelPT.py:310:0: C0301: Line too long (160/119) (line-too-long)\nnemo/core/classes/modelPT.py:390:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/classes/modelPT.py:1232:0: C0301: Line too long (123/119) (line-too-long)\nnemo/core/classes/modelPT.py:1469:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/classes/modelPT.py:1680:0: C0301: Line too long (128/119) (line-too-long)\nnemo/core/classes/modelPT.py:1699:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/classes/modelPT.py:1709:0: C0301: Line too long (122/119) (line-too-long)\nnemo/core/classes/modelPT.py:1835:0: C0301: Line too long (166/119) (line-too-long)\nnemo/core/classes/modelPT.py:1904:0: C0301: Line too long (120/119) (line-too-long)\nnemo/core/classes/modelPT.py:2058:0: C0301: Line too long (151/119) (line-too-long)\nnemo/core/classes/modelPT.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:869:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:926:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:930:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:937:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1205:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1629:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1747:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.73/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @pzelasko 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12263868034) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-10T13:42:05 | 2024-12-12T18:07:36 | 2024-12-12T18:07:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11533",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11533",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11533.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11533.patch",
"merged_at": "2024-12-12T18:07:34"
} | # What does this PR do ?
Synchronizes validation metrics across DDP ranks at the end of validation epoch. Fixes critical issue with corrupted checkpoints for multi-GPU Canary runs. Follows up on https://github.com/NVIDIA/NeMo/pull/10257
**Collection**: ASR
# Changelog
- Multi-GPU validation metric sync for ASR models
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11533/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11533/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11532 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11532/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11532/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11532/events | https://github.com/NVIDIA/NeMo/pull/11532 | 2,729,960,195 | PR_kwDOC_bI7s6Esoe0 | 11,532 | Fix mixtral export for NeMo 2.0 | {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:73:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:96:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:104:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:114:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:127:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:138:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:169:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:176:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:190:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:194:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:203:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:228:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:239:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:260:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:315:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:361:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:445:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:449:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:460:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:472:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:549:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:562:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:27:0: W0611: Unused import tensorstore (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.27/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @Laplasjan107 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12255938167) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-10T12:14:34 | 2024-12-10T22:59:03 | 2024-12-10T22:59:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11532",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11532",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11532.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11532.patch",
"merged_at": "2024-12-10T22:59:02"
} | # What does this PR do ?
Fixes export of NeMo 2.0 mixtral
**Collection**: nlp/llm
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11532/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11532/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11531 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11531/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11531/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11531/events | https://github.com/NVIDIA/NeMo/issues/11531 | 2,729,832,549 | I_kwDOC_bI7s6itfBl | 11,531 | Support Pipeline Parallel in Knowledge Distillation | {
"login": "zhaoyang-star",
"id": 24290792,
"node_id": "MDQ6VXNlcjI0MjkwNzky",
"avatar_url": "https://avatars.githubusercontent.com/u/24290792?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zhaoyang-star",
"html_url": "https://github.com/zhaoyang-star",
"followers_url": "https://api.github.com/users/zhaoyang-star/followers",
"following_url": "https://api.github.com/users/zhaoyang-star/following{/other_user}",
"gists_url": "https://api.github.com/users/zhaoyang-star/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zhaoyang-star/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhaoyang-star/subscriptions",
"organizations_url": "https://api.github.com/users/zhaoyang-star/orgs",
"repos_url": "https://api.github.com/users/zhaoyang-star/repos",
"events_url": "https://api.github.com/users/zhaoyang-star/events{/privacy}",
"received_events_url": "https://api.github.com/users/zhaoyang-star/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Hi @zhaoyang-star,\n\nPP will be available soon. First in [Megatron-LM](https://github.com/NVIDIA/Megatron-LM) then followed by NeMo immediately afterwards.\n\nPytorch FSDP is supported for [Model Optimizer](https://github.com/NVIDIA/TensorRT-Model-Optimizer) based distillation in general, though the NeMo FSDP strategy has not been looked into yet and I cannot provide an ETA right now.\n\nThank you for the interest!",
"@AAnoosheh Thanks for your great work! Recently I used distillation on NeMo. It realy help me a lot. \nJust one more question, how to record `kd_loss` in the tensorboard? `reduced_train_loss` is already recorded on tensorboard. I tried to print `kd_loss` in `/usr/local/lib/python3.10/dist-packages/modelopt/torch/distill/loss_balancers.py` but got no output info.\n\n```python\n aggregate_loss = sum(\n loss * weight for loss, weight in zip(kd_loss_dict.values(), self._kd_loss_weight)\n )\n kd_loss = aggregate_loss\n if output_loss is not None:\n aggregate_loss += (1.0 - sum(self._kd_loss_weight)) * output_loss\n # use 3 ways\n print(f\"total_loss: {aggregate_loss}, ce_loss: {output_loss}, kd_loss: {kd_loss}\", flush=True)\n print_rank_0(f\"total_loss: {aggregate_loss}, ce_loss: {output_loss}, kd_loss: {kd_loss}\")\n logging.info(f\"total_loss: {aggregate_loss}, ce_loss: {output_loss}, kd_loss: {kd_loss}\")\n\n return aggregate_loss\n```\n",
"Hi, I need to look into that and see how NeMo's logging works, thanks for letting me know.",
"> Hi, I need to look into that and see how NeMo's logging works, thanks for letting me know.\n\n@AAnoosheh Realy thanks for your quick reply. There is few info when google it. Recently I tried to use NeMo Distillation API to train a 8B model and met these 2 problems. The main problem is **the trainning time per step is very high**, which is ~ 150TFLOPs (TP is enabled) per GPU. While the performance is 490TFLOPs per GPU (PP is enabled) when pretrain it from scratch. I guess it is because NeMo Distillation API only support TP. The machine I used is H800, which the intra bandwidth is half of the H100.\n\nLooking forward to your feedback.",
"> Hi [@zhaoyang-star](https://github.com/zhaoyang-star),\n> \n> PP will be available soon. First in [Megatron-LM](https://github.com/NVIDIA/Megatron-LM) then followed by NeMo immediately afterwards.\n> \n> Pytorch FSDP is supported for [Model Optimizer](https://github.com/NVIDIA/TensorRT-Model-Optimizer) based distillation in general, though the NeMo FSDP strategy has not been looked into yet and I cannot provide an ETA right now.\n> \n> Thank you for the interest!\n\n@AAnoosheh Hi, may I inquire if there is a roadmap or ETA for Knowledge Distillation in Megatron-LM? I've noticed that there is currently no support for KD in Megatron-LM."
] | 2024-12-10T11:20:47 | 2024-12-23T08:12:20 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | As the [nemo-docs](https://docs.nvidia.com/nemo-framework/user-guide/latest/model-optimization/distillation/distillation.html) says, there are limitations of KD impl in NeMo:
- Only Megatron Core-based GPT models are supported
- Only logit-pair distillation is supported for now
- Pipeline parallelism not yet supported
- FSDP strategy not yet supported
For the 3rd and 4th, both of them are very important features for KD as the teacher model is much larger. TP may cause less training throughput than PP. So will the 2 features be in Roadmap? Thanks. @AAnoosheh @ko3n1g | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11531/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11531/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11529 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11529/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11529/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11529/events | https://github.com/NVIDIA/NeMo/issues/11529 | 2,728,895,398 | I_kwDOC_bI7s6ip6Om | 11,529 | How can i get cache streaming on Fastconformer-ctc nemo? | {
"login": "PhamDangNguyen",
"id": 86046279,
"node_id": "MDQ6VXNlcjg2MDQ2Mjc5",
"avatar_url": "https://avatars.githubusercontent.com/u/86046279?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PhamDangNguyen",
"html_url": "https://github.com/PhamDangNguyen",
"followers_url": "https://api.github.com/users/PhamDangNguyen/followers",
"following_url": "https://api.github.com/users/PhamDangNguyen/following{/other_user}",
"gists_url": "https://api.github.com/users/PhamDangNguyen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PhamDangNguyen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PhamDangNguyen/subscriptions",
"organizations_url": "https://api.github.com/users/PhamDangNguyen/orgs",
"repos_url": "https://api.github.com/users/PhamDangNguyen/repos",
"events_url": "https://api.github.com/users/PhamDangNguyen/events{/privacy}",
"received_events_url": "https://api.github.com/users/PhamDangNguyen/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-10T03:36:49 | 2025-01-18T01:54:17 | 2025-01-18T01:54:16 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Recently I'm looking for a streaming algorithm for Fastconformer-ctc but I only find the streaming for stt_en_fastconformer_hybrid_large_streaming (refer in https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/Online_ASR_Microphone_Demo_Cache_Aware_Streaming.ipynb). How I can find the cache streaming of Fastconformer-ctc ? thanks ! | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11529/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11529/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11528 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11528/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11528/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11528/events | https://github.com/NVIDIA/NeMo/pull/11528 | 2,728,657,658 | PR_kwDOC_bI7s6EoGUg | 11,528 | add stdit model | {
"login": "Kangkang-wky",
"id": 130197741,
"node_id": "U_kgDOB8Ko7Q",
"avatar_url": "https://avatars.githubusercontent.com/u/130197741?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kangkang-wky",
"html_url": "https://github.com/Kangkang-wky",
"followers_url": "https://api.github.com/users/Kangkang-wky/followers",
"following_url": "https://api.github.com/users/Kangkang-wky/following{/other_user}",
"gists_url": "https://api.github.com/users/Kangkang-wky/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kangkang-wky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kangkang-wky/subscriptions",
"organizations_url": "https://api.github.com/users/Kangkang-wky/orgs",
"repos_url": "https://api.github.com/users/Kangkang-wky/repos",
"events_url": "https://api.github.com/users/Kangkang-wky/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kangkang-wky/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.diffusion.models.stdit.spatial_attention\nnemo/collections/diffusion/models/stdit/spatial_attention.py:115:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.diffusion.models.stdit.stdit_embeddings\nnemo/collections/diffusion/models/stdit/stdit_embeddings.py:163:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_embeddings.py:435:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_embeddings.py:450:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_embeddings.py:5:0: W0611: Unused numpy imported as np (unused-import)\n************* Module nemo.collections.diffusion.models.stdit.stdit_layer_spec\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:55:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:58:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:73:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:76:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:90:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:445:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:132:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:141:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:145:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:149:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:165:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:171:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/stdit/stdit_layer_spec.py:3:0: W0611: Unused Literal imported from typing (unused-import)\n************* Module nemo.collections.diffusion.models.stdit.stdit_model\nnemo/collections/diffusion/models/stdit/stdit_model.py:41:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/diffusion/models/stdit/stdit_model.py:42:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/diffusion/models/stdit/stdit_model.py:2:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/diffusion/models/stdit/stdit_model.py:6:0: W0611: Unused torch.nn imported as nn (unused-import)\nnemo/collections/diffusion/models/stdit/stdit_model.py:8:0: W0611: Unused parallel_state imported from megatron.core (unused-import)\nnemo/collections/diffusion/models/stdit/stdit_model.py:9:0: W0611: Unused ShardedStateDict imported from megatron.core.dist_checkpointing.mapping (unused-import)\nnemo/collections/diffusion/models/stdit/stdit_model.py:17:0: W0611: Unused make_sharded_tensor_for_checkpoint imported from megatron.core.utils (unused-import)\n************* Module nemo.collections.diffusion.data.diffusion_fake_datamodule\nnemo/collections/diffusion/data/diffusion_fake_datamodule.py:147:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/data/diffusion_fake_datamodule.py:267:0: C0115: Missing class docstring (missing-class-docstring)\n\n-----------------------------------\nYour code has been rated at 9.56/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.diffusion.models.model\nnemo/collections/diffusion/models/model.py:77:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/model.py:410:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/model.py:420:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/model.py:430:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/model.py:465:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/model.py:487:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.diffusion.train\nnemo/collections/diffusion/train.py:99:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/train.py:240:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/train.py:275:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/train.py:540:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/train.py:33:0: W0611: Unused STDiT3BConfig imported from nemo.collections.diffusion.models.model (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.83/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-10T01:00:01 | 2025-01-08T03:42:04 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11528",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11528",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11528.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11528.patch",
"merged_at": null
} | # What does this PR do ?
Add STDiT(Spatial-Temporal DiT) model for nemo training. Support megatron parallel pattern in training pipeline.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add stdit model
- Add stdit layer
- Add stdit embedding
- Add stdit training factory function
- Support tp/sp/cp/dsp/pp/fsdp parallel pattern
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11528/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11528/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11527 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11527/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11527/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11527/events | https://github.com/NVIDIA/NeMo/pull/11527 | 2,728,614,208 | PR_kwDOC_bI7s6En8yz | 11,527 | chore(beep boop 🤖): Bump `MCORE_TAG=d4e72c0...` (2024-12-10) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-10T00:24:59 | 2025-01-01T02:03:24 | 2025-01-01T02:03:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11527",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11527",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11527.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11527.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=d4e72c0d33edc0c53aeb624f617eb77cebce6ae9`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11527/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11527/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11526 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11526/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11526/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11526/events | https://github.com/NVIDIA/NeMo/pull/11526 | 2,728,611,875 | PR_kwDOC_bI7s6En8Sr | 11,526 | [TTS] Add audio and mel codec HF models to docs | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @rlangman 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12290431792) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-10T00:22:40 | 2024-12-12T15:05:43 | 2024-12-12T15:05:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11526",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11526",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11526.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11526.patch",
"merged_at": "2024-12-12T15:05:41"
} | # What does this PR do ?
Add documentation for audio and mel codec Hugging Face models
**Collection**: [TTS]
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11526/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11526/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11525 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11525/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11525/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11525/events | https://github.com/NVIDIA/NeMo/pull/11525 | 2,728,540,371 | PR_kwDOC_bI7s6EnsOh | 11,525 | Add non-mcore fsdp2 strategy | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.strategies.fsdp2_strategy\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:85:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:91:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:142:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:169:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:198:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.25/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @BoxiangW 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12661272471) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:63:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:130:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:150:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:286:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.utils\nnemo/lightning/pytorch/strategies/utils.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/strategies/utils.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:58:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:70:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:121:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:131:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/utils.py:186:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.75/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.strategies.fsdp2_strategy\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:85:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:91:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:142:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:169:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/fsdp2_strategy.py:198:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.25/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-09T23:36:25 | 2025-01-08T18:32:47 | 2025-01-08T18:32:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11525",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11525",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11525.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11525.patch",
"merged_at": "2025-01-08T18:32:45"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11525/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11525/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11524 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11524/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11524/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11524/events | https://github.com/NVIDIA/NeMo/pull/11524 | 2,728,219,256 | PR_kwDOC_bI7s6Emjoy | 11,524 | Onur/te transformer layer | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:34:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:106:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:131:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:18:0: W0611: Unused AutoConfig imported from transformers (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.65/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-09T20:42:11 | 2025-01-01T02:03:25 | 2025-01-01T02:03:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11524",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11524",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11524.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11524.patch",
"merged_at": null
} | # What does this PR do ?
An experimental PR to benchmark TL of TE in Lite. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11524/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11524/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11523 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11523/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11523/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11523/events | https://github.com/NVIDIA/NeMo/pull/11523 | 2,728,165,109 | PR_kwDOC_bI7s6EmXg7 | 11,523 | NeMo 2.0 In-framework deployment support | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.deploy.nlp.megatronllm_deployable\nnemo/deploy/nlp/megatronllm_deployable.py:266:0: C0301: Line too long (144/119) (line-too-long)\nnemo/deploy/nlp/megatronllm_deployable.py:270:0: C0301: Line too long (248/119) (line-too-long)\nnemo/deploy/nlp/megatronllm_deployable.py:297:0: C0301: Line too long (120/119) (line-too-long)\nnemo/deploy/nlp/megatronllm_deployable.py:302:0: C0301: Line too long (122/119) (line-too-long)\nnemo/deploy/nlp/megatronllm_deployable.py:412:0: C0301: Line too long (158/119) (line-too-long)\nnemo/deploy/nlp/megatronllm_deployable.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/nlp/megatronllm_deployable.py:102:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/nlp/megatronllm_deployable.py:106:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/nlp/megatronllm_deployable.py:109:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/nlp/megatronllm_deployable.py:407:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.deploy.nlp.query_llm\nnemo/deploy/nlp/query_llm.py:302:0: C0301: Line too long (120/119) (line-too-long)\nnemo/deploy/nlp/query_llm.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/nlp/query_llm.py:16:0: W0611: Unused abstractmethod imported from abc (unused-import)\n************* Module nemo.deploy.utils\nnemo/deploy/utils.py:30:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/utils.py:63:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/utils.py:75:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/utils.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/utils.py:87:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/utils.py:92:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.megatron_parallel\nnemo/lightning/megatron_parallel.py:238:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:239:0: C0301: Line too long (140/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:240:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:546:0: C0301: Line too long (129/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:553:0: C0301: Line too long (135/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:829:0: C0301: Line too long (137/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1059:0: C0301: Line too long (136/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1632:0: C0301: Line too long (128/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:64:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:102:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:106:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:330:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:356:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:382:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:518:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:561:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:619:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:654:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:660:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:666:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:673:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:714:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:722:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:738:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:765:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:777:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:799:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1325:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1500:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1516:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1521:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1526:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1554:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1600:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1622:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1695:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1734:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1748:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.deploy.nlp.deploy_inframework_triton\nscripts/deploy/nlp/deploy_inframework_triton.py:31:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_inframework_triton.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_inframework_triton.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.deploy.nlp.query_inframework\nscripts/deploy/nlp/query_inframework.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/query_inframework.py:42:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/query_inframework.py:65:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.35/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @oyilmaz-nvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12300861492) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-09T20:13:04 | 2024-12-12T18:18:49 | 2024-12-12T18:18:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11523",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11523",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11523.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11523.patch",
"merged_at": "2024-12-12T18:18:48"
} | # What does this PR do ?
Adds nemo2 support for inframework deployment | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11523/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11523/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11522 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11522/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11522/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11522/events | https://github.com/NVIDIA/NeMo/pull/11522 | 2,728,060,555 | PR_kwDOC_bI7s6El_qm | 11,522 | Update Llama3 Fine-Tuning Notebook | {
"login": "roclark",
"id": 12703406,
"node_id": "MDQ6VXNlcjEyNzAzNDA2",
"avatar_url": "https://avatars.githubusercontent.com/u/12703406?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/roclark",
"html_url": "https://github.com/roclark",
"followers_url": "https://api.github.com/users/roclark/followers",
"following_url": "https://api.github.com/users/roclark/following{/other_user}",
"gists_url": "https://api.github.com/users/roclark/gists{/gist_id}",
"starred_url": "https://api.github.com/users/roclark/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/roclark/subscriptions",
"organizations_url": "https://api.github.com/users/roclark/orgs",
"repos_url": "https://api.github.com/users/roclark/repos",
"events_url": "https://api.github.com/users/roclark/events{/privacy}",
"received_events_url": "https://api.github.com/users/roclark/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-09T19:31:25 | 2024-12-09T22:28:50 | 2024-12-09T22:28:50 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11522",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11522",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11522.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11522.patch",
"merged_at": "2024-12-09T22:28:50"
} | # What does this PR do ?
Update the Llama3-8B PubMeQA fine-tuning example notebook for a seamless experience.
**Collection**: NLP
# Changelog
- Fix an issue where using a base model with an older Transformer Engine version would cause a crash indicating missing model weight files.
- Download the model directly from NGC in the notebook for a full end-to-end example.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11522/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11522/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11521 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11521/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11521/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11521/events | https://github.com/NVIDIA/NeMo/pull/11521 | 2,727,988,148 | PR_kwDOC_bI7s6ElvNZ | 11,521 | Fix CI issue on validation config | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:604:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.96/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @BoxiangW 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12242474897) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-09T19:03:04 | 2024-12-10T02:46:16 | 2024-12-10T02:46:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11521",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11521",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11521.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11521.patch",
"merged_at": "2024-12-10T02:46:15"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11521/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11521/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11520 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11520/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11520/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11520/events | https://github.com/NVIDIA/NeMo/pull/11520 | 2,727,967,701 | PR_kwDOC_bI7s6ElqpV | 11,520 | Remove unwanted params in DDP init in Megatron Parallel | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.megatron_parallel\nnemo/lightning/megatron_parallel.py:238:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:239:0: C0301: Line too long (140/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:240:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:546:0: C0301: Line too long (129/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:553:0: C0301: Line too long (135/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:829:0: C0301: Line too long (137/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1059:0: C0301: Line too long (136/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1632:0: C0301: Line too long (128/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:64:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:102:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:106:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:330:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:356:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:382:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:518:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:561:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:619:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:654:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:660:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:666:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:673:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:714:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:722:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:738:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:765:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:777:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:799:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1325:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1500:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1516:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1521:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1526:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1554:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1600:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1622:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1695:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1734:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1748:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.23/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @hemildesai 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12243379988) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-09T18:52:41 | 2024-12-10T17:40:13 | 2024-12-10T17:40:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11520",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11520",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11520.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11520.patch",
"merged_at": "2024-12-10T17:40:10"
} | # What does this PR do ?
Remove args no longer present in MCore DDP init - https://github.com/NVIDIA/Megatron-LM/blob/main/megatron/core/distributed/distributed_data_parallel.py#L37
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11520/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11520/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11519 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11519/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11519/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11519/events | https://github.com/NVIDIA/NeMo/pull/11519 | 2,727,904,988 | PR_kwDOC_bI7s6Elcw6 | 11,519 | Add SFT/PEFT HF tests | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12292184814) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:25:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:77:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/peft/hf.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:208:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:34:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:47:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:125:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.02/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:25:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:77:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/peft/hf.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:208:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:34:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:47:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:125:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.02/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-09T18:19:58 | 2024-12-12T18:31:47 | 2024-12-12T18:31:44 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11519",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11519",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11519.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11519.patch",
"merged_at": "2024-12-12T18:31:44"
} | # What does this PR do ?
Add CI tests for PEFT/SFT with HF models for single gpu and DDP setups.
TODO (pending on hf ckpt work for perf): tests for saving / resuming from ckpt.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11519/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11519/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11518 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11518/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11518/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11518/events | https://github.com/NVIDIA/NeMo/pull/11518 | 2,727,862,294 | PR_kwDOC_bI7s6ElTS6 | 11,518 | [TTS] Modify codec training tutorial to allow HF download | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @rlangman 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12250787239) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-09T17:58:56 | 2024-12-10T19:06:23 | 2024-12-10T19:06:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11518",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11518",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11518.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11518.patch",
"merged_at": "2024-12-10T19:06:21"
} | # What does this PR do ?
Modify the tutorial about training audio codec models so that the user can download and fine tune from a hugging face checkpoint.
**Collection**: [TTS]
# Changelog
- Change previous logic using `list_available_models` to instead use `from_pretrained()`
- Replace default 16khz audio codec config with `nvidia/audio-codec-22khz
`
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR. | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11518/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11518/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11517 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11517/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11517/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11517/events | https://github.com/NVIDIA/NeMo/pull/11517 | 2,727,726,321 | PR_kwDOC_bI7s6Ek1E4 | 11,517 | Support attention backend configuration changes | {
"login": "ananthsub",
"id": 2382532,
"node_id": "MDQ6VXNlcjIzODI1MzI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2382532?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ananthsub",
"html_url": "https://github.com/ananthsub",
"followers_url": "https://api.github.com/users/ananthsub/followers",
"following_url": "https://api.github.com/users/ananthsub/following{/other_user}",
"gists_url": "https://api.github.com/users/ananthsub/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ananthsub/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ananthsub/subscriptions",
"organizations_url": "https://api.github.com/users/ananthsub/orgs",
"repos_url": "https://api.github.com/users/ananthsub/repos",
"events_url": "https://api.github.com/users/ananthsub/events{/privacy}",
"received_events_url": "https://api.github.com/users/ananthsub/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-09T17:04:08 | 2025-01-03T10:36:16 | 2025-01-03T10:36:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11517",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11517",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11517.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11517.patch",
"merged_at": "2025-01-03T10:36:16"
} | # What does this PR do ?
Fix up after https://github.com/NVIDIA/Megatron-LM/commit/fa0dcc48720ed9f440f36c7973fe5e7a54c7d208
Users of megatron's TransformerConfig should no longer disable TransformerEngine attention backends through environment variables like `NVTE_FUSED_ATTN`, `NVTE_FLASH_ATTN`, and `NVTE_UNFUSED_ATTN`.
Instead, after https://github.com/NVIDIA/Megatron-LM/commit/fa0dcc48720ed9f440f36c7973fe5e7a54c7d208, users should explicitly specify the attention backend in the TransformerConfig.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11517/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11517/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11516 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11516/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11516/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11516/events | https://github.com/NVIDIA/NeMo/issues/11516 | 2,727,597,346 | I_kwDOC_bI7s6ik9Ui | 11,516 | transcribe method broken? | {
"login": "hammondm",
"id": 17928417,
"node_id": "MDQ6VXNlcjE3OTI4NDE3",
"avatar_url": "https://avatars.githubusercontent.com/u/17928417?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hammondm",
"html_url": "https://github.com/hammondm",
"followers_url": "https://api.github.com/users/hammondm/followers",
"following_url": "https://api.github.com/users/hammondm/following{/other_user}",
"gists_url": "https://api.github.com/users/hammondm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hammondm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hammondm/subscriptions",
"organizations_url": "https://api.github.com/users/hammondm/orgs",
"repos_url": "https://api.github.com/users/hammondm/repos",
"events_url": "https://api.github.com/users/hammondm/events{/privacy}",
"received_events_url": "https://api.github.com/users/hammondm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-09T16:17:40 | 2025-01-17T01:55:59 | 2025-01-17T01:55:58 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi.
For some reason, the `transcribe` method causes a core dump with quartznet or conformer. I'm running this in docker. My code is tweaked from one of the tutorials.
Mike H
Here's my code:
```
import os,glob,os,subprocess,tarfile
import wget,nemo,librosa,json
from ruamel.yaml import YAML
import nemo.collections.asr as nemo_asr
import pytorch_lightning as pl
from omegaconf import DictConfig
data_dir = '/data/an4'
config_path = 'quartzconf.yaml'
epochs = 3
if not os.path.exists(data_dir):
os.makedirs(data_dir)
#download data
if not os.path.exists(
data_dir + '/an4_sphere.tar.gz'
):
an4_url = 'https://dldata-public.s3.us' + \
'-east-2.amazonaws.com/an4_sphere.tar.gz'
an4_path = wget.download(an4_url,data_dir)
else:
an4_path = data_dir + '/an4_sphere.tar.gz'
#convert to wav files
if not os.path.exists(data_dir + '/an4/'):
tar = tarfile.open(an4_path)
tar.extractall(path=data_dir)
sph_list = glob.glob(
data_dir + '/an4/**/*.sph',
recursive=True
)
for sph_path in sph_list:
wav_path = sph_path[:-4] + '.wav'
cmd = ["sox",sph_path,wav_path]
subprocess.run(cmd)
#function to create manifest file
def build_manifest(
transcripts_path,
manifest_path,wav_path
):
with open(transcripts_path,'r') as fin:
with open(manifest_path,'w') as fout:
for line in fin:
transcript = line[: \
line.find('(')-1].lower()
transcript = transcript.replace(
'<s>',''
).replace('</s>','')
transcript = transcript.strip()
file_id = line[line.find('(')+1 : -2]
audio_path = os.path.join(
data_dir,wav_path,
file_id[file_id.find('-')+1 : \
file_id.rfind('-')],
file_id + '.wav')
duration = librosa.core.get_duration(
filename=audio_path
)
metadata = {
"audio_filepath": audio_path,
"duration": duration,
"text": transcript
}
json.dump(metadata,fout)
fout.write('\n')
#make manifest files
train_transcripts = data_dir + \
'/an4/etc/an4_train.transcription'
train_manifest = data_dir + \
'/an4/train_manifest.json'
if not os.path.isfile(train_manifest):
build_manifest(
train_transcripts,
train_manifest,
'an4/wav/an4_clstk'
)
test_transcripts = data_dir + \
'/an4/etc/an4_test.transcription'
test_manifest = data_dir + \
'/an4/test_manifest.json'
if not os.path.isfile(test_manifest):
build_manifest(
test_transcripts,
test_manifest,
'an4/wav/an4test_clstk'
)
#read config from yaml file
yaml = YAML(typ='safe')
with open(config_path) as f:
params = yaml.load(f)
print(params)
#build trainer
trainer = pl.Trainer(
devices=1,
accelerator='gpu',
max_epochs=epochs
)
#specify training and validation data
params['model']['train_ds']\
['manifest_filepath'] = train_manifest
params['model']['validation_ds']\
['manifest_filepath'] = test_manifest
#build model
first_asr_model = \
nemo_asr.models.EncDecCTCModel(
cfg=DictConfig(params['model']),
trainer=trainer
)
#train
trainer.fit(first_asr_model)
#do some inference
paths2audio_files = [
os.path.join(
data_dir,
'an4/wav/an4_clstk/mgah/cen2-mgah-b.wav'
),
os.path.join(
data_dir,
'an4/wav/an4_clstk/fmjd/cen7-fmjd-b.wav'
),
os.path.join(
data_dir,
'an4/wav/an4_clstk/fmjd/cen8-fmjd-b.wav'
),
os.path.join(
data_dir,
'an4/wav/an4_clstk/fkai/cen8-fkai-b.wav'
)
]
#print(first_asr_model.transcribe(
# paths2audio_files=paths2audio_files,
# batch_size=4
#))
```
Here's the output:
```
{'name': 'QuartzNet15x5', 'sample_rate': 16000, 'repeat': 1, 'dropout': 0.0, 'separable': True, 'labels': [' ', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', "'"], 'model': {'train_ds': {'manifest_filepath': '???', 'sample_rate': 16000, 'labels': [' ', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', "'"], 'batch_size': 32, 'trim_silence': True, 'max_duration': 16.7, 'shuffle': True, 'num_workers': 4, 'pin_memory': True, 'is_tarred': False, 'tarred_audio_filepaths': None, 'shuffle_n': 2048, 'bucketing_strategy': 'synced_randomized', 'bucketing_batch_size': None}, 'validation_ds': {'manifest_filepath': '???', 'sample_rate': 16000, 'labels': [' ', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', "'"], 'batch_size': 32, 'shuffle': False, 'num_workers': 4, 'pin_memory': True}, 'preprocessor': {'_target_': 'nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor', 'normalize': 'per_feature', 'window_size': 0.02, 'sample_rate': 16000, 'window_stride': 0.01, 'window': 'hann', 'features': 64, 'n_fft': 512, 'frame_splicing': 1, 'dither': 1e-05, 'stft_conv': False}, 'spec_augment': {'_target_': 'nemo.collections.asr.modules.SpectrogramAugmentation', 'rect_freq': 50, 'rect_masks': 5, 'rect_time': 120}, 'encoder': {'_target_': 'nemo.collections.asr.modules.ConvASREncoder', 'feat_in': 64, 'activation': 'relu', 'conv_mask': True, 'jasper': [{'filters': 128, 'repeat': 1, 'kernel': [11], 'stride': [1], 'dilation': [1], 'dropout': 0.0, 'residual': True, 'separable': True, 'se': True, 'se_context_size': -1}, {'filters': 256, 'repeat': 1, 'kernel': [13], 'stride': [1], 'dilation': [1], 'dropout': 0.0, 'residual': True, 'separable': True, 'se': True, 'se_context_size': -1}, {'filters': 256, 'repeat': 1, 'kernel': [15], 'stride': [1], 'dilation': [1], 'dropout': 0.0, 'residual': True, 'separable': True, 'se': True, 'se_context_size': -1}, {'filters': 256, 'repeat': 1, 'kernel': [17], 'stride': [1], 'dilation': [1], 'dropout': 0.0, 'residual': True, 'separable': True, 'se': True, 'se_context_size': -1}, {'filters': 256, 'repeat': 1, 'kernel': [19], 'stride': [1], 'dilation': [1], 'dropout': 0.0, 'residual': True, 'separable': True, 'se': True, 'se_context_size': -1}, {'filters': 256, 'repeat': 1, 'kernel': [21], 'stride': [1], 'dilation': [1], 'dropout': 0.0, 'residual': False, 'separable': True, 'se': True, 'se_context_size': -1}, {'filters': 1024, 'repeat': 1, 'kernel': [1], 'stride': [1], 'dilation': [1], 'dropout': 0.0, 'residual': False, 'separable': True, 'se': True, 'se_context_size': -1}]}, 'decoder': {'_target_': 'nemo.collections.asr.modules.ConvASRDecoder', 'feat_in': 1024, 'num_classes': 28, 'vocabulary': [' ', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', "'"]}, 'optim': {'name': 'novograd', 'lr': 0.01, 'betas': [0.8, 0.5], 'weight_decay': 0.001, 'sched': {'name': 'CosineAnnealing', 'monitor': 'val_loss', 'reduce_on_plateau': False, 'warmup_steps': None, 'warmup_ratio': None, 'min_lr': 0.0, 'last_epoch': -1}}}, 'trainer': {'devices': 1, 'max_epochs': 5, 'max_steps': -1, 'num_nodes': 1, 'accelerator': 'gpu', 'strategy': 'ddp', 'accumulate_grad_batches': 1, 'enable_checkpointing': False, 'logger': False, 'log_every_n_steps': 1, 'val_check_interval': 1.0, 'benchmark': False}, 'exp_manager': {'exp_dir': None, 'name': 'QuartzNet15x5', 'create_tensorboard_logger': True, 'create_checkpoint_callback': True}}
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
[NeMo I 2024-12-09 16:13:59 audio_to_text_dataset:49] Model level config does not contain `sample_rate`, please explicitly provide `sample_rate` to the dataloaders.
[NeMo I 2024-12-09 16:13:59 audio_to_text_dataset:49] Model level config does not contain `labels`, please explicitly provide `labels` to the dataloaders.
[NeMo I 2024-12-09 16:13:59 collections:196] Dataset loaded with 948 files totalling 0.71 hours
[NeMo I 2024-12-09 16:13:59 collections:197] 0 files were filtered totalling 0.00 hours
[NeMo I 2024-12-09 16:13:59 audio_to_text_dataset:49] Model level config does not contain `sample_rate`, please explicitly provide `sample_rate` to the dataloaders.
[NeMo I 2024-12-09 16:13:59 audio_to_text_dataset:49] Model level config does not contain `labels`, please explicitly provide `labels` to the dataloaders.
[NeMo I 2024-12-09 16:13:59 collections:196] Dataset loaded with 130 files totalling 0.10 hours
[NeMo I 2024-12-09 16:13:59 collections:197] 0 files were filtered totalling 0.00 hours
[NeMo I 2024-12-09 16:13:59 features:289] PADDING: 16
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1]
[NeMo I 2024-12-09 16:14:00 modelPT:728] Optimizer config = Novograd (
Parameter Group 0
amsgrad: False
betas: [0.8, 0.5]
eps: 1e-08
grad_averaging: False
lr: 0.01
weight_decay: 0.001
)
[NeMo I 2024-12-09 16:14:00 lr_scheduler:910] Scheduler "<nemo.core.optim.lr_scheduler.CosineAnnealing object at 0x7f8ff9db6da0>"
will be used during training (effective maximum steps = 90) -
Parameters :
(warmup_steps: null
warmup_ratio: null
min_lr: 0.0
last_epoch: -1
max_steps: 90
)
| Name | Type | Params
------------------------------------------------------------------------
0 | preprocessor | AudioToMelSpectrogramPreprocessor | 0
1 | encoder | ConvASREncoder | 1.2 M
2 | decoder | ConvASRDecoder | 29.7 K
3 | loss | CTCLoss | 0
4 | spec_augmentation | SpectrogramAugmentation | 0
5 | _wer | WER | 0
------------------------------------------------------------------------
1.2 M Trainable params
0 Non-trainable params
1.2 M Total params
4.836 Total estimated model params size (MB)
[NeMo W 2024-12-09 16:14:01 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/pytorch_lightning/loops/fit_loop.py:281: PossibleUserWarning: The number of training batches (30) is smaller than the logging interval Trainer(log_every_n_steps=50). Set a lower value for log_every_n_steps if you want to see logs for the training epoch.
rank_zero_warn(
Epoch 2: 100%|████████████████████████| 30/30 [00:01<00:00, 15.07it/s, v_num=15]`Trainer.fit` stopped: `max_epochs=3` reached.
Epoch 2: 100%|████████████████████████| 30/30 [00:02<00:00, 14.87it/s, v_num=15]
Transcribing: 0%| | 0/1 [00:00<?, ?it/s]Segmentation fault (core dumped)
```
Here's how the container was built:
```
docker run -it \
--gpus all \
--ipc=host \
--ulimit memlock=-1 \
--ulimit stack=67108864 \
-p 8888:8888 \
--name ne \
-v /data/:/mhdata \
nvcr.io/nvidia/nemo:23.10
```
***
**Describe the bug**
A clear and concise description of what the bug is.
**Steps/Code to reproduce bug**
Please list *minimal* steps or code snippet for us to be able to reproduce the bug.
A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.
**Expected behavior**
A clear and concise description of what you expected to happen.
**Environment overview (please complete the following information)**
- Environment location: [Bare-metal, Docker, Cloud(specify cloud provider - AWS, Azure, GCP, Collab)]
- Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install.
- If method of install is [Docker], provide `docker pull` & `docker run` commands used
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version
- PyTorch version
- Python version
**Additional context**
Add any other context about the problem here.
Example: GPU model
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11516/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11516/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11515 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11515/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11515/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11515/events | https://github.com/NVIDIA/NeMo/pull/11515 | 2,727,576,519 | PR_kwDOC_bI7s6EkTQq | 11,515 | Fix issue with Wandb update to settings parsing | {
"login": "skothenhill-nv",
"id": 148821680,
"node_id": "U_kgDOCN7WsA",
"avatar_url": "https://avatars.githubusercontent.com/u/148821680?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skothenhill-nv",
"html_url": "https://github.com/skothenhill-nv",
"followers_url": "https://api.github.com/users/skothenhill-nv/followers",
"following_url": "https://api.github.com/users/skothenhill-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/skothenhill-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skothenhill-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skothenhill-nv/subscriptions",
"organizations_url": "https://api.github.com/users/skothenhill-nv/orgs",
"repos_url": "https://api.github.com/users/skothenhill-nv/repos",
"events_url": "https://api.github.com/users/skothenhill-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/skothenhill-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.nemo_logger\nnemo/lightning/nemo_logger.py:75:0: C0301: Line too long (125/119) (line-too-long)\nnemo/lightning/nemo_logger.py:98:0: C0301: Line too long (120/119) (line-too-long)\nnemo/lightning/nemo_logger.py:99:0: C0301: Line too long (123/119) (line-too-long)\nnemo/lightning/nemo_logger.py:104:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/nemo_logger.py:174:0: C0301: Line too long (125/119) (line-too-long)\nnemo/lightning/nemo_logger.py:207:0: C0301: Line too long (128/119) (line-too-long)\nnemo/lightning/nemo_logger.py:208:0: C0301: Line too long (124/119) (line-too-long)\nnemo/lightning/nemo_logger.py:213:0: C0301: Line too long (124/119) (line-too-long)\n\n-----------------------------------\nYour code has been rated at 9.46/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-09T16:10:36 | 2025-01-01T02:03:28 | 2025-01-01T02:03:27 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11515",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11515",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11515.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11515.patch",
"merged_at": null
} | In this PR: https://github.com/wandb/wandb/pull/8649 Wandb added a hard constraint that directories are passed as strings rather than `pathlib.Path`s. We've requested a change on their end to allow for both types. In the interim, either this change or pinning `wandb==0.16.0` resolves the issue. We should avoid using pathlib.Path with Wandb constructs for now. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11515/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11515/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11514 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11514/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11514/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11514/events | https://github.com/NVIDIA/NeMo/pull/11514 | 2,727,565,650 | PR_kwDOC_bI7s6EkQyg | 11,514 | [BUG] wandb init path | {
"login": "skothenhill-nv",
"id": 148821680,
"node_id": "U_kgDOCN7WsA",
"avatar_url": "https://avatars.githubusercontent.com/u/148821680?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skothenhill-nv",
"html_url": "https://github.com/skothenhill-nv",
"followers_url": "https://api.github.com/users/skothenhill-nv/followers",
"following_url": "https://api.github.com/users/skothenhill-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/skothenhill-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skothenhill-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skothenhill-nv/subscriptions",
"organizations_url": "https://api.github.com/users/skothenhill-nv/orgs",
"repos_url": "https://api.github.com/users/skothenhill-nv/repos",
"events_url": "https://api.github.com/users/skothenhill-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/skothenhill-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.nemo_logger\nnemo/lightning/nemo_logger.py:75:0: C0301: Line too long (125/119) (line-too-long)\nnemo/lightning/nemo_logger.py:98:0: C0301: Line too long (120/119) (line-too-long)\nnemo/lightning/nemo_logger.py:99:0: C0301: Line too long (123/119) (line-too-long)\nnemo/lightning/nemo_logger.py:104:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/nemo_logger.py:174:0: C0301: Line too long (125/119) (line-too-long)\nnemo/lightning/nemo_logger.py:207:0: C0301: Line too long (128/119) (line-too-long)\nnemo/lightning/nemo_logger.py:208:0: C0301: Line too long (124/119) (line-too-long)\nnemo/lightning/nemo_logger.py:213:0: C0301: Line too long (124/119) (line-too-long)\n\n-----------------------------------\nYour code has been rated at 9.46/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-09T16:07:06 | 2024-12-09T16:07:35 | 2024-12-09T16:07:23 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11514",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11514",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11514.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11514.patch",
"merged_at": null
} | Wandb recently changed the init directory to be validated as a string, pathlib.Path fails. We have requested them to change this, in the interim we should either pin Wandb `wandb==0.16.0` or avoid using pathlib.Path with Wandb constructs.
| {
"login": "skothenhill-nv",
"id": 148821680,
"node_id": "U_kgDOCN7WsA",
"avatar_url": "https://avatars.githubusercontent.com/u/148821680?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skothenhill-nv",
"html_url": "https://github.com/skothenhill-nv",
"followers_url": "https://api.github.com/users/skothenhill-nv/followers",
"following_url": "https://api.github.com/users/skothenhill-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/skothenhill-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skothenhill-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skothenhill-nv/subscriptions",
"organizations_url": "https://api.github.com/users/skothenhill-nv/orgs",
"repos_url": "https://api.github.com/users/skothenhill-nv/repos",
"events_url": "https://api.github.com/users/skothenhill-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/skothenhill-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11514/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11514/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11513 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11513/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11513/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11513/events | https://github.com/NVIDIA/NeMo/pull/11513 | 2,726,846,128 | PR_kwDOC_bI7s6EhwaP | 11,513 | modelopt=0.21.0 update | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12262653049) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"> Why is modelopt not part of requirements txt?\r\n\r\nI think Eric wanted it to be only an optional requirement for NeMo in the initial integration effort (see [here](https://github.com/NVIDIA/NeMo/pull/8444#discussion_r1514770391) and [here](https://github.com/NVIDIA/NeMo/pull/8444/commits/ae88e4744e43f0c7afc7d6bc8739a42a05a18209#r1514771010)). It's also import guarded (see [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/quantization/quantizer.py#L34-L51), for example).\r\n\r\nAre you suggesting to revisit this decision?",
"> > Why is modelopt not part of requirements txt?\r\n> \r\n> I think Eric wanted it to be only an optional requirement for NeMo in the initial integration effort (see [here](https://github.com/NVIDIA/NeMo/pull/8444#discussion_r1514770391) and [here](https://github.com/NVIDIA/NeMo/pull/8444/commits/ae88e4744e43f0c7afc7d6bc8739a42a05a18209#r1514771010)). It's also import guarded (see [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/quantization/quantizer.py#L34-L51), for example).\r\n> \r\n> Are you suggesting to revisit this decision?\r\n\r\nIf this was for initial implementation then yes, let’s revisit it. But not necessarily as part of this PR. Thanks for explaining!",
"This needs to be synced with an update on container side, I'll let you know once ready",
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12549035693) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-09T12:03:24 | 2024-12-31T09:22:04 | 2024-12-31T09:22:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11513",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11513",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11513.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11513.patch",
"merged_at": "2024-12-31T09:22:02"
} | # What does this PR do ?
* ~~Bugfix to correctly support Mixtral for PTQ in NeMo 2.0.~~ done in https://github.com/NVIDIA/NeMo/pull/11607
* Updating `nvidia-modelopt=0.21.0`
**Collection**: LLM / NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to https://github.com/NVIDIA/NeMo/pull/11607
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11513/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11513/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11512 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11512/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11512/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11512/events | https://github.com/NVIDIA/NeMo/issues/11512 | 2,725,991,576 | I_kwDOC_bI7s6ie1SY | 11,512 | An error occurs when exporting T5G2PModel to ONNX. | {
"login": "VoiceGenerationProject",
"id": 155930019,
"node_id": "U_kgDOCUtNow",
"avatar_url": "https://avatars.githubusercontent.com/u/155930019?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VoiceGenerationProject",
"html_url": "https://github.com/VoiceGenerationProject",
"followers_url": "https://api.github.com/users/VoiceGenerationProject/followers",
"following_url": "https://api.github.com/users/VoiceGenerationProject/following{/other_user}",
"gists_url": "https://api.github.com/users/VoiceGenerationProject/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VoiceGenerationProject/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VoiceGenerationProject/subscriptions",
"organizations_url": "https://api.github.com/users/VoiceGenerationProject/orgs",
"repos_url": "https://api.github.com/users/VoiceGenerationProject/repos",
"events_url": "https://api.github.com/users/VoiceGenerationProject/events{/privacy}",
"received_events_url": "https://api.github.com/users/VoiceGenerationProject/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-09T05:01:02 | 2025-01-17T01:56:00 | 2025-01-17T01:55:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
An error occurs when exporting T5G2PModel to ONNX.
**Steps/Code to reproduce bug**
> import torch
> from transformers import PreTrainedTokenizerBase, AutoTokenizer
>
> from nemo.collections.tts.g2p.models.t5 import T5G2PModel
> model_name = "T5G2P.nemo"
> model = T5G2PModel.restore_from(model_name, map_location=torch.device("cpu"))
> model.eval()
>
> model.export("test.onnx")
[Error]
RuntimeError: 0 INTERNAL ASSERT FAILED at "../torch/csrc/jit/ir/alias_analysis.cpp":615, please report a bug to PyTorch. We don't have an op for aten::full but it isn't a special case. Argument types: int[], bool, int, NoneType, Device, bool,
Candidates:
aten::full.names(int[] size, Scalar fill_value, *, str[]? names, ScalarType? dtype=None, Layout? layout=None, Device? device=None, bool? pin_memory=None) -> Tensor
aten::full(SymInt[] size, Scalar fill_value, *, ScalarType? dtype=None, Layout? layout=None, Device? device=None, bool? pin_memory=None) -> Tensor
aten::full.names_out(int[] size, Scalar fill_value, *, str[]? names, Tensor(a!) out) -> Tensor(a!)
aten::full.out(SymInt[] size, Scalar fill_value, *, Tensor(a!) out) -> Tensor(a!)
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- Ubuntu 20.04
- PyTorch version - 2.3.0+cu118
- Python version - 3.10.12 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11512/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11512/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11511 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11511/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11511/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11511/events | https://github.com/NVIDIA/NeMo/pull/11511 | 2,725,734,681 | PR_kwDOC_bI7s6Ed5hb | 11,511 | Sortformer Diarizer 4spk v1 model PR Part 3: Speaker Diarization Mixin | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Don't forget to add `sync_dist=True` for validation\r\nhttps://github.com/NVIDIA/NeMo/blob/38002a777075ceec16a67d31b011e1c2dcde50a2/nemo/collections/asr/models/asr_model.py#L204C9-L204C66\r\n\r\nNote that we should make this change after @pzelasko 's PR https://github.com/NVIDIA/NeMo/pull/11533 is merged. Otherwise it will cause an error.\r\n",
"> Overall LGTM, just some small comments, and the only necessary change is to add `get_full_path()` to file paths when loading the manifest, such that relative paths can be properly handled. Another recommended change is to raise an error when `rttm_filepath` is a file that cannot be found, so that users can be notified of corrupted manifest\r\n\r\nMakes lots of sense. Added file existence check then added `get_full_path()`\r\n```python3\r\n if item['rttm_file'] is not None:\r\n if not os.path.exists(item['rttm_file']):\r\n raise FileNotFoundError(f\"RTTM file not found: {item['rttm_file']}\")\r\n else:\r\n item['rttm_file'] = get_full_path(audio_file=item['rttm_file'], manifest_file=manifest_file)\r\n```",
"> Minor comments, the only necessary change is to move file existence checking after `get_full_path`.\r\n\r\nNow all the existence check is moved after `get_full_path`. Thanks for commenting."
] | 2024-12-09T01:43:42 | 2024-12-18T17:46:49 | 2024-12-18T17:46:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11511",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11511",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11511.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11511.patch",
"merged_at": "2024-12-18T17:46:48"
} | # What does this PR do ?
Add diarization Mixin class to enable "one click" executable function (`diarize()`) as in ASR collections' `transcribe()` functions.
1. wav filepath string
2. a list of wav filepath strings
3. json manifest filepath string
Three types of input data is supported for
Sortformer PRs:
This is PR 3rd out of 4.
PR 1/4: https://github.com/NVIDIA/NeMo/pull/11282
PR 2/4: https://github.com/NVIDIA/NeMo/pull/11336
PR 3/4: This PR
PR 4/4: Sortformer Documents
**Collection**: [Note which collection this PR will affect]
# Changelog
- `nemo/collections/asr/parts/mixins/diarization.py`
Mixin class for `diarize()` one click functions.
- `tests/collections/speaker_tasks/mixins/test_diarization.py`
Test file for mixin classes.
# Usage
* Three line example:
```python
from nemo.collections.asr.models import SortformerEncLabelModel
diar_model = SortformerEncLabelModel.restore_from(restore_path="diar_sortformer_4spk-v1", map_location=torch.device('cuda'), strict=False)
pred_outputs = diar_model.diarize(audio="my_audio.wav")
```
# GitHub Actions CI
Run CICD
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
Anyone in NeMo ASR
# Additional Information
PR 1/4: https://github.com/NVIDIA/NeMo/pull/11282
PR 2/4: https://github.com/NVIDIA/NeMo/pull/11336
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11511/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11511/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11510 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11510/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11510/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11510/events | https://github.com/NVIDIA/NeMo/pull/11510 | 2,725,662,686 | PR_kwDOC_bI7s6EdpuQ | 11,510 | chore(beep boop 🤖): Bump `MCORE_TAG=6dfeb25...` (2024-12-09) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-09T00:25:44 | 2025-01-01T02:03:29 | 2025-01-01T02:03:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11510",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11510",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11510.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11510.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=6dfeb2597c625f5dc1ea2f564e45aee654ffca44`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11510/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11510/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11509 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11509/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11509/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11509/events | https://github.com/NVIDIA/NeMo/pull/11509 | 2,724,871,796 | PR_kwDOC_bI7s6EbAOe | 11,509 | chore(beep boop 🤖): Bump `MCORE_TAG=dc7fea9...` (2024-12-08) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-08T00:26:46 | 2024-12-29T02:03:53 | 2024-12-29T02:03:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11509",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11509",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11509.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11509.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=dc7fea91a15d12cbe5084699f09935a088f172f1`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11509/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11509/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11508 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11508/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11508/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11508/events | https://github.com/NVIDIA/NeMo/issues/11508 | 2,724,777,067 | I_kwDOC_bI7s6iaMxr | 11,508 | [ASR]: Compatibility error with NumPy v2.0 | {
"login": "njfamirm",
"id": 83071310,
"node_id": "MDQ6VXNlcjgzMDcxMzEw",
"avatar_url": "https://avatars.githubusercontent.com/u/83071310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/njfamirm",
"html_url": "https://github.com/njfamirm",
"followers_url": "https://api.github.com/users/njfamirm/followers",
"following_url": "https://api.github.com/users/njfamirm/following{/other_user}",
"gists_url": "https://api.github.com/users/njfamirm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/njfamirm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/njfamirm/subscriptions",
"organizations_url": "https://api.github.com/users/njfamirm/orgs",
"repos_url": "https://api.github.com/users/njfamirm/repos",
"events_url": "https://api.github.com/users/njfamirm/events{/privacy}",
"received_events_url": "https://api.github.com/users/njfamirm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"fixed with static version set for numpy",
"@njfamirm what version did you fix numpy to? I'm having the same problem. I tried to downgrade to numpy 2.0.2 but had other compatibility issues. Is [ASR] not compatible with numpy 2 at all or just the latest release?\n\nEDIT: in the end it worked with 1.23.5",
"> [@njfamirm](https://github.com/njfamirm) what version did you fix numpy to? I'm having the same problem. I tried to downgrade to numpy 2.0.2 but had other compatibility issues. Is [ASR] not compatible with numpy 2 at all or just the latest release?\n> \n> EDIT: in the end it worked with 1.23.5\n\nHi, `numpy==1.26.4`"
] | 2024-12-07T19:14:48 | 2024-12-19T14:10:48 | 2024-12-16T17:47:18 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi
**Describe the bug**
Compatibility error with NumPy v2.0: AttributeError: `np.sctypes was removed in the NumPy 2.0 release. Access dtypes explicitly instead.. Did you mean: 'dtypes'?`
**Steps/Code to reproduce bug**
Run this code
```python
import nemo.collections.asr as nemo_asr
# 1. Download and instantiate the Persian model
asr_model_name="nvidia/stt_fa_fastconformer_hybrid_large"
asr_model = nemo_asr.models.EncDecHybridRNNTCTCBPEModel.from_pretrained(model_name=asr_model_name)
audio_file_path = "voice_01.wav"
asr_model.transcribe([audio_file_path])
```
**Expected behavior**
Work fine!
**Environment overview (please complete the following information)**
- Environment location: [Github Codespace)]
- pip install nemo_toolkit==2.0.0
**Environment details**
- OS version: Linux codespaces-aa0b2f 6.5.0-1025-azure
- PyTorch version: `2.5.1`
- Python version: 3.12.7
| {
"login": "njfamirm",
"id": 83071310,
"node_id": "MDQ6VXNlcjgzMDcxMzEw",
"avatar_url": "https://avatars.githubusercontent.com/u/83071310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/njfamirm",
"html_url": "https://github.com/njfamirm",
"followers_url": "https://api.github.com/users/njfamirm/followers",
"following_url": "https://api.github.com/users/njfamirm/following{/other_user}",
"gists_url": "https://api.github.com/users/njfamirm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/njfamirm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/njfamirm/subscriptions",
"organizations_url": "https://api.github.com/users/njfamirm/orgs",
"repos_url": "https://api.github.com/users/njfamirm/repos",
"events_url": "https://api.github.com/users/njfamirm/events{/privacy}",
"received_events_url": "https://api.github.com/users/njfamirm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11508/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11508/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11507 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11507/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11507/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11507/events | https://github.com/NVIDIA/NeMo/issues/11507 | 2,724,488,939 | I_kwDOC_bI7s6iZGbr | 11,507 | [NLP] Punctuation and capitalisation | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-07T08:49:50 | 2025-01-15T01:56:43 | 2025-01-15T01:56:42 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I have noticed that in the section https://github.com/NVIDIA/NeMo/tree/main/examples/nlp/token_classification, a warning has been added (2 months ago), which states the section is deprecated and scheduled for removal in release 23.11.
Is this a mistake since on ngc the container is already at version 24.09? If not, could you share information on the future of punctuation and capitalisation, especially since the task is also an integral part in Riva pipelines? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11507/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11507/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11506 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11506/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11506/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11506/events | https://github.com/NVIDIA/NeMo/pull/11506 | 2,724,287,931 | PR_kwDOC_bI7s6EZIke | 11,506 | Apply packed sequence params change for fused rope compatibility | {
"login": "ananthsub",
"id": 2382532,
"node_id": "MDQ6VXNlcjIzODI1MzI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2382532?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ananthsub",
"html_url": "https://github.com/ananthsub",
"followers_url": "https://api.github.com/users/ananthsub/followers",
"following_url": "https://api.github.com/users/ananthsub/following{/other_user}",
"gists_url": "https://api.github.com/users/ananthsub/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ananthsub/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ananthsub/subscriptions",
"organizations_url": "https://api.github.com/users/ananthsub/orgs",
"repos_url": "https://api.github.com/users/ananthsub/repos",
"events_url": "https://api.github.com/users/ananthsub/events{/privacy}",
"received_events_url": "https://api.github.com/users/ananthsub/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:604:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.modules.common.megatron.adapters.mcore_mixins\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:140:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:142:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:60:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:69:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:108:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:226:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:333:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:359:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:443:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:450:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:474:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:481:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:499:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py:506:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.66/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-07T02:57:18 | 2024-12-09T18:06:53 | 2024-12-09T16:33:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11506",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11506",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11506.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11506.patch",
"merged_at": "2024-12-09T16:33:53"
} | # What does this PR do ?
Compatibility with https://github.com/NVIDIA/Megatron-LM/commit/210162aebcfc68d72f39049d5cf84a83d3b11dea
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ananthsub",
"id": 2382532,
"node_id": "MDQ6VXNlcjIzODI1MzI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2382532?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ananthsub",
"html_url": "https://github.com/ananthsub",
"followers_url": "https://api.github.com/users/ananthsub/followers",
"following_url": "https://api.github.com/users/ananthsub/following{/other_user}",
"gists_url": "https://api.github.com/users/ananthsub/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ananthsub/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ananthsub/subscriptions",
"organizations_url": "https://api.github.com/users/ananthsub/orgs",
"repos_url": "https://api.github.com/users/ananthsub/repos",
"events_url": "https://api.github.com/users/ananthsub/events{/privacy}",
"received_events_url": "https://api.github.com/users/ananthsub/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11506/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11506/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11505 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11505/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11505/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11505/events | https://github.com/NVIDIA/NeMo/pull/11505 | 2,724,282,432 | PR_kwDOC_bI7s6EZHj5 | 11,505 | Fix checkpoint import for mixtral with padded vocab size. | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:157:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:323:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:119:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:133:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:171:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:294:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:317:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:337:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:341:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.36/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12251859369) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-07T02:47:04 | 2024-12-10T21:02:27 | 2024-12-10T21:02:26 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11505",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11505",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11505.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11505.patch",
"merged_at": "2024-12-10T21:02:26"
} |
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11505/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11505/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11504 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11504/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11504/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11504/events | https://github.com/NVIDIA/NeMo/pull/11504 | 2,724,272,478 | PR_kwDOC_bI7s6EZFuo | 11,504 | MegatronStrategy: make pipeline_dtype function attribute. | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12241618845) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:604:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:282:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.97/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:604:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:282:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.97/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12250230260) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-07T02:28:18 | 2024-12-10T17:20:25 | 2024-12-10T17:20:24 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11504",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11504",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11504.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11504.patch",
"merged_at": "2024-12-10T17:20:24"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11504/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11504/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11503 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11503/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11503/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11503/events | https://github.com/NVIDIA/NeMo/pull/11503 | 2,724,194,230 | PR_kwDOC_bI7s6EY1NN | 11,503 | chore(beep boop 🤖): Bump `MCORE_TAG=bd677bf...` (2024-12-07) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-07T00:24:04 | 2024-12-29T02:03:54 | 2024-12-29T02:03:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11503",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11503",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11503.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11503.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=bd677bfb13ac2f19deaa927adc6da6f9201d66aa`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11503/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11503/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11502 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11502/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11502/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11502/events | https://github.com/NVIDIA/NeMo/pull/11502 | 2,724,104,708 | PR_kwDOC_bI7s6EYjg8 | 11,502 | minor fix for nemo2 sftpeft readme | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-06T23:10:52 | 2024-12-09T21:51:13 | 2024-12-09T21:51:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11502",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11502",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11502.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11502.patch",
"merged_at": "2024-12-09T21:51:11"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11502/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11502/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11501 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11501/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11501/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11501/events | https://github.com/NVIDIA/NeMo/pull/11501 | 2,723,753,019 | PR_kwDOC_bI7s6EXVW2 | 11,501 | changed-megatron-lm-ref | {
"login": "jgerh",
"id": 163925524,
"node_id": "U_kgDOCcVOFA",
"avatar_url": "https://avatars.githubusercontent.com/u/163925524?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jgerh",
"html_url": "https://github.com/jgerh",
"followers_url": "https://api.github.com/users/jgerh/followers",
"following_url": "https://api.github.com/users/jgerh/following{/other_user}",
"gists_url": "https://api.github.com/users/jgerh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jgerh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jgerh/subscriptions",
"organizations_url": "https://api.github.com/users/jgerh/orgs",
"repos_url": "https://api.github.com/users/jgerh/repos",
"events_url": "https://api.github.com/users/jgerh/events{/privacy}",
"received_events_url": "https://api.github.com/users/jgerh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "jgerh",
"id": 163925524,
"node_id": "U_kgDOCcVOFA",
"avatar_url": "https://avatars.githubusercontent.com/u/163925524?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jgerh",
"html_url": "https://github.com/jgerh",
"followers_url": "https://api.github.com/users/jgerh/followers",
"following_url": "https://api.github.com/users/jgerh/following{/other_user}",
"gists_url": "https://api.github.com/users/jgerh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jgerh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jgerh/subscriptions",
"organizations_url": "https://api.github.com/users/jgerh/orgs",
"repos_url": "https://api.github.com/users/jgerh/repos",
"events_url": "https://api.github.com/users/jgerh/events{/privacy}",
"received_events_url": "https://api.github.com/users/jgerh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "jgerh",
"id": 163925524,
"node_id": "U_kgDOCcVOFA",
"avatar_url": "https://avatars.githubusercontent.com/u/163925524?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jgerh",
"html_url": "https://github.com/jgerh",
"followers_url": "https://api.github.com/users/jgerh/followers",
"following_url": "https://api.github.com/users/jgerh/following{/other_user}",
"gists_url": "https://api.github.com/users/jgerh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jgerh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jgerh/subscriptions",
"organizations_url": "https://api.github.com/users/jgerh/orgs",
"repos_url": "https://api.github.com/users/jgerh/repos",
"events_url": "https://api.github.com/users/jgerh/events{/privacy}",
"received_events_url": "https://api.github.com/users/jgerh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-06T19:15:21 | 2024-12-29T02:03:56 | 2024-12-29T02:03:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11501",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11501",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11501.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11501.patch",
"merged_at": null
} | # What does this PR do ?
Replaced instances of Megatron-LM and Megatron-LM framework reference in docs to Megatron Core
**Collection**: [Note which collection this PR will affect]
# Changelog
- intro.rst
# Usage
no code changes
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [X] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [X] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11501/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11501/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11500 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11500/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11500/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11500/events | https://github.com/NVIDIA/NeMo/pull/11500 | 2,723,746,810 | PR_kwDOC_bI7s6EXUCF | 11,500 | Make HFDatasetDataModule a datasets.load_dataset wrapper | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"datamodule = llm.HFDatasetDataModule(\"rajpurkar/squad\", split=\"train\", pad_token_id=tokenizer.eos_token_id) - this solution enforces using a particular dataset split, \r\n\r\nlooking into finetune_default:\r\n```\r\n # datamodule = run.Config(llm.SquadDataModule, seq_length=2048, global_batch_size=128, micro_batch_size=1)\r\n```\r\n\r\nno split is provided and the the datamodule is able to provide both train and validation dataloaders so that later\r\n\r\n```\r\nrecipe.trainer.val_check_interval = 100\r\n```\r\n\r\ncan control whether validation should be active or not.",
"Hi @danielkorzekwa I would expect the `split` argument to be able to handle split selection, for example, passing a list of splits you want (e.g. `split=['train', 'test']`).\r\n\r\nPlease let me know if that does not work.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:25:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:74:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/peft/hf.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.api\nnemo/collections/llm/gpt/data/api.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:187:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:213:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:217:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:221:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:224:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:227:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:230:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:233:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:45:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:135:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:143:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:229:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:238:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:246:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:264:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:268:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:291:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:294:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:297:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:301:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:328:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:335:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:37:4: W0611: Unused import transformer_engine (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.13/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:25:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:74:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/peft/hf.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.api\nnemo/collections/llm/gpt/data/api.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:187:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:213:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:217:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:221:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:224:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:227:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:230:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:233:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:45:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:135:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:143:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:229:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:238:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:246:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:264:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:268:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:291:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:294:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:297:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:301:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:328:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:335:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:37:4: W0611: Unused import transformer_engine (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.13/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12265154384) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-06T19:11:34 | 2024-12-11T08:37:48 | 2024-12-11T08:37:45 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11500",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11500",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11500.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11500.patch",
"merged_at": "2024-12-11T08:37:45"
} | # What does this PR do ?
Before:
```
dataset = load_dataset("rajpurkar/squad", split="train")
datamodule = llm.HFDatasetDataModule(dataset, pad_token_id=tokenizer.eos_token_id)
```
After:
```
datamodule = llm.HFDatasetDataModule("rajpurkar/squad", split="train", pad_token_id=tokenizer.eos_token_id)
```
Some additional use-cases:
- Load multiple partitions:
```
datamodule = llm.HFDatasetDataModule("rajpurkar/squad", split=["train", "validation"], pad_token_id=tokenizer.eos_token_id)
```
- Custom collate-fn:
```
def my_collate_fn(examples):
....
datamodule = llm.HFDatasetDataModule("rajpurkar/squad", split=["train", "validation"], collate_fn=my_collate_fn)
```
- Custom map function:
```
datamodule = llm.HFDatasetDataModule("rajpurkar/squad", split="train", pad_token_id=tokenizer.eos_token_id)
datamodule.map(formatting_prompts_func, batched=False, batch_size=2)
```
Instead of calling `.map` on the dataset we call it on the datamodule (which forwards it to the dataset).
**Note:** We expect the user to take appropriate care so that the keys in the returned batch (dict of tensors) matches the arguments of the downstream model.
**Collection**: LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11500/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11500/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11499 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11499/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11499/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11499/events | https://github.com/NVIDIA/NeMo/pull/11499 | 2,723,705,737 | PR_kwDOC_bI7s6EXLB3 | 11,499 | readme updates for Q4 2024 | {
"login": "jgerh",
"id": 163925524,
"node_id": "U_kgDOCcVOFA",
"avatar_url": "https://avatars.githubusercontent.com/u/163925524?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jgerh",
"html_url": "https://github.com/jgerh",
"followers_url": "https://api.github.com/users/jgerh/followers",
"following_url": "https://api.github.com/users/jgerh/following{/other_user}",
"gists_url": "https://api.github.com/users/jgerh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jgerh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jgerh/subscriptions",
"organizations_url": "https://api.github.com/users/jgerh/orgs",
"repos_url": "https://api.github.com/users/jgerh/repos",
"events_url": "https://api.github.com/users/jgerh/events{/privacy}",
"received_events_url": "https://api.github.com/users/jgerh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "shashank3959",
"id": 20920371,
"node_id": "MDQ6VXNlcjIwOTIwMzcx",
"avatar_url": "https://avatars.githubusercontent.com/u/20920371?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shashank3959",
"html_url": "https://github.com/shashank3959",
"followers_url": "https://api.github.com/users/shashank3959/followers",
"following_url": "https://api.github.com/users/shashank3959/following{/other_user}",
"gists_url": "https://api.github.com/users/shashank3959/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shashank3959/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shashank3959/subscriptions",
"organizations_url": "https://api.github.com/users/shashank3959/orgs",
"repos_url": "https://api.github.com/users/shashank3959/repos",
"events_url": "https://api.github.com/users/shashank3959/events{/privacy}",
"received_events_url": "https://api.github.com/users/shashank3959/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "shashank3959",
"id": 20920371,
"node_id": "MDQ6VXNlcjIwOTIwMzcx",
"avatar_url": "https://avatars.githubusercontent.com/u/20920371?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shashank3959",
"html_url": "https://github.com/shashank3959",
"followers_url": "https://api.github.com/users/shashank3959/followers",
"following_url": "https://api.github.com/users/shashank3959/following{/other_user}",
"gists_url": "https://api.github.com/users/shashank3959/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shashank3959/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shashank3959/subscriptions",
"organizations_url": "https://api.github.com/users/shashank3959/orgs",
"repos_url": "https://api.github.com/users/shashank3959/repos",
"events_url": "https://api.github.com/users/shashank3959/events{/privacy}",
"received_events_url": "https://api.github.com/users/shashank3959/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "jgerh",
"id": 163925524,
"node_id": "U_kgDOCcVOFA",
"avatar_url": "https://avatars.githubusercontent.com/u/163925524?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jgerh",
"html_url": "https://github.com/jgerh",
"followers_url": "https://api.github.com/users/jgerh/followers",
"following_url": "https://api.github.com/users/jgerh/following{/other_user}",
"gists_url": "https://api.github.com/users/jgerh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jgerh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jgerh/subscriptions",
"organizations_url": "https://api.github.com/users/jgerh/orgs",
"repos_url": "https://api.github.com/users/jgerh/repos",
"events_url": "https://api.github.com/users/jgerh/events{/privacy}",
"received_events_url": "https://api.github.com/users/jgerh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-12-06T18:45:32 | 2025-01-04T00:09:35 | 2025-01-04T00:08:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11499",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11499",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11499.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11499.patch",
"merged_at": null
} | # What does this PR do ?
Updated the readme Latest News section to Q4 2024, revised links, changed playbook references to tutorial references, and made a few copyedits to the text. These updates were requested by Shashank.
**Collection**: [Note which collection this PR will affect]
# Changelog
- modified the readme.md file
# Usage
no code documentation change
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [X] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [X] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "shashank3959",
"id": 20920371,
"node_id": "MDQ6VXNlcjIwOTIwMzcx",
"avatar_url": "https://avatars.githubusercontent.com/u/20920371?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shashank3959",
"html_url": "https://github.com/shashank3959",
"followers_url": "https://api.github.com/users/shashank3959/followers",
"following_url": "https://api.github.com/users/shashank3959/following{/other_user}",
"gists_url": "https://api.github.com/users/shashank3959/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shashank3959/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shashank3959/subscriptions",
"organizations_url": "https://api.github.com/users/shashank3959/orgs",
"repos_url": "https://api.github.com/users/shashank3959/repos",
"events_url": "https://api.github.com/users/shashank3959/events{/privacy}",
"received_events_url": "https://api.github.com/users/shashank3959/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11499/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11499/timeline | null | null | true |
Subsets and Splits