url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/11700 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11700/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11700/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11700/events | https://github.com/NVIDIA/NeMo/issues/11700 | 2,754,551,674 | I_kwDOC_bI7s6kLx96 | 11,700 | IndexError: index 0 is out of bounds for dimension 1 with size 0 | {
"login": "starxa2",
"id": 69345050,
"node_id": "MDQ6VXNlcjY5MzQ1MDUw",
"avatar_url": "https://avatars.githubusercontent.com/u/69345050?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/starxa2",
"html_url": "https://github.com/starxa2",
"followers_url": "https://api.github.com/users/starxa2/followers",
"following_url": "https://api.github.com/users/starxa2/following{/other_user}",
"gists_url": "https://api.github.com/users/starxa2/gists{/gist_id}",
"starred_url": "https://api.github.com/users/starxa2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/starxa2/subscriptions",
"organizations_url": "https://api.github.com/users/starxa2/orgs",
"repos_url": "https://api.github.com/users/starxa2/repos",
"events_url": "https://api.github.com/users/starxa2/events{/privacy}",
"received_events_url": "https://api.github.com/users/starxa2/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [] | 2024-12-22T08:35:34 | 2024-12-22T08:35:34 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null |
File "/opt/conda/lib/python3.10/site-packages/nemo/collections/asr/parts/preprocessing/features.py", line 414, in forward
x = torch.cat((x[:, 0].unsqueeze(1), x[:, 1:] - self.preemph * x[:, :-1]), dim=1)
IndexError: index 0 is out of bounds for dimension 1 with size 0
while training the Conformer Transducer model on ASR Task, the datasets used were ( Indicsuperb, Indicvoices, mucs, shrutilipi, vanni ) | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11700/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11700/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11699 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11699/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11699/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11699/events | https://github.com/NVIDIA/NeMo/pull/11699 | 2,754,417,496 | PR_kwDOC_bI7s6GAJ4u | 11,699 | chore(beep boop 🤖): Bump `MCORE_TAG=d3c585e...` (2024-12-22) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-22T00:25:01 | 2025-01-03T12:55:28 | 2025-01-03T12:55:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11699",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11699",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11699.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11699.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=d3c585e90ebd5937243c8d4c9d5d5cf9d61665d6`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11699/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11699/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11698 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11698/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11698/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11698/events | https://github.com/NVIDIA/NeMo/pull/11698 | 2,754,327,511 | PR_kwDOC_bI7s6F_58H | 11,698 | ci: Update release.yml | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-21T19:25:36 | 2024-12-21T19:27:43 | 2024-12-21T19:27:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11698",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11698",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11698.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11698.patch",
"merged_at": "2024-12-21T19:27:41"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11698/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11698/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11697 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11697/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11697/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11697/events | https://github.com/NVIDIA/NeMo/pull/11697 | 2,754,318,615 | PR_kwDOC_bI7s6F_4f3 | 11,697 | Cherry pick `Bug fix - Inheritance of LLaVATemplateConfig and MLlamaTemplateConfig dataclasses (11661)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12670910330) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-21T19:02:49 | 2025-01-08T21:48:13 | 2025-01-08T21:48:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11697",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11697",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11697.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11697.patch",
"merged_at": "2025-01-08T21:48:12"
} | beep boop [🤖]: Hi @yashaswikarnati 👋,
we've cherry picked #11661 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11697/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11697/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11696 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11696/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11696/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11696/events | https://github.com/NVIDIA/NeMo/pull/11696 | 2,754,311,826 | PR_kwDOC_bI7s6F_3UY | 11,696 | ci: Bump release | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-21T18:44:26 | 2024-12-21T18:44:36 | 2024-12-21T18:44:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11696",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11696",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11696.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11696.patch",
"merged_at": "2024-12-21T18:44:33"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11696/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11696/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11695 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11695/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11695/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11695/events | https://github.com/NVIDIA/NeMo/pull/11695 | 2,753,660,316 | PR_kwDOC_bI7s6F9rD_ | 11,695 | chore(beep boop 🤖): Bump `MCORE_TAG=ca87dcd...` (2024-12-21) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-21T00:22:11 | 2025-01-03T12:55:04 | 2025-01-03T12:55:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11695",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11695",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11695.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11695.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=ca87dcd69727f9d436956a438733b994d13bba44`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11695/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11695/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11694 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11694/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11694/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11694/events | https://github.com/NVIDIA/NeMo/pull/11694 | 2,753,613,468 | PR_kwDOC_bI7s6F9hAd | 11,694 | r2.1.0 ptl fix | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This change made tests pass again, so merging it"
] | 2024-12-20T23:07:27 | 2024-12-21T06:25:04 | 2024-12-21T06:24:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11694",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11694",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11694.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11694.patch",
"merged_at": "2024-12-21T06:24:52"
} | r2.1.0 ptl fix | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11694/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11694/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11693 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11693/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11693/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11693/events | https://github.com/NVIDIA/NeMo/pull/11693 | 2,753,609,070 | PR_kwDOC_bI7s6F9gF- | 11,693 | chore: Bump to `r2.1.0rc2` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-20T23:01:27 | 2024-12-20T23:01:54 | 2024-12-20T23:01:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11693",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11693",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11693.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11693.patch",
"merged_at": "2024-12-20T23:01:48"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11693/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11693/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11692 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11692/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11692/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11692/events | https://github.com/NVIDIA/NeMo/pull/11692 | 2,753,596,916 | PR_kwDOC_bI7s6F9dY0 | 11,692 | Update requirements_lightning.txt | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @pablo-garay 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12443139468) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-20T22:48:54 | 2024-12-21T08:57:21 | 2024-12-21T08:57:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11692",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11692",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11692.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11692.patch",
"merged_at": "2024-12-21T08:57:20"
} | Update requirements_lightning.txt | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11692/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11692/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11691 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11691/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11691/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11691/events | https://github.com/NVIDIA/NeMo/issues/11691 | 2,753,270,962 | I_kwDOC_bI7s6kG5Sy | 11,691 | tutorial notebook fails installing mamba-ssm dependency | {
"login": "jeffgreenca",
"id": 2840857,
"node_id": "MDQ6VXNlcjI4NDA4NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/2840857?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jeffgreenca",
"html_url": "https://github.com/jeffgreenca",
"followers_url": "https://api.github.com/users/jeffgreenca/followers",
"following_url": "https://api.github.com/users/jeffgreenca/following{/other_user}",
"gists_url": "https://api.github.com/users/jeffgreenca/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jeffgreenca/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jeffgreenca/subscriptions",
"organizations_url": "https://api.github.com/users/jeffgreenca/orgs",
"repos_url": "https://api.github.com/users/jeffgreenca/repos",
"events_url": "https://api.github.com/users/jeffgreenca/events{/privacy}",
"received_events_url": "https://api.github.com/users/jeffgreenca/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"did you manage to solve that problem?"
] | 2024-12-20T18:39:13 | 2024-12-30T06:27:58 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Running the first code block of https://colab.research.google.com/github/NVIDIA/NeMo/blob/main/tutorials/00_NeMo_Primer.ipynb
(from commit 24b9e92dae026b5) fails:
```
Building wheels for collected packages: nemo_toolkit, mamba-ssm, antlr4-python3-runtime, progress, clip, fasttext, kaldi-python-io, pesq, rouge_score, sox, texterrors, distance, docopt, intervaltree, asciitree, cdifflib
Building wheel for nemo_toolkit (pyproject.toml) ... done
Created wheel for nemo_toolkit: filename=nemo_toolkit-2.2.0rc0-py3-none-any.whl size=5188616 sha256=379e6a7d97b38bff5aeb42be775e91170ec93aa4d9618e25920fef5d83d70554
Stored in directory: /tmp/pip-ephem-wheel-cache-7_lkbw58/wheels/6c/d2/4f/1572b895b6a4dbd9fdf534c882d9bc6e94e700a6db5bb20423
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Building wheel for mamba-ssm (setup.py) ... error
ERROR: Failed building wheel for mamba-ssm
```
May be related to https://github.com/NVIDIA/NeMo-Curator/issues/399 and also reported by this comment on a closed issue https://github.com/NVIDIA/NeMo/issues/10368#issuecomment-2530053323 | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11691/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11691/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11690 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11690/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11690/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11690/events | https://github.com/NVIDIA/NeMo/issues/11690 | 2,753,265,657 | I_kwDOC_bI7s6kG3_5 | 11,690 | docs.nvidia.com link to tutorial notebooks via `stable` tag, which fail to install dependencies | {
"login": "jeffgreenca",
"id": 2840857,
"node_id": "MDQ6VXNlcjI4NDA4NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/2840857?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jeffgreenca",
"html_url": "https://github.com/jeffgreenca",
"followers_url": "https://api.github.com/users/jeffgreenca/followers",
"following_url": "https://api.github.com/users/jeffgreenca/following{/other_user}",
"gists_url": "https://api.github.com/users/jeffgreenca/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jeffgreenca/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jeffgreenca/subscriptions",
"organizations_url": "https://api.github.com/users/jeffgreenca/orgs",
"repos_url": "https://api.github.com/users/jeffgreenca/repos",
"events_url": "https://api.github.com/users/jeffgreenca/events{/privacy}",
"received_events_url": "https://api.github.com/users/jeffgreenca/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-12-20T18:35:01 | 2025-01-20T01:57:43 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | For new NeMo users following the documentation, the first linked NeMo primer fails.
Starting from here:
https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/starthere/tutorials.html#tutorial-overview
The links in the above page reference the `stable` tag from this repo:
https://colab.research.google.com/github/NVIDIA/NeMo/blob/stable/tutorials/00_NeMo_Primer.ipynb
The commit tagged `stable` still suffers from #10368 causing a failure when trying to run the notebook. | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11690/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11690/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11689 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11689/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11689/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11689/events | https://github.com/NVIDIA/NeMo/pull/11689 | 2,753,202,930 | PR_kwDOC_bI7s6F8GFP | 11,689 | Initial commit | {
"login": "abhinavg4",
"id": 12746692,
"node_id": "MDQ6VXNlcjEyNzQ2Njky",
"avatar_url": "https://avatars.githubusercontent.com/u/12746692?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/abhinavg4",
"html_url": "https://github.com/abhinavg4",
"followers_url": "https://api.github.com/users/abhinavg4/followers",
"following_url": "https://api.github.com/users/abhinavg4/following{/other_user}",
"gists_url": "https://api.github.com/users/abhinavg4/gists{/gist_id}",
"starred_url": "https://api.github.com/users/abhinavg4/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/abhinavg4/subscriptions",
"organizations_url": "https://api.github.com/users/abhinavg4/orgs",
"repos_url": "https://api.github.com/users/abhinavg4/repos",
"events_url": "https://api.github.com/users/abhinavg4/events{/privacy}",
"received_events_url": "https://api.github.com/users/abhinavg4/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.clip.data.mock\nnemo/collections/vlm/clip/data/mock.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/data/mock.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/data/mock.py:85:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/data/mock.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/data/mock.py:95:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/data/mock.py:24:0: W0611: Unused IMAGE_TOKEN_INDEX imported from nemo.collections.vlm.neva.data.multimodal_tokens (unused-import)\n************* Module nemo.collections.vlm.clip.loss.clip_loss\nnemo/collections/vlm/clip/loss/clip_loss.py:170:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/vlm/clip/loss/clip_loss.py:3:0: W0611: Unused Sequence imported from typing (unused-import)\nnemo/collections/vlm/clip/loss/clip_loss.py:20:0: W0611: Unused torch.nn imported as nn (unused-import)\nnemo/collections/vlm/clip/loss/clip_loss.py:26:0: W0611: Unused ReductionT imported from nemo.lightning.megatron_parallel (unused-import)\n************* Module nemo.collections.vlm.clip.model.base\nnemo/collections/vlm/clip/model/base.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/base.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:78:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/base.py:122:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:125:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:136:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/base.py:150:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:178:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/base.py:221:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:228:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:233:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/base.py:244:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:254:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/base.py:271:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:279:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:283:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/base.py:302:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:309:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:322:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:325:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:329:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:335:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/base.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.clip.model.clip\nnemo/collections/vlm/clip/model/clip.py:114:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:115:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:116:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:117:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:122:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:123:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:124:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:125:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:126:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:127:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:132:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:133:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/vlm/clip/model/clip.py:43:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/clip.py:65:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/clip.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/clip/model/clip.py:93:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/clip.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/clip.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/clip/model/clip.py:282:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.02/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-20T17:51:24 | 2025-01-11T01:58:30 | 2025-01-11T01:58:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11689",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11689",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11689.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11689.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11689/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11689/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11688 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11688/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11688/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11688/events | https://github.com/NVIDIA/NeMo/pull/11688 | 2,753,149,106 | PR_kwDOC_bI7s6F76HG | 11,688 | Drop unexpected parameters directly on loading config | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12463417210) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"Hey @hemildesai. CI passed, this is ready. Would you approve the change?"
] | 2024-12-20T17:20:20 | 2025-01-03T16:20:28 | 2025-01-03T16:20:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11688",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11688",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11688.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11688.patch",
"merged_at": "2025-01-03T16:20:27"
} | # What does this PR do ?
Follow up to https://github.com/NVIDIA/NeMo/pull/11648 to remove deprecated params from the Fiddle config on the fly rather than use auxiliary script.
**Collection**: LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11688/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11688/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11687 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11687/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11687/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11687/events | https://github.com/NVIDIA/NeMo/pull/11687 | 2,752,498,458 | PR_kwDOC_bI7s6F5qah | 11,687 | moe fp8 | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.base\nnemo/collections/llm/gpt/model/base.py:231:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/llm/gpt/model/base.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:94:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:126:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:142:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:152:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:162:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:186:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:257:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:269:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:281:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:293:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:305:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:317:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:331:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:349:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:353:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:376:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:379:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:382:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:386:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:391:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:412:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:419:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:426:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:454:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:43:4: W0611: Unused import fused_weight_gradient_mlp_cuda (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.88/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @malay-nagda 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12470727491) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-20T11:03:04 | 2024-12-23T22:08:09 | 2024-12-23T22:08:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11687",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11687",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11687.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11687.patch",
"merged_at": "2024-12-23T22:08:07"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11687/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11687/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11686 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11686/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11686/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11686/events | https://github.com/NVIDIA/NeMo/pull/11686 | 2,752,278,521 | PR_kwDOC_bI7s6F46Rs | 11,686 | ci: Bump release workflow | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-20T09:09:13 | 2024-12-20T09:09:26 | 2024-12-20T09:09:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11686",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11686",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11686.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11686.patch",
"merged_at": "2024-12-20T09:09:20"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11686/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11686/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11685 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11685/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11685/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11685/events | https://github.com/NVIDIA/NeMo/pull/11685 | 2,752,108,639 | PR_kwDOC_bI7s6F4VEs | 11,685 | Cherry pick `Rename multimodal data module - EnergonMultiModalDataModule (11654)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12427283285) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-20T07:20:39 | 2024-12-20T14:02:49 | 2024-12-20T13:18:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11685",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11685",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11685.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11685.patch",
"merged_at": "2024-12-20T13:18:29"
} | beep boop [🤖]: Hi @yashaswikarnati 👋,
we've cherry picked #11654 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11685/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11685/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11684 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11684/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11684/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11684/events | https://github.com/NVIDIA/NeMo/issues/11684 | 2,752,052,215 | I_kwDOC_bI7s6kCPv3 | 11,684 | SymbolicValueError: STFT does not currently support complex types | {
"login": "kabyanil",
"id": 24878109,
"node_id": "MDQ6VXNlcjI0ODc4MTA5",
"avatar_url": "https://avatars.githubusercontent.com/u/24878109?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kabyanil",
"html_url": "https://github.com/kabyanil",
"followers_url": "https://api.github.com/users/kabyanil/followers",
"following_url": "https://api.github.com/users/kabyanil/following{/other_user}",
"gists_url": "https://api.github.com/users/kabyanil/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kabyanil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kabyanil/subscriptions",
"organizations_url": "https://api.github.com/users/kabyanil/orgs",
"repos_url": "https://api.github.com/users/kabyanil/repos",
"events_url": "https://api.github.com/users/kabyanil/events{/privacy}",
"received_events_url": "https://api.github.com/users/kabyanil/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-12-20T06:38:13 | 2025-01-20T01:57:44 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I am trying to export the preprocessor class of Quartznet model to onnx. My requirement is to run preprocessing in a non-python environment. However, the export is failing.
**Steps/Code to reproduce bug**
The bug can be reproduced using the following code -
```
quartznet = nemo_asr.models.EncDecCTCModel.from_pretrained(model_name="QuartzNet15x5Base-En")
preprocessor = quartznet.preprocessor.to(device)
preprocessor.eval()
preprocessor.export("prep.onnx", onnx_opset_version=17)
```
The following error is produced:
```
{
"name": "SymbolicValueError",
"message": "STFT does not currently support complex types [Caused by the value '97 defined in (%97 : Float(*, *, strides=[2946, 1], requires_grad=0, device=cpu) = onnx::Reshape[allowzero=0](%86, %96), scope: nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor::/nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures::featurizer # /home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/functional.py:703:0
)' (type 'Tensor') in the TorchScript graph. The containing node has kind 'onnx::Reshape'.]
(node defined in /home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/functional.py(703): stft
/home/ik/Documents/aakhor/asr/NeMo/nemo/collections/asr/parts/preprocessing/features.py(308): <lambda>
/home/ik/Documents/aakhor/asr/NeMo/nemo/collections/asr/parts/preprocessing/features.py(423): forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/utils/_contextlib.py(116): decorate_context
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1726): _slow_forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1747): _call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1736): _wrapped_call_impl
/home/ik/Documents/aakhor/asr/NeMo/nemo/collections/asr/modules/audio_preprocessing.py(292): get_features
/home/ik/Documents/aakhor/asr/NeMo/nemo/collections/asr/modules/audio_preprocessing.py(91): forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/utils/_contextlib.py(116): decorate_context
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1726): _slow_forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1747): _call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1736): _wrapped_call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/jit/_trace.py(130): wrapper
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/jit/_trace.py(139): forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1747): _call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1736): _wrapped_call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/jit/_trace.py(1500): _get_trace_graph
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(904): _trace_and_get_graph_from_model
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(997): _create_jit_graph
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(1113): _model_to_graph
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(1564): _export
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(502): export
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/__init__.py(375): export
/home/ik/Documents/aakhor/asr/NeMo/nemo/core/classes/exportable.py(221): _export
/home/ik/Documents/aakhor/asr/NeMo/nemo/core/classes/exportable.py(114): export
/tmp/ipykernel_10033/3317768717.py(8): <module>
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3577): run_code
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3517): run_ast_nodes
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3334): run_cell_async
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/async_helpers.py(128): _pseudo_sync_runner
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3130): _run_cell
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3075): run_cell
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/zmqshell.py(549): run_cell
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/ipkernel.py(449): do_execute
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelbase.py(778): execute_request
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/ipkernel.py(362): execute_request
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelbase.py(437): dispatch_shell
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelbase.py(534): process_one
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelbase.py(545): dispatch_queue
/home/ik/miniconda3/envs/nemo/lib/python3.11/asyncio/events.py(84): _run
/home/ik/miniconda3/envs/nemo/lib/python3.11/asyncio/base_events.py(1936): _run_once
/home/ik/miniconda3/envs/nemo/lib/python3.11/asyncio/base_events.py(608): run_forever
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/tornado/platform/asyncio.py(205): start
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelapp.py(739): start
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/traitlets/config/application.py(1075): launch_instance
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel_launcher.py(18): <module>
<frozen runpy>(88): _run_code
<frozen runpy>(198): _run_module_as_main
)
Inputs:
#0: 86 defined in (%86 : Float(*, *, *, strides=[2946, 2946, 1], requires_grad=0, device=cpu) = onnx::Pad[mode=\"reflect\"](%59, %85), scope: nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor::/nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures::featurizer # /home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/functional.py:5096:0
) (type 'Tensor')
#1: 96 defined in (%96 : int[] = prim::ListConstruct(%90, %95), scope: nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor::/nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures::featurizer
) (type 'List[int]')
Outputs:
#0: 97 defined in (%97 : Float(*, *, strides=[2946, 1], requires_grad=0, device=cpu) = onnx::Reshape[allowzero=0](%86, %96), scope: nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor::/nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures::featurizer # /home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/functional.py:703:0
) (type 'Tensor')",
"stack": "---------------------------------------------------------------------------
SymbolicValueError Traceback (most recent call last)
Cell In[10], line 8
4 preprocessor = quartznet.preprocessor.to(device)
6 preprocessor.eval()
----> 8 preprocessor.export(\"prep.onnx\", onnx_opset_version=18)
File ~/Documents/aakhor/asr/NeMo/nemo/core/classes/exportable.py:114, in Exportable.export(self, output, input_example, verbose, do_constant_folding, onnx_opset_version, check_trace, dynamic_axes, check_tolerance, export_modules_as_functions, keep_initializers_as_inputs)
112 model = self.get_export_subnet(subnet_name)
113 out_name = augment_filename(output, subnet_name)
--> 114 out, descr, out_example = model._export(
115 out_name,
116 input_example=input_example,
117 verbose=verbose,
118 do_constant_folding=do_constant_folding,
119 onnx_opset_version=onnx_opset_version,
120 check_trace=check_trace,
121 dynamic_axes=dynamic_axes,
122 check_tolerance=check_tolerance,
123 export_modules_as_functions=export_modules_as_functions,
124 keep_initializers_as_inputs=keep_initializers_as_inputs,
125 )
126 # Propagate input example (default scenario, may need to be overriden)
127 if input_example is not None:
File ~/Documents/aakhor/asr/NeMo/nemo/core/classes/exportable.py:221, in Exportable._export(self, output, input_example, verbose, do_constant_folding, onnx_opset_version, check_trace, dynamic_axes, check_tolerance, export_modules_as_functions, keep_initializers_as_inputs)
219 dynamic_axes = get_dynamic_axes(self.input_module.input_types_for_export, input_names)
220 dynamic_axes.update(get_dynamic_axes(self.output_module.output_types_for_export, output_names))
--> 221 torch.onnx.export(
222 jitted_model,
223 input_example,
224 output,
225 input_names=input_names,
226 output_names=output_names,
227 verbose=verbose,
228 do_constant_folding=do_constant_folding,
229 dynamic_axes=dynamic_axes,
230 opset_version=onnx_opset_version,
231 keep_initializers_as_inputs=keep_initializers_as_inputs,
232 export_modules_as_functions=export_modules_as_functions,
233 )
235 if check_trace:
236 verify_runtime(self, output, check_trace_input, input_names, check_tolerance=check_tolerance)
File ~/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/__init__.py:375, in export(model, args, f, kwargs, export_params, verbose, input_names, output_names, opset_version, dynamic_axes, keep_initializers_as_inputs, dynamo, external_data, dynamic_shapes, report, verify, profile, dump_exported_program, artifacts_dir, fallback, training, operator_export_type, do_constant_folding, custom_opsets, export_modules_as_functions, autograd_inlining, **_)
369 if dynamic_shapes:
370 raise ValueError(
371 \"The exporter only supports dynamic shapes \"
372 \"through parameter dynamic_axes when dynamo=False.\"
373 )
--> 375 export(
376 model,
377 args,
378 f, # type: ignore[arg-type]
379 kwargs=kwargs,
380 export_params=export_params,
381 verbose=verbose is True,
382 input_names=input_names,
383 output_names=output_names,
384 opset_version=opset_version,
385 dynamic_axes=dynamic_axes,
386 keep_initializers_as_inputs=keep_initializers_as_inputs,
387 training=training,
388 operator_export_type=operator_export_type,
389 do_constant_folding=do_constant_folding,
390 custom_opsets=custom_opsets,
391 export_modules_as_functions=export_modules_as_functions,
392 autograd_inlining=autograd_inlining,
393 )
394 return None
File ~/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py:502, in export(model, args, f, kwargs, export_params, verbose, training, input_names, output_names, operator_export_type, opset_version, do_constant_folding, dynamic_axes, keep_initializers_as_inputs, custom_opsets, export_modules_as_functions, autograd_inlining)
499 if kwargs is not None:
500 args = args + (kwargs,)
--> 502 _export(
503 model,
504 args,
505 f,
506 export_params,
507 verbose,
508 training,
509 input_names,
510 output_names,
511 operator_export_type=operator_export_type,
512 opset_version=opset_version,
513 do_constant_folding=do_constant_folding,
514 dynamic_axes=dynamic_axes,
515 keep_initializers_as_inputs=keep_initializers_as_inputs,
516 custom_opsets=custom_opsets,
517 export_modules_as_functions=export_modules_as_functions,
518 autograd_inlining=autograd_inlining,
519 )
521 return None
File ~/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py:1564, in _export(model, args, f, export_params, verbose, training, input_names, output_names, operator_export_type, export_type, opset_version, do_constant_folding, dynamic_axes, keep_initializers_as_inputs, fixed_batch_size, custom_opsets, add_node_names, onnx_shape_inference, export_modules_as_functions, autograd_inlining)
1561 dynamic_axes = {}
1562 _validate_dynamic_axes(dynamic_axes, model, input_names, output_names)
-> 1564 graph, params_dict, torch_out = _model_to_graph(
1565 model,
1566 args,
1567 verbose,
1568 input_names,
1569 output_names,
1570 operator_export_type,
1571 val_do_constant_folding,
1572 fixed_batch_size=fixed_batch_size,
1573 training=training,
1574 dynamic_axes=dynamic_axes,
1575 )
1577 # TODO: Don't allocate a in-memory string for the protobuf
1578 defer_weight_export = (
1579 export_type is not _exporter_states.ExportTypes.PROTOBUF_FILE
1580 )
File ~/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py:1117, in _model_to_graph(model, args, verbose, input_names, output_names, operator_export_type, do_constant_folding, _disable_torch_constant_prop, fixed_batch_size, training, dynamic_axes)
1114 params_dict = _get_named_param_dict(graph, params)
1116 try:
-> 1117 graph = _optimize_graph(
1118 graph,
1119 operator_export_type,
1120 _disable_torch_constant_prop=_disable_torch_constant_prop,
1121 fixed_batch_size=fixed_batch_size,
1122 params_dict=params_dict,
1123 dynamic_axes=dynamic_axes,
1124 input_names=input_names,
1125 module=module,
1126 )
1127 except Exception as e:
1128 torch.onnx.log(\"Torch IR graph at exception: \", graph)
File ~/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py:639, in _optimize_graph(graph, operator_export_type, _disable_torch_constant_prop, fixed_batch_size, params_dict, dynamic_axes, input_names, module)
636 _C._jit_pass_onnx_set_dynamic_input_shape(graph, dynamic_axes, input_names)
637 _C._jit_pass_onnx_lint(graph)
--> 639 graph = _C._jit_pass_onnx(graph, operator_export_type)
640 _C._jit_pass_onnx_lint(graph)
641 _C._jit_pass_lint(graph)
File ~/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py:1836, in _run_symbolic_function(graph, block, node, inputs, env, values_in_env, new_nodes, operator_export_type)
1831 if symbolic_fn is not None:
1832 # TODO Wrap almost identical attrs assignment or comment the difference.
1833 attrs = {
1834 k: symbolic_helper._node_get(node, k) for k in node.attributeNames()
1835 }
-> 1836 return symbolic_fn(graph_context, *inputs, **attrs)
1838 attrs = {
1839 k + \"_\" + node.kindOf(k)[0]: symbolic_helper._node_get(node, k)
1840 for k in node.attributeNames()
1841 }
1842 if namespace == \"onnx\":
1843 # Clone node to trigger ONNX shape inference
File ~/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/symbolic_helper.py:281, in parse_args.<locals>.decorator.<locals>.wrapper(g, *args, **kwargs)
275 if len(kwargs) == 1:
276 assert \"_outputs\" in kwargs, (
277 f\"Symbolic function {fn.__name__}'s '**kwargs' can only contain \"
278 f\"'_outputs' key at '**kwargs'. \"
279 f\"{FILE_BUG_MSG}\"
280 )
--> 281 return fn(g, *args, **kwargs)
File ~/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/symbolic_opset17.py:135, in stft(g, input, n_fft, hop_length, win_length, window, normalized, onesided, return_complex)
133 # Checks
134 if return_complex:
--> 135 raise errors.SymbolicValueError(
136 msg=\"STFT does not currently support complex types\", value=input
137 )
139 # Get STFT sizes
140 frame_step_value = hop_length if hop_length is not None else n_fft // 4
SymbolicValueError: STFT does not currently support complex types [Caused by the value '97 defined in (%97 : Float(*, *, strides=[2946, 1], requires_grad=0, device=cpu) = onnx::Reshape[allowzero=0](%86, %96), scope: nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor::/nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures::featurizer # /home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/functional.py:703:0
)' (type 'Tensor') in the TorchScript graph. The containing node has kind 'onnx::Reshape'.]
(node defined in /home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/functional.py(703): stft
/home/ik/Documents/aakhor/asr/NeMo/nemo/collections/asr/parts/preprocessing/features.py(308): <lambda>
/home/ik/Documents/aakhor/asr/NeMo/nemo/collections/asr/parts/preprocessing/features.py(423): forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/utils/_contextlib.py(116): decorate_context
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1726): _slow_forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1747): _call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1736): _wrapped_call_impl
/home/ik/Documents/aakhor/asr/NeMo/nemo/collections/asr/modules/audio_preprocessing.py(292): get_features
/home/ik/Documents/aakhor/asr/NeMo/nemo/collections/asr/modules/audio_preprocessing.py(91): forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/utils/_contextlib.py(116): decorate_context
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1726): _slow_forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1747): _call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1736): _wrapped_call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/jit/_trace.py(130): wrapper
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/jit/_trace.py(139): forward
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1747): _call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/modules/module.py(1736): _wrapped_call_impl
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/jit/_trace.py(1500): _get_trace_graph
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(904): _trace_and_get_graph_from_model
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(997): _create_jit_graph
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(1113): _model_to_graph
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(1564): _export
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/utils.py(502): export
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/onnx/__init__.py(375): export
/home/ik/Documents/aakhor/asr/NeMo/nemo/core/classes/exportable.py(221): _export
/home/ik/Documents/aakhor/asr/NeMo/nemo/core/classes/exportable.py(114): export
/tmp/ipykernel_10033/3317768717.py(8): <module>
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3577): run_code
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3517): run_ast_nodes
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3334): run_cell_async
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/async_helpers.py(128): _pseudo_sync_runner
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3130): _run_cell
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/IPython/core/interactiveshell.py(3075): run_cell
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/zmqshell.py(549): run_cell
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/ipkernel.py(449): do_execute
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelbase.py(778): execute_request
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/ipkernel.py(362): execute_request
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelbase.py(437): dispatch_shell
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelbase.py(534): process_one
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelbase.py(545): dispatch_queue
/home/ik/miniconda3/envs/nemo/lib/python3.11/asyncio/events.py(84): _run
/home/ik/miniconda3/envs/nemo/lib/python3.11/asyncio/base_events.py(1936): _run_once
/home/ik/miniconda3/envs/nemo/lib/python3.11/asyncio/base_events.py(608): run_forever
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/tornado/platform/asyncio.py(205): start
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel/kernelapp.py(739): start
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/traitlets/config/application.py(1075): launch_instance
/home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/ipykernel_launcher.py(18): <module>
<frozen runpy>(88): _run_code
<frozen runpy>(198): _run_module_as_main
)
Inputs:
#0: 86 defined in (%86 : Float(*, *, *, strides=[2946, 2946, 1], requires_grad=0, device=cpu) = onnx::Pad[mode=\"reflect\"](%59, %85), scope: nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor::/nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures::featurizer # /home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/nn/functional.py:5096:0
) (type 'Tensor')
#1: 96 defined in (%96 : int[] = prim::ListConstruct(%90, %95), scope: nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor::/nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures::featurizer
) (type 'List[int]')
Outputs:
#0: 97 defined in (%97 : Float(*, *, strides=[2946, 1], requires_grad=0, device=cpu) = onnx::Reshape[allowzero=0](%86, %96), scope: nemo.collections.asr.modules.audio_preprocessing.AudioToMelSpectrogramPreprocessor::/nemo.collections.asr.parts.preprocessing.features.FilterbankFeatures::featurizer # /home/ik/miniconda3/envs/nemo/lib/python3.11/site-packages/torch/functional.py:703:0
) (type 'Tensor')"
}
```
**Expected behavior**
The preprocessor should export to onnx successfully.
**Environment overview (please complete the following information)**
- Environment location: Local Ubuntu 22.04
- Method of NeMo install: from source using pip. Installed in editable mode.
**Environment details**
- OS version Ubuntu 22.04
- PyTorch version 2.5.1+cu124
- Python version 3.11.10
**Additional context**
The full model exports fine though. But that does not contain the preprocessor.
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11684/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11684/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11683 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11683/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11683/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11683/events | https://github.com/NVIDIA/NeMo/issues/11683 | 2,751,983,865 | I_kwDOC_bI7s6kB_D5 | 11,683 | Which version of transformer engine should I use, when I try to open ub_tp_comm_overlap? | {
"login": "sallyjunjun",
"id": 72725839,
"node_id": "MDQ6VXNlcjcyNzI1ODM5",
"avatar_url": "https://avatars.githubusercontent.com/u/72725839?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sallyjunjun",
"html_url": "https://github.com/sallyjunjun",
"followers_url": "https://api.github.com/users/sallyjunjun/followers",
"following_url": "https://api.github.com/users/sallyjunjun/following{/other_user}",
"gists_url": "https://api.github.com/users/sallyjunjun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sallyjunjun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sallyjunjun/subscriptions",
"organizations_url": "https://api.github.com/users/sallyjunjun/orgs",
"repos_url": "https://api.github.com/users/sallyjunjun/repos",
"events_url": "https://api.github.com/users/sallyjunjun/events{/privacy}",
"received_events_url": "https://api.github.com/users/sallyjunjun/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-12-20T05:40:25 | 2025-01-20T01:57:45 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am using NeMo with version v2.0.0rc0. When I set ub_tp_comm_overlap to true with tp and sp 2, I met the following error:
The version of transformer engine 1.6.0+c81733f. Should I update to newer te version?
When I update transformer engine to 1.13.0+e5edd6c. There occurs another error in NeMo:
CUDA 11.8 should be used in NeMo. But transformer engine in 1.13.0+e5edd6c version requires CUDA newer than 12.0.
I'm stuck in these version issues.
Could you please tell me which version of NeMo and TE and CUDA should I use to enable tp_comm_overlap feature? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11683/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11683/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11682 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11682/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11682/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11682/events | https://github.com/NVIDIA/NeMo/pull/11682 | 2,751,950,082 | PR_kwDOC_bI7s6F3yLM | 11,682 | Cherry pick `Add check for symlink in extraction of nemo files (11611)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.core.connectors.save_restore_connector\nnemo/core/connectors/save_restore_connector.py:50:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:203:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:302:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:416:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:421:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/connectors/save_restore_connector.py:690:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:698:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:706:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:714:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.69/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.core.connectors.save_restore_connector\nnemo/core/connectors/save_restore_connector.py:50:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:203:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:302:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:416:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:421:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/connectors/save_restore_connector.py:690:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:698:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:706:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:714:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.69/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Cherry picked in #11680 "
] | 2024-12-20T05:08:16 | 2024-12-20T20:51:35 | 2024-12-20T20:51:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11682",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11682",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11682.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11682.patch",
"merged_at": null
} | beep boop [🤖]: Hi @athitten 👋,
we've cherry picked #11611 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11682/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11682/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11681 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11681/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11681/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11681/events | https://github.com/NVIDIA/NeMo/pull/11681 | 2,751,852,621 | PR_kwDOC_bI7s6F3dK5 | 11,681 | Cherry pick `NIM supporting changes for nemo.export for NeMo 2.0 (part II) (11669)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:87:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:103:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:121:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:127:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:132:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:143:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:174:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:181:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:195:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:199:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:208:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:233:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:265:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:360:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:478:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:562:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:566:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:577:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:589:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:629:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:666:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:679:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:27:0: W0611: Unused import tensorstore (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.35/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:87:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:103:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:121:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:127:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:132:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:143:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:174:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:181:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:195:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:199:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:208:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:233:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:265:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:360:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:478:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:562:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:566:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:577:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:589:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:629:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:666:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:679:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:27:0: W0611: Unused import tensorstore (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.35/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"To be closed based on https://github.com/NVIDIA/NeMo/pull/11680"
] | 2024-12-20T03:27:14 | 2024-12-20T16:40:48 | 2024-12-20T16:40:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11681",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11681",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11681.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11681.patch",
"merged_at": null
} | beep boop [🤖]: Hi @janekl 👋,
we've cherry picked #11669 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11681/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11681/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11680 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11680/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11680/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11680/events | https://github.com/NVIDIA/NeMo/pull/11680 | 2,751,784,648 | PR_kwDOC_bI7s6F3OkB | 11,680 | r2.1.0 cherrypick | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.core.connectors.save_restore_connector\nnemo/core/connectors/save_restore_connector.py:50:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:203:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:302:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:416:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:421:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/connectors/save_restore_connector.py:690:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:698:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:706:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:714:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:87:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:103:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:121:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:127:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:132:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:143:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:174:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:181:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:195:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:199:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:208:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:233:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:265:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:360:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:478:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:562:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:566:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:577:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:589:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:629:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:666:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:679:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:27:0: W0611: Unused import tensorstore (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.73/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @pablo-garay 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12425012187) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"CI passed : https://github.com/NVIDIA/NeMo/actions/runs/12425012187"
] | 2024-12-20T02:25:31 | 2024-12-20T13:09:24 | 2024-12-20T13:09:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11680",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11680",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11680.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11680.patch",
"merged_at": "2024-12-20T13:09:23"
} | r2.1.0 cherrypick
https://github.com/NVIDIA/NeMo/pull/11679
https://github.com/NVIDIA/NeMo/pull/11662 | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11680/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 1,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11680/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11679 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11679/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11679/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11679/events | https://github.com/NVIDIA/NeMo/pull/11679 | 2,751,759,031 | PR_kwDOC_bI7s6F3JOr | 11,679 | Cherry pick `Utilities to detect and drop deprecated arguments from NeMo 2.0 checkpoint context io.json (11648)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"To close based on https://github.com/NVIDIA/NeMo/pull/11680?"
] | 2024-12-20T01:55:25 | 2024-12-20T16:41:03 | 2024-12-20T16:41:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11679",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11679",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11679.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11679.patch",
"merged_at": null
} | beep boop [🤖]: Hi @janekl 👋,
we've cherry picked #11648 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11679/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11679/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11678 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11678/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11678/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11678/events | https://github.com/NVIDIA/NeMo/pull/11678 | 2,751,755,676 | PR_kwDOC_bI7s6F3Ihu | 11,678 | Add options to assign vocab and mergers file for mockdatamoddule | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module pretraining\nscripts/llm/pretraining.py:35:0: C0301: Line too long (151/119) (line-too-long)\nscripts/llm/pretraining.py:144:0: C0301: Line too long (142/119) (line-too-long)\nscripts/llm/pretraining.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:119:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:22:0: W0611: Unused Any imported from typing (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.79/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.data.mock\nnemo/collections/llm/gpt/data/mock.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/data/mock.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/mock.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/mock.py:95:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/mock.py:100:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.37/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @BoxiangW 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12424276995) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-20T01:51:25 | 2024-12-23T22:42:54 | 2024-12-23T22:42:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11678",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11678",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11678.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11678.patch",
"merged_at": "2024-12-23T22:42:53"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11678/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11678/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11677 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11677/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11677/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11677/events | https://github.com/NVIDIA/NeMo/pull/11677 | 2,751,737,979 | PR_kwDOC_bI7s6F3EwF | 11,677 | Cherry pick `Downgrading the 'datasets' package from 3.0.0 to 2.21.0 for Multilang_ASR.ipynb and ASR_CTC_Language_Finetuning.ipynb (11675)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-20T01:32:38 | 2024-12-20T01:38:31 | 2024-12-20T01:38:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11677",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11677",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11677.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11677.patch",
"merged_at": "2024-12-20T01:38:29"
} | beep boop [🤖]: Hi @weiqingw4ng 👋,
we've cherry picked #11675 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11677/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11677/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11676 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11676/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11676/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11676/events | https://github.com/NVIDIA/NeMo/pull/11676 | 2,751,688,545 | PR_kwDOC_bI7s6F25tP | 11,676 | Enable precision-aware optimizer with TE.optim | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-20T00:58:56 | 2025-01-10T02:00:09 | 2025-01-10T02:00:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11676",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11676",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11676.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11676.patch",
"merged_at": null
} | # What does this PR do ?
Interface for precision-aware optimizer that uses Transformer Engin optimizer.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add the interface to enable precision-aware optimizer at both nemo 1.0 and 2.0
# Usage
- Set `recipe.optim.config.use_precision_aware_optimizer` for nemo 2.0
- Set `model.optim.use_precision_aware_optimizer` for nemo 1.0
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11676/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11676/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11675 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11675/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11675/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11675/events | https://github.com/NVIDIA/NeMo/pull/11675 | 2,751,680,371 | PR_kwDOC_bI7s6F239i | 11,675 | Downgrading the 'datasets' package from 3.0.0 to 2.21.0 for Multilang_ASR.ipynb and ASR_CTC_Language_Finetuning.ipynb | {
"login": "weiqingw4ng",
"id": 164252040,
"node_id": "U_kgDOCcpJiA",
"avatar_url": "https://avatars.githubusercontent.com/u/164252040?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/weiqingw4ng",
"html_url": "https://github.com/weiqingw4ng",
"followers_url": "https://api.github.com/users/weiqingw4ng/followers",
"following_url": "https://api.github.com/users/weiqingw4ng/following{/other_user}",
"gists_url": "https://api.github.com/users/weiqingw4ng/gists{/gist_id}",
"starred_url": "https://api.github.com/users/weiqingw4ng/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/weiqingw4ng/subscriptions",
"organizations_url": "https://api.github.com/users/weiqingw4ng/orgs",
"repos_url": "https://api.github.com/users/weiqingw4ng/repos",
"events_url": "https://api.github.com/users/weiqingw4ng/events{/privacy}",
"received_events_url": "https://api.github.com/users/weiqingw4ng/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-20T00:49:14 | 2024-12-20T01:32:12 | 2024-12-20T01:32:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11675",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11675",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11675.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11675.patch",
"merged_at": "2024-12-20T01:32:12"
} | # What does this PR do ?
'[datasets](https://pypi.org/project/datasets/#history)' recently released the latest version `3.0.0` on Sep 11th, but some HF datasets (e.g., [MCV 3.0](https://huggingface.co/datasets/mozilla-foundation/common_voice_3_0), [MCV 6.1](https://huggingface.co/datasets/mozilla-foundation/common_voice_6_1)) do not update their code for the latest version. Attempting to download these MCV datasets using datasets `3.0.0` results in the following error:
`TypeError: DownloadConfig.__init__() got an unexpected keyword argument 'ignore_url_params'.`
As a workaround, we need to downgrade the datasets package to version `2.21.0` in some tutorial notebooks. Please check the first block of each notebook for this change.
**Collection**: [Note which collection this PR will affect]
NeMo/tutorial/asr
# Changelog
Adding `!pip install datasets==2.21.0` in the first block of each tutorial.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
Although unrelated to this PR, I wanted to highlight an issue encountered when calling Trainer.test() multiple times. In the `Multilang_ASR.ipynb` notebook, this sometimes results in a `RuntimeError: CUDA error: an illegal memory access was encountered` error in certain containers with specific PyTorch versions. This behavior has been verified in containers `24.06` and `24.12-rc0` (`nvcr.io/nvidia/nemo:24.12-rc0`), though it does not occur consistently and does not appear in other containers like `24.05` (`nvcr.io/nvidia/nemo:24.05`). A similar issue has been documented [here](https://github.com/pytorch/pytorch/issues/130615) with the `24.06` container (`nvcr.io/nvidia/pytorch:24.06-py3`). Testing is ongoing, but the root cause has not yet been identified.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11675/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11675/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11674 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11674/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11674/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11674/events | https://github.com/NVIDIA/NeMo/pull/11674 | 2,751,656,702 | PR_kwDOC_bI7s6F2y26 | 11,674 | chore(beep boop 🤖): Bump `MCORE_TAG=7efaa73...` (2024-12-20) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-20T00:22:46 | 2025-01-03T12:55:00 | 2025-01-03T12:55:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11674",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11674",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11674.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11674.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=7efaa73405e9d5e5c0c17fa09a7bb951caa3641a`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11674/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11674/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11673 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11673/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11673/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11673/events | https://github.com/NVIDIA/NeMo/pull/11673 | 2,751,358,949 | PR_kwDOC_bI7s6F1w_8 | 11,673 | add pretrain tests for hf | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.recipes.hf_auto_model_for_causal_lm\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:100:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:153:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:194:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:20:0: W0611: Unused import torch (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.95/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.recipes.hf_auto_model_for_causal_lm\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:100:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:153:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:194:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:20:0: W0611: Unused import torch (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.95/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12642219341) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-19T20:29:41 | 2025-01-07T17:46:16 | 2025-01-07T17:46:14 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11673",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11673",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11673.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11673.patch",
"merged_at": "2025-01-07T17:46:14"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11673/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11673/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11672 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11672/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11672/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11672/events | https://github.com/NVIDIA/NeMo/pull/11672 | 2,751,278,598 | PR_kwDOC_bI7s6F1exD | 11,672 | Add multi images support for mllama generate | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @meatybobby 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12436720313) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-19T19:45:52 | 2024-12-20T23:25:33 | 2024-12-20T23:25:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11672",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11672",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11672.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11672.patch",
"merged_at": "2024-12-20T23:25:31"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11672/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11672/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11671 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11671/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11671/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11671/events | https://github.com/NVIDIA/NeMo/pull/11671 | 2,751,250,106 | PR_kwDOC_bI7s6F1Yb9 | 11,671 | Fixing the device assignment issues during inference (test_batch) in Sortformer model | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-19T19:27:42 | 2024-12-20T12:27:11 | 2024-12-20T12:27:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11671",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11671",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11671.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11671.patch",
"merged_at": "2024-12-20T12:27:11"
} | # What does this PR do ?
Fixing the device assignment issues during inference (test_batch) in Sortformer model
**Collection**:
ASR/speaker_tasks
# Changelog
- removed redundant device assignment in `audio_to_diar_labels.py`
- added `targets.to(self.device)` in `sortformer_diar_models.py`
# Usage
```python
python $BASEPATH/neural_diarizer/e2e_diarize_speech.py \
model_path=/path/to/diar_sortformer_4spk_v1.nemo \
batch_size=1 \
dataset_manifest=/path/to/diarization_manifest.json
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11671/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11671/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11670 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11670/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11670/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11670/events | https://github.com/NVIDIA/NeMo/pull/11670 | 2,751,239,050 | PR_kwDOC_bI7s6F1V9t | 11,670 | Remove NeMo 1 docs | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-19T19:20:22 | 2024-12-19T20:54:02 | 2024-12-19T20:54:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11670",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11670",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11670.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11670.patch",
"merged_at": "2024-12-19T20:54:00"
} | # What does this PR do ?
Equivalent docs in NeMo 2:
dev_guide.rst -- https://docs.nvidia.com/nemo-framework/user-guide/latest/nemo-2.0/features/hf-integration.html#create-a-model-importer
user_guide.rst -- https://docs.nvidia.com/nemo-framework/user-guide/latest/nemo-2.0/features/hf-integration.html#fine-tune-a-model-using-a-hugging-face-checkpoint
sequence_packing.rst -- https://docs.nvidia.com/nemo-framework/user-guide/latest/sft_peft/packed_sequence.html (staging)
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11670/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11670/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11669 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11669/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11669/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11669/events | https://github.com/NVIDIA/NeMo/pull/11669 | 2,750,930,820 | PR_kwDOC_bI7s6F0Qr4 | 11,669 | NIM supporting changes for nemo.export for NeMo 2.0 (part II) | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12417910494) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-19T16:54:01 | 2024-12-20T03:26:49 | 2024-12-20T03:26:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11669",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11669",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11669.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11669.patch",
"merged_at": "2024-12-20T03:26:48"
} | # What does this PR do ?
* Allowing to instantiate tokenizer for 2.0 checkpoints in `nemo.export` in limited environment w/o full nemo_toolkit>=2.0
* Removing direct import of `tensorrt_lazy_compiler` in `nemo.export` as in turn it triggers imports from `nemo.utils` that requires full NeMo installation
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11669/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11669/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11668 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11668/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11668/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11668/events | https://github.com/NVIDIA/NeMo/pull/11668 | 2,750,739,428 | PR_kwDOC_bI7s6FzmSZ | 11,668 | Huvu/t5 test mlmcommit | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-19T15:44:29 | 2025-01-10T02:00:11 | 2025-01-10T02:00:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11668",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11668",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11668.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11668.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11668/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11668/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11667 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11667/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11667/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11667/events | https://github.com/NVIDIA/NeMo/pull/11667 | 2,750,271,992 | PR_kwDOC_bI7s6Fx8xu | 11,667 | ci: Small pylint fix | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-19T13:04:50 | 2024-12-19T13:05:33 | 2024-12-19T13:05:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11667",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11667",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11667.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11667.patch",
"merged_at": "2024-12-19T13:05:31"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11667/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11667/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11666 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11666/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11666/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11666/events | https://github.com/NVIDIA/NeMo/issues/11666 | 2,749,721,138 | I_kwDOC_bI7s6j5Woy | 11,666 | FastPitch_Adapter_Finetuning doesn't works | {
"login": "zaidato",
"id": 185314416,
"node_id": "U_kgDOCwuscA",
"avatar_url": "https://avatars.githubusercontent.com/u/185314416?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zaidato",
"html_url": "https://github.com/zaidato",
"followers_url": "https://api.github.com/users/zaidato/followers",
"following_url": "https://api.github.com/users/zaidato/following{/other_user}",
"gists_url": "https://api.github.com/users/zaidato/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zaidato/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zaidato/subscriptions",
"organizations_url": "https://api.github.com/users/zaidato/orgs",
"repos_url": "https://api.github.com/users/zaidato/repos",
"events_url": "https://api.github.com/users/zaidato/events{/privacy}",
"received_events_url": "https://api.github.com/users/zaidato/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"."
] | 2024-12-19T09:24:23 | 2024-12-23T03:39:19 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I followed the steps in https://github.com/NVIDIA/NeMo/blob/main/tutorials/tts/FastPitch_Adapter_Finetuning.ipynb. But when I train FastPitch_MultiSpeaker_Pretraining.ipynb. Inference output was just the noise. It cannot pronounce any words. I already did exactly the steps in the tutorial. | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11666/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11666/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11665 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11665/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11665/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11665/events | https://github.com/NVIDIA/NeMo/pull/11665 | 2,749,561,577 | PR_kwDOC_bI7s6FveAo | 11,665 | expose flash decode to llm.generate | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:607:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.96/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-19T08:13:35 | 2025-01-10T02:00:12 | 2025-01-10T02:00:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11665",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11665",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11665.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11665.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11665/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11665/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11664 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11664/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11664/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11664/events | https://github.com/NVIDIA/NeMo/pull/11664 | 2,749,507,451 | PR_kwDOC_bI7s6FvSLz | 11,664 | Add DAPT tutorial | {
"login": "jihyeonRyu",
"id": 12709908,
"node_id": "MDQ6VXNlcjEyNzA5OTA4",
"avatar_url": "https://avatars.githubusercontent.com/u/12709908?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jihyeonRyu",
"html_url": "https://github.com/jihyeonRyu",
"followers_url": "https://api.github.com/users/jihyeonRyu/followers",
"following_url": "https://api.github.com/users/jihyeonRyu/following{/other_user}",
"gists_url": "https://api.github.com/users/jihyeonRyu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jihyeonRyu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jihyeonRyu/subscriptions",
"organizations_url": "https://api.github.com/users/jihyeonRyu/orgs",
"repos_url": "https://api.github.com/users/jihyeonRyu/repos",
"events_url": "https://api.github.com/users/jihyeonRyu/events{/privacy}",
"received_events_url": "https://api.github.com/users/jihyeonRyu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-19T07:42:16 | 2025-01-11T01:58:30 | 2025-01-11T01:58:30 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11664",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11664",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11664.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11664.patch",
"merged_at": null
} | # What does this PR do ?
Add a tutorial for DAPT training using ChipNeMo, provided as a step-by-step guide split into three stages, making it easy for users to follow along with interactive .ipynb notebooks.
**Collection**: [Note which collection this PR will affect]
# Changelog
Added four .ipynb tutorial files under /tutorials/llm/llama-3/dapt to guide users through the DAPT training process.
- Step 0: Create Dummy Data
- Step 1: DAPT
- Step 2: Alignment
- Step 3: Domain Adapted Retrieval
# Usage
You can follow the step-by-step tutorial by navigating to `/tutorials/llm/llama-3/dapt` and running the provided .ipynb notebooks.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ O] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ O] Did you write any new necessary tests?
- [ O] Did you add or update any necessary documentation?
- [ X] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [O] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11664/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11664/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11663 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11663/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11663/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11663/events | https://github.com/NVIDIA/NeMo/pull/11663 | 2,749,472,404 | PR_kwDOC_bI7s6FvKgd | 11,663 | Change peft merged model to bf16 | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.peft.api\nnemo/collections/llm/peft/api.py:37:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.86/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @HuiyingLi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12408342344) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-19T07:24:24 | 2024-12-19T22:02:48 | 2024-12-19T22:02:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11663",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11663",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11663.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11663.patch",
"merged_at": "2024-12-19T22:02:46"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11663/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11663/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11662 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11662/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11662/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11662/events | https://github.com/NVIDIA/NeMo/pull/11662 | 2,749,219,105 | PR_kwDOC_bI7s6FuTiB | 11,662 | Cherry pick `Fix Optimizer & LR scheduler & Consume Samples when Resuming in PEFT (11631)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Closing. Cherry-picked in #11680 "
] | 2024-12-19T04:28:29 | 2024-12-20T20:49:17 | 2024-12-20T20:49:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11662",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11662",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11662.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11662.patch",
"merged_at": null
} | beep boop [🤖]: Hi @suiyoubi 👋,
we've cherry picked #11631 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11662/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11662/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11661 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11661/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11661/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11661/events | https://github.com/NVIDIA/NeMo/pull/11661 | 2,749,182,092 | PR_kwDOC_bI7s6FuLbr | 11,661 | Bug fix - Inheritance of LLaVATemplateConfig and MLlamaTemplateConfig dataclasses | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
},
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | closed | false | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"[🤖]: Hi @yashaswikarnati 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12405995118) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @yashaswikarnati 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12447069259) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-19T03:50:39 | 2025-01-07T21:40:22 | 2024-12-21T19:02:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11661",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11661",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11661.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11661.patch",
"merged_at": "2024-12-21T19:02:21"
} | # What does this PR do ?
Bug fix - Inheritance of LLaVATemplateConfig and MLlamaTemplateConfig dataclasses
**Collection**:
Multimodal
# Changelog
- Fix Inheritance of LLaVATemplateConfig and MLlamaTemplateConfig dataclasses by using field attribute with default values
- Previously the class attributes were not inheriting properly from BaseConversationTemplateConfig
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11661/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11661/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11660 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11660/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11660/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11660/events | https://github.com/NVIDIA/NeMo/pull/11660 | 2,749,129,113 | PR_kwDOC_bI7s6FuANn | 11,660 | Cherry pick `Add fix docstring for VAD (11659)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-19T02:53:33 | 2024-12-19T02:57:27 | 2024-12-19T02:57:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11660",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11660",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11660.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11660.patch",
"merged_at": "2024-12-19T02:57:26"
} | beep boop [🤖]: Hi @titu1994 👋,
we've cherry picked #11659 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11660/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11660/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11659 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11659/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11659/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11659/events | https://github.com/NVIDIA/NeMo/pull/11659 | 2,749,126,985 | PR_kwDOC_bI7s6Ft_wJ | 11,659 | Add fix docstring for VAD | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-19T02:51:23 | 2024-12-19T02:53:10 | 2024-12-19T02:53:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11659",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11659",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11659.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11659.patch",
"merged_at": "2024-12-19T02:53:06"
} | # What does this PR do ?
Add a statement to use VAD only in colab environment
**Collection**: [ASR]
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11659/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11659/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11658 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11658/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11658/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11658/events | https://github.com/NVIDIA/NeMo/pull/11658 | 2,748,995,236 | PR_kwDOC_bI7s6FtkOT | 11,658 | chore(beep boop 🤖): Bump `MCORE_TAG=8d2bc43...` (2024-12-19) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-19T00:23:52 | 2025-01-03T12:54:57 | 2025-01-03T12:54:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11658",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11658",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11658.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11658.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=8d2bc4332c1aea92c7d69af5b220a37b1ba3cab3`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11658/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11658/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11657 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11657/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11657/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11657/events | https://github.com/NVIDIA/NeMo/pull/11657 | 2,748,973,501 | PR_kwDOC_bI7s6Ftfi5 | 11,657 | Fix tokenizer trust_remote_code | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.io.connector\nnemo/lightning/io/connector.py:148:0: C0301: Line too long (126/119) (line-too-long)\nnemo/lightning/io/connector.py:173:0: C0301: Line too long (152/119) (line-too-long)\nnemo/lightning/io/connector.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:130:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:268:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/connector.py:18:0: W0611: Unused PurePath imported from pathlib (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.24/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12403463413) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-19T00:01:37 | 2024-12-19T17:30:14 | 2024-12-19T17:30:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11657",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11657",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11657.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11657.patch",
"merged_at": "2024-12-19T17:30:11"
} | # What does this PR do ?
(Change is already in main branch)
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11657/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11657/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11656 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11656/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11656/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11656/events | https://github.com/NVIDIA/NeMo/pull/11656 | 2,748,838,283 | PR_kwDOC_bI7s6FtDLi | 11,656 | Cherrypick 11568 | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12402773109) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-18T22:05:07 | 2024-12-19T17:30:39 | 2024-12-19T17:30:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11656",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11656",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11656.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11656.patch",
"merged_at": "2024-12-19T17:30:36"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11656/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11656/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11655 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11655/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11655/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11655/events | https://github.com/NVIDIA/NeMo/pull/11655 | 2,748,718,134 | PR_kwDOC_bI7s6Fsoih | 11,655 | Add helper function to get data module for llava | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.api\nnemo/collections/vlm/api.py:1:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.74/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-18T20:44:46 | 2025-01-09T02:13:11 | 2025-01-09T02:13:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11655",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11655",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11655.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11655.patch",
"merged_at": null
} | Just extracts data module definition to a helper function. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11655/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11655/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11654 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11654/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11654/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11654/events | https://github.com/NVIDIA/NeMo/pull/11654 | 2,748,546,047 | PR_kwDOC_bI7s6FsCSO | 11,654 | Rename multimodal data module - EnergonMultiModalDataModule | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
},
{
"id": 7975307397,
"node_id": "LA_kwDOC_bI7s8AAAAB212IhQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.1",
"name": "r2.1.1",
"color": "62E914",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @yashaswikarnati 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12400830095) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @yashaswikarnati 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12424109080) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-18T19:03:01 | 2025-01-07T21:41:42 | 2024-12-20T07:20:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11654",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11654",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11654.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11654.patch",
"merged_at": "2024-12-20T07:20:13"
} | # What does this PR do ?
Rename multimodal data module SimpleMultiModalDataModule to EnergonMultiModalDataModule
**Collection**: Multimodal
# Changelog
Rename multimodal data module SimpleMultiModalDataModule to EnergonMultiModalDataModule
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11654/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11654/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11653 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11653/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11653/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11653/events | https://github.com/NVIDIA/NeMo/pull/11653 | 2,748,525,343 | PR_kwDOC_bI7s6Fr9vK | 11,653 | Add VLM PEFT test running with 4bit model weights. | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.peft.lora\nnemo/collections/llm/peft/lora.py:150:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.90/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12640174634) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-18T18:50:49 | 2025-01-07T17:25:48 | 2025-01-07T17:25:45 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11653",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11653",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11653.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11653.patch",
"merged_at": "2025-01-07T17:25:45"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11653/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11653/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11652 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11652/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11652/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11652/events | https://github.com/NVIDIA/NeMo/pull/11652 | 2,748,504,554 | PR_kwDOC_bI7s6Fr5FU | 11,652 | Speechllm develop gen duplex | {
"login": "kevinhu-nv",
"id": 184545435,
"node_id": "U_kgDOCv_wmw",
"avatar_url": "https://avatars.githubusercontent.com/u/184545435?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevinhu-nv",
"html_url": "https://github.com/kevinhu-nv",
"followers_url": "https://api.github.com/users/kevinhu-nv/followers",
"following_url": "https://api.github.com/users/kevinhu-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinhu-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevinhu-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinhu-nv/subscriptions",
"organizations_url": "https://api.github.com/users/kevinhu-nv/orgs",
"repos_url": "https://api.github.com/users/kevinhu-nv/repos",
"events_url": "https://api.github.com/users/kevinhu-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevinhu-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"@zhehuaichen Can you take a look?",
"More details:\r\n- Alignment: /home/kevinhu/s2s/s2s_salm_1ab_d1r_12fps_duplex4_data4b_mistral_1a_align.sh ([wandb](https://wandb.ai/aiapps/salm_s2s_huk/runs/tiqfqnt9?nw=nwuserhukevin))\r\n\r\n- User text:\r\n * /home/kevinhu/s2s/s2s_salm_1ab_d1r_12fps_duplex4_data4b_mistral_1a_srctext.sh ([wandb](https://wandb.ai/aiapps/salm_s2s_huk/runs/m82t2sbp?nw=nwuserhukevin))\r\n * Compare to baseline seems bleu is a little better: https://wandb.ai/aiapps/salm_s2s_huk/reports/Ablation-Adding-user-text-prediction--VmlldzoxMDY2NDc0Ng",
"All done - PTAL @zhehuaichen ",
"Thanks for the review!"
] | 2024-12-18T18:40:14 | 2024-12-19T21:52:02 | 2024-12-19T21:51:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11652",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11652",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11652.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11652.patch",
"merged_at": "2024-12-19T21:51:06"
} | # What does this PR do ?
Add support for predicting user text and using word alignment.
Add flags
1. ++model.predict_source_text=True, for predicting user text
2. lhotse tag s2s_duplex_align, for use word alignment in target speech-text prediction | {
"login": "kevinhu-nv",
"id": 184545435,
"node_id": "U_kgDOCv_wmw",
"avatar_url": "https://avatars.githubusercontent.com/u/184545435?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevinhu-nv",
"html_url": "https://github.com/kevinhu-nv",
"followers_url": "https://api.github.com/users/kevinhu-nv/followers",
"following_url": "https://api.github.com/users/kevinhu-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinhu-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevinhu-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinhu-nv/subscriptions",
"organizations_url": "https://api.github.com/users/kevinhu-nv/orgs",
"repos_url": "https://api.github.com/users/kevinhu-nv/repos",
"events_url": "https://api.github.com/users/kevinhu-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevinhu-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11652/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11652/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11651 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11651/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11651/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11651/events | https://github.com/NVIDIA/NeMo/pull/11651 | 2,748,419,213 | PR_kwDOC_bI7s6FrmUD | 11,651 | update nemo container version for notebooks | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-18T17:51:35 | 2024-12-19T03:21:13 | 2024-12-19T03:21:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11651",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11651",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11651.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11651.patch",
"merged_at": "2024-12-19T03:21:11"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11651/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11651/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11650 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11650/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11650/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11650/events | https://github.com/NVIDIA/NeMo/pull/11650 | 2,748,344,132 | PR_kwDOC_bI7s6FrVxt | 11,650 | Add usage instructions for Cosmos TensorRT | {
"login": "jojennin",
"id": 106725747,
"node_id": "U_kgDOBlyBcw",
"avatar_url": "https://avatars.githubusercontent.com/u/106725747?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jojennin",
"html_url": "https://github.com/jojennin",
"followers_url": "https://api.github.com/users/jojennin/followers",
"following_url": "https://api.github.com/users/jojennin/following{/other_user}",
"gists_url": "https://api.github.com/users/jojennin/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jojennin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jojennin/subscriptions",
"organizations_url": "https://api.github.com/users/jojennin/orgs",
"repos_url": "https://api.github.com/users/jojennin/repos",
"events_url": "https://api.github.com/users/jojennin/events{/privacy}",
"received_events_url": "https://api.github.com/users/jojennin/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-18T17:08:32 | 2025-01-06T18:13:02 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11650",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11650",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11650.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11650.patch",
"merged_at": null
} | # What does this PR do ?
This PR adds instructions on how to use the Cosmos Tokenizers with TensorRT
**Collection**: common/video_tokenizers
# Changelog
- Provides Cosmos TensorRT usage instructions
# Usage
See the file `nemo/collections/video_tokenizers/README.md`
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11650/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11650/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11649 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11649/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11649/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11649/events | https://github.com/NVIDIA/NeMo/pull/11649 | 2,748,168,182 | PR_kwDOC_bI7s6Fqu91 | 11,649 | Add Llama2 7B recipe | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-12-18T15:47:54 | 2025-01-09T02:13:12 | 2025-01-09T02:13:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11649",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11649",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11649.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11649.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11649/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11649/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11648 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11648/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11648/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11648/events | https://github.com/NVIDIA/NeMo/pull/11648 | 2,748,073,420 | PR_kwDOC_bI7s6FqZ9m | 11,648 | Utilities to detect and drop deprecated arguments from NeMo 2.0 checkpoint context io.json | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12411404781) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"> Looks great, I wonder if we can do this directly on the fly instead of via a script. What are your thoughts?\r\n\r\nYes we can definitely, I'll file a follow-up MR",
"[like] Hemil Desai reacted to your message:\r\n________________________________\r\nFrom: Jan Lasek ***@***.***>\r\nSent: Friday, December 20, 2024 4:39:25 PM\r\nTo: NVIDIA/NeMo ***@***.***>\r\nCc: Hemil Desai ***@***.***>; Review requested ***@***.***>\r\nSubject: Re: [NVIDIA/NeMo] Utilities to detect and drop deprecated arguments from NeMo 2.0 checkpoint context io.json (PR #11648)\r\n\r\n\r\nLooks great, I wonder if we can do this directly on the fly instead of via a script. What are your thoughts?\r\n\r\nYes we can definitely, I'll file a follow-up MR\r\n\r\n—\r\nReply to this email directly, view it on GitHub<https://github.com/NVIDIA/NeMo/pull/11648#issuecomment-2557357566>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB6Q25CX4XOU2IXPIJ5CIV32GRB33AVCNFSM6AAAAABT25MWBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJXGM2TONJWGY>.\r\nYou are receiving this because your review was requested.Message ID: ***@***.***>\r\n"
] | 2024-12-18T15:08:43 | 2024-12-20T16:39:54 | 2024-12-20T01:54:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11648",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11648",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11648.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11648.patch",
"merged_at": "2024-12-20T01:54:59"
} | # What does this PR do ?
Detecting and dropping unknown (deprecated) arguments from NeMo 2.0 io.json context.
**Collection**: LLM
# Usage
Loading the context for a NeMo 2.0 checkpoint produced using [24.09 container](https://catalog.ngc.nvidia.com/orgs/nvidia/containers/nemo/tags) and used with a more recent version results in the following error:
```
File "/usr/local/lib/python3.10/dist-packages/fiddle/_src/daglish.py", line 786, in apply
result = self.traversal_fn(value, state)
File "/usr/local/lib/python3.10/dist-packages/fiddle/_src/building.py", line 180, in _build
return call_buildable(value, arguments, current_path=state.current_path)
File "/usr/local/lib/python3.10/dist-packages/fiddle/_src/building.py", line 120, in call_buildable
return buildable.__build__(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/fiddle/_src/config.py", line 783, in __build__
return self.__fn_or_cls__(*args, **kwargs)
TypeError: OptimizerConfig.__init__() got an unexpected keyword argument 'overlap_grad_reduce'
```
This is a consequence of a recent Megatron-Core refactor that removed `overlap_grad_reduce` and `overlap_param_gather` from `OptimizerConfig`, see https://github.com/NVIDIA/Megatron-LM/commit/6ac4db023bf7eb0e825e09aa8532af4a2c55f359.
The context may be cleared from deprecated parameters and updated using the provided script to load model successfully for subsequent processing:
```
python scripts/llm/update_io_context.py \
--model_path /opt/checkpoints/LLAMA3-8B-nemo2-24-09 \
--build
```
Alternatively, `drop_unexpected_params(config)` can be directly called in `load` function from **nemo/lightning/io/mixin.py** in [L754](https://github.com/NVIDIA/NeMo/blob/0133deb268812109eab5211f902d7c4b99b6ee95/nemo/lightning/io/mixin.py#L754).
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11648/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11648/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11647 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11647/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11647/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11647/events | https://github.com/NVIDIA/NeMo/pull/11647 | 2,747,917,720 | PR_kwDOC_bI7s6Fp3mG | 11,647 | add renormalize_blend_weights param | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron_gpt_model\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:327:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:367:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:413:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:460:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:793:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1108:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1129:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1339:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1380:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1437:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1618:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1619:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1621:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1793:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1813:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1821:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1842:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1912:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1939:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:140:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:153:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:179:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:198:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:469:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:472:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:703:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:707:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:789:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1106:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1179:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1228:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1257:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1450:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1585:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1593:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1602:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1887:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2040:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2047:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2053:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:20:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:28:0: W0611: Unused _DataFetcherWrapper imported from lightning.pytorch.loops.fetchers (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:30:0: W0611: Unused OmegaConf imported from omegaconf (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:72:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:81:4: W0611: Unused megatron.core imported as core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:82:4: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.50/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @dimapihtar 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12394670204) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-18T14:05:20 | 2024-12-18T17:44:11 | 2024-12-18T17:44:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11647",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11647",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11647.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11647.patch",
"merged_at": "2024-12-18T17:44:09"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11647/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11647/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11646 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11646/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11646/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11646/events | https://github.com/NVIDIA/NeMo/pull/11646 | 2,747,525,390 | PR_kwDOC_bI7s6Fog46 | 11,646 | Update package_info.py | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-18T11:14:34 | 2024-12-18T11:16:35 | 2024-12-18T11:16:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11646",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11646",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11646.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11646.patch",
"merged_at": "2024-12-18T11:16:33"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11646/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11646/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11645 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11645/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11645/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11645/events | https://github.com/NVIDIA/NeMo/pull/11645 | 2,747,447,444 | PR_kwDOC_bI7s6FoPcP | 11,645 | Adding serialization to all Auto* objects in HuggingFace transformers | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"Is there a timeline to merge this branch into main? @marcromeyn ",
"I can address the comments tomorrow, and get it in a mergeable state",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.io.artifact.base\nnemo/lightning/io/artifact/base.py:22:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/artifact/base.py:29:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/artifact/base.py:33:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.io.artifact.file\nnemo/lightning/io/artifact/file.py:24:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/artifact/file.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/artifact/file.py:45:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/artifact/file.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/artifact/file.py:60:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/artifact/file.py:78:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.io.artifact.pickle\nnemo/lightning/io/artifact/pickle.py:23:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/artifact/pickle.py:35:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.76/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-18T10:40:34 | 2025-01-16T09:45:09 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11645",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11645",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11645.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11645.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11645/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11645/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11644 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11644/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11644/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11644/events | https://github.com/NVIDIA/NeMo/issues/11644 | 2,746,896,917 | I_kwDOC_bI7s6julIV | 11,644 | I came here for llama3 meets upcycling | {
"login": "sorobedio",
"id": 70527807,
"node_id": "MDQ6VXNlcjcwNTI3ODA3",
"avatar_url": "https://avatars.githubusercontent.com/u/70527807?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sorobedio",
"html_url": "https://github.com/sorobedio",
"followers_url": "https://api.github.com/users/sorobedio/followers",
"following_url": "https://api.github.com/users/sorobedio/following{/other_user}",
"gists_url": "https://api.github.com/users/sorobedio/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sorobedio/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sorobedio/subscriptions",
"organizations_url": "https://api.github.com/users/sorobedio/orgs",
"repos_url": "https://api.github.com/users/sorobedio/repos",
"events_url": "https://api.github.com/users/sorobedio/events{/privacy}",
"received_events_url": "https://api.github.com/users/sorobedio/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | open | false | null | [] | null | [
"Please check this: https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/upcycle_dense_to_moe.py"
] | 2024-12-18T06:21:15 | 2025-01-07T19:45:37 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Where is the code of llama3 meets upcycling | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11644/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11644/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11643 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11643/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11643/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11643/events | https://github.com/NVIDIA/NeMo/pull/11643 | 2,746,711,073 | PR_kwDOC_bI7s6FluSR | 11,643 | switch to grpc for deploy and eval | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"> Great speedup, I am wondering would it be possible to remove the rest option all together from eval? There doesn't seem to be any benefit in keeping the eval with rest API as an option.\r\n\r\nThanks for the suggestion! Updated the PR and removed the rest API part.",
"[🤖]: Hi @HuiyingLi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12398106403) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:442:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/llm/api.py:568:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:15:0: W0611: Unused import os (unused-import)\n************* Module nemo.deploy.deploy_base\nnemo/deploy/deploy_base.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/deploy_base.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/deploy_base.py:75:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/deploy_base.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/deploy_base.py:83:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/deploy_base.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.deploy.deploy_pytriton\nnemo/deploy/deploy_pytriton.py:53:0: C0301: Line too long (132/119) (line-too-long)\nnemo/deploy/deploy_pytriton.py:84:0: C0301: Line too long (126/119) (line-too-long)\n************* Module nemo.deploy.nlp.query_llm\nnemo/deploy/nlp/query_llm.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/nlp/query_llm.py:16:0: W0611: Unused abstractmethod imported from abc (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.72/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @HuiyingLi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12539700707) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-18T04:06:30 | 2024-12-30T23:06:58 | 2024-12-30T23:06:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11643",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11643",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11643.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11643.patch",
"merged_at": "2024-12-30T23:06:56"
} | # What does this PR do ?
Using PyTriton grpc client instead of rest API when running evaluation due to the large logits payload.
On arc_challenge with bs=1, llama3-8b
Before (rest API): 9487.118s
After (gRPC client): 502.976
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11643/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11643/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11642 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11642/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11642/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11642/events | https://github.com/NVIDIA/NeMo/pull/11642 | 2,746,708,535 | PR_kwDOC_bI7s6FltuL | 11,642 | Make LinearAdapter a nn.Linear child to maintain ckpt structure | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12403099852) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:26:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:22:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/peft/hf.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/sft/hf.py:90:0: C0301: Line too long (162/119) (line-too-long)\n************* Module nemo.collections.llm.peft.lora\nnemo/collections/llm/peft/lora.py:147:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.86/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:26:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:22:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/peft/hf.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/llm/sft/hf.py:90:0: C0301: Line too long (162/119) (line-too-long)\n************* Module nemo.collections.llm.peft.lora\nnemo/collections/llm/peft/lora.py:147:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.86/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12435908385) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-18T04:04:46 | 2024-12-20T21:36:56 | 2024-12-20T21:36:55 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11642",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11642",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11642.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11642.patch",
"merged_at": "2024-12-20T21:36:55"
} | # What does this PR do ?
Changes:
1. Make LinearAdapter a nn.Linear child -> so that when we swap it in to replace a nn.Linear the .weight and .bias attributes remain the same, therefore maintaining the checkpoint keys name path.
2. make LinearAdapter work with FSDPv1
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11642/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11642/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11641 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11641/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11641/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11641/events | https://github.com/NVIDIA/NeMo/pull/11641 | 2,746,603,964 | PR_kwDOC_bI7s6FlW0G | 11,641 | Fixing Multi_Task_Adapters.ipynb by replacing canary2 with canary_custom | {
"login": "weiqingw4ng",
"id": 164252040,
"node_id": "U_kgDOCcpJiA",
"avatar_url": "https://avatars.githubusercontent.com/u/164252040?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/weiqingw4ng",
"html_url": "https://github.com/weiqingw4ng",
"followers_url": "https://api.github.com/users/weiqingw4ng/followers",
"following_url": "https://api.github.com/users/weiqingw4ng/following{/other_user}",
"gists_url": "https://api.github.com/users/weiqingw4ng/gists{/gist_id}",
"starred_url": "https://api.github.com/users/weiqingw4ng/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/weiqingw4ng/subscriptions",
"organizations_url": "https://api.github.com/users/weiqingw4ng/orgs",
"repos_url": "https://api.github.com/users/weiqingw4ng/repos",
"events_url": "https://api.github.com/users/weiqingw4ng/events{/privacy}",
"received_events_url": "https://api.github.com/users/weiqingw4ng/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-18T02:43:31 | 2024-12-18T07:42:04 | 2024-12-18T07:42:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11641",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11641",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11641.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11641.patch",
"merged_at": "2024-12-18T07:42:04"
} | # What does this PR do ?
There is already a `canary2.py` file under the `nemo/collections/common/prompts` folder. In this tutorial, we register a new custom prompt formatter with the name `canary2`, which creates a conflict with the existing `canary2.py`. This PR resolves the conflict by changing the variable name from `canary2` to `canary_custom`.
**Collection**: [Note which collection this PR will affect]
NeMo/tutorial/asr
# Changelog
- Add specific line by line info of high level changes in this PR.
Updated requirements file
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11641/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11641/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11640 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11640/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11640/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11640/events | https://github.com/NVIDIA/NeMo/pull/11640 | 2,746,576,545 | PR_kwDOC_bI7s6FlQ6n | 11,640 | Fix baichuan export | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12385186888) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.gpt.model.baichuan\nnemo/collections/llm/gpt/model/baichuan.py:36:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:50:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:59:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:73:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:93:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:144:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:170:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/baichuan.py:184:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.19/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12397566243) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-18T02:22:26 | 2024-12-20T06:23:15 | 2024-12-20T06:23:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11640",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11640",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11640.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11640.patch",
"merged_at": "2024-12-20T06:23:13"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11640/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11640/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11639 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11639/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11639/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11639/events | https://github.com/NVIDIA/NeMo/pull/11639 | 2,746,524,835 | PR_kwDOC_bI7s6FlFtO | 11,639 | Cherry pick `Add fix docstring for speech commands (11638)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-18T01:44:02 | 2024-12-18T01:48:14 | 2024-12-18T01:48:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11639",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11639",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11639.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11639.patch",
"merged_at": "2024-12-18T01:48:12"
} | beep boop [🤖]: Hi @titu1994 👋,
we've cherry picked #11638 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11639/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11639/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11638 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11638/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11638/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11638/events | https://github.com/NVIDIA/NeMo/pull/11638 | 2,746,514,923 | PR_kwDOC_bI7s6FlDsZ | 11,638 | Add fix docstring for speech commands | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-18T01:36:53 | 2024-12-18T01:43:39 | 2024-12-18T01:43:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11638",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11638",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11638.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11638.patch",
"merged_at": "2024-12-18T01:43:34"
} | # What does this PR do ?
Add a note for Matchboxnet tutorial
**Collection**: [ASR]
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11638/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11638/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11637 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11637/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11637/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11637/events | https://github.com/NVIDIA/NeMo/pull/11637 | 2,746,409,847 | PR_kwDOC_bI7s6FktSZ | 11,637 | chore(beep boop 🤖): Bump `MCORE_TAG=14ca285...` (2024-12-18) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-18T00:23:32 | 2025-01-03T12:54:54 | 2025-01-03T12:54:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11637",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11637",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11637.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11637.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=14ca285dcc8b6862fbb992ef8de57402479c0e9f`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11637/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11637/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11636 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11636/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11636/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11636/events | https://github.com/NVIDIA/NeMo/pull/11636 | 2,746,344,720 | PR_kwDOC_bI7s6FkfWt | 11,636 | Fixing Multi_Task_Adapters.ipynb by replacing canary2 with canary_custom | {
"login": "weiqingw4ng",
"id": 164252040,
"node_id": "U_kgDOCcpJiA",
"avatar_url": "https://avatars.githubusercontent.com/u/164252040?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/weiqingw4ng",
"html_url": "https://github.com/weiqingw4ng",
"followers_url": "https://api.github.com/users/weiqingw4ng/followers",
"following_url": "https://api.github.com/users/weiqingw4ng/following{/other_user}",
"gists_url": "https://api.github.com/users/weiqingw4ng/gists{/gist_id}",
"starred_url": "https://api.github.com/users/weiqingw4ng/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/weiqingw4ng/subscriptions",
"organizations_url": "https://api.github.com/users/weiqingw4ng/orgs",
"repos_url": "https://api.github.com/users/weiqingw4ng/repos",
"events_url": "https://api.github.com/users/weiqingw4ng/events{/privacy}",
"received_events_url": "https://api.github.com/users/weiqingw4ng/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@weiqingw4ng lets merge this, but you have to cherry-pick / duplicate the PR to main. The current workflow is \r\n- send PRs to main\r\n- Add label 2.1.0 (or whatever is the latest) so that a CI action cherry picks the commit from main to the release branch.\r\n- Then merge both PRs.",
"\r\n\r\n\r\n> @weiqingw4ng lets merge this, but you have to cherry-pick / duplicate the PR to main. The current workflow is\r\n> \r\n> * send PRs to main\r\n> * Add label 2.1.0 (or whatever is the latest) so that a CI action cherry picks the commit from main to the release branch.\r\n> * Then merge both PRs.\r\n\r\n@titu1994 Thank you so much for the tips! I have already submitted a new PR to main with label 2.1.0. "
] | 2024-12-17T23:39:10 | 2024-12-18T02:45:20 | 2024-12-18T01:47:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11636",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11636",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11636.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11636.patch",
"merged_at": "2024-12-18T01:47:10"
} | # What does this PR do ?
There is already a `canary2.py` file under the `nemo/collections/common/prompts` folder. In this tutorial, we register a new custom prompt formatter with the name `canary2`, which creates a conflict with the existing `canary2.py`. This PR resolves the conflict by changing the variable name from `canary2` to `canary_custom`.
**Collection**: [Note which collection this PR will affect]
NeMo/tutorial/asr
# Changelog
- Add specific line by line info of high level changes in this PR.
Updated requirements file
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11636/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11636/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11635 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11635/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11635/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11635/events | https://github.com/NVIDIA/NeMo/pull/11635 | 2,746,267,435 | PR_kwDOC_bI7s6FkOb2 | 11,635 | ci: Bump release workflow | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-17T22:47:10 | 2024-12-17T22:47:21 | 2024-12-17T22:47:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11635",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11635",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11635.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11635.patch",
"merged_at": "2024-12-17T22:47:18"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11635/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11635/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11634 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11634/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11634/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11634/events | https://github.com/NVIDIA/NeMo/pull/11634 | 2,746,261,983 | PR_kwDOC_bI7s6FkNMY | 11,634 | Add delay for speech codes prediction | {
"login": "kevinhu-nv",
"id": 184545435,
"node_id": "U_kgDOCv_wmw",
"avatar_url": "https://avatars.githubusercontent.com/u/184545435?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevinhu-nv",
"html_url": "https://github.com/kevinhu-nv",
"followers_url": "https://api.github.com/users/kevinhu-nv/followers",
"following_url": "https://api.github.com/users/kevinhu-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinhu-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevinhu-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinhu-nv/subscriptions",
"organizations_url": "https://api.github.com/users/kevinhu-nv/orgs",
"repos_url": "https://api.github.com/users/kevinhu-nv/repos",
"events_url": "https://api.github.com/users/kevinhu-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevinhu-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"@zhehuaichen",
"> Thank you so much! Can u attach a working recipe based on the same baseline as mine before merging /lustre/fs12/portfolios/llmservice/users/zhehuaic/works/mod_speech_llm/scripts/s2s_salm_1ab_d1r_12fps_duplex4_data_scalec_mistral.sh\r\n\r\nSure - here it is with a delay of 5 tokens: /home/kevinhu/s2s/s2s_salm_1ab_d1r_12fps_duplex4_data4b_mistral_1a_delay5.sh",
"great. click the merge button when you verify that your recipe can train ",
"> great. click the merge button when you verify that your recipe can train\r\n\r\nAlready training :)"
] | 2024-12-17T22:44:05 | 2024-12-18T16:07:02 | 2024-12-18T16:07:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11634",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11634",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11634.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11634.patch",
"merged_at": "2024-12-18T16:07:01"
} | # What does this PR do ?
Add delay to speech codes prediction. | {
"login": "zhehuaichen",
"id": 139396994,
"node_id": "U_kgDOCE8Hgg",
"avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zhehuaichen",
"html_url": "https://github.com/zhehuaichen",
"followers_url": "https://api.github.com/users/zhehuaichen/followers",
"following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}",
"gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions",
"organizations_url": "https://api.github.com/users/zhehuaichen/orgs",
"repos_url": "https://api.github.com/users/zhehuaichen/repos",
"events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}",
"received_events_url": "https://api.github.com/users/zhehuaichen/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11634/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11634/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11633 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11633/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11633/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11633/events | https://github.com/NVIDIA/NeMo/pull/11633 | 2,746,243,462 | PR_kwDOC_bI7s6FkJLk | 11,633 | Add Seq Packing in NeMo / Neva2 | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.peft.api\nnemo/collections/llm/peft/api.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.multimodal.data.energon.base\nnemo/collections/multimodal/data/energon/base.py:88:0: C0301: Line too long (120/119) (line-too-long)\n************* Module nemo.collections.multimodal.data.energon.config\nnemo/collections/multimodal/data/energon/config.py:25:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/data/energon/config.py:32:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/data/energon/config.py:80:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.multimodal.data.energon.task_encoder\nnemo/collections/multimodal/data/energon/task_encoder.py:15:0: W0611: Unused import dataclasses (unused-import)\n************* Module nemo.collections.vlm.neva.data.config\nnemo/collections/vlm/neva/data/config.py:22:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/config.py:32:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/config.py:40:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.vlm.neva.data.lazy\nnemo/collections/vlm/neva/data/lazy.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:115:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:134:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:161:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:236:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:246:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/lazy.py:419:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:478:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/lazy.py:560:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:579:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:582:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:585:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.data.mock\nnemo/collections/vlm/neva/data/mock.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/mock.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:109:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.model.base\nnemo/collections/vlm/neva/model/base.py:481:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:484:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:509:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:93:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:155:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:176:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:243:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:255:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:282:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:303:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:334:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:371:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:384:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:896:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:913:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:917:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:949:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:952:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:955:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:959:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:965:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:972:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:48:0: W0611: Unused get_batch_on_this_context_parallel_rank imported from nemo.collections.llm.gpt.model.base (unused-import)\nnemo/collections/vlm/neva/model/base.py:48:0: W0611: Unused get_packed_seq_params imported from nemo.collections.llm.gpt.model.base (unused-import)\n************* Module nemo.lightning.megatron_parallel\nnemo/lightning/megatron_parallel.py:238:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:239:0: C0301: Line too long (140/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:240:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:546:0: C0301: Line too long (129/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:553:0: C0301: Line too long (135/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:829:0: C0301: Line too long (137/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1059:0: C0301: Line too long (136/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1632:0: C0301: Line too long (128/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:64:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:102:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:106:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:330:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:356:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:382:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:518:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:561:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:619:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:654:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:660:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:666:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:673:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:714:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:722:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:738:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:765:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:777:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:799:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1325:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1500:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1516:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1521:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1526:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1554:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1600:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1622:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1695:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1741:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1755:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.46/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @yaoyu-33 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12774637365) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-17T22:32:57 | 2025-01-15T21:25:45 | 2025-01-15T21:25:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11633",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11633",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11633.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11633.patch",
"merged_at": "2025-01-15T21:25:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11633/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11633/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11632 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11632/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11632/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11632/events | https://github.com/NVIDIA/NeMo/pull/11632 | 2,745,938,355 | PR_kwDOC_bI7s6FjEsM | 11,632 | Fix Gemma2 27B default num nodes | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12380607202) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-17T20:08:41 | 2024-12-18T15:47:28 | 2024-12-18T15:47:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11632",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11632",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11632.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11632.patch",
"merged_at": "2024-12-18T15:47:27"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11632/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11632/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11631 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11631/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11631/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11631/events | https://github.com/NVIDIA/NeMo/pull/11631 | 2,745,914,657 | PR_kwDOC_bI7s6Fi_Xq | 11,631 | Fix Optimizer & LR scheduler & Consume Samples when Resuming in PEFT | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12397455467) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12399162196) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-17T19:57:58 | 2024-12-19T04:28:04 | 2024-12-19T04:28:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11631",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11631",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11631.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11631.patch",
"merged_at": "2024-12-19T04:28:03"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11631/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11631/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11630 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11630/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11630/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11630/events | https://github.com/NVIDIA/NeMo/pull/11630 | 2,745,877,589 | PR_kwDOC_bI7s6Fi3IC | 11,630 | Cherrypick #11628 to r2.1.0 | {
"login": "nasretdinovr",
"id": 26926475,
"node_id": "MDQ6VXNlcjI2OTI2NDc1",
"avatar_url": "https://avatars.githubusercontent.com/u/26926475?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nasretdinovr",
"html_url": "https://github.com/nasretdinovr",
"followers_url": "https://api.github.com/users/nasretdinovr/followers",
"following_url": "https://api.github.com/users/nasretdinovr/following{/other_user}",
"gists_url": "https://api.github.com/users/nasretdinovr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nasretdinovr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nasretdinovr/subscriptions",
"organizations_url": "https://api.github.com/users/nasretdinovr/orgs",
"repos_url": "https://api.github.com/users/nasretdinovr/repos",
"events_url": "https://api.github.com/users/nasretdinovr/events{/privacy}",
"received_events_url": "https://api.github.com/users/nasretdinovr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-17T19:39:54 | 2024-12-18T04:21:16 | 2024-12-18T04:21:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11630",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11630",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11630.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11630.patch",
"merged_at": "2024-12-18T04:21:16"
} | # What does this PR do ?
This PR fixes name of the config in online augmentation tutorial
**Collection**: audio
# Changelog
- fixed config name in the file tutorials/audio/speech_enhancement/Speech_Enhancement_with_Online_Augmentation.ipynb
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11630/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11630/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11629 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11629/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11629/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11629/events | https://github.com/NVIDIA/NeMo/pull/11629 | 2,745,773,497 | PR_kwDOC_bI7s6Fif2l | 11,629 | Fix nan issue in nemo1 / neva | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.multimodal.models.multimodal_llm.neva.neva_model\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:191:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:192:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:323:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:852:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:865:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:867:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1259:0: C0301: Line too long (194/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1263:0: C0301: Line too long (245/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1310:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1394:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1573:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1696:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:113:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:133:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:146:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:163:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:184:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:187:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:300:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:310:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:507:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:548:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:581:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:610:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:725:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1179:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1185:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py:1626:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.61/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @yaoyu-33 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12398541875) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-17T18:55:21 | 2025-01-07T17:53:20 | 2025-01-07T17:53:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11629",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11629",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11629.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11629.patch",
"merged_at": "2025-01-07T17:53:18"
} | # What does this PR do ?
Fix nan issue in nemo1 / neva.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11629/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11629/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11628 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11628/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11628/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11628/events | https://github.com/NVIDIA/NeMo/pull/11628 | 2,745,625,868 | PR_kwDOC_bI7s6Fh_WJ | 11,628 | fixed config name in online augmentation tutorial | {
"login": "nasretdinovr",
"id": 26926475,
"node_id": "MDQ6VXNlcjI2OTI2NDc1",
"avatar_url": "https://avatars.githubusercontent.com/u/26926475?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nasretdinovr",
"html_url": "https://github.com/nasretdinovr",
"followers_url": "https://api.github.com/users/nasretdinovr/followers",
"following_url": "https://api.github.com/users/nasretdinovr/following{/other_user}",
"gists_url": "https://api.github.com/users/nasretdinovr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nasretdinovr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nasretdinovr/subscriptions",
"organizations_url": "https://api.github.com/users/nasretdinovr/orgs",
"repos_url": "https://api.github.com/users/nasretdinovr/repos",
"events_url": "https://api.github.com/users/nasretdinovr/events{/privacy}",
"received_events_url": "https://api.github.com/users/nasretdinovr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-12-17T17:51:05 | 2024-12-18T13:52:16 | 2024-12-18T13:52:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11628",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11628",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11628.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11628.patch",
"merged_at": "2024-12-18T13:52:16"
} | # What does this PR do ?
This PR fixes name of the config in online augmentation tutorial
**Collection**: audio
# Changelog
- fixed config name in the file tutorials/audio/speech_enhancement/Speech_Enhancement_with_Online_Augmentation.ipynb
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nasretdinovr",
"id": 26926475,
"node_id": "MDQ6VXNlcjI2OTI2NDc1",
"avatar_url": "https://avatars.githubusercontent.com/u/26926475?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nasretdinovr",
"html_url": "https://github.com/nasretdinovr",
"followers_url": "https://api.github.com/users/nasretdinovr/followers",
"following_url": "https://api.github.com/users/nasretdinovr/following{/other_user}",
"gists_url": "https://api.github.com/users/nasretdinovr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nasretdinovr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nasretdinovr/subscriptions",
"organizations_url": "https://api.github.com/users/nasretdinovr/orgs",
"repos_url": "https://api.github.com/users/nasretdinovr/repos",
"events_url": "https://api.github.com/users/nasretdinovr/events{/privacy}",
"received_events_url": "https://api.github.com/users/nasretdinovr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11628/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11628/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11627 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11627/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11627/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11627/events | https://github.com/NVIDIA/NeMo/pull/11627 | 2,745,228,887 | PR_kwDOC_bI7s6Fgmp2 | 11,627 | Remove triton requirement | {
"login": "thomasdhc",
"id": 9426164,
"node_id": "MDQ6VXNlcjk0MjYxNjQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thomasdhc",
"html_url": "https://github.com/thomasdhc",
"followers_url": "https://api.github.com/users/thomasdhc/followers",
"following_url": "https://api.github.com/users/thomasdhc/following{/other_user}",
"gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions",
"organizations_url": "https://api.github.com/users/thomasdhc/orgs",
"repos_url": "https://api.github.com/users/thomasdhc/repos",
"events_url": "https://api.github.com/users/thomasdhc/events{/privacy}",
"received_events_url": "https://api.github.com/users/thomasdhc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @thomasdhc 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12377040061) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-17T15:25:40 | 2024-12-17T17:59:31 | 2024-12-17T17:59:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11627",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11627",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11627.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11627.patch",
"merged_at": "2024-12-17T17:59:29"
} | # What does this PR do ?
Requirements specify pytorch-triton instead of triton
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "thomasdhc",
"id": 9426164,
"node_id": "MDQ6VXNlcjk0MjYxNjQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thomasdhc",
"html_url": "https://github.com/thomasdhc",
"followers_url": "https://api.github.com/users/thomasdhc/followers",
"following_url": "https://api.github.com/users/thomasdhc/following{/other_user}",
"gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions",
"organizations_url": "https://api.github.com/users/thomasdhc/orgs",
"repos_url": "https://api.github.com/users/thomasdhc/repos",
"events_url": "https://api.github.com/users/thomasdhc/events{/privacy}",
"received_events_url": "https://api.github.com/users/thomasdhc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11627/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11627/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11626 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11626/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11626/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11626/events | https://github.com/NVIDIA/NeMo/pull/11626 | 2,745,078,691 | PR_kwDOC_bI7s6FgF8d | 11,626 | Add docstring for tokenizer usage in data preprocessing script | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module preprocess_data_for_megatron\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:216:0: C0301: Line too long (168/119) (line-too-long)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:266:0: C0301: Line too long (164/119) (line-too-long)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:117:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:130:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:131:4: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:135:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:152:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:156:4: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:176:4: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:209:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:286:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.36/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module preprocess_data_for_megatron\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:216:0: C0301: Line too long (168/119) (line-too-long)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:266:0: C0301: Line too long (164/119) (line-too-long)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:117:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:130:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:131:4: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:135:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:152:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:156:4: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:176:4: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:209:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/nlp_language_modeling/preprocess_data_for_megatron.py:286:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.36/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @suiyoubi 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12433348300) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-17T14:22:57 | 2025-01-02T15:50:30 | 2025-01-02T15:50:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11626",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11626",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11626.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11626.patch",
"merged_at": "2025-01-02T15:50:29"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11626/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11626/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11625 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11625/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11625/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11625/events | https://github.com/NVIDIA/NeMo/issues/11625 | 2,744,932,646 | I_kwDOC_bI7s6jnFkm | 11,625 | How to disable `torch_dist` ckpt format ? | {
"login": "zhaoyang-star",
"id": 24290792,
"node_id": "MDQ6VXNlcjI0MjkwNzky",
"avatar_url": "https://avatars.githubusercontent.com/u/24290792?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zhaoyang-star",
"html_url": "https://github.com/zhaoyang-star",
"followers_url": "https://api.github.com/users/zhaoyang-star/followers",
"following_url": "https://api.github.com/users/zhaoyang-star/following{/other_user}",
"gists_url": "https://api.github.com/users/zhaoyang-star/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zhaoyang-star/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhaoyang-star/subscriptions",
"organizations_url": "https://api.github.com/users/zhaoyang-star/orgs",
"repos_url": "https://api.github.com/users/zhaoyang-star/repos",
"events_url": "https://api.github.com/users/zhaoyang-star/events{/privacy}",
"received_events_url": "https://api.github.com/users/zhaoyang-star/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-12-17T13:21:30 | 2025-01-17T01:55:54 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I noticed that `torch_dist` is the default ckpt format. How to set it to the normal `.pt` format? Thanks in advance. | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11625/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11625/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11624 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11624/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11624/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11624/events | https://github.com/NVIDIA/NeMo/pull/11624 | 2,744,796,081 | PR_kwDOC_bI7s6FfISf | 11,624 | ci: Improve Pylint guidance | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.sentencepiece_tokenizer\nnemo/export/sentencepiece_tokenizer.py:236:0: C0301: Line too long (139/119) (line-too-long)\nnemo/export/sentencepiece_tokenizer.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:138:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:144:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:186:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:194:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:202:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:217:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:224:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:231:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:243:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:253:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:256:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer.py:266:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 8.70/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.sentencepiece_tokenizer_copy\nnemo/export/sentencepiece_tokenizer_copy.py:236:0: C0301: Line too long (137/119) (line-too-long)\nnemo/export/sentencepiece_tokenizer_copy.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:113:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:138:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:144:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:161:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:186:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:194:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:202:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:217:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:224:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:231:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:243:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:253:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:256:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/sentencepiece_tokenizer_copy.py:266:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 8.70/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"sorry i didnt get back to this until now. \r\nApproved"
] | 2024-12-17T12:23:17 | 2024-12-17T21:45:09 | 2024-12-17T19:08:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11624",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11624",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11624.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11624.patch",
"merged_at": "2024-12-17T19:08:43"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11624/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11624/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11623 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11623/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11623/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11623/events | https://github.com/NVIDIA/NeMo/issues/11623 | 2,744,110,778 | I_kwDOC_bI7s6jj866 | 11,623 | speaker diarization inference Error: Missing 'speaker_model_cfg' Key in Configuration When Using Pretrained CKPT File | {
"login": "sipercai",
"id": 53717475,
"node_id": "MDQ6VXNlcjUzNzE3NDc1",
"avatar_url": "https://avatars.githubusercontent.com/u/53717475?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sipercai",
"html_url": "https://github.com/sipercai",
"followers_url": "https://api.github.com/users/sipercai/followers",
"following_url": "https://api.github.com/users/sipercai/following{/other_user}",
"gists_url": "https://api.github.com/users/sipercai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sipercai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sipercai/subscriptions",
"organizations_url": "https://api.github.com/users/sipercai/orgs",
"repos_url": "https://api.github.com/users/sipercai/repos",
"events_url": "https://api.github.com/users/sipercai/events{/privacy}",
"received_events_url": "https://api.github.com/users/sipercai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-12-17T07:10:32 | 2025-01-17T01:55:55 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | When running inference with the `multiscale_diar_decoder_infer.py` script after training the model, an error occurs related to a missing configuration attribute (`speaker_model_cfg`). The error traceback indicates that the configuration used for inference does not contain the required `speaker_model_cfg` key.
**Steps/Code to reproduce bug**
1. Train the model using the following command:
```bash
./multiscale_diar_decoder.py --config-path=../conf/neural_diarizer --config-name=msdd_5scl_15_05_50Povl_256x3x32x2.yaml model.train_ds.manifest_filepath=/data2/xxx_data/SD/nemo/msdwild/train/msdd_data.50step.json model.validation_ds.manifest_filepath=/data2/xxx_data/SD/nemo/msdwild/test/msdd_data.50step.json model.train_ds.emb_dir=/data2/xxx_data/SD/nemo/msdwild/train model.validation_ds.emb_dir=/data2/xxx_data/SD/nemo/msdwild/test exp_manager.name=sample_train exp_manager.exp_dir=./msdd_exp
```
2. After training, use the following command to run inference:
```bash
python multiscale_diar_decoder_infer.py --config-path='../conf/inference' --config-name='diar_infer_telephonic.yaml' \
diarizer.msdd_model.model_path='/home/data/xxx/project/SD/NeMo/examples/speaker_tasks/diarization/neural_diarizer/msdd_exp/sample_train/2024-12-17_12-32-23/checkpoints/test.ckpt' \
diarizer.oracle_vad=True \
diarizer.manifest_filepath='/data2/xxx_data/SD/nemo/msdwild/train/msdd_data.50step.json' \
diarizer.out_dir='output'
```
3. The following error occurs during inference:
```
Traceback (most recent call last):
File "/home/data/xxx/project/SD/NeMo/examples/speaker_tasks/diarization/neural_diarizer/multiscale_diar_decoder_infer.py", line 31, in main
diarizer_model = NeuralDiarizer(cfg=cfg).to(cfg.device)
File "/home/data/xxx/anaconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/asr/models/msdd_models.py", line 1019, in __init__
self._init_msdd_model(cfg)
File "/home/data/xxx/anaconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/asr/models/msdd_models.py", line 1114, in _init_msdd_model
self.msdd_model = EncDecDiarLabelModel.load_from_checkpoint(
File "/home/data/xxx/anaconda3/envs/nemo/lib/python3.10/site-packages/nemo/core/classes/modelPT.py", line 506, in load_from_checkpoint
checkpoint = super().load_from_checkpoint(
File "/home/data/xxx/anaconda3/envs/nemo/lib/python3.10/site-packages/lightning/pytorch/utilities/model_helpers.py", line 125, in wrapper
return self.method(cls, *args, **kwargs)
File "/home/data/xxx/anaconda3/envs/nemo/lib/python3.10/site-packages/lightning/pytorch/core/module.py", line 1582, in load_from_checkpoint
loaded = _load_from_checkpoint(
File "/home/data/xxx/anaconda3/envs/nemo/lib/python3.10/site-packages/lightning/pytorch/core/saving.py", line 91, in _load_from_checkpoint
model = _load_state(cls, checkpoint, strict=strict, **kwargs)
File "/home/data/xxx/anaconda3/envs/nemo/lib/python3.10/site-packages/lightning/pytorch/core/saving.py", line 165, in _load_state
obj = instantiator(cls, _cls_kwargs) if instantiator else cls(**_cls_kwargs)
File "/home/data/xxx/anaconda3/envs/nemo/lib/python3.10/site-packages/nemo/collections/asr/models/msdd_models.py", line 145, in __init__
self.msdd._speaker_model = EncDexxxeakerLabelModel.from_config_dict(cfg.speaker_model_cfg)
omegaconf.errors.ConfigAttributeError: Key 'speaker_model_cfg' is not in struct
full_key: cfg.speaker_model_cfg
object_type=dict
```
I found a similar issue in #8463, but I am passing the ckpt file and the issue is not resolved.
Could you please help? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11623/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11623/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11622 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11622/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11622/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11622/events | https://github.com/NVIDIA/NeMo/pull/11622 | 2,743,996,055 | PR_kwDOC_bI7s6FcXve | 11,622 | Cherrypick all + R2.1.0 fix cicd | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module pretraining\nscripts/llm/pretraining.py:35:0: C0301: Line too long (151/119) (line-too-long)\nscripts/llm/pretraining.py:144:0: C0301: Line too long (142/119) (line-too-long)\nscripts/llm/pretraining.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:119:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/llm/pretraining.py:22:0: W0611: Unused Any imported from typing (unused-import)\n\n-----------------------------------\nYour code has been rated at 8.73/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.t5.data.mock\nnemo/collections/llm/t5/data/mock.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/data/mock.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:89:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.data.pre_training\nnemo/collections/llm/t5/data/pre_training.py:302:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/llm/t5/data/pre_training.py:309:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/llm/t5/data/pre_training.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:226:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:229:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:246:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/pre_training.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.deploy.deploy_pytriton\nnemo/deploy/deploy_pytriton.py:53:0: C0301: Line too long (132/119) (line-too-long)\nnemo/deploy/deploy_pytriton.py:83:0: C0301: Line too long (126/119) (line-too-long)\n************* Module nemo.export.trt_llm.converter.model_to_trt_llm_ckpt\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:55:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:101:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:130:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:294:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:301:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:308:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/converter/model_to_trt_llm_ckpt.py:509:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.nemo_ckpt_loader.nemo_file\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:73:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:96:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:104:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:114:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:125:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:136:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:174:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:188:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:192:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:201:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:226:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:237:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:313:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:431:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:515:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:519:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:530:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:542:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:582:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:619:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:632:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py:27:0: W0611: Unused import tensorstore (unused-import)\n************* Module scripts.checkpoint_converters.convert_gpt_nemo_to_mcore\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:153:0: C0301: Line too long (122/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:154:0: C0301: Line too long (131/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:161:0: C0301: Line too long (127/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:162:0: C0301: Line too long (125/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:235:0: C0301: Line too long (133/119) (line-too-long)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:48:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:84:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:109:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:117:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:169:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:192:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:223:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_gpt_nemo_to_mcore.py:260:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.checkpoint_converters.convert_mixtral_hf_to_nemo\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:477:0: C0301: Line too long (146/119) (line-too-long)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:52:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:80:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:175:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:191:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:204:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:244:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:399:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:412:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:468:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py:520:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.deploy.nlp.deploy_triton\nscripts/deploy/nlp/deploy_triton.py:393:0: C0301: Line too long (121/119) (line-too-long)\nscripts/deploy/nlp/deploy_triton.py:30:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/deploy/nlp/deploy_triton.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:259:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:370:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:377:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module export_to_trt_llm\nscripts/export/export_to_trt_llm.py:25:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/export/export_to_trt_llm.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/export/export_to_trt_llm.py:156:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.63/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @pablo-garay 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12367244661) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-17T05:51:24 | 2024-12-17T15:18:57 | 2024-12-17T15:18:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11622",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11622",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11622.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11622.patch",
"merged_at": "2024-12-17T15:18:55"
} | Cherrypick all + R2.1.0 fix cicd | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11622/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11622/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11621 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11621/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11621/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11621/events | https://github.com/NVIDIA/NeMo/pull/11621 | 2,743,971,969 | PR_kwDOC_bI7s6FcSd8 | 11,621 | Handle MCore custom fsdp checkpoint load | {
"login": "shjwudp",
"id": 11439912,
"node_id": "MDQ6VXNlcjExNDM5OTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/11439912?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shjwudp",
"html_url": "https://github.com/shjwudp",
"followers_url": "https://api.github.com/users/shjwudp/followers",
"following_url": "https://api.github.com/users/shjwudp/following{/other_user}",
"gists_url": "https://api.github.com/users/shjwudp/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shjwudp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shjwudp/subscriptions",
"organizations_url": "https://api.github.com/users/shjwudp/orgs",
"repos_url": "https://api.github.com/users/shjwudp/repos",
"events_url": "https://api.github.com/users/shjwudp/events{/privacy}",
"received_events_url": "https://api.github.com/users/shjwudp/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.diffusion.flux_controlnet_infer\nnemo/collections/diffusion/flux_controlnet_infer.py:28:0: C0301: Line too long (188/119) (line-too-long)\nnemo/collections/diffusion/flux_controlnet_infer.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.diffusion.flux_controlnet_training\nnemo/collections/diffusion/flux_controlnet_training.py:36:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/flux_controlnet_training.py:18:0: W0611: Unused torch.nn imported as nn (unused-import)\nnemo/collections/diffusion/flux_controlnet_training.py:22:0: W0611: Unused AutoProcessor imported from transformers (unused-import)\nnemo/collections/diffusion/flux_controlnet_training.py:30:0: W0611: Unused Utils imported from nemo.collections.diffusion.utils.mcore_parallel_utils (unused-import)\n************* Module nemo.collections.diffusion.flux_training\nnemo/collections/diffusion/flux_training.py:36:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/flux_training.py:18:0: W0611: Unused torch.nn imported as nn (unused-import)\nnemo/collections/diffusion/flux_training.py:22:0: W0611: Unused AutoProcessor imported from transformers (unused-import)\nnemo/collections/diffusion/flux_training.py:30:0: W0611: Unused Utils imported from nemo.collections.diffusion.utils.mcore_parallel_utils (unused-import)\n************* Module nemo.collections.diffusion.models.flux.model\nnemo/collections/diffusion/models/flux/model.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/model.py:95:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:101:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/model.py:110:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/model.py:159:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:224:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/model.py:246:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:261:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:264:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:297:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:300:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:303:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:362:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:395:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:486:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:490:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:497:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/model.py:42:0: W0611: Unused megatron_parallel imported from nemo.lightning as mp (unused-import)\n************* Module nemo.collections.diffusion.models.flux.pipeline\nnemo/collections/diffusion/models/flux/pipeline.py:65:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/diffusion/models/flux/pipeline.py:373:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/diffusion/models/flux/pipeline.py:382:0: C0301: Line too long (171/119) (line-too-long)\nnemo/collections/diffusion/models/flux/pipeline.py:36:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:51:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:69:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:222:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:227:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:346:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:386:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:394:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux/pipeline.py:401:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module layers\nnemo/collections/diffusion/models/flux_controlnet/layers.py:53:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/layers.py:17:0: W0611: Unused import torch (unused-import)\n************* Module model\nnemo/collections/diffusion/models/flux_controlnet/model.py:244:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/diffusion/models/flux_controlnet/model.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/model.py:30:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/model.py:42:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux_controlnet/model.py:69:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux_controlnet/model.py:128:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/model.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/model.py:217:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux_controlnet/model.py:230:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux_controlnet/model.py:2:0: W0611: Unused List imported from typing (unused-import)\nnemo/collections/diffusion/models/flux_controlnet/model.py:4:0: W0611: Unused numpy imported as np (unused-import)\nnemo/collections/diffusion/models/flux_controlnet/model.py:11:0: W0611: Unused AdaLNContinuous imported from nemo.collections.diffusion.models.dit.dit_layer_spec (unused-import)\n************* Module pipeline\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:52:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:17:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:37:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:56:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:83:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:158:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:204:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:209:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:212:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:1:0: W0611: Unused Any imported from typing (unused-import)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:1:0: W0611: Unused Callable imported from typing (unused-import)\nnemo/collections/diffusion/models/flux_controlnet/pipeline.py:1:0: W0611: Unused Tuple imported from typing (unused-import)\n************* Module nemo.collections.diffusion.utils.flux_pipeline_utils\nnemo/collections/diffusion/utils/flux_pipeline_utils.py:15:0: W0611: Unused dataclass imported from dataclasses (unused-import)\nnemo/collections/diffusion/utils/flux_pipeline_utils.py:16:0: W0611: Unused Callable imported from typing (unused-import)\nnemo/collections/diffusion/utils/flux_pipeline_utils.py:18:0: W0611: Unused import torch (unused-import)\nnemo/collections/diffusion/utils/flux_pipeline_utils.py:19:0: W0611: Unused TransformerConfig imported from megatron.core.transformer.transformer_config (unused-import)\nnemo/collections/diffusion/utils/flux_pipeline_utils.py:24:0: W0611: Unused io imported from nemo.lightning (unused-import)\n************* Module nemo.lightning._strategy_lib\nnemo/lightning/_strategy_lib.py:574:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/_strategy_lib.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/_strategy_lib.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:166:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:202:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:515:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:599:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:612:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.megatron_parallel\nnemo/lightning/megatron_parallel.py:240:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:241:0: C0301: Line too long (140/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:242:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:551:0: C0301: Line too long (129/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:558:0: C0301: Line too long (135/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:827:0: C0301: Line too long (137/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1057:0: C0301: Line too long (136/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1624:0: C0301: Line too long (128/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:1663:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/megatron_parallel.py:66:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:69:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:104:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:108:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:308:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:332:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:358:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:384:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:520:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:566:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:570:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:635:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:678:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:712:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:720:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:736:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:763:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:775:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:797:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1317:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1492:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1498:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1504:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1508:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1513:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1518:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1546:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1592:8: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1614:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1687:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/megatron_parallel.py:1726:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:1740:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/megatron_parallel.py:51:0: W0611: Unused TrainerFn imported from pytorch_lightning.trainer.states (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.36/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-12-17T05:31:23 | 2024-12-17T17:56:48 | 2024-12-17T17:56:48 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11621",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11621",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11621.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11621.patch",
"merged_at": "2024-12-17T17:56:48"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Victor49152",
"id": 111467530,
"node_id": "U_kgDOBqTcCg",
"avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Victor49152",
"html_url": "https://github.com/Victor49152",
"followers_url": "https://api.github.com/users/Victor49152/followers",
"following_url": "https://api.github.com/users/Victor49152/following{/other_user}",
"gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions",
"organizations_url": "https://api.github.com/users/Victor49152/orgs",
"repos_url": "https://api.github.com/users/Victor49152/repos",
"events_url": "https://api.github.com/users/Victor49152/events{/privacy}",
"received_events_url": "https://api.github.com/users/Victor49152/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11621/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11621/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11620 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11620/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11620/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11620/events | https://github.com/NVIDIA/NeMo/pull/11620 | 2,743,813,718 | PR_kwDOC_bI7s6FbwTw | 11,620 | temp: make flaky test optional | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Already merged cherrypick in different PR"
] | 2024-12-17T02:59:35 | 2024-12-17T16:49:34 | 2024-12-17T16:49:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11620",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11620",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11620.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11620.patch",
"merged_at": null
} | temp: make flaky test optional | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11620/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11620/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11619 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11619/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11619/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11619/events | https://github.com/NVIDIA/NeMo/pull/11619 | 2,743,719,202 | PR_kwDOC_bI7s6FbcVl | 11,619 | Add more fine-grained performance metrics | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"[🤖]: Hi @ashors1 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12813863285) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.progress_printer\nnemo/lightning/pytorch/callbacks/progress_printer.py:116:0: C0301: Line too long (124/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/progress_printer.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:86:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:98:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:106:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:182:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:195:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:213:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.utils.exp_manager\nnemo/utils/exp_manager.py:372:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:397:0: C0301: Line too long (124/119) (line-too-long)\nnemo/utils/exp_manager.py:401:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:406:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:420:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:427:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:428:0: C0301: Line too long (126/119) (line-too-long)\nnemo/utils/exp_manager.py:430:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:432:0: C0301: Line too long (139/119) (line-too-long)\nnemo/utils/exp_manager.py:442:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:443:0: C0301: Line too long (128/119) (line-too-long)\nnemo/utils/exp_manager.py:444:0: C0301: Line too long (132/119) (line-too-long)\nnemo/utils/exp_manager.py:445:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:533:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:621:0: C0301: Line too long (208/119) (line-too-long)\nnemo/utils/exp_manager.py:622:0: C0301: Line too long (230/119) (line-too-long)\nnemo/utils/exp_manager.py:624:0: C0301: Line too long (178/119) (line-too-long)\nnemo/utils/exp_manager.py:661:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:796:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:804:0: C0301: Line too long (156/119) (line-too-long)\nnemo/utils/exp_manager.py:851:0: C0301: Line too long (141/119) (line-too-long)\nnemo/utils/exp_manager.py:859:0: C0301: Line too long (152/119) (line-too-long)\nnemo/utils/exp_manager.py:1129:0: C0301: Line too long (142/119) (line-too-long)\nnemo/utils/exp_manager.py:1153:0: C0301: Line too long (154/119) (line-too-long)\nnemo/utils/exp_manager.py:1219:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:1238:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:1264:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:97:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:112:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:138:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:147:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:156:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:167:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:281:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:284:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:302:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:308:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:311:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:314:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:352:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:355:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:358:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1145:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1246:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1265:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1268:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1284:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.41/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.progress_printer\nnemo/lightning/pytorch/callbacks/progress_printer.py:116:0: C0301: Line too long (124/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/progress_printer.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:86:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:98:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:106:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:182:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:195:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:210:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/progress_printer.py:213:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.utils.exp_manager\nnemo/utils/exp_manager.py:372:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:397:0: C0301: Line too long (124/119) (line-too-long)\nnemo/utils/exp_manager.py:401:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:406:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:420:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:427:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:428:0: C0301: Line too long (126/119) (line-too-long)\nnemo/utils/exp_manager.py:430:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:432:0: C0301: Line too long (139/119) (line-too-long)\nnemo/utils/exp_manager.py:442:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:443:0: C0301: Line too long (128/119) (line-too-long)\nnemo/utils/exp_manager.py:444:0: C0301: Line too long (132/119) (line-too-long)\nnemo/utils/exp_manager.py:445:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:533:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:621:0: C0301: Line too long (208/119) (line-too-long)\nnemo/utils/exp_manager.py:622:0: C0301: Line too long (230/119) (line-too-long)\nnemo/utils/exp_manager.py:624:0: C0301: Line too long (178/119) (line-too-long)\nnemo/utils/exp_manager.py:661:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:796:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:804:0: C0301: Line too long (156/119) (line-too-long)\nnemo/utils/exp_manager.py:851:0: C0301: Line too long (141/119) (line-too-long)\nnemo/utils/exp_manager.py:859:0: C0301: Line too long (152/119) (line-too-long)\nnemo/utils/exp_manager.py:1129:0: C0301: Line too long (142/119) (line-too-long)\nnemo/utils/exp_manager.py:1153:0: C0301: Line too long (154/119) (line-too-long)\nnemo/utils/exp_manager.py:1219:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:1238:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:1264:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:97:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:112:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:138:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:147:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:156:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:167:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:281:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:284:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:302:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:308:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:311:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:314:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:352:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:355:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:358:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1145:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1246:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1265:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1268:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1284:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.41/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @ashors1 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12837350287) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-17T01:17:05 | 2025-01-18T07:44:40 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11619",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11619",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11619.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11619.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11619/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11619/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11618 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11618/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11618/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11618/events | https://github.com/NVIDIA/NeMo/pull/11618 | 2,743,668,645 | PR_kwDOC_bI7s6FbRYs | 11,618 | chore(beep boop 🤖): Bump `MCORE_TAG=14ca285...` (2024-12-17) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-17T00:24:25 | 2025-01-03T12:54:51 | 2025-01-03T12:54:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11618",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11618",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11618.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11618.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=14ca285dcc8b6862fbb992ef8de57402479c0e9f`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11618/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11618/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11617 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11617/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11617/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11617/events | https://github.com/NVIDIA/NeMo/pull/11617 | 2,743,566,466 | PR_kwDOC_bI7s6Fa7Iy | 11,617 | Cherry pick `ci: Add `no-fail-fast` mode (11608)` into `r2.1.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Already merged cherrypick in different PR"
] | 2024-12-16T23:00:29 | 2024-12-17T16:46:37 | 2024-12-17T16:46:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11617",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11617",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11617.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11617.patch",
"merged_at": null
} | beep boop [🤖]: Hi @ko3n1g 👋,
we've cherry picked #11608 into for you! 🚀
Please review and approve this cherry pick by your convenience! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11617/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11617/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11616 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11616/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11616/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11616/events | https://github.com/NVIDIA/NeMo/pull/11616 | 2,743,424,124 | PR_kwDOC_bI7s6FabeM | 11,616 | Huvu/t5 test mlmcommit | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @huvunvidia 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12361604297) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"Not needed, updated this commit in the release branch."
] | 2024-12-16T21:22:08 | 2024-12-18T04:22:44 | 2024-12-18T04:22:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11616",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11616",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11616.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11616.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11616/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11616/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11615 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11615/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11615/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11615/events | https://github.com/NVIDIA/NeMo/pull/11615 | 2,743,226,391 | PR_kwDOC_bI7s6FZu_s | 11,615 | Cherrypick #11587 to r2.1.0 | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Already merged cherrypick in different PR"
] | 2024-12-16T19:35:17 | 2024-12-17T16:46:26 | 2024-12-17T16:46:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11615",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11615",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11615.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11615.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11615/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11615/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11614 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11614/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11614/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11614/events | https://github.com/NVIDIA/NeMo/pull/11614 | 2,743,124,757 | PR_kwDOC_bI7s6FZYNK | 11,614 | Fix moe and Gemma issue for TRTLLM Mcore export | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Hey @meatybobby. Thanks for issuing fixes. Because https://github.com/NVIDIA/NeMo/pull/11409 includes them (except [this one](https://github.com/NVIDIA/NeMo/pull/11409#discussion_r1894033070)), I think we can close the MR here and focus on landing 11409. OK?",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"All the fixes are already in main branch, closing the MR here.\r\n\r\nThanks for helping to identify and fix them."
] | 2024-12-16T18:44:07 | 2025-01-07T08:57:54 | 2025-01-07T08:57:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11614",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11614",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11614.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11614.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11614/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11614/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11613 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11613/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11613/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11613/events | https://github.com/NVIDIA/NeMo/pull/11613 | 2,743,093,369 | PR_kwDOC_bI7s6FZRT_ | 11,613 | add nemo2-sft-peft to readme | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-12-16T18:27:26 | 2024-12-16T21:41:00 | 2024-12-16T19:30:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11613",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11613",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11613.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11613.patch",
"merged_at": "2024-12-16T19:30:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11613/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11613/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11612 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11612/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11612/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11612/events | https://github.com/NVIDIA/NeMo/pull/11612 | 2,743,092,430 | PR_kwDOC_bI7s6FZRGi | 11,612 | Add sampling args in TRTLLM generate | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.trt_llm.tensorrt_llm_run\nnemo/export/trt_llm/tensorrt_llm_run.py:511:0: C0301: Line too long (125/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:515:0: C0301: Line too long (136/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:519:0: C0301: Line too long (123/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:562:0: C0301: Line too long (181/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:846:0: C0301: Line too long (153/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:529:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:538:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:596:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:33:0: W0611: Unused Mapping imported from tensorrt_llm.mapping (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.75/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.export.trt_llm.tensorrt_llm_run\nnemo/export/trt_llm/tensorrt_llm_run.py:511:0: C0301: Line too long (125/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:515:0: C0301: Line too long (136/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:519:0: C0301: Line too long (123/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:562:0: C0301: Line too long (181/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:846:0: C0301: Line too long (153/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:529:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:538:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:596:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:33:0: W0611: Unused Mapping imported from tensorrt_llm.mapping (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.75/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-12-16T18:26:52 | 2025-01-16T17:30:27 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11612",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11612",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11612.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11612.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11612/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11612/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11611 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11611/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11611/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11611/events | https://github.com/NVIDIA/NeMo/pull/11611 | 2,743,063,485 | PR_kwDOC_bI7s6FZKtk | 11,611 | Add check for symlink in extraction of nemo files | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.core.connectors.save_restore_connector\nnemo/core/connectors/save_restore_connector.py:50:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:203:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:302:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:416:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:421:0: C0301: Line too long (141/119) (line-too-long)\nnemo/core/connectors/save_restore_connector.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/core/connectors/save_restore_connector.py:690:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:698:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:706:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/connectors/save_restore_connector.py:714:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.69/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @athitten 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12418592706) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-16T18:11:04 | 2024-12-20T05:07:48 | 2024-12-20T05:07:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11611",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11611",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11611.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11611.patch",
"merged_at": "2024-12-20T05:07:47"
} | # What does this PR do ?
Checks for symlink during extraction of nemo tar files and disallows the extraction if a symlink or hard link exists to avoid security vulnerabilities.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11611/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11611/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11610 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11610/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11610/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11610/events | https://github.com/NVIDIA/NeMo/pull/11610 | 2,742,833,287 | PR_kwDOC_bI7s6FYYFi | 11,610 | remove deprecated files | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Already merged cherrypick in different PR"
] | 2024-12-16T16:23:09 | 2024-12-17T16:46:16 | 2024-12-17T16:46:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11610",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11610",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11610.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11610.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11610/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11610/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11609 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11609/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11609/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11609/events | https://github.com/NVIDIA/NeMo/pull/11609 | 2,742,254,171 | PR_kwDOC_bI7s6FWXja | 11,609 | Add Minitron depth pruning (layer dropping) to megatron_gpt_prune.py | {
"login": "kevalmorabia97",
"id": 28916987,
"node_id": "MDQ6VXNlcjI4OTE2OTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/28916987?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevalmorabia97",
"html_url": "https://github.com/kevalmorabia97",
"followers_url": "https://api.github.com/users/kevalmorabia97/followers",
"following_url": "https://api.github.com/users/kevalmorabia97/following{/other_user}",
"gists_url": "https://api.github.com/users/kevalmorabia97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevalmorabia97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevalmorabia97/subscriptions",
"organizations_url": "https://api.github.com/users/kevalmorabia97/orgs",
"repos_url": "https://api.github.com/users/kevalmorabia97/repos",
"events_url": "https://api.github.com/users/kevalmorabia97/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevalmorabia97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @kevalmorabia97 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12369936843) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module megatron_gpt_drop_layers\nexamples/nlp/language_modeling/megatron_gpt_drop_layers.py:16:0: C0301: Line too long (125/119) (line-too-long)\nexamples/nlp/language_modeling/megatron_gpt_drop_layers.py:76:0: C0301: Line too long (218/119) (line-too-long)\nexamples/nlp/language_modeling/megatron_gpt_drop_layers.py:167:0: C0301: Line too long (192/119) (line-too-long)\nexamples/nlp/language_modeling/megatron_gpt_drop_layers.py:54:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/nlp/language_modeling/megatron_gpt_drop_layers.py:102:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/nlp/language_modeling/megatron_gpt_drop_layers.py:116:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/nlp/language_modeling/megatron_gpt_drop_layers.py:45:0: W0611: Unused open_dict imported from omegaconf (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.47/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @kevalmorabia97 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12398557060) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-16T12:26:23 | 2024-12-19T23:16:21 | 2024-12-19T23:16:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11609",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11609",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11609.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11609.patch",
"merged_at": "2024-12-19T23:16:20"
} | # What does this PR do ?
- Add Minitron depth pruning (layer dropping) to `megatron_gpt_prune.py`
- Users no longer need to use 2 separate scripts for depth/width pruning. Previous depth pruning (layer dropping) script `megatron_gpt_drop_layers.py` will no longer be needed and can be deprecated in a later release
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add Minitron depth pruning (layer dropping) to `megatron_gpt_prune.py` to deprecate `megatron_gpt_drop_layers.py`
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "kevalmorabia97",
"id": 28916987,
"node_id": "MDQ6VXNlcjI4OTE2OTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/28916987?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevalmorabia97",
"html_url": "https://github.com/kevalmorabia97",
"followers_url": "https://api.github.com/users/kevalmorabia97/followers",
"following_url": "https://api.github.com/users/kevalmorabia97/following{/other_user}",
"gists_url": "https://api.github.com/users/kevalmorabia97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevalmorabia97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevalmorabia97/subscriptions",
"organizations_url": "https://api.github.com/users/kevalmorabia97/orgs",
"repos_url": "https://api.github.com/users/kevalmorabia97/repos",
"events_url": "https://api.github.com/users/kevalmorabia97/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevalmorabia97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11609/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11609/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11608 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11608/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11608/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11608/events | https://github.com/NVIDIA/NeMo/pull/11608 | 2,741,998,666 | PR_kwDOC_bI7s6FVfTn | 11,608 | ci: Add `no-fail-fast` mode | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7875884180,
"node_id": "LA_kwDOC_bI7s8AAAAB1XB0lA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.1.0",
"name": "r2.1.0",
"color": "5CD83D",
"default": false,
"description": ""
},
{
"id": 7889668318,
"node_id": "LA_kwDOC_bI7s8AAAAB1kLI3g",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/no-fail-fast",
"name": "no-fail-fast",
"color": "3013F6",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @ko3n1g 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12350941731) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-16T10:42:10 | 2024-12-17T09:26:42 | 2024-12-16T23:00:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11608",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11608",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11608.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11608.patch",
"merged_at": "2024-12-16T23:00:00"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11608/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11608/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11607 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11607/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11607/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11607/events | https://github.com/NVIDIA/NeMo/pull/11607 | 2,741,970,351 | PR_kwDOC_bI7s6FVZGe | 11,607 | Pass the number of experts to modelopt layer spec | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @janekl 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12350786407) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-16T10:29:31 | 2024-12-16T12:47:05 | 2024-12-16T12:47:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11607",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11607",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11607.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11607.patch",
"merged_at": "2024-12-16T12:47:04"
} | # What does this PR do ?
Bugfix to correctly support Mixtral for PTQ in NeMo 2.0.
**Collection**: LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to https://github.com/NVIDIA/NeMo/pull/11513
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11607/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11607/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11606 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11606/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11606/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11606/events | https://github.com/NVIDIA/NeMo/pull/11606 | 2,741,386,461 | PR_kwDOC_bI7s6FTX4R | 11,606 | Cherry pick pack (#11504, #11505, #11500, #11559, #11519, #11574, #11131) | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.jit_transform\nnemo/lightning/pytorch/callbacks/jit_transform.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:33:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:39:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:67:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:90:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:115:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.17/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.jit_transform\nnemo/lightning/pytorch/callbacks/jit_transform.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:33:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:39:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:67:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:90:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:115:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.17/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:25:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:77:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/peft/hf.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:604:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.api\nnemo/collections/llm/gpt/data/api.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:208:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:34:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:47:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:125:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:157:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:323:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:119:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:133:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:171:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:294:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:317:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:337:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:341:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:45:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:135:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:143:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:229:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:238:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:246:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:264:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:268:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:291:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:294:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:297:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:301:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:328:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:335:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:37:4: W0611: Unused import transformer_engine (unused-import)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:282:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.56/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/peft/hf.py:25:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:77:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/peft/hf.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:604:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.api\nnemo/collections/llm/gpt/data/api.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:38:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/api.py:44:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:208:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:34:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:47:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:107:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:110:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:125:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.mixtral\nnemo/collections/llm/gpt/model/mixtral.py:157:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:323:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/llm/gpt/model/mixtral.py:119:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:133:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:171:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:294:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:317:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:337:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/mixtral.py:341:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:45:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:135:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:143:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:229:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:238:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:246:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:264:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:268:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:291:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:294:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:297:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:301:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:306:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:328:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:335:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:37:4: W0611: Unused import transformer_engine (unused-import)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:282:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.56/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Not needed in release branch."
] | 2024-12-16T05:40:10 | 2024-12-16T19:41:33 | 2024-12-16T19:41:33 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11606",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11606",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11606.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11606.patch",
"merged_at": null
} | # What does this PR do ?
Cherry-pick containing the following:
- f0597d16177d8c735b9c49a00c3ade0159d0a5df
- 171a7af32c1422a264688fbd11f61bb9468999de
- 3d94b7e963deba805912d26f4d703c000be8a0d5
- 05398c6f99a8acd1478b0bd1c98aab97fb16cc1b
- 5452848750fc47ff0a055beab8fe4ee3b789fcdf
- da70785aa4f9a9dad688981658032ad4e20fcbe4
- a5517048645eae97a9a9fbb2cd36b2051a0b64dd
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11606/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11606/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11605 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11605/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11605/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11605/events | https://github.com/NVIDIA/NeMo/pull/11605 | 2,741,026,219 | PR_kwDOC_bI7s6FSH21 | 11,605 | chore(beep boop 🤖): Bump `MCORE_TAG=71c394b...` (2024-12-16) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-12-16T00:25:42 | 2025-01-03T12:54:48 | 2025-01-03T12:54:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11605",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11605",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11605.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11605.patch",
"merged_at": null
} | 🚀 PR to bump `NVIDIA/Megatron-LM` in `Dockerfile.ci` to `MCORE_TAG=71c394b172ce4f1b9466e1d728bad5cc6314d15d`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11605/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11605/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11604 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11604/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11604/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11604/events | https://github.com/NVIDIA/NeMo/issues/11604 | 2,740,770,494 | I_kwDOC_bI7s6jXNa- | 11,604 | Possible bug in ASRDecoderTimeStamps - math.ceil on fractional tokens_per_chunk leads to timestamps displacements on long files | {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"@tango4j , could you look at this? maybe at least change default values and add comment?"
] | 2024-12-15T17:12:11 | 2025-01-17T01:55:56 | null | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I used the class `ASRDecoderTimeStamps` with fastconformer model and observed incorrect timestamps on long (1 hour) audio. The timestamps near the end of file were offset by several seconds, bigger than the actual filesize.
I think the problem is in this expression when the result of division is fractional:
https://github.com/NVIDIA/NeMo/blob/186a05ef7a0ec702f4ab56b3eb6ec3c21d096b36/nemo/collections/asr/parts/utils/decoder_timestamps_utils.py#L633
For example, default values for fastconformer `self.chunk_len_in_sec = 15` and `self.model_stride_in_secs = 0.08` lead to fractional 187.5 being rounded to 188. It seems that the rounding error somehow accumulates on long audios.
When I set `self.chunk_len_in_sec = 14`, `14/0.08=175` (whole number), all timestamps are exact.
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11604/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11604/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11603 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11603/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11603/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11603/events | https://github.com/NVIDIA/NeMo/pull/11603 | 2,740,770,484 | PR_kwDOC_bI7s6FRQ1q | 11,603 | [Bug-fix] Set Minitron width pruning batch size 1 for optimal results | {
"login": "kevalmorabia97",
"id": 28916987,
"node_id": "MDQ6VXNlcjI4OTE2OTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/28916987?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevalmorabia97",
"html_url": "https://github.com/kevalmorabia97",
"followers_url": "https://api.github.com/users/kevalmorabia97/followers",
"following_url": "https://api.github.com/users/kevalmorabia97/following{/other_user}",
"gists_url": "https://api.github.com/users/kevalmorabia97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevalmorabia97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevalmorabia97/subscriptions",
"organizations_url": "https://api.github.com/users/kevalmorabia97/orgs",
"repos_url": "https://api.github.com/users/kevalmorabia97/repos",
"events_url": "https://api.github.com/users/kevalmorabia97/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevalmorabia97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[🤖]: Hi @kevalmorabia97 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12340762844) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[🤖]: Hi @kevalmorabia97 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12360187401) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-12-15T17:12:08 | 2024-12-16T21:33:56 | 2024-12-16T21:33:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11603",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11603",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11603.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11603.patch",
"merged_at": "2024-12-16T21:33:55"
} | # What does this PR do ?
Set Minitron width pruning batch size 1. BS>1 leads to ~1% MMLU drop for Llama 3.1 8B -> 4.5B width pruning compared to Minitron paper
**Collection**: N/A
# Changelog
- Set Minitron width pruning batch size 1 for optimal results
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "kevalmorabia97",
"id": 28916987,
"node_id": "MDQ6VXNlcjI4OTE2OTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/28916987?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevalmorabia97",
"html_url": "https://github.com/kevalmorabia97",
"followers_url": "https://api.github.com/users/kevalmorabia97/followers",
"following_url": "https://api.github.com/users/kevalmorabia97/following{/other_user}",
"gists_url": "https://api.github.com/users/kevalmorabia97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevalmorabia97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevalmorabia97/subscriptions",
"organizations_url": "https://api.github.com/users/kevalmorabia97/orgs",
"repos_url": "https://api.github.com/users/kevalmorabia97/repos",
"events_url": "https://api.github.com/users/kevalmorabia97/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevalmorabia97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11603/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11603/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11602 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11602/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11602/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11602/events | https://github.com/NVIDIA/NeMo/issues/11602 | 2,740,628,317 | I_kwDOC_bI7s6jWqtd | 11,602 | nemo forced aligner ''Tutorial: "How to use NFA?" 🚀 " not working | {
"login": "rachidis",
"id": 29929510,
"node_id": "MDQ6VXNlcjI5OTI5NTEw",
"avatar_url": "https://avatars.githubusercontent.com/u/29929510?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rachidis",
"html_url": "https://github.com/rachidis",
"followers_url": "https://api.github.com/users/rachidis/followers",
"following_url": "https://api.github.com/users/rachidis/following{/other_user}",
"gists_url": "https://api.github.com/users/rachidis/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rachidis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rachidis/subscriptions",
"organizations_url": "https://api.github.com/users/rachidis/orgs",
"repos_url": "https://api.github.com/users/rachidis/repos",
"events_url": "https://api.github.com/users/rachidis/events{/privacy}",
"received_events_url": "https://api.github.com/users/rachidis/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-12-15T12:54:57 | 2025-01-15T01:56:40 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
nemo
[A clear and concise description of what the bug is.
https://github.com/NVIDIA/NeMo/tree/main/tools/nemo_forced_aligner
is no more working
](https://colab.research.google.com/github/NVIDIA/NeMo/blob/main/tutorials/tools/NeMo_Forced_Aligner_Tutorial.ipynb)
**Steps/Code to reproduce bug**
3. Run NFA
It keeps requiring installing packages
unfortunately because of knowledge i could not resolve the problem. | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11602/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11602/timeline | null | null | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11601 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11601/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11601/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11601/events | https://github.com/NVIDIA/NeMo/issues/11601 | 2,740,579,046 | I_kwDOC_bI7s6jWerm | 11,601 | NeMo won't install, no module named torch | {
"login": "sedol1339",
"id": 5188731,
"node_id": "MDQ6VXNlcjUxODg3MzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/5188731?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sedol1339",
"html_url": "https://github.com/sedol1339",
"followers_url": "https://api.github.com/users/sedol1339/followers",
"following_url": "https://api.github.com/users/sedol1339/following{/other_user}",
"gists_url": "https://api.github.com/users/sedol1339/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sedol1339/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sedol1339/subscriptions",
"organizations_url": "https://api.github.com/users/sedol1339/orgs",
"repos_url": "https://api.github.com/users/sedol1339/repos",
"events_url": "https://api.github.com/users/sedol1339/events{/privacy}",
"received_events_url": "https://api.github.com/users/sedol1339/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | open | false | null | [] | null | [
"When I download the latest NeMo container from [here](https://catalog.ngc.nvidia.com/orgs/nvidia/containers/nemo/tags):\n```bash\ndocker pull nvcr.io/nvidia/nemo:24.12\n```\n\nI see a version of Python of 3.10.12, rather than 3.12.3. There may be a compatibility issue with the later version of Python.\n\nWhen I use the [PyTorch Configurator](https://pytorch.org/get-started/locally/), and select Stable (2.5.1), Linux, Pip, Python, and CUDA 12.4, this is the command to run:\n```bash\npip3 install torch torchvision torchaudio\n```\n\nWhen I then run \n```bash\npip3 install nemo_toolkit['all']\n```\n\nI don't seem to run into the errors you stated, but I do run into other errors when it comes to a requirement of the mamba, fasttext and texterrors modules. The end of my error shows this:\n```plaintext\nSuccessfully built mamba-ssm progress clip jieba kaldi-python-io pesq rouge-score sox wget distance docopt intervaltree asciitree cdifflib\nFailed to build fasttext texterrors\nERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (fasttext, texterrors)\n``` \n\nFor now, I would suggest just using the Docker container if you can. Here are NVIDIA's instructions: https://docs.nvidia.com/nemo-framework/user-guide/latest/installation.html.\n\nMy summary:\n1. Pull the docker container (takes about 10 min):\n```bash\ndocker pull nvcr.io/nvidia/nemo:24.12\n```\n\n2. Get the docker image ID\n```bash\ndocker images\n```\n```plaintext\nREPOSITORY TAG IMAGE ID CREATED SIZE\nnvcr.io/nvidia/nemo 24.12 684e6b41c9d2 12 days ago 88.8GB\n```\n\n3. Run the docker container interactively to test nemo inside:\n```bash\ndocker run -it --gpus all <docker_image_id> /bin/bash\n```\n\n\nI am running on WSL Ubuntu-22.04 and CUDA 12.4.\n\n\n"
] | 2024-12-15T12:09:34 | 2025-01-02T20:17:37 | null | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Hello! I performed the following list of commands to install NeMo:
```
python -m venv .venv
.venv/bin/python --version
>> Python 3.12.3
.venv/bin/python -m pip install torch torchvision torchaudio Cython packaging
.venv/bin/python -m pip install nemo_toolkit['all']
```
The last command output:
```
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [20 lines of output]
Traceback (most recent call last):
File "/home/oleg/yodas_conversion/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
main()
File "/home/oleg/yodas_conversion/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/oleg/yodas_conversion/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-3uiwo19z/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 334, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-3uiwo19z/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 304, in _get_build_requires
self.run_setup()
File "/tmp/pip-build-env-3uiwo19z/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 522, in run_setup
super().run_setup(setup_script=setup_script)
File "/tmp/pip-build-env-3uiwo19z/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 320, in run_setup
exec(code, locals())
File "<string>", line 19, in <module>
ModuleNotFoundError: No module named 'torch'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
```
For me the error is confusing since torch is installed. Any ideas of how to fix of debug this problem?
**Environment overview (please complete the following information)**
Ubuntu 24.04, CUDA 12.4 | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11601/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11601/timeline | null | null | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.