url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
β | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
β | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/11190 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11190/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11190/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11190/events | https://github.com/NVIDIA/NeMo/pull/11190 | 2,638,892,576 | PR_kwDOC_bI7s6BGBZw | 11,190 | Delete file for demo purposes [NOT FOR MERGING] | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-11-06T18:30:02 | 2024-11-06T18:31:32 | 2024-11-06T18:31:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11190",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11190",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11190.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11190.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11190/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11190/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11189 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11189/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11189/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11189/events | https://github.com/NVIDIA/NeMo/pull/11189 | 2,638,876,104 | PR_kwDOC_bI7s6BF9vQ | 11,189 | fix: regular torch optims (e.g., sgd) no longer error with closure spec | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.core.optim.optimizer_with_main_params\nnemo/core/optim/optimizer_with_main_params.py:91:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/optim/optimizer_with_main_params.py:96:0: C0301: Line too long (149/119) (line-too-long)\nnemo/core/optim/optimizer_with_main_params.py:195:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/optim/optimizer_with_main_params.py:200:0: C0301: Line too long (149/119) (line-too-long)\nnemo/core/optim/optimizer_with_main_params.py:149:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:403:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:446:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:450:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:471:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:477:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:497:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:513:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:517:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/optim/optimizer_with_main_params.py:520:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.50/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @terrykong π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12190011070) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-06T18:21:31 | 2024-12-06T06:56:34 | 2024-12-06T06:56:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11189",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11189",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11189.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11189.patch",
"merged_at": "2024-12-06T06:56:34"
} | # What does this PR do ?
Mcore distributed optimizers now require us to specify the `closure` kwarg. Example:
https://github.com/NVIDIA/NeMo-Aligner/blob/ac97fe334eff9ad3177edf274c011e74d14a4d60/nemo_aligner/algorithms/dpo.py#L202
This means that if the application also specifies `None` for `closure`, we'll error b/c closure is passed twice. This change pops off closure and ensures it is `None` to be compliant.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11189/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11189/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11188 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11188/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11188/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11188/events | https://github.com/NVIDIA/NeMo/pull/11188 | 2,638,850,809 | PR_kwDOC_bI7s6BF4JM | 11,188 | Run formatting only if files changed. Echo message if pylint fails. | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hey @artbataev , could you point me to an example that motivated this PR?",
"> Hey @artbataev , could you point me to an example that motivated this PR?\r\n\r\n@ko3n1g, I added the following changes:\r\n- run actions only if there are changed files. This is an extremely rare case, but we should handle this (if someone deleted `*.py` file - the action will fail). I can demonstrate this easily. Demo: https://github.com/NVIDIA/NeMo/actions/runs/11709698596/job/32614299397?pr=11190 in https://github.com/NVIDIA/NeMo/pull/11190\r\n- I added an explicit message to the developer about what to do if `pylint` fails. I already got a personal message about it in Slack. \r\n- `git diff` can fail if the PR target is different from the main, e.g., the release branch. But this will only be the case after some release branch is cut from the current main. Using `${{ steps.changed-files.outputs.all_changed_files }}` is safe and maintainable (and contains only changed *.py files)."
] | 2024-11-06T18:07:07 | 2024-11-07T13:38:03 | 2024-11-07T05:49:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11188",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11188",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11188.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11188.patch",
"merged_at": "2024-11-07T05:49:05"
} |
# What does this PR do ?
- fixes the issue when code actions are executed when files are deleted
- explicitly explain to developer how to fix pylint errors
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11188/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11188/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11187 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11187/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11187/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11187/events | https://github.com/NVIDIA/NeMo/pull/11187 | 2,638,848,143 | PR_kwDOC_bI7s6BF3jK | 11,187 | Fix finetuning datamodule resume | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module hf\nexamples/llm/sft/hf.py:70:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/sft/hf.py:24:0: C0115: Missing class docstring (missing-class-docstring)\nexamples/llm/sft/hf.py:37:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.77/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11749573280) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-06T18:05:34 | 2024-11-12T16:51:45 | 2024-11-12T16:51:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11187",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11187",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11187.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11187.patch",
"merged_at": "2024-11-12T16:51:44"
} | # What does this PR do ?
Save and load `consumed_samples` for proper resume of finetuning data module
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11187/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11187/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11186 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11186/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11186/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11186/events | https://github.com/NVIDIA/NeMo/pull/11186 | 2,638,619,698 | PR_kwDOC_bI7s6BFNwn | 11,186 | port tutorial changes from main to r2.0.0 | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-06T16:30:30 | 2024-11-06T16:45:27 | 2024-11-06T16:45:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11186",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11186",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11186.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11186.patch",
"merged_at": "2024-11-06T16:45:25"
} | # What does this PR do ?
Ports #11184 to r2.0.0 branch
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11186/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11186/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11185 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11185/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11185/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11185/events | https://github.com/NVIDIA/NeMo/pull/11185 | 2,638,598,620 | PR_kwDOC_bI7s6BFJgb | 11,185 | Add Alpaca Finetune Datamodule | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @suiyoubi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11707983178) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-06T16:23:01 | 2024-11-06T18:13:59 | 2024-11-06T18:13:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11185",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11185",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11185.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11185.patch",
"merged_at": "2024-11-06T18:13:58"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11185/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11185/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11184 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11184/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11184/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11184/events | https://github.com/NVIDIA/NeMo/pull/11184 | 2,638,136,376 | PR_kwDOC_bI7s6BDtrr | 11,184 | Fixes for Canary adapters tutorial | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"I don't know why the diff is so big - I did the following:\r\n* removed the `inference` argument in prompt format fn / data module \r\n* updated the custom dataset class to return a dataclass as minibatch, same as the default prompted dataset \r\n* re-ran the whole notebook.",
"[π€]: Hi @pzelasko π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11704844726) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-06T13:43:00 | 2024-11-06T16:13:52 | 2024-11-06T14:35:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11184",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11184",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11184.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11184.patch",
"merged_at": "2024-11-06T14:35:37"
} | # What does this PR do ?
Update prompt format fn usage in Multi-task ASR adapter tutorial
**Collection**: ASR
# Changelog
- Update prompt format fn usage in Multi-task ASR adapter tutorial
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11184/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11184/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11183 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11183/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11183/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11183/events | https://github.com/NVIDIA/NeMo/pull/11183 | 2,638,074,986 | PR_kwDOC_bI7s6BDg9x | 11,183 | ci: Build, test, publish a wheel | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-06T13:16:42 | 2024-11-07T22:35:54 | 2024-11-07T22:35:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11183",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11183",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11183.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11183.patch",
"merged_at": "2024-11-07T22:35:52"
} | # What does this PR do ?
* Builds the wheel
* Tests that itβs installable in a NGC container
* Pushes it to PyPi test
*
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11183/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11183/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11182 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11182/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11182/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11182/events | https://github.com/NVIDIA/NeMo/issues/11182 | 2,637,920,203 | I_kwDOC_bI7s6dO3fL | 11,182 | Would it be possible to use pyctcdecode with ASR cache-aware streaming? | {
"login": "gabitza-tech",
"id": 53811655,
"node_id": "MDQ6VXNlcjUzODExNjU1",
"avatar_url": "https://avatars.githubusercontent.com/u/53811655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gabitza-tech",
"html_url": "https://github.com/gabitza-tech",
"followers_url": "https://api.github.com/users/gabitza-tech/followers",
"following_url": "https://api.github.com/users/gabitza-tech/following{/other_user}",
"gists_url": "https://api.github.com/users/gabitza-tech/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gabitza-tech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gabitza-tech/subscriptions",
"organizations_url": "https://api.github.com/users/gabitza-tech/orgs",
"repos_url": "https://api.github.com/users/gabitza-tech/repos",
"events_url": "https://api.github.com/users/gabitza-tech/events{/privacy}",
"received_events_url": "https://api.github.com/users/gabitza-tech/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-06T12:10:36 | 2024-12-15T02:09:09 | 2024-12-15T02:09:09 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello,
I am interested if it would be possible to use the pyctcdecoder with hybrid CTC cache-aware streaming, and what would be the difficulties to implement it? I have seen that pyctcdecode support streaming with a stateful LM, but I am not sure how this would be affected in the case of cache-aware streaming.
Could you help me with some insights and direct me towards some resources in order to implement a feature like this?
Any insights are greatly appreciated!
Best regards,
Gabi | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11182/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11182/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11181 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11181/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11181/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11181/events | https://github.com/NVIDIA/NeMo/pull/11181 | 2,637,727,539 | PR_kwDOC_bI7s6BCcqi | 11,181 | Version bump to `2.1.0rc1` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-11-06T10:47:38 | 2024-11-06T10:57:12 | 2024-11-06T10:57:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11181",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11181",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11181.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11181.patch",
"merged_at": null
} | π Version bump NeMo-Toolkit to `2.1.0rc1` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11181/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11181/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11180 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11180/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11180/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11180/events | https://github.com/NVIDIA/NeMo/pull/11180 | 2,637,710,012 | PR_kwDOC_bI7s6BCZZO | 11,180 | ci: Add release workflow | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-06T10:42:23 | 2024-11-08T21:27:01 | 2024-11-08T21:26:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11180",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11180",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11180.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11180.patch",
"merged_at": "2024-11-08T21:26:59"
} | # What does this PR do ?
Bump PR: https://github.com/NVIDIA/NeMo/pull/11181
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11180/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11180/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11179 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11179/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11179/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11179/events | https://github.com/NVIDIA/NeMo/pull/11179 | 2,637,460,502 | PR_kwDOC_bI7s6BBoAd | 11,179 | Updated Diffusion Collection README | {
"login": "zpx01",
"id": 51731412,
"node_id": "MDQ6VXNlcjUxNzMxNDEy",
"avatar_url": "https://avatars.githubusercontent.com/u/51731412?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zpx01",
"html_url": "https://github.com/zpx01",
"followers_url": "https://api.github.com/users/zpx01/followers",
"following_url": "https://api.github.com/users/zpx01/following{/other_user}",
"gists_url": "https://api.github.com/users/zpx01/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zpx01/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zpx01/subscriptions",
"organizations_url": "https://api.github.com/users/zpx01/orgs",
"repos_url": "https://api.github.com/users/zpx01/repos",
"events_url": "https://api.github.com/users/zpx01/events{/privacy}",
"received_events_url": "https://api.github.com/users/zpx01/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-06T09:07:27 | 2024-11-07T00:03:24 | 2024-11-07T00:03:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11179",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11179",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11179.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11179.patch",
"merged_at": "2024-11-07T00:03:24"
} | # What does this PR do ?
Updates diffusion collection README with new features.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ethanhe42",
"id": 10027339,
"node_id": "MDQ6VXNlcjEwMDI3MzM5",
"avatar_url": "https://avatars.githubusercontent.com/u/10027339?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ethanhe42",
"html_url": "https://github.com/ethanhe42",
"followers_url": "https://api.github.com/users/ethanhe42/followers",
"following_url": "https://api.github.com/users/ethanhe42/following{/other_user}",
"gists_url": "https://api.github.com/users/ethanhe42/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ethanhe42/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ethanhe42/subscriptions",
"organizations_url": "https://api.github.com/users/ethanhe42/orgs",
"repos_url": "https://api.github.com/users/ethanhe42/repos",
"events_url": "https://api.github.com/users/ethanhe42/events{/privacy}",
"received_events_url": "https://api.github.com/users/ethanhe42/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11179/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11179/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11178 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11178/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11178/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11178/events | https://github.com/NVIDIA/NeMo/issues/11178 | 2,637,450,420 | I_kwDOC_bI7s6dNEy0 | 11,178 | tutorials/tts/Inference_ModelSelect.ipynb is throwing error when installing dependancies | {
"login": "bnarasimha",
"id": 9278710,
"node_id": "MDQ6VXNlcjkyNzg3MTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9278710?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bnarasimha",
"html_url": "https://github.com/bnarasimha",
"followers_url": "https://api.github.com/users/bnarasimha/followers",
"following_url": "https://api.github.com/users/bnarasimha/following{/other_user}",
"gists_url": "https://api.github.com/users/bnarasimha/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bnarasimha/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bnarasimha/subscriptions",
"organizations_url": "https://api.github.com/users/bnarasimha/orgs",
"repos_url": "https://api.github.com/users/bnarasimha/repos",
"events_url": "https://api.github.com/users/bnarasimha/events{/privacy}",
"received_events_url": "https://api.github.com/users/bnarasimha/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-06T09:02:20 | 2024-12-16T02:07:17 | 2024-12-16T02:07:16 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
First cell is throwing error when executed in Colab or any Jupyter Notebook
**Steps/Code to reproduce bug**
Execute cell
A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.
**Expected behavior**
Install all dependancies without any errors
**Environment overview (please complete the following information)**
- Environment location: Collab, Paperspace Notebooks, tried on both
**Additional context**
[Image](https://github.com/user-attachments/assets/dfb6837f-3fc8-41f9-a4aa-8cc461cdbcd5)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11178/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11178/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11177 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11177/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11177/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11177/events | https://github.com/NVIDIA/NeMo/pull/11177 | 2,637,027,686 | PR_kwDOC_bI7s6BAVe9 | 11,177 | Add support for Cosmos Tokenizers | {
"login": "jojennin",
"id": 106725747,
"node_id": "U_kgDOBlyBcw",
"avatar_url": "https://avatars.githubusercontent.com/u/106725747?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jojennin",
"html_url": "https://github.com/jojennin",
"followers_url": "https://api.github.com/users/jojennin/followers",
"following_url": "https://api.github.com/users/jojennin/following{/other_user}",
"gists_url": "https://api.github.com/users/jojennin/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jojennin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jojennin/subscriptions",
"organizations_url": "https://api.github.com/users/jojennin/orgs",
"repos_url": "https://api.github.com/users/jojennin/repos",
"events_url": "https://api.github.com/users/jojennin/events{/privacy}",
"received_events_url": "https://api.github.com/users/jojennin/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-06T04:46:44 | 2024-11-06T22:20:34 | 2024-11-06T22:20:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11177",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11177",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11177.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11177.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: This creates a new collection under common/video_tokenizers. Specifically, this collection creates a NeMo PyTorch lightning model for the Cosmos Tokenizers.
# Changelog
- Add a PyTorch lightning model for the Cosmos Tokenizers
- Add an example for multi-modal autoregressive image generation with Cosmos Tokenizer
- Add an example for preparing a megatron-energon dataset with Cosmos Tokenizer
# Usage
* We provide README's under the following directories
* `nemo/collections/common/video_tokenizers`
* `nemo/collections/diffusion/data`
* `nemo/collections/multimodal_autoregressive/data`
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jojennin",
"id": 106725747,
"node_id": "U_kgDOBlyBcw",
"avatar_url": "https://avatars.githubusercontent.com/u/106725747?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jojennin",
"html_url": "https://github.com/jojennin",
"followers_url": "https://api.github.com/users/jojennin/followers",
"following_url": "https://api.github.com/users/jojennin/following{/other_user}",
"gists_url": "https://api.github.com/users/jojennin/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jojennin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jojennin/subscriptions",
"organizations_url": "https://api.github.com/users/jojennin/orgs",
"repos_url": "https://api.github.com/users/jojennin/repos",
"events_url": "https://api.github.com/users/jojennin/events{/privacy}",
"received_events_url": "https://api.github.com/users/jojennin/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11177/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11177/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11176 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11176/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11176/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11176/events | https://github.com/NVIDIA/NeMo/pull/11176 | 2,636,863,394 | PR_kwDOC_bI7s6A_30n | 11,176 | adding canary docs | {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"@krishnacpuvvada please address and merge",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-06T02:11:58 | 2024-12-30T02:00:14 | 2024-12-30T02:00:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11176",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11176",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11176.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11176.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [ASR]
# Changelog
- Adding docs for canary
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11176/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11176/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11175 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11175/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11175/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11175/events | https://github.com/NVIDIA/NeMo/pull/11175 | 2,636,817,697 | PR_kwDOC_bI7s6A_uGK | 11,175 | Cherry pick `Change activation parsing in TRTLLM (11173)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-06T01:22:44 | 2024-11-06T02:08:11 | 2024-11-06T02:08:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11175",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11175",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11175.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11175.patch",
"merged_at": "2024-11-06T02:08:10"
} | [π€]: Hi @meatybobby π,<br><br>we've cherry picked #11173 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11175/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11175/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11174 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11174/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11174/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11174/events | https://github.com/NVIDIA/NeMo/pull/11174 | 2,636,765,441 | PR_kwDOC_bI7s6A_i4T | 11,174 | Bump `Dockerfile.ci` (2024-11-06) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11694787418) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-06T00:22:00 | 2024-11-06T08:52:10 | 2024-11-06T08:52:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11174",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11174",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11174.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11174.patch",
"merged_at": "2024-11-06T08:52:08"
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11174/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11174/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11173 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11173/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11173/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11173/events | https://github.com/NVIDIA/NeMo/pull/11173 | 2,636,361,123 | PR_kwDOC_bI7s6A-Vfz | 11,173 | Change activation parsing in TRTLLM | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @meatybobby π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11695414136) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-05T20:05:20 | 2024-11-06T02:52:01 | 2024-11-06T01:22:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11173",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11173",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11173.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11173.patch",
"merged_at": "2024-11-06T01:22:19"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11173/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11173/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11172 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11172/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11172/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11172/events | https://github.com/NVIDIA/NeMo/pull/11172 | 2,636,249,229 | PR_kwDOC_bI7s6A-AHV | 11,172 | Add global state cleanup function | {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-05T19:06:05 | 2024-11-27T02:03:58 | 2024-11-27T02:03:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11172",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11172",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11172.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11172.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11172/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11172/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11171 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11171/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11171/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11171/events | https://github.com/NVIDIA/NeMo/pull/11171 | 2,636,124,769 | PR_kwDOC_bI7s6A9nhI | 11,171 | add nemotron5 conversion | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.models.aed_multitask_models\nnemo/collections/asr/models/aed_multitask_models.py:695:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:727:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:769:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:777:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:1049:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:1115:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.models.ctc_bpe_models\nnemo/collections/asr/models/ctc_bpe_models.py:365:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:366:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:372:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:373:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:379:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:380:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:386:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:387:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:393:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:394:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:400:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:401:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:408:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:409:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:416:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:417:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:423:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:424:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:430:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:431:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:437:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:438:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:445:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:446:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:452:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:453:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:459:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:460:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:466:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:467:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:473:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:474:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:480:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:481:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:487:0: C0301: Line too long (171/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:488:0: C0301: Line too long (181/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:494:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:495:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:501:0: C0301: Line too long (171/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:502:0: C0301: Line too long (181/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:508:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:509:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:515:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:516:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:522:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:523:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:529:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:530:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:536:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:537:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:543:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:544:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:550:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:551:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:557:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:558:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:564:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:565:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:571:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:572:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:578:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:579:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:585:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:586:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:592:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:593:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:599:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:600:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:606:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:607:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:613:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:614:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:620:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:621:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:627:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:628:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:634:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:635:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:641:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:642:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:648:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:649:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:655:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:656:0: C0301: Line too long (163/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:662:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:663:0: C0301: Line too long (165/119) (line-too-long)\n************* Module nemo.collections.asr.models.ctc_models\nnemo/collections/asr/models/ctc_models.py:196:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:197:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:813:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:819:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:820:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:826:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:827:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:833:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:834:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:840:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:841:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:847:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:848:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:854:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:855:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:861:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:862:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:868:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:869:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:875:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:876:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:882:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:883:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:889:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:890:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:897:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:898:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:904:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:905:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:545:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:602:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:620:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:662:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:916:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_bpe_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:263:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:267:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:277:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:526:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:527:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:533:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:534:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:540:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:541:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:547:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:548:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:554:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:555:0: C0301: Line too long (190/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:561:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:562:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:568:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:569:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:575:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:576:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:582:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:583:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:589:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:590:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:596:0: C0301: Line too long (175/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:597:0: C0301: Line too long (211/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:603:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:604:0: C0301: Line too long (193/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:610:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:611:0: C0301: Line too long (197/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:617:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:618:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:624:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:625:0: C0301: Line too long (201/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:631:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:632:0: C0301: Line too long (199/119) (line-too-long)\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:717:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:718:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:16:0: W0611: Unused import json (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:17:0: W0611: Unused import os (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:18:0: W0611: Unused import tempfile (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:24:0: W0611: Unused tqdm imported from tqdm.auto (unused-import)\n************* Module nemo.collections.asr.models.rnnt_bpe_models\nnemo/collections/asr/models/rnnt_bpe_models.py:53:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:54:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:60:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:61:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:67:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:68:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:74:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:75:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:81:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:82:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:88:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:89:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:95:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:96:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:102:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:103:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:109:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:110:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:116:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:117:0: C0301: Line too long (172/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:123:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:124:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:130:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:131:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:137:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:138:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:144:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:145:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:151:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:152:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:158:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:159:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:165:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:166:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:172:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:173:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:179:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:180:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:186:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:187:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:193:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:194:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:200:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:201:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:207:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:208:0: C0301: Line too long (184/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:214:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:215:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:221:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:222:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:228:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:229:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:235:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:236:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:242:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:243:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:249:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:250:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:256:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:257:0: C0301: Line too long (174/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:263:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:264:0: C0301: Line too long (180/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:270:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:271:0: C0301: Line too long (177/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:277:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:278:0: C0301: Line too long (179/119) (line-too-long)\n************* Module nemo.collections.asr.models.rnnt_models\nnemo/collections/asr/models/rnnt_models.py:1084:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/rnnt_models.py:1085:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_models.py:230:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:705:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:803:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:820:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:888:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:896:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:1061:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:1092:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.modules.conv_asr\nnemo/collections/asr/modules/conv_asr.py:197:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:239:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:399:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:459:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:503:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:507:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:603:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:677:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:689:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:758:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:858:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:881:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:900:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:945:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:969:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:983:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:992:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.mixins.transcription\nnemo/collections/asr/parts/mixins/transcription.py:40:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/mixins/transcription.py:57:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/mixins/transcription.py:95:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/mixins/transcription.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.parts.submodules.rnnt_decoding\nnemo/collections/asr/parts/submodules/rnnt_decoding.py:1117:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_decoding.py:730:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/rnnt_decoding.py:756:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/rnnt_decoding.py:1770:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/rnnt_decoding.py:1827:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.utils.streaming_utils\nnemo/collections/asr/parts/utils/streaming_utils.py:426:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:429:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:473:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:546:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:569:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:632:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:644:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:658:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:685:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:777:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:783:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:787:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:824:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:842:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1515:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1521:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1525:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1537:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1542:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1549:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1584:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1587:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1597:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1608:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1612:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1683:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1731:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.utils.transcribe_utils\nnemo/collections/asr/parts/utils/transcribe_utils.py:177:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:339:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:636:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:651:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:659:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:662:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:670:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:64:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:220:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:351:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/api.py:252:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:312:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:324:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:486:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_mamba_model\nnemo/collections/nlp/models/language_modeling/megatron_mamba_model.py:43:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_mamba_model.py:24:4: W0611: Unused import mamba_ssm (unused-import)\n************* Module scripts.checkpoint_converters.convert_mamba2_pyt_to_nemo\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:49:0: C0301: Line too long (133/119) (line-too-long)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:62:0: C0301: Line too long (218/119) (line-too-long)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:55:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:102:4: C0115: Missing class docstring (missing-class-docstring)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:110:8: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:137:8: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:150:8: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:158:8: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:178:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py:286:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.44/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-05T17:57:11 | 2024-12-04T02:05:25 | 2024-12-04T02:05:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11171",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11171",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11171.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11171.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11171/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11171/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11170 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11170/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11170/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11170/events | https://github.com/NVIDIA/NeMo/pull/11170 | 2,636,117,427 | PR_kwDOC_bI7s6A9mNT | 11,170 | Add PP support in NeVA along with few bug fixes | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop π€: π¨ The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.neva.data.llava_next_energon\nnemo/collections/vlm/neva/data/llava_next_energon.py:28:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/llava_next_energon.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/llava_next_energon.py:37:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/llava_next_energon.py:104:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.llm.fn.activation\nnemo/collections/llm/fn/activation.py:25:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/fn/activation.py:30:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.base\nnemo/collections/llm/gpt/model/base.py:226:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/llm/gpt/model/base.py:51:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:94:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:131:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:149:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:159:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:182:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:252:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:264:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:276:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:288:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:300:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:312:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:326:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/base.py:344:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:348:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:371:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:374:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:377:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:381:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:386:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:407:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:414:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:421:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:449:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/base.py:43:4: W0611: Unused import fused_weight_gradient_mlp_cuda (unused-import)\n************* Module nemo.collections.llm.gpt.model.llama\nnemo/collections/llm/gpt/model/llama.py:483:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:42:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:80:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:89:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:111:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:132:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:142:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:154:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:164:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:175:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:186:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:192:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:198:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:209:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:213:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:225:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:265:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:302:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:321:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:338:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:475:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.ssm\nnemo/collections/llm/gpt/model/ssm.py:190:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/llm/gpt/model/ssm.py:193:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/llm/gpt/model/ssm.py:194:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/llm/gpt/model/ssm.py:195:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/llm/gpt/model/ssm.py:39:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:51:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:89:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:110:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:127:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:131:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:134:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:155:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:203:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:216:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/ssm.py:221:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:235:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:249:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:263:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:277:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:291:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/ssm.py:305:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.vlm.mllama.data.mock\nnemo/collections/vlm/mllama/data/mock.py:27:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/mock.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:84:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:89:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.base\nnemo/collections/vlm/mllama/model/base.py:50:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:99:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:116:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:121:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:152:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:155:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:162:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:227:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:276:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:315:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:319:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:364:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:398:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:491:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:508:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:541:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:544:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:547:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:551:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:557:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:564:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.data.conversation\nnemo/collections/vlm/neva/data/conversation.py:93:0: C0301: Line too long (255/119) (line-too-long)\nnemo/collections/vlm/neva/data/conversation.py:135:0: C0301: Line too long (198/119) (line-too-long)\nnemo/collections/vlm/neva/data/conversation.py:358:0: C0301: Line too long (176/119) (line-too-long)\nnemo/collections/vlm/neva/data/conversation.py:426:0: C0301: Line too long (314/119) (line-too-long)\nnemo/collections/vlm/neva/data/conversation.py:428:0: C0301: Line too long (210/119) (line-too-long)\nnemo/collections/vlm/neva/data/conversation.py:571:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/neva/data/conversation.py:595:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/neva/data/conversation.py:620:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/neva/data/conversation.py:63:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:78:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:237:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:240:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:286:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:300:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:324:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:336:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/conversation.py:18:0: W0611: Unused defaultdict imported from collections (unused-import)\n************* Module nemo.collections.vlm.neva.data.lazy\nnemo/collections/vlm/neva/data/lazy.py:564:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/data/lazy.py:67:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:115:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:134:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:161:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:236:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:246:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/lazy.py:418:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:493:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/lazy.py:557:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:568:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:571:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/lazy.py:574:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.data.mock\nnemo/collections/vlm/neva/data/mock.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/mock.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:83:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:88:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/mock.py:93:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.model.api\nnemo/collections/vlm/neva/model/api.py:20:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/api.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.model.base\nnemo/collections/vlm/neva/model/base.py:470:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:473:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:481:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:490:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/neva/model/base.py:93:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:151:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:172:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:227:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:242:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:261:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:282:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:313:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:351:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:364:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:619:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/base.py:636:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:640:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:664:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:667:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:670:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:674:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:687:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/base.py:27:0: W0611: Unused TEDotProductAttention imported from megatron.core.extensions.transformer_engine (unused-import)\n************* Module nemo.collections.vlm.neva.model.llava\nnemo/collections/vlm/neva/model/llava.py:108:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:109:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:110:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:111:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:146:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:147:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:148:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:149:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:150:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:151:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:152:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:153:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:154:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:155:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:156:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/neva/model/llava.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:46:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:59:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:83:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/model/llava.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/llava.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/llava.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/model/llava.py:223:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.io.state\nnemo/lightning/io/state.py:31:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/state.py:334:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.17/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @yaoyu-33 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11943673585) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-05T17:53:49 | 2024-11-21T17:58:34 | 2024-11-21T17:58:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11170",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11170",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11170.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11170.patch",
"merged_at": "2024-11-21T17:58:32"
} | # What does this PR do ?
Add support for enabling PP in neva training. 2 Options are supplied: (1) vit share 1st pp stage with llm, encoder_pp=0. (2) vit takes entire 1st pp stage with llm, encoder_pp=1.
**Collection**: [multimodal]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11170/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11170/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11169 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11169/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11169/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11169/events | https://github.com/NVIDIA/NeMo/pull/11169 | 2,636,042,971 | PR_kwDOC_bI7s6A9YNh | 11,169 | 2x more memory efficient Graph-based RNN-T | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @artbataev π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12320247404) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop π€: π¨ The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop π€: π¨ The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @artbataev π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12328248321) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-05T17:18:33 | 2024-12-17T08:57:41 | 2024-12-17T08:57:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11169",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11169",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11169.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11169.patch",
"merged_at": "2024-12-17T08:57:38"
} | # What does this PR do ?
- reduces memory usage of Graph-Transducer by 2 times: Triton-based implementation of log-softmax operation for RNN-T
- idea: store log probabilities only for blank/target labels (needed to compute RNN-T loss), not for all logits
- if we calculate full logits (Joint tensor), this is the optimal implementation: most of the memory is used by `logits/+gradients` (2x logits)
- previous implementation required `logits/+gradients`, `log_probs/+gradients` (4x logits)
- adds an option to return RNN-T graphs from `forward` along with the loss value for further usage (e.g., using alignment)
**Example**: bfloat16, 15 sec, 8x subsampling (~FastConformer), 3 words/sec, vocab size 1024, batch size 32
| | Logits | Extra Memory | Time |
| ----------------------- | ------- | ------------ | -------- |
| Without Triton (before) | 1.04 GB | 3.20 GB | 0.08 sec |
| **With Triton (here)** | 1.04 GB | **1.13 GB** | **0.06 sec** |
3x extra memory reduction, 2x total memory reduction (4.24 GB -> 2.17 GB).
Convergence: stable, see https://wandb.ai/nvidia/Graph_RNNT_Optimized
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [x] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11169/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11169/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11168 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11168/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11168/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11168/events | https://github.com/NVIDIA/NeMo/pull/11168 | 2,635,974,904 | PR_kwDOC_bI7s6A9KIB | 11,168 | Update copyright check | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-05T16:47:42 | 2024-11-05T16:47:59 | 2024-11-05T16:47:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11168",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11168",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11168.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11168.patch",
"merged_at": "2024-11-05T16:47:56"
} | Make/move copyright check template | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11168/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11168/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11167 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11167/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11167/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11167/events | https://github.com/NVIDIA/NeMo/pull/11167 | 2,635,897,459 | PR_kwDOC_bI7s6A86hD | 11,167 | Cherry pick `Added deprecation notice (11133)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-05T16:13:51 | 2024-11-05T16:22:51 | 2024-11-05T16:22:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11167",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11167",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11167.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11167.patch",
"merged_at": "2024-11-05T16:22:48"
} | [π€]: Hi @Ssofja π,<br><br>we've cherry picked #11133 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "Ssofja",
"id": 78349198,
"node_id": "MDQ6VXNlcjc4MzQ5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/78349198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ssofja",
"html_url": "https://github.com/Ssofja",
"followers_url": "https://api.github.com/users/Ssofja/followers",
"following_url": "https://api.github.com/users/Ssofja/following{/other_user}",
"gists_url": "https://api.github.com/users/Ssofja/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ssofja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ssofja/subscriptions",
"organizations_url": "https://api.github.com/users/Ssofja/orgs",
"repos_url": "https://api.github.com/users/Ssofja/repos",
"events_url": "https://api.github.com/users/Ssofja/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ssofja/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11167/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11167/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11166 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11166/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11166/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11166/events | https://github.com/NVIDIA/NeMo/pull/11166 | 2,635,855,593 | PR_kwDOC_bI7s6A8xpN | 11,166 | Integrate TE for HF models | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Closing since the code was moved to this PR: https://github.com/NVIDIA/NeMo/pull/11261"
] | 2024-11-05T15:55:22 | 2024-11-12T17:59:37 | 2024-11-12T17:59:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11166",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11166",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11166.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11166.patch",
"merged_at": null
} | # What does this PR do ?
Accelerates HF models with TE.
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11166/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11166/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11165 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11165/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11165/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11165/events | https://github.com/NVIDIA/NeMo/pull/11165 | 2,635,681,295 | PR_kwDOC_bI7s6A8OV- | 11,165 | Inframework deployment for nemo 2 ckpt | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Closing since it'll be included in this PR: https://github.com/NVIDIA/NeMo/pull/11233"
] | 2024-11-05T14:49:49 | 2024-11-08T17:30:03 | 2024-11-08T17:30:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11165",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11165",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11165.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11165.patch",
"merged_at": null
} | # What does this PR do ?
Adds in framework deployment support for nemo 2 ckpt.
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11165/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11165/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11164 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11164/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11164/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11164/events | https://github.com/NVIDIA/NeMo/pull/11164 | 2,635,546,236 | PR_kwDOC_bI7s6A7y6T | 11,164 | Update Multi_Task_Adapters.ipynb (#10600) | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-05T13:58:27 | 2024-11-05T13:59:39 | 2024-11-05T13:59:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11164",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11164",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11164.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11164.patch",
"merged_at": "2024-11-05T13:59:37"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11164/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11164/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11163 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11163/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11163/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11163/events | https://github.com/NVIDIA/NeMo/issues/11163 | 2,635,333,001 | I_kwDOC_bI7s6dE_2J | 11,163 | How to finetune the NEST model with CTC Loss for ASR task? | {
"login": "zw76859420",
"id": 42910032,
"node_id": "MDQ6VXNlcjQyOTEwMDMy",
"avatar_url": "https://avatars.githubusercontent.com/u/42910032?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zw76859420",
"html_url": "https://github.com/zw76859420",
"followers_url": "https://api.github.com/users/zw76859420/followers",
"following_url": "https://api.github.com/users/zw76859420/following{/other_user}",
"gists_url": "https://api.github.com/users/zw76859420/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zw76859420/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zw76859420/subscriptions",
"organizations_url": "https://api.github.com/users/zw76859420/orgs",
"repos_url": "https://api.github.com/users/zw76859420/repos",
"events_url": "https://api.github.com/users/zw76859420/events{/privacy}",
"received_events_url": "https://api.github.com/users/zw76859420/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"Have you checked paragraph \"Fine-tuning with pre-trained encoder\" of https://github.com/NVIDIA/NeMo/blob/stable/tutorials/asr/Self_Supervised_Pre_Training.ipynb ? ",
"Thanks for your kind reply, and i will review the above link.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-05T12:33:39 | 2025-01-03T01:58:42 | 2025-01-03T01:58:41 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | We have trained SSL model based on the NEST, how to finetune the previous model based on the CTC Loss function?
The pretraining scripts are as follows: [NEST](https://github.com/NVIDIA/NeMo/blob/main/examples/asr/speech_pretraining/masked_token_pred_pretrain.py) | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11163/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11163/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11162 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11162/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11162/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11162/events | https://github.com/NVIDIA/NeMo/pull/11162 | 2,635,323,228 | PR_kwDOC_bI7s6A7E7T | 11,162 | Update for compatibility with MCore Hyena config changes | {
"login": "guyjacob",
"id": 28220349,
"node_id": "MDQ6VXNlcjI4MjIwMzQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/28220349?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guyjacob",
"html_url": "https://github.com/guyjacob",
"followers_url": "https://api.github.com/users/guyjacob/followers",
"following_url": "https://api.github.com/users/guyjacob/following{/other_user}",
"gists_url": "https://api.github.com/users/guyjacob/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guyjacob/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guyjacob/subscriptions",
"organizations_url": "https://api.github.com/users/guyjacob/orgs",
"repos_url": "https://api.github.com/users/guyjacob/repos",
"events_url": "https://api.github.com/users/guyjacob/events{/privacy}",
"received_events_url": "https://api.github.com/users/guyjacob/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-11-05T12:28:58 | 2024-11-05T15:20:52 | 2024-11-05T15:20:51 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11162",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11162",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11162.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11162.patch",
"merged_at": "2024-11-05T15:20:51"
} | # What does this PR do ?
Update for compatibility with MCore Hyena config changes.
See: https://gitlab-master.nvidia.com/ataghibakhsh/megatron-lm/-/merge_requests/2
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11162/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11162/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11161 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11161/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11161/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11161/events | https://github.com/NVIDIA/NeMo/issues/11161 | 2,635,300,116 | I_kwDOC_bI7s6dE30U | 11,161 | How to export fastconformer based asr model to support torchscript model? | {
"login": "zw76859420",
"id": 42910032,
"node_id": "MDQ6VXNlcjQyOTEwMDMy",
"avatar_url": "https://avatars.githubusercontent.com/u/42910032?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zw76859420",
"html_url": "https://github.com/zw76859420",
"followers_url": "https://api.github.com/users/zw76859420/followers",
"following_url": "https://api.github.com/users/zw76859420/following{/other_user}",
"gists_url": "https://api.github.com/users/zw76859420/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zw76859420/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zw76859420/subscriptions",
"organizations_url": "https://api.github.com/users/zw76859420/orgs",
"repos_url": "https://api.github.com/users/zw76859420/repos",
"events_url": "https://api.github.com/users/zw76859420/events{/privacy}",
"received_events_url": "https://api.github.com/users/zw76859420/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "vsl9",
"id": 4344862,
"node_id": "MDQ6VXNlcjQzNDQ4NjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4344862?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vsl9",
"html_url": "https://github.com/vsl9",
"followers_url": "https://api.github.com/users/vsl9/followers",
"following_url": "https://api.github.com/users/vsl9/following{/other_user}",
"gists_url": "https://api.github.com/users/vsl9/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vsl9/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vsl9/subscriptions",
"organizations_url": "https://api.github.com/users/vsl9/orgs",
"repos_url": "https://api.github.com/users/vsl9/repos",
"events_url": "https://api.github.com/users/vsl9/events{/privacy}",
"received_events_url": "https://api.github.com/users/vsl9/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-05T12:17:31 | 2024-12-13T02:06:05 | 2024-12-13T02:06:04 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | We looked up the code in nemo (in example/asr/ folder), and we can't find any codes to export the asr model (based on fastconformer) to support thr pytorch torchscript format.
Please give us some suggestions to solve the above problems. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11161/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11161/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11160 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11160/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11160/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11160/events | https://github.com/NVIDIA/NeMo/pull/11160 | 2,634,861,389 | PR_kwDOC_bI7s6A5oG9 | 11,160 | ci: Move copyright check | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-05T09:09:41 | 2024-11-05T16:48:50 | 2024-11-05T16:48:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11160",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11160",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11160.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11160.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11160/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11160/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11159 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11159/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11159/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11159/events | https://github.com/NVIDIA/NeMo/pull/11159 | 2,634,808,333 | PR_kwDOC_bI7s6A5dp8 | 11,159 | Bump `Dockerfile.ci` (2024-11-05) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11680545192) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-05T08:46:34 | 2024-11-05T12:33:55 | 2024-11-05T12:33:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11159",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11159",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11159.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11159.patch",
"merged_at": "2024-11-05T12:33:53"
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11159/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11159/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11158 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11158/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11158/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11158/events | https://github.com/NVIDIA/NeMo/pull/11158 | 2,634,775,496 | PR_kwDOC_bI7s6A5X87 | 11,158 | Nemo2 batcheval | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:75:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:231:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:362:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/api.py:263:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:323:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:335:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:497:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.72/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @HuiyingLi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11903049320) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-05T08:33:31 | 2024-11-19T18:11:47 | 2024-11-19T18:11:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11158",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11158",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11158.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11158.patch",
"merged_at": "2024-11-19T18:11:44"
} | # What does this PR do ?
Adding evaluation of test set and write to file functions to llm.generate
```
data = llm.SquadDataModule(seq_length=2048, micro_batch_size=2, global_batch_size=8, num_workers=0)
data.prepare_data()
res = llm.generate(
path=output_path,
trainer=trainer,
input_dataset=data,
inference_params=CommonInferenceParams(num_tokens_to_generate=20, top_k=1),
max_batch_size=4,
output_path="test_prediction.txt",
)
```
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11158/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11158/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11157 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11157/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11157/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11157/events | https://github.com/NVIDIA/NeMo/pull/11157 | 2,634,602,451 | PR_kwDOC_bI7s6A41iD | 11,157 | NeMo-UX: Add sgd optim | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11681138470) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-05T07:01:57 | 2024-11-05T13:41:59 | 2024-11-05T13:41:58 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11157",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11157",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11157.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11157.patch",
"merged_at": "2024-11-05T13:41:58"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11157/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11157/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11156 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11156/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11156/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11156/events | https://github.com/NVIDIA/NeMo/pull/11156 | 2,634,225,068 | PR_kwDOC_bI7s6A3urX | 11,156 | Workload Inspector (WiT) performance anomaly detection Tool across GPUs | {
"login": "rkandu",
"id": 180480889,
"node_id": "U_kgDOCsHreQ",
"avatar_url": "https://avatars.githubusercontent.com/u/180480889?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rkandu",
"html_url": "https://github.com/rkandu",
"followers_url": "https://api.github.com/users/rkandu/followers",
"following_url": "https://api.github.com/users/rkandu/following{/other_user}",
"gists_url": "https://api.github.com/users/rkandu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rkandu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rkandu/subscriptions",
"organizations_url": "https://api.github.com/users/rkandu/orgs",
"repos_url": "https://api.github.com/users/rkandu/repos",
"events_url": "https://api.github.com/users/rkandu/events{/privacy}",
"received_events_url": "https://api.github.com/users/rkandu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-05T01:49:20 | 2024-11-27T02:04:01 | 2024-11-27T02:04:00 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11156",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11156",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11156.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11156.patch",
"merged_at": null
} | # What does this PR do ?
Workload analysis tool for anomaly detection and perf analysis. Tool uses Nsys trace captures.
PR takes Nsys profiling changes as a reference.
Provides diagnostic information at per GPU level by analysis of Nsys traces.
- Compute vs. exposed communication.
- Communication overlap at each collective and stream level.
- Slow kernels causing training bottlenecks.
```
Kernel time per iteration: 401.182 (ms)
Kernel instances per iteration: 1006
Kernel Statistic:
Class TimePerIter(ms) InstancePerIter TimePerIter(%) TotalTime(ms) TotalInstance TotalTime(%)
others 25.68 5513 2.90 256.79 55254 2.90
bf16_gemm 231.65 21236 53.99 2316.48 212400 53.99
layernorm 4.81 2808 0.80 48.12 28080 0.80
reduce 2.95 1112 0.62 29.53 11148 0.62
userbuffer 39.42 31332 23.96 394.18 313344 23.96
elementwise_kernel 88.76 29088 6.66 887.55 291128 6.66
attention 7.83 1841 10.92 78.32 18432 10.92
NCCL time per iteration: 285.951 (ms)
NCCL overlapped comm time per iteration: 175.113 (ms)
NCCL Overlap Statistics:
Class TimePerIter(ms) OverlapPerIter(ms) Overlap(ms) OverlapPerIter(%)
AllGather 109.85 71.50 714.98 65.09
ReduceScatter 134.08 103.61 1036.15 77.28
Per NCCL stream Overlap Statistics:
Class Stream ID Grid Size TimePerIter(ms) OverlapPerIter(ms) Overlap(ms) OverlapPerIter(%) TotalTime(%)
ReduceScatter 16 6 20.37 0.00 0.00 0.00 3.53
ReduceScatter 16 3 10.48 0.00 0.00 0.00 0.02
AllGather 10 4 81.74 32.62 50.48 8.24 19.74
AllGather 46 2 35.45 26.84 67.37 14.97 25.95
AllGather 22 1 0.05 0.00 0.00 0.00 0.00
GPU bubbles per iteration: 0.04%
Multiple NCCL streams overlap per iteration: 0.00%
```
# Changelog
- Added a Workload Inspector Lightening callback [nemo/lightning/pytorch/callbacks/workload_inspector.py](https://github.com/NVIDIA/NeMo/commit/df4887aead1210b94c2edb254e4c05c996f6749e#diff-dd4d5723656416f43d36613d894dcb66a1547cd6de072137d39f118b038838b2)
- WorkloadInspectorPlugin added to enable the tool [nemo/lightning/run/plugins.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-2b4c9a34429f8078889e60cccd2e2b6759100659c2afaa4ebbb493eb97704615)
- Added WiT callback to [nemo/lightning/pytorch/callbacks/__init__.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-c9e02dfa089e3aacf2f24c451f7af596b1573f22d0e4f218511aca881f6dd5e4)
- WiT enabling changes in Interface for Pytorch-lightning based NeMo models [βnemo/core/classes/modelPT.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-4b936f7283de92c1563db15e6e966eea3994139ff3ff18823b498592e060a75c)
- Invoke WiT plugin in [tests/lightning/test_nemo_run.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-65cf660991d9d1586bea1caa565d4f8abdf348a4e59432e66d064d79858b38b9)
- WiT enabling steps in various Megatron based models:
[βnemo/collections/multimodal/models/vision_language_foundation/clip/megatron_clip_models.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-db5f2e6c1e3156d33d2e5afa097b7d425e20c07e021f79e43d9916b993027c48)
[βnemo/collections/nlp/models/language_modeling/megatron_bert_model.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-d496e911eb06fca3128061957d326a83ba0a603ca8482ad292aee3851f49bf61)
[nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py]
(https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-d84a79499285d34da7d19099472502cb4e7c1b1672832488268066c9c7df852d)
[nemo/collections/vision/models/megatron_vit_classification_models.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-791dbc321fe2f4f37e07d17dd694d7a31b2b849510841958226c6d045b529035)
- Test cases for WiT
[βtests/lightning/pytorch/callbacks/test_workload_inspector.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-4b1ecd4d173033a01acb4e7389e7a6f043bb95916f063720ce9dc9ec3fe34319)
[βtests/collections/nlp/test_falcon_model.py](https://github.com/NVIDIA/NeMo/commit/76586ffd541c605facf7d146dcd58bad42fbf87a#diff-ca09720d0bccee0bd8699c8342d3ba78b427c2b70f8a9387dbf5e8b21d435901)
# Usage
Workload Inspector (WiT) uses NVIDIA Nsight profiling and CUDA Profiler Start/Stop APIs to detect anomalies in training applications.
```
# Workload Inspector profiling options in yaml file
wit_profile:
enabled: False
start_step: 10 # Global batch to start profiling
end_step: 10 # Global batch to end profiling
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11156/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11156/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11155 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11155/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11155/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11155/events | https://github.com/NVIDIA/NeMo/pull/11155 | 2,634,146,505 | PR_kwDOC_bI7s6A3d4- | 11,155 | Bump `Dockerfile.ci` (2024-11-05) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-05T00:22:10 | 2024-11-05T08:45:41 | 2024-11-05T08:45:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11155",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11155",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11155.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11155.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11155/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11155/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11154 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11154/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11154/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11154/events | https://github.com/NVIDIA/NeMo/pull/11154 | 2,634,059,567 | PR_kwDOC_bI7s6A3MwD | 11,154 | Alit/hyena ux cp | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-11-04T23:15:45 | 2024-11-04T23:15:54 | 2024-11-04T23:15:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11154",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11154",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11154.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11154.patch",
"merged_at": "2024-11-04T23:15:52"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11154/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11154/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11153 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11153/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11153/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11153/events | https://github.com/NVIDIA/NeMo/pull/11153 | 2,634,038,243 | PR_kwDOC_bI7s6A3IF8 | 11,153 | CP init | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-11-04T23:00:22 | 2024-11-04T23:13:02 | 2024-11-04T23:13:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11153",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11153",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11153.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11153.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11153/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11153/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11152 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11152/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11152/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11152/events | https://github.com/NVIDIA/NeMo/pull/11152 | 2,634,023,631 | PR_kwDOC_bI7s6A3Fe_ | 11,152 | Alit/hyena ux dist ckpt | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-11-04T22:50:22 | 2024-11-04T22:53:10 | 2024-11-04T22:53:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11152",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11152",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11152.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11152.patch",
"merged_at": "2024-11-04T22:53:08"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11152/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11152/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11151 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11151/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11151/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11151/events | https://github.com/NVIDIA/NeMo/issues/11151 | 2,633,994,921 | I_kwDOC_bI7s6c_5Kp | 11,151 | How to use wandb sweep for hyperparameter search when finetuning with llama2 | {
"login": "PurvangL",
"id": 104454645,
"node_id": "U_kgDOBjnZ9Q",
"avatar_url": "https://avatars.githubusercontent.com/u/104454645?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PurvangL",
"html_url": "https://github.com/PurvangL",
"followers_url": "https://api.github.com/users/PurvangL/followers",
"following_url": "https://api.github.com/users/PurvangL/following{/other_user}",
"gists_url": "https://api.github.com/users/PurvangL/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PurvangL/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PurvangL/subscriptions",
"organizations_url": "https://api.github.com/users/PurvangL/orgs",
"repos_url": "https://api.github.com/users/PurvangL/repos",
"events_url": "https://api.github.com/users/PurvangL/events{/privacy}",
"received_events_url": "https://api.github.com/users/PurvangL/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@okuchaiev following up regarding issue. please let me know if any other information needed."
] | 2024-11-04T22:33:09 | 2024-11-07T01:34:43 | 2024-11-07T01:34:43 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
Provide a code snippet on how new APIs/changes would be used by others.
```
I would like to do hyperparameter search with wandb sweep. Right now I can't find an option to add sweep config in yaml file. How can I enable wandb sweep and fine-tune llama2 model?
https://wandb.ai/aarora/Nvidia%20NeMO/reports/Train-Optimize-Analyze-Visualize-and-Deploy-Models-for-Automatic-Speech-Recognition-with-NVIDIA-s-NeMo--VmlldzoxNzI0ODEw
```
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
| {
"login": "PurvangL",
"id": 104454645,
"node_id": "U_kgDOBjnZ9Q",
"avatar_url": "https://avatars.githubusercontent.com/u/104454645?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PurvangL",
"html_url": "https://github.com/PurvangL",
"followers_url": "https://api.github.com/users/PurvangL/followers",
"following_url": "https://api.github.com/users/PurvangL/following{/other_user}",
"gists_url": "https://api.github.com/users/PurvangL/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PurvangL/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PurvangL/subscriptions",
"organizations_url": "https://api.github.com/users/PurvangL/orgs",
"repos_url": "https://api.github.com/users/PurvangL/repos",
"events_url": "https://api.github.com/users/PurvangL/events{/privacy}",
"received_events_url": "https://api.github.com/users/PurvangL/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11151/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11151/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11150 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11150/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11150/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11150/events | https://github.com/NVIDIA/NeMo/pull/11150 | 2,633,602,008 | PR_kwDOC_bI7s6A1wfi | 11,150 | Adding support for LLaVA NeXT | {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @yashaswikarnati π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11671706299) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop π€: π¨ The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.mllama.data.lazy\nnemo/collections/vlm/mllama/data/lazy.py:247:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/data/lazy.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:173:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:240:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:255:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:258:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:261:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.data.mock\nnemo/collections/vlm/mllama/data/mock.py:27:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/mock.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:75:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:80:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:85:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.data.sample_encoder\nnemo/collections/vlm/mllama/data/sample_encoder.py:28:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/sample_encoder.py:35:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.vlm.mllama.data.task_encoder\nnemo/collections/vlm/mllama/data/task_encoder.py:28:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/task_encoder.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/task_encoder.py:56:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.vlm.mllama.model.base\nnemo/collections/vlm/mllama/model/base.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:120:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:154:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:161:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:226:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:302:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:331:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:341:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:345:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:387:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:390:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:424:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:517:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:534:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:538:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:567:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:570:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:573:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:577:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:583:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:590:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.language\nnemo/collections/vlm/mllama/model/language.py:706:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/vlm/mllama/model/language.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:205:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:401:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:419:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:422:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:509:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:576:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:592:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:609:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:614:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:698:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.mllama\nnemo/collections/vlm/mllama/model/mllama.py:121:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:122:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:123:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:126:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:127:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:128:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:129:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:130:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:131:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:132:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:133:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:196:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:199:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:200:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:201:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:202:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:203:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:204:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:205:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:206:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:207:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:208:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:209:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:210:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:211:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:218:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:224:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:226:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:36:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:44:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:52:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:68:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:73:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:87:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:91:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.utils\nnemo/collections/vlm/mllama/model/utils.py:122:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/vlm/mllama/model/utils.py:125:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/mllama/model/utils.py:128:0: C0301: Line too long (125/119) (line-too-long)\n************* Module nemo.collections.vlm.mllama.model.vision\nnemo/collections/vlm/mllama/model/vision.py:620:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/vlm/mllama/model/vision.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:318:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:326:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:398:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:417:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:487:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:558:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:569:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:580:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.model.utils\nnemo/collections/vlm/neva/model/utils.py:3:0: C0301: Line too long (196/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:87:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:88:0: C0301: Line too long (188/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:144:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:159:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:169:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:259:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:345:0: C0301: Line too long (124/119) (line-too-long)\n\n-----------------------------------\nYour code has been rated at 9.54/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop π€: π¨ The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.mllama.data.lazy\nnemo/collections/vlm/mllama/data/lazy.py:247:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/data/lazy.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:173:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:240:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:255:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:258:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:261:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.data.mock\nnemo/collections/vlm/mllama/data/mock.py:27:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/mock.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:75:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:80:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:85:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.data.sample_encoder\nnemo/collections/vlm/mllama/data/sample_encoder.py:28:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/sample_encoder.py:35:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.vlm.mllama.data.task_encoder\nnemo/collections/vlm/mllama/data/task_encoder.py:28:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/task_encoder.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/task_encoder.py:56:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.vlm.mllama.model.base\nnemo/collections/vlm/mllama/model/base.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:120:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:154:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:161:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:226:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:302:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:331:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:341:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:345:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:387:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:390:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:424:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:517:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:534:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:538:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:567:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:570:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:573:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:577:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:583:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:590:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.language\nnemo/collections/vlm/mllama/model/language.py:706:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/vlm/mllama/model/language.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:205:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:401:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:419:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:422:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:509:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:576:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:592:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:609:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:614:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:698:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.mllama\nnemo/collections/vlm/mllama/model/mllama.py:121:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:122:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:123:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:126:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:127:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:128:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:129:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:130:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:131:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:132:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:133:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:196:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:199:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:200:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:201:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:202:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:203:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:204:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:205:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:206:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:207:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:208:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:209:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:210:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:211:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:218:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:224:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:226:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:36:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:44:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:52:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:68:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:73:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:87:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:91:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.utils\nnemo/collections/vlm/mllama/model/utils.py:122:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/vlm/mllama/model/utils.py:125:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/mllama/model/utils.py:128:0: C0301: Line too long (125/119) (line-too-long)\n************* Module nemo.collections.vlm.mllama.model.vision\nnemo/collections/vlm/mllama/model/vision.py:620:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/vlm/mllama/model/vision.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:318:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:326:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:398:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:417:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:487:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:558:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:569:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:580:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.model.utils\nnemo/collections/vlm/neva/model/utils.py:3:0: C0301: Line too long (196/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:87:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:88:0: C0301: Line too long (188/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:144:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:159:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:169:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:259:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:345:0: C0301: Line too long (124/119) (line-too-long)\n\n-----------------------------------\nYour code has been rated at 9.54/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module llava_next_energon_training\nexamples/vlm/llava_next_energon_training.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/vlm/llava_next_energon_training.py:2:0: W0611: Unused import os (unused-import)\nexamples/vlm/llava_next_energon_training.py:3:0: W0611: Unused import sys (unused-import)\nexamples/vlm/llava_next_energon_training.py:5:0: W0611: Unused import requests (unused-import)\nexamples/vlm/llava_next_energon_training.py:8:0: W0611: Unused VQASample imported from megatron.energon (unused-import)\nexamples/vlm/llava_next_energon_training.py:9:0: W0611: Unused Image imported from PIL (unused-import)\nexamples/vlm/llava_next_energon_training.py:17:0: W0611: Unused ImageDataConfig imported from nemo.collections.vlm (unused-import)\nexamples/vlm/llava_next_energon_training.py:17:0: W0611: Unused Llava1_5Config7B imported from nemo.collections.vlm (unused-import)\nexamples/vlm/llava_next_energon_training.py:17:0: W0611: Unused LlavaModel imported from nemo.collections.vlm (unused-import)\nexamples/vlm/llava_next_energon_training.py:20:0: W0611: Unused logging imported from nemo.utils (unused-import)\n************* Module llava_next_finetune_energon\nexamples/vlm/llava_next_finetune_energon.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/vlm/llava_next_finetune_energon.py:26:0: W0611: Unused ImageDataConfig imported from nemo.collections.vlm (unused-import)\n************* Module llava_next_generation_example\nexamples/vlm/llava_next_generation_example.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/vlm/llava_next_generation_example.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)\nexamples/vlm/llava_next_generation_example.py:2:0: W0611: Unused import os (unused-import)\nexamples/vlm/llava_next_generation_example.py:3:0: W0611: Unused import sys (unused-import)\nexamples/vlm/llava_next_generation_example.py:11:0: W0611: Unused VQASample imported from megatron.energon (unused-import)\n************* Module nemo.collections.llm.recipes.optim.sgd\nnemo/collections/llm/recipes/optim/sgd.py:23:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/recipes/optim/sgd.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.data.llava_next_energon\nnemo/collections/vlm/neva/data/llava_next_energon.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/neva/data/llava_next_energon.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/llava_next_energon.py:48:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/llava_next_energon.py:54:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/neva/data/llava_next_energon.py:124:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.export.vllm_hf_exporter\nnemo/export/vllm_hf_exporter.py:97:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module examples.llm.peft.hf\nexamples/llm/peft/hf.py:25:0: C0301: Line too long (184/119) (line-too-long)\nexamples/llm/peft/hf.py:76:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/peft/hf.py:21:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module hf\nexamples/llm/sft/hf.py:70:0: C0301: Line too long (162/119) (line-too-long)\nexamples/llm/sft/hf.py:24:0: C0115: Missing class docstring (missing-class-docstring)\nexamples/llm/sft/hf.py:37:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.data.audio_to_text\nnemo/collections/asr/data/audio_to_text.py:407:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/data/audio_to_text.py:428:0: C0301: Line too long (262/119) (line-too-long)\nnemo/collections/asr/data/audio_to_text.py:555:0: C0301: Line too long (262/119) (line-too-long)\nnemo/collections/asr/data/audio_to_text.py:651:0: C0301: Line too long (262/119) (line-too-long)\nnemo/collections/asr/data/audio_to_text.py:735:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/asr/data/audio_to_text.py:741:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/asr/data/audio_to_text.py:750:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/data/audio_to_text.py:168:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/data/audio_to_text.py:172:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/data/audio_to_text.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/data/audio_to_text.py:190:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/data/audio_to_text.py:376:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/data/audio_to_text.py:483:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/data/audio_to_text.py:697:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/data/audio_to_text.py:916:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/data/audio_to_text.py:936:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/data/audio_to_text.py:1011:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/data/audio_to_text.py:1294:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/data/audio_to_text.py:1364:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/data/audio_to_text.py:1387:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.models.aed_multitask_models\nnemo/collections/asr/models/aed_multitask_models.py:695:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:727:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:769:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:777:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:1049:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:1115:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.models.classification_models\nnemo/collections/asr/models/classification_models.py:380:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:525:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:526:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:532:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:533:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:539:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:540:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:546:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:547:0: C0301: Line too long (187/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:553:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:554:0: C0301: Line too long (187/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:560:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:561:0: C0301: Line too long (187/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:567:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:568:0: C0301: Line too long (187/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:574:0: C0301: Line too long (174/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:575:0: C0301: Line too long (211/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:581:0: C0301: Line too long (174/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:582:0: C0301: Line too long (211/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:695:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:922:0: C0301: Line too long (163/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:923:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:1134:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:1135:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:1136:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:1137:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:1138:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:1230:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/classification_models.py:48:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/models/classification_models.py:56:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/models/classification_models.py:160:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:592:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:612:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:630:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:809:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:827:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:836:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/classification_models.py:904:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/models/classification_models.py:1014:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.models.confidence_ensemble\nnemo/collections/asr/models/confidence_ensemble.py:42:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.models.ctc_bpe_models\nnemo/collections/asr/models/ctc_bpe_models.py:365:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:366:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:372:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:373:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:379:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:380:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:386:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:387:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:393:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:394:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:400:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:401:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:408:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:409:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:416:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:417:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:423:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:424:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:430:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:431:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:437:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:438:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:445:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:446:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:452:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:453:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:459:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:460:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:466:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:467:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:473:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:474:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:480:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:481:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:487:0: C0301: Line too long (171/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:488:0: C0301: Line too long (181/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:494:0: C0301: Line too long (165/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:495:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:501:0: C0301: Line too long (171/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:502:0: C0301: Line too long (181/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:508:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:509:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:515:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:516:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:522:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:523:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:529:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:530:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:536:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:537:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:543:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:544:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:550:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:551:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:557:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:558:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:564:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:565:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:571:0: C0301: Line too long (147/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:572:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:578:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:579:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:585:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:586:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:592:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:593:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:599:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:600:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:606:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:607:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:613:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:614:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:620:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:621:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:627:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:628:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:634:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:635:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:641:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:642:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:648:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:649:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:655:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:656:0: C0301: Line too long (163/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:662:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/ctc_bpe_models.py:663:0: C0301: Line too long (165/119) (line-too-long)\n************* Module nemo.collections.asr.models.ctc_models\nnemo/collections/asr/models/ctc_models.py:196:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:197:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:813:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:819:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:820:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:826:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:827:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:833:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:834:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:840:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:841:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:847:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:848:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:854:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:855:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:861:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:862:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:868:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:869:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:875:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:876:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:882:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:883:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:889:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:890:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:897:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:898:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:904:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:905:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/ctc_models.py:545:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:602:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:620:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:662:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/ctc_models.py:916:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_bpe_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:263:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:267:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:277:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:526:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:527:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:533:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:534:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:540:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:541:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:547:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:548:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:554:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:555:0: C0301: Line too long (190/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:561:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:562:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:568:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:569:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:575:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:576:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:582:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:583:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:589:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:590:0: C0301: Line too long (173/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:596:0: C0301: Line too long (175/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:597:0: C0301: Line too long (211/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:603:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:604:0: C0301: Line too long (193/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:610:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:611:0: C0301: Line too long (197/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:617:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:618:0: C0301: Line too long (199/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:624:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:625:0: C0301: Line too long (201/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:631:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_bpe_models.py:632:0: C0301: Line too long (199/119) (line-too-long)\n************* Module nemo.collections.asr.models.hybrid_rnnt_ctc_models\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:717:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:718:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:16:0: W0611: Unused import json (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:17:0: W0611: Unused import os (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:18:0: W0611: Unused import tempfile (unused-import)\nnemo/collections/asr/models/hybrid_rnnt_ctc_models.py:24:0: W0611: Unused tqdm imported from tqdm.auto (unused-import)\n************* Module nemo.collections.asr.models.rnnt_bpe_models\nnemo/collections/asr/models/rnnt_bpe_models.py:53:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:54:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:60:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:61:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:67:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:68:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:74:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:75:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:81:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:82:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:88:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:89:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:95:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:96:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:102:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:103:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:109:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:110:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:116:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:117:0: C0301: Line too long (172/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:123:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:124:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:130:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:131:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:137:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:138:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:144:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:145:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:151:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:152:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:158:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:159:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:165:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:166:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:172:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:173:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:179:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:180:0: C0301: Line too long (170/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:186:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:187:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:193:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:194:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:200:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:201:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:207:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:208:0: C0301: Line too long (184/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:214:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:215:0: C0301: Line too long (169/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:221:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:222:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:228:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:229:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:235:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:236:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:242:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:243:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:249:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:250:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:256:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:257:0: C0301: Line too long (174/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:263:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:264:0: C0301: Line too long (180/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:270:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:271:0: C0301: Line too long (177/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:277:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/asr/models/rnnt_bpe_models.py:278:0: C0301: Line too long (179/119) (line-too-long)\n************* Module nemo.collections.asr.models.rnnt_models\nnemo/collections/asr/models/rnnt_models.py:1084:0: C0301: Line too long (164/119) (line-too-long)\nnemo/collections/asr/models/rnnt_models.py:1085:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/asr/models/rnnt_models.py:230:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:705:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:803:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:820:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:888:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:896:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:1061:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/rnnt_models.py:1092:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.modules.conv_asr\nnemo/collections/asr/modules/conv_asr.py:197:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:239:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:399:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:459:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:503:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:507:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:603:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:677:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:689:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:758:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:858:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:881:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/conv_asr.py:900:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:945:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:969:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:983:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/modules/conv_asr.py:992:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.mixins.transcription\nnemo/collections/asr/parts/mixins/transcription.py:40:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/mixins/transcription.py:57:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/mixins/transcription.py:95:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/mixins/transcription.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.parts.numba.rnnt_loss.rnnt_pytorch\nnemo/collections/asr/parts/numba/rnnt_loss/rnnt_pytorch.py:88:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/numba/rnnt_loss/rnnt_pytorch.py:179:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/numba/rnnt_loss/rnnt_pytorch.py:260:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/numba/rnnt_loss/rnnt_pytorch.py:586:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/numba/rnnt_loss/rnnt_pytorch.py:591:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/numba/rnnt_loss/rnnt_pytorch.py:596:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/numba/rnnt_loss/rnnt_pytorch.py:601:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.parts.utils.streaming_utils\nnemo/collections/asr/parts/utils/streaming_utils.py:426:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:429:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:473:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:546:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:569:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:632:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:644:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:658:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:685:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:777:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:783:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:787:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:824:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:842:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1506:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1515:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1521:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1525:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1537:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1542:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1549:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1584:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1587:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1597:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1608:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1612:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1683:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/streaming_utils.py:1731:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.utils.transcribe_utils\nnemo/collections/asr/parts/utils/transcribe_utils.py:177:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:339:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:636:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:651:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:659:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:662:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/utils/transcribe_utils.py:670:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.common.tokenizers.huggingface.auto_tokenizer\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:52:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:53:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:64:0: C0301: Line too long (184/119) (line-too-long)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:178:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:183:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:200:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:173:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:211:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:237:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:260:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:271:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:277:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/huggingface/auto_tokenizer.py:15:0: W0611: Unused OrderedDict imported from collections (unused-import)\n************* Module nemo.collections.diffusion.models.dit.dit_embeddings\nnemo/collections/diffusion/models/dit/dit_embeddings.py:141:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:147:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:173:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:16:0: W0611: Unused import math (unused-import)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:17:0: W0611: Unused Dict imported from typing (unused-import)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:17:0: W0611: Unused Literal imported from typing (unused-import)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:17:0: W0611: Unused Optional imported from typing (unused-import)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:19:0: W0611: Unused numpy imported as np (unused-import)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:21:0: W0611: Unused torch.nn.functional imported as F (unused-import)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:24:0: W0611: Unused Rearrange imported from einops.layers.torch (unused-import)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:26:0: W0611: Unused get_pos_emb_on_this_cp_rank imported from megatron.core.models.common.embeddings.rotary_pos_embedding (unused-import)\nnemo/collections/diffusion/models/dit/dit_embeddings.py:28:0: W0611: Unused nn imported from torch (unused-import)\n************* Module nemo.collections.diffusion.models.dit.dit_layer_spec\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:194:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:234:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:249:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:268:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:288:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:306:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:362:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:396:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:416:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:549:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:552:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:53:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:59:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:65:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:74:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:108:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:132:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:138:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:157:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:221:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:383:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:482:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:565:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:623:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:643:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:675:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:736:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:775:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:800:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:826:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:845:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:21:0: W0611: Unused rearrange imported from einops (unused-import)\nnemo/collections/diffusion/models/dit/dit_layer_spec.py:22:0: W0611: Unused jit_fuser imported from megatron.core.jit (unused-import)\n************* Module nemo.collections.diffusion.models.dit.dit_model\nnemo/collections/diffusion/models/dit/dit_model.py:111:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_model.py:115:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_model.py:117:0: C0301: Line too long (157/119) (line-too-long)\nnemo/collections/diffusion/models/dit/dit_model.py:40:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_model.py:44:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/diffusion/models/dit/dit_model.py:53:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_model.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit/dit_model.py:20:0: W0611: Unused torch.nn.functional imported as F (unused-import)\n************* Module nemo.collections.diffusion.models.dit_llama.dit_llama_layer_spec\nnemo/collections/diffusion/models/dit_llama/dit_llama_layer_spec.py:76:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/diffusion/models/dit_llama/dit_llama_layer_spec.py:103:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/diffusion/models/dit_llama/dit_llama_layer_spec.py:119:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/diffusion/models/dit_llama/dit_llama_layer_spec.py:88:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/dit_llama/dit_llama_layer_spec.py:195:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.diffusion.models.dit_llama.dit_llama_model\nnemo/collections/diffusion/models/dit_llama/dit_llama_model.py:25:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.diffusion.models.model\nnemo/collections/diffusion/models/model.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/models/model.py:334:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.diffusion.sampler.edm.edm_pipeline\nnemo/collections/diffusion/sampler/edm/edm_pipeline.py:20:0: W0611: Unused rearrange imported from einops (unused-import)\n************* Module nemo.collections.diffusion.train\nnemo/collections/diffusion/train.py:223:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/diffusion/train.py:258:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:71:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:227:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:358:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/api.py:259:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:319:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:331:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/api.py:493:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.data.hf_dataset\nnemo/collections/llm/gpt/data/hf_dataset.py:21:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:51:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/data/hf_dataset.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.hf_auto_model_for_causal_lm\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:34:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:54:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:65:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:91:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/hf_auto_model_for_causal_lm.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.llama\nnemo/collections/llm/gpt/model/llama.py:483:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/llm/gpt/model/llama.py:42:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:80:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:89:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:111:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:132:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:142:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:154:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:164:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:175:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:186:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:192:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:198:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:209:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:213:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:225:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:265:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:302:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/llama.py:321:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:338:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/llama.py:475:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.gpt.model.nemotron\nnemo/collections/llm/gpt/model/nemotron.py:38:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:67:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:79:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:91:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:103:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:115:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:126:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:138:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:159:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:216:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:234:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:252:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/gpt/model/nemotron.py:256:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.quantization.quantizer\nnemo/collections/llm/quantization/quantizer.py:231:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/quantization/quantizer.py:264:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/quantization/quantizer.py:316:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.recipes.gemma_2b\nnemo/collections/llm/recipes/gemma_2b.py:256:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/recipes/gemma_2b.py:257:0: C0301: Line too long (158/119) (line-too-long)\n************* Module nemo.collections.llm.recipes.gemma_7b\nnemo/collections/llm/recipes/gemma_7b.py:259:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/llm/recipes/gemma_7b.py:260:0: C0301: Line too long (158/119) (line-too-long)\n************* Module nemo.collections.llm.recipes.hf_auto_model_for_causal_lm\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:103:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/llm/recipes/hf_auto_model_for_causal_lm.py:154:0: C0301: Line too...*[Comment body truncated]*",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop π€: π¨ The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.vlm.mllama.data.lazy\nnemo/collections/vlm/mllama/data/lazy.py:247:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/data/lazy.py:120:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:173:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:240:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:255:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:258:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/lazy.py:261:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.data.mock\nnemo/collections/vlm/mllama/data/mock.py:27:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/mock.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:75:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:80:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/mock.py:85:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.data.sample_encoder\nnemo/collections/vlm/mllama/data/sample_encoder.py:28:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/sample_encoder.py:35:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.vlm.mllama.data.task_encoder\nnemo/collections/vlm/mllama/data/task_encoder.py:28:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/data/task_encoder.py:41:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/data/task_encoder.py:56:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.vlm.mllama.model.base\nnemo/collections/vlm/mllama/model/base.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:120:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:151:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:154:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:161:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:226:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:302:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:331:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:341:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:345:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:387:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:390:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:424:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:517:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/base.py:534:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:538:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:567:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:570:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:573:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:577:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:583:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/base.py:590:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.language\nnemo/collections/vlm/mllama/model/language.py:706:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/vlm/mllama/model/language.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:137:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:205:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:361:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:401:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/language.py:419:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:422:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:509:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:576:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:592:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:609:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:614:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/language.py:698:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.mllama\nnemo/collections/vlm/mllama/model/mllama.py:121:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:122:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:123:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:126:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:127:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:128:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:129:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:130:0: C0301: Line too long (161/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:131:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:132:0: C0301: Line too long (160/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:133:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:196:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:199:0: C0301: Line too long (137/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:200:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:201:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:202:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:203:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:204:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:205:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:206:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:207:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:208:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:209:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:210:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:211:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:218:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:224:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:226:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/mllama/model/mllama.py:36:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:44:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:52:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:68:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:73:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:87:8: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:91:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:116:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/mllama.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.mllama.model.utils\nnemo/collections/vlm/mllama/model/utils.py:122:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/vlm/mllama/model/utils.py:125:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/vlm/mllama/model/utils.py:128:0: C0301: Line too long (125/119) (line-too-long)\n************* Module nemo.collections.vlm.mllama.model.vision\nnemo/collections/vlm/mllama/model/vision.py:620:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/vlm/mllama/model/vision.py:61:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:115:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:318:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:326:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:398:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:417:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:487:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/vlm/mllama/model/vision.py:558:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:569:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/vlm/mllama/model/vision.py:580:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.vlm.neva.model.utils\nnemo/collections/vlm/neva/model/utils.py:3:0: C0301: Line too long (196/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:87:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:88:0: C0301: Line too long (188/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:144:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:159:0: C0301: Line too long (139/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:169:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:259:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/vlm/neva/model/utils.py:345:0: C0301: Line too long (124/119) (line-too-long)\n\n-----------------------------------\nYour code has been rated at 9.54/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-11-04T18:57:19 | 2024-11-27T20:38:00 | 2024-11-27T20:38:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11150",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11150",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11150.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11150.patch",
"merged_at": null
} | # What does this PR do ?
added necessary task encoders for energon data module to support training LLaVA NeXT with NeVA Model. Also changes to neva base model to support passing num_image_tiles to mcore model.
**Collection**: [Note which collection this PR will affect]
Multimodal
# Changelog
- Task encoder for LLaVA NExT data module
- Modify data_step and forward_step of neva model to support image tiling.
# Usage
* Example usage of datamodule for LLaVa NeXT
```python
from nemo.collections.multimodal.data.energon.config import MultiModalSampleConfig
from nemo.collections.vlm import LlavaNextTaskEncoder
from nemo.collections.multimodal.data.energon import SimpleMultiModalDataModule
from transformers import AutoProcessor
processor = AutoProcessor.from_pretrained("llava-hf/llava-v1.6-mistral-7b-hf")
data_path = args.data_path
image_processor = processor.image_processor
tokenizer = processor.tokenizer
multimodal_sample_config = MultiModalSampleConfig()
task_encoder = LlavaNextTaskEncoder(
tokenizer=tokenizer, image_processor=image_processor, multimodal_sample_config=multimodal_sample_config
)
data = SimpleMultiModalDataModule(
path=data_path,
tokenizer=tokenizer,
image_processor=image_processor,
num_workers=8,
micro_batch_size=mbs,
global_batch_size=gbs,
multimodal_sample_config=multimodal_sample_config,
task_encoder=task_encoder,
)
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yashaswikarnati",
"id": 144376261,
"node_id": "U_kgDOCJsBxQ",
"avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yashaswikarnati",
"html_url": "https://github.com/yashaswikarnati",
"followers_url": "https://api.github.com/users/yashaswikarnati/followers",
"following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}",
"gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions",
"organizations_url": "https://api.github.com/users/yashaswikarnati/orgs",
"repos_url": "https://api.github.com/users/yashaswikarnati/repos",
"events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}",
"received_events_url": "https://api.github.com/users/yashaswikarnati/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11150/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11150/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11149 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11149/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11149/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11149/events | https://github.com/NVIDIA/NeMo/issues/11149 | 2,633,515,398 | I_kwDOC_bI7s6c-EGG | 11,149 | Learning Rate Sudden Dropped to min_lr after Warm-up Steps | {
"login": "zixianwang2022",
"id": 100260976,
"node_id": "U_kgDOBfnccA",
"avatar_url": "https://avatars.githubusercontent.com/u/100260976?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zixianwang2022",
"html_url": "https://github.com/zixianwang2022",
"followers_url": "https://api.github.com/users/zixianwang2022/followers",
"following_url": "https://api.github.com/users/zixianwang2022/following{/other_user}",
"gists_url": "https://api.github.com/users/zixianwang2022/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zixianwang2022/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zixianwang2022/subscriptions",
"organizations_url": "https://api.github.com/users/zixianwang2022/orgs",
"repos_url": "https://api.github.com/users/zixianwang2022/repos",
"events_url": "https://api.github.com/users/zixianwang2022/events{/privacy}",
"received_events_url": "https://api.github.com/users/zixianwang2022/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"Looking here[https://github.com/NVIDIA/NeMo/blob/main/nemo/core/optim/lr_scheduler.py#L353](url) you may need to set `decay_steps` (If I'm looking in the correct place). It looks like during the `warmup_steps` the learning rate linearly ramps to `max_lr`, then decays to `min_lr` during `decay_steps`. Curious if that works for you! ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-04T18:11:58 | 2024-12-18T02:02:11 | 2024-12-18T02:02:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Hi, I am observing that the learning rate suddenly dropped to `model.optim.sched.min_lr` after `model.optim.sched.warmup_steps`. I am using `CosineAnnealing`, where I am expecting the learning rate will gradually drop to min_lr after warmup steps instead of suddenly dropping.
**Steps/Code to reproduce bug**
```
optim:
name: distributed_fused_adam
lr: 5e-6
weight_decay: 0.01
betas:
- 0.9
- 0.98
sched:
name: CosineAnnealing
warmup_steps: 250
constant_steps: 2500
min_lr: 1e-7
```
**Expected behavior**
I am expecting the learning rate will gradually drop to min_lr after warmup steps instead of suddenly dropping. If I am doing it the wrong way, what should be the correct way of making this possible?
**Environment overview (please complete the following information)**
- PyTorch version 2.3
- Python version 3.10 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11149/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11149/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11148 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11148/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11148/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11148/events | https://github.com/NVIDIA/NeMo/pull/11148 | 2,633,369,626 | PR_kwDOC_bI7s6A1ASB | 11,148 | ci: Prevent double CI run after cherry-picks | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Done with #11180 "
] | 2024-11-04T17:10:48 | 2024-11-08T21:40:22 | 2024-11-08T21:40:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11148",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11148",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11148.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11148.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11148/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11148/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11147 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11147/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11147/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11147/events | https://github.com/NVIDIA/NeMo/pull/11147 | 2,633,265,960 | PR_kwDOC_bI7s6A0q67 | 11,147 | feat: Run PyLint | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"LGTM . Hope it is tested thoroughly with varied different cases / scenarios"
] | 2024-11-04T16:25:38 | 2024-11-06T09:01:26 | 2024-11-06T09:01:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11147",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11147",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11147.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11147.patch",
"merged_at": "2024-11-06T09:01:20"
} | # What does this PR do ?
Runs Pylint on changed files with the following rules:
* C0115: missing-class-docstring
* C0116: missing-function-docstring
* W0611: unused-import
* C0301: line-too-long
We can skip Pylint by attaching the label `skip-docs`. This will re-run the check automatically.
This label-mechanism is implemented by modifying the reformat workflow to run - additionally to its default triggers (`opened, synchronize, reopened`) - also on the events `labeled, unlabeled`. So every time a PR is labeled/unlabeled, the reformat workflow will run.
!!! For testing purpose, I added the event trigger `pull_request`. We need to remove this before merge. This is here only for show-casing. !!!
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11147/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11147/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11146 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11146/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11146/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11146/events | https://github.com/NVIDIA/NeMo/pull/11146 | 2,633,254,806 | PR_kwDOC_bI7s6A0ob7 | 11,146 | Fix freeze_model call in peft | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11669612420) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-04T16:20:56 | 2024-11-05T02:41:57 | 2024-11-05T02:41:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11146",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11146",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11146.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11146.patch",
"merged_at": "2024-11-05T02:41:56"
} | # What does this PR do ?
freeze_model() must be called because some peft methods may have custom freeze strategies
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11146/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11146/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11145 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11145/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11145/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11145/events | https://github.com/NVIDIA/NeMo/pull/11145 | 2,633,189,306 | PR_kwDOC_bI7s6A0alZ | 11,145 | config hierarchy | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@hemildesai and @marcromeyn I thought nemo-run has some cool tools for visualizing config hierarchy?",
"I think @ericharper, you mean graphviz feature here- https://github.com/NVIDIA/NeMo-Run/blob/main/src/nemo_run/config.py#L35, right? @marcromeyn @hemildesai \r\n\r\nBut, this PR is for a user to know what are all the high level options/params available to update/create a recipe. As there are so many different things in multiple places and repos, this can be a one stop to check all the available features.\r\nCC: @erhoo82 @jstjohn ",
"> I think @ericharper, you mean graphviz feature here- https://github.com/NVIDIA/NeMo-Run/blob/main/src/nemo_run/config.py#L35, right? @marcromeyn @hemildesai\r\n> \r\n> But, this PR is for a user to know what are all the high level options/params available to update/create a recipe. As there are so many different things in multiple places and repos, this can be a one stop to check all the available features. CC: @erhoo82 @jstjohn\r\n\r\nYeah the graphviz features are only available once you initialize the config in code. IIUC, this is more of a documentation guide.",
"@malay-nagda Can we move this to https://github.com/NVIDIA/NeMo/tree/main/nemo/collections/llm/recipes?\r\n\r\nThe collections/common module is not used in NeMo 2.0. Apart from that, the guide looks great.",
"This is nice. I wonder if we can generate this automatically? Since otherwise it might be tricky to keep this up-to-date",
"@hemildesai moved this to https://github.com/malay-nagda/NeMo/blob/config_flow/nemo/collections/llm/recipes/CONFIGURATION-HIERARCHY.md\r\n\r\n@marcromeyn given that the modules are spread across different places (and repos) and new features might be arbitrarily added in different places, not sure how we would generate this automatically? ",
"@marcromeyn we could probably update [Contributor Guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) (and the PR template also?) to say the developer should consider updating CONFIGURATION-HIERARCHY.md if they are adding a new feature/params/config options?",
"If this looks good, can we merge this? @marcromeyn @hemildesai @ericharper \r\ncc: @erhoo82 ",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-04T15:52:49 | 2024-12-06T18:45:54 | 2024-12-06T18:45:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11145",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11145",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11145.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11145.patch",
"merged_at": "2024-12-06T18:45:54"
} | # What does this PR do ?
List of available configuration options and features with the parameters a user can utilize for NeMo2.0 recipes.
**Collection**: [llm]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11145/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11145/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11144 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11144/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11144/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11144/events | https://github.com/NVIDIA/NeMo/pull/11144 | 2,633,188,262 | PR_kwDOC_bI7s6A0aXp | 11,144 | Fix RNN-T loss memory usage | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @artbataev π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11667864007) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-04T15:52:25 | 2024-11-04T19:09:04 | 2024-11-04T19:09:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11144",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11144",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11144.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11144.patch",
"merged_at": "2024-11-04T19:09:02"
} | # What does this PR do ?
Fixes memory usage for Numba-based implementation of RNN-T and Multi-blank Transducer losses.
The current implementation requires 3x memory compared to the size of logits (logits, gradient, extra memory = size of logits). This PR fixes memory usage to the minimal possible 2x (logits, gradient).
It looks like assigning tensors directly to `ctx` instead of saving them through `save_for_backward` breaks PyTorch logic, and it copies the gradient tensor (which results in extra memory usage).
TDT loss was not affected by this issue (I'm unsure why, but it requires contiguous tensor for labels-related logits).
**Before (main):**
- Peak memory before loss: 2.09 GB
- Peak memory after loss: **6.27 GB**
**After (this PR):**
- Peak memory before loss: 2.09 GB
- Peak memory after loss: **4.18 GB**
Code to check memory usage (size of tensors besides logits is negligible compared to logits):
```python
import torch
from nemo.collections.asr.parts.numba.rnnt_loss import RNNTLossNumba
device = torch.device("cuda")
loss = RNNTLossNumba(blank=1023, reduction='none')
batch_size = 32
logits = torch.rand([batch_size, 188, 90 + 1, 1024], device=device, dtype=torch.float32, requires_grad=True)
encoder_lengths = torch.full([batch_size], fill_value=188, device=device, dtype=torch.long)
label_lengths = torch.full([batch_size], fill_value=90, device=device, dtype=torch.long)
labels = torch.randint(0, 1022, size=[batch_size, 90], dtype=torch.long, device=device)
print(f"Peak memory before loss: {torch.cuda.max_memory_allocated() / (2 ** 30):.2f} GB")
loss_value = loss(acts=logits, act_lens=encoder_lengths, labels=labels, label_lens=label_lengths)
loss_value.sum().backward()
print(f"Peak memory after loss: {torch.cuda.max_memory_allocated() / (2 ** 30):.2f} GB")
```
**Collection**: [ASR]
# Changelog
- In transducer-related functions that extend autograd, save tensors using `ctx.save_for_backward(...)` instead of directly assigning tensors [according to PyTorch documentation](https://pytorch.org/docs/stable/notes/extending.html#extending-autograd).
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11144/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11144/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11143 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11143/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11143/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11143/events | https://github.com/NVIDIA/NeMo/pull/11143 | 2,632,263,180 | PR_kwDOC_bI7s6AxZdk | 11,143 | ci: Pin release freeze | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11668968462) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-04T09:19:06 | 2024-11-04T22:44:34 | 2024-11-04T17:30:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11143",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11143",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11143.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11143.patch",
"merged_at": "2024-11-04T17:30:36"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11143/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11143/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11142 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11142/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11142/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11142/events | https://github.com/NVIDIA/NeMo/issues/11142 | 2,632,222,096 | I_kwDOC_bI7s6c5IWQ | 11,142 | convert_qwen2_hf_to_nemo error | {
"login": "huangqingyi-code",
"id": 57956960,
"node_id": "MDQ6VXNlcjU3OTU2OTYw",
"avatar_url": "https://avatars.githubusercontent.com/u/57956960?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huangqingyi-code",
"html_url": "https://github.com/huangqingyi-code",
"followers_url": "https://api.github.com/users/huangqingyi-code/followers",
"following_url": "https://api.github.com/users/huangqingyi-code/following{/other_user}",
"gists_url": "https://api.github.com/users/huangqingyi-code/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huangqingyi-code/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huangqingyi-code/subscriptions",
"organizations_url": "https://api.github.com/users/huangqingyi-code/orgs",
"repos_url": "https://api.github.com/users/huangqingyi-code/repos",
"events_url": "https://api.github.com/users/huangqingyi-code/events{/privacy}",
"received_events_url": "https://api.github.com/users/huangqingyi-code/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-04T08:58:36 | 2024-12-13T02:06:06 | 2024-12-13T02:06:06 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | environment: nvcr.io/nvidia/nemo:24.07 image (I also tried installing it from scratch according to the readme. They all make the same mistake)
```python
python ./scripts/checkpoint_converters/convert_qwen2_hf_to_nemo.py --input_name_or_path ../Qwen2.5-7B/ --output_path ../Qwen2.5-7B.nemo
```
Traceback (most recent call last):
File "/workspace/NeMo/nemo/collections/nlp/models/language_modeling/megatron/bert/bert_spec.py", line 17, in <module>
from megatron.core.extensions.transformer_engine import (
ModuleNotFoundError: No module named 'megatron.core.extensions'
During handling of the above exception, another exception occurred:
NameError: name 'ApexGuardDefaults' is not defined | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11142/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11142/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11141 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11141/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11141/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11141/events | https://github.com/NVIDIA/NeMo/pull/11141 | 2,631,588,915 | PR_kwDOC_bI7s6AvPuM | 11,141 | Bump `Dockerfile.ci` (2024-11-04) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-04T00:23:35 | 2024-11-05T08:45:51 | 2024-11-05T08:45:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11141",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11141",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11141.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11141.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11141/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11141/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11140 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11140/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11140/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11140/events | https://github.com/NVIDIA/NeMo/pull/11140 | 2,630,882,322 | PR_kwDOC_bI7s6Atn9N | 11,140 | Bump `Dockerfile.ci` (2024-11-03) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-03T00:24:46 | 2024-11-04T09:21:44 | 2024-11-04T09:21:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11140",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11140",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11140.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11140.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11140/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11140/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11139 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11139/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11139/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11139/events | https://github.com/NVIDIA/NeMo/issues/11139 | 2,630,697,400 | I_kwDOC_bI7s6czUG4 | 11,139 | How to Visualize Backward Computational Graph | {
"login": "zixianwang2022",
"id": 100260976,
"node_id": "U_kgDOBfnccA",
"avatar_url": "https://avatars.githubusercontent.com/u/100260976?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zixianwang2022",
"html_url": "https://github.com/zixianwang2022",
"followers_url": "https://api.github.com/users/zixianwang2022/followers",
"following_url": "https://api.github.com/users/zixianwang2022/following{/other_user}",
"gists_url": "https://api.github.com/users/zixianwang2022/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zixianwang2022/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zixianwang2022/subscriptions",
"organizations_url": "https://api.github.com/users/zixianwang2022/orgs",
"repos_url": "https://api.github.com/users/zixianwang2022/repos",
"events_url": "https://api.github.com/users/zixianwang2022/events{/privacy}",
"received_events_url": "https://api.github.com/users/zixianwang2022/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-11-02T18:39:52 | 2024-12-10T02:06:18 | 2024-12-10T02:06:18 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
Is there a way I can visualize the computational graph during backward propagation in Megatron? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11139/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11139/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11138 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11138/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11138/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11138/events | https://github.com/NVIDIA/NeMo/pull/11138 | 2,630,268,653 | PR_kwDOC_bI7s6AsKeS | 11,138 | update nemo args for mcore flash decode arg change | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @HuiyingLi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11670553361) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-02T06:50:34 | 2024-11-05T02:19:12 | 2024-11-05T02:19:11 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11138",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11138",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11138.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11138.patch",
"merged_at": "2024-11-05T02:19:11"
} | update mcore transformer layer, block, attention forward args for flash decode
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11138/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11138/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11137 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11137/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11137/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11137/events | https://github.com/NVIDIA/NeMo/pull/11137 | 2,630,065,254 | PR_kwDOC_bI7s6Arl2O | 11,137 | Bump `Dockerfile.ci` (2024-11-02) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-02T00:22:01 | 2024-11-04T09:21:41 | 2024-11-04T09:21:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11137",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11137",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11137.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11137.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11137/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11137/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11136 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11136/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11136/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11136/events | https://github.com/NVIDIA/NeMo/pull/11136 | 2,629,607,589 | PR_kwDOC_bI7s6AqN9N | 11,136 | ci: Test redundancy | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-01T18:13:53 | 2024-11-04T09:22:29 | 2024-11-04T09:22:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11136",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11136",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11136.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11136.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11136/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11136/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11135 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11135/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11135/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11135/events | https://github.com/NVIDIA/NeMo/pull/11135 | 2,629,478,802 | PR_kwDOC_bI7s6ApzUD | 11,135 | Cherry pick `Virtual pipeline parallel support for LoRA in NLPAdapterModelMixin (11128)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-01T17:05:31 | 2024-11-01T17:58:07 | 2024-11-01T17:17:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11135",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11135",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11135.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11135.patch",
"merged_at": "2024-11-01T17:17:42"
} | [π€]: Hi @vysarge π,<br><br>we've cherry picked #11128 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "vysarge",
"id": 10239441,
"node_id": "MDQ6VXNlcjEwMjM5NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/10239441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vysarge",
"html_url": "https://github.com/vysarge",
"followers_url": "https://api.github.com/users/vysarge/followers",
"following_url": "https://api.github.com/users/vysarge/following{/other_user}",
"gists_url": "https://api.github.com/users/vysarge/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vysarge/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vysarge/subscriptions",
"organizations_url": "https://api.github.com/users/vysarge/orgs",
"repos_url": "https://api.github.com/users/vysarge/repos",
"events_url": "https://api.github.com/users/vysarge/events{/privacy}",
"received_events_url": "https://api.github.com/users/vysarge/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11135/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11135/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11134 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11134/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11134/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11134/events | https://github.com/NVIDIA/NeMo/pull/11134 | 2,629,370,120 | PR_kwDOC_bI7s6ApcQM | 11,134 | Remove deprecated tests | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"It's removing CI test, so no need to run CI"
] | 2024-11-01T16:16:33 | 2024-11-04T17:21:58 | 2024-11-04T17:21:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11134",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11134",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11134.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11134.patch",
"merged_at": "2024-11-04T17:21:56"
} | Remove deprecated tests | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11134/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11134/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11133 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11133/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11133/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11133/events | https://github.com/NVIDIA/NeMo/pull/11133 | 2,629,347,359 | PR_kwDOC_bI7s6ApXHj | 11,133 | Added deprecation notice | {
"login": "Ssofja",
"id": 78349198,
"node_id": "MDQ6VXNlcjc4MzQ5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/78349198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ssofja",
"html_url": "https://github.com/Ssofja",
"followers_url": "https://api.github.com/users/Ssofja/followers",
"following_url": "https://api.github.com/users/Ssofja/following{/other_user}",
"gists_url": "https://api.github.com/users/Ssofja/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ssofja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ssofja/subscriptions",
"organizations_url": "https://api.github.com/users/Ssofja/orgs",
"repos_url": "https://api.github.com/users/Ssofja/repos",
"events_url": "https://api.github.com/users/Ssofja/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ssofja/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @Ssofja π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11666093312) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-01T16:06:04 | 2024-11-05T16:13:24 | 2024-11-05T16:13:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11133",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11133",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11133.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11133.patch",
"merged_at": "2024-11-05T16:13:22"
} | # What does this PR do ?
Some deprecation notices have added for future code refactoring
Add a one line overview of what this PR aims to accomplish.
**Collection**: [asr]
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11133/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11133/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11132 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11132/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11132/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11132/events | https://github.com/NVIDIA/NeMo/pull/11132 | 2,628,866,857 | PR_kwDOC_bI7s6An1rh | 11,132 | Cherry pick 11097 in r2.0.0 | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-01T11:36:01 | 2024-11-01T15:06:14 | 2024-11-01T15:06:13 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11132",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11132",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11132.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11132.patch",
"merged_at": "2024-11-01T15:06:13"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11132/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11132/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11131 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11131/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11131/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11131/events | https://github.com/NVIDIA/NeMo/pull/11131 | 2,628,763,968 | PR_kwDOC_bI7s6Anhqc | 11,131 | add JitTransform | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11667702173) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11669825521) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11686124252) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11775520543) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12312781477) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.pytorch.callbacks.jit_transform\nnemo/lightning/pytorch/callbacks/jit_transform.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:33:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:39:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:67:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:90:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/callbacks/jit_transform.py:115:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.34/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"CI passed & only needed minimal conflict be solved\r\n\r\n"
] | 2024-11-01T10:23:08 | 2024-12-13T18:59:04 | 2024-12-13T18:59:03 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11131",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11131",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11131.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11131.patch",
"merged_at": "2024-12-13T18:59:03"
} | # What does this PR do ?
Changes:
1. Add JitTransform: callback to run torch.compile/thunder.jit on model
2. Add test for JitTransform callback
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11131/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11131/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11130 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11130/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11130/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11130/events | https://github.com/NVIDIA/NeMo/pull/11130 | 2,628,437,882 | PR_kwDOC_bI7s6AmiGO | 11,130 | Chery-pick 10918 & 11114 in r2.0.0 | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-01T06:40:20 | 2024-11-01T11:16:26 | 2024-11-01T11:16:25 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11130",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11130",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11130.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11130.patch",
"merged_at": "2024-11-01T11:16:25"
} | https://github.com/NVIDIA/NeMo/pull/10918
+ https://github.com/NVIDIA/NeMo/pull/11114
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11130/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11130/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11129 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11129/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11129/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11129/events | https://github.com/NVIDIA/NeMo/pull/11129 | 2,628,400,219 | PR_kwDOC_bI7s6AmZx_ | 11,129 | Cherry pick `GPT recipes to use full te spec (11119)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-01T06:07:37 | 2024-11-01T18:53:07 | 2024-11-01T18:53:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11129",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11129",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11129.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11129.patch",
"merged_at": "2024-11-01T18:53:06"
} | [π€]: Hi @JimmyZhang12 π,<br><br>we've cherry picked #11119 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11129/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11129/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11128 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11128/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11128/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11128/events | https://github.com/NVIDIA/NeMo/pull/11128 | 2,628,261,988 | PR_kwDOC_bI7s6Al_Pz | 11,128 | Virtual pipeline parallel support for LoRA in NLPAdapterModelMixin | {
"login": "vysarge",
"id": 10239441,
"node_id": "MDQ6VXNlcjEwMjM5NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/10239441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vysarge",
"html_url": "https://github.com/vysarge",
"followers_url": "https://api.github.com/users/vysarge/followers",
"following_url": "https://api.github.com/users/vysarge/following{/other_user}",
"gists_url": "https://api.github.com/users/vysarge/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vysarge/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vysarge/subscriptions",
"organizations_url": "https://api.github.com/users/vysarge/orgs",
"repos_url": "https://api.github.com/users/vysarge/repos",
"events_url": "https://api.github.com/users/vysarge/events{/privacy}",
"received_events_url": "https://api.github.com/users/vysarge/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-01T03:56:18 | 2024-11-01T17:05:04 | 2024-11-01T17:05:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11128",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11128",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11128.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11128.patch",
"merged_at": "2024-11-01T17:05:03"
} | # What does this PR do ?
Corrects handling of `model.virtual_pipeline_model_parallel_size` > 1 alongside `model.peft.peft_scheme=lora`; before this fix adapters are attached only to the first virtual pipeline chunk.
**Collection**: nlp
# Changelog
- Replace parameter-based check for first pipeline stage with `parallel_state.is_pipeline_first_stage()` to account for virtual pipeline stage
- Alter various methods (`_get_all_keys`, `_check_and_add_peft_cfg`, `setup_optimizer_param_groups`, `set_tunable_base_params`, `tie_weights`, `get_peft_state_dict`, `load_state_dict`) to apply LoRA changes to all layers rather than only those in the first chunk and to write and read checkpoints correctly when virtual pipeline parallel is used
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11128/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11128/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11127 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11127/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11127/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11127/events | https://github.com/NVIDIA/NeMo/pull/11127 | 2,628,197,089 | PR_kwDOC_bI7s6AlyTY | 11,127 | Recipe Fix for NeMo CI | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @suiyoubi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11623451238) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @suiyoubi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11655804861) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @suiyoubi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11668043330) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-11-01T02:54:27 | 2024-11-04T21:06:58 | 2024-11-04T21:06:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11127",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11127",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11127.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11127.patch",
"merged_at": "2024-11-04T21:06:57"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11127/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11127/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11126 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11126/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11126/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11126/events | https://github.com/NVIDIA/NeMo/pull/11126 | 2,628,055,596 | PR_kwDOC_bI7s6AlT52 | 11,126 | Bump `Dockerfile.ci` (2024-11-01) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-11-01T00:25:08 | 2024-11-04T09:21:37 | 2024-11-04T09:21:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11126",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11126",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11126.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11126.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11126/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11126/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11125 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11125/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11125/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11125/events | https://github.com/NVIDIA/NeMo/pull/11125 | 2,628,020,857 | PR_kwDOC_bI7s6AlNCO | 11,125 | Allow arguments passed to dataset class + Gemma recipe fix | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"thanks for the review!",
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11631826775) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"LGTM, thanks"
] | 2024-10-31T23:53:19 | 2024-11-01T17:53:01 | 2024-11-01T17:53:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11125",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11125",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11125.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11125.patch",
"merged_at": "2024-11-01T17:53:00"
} | # What does this PR do ?
Expose all arguments in GPTSFTDataset through a kwargs input to the datamodule.
Fix gemma recipe which requires add_bos=True.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11125/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11125/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11124 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11124/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11124/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11124/events | https://github.com/NVIDIA/NeMo/pull/11124 | 2,627,915,384 | PR_kwDOC_bI7s6Ak5b4 | 11,124 | vLLM Hugging Face exporter | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-31T22:07:55 | 2024-11-04T21:35:18 | 2024-11-04T21:35:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11124",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11124",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11124.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11124.patch",
"merged_at": "2024-11-04T21:35:18"
} | # What does this PR do ?
Adds an exporter for the HF models to vLLM and deploys it with PyTriton.
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11124/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11124/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11123 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11123/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11123/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11123/events | https://github.com/NVIDIA/NeMo/pull/11123 | 2,627,662,323 | PR_kwDOC_bI7s6AkG8b | 11,123 | Cherry pick `fix expert regex filter (11103)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-31T19:26:03 | 2024-11-01T06:42:49 | 2024-11-01T06:42:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11123",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11123",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11123.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11123.patch",
"merged_at": "2024-11-01T06:42:47"
} | [π€]: Hi @akoumpa π,<br><br>we've cherry picked #11103 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11123/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11123/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11122 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11122/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11122/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11122/events | https://github.com/NVIDIA/NeMo/pull/11122 | 2,627,642,817 | PR_kwDOC_bI7s6AkDVJ | 11,122 | Cherry pick `nemo1 to nemo2 checkpoint convert (10937)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-31T19:15:38 | 2024-11-01T16:23:57 | 2024-11-01T16:23:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11122",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11122",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11122.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11122.patch",
"merged_at": "2024-11-01T16:23:56"
} | [π€]: Hi @HuiyingLi π,<br><br>we've cherry picked #10937 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11122/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11122/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11121 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11121/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11121/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11121/events | https://github.com/NVIDIA/NeMo/pull/11121 | 2,627,634,316 | PR_kwDOC_bI7s6AkBfI | 11,121 | Fix packed seq path | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11618339897) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-31T19:10:00 | 2024-11-01T17:06:06 | 2024-11-01T17:06:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11121",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11121",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11121.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11121.patch",
"merged_at": "2024-11-01T17:06:04"
} | # What does this PR do ?
minor path fix
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11121/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11121/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11120 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11120/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11120/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11120/events | https://github.com/NVIDIA/NeMo/pull/11120 | 2,627,456,735 | PR_kwDOC_bI7s6AjcxJ | 11,120 | cherry-pick #10561 | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-31T17:41:18 | 2024-10-31T19:11:29 | 2024-10-31T19:11:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11120",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11120",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11120.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11120.patch",
"merged_at": "2024-10-31T19:11:28"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11120/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11120/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11119 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11119/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11119/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11119/events | https://github.com/NVIDIA/NeMo/pull/11119 | 2,627,361,830 | PR_kwDOC_bI7s6AjIy7 | 11,119 | GPT recipes to use full te spec | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"[π€]: Hi @JimmyZhang12 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11620616338) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-31T16:55:51 | 2024-11-01T06:07:14 | 2024-11-01T06:07:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11119",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11119",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11119.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11119.patch",
"merged_at": "2024-11-01T06:07:12"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11119/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11119/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11118 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11118/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11118/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11118/events | https://github.com/NVIDIA/NeMo/pull/11118 | 2,627,102,674 | PR_kwDOC_bI7s6AiSOa | 11,118 | Nemotron Recipe | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @suiyoubi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11633435287) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-31T15:08:06 | 2024-11-04T01:17:50 | 2024-11-04T01:17:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11118",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11118",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11118.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11118.patch",
"merged_at": "2024-11-04T01:17:49"
} | # What does this PR do ?
Rename Nemotron4-22b to Nemotron3-22b.
Added Finetune Recipes for all nemotron models.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11118/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11118/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11117 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11117/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11117/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11117/events | https://github.com/NVIDIA/NeMo/pull/11117 | 2,627,043,054 | PR_kwDOC_bI7s6AiGSJ | 11,117 | Add StragglerDetection and FTlauncher to NeMo2.0 | {
"login": "ShriyaPalsamudram",
"id": 69161273,
"node_id": "MDQ6VXNlcjY5MTYxMjcz",
"avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ShriyaPalsamudram",
"html_url": "https://github.com/ShriyaPalsamudram",
"followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers",
"following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}",
"gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions",
"organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs",
"repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos",
"events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}",
"received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ShriyaPalsamudram π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11635134648) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"@maanug-nv to introduce abstraction to reduce number of files changed to add a callback for all recipes.",
"[π€]: Hi @ShriyaPalsamudram π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11673519803) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"Are we able to verify in any way that straggler is working? i don't know if we can do anything besides searching the logs, but we should at least do that",
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop π€: π¨ The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.run.plugins\nnemo/lightning/run/plugins.py:81:0: C0301: Line too long (145/119) (line-too-long)\nnemo/lightning/run/plugins.py:92:0: C0301: Line too long (201/119) (line-too-long)\nnemo/lightning/run/plugins.py:102:0: C0301: Line too long (200/119) (line-too-long)\nnemo/lightning/run/plugins.py:104:0: C0301: Line too long (127/119) (line-too-long)\nnemo/lightning/run/plugins.py:188:0: C0301: Line too long (174/119) (line-too-long)\nnemo/lightning/run/plugins.py:264:0: C0301: Line too long (150/119) (line-too-long)\nnemo/lightning/run/plugins.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:166:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:211:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/run/plugins.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.16/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"Close PR as the tests are being added as part of https://github.com/NVIDIA/NeMo/pull/11406"
] | 2024-10-31T14:44:32 | 2024-12-02T08:58:43 | 2024-12-02T08:58:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11117",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11117",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11117.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11117.patch",
"merged_at": null
} | # What does this PR do ?
Add StragglerDetection and FTlauncher to NeMo2.0
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ShriyaPalsamudram",
"id": 69161273,
"node_id": "MDQ6VXNlcjY5MTYxMjcz",
"avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ShriyaPalsamudram",
"html_url": "https://github.com/ShriyaPalsamudram",
"followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers",
"following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}",
"gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions",
"organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs",
"repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos",
"events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}",
"received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11117/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11117/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11116 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11116/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11116/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11116/events | https://github.com/NVIDIA/NeMo/pull/11116 | 2,627,000,489 | PR_kwDOC_bI7s6Ah9kK | 11,116 | Remove stale checkpoint deletion on checkpoint saving failure | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11626246138) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-31T14:26:54 | 2024-11-01T11:49:22 | 2024-11-01T11:49:21 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11116",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11116",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11116.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11116.patch",
"merged_at": "2024-11-01T11:49:21"
} | # What does this PR do ?
If checkpoint saving fails, do not delete partial checkpoint files.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11116/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11116/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11115 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11115/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11115/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11115/events | https://github.com/NVIDIA/NeMo/pull/11115 | 2,626,946,733 | PR_kwDOC_bI7s6Ahx1E | 11,115 | Profiling - support Chakra & Kineto trace dumping | {
"login": "lilyw97",
"id": 169114869,
"node_id": "U_kgDOChR89Q",
"avatar_url": "https://avatars.githubusercontent.com/u/169114869?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lilyw97",
"html_url": "https://github.com/lilyw97",
"followers_url": "https://api.github.com/users/lilyw97/followers",
"following_url": "https://api.github.com/users/lilyw97/following{/other_user}",
"gists_url": "https://api.github.com/users/lilyw97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lilyw97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lilyw97/subscriptions",
"organizations_url": "https://api.github.com/users/lilyw97/orgs",
"repos_url": "https://api.github.com/users/lilyw97/repos",
"events_url": "https://api.github.com/users/lilyw97/events{/privacy}",
"received_events_url": "https://api.github.com/users/lilyw97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi @maanug-nv , I have fixed all the comments, can you help to review it again? I did `python setup.py style --fix` locally, and it returns successfully, but the reformat job seems failed, looks like it's a flow issue, I think it looks ready to be merged in.",
"Hi @maanug-nv , I updated the branch since it's out of date, seems only maintainers could edit the label? wondering if you could help to re-run the CICD? thanks",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.core.classes.modelPT\nnemo/core/classes/modelPT.py:82:0: C0301: Line too long (130/119) (line-too-long)\nnemo/core/classes/modelPT.py:177:0: C0301: Line too long (121/119) (line-too-long)\nnemo/core/classes/modelPT.py:184:0: C0301: Line too long (154/119) (line-too-long)\nnemo/core/classes/modelPT.py:258:0: C0301: Line too long (131/119) (line-too-long)\nnemo/core/classes/modelPT.py:262:0: C0301: Line too long (132/119) (line-too-long)\nnemo/core/classes/modelPT.py:310:0: C0301: Line too long (160/119) (line-too-long)\nnemo/core/classes/modelPT.py:390:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/classes/modelPT.py:1232:0: C0301: Line too long (123/119) (line-too-long)\nnemo/core/classes/modelPT.py:1469:0: C0301: Line too long (140/119) (line-too-long)\nnemo/core/classes/modelPT.py:1680:0: C0301: Line too long (128/119) (line-too-long)\nnemo/core/classes/modelPT.py:1699:0: C0301: Line too long (135/119) (line-too-long)\nnemo/core/classes/modelPT.py:1709:0: C0301: Line too long (122/119) (line-too-long)\nnemo/core/classes/modelPT.py:1835:0: C0301: Line too long (166/119) (line-too-long)\nnemo/core/classes/modelPT.py:1904:0: C0301: Line too long (120/119) (line-too-long)\nnemo/core/classes/modelPT.py:2058:0: C0301: Line too long (151/119) (line-too-long)\nnemo/core/classes/modelPT.py:223:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:869:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:926:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:930:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:937:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1205:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1629:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/core/classes/modelPT.py:1747:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.71/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-10-31T14:02:55 | 2024-11-19T20:20:03 | 2024-11-19T20:20:02 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11115",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11115",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11115.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11115.patch",
"merged_at": "2024-11-19T20:20:02"
} | # What does this PR do ?
**Add support of Chakra trace & Kineto trace dumping by `torch.profiler.profile`, take nsys profiling as PR reference**
**Collection**: [Note which collection this PR will affect] **All collections which is based on modelPT**
# Changelog
- Add specific line by line info of high level changes in this PR.
modePT.py:1747 Add setup chakra profiling
modePT.py:1917 Start chakra profiling at batch start callback
modePT.py:1917 End chakra profiling at batch end callback
# Usage
* You can potentially add a usage example below
NeMo-Framework-Launcher
```python
# Add a code snippet demonstrating how to use this
python3 ${NEMO_FRAMEWORK_LAUNCHER_DIR}/launcher_scripts/main.py \
training=gpt3/5b \
...
training.trainer.num_nodes=2 \
+training.model.optim.grad_sync_dtype=bf16 \
+training.model.chakra_profile.enabled=True \
+training.model.chakra_profile.start_step=0 \
+training.model.chakra_profile.end_step=10 \
+training.model.chakra_profile.warmup_steps=0 \
+training.model.chakra_profile.active_steps=1 \
+training.model.chakra_profile.trace_dir=${NEMO_FRAMEWORK_LAUNCHER_DIR}results/chakra/ \
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11115/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11115/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11114 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11114/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11114/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11114/events | https://github.com/NVIDIA/NeMo/pull/11114 | 2,626,625,018 | PR_kwDOC_bI7s6AgvBq | 11,114 | TP+MoE peft fix | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11611168398) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"CI passed https://github.com/NVIDIA/NeMo/actions/runs/11611168398"
] | 2024-10-31T11:30:22 | 2024-10-31T18:41:47 | 2024-10-31T18:41:44 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11114",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11114",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11114.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11114.patch",
"merged_at": "2024-10-31T18:41:44"
} | # What does this PR do ?
Model= MoE-based
ParallelismConfig= TP> 1 and SP=True
During token routing it is possible that experts might be routed a sequence with length non-dividable by TP, as a result when applying the adapter's output on the linear's output there's shape mismatch. This PR adds appropriate padding to the sequence of expert linear layers to avoid this issue. Please do note that routed tokens are not sequence parallel.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11114/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11114/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11113 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11113/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11113/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11113/events | https://github.com/NVIDIA/NeMo/pull/11113 | 2,626,607,098 | PR_kwDOC_bI7s6Agrx8 | 11,113 | Add support converting Llama-3.2 LLMs hf to nemo | {
"login": "AtsunoriFujita",
"id": 40932835,
"node_id": "MDQ6VXNlcjQwOTMyODM1",
"avatar_url": "https://avatars.githubusercontent.com/u/40932835?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/AtsunoriFujita",
"html_url": "https://github.com/AtsunoriFujita",
"followers_url": "https://api.github.com/users/AtsunoriFujita/followers",
"following_url": "https://api.github.com/users/AtsunoriFujita/following{/other_user}",
"gists_url": "https://api.github.com/users/AtsunoriFujita/gists{/gist_id}",
"starred_url": "https://api.github.com/users/AtsunoriFujita/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AtsunoriFujita/subscriptions",
"organizations_url": "https://api.github.com/users/AtsunoriFujita/orgs",
"repos_url": "https://api.github.com/users/AtsunoriFujita/repos",
"events_url": "https://api.github.com/users/AtsunoriFujita/events{/privacy}",
"received_events_url": "https://api.github.com/users/AtsunoriFujita/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"Thank you, could you set \"Run CICD\" tag?",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-31T11:21:02 | 2024-11-30T02:01:16 | 2024-11-30T02:01:15 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11113",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11113",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11113.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11113.patch",
"merged_at": null
} | # What does this PR do ?
Add support converting Llama-3.2 LLMs (1B and 3B) hf to nemo.
**Collection**: [Note which collection this PR will affect]
# Changelog
- You can specify either `--llama31` or `--llama32` as arguments or select nothing (llama3).
- For Llama-3.2, set the config to `model.cfg.share_embeddings_and_output_weights=True`
- The tokenizer is updated for each model.
# Usage
* You can potentially add a usage example below
```bash
#!/bin/sh
export INPUT="/workspace/Llama-3.2-1B"
export OUTPUT="/workspace/Llama-3.2-1B.nemo"
export PREC="bf16"
# Llama-3.2
python /opt/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --input_name_or_path=${INPUT} --output_path=${OUTPUT} --precision=${PREC} --llama32
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11113/reactions",
"total_count": 2,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 2,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11113/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11112 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11112/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11112/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11112/events | https://github.com/NVIDIA/NeMo/pull/11112 | 2,625,879,941 | PR_kwDOC_bI7s6AebnD | 11,112 | Cherry pick `disable overlap_param_gather_with_optimizer_step (11102)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-31T03:14:40 | 2024-10-31T19:06:53 | 2024-10-31T19:06:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11112",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11112",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11112.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11112.patch",
"merged_at": "2024-10-31T19:06:51"
} | [π€]: Hi @JimmyZhang12 π,<br><br>we've cherry picked #11102 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11112/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11112/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11111 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11111/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11111/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11111/events | https://github.com/NVIDIA/NeMo/pull/11111 | 2,625,852,481 | PR_kwDOC_bI7s6AeWbM | 11,111 | Cherry pick `Fix yaml serialization in io mixin (11106)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-31T02:47:05 | 2024-10-31T05:39:45 | 2024-10-31T05:39:44 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11111",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11111",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11111.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11111.patch",
"merged_at": "2024-10-31T05:39:44"
} | [π€]: Hi @hemildesai π,<br><br>we've cherry picked #11106 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11111/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11111/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11110 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11110/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11110/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11110/events | https://github.com/NVIDIA/NeMo/pull/11110 | 2,625,649,346 | PR_kwDOC_bI7s6Adpwn | 11,110 | Bump `Dockerfile.ci` (2024-10-31) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-31T00:22:46 | 2024-11-04T09:21:34 | 2024-11-04T09:21:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11110",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11110",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11110.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11110.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11110/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11110/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11109 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11109/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11109/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11109/events | https://github.com/NVIDIA/NeMo/pull/11109 | 2,625,621,322 | PR_kwDOC_bI7s6Adj8F | 11,109 | Fix MCoreGPTModel import in llm.gpt.model.base | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @hemildesai π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11605826871) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T23:55:55 | 2024-10-31T15:43:55 | 2024-10-31T15:43:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11109",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11109",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11109.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11109.patch",
"merged_at": "2024-10-31T15:43:53"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11109/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11109/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11108 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11108/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11108/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11108/events | https://github.com/NVIDIA/NeMo/pull/11108 | 2,625,606,168 | PR_kwDOC_bI7s6AdhiA | 11,108 | Add scripts for importing a ckpt and running a forward step on it for nemo.collections.llm | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"[π€]: Hi @hemildesai π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12638816755) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-10-30T23:43:10 | 2025-01-06T21:17:07 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11108",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11108",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11108.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11108.patch",
"merged_at": null
} | Jupyter notebook with pure python is not possible as of now because of
```
MegatronStrategy object at 0x70030c368ac0>)` is not compatible with an interactive environment
``` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11108/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11108/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11107 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11107/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11107/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11107/events | https://github.com/NVIDIA/NeMo/pull/11107 | 2,625,428,021 | PR_kwDOC_bI7s6Ac9hO | 11,107 | Alit/hyena ux dist ckpt | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-10-30T21:52:25 | 2024-10-30T21:53:36 | 2024-10-30T21:53:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11107",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11107",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11107.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11107.patch",
"merged_at": "2024-10-30T21:53:35"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11107/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11107/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11106 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11106/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11106/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11106/events | https://github.com/NVIDIA/NeMo/pull/11106 | 2,625,399,804 | PR_kwDOC_bI7s6Ac4Xx | 11,106 | Fix yaml serialization in io mixin | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"> Add docstring\r\n\r\nUpdated in https://github.com/NVIDIA/NeMo/pull/11106/commits/bd903a0c86b8ba847903f9ba8e1aad37f1f5ea6a",
"[π€]: Hi @hemildesai π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11602055172) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"CI passed : https://github.com/NVIDIA/NeMo/actions/runs/11602055172",
"There was a further commit after the triggered CI run but it was a docstring name + name change which shouldnt affect result:\r\nhttps://github.com/NVIDIA/NeMo/pull/11106/commits/bd903a0c86b8ba847903f9ba8e1aad37f1f5ea6a\r\n"
] | 2024-10-30T21:36:50 | 2024-10-31T02:46:38 | 2024-10-31T02:46:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11106",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11106",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11106.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11106.patch",
"merged_at": "2024-10-31T02:46:36"
} | Uses __class__ only when data.__qualname__ or similar fails | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11106/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11106/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11105 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11105/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11105/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11105/events | https://github.com/NVIDIA/NeMo/issues/11105 | 2,625,387,478 | I_kwDOC_bI7s6cfDvW | 11,105 | Slurm interactive mode, transcribe_speech_parallel.py gets stuck on consecutive runs | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-30T21:30:06 | 2024-12-07T02:03:55 | 2024-12-07T02:03:54 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | With container `nvcr.io/nvidia/nemo:24.07` (Pyxis/Enroot), ran in Slurm interactive mode with 1 GPU if I execute the command
```bash
python3 /opt/NeMo/examples/asr/transcribe_speech_parallel.py \
...
```
the script will get stuck on the second of multiple consecutive runs. The point where it does so is
```bash
> HERE
Using bfloat16 Automatic Mixed Precision (AMP)
GPU available: True (cuda), used: True
...
```
However if I execute the command
```bash
torchrun --standalone --nnodes=1 --nproc-per-node=1 /opt/NeMo/examples/asr/transcribe_speech_parallel.py \
...
```
I can run multiple consecutive times without any issues.
I have tried with standard debug parameters like
```
TORCH_CPP_LOG_LEVEL=INFO
TORCH_DISTRIBUTED_DEBUG=INFO
NCCL_DEBUG=INFO
NCCL_DEBUG_SUBSYS=ALL
```
but nothing peculiar pops out. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11105/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11105/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11104 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11104/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11104/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11104/events | https://github.com/NVIDIA/NeMo/pull/11104 | 2,625,342,923 | PR_kwDOC_bI7s6ActRq | 11,104 | DoRA | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11901641854) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"DoRA in recipes and CLI will follow in a separate PR",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.peft.lora\nnemo/collections/llm/peft/lora.py:50:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/peft/lora.py:56:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/peft/lora.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/peft/lora.py:99:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.91/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11917970302) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T21:06:04 | 2024-11-19T19:32:24 | 2024-11-19T19:32:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11104",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11104",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11104.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11104.patch",
"merged_at": "2024-11-19T19:32:22"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11104/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11104/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11103 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11103/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11103/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11103/events | https://github.com/NVIDIA/NeMo/pull/11103 | 2,625,188,794 | PR_kwDOC_bI7s6AcOY6 | 11,103 | fix expert regex filter | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11607489724) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11615823819) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T19:50:04 | 2024-10-31T19:25:37 | 2024-10-31T19:25:36 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11103",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11103",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11103.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11103.patch",
"merged_at": "2024-10-31T19:25:36"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11103/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11103/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11102 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11102/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11102/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11102/events | https://github.com/NVIDIA/NeMo/pull/11102 | 2,624,995,563 | PR_kwDOC_bI7s6AbmBv | 11,102 | disable overlap_param_gather_with_optimizer_step | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"[π€]: Hi @JimmyZhang12 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11602320077) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T18:36:34 | 2024-10-31T03:14:16 | 2024-10-31T03:14:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11102",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11102",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11102.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11102.patch",
"merged_at": "2024-10-31T03:14:15"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11102/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11102/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11101 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11101/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11101/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11101/events | https://github.com/NVIDIA/NeMo/pull/11101 | 2,624,966,525 | PR_kwDOC_bI7s6AbfYU | 11,101 | Cherry pick `Fix TRTLLM nemo2 activation parsing (11062)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-30T18:26:30 | 2024-10-31T00:46:38 | 2024-10-31T00:46:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11101",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11101",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11101.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11101.patch",
"merged_at": "2024-10-31T00:46:37"
} | [π€]: Hi @meatybobby π,<br><br>we've cherry picked #11062 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11101/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11101/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11100 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11100/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11100/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11100/events | https://github.com/NVIDIA/NeMo/pull/11100 | 2,624,220,664 | PR_kwDOC_bI7s6AZDMz | 11,100 | Add Packed Seq option to GPT based models | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @suiyoubi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11601541361) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T14:03:55 | 2024-10-31T15:20:34 | 2024-10-31T15:20:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11100",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11100",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11100.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11100.patch",
"merged_at": "2024-10-31T15:20:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11100/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11100/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11099 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11099/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11099/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11099/events | https://github.com/NVIDIA/NeMo/pull/11099 | 2,624,040,390 | PR_kwDOC_bI7s6AYeXy | 11,099 | Cherry pick 10613 and 11081 in r2.0.0 | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-30T13:04:56 | 2024-10-30T16:48:56 | 2024-10-30T16:48:56 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11099",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11099",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11099.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11099.patch",
"merged_at": "2024-10-30T16:48:56"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11099/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11099/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11098 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11098/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11098/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11098/events | https://github.com/NVIDIA/NeMo/pull/11098 | 2,624,006,769 | PR_kwDOC_bI7s6AYXAv | 11,098 | [Bugfix] fix qwen tokenizer config when converting to nemo format | {
"login": "chrjxj",
"id": 6042129,
"node_id": "MDQ6VXNlcjYwNDIxMjk=",
"avatar_url": "https://avatars.githubusercontent.com/u/6042129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chrjxj",
"html_url": "https://github.com/chrjxj",
"followers_url": "https://api.github.com/users/chrjxj/followers",
"following_url": "https://api.github.com/users/chrjxj/following{/other_user}",
"gists_url": "https://api.github.com/users/chrjxj/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chrjxj/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chrjxj/subscriptions",
"organizations_url": "https://api.github.com/users/chrjxj/orgs",
"repos_url": "https://api.github.com/users/chrjxj/repos",
"events_url": "https://api.github.com/users/chrjxj/events{/privacy}",
"received_events_url": "https://api.github.com/users/chrjxj/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@cuichenx can you review this PR please?",
"Thanks for your bugfix. I tested your code and found that I can not get the right response when do inference using the generated `.nemo` file. Is the `.nemo` file right? Could you please have a look? Thanks. @chrjxj @cuichenx \r\n\r\n# 1. HF -> nemo\r\nConvert [Qwen2.5-7B](https://huggingface.co/Qwen/Qwen2.5-7B/tree/main) to `Qwen2.5-7B.nemo`. After tar xvf, the `Qwen2.5-7B.nemo` is as following:\r\n```shell\r\nroot@inp16075348439349544319-3-1:/mnt/tenant-home_speed/nemo_models# tar xvf Qwen2.5-7B.nemo \r\n./\r\n./model_config.yaml\r\n./model_weights/\r\n./model_weights/.metadata\r\n./model_weights/__0_0.distcp\r\n./model_weights/__0_1.distcp\r\n./model_weights/common.pt\r\n./model_weights/metadata.json\r\n```\r\n\r\n# 2. Inference using `Qwen2.5-7B.nemo`\r\nThen I tried to do inference using `Qwen2.5-7B.nemo`.\r\n```\r\npython3 megatron_gpt_eval.py \\\r\n gpt_model_file=Qwen2.5-7B.nemo \\\r\n inference.greedy=True \\\r\n inference.add_BOS=True \\\r\n trainer.devices=1 \\\r\n trainer.num_nodes=1 \\\r\n tensor_model_parallel_size=1 \\\r\n pipeline_model_parallel_size=1 \\\r\n prompts='[\"who are you?\", \"What is the captial of China?\"]'\r\n```\r\n\r\nThe response seems wrong. Part of the output:\r\n```shell\r\n[NeMo I 2024-12-04 21:57:07 nlp_overrides:1386] Model MegatronGPTModel was successfully restored from Qwen2.5-7B.nemo.\r\nprompt=========:['who are you?', 'What is the captial of China?']\r\nsetting number of microbatches to constant 1\r\n***************************\r\n{'sentences': ['who are you?1000000000000000000000000000000000', 'What is the captial of China?100000000000000000000000000000'], 'tokens': [['<|im_start|>', 'who', 'Δ are', 'Δ you', '?', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0'], ['<|im_start|>', 'What', 'Δ is', 'Δ the', 'Δ capt', 'ial', 'Δ of', 'Δ China', '?', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0']], 'logprob': None, 'full_logprob': None, 'token_ids': [[151644, 14623, 525, 498, 30, 16, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15], [151644, 3838, 374, 279, 6427, 530, 315, 5616, 30, 16, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15]], 'offsets': [[0, 0, 3, 7, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45], [0, 0, 4, 7, 11, 16, 19, 22, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58]]}\r\n***************************\r\n[NeMo I 2024-12-04 21:57:14 megatron_gpt_model:1717] Pipeline model parallel rank: 0, Tensor model parallel rank: 0, Number of model parameters on device: 7.62e+09. Number of precise model parameters on device: 7615616512.\r\nLOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1,2,3,4,5,6,7]\r\n \r\nPredicting DataLoader 0: 0%| | 0/1 [00:00<?, ?it/s]setting number of microbatches to constant 1\r\nPredicting DataLoader 0: 100%|ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ| 1/1 [00:01<00:00, 0.51it/s]\r\n***************************\r\n[{'sentences': ['who are you?1000000000000000000000000000000000', 'What is the captial of China?100000000000000000000000000000'], 'tokens': [['<|im_start|>', 'who', 'Δ are', 'Δ you', '?', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0'], ['<|im_start|>', 'What', 'Δ is', 'Δ the', 'Δ capt', 'ial', 'Δ of', 'Δ China', '?', '1', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0']], 'logprob': None, 'full_logprob': None, 'token_ids': [[151644, 14623, 525, 498, 30, 16, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15], [151644, 3838, 374, 279, 6427, 530, 315, 5616, 30, 16, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15]], 'offsets': [[0, 0, 3, 7, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45], [0, 0, 4, 7, 11, 16, 19, 22, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58]]}]\r\n***************************\r\n```",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"So what is preventing this to be merged? @cuichenx @chrjxj ",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-10-30T12:51:40 | 2025-01-09T22:32:48 | 2025-01-09T22:32:48 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11098",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11098",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11098.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11098.patch",
"merged_at": "2025-01-09T22:32:48"
} | # What does this PR do ?
This PR fixes qwen tokenizer config when converting qwen2 from HF to nemo format;
Background: when running Qwen SFT, _build_tokenizer() will return Qwen2Tokenizer or Qwen2TokenizerFast based on cfg.tokenizer .
without this update, _build_tokenizer will use `use_fast` default value ( `False`) and create an Qwen2Tokenizer instance (wrapped by NeMo/nemo/collections/common/tokenizers/huggingface/auto_tokenizer.py). Qwen2Tokenizer instance don't have vocab attributes, which results in errors during SFT data loading.
Above changes is tested within `nvcr.io/nvidia/nemo:24.07`; passed.
**Collection**: LLM, Qwen2
# Changelog
- line 86 to 92, in NeMo/scripts/checkpoint_converters/convert_qwen2_hf_to_nemo.py
# Usage
* won't affect usage
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11098/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11098/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11097 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11097/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11097/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11097/events | https://github.com/NVIDIA/NeMo/pull/11097 | 2,623,956,636 | PR_kwDOC_bI7s6AYM9m | 11,097 | Fix datasets in CLI | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @marcromeyn π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11596710413) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T12:33:15 | 2024-10-30T20:26:48 | 2024-10-30T20:26:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11097",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11097",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11097.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11097.patch",
"merged_at": "2024-10-30T20:26:47"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11097/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11097/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11096 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11096/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11096/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11096/events | https://github.com/NVIDIA/NeMo/pull/11096 | 2,623,733,619 | PR_kwDOC_bI7s6AXe8N | 11,096 | NeMo-UX: HF PeFT fix | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11627743857) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11640568206) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T11:11:05 | 2024-11-04T15:50:11 | 2024-11-04T15:50:08 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11096",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11096",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11096.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11096.patch",
"merged_at": "2024-11-04T15:50:08"
} | # What does this PR do ?
How to run:
Invoke:
```
nemo llm finetune --factory 'hf_auto_model_for_causal_lm(model_name="microsoft/Phi-3-mini-128k-instruct", num_gpus_per_node=1)' data=squad data.sanity_check_dist_workers=False
```
requires https://github.com/NVIDIA/NeMo/pull/11097
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11096/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11096/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11095 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11095/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11095/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11095/events | https://github.com/NVIDIA/NeMo/pull/11095 | 2,623,416,892 | PR_kwDOC_bI7s6AWd2V | 11,095 | Update PTQ tests and ModelOpt version | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @janekl π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11590439104) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @janekl π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11595829411) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T09:32:13 | 2024-10-30T18:08:37 | 2024-10-30T18:08:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11095",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11095",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11095.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11095.patch",
"merged_at": "2024-10-30T18:08:36"
} | # What does this PR do ?
1. Deprecating Nemo 1 PTQ tests except FP8
2. Updating Nemo 1 FP8 PTQ test to use an up-to-date converted Llama 2 model
3. Bumping modelopt to 0.19.0
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to https://github.com/NVIDIA/NeMo/pull/10922
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11095/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11095/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11094 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11094/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11094/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11094/events | https://github.com/NVIDIA/NeMo/pull/11094 | 2,623,130,565 | PR_kwDOC_bI7s6AVjx4 | 11,094 | NeMo-UX: Mistral/mixtral peft ci test | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11627538913) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T07:18:16 | 2024-11-01T12:36:23 | 2024-11-01T12:36:21 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11094",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11094",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11094.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11094.patch",
"merged_at": "2024-11-01T12:36:21"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11094/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11094/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11093 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11093/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11093/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11093/events | https://github.com/NVIDIA/NeMo/pull/11093 | 2,622,660,931 | PR_kwDOC_bI7s6AUD3D | 11,093 | Akoumparouli/destructor singleton in megatronstrategy dtor | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-30T01:49:42 | 2024-11-21T02:01:26 | 2024-11-21T02:01:25 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11093",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11093",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11093.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11093.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11093/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11093/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11092 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11092/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11092/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11092/events | https://github.com/NVIDIA/NeMo/pull/11092 | 2,622,577,204 | PR_kwDOC_bI7s6ATyHT | 11,092 | Bump `Dockerfile.ci` (2024-10-30) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11584633004) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-30T00:22:41 | 2024-10-30T10:06:16 | 2024-10-30T10:06:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11092",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11092",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11092.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11092.patch",
"merged_at": "2024-10-30T10:06:14"
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11092/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11092/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11091 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11091/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11091/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11091/events | https://github.com/NVIDIA/NeMo/pull/11091 | 2,622,475,650 | PR_kwDOC_bI7s6ATe6p | 11,091 | Update pruning and distillation tutorial notebooks | {
"login": "gvenkatakris",
"id": 182821545,
"node_id": "U_kgDOCuWiqQ",
"avatar_url": "https://avatars.githubusercontent.com/u/182821545?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gvenkatakris",
"html_url": "https://github.com/gvenkatakris",
"followers_url": "https://api.github.com/users/gvenkatakris/followers",
"following_url": "https://api.github.com/users/gvenkatakris/following{/other_user}",
"gists_url": "https://api.github.com/users/gvenkatakris/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gvenkatakris/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gvenkatakris/subscriptions",
"organizations_url": "https://api.github.com/users/gvenkatakris/orgs",
"repos_url": "https://api.github.com/users/gvenkatakris/repos",
"events_url": "https://api.github.com/users/gvenkatakris/events{/privacy}",
"received_events_url": "https://api.github.com/users/gvenkatakris/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T22:52:42 | 2024-11-21T00:09:30 | 2024-11-13T07:15:13 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11091",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11091",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11091.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11091.patch",
"merged_at": "2024-11-13T07:15:13"
} | # What does this PR do ?
Updating pruning and distillation notebooks
width-pruning notebook added
| {
"login": "kevalmorabia97",
"id": 28916987,
"node_id": "MDQ6VXNlcjI4OTE2OTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/28916987?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevalmorabia97",
"html_url": "https://github.com/kevalmorabia97",
"followers_url": "https://api.github.com/users/kevalmorabia97/followers",
"following_url": "https://api.github.com/users/kevalmorabia97/following{/other_user}",
"gists_url": "https://api.github.com/users/kevalmorabia97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevalmorabia97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevalmorabia97/subscriptions",
"organizations_url": "https://api.github.com/users/kevalmorabia97/orgs",
"repos_url": "https://api.github.com/users/kevalmorabia97/repos",
"events_url": "https://api.github.com/users/kevalmorabia97/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevalmorabia97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11091/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11091/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.